Page MenuHomePhabricator

vsk (Vedant Kumar)
User

Projects

User Details

User Since
Jul 8 2015, 10:26 AM (236 w, 2 d)

Recent Activity

Yesterday

vsk added inline comments to D72938: Fix an assertion failure in DwarfExpression's subregister composition.
Fri, Jan 17, 2:24 PM · Restricted Project, debug-info
vsk committed rG510758dae2a8: debugserver: Pass -arch flags to mig invocation as needed (authored by vsk).
debugserver: Pass -arch flags to mig invocation as needed
Fri, Jan 17, 1:17 PM

Thu, Jan 16

vsk added a comment to D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

@TWeaver this is still causing a failure on some Darwin bots:

Thu, Jan 16, 5:10 PM · Restricted Project, debug-info
vsk added inline comments to D72880: Fix a buffer-size bug when the first DW_OP_piece is undefined.
Thu, Jan 16, 4:03 PM · Restricted Project
vsk accepted D72880: Fix a buffer-size bug when the first DW_OP_piece is undefined.

LGTM, this seems like a clear improvement.

Thu, Jan 16, 4:02 PM · Restricted Project
vsk accepted D72879: Add testing for DW_OP_piece and fix a bug with small Scalar values..

LGTM. In the future it'd be nice to maybe split out piece/bit_piece handling into their own self-contained functions, and maybe share more code between them. But landing this narrow fix now sounds good.

Thu, Jan 16, 3:53 PM · Restricted Project
vsk added inline comments to D72877: [FastISel] Lower `llvm.dbg.value(undef, ...` correctly..
Thu, Jan 16, 3:24 PM · debug-info, Restricted Project
vsk committed rG6c4d37733403: lldb: xfail TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on… (authored by vsk).
lldb: xfail TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on…
Thu, Jan 16, 2:54 PM
vsk added a reverting change for rG8d2f252bb8e4: lldb: Run TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on Darwin…: rG6c4d37733403: lldb: xfail TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on….
Thu, Jan 16, 2:54 PM

Wed, Jan 15

vsk committed rG1e89fb947ed1: debugserver: Cut dependency on intrinsics_gen (authored by vsk).
debugserver: Cut dependency on intrinsics_gen
Wed, Jan 15, 5:20 PM
vsk added inline comments to D71491: [ubsan] Check implicit casts in ObjC for-in statements.
Wed, Jan 15, 4:42 PM · Restricted Project
vsk updated the diff for D71491: [ubsan] Check implicit casts in ObjC for-in statements.
Wed, Jan 15, 4:41 PM · Restricted Project
vsk committed rG360abb7ee56f: [CodeExtractor] Transfer debug info to extracted function (authored by vsk).
[CodeExtractor] Transfer debug info to extracted function
Wed, Jan 15, 3:39 PM
vsk closed D72801: [CodeExtractor] Transfer debug info to extracted function.
Wed, Jan 15, 3:39 PM · Restricted Project
vsk updated the diff for D72801: [CodeExtractor] Transfer debug info to extracted function.

Address review feedback.

Wed, Jan 15, 3:02 PM · Restricted Project
vsk added inline comments to D72801: [CodeExtractor] Transfer debug info to extracted function.
Wed, Jan 15, 3:02 PM · Restricted Project
vsk closed D72795: DebugInfo: Factor out logic to update locations in MD_loop metadata, NFC.

This was committed in a2cc80bc95703b99afefddb1d9d545c639ac4ff5.

Wed, Jan 15, 2:52 PM · Restricted Project
vsk committed rG5aeb6798f268: [test] Move call-site-entry-linking.test into test/tools/dsymutil/X86 (authored by vsk).
[test] Move call-site-entry-linking.test into test/tools/dsymutil/X86
Wed, Jan 15, 2:25 PM
vsk committed rG43464509fced: DWARF: Simplify the way the return PC is attached to call site tags, NFC (authored by vsk).
DWARF: Simplify the way the return PC is attached to call site tags, NFC
Wed, Jan 15, 2:25 PM
vsk committed rG8d2f252bb8e4: lldb: Run TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on Darwin… (authored by vsk).
lldb: Run TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on Darwin…
Wed, Jan 15, 2:06 PM
vsk committed rGf0120556c7e2: [DWARF] Emit DW_AT_call_return_pc as an address (authored by vsk).
[DWARF] Emit DW_AT_call_return_pc as an address
Wed, Jan 15, 1:19 PM
vsk committed rGa2cc80bc9570: DebugInfo: Factor out logic to update locations in MD_loop metadata, NFC (authored by vsk).
DebugInfo: Factor out logic to update locations in MD_loop metadata, NFC
Wed, Jan 15, 1:19 PM
vsk added a reverting change for D53469: [DWARF] Use a function-local offset for AT_call_return_pc: rGf0120556c7e2: [DWARF] Emit DW_AT_call_return_pc as an address.
Wed, Jan 15, 1:19 PM · Restricted Project
vsk closed D72489: [DWARF] Emit DW_AT_call_return_pc as an address.
Wed, Jan 15, 1:19 PM · Restricted Project, Restricted Project
vsk added inline comments to D72489: [DWARF] Emit DW_AT_call_return_pc as an address.
Wed, Jan 15, 1:00 PM · Restricted Project, Restricted Project
vsk created D72801: [CodeExtractor] Transfer debug info to extracted function.
Wed, Jan 15, 12:51 PM · Restricted Project
vsk created D72795: DebugInfo: Factor out logic to update locations in MD_loop metadata, NFC.
Wed, Jan 15, 11:37 AM · Restricted Project

Tue, Jan 14

vsk added a comment to D72720: [libcxx] Allow manually specifying locales for use in tests via CMake.

Looks good to me. Please wait for another +1, as I'm not a regular libcxx contributor.

Tue, Jan 14, 10:23 AM · Restricted Project

Mon, Jan 13

vsk closed D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes).

Yes, this landed in 568db780bb7267651a902da8e85bc59fc89aea70.

Mon, Jan 13, 10:25 AM · Restricted Project
vsk accepted D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .

LGTM as well.

Mon, Jan 13, 9:38 AM · Restricted Project, debug-info

Fri, Jan 10

vsk committed rGe05e219926f9: [LockFileManager] Make default waitForUnlock timeout a parameter, NFC (authored by vsk).
[LockFileManager] Make default waitForUnlock timeout a parameter, NFC
Fri, Jan 10, 3:30 PM
vsk committed rG4c00dbf22d7f: lldbutil: Forward ASan launch info to test inferiors (authored by vsk).
lldbutil: Forward ASan launch info to test inferiors
Fri, Jan 10, 2:53 PM
vsk closed D71379: lldbutil: Forward ASan launch info to test inferiors.
Fri, Jan 10, 2:53 PM · Restricted Project
vsk committed rGa9052b4dfc1b: [AArch64] Add isAuthenticated predicate to MCInstDesc (authored by vsk).
[AArch64] Add isAuthenticated predicate to MCInstDesc
Fri, Jan 10, 2:34 PM
vsk closed D70329: [AArch64] Add isAuthenticating predicate to MCInstDesc.
Fri, Jan 10, 2:34 PM · Restricted Project
vsk updated subscribers of D72489: [DWARF] Emit DW_AT_call_return_pc as an address.
Fri, Jan 10, 1:01 PM · Restricted Project, Restricted Project
vsk updated the diff for D72489: [DWARF] Emit DW_AT_call_return_pc as an address.
Fri, Jan 10, 12:52 PM · Restricted Project, Restricted Project
vsk added a comment to D72489: [DWARF] Emit DW_AT_call_return_pc as an address.

Thanks for looking into this!

Could you measure the size of the object files of, for example, the clang binary before/after this change - and, if possible, on Linux (where relocations are required to fixup these addresses)? I'm concerned this might increase the size significantly.

Fri, Jan 10, 12:52 PM · Restricted Project, Restricted Project
vsk added inline comments to D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours .
Fri, Jan 10, 10:22 AM · Restricted Project, debug-info
vsk added a reviewer for D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours : jmorse.

This is great, thanks for doing this.

Fri, Jan 10, 9:53 AM · Restricted Project, debug-info
vsk added a comment to D72510: [lldb/Expression] Improve interpreter error message with a non-running target.

Nice. So, does !support_function_calls always imply that the target isn’t running?

Fri, Jan 10, 8:11 AM · Restricted Project

Thu, Jan 9

vsk added a comment to D53469: [DWARF] Use a function-local offset for AT_call_return_pc.

Really sorry it's taken a while to get to this, work had really piled up over the holidays. As a first step, I've put up D72489 to make llvm's DW_AT_call_return_pc standards-compliant without regressing lldb functionality. I'm not sure how to avoid paying for a relocation without things breaking in Propeller-ed binaries, as I haven't really had the time to think about deeply. Definitely open to suggestions.

Thu, Jan 9, 6:25 PM · Restricted Project
vsk added a reverting change for D53469: [DWARF] Use a function-local offset for AT_call_return_pc: D72489: [DWARF] Emit DW_AT_call_return_pc as an address.
Thu, Jan 9, 6:16 PM · Restricted Project
vsk created D72489: [DWARF] Emit DW_AT_call_return_pc as an address.
Thu, Jan 9, 6:16 PM · Restricted Project, Restricted Project
vsk committed rG4f1442301ce7: Merge commit 'refs/am/changes/2492b5a12550f7c4bb428c3761392f2ce47fa269_apple/ma… (authored by vsk).
Merge commit 'refs/am/changes/2492b5a12550f7c4bb428c3761392f2ce47fa269_apple/ma…
Thu, Jan 9, 4:01 PM

Tue, Jan 7

vsk added a comment to D70350: [DWARF] Allow cross-CU references of subprogram definitions.

Hey @modocache, thanks for the report and stack trace. It looks like clang crashes because it found a DISubprogram without an associated DIE. I'm not sure how this could happen: the function constructCallSiteEntryDIEs should ensure that the associated DIE exists. Are you aware of any other internal debug info-related changes which might break this assumption?

Tue, Jan 7, 2:06 PM · Restricted Project
vsk accepted D71869: [llvm-locstats] Add the --draw-plot option.

Thanks, LGTM as well.

Tue, Jan 7, 9:18 AM · Restricted Project, debug-info

Mon, Jan 6

vsk updated the diff for D70329: [AArch64] Add isAuthenticating predicate to MCInstDesc.

Cover pre-8.3 auti*sp instructions.

Mon, Jan 6, 1:11 PM · Restricted Project
vsk abandoned D72286: installation: Accept separate install prefix for LLDB.framework.

This is still not right. build-script does not include the arch-specific destdir in the install prefix to begin with.

Mon, Jan 6, 11:45 AM
vsk added a comment to D71970: [profile] Support merge pool size >= 10.

What kind of performance improvement were you able to measure for your workload with n >= 10? What was the impact on profile size?

Mon, Jan 6, 11:03 AM · Restricted Project, Restricted Project
vsk updated the diff for D72286: installation: Accept separate install prefix for LLDB.framework.

It looks like a framework-specific install prefix is required, as the install prefix for the framework is not always the same as the install prefix for the rest of the project.

Mon, Jan 6, 10:06 AM
vsk planned changes to D72286: installation: Accept separate install prefix for LLDB.framework.

Hm, the new framework install prefix seems redundant with CMAKE_INSTALL_PREFIX. Let me see if they can be shared.

Mon, Jan 6, 9:57 AM
vsk created D72286: installation: Accept separate install prefix for LLDB.framework.
Mon, Jan 6, 9:47 AM
vsk added a comment to D71379: lldbutil: Forward ASan launch info to test inferiors.

Ping.

Mon, Jan 6, 9:47 AM · Restricted Project
vsk added a comment to D70329: [AArch64] Add isAuthenticating predicate to MCInstDesc.

Ping.

Mon, Jan 6, 9:47 AM · Restricted Project

Fri, Dec 20

vsk committed rGfa4701e19795: [DWARF] Defer creating declaration DIEs until we prepare call site info (authored by vsk).
[DWARF] Defer creating declaration DIEs until we prepare call site info
Fri, Dec 20, 3:28 PM
vsk committed rG79daafc90308: Reland: [DWARF] Allow cross-CU references of subprogram definitions (authored by vsk).
Reland: [DWARF] Allow cross-CU references of subprogram definitions
Fri, Dec 20, 3:28 PM

Thu, Dec 19

vsk committed rGcaaacb839950: HotColdSplitting: Do not outline within noreturn functions (authored by vsk).
HotColdSplitting: Do not outline within noreturn functions
Thu, Dec 19, 2:40 PM

Dec 18 2019

vsk committed rG5094e6dad64c: Revert concepts changes from D41910 (authored by vsk).
Revert concepts changes from D41910
Dec 18 2019, 3:17 PM
vsk added a reverting change for rGfc0731b98a67: [Concepts] Constrained partial specializations and function overloads.: rG5094e6dad64c: Revert concepts changes from D41910.
Dec 18 2019, 3:17 PM
vsk added a reverting change for rG11d5fa6e87e3: [Concepts] Fix incorrect move out of temporary in D41910: rG5094e6dad64c: Revert concepts changes from D41910.
Dec 18 2019, 3:17 PM
vsk added a reverting change for rG12038be20ee6: [Concepts] Fix crash in D41910: rG5094e6dad64c: Revert concepts changes from D41910.
Dec 18 2019, 3:17 PM
vsk accepted D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

Thanks, lgtm as well.

Dec 18 2019, 10:06 AM · Restricted Project, debug-info

Dec 17 2019

vsk added inline comments to D71491: [ubsan] Check implicit casts in ObjC for-in statements.
Dec 17 2019, 11:26 AM · Restricted Project
vsk accepted D71585: [perf-training] Change profile file pattern string to use %4m instead of %p.

Separately, if you have the bandwidth to test out the new '%c%m' mode (https://clang.llvm.org/docs/SourceBasedCodeCoverage.html#running-the-instrumented-program / https://reviews.llvm.org/D68351), I'd appreciate any feedback about it. It should use ~4x less space.

Dec 17 2019, 10:54 AM · Restricted Project

Dec 16 2019

vsk added a comment to D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions..

Essentially KILL instructions are NOOPs. They do not change the bit fields of any of the registers they touch. They merely adjust the liveness of a register or subregister to indicate to future consumers that the liveness of some value in a register has changed.
[snip]

Dec 16 2019, 2:11 PM · Restricted Project, debug-info
vsk updated the diff for D71491: [ubsan] Check implicit casts in ObjC for-in statements.

Ignore an objc-cast report at a given SourceLocation after it's been reported once.

Dec 16 2019, 1:52 PM · Restricted Project
vsk updated the diff for D71491: [ubsan] Check implicit casts in ObjC for-in statements.

Avoid a static initializer.

Dec 16 2019, 1:40 PM · Restricted Project
vsk added inline comments to D71491: [ubsan] Check implicit casts in ObjC for-in statements.
Dec 16 2019, 1:40 PM · Restricted Project
vsk updated the diff for D71491: [ubsan] Check implicit casts in ObjC for-in statements.

Address review feedback.

Dec 16 2019, 1:40 PM · Restricted Project

Dec 13 2019

vsk accepted D71480: [BasicBlockUtils] Fix dbg.value elimination problem in MergeBlockIntoPredecessor.

LGTM as well.

Dec 13 2019, 3:36 PM · Restricted Project
vsk added a comment to D71478: [BasicBlockUtils] Add utility to remove redundant dbg.value instrs.

This is really nice.

Dec 13 2019, 3:28 PM · Restricted Project
vsk committed rGed83942bc025: [ubsan] Enable testing of .m files (authored by vsk).
[ubsan] Enable testing of .m files
Dec 13 2019, 3:00 PM
vsk created D71491: [ubsan] Check implicit casts in ObjC for-in statements.
Dec 13 2019, 2:15 PM · Restricted Project
vsk added inline comments to D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.
Dec 13 2019, 9:01 AM · Restricted Project

Dec 12 2019

vsk committed rG46d970cc4360: TypeCategory: Initialize m_enabled to false (authored by vsk).
TypeCategory: Initialize m_enabled to false
Dec 12 2019, 3:55 PM
GitHub <noreply@github.com> committed rG3ca8c89849ef: Merge pull request #304 from vedantk/apple/stable/20191106 (authored by vsk).
Merge pull request #304 from vedantk/apple/stable/20191106
Dec 12 2019, 3:52 PM
vsk committed rG42460cc933fe: Revert "[CGDebugInfo] Emit subprograms for decls when AT_tail_call is… (authored by vsk).
Revert "[CGDebugInfo] Emit subprograms for decls when AT_tail_call is…
Dec 12 2019, 3:52 PM
vsk added a reverting change for rGa5c8ec4baa2c: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood: rG42460cc933fe: Revert "[CGDebugInfo] Emit subprograms for decls when AT_tail_call is….
Dec 12 2019, 3:52 PM
vsk committed rG65164fd49cbd: Merge commit 'refs/am/changes/d889d1efefe9f97507e3eafa85a2e3939df9750f_apple/ma… (authored by vsk).
Merge commit 'refs/am/changes/d889d1efefe9f97507e3eafa85a2e3939df9750f_apple/ma…
Dec 12 2019, 3:40 PM
GitHub <noreply@github.com> committed rG0b6b2f102656: Reapply: Port swift specific compiler-rt code to Windows (authored by vsk).
Reapply: Port swift specific compiler-rt code to Windows
Dec 12 2019, 3:17 PM
vsk committed rG938e3002f347: Reapply: Port swift specific compiler-rt code to Windows (authored by vsk).
Reapply: Port swift specific compiler-rt code to Windows
Dec 12 2019, 3:17 PM
vsk committed rGcb4c50136692: Merge commit 'refs/am/changes/937241b0d9e8f896d4387292f01abf18ba9f9fcb_apple/ma… (authored by vsk).
Merge commit 'refs/am/changes/937241b0d9e8f896d4387292f01abf18ba9f9fcb_apple/ma…
Dec 12 2019, 3:06 PM
vsk committed rGace982bbdff1: Reapply: [profile] Fix bug in exit-on-signal specifier parsing (authored by vsk).
Reapply: [profile] Fix bug in exit-on-signal specifier parsing
Dec 12 2019, 3:00 PM
vsk committed rG05687dc86c53: Reapply: [profile] Add support for the exit-on-signal '%Nx' specifier (authored by vsk).
Reapply: [profile] Add support for the exit-on-signal '%Nx' specifier
Dec 12 2019, 3:00 PM
vsk committed rG5cd6761fd6d0: Fix Assumption-cache-invalidation (authored by Gwen Mittertreiner <gwenm@oculus.com>).
Fix Assumption-cache-invalidation
Dec 12 2019, 2:59 PM
vsk committed rGef758dcb83f4: rdar://49167240: [HotColdSplit] Reflect full cost of parameters in split penalty (authored by vsk).
rdar://49167240: [HotColdSplit] Reflect full cost of parameters in split penalty
Dec 12 2019, 1:31 PM
vsk committed rG08d603e3ff4a: Re-apply "swift-clang: Enable hot/cold splitting by default" (authored by vsk).
Re-apply "swift-clang: Enable hot/cold splitting by default"
Dec 12 2019, 1:01 PM
vsk committed rG237d75ba18dc: Merge remote-tracking branch 'llvm/master' into upstream-with-swift (authored by vsk).
Merge remote-tracking branch 'llvm/master' into upstream-with-swift
Dec 12 2019, 1:01 PM
vsk committed rGf148d1dc8b29: Revert "swift-clang: Enable hot/cold splitting by default" (authored by vsk).
Revert "swift-clang: Enable hot/cold splitting by default"
Dec 12 2019, 1:00 PM
vsk committed rG9f13b8b01063: Merge remote-tracking branch 'llvm/master' into upstream-with-swift (authored by vsk).
Merge remote-tracking branch 'llvm/master' into upstream-with-swift
Dec 12 2019, 12:56 PM
vsk committed rGa9b28fe263fa: Merge remote-tracking branch 'llvm/master' into upstream-with-swift (authored by vsk).
Merge remote-tracking branch 'llvm/master' into upstream-with-swift
Dec 12 2019, 12:56 PM
vsk committed rGfaf823857ecc: [test] Set -fno-split-cold-code in tests sensitive to splitting, NFC (authored by vsk).
[test] Set -fno-split-cold-code in tests sensitive to splitting, NFC
Dec 12 2019, 12:46 PM
vsk committed rG0ecf71a66d5b: swift-clang: Enable hot/cold splitting by default (authored by vsk).
swift-clang: Enable hot/cold splitting by default
Dec 12 2019, 12:46 PM
vsk committed rG63688242ece6: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting (authored by vsk).
[PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting
Dec 12 2019, 12:46 PM
vsk committed rG8c5c6adafe3f: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting (llvm) (authored by vsk).
[PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting (llvm)
Dec 12 2019, 12:46 PM
vsk accepted D71415: [llvm-locstats] Avoid the loc stats for the cases with no scope bytes coverage.
Dec 12 2019, 11:19 AM · Restricted Project, debug-info
vsk added a comment to D71310: RFC: Remove "Validators".

I believe this change is responsible:

Dec 12 2019, 11:10 AM · Restricted Project
vsk added a comment to D71310: RFC: Remove "Validators".

Just a heads up while I investigate, I'm starting to see this on the sanitizer bot:

/Users/buildslave/jenkins/workspace/lldb-cmake-sanitized/llvm-project/lldb/include/lldb/DataFormatters/TypeCategory.h:278:35: runtime error: load of value 190, which is not a valid value for type 'bool'

http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake-sanitized/621

Dec 12 2019, 11:00 AM · Restricted Project
vsk accepted D71416: [LiveDebugValues] Omit entry values for DBG_VALUEs with pre-existing expressions.

Thanks, lgtm as well.

Dec 12 2019, 10:41 AM · Restricted Project, debug-info