Page MenuHomePhabricator

vsk (Vedant Kumar)
User

Projects

User Details

User Since
Jul 8 2015, 10:26 AM (246 w, 6 d)

Recent Activity

Today

vsk created D77155: [llvm-locstats] Fix labels on x-axis of comparison chart.
Tue, Mar 31, 11:26 AM · Restricted Project

Yesterday

vsk committed rGdcc410b5cf20: [LoopVectorize] Fix crash on "getNoopOrZeroExtend cannot truncate!" (PR45259) (authored by vsk).
[LoopVectorize] Fix crash on "getNoopOrZeroExtend cannot truncate!" (PR45259)
Mon, Mar 30, 10:19 AM
vsk closed D76669: [LoopVectorize] Fix crash on "getNoopOrZeroExtend cannot truncate!" (PR45259).
Mon, Mar 30, 10:19 AM · Restricted Project

Fri, Mar 27

vsk accepted D76930: [DebugInfo] Ensure dead store elimination can mark an operand value as undefined.

Thanks, lgtm, +1 for the proposal to hide/delete salvageDebugInfo.

Fri, Mar 27, 10:16 AM

Thu, Mar 26

vsk accepted D76763: Export Segment.IsGapRegion to JSON.

Lgtm, thanks.

Thu, Mar 26, 9:46 AM · Restricted Project

Wed, Mar 25

vsk accepted D76796: [llvm-cov] Improve error message for missing profdata.

Thanks, lgtm. I don't have a strong opinion on the message format -- David's suggestion sounds reasonable.

Wed, Mar 25, 1:32 PM · Restricted Project
vsk added a comment to D76763: Export Segment.IsGapRegion to JSON.

Thanks for doing this. Yes, I think a patch version bump would be appropriate. Also, please update test/tools/llvm-cov/Inputs/binary-formats.canonical.json to test this change.

Wed, Mar 25, 10:16 AM · Restricted Project

Tue, Mar 24

vsk updated the diff for D76669: [LoopVectorize] Fix crash on "getNoopOrZeroExtend cannot truncate!" (PR45259).

@fhahn thanks for the simplified test! This update should incorporate all the feedback.

Tue, Mar 24, 4:10 PM · Restricted Project
vsk committed rG03e29e2c19a8: [lldb/DWARF] Reland: Use DW_AT_call_pc to determine artificial frame address (authored by vsk).
[lldb/DWARF] Reland: Use DW_AT_call_pc to determine artificial frame address
Tue, Mar 24, 12:56 PM
vsk added a reverting change for rG6905394d1539: [lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address: rG0a9b91c390b2: Revert "[lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address".
Tue, Mar 24, 12:23 PM
vsk committed rG0a9b91c390b2: Revert "[lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address" (authored by vsk).
Revert "[lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address"
Tue, Mar 24, 12:23 PM
vsk committed rG6905394d1539: [lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address (authored by vsk).
[lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address
Tue, Mar 24, 12:23 PM
vsk closed D76337: [lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address.
Tue, Mar 24, 12:22 PM · Restricted Project
vsk committed rGf7052da6db8f: [DWARF] Emit DW_AT_call_pc for tail calls (authored by vsk).
[DWARF] Emit DW_AT_call_pc for tail calls
Tue, Mar 24, 12:22 PM
vsk closed D76336: [DWARF] Emit DW_AT_call_pc for tail calls.
Tue, Mar 24, 12:22 PM · Restricted Project, debug-info
vsk added a comment to D76337: [lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address.

I'll land this shortly if there aren't any objections.

Tue, Mar 24, 11:49 AM · Restricted Project

Mon, Mar 23

vsk committed rGb7cd291c1542: [GlobalOpt] Treat null-check of loaded value as use of global (PR35760) (authored by vsk).
[GlobalOpt] Treat null-check of loaded value as use of global (PR35760)
Mon, Mar 23, 10:50 PM
vsk closed D76645: [GlobalOpt] Treat null-check of loaded value as use of global (PR35760).
Mon, Mar 23, 10:50 PM · Restricted Project
vsk created D76669: [LoopVectorize] Fix crash on "getNoopOrZeroExtend cannot truncate!" (PR45259).
Mon, Mar 23, 10:49 PM · Restricted Project
vsk added a comment to D76645: [GlobalOpt] Treat null-check of loaded value as use of global (PR35760).

Thanks!

Mon, Mar 23, 10:49 PM · Restricted Project
vsk created D76645: [GlobalOpt] Treat null-check of loaded value as use of global (PR35760).
Mon, Mar 23, 3:48 PM · Restricted Project
vsk added inline comments to D76336: [DWARF] Emit DW_AT_call_pc for tail calls.
Mon, Mar 23, 2:11 PM · Restricted Project, debug-info
vsk updated the diff for D76336: [DWARF] Emit DW_AT_call_pc for tail calls.

Address review feedback.

Mon, Mar 23, 2:11 PM · Restricted Project, debug-info

Fri, Mar 20

vsk updated the diff for D76336: [DWARF] Emit DW_AT_call_pc for tail calls.

Add more detailed comments, and always emit DW_AT_call_pc in DWARF5 mode (even when tuning for GDB).

Fri, Mar 20, 5:22 PM · Restricted Project, debug-info
vsk added a comment to D76336: [DWARF] Emit DW_AT_call_pc for tail calls.
In D76336#1934726, @vsk wrote:
In D76336#1934599, @vsk wrote:

Per @djtodoro's suggestion, avoid emitting DW_AT_call_pc when tuning for gdb. We already emit AT_call_return_pc in this case, which seems weird/wrong to me, but that's what gdb expects to see it seems.

Does it work for GDB?

Yes, @djtodoro's second-to-last comment shows an example where gdb works out the address for an artificial frame using the "return pc".

If so, how? Please be sure there's clear documentation (probably in a somewhat long explanatory comment in the LLVM source itself) about why this divergence is justified

I left a comment where DW_AT_call_pc is emitted explaining the situation: 'GDB prefers to work out what the call pc is by subtracting an offset from DW_AT_low_pc/DW_AT_call_return_pc'. I'll expand on this.

Should we do that only in DWARFv4, and leave DWARFv5 standard & let GDB implement the missing functionality to understand the standard form?

Fri, Mar 20, 5:22 PM · Restricted Project, debug-info
vsk added a comment to D76336: [DWARF] Emit DW_AT_call_pc for tail calls.
In D76336#1934599, @vsk wrote:

Per @djtodoro's suggestion, avoid emitting DW_AT_call_pc when tuning for gdb. We already emit AT_call_return_pc in this case, which seems weird/wrong to me, but that's what gdb expects to see it seems.

Does it work for GDB?

Fri, Mar 20, 3:45 PM · Restricted Project, debug-info
vsk updated the diff for D76336: [DWARF] Emit DW_AT_call_pc for tail calls.

Per @djtodoro's suggestion, avoid emitting DW_AT_call_pc when tuning for gdb. We already emit AT_call_return_pc in this case, which seems weird/wrong to me, but that's what gdb expects to see it seems.

Fri, Mar 20, 2:40 PM · Restricted Project, debug-info
vsk committed rG7ec24448801c: unittest: Work around build failure on MSVC builders (authored by vsk).
unittest: Work around build failure on MSVC builders
Fri, Mar 20, 1:01 PM
vsk committed rGa24594335513: [LiveDebugValues] Speed up collectIDsForRegs, NFC (authored by vsk).
[LiveDebugValues] Speed up collectIDsForRegs, NFC
Fri, Mar 20, 12:29 PM
vsk committed rGa3fd1a1c744f: [ADT] CoalescingBitVector: Add advanceToLowerBound iterator operation (authored by vsk).
[ADT] CoalescingBitVector: Add advanceToLowerBound iterator operation
Fri, Mar 20, 12:29 PM
vsk closed D76467: [LiveDebugValues] Speed up collectIDsForRegs, NFC.
Fri, Mar 20, 12:29 PM · Restricted Project, debug-info
vsk committed rG4716ebb823e4: [ADT] CoalescingBitVector: Avoid initial heap allocation, NFC (authored by vsk).
[ADT] CoalescingBitVector: Avoid initial heap allocation, NFC
Fri, Mar 20, 12:29 PM
vsk closed D76466: [ADT] CoalescingBitVector: Add advanceToLowerBound iterator operation.
Fri, Mar 20, 12:29 PM · Restricted Project
vsk closed D76465: [ADT] CoalescingBitVector: Avoid initial heap allocation, NFC.
Fri, Mar 20, 12:29 PM · Restricted Project, debug-info
vsk updated the diff for D76466: [ADT] CoalescingBitVector: Add advanceToLowerBound iterator operation.

Add additional documentation, as suggested.

Fri, Mar 20, 11:55 AM · Restricted Project
vsk added inline comments to D76467: [LiveDebugValues] Speed up collectIDsForRegs, NFC.
Fri, Mar 20, 11:55 AM · Restricted Project, debug-info
vsk accepted D76476: Add formatter for libc++ std::unique_ptr .

LGTM with some added test coverage. Jim?

Fri, Mar 20, 11:55 AM · Restricted Project
vsk committed rG636665331bbd: PR45181: Fix another invalid DIExpression combination (authored by vsk).
PR45181: Fix another invalid DIExpression combination
Fri, Mar 20, 11:24 AM
vsk added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

@manojgupta I apologize for not catching this earlier. The issue should really be fixed by 636665331bbd4c369a9f33c4d35fb9a863c94646.

Fri, Mar 20, 11:23 AM · Restricted Project, Restricted Project, Restricted Project, debug-info
vsk added a comment to D73534: [DebugInfo] Enable the debug entry values feature by default.

Oh sorry, I thought it all has been fixed, since all the tests pass.

We should revert the D75036 until we fix all the issues.

@dstenb do you agree?

Fri, Mar 20, 11:23 AM · Restricted Project, Restricted Project, Restricted Project, debug-info
vsk added a comment to D76476: Add formatter for libc++ std::unique_ptr .

Awesome :)

Fri, Mar 20, 8:05 AM · Restricted Project

Thu, Mar 19

vsk updated the diff for D76466: [ADT] CoalescingBitVector: Add advanceToLowerBound iterator operation.

Allow advanceToLowerBound to be called on end(), as this happens in practice.

Thu, Mar 19, 6:07 PM · Restricted Project
vsk added a comment to D76016: [ProfileData] Add option to ignore invalid regions.

I see. No, I think whenever we have malformed coverage data, it points to an underlying bug in the compiler. Still, I think llvm-cov's treatment of invalid data is too severe. Is there a good reason it should bail entirely? If it's able to process all but a single coverage region, it seems like it ought to report what it was able to process, no? I think that at least having the option for llvm-cov to behave this way is helpful, although I can understand if others disagree.

For the time being, I'm working to fix the coverage data flaw in Clang's support of C++20 coroutines. But just to reiterate: it's not just coroutines and new language features that have caused invalid regions to appear in coverage data, there's also been cases such as D65428, which as far as I can tell is a bug in a long-existing language feature. In a sense, it's nice that llvm-cov "fails fast" and reports invalid data, but pragmatically it's also nice to have the capability to make it resilient to frontend bugs. At least, that's what I think -- let me know if you disagree :)

Thu, Mar 19, 6:07 PM · Restricted Project
vsk created D76467: [LiveDebugValues] Speed up collectIDsForRegs, NFC.
Thu, Mar 19, 5:00 PM · Restricted Project, debug-info
vsk added a child revision for D76466: [ADT] CoalescingBitVector: Add advanceToLowerBound iterator operation: D76467: [LiveDebugValues] Speed up collectIDsForRegs, NFC.
Thu, Mar 19, 5:00 PM · Restricted Project
vsk created D76466: [ADT] CoalescingBitVector: Add advanceToLowerBound iterator operation.
Thu, Mar 19, 5:00 PM · Restricted Project
vsk created D76465: [ADT] CoalescingBitVector: Avoid initial heap allocation, NFC.
Thu, Mar 19, 5:00 PM · Restricted Project, debug-info
vsk added a comment to D76336: [DWARF] Emit DW_AT_call_pc for tail calls.

@dblaikie wrote:
why is this only relevant in optimized builds?

I think the main benefit of the call-site information is using it together with call-site-parameters, used for computing the actual value of parameter, even the location of the parameter was not provided (optimized-out).

That presents some interestingly tricky challenges. We have -fstandalone-debug for if you are building one part of a program with debug info an others without - but there's nothing equivalent for if you're building part of a program optimized but other parts unoptimized. And this heuristic (only emit these attributes for optimized code) assumes the caller and callee are both equally optimized/similarly compiled - which isn't necessarily true.

Thu, Mar 19, 3:54 PM · Restricted Project, debug-info
vsk added a comment to D76336: [DWARF] Emit DW_AT_call_pc for tail calls.

This patch causes a 0.7% size increase in rela.debug_addr in a stage2 -gdwarf-5 build on Linux. That's ~569KB, similar to the size increase seen on Darwin (see my earlier comment). Here are the steps I took to measure:

Thu, Mar 19, 3:22 PM · Restricted Project, debug-info
vsk added a reviewer for D76449: [lldb/Dwarf] Change DW_OP_piece to use an llvm::BitVector (WIP): labath.

Excited to see this take shape :)

Thu, Mar 19, 2:50 PM · Restricted Project
vsk committed rG5e6e545cbab0: [test] Re-enable accidentally disabled X86 tests (authored by vsk).
[test] Re-enable accidentally disabled X86 tests
Thu, Mar 19, 9:48 AM
vsk added a comment to D73568: Remove lit feature object-emission.

My earlier comment was wrong, none of the tests broke, I just had a stale build directory. I've re-enabled the x86 tests in 5e6e545cbab05589c8fcef5f03eca60dc227a6ca.

Thu, Mar 19, 9:45 AM · Restricted Project
vsk added a comment to D73568: Remove lit feature object-emission.
In D73568#1927929, @vsk wrote:

If 'object-emission' is gone, can we fix this by removing all instances of 'REQUIRES: x86'?

Interesting. I'd have thought this would match an x86_64-foo-foo target triple, but perhaps not.
In any case, tests under an X86 directory should not need an explicit REQUIRES because the lit.local.cfg takes care of that.

Thu, Mar 19, 9:10 AM · Restricted Project

Wed, Mar 18

vsk added a comment to D76336: [DWARF] Emit DW_AT_call_pc for tail calls.
In D76336#1929994, @vsk wrote:

(general caveat: this should be committed as separate patches - between llvm and llvm-dsymutil (much like llvm-dwarfdump and llvm codegen are usually committed separately) - but yeah, it's nice to see it all together for review))

Sounds good, I'll split this up before committing.

Do you happen to have numbers for, say, clang, on the growth of object size because of this - specifically I'd be interested in the growth of the .rela.debug_addr section in a DWARFv5 build.

I looked at the size impact on a Darwin -gdwarf-4 stage2 clang build. The aggregate size of .o's post-patch grows 0.006% (8367046264 bytes -> 8367544576 bytes, a 486KB increase). Tail calls make up ~5% of all calls (in clang at least), so this is in line with what was measured in D72489. In D72489, I added a relocation to every non-tail call site entry, which increased the aggregate .o size by 0.04% (~3MB).

I don't think linker support for dwarf5 is mature enough on Darwin for me to measure. Perhaps that measurement wouldn't be very useful, as ELF relocations are different.

Right, an ELF measurement is what I was interested in, owing to the different relocations & .rela.debug_addr is especially significant to my use case involving split DWARF and compressed DWARF, so some of the largest remaining content is debug_addr relocations.

Wed, Mar 18, 4:51 PM · Restricted Project, debug-info
vsk committed rG47622efc6f01: [clang/test] Add test for DIFlagAllCallsDescribed under -ggdb + -gdwarf-4, NFC (authored by vsk).
[clang/test] Add test for DIFlagAllCallsDescribed under -ggdb + -gdwarf-4, NFC
Wed, Mar 18, 3:47 PM
vsk updated the diff for D76336: [DWARF] Emit DW_AT_call_pc for tail calls.

Incorporate feedback from @djtodoro.

Wed, Mar 18, 3:46 PM · Restricted Project, debug-info
vsk added a comment to D76336: [DWARF] Emit DW_AT_call_pc for tail calls.

(general caveat: this should be committed as separate patches - between llvm and llvm-dsymutil (much like llvm-dwarfdump and llvm codegen are usually committed separately) - but yeah, it's nice to see it all together for review))

Wed, Mar 18, 3:46 PM · Restricted Project, debug-info
vsk added a comment to D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.

@awpandey @SouraVX this is still breaking the stage2 clang self-host with -gdwarf-5, see https://bugs.llvm.org/show_bug.cgi?id=45166. Do you have time to take a look?

Wed, Mar 18, 11:57 AM · Restricted Project, Restricted Project

Tue, Mar 17

vsk added a child revision for D76336: [DWARF] Emit DW_AT_call_pc for tail calls: D76337: [lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address.
Tue, Mar 17, 6:23 PM · Restricted Project, debug-info
vsk created D76337: [lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address.
Tue, Mar 17, 6:23 PM · Restricted Project
vsk created D76336: [DWARF] Emit DW_AT_call_pc for tail calls.
Tue, Mar 17, 6:23 PM · Restricted Project, debug-info
vsk added a comment to D73568: Remove lit feature object-emission.

@ted @JDevlieghere I think this caused a bunch of tests to be disabled, because "x86" is not an available feature.

Tue, Mar 17, 4:46 PM · Restricted Project
vsk committed rG526c51e6fdc8: [DwarfDebug] Fix an assertion error when emitting call site info that combines… (authored by vsk).
[DwarfDebug] Fix an assertion error when emitting call site info that combines…
Tue, Mar 17, 12:58 PM
vsk closed D76164: Fix an assertion error when emitting call site info that combines two DW_OP_stack_values..
Tue, Mar 17, 12:58 PM · Restricted Project, debug-info
vsk updated the diff for D76164: Fix an assertion error when emitting call site info that combines two DW_OP_stack_values..

Fix typo, tighten up test.

Tue, Mar 17, 11:16 AM · Restricted Project, debug-info
vsk added inline comments to D76279: [DebugInfo] Fix multi-byte entry values in call site values.
Tue, Mar 17, 11:16 AM · Restricted Project, debug-info
vsk added a comment to D75175: [CallSiteInfo] Enable the call site info only for -g + optimizations.

Sorry for the delay here.

Tue, Mar 17, 10:10 AM · Restricted Project, debug-info, Restricted Project

Mon, Mar 16

vsk updated the diff for D76164: Fix an assertion error when emitting call site info that combines two DW_OP_stack_values..

Address review feedback.

Mon, Mar 16, 6:35 PM · Restricted Project, debug-info
vsk accepted D76145: [DebugInfo] Introduce a DW_OP_LLVM_convert_generic operation.

Thanks, lgtm.

Mon, Mar 16, 4:57 PM · Restricted Project, debug-info
vsk accepted D76146: [DebugInfo] Use DW_OP_LLVM_convert_generic after sign/zero exts.

It seems sensible to limit conversions back to the generic type as much as possible, so this approach lgtm.

Mon, Mar 16, 4:57 PM · Restricted Project, debug-info
vsk commandeered D76164: Fix an assertion error when emitting call site info that combines two DW_OP_stack_values..

@djtodoro Perhaps I'm missing something, but it doesn't look like D76146 would address the issue of there being two DW_OP_stack_values in the combined expression. So I think something along the lines of this patch will be needed. I'll commandeer this, per Adrian's request.

Mon, Mar 16, 4:24 PM · Restricted Project, debug-info
vsk added a comment to D75326: [entry values] X86: Describe effects of MOV{8,16}ri (PR45053).

@djtodoro thanks for landing a workaround!

Mon, Mar 16, 4:24 PM · debug-info, Restricted Project
vsk added a comment to D76016: [ProfileData] Add option to ignore invalid regions.

I'm not sure this is the right thing to do. Do you see the 'malformed coverage data' error reported when there isn't a compiler bug? I worry that if this option were made available, frontend support for new language features would lag behind.

Mon, Mar 16, 3:51 PM · Restricted Project

Wed, Mar 4

vsk accepted D75615: Revert "[CGBlocks] Improve line info in backtraces containing *_helper_block".

Nice! Lgtm, thanks.

Wed, Mar 4, 1:29 PM · Restricted Project, debug-info
vsk accepted D75625: [AArch64] Harmonize print format of hint instructions..

Thanks, I think this is a nice cleanup. LGTM provided that this is check-llvm clean.

Wed, Mar 4, 10:39 AM · Restricted Project
vsk added inline comments to D75615: Revert "[CGBlocks] Improve line info in backtraces containing *_helper_block".
Wed, Mar 4, 9:32 AM · Restricted Project, debug-info

Tue, Mar 3

vsk added a comment to D75326: [entry values] X86: Describe effects of MOV{8,16}ri (PR45053).

Sorry for the delay here.

Tue, Mar 3, 2:25 PM · debug-info, Restricted Project
vsk committed rGb5b21812dcdd: test: Adjust no-dbg-value-after-terminator.mir to use `not --crash` (authored by vsk).
test: Adjust no-dbg-value-after-terminator.mir to use `not --crash`
Tue, Mar 3, 1:48 PM
vsk committed rGf002ee55c781: [MachineVerifier] Remove placement rule exception for debug entry values (authored by vsk).
[MachineVerifier] Remove placement rule exception for debug entry values
Tue, Mar 3, 1:17 PM
vsk closed D75559: [MachineVerifier] Remove placement rule exception for debug entry values.
Tue, Mar 3, 1:15 PM · Restricted Project, debug-info
vsk committed rG2bf496620cbb: [LiveDebugValues] Do not insert DBG_VALUEs after a MBB terminator (authored by vsk).
[LiveDebugValues] Do not insert DBG_VALUEs after a MBB terminator
Tue, Mar 3, 1:15 PM
vsk closed D75548: [LiveDebugValues] Do not insert DBG_VALUEs after a MBB terminator.
Tue, Mar 3, 1:14 PM · Restricted Project, debug-info
vsk created D75559: [MachineVerifier] Remove placement rule exception for debug entry values.
Tue, Mar 3, 12:37 PM · Restricted Project, debug-info
vsk added a child revision for D75548: [LiveDebugValues] Do not insert DBG_VALUEs after a MBB terminator: D75559: [MachineVerifier] Remove placement rule exception for debug entry values.
Tue, Mar 3, 12:37 PM · Restricted Project, debug-info
vsk created D75548: [LiveDebugValues] Do not insert DBG_VALUEs after a MBB terminator.
Tue, Mar 3, 11:17 AM · Restricted Project, debug-info
vsk edited reviewers for D75520: [compiler-rt] Fix tests after defaulting to -fno-common. NFC., added: eugenis, vitalybuka; removed: vsk.

Adding reviewers with more familiarity with Asan.

Tue, Mar 3, 7:23 AM · Restricted Project

Mon, Mar 2

vsk committed rGd64a22a2add9: [LiveDebugValues] Prevent some misuse of LocIndex::fromRawInteger, NFC (authored by vsk).
[LiveDebugValues] Prevent some misuse of LocIndex::fromRawInteger, NFC
Mon, Mar 2, 5:15 PM
vsk accepted D74030: [DebugInfo] Avoid generating duplicate llvm.dbg.value.

LGTM, thanks!

Mon, Mar 2, 1:19 PM · Restricted Project, debug-info
vsk committed rG0eb5b6e88c78: [test/compiler-rt] Disable ubsan/TestCases/Misc/nullability.c on Android (authored by vsk).
[test/compiler-rt] Disable ubsan/TestCases/Misc/nullability.c on Android
Mon, Mar 2, 12:04 PM
vsk committed rG80cd518b809d: [Coverage] Collect all function records in an object (D69471 followup) (authored by vsk).
[Coverage] Collect all function records in an object (D69471 followup)
Mon, Mar 2, 12:04 PM
vsk added a comment to rGc54597b99d6f: [ubsan] Add support for -fsanitize=nullability-* suppressions.

FYI - the reason why this breaks on the Android bots is because they use android_compile.py and some other scripts to actually compile and deploy things onto Android devices. Because the suppressions files aren't pushed to the devices (and the paths aren't correct), the tests are failing.

Mon, Mar 2, 12:03 PM
vsk committed rG806bb1e029bb: Second attempt to disable instrprof-merging.cpp (authored by vsk).
Second attempt to disable instrprof-merging.cpp
Mon, Mar 2, 9:31 AM
vsk committed rGf82ae3ad8f1b: Disable instrprof-merging.cpp to unblock bots while I investigate (authored by vsk).
Disable instrprof-merging.cpp to unblock bots while I investigate
Mon, Mar 2, 7:54 AM

Feb 28 2020

vsk committed rGa1f3eb2085c1: Disable instrprof-merging.cpp on powerpc64 (D69471 follow up) (authored by vsk).
Disable instrprof-merging.cpp on powerpc64 (D69471 follow up)
Feb 28 2020, 7:06 PM
vsk committed rGe63a3b445ac0: Add cast to appease clang-armv7-linux-build-cache (D69471 followup) (authored by vsk).
Add cast to appease clang-armv7-linux-build-cache (D69471 followup)
Feb 28 2020, 6:30 PM
vsk committed rGdd1ea9de2e3e: Reland: [Coverage] Revise format to reduce binary size (authored by vsk).
Reland: [Coverage] Revise format to reduce binary size
Feb 28 2020, 6:13 PM
vsk committed rG3388871714d3: Revert "[Coverage] Revise format to reduce binary size" (authored by vsk).
Revert "[Coverage] Revise format to reduce binary size"
Feb 28 2020, 6:04 PM
vsk added a reverting change for rG99317124e1c7: [Coverage] Revise format to reduce binary size: rG3388871714d3: Revert "[Coverage] Revise format to reduce binary size".
Feb 28 2020, 6:04 PM
vsk committed rG7300c338e5f5: [compiler-rt/test] Relax a test so we can debug it on sanitizer-x86_64-linux… (authored by vsk).
[compiler-rt/test] Relax a test so we can debug it on sanitizer-x86_64-linux…
Feb 28 2020, 5:48 PM
vsk committed rG99317124e1c7: [Coverage] Revise format to reduce binary size (authored by vsk).
[Coverage] Revise format to reduce binary size
Feb 28 2020, 5:37 PM