This is an archive of the discontinued LLVM Phabricator instance.

Differential D136308

[docs] Update compiler-rt/CODE_OWNERS.TXT
ClosedPublic

Authored by vitalybuka on Oct 19 2022, 5:35 PM.

Details

Reviewers
browneee
cryptoad
Commits
rG773e5dfbc6bf: [docs] Update compiler-rt/CODE_OWNERS.TXT
Summary

D135617 leftovers

Diff Detail

Event Timeline

vitalybuka created this revision.Oct 19 2022, 5:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2022, 5:35 PM
Herald added subscribers: Enna1, cryptoad, dberris. · View Herald Transcript
vitalybuka requested review of this revision.Oct 19 2022, 5:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2022, 5:35 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka added reviewers: void, dberris, browneee, cryptoad, vsk, davidxl.Oct 19 2022, 5:37 PM
Harbormaster completed remote builds in B193132: Diff 469092.Oct 19 2022, 6:02 PM
browneee accepted this revision.Oct 19 2022, 8:06 PM
void added inline comments.Oct 21 2022, 4:31 PM
compiler-rt/CODE_OWNERS.TXT
59

???

vitalybuka added inline comments.Oct 21 2022, 4:45 PM
compiler-rt/CODE_OWNERS.TXT
59

I don't have good idea who should be Profile OWNER
There was https://reviews.llvm.org/D135617#inline-1307547
If it's wrong I will undo this part.

void added inline comments.Oct 24 2022, 11:09 AM
compiler-rt/CODE_OWNERS.TXT
59

I guess it's okay...

vitalybuka added a comment.Nov 16 2022, 7:47 PM

ping

vitalybuka added a comment.Nov 21 2022, 5:02 PM

@vsk @davidxl @cryptoad @dberris PTAL

vitalybuka added a comment.Jan 23 2023, 2:56 PM

ping

Herald added subscribers: yaneury, supersymetrie, Chia-hungDuan. · View Herald TranscriptJan 23 2023, 2:56 PM
vitalybuka added a comment.Jan 27 2023, 11:17 AM

@vsk @davidxl @cryptoad @dberris
Please let me know what do you think about changes with your own names.

cryptoad accepted this revision.Jan 27 2023, 11:53 AM
vitalybuka updated this revision to Diff 500301.Feb 24 2023, 3:06 PM

only agreed changes

vitalybuka removed reviewers: void, dberris, vsk, davidxl.Feb 24 2023, 3:06 PM
This revision is now accepted and ready to land.Feb 24 2023, 3:06 PM
This revision was landed with ongoing or failed builds.Feb 24 2023, 3:07 PM
Closed by commit rG773e5dfbc6bf: [docs] Update compiler-rt/CODE_OWNERS.TXT (authored by vitalybuka). · Explain Why
This revision was automatically updated to reflect the committed changes.
vitalybuka added a commit: rG773e5dfbc6bf: [docs] Update compiler-rt/CODE_OWNERS.TXT.
Harbormaster completed remote builds in B215831: Diff 500301.Feb 25 2023, 12:19 AM

Revision Contents

PathSize
compiler-rt/
8 lines

Diff 500302

compiler-rt/CODE_OWNERS.TXT

This file is a list of the people responsible for ensuring that patches for a This file is a list of the people responsible for ensuring that patches for a
particular part of compiler-rt are reviewed, either by themself or by particular part of compiler-rt are reviewed, either by themself or by
someone else. They are also the gatekeepers for their part of compiler-rt, with someone else. They are also the gatekeepers for their part of compiler-rt, with
the final word on what goes in or not. the final word on what goes in or not.
The list is sorted by surname and formatted to allow easy grepping and The list is sorted by surname and formatted to allow easy grepping and
beautification by scripts. The fields are: name (N), email (E), web-address beautification by scripts. The fields are: name (N), email (E), web-address
(W), PGP key ID and fingerprint (P), description (D), and snail-mail address (W), PGP key ID and fingerprint (P), description (D), and snail-mail address
(S). (S).
N: Saleem Abdulrasool N: Saleem Abdulrasool
E: compnerd@compnerd.org E: compnerd@compnerd.org
D: builtins library D: builtins library
N: Andrew Browne
E: browneee@google.com
D: DataFlowSanitizer
N: Vitaly Buka N: Vitaly Buka
E: vitalybuka@google.com E: vitalybuka@google.com
D: Sanitizers D: Sanitizers
N: Peter Collingbourne N: Peter Collingbourne
E: peter@pcc.me.uk E: peter@pcc.me.uk
D: CFI, SafeStack D: CFI, SafeStack
N: Lang Hames N: Lang Hames
E: lhames@gmail.com E: lhames@gmail.com
D: ORC D: ORC
N: Petr Hosek N: Petr Hosek
E: phosek@google.com E: phosek@google.com
D: CRT, CMake build D: CRT, CMake build
N: Teresa Johnson N: Teresa Johnson
E: tejohnson@google.com E: tejohnson@google.com
D: MemProf D: MemProf
N: Kostya Kortchinsky
E: kostya.kortchinsky@gmail.com
D: SCUDO
N: Mitch Phillips N: Mitch Phillips
E: mitchp@google.com E: mitchp@google.com
D: GWP ASAN D: GWP ASAN
N: Alexander Potapenko N: Alexander Potapenko
E: glider@google.com E: glider@google.com
D: Sanitizers D: Sanitizers
N: Kostya Serebryany N: Kostya Serebryany
E: kcc@google.com E: kcc@google.com
D: AddressSanitizer, sanitizer_common, LeakSanitizer, LibFuzzer D: AddressSanitizer, sanitizer_common, LeakSanitizer, LibFuzzer
N: Richard Smith N: Richard Smith
E: richard-llvm@metafoo.co.uk E: richard-llvm@metafoo.co.uk
D: UndefinedBehaviorSanitizer D: UndefinedBehaviorSanitizer
N: Evgeniy Stepanov N: Evgeniy Stepanov
E: eugenis@google.com E: eugenis@google.com
D: MemorySanitizer, Android port of sanitizers D: MemorySanitizer, Android port of sanitizers
N: Dmitry Vyukov N: Dmitry Vyukov
E: dvyukov@google.com E: dvyukov@google.com
D: ThreadSanitizer D: ThreadSanitizer
N: Bill Wendling N: Bill Wendling
voidUnsubmitted
Not Done
ReplyInline Actions

???

void: ???
vitalybukaAuthorUnsubmitted
Done
ReplyInline Actions

I don't have good idea who should be Profile OWNER
There was https://reviews.llvm.org/D135617#inline-1307547
If it's wrong I will undo this part.

vitalybuka: I don't have good idea who should be Profile OWNER There was https://reviews.llvm.
voidUnsubmitted
Not Done
ReplyInline Actions

I guess it's okay...

void: I guess it's okay...
E: isanbard@gmail.com E: isanbard@gmail.com
D: Profile runtime library D: Profile runtime library