Page MenuHomePhabricator

lhames (Lang Hames)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2013, 2:34 PM (338 w, 1 d)

Recent Activity

Today

lhames committed rG7371fb422900: [ORC] Remove query dependencies when symbols are resolved. (authored by lhames).
[ORC] Remove query dependencies when symbols are resolved.
Fri, Aug 23, 1:41 PM
lhames committed rGe00585c77ca6: [ORC] Fix a FIXME: Propagate errors to dependencies. (authored by lhames).
[ORC] Fix a FIXME: Propagate errors to dependencies.
Fri, Aug 23, 1:40 PM
lhames committed rGa47d622240b1: [ORC] Fix an incorrect comment. (authored by lhames).
[ORC] Fix an incorrect comment.
Fri, Aug 23, 1:40 PM
lhames committed rL369809: [ORC] Remove query dependencies when symbols are resolved..
[ORC] Remove query dependencies when symbols are resolved.
Fri, Aug 23, 1:40 PM
lhames committed rL369808: [ORC] Fix a FIXME: Propagate errors to dependencies..
[ORC] Fix a FIXME: Propagate errors to dependencies.
Fri, Aug 23, 1:40 PM
lhames committed rL369807: [ORC] Fix an incorrect comment..
[ORC] Fix an incorrect comment.
Fri, Aug 23, 1:40 PM

Tue, Aug 20

lhames accepted D66159: [Object] Add tapi files to object.

Looks good to me too. :)

Tue, Aug 20, 10:47 AM · Restricted Project

Mon, Aug 19

lhames accepted D66440: [ORC] fix use-after-free detected by -Wreturn-stack-address.

LGTM. Nice catch!

Mon, Aug 19, 2:55 PM · Restricted Project
lhames added inline comments to D66399: [ORCv2] - New Speculate Query Implementation.
Mon, Aug 19, 2:29 PM · Restricted Project, Restricted Project

Sun, Aug 18

lhames committed rGcf276ba82e81: [ORC] Make sure we linker-mangle symbol names in the SpeculationLayer. (authored by lhames).
[ORC] Make sure we linker-mangle symbol names in the SpeculationLayer.
Sun, Aug 18, 2:31 PM
lhames committed rL369219: [ORC] Make sure we linker-mangle symbol names in the SpeculationLayer..
[ORC] Make sure we linker-mangle symbol names in the SpeculationLayer.
Sun, Aug 18, 2:29 PM
lhames committed rGa264b6074a4f: [ORC] Remove some dead code. (authored by lhames).
[ORC] Remove some dead code.
Sun, Aug 18, 2:23 PM
lhames committed rL369218: [ORC] Remove some dead code..
[ORC] Remove some dead code.
Sun, Aug 18, 2:21 PM

Fri, Aug 16

lhames committed rG8e2837e549db: [ORC] Re-introduce self-dependence accidentally dropped from a unit test. (authored by lhames).
[ORC] Re-introduce self-dependence accidentally dropped from a unit test.
Fri, Aug 16, 4:23 PM
lhames committed rL369171: [ORC] Re-introduce self-dependence accidentally dropped from a unit test..
[ORC] Re-introduce self-dependence accidentally dropped from a unit test.
Fri, Aug 16, 4:23 PM
lhames committed rG9bb9a0c10b21: [ORC] Remove some stray debugging output accidentally left in r368707 (authored by lhames).
[ORC] Remove some stray debugging output accidentally left in r368707
Fri, Aug 16, 12:35 PM
lhames committed rL369141: [ORC] Remove some stray debugging output accidentally left in r368707.
[ORC] Remove some stray debugging output accidentally left in r368707
Fri, Aug 16, 12:32 PM

Tue, Aug 13

lhames committed rG810b574d772a: [ORC] Fix SpeculativeJIT example code broken by r368707. (authored by lhames).
[ORC] Fix SpeculativeJIT example code broken by r368707.
Tue, Aug 13, 3:48 PM
lhames committed rL368764: [ORC] Fix SpeculativeJIT example code broken by r368707..
[ORC] Fix SpeculativeJIT example code broken by r368707.
Tue, Aug 13, 3:43 PM
lhames committed rG0fed4945d905: [ORC] Fix BuildingAJIT tutorial code broken by r368707. (authored by lhames).
[ORC] Fix BuildingAJIT tutorial code broken by r368707.
Tue, Aug 13, 12:41 PM
lhames committed rL368740: [ORC] Fix BuildingAJIT tutorial code broken by r368707..
[ORC] Fix BuildingAJIT tutorial code broken by r368707.
Tue, Aug 13, 12:38 PM
lhames committed rG52a34a78d9af: [ORC] Refactor definition-generation, add a generator for static libraries. (authored by lhames).
[ORC] Refactor definition-generation, add a generator for static libraries.
Tue, Aug 13, 9:08 AM
lhames committed rL368707: [ORC] Refactor definition-generation, add a generator for static libraries..
[ORC] Refactor definition-generation, add a generator for static libraries.
Tue, Aug 13, 9:05 AM

Thu, Aug 8

lhames accepted D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit.

LGTM.

Thu, Aug 8, 10:42 AM · Restricted Project, Restricted Project

Tue, Aug 6

lhames added a comment to D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create..

I think the right line is:

Tue, Aug 6, 2:54 PM · Restricted Project, Restricted Project

Mon, Aug 5

lhames committed rG1707735fa479: [ORC] Work around broken GCC/libstdc++ by adding an explicit conversion. (authored by lhames).
[ORC] Work around broken GCC/libstdc++ by adding an explicit conversion.
Mon, Aug 5, 1:31 PM
lhames committed rL367921: [ORC] Work around broken GCC/libstdc++ by adding an explicit conversion..
[ORC] Work around broken GCC/libstdc++ by adding an explicit conversion.
Mon, Aug 5, 1:30 PM
lhames accepted D65760: [ORC] Add host CPU name and sub-target features to JITTargetMachineBuilder::detectHost().

Looks good to me. Thanks Diego!

Mon, Aug 5, 12:57 PM · Restricted Project

Sat, Aug 3

lhames committed rGfe3749920703: [JITLink] Fix an overly-wide read in the MachO/x86-64 test case. (authored by lhames).
[JITLink] Fix an overly-wide read in the MachO/x86-64 test case.
Sat, Aug 3, 3:39 PM
lhames committed rL367767: [JITLink] Fix an overly-wide read in the MachO/x86-64 test case..
[JITLink] Fix an overly-wide read in the MachO/x86-64 test case.
Sat, Aug 3, 3:37 PM
lhames committed rG3daccaac8a6b: [JITLink] Add support for MachO/x86-64 UNSIGNED relocs with length=2. (authored by lhames).
[JITLink] Add support for MachO/x86-64 UNSIGNED relocs with length=2.
Sat, Aug 3, 1:18 PM
lhames committed rGb31229af4f4a: [JITLink] Fix error message formatting. (authored by lhames).
[JITLink] Fix error message formatting.
Sat, Aug 3, 1:18 PM
lhames committed rL367764: [JITLink] Add support for MachO/x86-64 UNSIGNED relocs with length=2..
[JITLink] Add support for MachO/x86-64 UNSIGNED relocs with length=2.
Sat, Aug 3, 1:16 PM
lhames committed rL367763: [JITLink] Fix error message formatting..
[JITLink] Fix error message formatting.
Sat, Aug 3, 1:16 PM

Fri, Aug 2

lhames committed rG38136d3b9687: [ORC] Remove some old debugging output from a unit test. (authored by lhames).
[ORC] Remove some old debugging output from a unit test.
Fri, Aug 2, 6:35 PM
lhames committed rL367742: [ORC] Remove some old debugging output from a unit test..
[ORC] Remove some old debugging output from a unit test.
Fri, Aug 2, 6:32 PM
lhames committed rG10430f417434: [ORC] Remove a dead method. (authored by lhames).
[ORC] Remove a dead method.
Fri, Aug 2, 1:10 PM
lhames committed rL367716: [ORC] Remove a dead method..
[ORC] Remove a dead method.
Fri, Aug 2, 1:10 PM
lhames added a comment to D65590: Make name resolution in ORC skip extra symbols.

Hi Sasha,

Fri, Aug 2, 12:46 PM · Restricted Project
lhames committed rGcb391279b41b: [ORC] Turn on symbol-flags overrides for LLJIT on Windows by default. (authored by lhames).
[ORC] Turn on symbol-flags overrides for LLJIT on Windows by default.
Fri, Aug 2, 12:44 PM
lhames committed rL367712: [ORC] Turn on symbol-flags overrides for LLJIT on Windows by default..
[ORC] Turn on symbol-flags overrides for LLJIT on Windows by default.
Fri, Aug 2, 12:44 PM
lhames committed rG809e9d1efa2f: [ORC] Change the locking scheme for ThreadSafeModule. (authored by lhames).
[ORC] Change the locking scheme for ThreadSafeModule.
Fri, Aug 2, 8:22 AM
lhames committed rL367686: [ORC] Change the locking scheme for ThreadSafeModule..
[ORC] Change the locking scheme for ThreadSafeModule.
Fri, Aug 2, 8:21 AM

Thu, Aug 1

lhames added a comment to D65548: Make JITDylib ignore Exported flag.

Hi Sasha,

Thu, Aug 1, 11:43 AM · Restricted Project

Wed, Jul 31

lhames committed rG001a5545142d: [docs] Add references to unreferenced footnotes. (authored by lhames).
[docs] Add references to unreferenced footnotes.
Wed, Jul 31, 11:10 AM
lhames committed rL367458: [docs] Add references to unreferenced footnotes..
[docs] Add references to unreferenced footnotes.
Wed, Jul 31, 11:10 AM
lhames accepted D63378: [ORC] WIP Speculative compilation.

Minor style nits aside, this looks great. Once you've addressed them (and run clang-format over the patch) feel free to commit this to the mainline and continue development there. :)

Wed, Jul 31, 10:44 AM · Restricted Project, Restricted Project

Jul 18 2019

lhames committed rGbcccd04b7a40: Update the SimpleJIT class in the clang-interpreter example to use ORCv2. (authored by lhames).
Update the SimpleJIT class in the clang-interpreter example to use ORCv2.
Jul 18 2019, 3:48 PM
lhames committed rL366511: Update the SimpleJIT class in the clang-interpreter example to use ORCv2..
Update the SimpleJIT class in the clang-interpreter example to use ORCv2.
Jul 18 2019, 3:47 PM
lhames committed rG9e52d0576ab7: [ORC] Suppress an ORCv1 deprecation warning. (authored by lhames).
[ORC] Suppress an ORCv1 deprecation warning.
Jul 18 2019, 12:59 PM
lhames committed rL366485: [ORC] Suppress an ORCv1 deprecation warning..
[ORC] Suppress an ORCv1 deprecation warning.
Jul 18 2019, 12:56 PM

Jul 17 2019

lhames committed rG1716454027db: [ORC] Add deprecation warnings to ORCv1 layers and utilities. (authored by lhames).
[ORC] Add deprecation warnings to ORCv1 layers and utilities.
Jul 17 2019, 9:42 AM
lhames committed rL366344: [ORC] Add deprecation warnings to ORCv1 layers and utilities..
[ORC] Add deprecation warnings to ORCv1 layers and utilities.
Jul 17 2019, 9:40 AM
lhames closed D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities..
Jul 17 2019, 9:40 AM · Restricted Project

Jul 16 2019

lhames added a comment to D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities..

I’m going to land this. There may be fallout to example programs and other LLVM projects and want to try to shake that out before the 9.0 branch gets cut.

Jul 16 2019, 4:59 PM · Restricted Project
lhames updated the diff for D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities..
  • [ORC] Add a deprecation note to the lli -jit-kind=orc-mcjit option.
Jul 16 2019, 4:54 PM · Restricted Project
lhames added a comment to D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities..
Jul 16 2019, 4:53 PM · Restricted Project
lhames committed rGc23619b0c900: [ORC][docs] Fix an RST error: the code-block directive needs a newline after it. (authored by lhames).
[ORC][docs] Fix an RST error: the code-block directive needs a newline after it.
Jul 16 2019, 2:44 PM
lhames committed rL366270: [ORC][docs] Fix an RST error: the code-block directive needs a newline after it..
[ORC][docs] Fix an RST error: the code-block directive needs a newline after it.
Jul 16 2019, 2:43 PM
lhames committed rG607cd44bdc6a: [ORC][docs] Trim ORCv1 to ORCv2 transition section, add a how-to section. (authored by lhames).
[ORC][docs] Trim ORCv1 to ORCv2 transition section, add a how-to section.
Jul 16 2019, 2:37 PM
lhames committed rL366269: [ORC][docs] Trim ORCv1 to ORCv2 transition section, add a how-to section..
[ORC][docs] Trim ORCv1 to ORCv2 transition section, add a how-to section.
Jul 16 2019, 2:37 PM

Jul 15 2019

lhames committed rG853813293ace: [clang-fuzzer] Remove 'setUseOrcMCJITReplacement(false)' call. (authored by lhames).
[clang-fuzzer] Remove 'setUseOrcMCJITReplacement(false)' call.
Jul 15 2019, 3:30 PM
lhames committed rL366141: [clang-fuzzer] Remove 'setUseOrcMCJITReplacement(false)' call..
[clang-fuzzer] Remove 'setUseOrcMCJITReplacement(false)' call.
Jul 15 2019, 3:27 PM
lhames updated the diff for D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities..
  • [ORC] Add deprecation warning for OrcMCJITReplacement
Jul 15 2019, 2:37 PM · Restricted Project
lhames added a comment to D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities..

... ORCv1 should be deprecated sooner rather than later. Though, a decision for the scope proposed here should come with a plan for OrcMCJITReplacement.

Jul 15 2019, 1:14 PM · Restricted Project
lhames committed rGa13cca41c5ce: [ORC] Start adding ORCv1 to ORCv2 transition tips to the ORCv2 doc. (authored by lhames).
[ORC] Start adding ORCv1 to ORCv2 transition tips to the ORCv2 doc.
Jul 15 2019, 8:40 AM
lhames committed rL366075: [ORC] Start adding ORCv1 to ORCv2 transition tips to the ORCv2 doc..
[ORC] Start adding ORCv1 to ORCv2 transition tips to the ORCv2 doc.
Jul 15 2019, 8:36 AM

Jul 11 2019

lhames added a comment to D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities..

This is the fist time I’ve used the deprecation attribute, so I’ve just taken a stab at maintaining sanity here. To keep the tree building cleanly, since we still have tests and internal utilities using these classes, I have added the attribute to the constructors of classes being removed, and added new, non-warning constructors alongside, distinguished by a dummy argument at the start of the list. Adding ‘AcknowledgeORCv1Deprecation’ to the start of any call to a deprecated constructor thus removes the warning.

Jul 11 2019, 6:19 PM · Restricted Project
lhames created D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities..
Jul 11 2019, 5:58 PM · Restricted Project

Jul 10 2019

lhames committed rG843f198a83d8: [ORC] Add custom IR compiler configuration to LLJITBuilder to enable obj caches. (authored by lhames).
[ORC] Add custom IR compiler configuration to LLJITBuilder to enable obj caches.
Jul 10 2019, 10:25 AM
lhames committed rL365671: [ORC] Add custom IR compiler configuration to LLJITBuilder to enable obj caches..
[ORC] Add custom IR compiler configuration to LLJITBuilder to enable obj caches.
Jul 10 2019, 10:24 AM

Jul 9 2019

lhames added a comment to D63378: [ORC] WIP Speculative compilation.

This is looking good. I think it would be nice to have an example QueryAnalysis implementation to demonstrate how that is supposed to work.

Jul 9 2019, 12:05 PM · Restricted Project, Restricted Project
lhames accepted D63377: [ORC] Avoid Race in Assertions .

Tentatively LGTM. Was this is generating a TSan error, or a crash? I would expect this to pass TSan, so writing a test case is probably not practical.

Jul 9 2019, 11:17 AM · Restricted Project

Jul 8 2019

lhames added a comment to D63378: [ORC] WIP Speculative compilation.

Hi Praveen,

Jul 8 2019, 10:06 PM · Restricted Project, Restricted Project

Jul 7 2019

lhames closed D62120: [ORC] fix unreachable code bug.

Committed in r361199.

Jul 7 2019, 7:08 PM · Restricted Project
lhames accepted D62120: [ORC] fix unreachable code bug.

Wouldn't just deleting L142 from the existing sources be simpler? (or moving L146-148 into the for loop at the end (L142)?

Jul 7 2019, 7:08 PM · Restricted Project

Jul 3 2019

lhames committed rGf5a885fddd63: [JITLink][ORC] Add EHFrameRegistrar interface, use in EHFrameRegistrationPlugin. (authored by lhames).
[JITLink][ORC] Add EHFrameRegistrar interface, use in EHFrameRegistrationPlugin.
Jul 3 2019, 5:09 PM
lhames committed rL365098: [JITLink][ORC] Add EHFrameRegistrar interface, use in EHFrameRegistrationPlugin..
[JITLink][ORC] Add EHFrameRegistrar interface, use in EHFrameRegistrationPlugin.
Jul 3 2019, 5:08 PM

Jul 2 2019

lhames committed rGdbc86d20cbab: [lli] Fix a typo in a header. (authored by lhames).
[lli] Fix a typo in a header.
Jul 2 2019, 11:41 AM
lhames committed rL364956: [lli] Fix a typo in a header..
[lli] Fix a typo in a header.
Jul 2 2019, 11:40 AM

Jun 28 2019

lhames committed rG62a627ae781e: Re-apply r364600 with fixes. (authored by lhames).
Re-apply r364600 with fixes.
Jun 28 2019, 11:38 AM
lhames committed rL364672: Re-apply r364600 with fixes..
Re-apply r364600 with fixes.
Jun 28 2019, 11:37 AM

Jun 27 2019

lhames committed rGc29abb50f29d: Revert "[JITLink][MachO/x86-64] Add a testcase for X86_64_RELOC_GOT." (authored by lhames).
Revert "[JITLink][MachO/x86-64] Add a testcase for X86_64_RELOC_GOT."
Jun 27 2019, 4:04 PM
lhames committed rL364606: Revert "[JITLink][MachO/x86-64] Add a testcase for X86_64_RELOC_GOT.".
Revert "[JITLink][MachO/x86-64] Add a testcase for X86_64_RELOC_GOT."
Jun 27 2019, 4:00 PM
lhames committed rG4a8dc6153464: [JITLink][MachO/x86-64] Add a testcase for X86_64_RELOC_GOT. (authored by lhames).
[JITLink][MachO/x86-64] Add a testcase for X86_64_RELOC_GOT.
Jun 27 2019, 2:52 PM
lhames committed rL364598: [JITLink][MachO/x86-64] Add a testcase for X86_64_RELOC_GOT..
[JITLink][MachO/x86-64] Add a testcase for X86_64_RELOC_GOT.
Jun 27 2019, 2:51 PM

Jun 26 2019

lhames accepted D63518: BitStream reader: propagate errors.

Indeed! That's a pretty terrifying thing... but I'm not signing up to address *that* particular issue :)

Jun 26 2019, 9:16 AM · Restricted Project, Restricted Project

Jun 25 2019

lhames added a comment to D63518: BitStream reader: propagate errors.

I haven't had a chance to audit the whole patch yet, but in general the error suppression idioms are unsafe (though maybe no more so than the existing code?).

Jun 25 2019, 3:03 PM · Restricted Project, Restricted Project

Jun 15 2019

lhames added inline comments to D63378: [ORC] WIP Speculative compilation.
Jun 15 2019, 10:24 AM · Restricted Project, Restricted Project
lhames added a comment to D63378: [ORC] WIP Speculative compilation.

This is an excellent start!

Jun 15 2019, 10:15 AM · Restricted Project, Restricted Project

Jun 14 2019

lhames committed rG1b091540d28e: [JITLink] Move JITLinkMemoryManager into its own header. (authored by lhames).
[JITLink] Move JITLinkMemoryManager into its own header.
Jun 14 2019, 12:39 PM
lhames committed rL363444: [JITLink] Move JITLinkMemoryManager into its own header..
[JITLink] Move JITLinkMemoryManager into its own header.
Jun 14 2019, 12:38 PM

Jun 13 2019

lhames committed rG2f8c6f93626e: [ORC] Rename MaterializationResponsibility resolve and emit methods to… (authored by lhames).
[ORC] Rename MaterializationResponsibility resolve and emit methods to…
Jun 13 2019, 1:09 PM
lhames committed rL363322: [ORC] Rename MaterializationResponsibility resolve and emit methods to.
[ORC] Rename MaterializationResponsibility resolve and emit methods to
Jun 13 2019, 1:09 PM
lhames accepted D62491: Updating Kaleidoscope tutorial to Synchronize with ORC v2 APIs.

This looks good to me. Thanks Praveen!

Jun 13 2019, 8:00 AM · Restricted Project

Jun 7 2019

lhames committed rGd4a8089f035a: [ORC] Update symbol lookup to use a single callback with a required symbol… (authored by lhames).
[ORC] Update symbol lookup to use a single callback with a required symbol…
Jun 7 2019, 12:32 PM
lhames committed rL362832: [ORC] Update symbol lookup to use a single callback with a required symbol state.
[ORC] Update symbol lookup to use a single callback with a required symbol state
Jun 7 2019, 12:30 PM

Jun 3 2019

lhames committed rG357e8a390ca9: [ORC] Use uint8_t for bitfields in SymbolTableEntry. (authored by lhames).
[ORC] Use uint8_t for bitfields in SymbolTableEntry.
Jun 3 2019, 3:01 PM
lhames committed rL362450: [ORC] Use uint8_t for bitfields in SymbolTableEntry..
[ORC] Use uint8_t for bitfields in SymbolTableEntry.
Jun 3 2019, 3:00 PM

May 30 2019

lhames committed rGa100042b27f6: [RuntimeDyld] Update reserveAllocationSpace to account for stub padding. (authored by lhames).
[RuntimeDyld] Update reserveAllocationSpace to account for stub padding.
May 30 2019, 1:56 PM