- User Since
- Feb 27 2013, 2:34 PM (302 w, 5 d)
Tue, Dec 11
Thu, Dec 6
Apart from these specific comments, my general thought is that this is fine as far as it goes, but as it grows more fully featured it seems likely to start overlapping more libObject and MC functionality.
Committed in r348223.
Tue, Dec 4
Swinging back around to this, as I have a concrete use-case now (allowing JIT clients to query MaterializationUnit types when deciding how to dispatch compiler invocations in the JIT).
Updated to add documentation, comments.
Mon, Dec 3
Wed, Nov 28
Oops. Those comments were for and old diff. The no-op sorts are gone, but the other three still apply.
Tue, Nov 27
Nitpicks aside, the mach-o side of this looks good to me. :)
Mon, Nov 19
LGTM. Committed as r347281. Thanks Eugene!
Nov 13 2018
Updates the PerfJITEventListener API and fixes a comment that referred to the old API.
Nov 12 2018
Oct 31 2018
Oct 30 2018
Oct 26 2018
- [ExecutionEngine] Rename/format JITEventListener methods.
Thanks everyone! Committed in r345411.
Oct 25 2018
- Fix a missing &&
- Add non templated constructors for DenseMap, clarify clang version in comment.
Oops -- forgot to clang-format this. Will do so before applying if it is accepted though.
Oct 24 2018
Oct 23 2018
Oct 22 2018
Committed in r344995. Thanks again Andrew!
Oct 20 2018
Oct 18 2018
Oct 17 2018
Oct 16 2018
Oct 15 2018
Committed as r344542.
Use PowerOf2Ceil as per Craig's suggestion, and validate set contents in the non power-of-two length initializer list unit test as per Dave's suggestion.
Committed in r344522.
Oct 14 2018
Updated to remove the dependence on stable iteration order for operator== (on both DenseMap and DenseSet). Also adds some comments on performance.
Broke out https://reviews.llvm.org/D53260 for the DenseSet bug fix.
Oct 13 2018
I do not think this landed in the end (it does not look like it). It may be able to be rewritten more naturally now that LLJIT has native support for multiple threads. Also ThreadSafeModule and ThreadSafeContext will help with the context management issues.
I think the changes in r343122 provide a superset of this functionality, so this can be closed.