Page MenuHomePhabricator
People lhames

lhames (Lang Hames)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2013, 2:34 PM (302 w, 5 d)

Recent Activity
View All

Tue, Dec 11

lhames added a comment to D39111: Extensible LLVM RTTI.

Gentle ping.

Tue, Dec 11, 6:14 PM

Thu, Dec 6

lhames added a comment to D54674: [llvm-objcopy] First bits for MachO .

Apart from these specific comments, my general thought is that this is fine as far as it goes, but as it grows more fully featured it seems likely to start overlapping more libObject and MC functionality.

Thu, Dec 6, 8:46 PM
lhames closed D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..

Committed in r348223.

Thu, Dec 6, 6:14 PM

Tue, Dec 4

lhames added a comment to D39111: Extensible LLVM RTTI.

Swinging back around to this, as I have a concrete use-case now (allowing JIT clients to query MaterializationUnit types when deciding how to dispatch compiler invocations in the JIT).

Tue, Dec 4, 7:25 PM
lhames updated the diff for D39111: Extensible LLVM RTTI.

Updated to add documentation, comments.

Tue, Dec 4, 7:17 PM

Mon, Dec 3

lhames committed rL348223: [ExecutionEngine] Change NotifyObjectEmitted/NotifyObjectFreed API..
[ExecutionEngine] Change NotifyObjectEmitted/NotifyObjectFreed API.
Mon, Dec 3, 4:58 PM

Wed, Nov 28

lhames accepted D53945: [TextAPI] TBD Reader/Writer.

Looks good to me. :)

Wed, Nov 28, 1:06 PM
lhames added a comment to D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..

Gentle ping.

Wed, Nov 28, 12:09 PM
lhames added a comment to D53945: [TextAPI] TBD Reader/Writer.

Oops. Those comments were for and old diff. The no-op sorts are gone, but the other three still apply.

Wed, Nov 28, 9:40 AM

Tue, Nov 27

lhames added a comment to D53945: [TextAPI] TBD Reader/Writer.

Nitpicks aside, the mach-o side of this looks good to me. :)

Tue, Nov 27, 4:55 PM

Mon, Nov 19

lhames committed rL347281: [ExecutionEngine][Interpreter] Fix out-of-bounds array access..
[ExecutionEngine][Interpreter] Fix out-of-bounds array access.
Mon, Nov 19, 5:05 PM
lhames closed D53556: [Interpreter] Fix out-of-bounds access in ffiInvoke.
Mon, Nov 19, 5:04 PM
lhames accepted D53556: [Interpreter] Fix out-of-bounds access in ffiInvoke.

LGTM. Committed as r347281. Thanks Eugene!

Mon, Nov 19, 5:04 PM

Nov 13 2018

lhames updated the diff for D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..

Updates the PerfJITEventListener API and fixes a comment that referred to the old API.

Nov 13 2018, 3:24 PM

Nov 12 2018

lhames committed rL346727: [BuildingAJIT] Clang-format chapters 1 and 2..
[BuildingAJIT] Clang-format chapters 1 and 2.
Nov 12 2018, 5:28 PM
lhames committed rL346726: [BuildingAJIT] Update chapter 2 to use the ORCv2 APIs..
[BuildingAJIT] Update chapter 2 to use the ORCv2 APIs.
Nov 12 2018, 5:28 PM

Oct 31 2018

lhames added a comment to D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..
In D53773#1280967, @anarazel wrote:

This looks like a sensible improvement. There's probably not many implementors of the interface, so the renaming shouldn't cause much pain.

I noticed however that you didn't update ExecutionEngine/PerfJITEvents/PerfJITEventListener.cpp?

Oct 31 2018, 4:41 PM
lhames added a reviewer for D53815: [TableGen] Better error checking for TIED_TO constraints.: MatzeB.
Oct 31 2018, 8:31 AM

Oct 30 2018

lhames committed rL345696: [ORC] Fix hex printing of uint64_t values..
[ORC] Fix hex printing of uint64_t values.
Oct 30 2018, 10:19 PM

Oct 26 2018

lhames updated the diff for D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..
  • [ExecutionEngine] Rename/format JITEventListener methods.
Oct 26 2018, 9:36 PM
lhames created D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..
Oct 26 2018, 12:01 PM
lhames closed D53726: [ADT] Work around a bug in older compiler versions..
Oct 26 2018, 11:55 AM
lhames accepted D53726: [ADT] Work around a bug in older compiler versions..

Thanks everyone! Committed in r345411.

Oct 26 2018, 11:55 AM
lhames committed rL345411: [ADT] Use explicit constructors for DenseMapPair to work around compiler issues..
[ADT] Use explicit constructors for DenseMapPair to work around compiler issues.
Oct 26 2018, 10:52 AM

Oct 25 2018

lhames updated the diff for D53726: [ADT] Work around a bug in older compiler versions..
  • Fix a missing &&
Oct 25 2018, 2:24 PM
lhames added a comment to D53726: [ADT] Work around a bug in older compiler versions..
In D53726#1276405, @dblaikie wrote:

Patch description doesn't seem to immediately relate to the change - nor test cases demonstrating the connection?

Oct 25 2018, 2:14 PM
lhames retitled D53726: [ADT] Work around a bug in older compiler versions. from [ADT] Add initializer_list constructor, equality tests for DenseMap/DenseSet. to [ADT] Work around a bug in older compiler versions..
Oct 25 2018, 2:14 PM
lhames updated the diff for D53726: [ADT] Work around a bug in older compiler versions..
  • Add non templated constructors for DenseMap, clarify clang version in comment.
  • clang-format
Oct 25 2018, 2:09 PM
lhames added a comment to D53726: [ADT] Work around a bug in older compiler versions..

Oops -- forgot to clang-format this. Will do so before applying if it is accepted though.

Oct 25 2018, 12:46 PM
lhames created D53726: [ADT] Work around a bug in older compiler versions..
Oct 25 2018, 12:43 PM

Oct 24 2018

lhames committed rL345195: [ExecutionEngine] Remove some dead code from JITEventListener.h..
[ExecutionEngine] Remove some dead code from JITEventListener.h.
Oct 24 2018, 1:41 PM

Oct 23 2018

lhames committed rL345098: [ORC] Re-apply r345077 with fixes to remove ambiguity in lookup calls..
[ORC] Re-apply r345077 with fixes to remove ambiguity in lookup calls.
Oct 23 2018, 4:03 PM
lhames committed rL345077: [ORC] Change how non-exported symbols are matched during lookup..
[ORC] Change how non-exported symbols are matched during lookup.
Oct 23 2018, 1:22 PM

Oct 22 2018

lhames closed D51343: Fix RuntimeDyldCOFFX86_64 handling of image-relative relocations when there are not loaded sections.

Committed in r344995. Thanks again Andrew!

Oct 22 2018, 7:56 PM
lhames committed rL344995: [RuntimeDyld][COFF] Skip non-loaded sections when calculating ImageBase..
[RuntimeDyld][COFF] Skip non-loaded sections when calculating ImageBase.
Oct 22 2018, 6:39 PM
lhames committed rL344994: [ORC] Show JITDylib search order in JITDylib::dump..
[ORC] Show JITDylib search order in JITDylib::dump.
Oct 22 2018, 6:39 PM
lhames committed rL344993: [ORC] Dump flags for JITDylib symbol table entries..
[ORC] Dump flags for JITDylib symbol table entries.
Oct 22 2018, 6:38 PM
lhames committed rL344956: [ORC] Guard access to the MemMgrs vector in RTDyldObjectLinkingLayer..
[ORC] Guard access to the MemMgrs vector in RTDyldObjectLinkingLayer.
Oct 22 2018, 2:21 PM

Oct 20 2018

lhames committed rL344863: [ORC] Add some more basic sanity tests for the LLJIT..
[ORC] Add some more basic sanity tests for the LLJIT.
Oct 20 2018, 1:42 PM

Oct 18 2018

lhames committed rL344763: [ORC] Add a createJITDylib method to LLJIT..
[ORC] Add a createJITDylib method to LLJIT.
Oct 18 2018, 3:44 PM

Oct 17 2018

lhames committed rL344720: [BuildingAJIT] Update the Ch1 KaleidoscopeJIT class to expose errors to clients..
[BuildingAJIT] Update the Ch1 KaleidoscopeJIT class to expose errors to clients.
Oct 17 2018, 5:53 PM
lhames committed rL344712: [BuildingAJIT] Simplify a tutorial example and fix a syntax error..
[BuildingAJIT] Simplify a tutorial example and fix a syntax error.
Oct 17 2018, 3:30 PM
lhames committed rL344705: [BuildingAJIT] Fix a function signature in the documentation..
[BuildingAJIT] Fix a function signature in the documentation.
Oct 17 2018, 12:37 PM

Oct 16 2018

lhames committed rL344667: [BuildingAJIT] Update chapter 1 to use the ORCv2 APIs..
[BuildingAJIT] Update chapter 1 to use the ORCv2 APIs.
Oct 16 2018, 8:36 PM
lhames committed rL344643: [ORC] Make the VModuleKey optional, propagate it via MaterializationUnit and.
[ORC] Make the VModuleKey optional, propagate it via MaterializationUnit and
Oct 16 2018, 1:15 PM

Oct 15 2018

lhames added a comment to D51343: Fix RuntimeDyldCOFFX86_64 handling of image-relative relocations when there are not loaded sections.

Hi Andrew,

Oct 15 2018, 5:28 PM
lhames committed rL344572: [ORC] Rename ORC layers to make the "new" ORC layers the default..
[ORC] Rename ORC layers to make the "new" ORC layers the default.
Oct 15 2018, 3:58 PM
lhames committed rL344567: [ORC] Rename MultiThreadedSimpleCompiler to ConcurrentIRCompiler..
[ORC] Rename MultiThreadedSimpleCompiler to ConcurrentIRCompiler.
Oct 15 2018, 3:38 PM
lhames committed rL344566: Change a TerminatorInst* to an Instruction* in HotColdSplitting.cpp..
Change a TerminatorInst* to an Instruction* in HotColdSplitting.cpp.
Oct 15 2018, 3:29 PM
lhames committed rL344565: [ORC] Switch to DenseMap/DenseSet for ORC symbol map/set types..
[ORC] Switch to DenseMap/DenseSet for ORC symbol map/set types.
Oct 15 2018, 3:29 PM
lhames closed D53260: [ADT] Fix a bug in DenseSet's initializer_list constructor..

Committed as r344542.

Oct 15 2018, 11:37 AM
lhames committed rL344542: [ADT] Fix a bug in DenseSet's initializer_list constructor..
[ADT] Fix a bug in DenseSet's initializer_list constructor.
Oct 15 2018, 11:36 AM
lhames updated the diff for D53260: [ADT] Fix a bug in DenseSet's initializer_list constructor..

Use PowerOf2Ceil as per Craig's suggestion, and validate set contents in the non power-of-two length initializer list unit test as per Dave's suggestion.

Oct 15 2018, 9:11 AM
lhames added inline comments to D53260: [ADT] Fix a bug in DenseSet's initializer_list constructor..
Oct 15 2018, 8:37 AM
lhames closed D53247: [ADT] Add initializer_list constructor, equality tests for DenseMap/DenseSet..

Committed in r344522.

Oct 15 2018, 8:29 AM
lhames committed rL344522: [ADT] Adds equality operators for DenseMap and DenseSet, and an initializer_list.
[ADT] Adds equality operators for DenseMap and DenseSet, and an initializer_list
Oct 15 2018, 8:29 AM

Oct 14 2018

lhames committed rL344489: [ORC] Simplify naming for JITDylib definition generators..
[ORC] Simplify naming for JITDylib definition generators.
Oct 14 2018, 10:09 PM
lhames updated the diff for D53247: [ADT] Add initializer_list constructor, equality tests for DenseMap/DenseSet..

Updated to remove the dependence on stable iteration order for operator== (on both DenseMap and DenseSet). Also adds some comments on performance.

Oct 14 2018, 2:02 PM
lhames added a comment to D53247: [ADT] Add initializer_list constructor, equality tests for DenseMap/DenseSet..

Broke out https://reviews.llvm.org/D53260 for the DenseSet bug fix.

Oct 14 2018, 12:07 PM
lhames created D53260: [ADT] Fix a bug in DenseSet's initializer_list constructor..
Oct 14 2018, 12:07 PM
lhames added inline comments to D53247: [ADT] Add initializer_list constructor, equality tests for DenseMap/DenseSet..
Oct 14 2018, 9:27 AM
lhames committed rL344478: [ORC] Remove XXLayer::add methods that default to using the main JITDylib..
[ORC] Remove XXLayer::add methods that default to using the main JITDylib.
Oct 14 2018, 9:12 AM
lhames added inline comments to D53247: [ADT] Add initializer_list constructor, equality tests for DenseMap/DenseSet..
Oct 14 2018, 9:05 AM

Oct 13 2018

lhames added a comment to D51128: [ORC] LLJITTest: API test and usage examples with actual codegen.

I do not think this landed in the end (it does not look like it). It may be able to be rewritten more naturally now that LLJIT has native support for multiple threads. Also ThreadSafeModule and ThreadSafeContext will help with the context management issues.

Oct 13 2018, 3:53 PM
lhames created D53247: [ADT] Add initializer_list constructor, equality tests for DenseMap/DenseSet..
Oct 13 2018, 3:29 PM
lhames committed rL344467: [ORC] During lookup, do not match against hidden symbols in other JITDylibs..
[ORC] During lookup, do not match against hidden symbols in other JITDylibs.
Oct 13 2018, 2:57 PM
lhames added a comment to D51126: [ORC] LLJIT::Create() proposal: add flag to enable multithreaded codegen.

I think the changes in r343122 provide a superset of this functionality, so this can be closed.

Oct 13 2018, 12:39 PM

Oct 9 2018

lhames committed rL344078: [ORC] Promote and rename private symbols inside the CompileOnDemand layer,.
[ORC] Promote and rename private symbols inside the CompileOnDemand layer,
Oct 9 2018, 1:46 PM

Oct 6 2018

lhames committed rL343929: [ORC] Consume unhandled errors in unit test..
[ORC] Consume unhandled errors in unit test.
Oct 6 2018, 6:09 PM
lhames committed rL343928: [ORC] Add a 'remove' method to JITDylib to remove symbols..
[ORC] Add a 'remove' method to JITDylib to remove symbols.
Oct 6 2018, 4:05 PM
lhames committed rL343927: [ORC] Pass symbol name to discard by const reference..
[ORC] Pass symbol name to discard by const reference.
Oct 6 2018, 4:03 PM

Sep 30 2018

lhames committed rL343442: [ORC] Pass Symbols to ExecutionSession::lookup by value, potentially saving a.
[ORC] Pass Symbols to ExecutionSession::lookup by value, potentially saving a
Sep 30 2018, 10:00 PM
lhames committed rL343430: [ORC] Add convenience methods for creating DynamicLibraryFallbackGenerators for.
[ORC] Add convenience methods for creating DynamicLibraryFallbackGenerators for
Sep 30 2018, 6:01 PM
lhames committed rL343429: [ORC] Add a method to JITTargetMachineBuilder to get the default data layout.
[ORC] Add a method to JITTargetMachineBuilder to get the default data layout
Sep 30 2018, 6:01 PM
lhames committed rL343427: [ORC] Add an 'intern' method to ExecutionEngine for interning symbol names..
[ORC] Add an 'intern' method to ExecutionEngine for interning symbol names.
Sep 30 2018, 4:20 PM
lhames committed rL343423: [ORC] Extract and tidy up JITTargetMachineBuilder, add unit test..
[ORC] Extract and tidy up JITTargetMachineBuilder, add unit test.
Sep 30 2018, 12:14 PM

Sep 29 2018

lhames committed rL343396: [ORC] Add partitioning support to CompileOnDemandLayer2..
[ORC] Add partitioning support to CompileOnDemandLayer2.
Sep 29 2018, 4:53 PM
lhames committed rL343395: [ORC] Clear SymbolToDefinitionMap when materializing a MaterializationUnit..
[ORC] Clear SymbolToDefinitionMap when materializing a MaterializationUnit.
Sep 29 2018, 4:53 PM
lhames committed rL343394: Add a comment to clarify the contract for LLVMGetErrorMessage in the c-bindings.
Add a comment to clarify the contract for LLVMGetErrorMessage in the c-bindings
Sep 29 2018, 4:53 PM

Sep 28 2018

lhames committed rL343367: [ORC] Make MaterializationResponsibility::getRequestedSymbols() const..
[ORC] Make MaterializationResponsibility::getRequestedSymbols() const.
Sep 28 2018, 3:05 PM
lhames committed rL343365: [ORC] Add more utilities to aid debugging output..
[ORC] Add more utilities to aid debugging output.
Sep 28 2018, 2:52 PM
lhames committed rL343358: [ORC] Narrow a cast: the block guarded by the condition only handles.
[ORC] Narrow a cast: the block guarded by the condition only handles
Sep 28 2018, 1:17 PM
lhames committed rL343327: [ORC] Remove some dead code..
[ORC] Remove some dead code.
Sep 28 2018, 8:15 AM
lhames committed rL343326: [ORC] Fix the unit tests that were broken by r343323..
[ORC] Fix the unit tests that were broken by r343323.
Sep 28 2018, 8:10 AM
lhames committed rL343323: [ORC] Improve debugging output for ORC..
[ORC] Improve debugging output for ORC.
Sep 28 2018, 8:07 AM

Sep 27 2018

lhames committed rL343288: [ORC] clang-format the ThreadSafeModule code..
[ORC] clang-format the ThreadSafeModule code.
Sep 27 2018, 6:43 PM
lhames committed rL343287: [ORC] Add a const version of ThreadSafeModule::getModule()..
[ORC] Add a const version of ThreadSafeModule::getModule().
Sep 27 2018, 6:43 PM
lhames committed rL343286: [ORC] Lock ThreadSafeContext during module destruction in ThreadSafeModule's.
[ORC] Lock ThreadSafeContext during module destruction in ThreadSafeModule's
Sep 27 2018, 6:43 PM
lhames committed rL343266: [ORC] Add definition for IRLayer::setCloneToNewContextOnEmit, use it to set the.
[ORC] Add definition for IRLayer::setCloneToNewContextOnEmit, use it to set the
Sep 27 2018, 2:15 PM
lhames committed rL343262: [ORC] Make LocalIndirectStubsManager's operations thread-safe..
[ORC] Make LocalIndirectStubsManager's operations thread-safe.
Sep 27 2018, 1:38 PM
lhames committed rL343261: [ORC] Lock ThreadSafeContext during Module destructing in ThreadSafeModule..
[ORC] Lock ThreadSafeContext during Module destructing in ThreadSafeModule.
Sep 27 2018, 1:37 PM
lhames committed rL343257: [ORC] Coalesce all of ORC's symbol renaming / linkage-promotion utilities into.
[ORC] Coalesce all of ORC's symbol renaming / linkage-promotion utilities into
Sep 27 2018, 12:29 PM
lhames committed rL343256: [ORC] LastKey needs to be protected to prevent data races..
[ORC] LastKey needs to be protected to prevent data races.
Sep 27 2018, 12:29 PM
lhames committed rL343255: [lli] Fix ArgV setup bug when running in -jit-kind=orc-lazy mode..
[lli] Fix ArgV setup bug when running in -jit-kind=orc-lazy mode.
Sep 27 2018, 12:28 PM

Sep 26 2018

lhames committed rL343167: [ORC] Use ExecutionSession's pre-constructed main JITDylib in LLJIT..
[ORC] Use ExecutionSession's pre-constructed main JITDylib in LLJIT.
Sep 26 2018, 9:21 PM
lhames committed rL343162: Re-reapply r343129 with more fixes..
Re-reapply r343129 with more fixes.
Sep 26 2018, 7:11 PM
lhames committed rL343161: Revert "Re-revert r343129.".
Revert "Re-revert r343129."
Sep 26 2018, 7:11 PM
lhames committed rL343151: Re-revert r343129..
Re-revert r343129.
Sep 26 2018, 4:34 PM
lhames committed rL343149: Reapply r343129 with fix..
Reapply r343129 with fix.
Sep 26 2018, 3:36 PM
lhames committed rL343133: Revert r343129 "[ORC] Change the field order of ThreadSafeModule to ensure the ".
Revert r343129 "[ORC] Change the field order of ThreadSafeModule to ensure the "
Sep 26 2018, 12:38 PM