Page MenuHomePhabricator

lhames (Lang Hames)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2013, 2:34 PM (346 w, 4 h)

Recent Activity

Yesterday

lhames committed rGa98546ebcd2a: [Orc] Add a method for ObjectLinkingLayer to return ownership of object buffers. (authored by lhames).
[Orc] Add a method for ObjectLinkingLayer to return ownership of object buffers.
Tue, Oct 15, 2:42 PM
lhames committed rL374951: [Orc] Add a method for ObjectLinkingLayer to return ownership of object buffers..
[Orc] Add a method for ObjectLinkingLayer to return ownership of object buffers.
Tue, Oct 15, 2:42 PM
lhames committed rGc85d0aaa2a6d: [JITLink] Switch to slab allocation for InProcessMemoryManager, re-enable test. (authored by lhames).
[JITLink] Switch to slab allocation for InProcessMemoryManager, re-enable test.
Tue, Oct 15, 2:14 PM
lhames committed rL374948: [JITLink] Switch to slab allocation for InProcessMemoryManager, re-enable test..
[JITLink] Switch to slab allocation for InProcessMemoryManager, re-enable test.
Tue, Oct 15, 2:05 PM

Thu, Oct 10

lhames committed rGe5c61cee44f5: [JITLink] Disable the MachO/AArch64 testcase while investigating bot failures. (authored by lhames).
[JITLink] Disable the MachO/AArch64 testcase while investigating bot failures.
Thu, Oct 10, 7:04 PM
lhames committed rL374500: [JITLink] Disable the MachO/AArch64 testcase while investigating bot failures..
[JITLink] Disable the MachO/AArch64 testcase while investigating bot failures.
Thu, Oct 10, 6:55 PM
lhames committed rGb45359387092: [JITLink] Fix MachO/arm64 GOTPAGEOFF encoding. (authored by lhames).
[JITLink] Fix MachO/arm64 GOTPAGEOFF encoding.
Thu, Oct 10, 6:55 PM
lhames committed rL374499: [JITLink] Fix MachO/arm64 GOTPAGEOFF encoding..
[JITLink] Fix MachO/arm64 GOTPAGEOFF encoding.
Thu, Oct 10, 6:54 PM
lhames accepted D68732: Break out OrcError and RPC.

Hi Chris,

Thu, Oct 10, 4:55 PM · Restricted Project
lhames committed rG3cc04f6a41c6: [JITLink] Add an initial implementation of JITLink for MachO/AArch64. (authored by lhames).
[JITLink] Add an initial implementation of JITLink for MachO/AArch64.
Thu, Oct 10, 4:45 PM
lhames committed rG96cd736c2df4: [JITLink] Move MachO/x86 got test further down in the data section. (authored by lhames).
[JITLink] Move MachO/x86 got test further down in the data section.
Thu, Oct 10, 4:44 PM
lhames committed rL374476: [JITLink] Add an initial implementation of JITLink for MachO/AArch64..
[JITLink] Add an initial implementation of JITLink for MachO/AArch64.
Thu, Oct 10, 4:36 PM
lhames committed rL374475: [JITLink] Move MachO/x86 got test further down in the data section..
[JITLink] Move MachO/x86 got test further down in the data section.
Thu, Oct 10, 4:36 PM

Fri, Oct 4

lhames accepted D68447: [JITLink] Silence GCC warnings. NFC..

LGTM! Thanks Martin!

Fri, Oct 4, 11:22 AM · Restricted Project

Thu, Oct 3

lhames committed rG7f379a3366ca: [JITLink] Explicitly destroy bumpptr-allocated blocks to avoid a memory leak. (authored by lhames).
[JITLink] Explicitly destroy bumpptr-allocated blocks to avoid a memory leak.
Thu, Oct 3, 10:24 PM
lhames committed rG6fd9129aafdf: [JITLink] Fix an unused variable warning. (authored by lhames).
[JITLink] Fix an unused variable warning.
Thu, Oct 3, 10:24 PM
lhames committed rL373693: [JITLink] Explicitly destroy bumpptr-allocated blocks to avoid a memory leak..
[JITLink] Explicitly destroy bumpptr-allocated blocks to avoid a memory leak.
Thu, Oct 3, 10:24 PM
lhames committed rL373692: [JITLink] Fix an unused variable warning..
[JITLink] Fix an unused variable warning.
Thu, Oct 3, 10:23 PM
lhames committed rG4e920e58e6bc: [JITLink] Switch from an atom-based model to a "blocks and symbols" model. (authored by lhames).
[JITLink] Switch from an atom-based model to a "blocks and symbols" model.
Thu, Oct 3, 8:58 PM
lhames committed rL373689: [JITLink] Switch from an atom-based model to a "blocks and symbols" model..
[JITLink] Switch from an atom-based model to a "blocks and symbols" model.
Thu, Oct 3, 8:53 PM

Tue, Sep 24

lhames commandeered D65934: [ORC] FIxed warning on Windows about deprecated ORCv1.

Yep — this can be abandoned.

Tue, Sep 24, 9:50 AM · Restricted Project
lhames abandoned D65934: [ORC] FIxed warning on Windows about deprecated ORCv1.
Tue, Sep 24, 9:50 AM · Restricted Project

Wed, Sep 18

lhames committed rG366ab0d086a4: [AArch64] Don't implicitly enable global isel on Darwin if code-model==large. (authored by lhames).
[AArch64] Don't implicitly enable global isel on Darwin if code-model==large.
Wed, Sep 18, 12:56 PM
lhames committed rL372256: [AArch64] Don't implicitly enable global isel on Darwin if code-model==large..
[AArch64] Don't implicitly enable global isel on Darwin if code-model==large.
Wed, Sep 18, 12:56 PM
lhames closed D67724: [AArch64] Don't implicitly enable global isel on Darwin if code-model==large..
Wed, Sep 18, 12:56 PM · Restricted Project
lhames created D67724: [AArch64] Don't implicitly enable global isel on Darwin if code-model==large..
Wed, Sep 18, 11:40 AM · Restricted Project

Sep 12 2019

lhames accepted D67477: Add dependency from Orc to Passes.

Yep — eventually I want to break out the parts of ORC that rely on IR/Passes. This is the right thing to do for now though. Thanks Sanjoy!

Sep 12 2019, 7:57 AM · Restricted Project

Sep 11 2019

lhames accepted D67407: All Errors must be checked.

LGTM. Thanks Chris!

Sep 11 2019, 1:25 PM · Restricted Project

Sep 10 2019

lhames added a comment to D67407: All Errors must be checked.

I think you need to consume Result here instead of joining it:

Sep 10 2019, 4:16 PM · Restricted Project

Sep 6 2019

lhames committed rG88cddb7a1c17: [ORC][RPC] Join server thread before checking condition in unit test. (authored by lhames).
[ORC][RPC] Join server thread before checking condition in unit test.
Sep 6 2019, 2:55 PM
lhames committed rL371263: [ORC][RPC] Join server thread before checking condition in unit test..
[ORC][RPC] Join server thread before checking condition in unit test.
Sep 6 2019, 2:55 PM
lhames committed rG7c848acf0a86: [ORC] Add a missing #include atomic. (authored by lhames).
[ORC] Add a missing #include atomic.
Sep 6 2019, 1:50 PM
lhames committed rL371255: [ORC] Add a missing #include atomic..
[ORC] Add a missing #include atomic.
Sep 6 2019, 1:48 PM
lhames committed rGc1105111b393: [ORC] Make sure RPC channel-send is called in blocking calls and responses. (authored by lhames).
[ORC] Make sure RPC channel-send is called in blocking calls and responses.
Sep 6 2019, 12:25 PM
lhames committed rG335676ee6216: [llvm-jitlink] Add optional slab allocator for testing locality optimizations. (authored by lhames).
[llvm-jitlink] Add optional slab allocator for testing locality optimizations.
Sep 6 2019, 12:24 PM
lhames committed rL371245: [ORC] Make sure RPC channel-send is called in blocking calls and responses..
[ORC] Make sure RPC channel-send is called in blocking calls and responses.
Sep 6 2019, 12:21 PM
lhames committed rL371244: [llvm-jitlink] Add optional slab allocator for testing locality optimizations..
[llvm-jitlink] Add optional slab allocator for testing locality optimizations.
Sep 6 2019, 12:21 PM

Sep 4 2019

lhames committed rG41adc374086d: [llvm-rtdyld][llvm-jitlink] Rename struct member to remove ambiguity. (authored by lhames).
[llvm-rtdyld][llvm-jitlink] Rename struct member to remove ambiguity.
Sep 4 2019, 1:28 PM
lhames committed rG796695379327: [llvm-rtdyld] Add timers to match llvm-jitlink. (authored by lhames).
[llvm-rtdyld] Add timers to match llvm-jitlink.
Sep 4 2019, 1:28 PM
lhames committed rL370969: [llvm-rtdyld][llvm-jitlink] Rename struct member to remove ambiguity..
[llvm-rtdyld][llvm-jitlink] Rename struct member to remove ambiguity.
Sep 4 2019, 1:28 PM
lhames committed rL370968: [llvm-rtdyld] Add timers to match llvm-jitlink..
[llvm-rtdyld] Add timers to match llvm-jitlink.
Sep 4 2019, 1:28 PM
lhames committed rG200415c6dcc5: [JITLink] Fix the show-timers option on llvm-jitlink. (authored by lhames).
[JITLink] Fix the show-timers option on llvm-jitlink.
Sep 4 2019, 11:38 AM
lhames committed rGe4526330b39e: [docs] Add some comments to the inline LLJIT example. (authored by lhames).
[docs] Add some comments to the inline LLJIT example.
Sep 4 2019, 11:38 AM
lhames committed rL370951: [JITLink] Fix the show-timers option on llvm-jitlink..
[JITLink] Fix the show-timers option on llvm-jitlink.
Sep 4 2019, 11:38 AM
lhames committed rL370950: [docs] Add some comments to the inline LLJIT example..
[docs] Add some comments to the inline LLJIT example.
Sep 4 2019, 11:38 AM

Sep 3 2019

lhames committed rL370810: Request commit access for lhames.
Request commit access for lhames
Sep 3 2019, 12:22 PM

Aug 27 2019

lhames committed rL370088: [JITLink] Fix bogus TimerGroup constructor call..
[JITLink] Fix bogus TimerGroup constructor call.
Aug 27 2019, 11:25 AM
lhames committed rGfd10536a8c28: [JITLink] Fix bogus TimerGroup constructor call. (authored by lhames).
[JITLink] Fix bogus TimerGroup constructor call.
Aug 27 2019, 11:21 AM
lhames committed rL370074: [JITLink][ORC] Track eh-frame section size for registration/deregistration..
[JITLink][ORC] Track eh-frame section size for registration/deregistration.
Aug 27 2019, 9:13 AM
lhames committed rL370075: [JITLink] Add timers and -show-times option to llvm-jitlink..
[JITLink] Add timers and -show-times option to llvm-jitlink.
Aug 27 2019, 9:12 AM
lhames committed rG6fd3960066f1: [JITLink] Add timers and -show-times option to llvm-jitlink. (authored by lhames).
[JITLink] Add timers and -show-times option to llvm-jitlink.
Aug 27 2019, 9:07 AM
lhames committed rGc48f1f6da690: [JITLink][ORC] Track eh-frame section size for registration/deregistration. (authored by lhames).
[JITLink][ORC] Track eh-frame section size for registration/deregistration.
Aug 27 2019, 9:07 AM
lhames committed rL370072: [JITLink] Don't under-align zero-fill sections..
[JITLink] Don't under-align zero-fill sections.
Aug 27 2019, 8:37 AM
lhames committed rG70e158e09e9d: [JITLink] Don't under-align zero-fill sections. (authored by lhames).
[JITLink] Don't under-align zero-fill sections.
Aug 27 2019, 8:31 AM

Aug 26 2019

lhames committed rG8853ac7e022c: [ORC] Make sure that queries on emitted-but-not-ready symbols fail correctly. (authored by lhames).
[ORC] Make sure that queries on emitted-but-not-ready symbols fail correctly.
Aug 26 2019, 2:46 PM
lhames committed rG8ec96618700f: [ORC] Fix an overly aggressive assert. (authored by lhames).
[ORC] Fix an overly aggressive assert.
Aug 26 2019, 2:46 PM
lhames committed rL369976: [ORC] Make sure that queries on emitted-but-not-ready symbols fail correctly..
[ORC] Make sure that queries on emitted-but-not-ready symbols fail correctly.
Aug 26 2019, 2:46 PM
lhames committed rL369975: [ORC] Fix an overly aggressive assert..
[ORC] Fix an overly aggressive assert.
Aug 26 2019, 2:44 PM

Aug 24 2019

lhames added a comment to D66705: FileManager: Use llvm::Expected in new getFileRef API.

Updated patch after running check-clang and learning more about Expected. I've added a parallel API using Optional<FileEntryRef> for clients that don't want to do anything with the error.

@lhames, is it reasonable to add llvm::expectedToOptional?

Aug 24 2019, 4:54 PM · Restricted Project
lhames accepted D66399: [ORCv2] - New Speculate Query Implementation.

LGTM, pending else-after-return fixes.

Aug 24 2019, 10:04 AM · Restricted Project, Restricted Project

Aug 23 2019

lhames committed rG7371fb422900: [ORC] Remove query dependencies when symbols are resolved. (authored by lhames).
[ORC] Remove query dependencies when symbols are resolved.
Aug 23 2019, 1:41 PM
lhames committed rGe00585c77ca6: [ORC] Fix a FIXME: Propagate errors to dependencies. (authored by lhames).
[ORC] Fix a FIXME: Propagate errors to dependencies.
Aug 23 2019, 1:40 PM
lhames committed rGa47d622240b1: [ORC] Fix an incorrect comment. (authored by lhames).
[ORC] Fix an incorrect comment.
Aug 23 2019, 1:40 PM
lhames committed rL369809: [ORC] Remove query dependencies when symbols are resolved..
[ORC] Remove query dependencies when symbols are resolved.
Aug 23 2019, 1:40 PM
lhames committed rL369808: [ORC] Fix a FIXME: Propagate errors to dependencies..
[ORC] Fix a FIXME: Propagate errors to dependencies.
Aug 23 2019, 1:40 PM
lhames committed rL369807: [ORC] Fix an incorrect comment..
[ORC] Fix an incorrect comment.
Aug 23 2019, 1:40 PM

Aug 20 2019

lhames accepted D66159: [Object] Add tapi files to object.

Looks good to me too. :)

Aug 20 2019, 10:47 AM · Restricted Project

Aug 19 2019

lhames accepted D66440: [ORC] fix use-after-free detected by -Wreturn-stack-address.

LGTM. Nice catch!

Aug 19 2019, 2:55 PM · Restricted Project
lhames added inline comments to D66399: [ORCv2] - New Speculate Query Implementation.
Aug 19 2019, 2:29 PM · Restricted Project, Restricted Project

Aug 18 2019

lhames committed rGcf276ba82e81: [ORC] Make sure we linker-mangle symbol names in the SpeculationLayer. (authored by lhames).
[ORC] Make sure we linker-mangle symbol names in the SpeculationLayer.
Aug 18 2019, 2:31 PM
lhames committed rL369219: [ORC] Make sure we linker-mangle symbol names in the SpeculationLayer..
[ORC] Make sure we linker-mangle symbol names in the SpeculationLayer.
Aug 18 2019, 2:29 PM
lhames committed rGa264b6074a4f: [ORC] Remove some dead code. (authored by lhames).
[ORC] Remove some dead code.
Aug 18 2019, 2:23 PM
lhames committed rL369218: [ORC] Remove some dead code..
[ORC] Remove some dead code.
Aug 18 2019, 2:21 PM

Aug 16 2019

lhames committed rG8e2837e549db: [ORC] Re-introduce self-dependence accidentally dropped from a unit test. (authored by lhames).
[ORC] Re-introduce self-dependence accidentally dropped from a unit test.
Aug 16 2019, 4:23 PM
lhames committed rL369171: [ORC] Re-introduce self-dependence accidentally dropped from a unit test..
[ORC] Re-introduce self-dependence accidentally dropped from a unit test.
Aug 16 2019, 4:23 PM
lhames committed rG9bb9a0c10b21: [ORC] Remove some stray debugging output accidentally left in r368707 (authored by lhames).
[ORC] Remove some stray debugging output accidentally left in r368707
Aug 16 2019, 12:35 PM
lhames committed rL369141: [ORC] Remove some stray debugging output accidentally left in r368707.
[ORC] Remove some stray debugging output accidentally left in r368707
Aug 16 2019, 12:32 PM

Aug 13 2019

lhames committed rG810b574d772a: [ORC] Fix SpeculativeJIT example code broken by r368707. (authored by lhames).
[ORC] Fix SpeculativeJIT example code broken by r368707.
Aug 13 2019, 3:48 PM
lhames committed rL368764: [ORC] Fix SpeculativeJIT example code broken by r368707..
[ORC] Fix SpeculativeJIT example code broken by r368707.
Aug 13 2019, 3:43 PM
lhames committed rG0fed4945d905: [ORC] Fix BuildingAJIT tutorial code broken by r368707. (authored by lhames).
[ORC] Fix BuildingAJIT tutorial code broken by r368707.
Aug 13 2019, 12:41 PM
lhames committed rL368740: [ORC] Fix BuildingAJIT tutorial code broken by r368707..
[ORC] Fix BuildingAJIT tutorial code broken by r368707.
Aug 13 2019, 12:38 PM
lhames committed rG52a34a78d9af: [ORC] Refactor definition-generation, add a generator for static libraries. (authored by lhames).
[ORC] Refactor definition-generation, add a generator for static libraries.
Aug 13 2019, 9:08 AM
lhames committed rL368707: [ORC] Refactor definition-generation, add a generator for static libraries..
[ORC] Refactor definition-generation, add a generator for static libraries.
Aug 13 2019, 9:05 AM

Aug 8 2019

lhames accepted D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit.

LGTM.

Aug 8 2019, 10:42 AM · Restricted Project, Restricted Project

Aug 6 2019

lhames added a comment to D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create..

I think the right line is:

Aug 6 2019, 2:54 PM · Restricted Project, Restricted Project

Aug 5 2019

lhames committed rG1707735fa479: [ORC] Work around broken GCC/libstdc++ by adding an explicit conversion. (authored by lhames).
[ORC] Work around broken GCC/libstdc++ by adding an explicit conversion.
Aug 5 2019, 1:31 PM
lhames committed rL367921: [ORC] Work around broken GCC/libstdc++ by adding an explicit conversion..
[ORC] Work around broken GCC/libstdc++ by adding an explicit conversion.
Aug 5 2019, 1:30 PM
lhames accepted D65760: [ORC] Add host CPU name and sub-target features to JITTargetMachineBuilder::detectHost().

Looks good to me. Thanks Diego!

Aug 5 2019, 12:57 PM · Restricted Project

Aug 3 2019

lhames committed rGfe3749920703: [JITLink] Fix an overly-wide read in the MachO/x86-64 test case. (authored by lhames).
[JITLink] Fix an overly-wide read in the MachO/x86-64 test case.
Aug 3 2019, 3:39 PM
lhames committed rL367767: [JITLink] Fix an overly-wide read in the MachO/x86-64 test case..
[JITLink] Fix an overly-wide read in the MachO/x86-64 test case.
Aug 3 2019, 3:37 PM
lhames committed rG3daccaac8a6b: [JITLink] Add support for MachO/x86-64 UNSIGNED relocs with length=2. (authored by lhames).
[JITLink] Add support for MachO/x86-64 UNSIGNED relocs with length=2.
Aug 3 2019, 1:18 PM
lhames committed rGb31229af4f4a: [JITLink] Fix error message formatting. (authored by lhames).
[JITLink] Fix error message formatting.
Aug 3 2019, 1:18 PM
lhames committed rL367764: [JITLink] Add support for MachO/x86-64 UNSIGNED relocs with length=2..
[JITLink] Add support for MachO/x86-64 UNSIGNED relocs with length=2.
Aug 3 2019, 1:16 PM
lhames committed rL367763: [JITLink] Fix error message formatting..
[JITLink] Fix error message formatting.
Aug 3 2019, 1:16 PM

Aug 2 2019

lhames committed rG38136d3b9687: [ORC] Remove some old debugging output from a unit test. (authored by lhames).
[ORC] Remove some old debugging output from a unit test.
Aug 2 2019, 6:35 PM
lhames committed rL367742: [ORC] Remove some old debugging output from a unit test..
[ORC] Remove some old debugging output from a unit test.
Aug 2 2019, 6:32 PM
lhames committed rG10430f417434: [ORC] Remove a dead method. (authored by lhames).
[ORC] Remove a dead method.
Aug 2 2019, 1:10 PM
lhames committed rL367716: [ORC] Remove a dead method..
[ORC] Remove a dead method.
Aug 2 2019, 1:10 PM
lhames added a comment to D65590: Make name resolution in ORC skip extra symbols.

Hi Sasha,

Aug 2 2019, 12:46 PM · Restricted Project
lhames committed rGcb391279b41b: [ORC] Turn on symbol-flags overrides for LLJIT on Windows by default. (authored by lhames).
[ORC] Turn on symbol-flags overrides for LLJIT on Windows by default.
Aug 2 2019, 12:44 PM