Page MenuHomePhabricator

lhames (Lang Hames)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2013, 2:34 PM (433 w, 1 d)

Recent Activity

Today

lhames accepted D104480: [Orc] add C-API for transform layer.

Apart from those two comments, this looks great!

Thu, Jun 17, 4:12 PM · Restricted Project, Restricted Project

Yesterday

lhames committed rG838490de7ede: [ORC] Switch from uint8_t to char buffers for TargetProcessControl::runWrapper. (authored by lhames).
[ORC] Switch from uint8_t to char buffers for TargetProcessControl::runWrapper.
Wed, Jun 16, 9:16 PM
lhames committed rG834616146b7d: [ORC] Switch to WrapperFunction utility for calls to registration functions. (authored by lhames).
[ORC] Switch to WrapperFunction utility for calls to registration functions.
Wed, Jun 16, 1:06 AM

Tue, Jun 15

lhames committed rG89fa1a3a831f: [ORC] Fix endianness in manual serialization to match WrapperFunctionUtils. (authored by lhames).
[ORC] Fix endianness in manual serialization to match WrapperFunctionUtils.
Tue, Jun 15, 4:54 AM
lhames committed rG0672d5d104de: [ORC] Fix missing std::move. (authored by lhames).
[ORC] Fix missing std::move.
Tue, Jun 15, 4:43 AM
lhames committed rG48fb8ecf443b: [ORC] Fix narrowing-in-initializer-list warnings. (authored by lhames).
[ORC] Fix narrowing-in-initializer-list warnings.
Tue, Jun 15, 4:40 AM
lhames committed rG5a28bdeeb61a: [ORC] Fix missing function in unit test. (authored by lhames).
[ORC] Fix missing function in unit test.
Tue, Jun 15, 4:39 AM
lhames committed rG5188b9af84c4: [ORC] Make WrapperFunctionResult's ValuePtr member non-const. (authored by lhames).
[ORC] Make WrapperFunctionResult's ValuePtr member non-const.
Tue, Jun 15, 4:26 AM
lhames committed rG4eb9fe2e1a07: [ORC] Port WrapperFunctionUtils and SimplePackedSerialization from ORC runtime. (authored by lhames).
[ORC] Port WrapperFunctionUtils and SimplePackedSerialization from ORC runtime.
Tue, Jun 15, 4:14 AM

Mon, Jun 14

lhames committed rG68c161090ef6: [ORC-RT] Fix void function handling in the WrapperFunction utility. (authored by lhames).
[ORC-RT] Fix void function handling in the WrapperFunction utility.
Mon, Jun 14, 10:53 PM

Sun, Jun 13

lhames committed rGba9e28064b25: [ORC-RT] Fix an error check. (authored by lhames).
[ORC-RT] Fix an error check.
Sun, Jun 13, 7:00 PM
lhames committed rGa7c3105adb55: [ORC-RT] Remove unused header in unit test. (authored by lhames).
[ORC-RT] Remove unused header in unit test.
Sun, Jun 13, 3:52 AM
lhames committed rGfc3ca2cc083b: [JITLink][MachO] Add missing testcase. (authored by lhames).
[JITLink][MachO] Add missing testcase.
Sun, Jun 13, 3:52 AM
lhames committed rGe405db075b30: [ORC-RT] Fix a comment. (authored by lhames).
[ORC-RT] Fix a comment.
Sun, Jun 13, 3:51 AM

Sat, Jun 12

lhames committed rG49f4a58d53c7: [ORC-RT] Split Simple-Packed-Serialization code into its own header. (authored by lhames).
[ORC-RT] Split Simple-Packed-Serialization code into its own header.
Sat, Jun 12, 6:07 PM

Wed, Jun 9

lhames committed rG82f8aef3deb1: [JITLink][MachO] Handle muliple symbols at same offset when splitting C-strings. (authored by lhames).
[JITLink][MachO] Handle muliple symbols at same offset when splitting C-strings.
Wed, Jun 9, 2:35 AM

Tue, Jun 8

lhames committed rGf9649d123db6: [JITLink][MachO] Split C-string literal sections on null-terminators. (authored by lhames).
[JITLink][MachO] Split C-string literal sections on null-terminators.
Tue, Jun 8, 5:21 PM
lhames committed rG4f16ccdab2d3: [JITLink] Clarify LinkGraph::splitBlock contract in comment. (authored by lhames).
[JITLink] Clarify LinkGraph::splitBlock contract in comment.
Tue, Jun 8, 1:56 AM

Tue, Jun 1

lhames committed rGda5924132771: [ORC-RT] Add WrapperFunctionResult, Simple Packed Serialization (SPS) system. (authored by lhames).
[ORC-RT] Add WrapperFunctionResult, Simple Packed Serialization (SPS) system.
Tue, Jun 1, 11:26 AM
lhames committed rG28c3e9c0d150: [ORC-RT] Rename C-API functions to use __orc_rt_ prefix (instead of OrcRT). (authored by lhames).
[ORC-RT] Rename C-API functions to use __orc_rt_ prefix (instead of OrcRT).
Tue, Jun 1, 11:26 AM
lhames committed rGd791f0c2199e: [ORC-RT] Add equality/inequality comparison to string_view. (authored by lhames).
[ORC-RT] Add equality/inequality comparison to string_view.
Tue, Jun 1, 11:26 AM

Sun, May 30

lhames committed rG1ed29f8784ee: [ORC-RT] Add common.h -- Logging, casting and remote dispatch utilities. (authored by lhames).
[ORC-RT] Add common.h -- Logging, casting and remote dispatch utilities.
Sun, May 30, 11:45 AM
lhames committed rG442f2d7bc0bc: [ORC-RT] Add OrcRTCWrapperFunctionResult. (authored by lhames).
[ORC-RT] Add OrcRTCWrapperFunctionResult.
Sun, May 30, 11:45 AM

Wed, May 26

lhames committed rG95ce0def7c98: [ORC-RT] Add endianness support to the ORC runtime. (authored by lhames).
[ORC-RT] Add endianness support to the ORC runtime.
Wed, May 26, 5:29 PM

Tue, May 25

lhames committed rG249cd9dd6002: [JITLink][MachO][arm64] Build GOT entries for defined symbols too. (authored by lhames).
[JITLink][MachO][arm64] Build GOT entries for defined symbols too.
Tue, May 25, 12:19 PM
lhames committed rG2367a7bdab36: [JITLink][MachO][arm64] Use a more descriptive test name. (authored by lhames).
[JITLink][MachO][arm64] Use a more descriptive test name.
Tue, May 25, 12:19 PM

Mon, May 24

lhames committed rG0ab14f19685e: [JITLink] Suppress expect-death test in release mode. (authored by lhames).
[JITLink] Suppress expect-death test in release mode.
Mon, May 24, 10:57 PM
lhames committed rG82ad2b6e94b6: [JITLink] Enable creation and management of mutable block content. (authored by lhames).
[JITLink] Enable creation and management of mutable block content.
Mon, May 24, 10:09 PM

Sat, May 22

lhames committed rG1a1d6e6f9873: [ORC] Add more synchronization to TestLookupWithUnthreadedMaterialization. (authored by lhames).
[ORC] Add more synchronization to TestLookupWithUnthreadedMaterialization.
Sat, May 22, 8:00 AM
lhames committed rG2b45895df46e: [JITLink] Move some Block bitfields into Addressable to improve packing. (authored by lhames).
[JITLink] Move some Block bitfields into Addressable to improve packing.
Sat, May 22, 7:59 AM

Fri, May 21

lhames committed rG4272fca2db9c: [ORC] Check for underflow on SymbolStringPtr ref-counts. (authored by lhames).
[ORC] Check for underflow on SymbolStringPtr ref-counts.
Fri, May 21, 9:13 PM
lhames committed rG20634ece159b: [ORC] Fix debugging output: printDescription should not have a newline. (authored by lhames).
[ORC] Fix debugging output: printDescription should not have a newline.
Fri, May 21, 9:13 PM
lhames committed rGfda4300da829: [ORC] Fix race condtition in CoreAPIsTest. (authored by lhames).
[ORC] Fix race condtition in CoreAPIsTest.
Fri, May 21, 9:13 PM
lhames committed rG40df1b15b4f7: [ORC][C-bindings] Replace LLVMOrcJITTargetMachineBuilderDisposeTargetTriple. (authored by lhames).
[ORC][C-bindings] Replace LLVMOrcJITTargetMachineBuilderDisposeTargetTriple.
Fri, May 21, 5:38 PM
lhames closed D102957: [Orc][C-bindings] remove LLVMOrcJITTargetMachineBuilderDisposeTargetTriple in favor of LLVMDisposeMessage.
Fri, May 21, 5:38 PM · Restricted Project
lhames accepted D102957: [Orc][C-bindings] remove LLVMOrcJITTargetMachineBuilderDisposeTargetTriple in favor of LLVMDisposeMessage.

LGTM.

Fri, May 21, 5:15 PM · Restricted Project
lhames committed rG16b284e99e4b: [ORC-RT] Add missing headers to CMakeLists.txt. (authored by lhames).
[ORC-RT] Add missing headers to CMakeLists.txt.
Fri, May 21, 10:24 AM
lhames added a comment to D102710: [NFC][test] replace empty returns with GTEST_SKIP.

I do not have commit access so it'd be great if somebody could land this on my behalf.

Fri, May 21, 10:16 AM · Restricted Project
lhames committed rG95612afc1d69: [ORC] Use GTEST_SKIP in ORC C-API unit test. (authored by lhames).
[ORC] Use GTEST_SKIP in ORC C-API unit test.
Fri, May 21, 10:16 AM
lhames closed D102710: [NFC][test] replace empty returns with GTEST_SKIP.
Fri, May 21, 10:15 AM · Restricted Project

Thu, May 20

lhames added inline comments to D100944: [MC][ELF] Emit separate unique sections for different flags.
Thu, May 20, 6:09 PM · Restricted Project
lhames added a comment to D100944: [MC][ELF] Emit separate unique sections for different flags.

...
Changed Orc/RTDyldObjectLinkingLayerTest.cpp to use a non-allocatable
section (.note.GNU-stack) for its check, rather than trying to place an
object in the .debug_str section, which now results in a new .debug_str
section with SHF_ALLOC.

Thu, May 20, 5:57 PM · Restricted Project
lhames committed rGd22b27cfde0f: [ORC-RT] Add string_view and span utilities for use by the ORC runtime. (authored by lhames).
[ORC-RT] Add string_view and span utilities for use by the ORC runtime.
Thu, May 20, 11:03 AM
lhames accepted D102756: [clang-repl] Tell the LLJIT the exact target triple we use..

LGTM. :)

Thu, May 20, 9:34 AM

Wed, May 19

lhames added a comment to D102694: [lit][gtest] Support SKIPPED tests.

FWIW this looks reasonable to me, but I'm not a lit expert.

Wed, May 19, 1:34 PM · Restricted Project, Restricted Project
lhames committed rG1dfa47910a23: [ORC-RT] Add ORC runtime error and expected types. (authored by lhames).
[ORC-RT] Add ORC runtime error and expected types.
Wed, May 19, 1:31 PM
lhames committed rGef6e1213b1c0: [ORC] Add a CPU getter to JITTargetMachineBuilder. (authored by lhames).
[ORC] Add a CPU getter to JITTargetMachineBuilder.
Wed, May 19, 1:31 PM

May 18 2021

lhames accepted D102710: [NFC][test] replace empty returns with GTEST_SKIP.

LGTM, pending acceptance of https://reviews.llvm.org/D102694.

May 18 2021, 1:13 PM · Restricted Project
lhames committed rGbd6c93c00432: [ORC-RT] Add compiler abstraction header for the ORC runtime. (authored by lhames).
[ORC-RT] Add compiler abstraction header for the ORC runtime.
May 18 2021, 8:44 AM
lhames committed rG9e5f3dd9dbb0: [ORC-RT] Add apply_tuple utility. (authored by lhames).
[ORC-RT] Add apply_tuple utility.
May 18 2021, 8:44 AM
lhames committed rGc42580bf2076: [ORC] Don't try to obtain a ref to a non-existent buffer. (authored by lhames).
[ORC] Don't try to obtain a ref to a non-existent buffer.
May 18 2021, 8:44 AM

May 16 2021

lhames added a comment to D98305: [JITLink] Introduce generic x86-64 support by refactoring MachO/x86-64..

Hi Lang,

Unfortunately, I don't think there's currently a working bot running the LLVM tests on Windows. I can see the failure locally on my machine and in our internal CI, top of tree with the following configuration (host triple is x86_64-pc-windows-msvc):

-G Ninja -DCMAKE_BUILD_TYPE=Debug -DLLVM_ENABLE_PROJECTS=clang;lld;lldb;mlir -DLLVM_TARGETS_TO_BUILD=host -DLLDB_INCLUDE_TESTS=OFF -DLLVM_ENABLE_ASSERTIONS=ON
May 16 2021, 10:15 AM · Restricted Project
lhames committed rGd1a7630369bc: [JITLink] Fix symbol comparator in LinkGraph::dump. (authored by lhames).
[JITLink] Fix symbol comparator in LinkGraph::dump.
May 16 2021, 10:13 AM

May 15 2021

lhames added a comment to D98305: [JITLink] Introduce generic x86-64 support by refactoring MachO/x86-64..

I believe this change, or one of the subsequent ones (I can't find them on Differential, sorry), broke a test on the Windows Debug build.

Failed Tests (1):
  LLVM :: ExecutionEngine/JITLink/X86/ELF_skip_debug_sections.s
May 15 2021, 9:33 AM · Restricted Project

May 14 2021

lhames committed rG49cdd62db569: [llvm-jitlink] Link libnetwork on Haiku in llvm-jitlink (authored by lhames).
[llvm-jitlink] Link libnetwork on Haiku in llvm-jitlink
May 14 2021, 8:49 PM
lhames closed D98405: [cmake] Link to libnetwork on Haiku in llvm-jitlink.
May 14 2021, 8:49 PM · Restricted Project

May 13 2021

lhames committed rGc82a0ae70e28: [ORC] Add JITLink dependence for ObjectLinkingLayerTest. (authored by lhames).
[ORC] Add JITLink dependence for ObjectLinkingLayerTest.
May 13 2021, 10:50 PM
lhames committed rG0fda4c4745b8: [ORC] Add support for adding LinkGraphs directly to ObjectLinkingLayer. (authored by lhames).
[ORC] Add support for adding LinkGraphs directly to ObjectLinkingLayer.
May 13 2021, 9:56 PM
lhames committed rG9099c9ef78c0: [JITLink] Fix missing 'static' keyword in unit test. (authored by lhames).
[JITLink] Fix missing 'static' keyword in unit test.
May 13 2021, 9:56 PM
lhames committed rG65736ac439be: [ORC] Remove the OrcExecutionTest class. It is no longer used. (authored by lhames).
[ORC] Remove the OrcExecutionTest class. It is no longer used.
May 13 2021, 6:33 PM
lhames committed rG527bd6dc1cc1: [ORC] Remove unused RTDyldObjectLinkingLayerExecutionTest class from unit test. (authored by lhames).
[ORC] Remove unused RTDyldObjectLinkingLayerExecutionTest class from unit test.
May 13 2021, 6:33 PM
lhames committed rGc76e3c319ebf: [ORC] Remove some stale unit test utils. (authored by lhames).
[ORC] Remove some stale unit test utils.
May 13 2021, 6:33 PM
lhames added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

...
Command Output (stderr):

triple: powerpc64-ibm-aix7.2.0.0
datalayout: E-m:a-i64:64-n32:64-S128-v256:256:256-v512:512:512
error: Added modules have incompatible data layouts: e-m:e-i64:64-n32:64-S128-v256:256:256-v512:512:512 (module) vs E-m:a-i64:64-n32:64-S128-v256:256:256-v512:512:512 (jit)

May 13 2021, 2:41 PM · Restricted Project
lhames committed rG71a0609a2b53: [clang-repl] Temporarily disable the execute.cpp test on ppc64. (authored by lhames).
[clang-repl] Temporarily disable the execute.cpp test on ppc64.
May 13 2021, 2:40 PM
lhames added a comment to D96033: [clang-repl] Land initial infrastructure for incremental parsing.

...
I have a local build I can apply a patch to.

May 13 2021, 10:07 AM · Restricted Project

May 12 2021

lhames committed rG2f21a272af69: [JITLink] Expose x86-64 pointer jump stub block construction. (authored by lhames).
[JITLink] Expose x86-64 pointer jump stub block construction.
May 12 2021, 10:28 PM
lhames committed rG4b0f5edd36c6: [JITLink] Add a transferDefinedSymbol operation. (authored by lhames).
[JITLink] Add a transferDefinedSymbol operation.
May 12 2021, 10:28 PM

May 11 2021

lhames updated subscribers of rGcbcfca343f02: [JITLink] Make LinkGraph debug dumps more readable..

Hi Leonard,

May 11 2021, 4:28 PM
lhames committed rGd63860a05226: [JITLink] Fix bogus format string. (authored by lhames).
[JITLink] Fix bogus format string.
May 11 2021, 4:04 PM
lhames committed rGa0162a81b137: [JITLink][MachO/x86_64] Expose API for creating eh-frame fixing passes. (authored by lhames).
[JITLink][MachO/x86_64] Expose API for creating eh-frame fixing passes.
May 11 2021, 3:26 PM
lhames committed rG74a96b4c9843: [JITLink][x86-64] Add an x86_64 PointerSize constexpr. (authored by lhames).
[JITLink][x86-64] Add an x86_64 PointerSize constexpr.
May 11 2021, 3:26 PM
lhames committed rGcbcfca343f02: [JITLink] Make LinkGraph debug dumps more readable. (authored by lhames).
[JITLink] Make LinkGraph debug dumps more readable.
May 11 2021, 3:26 PM
lhames committed rGe0b6c99288bf: Re-apply "[ORC-RT] Add unit test infrastructure, extensible_rtti..." (authored by lhames).
Re-apply "[ORC-RT] Add unit test infrastructure, extensible_rtti..."
May 11 2021, 10:29 AM
lhames added a reverting change for rG6d263b6f1c97: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test: rG1c7c6f2b1062: Revert "[ORC-RT] Add unit test infrastructure, extensible_rtti...".
May 11 2021, 9:52 AM
lhames committed rG1c7c6f2b1062: Revert "[ORC-RT] Add unit test infrastructure, extensible_rtti..." (authored by lhames).
Revert "[ORC-RT] Add unit test infrastructure, extensible_rtti..."
May 11 2021, 9:52 AM
lhames added a reverting change for D102080: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test: rG1c7c6f2b1062: Revert "[ORC-RT] Add unit test infrastructure, extensible_rtti...".
May 11 2021, 9:52 AM · Restricted Project
lhames updated subscribers of D102080: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test.

Hi Nico,

May 11 2021, 9:41 AM · Restricted Project

May 10 2021

lhames committed rG6d263b6f1c97: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test (authored by lhames).
[ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test
May 10 2021, 5:17 PM
lhames closed D102080: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test.
May 10 2021, 5:17 PM · Restricted Project
lhames committed rG9507bace6c12: [ORC] Use a unique_function rather than std::function for dispatchTask. (authored by lhames).
[ORC] Use a unique_function rather than std::function for dispatchTask.
May 10 2021, 1:05 PM
lhames added inline comments to D102080: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test.
May 10 2021, 12:18 PM · Restricted Project
lhames added a comment to D102080: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test.

@phosek It's really just the CMake changes that need reviewing here. The C++ code is adapted directly from code already in LLVM.

May 10 2021, 10:16 AM · Restricted Project
lhames committed rG08d18af26105: [ORC] Update SpeculativeJIT example for dispatchTask changes in 5344c88dcb2. (authored by lhames).
[ORC] Update SpeculativeJIT example for dispatchTask changes in 5344c88dcb2.
May 10 2021, 9:31 AM
lhames added a comment to rG7f9a89f9a2cc: [ORC] Use the new dispatchTask API to run query callbacks..

Sure thing. I should have a fix for this shortly.

May 10 2021, 8:46 AM
lhames added a comment to D102080: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test.

I think on Apple platforms TSAN only builds a dylib for production [1]....

May 10 2021, 7:41 AM · Restricted Project

May 9 2021

lhames committed rG7f9a89f9a2cc: [ORC] Use the new dispatchTask API to run query callbacks. (authored by lhames).
[ORC] Use the new dispatchTask API to run query callbacks.
May 9 2021, 7:38 PM
lhames committed rG5344c88dcb28: [ORC] Generalize materialization dispatch to task dispatch. (authored by lhames).
[ORC] Generalize materialization dispatch to task dispatch.
May 9 2021, 7:38 PM

May 8 2021

lhames abandoned D79685: [Support] Use unique_function for ThreadPool..

This blew up on the builders. The MSVC implementation of packaged_task does not support unique_function (at least at the moment).

May 8 2021, 8:05 PM · Restricted Project
lhames accepted D97898: [RuntimeDyld] Add allowStubs/allowZeroSyms.

LGTM. Thanks Rafael!

May 8 2021, 8:03 PM · Restricted Project

May 7 2021

lhames updated the diff for D102080: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test.

Fix Linux build, add comments noting that the runtime extensible_rtti
code was adapted from LLVM.

May 7 2021, 7:03 PM · Restricted Project
lhames added a comment to D102080: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test.

Looks like this is broken on Linux. Looking in to that now...

May 7 2021, 10:24 AM · Restricted Project
lhames added a comment to D102080: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test.

I've tried to adapt this from the Xray and TSan test CMakeLists.txt. Most of it makes sense to me (as much as any CMake can), but I was surprised by this pattern which showed up in Xray and TSan (and all the other projects that I looked at):

May 7 2021, 9:50 AM · Restricted Project
lhames updated the diff for D102080: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test.

Include the whole patch. (Why are you like this arc?)

May 7 2021, 9:42 AM · Restricted Project
lhames updated the diff for D102080: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test.

Fix incomplete cargo-culting of unittest CMake.

May 7 2021, 9:40 AM · Restricted Project
lhames requested review of D102080: [ORC-RT] Add unit test infrastructure, extensible_rtti implementation, unit test.
May 7 2021, 9:35 AM · Restricted Project

May 6 2021

lhames accepted D101971: [AIX][Test][ORC] Skip unsupported ORC C API tests on AIX.

LGTM. Thanks Hubert!

May 6 2021, 7:05 AM · Restricted Project

May 5 2021

lhames requested changes to D101971: [AIX][Test][ORC] Skip unsupported ORC C API tests on AIX.

Hi Hubert,

May 5 2021, 9:07 PM · Restricted Project
lhames committed rGabdd14a2d785: [ORC] Add missing library dependency on IRReader. (authored by lhames).
[ORC] Add missing library dependency on IRReader.
May 5 2021, 7:38 PM
lhames committed rG7b73cd684a8d: [ORC] Introduce C API for adding object buffers directly to an object layer. (authored by lhames).
[ORC] Introduce C API for adding object buffers directly to an object layer.
May 5 2021, 7:12 PM
lhames accepted D98405: [cmake] Link to libnetwork on Haiku in llvm-jitlink.

If we acquire too many of these special cases then we should consider creating some more generic CMake infrastructure for them, but I think for now this is fine as-is.

May 5 2021, 8:49 AM · Restricted Project