Page MenuHomePhabricator

lhames (Lang Hames)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2013, 2:34 PM (320 w, 1 d)

Recent Activity

Wed, Apr 17

lhames updated the diff for D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..
  • Fix some section layout and test infrastructure bugs, start work on an initial testcase.
Wed, Apr 17, 8:42 PM · Restricted Project
lhames updated the diff for D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..

Another big update.

Wed, Apr 17, 11:28 AM · Restricted Project
lhames added a comment to D60810: [Support] Add LEB128 support to BinaryStreamReader/Writer..

Thanks Dave!

Wed, Apr 17, 8:42 AM · Restricted Project
lhames committed rGc1106c9b1161: [Support] Add LEB128 support to BinaryStreamReader/Writer. (authored by lhames).
[Support] Add LEB128 support to BinaryStreamReader/Writer.
Wed, Apr 17, 8:37 AM
lhames committed rL358584: [Support] Add LEB128 support to BinaryStreamReader/Writer..
[Support] Add LEB128 support to BinaryStreamReader/Writer.
Wed, Apr 17, 8:36 AM
lhames closed D60810: [Support] Add LEB128 support to BinaryStreamReader/Writer..
Wed, Apr 17, 8:36 AM · Restricted Project

Tue, Apr 16

lhames created D60810: [Support] Add LEB128 support to BinaryStreamReader/Writer..
Tue, Apr 16, 9:30 PM · Restricted Project

Sun, Apr 14

lhames accepted D58083: lld: Fix initial Mach-O load commands size calculation omitting LC_FUNCTION_STARTS.

Hi Comex,

Sun, Apr 14, 10:10 AM · Restricted Project

Fri, Apr 12

lhames committed rGc7c1f21525f8: Simplify decoupling between RuntimeDyld/RuntimeDyldChecker, add 'got_addr' util. (authored by lhames).
Simplify decoupling between RuntimeDyld/RuntimeDyldChecker, add 'got_addr' util.
Fri, Apr 12, 11:07 AM
lhames committed rL358295: Simplify decoupling between RuntimeDyld/RuntimeDyldChecker, add 'got_addr' util..
Simplify decoupling between RuntimeDyld/RuntimeDyldChecker, add 'got_addr' util.
Fri, Apr 12, 11:07 AM

Tue, Apr 9

lhames added a comment to D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..
  • Lots of changes. Headlines:
Tue, Apr 9, 3:57 PM · Restricted Project
lhames updated the diff for D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..
  • Lots of changes. Headlines:
Tue, Apr 9, 3:57 PM · Restricted Project

Mon, Apr 8

lhames added a comment to D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..

New patch coming soon: more complete relocation support, weak symbol support, testing infrastructure, and a new llvm-jitlink tool (the jitlink counterpart to llvm-rtdyld).

Mon, Apr 8, 5:01 PM · Restricted Project
lhames committed rGd250238abd0c: [RuntimeDyld] Fix an ambiguous make_unique call. (authored by lhames).
[RuntimeDyld] Fix an ambiguous make_unique call.
Mon, Apr 8, 3:19 PM
lhames committed rL357950: [RuntimeDyld] Fix an ambiguous make_unique call..
[RuntimeDyld] Fix an ambiguous make_unique call.
Mon, Apr 8, 3:19 PM
lhames committed rG941f247d30c4: [RuntimeDyld] Decouple RuntimeDyldChecker from RuntimeDyld. (authored by lhames).
[RuntimeDyld] Decouple RuntimeDyldChecker from RuntimeDyld.
Mon, Apr 8, 2:51 PM
lhames committed rL357947: [RuntimeDyld] Decouple RuntimeDyldChecker from RuntimeDyld..
[RuntimeDyld] Decouple RuntimeDyldChecker from RuntimeDyld.
Mon, Apr 8, 2:51 PM

Tue, Mar 26

lhames added a comment to D58083: lld: Fix initial Mach-O load commands size calculation omitting LC_FUNCTION_STARTS.

Hi Comex,

Tue, Mar 26, 12:55 AM · Restricted Project

Mar 11 2019

lhames updated the diff for D59107: [Support] Add error handling to sys::Process::getPageSize()..
  • Address Dave's feedback.
Mar 11 2019, 3:31 PM · Restricted Project

Mar 7 2019

lhames added inline comments to D59107: [Support] Add error handling to sys::Process::getPageSize()..
Mar 7 2019, 1:38 PM · Restricted Project
lhames created D59107: [Support] Add error handling to sys::Process::getPageSize()..
Mar 7 2019, 12:52 PM · Restricted Project

Mar 6 2019

lhames updated the diff for D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..
  • Change the way dead stripping is performed.
  • Flesh out initial JITLink MachO/x86-64 unit test.
  • clang-format
  • Address dblaikie's review feedback, also make Atom/DefinedAtom/Section
Mar 6 2019, 4:36 PM · Restricted Project
lhames added a comment to D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..

Thanks Dave! I've got a patch that addresses your feedback that I will post from the bus in a minute.

Mar 6 2019, 4:03 PM · Restricted Project

Mar 4 2019

lhames added a comment to D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..

Since you're rewrite this, is there any potential for sharing code with lld? Relocating instructions should essentially be the same between these two.

I haven't read this patch, but as a general comment, I could say that a static linker is fairly different from a JIT linker...

Mar 4 2019, 8:42 AM · Restricted Project
lhames added a comment to D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..

My main concern with this design is how you plan to integrate this with the existing infrastructure. Are you planning on laying this under RuntimeDyLD? Or somehow factoring out common implementation to be used by both? I'm generally bothered by the seeming duplication of such a fragile piece of infrastructure.

Mar 4 2019, 8:22 AM · Restricted Project

Feb 27 2019

lhames added a reviewer for D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld.: sgraenitz.
Feb 27 2019, 10:27 AM · Restricted Project

Feb 26 2019

lhames created D58704: Initial (incomplete) implementation of JITLink - A replacement for RuntimeDyld..
Feb 26 2019, 5:50 PM · Restricted Project

Feb 21 2019

lhames committed rGde9b30db3d8a: Fix a think-o in the disable-kaleidoscope-tests-on-windows predicate of r354646. (authored by lhames).
Fix a think-o in the disable-kaleidoscope-tests-on-windows predicate of r354646.
Feb 21 2019, 7:57 PM
lhames committed rL354650: Fix a think-o in the disable-kaleidoscope-tests-on-windows predicate of r354646..
Fix a think-o in the disable-kaleidoscope-tests-on-windows predicate of r354646.
Feb 21 2019, 7:56 PM
lhames committed rG4a7db8cb9036: Add 'Windows' to the disabled platforms list for the Kaleidoscope tests. (authored by lhames).
Add 'Windows' to the disabled platforms list for the Kaleidoscope tests.
Feb 21 2019, 5:46 PM
lhames committed rL354646: Add 'Windows' to the disabled platforms list for the Kaleidoscope tests..
Add 'Windows' to the disabled platforms list for the Kaleidoscope tests.
Feb 21 2019, 5:46 PM
lhames committed rGf4b86cb28e67: Disable Kaleidoscope tests on Win32 -- looks like they're still failing there. (authored by lhames).
Disable Kaleidoscope tests on Win32 -- looks like they're still failing there.
Feb 21 2019, 5:21 PM
lhames committed rL354645: Disable Kaleidoscope tests on Win32 -- looks like they're still failing there..
Disable Kaleidoscope tests on Win32 -- looks like they're still failing there.
Feb 21 2019, 5:19 PM
lhames committed rGecfac6cd2ce0: [Kaleidoscope] Re-enable Kaleidoscope tests. (authored by lhames).
[Kaleidoscope] Re-enable Kaleidoscope tests.
Feb 21 2019, 2:25 PM
lhames committed rL354630: [Kaleidoscope] Re-enable Kaleidoscope tests..
[Kaleidoscope] Re-enable Kaleidoscope tests.
Feb 21 2019, 2:24 PM
lhames committed rGddf91af5a67b: [Kaleidoscope] Fix symbol resolver to search in reverse order. (authored by lhames).
[Kaleidoscope] Fix symbol resolver to search in reverse order.
Feb 21 2019, 8:53 AM
lhames committed rL354598: [Kaleidoscope] Fix symbol resolver to search in reverse order..
[Kaleidoscope] Fix symbol resolver to search in reverse order.
Feb 21 2019, 8:52 AM

Feb 6 2019

Herald added a project to D39111: Extensible LLVM RTTI: Restricted Project.

Ping.

Feb 6 2019, 4:00 PM · Restricted Project

Feb 5 2019

lhames added a comment to D57618: [ADT] Add a fallible_iterator wrapper..

Committed. I updated the language in the fallible iterators section of the programmers manual too. Feed back on that is very welcome too.

Feb 5 2019, 3:28 PM · Restricted Project
lhames committed rG3e040e05f89c: [ADT] Add a fallible_iterator wrapper. (authored by lhames).
[ADT] Add a fallible_iterator wrapper.
Feb 5 2019, 3:17 PM
lhames committed rL353237: [ADT] Add a fallible_iterator wrapper..
[ADT] Add a fallible_iterator wrapper.
Feb 5 2019, 3:17 PM
lhames closed D57618: [ADT] Add a fallible_iterator wrapper..
Feb 5 2019, 3:17 PM · Restricted Project
lhames accepted D36806: Switch to cantFail(), since it does the same assertion..

Looks like this was LGTM'd but never applied. Stephen -- do you have commit access?

Feb 5 2019, 1:17 PM · Restricted Project
lhames closed D50429: [MCJIT] Fix case of Error::success being passed to report_fatal_error..

This was committed in r339809.

Feb 5 2019, 1:05 PM · Restricted Project
lhames added inline comments to D57618: [ADT] Add a fallible_iterator wrapper..
Feb 5 2019, 12:56 PM · Restricted Project
lhames updated the diff for D57618: [ADT] Add a fallible_iterator wrapper..
  • Remove unused collection elements.
Feb 5 2019, 12:53 PM · Restricted Project
lhames updated the diff for D57618: [ADT] Add a fallible_iterator wrapper..
  • Require iterator checks on each increment, rename some test vars.
Feb 5 2019, 12:42 PM · Restricted Project

Feb 4 2019

lhames updated the diff for D57618: [ADT] Add a fallible_iterator wrapper..
  • Rename test classes and remove fixture, add test for deref-returns-expected.
Feb 4 2019, 8:41 PM · Restricted Project
lhames added inline comments to D57618: [ADT] Add a fallible_iterator wrapper..
Feb 4 2019, 5:19 PM · Restricted Project
lhames added inline comments to D57618: [ADT] Add a fallible_iterator wrapper..
Feb 4 2019, 3:13 PM · Restricted Project
lhames updated the diff for D57618: [ADT] Add a fallible_iterator wrapper..
  • Address several review feedback comments.
Feb 4 2019, 2:57 PM · Restricted Project
lhames added inline comments to D57618: [ADT] Add a fallible_iterator wrapper..
Feb 4 2019, 2:49 PM · Restricted Project
lhames added inline comments to D57618: [ADT] Add a fallible_iterator wrapper..
Feb 4 2019, 2:42 PM · Restricted Project
lhames added a comment to D57618: [ADT] Add a fallible_iterator wrapper..

Assuming this looks good to everyone, I will also update the programmers manual documentation for fallible iterators. I wanted to get this into a final form before re-writing the docs though.

Feb 4 2019, 12:39 PM · Restricted Project
lhames updated the diff for D57618: [ADT] Add a fallible_iterator wrapper..
  • Remove the cantFail added in r352888, since fallible_iterator makes it unneccessary.
Feb 4 2019, 12:38 PM · Restricted Project
lhames updated the diff for D57618: [ADT] Add a fallible_iterator wrapper..
  • Fix a missing header, rename make_fallible_iter to make_fallible_itr, and update Archive::child_iterator to use the fallible_iterator wrapper.
Feb 4 2019, 11:44 AM · Restricted Project

Feb 1 2019

lhames created D57618: [ADT] Add a fallible_iterator wrapper..
Feb 1 2019, 2:07 PM · Restricted Project

Jan 30 2019

lhames added inline comments to D57462: [llvm-objcopy][NFC] More error propagation (executeObjcopyOnArchive).
Jan 30 2019, 4:04 PM · Restricted Project
lhames accepted D57482: [RuntimeDyld] Don't try to allocate sections with alignment 0..

Nice catch. LGTM. Thanks Zach!

Jan 30 2019, 3:45 PM
lhames added inline comments to D57462: [llvm-objcopy][NFC] More error propagation (executeObjcopyOnArchive).
Jan 30 2019, 3:42 PM · Restricted Project
lhames added inline comments to D57462: [llvm-objcopy][NFC] More error propagation (executeObjcopyOnArchive).
Jan 30 2019, 2:20 PM · Restricted Project

Jan 28 2019

lhames accepted D55943: [RuntimeDyld] load all sections with ProcessAllSections.

LGTM! Do you have commit access?

Jan 28 2019, 1:04 PM

Jan 17 2019

lhames accepted D56819: Document toolchain update policy.

This looks great. Thanks JF!

Jan 17 2019, 10:41 AM

Jan 15 2019

lhames requested changes to D55943: [RuntimeDyld] load all sections with ProcessAllSections.

Hi Yonghong,

Jan 15 2019, 3:20 PM
lhames added a comment to D47073: Document and Enforce new Host Compiler Policy.

OK I think we've had more than enough bikeshed, over months, and in-person at the LLVM dev meeting. This is good enough, we want to warn people for the LLVM 8 branch which is tomorrow. Let's get this checked in today. We'll start a discussion on LLVM dev when anything *actually* changes, so nobody needs to panic just yet.

I strongly disagree with this right now: this is *not* OK to rush this as is.

If you need something in the release, then it can be done in a much less controversial way.

Jan 15 2019, 2:01 PM
lhames added a comment to D47073: Document and Enforce new Host Compiler Policy.
In D47073#1358039, @jfb wrote:

Is there any particular reason why we'd need this for LLVM 8?

Yes: we want to warn folks early. This is just warning them, and they can opt-out. Getting it in the release branch is exactly the right place: people try out releases much more than tip-of-tree.

Jan 15 2019, 12:53 PM
lhames committed rL351195: Revert r351138 "[ORC] Move ORC Core symbol map and set types into their own.
Revert r351138 "[ORC] Move ORC Core symbol map and set types into their own
Jan 15 2019, 7:25 AM

Jan 14 2019

lhames committed rL351138: [ORC] Move ORC Core symbol map and set types into their own header: CoreTypes.h..
[ORC] Move ORC Core symbol map and set types into their own header: CoreTypes.h.
Jan 14 2019, 3:53 PM
lhames accepted D56649: llvm-objdump -m -D should disassemble all text segments.

LGTM!

Jan 14 2019, 3:43 PM
lhames committed rL351128: [Object] Return a symbol_iterator, rather than a basic_symbol_iterator, from.
[Object] Return a symbol_iterator, rather than a basic_symbol_iterator, from
Jan 14 2019, 2:09 PM

Dec 11 2018

lhames added a comment to D39111: Extensible LLVM RTTI.

Gentle ping.

Dec 11 2018, 6:14 PM · Restricted Project

Dec 6 2018

lhames added a comment to D54674: [llvm-objcopy] First bits for MachO .

Apart from these specific comments, my general thought is that this is fine as far as it goes, but as it grows more fully featured it seems likely to start overlapping more libObject and MC functionality.

Dec 6 2018, 8:46 PM · Restricted Project
lhames closed D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..

Committed in r348223.

Dec 6 2018, 6:14 PM

Dec 4 2018

lhames added a comment to D39111: Extensible LLVM RTTI.

Swinging back around to this, as I have a concrete use-case now (allowing JIT clients to query MaterializationUnit types when deciding how to dispatch compiler invocations in the JIT).

Dec 4 2018, 7:25 PM · Restricted Project
lhames updated the diff for D39111: Extensible LLVM RTTI.

Updated to add documentation, comments.

Dec 4 2018, 7:17 PM · Restricted Project

Dec 3 2018

lhames committed rL348223: [ExecutionEngine] Change NotifyObjectEmitted/NotifyObjectFreed API..
[ExecutionEngine] Change NotifyObjectEmitted/NotifyObjectFreed API.
Dec 3 2018, 4:58 PM

Nov 28 2018

lhames accepted D53945: [TextAPI] TBD Reader/Writer.

Looks good to me. :)

Nov 28 2018, 1:06 PM · Restricted Project
lhames added a comment to D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..

Gentle ping.

Nov 28 2018, 12:09 PM
lhames added a comment to D53945: [TextAPI] TBD Reader/Writer.

Oops. Those comments were for and old diff. The no-op sorts are gone, but the other three still apply.

Nov 28 2018, 9:40 AM · Restricted Project

Nov 27 2018

lhames added a comment to D53945: [TextAPI] TBD Reader/Writer.

Nitpicks aside, the mach-o side of this looks good to me. :)

Nov 27 2018, 4:55 PM · Restricted Project

Nov 19 2018

lhames committed rL347281: [ExecutionEngine][Interpreter] Fix out-of-bounds array access..
[ExecutionEngine][Interpreter] Fix out-of-bounds array access.
Nov 19 2018, 5:05 PM
lhames closed D53556: [Interpreter] Fix out-of-bounds access in ffiInvoke.
Nov 19 2018, 5:04 PM
lhames accepted D53556: [Interpreter] Fix out-of-bounds access in ffiInvoke.

LGTM. Committed as r347281. Thanks Eugene!

Nov 19 2018, 5:04 PM

Nov 13 2018

lhames updated the diff for D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..

Updates the PerfJITEventListener API and fixes a comment that referred to the old API.

Nov 13 2018, 3:24 PM

Nov 12 2018

lhames committed rL346727: [BuildingAJIT] Clang-format chapters 1 and 2..
[BuildingAJIT] Clang-format chapters 1 and 2.
Nov 12 2018, 5:28 PM
lhames committed rL346726: [BuildingAJIT] Update chapter 2 to use the ORCv2 APIs..
[BuildingAJIT] Update chapter 2 to use the ORCv2 APIs.
Nov 12 2018, 5:28 PM

Oct 31 2018

lhames added a comment to D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..

This looks like a sensible improvement. There's probably not many implementors of the interface, so the renaming shouldn't cause much pain.

I noticed however that you didn't update ExecutionEngine/PerfJITEvents/PerfJITEventListener.cpp?

Oct 31 2018, 4:41 PM
lhames added a reviewer for D53815: [TableGen] Better error checking for TIED_TO constraints.: MatzeB.
Oct 31 2018, 8:31 AM

Oct 30 2018

lhames committed rL345696: [ORC] Fix hex printing of uint64_t values..
[ORC] Fix hex printing of uint64_t values.
Oct 30 2018, 10:19 PM

Oct 26 2018

lhames updated the diff for D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..
  • [ExecutionEngine] Rename/format JITEventListener methods.
Oct 26 2018, 9:36 PM
lhames created D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..
Oct 26 2018, 12:01 PM
lhames closed D53726: [ADT] Work around a bug in older compiler versions..
Oct 26 2018, 11:55 AM
lhames accepted D53726: [ADT] Work around a bug in older compiler versions..

Thanks everyone! Committed in r345411.

Oct 26 2018, 11:55 AM
lhames committed rL345411: [ADT] Use explicit constructors for DenseMapPair to work around compiler issues..
[ADT] Use explicit constructors for DenseMapPair to work around compiler issues.
Oct 26 2018, 10:52 AM

Oct 25 2018

lhames updated the diff for D53726: [ADT] Work around a bug in older compiler versions..
  • Fix a missing &&
Oct 25 2018, 2:24 PM
lhames added a comment to D53726: [ADT] Work around a bug in older compiler versions..

Patch description doesn't seem to immediately relate to the change - nor test cases demonstrating the connection?

Oct 25 2018, 2:14 PM
lhames retitled D53726: [ADT] Work around a bug in older compiler versions. from [ADT] Add initializer_list constructor, equality tests for DenseMap/DenseSet. to [ADT] Work around a bug in older compiler versions..
Oct 25 2018, 2:14 PM
lhames updated the diff for D53726: [ADT] Work around a bug in older compiler versions..
  • Add non templated constructors for DenseMap, clarify clang version in comment.
  • clang-format
Oct 25 2018, 2:09 PM
lhames added a comment to D53726: [ADT] Work around a bug in older compiler versions..

Oops -- forgot to clang-format this. Will do so before applying if it is accepted though.

Oct 25 2018, 12:46 PM
lhames created D53726: [ADT] Work around a bug in older compiler versions..
Oct 25 2018, 12:43 PM