Page MenuHomePhabricator

lhames (Lang Hames)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2013, 2:34 PM (412 w, 16 h)

Recent Activity

Tue, Jan 19

lhames committed rG95b63c7b1394: [ORC] Move LookupRequest from OrcShared to Orc. (authored by lhames).
[ORC] Move LookupRequest from OrcShared to Orc.
Tue, Jan 19, 1:24 AM

Mon, Jan 18

lhames committed rG24672ddea3c9: [ORC] Move OrcError.h to include/llvm/ExecutionEngine/Orc/Shared. (authored by lhames).
[ORC] Move OrcError.h to include/llvm/ExecutionEngine/Orc/Shared.
Mon, Jan 18, 9:18 PM

Sun, Jan 17

lhames committed rGe5619065b8b8: [JITLink][ELF] New ELF skip-debug-sections test requires asserts. (authored by lhames).
[JITLink][ELF] New ELF skip-debug-sections test requires asserts.
Sun, Jan 17, 8:42 PM
lhames committed rGa817f46d50c3: [JITLink][ELF] Skip DWARF sections in ELF objects. (authored by lhames).
[JITLink][ELF] Skip DWARF sections in ELF objects.
Sun, Jan 17, 5:50 PM

Thu, Jan 14

lhames accepted D94690: [Orc] Allow LLJITBuilder's CreateObjectLinkingLayer to return errors.

Great. Thanks very much Stefan!

Thu, Jan 14, 1:26 PM · Restricted Project
lhames added inline comments to D94690: [Orc] Allow LLJITBuilder's CreateObjectLinkingLayer to return errors.
Thu, Jan 14, 12:52 PM · Restricted Project
lhames accepted D94689: [Orc][NFC] Turn LLJIT member ObjTransformLayer into unique_ptr.

LGTM!

Thu, Jan 14, 12:45 PM · Restricted Project

Tue, Jan 12

lhames committed rGcd8a80de9608: [Orc] Add a unit test for asynchronous definition generation. (authored by lhames).
[Orc] Add a unit test for asynchronous definition generation.
Tue, Jan 12, 7:26 PM

Mon, Jan 11

lhames committed rGef50c07b1fad: [JITLink] Add a new PostAllocationPasses list. (authored by lhames).
[JITLink] Add a new PostAllocationPasses list.
Mon, Jan 11, 4:59 PM
lhames accepted D90789: [docs] Update DebuggingJITedCode page after fix in LLDB.

I think an orc-greedy mode for LLI sounds like a great idea. Also, once we have it we should probably make it the default mode instead of MCJIT.

Mon, Jan 11, 2:44 PM · Restricted Project

Sun, Jan 10

lhames committed rG7b11f564dcfc: [JITLink] Rename PostAllocationPasses to PreFixupPasses. (authored by lhames).
[JITLink] Rename PostAllocationPasses to PreFixupPasses.
Sun, Jan 10, 11:35 PM

Sat, Jan 2

lhames committed rGa554cd6ae5bc: [RuntimeDyld] Fix dangling reference in RuntimeDyldELF. (authored by lhames).
[RuntimeDyld] Fix dangling reference in RuntimeDyldELF.
Sat, Jan 2, 3:21 PM
lhames closed D89373: Fixed dangling reference in RuntimeDyldELF.
Sat, Jan 2, 3:20 PM · Restricted Project

Wed, Dec 30

lhames committed rGa14c955af860: [ORC] Remove some stale debugging output. (authored by lhames).
[ORC] Remove some stale debugging output.
Wed, Dec 30, 3:43 PM

Tue, Dec 29

lhames committed rG5efc71e119d4: [ORC] Move Orc RPC code into Shared, rename some RPC types. (authored by lhames).
[ORC] Move Orc RPC code into Shared, rename some RPC types.
Tue, Dec 29, 5:49 PM

Dec 15 2020

lhames committed rGec6b71df70a0: [JITLink][ORC] Enable creation / linking of raw jitlink::LinkGraphs. (authored by lhames).
[JITLink][ORC] Enable creation / linking of raw jitlink::LinkGraphs.
Dec 15 2020, 7:02 PM

Dec 13 2020

lhames added a comment to rG8904ee8ac7eb: [JITLink] Add JITLinkDylib type, thread through JITLinkMemoryManager APIs..

Hi All,

Dec 13 2020, 6:43 PM
lhames committed rG04795ab8368a: Re-apply 8904ee8ac7e with missing header included this time. (authored by lhames).
Re-apply 8904ee8ac7e with missing header included this time.
Dec 13 2020, 6:40 PM
lhames committed rG8904ee8ac7eb: [JITLink] Add JITLinkDylib type, thread through JITLinkMemoryManager APIs. (authored by lhames).
[JITLink] Add JITLinkDylib type, thread through JITLinkMemoryManager APIs.
Dec 13 2020, 5:30 PM
lhames committed rG77bb3c1ac200: [JITLink] Fix include guard end comment. (authored by lhames).
[JITLink] Fix include guard end comment.
Dec 13 2020, 5:30 PM
lhames committed rG0207de0bfe77: [ORC] Prefer preincrement on iterator. (authored by lhames).
[ORC] Prefer preincrement on iterator.
Dec 13 2020, 5:30 PM

Dec 12 2020

lhames added a comment to D92588: [Doc][NFC] Fix Kaleidoscope links, typos, cfg image and add blog posts for MCJIT.

@fhahn @xgupta Apologies for the delayed reply. I'm not sure why this was abandoned -- it looks good to me.

Dec 12 2020, 5:20 PM · Restricted Project

Dec 9 2020

lhames committed rG5bb28fa0f51e: [JITLink][ELF] Reformat/add debug logging in ELF_x86_64.cpp. (authored by lhames).
[JITLink][ELF] Reformat/add debug logging in ELF_x86_64.cpp.
Dec 9 2020, 11:48 PM

Dec 7 2020

lhames accepted D90860: [JITLink][ELF] Route objects to their matching linker backends based on header info.

LGTM. Thanks Stefan!

Dec 7 2020, 4:06 PM · Restricted Project
lhames accepted D91707: [Orc] Two small fixes in TPCDynamicLibrarySearchGenerator.

LGTM -- Nice catch, thanks Stefan!

Dec 7 2020, 2:16 PM · Restricted Project

Dec 5 2020

lhames committed rG5bc9c858e340: [ORC] Fix missing forward of Allow filter in TPCDynamicLibrarySearchGenerator. (authored by lhames).
[ORC] Fix missing forward of Allow filter in TPCDynamicLibrarySearchGenerator.
Dec 5 2020, 8:52 PM

Nov 25 2020

lhames added a comment to D91935: [MCJIT] Add cmake variables to customize ittapi git location and revision..

Thanks for the explanation. Doing a git clone as part of the build is usually discouraged, though I see Lang approved the original patch. Is this code disabled by default?

Nov 25 2020, 5:28 PM · Restricted Project

Nov 23 2020

lhames added a comment to D89211: [RTDYLD] add debug statements for resolveX86Relocation.

Sorry -- I missed this one earlier. For what it's worth JITLink prints with wild abandon. In general I'd rather log everything and then concentrate on log formatting to make it searchable/digestible.

Nov 23 2020, 8:11 PM · Restricted Project

Nov 16 2020

lhames abandoned D79312: [ORC] Preliminary support for removable code..

This has been superseded by the removable code support added in 0aec49c8531.

Nov 16 2020, 9:59 PM · Restricted Project
lhames committed rG22e44358d3e4: [ORC] Include config.h in RegisterEHFrames.cpp. (authored by lhames).
[ORC] Include config.h in RegisterEHFrames.cpp.
Nov 16 2020, 7:19 PM
lhames committed rGf62e5f456917: [MCJIT] Profile the code generated by MCJIT engine using Intel VTune profiler (authored by lhames).
[MCJIT] Profile the code generated by MCJIT engine using Intel VTune profiler
Nov 16 2020, 1:04 AM
lhames closed D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.
Nov 16 2020, 1:04 AM · Restricted Project

Nov 15 2020

lhames accepted D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

Hi Elena,

Nov 15 2020, 6:49 PM · Restricted Project

Nov 13 2020

lhames closed D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..

Committed in 1d0676b54c4.

Nov 13 2020, 2:41 PM · Restricted Project
lhames added inline comments to D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..
Nov 13 2020, 2:40 PM · Restricted Project
lhames committed rGf2980e8849a7: [ORC] Fix missing return value. (authored by lhames).
[ORC] Fix missing return value.
Nov 13 2020, 2:31 PM
lhames committed rG00526cc78eff: [ORC][examples] Fix missing includes/dependencies in more examples. (authored by lhames).
[ORC][examples] Fix missing includes/dependencies in more examples.
Nov 13 2020, 1:23 AM
lhames committed rGe8427656663d: [ORC] Make a narrowing conversion explicit. (authored by lhames).
[ORC] Make a narrowing conversion explicit.
Nov 13 2020, 1:12 AM
lhames committed rG1bf805dd2cb2: [examples] Fix Kaleidoscope examples after OrcJIT break-up / remote TPC commit. (authored by lhames).
[examples] Fix Kaleidoscope examples after OrcJIT break-up / remote TPC commit.
Nov 13 2020, 12:13 AM

Nov 12 2020

lhames committed rG935ca5a1a7be: [examples] Fix Kaleidoscope examples after OrcJIT break-up / remote TPC commit. (authored by lhames).
[examples] Fix Kaleidoscope examples after OrcJIT break-up / remote TPC commit.
Nov 12 2020, 11:45 PM
lhames committed rGdabc914d2bd5: [ORC][examples] Fix include and library dependence for SpeculativeJIT example. (authored by lhames).
[ORC][examples] Fix include and library dependence for SpeculativeJIT example.
Nov 12 2020, 11:25 PM
lhames committed rG98f70e94e059: [ORC] Add dependence of OrcJIT on OrcTargetProcess. (authored by lhames).
[ORC] Add dependence of OrcJIT on OrcTargetProcess.
Nov 12 2020, 11:10 PM
lhames committed rGd3715b5a060f: [ORC] Make WrapperFunctionResult::zeroInit static (authored by lhames).
[ORC] Make WrapperFunctionResult::zeroInit static
Nov 12 2020, 10:15 PM
lhames committed rGbdf26d8d1935: [ORC] Remove designated initializer. (authored by lhames).
[ORC] Remove designated initializer.
Nov 12 2020, 10:12 PM
lhames committed rG1d0676b54c4e: [ORC] Break up OrcJIT library, add Orc-RPC based remote TargetProcessControl (authored by lhames).
[ORC] Break up OrcJIT library, add Orc-RPC based remote TargetProcessControl
Nov 12 2020, 10:06 PM

Nov 11 2020

lhames committed rGc7e64df44559: [docs] Fix formatting, clarify comment in ORCv2 doc (authored by lhames).
[docs] Fix formatting, clarify comment in ORCv2 doc
Nov 11 2020, 6:19 PM
lhames committed rG48ee1ea05cc0: [docs] Fix formatting in ORCv2.rst. (authored by lhames).
[docs] Fix formatting in ORCv2.rst.
Nov 11 2020, 4:10 PM
lhames committed rG984e87923f10: [docs] Update ORCv2 design doc. (authored by lhames).
[docs] Update ORCv2 design doc.
Nov 11 2020, 3:54 PM
lhames updated the diff for D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..

Make executable symbols in llvm-jitlink-executor visible.

Nov 11 2020, 2:45 PM · Restricted Project

Nov 10 2020

lhames added a comment to D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..

Please let me know if you have any other thoughts / comments, otherwise I'm hoping to commit this by the end of the week so we can move on to the next step: Full support for initializers in remote processes.

Nov 10 2020, 6:03 PM · Restricted Project
lhames updated the diff for D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..

Address review comments.

Nov 10 2020, 5:40 PM · Restricted Project
lhames added a comment to D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..

Ok, actually the headers don't follow the breakdown. Why is that?

Nov 10 2020, 5:39 PM · Restricted Project
lhames committed rGe7a63df88ccc: [ORC] Add debugging output for ResourceTracker to be used in JITDylib::define. (authored by lhames).
[ORC] Add debugging output for ResourceTracker to be used in JITDylib::define.
Nov 10 2020, 3:59 PM

Nov 5 2020

lhames accepted D89373: Fixed dangling reference in RuntimeDyldELF.

Looks good to me. Thanks Moritz!

Nov 5 2020, 10:23 AM · Restricted Project

Nov 3 2020

lhames accepted D90722: [RTDYLD] support absolute relocations where needed.

Hi Jameson, Valentin,

Nov 3 2020, 7:15 PM · Restricted Project

Oct 30 2020

lhames added a comment to D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..

I'm curious to get your take on the library breakdown and corresponding headers too. We now have:

Oct 30 2020, 9:32 PM · Restricted Project
lhames added inline comments to D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..
Oct 30 2020, 8:47 PM · Restricted Project
lhames updated the diff for D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..

Fix diff to include original changes.

Oct 30 2020, 8:45 PM · Restricted Project
lhames updated the diff for D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..

Address review comments.

Oct 30 2020, 8:44 PM · Restricted Project

Oct 29 2020

lhames accepted D90331: [JITLink][ELF] Implement R_X86_64_PLT32 relocations.

Looks great to me. Thanks very much Stefan!

Oct 29 2020, 12:45 PM · Restricted Project

Oct 28 2020

lhames added a comment to D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

Thanks a lot for your help!
Being very new here, I do not have commit access to land this, could you please land this?

Hi Elena,

I missed that this included a definition of a git submodule. This would be the first in the main LLVM tree and I think we'd need to ask the community about inclusion. Is it required for this patch, or could it be dropped and downloading of that module left to clients who want to enable Intel JIT events support?

Hi Lang!

At my opinion, to add submodule is a good solution for open source project to be up to date with ITT API source.
The alternative solution - just add necessary source files from ITT API to the llvm/lib/ExecutionEngine/IntelJITEvents/ directory and manually update them from time to time.
How do you think, what is better to implement in my case?

Oct 28 2020, 7:20 PM · Restricted Project

Oct 27 2020

lhames added a comment to D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

Thanks a lot for your help!
Being very new here, I do not have commit access to land this, could you please land this?

Oct 27 2020, 4:05 PM · Restricted Project

Oct 25 2020

lhames requested review of D90132: [ORC] Prototype ORC library reorg + RPC based TargetProcessControl..
Oct 25 2020, 11:07 PM · Restricted Project
lhames updated subscribers of D89758: Unconditionally #include <future>.

Hi Geoffrey,

Oct 25 2020, 10:23 PM · Restricted Project

Oct 23 2020

lhames committed rG996a8b42aa2d: Re-apply "[JITLink][ELF] Add support for ELF::R_X86_64_REX_GOTPCRELX relocation" (authored by lhames).
Re-apply "[JITLink][ELF] Add support for ELF::R_X86_64_REX_GOTPCRELX relocation"
Oct 23 2020, 9:49 AM

Oct 22 2020

lhames accepted D89795: [jitlink][ELF] Add zero-fill blocks for symbols in section SHN_COMMON.

This looks good to me.

Oct 22 2020, 11:32 PM · Restricted Project
lhames added a reverting change for rGe2fceec2fd15: [JITLink][ELF] Add support for ELF::R_X86_64_REX_GOTPCRELX relocation.: rG0f910387e610: Revert "[JITLink][ELF] Add support for ELF::R_X86_64_REX_GOTPCRELX relocation.".
Oct 22 2020, 11:22 PM
lhames committed rG0f910387e610: Revert "[JITLink][ELF] Add support for ELF::R_X86_64_REX_GOTPCRELX relocation." (authored by lhames).
Revert "[JITLink][ELF] Add support for ELF::R_X86_64_REX_GOTPCRELX relocation."
Oct 22 2020, 11:22 PM
lhames committed rGe2fceec2fd15: [JITLink][ELF] Add support for ELF::R_X86_64_REX_GOTPCRELX relocation. (authored by lhames).
[JITLink][ELF] Add support for ELF::R_X86_64_REX_GOTPCRELX relocation.
Oct 22 2020, 10:43 PM
lhames added a comment to D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

I agree that I can't see how this would affect things. Fine with this going in and taking our chances.

Oct 22 2020, 2:19 PM · Restricted Project

Oct 20 2020

lhames added a comment to D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

It's not clear to me that Elena's patch should affect this. I'm inclined to accept it and just keep an eye on the bots. If everything passes we can chalk it up to a misconfig on Harbormaster. If the bots fail we can revert, and maybe the logs will give us some more insight into what's going on.

Oct 20 2020, 2:20 PM · Restricted Project
lhames added a comment to D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

@jingham @clayborg Do either of you recognize the error that seems to be triggered? It looks like it's consistent across the tests, or at least the ones that I looked at:

Oct 20 2020, 2:19 PM · Restricted Project

Oct 19 2020

lhames accepted D89758: Unconditionally #include <future>.

Looks good to me. Thanks Geoffrey!

Oct 19 2020, 7:57 PM · Restricted Project
lhames committed rG1044dfa7edb7: [ORC] Remove commented out methods accidentally left in in 069919c9ba3. (authored by lhames).
[ORC] Remove commented out methods accidentally left in in 069919c9ba3.
Oct 19 2020, 7:55 PM
lhames committed rG9898d9d885c7: [ORC] Fix a missing include. (authored by lhames).
[ORC] Fix a missing include.
Oct 19 2020, 12:14 PM
lhames committed rGc89447b65984: [ORC] Fix unused variable warning. (authored by lhames).
[ORC] Fix unused variable warning.
Oct 19 2020, 9:07 AM
lhames committed rGf35707047e21: [ORC] Break up C-API header Orc.h, and add JITEventListener support. (authored by lhames).
[ORC] Break up C-API header Orc.h, and add JITEventListener support.
Oct 19 2020, 2:01 AM
lhames committed rG00369849e109: [ORC] Add function to get pool entry string. (authored by lhames).
[ORC] Add function to get pool entry string.
Oct 19 2020, 2:01 AM
lhames committed rG24afffe63a7b: [ORC] Add C API support for defining absolute symbols. (authored by lhames).
[ORC] Add C API support for defining absolute symbols.
Oct 19 2020, 2:01 AM
lhames committed rGb6ca0c7dd535: [ORC] Add support for custom generators to the C bindings. (authored by lhames).
[ORC] Add support for custom generators to the C bindings.
Oct 19 2020, 2:01 AM
lhames committed rG19402ce79a89: [Support] Add a C-API function to create a StringError instance. (authored by lhames).
[Support] Add a C-API function to create a StringError instance.
Oct 19 2020, 2:01 AM
lhames committed rG4b477e776382: [ORC] Add an OrcV2 ResourceTracker / Removable-code example. (authored by lhames).
[ORC] Add an OrcV2 ResourceTracker / Removable-code example.
Oct 19 2020, 2:00 AM
lhames committed rG91d1f417fd89: [ORC] Add basic ResourceTracker support to the OrcV2 C Bindings. (authored by lhames).
[ORC] Add basic ResourceTracker support to the OrcV2 C Bindings.
Oct 19 2020, 2:00 AM
lhames committed rG49c065ae70ec: [ORC] Rename LLVMOrcJITDylibDefinitionGeneratorRef. (authored by lhames).
[ORC] Rename LLVMOrcJITDylibDefinitionGeneratorRef.
Oct 19 2020, 2:00 AM
lhames committed rG40f3fb52f706: [ORC] Fix C API function name. (authored by lhames).
[ORC] Fix C API function name.
Oct 19 2020, 2:00 AM
lhames committed rG35e48d7b9173: [ORC] Add C API functions to obtain and clear the symbol string pool. (authored by lhames).
[ORC] Add C API functions to obtain and clear the symbol string pool.
Oct 19 2020, 2:00 AM
lhames committed rG14cb9b4e21de: [ORC] Add a C API function to set the ExecutionSession error reporter. (authored by lhames).
[ORC] Add a C API function to set the ExecutionSession error reporter.
Oct 19 2020, 2:00 AM
lhames committed rGc88d9eae8a71: [ORC] Fix a memory leak in the OrcV2 C API (and some comment typos). (authored by lhames).
[ORC] Fix a memory leak in the OrcV2 C API (and some comment typos).
Oct 19 2020, 2:00 AM
lhames committed rG069919c9ba33: [ORC] Update Symbol Lookup / DefinitionGenerator system. (authored by lhames).
[ORC] Update Symbol Lookup / DefinitionGenerator system.
Oct 19 2020, 2:00 AM
lhames committed rG5d2e359ce62f: [ORC] Move DefinitionGenerator out of JITDylib. (authored by lhames).
[ORC] Move DefinitionGenerator out of JITDylib.
Oct 19 2020, 2:00 AM
lhames committed rG680845ec0d61: [ORC] Move MaterializationResponsibility methods to ExecutionSession. (authored by lhames).
[ORC] Move MaterializationResponsibility methods to ExecutionSession.
Oct 19 2020, 2:00 AM
lhames committed rG039f3d01cbff: [examples] Fix test: Kaleidoscope Chapter 4 no longer supports redefinition. (authored by lhames).
[examples] Fix test: Kaleidoscope Chapter 4 no longer supports redefinition.
Oct 19 2020, 12:36 AM
lhames committed rG7579941d8b02: [examples] Fix Kaleidoscope-Ch3, which was broken by ad92f16ccc5. (authored by lhames).
[examples] Fix Kaleidoscope-Ch3, which was broken by ad92f16ccc5.
Oct 19 2020, 12:27 AM
lhames committed rGd54c4e382114: [ORC] Move SimpleResourceManager function object inits out of constructor. (authored by lhames).
[ORC] Move SimpleResourceManager function object inits out of constructor.
Oct 19 2020, 12:20 AM
lhames committed rG0aa5e34f6591: [ORC] Add a missing '&'. (authored by lhames).
[ORC] Add a missing '&'.
Oct 19 2020, 12:20 AM

Oct 18 2020

lhames committed rGad92f16ccc5f: [ORC][examples] Update Kaleidoscope and BuildingAJIT tutorial series to OrcV2. (authored by lhames).
[ORC][examples] Update Kaleidoscope and BuildingAJIT tutorial series to OrcV2.
Oct 18 2020, 9:23 PM
lhames committed rG0aec49c8531b: [ORC] Add support for resource tracking/removal (removable code). (authored by lhames).
[ORC] Add support for resource tracking/removal (removable code).
Oct 18 2020, 9:23 PM
lhames committed rG6154c4115cd4: [ORC] Remove OrcV1 APIs. (authored by lhames).
[ORC] Remove OrcV1 APIs.
Oct 18 2020, 9:23 PM

Oct 6 2020

lhames added a comment to D86435: Profiling the code generated by MCJIT engine using Intel VTune profiler.

Hi @lhames @andrew.w.kaylor

Looking at "Build Status" for the last diff, I can see 29 tests failed (windows) and 41 tests failed (linux).
do you think that tests failures are related to my commit?
Thank you in advance!

Oct 6 2020, 8:09 PM · Restricted Project
lhames added a comment to D88344: Fix useless move() in IRCompileLayer.h.

Yes, please go ahead and abandon this review -- it will be fixed as soon as the orcv1-removal patch lands. Thank you for the contribution though!

Oct 6 2020, 8:03 PM · Restricted Project