Page MenuHomePhabricator

lhames (Lang Hames)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2013, 2:34 PM (329 w, 6 d)

Recent Activity

Today

lhames added a comment to D63518: BitStream reader: propagate errors.

I haven't had a chance to audit the whole patch yet, but in general the error suppression idioms are unsafe (though maybe no more so than the existing code?).

Tue, Jun 25, 3:03 PM · Restricted Project, Restricted Project

Sat, Jun 15

lhames added inline comments to D63378: [ORC] WIP Speculative compilation.
Sat, Jun 15, 10:24 AM · Restricted Project, Restricted Project
lhames added a comment to D63378: [ORC] WIP Speculative compilation.

This is an excellent start!

Sat, Jun 15, 10:15 AM · Restricted Project, Restricted Project

Fri, Jun 14

lhames committed rG1b091540d28e: [JITLink] Move JITLinkMemoryManager into its own header. (authored by lhames).
[JITLink] Move JITLinkMemoryManager into its own header.
Fri, Jun 14, 12:39 PM
lhames committed rL363444: [JITLink] Move JITLinkMemoryManager into its own header..
[JITLink] Move JITLinkMemoryManager into its own header.
Fri, Jun 14, 12:38 PM

Thu, Jun 13

lhames committed rG2f8c6f93626e: [ORC] Rename MaterializationResponsibility resolve and emit methods to… (authored by lhames).
[ORC] Rename MaterializationResponsibility resolve and emit methods to…
Thu, Jun 13, 1:09 PM
lhames committed rL363322: [ORC] Rename MaterializationResponsibility resolve and emit methods to.
[ORC] Rename MaterializationResponsibility resolve and emit methods to
Thu, Jun 13, 1:09 PM
lhames accepted D62491: Updating Kaleidoscope tutorial to Synchronize with ORC v2 APIs.

This looks good to me. Thanks Praveen!

Thu, Jun 13, 8:00 AM · Restricted Project

Fri, Jun 7

lhames committed rGd4a8089f035a: [ORC] Update symbol lookup to use a single callback with a required symbol… (authored by lhames).
[ORC] Update symbol lookup to use a single callback with a required symbol…
Fri, Jun 7, 12:32 PM
lhames committed rL362832: [ORC] Update symbol lookup to use a single callback with a required symbol state.
[ORC] Update symbol lookup to use a single callback with a required symbol state
Fri, Jun 7, 12:30 PM

Mon, Jun 3

lhames committed rG357e8a390ca9: [ORC] Use uint8_t for bitfields in SymbolTableEntry. (authored by lhames).
[ORC] Use uint8_t for bitfields in SymbolTableEntry.
Mon, Jun 3, 3:01 PM
lhames committed rL362450: [ORC] Use uint8_t for bitfields in SymbolTableEntry..
[ORC] Use uint8_t for bitfields in SymbolTableEntry.
Mon, Jun 3, 3:00 PM

Thu, May 30

lhames committed rGa100042b27f6: [RuntimeDyld] Update reserveAllocationSpace to account for stub padding. (authored by lhames).
[RuntimeDyld] Update reserveAllocationSpace to account for stub padding.
Thu, May 30, 1:56 PM
lhames committed rL362151: [RuntimeDyld] Update reserveAllocationSpace to account for stub padding..
[RuntimeDyld] Update reserveAllocationSpace to account for stub padding.
Thu, May 30, 1:55 PM
lhames committed rG0e124b37bd7f: [RuntimeDyld] Apply padding and alignment bumps to all sections with stubs, and… (authored by lhames).
[RuntimeDyld] Apply padding and alignment bumps to all sections with stubs, and…
Thu, May 30, 12:58 PM
lhames committed rL362139: [RuntimeDyld] Apply padding and alignment bumps to all sections with stubs, and.
[RuntimeDyld] Apply padding and alignment bumps to all sections with stubs, and
Thu, May 30, 12:56 PM

Tue, May 28

lhames committed rGeb5ee3004f79: [ORC] Track JIT symbol states more explicitly. (authored by lhames).
[ORC] Track JIT symbol states more explicitly.
Tue, May 28, 4:34 PM
lhames committed rL361899: [ORC] Track JIT symbol states more explicitly..
[ORC] Track JIT symbol states more explicitly.
Tue, May 28, 4:34 PM

Mon, May 27

lhames committed rG23343c5d90bb: [RuntimeDyld][ARM] Fix an incorrect assertion condition. (authored by lhames).
[RuntimeDyld][ARM] Fix an incorrect assertion condition.
Mon, May 27, 2:33 PM
lhames committed rL361782: [RuntimeDyld][ARM] Fix an incorrect assertion condition..
[RuntimeDyld][ARM] Fix an incorrect assertion condition.
Mon, May 27, 2:33 PM

May 22 2019

lhames committed rGa98a4fb57f5e: [ORC] Remove a stray decl that accidentally found its way in to r361322. (authored by lhames).
[ORC] Remove a stray decl that accidentally found its way in to r361322.
May 22 2019, 3:55 PM
lhames committed rL361441: [ORC] Remove a stray decl that accidentally found its way in to r361322..
[ORC] Remove a stray decl that accidentally found its way in to r361322.
May 22 2019, 3:55 PM
lhames committed rG00be4e68ad63: [docs] Make a note of the HowToUseLLJIT example in the ORCv2 design doc. (authored by lhames).
[docs] Make a note of the HowToUseLLJIT example in the ORCv2 design doc.
May 22 2019, 2:43 PM
lhames committed rL361437: [docs] Make a note of the HowToUseLLJIT example in the ORCv2 design doc..
[docs] Make a note of the HowToUseLLJIT example in the ORCv2 design doc.
May 22 2019, 2:43 PM
lhames committed rGe3748b5a8575: Add a HowToUseLLJIT example project. (authored by lhames).
Add a HowToUseLLJIT example project.
May 22 2019, 2:36 PM
lhames committed rL361435: Add a HowToUseLLJIT example project..
Add a HowToUseLLJIT example project.
May 22 2019, 2:36 PM

May 21 2019

lhames committed rGa2ee80b084e5: [ORC] Guarantee unique JITDylib names in lli, add usage notes to createJITDylib. (authored by lhames).
[ORC] Guarantee unique JITDylib names in lli, add usage notes to createJITDylib.
May 21 2019, 3:08 PM
lhames committed rL361322: [ORC] Guarantee unique JITDylib names in lli, add usage notes to createJITDylib..
[ORC] Guarantee unique JITDylib names in lli, add usage notes to createJITDylib.
May 21 2019, 3:08 PM
lhames added a comment to D39111: Extensible LLVM RTTI.

Gentle ping. Work on JITLink bought me some time, but I'm starting to hit situations where I would like to use this again. ;)

May 21 2019, 2:04 PM · Restricted Project
lhames added a comment to D62120: [ORC] fix unreachable code bug.

We don't want to clear unconditionally: we should (at least optionally) preserve the state so that clients can attempt recovery from transient errors (e.g. network drop-outs).

May 21 2019, 11:30 AM · Restricted Project

May 20 2019

lhames committed rGf088e195cc2a: [ORC] Assert that JITDylibs have unique names. (authored by lhames).
[ORC] Assert that JITDylibs have unique names.
May 20 2019, 8:22 PM
lhames committed rL361215: [ORC] Assert that JITDylibs have unique names..
[ORC] Assert that JITDylibs have unique names.
May 20 2019, 8:22 PM
lhames closed D62139: Ensuring unique names for JITDylib's.
May 20 2019, 8:22 PM · Restricted Project
lhames added a comment to D62139: Ensuring unique names for JITDylib's.

Oh -- I missed that this was passing the name as a std::string by value. This will result in unnecessary string copies. In general for a case like this you would use an llvm::StringRef -- It's a lightweight string reference type. I'll switch to that before committing.

May 20 2019, 7:33 PM · Restricted Project
lhames accepted D62139: Ensuring unique names for JITDylib's.

Looks good to me.

May 20 2019, 7:02 PM · Restricted Project
lhames accepted D62112: [ORC] fix use-after-move. NFC.

LGTM! Thanks Nick!

May 20 2019, 2:50 PM · Restricted Project
lhames added a comment to D62139: Ensuring unique names for JITDylib's.

Yeah -- this seems to be missing the header side of the patch. You should be able to use the "update diff" option to create a new diff (still attached to this revision) with both sides of the change.

May 20 2019, 2:38 PM · Restricted Project
lhames committed rG54dc01cbfc4f: [docs] Fix an RST typo: "code-blocks" should be "code-block". (authored by lhames).
[docs] Fix an RST typo: "code-blocks" should be "code-block".
May 20 2019, 2:32 PM
lhames committed rL361200: [docs] Fix an RST typo: "code-blocks" should be "code-block"..
[docs] Fix an RST typo: "code-blocks" should be "code-block".
May 20 2019, 2:32 PM
lhames committed rG0dcf69eb8287: [ORC] Remove some unreachable code. (authored by lhames).
[ORC] Remove some unreachable code.
May 20 2019, 2:32 PM
lhames committed rL361199: [ORC] Remove some unreachable code..
[ORC] Remove some unreachable code.
May 20 2019, 2:27 PM
lhames committed rG4dfa665ebf10: [docs] Add more details/examples for LLJIT/LLLazyJIT, tweak lookup discussion. (authored by lhames).
[docs] Add more details/examples for LLJIT/LLLazyJIT, tweak lookup discussion.
May 20 2019, 2:06 PM
lhames committed rL361198: [docs] Add more details/examples for LLJIT/LLLazyJIT, tweak lookup discussion..
[docs] Add more details/examples for LLJIT/LLLazyJIT, tweak lookup discussion.
May 20 2019, 2:06 PM
lhames closed D61599: [Support] Reverted r357058 and r351916, MemoryBlock class now exposes its allocated size instead of requested size..

Committed in r361195.

May 20 2019, 2:00 PM · Restricted Project
lhames committed rG93d2bdda6bfe: [Support] Renamed member 'Size' to 'AllocatedSize' in MemoryBlock and… (authored by lhames).
[Support] Renamed member 'Size' to 'AllocatedSize' in MemoryBlock and…
May 20 2019, 1:51 PM
lhames committed rL361195: [Support] Renamed member 'Size' to 'AllocatedSize' in MemoryBlock and….
[Support] Renamed member 'Size' to 'AllocatedSize' in MemoryBlock and…
May 20 2019, 1:50 PM

May 17 2019

lhames committed rG82c3f3dae0e0: [docs] Fix some RST errors. (authored by lhames).
[docs] Fix some RST errors.
May 17 2019, 8:21 PM
lhames committed rL361092: [docs] Fix some RST errors..
[docs] Fix some RST errors.
May 17 2019, 8:20 PM
lhames committed rG5f36a28556c3: [docs][ORC] Start work on an ORC design doc. Very much a work in progress. (authored by lhames).
[docs][ORC] Start work on an ORC design doc. Very much a work in progress.
May 17 2019, 8:07 PM
lhames committed rL361089: [docs][ORC] Start work on an ORC design doc. Very much a work in progress..
[docs][ORC] Start work on an ORC design doc. Very much a work in progress.
May 17 2019, 8:06 PM

May 16 2019

lhames committed rGc97b50e2247f: [ORC] Change handling for SymbolStringPtr tombstones and empty keys. (authored by lhames).
[ORC] Change handling for SymbolStringPtr tombstones and empty keys.
May 16 2019, 11:28 AM
lhames committed rL360925: [ORC] Change handling for SymbolStringPtr tombstones and empty keys..
[ORC] Change handling for SymbolStringPtr tombstones and empty keys.
May 16 2019, 11:27 AM
lhames added a comment to D59107: [Support] Add error handling to sys::Process::getPageSize()..

Sorry I missed them, and thanks very much for the fix Sven!

May 16 2019, 10:33 AM · Restricted Project
lhames committed rGd18f58166c06: [ORC] Use inline friend definitions for SymbolStringPtr operators. (authored by lhames).
[ORC] Use inline friend definitions for SymbolStringPtr operators.
May 16 2019, 10:22 AM
lhames committed rL360917: [ORC] Use inline friend definitions for SymbolStringPtr operators..
[ORC] Use inline friend definitions for SymbolStringPtr operators.
May 16 2019, 10:17 AM

May 15 2019

lhames committed rG46441a734ee9: [ORC] Modify DenseMap hashing for SymbolStringPtrs. (authored by lhames).
[ORC] Modify DenseMap hashing for SymbolStringPtrs.
May 15 2019, 5:19 PM
lhames committed rGc2fb896522fe: [JITLink][MachO] Use getSymbol64TableEntry for 64-bit MachO files. (authored by lhames).
[JITLink][MachO] Use getSymbol64TableEntry for 64-bit MachO files.
May 15 2019, 5:19 PM
lhames committed rL360831: [ORC] Modify DenseMap hashing for SymbolStringPtrs..
[ORC] Modify DenseMap hashing for SymbolStringPtrs.
May 15 2019, 5:19 PM
lhames committed rL360830: [JITLink][MachO] Use getSymbol64TableEntry for 64-bit MachO files..
[JITLink][MachO] Use getSymbol64TableEntry for 64-bit MachO files.
May 15 2019, 5:19 PM

May 14 2019

lhames accepted D61599: [Support] Reverted r357058 and r351916, MemoryBlock class now exposes its allocated size instead of requested size..

Formally accepting so Phab does not gripe at me when this gets committed. :)

May 14 2019, 1:05 PM · Restricted Project
lhames added a comment to D61599: [Support] Reverted r357058 and r351916, MemoryBlock class now exposes its allocated size instead of requested size..

Looks good to me. Thanks so much for all your work on this Machiel!

May 14 2019, 1:05 PM · Restricted Project
lhames accepted D61714: [MachO] Fix two bugs with reexported dylibs.

Is it possible to write a test case for this? Otherwise LGTM. Thanks for all the work on this! :)

May 14 2019, 12:48 PM · Restricted Project

May 13 2019

lhames committed rG56baade10dcf: [JITLink][MachO] Honor the no-dead-strip flag on nlist entries. (authored by lhames).
[JITLink][MachO] Honor the no-dead-strip flag on nlist entries.
May 13 2019, 1:53 PM
lhames committed rL360618: [JITLink][MachO] Honor the no-dead-strip flag on nlist entries..
[JITLink][MachO] Honor the no-dead-strip flag on nlist entries.
May 13 2019, 1:52 PM

May 12 2019

lhames committed rG45139290942c: [JITLink] Track section alignment and make sure it is respected during layout. (authored by lhames).
[JITLink] Track section alignment and make sure it is respected during layout.
May 12 2019, 9:50 PM
lhames committed rL360555: [JITLink] Track section alignment and make sure it is respected during layout..
[JITLink] Track section alignment and make sure it is respected during layout.
May 12 2019, 9:48 PM
lhames committed rG23085ec36d08: [JITLink] Add a test for zero-filled content. (authored by lhames).
[JITLink] Add a test for zero-filled content.
May 12 2019, 3:27 PM
lhames committed rG27415e7a92fa: [ORC] Fix some typos. (authored by lhames).
[ORC] Fix some typos.
May 12 2019, 3:26 PM
lhames committed rL360547: [JITLink] Add a test for zero-filled content..
[JITLink] Add a test for zero-filled content.
May 12 2019, 3:26 PM
lhames committed rL360546: [ORC] Fix some typos..
[ORC] Fix some typos.
May 12 2019, 3:26 PM

May 10 2019

lhames committed rGb3d6073b3caa: [ORC] Make a narrowing-cast explicit to silence a compiler warning. (authored by lhames).
[ORC] Make a narrowing-cast explicit to silence a compiler warning.
May 10 2019, 3:49 PM
lhames committed rL360478: [ORC] Make a narrowing-cast explicit to silence a compiler warning..
[ORC] Make a narrowing-cast explicit to silence a compiler warning.
May 10 2019, 3:49 PM
lhames committed rGb0cecfc90701: [JITLink][MachO] Mark atoms in sections 'no-dead-strip' set live by default. (authored by lhames).
[JITLink][MachO] Mark atoms in sections 'no-dead-strip' set live by default.
May 10 2019, 3:23 PM
lhames committed rL360477: [JITLink][MachO] Mark atoms in sections 'no-dead-strip' set live by default..
[JITLink][MachO] Mark atoms in sections 'no-dead-strip' set live by default.
May 10 2019, 3:22 PM
lhames accepted D61793: Fixing typos.

Thanks Praveen!

May 10 2019, 3:14 PM · Restricted Project

May 9 2019

lhames committed rG112967833e4f: [JITLink] Fixed a signedness bug when processing X86_64_RELOC_SUBTRACTOR. (authored by lhames).
[JITLink] Fixed a signedness bug when processing X86_64_RELOC_SUBTRACTOR.
May 9 2019, 4:20 PM
lhames committed rL360392: [JITLink] Fixed a signedness bug when processing X86_64_RELOC_SUBTRACTOR..
[JITLink] Fixed a signedness bug when processing X86_64_RELOC_SUBTRACTOR.
May 9 2019, 4:15 PM
lhames committed rG5e332f19928f: [ORC] Simplify logic for updating edges when should-discard atoms are pruned. (authored by lhames).
[ORC] Simplify logic for updating edges when should-discard atoms are pruned.
May 9 2019, 3:04 PM
lhames committed rGdd61274f775a: [JITLink] Improve/fix some JITLink debugging output. (authored by lhames).
[JITLink] Improve/fix some JITLink debugging output.
May 9 2019, 3:03 PM
lhames committed rG5fa4e9d99018: [ORC] Fix a formatting bug. (authored by lhames).
[ORC] Fix a formatting bug.
May 9 2019, 3:03 PM
lhames committed rL360384: [ORC] Simplify logic for updating edges when should-discard atoms are pruned..
[ORC] Simplify logic for updating edges when should-discard atoms are pruned.
May 9 2019, 3:02 PM
lhames committed rL360383: [JITLink] Improve/fix some JITLink debugging output..
[JITLink] Improve/fix some JITLink debugging output.
May 9 2019, 3:02 PM
lhames committed rL360382: [ORC] Fix a formatting bug..
[ORC] Fix a formatting bug.
May 9 2019, 3:02 PM

May 8 2019

Herald added a project to D51126: [ORC] LLJIT::Create() proposal: add flag to enable multithreaded codegen: Restricted Project.

I suggest we close this: The code is stale now, though the idea could be applied (and would be a neater fit) in the new LLJITBuilder utility.

May 8 2019, 3:48 PM · Restricted Project

May 7 2019

lhames committed rGe4b4ab6d26f8: [Support] Add error handling to sys::Process::getPageSize(). (authored by lhames).
[Support] Add error handling to sys::Process::getPageSize().
May 7 2019, 7:10 PM
lhames committed rL360221: [Support] Add error handling to sys::Process::getPageSize()..
[Support] Add error handling to sys::Process::getPageSize().
May 7 2019, 7:10 PM
lhames closed D59107: [Support] Add error handling to sys::Process::getPageSize()..
May 7 2019, 7:10 PM · Restricted Project
lhames committed rG0d8ae1e3435a: Reapply r360194 "[JITLink] Add support for MachO .alt_entry atoms." with fixes. (authored by lhames).
Reapply r360194 "[JITLink] Add support for MachO .alt_entry atoms." with fixes.
May 7 2019, 3:56 PM
lhames committed rL360205: Reapply r360194 "[JITLink] Add support for MachO .alt_entry atoms." with fixes..
Reapply r360194 "[JITLink] Add support for MachO .alt_entry atoms." with fixes.
May 7 2019, 3:56 PM
lhames committed rG1a10101e2182: Revert r360194 "[JITLink] Add support for MachO .alt_entry atoms." (authored by lhames).
Revert r360194 "[JITLink] Add support for MachO .alt_entry atoms."
May 7 2019, 3:19 PM
lhames committed rL360200: Revert r360194 "[JITLink] Add support for MachO .alt_entry atoms.".
Revert r360194 "[JITLink] Add support for MachO .alt_entry atoms."
May 7 2019, 3:17 PM
lhames added a comment to D61599: [Support] Reverted r357058 and r351916, MemoryBlock class now exposes its allocated size instead of requested size..

Great! Thanks so much Machiel!

May 7 2019, 2:49 PM · Restricted Project
lhames committed rG2b09b25e4868: [JITLink] Add support for MachO .alt_entry atoms. (authored by lhames).
[JITLink] Add support for MachO .alt_entry atoms.
May 7 2019, 2:35 PM
lhames committed rL360194: [JITLink] Add support for MachO .alt_entry atoms..
[JITLink] Add support for MachO .alt_entry atoms.
May 7 2019, 2:34 PM
lhames added a comment to D61599: [Support] Reverted r357058 and r351916, MemoryBlock class now exposes its allocated size instead of requested size..

Yes I agree it would be better if the Size member of MemoryBlock just held the allocated size. This would mean that r357058 and r351916 (and perhaps others) should be reverted.

May 7 2019, 1:02 PM · Restricted Project
lhames added a comment to D56941: MemoryBlock: Do not automatically extend a given size to a multiple of page size..

See discussion on https://reviews.llvm.org/D61599.

May 7 2019, 1:02 PM · Restricted Project
Herald added a project to D56941: MemoryBlock: Do not automatically extend a given size to a multiple of page size.: Restricted Project.

Bah -- I missed this at the time. This should be reverted. We can rename methods to clarify, but MemoryBlock should hold the allocated size, not the requested size.

May 7 2019, 12:58 PM · Restricted Project
lhames requested changes to D61599: [Support] Reverted r357058 and r351916, MemoryBlock class now exposes its allocated size instead of requested size..

I don't think this is the right solution. MemoryBlock's purpose is to track the allocated memory. What the client does with that memory (including subdividing it) is their business. The client already knows the number of bytes they're requesting, so the fix for fragmentation in SectionMemoryManager should be limited to fixes in SectionMemoryManager.

May 7 2019, 11:11 AM · Restricted Project
lhames committed rG4f349404da89: [JITLink] Fix some copy/paste related typos in a test case. (authored by lhames).
[JITLink] Fix some copy/paste related typos in a test case.
May 7 2019, 8:35 AM
lhames committed rL360160: [JITLink] Fix some copy/paste related typos in a test case..
[JITLink] Fix some copy/paste related typos in a test case.
May 7 2019, 8:35 AM