Minor style nits aside, this looks great. Once you've addressed them (and run clang-format over the patch) feel free to commit this to the mainline and continue development there. :)

Wed, Jul 31, 10:44 AM · Restricted Project, Restricted Project

Jul 18 2019

lhames committed rGbcccd04b7a40: Update the SimpleJIT class in the clang-interpreter example to use ORCv2. (authored by lhames).

Update the SimpleJIT class in the clang-interpreter example to use ORCv2.

Jul 18 2019, 3:48 PM

lhames committed rL366511: Update the SimpleJIT class in the clang-interpreter example to use ORCv2..

Update the SimpleJIT class in the clang-interpreter example to use ORCv2.

Jul 18 2019, 3:47 PM

lhames committed rG9e52d0576ab7: [ORC] Suppress an ORCv1 deprecation warning. (authored by lhames).

[ORC] Suppress an ORCv1 deprecation warning.

Jul 18 2019, 12:59 PM

lhames committed rL366485: [ORC] Suppress an ORCv1 deprecation warning..

[ORC] Suppress an ORCv1 deprecation warning.

Jul 18 2019, 12:56 PM

Jul 17 2019

lhames committed rG1716454027db: [ORC] Add deprecation warnings to ORCv1 layers and utilities. (authored by lhames).

[ORC] Add deprecation warnings to ORCv1 layers and utilities.

Jul 17 2019, 9:42 AM

lhames committed rL366344: [ORC] Add deprecation warnings to ORCv1 layers and utilities..

[ORC] Add deprecation warnings to ORCv1 layers and utilities.

Jul 17 2019, 9:40 AM

lhames closed D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities..

Jul 17 2019, 9:40 AM · Restricted Project

Jul 16 2019

lhames added a comment to D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities..

I’m going to land this. There may be fallout to example programs and other LLVM projects and want to try to shake that out before the 9.0 branch gets cut.

Jul 16 2019, 4:59 PM · Restricted Project

lhames updated the diff for D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities..

[ORC] Add a deprecation note to the lli -jit-kind=orc-mcjit option.

Jul 16 2019, 4:54 PM · Restricted Project

lhames added a comment to D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities..

In D64609#1588195, @sgraenitz wrote:

72 work with orc-lazy https://reviews.llvm.org/differential/diff/210161/

Jul 16 2019, 4:53 PM · Restricted Project

lhames committed rGc23619b0c900: [ORC][docs] Fix an RST error: the code-block directive needs a newline after it. (authored by lhames).

[ORC][docs] Fix an RST error: the code-block directive needs a newline after it.

Jul 16 2019, 2:44 PM

lhames committed rL366270: [ORC][docs] Fix an RST error: the code-block directive needs a newline after it..

[ORC][docs] Fix an RST error: the code-block directive needs a newline after it.

Jul 16 2019, 2:43 PM

lhames committed rG607cd44bdc6a: [ORC][docs] Trim ORCv1 to ORCv2 transition section, add a how-to section. (authored by lhames).

[ORC][docs] Trim ORCv1 to ORCv2 transition section, add a how-to section.

Jul 16 2019, 2:37 PM

lhames committed rL366269: [ORC][docs] Trim ORCv1 to ORCv2 transition section, add a how-to section..

[ORC][docs] Trim ORCv1 to ORCv2 transition section, add a how-to section.

Jul 16 2019, 2:37 PM

Jul 15 2019

lhames committed rG853813293ace: [clang-fuzzer] Remove 'setUseOrcMCJITReplacement(false)' call. (authored by lhames).

[clang-fuzzer] Remove 'setUseOrcMCJITReplacement(false)' call.

Jul 15 2019, 3:30 PM

lhames committed rL366141: [clang-fuzzer] Remove 'setUseOrcMCJITReplacement(false)' call..

[clang-fuzzer] Remove 'setUseOrcMCJITReplacement(false)' call.

Jul 15 2019, 3:27 PM

lhames updated the diff for D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities..

[ORC] Add deprecation warning for OrcMCJITReplacement

Jul 15 2019, 2:37 PM · Restricted Project

lhames added a comment to D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities..

In D64609#1583075, @sgraenitz wrote:

... ORCv1 should be deprecated sooner rather than later. Though, a decision for the scope proposed here should come with a plan for OrcMCJITReplacement.

Jul 15 2019, 1:14 PM · Restricted Project

lhames committed rGa13cca41c5ce: [ORC] Start adding ORCv1 to ORCv2 transition tips to the ORCv2 doc. (authored by lhames).

[ORC] Start adding ORCv1 to ORCv2 transition tips to the ORCv2 doc.

Jul 15 2019, 8:40 AM

lhames committed rL366075: [ORC] Start adding ORCv1 to ORCv2 transition tips to the ORCv2 doc..

[ORC] Start adding ORCv1 to ORCv2 transition tips to the ORCv2 doc.

Jul 15 2019, 8:36 AM

Jul 11 2019

lhames added a comment to D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities..

This is the fist time I’ve used the deprecation attribute, so I’ve just taken a stab at maintaining sanity here. To keep the tree building cleanly, since we still have tests and internal utilities using these classes, I have added the attribute to the constructors of classes being removed, and added new, non-warning constructors alongside, distinguished by a dummy argument at the start of the list. Adding ‘AcknowledgeORCv1Deprecation’ to the start of any call to a deprecated constructor thus removes the warning.

Jul 11 2019, 6:19 PM · Restricted Project

lhames created D64609: [ORC] Add deprecation warnings to ORCv1 layers and utilities..

Jul 11 2019, 5:58 PM · Restricted Project

Jul 10 2019

lhames committed rG843f198a83d8: [ORC] Add custom IR compiler configuration to LLJITBuilder to enable obj caches. (authored by lhames).

[ORC] Add custom IR compiler configuration to LLJITBuilder to enable obj caches.

Jul 10 2019, 10:25 AM

lhames committed rL365671: [ORC] Add custom IR compiler configuration to LLJITBuilder to enable obj caches..

[ORC] Add custom IR compiler configuration to LLJITBuilder to enable obj caches.

Jul 10 2019, 10:24 AM

Jul 9 2019

lhames added a comment to D63378: [ORC] WIP Speculative compilation.

This is looking good. I think it would be nice to have an example QueryAnalysis implementation to demonstrate how that is supposed to work.

Jul 9 2019, 12:05 PM · Restricted Project, Restricted Project

lhames accepted D63377: [ORC] Avoid Race in Assertions .

Tentatively LGTM. Was this is generating a TSan error, or a crash? I would expect this to pass TSan, so writing a test case is probably not practical.

Jul 9 2019, 11:17 AM · Restricted Project

Jul 8 2019

lhames added a comment to D63378: [ORC] WIP Speculative compilation.

Hi Praveen,

Jul 8 2019, 10:06 PM · Restricted Project, Restricted Project

Jul 7 2019

lhames closed D62120: [ORC] fix unreachable code bug.

Committed in r361199.

Jul 7 2019, 7:08 PM · Restricted Project

lhames accepted D62120: [ORC] fix unreachable code bug.

In D62120#1511073, @nickdesaulniers wrote:

Wouldn't just deleting L142 from the existing sources be simpler? (or moving L146-148 into the for loop at the end (L142)?

Jul 7 2019, 7:08 PM · Restricted Project

Jul 3 2019

lhames committed rGf5a885fddd63: [JITLink][ORC] Add EHFrameRegistrar interface, use in EHFrameRegistrationPlugin. (authored by lhames).

[JITLink][ORC] Add EHFrameRegistrar interface, use in EHFrameRegistrationPlugin.

Jul 3 2019, 5:09 PM

lhames committed rL365098: [JITLink][ORC] Add EHFrameRegistrar interface, use in EHFrameRegistrationPlugin..

[JITLink][ORC] Add EHFrameRegistrar interface, use in EHFrameRegistrationPlugin.

Jul 3 2019, 5:08 PM

Jul 2 2019

lhames committed rGdbc86d20cbab: [lli] Fix a typo in a header. (authored by lhames).

[lli] Fix a typo in a header.

Jul 2 2019, 11:41 AM

lhames committed rL364956: [lli] Fix a typo in a header..

[lli] Fix a typo in a header.

Jul 2 2019, 11:40 AM

Jun 28 2019

lhames committed rG62a627ae781e: Re-apply r364600 with fixes. (authored by lhames).

Re-apply r364600 with fixes.

Jun 28 2019, 11:38 AM

lhames committed rL364672: Re-apply r364600 with fixes..

Re-apply r364600 with fixes.

Jun 28 2019, 11:37 AM

Jun 27 2019

lhames committed rGc29abb50f29d: Revert "[JITLink][MachO/x86-64] Add a testcase for X86_64_RELOC_GOT." (authored by lhames).

Revert "[JITLink][MachO/x86-64] Add a testcase for X86_64_RELOC_GOT."

Jun 27 2019, 4:04 PM

lhames committed rL364606: Revert "[JITLink][MachO/x86-64] Add a testcase for X86_64_RELOC_GOT.".

Revert "[JITLink][MachO/x86-64] Add a testcase for X86_64_RELOC_GOT."

Jun 27 2019, 4:00 PM

lhames committed rG4a8dc6153464: [JITLink][MachO/x86-64] Add a testcase for X86_64_RELOC_GOT. (authored by lhames).

[JITLink][MachO/x86-64] Add a testcase for X86_64_RELOC_GOT.

Jun 27 2019, 2:52 PM

lhames committed rL364598: [JITLink][MachO/x86-64] Add a testcase for X86_64_RELOC_GOT..

[JITLink][MachO/x86-64] Add a testcase for X86_64_RELOC_GOT.

Jun 27 2019, 2:51 PM

Jun 26 2019

lhames accepted D63518: BitStream reader: propagate errors.

Indeed! That's a pretty terrifying thing... but I'm not signing up to address *that* particular issue :)

Jun 26 2019, 9:16 AM · Restricted Project, Restricted Project

Jun 25 2019

lhames added a comment to D63518: BitStream reader: propagate errors.

I haven't had a chance to audit the whole patch yet, but in general the error suppression idioms are unsafe (though maybe no more so than the existing code?).

Jun 25 2019, 3:03 PM · Restricted Project, Restricted Project