Page MenuHomePhabricator

lhames (Lang Hames)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2013, 2:34 PM (311 w, 1 d)

Recent Activity

Wed, Feb 6

Herald added a project to D39111: Extensible LLVM RTTI: Restricted Project.

Ping.

Wed, Feb 6, 4:00 PM · Restricted Project

Tue, Feb 5

lhames added a comment to D57618: [ADT] Add a fallible_iterator wrapper..

Committed. I updated the language in the fallible iterators section of the programmers manual too. Feed back on that is very welcome too.

Tue, Feb 5, 3:28 PM · Restricted Project
lhames committed rG3e040e05f89c: [ADT] Add a fallible_iterator wrapper. (authored by lhames).
[ADT] Add a fallible_iterator wrapper.
Tue, Feb 5, 3:17 PM
lhames committed rL353237: [ADT] Add a fallible_iterator wrapper..
[ADT] Add a fallible_iterator wrapper.
Tue, Feb 5, 3:17 PM
lhames closed D57618: [ADT] Add a fallible_iterator wrapper..
Tue, Feb 5, 3:17 PM · Restricted Project
lhames accepted D36806: Switch to cantFail(), since it does the same assertion..

Looks like this was LGTM'd but never applied. Stephen -- do you have commit access?

Tue, Feb 5, 1:17 PM · Restricted Project
lhames closed D50429: [MCJIT] Fix case of Error::success being passed to report_fatal_error..

This was committed in r339809.

Tue, Feb 5, 1:05 PM · Restricted Project
lhames added inline comments to D57618: [ADT] Add a fallible_iterator wrapper..
Tue, Feb 5, 12:56 PM · Restricted Project
lhames updated the diff for D57618: [ADT] Add a fallible_iterator wrapper..
  • Remove unused collection elements.
Tue, Feb 5, 12:53 PM · Restricted Project
lhames updated the diff for D57618: [ADT] Add a fallible_iterator wrapper..
  • Require iterator checks on each increment, rename some test vars.
Tue, Feb 5, 12:42 PM · Restricted Project

Mon, Feb 4

lhames updated the diff for D57618: [ADT] Add a fallible_iterator wrapper..
  • Rename test classes and remove fixture, add test for deref-returns-expected.
Mon, Feb 4, 8:41 PM · Restricted Project
lhames added inline comments to D57618: [ADT] Add a fallible_iterator wrapper..
Mon, Feb 4, 5:19 PM · Restricted Project
lhames added inline comments to D57618: [ADT] Add a fallible_iterator wrapper..
Mon, Feb 4, 3:13 PM · Restricted Project
lhames updated the diff for D57618: [ADT] Add a fallible_iterator wrapper..
  • Address several review feedback comments.
Mon, Feb 4, 2:57 PM · Restricted Project
lhames added inline comments to D57618: [ADT] Add a fallible_iterator wrapper..
Mon, Feb 4, 2:49 PM · Restricted Project
lhames added inline comments to D57618: [ADT] Add a fallible_iterator wrapper..
Mon, Feb 4, 2:42 PM · Restricted Project
lhames added a comment to D57618: [ADT] Add a fallible_iterator wrapper..

Assuming this looks good to everyone, I will also update the programmers manual documentation for fallible iterators. I wanted to get this into a final form before re-writing the docs though.

Mon, Feb 4, 12:39 PM · Restricted Project
lhames updated the diff for D57618: [ADT] Add a fallible_iterator wrapper..
  • Remove the cantFail added in r352888, since fallible_iterator makes it unneccessary.
Mon, Feb 4, 12:38 PM · Restricted Project
lhames updated the diff for D57618: [ADT] Add a fallible_iterator wrapper..
  • Fix a missing header, rename make_fallible_iter to make_fallible_itr, and update Archive::child_iterator to use the fallible_iterator wrapper.
Mon, Feb 4, 11:44 AM · Restricted Project

Fri, Feb 1

lhames created D57618: [ADT] Add a fallible_iterator wrapper..
Fri, Feb 1, 2:07 PM · Restricted Project

Wed, Jan 30

lhames added inline comments to D57462: [llvm-objcopy][NFC] More error propagation (executeObjcopyOnArchive).
Wed, Jan 30, 4:04 PM · Restricted Project
lhames accepted D57482: [RuntimeDyld] Don't try to allocate sections with alignment 0..

Nice catch. LGTM. Thanks Zach!

Wed, Jan 30, 3:45 PM
lhames added inline comments to D57462: [llvm-objcopy][NFC] More error propagation (executeObjcopyOnArchive).
Wed, Jan 30, 3:42 PM · Restricted Project
lhames added inline comments to D57462: [llvm-objcopy][NFC] More error propagation (executeObjcopyOnArchive).
Wed, Jan 30, 2:20 PM · Restricted Project

Mon, Jan 28

lhames accepted D55943: [RuntimeDyld] load all sections with ProcessAllSections.

LGTM! Do you have commit access?

Mon, Jan 28, 1:04 PM

Thu, Jan 17

lhames accepted D56819: Document toolchain update policy.

This looks great. Thanks JF!

Thu, Jan 17, 10:41 AM

Jan 15 2019

lhames requested changes to D55943: [RuntimeDyld] load all sections with ProcessAllSections.

Hi Yonghong,

Jan 15 2019, 3:20 PM
lhames added a comment to D47073: Document and Enforce new Host Compiler Policy.

OK I think we've had more than enough bikeshed, over months, and in-person at the LLVM dev meeting. This is good enough, we want to warn people for the LLVM 8 branch which is tomorrow. Let's get this checked in today. We'll start a discussion on LLVM dev when anything *actually* changes, so nobody needs to panic just yet.

I strongly disagree with this right now: this is *not* OK to rush this as is.

If you need something in the release, then it can be done in a much less controversial way.

Jan 15 2019, 2:01 PM
lhames added a comment to D47073: Document and Enforce new Host Compiler Policy.
In D47073#1358039, @jfb wrote:

Is there any particular reason why we'd need this for LLVM 8?

Yes: we want to warn folks early. This is just warning them, and they can opt-out. Getting it in the release branch is exactly the right place: people try out releases much more than tip-of-tree.

Jan 15 2019, 12:53 PM
lhames committed rL351195: Revert r351138 "[ORC] Move ORC Core symbol map and set types into their own.
Revert r351138 "[ORC] Move ORC Core symbol map and set types into their own
Jan 15 2019, 7:25 AM

Jan 14 2019

lhames committed rL351138: [ORC] Move ORC Core symbol map and set types into their own header: CoreTypes.h..
[ORC] Move ORC Core symbol map and set types into their own header: CoreTypes.h.
Jan 14 2019, 3:53 PM
lhames accepted D56649: llvm-objdump -m -D should disassemble all text segments.

LGTM!

Jan 14 2019, 3:43 PM
lhames committed rL351128: [Object] Return a symbol_iterator, rather than a basic_symbol_iterator, from.
[Object] Return a symbol_iterator, rather than a basic_symbol_iterator, from
Jan 14 2019, 2:09 PM

Dec 11 2018

lhames added a comment to D39111: Extensible LLVM RTTI.

Gentle ping.

Dec 11 2018, 6:14 PM · Restricted Project

Dec 6 2018

lhames added a comment to D54674: [llvm-objcopy] First bits for MachO .

Apart from these specific comments, my general thought is that this is fine as far as it goes, but as it grows more fully featured it seems likely to start overlapping more libObject and MC functionality.

Dec 6 2018, 8:46 PM · Restricted Project
lhames closed D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..

Committed in r348223.

Dec 6 2018, 6:14 PM

Dec 4 2018

lhames added a comment to D39111: Extensible LLVM RTTI.

Swinging back around to this, as I have a concrete use-case now (allowing JIT clients to query MaterializationUnit types when deciding how to dispatch compiler invocations in the JIT).

Dec 4 2018, 7:25 PM · Restricted Project
lhames updated the diff for D39111: Extensible LLVM RTTI.

Updated to add documentation, comments.

Dec 4 2018, 7:17 PM · Restricted Project

Dec 3 2018

lhames committed rL348223: [ExecutionEngine] Change NotifyObjectEmitted/NotifyObjectFreed API..
[ExecutionEngine] Change NotifyObjectEmitted/NotifyObjectFreed API.
Dec 3 2018, 4:58 PM

Nov 28 2018

lhames accepted D53945: [TextAPI] TBD Reader/Writer.

Looks good to me. :)

Nov 28 2018, 1:06 PM
lhames added a comment to D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..

Gentle ping.

Nov 28 2018, 12:09 PM
lhames added a comment to D53945: [TextAPI] TBD Reader/Writer.

Oops. Those comments were for and old diff. The no-op sorts are gone, but the other three still apply.

Nov 28 2018, 9:40 AM

Nov 27 2018

lhames added a comment to D53945: [TextAPI] TBD Reader/Writer.

Nitpicks aside, the mach-o side of this looks good to me. :)

Nov 27 2018, 4:55 PM

Nov 19 2018

lhames committed rL347281: [ExecutionEngine][Interpreter] Fix out-of-bounds array access..
[ExecutionEngine][Interpreter] Fix out-of-bounds array access.
Nov 19 2018, 5:05 PM
lhames closed D53556: [Interpreter] Fix out-of-bounds access in ffiInvoke.
Nov 19 2018, 5:04 PM
lhames accepted D53556: [Interpreter] Fix out-of-bounds access in ffiInvoke.

LGTM. Committed as r347281. Thanks Eugene!

Nov 19 2018, 5:04 PM

Nov 13 2018

lhames updated the diff for D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..

Updates the PerfJITEventListener API and fixes a comment that referred to the old API.

Nov 13 2018, 3:24 PM

Nov 12 2018

lhames committed rL346727: [BuildingAJIT] Clang-format chapters 1 and 2..
[BuildingAJIT] Clang-format chapters 1 and 2.
Nov 12 2018, 5:28 PM
lhames committed rL346726: [BuildingAJIT] Update chapter 2 to use the ORCv2 APIs..
[BuildingAJIT] Update chapter 2 to use the ORCv2 APIs.
Nov 12 2018, 5:28 PM

Oct 31 2018

lhames added a comment to D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..

This looks like a sensible improvement. There's probably not many implementors of the interface, so the renaming shouldn't cause much pain.

I noticed however that you didn't update ExecutionEngine/PerfJITEvents/PerfJITEventListener.cpp?

Oct 31 2018, 4:41 PM
lhames added a reviewer for D53815: [TableGen] Better error checking for TIED_TO constraints.: MatzeB.
Oct 31 2018, 8:31 AM

Oct 30 2018

lhames committed rL345696: [ORC] Fix hex printing of uint64_t values..
[ORC] Fix hex printing of uint64_t values.
Oct 30 2018, 10:19 PM

Oct 26 2018

lhames updated the diff for D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..
  • [ExecutionEngine] Rename/format JITEventListener methods.
Oct 26 2018, 9:36 PM
lhames created D53773: [ExecutionEngine] Track objects using an abstract ObjectKey in JITEventListeners..
Oct 26 2018, 12:01 PM
lhames closed D53726: [ADT] Work around a bug in older compiler versions..
Oct 26 2018, 11:55 AM
lhames accepted D53726: [ADT] Work around a bug in older compiler versions..

Thanks everyone! Committed in r345411.

Oct 26 2018, 11:55 AM
lhames committed rL345411: [ADT] Use explicit constructors for DenseMapPair to work around compiler issues..
[ADT] Use explicit constructors for DenseMapPair to work around compiler issues.
Oct 26 2018, 10:52 AM

Oct 25 2018

lhames updated the diff for D53726: [ADT] Work around a bug in older compiler versions..
  • Fix a missing &&
Oct 25 2018, 2:24 PM
lhames added a comment to D53726: [ADT] Work around a bug in older compiler versions..

Patch description doesn't seem to immediately relate to the change - nor test cases demonstrating the connection?

Oct 25 2018, 2:14 PM
lhames retitled D53726: [ADT] Work around a bug in older compiler versions. from [ADT] Add initializer_list constructor, equality tests for DenseMap/DenseSet. to [ADT] Work around a bug in older compiler versions..
Oct 25 2018, 2:14 PM
lhames updated the diff for D53726: [ADT] Work around a bug in older compiler versions..
  • Add non templated constructors for DenseMap, clarify clang version in comment.
  • clang-format
Oct 25 2018, 2:09 PM
lhames added a comment to D53726: [ADT] Work around a bug in older compiler versions..

Oops -- forgot to clang-format this. Will do so before applying if it is accepted though.

Oct 25 2018, 12:46 PM
lhames created D53726: [ADT] Work around a bug in older compiler versions..
Oct 25 2018, 12:43 PM

Oct 24 2018

lhames committed rL345195: [ExecutionEngine] Remove some dead code from JITEventListener.h..
[ExecutionEngine] Remove some dead code from JITEventListener.h.
Oct 24 2018, 1:41 PM

Oct 23 2018

lhames committed rL345098: [ORC] Re-apply r345077 with fixes to remove ambiguity in lookup calls..
[ORC] Re-apply r345077 with fixes to remove ambiguity in lookup calls.
Oct 23 2018, 4:03 PM
lhames committed rL345077: [ORC] Change how non-exported symbols are matched during lookup..
[ORC] Change how non-exported symbols are matched during lookup.
Oct 23 2018, 1:22 PM

Oct 22 2018

lhames closed D51343: Fix RuntimeDyldCOFFX86_64 handling of image-relative relocations when there are not loaded sections.

Committed in r344995. Thanks again Andrew!

Oct 22 2018, 7:56 PM
lhames committed rL344995: [RuntimeDyld][COFF] Skip non-loaded sections when calculating ImageBase..
[RuntimeDyld][COFF] Skip non-loaded sections when calculating ImageBase.
Oct 22 2018, 6:39 PM
lhames committed rL344994: [ORC] Show JITDylib search order in JITDylib::dump..
[ORC] Show JITDylib search order in JITDylib::dump.
Oct 22 2018, 6:39 PM
lhames committed rL344993: [ORC] Dump flags for JITDylib symbol table entries..
[ORC] Dump flags for JITDylib symbol table entries.
Oct 22 2018, 6:38 PM
lhames committed rL344956: [ORC] Guard access to the MemMgrs vector in RTDyldObjectLinkingLayer..
[ORC] Guard access to the MemMgrs vector in RTDyldObjectLinkingLayer.
Oct 22 2018, 2:21 PM

Oct 20 2018

lhames committed rL344863: [ORC] Add some more basic sanity tests for the LLJIT..
[ORC] Add some more basic sanity tests for the LLJIT.
Oct 20 2018, 1:42 PM

Oct 18 2018

lhames committed rL344763: [ORC] Add a createJITDylib method to LLJIT..
[ORC] Add a createJITDylib method to LLJIT.
Oct 18 2018, 3:44 PM

Oct 17 2018

lhames committed rL344720: [BuildingAJIT] Update the Ch1 KaleidoscopeJIT class to expose errors to clients..
[BuildingAJIT] Update the Ch1 KaleidoscopeJIT class to expose errors to clients.
Oct 17 2018, 5:53 PM
lhames committed rL344712: [BuildingAJIT] Simplify a tutorial example and fix a syntax error..
[BuildingAJIT] Simplify a tutorial example and fix a syntax error.
Oct 17 2018, 3:30 PM
lhames committed rL344705: [BuildingAJIT] Fix a function signature in the documentation..
[BuildingAJIT] Fix a function signature in the documentation.
Oct 17 2018, 12:37 PM

Oct 16 2018

lhames committed rL344667: [BuildingAJIT] Update chapter 1 to use the ORCv2 APIs..
[BuildingAJIT] Update chapter 1 to use the ORCv2 APIs.
Oct 16 2018, 8:36 PM
lhames committed rL344643: [ORC] Make the VModuleKey optional, propagate it via MaterializationUnit and.
[ORC] Make the VModuleKey optional, propagate it via MaterializationUnit and
Oct 16 2018, 1:15 PM

Oct 15 2018

lhames added a comment to D51343: Fix RuntimeDyldCOFFX86_64 handling of image-relative relocations when there are not loaded sections.

Hi Andrew,

Oct 15 2018, 5:28 PM
lhames committed rL344572: [ORC] Rename ORC layers to make the "new" ORC layers the default..
[ORC] Rename ORC layers to make the "new" ORC layers the default.
Oct 15 2018, 3:58 PM
lhames committed rL344567: [ORC] Rename MultiThreadedSimpleCompiler to ConcurrentIRCompiler..
[ORC] Rename MultiThreadedSimpleCompiler to ConcurrentIRCompiler.
Oct 15 2018, 3:38 PM
lhames committed rL344566: Change a TerminatorInst* to an Instruction* in HotColdSplitting.cpp..
Change a TerminatorInst* to an Instruction* in HotColdSplitting.cpp.
Oct 15 2018, 3:29 PM
lhames committed rL344565: [ORC] Switch to DenseMap/DenseSet for ORC symbol map/set types..
[ORC] Switch to DenseMap/DenseSet for ORC symbol map/set types.
Oct 15 2018, 3:29 PM
lhames closed D53260: [ADT] Fix a bug in DenseSet's initializer_list constructor..

Committed as r344542.

Oct 15 2018, 11:37 AM
lhames committed rL344542: [ADT] Fix a bug in DenseSet's initializer_list constructor..
[ADT] Fix a bug in DenseSet's initializer_list constructor.
Oct 15 2018, 11:36 AM
lhames updated the diff for D53260: [ADT] Fix a bug in DenseSet's initializer_list constructor..

Use PowerOf2Ceil as per Craig's suggestion, and validate set contents in the non power-of-two length initializer list unit test as per Dave's suggestion.

Oct 15 2018, 9:11 AM
lhames added inline comments to D53260: [ADT] Fix a bug in DenseSet's initializer_list constructor..
Oct 15 2018, 8:37 AM
lhames closed D53247: [ADT] Add initializer_list constructor, equality tests for DenseMap/DenseSet..

Committed in r344522.

Oct 15 2018, 8:29 AM
lhames committed rL344522: [ADT] Adds equality operators for DenseMap and DenseSet, and an initializer_list.
[ADT] Adds equality operators for DenseMap and DenseSet, and an initializer_list
Oct 15 2018, 8:29 AM

Oct 14 2018

lhames committed rL344489: [ORC] Simplify naming for JITDylib definition generators..
[ORC] Simplify naming for JITDylib definition generators.
Oct 14 2018, 10:09 PM
lhames updated the diff for D53247: [ADT] Add initializer_list constructor, equality tests for DenseMap/DenseSet..

Updated to remove the dependence on stable iteration order for operator== (on both DenseMap and DenseSet). Also adds some comments on performance.

Oct 14 2018, 2:02 PM
lhames added a comment to D53247: [ADT] Add initializer_list constructor, equality tests for DenseMap/DenseSet..

Broke out https://reviews.llvm.org/D53260 for the DenseSet bug fix.

Oct 14 2018, 12:07 PM
lhames created D53260: [ADT] Fix a bug in DenseSet's initializer_list constructor..
Oct 14 2018, 12:07 PM
lhames added inline comments to D53247: [ADT] Add initializer_list constructor, equality tests for DenseMap/DenseSet..
Oct 14 2018, 9:27 AM
lhames committed rL344478: [ORC] Remove XXLayer::add methods that default to using the main JITDylib..
[ORC] Remove XXLayer::add methods that default to using the main JITDylib.
Oct 14 2018, 9:12 AM
lhames added inline comments to D53247: [ADT] Add initializer_list constructor, equality tests for DenseMap/DenseSet..
Oct 14 2018, 9:05 AM

Oct 13 2018

lhames added a comment to D51128: [ORC] LLJITTest: API test and usage examples with actual codegen.

I do not think this landed in the end (it does not look like it). It may be able to be rewritten more naturally now that LLJIT has native support for multiple threads. Also ThreadSafeModule and ThreadSafeContext will help with the context management issues.

Oct 13 2018, 3:53 PM
lhames created D53247: [ADT] Add initializer_list constructor, equality tests for DenseMap/DenseSet..
Oct 13 2018, 3:29 PM
lhames committed rL344467: [ORC] During lookup, do not match against hidden symbols in other JITDylibs..
[ORC] During lookup, do not match against hidden symbols in other JITDylibs.
Oct 13 2018, 2:57 PM
lhames added a comment to D51126: [ORC] LLJIT::Create() proposal: add flag to enable multithreaded codegen.

I think the changes in r343122 provide a superset of this functionality, so this can be closed.

Oct 13 2018, 12:39 PM