User Details
- User Since
- Feb 27 2013, 2:34 PM (481 w, 4 d)
Sat, May 21
Fri, May 20
Thu, May 19
Tue, May 17
LGTM.
LGTM!
Tue, May 10
LGTM. Thanks @Hahnfeld.
Thu, May 5
Sorry for the breakage there, and thanks for the quick fix!
LGTM. Thanks very much @housel!
Thu, Apr 28
This looks great -- with this applied I was able to use libunwind with the JIT on linux without issues.
Wed, Apr 27
Sorry for the delayed review on this one.
Tue, Apr 26
Apr 17 2022
Apr 16 2022
Apr 15 2022
Apr 12 2022
Apr 7 2022
Apr 5 2022
Apr 1 2022
LGTM. Thanks Jakob!
I can't speak to the RISC-V assembly, but the API use looks good to me.
Mar 26 2022
Mar 23 2022
I'm currently doing that via MCContext::getGenDwarfForAssembly...
Mar 8 2022
Mar 7 2022
Mar 1 2022
Feb 27 2022
Feb 13 2022
Feb 9 2022
Feb 7 2022
Looks good to me.
Feb 3 2022
HI Rainer,
Jan 29 2022
Patch should be clang-format'd to eliminate the lint warnings, but otherwise LGTM. Thanks Stephen and Siwei!
Reviewing the patch as-is because I think it's a great addition. If work on the ELF/aarch64 backend is starting in earnest though I would prefer to create a new generic aarch64.h header (along the lines of riscv.h and x86_64.h) and populate it with the existing MachO relocations -- the fixup logic is generally sharable, so there shouldn't be any need to duplicate it, though ELF will probably require some extra relocations beyond the set MachO uses.
Jan 24 2022
Does check-orc-rt need to be added to COMPILER_RT_TEST_SUITES too? I guess not, otherwise we wouldn't have seen this missing dependency in the first place?
Jan 21 2022
Jan 19 2022
Jan 18 2022
LGTM, thanks Sameer!
LGTM. Thanks Ben!
Jan 17 2022
Jan 15 2022
Jan 14 2022
LGTM. Thanks Ben!
Jan 13 2022
I think this will need an update for the JITTargetAddress -> ExecutorAddr switch in 118e953b18f, but otherwise LGTM. Thanks Stephen!
LGTM! Thanks very much @fourdim!
Jan 12 2022
LGTM.
Hi Nico, Mikael,
Jan 11 2022
LGTM. Thanks Stefan!
Jan 10 2022
Jan 9 2022
The code should be clang-formatted. Otherwise LGTM.