User Details
- User Since
- Feb 27 2013, 2:34 PM (412 w, 16 h)
Tue, Jan 19
Mon, Jan 18
Sun, Jan 17
Thu, Jan 14
Great. Thanks very much Stefan!
LGTM!
Tue, Jan 12
Mon, Jan 11
I think an orc-greedy mode for LLI sounds like a great idea. Also, once we have it we should probably make it the default mode instead of MCJIT.
Sun, Jan 10
Sat, Jan 2
Wed, Dec 30
Tue, Dec 29
Dec 15 2020
Dec 13 2020
Hi All,
Dec 12 2020
@fhahn @xgupta Apologies for the delayed reply. I'm not sure why this was abandoned -- it looks good to me.
Dec 9 2020
Dec 7 2020
LGTM. Thanks Stefan!
LGTM -- Nice catch, thanks Stefan!
Dec 5 2020
Nov 25 2020
Nov 23 2020
Sorry -- I missed this one earlier. For what it's worth JITLink prints with wild abandon. In general I'd rather log everything and then concentrate on log formatting to make it searchable/digestible.
Nov 16 2020
This has been superseded by the removable code support added in 0aec49c8531.
Nov 15 2020
Hi Elena,
Nov 13 2020
Committed in 1d0676b54c4.
Nov 12 2020
Nov 11 2020
Make executable symbols in llvm-jitlink-executor visible.
Nov 10 2020
Please let me know if you have any other thoughts / comments, otherwise I'm hoping to commit this by the end of the week so we can move on to the next step: Full support for initializers in remote processes.
Address review comments.
Nov 5 2020
Looks good to me. Thanks Moritz!
Nov 3 2020
Hi Jameson, Valentin,
Oct 30 2020
I'm curious to get your take on the library breakdown and corresponding headers too. We now have:
Fix diff to include original changes.
Address review comments.
Oct 29 2020
Looks great to me. Thanks very much Stefan!
Oct 28 2020
Oct 27 2020
Oct 25 2020
Hi Geoffrey,
Oct 23 2020
Oct 22 2020
This looks good to me.
Oct 20 2020
It's not clear to me that Elena's patch should affect this. I'm inclined to accept it and just keep an eye on the bots. If everything passes we can chalk it up to a misconfig on Harbormaster. If the bots fail we can revert, and maybe the logs will give us some more insight into what's going on.
@jingham @clayborg Do either of you recognize the error that seems to be triggered? It looks like it's consistent across the tests, or at least the ones that I looked at:
Oct 19 2020
Looks good to me. Thanks Geoffrey!
Oct 18 2020
Oct 6 2020
Yes, please go ahead and abandon this review -- it will be fixed as soon as the orcv1-removal patch lands. Thank you for the contribution though!