Page MenuHomePhabricator

lhames (Lang Hames)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2013, 2:34 PM (360 w, 4 d)

Recent Activity

Sat, Jan 25

lhames added inline comments to D70759: [llvm-symbolizer] Support debug file lookup using build ID.
Sat, Jan 25, 4:26 PM · Restricted Project

Fri, Jan 24

lhames accepted D72486: Add ThinLtoJIT example.

LGTM! I really like this. I'm all for adding it as another example if you're happy to maintain it.

Fri, Jan 24, 3:50 PM · Restricted Project
lhames accepted D71804: Fix -Wpessimizing-move warnings.

LGTM. Please go ahead and commit. If you do not have commit access just let me know and I can commit on your behalf.

Fri, Jan 24, 2:55 PM · Restricted Project

Thu, Jan 23

lhames committed rGfbb8642c1c4c: [examples][ORC] Fix program names in calls to parse cl opt in examples. (authored by lhames).
[examples][ORC] Fix program names in calls to parse cl opt in examples.
Thu, Jan 23, 7:28 PM
lhames committed rGbb7a5707ac00: [examples][ORC] Add an example of how to use a custom ObjectLinkingLayer plugin. (authored by lhames).
[examples][ORC] Add an example of how to use a custom ObjectLinkingLayer plugin.
Thu, Jan 23, 7:28 PM
lhames committed rG46aa5c13c5fc: [examples][ORC] Remove an unused parameter from IR in an LLJIT example. (authored by lhames).
[examples][ORC] Remove an unused parameter from IR in an LLJIT example.
Thu, Jan 23, 7:28 PM
lhames requested changes to D73015: Add more detailed comment for ORC stub code.

Hi Axis,

Thu, Jan 23, 1:52 PM · Restricted Project, Restricted Project

Wed, Jan 22

lhames added a comment to D72176: Make ErrorList class default constructible and add simple push_back() method.

Actually, since I'm pontificating about Error on this thread anyway, the other big change that I would like to see (which is also impacted by ErrorList) would be to ditch handleErrors entirely. If we had the "one Error/Expected == one failure" invariant, we could switch to an "err_cast" idiom:

Wed, Jan 22, 11:19 AM · Restricted Project
lhames added a reviewer for D72176: Make ErrorList class default constructible and add simple push_back() method: dblaikie.

This seems like a nice change for ErrorList.

Wed, Jan 22, 10:42 AM · Restricted Project

Tue, Jan 21

lhames committed rG97d000da2e60: [ORC] Fix the LLJITWithObjectCache example to address changes in ce2207abaf9. (authored by lhames).
[ORC] Fix the LLJITWithObjectCache example to address changes in ce2207abaf9.
Tue, Jan 21, 10:54 PM
lhames added inline comments to D72486: Add ThinLtoJIT example.
Tue, Jan 21, 10:43 PM · Restricted Project
lhames committed rGb54aa053d3ae: Update clang-interpreter example to incorporate changes in ce2207abaf9. (authored by lhames).
Update clang-interpreter example to incorporate changes in ce2207abaf9.
Tue, Jan 21, 10:02 PM
lhames committed rG98e55477558a: [ORC] Update examples to incorporate changes in ce2207abaf9. (authored by lhames).
[ORC] Update examples to incorporate changes in ce2207abaf9.
Tue, Jan 21, 8:42 PM
lhames added a comment to D72486: Add ThinLtoJIT example.

I need to check this out and play around with it a bit to wrap my head around it, especially the performance tuning issues. This is very exciting though!

Tue, Jan 21, 8:42 PM · Restricted Project
lhames committed rGe0a6093a744d: [ORC] Fix a missing move in ce2207abaf9. (authored by lhames).
[ORC] Fix a missing move in ce2207abaf9.
Tue, Jan 21, 8:16 PM
lhames committed rGce2207abaf9a: [ORC] Add support for emulated TLS to ORCv2. (authored by lhames).
[ORC] Add support for emulated TLS to ORCv2.
Tue, Jan 21, 7:58 PM
lhames added a comment to D73015: Add more detailed comment for ORC stub code.

I think this would be better explained through comments. There is a comment regarding this code sequence at the top of the function, but it would make sense to add a second one directly above where we use the constant.

Tue, Jan 21, 11:46 AM · Restricted Project, Restricted Project

Sun, Jan 19

lhames committed rG84217ad66115: [ORC] Add weak symbol support to defineMaterializing, fix for PR40074. (authored by lhames).
[ORC] Add weak symbol support to defineMaterializing, fix for PR40074.
Sun, Jan 19, 11:02 AM

Fri, Jan 17

lhames closed D65015: Enable CodeGenOpt::None on non-iOS ARM.

This landed in d2751f8fdf6c072045bab62f6035511e028f46ee (I failed to format the revision number correctly in the commit message, so it wasn’t automatically picked up here, sorry).

Fri, Jan 17, 11:30 AM · Restricted Project
lhames added a comment to D72301: [ORC] Fix the move-captured std::unique_ptr vs. std::function dilemma.

The current workaround creates and copies a std::shared_pointer. That's quite expensive. In a first step we can move-capture it in the Work lambda to avoid the copy. I think we don't get around the creation (assuming we keep a smart pointer), so why not receive it as a std::shared_ptr directly? The only disproportionate overhead I see is in the materializeOnCurrentThread case. I changed that to not calling the function at all.

Fri, Jan 17, 11:11 AM · Restricted Project

Thu, Jan 16

lhames committed rGf6d6b98eec41: [docs][ORC] Try to fix 'title-level inconsistent' error in ORCv2.rst. (authored by lhames).
[docs][ORC] Try to fix 'title-level inconsistent' error in ORCv2.rst.
Thu, Jan 16, 9:48 PM
lhames committed rGadef2f5324cc: [docs][ORC] Fix some RST errors in the ORCv2 doc. (authored by lhames).
[docs][ORC] Fix some RST errors in the ORCv2 doc.
Thu, Jan 16, 9:12 PM
lhames committed rG0d3d584f82ff: [docs][ORC] Update the "utilities" section, tidy intro and fix typo. (authored by lhames).
[docs][ORC] Update the "utilities" section, tidy intro and fix typo.
Thu, Jan 16, 8:09 PM

Wed, Jan 15

lhames committed rGd629525597eb: [docs][ORC] Update the laziness section of the ORCv2 design doc. (authored by lhames).
[docs][ORC] Update the laziness section of the ORCv2 design doc.
Wed, Jan 15, 11:37 AM
lhames committed rGc75180258e63: [ORC] Set setCloneToNewContextOnEmit on LLJIT's transform layer when needed. (authored by lhames).
[ORC] Set setCloneToNewContextOnEmit on LLJIT's transform layer when needed.
Wed, Jan 15, 10:31 AM
lhames added a comment to D72406: [Orc][LLJIT] Add optimizer support to LLJIT.

Actually I missed that clone-to-new-context update in e9e26c01cd865da678b1af6ba5f417c713956a66. I've fixed it in c75180258e6. Thanks for this Don!

Wed, Jan 15, 10:31 AM · Restricted Project
lhames committed rGe9e26c01cd86: [ORC] Simplify use of lazyReexports with LLJIT. (authored by lhames).
[ORC] Simplify use of lazyReexports with LLJIT.
Wed, Jan 15, 8:03 AM
lhames committed rGd2fabd70065e: [ORC] Update lazyReexports to support aliases with different symbol names. (authored by lhames).
[ORC] Update lazyReexports to support aliases with different symbol names.
Wed, Jan 15, 8:03 AM

Tue, Jan 14

lhames added inline comments to D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes.
Tue, Jan 14, 6:10 PM · Restricted Project

Sun, Jan 12

lhames added a comment to rGece8fed60906: [ORC] Add a runAsMain utility function to ExecutionUtils..

I was about to say enjoy your time off and have a look here on Monday: D72563 I guess we don't need it anymore :)

Sun, Jan 12, 10:39 AM

Sat, Jan 11

lhames committed rG2cdb18afda84: [ORC] Fix argv handling in runAsMain / lli. (authored by lhames).
[ORC] Fix argv handling in runAsMain / lli.
Sat, Jan 11, 1:26 PM
lhames added a comment to rGece8fed60906: [ORC] Add a runAsMain utility function to ExecutionUtils..

Hi Stefan,

Sat, Jan 11, 1:26 PM
lhames committed rGd2751f8fdf6c: [ExecutionEngine] Re-enable FastISel for non-iOS arm targets. (authored by lhames).
[ExecutionEngine] Re-enable FastISel for non-iOS arm targets.
Sat, Jan 11, 10:54 AM

Fri, Jan 10

lhames added a comment to D72486: Add ThinLtoJIT example.

Hi Stefan. Thanks for posting this! I’m out on vacation this week, but looking forward to reviewing when I get back to the office next week.

Fri, Jan 10, 8:15 AM · Restricted Project

Wed, Jan 8

lhames accepted D65015: Enable CodeGenOpt::None on non-iOS ARM.

LGTM. Do you have commit access? If not just let me know and I can commit on your behalf.

Wed, Jan 8, 1:00 PM · Restricted Project

Fri, Jan 3

lhames added a comment to D70628: [Support] Enable file + line info in LLVM stack traces on Darwin..

...
I think the best long term solution to this problem is to teach llvm-symbolize how to cope with debug info in objects, rather than requiring a dSYM. An intermediate step (possibly generically useful) would be to add an option to llvm-symbolize to run llvm-dsymutil if there's no dSYM available.

I suppose that might be useful for individuals, but I don't think it would be a good idea for the bots, which is my primary target.

My last comment concerned the intermediate step. I think your long-term solution would be great.

Fri, Jan 3, 1:51 PM · Restricted Project

Thu, Jan 2

lhames added a comment to D70600: [Error] Add stack traces for llvm::Error invariant violations..

Oh, I remember part of my motivation for designing it this way: While failure values are expected to be expensive, we don't want to make them unnecessarily expensive, which is why the error-geneation-point trace is under a flag: You don't want to stack-trace every error that is ever generated. However, making this conditional means we need to check a global flag to decide whether we *should* do the stack trace. Once you're doing that, you may as well make your "flag" a pointer to the side table.

Thu, Jan 2, 5:09 PM · Restricted Project
lhames added a comment to D70600: [Error] Add stack traces for llvm::Error invariant violations..

FWIW working on a codebase that heavily uses both Error and threads, the side-table seems fairly a bit terrifying. Even if the thread safety issues are fixed, do we really want to pay for mutex lock/unlock to create errors, to save a pointer?

thread_local might be an option, though as I understand llvm/Support may have to be portable to environments where that doesn't work well.

Thu, Jan 2, 5:09 PM · Restricted Project
lhames committed rG355983103f00: [lli] Add a filter to avoid importing the process's main symbol. (authored by lhames).
[lli] Add a filter to avoid importing the process's main symbol.
Thu, Jan 2, 4:13 PM
lhames added inline comments to D70600: [Error] Add stack traces for llvm::Error invariant violations..
Thu, Jan 2, 10:08 AM · Restricted Project

Dec 20 2019

lhames added a comment to D71683: [ORC][EH] Deregister EH frames in MemoryManager dtor.

Actually, are you seeing this bug on ORC? Or just on MCJIT?

ORC, specifically ORCv2.

Dec 20 2019, 9:13 PM · Restricted Project
lhames committed rG9f4f237e29e7: [ORC] De-register eh-frames in the RTDyldObjectLinkingLayer destructor. (authored by lhames).
[ORC] De-register eh-frames in the RTDyldObjectLinkingLayer destructor.
Dec 20 2019, 9:12 PM
lhames accepted D71792: Constrain the macho-stabs test added in f72d001e099 to run on systems configured with an x86 backend..

LGTM.

Dec 20 2019, 5:44 PM · Restricted Project
lhames added a comment to D71683: [ORC][EH] Deregister EH frames in MemoryManager dtor.

Actually, are you seeing this bug on ORC? Or just on MCJIT?

Dec 20 2019, 5:38 PM · Restricted Project
lhames accepted D71683: [ORC][EH] Deregister EH frames in MemoryManager dtor.

Hi myhsu -- This looks good to me. Do you have commit access? If so please feel free to commit. If not just let me know and I will commit on your behalf.

Dec 20 2019, 1:25 AM · Restricted Project

Dec 19 2019

lhames committed rG07ac3145ccd5: [Orc][LLJIT] Re-apply 298e183e813 (use JITLink for LLJIT where supported). (authored by lhames).
[Orc][LLJIT] Re-apply 298e183e813 (use JITLink for LLJIT where supported).
Dec 19 2019, 9:28 PM
lhames committed rGd9220b580b32: [JITLink][MachO] Fix common symbol size plumbing. (authored by lhames).
[JITLink][MachO] Fix common symbol size plumbing.
Dec 19 2019, 9:27 PM

Dec 18 2019

lhames committed rG5ea91bea15dd: Revert "[Orc][LLJIT] Use JITLink even if a custom JITTargetMachineBuilder is… (authored by lhames).
Revert "[Orc][LLJIT] Use JITLink even if a custom JITTargetMachineBuilder is…
Dec 18 2019, 3:17 PM
lhames added a reverting change for rG298e183e813c: [Orc][LLJIT] Use JITLink even if a custom JITTargetMachineBuilder is supplied.: rG5ea91bea15dd: Revert "[Orc][LLJIT] Use JITLink even if a custom JITTargetMachineBuilder is….
Dec 18 2019, 3:17 PM
lhames committed rG298e183e813c: [Orc][LLJIT] Use JITLink even if a custom JITTargetMachineBuilder is supplied. (authored by lhames).
[Orc][LLJIT] Use JITLink even if a custom JITTargetMachineBuilder is supplied.
Dec 18 2019, 2:19 PM

Dec 15 2019

lhames committed rG3c9bf77b2e61: [examples] Rename LLJITWithJITLink to LLJITWithCustomObjectLinkingLayer. (authored by lhames).
[examples] Rename LLJITWithJITLink to LLJITWithCustomObjectLinkingLayer.
Dec 15 2019, 10:01 PM
lhames committed rG073df421e0d7: [examples] Update LLJITWithJITLink example for change in c0143f37dab. (authored by lhames).
[examples] Update LLJITWithJITLink example for change in c0143f37dab.
Dec 15 2019, 10:00 PM
lhames committed rG67a1b7f05379: [Orc][LLJIT] Automatically use JITLink for LLJIT on supported platforms. (authored by lhames).
[Orc][LLJIT] Automatically use JITLink for LLJIT on supported platforms.
Dec 15 2019, 10:00 PM
lhames committed rGc0143f37dab3: [ORC] Make ObjectLinkingLayer own its jitlink::MemoryManager. (authored by lhames).
[ORC] Make ObjectLinkingLayer own its jitlink::MemoryManager.
Dec 15 2019, 5:37 PM
lhames committed rG064e7d1df17d: [Kaleidoscope][BuildingAJIT] Add a missing std::move. (authored by lhames).
[Kaleidoscope][BuildingAJIT] Add a missing std::move.
Dec 15 2019, 3:45 PM
lhames added a comment to D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource.

I would prefer landing this as-is because it is just doing the same we do in other places in LLVM. Afterwards migrating the whole RTTI system in LLVM to a new system (whether that will be D39111 or just a ClassID type) sounds good to me.

Dec 15 2019, 12:57 AM · Restricted Project

Dec 12 2019

lhames added a comment to D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource.

Side note: This https://reviews.llvm.org/D39111 seems related. The patch has languished as I have been busy with other work, but if it would be useful for you guys I'd be happy to try to land it.

Dec 12 2019, 2:04 PM · Restricted Project

Dec 5 2019

lhames committed rG72db78eba596: [JITLink] Use Blocks rather than Symbols for SectionRange. (authored by lhames).
[JITLink] Use Blocks rather than Symbols for SectionRange.
Dec 5 2019, 8:25 PM
lhames committed rG8c4f048a0006: [JITLink] Remove the Section::symbols_empty() method. (authored by lhames).
[JITLink] Remove the Section::symbols_empty() method.
Dec 5 2019, 8:25 PM
lhames committed rG41eeded80431: Fix the clang interpreter example which was broken by 4fc68b9b7f3e0. (authored by lhames).
Fix the clang interpreter example which was broken by 4fc68b9b7f3e0.
Dec 5 2019, 2:48 AM
lhames committed rG4fc68b9b7f3e: [ORC] Remove the automagic Main JITDylib fram ExecutionSession. (authored by lhames).
[ORC] Remove the automagic Main JITDylib fram ExecutionSession.
Dec 5 2019, 1:44 AM

Dec 2 2019

lhames committed rGece8fed60906: [ORC] Add a runAsMain utility function to ExecutionUtils. (authored by lhames).
[ORC] Add a runAsMain utility function to ExecutionUtils.
Dec 2 2019, 2:05 AM
lhames committed rG0e7ecc651a47: [ExecutionEngine] Add a jitTargetAddressToFunction utility function. (authored by lhames).
[ExecutionEngine] Add a jitTargetAddressToFunction utility function.
Dec 2 2019, 2:05 AM
lhames committed rG5c05b4a279f5: [Orc] Add setters for target options and features to JITTargetMachineBuilder. (authored by lhames).
[Orc] Add setters for target options and features to JITTargetMachineBuilder.
Dec 2 2019, 2:05 AM

Nov 28 2019

lhames committed rG674df13b5fa7: [ORC][JITLink] Add support for weak references, and improve handling of static… (authored by lhames).
[ORC][JITLink] Add support for weak references, and improve handling of static…
Nov 28 2019, 1:33 PM

Nov 27 2019

lhames committed rGc33598d5e547: [JITLink] Make sure MachO/x86-64 handles 32-bit signed addends correctly. (authored by lhames).
[JITLink] Make sure MachO/x86-64 handles 32-bit signed addends correctly.
Nov 27 2019, 10:48 PM
lhames added a comment to D70628: [Support] Enable file + line info in LLVM stack traces on Darwin..

Just a standard llvm Debug build. Is there an cmake option I'm missing?

Nov 27 2019, 12:42 AM · Restricted Project

Nov 26 2019

lhames added a comment to D69434: ExecutionEngine: add preliminary support for COFF ARM64 .

Coming to this a bit late -- Thanks for working on this kaadam! And thanks for the review mstorsjo.

Nov 26 2019, 3:00 PM · Restricted Project

Nov 23 2019

lhames added a comment to D70628: [Support] Enable file + line info in LLVM stack traces on Darwin..

This is awesome, thanks for working on it!

I pulled down your patch and built it, but am not getting expected results. Did I miss something?

Nov 23 2019, 1:04 PM · Restricted Project
lhames updated the diff for D70628: [Support] Enable file + line info in LLVM stack traces on Darwin..
  • Remove check for an impossible magic value.
Nov 23 2019, 1:04 PM · Restricted Project
lhames updated the diff for D70628: [Support] Enable file + line info in LLVM stack traces on Darwin..
  • Remove byte-swapping code. This will run in process, so endianness shouldn't
  • Fix variable naming.
Nov 23 2019, 9:17 AM · Restricted Project
lhames updated the diff for D70628: [Support] Enable file + line info in LLVM stack traces on Darwin..
  • Remove byte-swapping code. This will run in process, so endianness shouldn't
Nov 23 2019, 9:17 AM · Restricted Project

Nov 22 2019

lhames added inline comments to D70600: [Error] Add stack traces for llvm::Error invariant violations..
Nov 22 2019, 7:08 PM · Restricted Project
lhames added a comment to D70628: [Support] Enable file + line info in LLVM stack traces on Darwin..

Looking for feedback on the approach before I go too much further with this. I was motivated to enable file + line info by Don Hinton's work in https://reviews.llvm.org/D70259 and https://reviews.llvm.org/D70263, where he attaches source location information certain calls to aid in debugging of error handling failures. I have a review out for an alternative scheme that produces full backtraces for error handling failures (see https://reviews.llvm.org/D70600), but the lack of file and line info in the traces is a drawback compared to Don's approach.

Nov 22 2019, 5:27 PM · Restricted Project
lhames created D70628: [Support] Enable file + line info in LLVM stack traces on Darwin..
Nov 22 2019, 5:08 PM · Restricted Project
lhames updated the summary of D70600: [Error] Add stack traces for llvm::Error invariant violations..
Nov 22 2019, 9:31 AM · Restricted Project
lhames updated the summary of D70600: [Error] Add stack traces for llvm::Error invariant violations..
Nov 22 2019, 9:31 AM · Restricted Project
lhames updated the diff for D70600: [Error] Add stack traces for llvm::Error invariant violations..
  • Replace report_fatal_error declaration that was accidentally removed.
Nov 22 2019, 9:31 AM · Restricted Project
lhames created D70600: [Error] Add stack traces for llvm::Error invariant violations..
Nov 22 2019, 8:03 AM · Restricted Project

Nov 20 2019

lhames committed rG8e896b19ddd9: [Error] Remove a broken code fragment accidentally included in 76bcbaafab2. (authored by lhames).
[Error] Remove a broken code fragment accidentally included in 76bcbaafab2.
Nov 20 2019, 5:58 PM
lhames committed rG76bcbaafab2d: [Orc][Modules] Fix Modules build fallout from a34680a33eb. (authored by lhames).
[Orc][Modules] Fix Modules build fallout from a34680a33eb.
Nov 20 2019, 5:40 PM
lhames committed rGa329cf69696f: [Support][Error] Unfriend FileError. It is not special. (authored by lhames).
[Support][Error] Unfriend FileError. It is not special.
Nov 20 2019, 3:11 PM

Nov 18 2019

lhames added a comment to D70263: [Error] Add source location to Errors.

In my initial commit, I had added a new class specifically for this, SourceLocationError, but @beanz convinced me to reuse FileError, since the only difference was the message formatting.

Should I add back SourceLocationError?

Nov 18 2019, 1:33 PM · Restricted Project

Nov 15 2019

lhames added a comment to D70263: [Error] Add source location to Errors.

I'm not sure I follow this. My understanding is that FileError was designed to make it easy to attach a source location to an error generated while operating on a file, but this patch is adapting it to track the LLVM source location that generated the error, right?

Nov 15 2019, 11:17 AM · Restricted Project
lhames added a comment to D70259: [Error] Add source location to cantFail.

Hi Don,

Nov 15 2019, 11:08 AM · Restricted Project

Nov 14 2019

lhames committed rG16f38dda292c: [ORC] Add a utility to support dumping JIT'd objects to disk for debugging. (authored by lhames).
[ORC] Add a utility to support dumping JIT'd objects to disk for debugging.
Nov 14 2019, 9:28 PM
lhames committed rG058bc4c8d48a: [ADT] Move drop_begin from iterator_range.h into STLExtras. (authored by lhames).
[ADT] Move drop_begin from iterator_range.h into STLExtras.
Nov 14 2019, 8:16 AM
lhames closed D70189: [ADT] Move drop_begin from iterator_range.h into STLExtras..
Nov 14 2019, 8:16 AM · Restricted Project

Nov 13 2019

lhames created D70189: [ADT] Move drop_begin from iterator_range.h into STLExtras..
Nov 13 2019, 9:23 AM · Restricted Project

Nov 7 2019

lhames added inline comments to D69677: Correctly update isSignalFrame when unwinding the stack via dwarf..
Nov 7 2019, 2:54 PM · Restricted Project
lhames accepted D69677: Correctly update isSignalFrame when unwinding the stack via dwarf..

Ok. So the documentation (sparse as it is) syncs up with what you're seeing in existing implementations. Looks good to me. :)

Nov 7 2019, 1:09 PM · Restricted Project

Nov 6 2019

lhames added a comment to D69817: Fix OrcError build with modules enabled..

I couldn’t reproduce this -DLLVM_ENABLE_MODULES=On and my system compiler. I’ll try a 2-stage build and see if I have any luck with that.

Nov 6 2019, 4:29 PM · Restricted Project
lhames added a comment to D69677: Correctly update isSignalFrame when unwinding the stack via dwarf..

Looks sane to me, but I'm not a cfi_signal_frame expert.

Nov 6 2019, 3:24 PM · Restricted Project
lhames committed rGbaaa097360a0: [docs] Fix references to a renamed flag. (authored by lhames).
[docs] Fix references to a renamed flag.
Nov 6 2019, 2:47 PM
lhames closed D69783: [docs] Fixed the flag used to debug with gdb and lli using jit in docs..

No I do not have commit access. Please help me commit this.
Thanks for your help!

Nov 6 2019, 2:47 PM · Restricted Project
lhames committed rG76aee8a38944: [JITLink] Refactor EH-frame handling to support eh-frames with existing relocs. (authored by lhames).
[JITLink] Refactor EH-frame handling to support eh-frames with existing relocs.
Nov 6 2019, 2:31 PM

Nov 5 2019

lhames added a comment to D69817: Fix OrcError build with modules enabled..

I think Chris is right. This isn’t an ideal breakdown of the library, but it’s a step in the right direction: OrcError should should only depend on Support (not the rest of ExecutionEngine), and ExecutionEngine should depend on OrcError.

Nov 5 2019, 6:11 PM · Restricted Project

Nov 4 2019

lhames accepted D69783: [docs] Fixed the flag used to debug with gdb and lli using jit in docs..

Looks good to me. Thanks Jian!

Nov 4 2019, 1:09 PM · Restricted Project
lhames accepted D69805: [Orc] Fix iterator usage after remove.

LGTM. Thanks Alexandre!

Nov 4 2019, 1:00 PM · Restricted Project

Oct 30 2019

lhames committed rG58e66f2f6375: [JITLink] Move block ownership from LinkGraph to Section. (authored by lhames).
[JITLink] Move block ownership from LinkGraph to Section.
Oct 30 2019, 6:01 PM