Page MenuHomePhabricator

lhames (Lang Hames)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 27 2013, 2:34 PM (525 w, 4 d)

Recent Activity

Today

lhames added a comment to D145686: [RuntimeDyld][ELF] Add minimal RISC-V support.

Is there something preventing Bolt from moving to ORC / JITLink? If Bolt is able to move over then the aim should be to do that. If Bolt is unable to move over then we need to know why so that we can address the issue. RuntimeDyld is very much in maintenance mode at the moment, and we're working hard to reach parity in backend coverage so that we can officially deprecate it.

Sun, Mar 26, 2:15 PM · Restricted Project, Restricted Project
lhames committed rG2ad8e6e082e2: [examples] Add export_executable_symbols to HowToUseLLJIT example. (authored by lhames).
[examples] Add export_executable_symbols to HowToUseLLJIT example.
Sun, Mar 26, 11:30 AM · Restricted Project, Restricted Project

Fri, Mar 24

lhames committed rG1703ff776c3a: [llvm-jitlink] Remove unnecessary header include left in 01bdd8cffca. (authored by lhames).
[llvm-jitlink] Remove unnecessary header include left in 01bdd8cffca.
Fri, Mar 24, 4:22 PM · Restricted Project, Restricted Project
lhames committed rG01bdd8cffcaf: [llvm-jitlink] Rename -show-graph option to -show-graphs, make it a regex. (authored by lhames).
[llvm-jitlink] Rename -show-graph option to -show-graphs, make it a regex.
Fri, Mar 24, 4:06 PM · Restricted Project, Restricted Project

Thu, Mar 23

lhames committed rGec2333d88538: [JITLink] Add a jitlink::Section::empty operation. (authored by lhames).
[JITLink] Add a jitlink::Section::empty operation.
Thu, Mar 23, 2:52 PM · Restricted Project, Restricted Project

Wed, Mar 22

lhames accepted D144083: [JITLink] Initial AArch32 backend.

Relocation names should be generic (at least for getEdgeKindName), but otherwise LGTM!

Wed, Mar 22, 2:55 PM · Restricted Project, Restricted Project
lhames accepted D146658: [JITLink] Deterministic JITDylib symbol table dumps.

LGTM. Thanks @sgraenitz!

Wed, Mar 22, 2:03 PM · Restricted Project, Restricted Project
lhames accepted D146641: [JITLink] Introduce target flags for Symbol and prepare ObjectLinkingLayer to account for them.
Wed, Mar 22, 10:03 AM · Restricted Project, Restricted Project

Mon, Mar 20

lhames added inline comments to D146411: Basic VTune support for JITLink.
Mon, Mar 20, 8:38 PM · Restricted Project, Restricted Project
lhames committed rG00c4343d2163: [llvm-jitlink] Fix typo in description of llvm-jitlink's -alias option. (authored by lhames).
[llvm-jitlink] Fix typo in description of llvm-jitlink's -alias option.
Mon, Mar 20, 8:18 PM · Restricted Project, Restricted Project
lhames accepted D146391: Add DWARFContext generation from LinkGraphs, use in perf support.

For testing, there are a couple of options that I think should be possible.

Right now D146169's test is only that the jitdump file exists, not on the accuracy of the content. I've been verifying the content of that file using my own custom python script, so one option is to upload that script (to where?), output to json, and check that json for accuracy (with what tools?).

Mon, Mar 20, 7:11 PM · Restricted Project, Restricted Project
lhames accepted D146169: Non-debuginfo JITLink perf jitdump support.

Do the perf JIT APIs support unloading code? If so these should have a // TODO to fill them in later. (I don't think they're needed for the initial commit).

I don't see any records for code unloading in https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/Documentation/jitdump-specification.txt , and PerfJITEventListener didn't have support for code unloading either, so I'm inclined to believe it doesn't exist right now.

Mon, Mar 20, 6:43 PM · Restricted Project, Restricted Project
lhames committed rGf05ac803ffe7: Re-apply "[JITLink][ELF] Don't skip debug info sections by default." (authored by lhames).
Re-apply "[JITLink][ELF] Don't skip debug info sections by default."
Mon, Mar 20, 3:26 PM · Restricted Project, Restricted Project
lhames committed rGfb1b9945be76: [JITLink][ELF][AArch64] Add support for ELF R_AARCH64_ABS32 relocation. (authored by lhames).
[JITLink][ELF][AArch64] Add support for ELF R_AARCH64_ABS32 relocation.
Mon, Mar 20, 2:03 PM · Restricted Project, Restricted Project

Sun, Mar 19

lhames added a comment to D146391: Add DWARFContext generation from LinkGraphs, use in perf support.

Thanks very much @pchintalapudi!

Sun, Mar 19, 9:05 PM · Restricted Project, Restricted Project
lhames added a comment to D146169: Non-debuginfo JITLink perf jitdump support.

This looks great -- thanks very much @pchintalapudi!

Sun, Mar 19, 8:27 PM · Restricted Project, Restricted Project
lhames committed rG333ae0a6c4d2: [ORC] Use ExecutorAddr instead of JITTargetAddress in JITDylib symbol table. (authored by lhames).
[ORC] Use ExecutorAddr instead of JITTargetAddress in JITDylib symbol table.
Sun, Mar 19, 5:34 PM · Restricted Project, Restricted Project
lhames added a comment to D144276: [ORC] Introduce SetUpExecutorNativePlatform utility..

For the Linux failure it looks like test/ExecutionEngine/OrcLazy/emulated-tls.ll just needed -lljit-platform=Inactive added to preserve the existing failure mode. I'll add that when I update the review this evening.

Sun, Mar 19, 5:05 PM · Restricted Project, Restricted Project
lhames added a comment to D144276: [ORC] Introduce SetUpExecutorNativePlatform utility..

Accidentally landed this before it was ready -- my apologies.

Sun, Mar 19, 4:40 PM · Restricted Project, Restricted Project
lhames added a reverting change for rGbdf5f9c3228d: [ORC] Introduce SetUpExecutorNativePlatform utility.: rG500d530eaf1c: Revert "[ORC] Introduce SetUpExecutorNativePlatform utility.".
Sun, Mar 19, 3:56 PM · Restricted Project, Restricted Project
lhames committed rG500d530eaf1c: Revert "[ORC] Introduce SetUpExecutorNativePlatform utility." (authored by lhames).
Revert "[ORC] Introduce SetUpExecutorNativePlatform utility."
Sun, Mar 19, 3:56 PM · Restricted Project, Restricted Project
lhames added a reverting change for D144276: [ORC] Introduce SetUpExecutorNativePlatform utility.: rG500d530eaf1c: Revert "[ORC] Introduce SetUpExecutorNativePlatform utility.".
Sun, Mar 19, 3:56 PM · Restricted Project, Restricted Project
lhames committed rGbdf5f9c3228d: [ORC] Introduce SetUpExecutorNativePlatform utility. (authored by lhames).
[ORC] Introduce SetUpExecutorNativePlatform utility.
Sun, Mar 19, 3:30 PM · Restricted Project, Restricted Project
lhames closed D144276: [ORC] Introduce SetUpExecutorNativePlatform utility..
Sun, Mar 19, 3:30 PM · Restricted Project, Restricted Project
lhames accepted D142386: ExecutionEngine: support composite types handling..

@Panzerschrek I don't have a problem with this landing, but want to echo Hahnfeld's point: the interpreter is legacy mode at this point. While there are no immediate plan to remove it, it's not being actively maintained either, and it's possible that it will be removed in a future version (though I would expect us to give a deprecation warning well in advance).

Sun, Mar 19, 2:36 PM · Restricted Project, Restricted Project

Sat, Mar 18

lhames committed rG57aeb3054604: [JITLink][ELF] Don't skip debug info sections by default. (authored by lhames).
[JITLink][ELF] Don't skip debug info sections by default.
Sat, Mar 18, 10:45 PM · Restricted Project, Restricted Project
lhames committed rGede78c1704ed: [JITLink][ELF][x86-64] Add support for R_X86_64_32 relocation. (authored by lhames).
[JITLink][ELF][x86-64] Add support for R_X86_64_32 relocation.
Sat, Mar 18, 9:23 PM · Restricted Project, Restricted Project
lhames committed rG0b7e16afc9f8: Re-apply "[JITLink][ORC] Rename MemDeallocPolicy to MemLifetime..." with fixes. (authored by lhames).
Re-apply "[JITLink][ORC] Rename MemDeallocPolicy to MemLifetime..." with fixes.
Sat, Mar 18, 10:14 AM · Restricted Project, Restricted Project

Fri, Mar 17

lhames committed rGb5c862e15caf: [JITLink] Store Sections in a DenseMap with the section name as key. (authored by lhames).
[JITLink] Store Sections in a DenseMap with the section name as key.
Fri, Mar 17, 8:22 PM · Restricted Project, Restricted Project
lhames added a reverting change for rG2cc64df0bd6a: [JITLink][ORC] Rename MemDeallocPolicy to MemLifetimePolicy, add NoAlloc option.: rG5379c46d4906: Revert "[JITLink][ORC] Rename MemDeallocPolicy to MemLifetimePolicy, add ...".
Fri, Mar 17, 12:59 PM · Restricted Project, Restricted Project
lhames committed rG5379c46d4906: Revert "[JITLink][ORC] Rename MemDeallocPolicy to MemLifetimePolicy, add ..." (authored by lhames).
Revert "[JITLink][ORC] Rename MemDeallocPolicy to MemLifetimePolicy, add ..."
Fri, Mar 17, 12:59 PM · Restricted Project, Restricted Project
lhames added a reverting change for D146183: [JITLink][ORC] Rename MemDeallocPolicy to MemLifetimePolicy, add NoAlloc option.: rG5379c46d4906: Revert "[JITLink][ORC] Rename MemDeallocPolicy to MemLifetimePolicy, add ...".
Fri, Mar 17, 12:59 PM · Restricted Project, Restricted Project
lhames committed rG2cc64df0bd6a: [JITLink][ORC] Rename MemDeallocPolicy to MemLifetimePolicy, add NoAlloc option. (authored by lhames).
[JITLink][ORC] Rename MemDeallocPolicy to MemLifetimePolicy, add NoAlloc option.
Fri, Mar 17, 12:39 PM · Restricted Project, Restricted Project
lhames closed D146183: [JITLink][ORC] Rename MemDeallocPolicy to MemLifetimePolicy, add NoAlloc option..
Fri, Mar 17, 12:38 PM · Restricted Project, Restricted Project

Thu, Mar 16

lhames added a comment to D146183: [JITLink][ORC] Rename MemDeallocPolicy to MemLifetimePolicy, add NoAlloc option..

New commit language on edges between Standard/Finalize and NoAlloc sections:

Thu, Mar 16, 9:40 PM · Restricted Project, Restricted Project
lhames updated the diff for D146183: [JITLink][ORC] Rename MemDeallocPolicy to MemLifetimePolicy, add NoAlloc option..

Use NoAlloc lifetime in LinkGraphBuilders for COFF, ELF and MachO.

Thu, Mar 16, 9:18 PM · Restricted Project, Restricted Project

Wed, Mar 15

lhames added a comment to D146183: [JITLink][ORC] Rename MemDeallocPolicy to MemLifetimePolicy, add NoAlloc option..

LinkGraphBuilder changes TBD.

Wed, Mar 15, 7:15 PM · Restricted Project, Restricted Project
lhames requested review of D146183: [JITLink][ORC] Rename MemDeallocPolicy to MemLifetimePolicy, add NoAlloc option..
Wed, Mar 15, 5:48 PM · Restricted Project, Restricted Project

Tue, Mar 14

lhames committed rGb6ae90b86c42: [lli] Register profiling support for ORC in lli (authored by tetzank).
[lli] Register profiling support for ORC in lli
Tue, Mar 14, 5:03 PM · Restricted Project, Restricted Project
lhames added a comment to D126214: Register profiling support for OrcJit in lli.

Very belatedly landed. Thanks again for this Frank!

Tue, Mar 14, 5:03 PM · Restricted Project, Restricted Project
lhames closed D126214: Register profiling support for OrcJit in lli.
Tue, Mar 14, 5:03 PM · Restricted Project, Restricted Project
Herald added a project to D116475: [JITLink] Add anonymous symbols in LinkGraph for unnamed temporary symbols: Restricted Project.

This was reapplied with fixes in 0283b07746e87.

Tue, Mar 14, 3:23 PM · Restricted Project, Restricted Project
lhames accepted D146067: JITLink: Add missing EHFrame NULL terminator on aarch64/ELF.

LGTM. Thanks @tstellar!

Tue, Mar 14, 10:18 AM · Restricted Project, Restricted Project

Sat, Mar 11

lhames added inline comments to D144083: [JITLink] Initial AArch32 backend.
Sat, Mar 11, 3:38 PM · Restricted Project, Restricted Project

Thu, Mar 9

lhames committed rG7163b1ab8d95: [JITLink][docs] Update docs for generic link algorithm and memory manager apis. (authored by lhames).
[JITLink][docs] Update docs for generic link algorithm and memory manager apis.
Thu, Mar 9, 11:38 PM · Restricted Project, Restricted Project
lhames committed rG1b5a60511234: [JITLink] Use unique_function rather than std::function for JITLink passes. (authored by lhames).
[JITLink] Use unique_function rather than std::function for JITLink passes.
Thu, Mar 9, 8:04 PM · Restricted Project, Restricted Project
lhames added a comment to D145710: [ORC] Fix name shadowing issue, NFC..

Hi Aman,

Thu, Mar 9, 7:28 PM · Restricted Project, Restricted Project

Sun, Mar 5

lhames added a comment to D144714: [JITLink] Introduce virtual offsets for Symbol definitions in LinkGraph.

My gut reaction is to want to introduce a new "target flags" concept into Symbol, rather than using/abusing the address. On the other hand I think that using/abusing the address is the standard for thumb, and people might get thrown if this bit _isn't_ where they expect it to be.

Sun, Mar 5, 6:28 PM · Restricted Project, Restricted Project

Wed, Mar 1

lhames committed rG0963833a1943: [ExecutionEngine] Silence warnings about sprintf use in interpreter. (authored by lhames).
[ExecutionEngine] Silence warnings about sprintf use in interpreter.
Wed, Mar 1, 3:39 PM · Restricted Project, Restricted Project
lhames committed rG38d16f509a3f: [ORC] Drop StaticLibraryDefinitionGenerator Load/Create overloads with triples. (authored by lhames).
[ORC] Drop StaticLibraryDefinitionGenerator Load/Create overloads with triples.
Wed, Mar 1, 3:39 PM · Restricted Project, Restricted Project
lhames added inline comments to D144276: [ORC] Introduce SetUpExecutorNativePlatform utility..
Wed, Mar 1, 1:49 PM · Restricted Project, Restricted Project

Feb 22 2023

lhames added inline comments to D144447: [Clang] Teach buildFMulAdd to peek through fneg to find fmul..
Feb 22 2023, 5:00 PM · Restricted Project, Restricted Project

Feb 21 2023

lhames committed rG0df66569e529: [ORC] Add an ExecutionSession::getTargetTriple convenience function. (authored by lhames).
[ORC] Add an ExecutionSession::getTargetTriple convenience function.
Feb 21 2023, 8:17 PM · Restricted Project, Restricted Project
lhames committed rG34fccfb23c47: [ORC-RT] Remove the '__' prefix from the ORC runtime's public API. (authored by lhames).
[ORC-RT] Remove the '__' prefix from the ORC runtime's public API.
Feb 21 2023, 6:37 PM · Restricted Project, Restricted Project
lhames committed rG332a934ced7f: [ORC-RT][MachO] Use 'UseCallbackStyleUnwindInfo' flag, rather than re-test. (authored by lhames).
[ORC-RT][MachO] Use 'UseCallbackStyleUnwindInfo' flag, rather than re-test.
Feb 21 2023, 4:48 PM · Restricted Project, Restricted Project

Feb 20 2023

lhames added a comment to D141797: [ORC] Move 'CompleteAllocation' lambda body into its own method..

Yep -- just moves the lambda body out into a method. NFC.

Feb 20 2023, 10:01 AM · Restricted Project, Restricted Project

Feb 17 2023

lhames committed rG2ec1aba2b69f: [llvm-jitlink] Discard allocation actions in -noexec mode. (authored by lhames).
[llvm-jitlink] Discard allocation actions in -noexec mode.
Feb 17 2023, 8:27 PM · Restricted Project, Restricted Project, Restricted Project
lhames requested review of D144276: [ORC] Introduce SetUpExecutorNativePlatform utility..
Feb 17 2023, 9:38 AM · Restricted Project, Restricted Project

Feb 15 2023

lhames added inline comments to D144083: [JITLink] Initial AArch32 backend.
Feb 15 2023, 11:09 AM · Restricted Project, Restricted Project
lhames added a comment to D144083: [JITLink] Initial AArch32 backend.

Very cool. Thank you for contributing this -- it's great to finally see ARM32 support in JITLink! :)

Feb 15 2023, 10:48 AM · Restricted Project, Restricted Project

Feb 14 2023

lhames committed rGef6d474aa7ac: [ORC] Add ELFNixPlatform::Create overload -- Pass ORC runtime as def generator. (authored by lhames).
[ORC] Add ELFNixPlatform::Create overload -- Pass ORC runtime as def generator.
Feb 14 2023, 7:20 PM · Restricted Project, Restricted Project

Feb 13 2023

lhames committed rG171ffd499e16: [ORC] StaticLibraryDefinitionGenerator -- support in-memory universal binaries. (authored by lhames).
[ORC] StaticLibraryDefinitionGenerator -- support in-memory universal binaries.
Feb 13 2023, 8:54 AM · Restricted Project, Restricted Project

Feb 12 2023

lhames committed rGbe2fc577c389: [ORC] Add MachOPlatform::Create overload -- Pass ORC runtime as def generator. (authored by lhames).
[ORC] Add MachOPlatform::Create overload -- Pass ORC runtime as def generator.
Feb 12 2023, 1:31 PM · Restricted Project, Restricted Project

Feb 11 2023

lhames committed rG6d90c590b7f5: [JITLink] Don't initialize local ArrayRefs with initializer lists. (authored by lhames).
[JITLink] Don't initialize local ArrayRefs with initializer lists.
Feb 11 2023, 5:15 PM · Restricted Project, Restricted Project
lhames committed rG86cbf3d5f8a2: [JITLink] Add explicit conversion to silence warnings / errors on bots. (authored by lhames).
[JITLink] Add explicit conversion to silence warnings / errors on bots.
Feb 11 2023, 1:13 PM · Restricted Project, Restricted Project
lhames committed rG10b5fec25638: [JITLink][ORC] Add LinkGraph::allocateCString method. (authored by lhames).
[JITLink][ORC] Add LinkGraph::allocateCString method.
Feb 11 2023, 12:30 PM · Restricted Project, Restricted Project
lhames committed rG9eccc6cce07b: [JITLink] Add a predicate to test for C-string blocks. (authored by lhames).
[JITLink] Add a predicate to test for C-string blocks.
Feb 11 2023, 10:52 AM · Restricted Project, Restricted Project
lhames committed rG3d4e9d5eb0f7: [ORC] Move ORC-specific object format details into OrcShared. (authored by lhames).
[ORC] Move ORC-specific object format details into OrcShared.
Feb 11 2023, 10:52 AM · Restricted Project, Restricted Project

Feb 10 2023

lhames committed rG0751fc68b976: [libunwind] On Darwin, add a callback-based lookup scheme for JIT'd unwind info. (authored by lhames).
[libunwind] On Darwin, add a callback-based lookup scheme for JIT'd unwind info.
Feb 10 2023, 2:37 PM · Restricted Project
lhames closed D142176: [libunwind] On Darwin, add a callback-based lookup scheme for JIT'd unwind info..
Feb 10 2023, 2:37 PM · Restricted Project, Restricted Project, Restricted Project

Feb 8 2023

lhames accepted D143568: [RuntimeDyld][ELF] Fixed relocations referencing undefined TLS symbols.

LGTM.

Feb 8 2023, 7:50 AM · Restricted Project, Restricted Project

Feb 4 2023

lhames added a comment to D142443: [ORC] Drop Comdat when discarding IR symbol.

I received three complaints from AArch64 bots now failing Clang Interpreter tests, for example: https://lab.llvm.org/buildbot/#/builders/197/builds/3920 I don't quite understand how this can happen and currently have no easy way to verify, so reverting a second time...

Feb 4 2023, 9:15 PM · Restricted Project, Restricted Project
lhames added a comment to D143039: [AArch64] Unconditionally use DW_EH_PE_indirect|DW_EH_PE_pcrel personality/lsda/ttype encodings.

LLJIT has been update to default to JITLink on arm64 in 6747fc07d1aa, and on my local machine the interpreter tests now pass with this patch applied.

Feb 4 2023, 9:11 PM · Restricted Project, Restricted Project
lhames committed rG6747fc07d1aa: [ORC] Use JITLink as the default linker for LLJIT on Linux/arm64. (authored by lhames).
[ORC] Use JITLink as the default linker for LLJIT on Linux/arm64.
Feb 4 2023, 9:09 PM · Restricted Project, Restricted Project
lhames added a comment to D143039: [AArch64] Unconditionally use DW_EH_PE_indirect|DW_EH_PE_pcrel personality/lsda/ttype encodings.

My best guess is that the JIT linker is dropping this. I'm just doing a Linux build now so that I can figure out what's going wrong.

I suspect that 43acef48d38ec0dd391f212144d4a25095e4fc5f has incomplete support.

Feb 4 2023, 6:18 PM · Restricted Project, Restricted Project
lhames added a comment to D143039: [AArch64] Unconditionally use DW_EH_PE_indirect|DW_EH_PE_pcrel personality/lsda/ttype encodings.
JIT session error: Symbols not found: [ DW.ref.__gxx_personality_v0 ]

If I hand-compile source for the failing simple-execution.cpp testcase on Darwin with clang --target=arm64-pc-linux-gnu -fno-pic -S I see new references to DW.ref.__gxx_personality_v0, but I also see a definition:

        .hidden DW.ref.__gxx_personality_v0
        .weak   DW.ref.__gxx_personality_v0
        .section        .data.DW.ref.__gxx_personality_v0,"aGw",@progbits,DW.ref.__gxx_personality_v0,comdat
        .p2align        3, 0x0
        .type   DW.ref.__gxx_personality_v0,@object
        .size   DW.ref.__gxx_personality_v0, 8
DW.ref.__gxx_personality_v0:
        .xword  __gxx_personality_v0

My best guess is that the JIT linker is dropping this. I'm just doing a Linux build now so that I can figure out what's going wrong.

Feb 4 2023, 9:35 AM · Restricted Project, Restricted Project

Feb 3 2023

lhames added a comment to D142443: [ORC] Drop Comdat when discarding IR symbol.

Instead of adding an xfail, does it make more sense to pass an explicit triple to lli instead?

Feb 3 2023, 12:05 PM · Restricted Project, Restricted Project
lhames committed rG7e528d4689e6: [ORC] Make weak-comdat.ll testcase UNSUPPORTED on Darwin, rather than XFAIL. (authored by lhames).
[ORC] Make weak-comdat.ll testcase UNSUPPORTED on Darwin, rather than XFAIL.
Feb 3 2023, 12:04 PM · Restricted Project, Restricted Project

Feb 1 2023

lhames committed rGd42c2352aa3a: [JITLink] Ensure that in-flight alloc is abandoned on error in post-alloc phase. (authored by lhames).
[JITLink] Ensure that in-flight alloc is abandoned on error in post-alloc phase.
Feb 1 2023, 6:05 PM · Restricted Project, Restricted Project
lhames committed rG2aa85ecaf61d: [ORC] Merge redundant jitlink::Symbol -> JITSymbolFlags mappings. (authored by lhames).
[ORC] Merge redundant jitlink::Symbol -> JITSymbolFlags mappings.
Feb 1 2023, 4:40 PM · Restricted Project, Restricted Project

Jan 31 2023

lhames committed rG930d477d5d8f: [lli] Don't create an ExecutorProcessControl in non-remote MCJIT config. (authored by lhames).
[lli] Don't create an ExecutorProcessControl in non-remote MCJIT config.
Jan 31 2023, 6:25 PM · Restricted Project, Restricted Project
lhames committed rG380355cb4c6b: [ORC] Fix an iterator invalidation issue in JITDylib::defineMaterializing. (authored by lhames).
[ORC] Fix an iterator invalidation issue in JITDylib::defineMaterializing.
Jan 31 2023, 6:11 PM · Restricted Project, Restricted Project
lhames committed rG6df32b8db1f0: [ORC] Enable DenseMap<SymbolStringPtr, T>::find_as(NonOwningSymbolStringPtr). (authored by lhames).
[ORC] Enable DenseMap<SymbolStringPtr, T>::find_as(NonOwningSymbolStringPtr).
Jan 31 2023, 6:11 PM · Restricted Project, Restricted Project
lhames committed rG81334f4b018e: [ORC] Further improvements to SymbolStringPtr & NonOwningSymbolStringPtr. (authored by lhames).
[ORC] Further improvements to SymbolStringPtr & NonOwningSymbolStringPtr.
Jan 31 2023, 4:42 PM · Restricted Project, Restricted Project
lhames committed rGeded5d381565: [ORC] Add a NonOwningSymbolStringPtr utility. (authored by lhames).
[ORC] Add a NonOwningSymbolStringPtr utility.
Jan 31 2023, 2:28 PM · Restricted Project, Restricted Project
lhames closed D142314: [ORC] Add a NonOwningSymbolStringPtr utility..
Jan 31 2023, 2:28 PM · Restricted Project, Restricted Project
lhames added inline comments to D142314: [ORC] Add a NonOwningSymbolStringPtr utility..
Jan 31 2023, 11:11 AM · Restricted Project, Restricted Project
lhames updated the diff for D142314: [ORC] Add a NonOwningSymbolStringPtr utility..

Address latest feedback.

Jan 31 2023, 11:08 AM · Restricted Project, Restricted Project
lhames accepted D142954: [ExecutionEngine] Enable ExecutionEngine regression tests on LoongArch.

LGTM. Thanks @wangleiat!

Jan 31 2023, 8:30 AM · Restricted Project, Restricted Project

Jan 30 2023

lhames added a comment to D142176: [libunwind] On Darwin, add a callback-based lookup scheme for JIT'd unwind info..

Are there any further comments on this patch? If not I'll go ahead and land it based on Pete's approval.

Jan 30 2023, 11:42 AM · Restricted Project, Restricted Project, Restricted Project

Jan 29 2023

lhames committed rGc0320e731fdf: [ORC] Add ordering to ExecutorAddrRanges. (authored by lhames).
[ORC] Add ordering to ExecutorAddrRanges.
Jan 29 2023, 3:24 PM · Restricted Project, Restricted Project
lhames accepted D142846: [JITLink] Adds support for PLT based relocations to the ELF/i386 JITLink backend.

Looks great! Thanks very much @jain98!

Jan 29 2023, 2:44 PM · Restricted Project, Restricted Project

Jan 28 2023

lhames committed rG2667be0eb85b: [JITLink][MachO] Error on N_EXT symbols with illegal string-table index 0. (authored by lhames).
[JITLink][MachO] Error on N_EXT symbols with illegal string-table index 0.
Jan 28 2023, 7:59 PM · Restricted Project, Restricted Project

Jan 24 2023

lhames accepted D142352: [CodeGen] Filter out available_externally aliases.

This looks right to me -- the verifier already requires available_externally aliases to point to other available_externally symbols, so if we're skipping an alias here then we know that we'll also skip all the things that it points to.

Jan 24 2023, 5:07 PM · Restricted Project, Restricted Project
lhames updated the diff for D142314: [ORC] Add a NonOwningSymbolStringPtr utility..

Address review feedback.

Jan 24 2023, 4:30 PM · Restricted Project, Restricted Project
lhames added a comment to D142188: [ORC] Fix in-process lookup of symbols without GlobalPrefix.

Sure, but is this actually relevant? Passing foo is not properly mangled and an error on the client side.

Jan 24 2023, 9:48 AM · Restricted Project, Restricted Project, Restricted Project
lhames accepted D138264: [COFF] Improve JIT support of weak symbols.

LGTM!

Jan 24 2023, 9:00 AM · Restricted Project, Restricted Project

Jan 23 2023

lhames added a comment to D142176: [libunwind] On Darwin, add a callback-based lookup scheme for JIT'd unwind info..

Here's a potential testcase, for anyone who wants to try this out. You'll need to build LLVM, compiler-rt, and libunwind:

Jan 23 2023, 10:48 PM · Restricted Project, Restricted Project, Restricted Project
lhames added a comment to D140627: [orc] Pass big JITTargetMachineBuilder parameters by reference to avoid unnecessary copies.

JITTargetMachineBuilders are only moved around at startup at the moment, and they're only ~0.5kb. Have they been observed to have a performance impact? If so we should probably transfer them via unique_ptr to avoid the copies, but I'm not sure it's necessary yet.

Jan 23 2023, 10:31 PM · Restricted Project, Restricted Project
lhames added a reviewer for D142176: [libunwind] On Darwin, add a callback-based lookup scheme for JIT'd unwind info.: ab.
Jan 23 2023, 5:54 PM · Restricted Project, Restricted Project, Restricted Project