Page MenuHomePhabricator

glider (Alexander Potapenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 6 2012, 6:28 AM (509 w, 4 d)

Recent Activity

Jul 13 2022

glider requested review of D129645: [compiler-rt][hwasan] Support for new Intel LAM API.
Jul 13 2022, 7:44 AM · Restricted Project, Restricted Project

Jun 29 2022

glider requested review of D128810: [Sanitizer] Switch the LAM repository to another repo.
Jun 29 2022, 5:36 AM · Restricted Project

Jun 17 2022

glider committed rG7ab44b5c2155: [msan] Allow KMSAN to use -fsanitize-memory-param-retval (authored by glider).
[msan] Allow KMSAN to use -fsanitize-memory-param-retval
Jun 17 2022, 1:54 AM · Restricted Project, Restricted Project
glider closed D127860: [msan] Allow KMSAN to use -fsanitize-memory-param-retval.
Jun 17 2022, 1:54 AM · Restricted Project, Restricted Project

Jun 16 2022

glider updated the diff for D127860: [msan] Allow KMSAN to use -fsanitize-memory-param-retval.

Rebase

Jun 16 2022, 1:07 PM · Restricted Project, Restricted Project

Jun 15 2022

glider added reviewers for D127860: [msan] Allow KMSAN to use -fsanitize-memory-param-retval: eugenis, vitalybuka, kda.
Jun 15 2022, 7:34 AM · Restricted Project, Restricted Project
glider requested review of D127860: [msan] Allow KMSAN to use -fsanitize-memory-param-retval.
Jun 15 2022, 7:33 AM · Restricted Project, Restricted Project

May 31 2022

glider updated the summary of D126385: [msan] Implement -msan-pass-caller-to-runtime..
May 31 2022, 4:25 AM · Restricted Project, Restricted Project
glider added a comment to D126385: [msan] Implement -msan-pass-caller-to-runtime..

FWIW in my current configuration out of 128K instrumented functions there are 120K calls to msan_get_context_state_caller() and 8K calls to msan_get_context_state().

May 31 2022, 1:39 AM · Restricted Project, Restricted Project

May 30 2022

glider updated the diff for D126385: [msan] Implement -msan-pass-caller-to-runtime..

Updated a comment

May 30 2022, 9:52 AM · Restricted Project, Restricted Project
glider updated the diff for D126385: [msan] Implement -msan-pass-caller-to-runtime..

Introduced __msan_get_context_state_caller()

May 30 2022, 9:50 AM · Restricted Project, Restricted Project
glider added a comment to D126385: [msan] Implement -msan-pass-caller-to-runtime..

Do you have estimate of how often this happend? How many different instrumented functions which can be called from uninstrumented code?

May 30 2022, 7:57 AM · Restricted Project, Restricted Project

May 25 2022

glider requested review of D126385: [msan] Implement -msan-pass-caller-to-runtime..
May 25 2022, 8:10 AM · Restricted Project, Restricted Project

Mar 30 2022

glider accepted D122724: [AddressSanitizer] Allow prefixing meminstrinsic calls in kernel mode.
Mar 30 2022, 7:32 AM · Restricted Project, Restricted Project
glider added a comment to D122724: [AddressSanitizer] Allow prefixing meminstrinsic calls in kernel mode.

LGTM. Thanks for taking care of this!

Mar 30 2022, 5:33 AM · Restricted Project, Restricted Project

Feb 18 2022

glider committed rGc85a26454d4b: [asan] Add support for disable_sanitizer_instrumentation attribute (authored by glider).
[asan] Add support for disable_sanitizer_instrumentation attribute
Feb 18 2022, 12:52 AM
glider closed D120055: [asan] Add support for disable_sanitizer_instrumentation attribute.
Feb 18 2022, 12:52 AM · Restricted Project, Restricted Project

Feb 17 2022

glider requested review of D120055: [asan] Add support for disable_sanitizer_instrumentation attribute.
Feb 17 2022, 6:55 AM · Restricted Project, Restricted Project
glider committed rGbe77afe43dd3: tsan: Add a missing disable_sanitizer_instrumentation attribute (authored by glider).
tsan: Add a missing disable_sanitizer_instrumentation attribute
Feb 17 2022, 6:35 AM
glider closed D120050: tsan: Add a missing disable_sanitizer_instrumentation attribute.
Feb 17 2022, 6:35 AM · Restricted Project
glider requested review of D120050: tsan: Add a missing disable_sanitizer_instrumentation attribute.
Feb 17 2022, 6:17 AM · Restricted Project

Feb 15 2022

glider added a reverting change for rGdd145f953db3: [asan] Add support for disable_sanitizer_instrumentation attribute: rG05ee1f4af897: Revert "[asan] Add support for disable_sanitizer_instrumentation attribute".
Feb 15 2022, 6:05 AM
glider committed rG05ee1f4af897: Revert "[asan] Add support for disable_sanitizer_instrumentation attribute" (authored by glider).
Revert "[asan] Add support for disable_sanitizer_instrumentation attribute"
Feb 15 2022, 6:05 AM
glider added a reverting change for D119726: [asan] Add support for disable_sanitizer_instrumentation attribute: rG05ee1f4af897: Revert "[asan] Add support for disable_sanitizer_instrumentation attribute".
Feb 15 2022, 6:05 AM · Restricted Project, Restricted Project
glider closed D119838: Revert "[asan] Add support for disable_sanitizer_instrumentation attribute".
Feb 15 2022, 6:05 AM · Restricted Project, Restricted Project
glider added a reverting change for rGdd145f953db3: [asan] Add support for disable_sanitizer_instrumentation attribute: D119838: Revert "[asan] Add support for disable_sanitizer_instrumentation attribute".
Feb 15 2022, 6:03 AM
glider requested review of D119838: Revert "[asan] Add support for disable_sanitizer_instrumentation attribute".
Feb 15 2022, 6:03 AM · Restricted Project, Restricted Project
glider added a reverting change for D119726: [asan] Add support for disable_sanitizer_instrumentation attribute: D119838: Revert "[asan] Add support for disable_sanitizer_instrumentation attribute".
Feb 15 2022, 6:03 AM · Restricted Project, Restricted Project
glider committed rGdd145f953db3: [asan] Add support for disable_sanitizer_instrumentation attribute (authored by glider).
[asan] Add support for disable_sanitizer_instrumentation attribute
Feb 15 2022, 5:06 AM
glider closed D119726: [asan] Add support for disable_sanitizer_instrumentation attribute.
Feb 15 2022, 5:06 AM · Restricted Project, Restricted Project
glider updated the diff for D119726: [asan] Add support for disable_sanitizer_instrumentation attribute.

Rebase

Feb 15 2022, 2:23 AM · Restricted Project, Restricted Project

Feb 14 2022

glider updated subscribers of D119726: [asan] Add support for disable_sanitizer_instrumentation attribute.
Feb 14 2022, 8:18 AM · Restricted Project, Restricted Project
glider requested review of D119726: [asan] Add support for disable_sanitizer_instrumentation attribute.
Feb 14 2022, 8:04 AM · Restricted Project, Restricted Project

Jan 10 2022

glider accepted D115440: Provide __builtin_alloca*_uninitialized variants.

FWIW the implementation looks good to me.

Jan 10 2022, 6:50 AM · Restricted Project

Dec 10 2021

glider committed rG2b554920f11c: [asan] Add support for disable_sanitizer_instrumentation attribute (authored by glider).
[asan] Add support for disable_sanitizer_instrumentation attribute
Dec 10 2021, 3:21 AM
glider closed D114421: [asan] Add support for disable_sanitizer_instrumentation attribute.
Dec 10 2021, 3:20 AM · Restricted Project, Restricted Project
glider committed rG1aa59ff2f789: [msan] Implement -msan-disable-checks. (authored by glider).
[msan] Implement -msan-disable-checks.
Dec 10 2021, 1:39 AM
glider closed D115236: [msan] Implement -msan-disable-checks..
Dec 10 2021, 1:38 AM · Restricted Project

Dec 9 2021

glider updated the diff for D114421: [asan] Add support for disable_sanitizer_instrumentation attribute.

Fix a windows test failure: https://buildkite.com/llvm-project/premerge-checks/builds/69318#0b873cc6-bf07-482a-ac37-e960566ac8a3

Dec 9 2021, 8:58 AM · Restricted Project, Restricted Project
glider updated the diff for D114421: [asan] Add support for disable_sanitizer_instrumentation attribute.

Rebase.

Dec 9 2021, 7:56 AM · Restricted Project, Restricted Project
glider retitled D115236: [msan] Implement -msan-disable-checks. from [msan] Implement -msan-no-sanitize-all. to [msan] Implement -msan-disable-checks..
Dec 9 2021, 6:41 AM · Restricted Project
glider updated the diff for D115236: [msan] Implement -msan-disable-checks..

Rename the flag

Dec 9 2021, 6:39 AM · Restricted Project
glider added a comment to D115440: Provide __builtin_alloca*_uninitialized variants.

For completeness, also provide __builtin_alloca_with_align_uninitialized().

Dec 9 2021, 6:35 AM · Restricted Project
glider added a comment to D115440: Provide __builtin_alloca*_uninitialized variants.

I second this proposal.
https://reviews.llvm.org/D60548 suggests to handle this case using a pragma, but the required change seems to be more intrusive.

Dec 9 2021, 5:12 AM · Restricted Project
glider added inline comments to D115236: [msan] Implement -msan-disable-checks..
Dec 9 2021, 3:48 AM · Restricted Project

Dec 8 2021

glider added inline comments to D115236: [msan] Implement -msan-disable-checks..
Dec 8 2021, 2:11 PM · Restricted Project
glider updated the diff for D115236: [msan] Implement -msan-disable-checks..

Rebase

Dec 8 2021, 9:40 AM · Restricted Project
glider updated the diff for D115236: [msan] Implement -msan-disable-checks..

Fixed flag name

Dec 8 2021, 6:21 AM · Restricted Project
glider retitled D115236: [msan] Implement -msan-disable-checks. from [msan] Implement -msan-no-sanitize-whole-file. to [msan] Implement -msan-no-sanitize-all..
Dec 8 2021, 5:16 AM · Restricted Project
glider added inline comments to D115236: [msan] Implement -msan-disable-checks..
Dec 8 2021, 4:46 AM · Restricted Project
glider updated the diff for D115236: [msan] Implement -msan-disable-checks..

Addressed review comments

Dec 8 2021, 4:46 AM · Restricted Project

Dec 7 2021

glider added a comment to D114421: [asan] Add support for disable_sanitizer_instrumentation attribute.

Should we have in AddressSanitizer.cpp the following for consistency with other sanitizers?

Dec 7 2021, 7:14 AM · Restricted Project, Restricted Project
glider updated the diff for D114421: [asan] Add support for disable_sanitizer_instrumentation attribute.

Updated asan-globals.cpp

Dec 7 2021, 7:09 AM · Restricted Project, Restricted Project
glider updated the diff for D114421: [asan] Add support for disable_sanitizer_instrumentation attribute.

Addressed the comments

Dec 7 2021, 6:52 AM · Restricted Project, Restricted Project
glider added inline comments to D115236: [msan] Implement -msan-disable-checks..
Dec 7 2021, 4:34 AM · Restricted Project
glider requested review of D115236: [msan] Implement -msan-disable-checks..
Dec 7 2021, 4:32 AM · Restricted Project

Dec 2 2021

glider added a comment to D114421: [asan] Add support for disable_sanitizer_instrumentation attribute.

Given this is a minor change that only affects users of disable_sanitizer_instrumentation, I'm inclined towards landing it.

Dec 2 2021, 3:23 AM · Restricted Project, Restricted Project

Nov 29 2021

glider added a comment to D114421: [asan] Add support for disable_sanitizer_instrumentation attribute.

Vitaly, Evgenii, can one of you please take a look?

Nov 29 2021, 2:58 AM · Restricted Project, Restricted Project
glider added a reviewer for D114421: [asan] Add support for disable_sanitizer_instrumentation attribute: eugenis.
Nov 29 2021, 2:58 AM · Restricted Project, Restricted Project

Nov 23 2021

glider requested review of D114421: [asan] Add support for disable_sanitizer_instrumentation attribute.
Nov 23 2021, 1:35 AM · Restricted Project, Restricted Project

Nov 17 2021

glider accepted D114079: tsan: don't consider debug calls as calls.

LGTM

Nov 17 2021, 5:05 AM · Restricted Project

Nov 8 2021

glider added inline comments to D113045: [HWASan] Ensure RNG is initialized in GenerateRandomTag.
Nov 8 2021, 1:03 AM · Restricted Project

Nov 4 2021

glider added inline comments to D113045: [HWASan] Ensure RNG is initialized in GenerateRandomTag.
Nov 4 2021, 4:32 AM · Restricted Project

Aug 23 2021

glider committed rGcdb391698bb2: [tsan] Do not include <stdatomic.h> from sanitize-thread-disable.c (authored by glider).
[tsan] Do not include <stdatomic.h> from sanitize-thread-disable.c
Aug 23 2021, 7:25 AM
glider closed D108555: [tsan] Do not include <stdatomic.h> from sanitize-thread-disable.c.
Aug 23 2021, 7:24 AM · Restricted Project
glider retitled D108555: [tsan] Do not include <stdatomic.h> from sanitize-thread-disable.c from [tsan] Make sanitize-thread-disable.c an X86-only test to [tsan] Do not include <stdatomic.h> from sanitize-thread-disable.c.
Aug 23 2021, 7:18 AM · Restricted Project
glider added a comment to D108555: [tsan] Do not include <stdatomic.h> from sanitize-thread-disable.c.

LGTM, thanks!

Patch title ("...an X86-only test..") also needs adjustment.

Aug 23 2021, 7:17 AM · Restricted Project
glider added inline comments to D108555: [tsan] Do not include <stdatomic.h> from sanitize-thread-disable.c.
Aug 23 2021, 7:12 AM · Restricted Project
glider updated the diff for D108555: [tsan] Do not include <stdatomic.h> from sanitize-thread-disable.c.

Removed the header

Aug 23 2021, 7:12 AM · Restricted Project
glider added a comment to D108555: [tsan] Do not include <stdatomic.h> from sanitize-thread-disable.c.

Not really sure what's the best solution here, but I think restricting the test to x86 should help.
So far only ARM and PPC bots reported failures.

Aug 23 2021, 6:59 AM · Restricted Project
glider requested review of D108555: [tsan] Do not include <stdatomic.h> from sanitize-thread-disable.c.
Aug 23 2021, 6:56 AM · Restricted Project
glider committed rG8300d52e8cbf: [tsan] Add support for disable_sanitizer_instrumentation attribute (authored by glider).
[tsan] Add support for disable_sanitizer_instrumentation attribute
Aug 23 2021, 3:41 AM
glider closed D108202: [tsan] Add support for disable_sanitizer_instrumentation attribute.
Aug 23 2021, 3:40 AM · Restricted Project, Restricted Project
glider updated the diff for D108202: [tsan] Add support for disable_sanitizer_instrumentation attribute.

Addressed Marco's comments

Aug 23 2021, 3:26 AM · Restricted Project, Restricted Project

Aug 20 2021

glider committed rG417a49e78e73: [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c (authored by glider).
[msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c
Aug 20 2021, 7:01 AM
glider closed D108465: [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c.
Aug 20 2021, 7:00 AM · Restricted Project
glider added a comment to D108465: [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c.

Who reported the issue? Might be worth mentioning in commit message, otherwise it appears to come out of nowhere (although it's semi-obvious given x86-64 is only supported).

Aug 20 2021, 6:59 AM · Restricted Project
glider updated the diff for D108465: [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c.

Updated patch description with links to bot failures.

Aug 20 2021, 6:58 AM · Restricted Project
glider added a comment to D108465: [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c.

TBR

Aug 20 2021, 6:54 AM · Restricted Project
glider requested review of D108465: [msan] Hotfix clang/test/CodeGen/sanitize-memory-disable.c.
Aug 20 2021, 6:53 AM · Restricted Project
glider committed rG8dc7dcdca1e0: [msan] Add support for disable_sanitizer_instrumentation attribute (authored by glider).
[msan] Add support for disable_sanitizer_instrumentation attribute
Aug 20 2021, 6:14 AM
glider closed D108199: [msan] Add support for disable_sanitizer_instrumentation attribute.
Aug 20 2021, 6:14 AM · Restricted Project, Restricted Project
glider added inline comments to D108199: [msan] Add support for disable_sanitizer_instrumentation attribute.
Aug 20 2021, 6:03 AM · Restricted Project, Restricted Project
glider updated the diff for D108199: [msan] Add support for disable_sanitizer_instrumentation attribute.

Addressed Marco's comments

Aug 20 2021, 6:01 AM · Restricted Project, Restricted Project
glider updated the diff for D108199: [msan] Add support for disable_sanitizer_instrumentation attribute.

Updated after landing the disable_sanitizer_instrumentation to LLVM

Aug 20 2021, 5:39 AM · Restricted Project, Restricted Project
glider committed rGb0391dfc737e: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute (authored by glider).
[clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute
Aug 20 2021, 5:06 AM
glider closed D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute.
Aug 20 2021, 5:06 AM · Restricted Project, Restricted Project, Restricted Project
glider added a comment to D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute.

llvm/docs/LangRef.rst also needs a corresponding change.

Right, will do. I thought LangRef was missing the sanitizer bits as well, and was planning to add them together, but apparently I was just looking for the wrong attributes.

Aug 20 2021, 4:10 AM · Restricted Project, Restricted Project, Restricted Project
glider updated the diff for D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute.

Updated LangRef.rst

Aug 20 2021, 4:04 AM · Restricted Project, Restricted Project, Restricted Project

Aug 19 2021

glider added a comment to D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute.

llvm/docs/LangRef.rst also needs a corresponding change.

Aug 19 2021, 7:01 AM · Restricted Project, Restricted Project, Restricted Project
glider updated the diff for D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute.

Updated BitcodeReader.cpp and several tests per Marco's suggestion
Renamed ATTR_DISABLE_SANITIZER_INSTRUMENTATION to ATTR_KIND_DISABLE_SANITIZER_INSTRUMENTATION

Aug 19 2021, 6:20 AM · Restricted Project, Restricted Project, Restricted Project
glider added inline comments to D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute.
Aug 19 2021, 5:34 AM · Restricted Project, Restricted Project, Restricted Project
glider accepted D108305: [tsan] Fix pthread_once() on Mac OS X.

LGTM, thanks!

Aug 19 2021, 3:39 AM · Restricted Project
glider accepted D108278: [clang] Do not warn unused -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang.

I don't have a strong opinion on this. On one hand, passing the correct flags should be something best taken care of by the build system.
On the other hand, letting this flag proliferate is a good thing to do, so let's make the users' life a bit easier.

Aug 19 2021, 2:13 AM · Restricted Project

Aug 18 2021

glider committed rG7338be0e6e8d: [tsan] Disable Trace.MemoryAccessSize on Mac (authored by glider).
[tsan] Disable Trace.MemoryAccessSize on Mac
Aug 18 2021, 6:10 AM
glider closed D108294: [tsan] Disable Trace.MemoryAccessSize on Mac.
Aug 18 2021, 6:10 AM · Restricted Project
glider added a comment to D108294: [tsan] Disable Trace.MemoryAccessSize on Mac.

Please take a look

Aug 18 2021, 5:41 AM · Restricted Project
glider requested review of D108294: [tsan] Disable Trace.MemoryAccessSize on Mac.
Aug 18 2021, 5:40 AM · Restricted Project
glider added a comment to D107359: tsan: unify __cxa_guard_acquire and pthread_once implementations.

Let me go ahead and mark this test as unsupported on Darwin for now until we get it sorted out.

Aug 18 2021, 4:36 AM · Restricted Project

Aug 17 2021

glider added inline comments to D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute.
Aug 17 2021, 7:04 AM · Restricted Project, Restricted Project, Restricted Project