User Details
User Details
- User Since
- Apr 13 2015, 9:48 AM (110 w, 1 d)
Recent Activity
Recent Activity
Yesterday
Yesterday
davidxl committed rL303567: [PartialInlining] Add internal options to enable partial inlining in pass….
[PartialInlining] Add internal options to enable partial inlining in pass…
davidxl updated the diff for D33382: [PartialInlining] introduce an internal option to add partial inlining pass in the pipeline (off by default for now).
added internal option for new PM as well.
Sat, May 20
Sat, May 20
Fri, May 19
Fri, May 19
davidxl updated the diff for D33164: [Profile[ Enhance expect lowering to handle correlated branches.
Addressed review comments.
davidxl added inline comments to D33164: [Profile[ Enhance expect lowering to handle correlated branches.
davidxl added a comment to D33164: [Profile[ Enhance expect lowering to handle correlated branches.
Any more comments?
Tue, May 16
Tue, May 16
davidxl updated the diff for D33164: [Profile[ Enhance expect lowering to handle correlated branches.
Address review feedback.
davidxl added inline comments to D33164: [Profile[ Enhance expect lowering to handle correlated branches.
davidxl updated the diff for D33164: [Profile[ Enhance expect lowering to handle correlated branches.
Address Chandler's feedbacks.
davidxl added inline comments to D33164: [Profile[ Enhance expect lowering to handle correlated branches.
davidxl updated the diff for D33164: [Profile[ Enhance expect lowering to handle correlated branches.
Address Wei's review feebback.
davidxl added inline comments to D33164: [Profile[ Enhance expect lowering to handle correlated branches.
lgtm
davidxl added inline comments to D30633: [BPI] Reduce the probability of unreachable edge to minimal value greater than 0.
davidxl added a comment to D30633: [BPI] Reduce the probability of unreachable edge to minimal value greater than 0.
That is not my question :)
davidxl added a comment to D30633: [BPI] Reduce the probability of unreachable edge to minimal value greater than 0.
It is known that BFI can not handle zero weight and it will add 1 to zero weight when it sees it.
Mon, May 15
Mon, May 15
Sat, May 13
Sat, May 13
Renable test that was disabled due to cost analysis
Fix test failure on windows -- do not return deleted func
Fri, May 12
Fri, May 12
[PartialInlining] Profile based cost analysis
lgtm
davidxl updated the diff for D32783: [PartialInlining] Add frequency based cost analysis.
Address review feedbacks.
davidxl added inline comments to D32783: [PartialInlining] Add frequency based cost analysis.
davidxl updated the diff for D32783: [PartialInlining] Add frequency based cost analysis.
Remove { }
davidxl added inline comments to D32324: CodeGen: BlockPlacement: Increase tail duplication size for O3..
Wed, May 10
Wed, May 10
davidxl updated the diff for D32783: [PartialInlining] Add frequency based cost analysis.
Further tuned cost/benefit computation with SPEC 2k/06 tuning. Get speedups in a few benchmarks and fixed the regression in perlbmk (many cases with early return branch which is never taken).
davidxl accepted D32688: [Coverage] Comdat section name should be same as the variable name in COFF format.
lgtm
Fri, May 5
Fri, May 5
davidxl updated the diff for D32783: [PartialInlining] Add frequency based cost analysis.
Address feedback -- revert change in CodeExtractor.h and .cc file
Thu, May 4
Thu, May 4
davidxl added inline comments to D32783: [PartialInlining] Add frequency based cost analysis.
davidxl updated the diff for D32783: [PartialInlining] Add frequency based cost analysis.
- Addressed review feedbacks
- More refactorings and naming cleanups (for consistency)
- Added handling of function entry count update and a new test case for it.
davidxl added inline comments to D32783: [PartialInlining] Add frequency based cost analysis.
davidxl updated the diff for D32783: [PartialInlining] Add frequency based cost analysis.
Addressed review feedbacks by eraman
Wed, May 3
Wed, May 3
davidxl added inline comments to D28593: Update loop branch_weight metadata after loop rotation..
davidxl added inline comments to D32688: [Coverage] Comdat section name should be same as the variable name in COFF format.
davidxl added inline comments to D32324: CodeGen: BlockPlacement: Increase tail duplication size for O3..
Tue, May 2
Tue, May 2
davidxl updated the diff for D32783: [PartialInlining] Add frequency based cost analysis.
Update test case -- added a cold region test.
[PartialInlining] Add more early filtering
Mon, May 1
Mon, May 1
Refactor callsite cost computation into a helper function /NFC
[PartialInlining] Hook up inline cost analysis
davidxl added a comment to D32688: [Coverage] Comdat section name should be same as the variable name in COFF format.
This patch basically splits the comdat section for data, counters and value vars with COFF.
Sun, Apr 30
Sun, Apr 30
davidxl updated the diff for D32666: [PartialInlining] Add support in partial inliner to use cost analysis in inliner .
Address review feedback -- add one more test case.
Fri, Apr 28
Fri, Apr 28
davidxl added a comment to D32563: Add LiveRangeShrink pass to shrink live range within BB..
A couple of comments:
lgtm
Thu, Apr 27
Thu, Apr 27
davidxl added inline comments to D32624: Memory intrinsic value profile optimization: Avoid divide by 0.
davidxl added inline comments to D32624: Memory intrinsic value profile optimization: Avoid divide by 0.
davidxl added inline comments to D32563: Add LiveRangeShrink pass to shrink live range within BB..
lgtm
davidxl committed rL301561: [PartialInlining]: Improve partial inlining to handle complex conditions.
[PartialInlining]: Improve partial inlining to handle complex conditions
Wed, Apr 26
Wed, Apr 26
davidxl updated the diff for D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
Addressed review feedback by eraman.
davidxl added inline comments to D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
davidxl updated the diff for D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
Address review comments.
davidxl added inline comments to D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
davidxl updated the diff for D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
Address Wei's review feedback. Also fixed a bug found in clang self build test.
davidxl added inline comments to D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
Tue, Apr 25
Tue, Apr 25
davidxl updated the diff for D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
addressed review comments.
davidxl added inline comments to D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
davidxl updated the diff for D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
Address review feedback. The new version now can handle more general conditions (see test cases).
Mon, Apr 24
Mon, Apr 24
[CodeExtractor]: Fixup use refs of the old phi.
lgtm
lgtm
davidxl added inline comments to D32447: Update profile during memory instrinsic optimization.
Sun, Apr 23
Sun, Apr 23
[PartialInine]: add triaging options
[PartialInlining] Add optimization remark support
Apr 22 2017
Apr 22 2017
davidxl updated the diff for D32387: [PartialInlining] Add Optimization Remark Support.
Use dash instead of underscore.
davidxl added a comment to D32387: [PartialInlining] Add Optimization Remark Support.
The way it is used, it does not require any analysis pass (on demand ).
davidxl updated the diff for D32387: [PartialInlining] Add Optimization Remark Support.
Rebase.
davidxl committed rL301090: [PartialInlining] Using existing hasAddressTaken interface to legality check/NFC.
[PartialInlining] Using existing hasAddressTaken interface to legality check/NFC
davidxl added inline comments to D32387: [PartialInlining] Add Optimization Remark Support.
Apr 21 2017
Apr 21 2017
davidxl committed rL301042: [PartialInliner] Partial inliner needs to check use kind before transformation.
[PartialInliner] Partial inliner needs to check use kind before transformation
Apr 20 2017
Apr 20 2017
davidxl accepted D32335: [PartialInliner] Fix crash when inlining functions with unreachable blocks.
The root cause of the problem is that the partial inliner split the newreturn block unconditionally -- even when there is no PHIs in them (creating unreachable block). I have included that fix in my patch, but this patch is fine too.
davidxl added inline comments to D32324: CodeGen: BlockPlacement: Increase tail duplication size for O3..
Use basicblock split block utility function
by the way, what is your PM setup for partial inlining?
davidxl added a comment to D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
Is it possible that some of the BBs on the chain may be very big and we don't want to partial inline them?
Apr 19 2017
Apr 19 2017
davidxl updated the diff for D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
Addressed review comments. Added more test including multi return case.
davidxl added inline comments to D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
davidxl added inline comments to D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
davidxl updated the diff for D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
Addressed review comments .
lgtm
Apr 18 2017
Apr 18 2017
davidxl added a comment to D30062: Estimate speedup due to inlining and use that to adjust threshold..
Given the performance data, I suggest drop the min speedup requirement to 0 at O3.
Apr 17 2017
Apr 17 2017
davidxl accepted D31952: Build SymbolMap in SampleProfileLoader to help matchin function names with suffix..
ok. The original erase is fine (given the intention is to discard cases with conflicts).
davidxl added inline comments to D31952: Build SymbolMap in SampleProfileLoader to help matchin function names with suffix..
davidxl added inline comments to D31952: Build SymbolMap in SampleProfileLoader to help matchin function names with suffix..