Page MenuHomePhabricator

davidxl (David Li)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2015, 9:48 AM (201 w, 18 h)

Recent Activity

Thu, Feb 14

davidxl added a reviewer for D58259: Fixed failure on Darwin due to r354064: vsk.
Thu, Feb 14, 3:29 PM · Restricted Project

Wed, Feb 13

davidxl accepted D58215: Refine ArgPromotion metadata handling.

lgtm

Wed, Feb 13, 10:41 PM · Restricted Project
davidxl added inline comments to D58215: Refine ArgPromotion metadata handling.
Wed, Feb 13, 4:53 PM · Restricted Project
davidxl accepted D55893: Set hidden attribute on lprofMergeValueProfData.

lgtm

Wed, Feb 13, 9:15 AM · Restricted Project

Fri, Feb 8

davidxl accepted D57463: Add a module pass for order file instrumentation.

LLVM part looks ok. Do you have plan to hook it up with Clang driver? It is also good to add support in llvm-profdata to support converting the raw mapping+dumping into linker order file format.

Fri, Feb 8, 9:13 AM
davidxl added inline comments to D54175: [PGO] context sensitive PGO.
Fri, Feb 8, 9:09 AM
davidxl added inline comments to D57463: Add a module pass for order file instrumentation.
Fri, Feb 8, 9:02 AM
davidxl accepted D57846: ArgumentPromotion should copy all metadata to new Function.

lgtm

Fri, Feb 8, 8:57 AM · Restricted Project

Thu, Feb 7

davidxl accepted D57929: [InstrProf] Implement static profdata registration.

lgtm.

Thu, Feb 7, 4:47 PM · Restricted Project, Restricted Project
davidxl added inline comments to D57929: [InstrProf] Implement static profdata registration.
Thu, Feb 7, 4:06 PM · Restricted Project, Restricted Project
davidxl added inline comments to D57929: [InstrProf] Implement static profdata registration.
Thu, Feb 7, 3:34 PM · Restricted Project, Restricted Project

Wed, Feb 6

davidxl accepted D57853: [InstrProf] Port test suite to Windows.

lgtm

Wed, Feb 6, 3:21 PM · Restricted Project, Restricted Project

Fri, Feb 1

davidxl accepted D57583: [PGO] Fix the type of the formated variable.

lgtm

Fri, Feb 1, 11:03 AM · Restricted Project
davidxl added inline comments to D57530: Order File Instrumentation: dump the data in compiler-rt.
Fri, Feb 1, 9:50 AM
davidxl added a comment to D54175: [PGO] context sensitive PGO.

Please also add a profile dumping/reading round trip test with isCS flag (there are existing similar test for llvm-profdata)

Fri, Feb 1, 9:24 AM

Thu, Jan 31

davidxl added inline comments to D57463: Add a module pass for order file instrumentation.
Thu, Jan 31, 4:26 PM

Wed, Jan 30

davidxl added a comment to D57463: Add a module pass for order file instrumentation.

There is a copy of InstrProfData.inc in compiler-rt, and that one needs to be kept in sync with the one in compiler side.

Wed, Jan 30, 10:23 AM
davidxl added a comment to D57463: Add a module pass for order file instrumentation.

Have not looked at it in details, but it looks like the support for the new PM is missing. Can that be added?

Wed, Jan 30, 9:58 AM

Sun, Jan 27

davidxl added a comment to D54815: [ThinLTO] Add summary entries for index-based WPD.

Thanks for the data. It is certainly a great improvement over the hybrid WPD.

Sun, Jan 27, 2:44 PM · Restricted Project

Thu, Jan 24

davidxl accepted D57067: [MBP] Don't move bottom block before header if it can't reduce taken branches.

Do you have any benchmarking numbers?

Thu, Jan 24, 9:57 AM

Wed, Jan 23

davidxl added inline comments to D57067: [MBP] Don't move bottom block before header if it can't reduce taken branches.
Wed, Jan 23, 11:25 AM

Tue, Jan 22

davidxl added inline comments to D57067: [MBP] Don't move bottom block before header if it can't reduce taken branches.
Tue, Jan 22, 10:10 PM

Jan 11 2019

davidxl added a comment to D54815: [ThinLTO] Add summary entries for index-based WPD.

Vtable funcs info should be in the initializers of vtable global variables right?

Jan 11 2019, 2:13 PM · Restricted Project
davidxl added a comment to D54815: [ThinLTO] Add summary entries for index-based WPD.

A very high level meta question: can thinLink phase read symbol table from each module? If yes, why duplicate the symtab information into summary?

Jan 11 2019, 1:49 PM · Restricted Project

Jan 8 2019

davidxl accepted D56464: Refactor synthetic profile count computation. NFC..

lgtm

Jan 8 2019, 6:37 PM
davidxl added inline comments to D56464: Refactor synthetic profile count computation. NFC..
Jan 8 2019, 4:47 PM

Jan 7 2019

davidxl accepted D56342: [llvm-profdata] add value-cutoff functionality to show command.

lgtm

Jan 7 2019, 3:18 PM
davidxl added inline comments to D56342: [llvm-profdata] add value-cutoff functionality to show command.
Jan 7 2019, 2:50 PM
davidxl added inline comments to D56342: [llvm-profdata] add value-cutoff functionality to show command.
Jan 7 2019, 11:58 AM
davidxl added a comment to D56342: [llvm-profdata] add value-cutoff functionality to show command.

why is list-below-cutoff option useful?

Jan 7 2019, 9:45 AM

Jan 4 2019

davidxl accepted D56327: [PGO] Use SourceFileName rather module name in PGOFuncName.

lgtm

Jan 4 2019, 2:34 PM
davidxl added inline comments to D56327: [PGO] Use SourceFileName rather module name in PGOFuncName.
Jan 4 2019, 2:18 PM
davidxl added inline comments to D56327: [PGO] Use SourceFileName rather module name in PGOFuncName.
Jan 4 2019, 12:29 PM
davidxl accepted D55967: [CodeExtractor] Do not extract unsafe lifetime markers.

lgtm

Jan 4 2019, 9:32 AM

Dec 21 2018

davidxl accepted D56019: [IR] Add Instruction::isLifetimeStartOrEnd, NFC.

lgtm

Dec 21 2018, 12:20 PM
davidxl added inline comments to D55967: [CodeExtractor] Do not extract unsafe lifetime markers.
Dec 21 2018, 11:28 AM
davidxl added inline comments to D55967: [CodeExtractor] Do not extract unsafe lifetime markers.
Dec 21 2018, 11:15 AM

Dec 20 2018

davidxl added inline comments to D55967: [CodeExtractor] Do not extract unsafe lifetime markers.
Dec 20 2018, 4:19 PM

Dec 19 2018

davidxl added a comment to D55893: Set hidden attribute on lprofMergeValueProfData.

Can you write a test case with a shared library that is instrumented and write a main program with dlopen to demonstrate the problem if the fix is not there?

Dec 19 2018, 11:33 AM · Restricted Project
davidxl added a comment to D55893: Set hidden attribute on lprofMergeValueProfData.

Test case?

Dec 19 2018, 11:21 AM · Restricted Project

Dec 13 2018

davidxl accepted D55643: [llvm] Address base discriminator overflow in X86DiscriminateMemOps.
Dec 13 2018, 11:41 AM

Dec 11 2018

davidxl added inline comments to D54507: [ThinLTO] Handle chains of aliases.
Dec 11 2018, 12:25 PM
davidxl added inline comments to D54507: [ThinLTO] Handle chains of aliases.
Dec 11 2018, 10:49 AM

Nov 30 2018

davidxl added inline comments to D54176: [PGO] clang part of change for context-sensitive PGO..
Nov 30 2018, 3:27 PM · Restricted Project
davidxl accepted D54607: [ThinLTO] Allow importing of functions with var args.

lgtm

Nov 30 2018, 2:51 PM
davidxl added a comment to D54176: [PGO] clang part of change for context-sensitive PGO..

Can you add a summary of this change, i.e., the driver option processing flow for csPGO.

Nov 30 2018, 9:37 AM · Restricted Project

Nov 27 2018

davidxl accepted D54748: [PartialInliner] Make PHIs free in cost computation..

There are more rooms to improve, but can be done independently.

Nov 27 2018, 8:40 AM

Nov 26 2018

davidxl accepted D54916: Add new passes to X86 pipeline tests.

lgtm

Nov 26 2018, 2:16 PM
davidxl accepted D54913: [ICP] Remove incompatible attributes at indirect-call promoted callsites..

lgtm

Nov 26 2018, 2:04 PM
davidxl added inline comments to D54913: [ICP] Remove incompatible attributes at indirect-call promoted callsites..
Nov 26 2018, 1:48 PM
davidxl added inline comments to D54748: [PartialInliner] Make PHIs free in cost computation..
Nov 26 2018, 10:08 AM

Nov 15 2018

davidxl added inline comments to D54564: [LTO] Load sample profile in LTO link step..
Nov 15 2018, 9:29 AM

Nov 12 2018

davidxl added inline comments to D54175: [PGO] context sensitive PGO.
Nov 12 2018, 3:53 PM
davidxl accepted D54052: Support for inserting profile-directed cache prefetches.

lgtm too.

Nov 12 2018, 10:58 AM

Nov 11 2018

davidxl accepted D54270: [ThinLTO] Update handling of vararg functions to match inliner.

lgtm

Nov 11 2018, 2:21 PM

Nov 7 2018

davidxl accepted D54212: [PGO] early exit if all count values are zero.

lgtm

Nov 7 2018, 1:02 PM
davidxl added a comment to D54212: [PGO] early exit if all count values are zero.

Can you add a simple test case making sure the func entry is properly annotated?

Nov 7 2018, 10:25 AM
davidxl added a comment to D54175: [PGO] context sensitive PGO.

Test cases are missing in the patch.

Nov 7 2018, 10:11 AM
davidxl added inline comments to D54175: [PGO] context sensitive PGO.
Nov 7 2018, 10:10 AM
davidxl added inline comments to D54212: [PGO] early exit if all count values are zero.
Nov 7 2018, 9:13 AM
davidxl added inline comments to D54175: [PGO] context sensitive PGO.
Nov 7 2018, 9:07 AM

Nov 6 2018

davidxl added inline comments to D54052: Support for inserting profile-directed cache prefetches.
Nov 6 2018, 12:01 PM
davidxl accepted D53345: [ThinLTO] Split NotEligibleToImport into legality and inlinability flags.

lgtm

Nov 6 2018, 11:38 AM

Nov 5 2018

davidxl added inline comments to D53345: [ThinLTO] Split NotEligibleToImport into legality and inlinability flags.
Nov 5 2018, 10:48 AM
davidxl added inline comments to D53345: [ThinLTO] Split NotEligibleToImport into legality and inlinability flags.
Nov 5 2018, 10:42 AM
davidxl added inline comments to D54052: Support for inserting profile-directed cache prefetches.
Nov 5 2018, 9:17 AM

Nov 2 2018

davidxl added a reviewer for D54052: Support for inserting profile-directed cache prefetches: craig.topper.
Nov 2 2018, 3:14 PM
davidxl added a reviewer for D54052: Support for inserting profile-directed cache prefetches: wmi.
Nov 2 2018, 3:06 PM
davidxl accepted D54040: [ProfileSummary] Add options to override hot and cold count thresholds..

lgtm

Nov 2 2018, 10:37 AM

Oct 18 2018

davidxl accepted D53378: Make Function::getInstructionCount const.

lgtm

Oct 18 2018, 11:04 AM

Oct 10 2018

davidxl added a comment to D51248: Support for remapping profile data, for sample-based profiling..

looks fine to me.

Oct 10 2018, 12:02 PM

Oct 9 2018

davidxl accepted D51247: Support for remapping profile data, for instrumentation-based profiling..

lgtm

Oct 9 2018, 9:45 PM
davidxl added a comment to D53044: [ELF] Don't warn on undefined symbols if UnresolvedPolicy::Ignore is used.

What is the intended use of such warnings?

Oct 9 2018, 3:17 PM
davidxl accepted D52509: [compiler-rt] Remove unused formal parameters from allocateOneNode. NFC..

lgtm

Oct 9 2018, 12:09 PM

Oct 3 2018

davidxl added inline comments to D52845: Update entry count for cold calls.
Oct 3 2018, 2:55 PM
davidxl added inline comments to D52845: Update entry count for cold calls.
Oct 3 2018, 2:13 PM
davidxl edited reviewers for D52845: Update entry count for cold calls, added: wmi; removed: davidxl.
Oct 3 2018, 2:04 PM

Sep 26 2018

davidxl added a comment to D46662: [X86] condition branches folding for three-way conditional codes.

What is the definition of branch density?

Sep 26 2018, 9:07 AM

Sep 17 2018

davidxl accepted D52056: [PGO][CHR] Add opt remarks..

lgtm

Sep 17 2018, 11:44 AM
davidxl added inline comments to D52056: [PGO][CHR] Add opt remarks..
Sep 17 2018, 9:11 AM

Sep 11 2018

davidxl added inline comments to D51247: Support for remapping profile data, for instrumentation-based profiling..
Sep 11 2018, 9:22 AM

Sep 7 2018

davidxl accepted D51246: Common infrastructure for reading a profile remapping file and building a mangling remapper from it..

lgtm

Sep 7 2018, 5:10 PM
davidxl accepted D51740: [PGO][CHR] Small cleanup..

lgtm

Sep 7 2018, 10:06 AM

Sep 6 2018

davidxl added inline comments to D51740: [PGO][CHR] Small cleanup..
Sep 6 2018, 3:28 PM
davidxl accepted D51643: [SampleFDO] Make sample profile loader unaware of compact format change.

lgtm

Sep 6 2018, 2:29 PM
davidxl added inline comments to D51643: [SampleFDO] Make sample profile loader unaware of compact format change.
Sep 6 2018, 10:55 AM
davidxl added inline comments to D51643: [SampleFDO] Make sample profile loader unaware of compact format change.
Sep 6 2018, 10:31 AM
davidxl added a comment to D51398: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely invertible.

The MD part LGTM

Sep 6 2018, 10:18 AM
davidxl added inline comments to D51643: [SampleFDO] Make sample profile loader unaware of compact format change.
Sep 6 2018, 10:05 AM

Sep 5 2018

davidxl accepted D50093: Introduce DebugCounter into PartiallyInlineLibCalls pass.

lgtm. I am not fixed on the naming either.

Sep 5 2018, 6:44 PM
davidxl added a comment to D50093: Introduce DebugCounter into PartiallyInlineLibCalls pass.

The counter name seems too long, how about dropping 'transform'.

Sep 5 2018, 2:09 PM
davidxl added inline comments to D51643: [SampleFDO] Make sample profile loader unaware of compact format change.
Sep 5 2018, 9:06 AM

Sep 4 2018

davidxl accepted D51658: Fix a memory leak after rL341386..

lgtm

Sep 4 2018, 2:18 PM
davidxl accepted D51647: Fix build failures after rL341386..

lgtm

Sep 4 2018, 11:13 AM
davidxl accepted D51249: Add flag to enable profile remapping to external interfaces to LLVM..

lgtm

Sep 4 2018, 10:25 AM

Sep 3 2018

davidxl added a comment to D51398: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely invertible.

The meta data update code looks fine to me.

Sep 3 2018, 11:04 PM

Aug 31 2018

davidxl accepted D51470: Add flag to llvm-profdata to allow symbols in profile data to be remapped, andadd a tool to generate symbol remapping files..

Wei may have more comments on the samplePGO remapping code.

Aug 31 2018, 8:43 AM

Aug 30 2018

davidxl added a comment to D51398: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely invertible.

thanks. In this case, checking if LHS/RHS 's order is swapped is probably needed.

Aug 30 2018, 1:47 PM
davidxl added a comment to D51398: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely invertible.

the meta data on select tracks the probability the predicate value is 'true'. As long as the predicate expression is not changed, the meta data does not change. Is the transformation doing something else?

Aug 30 2018, 12:00 PM
davidxl accepted D50591: [PGO] Control Height Reduction.

lgtm.

Aug 30 2018, 11:03 AM