User Details
User Details
- User Since
- Apr 13 2015, 9:48 AM (187 w, 1 d)
Mon, Nov 12
Mon, Nov 12
davidxl added inline comments to D54175: [PGO] context sensitive PGO.
lgtm too.
Sun, Nov 11
Sun, Nov 11
lgtm
Wed, Nov 7
Wed, Nov 7
davidxl added a comment to D54212: [PGO] early exit if all count values are zero.
Can you add a simple test case making sure the func entry is properly annotated?
davidxl added a comment to D54175: [PGO] context sensitive PGO.
Test cases are missing in the patch.
davidxl added inline comments to D54175: [PGO] context sensitive PGO.
davidxl added inline comments to D54212: [PGO] early exit if all count values are zero.
davidxl added inline comments to D54175: [PGO] context sensitive PGO.
Tue, Nov 6
Tue, Nov 6
davidxl added inline comments to D54052: Support for inserting profile-directed cache prefetches.
lgtm
Mon, Nov 5
Mon, Nov 5
davidxl added inline comments to D53345: [ThinLTO] Split NotEligibleToImport into legality and inlinability flags.
davidxl added inline comments to D53345: [ThinLTO] Split NotEligibleToImport into legality and inlinability flags.
davidxl added inline comments to D54052: Support for inserting profile-directed cache prefetches.
Fri, Nov 2
Fri, Nov 2
davidxl added a reviewer for D54052: Support for inserting profile-directed cache prefetches: craig.topper.
lgtm
Thu, Oct 18
Thu, Oct 18
Oct 10 2018
Oct 10 2018
davidxl added a comment to D51248: Support for remapping profile data, for sample-based profiling..
looks fine to me.
Oct 9 2018
Oct 9 2018
lgtm
davidxl added a comment to D53044: [ELF] Don't warn on undefined symbols if UnresolvedPolicy::Ignore is used.
What is the intended use of such warnings?
lgtm
Oct 3 2018
Oct 3 2018
davidxl added inline comments to D52845: Update entry count for cold calls.
davidxl added inline comments to D52845: Update entry count for cold calls.
davidxl edited reviewers for D52845: Update entry count for cold calls, added: wmi; removed: davidxl.
Sep 26 2018
Sep 26 2018
davidxl added a comment to D46662: [X86] condition branches folding for three-way conditional codes.
What is the definition of branch density?
Sep 17 2018
Sep 17 2018
davidxl added inline comments to D52056: [PGO][CHR] Add opt remarks..
Sep 11 2018
Sep 11 2018
davidxl added inline comments to D51247: Support for remapping profile data, for instrumentation-based profiling..
Sep 7 2018
Sep 7 2018
davidxl accepted D51246: Common infrastructure for reading a profile remapping file and building a mangling remapper from it..
lgtm
Sep 6 2018
Sep 6 2018
davidxl added inline comments to D51740: [PGO][CHR] Small cleanup..
lgtm
davidxl added inline comments to D51643: [SampleFDO] Make sample profile loader unaware of compact format change.
davidxl added inline comments to D51643: [SampleFDO] Make sample profile loader unaware of compact format change.
davidxl added a comment to D51398: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely invertible.
The MD part LGTM
davidxl added inline comments to D51643: [SampleFDO] Make sample profile loader unaware of compact format change.
Sep 5 2018
Sep 5 2018
lgtm. I am not fixed on the naming either.
davidxl added a comment to D50093: Introduce DebugCounter into PartiallyInlineLibCalls pass.
The counter name seems too long, how about dropping 'transform'.
davidxl added inline comments to D51643: [SampleFDO] Make sample profile loader unaware of compact format change.
Sep 4 2018
Sep 4 2018
lgtm
Sep 3 2018
Sep 3 2018
davidxl added a comment to D51398: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely invertible.
The meta data update code looks fine to me.
Aug 31 2018
Aug 31 2018
davidxl accepted D51470: Add flag to llvm-profdata to allow symbols in profile data to be remapped, andadd a tool to generate symbol remapping files..
Wei may have more comments on the samplePGO remapping code.
Aug 30 2018
Aug 30 2018
davidxl added a comment to D51398: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely invertible.
thanks. In this case, checking if LHS/RHS 's order is swapped is probably needed.
davidxl added a comment to D51398: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely invertible.
the meta data on select tracks the probability the predicate value is 'true'. As long as the predicate expression is not changed, the meta data does not change. Is the transformation doing something else?
davidxl added inline comments to D51248: Support for remapping profile data, for sample-based profiling..
davidxl retitled D51470: Add flag to llvm-profdata to allow symbols in profile data to be remapped, andadd a tool to generate symbol remapping files. from Add flag to llvm-profdata to allow symbols in profile data to be remapped, and
add a tool to generate symbol remapping files. to Add flag to llvm-profdata to allow symbols in profile data to be remapped, andadd a tool to generate symbol remapping files..
davidxl added a comment to D51470: Add flag to llvm-profdata to allow symbols in profile data to be remapped, andadd a tool to generate symbol remapping files..
Some test case for llvm-profdata new option is also needed (under test/tools/llvm-profdata)
davidxl added a comment to D51246: Common infrastructure for reading a profile remapping file and building a mangling remapper from it..
Perhaps add some test cases for the parser and reader?
Aug 29 2018
Aug 29 2018
davidxl added inline comments to D51398: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely invertible.
davidxl added inline comments to D50591: [PGO] Control Height Reduction.
Aug 27 2018
Aug 27 2018
davidxl added inline comments to D51247: Support for remapping profile data, for instrumentation-based profiling..
davidxl added inline comments to D51247: Support for remapping profile data, for instrumentation-based profiling..
davidxl added inline comments to D51247: Support for remapping profile data, for instrumentation-based profiling..
davidxl added inline comments to D50591: [PGO] Control Height Reduction.
davidxl added a reviewer for D51248: Support for remapping profile data, for sample-based profiling.: wmi.
davidxl added inline comments to D51248: Support for remapping profile data, for sample-based profiling..
Aug 26 2018
Aug 26 2018
davidxl added inline comments to D51249: Add flag to enable profile remapping to external interfaces to LLVM..
Aug 24 2018
Aug 24 2018
davidxl added a comment to D51240: Add a flag to remap manglings when reading profile data information..
Re "Why not":
davidxl added a comment to D51240: Add a flag to remap manglings when reading profile data information..
thanks for working on this.
[PGO] add target md5sum in warning message for icall
Aug 23 2018
Aug 23 2018
(-text option with show command is a 'mis-feature', -text should really be used together with the 'merge' command, but it is too late to remove it now).
davidxl added inline comments to D50591: [PGO] Control Height Reduction.
Aug 21 2018
Aug 21 2018
davidxl accepted D51037: [CodeExtractor] Use 'normal destination' BB as insert point to store invoke results..
lgtm
davidxl added inline comments to D51037: [CodeExtractor] Use 'normal destination' BB as insert point to store invoke results..
Aug 20 2018
Aug 20 2018
davidxl added inline comments to D50591: [PGO] Control Height Reduction.
Aug 17 2018
Aug 17 2018
lgtm
davidxl added inline comments to D50881: [ThinLTO] Add option for printing import failure reasons.
Aug 16 2018
Aug 16 2018
lgtm
davidxl added inline comments to D50591: [PGO] Control Height Reduction.
Aug 15 2018
Aug 15 2018
lgtm
Aug 14 2018
Aug 14 2018
davidxl added inline comments to D50591: [PGO] Control Height Reduction.
Aug 13 2018
Aug 13 2018
davidxl added a comment to D50591: [PGO] Control Height Reduction.
The request for test case description also applies to other new test cases.
Jul 26 2018
Jul 26 2018
lgtm
Jul 25 2018
Jul 25 2018
Add an option to specify the name of
Jul 23 2018
Jul 23 2018
lgtm
davidxl added a comment to D49447: Add an option to specify function name when view/print CFG.
ping.
davidxl added a comment to D49664: [profile] Fix finding the first and last directory separators on Windows..
Is it possible to add a test case?
lgtm
Jul 19 2018
Jul 19 2018
davidxl requested changes to D49460: Flush counters before forking to avoid counting the execution before fork twice.
Adding dependency on libdl is not desirable. I think you also need to change codegen (when coverage is on) to lower call to fork into call to the gcov version.
davidxl accepted D49460: Flush counters before forking to avoid counting the execution before fork twice.
lgtm
davidxl added inline comments to D49529: [profile] Add interface to get profile filename.
Jul 18 2018
Jul 18 2018
davidxl added inline comments to D49529: [profile] Add interface to get profile filename.
davidxl added a comment to D49460: Flush counters before forking to avoid counting the execution before fork twice.
One of the real issues is that func1, fork, and func2 are in the same BB and share the same profile counter. The BB ending with fork should be split so that func2 's block has its own counter.
davidxl added inline comments to D49460: Flush counters before forking to avoid counting the execution before fork twice.
Jul 17 2018
Jul 17 2018
Jul 13 2018
Jul 13 2018
lgtm
Jul 12 2018
Jul 12 2018
davidxl added a reviewer for D39339: [CallGraph] Refine call graph for indirect calls with !callees metadata: eraman.
davidxl added inline comments to D48670: [ThinLTO] Ensure we always select the same function copy to import.
Jul 3 2018
Jul 3 2018
LGTM ( watch out any potential breakages)
davidxl added inline comments to D48538: Make __gcov_flush flush counters for all shared libraries.