Page MenuHomePhabricator

davidxl (David Li)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2015, 9:48 AM (209 w, 4 d)

Recent Activity

Yesterday

davidxl accepted D60911: [PGO/SamplePGO][NFC] Move the function updateProfWeight from Instruction to CallInst.

This is not completely NFC as it modifies branch weight update behavior (though correctly), so please do more pgo testings to avoid surprises (e.g, some weird dependencies on old behavior).

Fri, Apr 19, 12:21 PM · Restricted Project
davidxl added a comment to D60903: [SampleFDO] Never set profile entry count to 0.

Looked at the Instruction::updateProfWeight() --- the part that update branch_weights seems bogus -- there is need need to scale branch weight at all.

Fri, Apr 19, 10:06 AM · Restricted Project
davidxl added a comment to D60903: [SampleFDO] Never set profile entry count to 0.

Can you clarify? IIRC, we never update the per-call site profile meta data with inline transformations.

Fri, Apr 19, 10:02 AM · Restricted Project
davidxl added a comment to D60903: [SampleFDO] Never set profile entry count to 0.

It is possible to for an entry with zero count -- as for instance in instrumentation PGO. Should it be fixed in place where the div by zero happens?

Fri, Apr 19, 9:21 AM · Restricted Project

Thu, Apr 11

davidxl accepted D60587: Add options for MaxLoadsPerMemcmp(OptSize)..

lgtm

Thu, Apr 11, 2:55 PM · Restricted Project

Wed, Apr 10

davidxl accepted D60154: [PGO] Better handling of profile hash mismatch.
Wed, Apr 10, 12:43 PM · Restricted Project
davidxl added inline comments to D60154: [PGO] Better handling of profile hash mismatch.
Wed, Apr 10, 10:32 AM · Restricted Project
davidxl added inline comments to D60154: [PGO] Better handling of profile hash mismatch.
Wed, Apr 10, 10:09 AM · Restricted Project

Fri, Mar 29

davidxl accepted D59967: [llvm][NFC] Factor out logic for getting incoming & back Loop edges.

lgtm

Fri, Mar 29, 9:36 AM · Restricted Project

Thu, Mar 28

davidxl added inline comments to D59967: [llvm][NFC] Factor out logic for getting incoming & back Loop edges.
Thu, Mar 28, 3:56 PM · Restricted Project

Thu, Mar 21

davidxl added a comment to D59514: [PGO] Profile guided code size optimization..

Look fine in general. Easwaran can help with review of pass pipeline changes

Thu, Mar 21, 9:13 AM · Restricted Project

Mar 19 2019

davidxl added a comment to D59514: [PGO] Profile guided code size optimization..

Missing unit tests for the feature.

Mar 19 2019, 4:05 PM · Restricted Project
davidxl added a reviewer for D59514: [PGO] Profile guided code size optimization.: eraman.
Mar 19 2019, 12:00 PM · Restricted Project

Mar 12 2019

davidxl added inline comments to D59225: [profile] Support for GCDA profiling in Fuchsia.
Mar 12 2019, 9:29 AM · Restricted Project, Restricted Project
davidxl added inline comments to D54815: [ThinLTO] Add summary entries for index-based WPD.
Mar 12 2019, 9:19 AM · Restricted Project

Mar 11 2019

davidxl added inline comments to D59153: [MBP] Make sure the exit BB is the most possible successor before rotating a loop.
Mar 11 2019, 8:14 PM · Restricted Project

Mar 7 2019

davidxl added inline comments to D58997: Order File Instrumentation: dump the data in compiler-rt (Make it work for Linux/Windows etc).
Mar 7 2019, 8:53 PM · Restricted Project, Restricted Project

Mar 6 2019

davidxl added inline comments to D58997: Order File Instrumentation: dump the data in compiler-rt (Make it work for Linux/Windows etc).
Mar 6 2019, 1:47 PM · Restricted Project, Restricted Project

Mar 5 2019

davidxl added inline comments to D58997: Order File Instrumentation: dump the data in compiler-rt (Make it work for Linux/Windows etc).
Mar 5 2019, 2:37 PM · Restricted Project, Restricted Project

Mar 4 2019

davidxl accepted D54176: [PGO] clang part of change for context-sensitive PGO..

lgtm

Mar 4 2019, 11:06 AM · Restricted Project
davidxl added inline comments to D54176: [PGO] clang part of change for context-sensitive PGO..
Mar 4 2019, 8:34 AM · Restricted Project

Mar 2 2019

davidxl accepted D57530: Order File Instrumentation: dump the data in compiler-rt.

lgtm

Mar 2 2019, 5:24 PM · Restricted Project, Restricted Project

Feb 28 2019

davidxl added inline comments to D57530: Order File Instrumentation: dump the data in compiler-rt.
Feb 28 2019, 4:12 PM · Restricted Project, Restricted Project
davidxl added inline comments to D57530: Order File Instrumentation: dump the data in compiler-rt.
Feb 28 2019, 10:11 AM · Restricted Project, Restricted Project
davidxl added a comment to D58787: [ProfileData] Sort ProfilingData by hash.

The secondary map 'ProfileData' is needed occasionally (to use cfg hash). doing sorting with std::map is not needed strictly speaking, but it has the nice property of having fixed order.

Feb 28 2019, 9:15 AM · Restricted Project
davidxl added a comment to D58787: [ProfileData] Sort ProfilingData by hash.

The number of functions with name conflicts (and requires) using secondary map is very few, so the performance should not be affected.

Feb 28 2019, 9:04 AM · Restricted Project
davidxl accepted D58787: [ProfileData] Sort ProfilingData by hash.

lgtm

Feb 28 2019, 8:51 AM · Restricted Project

Feb 27 2019

davidxl added a comment to D57530: Order File Instrumentation: dump the data in compiler-rt.

thanks. Can you add a few test cases in the patch?

Feb 27 2019, 9:36 AM · Restricted Project, Restricted Project

Feb 26 2019

davidxl added a comment to D54176: [PGO] clang part of change for context-sensitive PGO..

Please add changes to option documentation.

Feb 26 2019, 12:33 PM · Restricted Project
davidxl accepted D54177: PGO] change InstrProfData.inc for context sensitive PGO.

lgtm

Feb 26 2019, 12:32 PM

Feb 25 2019

davidxl accepted D54175: [PGO] context sensitive PGO.

lgtm

Feb 25 2019, 9:30 AM · Restricted Project

Feb 21 2019

davidxl accepted D58393: [MBP] Factor out function hasViableTopFallthrough and enhancement.

lgtm

Feb 21 2019, 3:35 PM · Restricted Project
davidxl added inline comments to D58393: [MBP] Factor out function hasViableTopFallthrough and enhancement.
Feb 21 2019, 2:32 PM · Restricted Project
davidxl added inline comments to D58393: [MBP] Factor out function hasViableTopFallthrough and enhancement.
Feb 21 2019, 1:22 PM · Restricted Project

Feb 14 2019

davidxl added a reviewer for D58259: Fixed failure on Darwin due to r354064: vsk.
Feb 14 2019, 3:29 PM · Restricted Project

Feb 13 2019

davidxl accepted D58215: Refine ArgPromotion metadata handling.

lgtm

Feb 13 2019, 10:41 PM · Restricted Project
davidxl added inline comments to D58215: Refine ArgPromotion metadata handling.
Feb 13 2019, 4:53 PM · Restricted Project
davidxl accepted D55893: Set hidden attribute on lprofMergeValueProfData.

lgtm

Feb 13 2019, 9:15 AM · Restricted Project

Feb 8 2019

davidxl accepted D57463: Add a module pass for order file instrumentation.

LLVM part looks ok. Do you have plan to hook it up with Clang driver? It is also good to add support in llvm-profdata to support converting the raw mapping+dumping into linker order file format.

Feb 8 2019, 9:13 AM · Restricted Project
davidxl added inline comments to D54175: [PGO] context sensitive PGO.
Feb 8 2019, 9:09 AM · Restricted Project
davidxl added inline comments to D57463: Add a module pass for order file instrumentation.
Feb 8 2019, 9:02 AM · Restricted Project
davidxl accepted D57846: ArgumentPromotion should copy all metadata to new Function.

lgtm

Feb 8 2019, 8:57 AM · Restricted Project

Feb 7 2019

davidxl accepted D57929: [InstrProf] Implement static profdata registration.

lgtm.

Feb 7 2019, 4:47 PM · Restricted Project, Restricted Project
davidxl added inline comments to D57929: [InstrProf] Implement static profdata registration.
Feb 7 2019, 4:06 PM · Restricted Project, Restricted Project
davidxl added inline comments to D57929: [InstrProf] Implement static profdata registration.
Feb 7 2019, 3:34 PM · Restricted Project, Restricted Project

Feb 6 2019

davidxl accepted D57853: [InstrProf] Port test suite to Windows.

lgtm

Feb 6 2019, 3:21 PM · Restricted Project, Restricted Project

Feb 1 2019

davidxl accepted D57583: [PGO] Fix the type of the formated variable.

lgtm

Feb 1 2019, 11:03 AM · Restricted Project
davidxl added inline comments to D57530: Order File Instrumentation: dump the data in compiler-rt.
Feb 1 2019, 9:50 AM · Restricted Project, Restricted Project
davidxl added a comment to D54175: [PGO] context sensitive PGO.

Please also add a profile dumping/reading round trip test with isCS flag (there are existing similar test for llvm-profdata)

Feb 1 2019, 9:24 AM · Restricted Project

Jan 31 2019

davidxl added inline comments to D57463: Add a module pass for order file instrumentation.
Jan 31 2019, 4:26 PM · Restricted Project

Jan 30 2019

davidxl added a comment to D57463: Add a module pass for order file instrumentation.

There is a copy of InstrProfData.inc in compiler-rt, and that one needs to be kept in sync with the one in compiler side.

Jan 30 2019, 10:23 AM · Restricted Project
davidxl added a comment to D57463: Add a module pass for order file instrumentation.

Have not looked at it in details, but it looks like the support for the new PM is missing. Can that be added?

Jan 30 2019, 9:58 AM · Restricted Project

Jan 27 2019

davidxl added a comment to D54815: [ThinLTO] Add summary entries for index-based WPD.

Thanks for the data. It is certainly a great improvement over the hybrid WPD.

Jan 27 2019, 2:44 PM · Restricted Project

Jan 24 2019

davidxl accepted D57067: [MBP] Don't move bottom block before header if it can't reduce taken branches.

Do you have any benchmarking numbers?

Jan 24 2019, 9:57 AM

Jan 23 2019

davidxl added inline comments to D57067: [MBP] Don't move bottom block before header if it can't reduce taken branches.
Jan 23 2019, 11:25 AM

Jan 22 2019

davidxl added inline comments to D57067: [MBP] Don't move bottom block before header if it can't reduce taken branches.
Jan 22 2019, 10:10 PM

Jan 11 2019

davidxl added a comment to D54815: [ThinLTO] Add summary entries for index-based WPD.

Vtable funcs info should be in the initializers of vtable global variables right?

Jan 11 2019, 2:13 PM · Restricted Project
davidxl added a comment to D54815: [ThinLTO] Add summary entries for index-based WPD.

A very high level meta question: can thinLink phase read symbol table from each module? If yes, why duplicate the symtab information into summary?

Jan 11 2019, 1:49 PM · Restricted Project

Jan 8 2019

davidxl accepted D56464: Refactor synthetic profile count computation. NFC..

lgtm

Jan 8 2019, 6:37 PM
davidxl added inline comments to D56464: Refactor synthetic profile count computation. NFC..
Jan 8 2019, 4:47 PM

Jan 7 2019

davidxl accepted D56342: [llvm-profdata] add value-cutoff functionality to show command.

lgtm

Jan 7 2019, 3:18 PM
davidxl added inline comments to D56342: [llvm-profdata] add value-cutoff functionality to show command.
Jan 7 2019, 2:50 PM
davidxl added inline comments to D56342: [llvm-profdata] add value-cutoff functionality to show command.
Jan 7 2019, 11:58 AM
davidxl added a comment to D56342: [llvm-profdata] add value-cutoff functionality to show command.

why is list-below-cutoff option useful?

Jan 7 2019, 9:45 AM

Jan 4 2019

davidxl accepted D56327: [PGO] Use SourceFileName rather module name in PGOFuncName.

lgtm

Jan 4 2019, 2:34 PM
davidxl added inline comments to D56327: [PGO] Use SourceFileName rather module name in PGOFuncName.
Jan 4 2019, 2:18 PM
davidxl added inline comments to D56327: [PGO] Use SourceFileName rather module name in PGOFuncName.
Jan 4 2019, 12:29 PM
davidxl accepted D55967: [CodeExtractor] Do not extract unsafe lifetime markers.

lgtm

Jan 4 2019, 9:32 AM

Dec 21 2018

davidxl accepted D56019: [IR] Add Instruction::isLifetimeStartOrEnd, NFC.

lgtm

Dec 21 2018, 12:20 PM
davidxl added inline comments to D55967: [CodeExtractor] Do not extract unsafe lifetime markers.
Dec 21 2018, 11:28 AM
davidxl added inline comments to D55967: [CodeExtractor] Do not extract unsafe lifetime markers.
Dec 21 2018, 11:15 AM

Dec 20 2018

davidxl added inline comments to D55967: [CodeExtractor] Do not extract unsafe lifetime markers.
Dec 20 2018, 4:19 PM

Dec 19 2018

davidxl added a comment to D55893: Set hidden attribute on lprofMergeValueProfData.

Can you write a test case with a shared library that is instrumented and write a main program with dlopen to demonstrate the problem if the fix is not there?

Dec 19 2018, 11:33 AM · Restricted Project
davidxl added a comment to D55893: Set hidden attribute on lprofMergeValueProfData.

Test case?

Dec 19 2018, 11:21 AM · Restricted Project

Dec 13 2018

davidxl accepted D55643: [llvm] Address base discriminator overflow in X86DiscriminateMemOps.
Dec 13 2018, 11:41 AM

Dec 11 2018

davidxl added inline comments to D54507: [ThinLTO] Handle chains of aliases.
Dec 11 2018, 12:25 PM
davidxl added inline comments to D54507: [ThinLTO] Handle chains of aliases.
Dec 11 2018, 10:49 AM

Nov 30 2018

davidxl added inline comments to D54176: [PGO] clang part of change for context-sensitive PGO..
Nov 30 2018, 3:27 PM · Restricted Project
davidxl accepted D54607: [ThinLTO] Allow importing of functions with var args.

lgtm

Nov 30 2018, 2:51 PM
davidxl added a comment to D54176: [PGO] clang part of change for context-sensitive PGO..

Can you add a summary of this change, i.e., the driver option processing flow for csPGO.

Nov 30 2018, 9:37 AM · Restricted Project

Nov 27 2018

davidxl accepted D54748: [PartialInliner] Make PHIs free in cost computation..

There are more rooms to improve, but can be done independently.

Nov 27 2018, 8:40 AM

Nov 26 2018

davidxl accepted D54916: Add new passes to X86 pipeline tests.

lgtm

Nov 26 2018, 2:16 PM
davidxl accepted D54913: [ICP] Remove incompatible attributes at indirect-call promoted callsites..

lgtm

Nov 26 2018, 2:04 PM
davidxl added inline comments to D54913: [ICP] Remove incompatible attributes at indirect-call promoted callsites..
Nov 26 2018, 1:48 PM
davidxl added inline comments to D54748: [PartialInliner] Make PHIs free in cost computation..
Nov 26 2018, 10:08 AM

Nov 15 2018

davidxl added inline comments to D54564: [LTO] Load sample profile in LTO link step..
Nov 15 2018, 9:29 AM

Nov 12 2018

davidxl added inline comments to D54175: [PGO] context sensitive PGO.
Nov 12 2018, 3:53 PM · Restricted Project
davidxl accepted D54052: Support for inserting profile-directed cache prefetches.

lgtm too.

Nov 12 2018, 10:58 AM

Nov 11 2018

davidxl accepted D54270: [ThinLTO] Update handling of vararg functions to match inliner.

lgtm

Nov 11 2018, 2:21 PM

Nov 7 2018

davidxl accepted D54212: [PGO] early exit if all count values are zero.

lgtm

Nov 7 2018, 1:02 PM
davidxl added a comment to D54212: [PGO] early exit if all count values are zero.

Can you add a simple test case making sure the func entry is properly annotated?

Nov 7 2018, 10:25 AM
davidxl added a comment to D54175: [PGO] context sensitive PGO.

Test cases are missing in the patch.

Nov 7 2018, 10:11 AM · Restricted Project
davidxl added inline comments to D54175: [PGO] context sensitive PGO.
Nov 7 2018, 10:10 AM · Restricted Project
davidxl added inline comments to D54212: [PGO] early exit if all count values are zero.
Nov 7 2018, 9:13 AM
davidxl added inline comments to D54175: [PGO] context sensitive PGO.
Nov 7 2018, 9:07 AM · Restricted Project

Nov 6 2018

davidxl added inline comments to D54052: Support for inserting profile-directed cache prefetches.
Nov 6 2018, 12:01 PM
davidxl accepted D53345: [ThinLTO] Split NotEligibleToImport into legality and inlinability flags.

lgtm

Nov 6 2018, 11:38 AM

Nov 5 2018

davidxl added inline comments to D53345: [ThinLTO] Split NotEligibleToImport into legality and inlinability flags.
Nov 5 2018, 10:48 AM
davidxl added inline comments to D53345: [ThinLTO] Split NotEligibleToImport into legality and inlinability flags.
Nov 5 2018, 10:42 AM
davidxl added inline comments to D54052: Support for inserting profile-directed cache prefetches.
Nov 5 2018, 9:17 AM