davidxl (David Li)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2015, 9:48 AM (187 w, 1 d)

Recent Activity

Mon, Nov 12

davidxl added inline comments to D54175: [PGO] context sensitive PGO.
Mon, Nov 12, 3:53 PM
davidxl accepted D54052: Support for inserting profile-directed cache prefetches.

lgtm too.

Mon, Nov 12, 10:58 AM

Sun, Nov 11

davidxl accepted D54270: [ThinLTO] Update handling of vararg functions to match inliner.

lgtm

Sun, Nov 11, 2:21 PM

Wed, Nov 7

davidxl accepted D54212: [PGO] early exit if all count values are zero.

lgtm

Wed, Nov 7, 1:02 PM
davidxl added a comment to D54212: [PGO] early exit if all count values are zero.

Can you add a simple test case making sure the func entry is properly annotated?

Wed, Nov 7, 10:25 AM
davidxl added a comment to D54175: [PGO] context sensitive PGO.

Test cases are missing in the patch.

Wed, Nov 7, 10:11 AM
davidxl added inline comments to D54175: [PGO] context sensitive PGO.
Wed, Nov 7, 10:10 AM
davidxl added inline comments to D54212: [PGO] early exit if all count values are zero.
Wed, Nov 7, 9:13 AM
davidxl added inline comments to D54175: [PGO] context sensitive PGO.
Wed, Nov 7, 9:07 AM

Tue, Nov 6

davidxl added inline comments to D54052: Support for inserting profile-directed cache prefetches.
Tue, Nov 6, 12:01 PM
davidxl accepted D53345: [ThinLTO] Split NotEligibleToImport into legality and inlinability flags.

lgtm

Tue, Nov 6, 11:38 AM

Mon, Nov 5

davidxl added inline comments to D53345: [ThinLTO] Split NotEligibleToImport into legality and inlinability flags.
Mon, Nov 5, 10:48 AM
davidxl added inline comments to D53345: [ThinLTO] Split NotEligibleToImport into legality and inlinability flags.
Mon, Nov 5, 10:42 AM
davidxl added inline comments to D54052: Support for inserting profile-directed cache prefetches.
Mon, Nov 5, 9:17 AM

Fri, Nov 2

davidxl added a reviewer for D54052: Support for inserting profile-directed cache prefetches: craig.topper.
Fri, Nov 2, 3:14 PM
davidxl added a reviewer for D54052: Support for inserting profile-directed cache prefetches: wmi.
Fri, Nov 2, 3:06 PM
davidxl accepted D54040: [ProfileSummary] Add options to override hot and cold count thresholds..

lgtm

Fri, Nov 2, 10:37 AM

Thu, Oct 18

davidxl accepted D53378: Make Function::getInstructionCount const.

lgtm

Thu, Oct 18, 11:04 AM

Oct 10 2018

davidxl added a comment to D51248: Support for remapping profile data, for sample-based profiling..

looks fine to me.

Oct 10 2018, 12:02 PM

Oct 9 2018

davidxl accepted D51247: Support for remapping profile data, for instrumentation-based profiling..

lgtm

Oct 9 2018, 9:45 PM
davidxl added a comment to D53044: [ELF] Don't warn on undefined symbols if UnresolvedPolicy::Ignore is used.

What is the intended use of such warnings?

Oct 9 2018, 3:17 PM
davidxl accepted D52509: [compiler-rt] Remove unused formal parameters from allocateOneNode. NFC..

lgtm

Oct 9 2018, 12:09 PM

Oct 3 2018

davidxl added inline comments to D52845: Update entry count for cold calls.
Oct 3 2018, 2:55 PM
davidxl added inline comments to D52845: Update entry count for cold calls.
Oct 3 2018, 2:13 PM
davidxl edited reviewers for D52845: Update entry count for cold calls, added: wmi; removed: davidxl.
Oct 3 2018, 2:04 PM

Sep 26 2018

davidxl added a comment to D46662: [X86] condition branches folding for three-way conditional codes.

What is the definition of branch density?

Sep 26 2018, 9:07 AM

Sep 17 2018

davidxl accepted D52056: [PGO][CHR] Add opt remarks..

lgtm

Sep 17 2018, 11:44 AM
davidxl added inline comments to D52056: [PGO][CHR] Add opt remarks..
Sep 17 2018, 9:11 AM

Sep 11 2018

davidxl added inline comments to D51247: Support for remapping profile data, for instrumentation-based profiling..
Sep 11 2018, 9:22 AM

Sep 7 2018

davidxl accepted D51246: Common infrastructure for reading a profile remapping file and building a mangling remapper from it..

lgtm

Sep 7 2018, 5:10 PM
davidxl accepted D51740: [PGO][CHR] Small cleanup..

lgtm

Sep 7 2018, 10:06 AM

Sep 6 2018

davidxl added inline comments to D51740: [PGO][CHR] Small cleanup..
Sep 6 2018, 3:28 PM
davidxl accepted D51643: [SampleFDO] Make sample profile loader unaware of compact format change.

lgtm

Sep 6 2018, 2:29 PM
davidxl added inline comments to D51643: [SampleFDO] Make sample profile loader unaware of compact format change.
Sep 6 2018, 10:55 AM
davidxl added inline comments to D51643: [SampleFDO] Make sample profile loader unaware of compact format change.
Sep 6 2018, 10:31 AM
davidxl added a comment to D51398: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely invertible.

The MD part LGTM

Sep 6 2018, 10:18 AM
davidxl added inline comments to D51643: [SampleFDO] Make sample profile loader unaware of compact format change.
Sep 6 2018, 10:05 AM

Sep 5 2018

davidxl accepted D50093: Introduce DebugCounter into PartiallyInlineLibCalls pass.

lgtm. I am not fixed on the naming either.

Sep 5 2018, 6:44 PM
davidxl added a comment to D50093: Introduce DebugCounter into PartiallyInlineLibCalls pass.

The counter name seems too long, how about dropping 'transform'.

Sep 5 2018, 2:09 PM
davidxl added inline comments to D51643: [SampleFDO] Make sample profile loader unaware of compact format change.
Sep 5 2018, 9:06 AM

Sep 4 2018

davidxl accepted D51658: Fix a memory leak after rL341386..

lgtm

Sep 4 2018, 2:18 PM
davidxl accepted D51647: Fix build failures after rL341386..

lgtm

Sep 4 2018, 11:13 AM
davidxl accepted D51249: Add flag to enable profile remapping to external interfaces to LLVM..

lgtm

Sep 4 2018, 10:25 AM

Sep 3 2018

davidxl added a comment to D51398: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely invertible.

The meta data update code looks fine to me.

Sep 3 2018, 11:04 PM

Aug 31 2018

davidxl accepted D51470: Add flag to llvm-profdata to allow symbols in profile data to be remapped, andadd a tool to generate symbol remapping files..

Wei may have more comments on the samplePGO remapping code.

Aug 31 2018, 8:43 AM

Aug 30 2018

davidxl added a comment to D51398: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely invertible.

thanks. In this case, checking if LHS/RHS 's order is swapped is probably needed.

Aug 30 2018, 1:47 PM
davidxl added a comment to D51398: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely invertible.

the meta data on select tracks the probability the predicate value is 'true'. As long as the predicate expression is not changed, the meta data does not change. Is the transformation doing something else?

Aug 30 2018, 12:00 PM
davidxl accepted D50591: [PGO] Control Height Reduction.

lgtm.

Aug 30 2018, 11:03 AM
davidxl added inline comments to D51248: Support for remapping profile data, for sample-based profiling..
Aug 30 2018, 9:44 AM
davidxl retitled D51470: Add flag to llvm-profdata to allow symbols in profile data to be remapped, andadd a tool to generate symbol remapping files. from Add flag to llvm-profdata to allow symbols in profile data to be remapped, and add a tool to generate symbol remapping files. to Add flag to llvm-profdata to allow symbols in profile data to be remapped, andadd a tool to generate symbol remapping files..
Aug 30 2018, 9:30 AM
davidxl added a comment to D51470: Add flag to llvm-profdata to allow symbols in profile data to be remapped, andadd a tool to generate symbol remapping files..

Some test case for llvm-profdata new option is also needed (under test/tools/llvm-profdata)

Aug 30 2018, 9:30 AM
davidxl added a comment to D51246: Common infrastructure for reading a profile remapping file and building a mangling remapper from it..

Perhaps add some test cases for the parser and reader?

Aug 30 2018, 9:22 AM

Aug 29 2018

davidxl added inline comments to D51398: [InstCombine] Fold (min/max ~X, Y) -> ~(max/min X, ~Y) when Y is freely invertible.
Aug 29 2018, 3:22 PM
davidxl added inline comments to D50591: [PGO] Control Height Reduction.
Aug 29 2018, 8:39 AM

Aug 27 2018

davidxl added inline comments to D51247: Support for remapping profile data, for instrumentation-based profiling..
Aug 27 2018, 6:48 PM
davidxl added inline comments to D51247: Support for remapping profile data, for instrumentation-based profiling..
Aug 27 2018, 1:22 PM
davidxl added inline comments to D51247: Support for remapping profile data, for instrumentation-based profiling..
Aug 27 2018, 11:24 AM
davidxl added inline comments to D50591: [PGO] Control Height Reduction.
Aug 27 2018, 10:00 AM
davidxl added a reviewer for D51248: Support for remapping profile data, for sample-based profiling.: wmi.
Aug 27 2018, 9:08 AM
davidxl added inline comments to D51248: Support for remapping profile data, for sample-based profiling..
Aug 27 2018, 9:08 AM

Aug 26 2018

davidxl added inline comments to D51246: Common infrastructure for reading a profile remapping file and building a mangling remapper from it..
Aug 26 2018, 9:58 PM
davidxl added inline comments to D51249: Add flag to enable profile remapping to external interfaces to LLVM..
Aug 26 2018, 8:39 PM

Aug 24 2018

davidxl added a comment to D51240: Add a flag to remap manglings when reading profile data information..

Re "Why not":

Aug 24 2018, 8:16 PM
davidxl added a comment to D51240: Add a flag to remap manglings when reading profile data information..

thanks for working on this.

Aug 24 2018, 5:07 PM
davidxl committed rL340657: [PGO] add target md5sum in warning message for icall.
[PGO] add target md5sum in warning message for icall
Aug 24 2018, 2:39 PM
davidxl closed D51193: [PGO] Print target md5sum in missed optimization message.
Aug 24 2018, 2:39 PM

Aug 23 2018

davidxl created D51193: [PGO] Print target md5sum in missed optimization message.
Aug 23 2018, 3:46 PM
davidxl accepted D51188: make llvm-profdata show -text work as advertised in the documentation.

(-text option with show command is a 'mis-feature', -text should really be used together with the 'merge' command, but it is too late to remove it now).

Aug 23 2018, 3:30 PM
davidxl added inline comments to D50591: [PGO] Control Height Reduction.
Aug 23 2018, 11:42 AM

Aug 21 2018

davidxl accepted D51037: [CodeExtractor] Use 'normal destination' BB as insert point to store invoke results..

lgtm

Aug 21 2018, 9:43 AM
davidxl added inline comments to D51037: [CodeExtractor] Use 'normal destination' BB as insert point to store invoke results..
Aug 21 2018, 9:37 AM

Aug 20 2018

davidxl added inline comments to D50591: [PGO] Control Height Reduction.
Aug 20 2018, 10:12 AM

Aug 17 2018

davidxl accepted D50881: [ThinLTO] Add option for printing import failure reasons.

lgtm

Aug 17 2018, 9:20 AM
davidxl added inline comments to D50881: [ThinLTO] Add option for printing import failure reasons.
Aug 17 2018, 8:47 AM

Aug 16 2018

davidxl accepted D50867: [InstrProf] Use atomic profile counter updates for TSan.

lgtm

Aug 16 2018, 3:22 PM
davidxl added inline comments to D50591: [PGO] Control Height Reduction.
Aug 16 2018, 10:26 AM

Aug 15 2018

davidxl accepted D50822: [BFI] Use rounding while computing profile counts..

lgtm

Aug 15 2018, 5:13 PM

Aug 14 2018

davidxl added inline comments to D50591: [PGO] Control Height Reduction.
Aug 14 2018, 12:25 PM

Aug 13 2018

davidxl added a comment to D50591: [PGO] Control Height Reduction.

The request for test case description also applies to other new test cases.

Aug 13 2018, 10:13 AM

Jul 26 2018

davidxl accepted D49882: [InstrProf] Use comdats on COFF for available_externally functions.

lgtm

Jul 26 2018, 3:53 PM

Jul 25 2018

davidxl committed rL337940: Add an option to specify the name of.
Add an option to specify the name of
Jul 25 2018, 10:22 AM
davidxl closed D49447: Add an option to specify function name when view/print CFG.
Jul 25 2018, 10:22 AM

Jul 23 2018

davidxl accepted D49664: [profile] Fix finding the first and last directory separators on Windows..

lgtm

Jul 23 2018, 10:24 PM
davidxl added a comment to D49447: Add an option to specify function name when view/print CFG.

ping.

Jul 23 2018, 2:05 PM
davidxl added a comment to D49664: [profile] Fix finding the first and last directory separators on Windows..

Is it possible to add a test case?

Jul 23 2018, 8:22 AM
davidxl accepted D49666: [profile] Fix a possible memory leak in parseFilenamePattern()..

lgtm

Jul 23 2018, 8:19 AM

Jul 19 2018

davidxl requested changes to D49460: Flush counters before forking to avoid counting the execution before fork twice.

Adding dependency on libdl is not desirable. I think you also need to change codegen (when coverage is on) to lower call to fork into call to the gcov version.

Jul 19 2018, 3:17 PM
davidxl accepted D49529: [profile] Add interface to get profile filename.

lgtm

Jul 19 2018, 10:19 AM
davidxl accepted D49460: Flush counters before forking to avoid counting the execution before fork twice.

lgtm

Jul 19 2018, 10:16 AM
davidxl added inline comments to D49529: [profile] Add interface to get profile filename.
Jul 19 2018, 9:26 AM

Jul 18 2018

davidxl added inline comments to D49529: [profile] Add interface to get profile filename.
Jul 18 2018, 11:55 PM
davidxl added a comment to D49460: Flush counters before forking to avoid counting the execution before fork twice.

One of the real issues is that func1, fork, and func2 are in the same BB and share the same profile counter. The BB ending with fork should be split so that func2 's block has its own counter.

Jul 18 2018, 11:58 AM
davidxl added inline comments to D49460: Flush counters before forking to avoid counting the execution before fork twice.
Jul 18 2018, 11:52 AM

Jul 17 2018

davidxl created D49447: Add an option to specify function name when view/print CFG.
Jul 17 2018, 1:17 PM

Jul 13 2018

davidxl accepted D48670: [ThinLTO] Ensure we always select the same function copy to import.

lgtm

Jul 13 2018, 1:54 PM
davidxl added inline comments to D48307: [Inliner] Try to inline if some blocks in the callee have address taken, but not used in a meaningful..
Jul 13 2018, 11:43 AM

Jul 12 2018

davidxl added a reviewer for D39339: [CallGraph] Refine call graph for indirect calls with !callees metadata: eraman.
Jul 12 2018, 3:09 PM
davidxl added inline comments to D48670: [ThinLTO] Ensure we always select the same function copy to import.
Jul 12 2018, 11:46 AM

Jul 3 2018

davidxl accepted D48538: Make __gcov_flush flush counters for all shared libraries.

LGTM ( watch out any potential breakages)

Jul 3 2018, 8:54 PM
davidxl added inline comments to D48538: Make __gcov_flush flush counters for all shared libraries.
Jul 3 2018, 10:14 AM