davidxl (David Li)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2015, 9:48 AM (110 w, 1 d)

Recent Activity

Yesterday

davidxl committed rL303567: [PartialInlining] Add internal options to enable partial inlining in pass….
[PartialInlining] Add internal options to enable partial inlining in pass…
Mon, May 22, 9:42 AM
davidxl closed D33382: [PartialInlining] introduce an internal option to add partial inlining pass in the pipeline (off by default for now) by committing rL303567: [PartialInlining] Add internal options to enable partial inlining in pass….
Mon, May 22, 9:42 AM
davidxl updated the diff for D33382: [PartialInlining] introduce an internal option to add partial inlining pass in the pipeline (off by default for now).

added internal option for new PM as well.

Mon, May 22, 9:20 AM

Sat, May 20

davidxl created D33382: [PartialInlining] introduce an internal option to add partial inlining pass in the pipeline (off by default for now).
Sat, May 20, 9:30 PM

Fri, May 19

davidxl updated the diff for D33164: [Profile[ Enhance expect lowering to handle correlated branches.

Addressed review comments.

Fri, May 19, 9:44 PM
davidxl added inline comments to D33164: [Profile[ Enhance expect lowering to handle correlated branches.
Fri, May 19, 9:43 PM
davidxl added a comment to D33164: [Profile[ Enhance expect lowering to handle correlated branches.

Any more comments?

Fri, May 19, 9:43 AM

Tue, May 16

davidxl updated the diff for D33164: [Profile[ Enhance expect lowering to handle correlated branches.

Address review feedback.

Tue, May 16, 8:29 PM
davidxl added inline comments to D33164: [Profile[ Enhance expect lowering to handle correlated branches.
Tue, May 16, 8:28 PM
davidxl updated the diff for D33164: [Profile[ Enhance expect lowering to handle correlated branches.

Address Chandler's feedbacks.

Tue, May 16, 4:00 PM
davidxl added inline comments to D33164: [Profile[ Enhance expect lowering to handle correlated branches.
Tue, May 16, 3:59 PM
davidxl updated the diff for D33164: [Profile[ Enhance expect lowering to handle correlated branches.

Address Wei's review feebback.

Tue, May 16, 2:43 PM
davidxl added inline comments to D33164: [Profile[ Enhance expect lowering to handle correlated branches.
Tue, May 16, 2:43 PM
davidxl accepted D33156: Add hasProfileSummary and has{Sample|Instrumentation}Profile methods..

lgtm

Tue, May 16, 1:12 PM
davidxl added inline comments to D30633: [BPI] Reduce the probability of unreachable edge to minimal value greater than 0.
Tue, May 16, 12:45 PM
davidxl added a comment to D30633: [BPI] Reduce the probability of unreachable edge to minimal value greater than 0.

That is not my question :)

Tue, May 16, 9:34 AM
davidxl added a comment to D30633: [BPI] Reduce the probability of unreachable edge to minimal value greater than 0.

It is known that BFI can not handle zero weight and it will add 1 to zero weight when it sees it.

Tue, May 16, 8:55 AM

Mon, May 15

davidxl committed rL303126: Fix memory leak.
Fix memory leak
Mon, May 15, 3:57 PM

Sat, May 13

davidxl committed rL303000: Renable test that was disabled due to cost analysis.
Renable test that was disabled due to cost analysis
Sat, May 13, 8:11 PM
davidxl committed rL302999: Fix test failure on windows -- do not return deleted func.
Fix test failure on windows -- do not return deleted func
Sat, May 13, 8:07 PM
davidxl created D33164: [Profile[ Enhance expect lowering to handle correlated branches.
Sat, May 13, 11:59 AM

Fri, May 12

davidxl committed rL302967: [PartialInlining] Profile based cost analysis.
[PartialInlining] Profile based cost analysis
Fri, May 12, 4:55 PM
davidxl closed D32783: [PartialInlining] Add frequency based cost analysis by committing rL302967: [PartialInlining] Profile based cost analysis.
Fri, May 12, 4:55 PM
davidxl accepted D32324: CodeGen: BlockPlacement: Increase tail duplication size for O3..

lgtm

Fri, May 12, 4:17 PM
davidxl updated the diff for D32783: [PartialInlining] Add frequency based cost analysis.

Address review feedbacks.

Fri, May 12, 1:37 PM
davidxl added inline comments to D32783: [PartialInlining] Add frequency based cost analysis.
Fri, May 12, 1:36 PM
davidxl updated the diff for D32783: [PartialInlining] Add frequency based cost analysis.

Remove { }

Fri, May 12, 9:36 AM
davidxl added inline comments to D32324: CodeGen: BlockPlacement: Increase tail duplication size for O3..
Fri, May 12, 9:32 AM

Wed, May 10

davidxl updated the diff for D32783: [PartialInlining] Add frequency based cost analysis.

Further tuned cost/benefit computation with SPEC 2k/06 tuning. Get speedups in a few benchmarks and fixed the regression in perlbmk (many cases with early return branch which is never taken).

Wed, May 10, 9:18 PM
davidxl accepted D32688: [Coverage] Comdat section name should be same as the variable name in COFF format.

lgtm

Wed, May 10, 7:22 PM

Fri, May 5

davidxl updated the diff for D32783: [PartialInlining] Add frequency based cost analysis.

Address feedback -- revert change in CodeExtractor.h and .cc file

Fri, May 5, 5:16 PM

Thu, May 4

davidxl added inline comments to D32783: [PartialInlining] Add frequency based cost analysis.
Thu, May 4, 10:08 PM
davidxl updated the diff for D32783: [PartialInlining] Add frequency based cost analysis.
  1. Addressed review feedbacks
  2. More refactorings and naming cleanups (for consistency)
  3. Added handling of function entry count update and a new test case for it.
Thu, May 4, 10:06 PM
davidxl added inline comments to D32783: [PartialInlining] Add frequency based cost analysis.
Thu, May 4, 12:25 PM
davidxl updated the diff for D32783: [PartialInlining] Add frequency based cost analysis.

Addressed review feedbacks by eraman

Thu, May 4, 12:22 PM

Wed, May 3

davidxl added inline comments to D28593: Update loop branch_weight metadata after loop rotation..
Wed, May 3, 12:22 PM
davidxl added inline comments to D32688: [Coverage] Comdat section name should be same as the variable name in COFF format.
Wed, May 3, 9:25 AM
davidxl added inline comments to D32324: CodeGen: BlockPlacement: Increase tail duplication size for O3..
Wed, May 3, 9:12 AM

Tue, May 2

davidxl updated the diff for D32783: [PartialInlining] Add frequency based cost analysis.

Update test case -- added a cold region test.

Tue, May 2, 11:08 PM
davidxl created D32783: [PartialInlining] Add frequency based cost analysis.
Tue, May 2, 10:47 PM
davidxl committed rL301959: [PartialInlining] Add more early filtering.
[PartialInlining] Add more early filtering
Tue, May 2, 11:56 AM

Mon, May 1

davidxl committed rL301899: Refactor callsite cost computation into a helper function /NFC.
Refactor callsite cost computation into a helper function /NFC
Mon, May 1, 10:51 PM
davidxl committed rL301894: [PartialInlining] Hook up inline cost analysis.
[PartialInlining] Hook up inline cost analysis
Mon, May 1, 7:57 PM
davidxl closed D32666: [PartialInlining] Add support in partial inliner to use cost analysis in inliner by committing rL301894: [PartialInlining] Hook up inline cost analysis.
Mon, May 1, 7:57 PM
davidxl added a comment to D32688: [Coverage] Comdat section name should be same as the variable name in COFF format.

This patch basically splits the comdat section for data, counters and value vars with COFF.

Mon, May 1, 11:29 AM

Sun, Apr 30

davidxl updated the diff for D32666: [PartialInlining] Add support in partial inliner to use cost analysis in inliner .

Address review feedback -- add one more test case.

Sun, Apr 30, 5:04 PM

Fri, Apr 28

davidxl created D32666: [PartialInlining] Add support in partial inliner to use cost analysis in inliner .
Fri, Apr 28, 4:59 PM
davidxl added a comment to D32563: Add LiveRangeShrink pass to shrink live range within BB..

A couple of comments:

Fri, Apr 28, 10:23 AM
davidxl accepted D32624: Memory intrinsic value profile optimization: Avoid divide by 0.

lgtm

Fri, Apr 28, 7:32 AM

Thu, Apr 27

davidxl added inline comments to D32624: Memory intrinsic value profile optimization: Avoid divide by 0.
Thu, Apr 27, 6:59 PM
davidxl added inline comments to D32624: Memory intrinsic value profile optimization: Avoid divide by 0.
Thu, Apr 27, 5:13 PM
davidxl added inline comments to D32563: Add LiveRangeShrink pass to shrink live range within BB..
Thu, Apr 27, 3:38 PM
davidxl accepted D32607: Memory intrinsic value profile optimization: Improve debug output (NFC).

lgtm

Thu, Apr 27, 11:34 AM
davidxl committed rL301561: [PartialInlining]: Improve partial inlining to handle complex conditions.
[PartialInlining]: Improve partial inlining to handle complex conditions
Thu, Apr 27, 9:47 AM
davidxl closed D32249: [PartialInl] Enhance partial inliner to handle more complex conditions by committing rL301561: [PartialInlining]: Improve partial inlining to handle complex conditions.
Thu, Apr 27, 9:47 AM

Wed, Apr 26

davidxl updated the diff for D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.

Addressed review feedback by eraman.

Wed, Apr 26, 8:43 PM
davidxl added inline comments to D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
Wed, Apr 26, 8:42 PM
davidxl updated the diff for D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.

Address review comments.

Wed, Apr 26, 2:34 PM
davidxl added inline comments to D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
Wed, Apr 26, 2:33 PM
davidxl updated the diff for D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.

Address Wei's review feedback. Also fixed a bug found in clang self build test.

Wed, Apr 26, 1:28 PM
davidxl added inline comments to D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
Wed, Apr 26, 1:20 PM

Tue, Apr 25

davidxl updated the diff for D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.

addressed review comments.

Tue, Apr 25, 9:57 PM
davidxl added inline comments to D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
Tue, Apr 25, 9:56 PM
davidxl updated the diff for D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.

Address review feedback. The new version now can handle more general conditions (see test cases).

Tue, Apr 25, 9:10 PM

Mon, Apr 24

davidxl committed rL301291: [CodeExtractor]: Fixup use refs of the old phi..
[CodeExtractor]: Fixup use refs of the old phi.
Mon, Apr 24, 10:04 PM
davidxl closed D32468: [CodeExtractor]: Fix an extractor bug of missing replacing use of old phi with the new one by committing rL301291: [CodeExtractor]: Fixup use refs of the old phi..
Mon, Apr 24, 10:04 PM
davidxl created D32468: [CodeExtractor]: Fix an extractor bug of missing replacing use of old phi with the new one.
Mon, Apr 24, 8:36 PM
davidxl accepted D32465: [PM] Run IndirectCallPromotion only when PGO is enabled.

lgtm

Mon, Apr 24, 8:21 PM
davidxl accepted D32447: Update profile during memory instrinsic optimization.

lgtm

Mon, Apr 24, 11:57 AM
davidxl added inline comments to D32447: Update profile during memory instrinsic optimization.
Mon, Apr 24, 11:51 AM

Sun, Apr 23

davidxl committed rL301148: [PartialInine]: add triaging options.
[PartialInine]: add triaging options
Sun, Apr 23, 4:52 PM
davidxl committed rL301143: [PartialInlining] Add optimization remark support.
[PartialInlining] Add optimization remark support
Sun, Apr 23, 2:54 PM
davidxl closed D32387: [PartialInlining] Add Optimization Remark Support by committing rL301143: [PartialInlining] Add optimization remark support.
Sun, Apr 23, 2:54 PM

Apr 22 2017

davidxl updated the diff for D32387: [PartialInlining] Add Optimization Remark Support.

Use dash instead of underscore.

Apr 22 2017, 8:30 PM
davidxl added a comment to D32387: [PartialInlining] Add Optimization Remark Support.

The way it is used, it does not require any analysis pass (on demand ).

Apr 22 2017, 8:30 PM
davidxl updated the diff for D32387: [PartialInlining] Add Optimization Remark Support.

Rebase.

Apr 22 2017, 12:42 PM
davidxl committed rL301090: [PartialInlining] Using existing hasAddressTaken interface to legality check/NFC.
[PartialInlining] Using existing hasAddressTaken interface to legality check/NFC
Apr 22 2017, 12:37 PM
davidxl added inline comments to D32387: [PartialInlining] Add Optimization Remark Support.
Apr 22 2017, 12:29 PM

Apr 21 2017

davidxl created D32387: [PartialInlining] Add Optimization Remark Support.
Apr 21 2017, 7:56 PM
davidxl committed rL301042: [PartialInliner] Partial inliner needs to check use kind before transformation.
[PartialInliner] Partial inliner needs to check use kind before transformation
Apr 21 2017, 2:34 PM
davidxl closed D32373: [PartialInliner] Do not do partial inlining for functions with non-call references by committing rL301042: [PartialInliner] Partial inliner needs to check use kind before transformation.
Apr 21 2017, 2:33 PM
davidxl created D32373: [PartialInliner] Do not do partial inlining for functions with non-call references.
Apr 21 2017, 2:07 PM

Apr 20 2017

davidxl accepted D32335: [PartialInliner] Fix crash when inlining functions with unreachable blocks.

The root cause of the problem is that the partial inliner split the newreturn block unconditionally -- even when there is no PHIs in them (creating unreachable block). I have included that fix in my patch, but this patch is fine too.

Apr 20 2017, 9:12 PM
davidxl added inline comments to D32324: CodeGen: BlockPlacement: Increase tail duplication size for O3..
Apr 20 2017, 4:35 PM
davidxl committed rL300899: Use basicblock split block utility function.
Use basicblock split block utility function
Apr 20 2017, 2:53 PM
davidxl closed D32308: Use BasicBlock Util SplitBlock interface to update DT by committing rL300899: Use basicblock split block utility function.
Apr 20 2017, 2:53 PM
davidxl created D32308: Use BasicBlock Util SplitBlock interface to update DT .
Apr 20 2017, 1:46 PM
davidxl accepted D32305: [CodeExtractor] Remove a bunch of unneeded constructors.

by the way, what is your PM setup for partial inlining?

Apr 20 2017, 11:32 AM
davidxl added a comment to D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.

Is it possible that some of the BBs on the chain may be very big and we don't want to partial inline them?

Apr 20 2017, 10:29 AM

Apr 19 2017

davidxl updated the diff for D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.

Addressed review comments. Added more test including multi return case.

Apr 19 2017, 11:27 PM
davidxl added inline comments to D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
Apr 19 2017, 11:26 PM
davidxl added inline comments to D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
Apr 19 2017, 3:45 PM
davidxl updated the diff for D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.

Addressed review comments .

Apr 19 2017, 3:44 PM
davidxl created D32249: [PartialInl] Enhance partial inliner to handle more complex conditions.
Apr 19 2017, 3:07 PM
davidxl accepted D28962: Add BFI in constanthoisting pass and do the hoisting selectively.

lgtm

Apr 19 2017, 2:49 PM

Apr 18 2017

davidxl added a comment to D30062: Estimate speedup due to inlining and use that to adjust threshold..

Given the performance data, I suggest drop the min speedup requirement to 0 at O3.

Apr 18 2017, 12:18 PM

Apr 17 2017

davidxl accepted D31952: Build SymbolMap in SampleProfileLoader to help matchin function names with suffix..

ok. The original erase is fine (given the intention is to discard cases with conflicts).

Apr 17 2017, 3:00 PM
davidxl added inline comments to D31952: Build SymbolMap in SampleProfileLoader to help matchin function names with suffix..
Apr 17 2017, 2:37 PM
davidxl added inline comments to D31952: Build SymbolMap in SampleProfileLoader to help matchin function names with suffix..
Apr 17 2017, 2:23 PM
davidxl added a reviewer for D31952: Build SymbolMap in SampleProfileLoader to help matchin function names with suffix.: tejohnson.
Apr 17 2017, 10:53 AM