Page MenuHomePhabricator

hctim (Mitch Phillips)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2017, 3:58 PM (92 w, 4 d)

Recent Activity

Mon, Jun 17

hctim committed rG8fbb88fbff5e: [GWP-ASan] Disable GWP-ASan on Android for now. (authored by hctim).
[GWP-ASan] Disable GWP-ASan on Android for now.
Mon, Jun 17, 3:36 PM
hctim committed rL363624: [GWP-ASan] Disable GWP-ASan on Android for now..
[GWP-ASan] Disable GWP-ASan on Android for now.
Mon, Jun 17, 3:35 PM
hctim closed D63460: [GWP-ASan] Disable GWP-ASan on Android for now..
Mon, Jun 17, 3:35 PM · Restricted Project, Restricted Project
hctim added a comment to D63460: [GWP-ASan] Disable GWP-ASan on Android for now..

Current failures look like this:

Mon, Jun 17, 3:25 PM · Restricted Project, Restricted Project
hctim created D63460: [GWP-ASan] Disable GWP-ASan on Android for now..
Mon, Jun 17, 3:24 PM · Restricted Project, Restricted Project
hctim committed rG79bc188dc242: Attempt to fix GWP-ASan build failure on sanitizer-android. Add -fPIC. (authored by hctim).
Attempt to fix GWP-ASan build failure on sanitizer-android. Add -fPIC.
Mon, Jun 17, 12:37 PM
hctim committed rL363604: Attempt to fix GWP-ASan build failure on sanitizer-android. Add -fPIC..
Attempt to fix GWP-ASan build failure on sanitizer-android. Add -fPIC.
Mon, Jun 17, 12:37 PM
hctim committed rG21184ec5c48c: [GWP-ASan] Integration with Scudo [5]. (authored by hctim).
[GWP-ASan] Integration with Scudo [5].
Mon, Jun 17, 10:44 AM
hctim committed rL363584: [GWP-ASan] Integration with Scudo [5]..
[GWP-ASan] Integration with Scudo [5].
Mon, Jun 17, 10:42 AM
hctim closed D62929: [GWP-ASan] Integration with Scudo [5]..
Mon, Jun 17, 10:42 AM · Restricted Project, Restricted Project
hctim updated the diff for D62929: [GWP-ASan] Integration with Scudo [5]..

Merge master in preparation for submit.

Mon, Jun 17, 10:42 AM · Restricted Project, Restricted Project

Fri, Jun 14

hctim raised a concern with rL363410: GlobalISel: Avoid producing Illegal copies in RegBankSelect.

This broke the sanitizer buildbots - please take a look (reverted w/ error log in rL363476).

Fri, Jun 14, 4:46 PM
hctim committed rG0d44f129bb99: Revert "GlobalISel: Avoid producing Illegal copies in RegBankSelect" (authored by hctim).
Revert "GlobalISel: Avoid producing Illegal copies in RegBankSelect"
Fri, Jun 14, 4:43 PM
hctim added a reverting change for rGc2864c0de07e: GlobalISel: Avoid producing Illegal copies in RegBankSelect: rG0d44f129bb99: Revert "GlobalISel: Avoid producing Illegal copies in RegBankSelect".
Fri, Jun 14, 4:43 PM
hctim added a reverting change for rL363410: GlobalISel: Avoid producing Illegal copies in RegBankSelect: rL363476: Revert "GlobalISel: Avoid producing Illegal copies in RegBankSelect".
Fri, Jun 14, 4:43 PM
hctim committed rL363476: Revert "GlobalISel: Avoid producing Illegal copies in RegBankSelect".
Revert "GlobalISel: Avoid producing Illegal copies in RegBankSelect"
Fri, Jun 14, 4:43 PM

Mon, Jun 10

hctim added inline comments to D62929: [GWP-ASan] Integration with Scudo [5]..
Mon, Jun 10, 9:15 AM · Restricted Project, Restricted Project
hctim updated the diff for D62929: [GWP-ASan] Integration with Scudo [5]..
  • Added new realloc test, deleted dummy test.
Mon, Jun 10, 9:15 AM · Restricted Project, Restricted Project

Fri, Jun 7

hctim committed rG45500fcd5dee: [GWP-ASan] Removed unittests from Android build. (authored by hctim).
[GWP-ASan] Removed unittests from Android build.
Fri, Jun 7, 1:57 PM
hctim committed rL362842: [GWP-ASan] Removed unittests from Android build..
[GWP-ASan] Removed unittests from Android build.
Fri, Jun 7, 1:57 PM
hctim closed D63019: [GWP-ASan] Removed unittests from Android build..
Fri, Jun 7, 1:57 PM · Restricted Project, Restricted Project
hctim created D63019: [GWP-ASan] Removed unittests from Android build..
Fri, Jun 7, 12:18 PM · Restricted Project, Restricted Project

Thu, Jun 6

hctim committed rGe41e366ae727: Change GWP-ASan build to use '-pthread' instead of '-lpthread' in order to try… (authored by hctim).
Change GWP-ASan build to use '-pthread' instead of '-lpthread' in order to try…
Thu, Jun 6, 4:43 PM
hctim committed rL362758: Change GWP-ASan build to use '-pthread' instead of '-lpthread' in order.
Change GWP-ASan build to use '-pthread' instead of '-lpthread' in order
Thu, Jun 6, 4:42 PM
hctim updated the diff for D62929: [GWP-ASan] Integration with Scudo [5]..
  • Removed extra var in scudo lit cfg.
Thu, Jun 6, 1:04 PM · Restricted Project, Restricted Project
hctim added a comment to D62929: [GWP-ASan] Integration with Scudo [5]..

The only potential concern I have is the specific use of the TLS variables in GWP-ASan which might not work everywhere here (eg: if a platform is using emutls as TLS as it uses malloc() internally).

Thu, Jun 6, 1:04 PM · Restricted Project, Restricted Project

Wed, Jun 5

hctim created D62929: [GWP-ASan] Integration with Scudo [5]..
Wed, Jun 5, 1:15 PM · Restricted Project, Restricted Project
hctim committed rGa95edb9dc1dd: [GWP-ASan] Core Guarded Pool Allocator [4]. (authored by hctim).
[GWP-ASan] Core Guarded Pool Allocator [4].
Wed, Jun 5, 12:42 PM
hctim committed rL362636: [GWP-ASan] Core Guarded Pool Allocator [4]..
[GWP-ASan] Core Guarded Pool Allocator [4].
Wed, Jun 5, 12:40 PM
hctim closed D62872: [GWP-ASan] Core Guarded Pool Allocator [4]..
Wed, Jun 5, 12:39 PM · Restricted Project, Restricted Project
hctim updated the diff for D62872: [GWP-ASan] Core Guarded Pool Allocator [4]..
  • Merge branch 'master' into gwp_asan/gpa
  • Merged master. Added a TODO.
Wed, Jun 5, 12:39 PM · Restricted Project, Restricted Project

Tue, Jun 4

hctim updated the diff for D62872: [GWP-ASan] Core Guarded Pool Allocator [4]..
  • Added GPA.h to CMakeLists.txt
  • Merge branch 'master' into gwp_asan/gpa
  • Vlad's comments.
Tue, Jun 4, 7:08 PM · Restricted Project, Restricted Project
hctim added inline comments to D62872: [GWP-ASan] Core Guarded Pool Allocator [4]..
Tue, Jun 4, 7:08 PM · Restricted Project, Restricted Project
hctim committed rGc012188adaf7: Changed force build of GWP-ASan options parser to be statically linked instead… (authored by hctim).
Changed force build of GWP-ASan options parser to be statically linked instead…
Tue, Jun 4, 6:28 PM
hctim committed rL362566: Changed force build of GWP-ASan options parser to be statically.
Changed force build of GWP-ASan options parser to be statically
Tue, Jun 4, 6:28 PM
hctim removed a reviewer for D62875: [GWP-ASan] Add public-facing documentation [6].: jfb.
Tue, Jun 4, 1:21 PM · Restricted Project, Restricted Project
hctim removed a reviewer for D62872: [GWP-ASan] Core Guarded Pool Allocator [4].: jfb.
Tue, Jun 4, 1:20 PM · Restricted Project, Restricted Project
hctim created D62875: [GWP-ASan] Add public-facing documentation [6]..
Tue, Jun 4, 1:19 PM · Restricted Project, Restricted Project
hctim created D62872: [GWP-ASan] Core Guarded Pool Allocator [4]..
Tue, Jun 4, 12:46 PM · Restricted Project, Restricted Project
hctim committed rG2e207d4d76df: Fixed GWP-ASan build breakage. When adding the optional flag parser, there was… (authored by hctim).
Fixed GWP-ASan build breakage. When adding the optional flag parser, there was…
Tue, Jun 4, 12:19 PM
hctim committed rL362542: Fixed GWP-ASan build breakage. When adding the optional flag parser, there was….
Fixed GWP-ASan build breakage. When adding the optional flag parser, there was…
Tue, Jun 4, 12:16 PM
hctim committed rG2133daf232c5: [GWP-ASan] Configuration options [3]. (authored by hctim).
[GWP-ASan] Configuration options [3].
Tue, Jun 4, 9:59 AM
hctim committed rL362527: [GWP-ASan] Configuration options [3]..
[GWP-ASan] Configuration options [3].
Tue, Jun 4, 9:59 AM
hctim closed D62698: [GWP-ASan] Configuration options [3]..
Tue, Jun 4, 9:59 AM · Restricted Project, Restricted Project
hctim updated the diff for D62698: [GWP-ASan] Configuration options [3]..
  • Matt's last round of comments.
  • Merge branch 'master' into gwp_asan/options
Tue, Jun 4, 9:58 AM · Restricted Project, Restricted Project

Mon, Jun 3

hctim updated the diff for D62698: [GWP-ASan] Configuration options [3]..
  • Matt's comments #3.
Mon, Jun 3, 10:24 AM · Restricted Project, Restricted Project

Fri, May 31

hctim updated the diff for D62698: [GWP-ASan] Configuration options [3]..
  • Merge branch 'master' into gwp_asan/options
  • Updated from Matt's comments.
Fri, May 31, 3:46 PM · Restricted Project, Restricted Project
hctim added inline comments to D62698: [GWP-ASan] Configuration options [3]..
Fri, May 31, 3:46 PM · Restricted Project, Restricted Project

Thu, May 30

hctim committed rG365e59248056: Attempt to fix test failure for armv8. (authored by hctim).
Attempt to fix test failure for armv8.
Thu, May 30, 3:00 PM
hctim added a comment to D61923: [GWP-ASan] Mutex implementation [2]..

Looks like this also broke an armv8 bot, due to a maximum number of threads issue. Have filed rL362163 to attempt to fix. If that doesn't work, I'll just disable the test for armv8.

Thu, May 30, 3:00 PM · Restricted Project, Restricted Project, Restricted Project
hctim committed rL362163: Attempt to fix test failure for armv8..
Attempt to fix test failure for armv8.
Thu, May 30, 2:55 PM
hctim added a comment to D61923: [GWP-ASan] Mutex implementation [2]..

Looks like this broke an autoconf bot. Have submitted rL362149, which should hopefully fix the issue.

Thu, May 30, 1:48 PM · Restricted Project, Restricted Project, Restricted Project
hctim committed rG9bd9a03ad04c: Attempt to fix 'mutex.h' not found when building mutex_posix. (authored by hctim).
Attempt to fix 'mutex.h' not found when building mutex_posix.
Thu, May 30, 1:48 PM
hctim committed rL362149: Attempt to fix 'mutex.h' not found when building mutex_posix..
Attempt to fix 'mutex.h' not found when building mutex_posix.
Thu, May 30, 1:48 PM
hctim created D62698: [GWP-ASan] Configuration options [3]..
Thu, May 30, 1:31 PM · Restricted Project, Restricted Project
hctim committed rG5f0f4e3ae03a: [GWP-ASan] Mutex implementation [2]. (authored by hctim).
[GWP-ASan] Mutex implementation [2].
Thu, May 30, 12:43 PM
hctim committed rL362138: [GWP-ASan] Mutex implementation [2]..
[GWP-ASan] Mutex implementation [2].
Thu, May 30, 12:42 PM
hctim closed D61923: [GWP-ASan] Mutex implementation [2]..
Thu, May 30, 12:42 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D61923: [GWP-ASan] Mutex implementation [2]..

Merged with tip-of-tree in preparation for submit.

Thu, May 30, 12:42 PM · Restricted Project, Restricted Project, Restricted Project
hctim added inline comments to D61923: [GWP-ASan] Mutex implementation [2]..
Thu, May 30, 10:35 AM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D61923: [GWP-ASan] Mutex implementation [2]..
  • Updated from Matt's comments.
Thu, May 30, 10:35 AM · Restricted Project, Restricted Project, Restricted Project

Wed, May 29

hctim added inline comments to D61923: [GWP-ASan] Mutex implementation [2]..
Wed, May 29, 4:32 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D61923: [GWP-ASan] Mutex implementation [2]..
  • Apologies about the delay on this. Updated with Matt's comments.
Wed, May 29, 4:32 PM · Restricted Project, Restricted Project, Restricted Project

Wed, May 22

hctim added inline comments to D61923: [GWP-ASan] Mutex implementation [2]..
Wed, May 22, 8:32 AM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D61923: [GWP-ASan] Mutex implementation [2]..
  • Ifdef-d headers into mutex.h
Wed, May 22, 8:31 AM · Restricted Project, Restricted Project, Restricted Project

Tue, May 21

hctim updated the diff for D61923: [GWP-ASan] Mutex implementation [2]..
  • Updated to use pointer-to-impl to abstract implementation behaviour away from header files.
Tue, May 21, 4:03 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D61923: [GWP-ASan] Mutex implementation [2]..

Changed GWP-ASan to use platform specific mutexes. For now, we only
target Android and Linux, and subsequently only need the pthread_mutex
variant for POSIX.

Tue, May 21, 3:25 PM · Restricted Project, Restricted Project, Restricted Project

May 18 2019

hctim added a comment to rL361073: Explicitly remove -stdlib=libc++, as we pass -nostdinc++ anyway. This should….

Any chance this could've caused the build breakage starting at http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/14855 ?

May 18 2019, 10:43 AM

May 17 2019

hctim updated the diff for D61923: [GWP-ASan] Mutex implementation [2]..

Merged in master after fixing up some buildbots with the previous patches.

May 17 2019, 2:08 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated subscribers of rL361073: Explicitly remove -stdlib=libc++, as we pass -nostdinc++ anyway. This should….

@morehouse @vitalybuka: FYI - should fix the android bot.

May 17 2019, 1:37 PM
hctim committed rG182c638fe090: Explicitly remove -stdlib=libc++, as we pass -nostdinc++ anyway. This should… (authored by hctim).
Explicitly remove -stdlib=libc++, as we pass -nostdinc++ anyway. This should…
May 17 2019, 1:33 PM
hctim committed rCRT361073: Explicitly remove -stdlib=libc++, as we pass -nostdinc++ anyway. This should….
Explicitly remove -stdlib=libc++, as we pass -nostdinc++ anyway. This should…
May 17 2019, 1:32 PM
hctim committed rL361073: Explicitly remove -stdlib=libc++, as we pass -nostdinc++ anyway. This should….
Explicitly remove -stdlib=libc++, as we pass -nostdinc++ anyway. This should…
May 17 2019, 1:32 PM

May 16 2019

hctim committed rG364f662fa3f3: [GWP-ASan] Fixed issue with c++ standard library dependency. (authored by hctim).
[GWP-ASan] Fixed issue with c++ standard library dependency.
May 16 2019, 8:19 PM
hctim committed rL360982: [GWP-ASan] Fixed issue with c++ standard library dependency..
[GWP-ASan] Fixed issue with c++ standard library dependency.
May 16 2019, 8:19 PM
hctim committed rCRT360982: [GWP-ASan] Fixed issue with c++ standard library dependency..
[GWP-ASan] Fixed issue with c++ standard library dependency.
May 16 2019, 8:19 PM
hctim closed D62048: [GWP-ASan] Fixed issue with c++ standard library dependency..
May 16 2019, 8:19 PM · Restricted Project, Restricted Project
hctim updated the diff for D62048: [GWP-ASan] Fixed issue with c++ standard library dependency..
  • Merge branch 'master' into gwp_asan/fix-c++stdlib
May 16 2019, 8:16 PM · Restricted Project, Restricted Project
hctim added inline comments to D62048: [GWP-ASan] Fixed issue with c++ standard library dependency..
May 16 2019, 8:13 PM · Restricted Project, Restricted Project
hctim updated the diff for D62048: [GWP-ASan] Fixed issue with c++ standard library dependency..
  • /s/transient/delegated
May 16 2019, 8:13 PM · Restricted Project, Restricted Project
hctim added a comment to D62048: [GWP-ASan] Fixed issue with c++ standard library dependency..

LGTM, would it be possible to land this?

May 16 2019, 7:23 PM · Restricted Project, Restricted Project
hctim added a comment to D62039: [GWP-ASan] Add missing dependency on C++ headers.

I've filed D62048 which should resolve the build order discrepancy. Would prefer to do that rather than this as GWP-ASan shouldn't need to clash swords with c++ standard library, as it shouldn't be using it in the first place :)

May 16 2019, 5:48 PM · Restricted Project, Restricted Project
hctim created D62048: [GWP-ASan] Fixed issue with c++ standard library dependency..
May 16 2019, 5:44 PM · Restricted Project, Restricted Project

May 15 2019

hctim added a comment to D61923: [GWP-ASan] Mutex implementation [2]..
In D61923#1503272, @jfb wrote:

Have you asked on libcxx-dev whether a stand-alone base is something of interest to them?

No, but I will follow up on that.

May 15 2019, 10:43 AM · Restricted Project, Restricted Project, Restricted Project
hctim updated the summary of D61923: [GWP-ASan] Mutex implementation [2]..
May 15 2019, 10:08 AM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D61923: [GWP-ASan] Mutex implementation [2]..

Is the question why do Scudo has its own as opposed to rely on platform specific ones?

May 15 2019, 10:00 AM · Restricted Project, Restricted Project, Restricted Project

May 14 2019

hctim added a comment to D60593: [GwpAsan] Introduce GWP-ASan..
In D60593#1502266, @jfb wrote:

Hello I'm here to bikeshed, and this is a terrible name for an LLVM project. Or super appropriate because LLVM itself is a terrible name? In any case, backronym it to something else, or rename it. Thanks!

May 14 2019, 6:21 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D61923: [GWP-ASan] Mutex implementation [2]..
In D61923#1502245, @jfb wrote:

Seems a shame to duplicate mutex again... Why can't use use the STL's version again? It doesn't allocate.

May 14 2019, 6:00 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D61923: [GWP-ASan] Mutex implementation [2]..
May 14 2019, 5:59 PM · Restricted Project, Restricted Project, Restricted Project
hctim created D61923: [GWP-ASan] Mutex implementation [2]..
May 14 2019, 4:28 PM · Restricted Project, Restricted Project, Restricted Project
hctim committed rCRT360710: [GWP-ASan] Initial build files, implementation of PRNG [1]..
[GWP-ASan] Initial build files, implementation of PRNG [1].
May 14 2019, 2:54 PM
hctim committed rGc9dd299736ad: [GWP-ASan] Initial build files, implementation of PRNG [1]. (authored by hctim).
[GWP-ASan] Initial build files, implementation of PRNG [1].
May 14 2019, 2:44 PM
hctim committed rL360710: [GWP-ASan] Initial build files, implementation of PRNG [1]..
[GWP-ASan] Initial build files, implementation of PRNG [1].
May 14 2019, 2:43 PM
hctim closed D61867: [GWP-ASan] Initial build files, implementation of PRNG [1]..
May 14 2019, 2:43 PM · Restricted Project, Restricted Project
hctim updated the diff for D61867: [GWP-ASan] Initial build files, implementation of PRNG [1]..
  • Merged in master ready for submission.
May 14 2019, 2:37 PM · Restricted Project, Restricted Project
hctim updated the diff for D61867: [GWP-ASan] Initial build files, implementation of PRNG [1]..
  • Updated getRandomUnsigned32() to simply use xorshift32, instead of xorwow.
May 14 2019, 2:23 PM · Restricted Project, Restricted Project
hctim added inline comments to D61867: [GWP-ASan] Initial build files, implementation of PRNG [1]..
May 14 2019, 1:26 PM · Restricted Project, Restricted Project
hctim updated the diff for D61867: [GWP-ASan] Initial build files, implementation of PRNG [1]..
  • /s/static thread_local/thread_local
May 14 2019, 1:26 PM · Restricted Project, Restricted Project
hctim updated the diff for D61867: [GWP-ASan] Initial build files, implementation of PRNG [1]..
  • Updated to 32-bit PRNG, removed unneccessary definitions.h
May 14 2019, 10:04 AM · Restricted Project, Restricted Project

May 13 2019

hctim added a comment to D61867: [GWP-ASan] Initial build files, implementation of PRNG [1]..

function-static vs global-static TLS variables: http://quick-bench.com/te2xYFbzDW0dqt-ql0fOQMieFEM

May 13 2019, 11:26 AM · Restricted Project, Restricted Project