- User Since
- Sep 8 2017, 3:58 PM (162 w, 6 d)
Tue, Oct 20
(commenting to try and front my comments before your new patch)
Mon, Oct 19
LGTM w/ one discrepancy
Sep 18 2020
Not a known issue - no, but MSan doesn't play nice with uninistrumented libraries (including things like libcxx) - and so it can be tricky to ensure your build is properly sanitized, which is why I'd recommend the build script :).
Sep 17 2020
Looks like this patch broke the MSan buildbots, PTAL (repro instructions https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild):
Sep 16 2020
Sep 8 2020
Mostly just some nits - other than that LGTM.
Sep 2 2020
LGTM (after the keep_seed patch lands)
Still LGTM - can't validate the Fuchsia change on my end but Linux still seems fine.
Sep 1 2020
Aug 26 2020
Aug 25 2020
Is it possible to fork the cross_over_uniformdist changes into a supplementary patchset easily? Seems like an related but indepentent change (prefer one patchset per feature if possible please -- reviewing is O(n^3) in lines-of-code-per-patch and it's also nice to have different commits for different features).
Aug 24 2020
Aug 17 2020
Aug 7 2020
Aug 3 2020
Hi folks, looks like this patch broke check-clang under ASan/MSan, would you mind taking a look? Thanks.
Hi Simon, looks like this patch breaks bots that use -Wsign-compare (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/28842/steps/ninja%20check-asan/logs/stdio).
Jul 31 2020
Fix an OOB operand problem. ISel is smart enough to figure out the MO_G3
relocation should use a 48-bit shift, but assert()'s internally if the third
operand isn't specified.
Jul 28 2020
Jul 27 2020
- Fix up 'dealloc' typo.
Apparently static constexpr declarations and initializers go in headers,
but they still require declarations to avoid link-time undefined
reference complaints (except after c++17). Learn something new every day, I guess.
Jul 24 2020
Revert of the original changes was already done in 540b92147da0e9a2c2d096505eb0785ec79f2024 :) - a rebase should fix it up.
Jul 23 2020
Jul 21 2020
Jul 17 2020
- Refactor the backtrace code into a common core.
Jul 16 2020
- And patch in the changes to scudo/standalone.
- Remove vestigal changes to sanitizer_common.
+@cryptoad as this touches non-standalone scudo, but to a very limited degree.
LGTM w/ nit
Jul 14 2020
Jul 13 2020
Jul 8 2020
Jul 1 2020
So - the FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION flag is a property of the build system and not that of the compiler. There are some places (android) where enabling FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION globally changes the behaviour of large amounts of libraries in ways that break the build system.
Jun 30 2020
Changed the filename and fixed up the inverted test.
Hi @arsenm - does this patch LGTY? Still unsure about whether we need to notify the CO here, if you could help advise that would be much appreciated. Thanks.
Jun 26 2020
- Remove vestigal operand and set regclass properly.
- Reformat exported-tagged-globalc.
Jun 25 2020
Abandoning - fixing the underlying issue at D82615.
First patchset was the wrong diff. Should be the right one now.
Jun 24 2020
Reverted in 10045cbe01928d9281723c640c03984d540f9012 to bring the ASan bots green again.
Jun 23 2020
Jun 22 2020
Jun 19 2020
Jun 18 2020
How does this change look w.r.t. a memory replay test (https://android.googlesource.com/platform/bionic/+/master/docs/native_allocator.md#memory-replay-benchmarks)?
Jun 16 2020