Page MenuHomePhabricator

hctim (Mitch Phillips)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2017, 3:58 PM (162 w, 6 d)

Recent Activity

Yesterday

hctim accepted D89984: [GWP-ASan] Move random-related code in the allocator (redo).
Thu, Oct 22, 1:42 PM · Restricted Project
hctim accepted D89908: [GWP-ASan] Move random-related code in the allocator.

LGTM!

Thu, Oct 22, 10:08 AM · Restricted Project
hctim added inline comments to D89908: [GWP-ASan] Move random-related code in the allocator.
Thu, Oct 22, 9:34 AM · Restricted Project

Tue, Oct 20

hctim accepted D89811: [GWP-ASan] Rework utilities (NFC).
Tue, Oct 20, 11:51 AM · Restricted Project
hctim added a comment to D89808: [GWP-ASan] Rework utilities (NFC).

(commenting to try and front my comments before your new patch)

Tue, Oct 20, 10:35 AM · Restricted Project

Mon, Oct 19

hctim accepted D89750: [hwasan] Increase max allocation size to 1Tb..
Mon, Oct 19, 5:03 PM · Restricted Project
hctim added a comment to D89721: [GWP-ASan] Cleanup (NFC).

LGTM

Mon, Oct 19, 1:18 PM · Restricted Project
hctim added inline comments to D89721: [GWP-ASan] Cleanup (NFC).
Mon, Oct 19, 12:44 PM · Restricted Project
hctim accepted D89721: [GWP-ASan] Cleanup (NFC).

LGTM w/ one discrepancy

Mon, Oct 19, 12:17 PM · Restricted Project

Sep 18 2020

hctim added a comment to D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions.

Not a known issue - no, but MSan doesn't play nice with uninistrumented libraries (including things like libcxx) - and so it can be tricky to ensure your build is properly sanitized, which is why I'd recommend the build script :).

Sep 18 2020, 11:35 AM · Restricted Project

Sep 17 2020

hctim added a comment to D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions.

Looks like this patch broke the MSan buildbots, PTAL (repro instructions https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild):

Sep 17 2020, 10:12 AM · Restricted Project

Sep 16 2020

hctim added inline comments to D87739: scudo: Add an API for disabling memory initialization per-thread..
Sep 16 2020, 12:32 PM · Restricted Project
hctim added inline comments to D87739: scudo: Add an API for disabling memory initialization per-thread..
Sep 16 2020, 11:07 AM · Restricted Project

Sep 8 2020

hctim accepted D86560: [libFuzzer] Add a command-line option for tracing mutation of corpus inputs in the dot graph format..

LGTM

Sep 8 2020, 8:34 PM · Restricted Project
hctim accepted D86560: [libFuzzer] Add a command-line option for tracing mutation of corpus inputs in the dot graph format..

Mostly just some nits - other than that LGTM.

Sep 8 2020, 1:21 PM · Restricted Project

Sep 2 2020

hctim added inline comments to D86577: [libFuzzer] Add an option to keep initial seed inputs around..
Sep 2 2020, 3:33 PM · Restricted Project
hctim added inline comments to D86092: [libFuzzer] Scale energy assigned to each input based on input execution time..
Sep 2 2020, 3:02 PM · Restricted Project
hctim added inline comments to D86577: [libFuzzer] Add an option to keep initial seed inputs around..
Sep 2 2020, 2:27 PM · Restricted Project
hctim accepted D86954: [libFuzzer] Evenly select inputs to cross over with from the corpus regardless of the input's coverage..

LGTM (after the keep_seed patch lands)

Sep 2 2020, 12:39 PM · Restricted Project
hctim accepted D86800: [scudo][standalone] Enable secondary cache release on Fuchsia.

Still LGTM - can't validate the Fuchsia change on my end but Linux still seems fine.

Sep 2 2020, 12:28 PM · Restricted Project

Sep 1 2020

hctim added inline comments to D86092: [libFuzzer] Scale energy assigned to each input based on input execution time..
Sep 1 2020, 6:26 PM · Restricted Project
hctim accepted D86800: [scudo][standalone] Enable secondary cache release on Fuchsia.
Sep 1 2020, 6:02 PM · Restricted Project
hctim added inline comments to D86954: [libFuzzer] Evenly select inputs to cross over with from the corpus regardless of the input's coverage..
Sep 1 2020, 11:15 AM · Restricted Project

Aug 26 2020

hctim added inline comments to D86577: [libFuzzer] Add an option to keep initial seed inputs around..
Aug 26 2020, 10:42 AM · Restricted Project

Aug 25 2020

hctim added a comment to D86577: [libFuzzer] Add an option to keep initial seed inputs around..

Is it possible to fork the cross_over_uniformdist changes into a supplementary patchset easily? Seems like an related but indepentent change (prefer one patchset per feature if possible please -- reviewing is O(n^3) in lines-of-code-per-patch and it's also nice to have different commits for different features).

Aug 25 2020, 6:07 PM · Restricted Project
hctim added inline comments to D86560: [libFuzzer] Add a command-line option for tracing mutation of corpus inputs in the dot graph format..
Aug 25 2020, 5:42 PM · Restricted Project

Aug 24 2020

hctim accepted D86399: [scudo][standalone] Skip irrelevant regions during release.

Interesting that GCC does not inline capture by ref https://godbolt.org/z/exfP69

Would you recommend some change to ensure inlining?

Aug 24 2020, 9:21 AM · Restricted Project

Aug 17 2020

hctim added inline comments to D86092: [libFuzzer] Scale energy assigned to each input based on input execution time..
Aug 17 2020, 3:25 PM · Restricted Project

Aug 7 2020

hctim added a reverting change for rGb497665d98ad: Reland D64327 [MC][ELF] Allow STT_SECTION referencing SHF_MERGE on REL targets: rG382df1c6744d: Revert "Reland D64327 [MC][ELF] Allow STT_SECTION referencing SHF_MERGE on REL….
Aug 7 2020, 10:59 AM
hctim committed rG382df1c6744d: Revert "Reland D64327 [MC][ELF] Allow STT_SECTION referencing SHF_MERGE on REL… (authored by hctim).
Revert "Reland D64327 [MC][ELF] Allow STT_SECTION referencing SHF_MERGE on REL…
Aug 7 2020, 10:59 AM

Aug 3 2020

hctim added a comment to D84572: Allow .dSYM's to be directly placed in an alternate directory.

Hi folks, looks like this patch broke check-clang under ASan/MSan, would you mind taking a look? Thanks.

Aug 3 2020, 4:13 PM · Restricted Project
hctim added a comment to rG219f32f4b686: [X86][SSE] Shuffle combine blends to OR(X,Y) if the relevant elements are known….

Hi Simon, looks like this patch breaks bots that use -Wsign-compare (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/28842/steps/ninja%20check-asan/logs/stdio).

I've reverted in 66e7dce714fabd3ddb1aed635e4b826476d4f1a2 to bring the bots back online

np, cheers - I don't appear to have received any buildbot failure emails which is a bit odd. I'll resubmit in the morning.

Aug 3 2020, 4:10 PM
hctim committed rG9a05fa10bd05: [HWASan] [GlobalISel] Add +tagged-globals backend feature for GlobalISel (authored by hctim).
[HWASan] [GlobalISel] Add +tagged-globals backend feature for GlobalISel
Aug 3 2020, 2:29 PM
hctim closed D82615: [HWASan] [GlobalISel] Add +tagged-globals backend feature for GlobalISel.
Aug 3 2020, 2:29 PM · Restricted Project, Restricted Project
hctim added a comment to rG219f32f4b686: [X86][SSE] Shuffle combine blends to OR(X,Y) if the relevant elements are known….

Hi Simon, looks like this patch breaks bots that use -Wsign-compare (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/28842/steps/ninja%20check-asan/logs/stdio).

Aug 3 2020, 1:53 PM
hctim added a reverting change for rG219f32f4b686: [X86][SSE] Shuffle combine blends to OR(X,Y) if the relevant elements are known…: rG66e7dce714fa: Revert "[X86][SSE] Shuffle combine blends to OR(X,Y) if the relevant elements….
Aug 3 2020, 1:51 PM
hctim committed rG66e7dce714fa: Revert "[X86][SSE] Shuffle combine blends to OR(X,Y) if the relevant elements… (authored by hctim).
Revert "[X86][SSE] Shuffle combine blends to OR(X,Y) if the relevant elements…
Aug 3 2020, 1:51 PM

Jul 31 2020

hctim updated the diff for D82615: [HWASan] [GlobalISel] Add +tagged-globals backend feature for GlobalISel.

Fix an OOB operand problem. ISel is smart enough to figure out the MO_G3
relocation should use a 48-bit shift, but assert()'s internally if the third
operand isn't specified.

Jul 31 2020, 4:04 PM · Restricted Project, Restricted Project

Jul 28 2020

hctim added inline comments to D84805: [Scudo][CMake] Add -fno-lto to Scudo libraries.
Jul 28 2020, 3:51 PM · Restricted Project

Jul 27 2020

hctim committed rGd19af2f2476b: [GWP-ASan] Crash handler API returns sizeof(collected trace) (authored by hctim).
[GWP-ASan] Crash handler API returns sizeof(collected trace)
Jul 27 2020, 10:54 AM
hctim closed D84652: [GWP-ASan] Crash handler API returns sizeof(collected trace).
Jul 27 2020, 10:54 AM · Restricted Project
hctim updated the diff for D84652: [GWP-ASan] Crash handler API returns sizeof(collected trace).
  • Fix up 'dealloc' typo.
Jul 27 2020, 10:51 AM · Restricted Project
hctim updated the diff for D84652: [GWP-ASan] Crash handler API returns sizeof(collected trace).

Apparently static constexpr declarations and initializers go in headers,
but they still require declarations to avoid link-time undefined
reference complaints (except after c++17). Learn something new every day, I guess.

Jul 27 2020, 7:10 AM · Restricted Project
Herald added a project to D84652: [GWP-ASan] Crash handler API returns sizeof(collected trace): Restricted Project.
Jul 27 2020, 6:30 AM · Restricted Project
hctim committed rG005eee8b3ef7: [GWP-ASan] Fix uninitialized memory use in sigaction. (authored by hctim).
[GWP-ASan] Fix uninitialized memory use in sigaction.
Jul 27 2020, 5:54 AM

Jul 24 2020

hctim added a reviewer for D84561: Replace fuzzer::FuzzerDriver's INTERFACE marking with new LLVMRunFuzzerDriver.: kcc.
Jul 24 2020, 3:30 PM · Restricted Project, Restricted Project
hctim updated subscribers of D84561: Replace fuzzer::FuzzerDriver's INTERFACE marking with new LLVMRunFuzzerDriver..

Revert of the original changes was already done in 540b92147da0e9a2c2d096505eb0785ec79f2024 :) - a rebase should fix it up.

Jul 24 2020, 3:30 PM · Restricted Project, Restricted Project

Jul 23 2020

hctim committed rG540b92147da0: Revert "[libFuzzer] Expose fuzzer::FuzzerDriver()" (authored by hctim).
Revert "[libFuzzer] Expose fuzzer::FuzzerDriver()"
Jul 23 2020, 5:08 PM
hctim added a reverting change for rG22a376e73bc2: [libFuzzer] Expose fuzzer::FuzzerDriver(): rG540b92147da0: Revert "[libFuzzer] Expose fuzzer::FuzzerDriver()".
Jul 23 2020, 5:08 PM
hctim committed rG22a376e73bc2: [libFuzzer] Expose fuzzer::FuzzerDriver() (authored by hctim).
[libFuzzer] Expose fuzzer::FuzzerDriver()
Jul 23 2020, 12:09 PM
hctim closed D84425: [libFuzzer] Expose fuzzer::FuzzerDriver().
Jul 23 2020, 12:08 PM · Restricted Project
Herald added a project to D84425: [libFuzzer] Expose fuzzer::FuzzerDriver(): Restricted Project.
Jul 23 2020, 9:19 AM · Restricted Project

Jul 21 2020

hctim committed rG4f029d1be4e1: [GWP-ASan] Split the unwinder into segv/non-segv. (authored by hctim).
[GWP-ASan] Split the unwinder into segv/non-segv.
Jul 21 2020, 8:26 AM

Jul 17 2020

hctim committed rG502f0cc0e388: [GWP-ASan] Split the unwinder into segv/non-segv. (authored by hctim).
[GWP-ASan] Split the unwinder into segv/non-segv.
Jul 17 2020, 1:05 PM
hctim closed D83994: [GWP-ASan] Split the unwinder into segv/non-segv..
Jul 17 2020, 1:05 PM · Restricted Project
hctim added inline comments to D83994: [GWP-ASan] Split the unwinder into segv/non-segv..
Jul 17 2020, 10:35 AM · Restricted Project
hctim updated the diff for D83994: [GWP-ASan] Split the unwinder into segv/non-segv..
  • Refactor the backtrace code into a common core.
Jul 17 2020, 10:35 AM · Restricted Project
hctim added inline comments to D83994: [GWP-ASan] Split the unwinder into segv/non-segv..
Jul 17 2020, 9:03 AM · Restricted Project

Jul 16 2020

hctim updated the diff for D83994: [GWP-ASan] Split the unwinder into segv/non-segv..
  • And patch in the changes to scudo/standalone.
Jul 16 2020, 5:06 PM · Restricted Project
hctim updated the diff for D83994: [GWP-ASan] Split the unwinder into segv/non-segv..
  • Remove vestigal changes to sanitizer_common.
Jul 16 2020, 5:03 PM · Restricted Project
hctim updated subscribers of D83994: [GWP-ASan] Split the unwinder into segv/non-segv..

+@cryptoad as this touches non-standalone scudo, but to a very limited degree.

Jul 16 2020, 5:01 PM · Restricted Project
hctim updated the diff for D83994: [GWP-ASan] Split the unwinder into segv/non-segv..

Correct diff.

Jul 16 2020, 4:59 PM · Restricted Project
Herald added a project to D83994: [GWP-ASan] Split the unwinder into segv/non-segv.: Restricted Project.
Jul 16 2020, 4:59 PM · Restricted Project
hctim accepted D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.".

LGTM

Jul 16 2020, 3:39 PM · Restricted Project, Restricted Project
hctim added inline comments to D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.".
Jul 16 2020, 3:07 PM · Restricted Project, Restricted Project
hctim accepted D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.".

LGTM w/ nit

Jul 16 2020, 2:51 PM · Restricted Project, Restricted Project

Jul 14 2020

hctim accepted D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

LGTM

Jul 14 2020, 3:29 PM · Restricted Project, Restricted Project
hctim accepted D83823: [libFuzzer] Fix compilation error by including missing platform macro definitions..

LGTM

Jul 14 2020, 3:22 PM · Restricted Project
hctim added inline comments to D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..
Jul 14 2020, 9:55 AM · Restricted Project, Restricted Project

Jul 13 2020

hctim added a comment to D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Right. Apparently with -O2 many calls to memcmp-like functions are removed. I just wondered, though, what makes more sense: disabling such optimization when building (i) with sancov, or (ii) with -fsanitize=fuzzer? If we go for (i), would it make sense to do it in the SanitizerCoverage module pass like other sanitizers do? What do you think? Also, can it be addressed in a follow-up patch?

My opinion is to make it part of -fsanitize=fuzzer, or maybe disable parts of the builtin optimization pass for functions with the OptForFuzzing attribute.

And I think a follow-up patch is easier to review.

Jul 13 2020, 12:41 PM · Restricted Project, Restricted Project
hctim added a comment to D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Builtin libfunc optimizations may transform memcmp and strcmp-like functions. To disable such optimizations, -fno-builtin= flag was additionally added in compiling new test cases. FWIW, the original test cases didn't require such flags since other sanitizers including ASan disables those optimizations in their LLVM pass by dropping libfunc attribute in the call instructions.

Jul 13 2020, 11:38 AM · Restricted Project, Restricted Project

Jul 8 2020

hctim committed rG5a98581d196b: [NFC] Fix some docs warnings (authored by hctim).
[NFC] Fix some docs warnings
Jul 8 2020, 4:31 PM
hctim closed D83416: [NFC] Fix some docs warnings.
Jul 8 2020, 4:31 PM · Restricted Project
hctim added a reviewer for D83416: [NFC] Fix some docs warnings: lattner.
Jul 8 2020, 12:27 PM · Restricted Project
hctim updated the summary of D83416: [NFC] Fix some docs warnings.
Jul 8 2020, 12:26 PM · Restricted Project
Herald added a project to D83416: [NFC] Fix some docs warnings: Restricted Project.
Jul 8 2020, 12:23 PM · Restricted Project
hctim accepted D83369: hwasan: Don't pass the tagged-globals target-feature to non-aarch64 backends..

Thanks!

Jul 8 2020, 8:54 AM · Restricted Project

Jul 1 2020

hctim added a comment to D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage).

So - the FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION flag is a property of the build system and not that of the compiler. There are some places (android) where enabling FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION globally changes the behaviour of large amounts of libraries in ways that break the build system.

Jul 1 2020, 10:15 AM · Restricted Project

Jun 30 2020

hctim updated the diff for D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage).

Changed the filename and fixed up the inverted test.

Jun 30 2020, 5:23 PM · Restricted Project
hctim created D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage).
Jun 30 2020, 4:52 PM · Restricted Project
hctim added a comment to D82615: [HWASan] [GlobalISel] Add +tagged-globals backend feature for GlobalISel.

Hi @arsenm - does this patch LGTY? Still unsure about whether we need to notify the CO here, if you could help advise that would be much appreciated. Thanks.

Jun 30 2020, 11:24 AM · Restricted Project, Restricted Project

Jun 26 2020

hctim added a comment to D82615: [HWASan] [GlobalISel] Add +tagged-globals backend feature for GlobalISel.

I'm not familiar with these types globals. Do you think there's any issue with the current design that would make it difficult to generate optimal code in future?

Jun 26 2020, 4:13 PM · Restricted Project, Restricted Project
hctim updated the diff for D82615: [HWASan] [GlobalISel] Add +tagged-globals backend feature for GlobalISel.
  • Remove vestigal operand and set regclass properly.
Jun 26 2020, 2:08 PM · Restricted Project, Restricted Project
hctim added inline comments to D82615: [HWASan] [GlobalISel] Add +tagged-globals backend feature for GlobalISel.
Jun 26 2020, 2:08 PM · Restricted Project, Restricted Project
hctim added a reviewer for D82615: [HWASan] [GlobalISel] Add +tagged-globals backend feature for GlobalISel: aemerson.
Jun 26 2020, 11:29 AM · Restricted Project, Restricted Project
hctim updated the diff for D82615: [HWASan] [GlobalISel] Add +tagged-globals backend feature for GlobalISel.
  • Reformat exported-tagged-globalc.
Jun 26 2020, 11:29 AM · Restricted Project, Restricted Project
hctim added inline comments to D82615: [HWASan] [GlobalISel] Add +tagged-globals backend feature for GlobalISel.
Jun 26 2020, 11:29 AM · Restricted Project, Restricted Project

Jun 25 2020

hctim abandoned D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals..

Abandoning - fixing the underlying issue at D82615.

Jun 25 2020, 6:02 PM · Restricted Project, Restricted Project, Restricted Project
hctim created D82615: [HWASan] [GlobalISel] Add +tagged-globals backend feature for GlobalISel.
Jun 25 2020, 5:29 PM · Restricted Project, Restricted Project
hctim updated the diff for D82615: [HWASan] [GlobalISel] Add +tagged-globals backend feature for GlobalISel.

First patchset was the wrong diff. Should be the right one now.

Jun 25 2020, 5:29 PM · Restricted Project, Restricted Project

Jun 24 2020

hctim added a comment to D80330: [BitcodeReader] Fix DelayedShuffle handling for ConstantExpr shuffles..

Reverted in 10045cbe01928d9281723c640c03984d540f9012 to bring the ASan bots green again.

Jun 24 2020, 3:13 PM · Restricted Project
hctim committed rG10045cbe0192: Revert "[BitcodeReader] Fix DelayedShuffle handling for ConstantExpr shuffles." (authored by hctim).
Revert "[BitcodeReader] Fix DelayedShuffle handling for ConstantExpr shuffles."
Jun 24 2020, 2:41 PM
hctim added a reverting change for rGb5740105d270: [BitcodeReader] Fix DelayedShuffle handling for ConstantExpr shuffles.: rG10045cbe0192: Revert "[BitcodeReader] Fix DelayedShuffle handling for ConstantExpr shuffles.".
Jun 24 2020, 2:41 PM

Jun 23 2020

hctim added a comment to D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals..

I don't follow. It no longer falls back, so what is the problem?

Jun 23 2020, 3:05 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals..

I'm OK with this as a workaround, but it would be more natural to detect the unsupported IR pattern in globalisel and fall back instead of disabling it entirely. Is it difficult to do for some reason?

Jun 23 2020, 2:31 PM · Restricted Project, Restricted Project, Restricted Project

Jun 22 2020

hctim added a comment to D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals..

Is the fallback not working correctly in this case for some reason?

Jun 22 2020, 5:12 PM · Restricted Project, Restricted Project, Restricted Project

Jun 19 2020

hctim created D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals..
Jun 19 2020, 5:56 PM · Restricted Project, Restricted Project, Restricted Project

Jun 18 2020

hctim added a comment to D82031: [scudo][standalone] Release smaller blocks less often.

How does this change look w.r.t. a memory replay test (https://android.googlesource.com/platform/bionic/+/master/docs/native_allocator.md#memory-replay-benchmarks)?

Is it possible to get a before/after of RSS/USS and CPU? This change seems like a very reasonable strategy to me, but I feel like I'm flying blind.

I'm planning to run perf tests on this. Unfortunately, I lost the device I was using last night, so I couldn't run the data properly. I can put up the data here when I'm done.

Jun 18 2020, 11:26 AM · Restricted Project
hctim added a comment to D82031: [scudo][standalone] Release smaller blocks less often.

How does this change look w.r.t. a memory replay test (https://android.googlesource.com/platform/bionic/+/master/docs/native_allocator.md#memory-replay-benchmarks)?

Jun 18 2020, 10:18 AM · Restricted Project

Jun 16 2020

hctim accepted D81921: [llvm] Avoid linking llvm-cfi-verify to duplicate libs.

LGTM, thanks!

Jun 16 2020, 10:26 AM · Restricted Project