hctim (Mitch Phillips)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2017, 3:58 PM (45 w, 1 d)

Recent Activity

Nov 15 2017

hctim created D40111: [cfi-verify] Add blame context printing, and improved print format..
Nov 15 2017, 4:46 PM

Nov 14 2017

hctim removed 1 auditor(s) for rL318238: [cfi-verify] Validate there are no register clobbers between CFI-check and…: grosbach.
Nov 14 2017, 4:39 PM
hctim added a comment to rL318238: [cfi-verify] Validate there are no register clobbers between CFI-check and….

Note to grosbach: I'm not sure why you were added to audit - the change was accepted by reviewers, I've removed you :)

Nov 14 2017, 4:39 PM
hctim committed rL318238: [cfi-verify] Validate there are no register clobbers between CFI-check and….
[cfi-verify] Validate there are no register clobbers between CFI-check and…
Nov 14 2017, 4:35 PM
hctim closed D39820: [cfi-verify] Validate there are no register clobbers between CFI-check and instruction execution. by committing rL318238: [cfi-verify] Validate there are no register clobbers between CFI-check and….
Nov 14 2017, 4:35 PM
hctim updated the diff for D39820: [cfi-verify] Validate there are no register clobbers between CFI-check and instruction execution..

/s/eax/rax

Nov 14 2017, 2:54 PM
hctim updated the diff for D39820: [cfi-verify] Validate there are no register clobbers between CFI-check and instruction execution..

Merged master in preparation for submission.

Nov 14 2017, 2:53 PM
hctim committed rL318211: [cfi-verify] Add DOT graph printing for GraphResult objects..
[cfi-verify] Add DOT graph printing for GraphResult objects.
Nov 14 2017, 2:46 PM
hctim closed D39819: [cfi-verify] Add DOT graph printing for GraphResult objects. by committing rL318211: [cfi-verify] Add DOT graph printing for GraphResult objects..
Nov 14 2017, 2:46 PM
hctim updated the diff for D39819: [cfi-verify] Add DOT graph printing for GraphResult objects..

Merged in master in preparation for submission.

Nov 14 2017, 2:42 PM

Nov 13 2017

hctim retitled D39820: [cfi-verify] Validate there are no register clobbers between CFI-check and instruction execution. from [cfi-verify] Validate there are no spills between CFI-check and instruction execution. to [cfi-verify] Validate there are no register clobbers between CFI-check and instruction execution..
Nov 13 2017, 1:28 PM
hctim updated the diff for D39820: [cfi-verify] Validate there are no register clobbers between CFI-check and instruction execution..

Updated clobber checking to use hasDefOfPhysReg rather than the implicit counterpart. This change now includes a modification to make MCInstrDesc::hasDefOfPhysReg public on pcc's reccomendation.

Nov 13 2017, 1:28 PM
hctim abandoned D39925: [MC] Expose hasDefOfPhysReg(..) in the public MCInstrDesc interface..

Abandoned this revision, merged it as part of D39820 on reccomendation from pcc.

Nov 13 2017, 1:24 PM
hctim updated the diff for D39819: [cfi-verify] Add DOT graph printing for GraphResult objects..

... and merged in master.

Nov 13 2017, 1:18 PM
hctim updated the diff for D39819: [cfi-verify] Add DOT graph printing for GraphResult objects..

Sorted intermediate nodes before printing graphs to DOT format - making the output deterministic.

Nov 13 2017, 1:16 PM
hctim added inline comments to D39819: [cfi-verify] Add DOT graph printing for GraphResult objects..
Nov 13 2017, 12:34 PM

Nov 10 2017

hctim updated the diff for D39819: [cfi-verify] Add DOT graph printing for GraphResult objects..

Addressed Peter's comments: Updated dot printing integration test to be more descriptive.

Nov 10 2017, 4:35 PM
hctim created D39925: [MC] Expose hasDefOfPhysReg(..) in the public MCInstrDesc interface..
Nov 10 2017, 2:51 PM
hctim added inline comments to D39820: [cfi-verify] Validate there are no register clobbers between CFI-check and instruction execution..
Nov 10 2017, 1:56 PM
hctim updated the diff for D39820: [cfi-verify] Validate there are no register clobbers between CFI-check and instruction execution..

Addressed Vlad's comments: Added an explicit register check and some minor changes.

Nov 10 2017, 1:56 PM
hctim committed rL317927: [cfi-verify] Made FileAnalysis operate on a GraphResult rather than build one….
[cfi-verify] Made FileAnalysis operate on a GraphResult rather than build one…
Nov 10 2017, 1:00 PM
hctim closed D39764: [cfi-verify] Made FileAnalysis operate on a GraphResult rather than build one and validate it. by committing rL317927: [cfi-verify] Made FileAnalysis operate on a GraphResult rather than build one….
Nov 10 2017, 1:00 PM
hctim updated the diff for D39764: [cfi-verify] Made FileAnalysis operate on a GraphResult rather than build one and validate it..

Merged with master in preparation for submission.

Nov 10 2017, 12:58 PM
hctim updated the diff for D39819: [cfi-verify] Add DOT graph printing for GraphResult objects..

Updated with a graph printing test.

Nov 10 2017, 11:34 AM
hctim added inline comments to D39764: [cfi-verify] Made FileAnalysis operate on a GraphResult rather than build one and validate it..
Nov 10 2017, 10:52 AM
hctim updated the diff for D39764: [cfi-verify] Made FileAnalysis operate on a GraphResult rather than build one and validate it..

Updated with Vlad's comments, classified the enum, and changed the constant for the unknown instruction to be more obvious at a glance.

Nov 10 2017, 10:49 AM

Nov 9 2017

hctim updated the diff for D39764: [cfi-verify] Made FileAnalysis operate on a GraphResult rather than build one and validate it..

Updated with Vlad's comments, changed some enum values/comments, and merged in master.

Nov 9 2017, 2:18 PM

Nov 8 2017

hctim committed rL317743: [cfi-verify] Adds blacklist blame behaviour to cfi-verify..
[cfi-verify] Adds blacklist blame behaviour to cfi-verify.
Nov 8 2017, 4:18 PM
hctim closed D39750: [cfi-verify] Adds blacklist blame behaviour to cfi-verify. by committing rL317743: [cfi-verify] Adds blacklist blame behaviour to cfi-verify..
Nov 8 2017, 4:18 PM
hctim updated the diff for D39750: [cfi-verify] Adds blacklist blame behaviour to cfi-verify..

Unrolled the inner loop of blame checking and rebased against master.

Nov 8 2017, 4:15 PM
hctim planned changes to D39209: Updated llvm-cfi-verify's docs to reflect design changes..

Needs further updates with latest changes.

Nov 8 2017, 3:18 PM
hctim removed a reviewer for D39209: Updated llvm-cfi-verify's docs to reflect design changes.: pcc.
Nov 8 2017, 3:17 PM
hctim added a dependency for D39820: [cfi-verify] Validate there are no register clobbers between CFI-check and instruction execution.: D39819: [cfi-verify] Add DOT graph printing for GraphResult objects..
Nov 8 2017, 3:14 PM
hctim added a dependent revision for D39819: [cfi-verify] Add DOT graph printing for GraphResult objects.: D39820: [cfi-verify] Validate there are no register clobbers between CFI-check and instruction execution..
Nov 8 2017, 3:14 PM
hctim created D39820: [cfi-verify] Validate there are no register clobbers between CFI-check and instruction execution..
Nov 8 2017, 3:14 PM
hctim updated the diff for D39819: [cfi-verify] Add DOT graph printing for GraphResult objects..

Minor formatting changes.

Nov 8 2017, 3:08 PM
hctim added a dependency for D39819: [cfi-verify] Add DOT graph printing for GraphResult objects.: D39764: [cfi-verify] Made FileAnalysis operate on a GraphResult rather than build one and validate it..
Nov 8 2017, 3:06 PM
hctim added a dependent revision for D39764: [cfi-verify] Made FileAnalysis operate on a GraphResult rather than build one and validate it.: D39819: [cfi-verify] Add DOT graph printing for GraphResult objects..
Nov 8 2017, 3:06 PM
hctim created D39819: [cfi-verify] Add DOT graph printing for GraphResult objects..
Nov 8 2017, 3:06 PM
hctim updated the diff for D39764: [cfi-verify] Made FileAnalysis operate on a GraphResult rather than build one and validate it..

Finally - rebase against the parent revision.

Nov 8 2017, 2:32 PM
hctim updated the diff for D39764: [cfi-verify] Made FileAnalysis operate on a GraphResult rather than build one and validate it..

Made unit tests not use a helper, they should explicitly individually check the result against the expected enum.

Nov 8 2017, 2:29 PM

Nov 7 2017

hctim added a comment to D28907: [SLP] Fix for PR30787: Failure to beneficially vectorize 'copyable' elements in integer binary ops..

Reverted due to build breakage in rL317641. PTAL :)

Nov 7 2017, 4:23 PM
hctim committed rL317641: Revert rL317618.
Revert rL317618
Nov 7 2017, 4:21 PM
hctim added a reverting commit for rL317618: [SLPVectorizer] Failure to beneficially vectorize 'copyable' elements in…: rL317641: Revert rL317618.
Nov 7 2017, 4:21 PM
hctim added a dependent revision for D39750: [cfi-verify] Adds blacklist blame behaviour to cfi-verify.: D39764: [cfi-verify] Made FileAnalysis operate on a GraphResult rather than build one and validate it..
Nov 7 2017, 3:09 PM
hctim added a dependency for D39764: [cfi-verify] Made FileAnalysis operate on a GraphResult rather than build one and validate it.: D39750: [cfi-verify] Adds blacklist blame behaviour to cfi-verify..
Nov 7 2017, 3:09 PM
hctim created D39764: [cfi-verify] Made FileAnalysis operate on a GraphResult rather than build one and validate it..
Nov 7 2017, 3:08 PM
hctim updated the diff for D39750: [cfi-verify] Adds blacklist blame behaviour to cfi-verify..

Rebased over master.

Nov 7 2017, 2:14 PM
hctim committed rL317617: Extend SpecialCaseList to allow users to blame matches on entries in the file..
Extend SpecialCaseList to allow users to blame matches on entries in the file.
Nov 7 2017, 1:17 PM
hctim closed D39485: Extend SpecialCaseList to allow users to blame matches on entries in the file. by committing rL317617: Extend SpecialCaseList to allow users to blame matches on entries in the file..
Nov 7 2017, 1:17 PM
hctim committed rL317616: Update SanitizerSpecialCaseList to use renamed functions in base class..
Update SanitizerSpecialCaseList to use renamed functions in base class.
Nov 7 2017, 1:17 PM
hctim closed D39486: Update SanitizerSpecialCaseList to use renamed functions in base class. by committing rL317616: Update SanitizerSpecialCaseList to use renamed functions in base class..
Nov 7 2017, 1:17 PM
hctim updated the diff for D39485: Extend SpecialCaseList to allow users to blame matches on entries in the file..

Updated with Vlad's comments and rebased over master in preparation for submission.

Nov 7 2017, 1:13 PM
hctim updated the summary of D39750: [cfi-verify] Adds blacklist blame behaviour to cfi-verify..
Nov 7 2017, 12:37 PM
hctim added a dependency for D39750: [cfi-verify] Adds blacklist blame behaviour to cfi-verify.: D39485: Extend SpecialCaseList to allow users to blame matches on entries in the file..
Nov 7 2017, 11:03 AM
hctim added a dependent revision for D39485: Extend SpecialCaseList to allow users to blame matches on entries in the file.: D39750: [cfi-verify] Adds blacklist blame behaviour to cfi-verify..
Nov 7 2017, 11:03 AM
hctim created D39750: [cfi-verify] Adds blacklist blame behaviour to cfi-verify..
Nov 7 2017, 11:03 AM

Nov 6 2017

hctim committed rL317500: [cfi-verify] Added a simple check that stops division-by-zero error when no….
[cfi-verify] Added a simple check that stops division-by-zero error when no…
Nov 6 2017, 11:14 AM
hctim committed rL317498: Make MCAsmBackend and MCCodeEmiiter passed by unique_ptr rval.
Make MCAsmBackend and MCCodeEmiiter passed by unique_ptr rval
Nov 6 2017, 10:57 AM
hctim closed D39268: Make MCAsmBackend and MCCodeEmiiter passed by unique_ptr rval by committing rL317498: Make MCAsmBackend and MCCodeEmiiter passed by unique_ptr rval.
Nov 6 2017, 10:57 AM
hctim updated the diff for D39268: Make MCAsmBackend and MCCodeEmiiter passed by unique_ptr rval.

Merge for submission.

Nov 6 2017, 10:56 AM
hctim updated the diff for D39486: Update SanitizerSpecialCaseList to use renamed functions in base class..

Whoops - update wrong commit. Reverting these changes.

Nov 6 2017, 10:51 AM
hctim updated the diff for D39486: Update SanitizerSpecialCaseList to use renamed functions in base class..

Merge for submission.

Nov 6 2017, 10:49 AM

Nov 3 2017

hctim committed rL317364: [cfi-verify] Add blacklist parsing for result filtering..
[cfi-verify] Add blacklist parsing for result filtering.
Nov 3 2017, 1:55 PM
hctim closed D39525: [cfi-verify] Add blacklist parsing for result filtering. by committing rL317364: [cfi-verify] Add blacklist parsing for result filtering..
Nov 3 2017, 1:55 PM
hctim updated the diff for D39525: [cfi-verify] Add blacklist parsing for result filtering..

Updated with Vlad's comments and merged in master in preparation for submission.

Nov 3 2017, 1:52 PM
hctim committed rL317355: [cfi-verify] Add an interesting unit test where undef search length changes….
[cfi-verify] Add an interesting unit test where undef search length changes…
Nov 3 2017, 1:00 PM
hctim closed D38658: [cfi-verify] Add an interesting unit test where undef search length changes result. by committing rL317355: [cfi-verify] Add an interesting unit test where undef search length changes….
Nov 3 2017, 1:00 PM
hctim updated the diff for D38658: [cfi-verify] Add an interesting unit test where undef search length changes result..

Merge in HEAD for submission.

Nov 3 2017, 12:58 PM
hctim added inline comments to D38658: [cfi-verify] Add an interesting unit test where undef search length changes result..
Nov 3 2017, 12:57 PM
hctim added inline comments to D38658: [cfi-verify] Add an interesting unit test where undef search length changes result..
Nov 3 2017, 11:15 AM

Nov 2 2017

hctim updated the diff for D39525: [cfi-verify] Add blacklist parsing for result filtering..

Updated with Vlad's comments, and rebased against master.

Nov 2 2017, 1:25 PM
hctim updated the diff for D38658: [cfi-verify] Add an interesting unit test where undef search length changes result..

Accidentally updated the wrong patch - reverted last diff.

Nov 2 2017, 1:24 PM
hctim updated the diff for D38658: [cfi-verify] Add an interesting unit test where undef search length changes result..

Updated with Vlad's comments, and rebased against master.

Nov 2 2017, 1:24 PM
hctim committed rL317223: Fixed line length style issue..
Fixed line length style issue.
Nov 2 2017, 11:05 AM
hctim closed D39395: Fixed line length style issue. by committing rL317223: Fixed line length style issue..
Nov 2 2017, 11:05 AM

Nov 1 2017

hctim added a dependent revision for D38658: [cfi-verify] Add an interesting unit test where undef search length changes result.: D39525: [cfi-verify] Add blacklist parsing for result filtering..
Nov 1 2017, 6:24 PM
hctim added a dependency for D39525: [cfi-verify] Add blacklist parsing for result filtering.: D38658: [cfi-verify] Add an interesting unit test where undef search length changes result..
Nov 1 2017, 6:24 PM
hctim created D39525: [cfi-verify] Add blacklist parsing for result filtering..
Nov 1 2017, 6:24 PM
hctim committed rL317141: Update cl::opt<uint64_t> instances to cl::opt<unsigned long long>.
Update cl::opt<uint64_t> instances to cl::opt<unsigned long long>
Nov 1 2017, 4:40 PM
hctim closed D38657: Update cl::opt<uint64_t> instances to cl::opt<unsigned long long> by committing rL317141: Update cl::opt<uint64_t> instances to cl::opt<unsigned long long>.
Nov 1 2017, 4:40 PM
hctim updated the diff for D38657: Update cl::opt<uint64_t> instances to cl::opt<unsigned long long>.

Merged master in preparation for submission.

Nov 1 2017, 4:37 PM
hctim updated the diff for D39485: Extend SpecialCaseList to allow users to blame matches on entries in the file..

Accidently made last modifications on an old patch, merged the changes across onto the most recent patch and fixed up the regressions.

Nov 1 2017, 1:22 PM
hctim added inline comments to D39485: Extend SpecialCaseList to allow users to blame matches on entries in the file..
Nov 1 2017, 1:18 PM
hctim updated the diff for D39485: Extend SpecialCaseList to allow users to blame matches on entries in the file..

Fixed line parsing to not ignore blank lines, line number is correctly generated.

Nov 1 2017, 1:18 PM
hctim added a comment to D39486: Update SanitizerSpecialCaseList to use renamed functions in base class..

Why is there a cyclical dependency? D39485 doesn't delete SpecialCaseList::inSection()?

Nov 1 2017, 10:52 AM

Oct 31 2017

hctim added a comment to D39268: Make MCAsmBackend and MCCodeEmiiter passed by unique_ptr rval.

Friendly ping :)

Oct 31 2017, 6:09 PM
hctim edited reviewers for D39486: Update SanitizerSpecialCaseList to use renamed functions in base class., added: vlad.tsyrklevich; removed: kcc.
Oct 31 2017, 6:02 PM
hctim edited reviewers for D39485: Extend SpecialCaseList to allow users to blame matches on entries in the file., added: vlad.tsyrklevich; removed: kcc.
Oct 31 2017, 6:02 PM
hctim committed rL317060: Add test dependency on llvm-cfi-verify to fix up the build breakages on….
Add test dependency on llvm-cfi-verify to fix up the build breakages on…
Oct 31 2017, 5:50 PM
hctim updated the summary of D39485: Extend SpecialCaseList to allow users to blame matches on entries in the file..
Oct 31 2017, 5:40 PM
hctim added a dependency for D39486: Update SanitizerSpecialCaseList to use renamed functions in base class.: D39485: Extend SpecialCaseList to allow users to blame matches on entries in the file..
Oct 31 2017, 5:39 PM
hctim added a dependent revision for D39485: Extend SpecialCaseList to allow users to blame matches on entries in the file.: D39486: Update SanitizerSpecialCaseList to use renamed functions in base class..
Oct 31 2017, 5:39 PM
hctim created D39486: Update SanitizerSpecialCaseList to use renamed functions in base class..
Oct 31 2017, 5:39 PM
hctim created D39485: Extend SpecialCaseList to allow users to blame matches on entries in the file..
Oct 31 2017, 5:35 PM
hctim abandoned D39477: Extend SpecialCaseList to allow users to blame precise entries in the SCL file..
Oct 31 2017, 4:45 PM
hctim committed rL317050: Parse DWARF information to reduce false positives..
Parse DWARF information to reduce false positives.
Oct 31 2017, 4:20 PM
hctim closed D38654: Parse DWARF information to reduce false positives. by committing rL317050: Parse DWARF information to reduce false positives..
Oct 31 2017, 4:20 PM
hctim created D39477: Extend SpecialCaseList to allow users to blame precise entries in the SCL file..
Oct 31 2017, 2:18 PM
hctim updated the diff for D38654: Parse DWARF information to reduce false positives..

Added test where a file contains line table information, but an indirect CF instruction is not covered by the LT information.

Oct 31 2017, 12:15 PM