Page MenuHomePhabricator

hctim (Mitch Phillips)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2017, 3:58 PM (124 w, 1 h)

Recent Activity

Today

hctim committed rGe1440f594c14: [GWP-ASan] Add names to anonymous mappings. (authored by hctim).
[GWP-ASan] Add names to anonymous mappings.
Fri, Jan 24, 3:05 PM
hctim closed D73373: [GWP-ASan] Add names to anonymous mappings..
Fri, Jan 24, 3:05 PM · Restricted Project, Restricted Project
hctim updated the diff for D73373: [GWP-ASan] Add names to anonymous mappings..
  • Merged from master (after enable/disable + fork support by @eugenis).
Fri, Jan 24, 3:05 PM · Restricted Project, Restricted Project
hctim added a comment to D64457: [GWP-ASan] Attempt to fix Android/ARM platforms..

Reviving this a little. check-gwp_asan in my aarch64 crostool now WAI, with some warnings during compilation from ar and ranlib: unsupported GNU_PROPERTY_TYPE (5) type: 0xc0000000. Looks like this is the PAC/BTI properties from D62609, but doesn't really hurt us here.

Fri, Jan 24, 2:55 PM · Restricted Project, Restricted Project
hctim updated the diff for D64457: [GWP-ASan] Attempt to fix Android/ARM platforms..
  • Updates.
Fri, Jan 24, 2:48 PM · Restricted Project, Restricted Project
hctim added a comment to D73373: [GWP-ASan] Add names to anonymous mappings..

AFAIK we do test on android.

Fri, Jan 24, 1:22 PM · Restricted Project, Restricted Project
hctim added a comment to D73373: [GWP-ASan] Add names to anonymous mappings..

Could you add a test?

Fri, Jan 24, 12:55 PM · Restricted Project, Restricted Project
hctim created D73373: [GWP-ASan] Add names to anonymous mappings..
Fri, Jan 24, 11:10 AM · Restricted Project, Restricted Project

Yesterday

hctim accepted D73294: [GWP-ASan] enable/disable and fork support..

LGTM with installAtFork() and cond_wait() comments.

Thu, Jan 23, 5:38 PM · Restricted Project, Restricted Project
hctim added a reviewer for D73305: [gwp-asan] Implement malloc_iterate.: cryptoad.
Thu, Jan 23, 4:49 PM · Restricted Project, Restricted Project
hctim accepted D73305: [gwp-asan] Implement malloc_iterate..
Thu, Jan 23, 4:41 PM · Restricted Project, Restricted Project
hctim added inline comments to D73294: [GWP-ASan] enable/disable and fork support..
Thu, Jan 23, 3:11 PM · Restricted Project, Restricted Project
hctim committed rGe174da447c18: [Clang][IFS][Test] Work around in-process cc1 ASAN issues #2. (authored by hctim).
[Clang][IFS][Test] Work around in-process cc1 ASAN issues #2.
Thu, Jan 23, 2:32 PM
hctim added a comment to D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation.

For tracking purposes.

Thu, Jan 23, 2:31 PM · Restricted Project, Restricted Project
hctim added a comment to rGd1dbb5e4718a: AMDGPU/GlobalISel: Select G_INSERT_VECTOR_ELT.

This patch broke the UBSan build bots here.

Thu, Jan 23, 11:05 AM

Tue, Jan 21

hctim added a comment to D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation.

In the meantime I could -fno-integrated-cc1 the driver.c InterfaceStubs tests to quite the bots if that is what people want (and file a bug on bugzilla).

Tue, Jan 21, 3:18 PM · Restricted Project, Restricted Project
hctim added a comment to D73143: [scudo][standalone] Reduce Android region sizes to 128MB.

This is unfortunately one of those situations where we have to bend to
existing code because we doubt it's going to change any time soon.

Tue, Jan 21, 2:59 PM · Restricted Project, Restricted Project

Mon, Jan 20

hctim committed rGb16f82ad3b09: Revert "[MachO] Add a test for detecting reserved unit length." (authored by hctim).
Revert "[MachO] Add a test for detecting reserved unit length."
Mon, Jan 20, 10:43 PM
hctim added a reverting change for rGfcc08aa835de: [MachO] Add a test for detecting reserved unit length.: rGb16f82ad3b09: Revert "[MachO] Add a test for detecting reserved unit length.".
Mon, Jan 20, 10:43 PM
hctim added a comment to D72695: [MachO] Add a test for detecting reserved unit length..

This test broke the UBSan buildbot here. I've rolled it back for now, but to reproduce the issue should be as simple as adding -DLLVM_USE_SANITIZER=Undefined and running ninja check-lld or make check-lld depending on which tool you use :)

Mon, Jan 20, 10:43 PM · Restricted Project, lld
hctim added a comment to D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer..

This change broke the sanitizer buildbots and was reverted here. Please see here for more information:

Mon, Jan 20, 4:45 PM · Restricted Project
hctim committed rGedd4398f4cd3: Revert "PR17164: Change clang's default behavior from -flax-vector… (authored by hctim).
Revert "PR17164: Change clang's default behavior from -flax-vector…
Mon, Jan 20, 4:37 PM
hctim added a reverting change for rGb72a8c65e4e3: PR17164: Change clang's default behavior from -flax-vector-conversions=all to…: rGedd4398f4cd3: Revert "PR17164: Change clang's default behavior from -flax-vector….
Mon, Jan 20, 4:37 PM
Herald added a project to D49793: [AArch64] - return address signing: Restricted Project.
Mon, Jan 20, 4:36 PM · Restricted Project
hctim added inline comments to D73055: [scudo][standalone] Allow sched_getaffinity to fail.
Mon, Jan 20, 3:42 PM · Restricted Project, Restricted Project

Mon, Jan 13

hctim added a comment to D72470: [scudo][standalone] Fork support.

FWIW I'm ok with this landing in the previous version, disabling GWP-ASan, because its integration in scudo is so broken right now.

Mon, Jan 13, 5:55 PM · Restricted Project, Restricted Project

Sun, Jan 12

hctim added a comment to D72546: Scudo tests with GWP-ASan..

Oh, also, would you mind please updating the commit message to mention that this change adds enable/disable support, and fork protections? Thanks!

Sun, Jan 12, 9:06 PM · Restricted Project, Restricted Project
hctim added a comment to D72546: Scudo tests with GWP-ASan..

Thanks for doing this.

Sun, Jan 12, 8:30 PM · Restricted Project, Restricted Project

Tue, Jan 7

hctim added inline comments to D72364: [scudo][standalone] Modify malloc_{enable,disable} wrt fork.
Tue, Jan 7, 4:09 PM · Restricted Project, Restricted Project
hctim added inline comments to D72364: [scudo][standalone] Modify malloc_{enable,disable} wrt fork.
Tue, Jan 7, 3:23 PM · Restricted Project, Restricted Project

Dec 23 2019

hctim added inline comments to D70762: scudo: Add initial memory tagging support..
Dec 23 2019, 10:10 AM · Restricted Project, Restricted Project

Dec 18 2019

hctim committed rGb19d87b16f81: Revert "Add an -fno-temp-file flag for compilation" (authored by hctim).
Revert "Add an -fno-temp-file flag for compilation"
Dec 18 2019, 9:07 AM
hctim added a reverting change for rGd129aa1d5369: Add an -fno-temp-file flag for compilation: rGb19d87b16f81: Revert "Add an -fno-temp-file flag for compilation".
Dec 18 2019, 9:07 AM
hctim added a comment to D70615: Add an -fno-temp-file flag for compilation.

This change broke the sanitizer buildbots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/37446

Dec 18 2019, 9:07 AM · Restricted Project
hctim committed rG2f4c3c565a34: [NFC] Fix sanitizer lint problem that's breaking Android bot. (authored by hctim).
[NFC] Fix sanitizer lint problem that's breaking Android bot.
Dec 18 2019, 8:52 AM
hctim added a comment to rGe14ff22694c2: [compiler-rt] Sync NetBSD ioctl definitions with 9.99.26.

Fyi - slight lint bug introduced here, fixed in 2f4c3c565a34b2c30fb883c85acbf4114b455c26.

Dec 18 2019, 8:52 AM

Dec 17 2019

hctim committed rGf827aff85988: Revert "[ MC ] Match labels to existing fragments even when switching sections." (authored by hctim).
Revert "[ MC ] Match labels to existing fragments even when switching sections."
Dec 17 2019, 3:06 PM
hctim added inline comments to D71368: [ MC ] Match labels to existing fragments even when switching sections..
Dec 17 2019, 3:06 PM · Restricted Project
hctim added a reverting change for rG4272372c571c: [ MC ] Match labels to existing fragments even when switching sections.: rGf827aff85988: Revert "[ MC ] Match labels to existing fragments even when switching sections.".
Dec 17 2019, 3:06 PM
hctim committed rG2423774cc2a0: Revert "Honor -fuse-init-array when os is not specified on x86" (authored by hctim).
Revert "Honor -fuse-init-array when os is not specified on x86"
Dec 17 2019, 7:39 AM
hctim added a reverting change for rGaa5ee8f24444: Honor -fuse-init-array when os is not specified on x86: rG2423774cc2a0: Revert "Honor -fuse-init-array when os is not specified on x86".
Dec 17 2019, 7:39 AM
hctim added a comment to D71360: Honor -fuse-init-array when os is not specified on x86.

Reverted in 2423774cc2a040d34d32aacaf261805cb195ebd2 due to breaking the sanitizer buildbots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/37410

Dec 17 2019, 7:39 AM · Restricted Project

Dec 16 2019

hctim planned changes to D71497: [GWP-ASan] Add in-proc/out-of-proc crash handler interface..
Dec 16 2019, 1:40 PM · Restricted Project, Restricted Project

Dec 13 2019

hctim created D71497: [GWP-ASan] Add in-proc/out-of-proc crash handler interface..
Dec 13 2019, 4:40 PM · Restricted Project, Restricted Project
hctim committed rGd6c445ea6907: [NFC] Guard scudo_standalone's optional dependency on GWP-ASan behind flags. (authored by hctim).
[NFC] Guard scudo_standalone's optional dependency on GWP-ASan behind flags.
Dec 13 2019, 11:01 AM
hctim committed rGa00cd6dfea9f: [GWP-ASan] [Scudo] ifdef entire GWP-ASan tests. (authored by hctim).
[GWP-ASan] [Scudo] ifdef entire GWP-ASan tests.
Dec 13 2019, 9:48 AM
hctim committed rGed4618edb356: [Scudo] [GWP-ASan] Add GWP-ASan to Scudo Standalone. (authored by hctim).
[Scudo] [GWP-ASan] Add GWP-ASan to Scudo Standalone.
Dec 13 2019, 9:20 AM
hctim closed D71229: [Scudo] [GWP-ASan] Add GWP-ASan to Scudo Standalone..
Dec 13 2019, 9:20 AM · Restricted Project, Restricted Project

Dec 11 2019

hctim accepted D71285: [fuzzer] Add basic support for emscripten..
Dec 11 2019, 7:44 AM · Restricted Project, Restricted Project

Dec 10 2019

hctim updated the diff for D71229: [Scudo] [GWP-ASan] Add GWP-ASan to Scudo Standalone..
  • Enforce alignment to GWP-ASan. If userspace calls posix_memalign, this alignment guarantee should be kept even if the allocation is chosen to be sampled.
Dec 10 2019, 5:23 PM · Restricted Project, Restricted Project
hctim added inline comments to D71285: [fuzzer] Add basic support for emscripten..
Dec 10 2019, 1:51 PM · Restricted Project, Restricted Project
hctim updated the diff for D71229: [Scudo] [GWP-ASan] Add GWP-ASan to Scudo Standalone..
  • Guard isOwned behind macro.
Dec 10 2019, 9:32 AM · Restricted Project, Restricted Project
hctim added inline comments to D71229: [Scudo] [GWP-ASan] Add GWP-ASan to Scudo Standalone..
Dec 10 2019, 9:32 AM · Restricted Project, Restricted Project
hctim accepted D71223: [scudo][standalone] Define hasHardwareCRC32 for other archs.
Dec 10 2019, 7:42 AM · Restricted Project, Restricted Project

Dec 9 2019

hctim added a comment to D71229: [Scudo] [GWP-ASan] Add GWP-ASan to Scudo Standalone..

What's the current plan for testing? (Currently I have only enabled the standalone on Linux x86/64 for upstream)

Dec 9 2019, 4:39 PM · Restricted Project, Restricted Project
hctim updated the diff for D71229: [Scudo] [GWP-ASan] Add GWP-ASan to Scudo Standalone..
  • Synced to master, added isOwned and /s/size_t/uptr.
Dec 9 2019, 4:38 PM · Restricted Project, Restricted Project
hctim created D71229: [Scudo] [GWP-ASan] Add GWP-ASan to Scudo Standalone..
Dec 9 2019, 2:44 PM · Restricted Project, Restricted Project
hctim accepted D71148: [hwasan] Offline symbolization script..

LGTM with a couple comments

Dec 9 2019, 9:28 AM · Restricted Project, Restricted Project
hctim committed rG26fd95680bcf: [GWP-ASan] 32-bit test pointers, allow multi-init for test. (authored by hctim).
[GWP-ASan] 32-bit test pointers, allow multi-init for test.
Dec 9 2019, 8:24 AM
hctim closed D71121: [GWP-ASan] 32-bit test pointers, allow multi-init for test..
Dec 9 2019, 8:24 AM · Restricted Project, Restricted Project
hctim accepted D71104: scudo: Add a basic malloc/free benchmark..
Dec 9 2019, 8:15 AM · Restricted Project, Restricted Project

Dec 6 2019

hctim added inline comments to D71148: [hwasan] Offline symbolization script..
Dec 6 2019, 2:25 PM · Restricted Project, Restricted Project
hctim added inline comments to D71148: [hwasan] Offline symbolization script..
Dec 6 2019, 2:25 PM · Restricted Project, Restricted Project
hctim added inline comments to D71104: scudo: Add a basic malloc/free benchmark..
Dec 6 2019, 12:06 PM · Restricted Project, Restricted Project
hctim created D71121: [GWP-ASan] 32-bit test pointers, allow multi-init for test..
Dec 6 2019, 8:01 AM · Restricted Project, Restricted Project
hctim added inline comments to D71104: scudo: Add a basic malloc/free benchmark..
Dec 6 2019, 7:53 AM · Restricted Project, Restricted Project
hctim added inline comments to D71104: scudo: Add a basic malloc/free benchmark..
Dec 6 2019, 7:24 AM · Restricted Project, Restricted Project

Dec 4 2019

hctim planned changes to D70681: [GWP-ASan] Implementation of crash handler API..

The third seems like it might be exposing internals we don't want to expose and potentially lead to versioning issues.

Dec 4 2019, 11:19 AM · Restricted Project, Restricted Project

Dec 2 2019

hctim accepted D70908: [scudo][standalone] Add chunk ownership function.

I think that not claiming ownership of a corrupted chunk is something we can live with.
The ownership concept for tcmalloc has strong requirements, which I think are fulfilled by this implementation.

Dec 2 2019, 1:30 PM · Restricted Project, Restricted Project
hctim added a comment to D70908: [scudo][standalone] Add chunk ownership function.

So the model presented asserts that if the chunk header is truncated, the pointer is not owned by us. Is this WAI? I can forsee that a chunk header was truncated, and then the pointer to the associated allocation is checked for ownership, which the ownership will fail as the chunk header check didn't succeed.

Dec 2 2019, 11:47 AM · Restricted Project, Restricted Project

Nov 27 2019

hctim added a comment to D70762: scudo: Add initial memory tagging support..

The granules
either side of the allocation are tagged with tag 0, which is normally
excluded from the set of tags that may be selected randomly

Nov 27 2019, 2:00 PM · Restricted Project, Restricted Project
hctim added inline comments to D70762: scudo: Add initial memory tagging support..
Nov 27 2019, 1:49 PM · Restricted Project, Restricted Project
hctim added inline comments to D70762: scudo: Add initial memory tagging support..
Nov 27 2019, 12:37 PM · Restricted Project, Restricted Project
hctim planned changes to D64457: [GWP-ASan] Attempt to fix Android/ARM platforms..

Can this be abandoned? Looks stale.

Nov 27 2019, 12:37 PM · Restricted Project, Restricted Project
hctim added inline comments to D70762: scudo: Add initial memory tagging support..
Nov 27 2019, 11:13 AM · Restricted Project, Restricted Project

Nov 26 2019

hctim accepted D70682: [scudo][standalone] Make tests work on Fuchsia.
Nov 26 2019, 10:12 AM · Restricted Project, Restricted Project

Nov 25 2019

hctim added inline comments to D70682: [scudo][standalone] Make tests work on Fuchsia.
Nov 25 2019, 3:33 PM · Restricted Project, Restricted Project
hctim added inline comments to D70682: [scudo][standalone] Make tests work on Fuchsia.
Nov 25 2019, 2:56 PM · Restricted Project, Restricted Project
hctim committed rG19edfb37282a: [GWP-ASan] Add GWP_ASAN_ prefix to macros. (authored by hctim).
[GWP-ASan] Add GWP_ASAN_ prefix to macros.
Nov 25 2019, 12:28 PM
hctim closed D70683: [GWP-ASan] Add GWP_ASAN_ prefix to macros..
Nov 25 2019, 12:28 PM · Restricted Project, Restricted Project
hctim added inline comments to D70682: [scudo][standalone] Make tests work on Fuchsia.
Nov 25 2019, 11:04 AM · Restricted Project, Restricted Project
hctim added inline comments to D70682: [scudo][standalone] Make tests work on Fuchsia.
Nov 25 2019, 10:54 AM · Restricted Project, Restricted Project
hctim created D70683: [GWP-ASan] Add GWP_ASAN_ prefix to macros..
Nov 25 2019, 10:34 AM · Restricted Project, Restricted Project
hctim created D70681: [GWP-ASan] Implementation of crash handler API..
Nov 25 2019, 10:17 AM · Restricted Project, Restricted Project
hctim accepted D70552: [scudo][standalone] Fix for releaseToOS prior to init.
Nov 25 2019, 8:28 AM · Restricted Project, Restricted Project

Nov 21 2019

hctim added inline comments to D70452: [scudo][standalone] Minor optimization & improvements.
Nov 21 2019, 9:19 AM · Restricted Project, Restricted Project
hctim accepted D70452: [scudo][standalone] Minor optimization & improvements.

Other than that, LGTM

Nov 21 2019, 9:01 AM · Restricted Project, Restricted Project
hctim added inline comments to D70452: [scudo][standalone] Minor optimization & improvements.
Nov 21 2019, 9:01 AM · Restricted Project, Restricted Project

Nov 14 2019

hctim accepted D70276: [scudo][standalone] Enabled SCUDO_DEBUG for tests + fixes.
Nov 14 2019, 3:04 PM · Restricted Project, Restricted Project

Nov 12 2019

hctim accepted D69593: [libFuzzer] don't use /dev/null for DiscardOuput in Fuchsia..

Ping :)

Nov 12 2019, 1:43 PM · Restricted Project, Restricted Project

Nov 7 2019

hctim committed rZORG53b0602b58d2: Remove error in additional '(' that was placed in previous patch. (authored by hctim).
Remove error in additional '(' that was placed in previous patch.
Nov 7 2019, 8:00 AM
hctim committed rG343597789eba: [GWP-ASan] Respect compiler-rt's -fno-lto (authored by hctim).
[GWP-ASan] Respect compiler-rt's -fno-lto
Nov 7 2019, 7:50 AM
hctim committed rZORG750be2533627: Conditionally build LLD for sanitizer bots. (authored by hctim).
Conditionally build LLD for sanitizer bots.
Nov 7 2019, 7:23 AM

Nov 6 2019

hctim committed rZORG7b38316441a5: Add LLD to slow builder sanitizer bot. (authored by hctim).
Add LLD to slow builder sanitizer bot.
Nov 6 2019, 4:47 PM

Oct 28 2019

hctim committed rG2513250be336: [scudo][standalone] Lists fix (authored by cryptoad).
[scudo][standalone] Lists fix
Oct 28 2019, 3:30 PM
hctim closed D69529: [scudo][standalone] Lists fix.
Oct 28 2019, 3:30 PM · Restricted Project, Restricted Project
hctim accepted D69529: [scudo][standalone] Lists fix.
Oct 28 2019, 1:39 PM · Restricted Project, Restricted Project
hctim committed rG6f2de9cbb37f: [scudo][standalone] Consolidate lists (authored by cryptoad).
[scudo][standalone] Consolidate lists
Oct 28 2019, 9:35 AM
hctim closed D69516: [scudo][standalone] Consolidate lists.
Oct 28 2019, 9:35 AM · Restricted Project, Restricted Project
hctim accepted D69516: [scudo][standalone] Consolidate lists.

LGTM - review done in D69265

Oct 28 2019, 9:01 AM · Restricted Project, Restricted Project