Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

hctim (Mitch Phillips)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2017, 3:58 PM (316 w, 5 d)

Recent Activity

Fri, Sep 15

hctim committed rG79e96b2457fe: Fix-forward a -Wconversion scudo bug. (authored by hctim).
Fix-forward a -Wconversion scudo bug.
Fri, Sep 15, 10:14 AM · Restricted Project, Restricted Project

Aug 14 2023

hctim added a comment to D150262: Disable sanitizer's on ifunc resolvers..

ok, I can land it too, no worries.

Aug 14 2023, 6:06 AM · Restricted Project, Restricted Project
hctim added a comment to D150262: Disable sanitizer's on ifunc resolvers..

Peter's out of office. This patch looks fine to me, and I'll land it for you.

Aug 14 2023, 6:01 AM · Restricted Project, Restricted Project

Aug 3 2023

hctim added a comment to D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases.

Hi folks,

Aug 3 2023, 7:57 AM · Restricted Project, Restricted Project

Jul 31 2023

hctim committed rGca35a19acab1: [lld] Synthesize metadata for MTE globals (authored by hctim).
[lld] Synthesize metadata for MTE globals
Jul 31 2023, 8:08 AM · Restricted Project
hctim closed D152921: [lld] Synthesize metadata for MTE globals.
Jul 31 2023, 8:08 AM · Restricted Project, Restricted Project
hctim updated the diff for D152921: [lld] Synthesize metadata for MTE globals.

Final updates.

Jul 31 2023, 7:52 AM · Restricted Project, Restricted Project
hctim added inline comments to D152921: [lld] Synthesize metadata for MTE globals.
Jul 31 2023, 7:52 AM · Restricted Project, Restricted Project

Jul 25 2023

hctim updated the diff for D152921: [lld] Synthesize metadata for MTE globals.

More comment updates.

Jul 25 2023, 7:42 AM · Restricted Project, Restricted Project
hctim added inline comments to D152921: [lld] Synthesize metadata for MTE globals.
Jul 25 2023, 7:42 AM · Restricted Project, Restricted Project

Jul 24 2023

hctim added inline comments to D152921: [lld] Synthesize metadata for MTE globals.
Jul 24 2023, 8:09 AM · Restricted Project, Restricted Project
hctim updated the diff for D152921: [lld] Synthesize metadata for MTE globals.

Update with comments from Ray.

Jul 24 2023, 8:09 AM · Restricted Project, Restricted Project

Jul 20 2023

hctim added a comment to D150044: [libc++][print] Adds FILE functions..
$ lldb /home/mitchp/build/libcxx_build_msan/test/std/input.output/iostream.format/print.fun/Output/vprint_nonunicode.file.pass.cpp.dir/t.tmp.exe
(lldb) target create "/home/mitchp/build/libcxx_build_msan/test/std/input.output/iostream.format/print.fun/Output/vprint_nonunicode.file.pass.cpp.dir/t.tmp.exe"                                            Current executable set to '/home/mitchp/build/libcxx_build_msan/test/std/input.output/iostream.format/print.fun/Output/vprint_nonunicode.file.pass.cpp.dir/t.tmp.exe' (aarch64).                            (lldb) r
Process 737940 launched: '/home/mitchp/build/libcxx_build_msan/test/std/input.output/iostream.format/print.fun/Output/vprint_nonunicode.file.pass.cpp.dir/t.tmp.exe' (aarch64)
Process 737940 stopped and restarted: thread 1 received signal: SIGCHLD
libc++abi: terminating due to uncaught exception of type std::__1::format_error: Argument index out of bounds
Process 737940 stopped
* thread #1, name = 't.tmp.exe', stop reason = signal SIGABRT
    frame #0: 0x0000fffff7ac7eac libc.so.6`__GI_raise(sig=6) at raise.c:51:1
(lldb) bt
* thread #1, name = 't.tmp.exe', stop reason = signal SIGABRT
  * frame #0: 0x0000fffff7ac7eac libc.so.6`__GI_raise(sig=6) at raise.c:51:1
    frame #1: 0x0000fffff7ab4aa0 libc.so.6`__GI_abort at abort.c:79:7
    frame #2: 0x0000fffff7dd4948 libc++abi.so.1`abort_message at abort_message.cpp:78:5
    frame #3: 0x0000fffff7d8a1f0 libc++abi.so.1`::demangling_terminate_handler() at cxa_default_handlers.cpp:72:9
    frame #4: 0x0000fffff7dd3138 libc++abi.so.1`std::__terminate(void (*)()) at cxa_handlers.cpp:59:9
    frame #5: 0x0000fffff7dda23c libc++abi.so.1`__cxxabiv1::failed_throw(__cxxabiv1::__cxa_exception*) at cxa_exception.cpp:152:5
    frame #6: 0x0000fffff7dda168 libc++abi.so.1`::__cxa_throw() at cxa_exception.cpp:283:5
    frame #7: 0x0000aaaaaabdbfac t.tmp.exe`std::__1::__throw_format_error[abi:v170000](__s="Argument index out of bounds") at format_error.h:41:3
    frame #8: 0x0000aaaaaabdf058 t.tmp.exe`auto char const* std::__1::__format::__handle_replacement_field[abi:v170000]<char const*, std::__1::basic_format_parse_context<char>, std::__1::basic_format_cont
ext<std::__1::back_insert_iterator<std::__1::__format::__output_buffer<char>>, char>>(this=0x0000ffffffffe0c0, __arg=monostate @ 0x0000ffffffffdeaf)::'lambda'(char const*)::operator()<std::__1::monostate>
(char const*) const at format_functions.h:274:13
    frame #9: 0x0000aaaaaabdefe8 t.tmp.exe`decltype(std::declval<char const*>()(std::declval<std::__1::monostate&>())) std::__1::__invoke[abi:v170000]<char const* std::__1::__format::__handle_replacement_
field[abi:v170000]<char const*, std::__1::basic_format_parse_context<char>, std::__1::basic_format_context<std::__1::back_insert_iterator<std::__1::__format::__output_buffer<char>>, char>>(char const*, ch
ar const*, std::__1::basic_format_parse_context<char>&, std::__1::basic_format_context<std::__1::back_insert_iterator<std::__1::__format::__output_buffer<char>>, char>&)::'lambda'(char const*), std::__1::
monostate&>(__f=0x0000ffffffffe0c0, __args=0x0000ffffffffe0a0) at invoke.h:340:25
    frame #10: 0x0000aaaaaabde430 t.tmp.exe`std::__1::invoke_result<char const*, std::__1::monostate&>::type std::__1::invoke[abi:v170000]<char const* std::__1::__format::__handle_replacement_field[abi:v1
70000]<char const*, std::__1::basic_format_parse_context<char>, std::__1::basic_format_context<std::__1::back_insert_iterator<std::__1::__format::__output_buffer<char>>, char>>(char const*, char const*, s
td::__1::basic_format_parse_context<char>&, std::__1::basic_format_context<std::__1::back_insert_iterator<std::__1::__format::__output_buffer<char>>, char>&)::'lambda'(char const*), std::__1::monostate&>(
__f=0x0000ffffffffe0c0, __args=0x0000ffffffffe0a0) at invoke.h:30:12
    frame #11: 0x0000aaaaaabdcfa0 t.tmp.exe`decltype(auto) std::__1::__visit_format_arg[abi:v170000]<char const* std::__1::__format::__handle_replacement_field[abi:v170000]<char const*, std::__1::basic_fo
rmat_parse_context<char>, std::__1::basic_format_context<std::__1::back_insert_iterator<std::__1::__format::__output_buffer<char>>, char>>(char const*, char const*, std::__1::basic_format_parse_context<ch
ar>&, std::__1::basic_format_context<std::__1::back_insert_iterator<std::__1::__format::__output_buffer<char>>, char>&)::'lambda'(char const*), std::__1::basic_format_context<std::__1::back_insert_iterato
r<std::__1::__format::__output_buffer<char>>, char>>(__vis=0x0000ffffffffe0c0, __arg=basic_format_arg<std::__1::basic_format_context<std::__1::back_insert_iterator<std::__1::__format::__output_buffer<char
> >, char> > @ 0x0000ffffffffe0a0) at format_arg.h:103:12
    frame #12: 0x0000aaaaaabdc404 t.tmp.exe`char const* std::__1::__format::__handle_replacement_field[abi:v170000]<char const*, std::__1::basic_format_parse_context<char>, std::__1::basic_format_context<
std::__1::back_insert_iterator<std::__1::__format::__output_buffer<char>>, char>>(__begin="}", __end="", __parse_ctx=0x0000ffffffffe408, __ctx=0x0000ffffffffe3c8) at format_functions.h:271:5
    frame #13: 0x0000aaaaaabd7ddc t.tmp.exe`std::__1::basic_format_context<std::__1::back_insert_iterator<std::__1::__format::__output_buffer<char>>, char>::iterator std::__1::__format::__vformat_to[abi:v
170000]<std::__1::basic_format_parse_context<char>, std::__1::basic_format_context<std::__1::back_insert_iterator<std::__1::__format::__output_buffer<char>>, char>>(__parse_ctx=0x0000ffffffffe408, __ctx=0
x0000ffffffffe3c8) at format_functions.h:312:13
    frame #14: 0x0000aaaaaabd7738 t.tmp.exe`std::__1::back_insert_iterator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>> std::__1::__vformat_to[abi:v170000]<std::__1::back_insert_iterator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>, char, std::__1::back_insert_iterator<std::__1::__format::__output_buffer<char>>>(__out_it=(container = ""), __fmt="hello {}", __args=basic_format_args<std::__1::basic_format_context<std::__1::back_insert_iterator<std::__1::__format::__output_buffer<char> >, char> > @ 0x0000ffffffffe808) at format_functions.h:387:5
    frame #15: 0x0000aaaaaabd6ee4 t.tmp.exe`void std::__1::__print::__vprint_nonunicode[abi:v170000]<void>(_IO_FILE*, std::__1::basic_string_view<char, std::__1::char_traits<char>>, std::__1::basic_format_args<std::__1::basic_format_context<std::__1::back_insert_iterator<std::__1::__format::__output_buffer<char>>, char>>, bool) [inlined] std::__1::back_insert_iterator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>> std::__1::vformat_to[abi:v170000]<std::__1::back_insert_iterator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>>(__out_it=(container = ""), __fmt="hello {}", __args=std::__1::format_args @ 0x0000ffffffffe7a0) at format_functions.h:399:10
    frame #16: 0x0000aaaaaabd6e5c t.tmp.exe`void std::__1::__print::__vprint_nonunicode[abi:v170000]<void>(_IO_FILE*, std::__1::basic_string_view<char, std::__1::char_traits<char>>, std::__1::basic_format_args<std::__1::basic_format_context<std::__1::back_insert_iterator<std::__1::__format::__output_buffer<char>>, char>>, bool) [inlined] std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> std::__1::vformat[abi:v170000]<void>(__fmt="hello {}", __args=std::__1::format_args @ 0x0000ffffffffe730) at format_functions.h:432:3
    frame #17: 0x0000aaaaaabd6d3c t.tmp.exe`void std::__1::__print::__vprint_nonunicode[abi:v170000]<void>(__stream=0x0000e14000000000, __fmt="hello {}", __args=std::__1::format_args @ 0x0000ffffffffe8c8, __write_nl=false) at print:208:18
    frame #18: 0x0000aaaaaabd6850 t.tmp.exe`void std::__1::vprint_nonunicode[abi:v170000]<void>(__stream=0x0000e14000000000, __fmt="hello {}", __args=std::__1::format_args @ 0x0000ffffffffea38) at print:355:3
    frame #19: 0x0000aaaaaabc1510 t.tmp.exe`auto $_1::operator()<>(this=0x0000fffffffff2f6, what="Argument index out of bounds", fmt="hello {}") const at vprint_nonunicode.file.pass.cpp:57:3
    frame #20: 0x0000aaaaaabbb3f0 t.tmp.exe`void print_tests<$_0, $_1>(check=(unnamed class) @ 0x0000fffffffff2f7, check_exception=(unnamed class) @ 0x0000fffffffff2f6) at print_tests.h:78:3
    frame #21: 0x0000aaaaaabb9d9c t.tmp.exe`main((null)=1, (null)=0x0000fffffffff4e8) at vprint_nonunicode.file.pass.cpp:134:3
    frame #22: 0x0000fffff7ab4e18 libc.so.6`__libc_start_main(main=(t.tmp.exe`main at vprint_nonunicode.file.pass.cpp:133), argc=1, argv=0x0000fffffffff4e8, init=<unavailable>, fini=<unavailable>, rtld_fini=<unavailable>, stack_end=<unavailable>) at libc-start.c:308:16
    frame #23: 0x0000aaaaaab31df4 t.tmp.exe`_start + 52
Jul 20 2023, 10:37 AM · Restricted Project, Restricted Project
hctim added a comment to D150044: [libc++][print] Adds FILE functions..

I indeed only turned of msan, doing it for asan and hwsan is trivial. Are the other sanitizers that fail?

Jul 20 2023, 9:09 AM · Restricted Project, Restricted Project
hctim added a comment to D150044: [libc++][print] Adds FILE functions..

Thanks! It's a bit tricky to find the proper flags to only disable it on aarch64 with msan. Instead I'll disable it for all msan builds.

Jul 20 2023, 7:54 AM · Restricted Project, Restricted Project

Jul 19 2023

hctim added a comment to D150044: [libc++][print] Adds FILE functions..

Unfortunately I can't reproduce it locally (Linux x86_64). I see https://lab.llvm.org/buildbot/#/builders/74 the x86_64 msan buildbot is happy but the aarch64. The exception in the logs is thrown in the test, but it seems it's not caught. Is it possible to see where the exception is thrown? Or can I get access to the buildbot to run some tests?

Jul 19 2023, 10:13 AM · Restricted Project, Restricted Project
hctim added a comment to D150044: [libc++][print] Adds FILE functions..

Edit: May have misattributed this due to changes in vprint files, but I'm bisecting now. There were ~4 other libcxx changes that I'm not 100% confident this is the culprit.

Jul 19 2023, 3:24 AM · Restricted Project, Restricted Project
hctim added a comment to D153911: [cmake] Add -Wcast-qual to C flags if LLVM_ENABLE_WARNINGS is defined..

Hi, we're still seeing sanitizer buildbot failures from what I assume is this patch.

Jul 19 2023, 3:18 AM · Restricted Project, Restricted Project

Jul 18 2023

hctim added a comment to D152921: [lld] Synthesize metadata for MTE globals.

Friendly ping @MaskRay

Jul 18 2023, 9:24 AM · Restricted Project, Restricted Project
hctim added a reverting change for rG31263211c6a4: [sanitizer][asan][win] Intercept _strdup on Windows instead of strdup: rG03dc87e93937: Revert "[sanitizer][asan][win] Intercept _strdup on Windows instead of strdup".
Jul 18 2023, 3:21 AM · Restricted Project, Restricted Project
hctim committed rG03dc87e93937: Revert "[sanitizer][asan][win] Intercept _strdup on Windows instead of strdup" (authored by hctim).
Revert "[sanitizer][asan][win] Intercept _strdup on Windows instead of strdup"
Jul 18 2023, 3:21 AM · Restricted Project, Restricted Project

Jul 17 2023

hctim added a comment to D154917: [Attributor] Replace AAReturnedValues with AAPotentialValuesReturned.

Hi Johannes, looks like this broke the UBSan buildbot: https://lab.llvm.org/buildbot/#/builders/85/builds/17728/steps/13/logs/stdio

Jul 17 2023, 2:35 PM · Restricted Project, Restricted Project
hctim added a comment to D155317: [ubsan] Disable sigaction.cpp on ubsan-tsan .

Hey @Caslyn, looks like this unfortunately didn't fix the buildbot breakage caused by https://reviews.llvm.org/D155272, I still see UBSan-ThreadSanitizer-aarch64 :: TestCases/Misc/Linux/sigaction.cpp broken at head (https://lab.llvm.org/buildbot/#/builders/238/builds/4398).

Jul 17 2023, 1:01 AM · Restricted Project, Restricted Project

Jul 13 2023

hctim updated the diff for D152921: [lld] Synthesize metadata for MTE globals.

Move to '-' from '-1 *'

Jul 13 2023, 12:35 AM · Restricted Project, Restricted Project

Jul 12 2023

hctim added inline comments to D152921: [lld] Synthesize metadata for MTE globals.
Jul 12 2023, 7:17 AM · Restricted Project, Restricted Project
hctim updated the diff for D152921: [lld] Synthesize metadata for MTE globals.

Update w/ Ray's comments.

Jul 12 2023, 7:16 AM · Restricted Project, Restricted Project

Jul 10 2023

hctim added inline comments to D152921: [lld] Synthesize metadata for MTE globals.
Jul 10 2023, 2:32 AM · Restricted Project, Restricted Project
hctim updated the diff for D152921: [lld] Synthesize metadata for MTE globals.

Update from comments.

Jul 10 2023, 2:32 AM · Restricted Project, Restricted Project

Jul 7 2023

hctim updated the diff for D152921: [lld] Synthesize metadata for MTE globals.

Update from Peter's test comments.

Jul 7 2023, 2:27 AM · Restricted Project, Restricted Project
hctim added inline comments to D152921: [lld] Synthesize metadata for MTE globals.
Jul 7 2023, 2:27 AM · Restricted Project, Restricted Project

Jun 29 2023

hctim updated the diff for D152921: [lld] Synthesize metadata for MTE globals.

Update from Peter's comments (thanks for the review!).

Jun 29 2023, 6:03 AM · Restricted Project, Restricted Project
hctim added inline comments to D152921: [lld] Synthesize metadata for MTE globals.
Jun 29 2023, 6:02 AM · Restricted Project, Restricted Project

Jun 22 2023

hctim added a reverting change for rG9246df7049b0: Revert "Revert "[LLD][ELF] Cortex-M Security Extensions (CMSE) Support"": rGcd116e046034: Revert "Revert "Revert "[LLD][ELF] Cortex-M Security Extensions (CMSE)….
Jun 22 2023, 5:34 AM · Restricted Project
hctim committed rGcd116e046034: Revert "Revert "Revert "[LLD][ELF] Cortex-M Security Extensions (CMSE)… (authored by hctim).
Revert "Revert "Revert "[LLD][ELF] Cortex-M Security Extensions (CMSE)…
Jun 22 2023, 5:34 AM · Restricted Project
hctim added a comment to D139092: [LLD][ELF] Cortex-M Security Extensions (CMSE) Support.

Hi folks,

Jun 22 2023, 5:33 AM · Restricted Project, Restricted Project

Jun 21 2023

hctim added a reverting change for rGbba2b6561102: [mlir][RunnerUtils] Make symbols private + implement loading mechanism.: rG3c3ebebca2b7: Revert "[mlir][RunnerUtils] Make symbols private + implement loading mechanism.".
Jun 21 2023, 4:03 PM · Restricted Project, Restricted Project
hctim committed rG3c3ebebca2b7: Revert "[mlir][RunnerUtils] Make symbols private + implement loading mechanism." (authored by hctim).
Revert "[mlir][RunnerUtils] Make symbols private + implement loading mechanism."
Jun 21 2023, 4:03 PM · Restricted Project, Restricted Project
hctim added a reverting change for D153250: [mlir][RunnerUtils] Make symbols private + implement loading mechanism.: rG3c3ebebca2b7: Revert "[mlir][RunnerUtils] Make symbols private + implement loading mechanism.".
Jun 21 2023, 4:03 PM · Restricted Project, Restricted Project
hctim added a comment to D153250: [mlir][RunnerUtils] Make symbols private + implement loading mechanism..

Hi folks, I did a bisect and unfortunately this broke the HWASan buildbot. It only showed up on the build after yours because your patch was included in a set that was broken for other reasons. https://lab.llvm.org/buildbot/#/builders/236/builds/4911

Jun 21 2023, 3:25 PM · Restricted Project, Restricted Project

Jun 20 2023

hctim added a comment to D150870: [lld][Arm] Big Endian - Byte invariant support..

Hi, looks like this broke the sanitizer buildbots: https://lab.llvm.org/buildbot/#/builders/5/builds/34555/steps/10/logs/stdio

Jun 20 2023, 9:26 AM · Restricted Project, Restricted Project

Jun 15 2023

hctim accepted D152984: [scudo] Disable OddEvenTags by default..

Yeah, I agree.

Jun 15 2023, 1:45 AM · Restricted Project, Restricted Project

Jun 14 2023

hctim added reviewers for D152921: [lld] Synthesize metadata for MTE globals: pcc, eugenis.
Jun 14 2023, 7:38 AM · Restricted Project, Restricted Project
hctim requested review of D152921: [lld] Synthesize metadata for MTE globals.
Jun 14 2023, 7:37 AM · Restricted Project, Restricted Project

Jun 12 2023

hctim accepted D152760: [test][sanitizer] Add ArrayRef tests.
Jun 12 2023, 10:24 PM · Restricted Project, Restricted Project
hctim added a comment to D152760: [test][sanitizer] Add ArrayRef tests.

Looks good to me. Have you considered adding a quick and dirty fuzz target (e.g. compiler-rt/tools/gwp_asan/options_parser_fuzzer.cpp)?

Jun 12 2023, 10:24 PM · Restricted Project, Restricted Project
hctim accepted D152188: [scudo] Detach the hooks from Scudo's internal implementation.

LGTM

Jun 12 2023, 10:15 AM · Restricted Project, Restricted Project

May 26 2023

hctim added a comment to D146987: [Assignment Tracking] Enable by default.

Hey, found another error that occurs when building Android that looks to be different from @MaskRay's revert.

May 26 2023, 5:15 AM · Restricted Project, Restricted Project, debug-info

May 17 2023

hctim updated the diff for D150742: [HWASan] Ignore shortgranules for global tag selection.

Update from Vitaly's comments.

May 17 2023, 5:05 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D150742: [HWASan] Ignore shortgranules for global tag selection.

Can you update some test?

May 17 2023, 5:05 PM · Restricted Project, Restricted Project, Restricted Project

May 16 2023

hctim requested review of D150742: [HWASan] Ignore shortgranules for global tag selection.
May 16 2023, 5:47 PM · Restricted Project, Restricted Project, Restricted Project

May 15 2023

hctim accepted D150262: Disable sanitizer's on ifunc resolvers..

Looks good to me, but I'd like @pcc to also confirm.

May 15 2023, 1:10 PM · Restricted Project, Restricted Project

Apr 26 2023

hctim accepted D149311: [gwp_asan] Exclude recoverable tests on Fuchsia.

LGTM w/ nit

Apr 26 2023, 5:09 PM · Restricted Project, Restricted Project

Apr 18 2023

hctim accepted D147189: [gwp_asan] Employ EXPECT_DEATH for zxtest compatibility.

LGTM w/ nit.

Apr 18 2023, 2:44 PM · Restricted Project, Restricted Project

Apr 12 2023

hctim committed rG7c1a6319ca03: [MTE] [llvm-readobj] Add globals section parsing to --memtag (authored by hctim).
[MTE] [llvm-readobj] Add globals section parsing to --memtag
Apr 12 2023, 10:25 AM · Restricted Project, Restricted Project
hctim added inline comments to D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag.
Apr 12 2023, 10:24 AM · Restricted Project, Restricted Project
hctim closed D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag.
Apr 12 2023, 10:24 AM · Restricted Project, Restricted Project

Apr 10 2023

hctim added inline comments to D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag.
Apr 10 2023, 2:15 PM · Restricted Project, Restricted Project
hctim updated the diff for D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag.

Add more tests for edge cases in decoding.

Apr 10 2023, 2:15 PM · Restricted Project, Restricted Project

Apr 3 2023

hctim accepted D142888: [compiler-rt] Fix scudo build on ARM.
Apr 3 2023, 11:00 AM · Restricted Project, Restricted Project

Mar 31 2023

hctim added a comment to rG471f1664f382: [NFC][PowerPC] Marked the addr-label.ll test unsupported on PowerPC..

Ah, looks fixed in d4af896572592.

Mar 31 2023, 12:20 PM · Restricted Project, Restricted Project
hctim added a comment to rG471f1664f382: [NFC][PowerPC] Marked the addr-label.ll test unsupported on PowerPC..

G'day, looks like you made a mistake here: https://lab.llvm.org/buildbot/#/builders/236/builds/3155

Mar 31 2023, 12:18 PM · Restricted Project, Restricted Project
hctim added inline comments to D142888: [compiler-rt] Fix scudo build on ARM.
Mar 31 2023, 12:07 PM · Restricted Project, Restricted Project

Mar 30 2023

hctim added inline comments to D147189: [gwp_asan] Employ EXPECT_DEATH for zxtest compatibility.
Mar 30 2023, 3:21 PM · Restricted Project, Restricted Project
hctim added inline comments to D147189: [gwp_asan] Employ EXPECT_DEATH for zxtest compatibility.
Mar 30 2023, 10:42 AM · Restricted Project, Restricted Project
hctim added a comment to D142888: [compiler-rt] Fix scudo build on ARM.

Right, Scudo works on arm32 on Android. Android doesn't use cmake so I guess there's a proper unwind lib linked on arm32 Android in Android.bp when Scudo+gwp_asan is enabled. I didn't try it on arm32 Android, maybe @hctim can comment more.

Mar 30 2023, 8:46 AM · Restricted Project, Restricted Project

Mar 29 2023

hctim added a comment to D146935: [mlir-cpu-runner] Add export_executable_symbols in CMake..

Yeah, dlopen-ing a symbol that's already defined in the main executable would definitely do it. You shouldn't just disable ODR checking, as this is a real bug.

I had a look at our internal codebase, and saw three symbols (including the one you listed in your bug) being allow-listed with the following flags:

-Wl,--export-dynamic-symbol=llvm_orc_registerJITLoaderGDBWrapper
-Wl,--export-dynamic-symbol=llvm_orc_registerEHFrameSectionWrapper
-Wl,--export-dynamic-symbol=llvm_orc_deregisterEHFrameSectionWrapper

Do you think that'd do it for you instead of exporting every linked symbol from the executable?

Mar 29 2023, 3:55 PM · Restricted Project, Restricted Project
hctim added a comment to D146935: [mlir-cpu-runner] Add export_executable_symbols in CMake..

Thanks for the pointers! I do see that both mlir-cpu-runner and libmlir_async_runtime.so define EnableABIBreakingChecks:

$ nm libmlir_async_runtime.so | grep EnableABIBreakingChecks

000000000038cb80 B _ZN4llvm23EnableABIBreakingChecksE

$ nm mlir-cpu-runner | grep EnableABIBreakingChecks
000000000474364c B _ZN4llvm23EnableABIBreakingChecksE

IIUC, the problem comes from this RUN line:

// RUN: | mlir-cpu-runner                                                      \
// RUN:     -e main -entry-point-result=void -O0                               \
// RUN:     -shared-libs=%mlir_c_runner_utils  \
// RUN:     -shared-libs=%mlir_runner_utils    \
// RUN:     -shared-libs=%mlir_async_runtime   \

I'm guessing that this is due to dlopen (which is what -shared-libs translates to). Which makes me think - would ASAN_OPTIONS=detect_odr_violation=0 be the right solution/work-around? Not ideal 🤔 . I could add a GitHub issue to let people know that longer term we should consider some other fix. WDYT?

Mar 29 2023, 3:53 PM · Restricted Project, Restricted Project
hctim added a comment to D146744: [WebAssembly] Redesign DebugValueManager.

This might've broken builds? Either that, or one of your other three patches.

Mar 29 2023, 1:11 PM · Restricted Project, Restricted Project
hctim added a comment to D146935: [mlir-cpu-runner] Add export_executable_symbols in CMake..

No problems at all! In case you're not familiar, ODR is explained a little in our docs (and the other stuff that's linked there). Best bet to track it down is to figure out why llvm/lib/Support/ABIBreak.cpp is linked twice.

Mar 29 2023, 12:28 PM · Restricted Project, Restricted Project
hctim added a comment to D146920: [compiler-rt] Drop -Werror in compiler flag checks.

Already reverted in https://reviews.llvm.org/rG270067d69532448c4f6d7956e68d7a392857f9ce :)

Mar 29 2023, 12:22 PM · Restricted Project, Restricted Project
hctim committed rG3be6c4d413f6: Revert "Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656"" (authored by hctim).
Revert "Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656""
Mar 29 2023, 11:40 AM · Restricted Project, Restricted Project
hctim added a reverting change for rG791164751241: Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656": rG3be6c4d413f6: Revert "Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656"".
Mar 29 2023, 11:40 AM · Restricted Project, Restricted Project
hctim added a reverting change for rG158a431227a8: Revert ExtractAPI from https://reviews.llvm.org/D146656: rG96f028c0a282: Revert "[clang][ExtractAPI] Add queried symbol to parent contexts in libclang".
Mar 29 2023, 11:40 AM · Restricted Project, Restricted Project
hctim added a reverting change for rG1cfe1e732ad8: [clang][ExtractAPI] Add queried symbol to parent contexts in libclang: rG96f028c0a282: Revert "[clang][ExtractAPI] Add queried symbol to parent contexts in libclang".
Mar 29 2023, 11:40 AM · Restricted Project, Restricted Project
hctim committed rG96f028c0a282: Revert "[clang][ExtractAPI] Add queried symbol to parent contexts in libclang" (authored by hctim).
Revert "[clang][ExtractAPI] Add queried symbol to parent contexts in libclang"
Mar 29 2023, 11:40 AM · Restricted Project, Restricted Project
hctim added a reverting change for D147138: [clang][ExtractAPI] Add queried symbol to parent contexts in libclang: rG96f028c0a282: Revert "[clang][ExtractAPI] Add queried symbol to parent contexts in libclang".
Mar 29 2023, 11:40 AM · Restricted Project, Restricted Project
hctim added a comment to rG791164751241: Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656".

Hi, looks like this re-land triggered an ASan-detected heap leak: https://lab.llvm.org/buildbot/#/builders/5/builds/32516

Mar 29 2023, 11:35 AM · Restricted Project, Restricted Project
hctim updated subscribers of D146920: [compiler-rt] Drop -Werror in compiler flag checks.

Hey, looks like this breaks check-sanitizer on all the bots. Easily reproducible on a vanilla build, just do check-sanitizer on something that builds compiler-rt.

Mar 29 2023, 9:09 AM · Restricted Project, Restricted Project
hctim added a reverting change for rGe4918d43763e: [compiler-rt] Quote multiple warning flags in check_cxx_compiler_flag invocation: rG270067d69532: Revert "[compiler-rt] Quote multiple warning flags in check_cxx_compiler_flag….
Mar 29 2023, 9:07 AM · Restricted Project, Restricted Project
hctim committed rG270067d69532: Revert "[compiler-rt] Quote multiple warning flags in check_cxx_compiler_flag… (authored by hctim).
Revert "[compiler-rt] Quote multiple warning flags in check_cxx_compiler_flag…
Mar 29 2023, 9:07 AM · Restricted Project, Restricted Project
hctim added a reverting change for D146920: [compiler-rt] Drop -Werror in compiler flag checks: rG270067d69532: Revert "[compiler-rt] Quote multiple warning flags in check_cxx_compiler_flag….
Mar 29 2023, 9:07 AM · Restricted Project, Restricted Project
hctim added a reverting change for rGccdcfad08152: [mlir-cpu-runner] Add export_executable_symbols in CMake.: rG96c036113eae: Revert "[mlir-cpu-runner] Add export_executable_symbols in CMake.".
Mar 29 2023, 8:54 AM · Restricted Project, Restricted Project
hctim committed rG96c036113eae: Revert "[mlir-cpu-runner] Add export_executable_symbols in CMake." (authored by hctim).
Revert "[mlir-cpu-runner] Add export_executable_symbols in CMake."
Mar 29 2023, 8:54 AM · Restricted Project, Restricted Project
hctim added a reverting change for D146935: [mlir-cpu-runner] Add export_executable_symbols in CMake.: rG96c036113eae: Revert "[mlir-cpu-runner] Add export_executable_symbols in CMake.".
Mar 29 2023, 8:53 AM · Restricted Project, Restricted Project
hctim added a comment to D146935: [mlir-cpu-runner] Add export_executable_symbols in CMake..

Hi folks, looks like this broke ASan buildbots because of an ODR. Full reproduction instructions can be found at https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild (either using buildbot_fast.sh or buildbot_bootstrap_asan.sh), or alternatively this is quickly reproducible without a multi-stage build using my example cmake config below (which definitely has some stuff you don't need, like libc):

Mar 29 2023, 8:52 AM · Restricted Project, Restricted Project

Mar 27 2023

hctim added a comment to D126959: [C++20][Modules] Introduce an implementation module..

Hi, yep, I've reverted upstream. If you could please also integrate https://reviews.llvm.org/rG8c7c1f11ffaacf762e612c65440fd2cbb58ee426 in the relanding, that would be great.

Mar 27 2023, 5:04 AM · Restricted Project, Restricted Project
hctim added a reverting change for rGc6e9823724ef: [C++20][Modules] Introduce an implementation module.: rG074f6fd61d38: Revert "[C++20][Modules] Introduce an implementation module.".
Mar 27 2023, 5:03 AM · Restricted Project, Restricted Project
hctim committed rG074f6fd61d38: Revert "[C++20][Modules] Introduce an implementation module." (authored by hctim).
Revert "[C++20][Modules] Introduce an implementation module."
Mar 27 2023, 5:03 AM · Restricted Project, Restricted Project
hctim added a reverting change for rG8c7c1f11ffaa: Silence unused variable warning in NDEBUG builds: rG5ca710ab148b: Revert "Silence unused variable warning in NDEBUG builds".
Mar 27 2023, 5:03 AM · Restricted Project, Restricted Project
hctim committed rG5ca710ab148b: Revert "Silence unused variable warning in NDEBUG builds" (authored by hctim).
Revert "Silence unused variable warning in NDEBUG builds"
Mar 27 2023, 5:03 AM · Restricted Project, Restricted Project
hctim added a reverting change for D126959: [C++20][Modules] Introduce an implementation module.: rG074f6fd61d38: Revert "[C++20][Modules] Introduce an implementation module.".
Mar 27 2023, 5:03 AM · Restricted Project, Restricted Project

Mar 20 2023

hctim updated the diff for D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag.

Add some extra edge case tests.

Mar 20 2023, 4:09 PM · Restricted Project, Restricted Project
hctim added inline comments to D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag.
Mar 20 2023, 4:09 PM · Restricted Project, Restricted Project
hctim accepted D146351: sanitizer_common: Use plain thread_local for __sancov_lowest_stack definition..

Any ideas why this was IE in the first place? Don't see any notes in the patch that added it (https://reviews.llvm.org/D37156)?

Mar 20 2023, 10:28 AM · Restricted Project, Restricted Project

Mar 17 2023

hctim accepted D146341: gn build: Pass -fno-emulated-tls when targeting Android..
Mar 17 2023, 5:22 PM · Restricted Project, Restricted Project
hctim added inline comments to D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag.
Mar 17 2023, 3:00 PM · Restricted Project, Restricted Project
hctim updated the diff for D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag.

Address jhenderson@'s comments.

Mar 17 2023, 3:00 PM · Restricted Project, Restricted Project

Mar 9 2023

hctim requested review of D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag.
Mar 9 2023, 8:21 PM · Restricted Project, Restricted Project

Mar 7 2023

hctim committed rG02e8eb1a438b: Split getCompileUnitFor{Data,Code}Address. (authored by hctim).
Split getCompileUnitFor{Data,Code}Address.
Mar 7 2023, 12:05 PM · Restricted Project, Restricted Project
hctim closed D145009: Split getCompileUnitFor{Data,Code}Address..
Mar 7 2023, 12:04 PM · Restricted Project, Restricted Project