Page MenuHomePhabricator

hctim (Mitch Phillips)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2017, 3:58 PM (246 w, 6 h)

Recent Activity

Yesterday

hctim added a comment to D126100: Add sanitizer-specific GlobalValue attributes..

(friendly ping)

Thu, May 26, 11:52 AM · Restricted Project, Restricted Project, Restricted Project

Tue, May 24

hctim updated the diff for D126100: Add sanitizer-specific GlobalValue attributes..

Remove extra creation path, turns out it's a duplicate of elsewhere.

Tue, May 24, 3:06 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D126224: Add DWARF string debug to clang release notes..

It sounds like the consensus is what's represented in the release notes, "if this new feature breaks you, then you need to fix yourself".

Tue, May 24, 9:45 AM · Restricted Project, Restricted Project

Mon, May 23

hctim updated the diff for D126100: Add sanitizer-specific GlobalValue attributes..

Add an extra Global creation path from the frontend, and fix up a comment from Kirill on the other revision.

Mon, May 23, 3:56 PM · Restricted Project, Restricted Project, Restricted Project
hctim abandoned D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage).
Mon, May 23, 3:46 PM · Restricted Project, Restricted Project
hctim planned changes to D124493: Move Sanitizer metadata to be on-GlobalValue..

Pulled out the IR-specific changes to D126100.

Mon, May 23, 3:42 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
hctim committed rGcead4eceb01b: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals (authored by hctim).
[symbolizer] Parse DW_TAG_variable DIs to show line info for globals
Mon, May 23, 1:31 PM · Restricted Project, Restricted Project
hctim closed D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.
Mon, May 23, 1:30 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

David's comments.

Mon, May 23, 1:10 PM · Restricted Project, Restricted Project, Restricted Project
hctim requested review of D126224: Add DWARF string debug to clang release notes..
Mon, May 23, 10:12 AM · Restricted Project, Restricted Project

Fri, May 20

hctim requested review of D126100: Add sanitizer-specific GlobalValue attributes..
Fri, May 20, 4:09 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D110552: tsan: add lock free stack pattern test.

Looks like I missed something, probably because 'ppc' isn't a feature recognised by compiler-rt's lit config. Looking.

@hctim Maybe try UNSUPPORTED: ppc64?

Fri, May 20, 2:39 PM · Restricted Project, Restricted Project
hctim committed rGde066267254a: PPC+TSan whack-a-mole, round 3. (authored by hctim).
PPC+TSan whack-a-mole, round 3.
Fri, May 20, 2:23 PM · Restricted Project, Restricted Project
hctim committed rGbd62b70b515b: Add 'ppc' as a target (for both 32- and 64-bit ppc). (authored by hctim).
Add 'ppc' as a target (for both 32- and 64-bit ppc).
Fri, May 20, 1:57 PM · Restricted Project, Restricted Project
hctim added a comment to D110552: tsan: add lock free stack pattern test.

Looks like I missed something, probably because 'ppc' isn't a feature recognised by compiler-rt's lit config. Looking.

Fri, May 20, 1:49 PM · Restricted Project, Restricted Project
hctim added a comment to D110552: tsan: add lock free stack pattern test.

I think there may be some flakes and the best way to address it for now may be adding a constraint to not run it on PPC.

Unfortunately, I do not know how to add such constraint. Can you please advise me?

Fri, May 20, 1:08 PM · Restricted Project, Restricted Project
hctim committed rGb517d679dd69: Mark new TSan test as unsupported on PPC. (authored by hctim).
Mark new TSan test as unsupported on PPC.
Fri, May 20, 1:08 PM · Restricted Project, Restricted Project
hctim committed rG80ac0b9bc886: Fix up fuzzing test on Windows. (authored by hctim).
Fix up fuzzing test on Windows.
Fri, May 20, 11:27 AM · Restricted Project, Restricted Project
hctim committed rG3bd112c720dc: Update fuzzing test to comply with new optimisation. (authored by hctim).
Update fuzzing test to comply with new optimisation.
Fri, May 20, 11:02 AM · Restricted Project, Restricted Project

Thu, May 19

hctim added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

We noticed when building Fuchsia using ToT LLVM that CGo has trouble with the new changes to DWARF introduced in this patch. It appears as if CGo is confused because it found a DW_TAG_variable that doesn't have a name, which is allowed by the DWARF standard.

This patch seems like a good change to me and is well thought out and tested, but I think this may cause issues in the wider ecosystem as people interact with it. It may simply be a problem w/ Go, and a bug fix there is all that is necessary, but there is also the chance that other compilers and toolchains will have similar issues.

I want to be clear that I don't necessarily think a revert is in order, but we should take the opportunity to determine the right course of action.

Thu, May 19, 11:00 AM · Restricted Project, Restricted Project, Restricted Project

Wed, May 18

hctim added inline comments to D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.
Wed, May 18, 2:45 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

Explicitly only match 'DW_OP_addr[x] [+ DW_OP_plus_uconst]'

Wed, May 18, 2:44 PM · Restricted Project, Restricted Project, Restricted Project
hctim committed rGf9a3c43eaa97: [NFCI] clang-format gwp-asan files. (authored by hctim).
[NFCI] clang-format gwp-asan files.
Wed, May 18, 2:11 PM · Restricted Project, Restricted Project
hctim committed rGe831ea6912d1: [NFCI] clang-format scudo standalone (authored by hctim).
[NFCI] clang-format scudo standalone
Wed, May 18, 2:05 PM · Restricted Project, Restricted Project
hctim committed rG7aa1fa0a0a07: Reland "[dwarf] Emit a DIGlobalVariable for constant strings." (authored by hctim).
Reland "[dwarf] Emit a DIGlobalVariable for constant strings."
Wed, May 18, 1:59 PM · Restricted Project, Restricted Project, Restricted Project
hctim closed D123534: [dwarf] Emit a DIGlobalVariable for constant strings..
Wed, May 18, 1:58 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

Fix the fuchsia windows bot by making the DILocalVariables in the test order-independent.

Wed, May 18, 1:58 PM · Restricted Project, Restricted Project, Restricted Project
hctim reopened D123534: [dwarf] Emit a DIGlobalVariable for constant strings..
Wed, May 18, 1:58 PM · Restricted Project, Restricted Project, Restricted Project

Tue, May 17

hctim added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

Why, on Fuchsia, on WIndows, the DIs are in the order q -> p -> r is beyond me (instead of the file order and my order p -> q -> r. Looking into it.

Tue, May 17, 9:19 AM · Restricted Project, Restricted Project, Restricted Project

Mon, May 16

hctim added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

Done, I'll take a look and resubmit later.

Mon, May 16, 7:10 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a reverting change for rG4680982b36a8: [dwarf] Emit a DIGlobalVariable for constant strings.: rGed2c3218f5ba: Revert "[dwarf] Emit a DIGlobalVariable for constant strings.".
Mon, May 16, 7:09 PM · Restricted Project, Restricted Project, Restricted Project
hctim committed rGed2c3218f5ba: Revert "[dwarf] Emit a DIGlobalVariable for constant strings." (authored by hctim).
Revert "[dwarf] Emit a DIGlobalVariable for constant strings."
Mon, May 16, 7:09 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a reverting change for D123534: [dwarf] Emit a DIGlobalVariable for constant strings.: rGed2c3218f5ba: Revert "[dwarf] Emit a DIGlobalVariable for constant strings.".
Mon, May 16, 7:08 PM · Restricted Project, Restricted Project, Restricted Project
hctim committed rG4680982b36a8: [dwarf] Emit a DIGlobalVariable for constant strings. (authored by hctim).
[dwarf] Emit a DIGlobalVariable for constant strings.
Mon, May 16, 4:52 PM · Restricted Project, Restricted Project, Restricted Project
hctim closed D123534: [dwarf] Emit a DIGlobalVariable for constant strings..
Mon, May 16, 4:52 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

Touch ups from comments.

Mon, May 16, 11:35 AM · Restricted Project, Restricted Project, Restricted Project
hctim added inline comments to D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.
Mon, May 16, 10:53 AM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

Patch update.

Mon, May 16, 10:53 AM · Restricted Project, Restricted Project, Restricted Project

Fri, May 13

hctim updated the diff for D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

Remove test based on removed invariant (DIGlobalVariables no longer need a name).

Fri, May 13, 9:41 AM · Restricted Project, Restricted Project, Restricted Project

Thu, May 12

hctim updated the diff for D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

update patch

Thu, May 12, 7:57 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

That's fine, a Windows machine shouldn't be necessary. This patch has to change the AsmPrinter for DWARF, so it makes sense that it should do the same for CodeView. I think it should be sufficient to continue this loop when a global variable display name is empty:
https://github.com/llvm/llvm-project/blob/main/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp#L3175

It will need a test, and the tests at llvm/test/DebugInfo/COFF/global* should be good templates. Basically, have a file with two globals, one named and unnamed, and use FileCheck to confirm that there is only one GDATA record.

Thu, May 12, 7:55 PM · Restricted Project, Restricted Project, Restricted Project

Wed, May 11

hctim added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

This seems reasonable, but I worry about the consequences of creating lots of unnamed global variables. What will gdb do with so many unnamed globals? What will the PDB linker do with all these unnamed globals? I can't answer these questions, and you're welcome to try and find out, but I predict there will be problems, so just be aware of that possibility.

Wed, May 11, 7:08 PM · Restricted Project, Restricted Project, Restricted Project

Tue, May 10

hctim added inline comments to D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.
Tue, May 10, 5:07 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

(comment)

Tue, May 10, 5:07 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

@rnk @aprantl @probinson: this looks plausible to me to take as a general change to the emitted DWARF, but I'm open to ideas/suggestions if folks find this to be too much growth for not enough benefit & that it should be behind a flag?

Tue, May 10, 2:09 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Apr 29

hctim updated the diff for D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

(restoring after uploading the diff for D123534 here accidentally)

Fri, Apr 29, 3:22 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

(restoring after uploading the diff for D123534 here accidentally)

Fri, Apr 29, 3:20 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

(restoring after uploading the diff for D123538 here accidentally)

Fri, Apr 29, 3:19 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

Update test, rebase off of string debuginfo.

Fri, Apr 29, 3:18 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

Update test, rebase off of string debuginfo.

Fri, Apr 29, 3:17 PM · Restricted Project, Restricted Project, Restricted Project

Apr 27 2022

hctim retitled D124493: Move Sanitizer metadata to be on-GlobalValue. from [symbolizer] Parse DW_TAG_variable DIs to show line info for globals to Move Sanitizer metadata to be on-GlobalValue..
Apr 27 2022, 2:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 26 2022

hctim removed a reviewer for D124493: Move Sanitizer metadata to be on-GlobalValue.: jhenderson.
Apr 26 2022, 6:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D124493: Move Sanitizer metadata to be on-GlobalValue..

Wrong base, updating.

Apr 26 2022, 6:12 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D124493: Move Sanitizer metadata to be on-GlobalValue..

Sorry for the large patch. Honestly, looks bigger than it is due to 1-line changes in many files + many-line changes in stuff that was pretty much moved around. I didn't see a great way to split this up except for sharding out the GlobalValue changes + IR + bitcode read/write, but didn't think that was substantial enough to warrant it.

Apr 26 2022, 6:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
hctim requested review of D124493: Move Sanitizer metadata to be on-GlobalValue..
Apr 26 2022, 6:09 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

Fix a small ordering bug, update with comments.

Apr 26 2022, 4:29 PM · Restricted Project, Restricted Project, Restricted Project
hctim added inline comments to D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.
Apr 26 2022, 4:29 PM · Restricted Project, Restricted Project, Restricted Project
hctim added inline comments to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..
Apr 26 2022, 4:10 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

summary of DWARF:
& how many of these descriptions get added to the debug info?

Apr 26 2022, 4:08 PM · Restricted Project, Restricted Project, Restricted Project

Apr 21 2022

hctim updated the diff for D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.
XCOFF/print-linenumber.testdepends on the fact that symbolizing '0x0' should pull it from .text, even if there's a global variable also at '0x0'. This is why (as above) I don't think objfiles are a good test case for llvm-symbolizer, as an address alone can point to multiple symbolizable things.
Apr 21 2022, 4:08 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

minor fix

Apr 21 2022, 3:50 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

.

Apr 21 2022, 2:34 PM · Restricted Project, Restricted Project, Restricted Project
hctim added inline comments to D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.
Apr 21 2022, 2:33 PM · Restricted Project, Restricted Project, Restricted Project
hctim accepted D123010: [asan] Emit .size directive for global object size before redzone.

I just did a quick check against llvm/test/Instrumentation/AddressSanitizer/adaptive_global_redzones.ll, compiling and linking it as a DSO, and it looks right (only the sizes change).

Apr 21 2022, 1:44 PM · Restricted Project, Restricted Project
hctim added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

I just did an experiment with the following patch that punts everything to const char* types to try and get better folding onto a single type:

Apr 21 2022, 1:31 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

1263559896 (new) - 1248280328 (old) = 15279568 B (1.22% increase). Seems more reasonable to me.

Apr 21 2022, 12:27 PM · Restricted Project, Restricted Project, Restricted Project

Apr 20 2022

hctim added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

Yeah, as I drove away from my desk I realized my mistake. Will get new accurate numbers.

Apr 20 2022, 7:34 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

Confirmed again with -DCMAKE_BUILD_TYPE=RelWithDebInfo -DLLVM_ENABLE_ASSERTIONS=On:

Apr 20 2022, 4:38 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

Patch update.

Apr 20 2022, 4:20 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

What's the DW_AT_type referring to? (why is there a type called ".str"?)

For your particular purposes, it seems like the name/type/linkage name could all be omitted & that might be OK, since these entities aren't actually named in the source?

Apr 20 2022, 4:19 PM · Restricted Project, Restricted Project, Restricted Project

Apr 19 2022

hctim added inline comments to D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.
Apr 19 2022, 1:54 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

Update

Apr 19 2022, 1:54 PM · Restricted Project, Restricted Project, Restricted Project

Apr 15 2022

hctim added inline comments to D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.
Apr 15 2022, 3:51 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

.

Apr 15 2022, 3:51 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..
section : increase in bytes for clang built with full debuginfo : %% of total binary size
.debug_loclists		317782		0.0250%
.debug_abbrev		88590		0.0070%
.debug_info		10070834	0.7929%
.debug_rnglists		143320		0.0113%
.debug_str_offsets	1090516		0.0859%
.debug_str		7789440		0.6132%
.debug_addr		3611552		0.2843%
.debug_line		-187964		-0.0148%
.debug_line_str		2043		0.0002%
Apr 15 2022, 2:45 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

This seems like it would significantly introduce debug info size for at least some kinds of code - have you done any size measurements of this change?

Apr 15 2022, 2:33 PM · Restricted Project, Restricted Project, Restricted Project

Apr 14 2022

hctim added inline comments to D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.
Apr 14 2022, 2:54 PM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2022

hctim added a reviewer for D123534: [dwarf] Emit a DIGlobalVariable for constant strings.: dblaikie.
Apr 13 2022, 10:50 AM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2022

hctim added a comment to D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

I do not want to bother you at all:
https://llvm.org/docs/ProgrammersManual.html#map

Apr 11 2022, 1:33 PM · Restricted Project, Restricted Project, Restricted Project
hctim added inline comments to D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.
Apr 11 2022, 1:15 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.

.

Apr 11 2022, 1:15 PM · Restricted Project, Restricted Project, Restricted Project
hctim requested review of D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals.
Apr 11 2022, 12:58 PM · Restricted Project, Restricted Project, Restricted Project
hctim requested review of D123534: [dwarf] Emit a DIGlobalVariable for constant strings..
Apr 11 2022, 12:02 PM · Restricted Project, Restricted Project, Restricted Project

Apr 8 2022

hctim committed rGfa34951fbc9b: Reland "[MTE] Add -fsanitize=memtag* and friends." (authored by hctim).
Reland "[MTE] Add -fsanitize=memtag* and friends."
Apr 8 2022, 2:29 PM · Restricted Project, Restricted Project
hctim added a comment to D118948: [MTE] Add -fsanitize=memtag* and friends..

Thanks, I'll take a look.

Apr 8 2022, 1:18 PM · Restricted Project, Restricted Project, Restricted Project
hctim committed rG8aa1490513f1: [MTE] Add -fsanitize=memtag* and friends. (authored by hctim).
[MTE] Add -fsanitize=memtag* and friends.
Apr 8 2022, 12:14 PM · Restricted Project, Restricted Project
hctim closed D118948: [MTE] Add -fsanitize=memtag* and friends..
Apr 8 2022, 12:13 PM · Restricted Project, Restricted Project, Restricted Project
hctim added inline comments to D118948: [MTE] Add -fsanitize=memtag* and friends..
Apr 8 2022, 11:09 AM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D118948: [MTE] Add -fsanitize=memtag* and friends..

.

Apr 8 2022, 11:08 AM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D118948: [MTE] Add -fsanitize=memtag* and friends..

Over to @eugenis for any final touches

Apr 8 2022, 10:35 AM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D118948: [MTE] Add -fsanitize=memtag* and friends..

Comments

Apr 8 2022, 10:34 AM · Restricted Project, Restricted Project, Restricted Project

Apr 5 2022

hctim added a comment to D118948: [MTE] Add -fsanitize=memtag* and friends..

Since this driver option has no-op for glibc/musl/other ELF OS, by convention it should report an err_drv_unsupported_opt_for_target error.
This allows configure-time detection.

Apr 5 2022, 11:52 AM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D118948: [MTE] Add -fsanitize=memtag* and friends..

.

Apr 5 2022, 11:52 AM · Restricted Project, Restricted Project, Restricted Project

Apr 4 2022

hctim added a comment to D118948: [MTE] Add -fsanitize=memtag* and friends..

Is -fsanitize=memtag-heap Android specific or target independent? It passes Android flags to the linker?!?

Apr 4 2022, 12:55 PM · Restricted Project, Restricted Project, Restricted Project
hctim added inline comments to D118948: [MTE] Add -fsanitize=memtag* and friends..
Apr 4 2022, 12:35 PM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D118948: [MTE] Add -fsanitize=memtag* and friends..

(comments)

Apr 4 2022, 12:35 PM · Restricted Project, Restricted Project, Restricted Project
hctim committed rG786c89fed379: [ELF][MTE] Add --android-memtag-* options to synthesize ELF notes (authored by hctim).
[ELF][MTE] Add --android-memtag-* options to synthesize ELF notes
Apr 4 2022, 11:18 AM · Restricted Project
hctim closed D119384: [ELF][MTE] Add --android-memtag-* options to synthesize ELF notes.
Apr 4 2022, 11:18 AM · Restricted Project, Restricted Project
hctim added a comment to D119384: [ELF][MTE] Add --android-memtag-* options to synthesize ELF notes.

LG. It will be nice to have a link to the Android bionic implementation, so that when iterating on the semantics we can get a reference.

Apr 4 2022, 11:07 AM · Restricted Project, Restricted Project

Apr 1 2022

hctim committed rG9262d031a452: [NFCI] clang-format SanitizerArgs.cpp (authored by hctim).
[NFCI] clang-format SanitizerArgs.cpp
Apr 1 2022, 4:38 PM · Restricted Project, Restricted Project