Page MenuHomePhabricator

hctim (Mitch Phillips)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2017, 3:58 PM (289 w, 6 d)

Recent Activity

Today

hctim added inline comments to D147189: [gwp_asan] Employ EXPECT_DEATH for zxtest compatibility.
Thu, Mar 30, 3:21 PM · Restricted Project, Restricted Project
hctim added inline comments to D147189: [gwp_asan] Employ EXPECT_DEATH for zxtest compatibility.
Thu, Mar 30, 10:42 AM · Restricted Project, Restricted Project
hctim added a comment to D142888: [compiler-rt] Fix scudo build on ARM.

Right, Scudo works on arm32 on Android. Android doesn't use cmake so I guess there's a proper unwind lib linked on arm32 Android in Android.bp when Scudo+gwp_asan is enabled. I didn't try it on arm32 Android, maybe @hctim can comment more.

Thu, Mar 30, 8:46 AM · Restricted Project, Restricted Project

Yesterday

hctim added a comment to D146935: [mlir-cpu-runner] Add export_executable_symbols in CMake..

Yeah, dlopen-ing a symbol that's already defined in the main executable would definitely do it. You shouldn't just disable ODR checking, as this is a real bug.

I had a look at our internal codebase, and saw three symbols (including the one you listed in your bug) being allow-listed with the following flags:

-Wl,--export-dynamic-symbol=llvm_orc_registerJITLoaderGDBWrapper
-Wl,--export-dynamic-symbol=llvm_orc_registerEHFrameSectionWrapper
-Wl,--export-dynamic-symbol=llvm_orc_deregisterEHFrameSectionWrapper

Do you think that'd do it for you instead of exporting every linked symbol from the executable?

Wed, Mar 29, 3:55 PM · Restricted Project, Restricted Project
hctim added a comment to D146935: [mlir-cpu-runner] Add export_executable_symbols in CMake..

Thanks for the pointers! I do see that both mlir-cpu-runner and libmlir_async_runtime.so define EnableABIBreakingChecks:

$ nm libmlir_async_runtime.so | grep EnableABIBreakingChecks

000000000038cb80 B _ZN4llvm23EnableABIBreakingChecksE

$ nm mlir-cpu-runner | grep EnableABIBreakingChecks
000000000474364c B _ZN4llvm23EnableABIBreakingChecksE

IIUC, the problem comes from this RUN line:

// RUN: | mlir-cpu-runner                                                      \
// RUN:     -e main -entry-point-result=void -O0                               \
// RUN:     -shared-libs=%mlir_c_runner_utils  \
// RUN:     -shared-libs=%mlir_runner_utils    \
// RUN:     -shared-libs=%mlir_async_runtime   \

I'm guessing that this is due to dlopen (which is what -shared-libs translates to). Which makes me think - would ASAN_OPTIONS=detect_odr_violation=0 be the right solution/work-around? Not ideal 🤔 . I could add a GitHub issue to let people know that longer term we should consider some other fix. WDYT?

Wed, Mar 29, 3:53 PM · Restricted Project, Restricted Project
hctim added a comment to D146744: [WebAssembly] Redesign DebugValueManager.

This might've broken builds? Either that, or one of your other three patches.

Wed, Mar 29, 1:11 PM · Restricted Project, Restricted Project
hctim added a comment to D146935: [mlir-cpu-runner] Add export_executable_symbols in CMake..

No problems at all! In case you're not familiar, ODR is explained a little in our docs (and the other stuff that's linked there). Best bet to track it down is to figure out why llvm/lib/Support/ABIBreak.cpp is linked twice.

Wed, Mar 29, 12:28 PM · Restricted Project, Restricted Project
hctim added a comment to D146920: [compiler-rt] Quote multiple warning flags in check_cxx_compiler_flag invocation.

Already reverted in https://reviews.llvm.org/rG270067d69532448c4f6d7956e68d7a392857f9ce :)

Wed, Mar 29, 12:22 PM · Restricted Project, Restricted Project
hctim committed rG3be6c4d413f6: Revert "Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656"" (authored by hctim).
Revert "Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656""
Wed, Mar 29, 11:40 AM · Restricted Project, Restricted Project
hctim added a reverting change for rG791164751241: Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656": rG3be6c4d413f6: Revert "Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656"".
Wed, Mar 29, 11:40 AM · Restricted Project, Restricted Project
hctim added a reverting change for rG158a431227a8: Revert ExtractAPI from https://reviews.llvm.org/D146656: rG96f028c0a282: Revert "[clang][ExtractAPI] Add queried symbol to parent contexts in libclang".
Wed, Mar 29, 11:40 AM · Restricted Project, Restricted Project
hctim added a reverting change for rG1cfe1e732ad8: [clang][ExtractAPI] Add queried symbol to parent contexts in libclang: rG96f028c0a282: Revert "[clang][ExtractAPI] Add queried symbol to parent contexts in libclang".
Wed, Mar 29, 11:40 AM · Restricted Project, Restricted Project
hctim committed rG96f028c0a282: Revert "[clang][ExtractAPI] Add queried symbol to parent contexts in libclang" (authored by hctim).
Revert "[clang][ExtractAPI] Add queried symbol to parent contexts in libclang"
Wed, Mar 29, 11:40 AM · Restricted Project, Restricted Project
hctim added a reverting change for D147138: [clang][ExtractAPI] Add queried symbol to parent contexts in libclang: rG96f028c0a282: Revert "[clang][ExtractAPI] Add queried symbol to parent contexts in libclang".
Wed, Mar 29, 11:40 AM · Restricted Project, Restricted Project
hctim added a comment to rG791164751241: Revert "Revert ExtractAPI from https://reviews.llvm.org/D146656".

Hi, looks like this re-land triggered an ASan-detected heap leak: https://lab.llvm.org/buildbot/#/builders/5/builds/32516

Wed, Mar 29, 11:35 AM · Restricted Project, Restricted Project
hctim updated subscribers of D146920: [compiler-rt] Quote multiple warning flags in check_cxx_compiler_flag invocation.

Hey, looks like this breaks check-sanitizer on all the bots. Easily reproducible on a vanilla build, just do check-sanitizer on something that builds compiler-rt.

Wed, Mar 29, 9:09 AM · Restricted Project, Restricted Project
hctim added a reverting change for rGe4918d43763e: [compiler-rt] Quote multiple warning flags in check_cxx_compiler_flag invocation: rG270067d69532: Revert "[compiler-rt] Quote multiple warning flags in check_cxx_compiler_flag….
Wed, Mar 29, 9:07 AM · Restricted Project, Restricted Project
hctim committed rG270067d69532: Revert "[compiler-rt] Quote multiple warning flags in check_cxx_compiler_flag… (authored by hctim).
Revert "[compiler-rt] Quote multiple warning flags in check_cxx_compiler_flag…
Wed, Mar 29, 9:07 AM · Restricted Project, Restricted Project
hctim added a reverting change for D146920: [compiler-rt] Quote multiple warning flags in check_cxx_compiler_flag invocation: rG270067d69532: Revert "[compiler-rt] Quote multiple warning flags in check_cxx_compiler_flag….
Wed, Mar 29, 9:07 AM · Restricted Project, Restricted Project
hctim added a reverting change for rGccdcfad08152: [mlir-cpu-runner] Add export_executable_symbols in CMake.: rG96c036113eae: Revert "[mlir-cpu-runner] Add export_executable_symbols in CMake.".
Wed, Mar 29, 8:54 AM · Restricted Project, Restricted Project
hctim committed rG96c036113eae: Revert "[mlir-cpu-runner] Add export_executable_symbols in CMake." (authored by hctim).
Revert "[mlir-cpu-runner] Add export_executable_symbols in CMake."
Wed, Mar 29, 8:54 AM · Restricted Project, Restricted Project
hctim added a reverting change for D146935: [mlir-cpu-runner] Add export_executable_symbols in CMake.: rG96c036113eae: Revert "[mlir-cpu-runner] Add export_executable_symbols in CMake.".
Wed, Mar 29, 8:53 AM · Restricted Project, Restricted Project
hctim added a comment to D146935: [mlir-cpu-runner] Add export_executable_symbols in CMake..

Hi folks, looks like this broke ASan buildbots because of an ODR. Full reproduction instructions can be found at https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild (either using buildbot_fast.sh or buildbot_bootstrap_asan.sh), or alternatively this is quickly reproducible without a multi-stage build using my example cmake config below (which definitely has some stuff you don't need, like libc):

Wed, Mar 29, 8:52 AM · Restricted Project, Restricted Project

Mon, Mar 27

hctim added a comment to D126959: [C++20][Modules] Introduce an implementation module..

Hi, yep, I've reverted upstream. If you could please also integrate https://reviews.llvm.org/rG8c7c1f11ffaacf762e612c65440fd2cbb58ee426 in the relanding, that would be great.

Mon, Mar 27, 5:04 AM · Restricted Project, Restricted Project
hctim added a reverting change for rGc6e9823724ef: [C++20][Modules] Introduce an implementation module.: rG074f6fd61d38: Revert "[C++20][Modules] Introduce an implementation module.".
Mon, Mar 27, 5:03 AM · Restricted Project, Restricted Project
hctim committed rG074f6fd61d38: Revert "[C++20][Modules] Introduce an implementation module." (authored by hctim).
Revert "[C++20][Modules] Introduce an implementation module."
Mon, Mar 27, 5:03 AM · Restricted Project, Restricted Project
hctim added a reverting change for rG8c7c1f11ffaa: Silence unused variable warning in NDEBUG builds: rG5ca710ab148b: Revert "Silence unused variable warning in NDEBUG builds".
Mon, Mar 27, 5:03 AM · Restricted Project, Restricted Project
hctim committed rG5ca710ab148b: Revert "Silence unused variable warning in NDEBUG builds" (authored by hctim).
Revert "Silence unused variable warning in NDEBUG builds"
Mon, Mar 27, 5:03 AM · Restricted Project, Restricted Project
hctim added a reverting change for D126959: [C++20][Modules] Introduce an implementation module.: rG074f6fd61d38: Revert "[C++20][Modules] Introduce an implementation module.".
Mon, Mar 27, 5:03 AM · Restricted Project, Restricted Project

Mon, Mar 20

hctim updated the diff for D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag.

Add some extra edge case tests.

Mon, Mar 20, 4:09 PM · Restricted Project, Restricted Project
hctim added inline comments to D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag.
Mon, Mar 20, 4:09 PM · Restricted Project, Restricted Project
hctim accepted D146351: sanitizer_common: Use plain thread_local for __sancov_lowest_stack definition..

Any ideas why this was IE in the first place? Don't see any notes in the patch that added it (https://reviews.llvm.org/D37156)?

Mon, Mar 20, 10:28 AM · Restricted Project, Restricted Project

Fri, Mar 17

hctim accepted D146341: gn build: Pass -fno-emulated-tls when targeting Android..
Fri, Mar 17, 5:22 PM · Restricted Project, Restricted Project
hctim added inline comments to D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag.
Fri, Mar 17, 3:00 PM · Restricted Project, Restricted Project
hctim updated the diff for D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag.

Address jhenderson@'s comments.

Fri, Mar 17, 3:00 PM · Restricted Project, Restricted Project

Thu, Mar 9

hctim requested review of D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag.
Thu, Mar 9, 8:21 PM · Restricted Project, Restricted Project

Tue, Mar 7

hctim committed rG02e8eb1a438b: Split getCompileUnitFor{Data,Code}Address. (authored by hctim).
Split getCompileUnitFor{Data,Code}Address.
Tue, Mar 7, 12:05 PM · Restricted Project, Restricted Project
hctim closed D145009: Split getCompileUnitFor{Data,Code}Address..
Tue, Mar 7, 12:04 PM · Restricted Project, Restricted Project

Wed, Mar 1

hctim committed rGc574e93afd2e: [lld] [MTE] Add DT_AARCH64_MEMTAG_* dynamic entries, and small cleanup (authored by hctim).
[lld] [MTE] Add DT_AARCH64_MEMTAG_* dynamic entries, and small cleanup
Wed, Mar 1, 11:14 AM · Restricted Project
hctim closed D143769: [lld] [MTE] Add DT_AARCH64_MEMTAG_* dynamic entries, and small cleanup.
Wed, Mar 1, 11:14 AM · Restricted Project, Restricted Project
hctim committed rGa4d39d4b69b2: [llvm-readobj] Add --memtag (authored by hctim).
[llvm-readobj] Add --memtag
Wed, Mar 1, 11:00 AM · Restricted Project, Restricted Project
hctim closed D143693: [llvm-readobj] Add --memtag.
Wed, Mar 1, 11:00 AM · Restricted Project, Restricted Project

Feb 28 2023

hctim updated the diff for D143693: [llvm-readobj] Add --memtag.

Address MaskRay and jhenderson's comments.

Feb 28 2023, 4:07 PM · Restricted Project, Restricted Project
hctim requested review of D145009: Split getCompileUnitFor{Data,Code}Address..
Feb 28 2023, 2:55 PM · Restricted Project, Restricted Project
hctim committed rGbc949f923ee3: [GWP-ASan] Handle wild touches of the guarded pool. (authored by hctim).
[GWP-ASan] Handle wild touches of the guarded pool.
Feb 28 2023, 2:16 PM · Restricted Project, Restricted Project
hctim closed D144973: [GWP-ASan] Handle wild touches of the guarded pool..
Feb 28 2023, 2:15 PM · Restricted Project, Restricted Project
hctim added inline comments to D140173: [GWP-ASan] Add recoverable mode..
Feb 28 2023, 8:16 AM · Restricted Project, Restricted Project
hctim requested review of D144973: [GWP-ASan] Handle wild touches of the guarded pool..
Feb 28 2023, 8:16 AM · Restricted Project, Restricted Project

Feb 23 2023

hctim accepted D144669: [HWASAN][LSAN] Only initialize Symbolizer if leak checking is enabled.
Feb 23 2023, 1:37 PM · Restricted Project, Restricted Project
hctim accepted D144424: ASAN: keep support for Global::location.
Feb 23 2023, 9:35 AM · Restricted Project, Restricted Project

Feb 21 2023

hctim added a comment to D144424: ASAN: keep support for Global::location.

we don't support llvm-symbolizer and the default libbacktraace symbolizer does not support location info.

Feb 21 2023, 11:31 AM · Restricted Project, Restricted Project

Feb 17 2023

hctim added a comment to D143693: [llvm-readobj] Add --memtag.

@fmayer / @jhenderson / @MaskRay , would you folks mind taking a second pass? thanks.

Feb 17 2023, 11:13 AM · Restricted Project, Restricted Project
hctim added a comment to D143769: [lld] [MTE] Add DT_AARCH64_MEMTAG_* dynamic entries, and small cleanup.

@fmayer / @MaskRay , would you mind taking a quick second pass? thanks

Feb 17 2023, 11:12 AM · Restricted Project, Restricted Project

Feb 15 2023

hctim added inline comments to D143693: [llvm-readobj] Add --memtag.
Feb 15 2023, 3:39 PM · Restricted Project, Restricted Project
hctim updated the diff for D143693: [llvm-readobj] Add --memtag.

Update with jhenderson@'s comments: used arrayref in place of vector, some minor reformatting and renaming.

Feb 15 2023, 12:29 PM · Restricted Project, Restricted Project

Feb 13 2023

hctim updated the diff for D143769: [lld] [MTE] Add DT_AARCH64_MEMTAG_* dynamic entries, and small cleanup.

Update the test a little to be explicit about warning/error, remove a newline.

Feb 13 2023, 10:02 AM · Restricted Project, Restricted Project
hctim added a comment to D143769: [lld] [MTE] Add DT_AARCH64_MEMTAG_* dynamic entries, and small cleanup.

Considering adding some documentation to lld/docs/ld.lld.1. It can contain more information than lld/ELF/Options.td

Feb 13 2023, 10:01 AM · Restricted Project, Restricted Project
hctim updated the diff for D143693: [llvm-readobj] Add --memtag.

Address Ray's comments.

Feb 13 2023, 9:17 AM · Restricted Project, Restricted Project
hctim retitled D143693: [llvm-readobj] Add --memtag from Add --memtag to llvm-readelf/llvm-readobj. to [llvm-readobj] Add --memtag.
Feb 13 2023, 9:16 AM · Restricted Project, Restricted Project

Feb 10 2023

hctim added inline comments to D143769: [lld] [MTE] Add DT_AARCH64_MEMTAG_* dynamic entries, and small cleanup.
Feb 10 2023, 11:15 AM · Restricted Project, Restricted Project
hctim requested review of D143769: [lld] [MTE] Add DT_AARCH64_MEMTAG_* dynamic entries, and small cleanup.
Feb 10 2023, 10:56 AM · Restricted Project, Restricted Project
hctim updated the diff for D143693: [llvm-readobj] Add --memtag.

Add a comment describing the use of printNotesHelper.

Feb 10 2023, 10:05 AM · Restricted Project, Restricted Project

Feb 9 2023

hctim updated the diff for D143693: [llvm-readobj] Add --memtag.

Add test that --memtag doesn't print non-MTE dynamic entries.

Feb 9 2023, 5:41 PM · Restricted Project, Restricted Project
hctim requested review of D143693: [llvm-readobj] Add --memtag.
Feb 9 2023, 5:14 PM · Restricted Project, Restricted Project

Feb 2 2023

hctim added a reverting change for rGb1e9ab7438a0: Add CFI integer types normalization: rGb88ebb3d94cb: Revert "Add CFI integer types normalization".
Feb 2 2023, 3:52 PM · Restricted Project, Restricted Project
hctim committed rGb88ebb3d94cb: Revert "Add CFI integer types normalization" (authored by hctim).
Revert "Add CFI integer types normalization"
Feb 2 2023, 3:52 PM · Restricted Project, Restricted Project
hctim added a reverting change for D139395: Add CFI integer types normalization: rGb88ebb3d94cb: Revert "Add CFI integer types normalization".
Feb 2 2023, 3:52 PM · Restricted Project, Restricted Project
hctim added a comment to D139395: Add CFI integer types normalization.

Hey folks, looks like this caused a failure on the msan buildbot: https://lab.llvm.org/buildbot/#/builders/237/builds/785

Feb 2 2023, 3:46 PM · Restricted Project, Restricted Project
hctim committed rG10939d1d580b: [GWP-ASan] Remove thread clamping in tests. (authored by hctim).
[GWP-ASan] Remove thread clamping in tests.
Feb 2 2023, 3:40 PM · Restricted Project, Restricted Project
hctim closed D143221: [GWP-ASan] Remove thread clamping in tests..
Feb 2 2023, 3:40 PM · Restricted Project, Restricted Project
hctim requested review of D143221: [GWP-ASan] Remove thread clamping in tests..
Feb 2 2023, 3:21 PM · Restricted Project, Restricted Project

Feb 1 2023

hctim added a comment to D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility.

Hey, looks like this broke the x86_64-linux sanitizer buildbot: https://lab.llvm.org/buildbot/#/builders/37/builds/19910

Feb 1 2023, 4:19 PM · Restricted Project, Restricted Project
hctim added a comment to D143110: [mlgo] Make InteractiveModelRunner actually work with named pipes.

Hey, looks like this might've broken the windows sanitizer bots. Would you be able to take a look? https://lab.llvm.org/buildbot/#/builders/127/builds/43077

Feb 1 2023, 4:12 PM · Restricted Project, Restricted Project
hctim committed rG7e566a3d1117: Remove another unnecessary integer-check. (authored by hctim).
Remove another unnecessary integer-check.
Feb 1 2023, 3:09 PM · Restricted Project, Restricted Project
hctim committed rGb3b940d1501e: Remove unnecessary comparison. (authored by hctim).
Remove unnecessary comparison.
Feb 1 2023, 3:06 PM · Restricted Project, Restricted Project
hctim added a reverting change for rGbcc10817d556: Fix tsan problem where the per-thread shared_ptr() can be locked right before…: rG44003d719dd3: Revert "Fix tsan problem where the per-thread shared_ptr() can be locked right….
Feb 1 2023, 10:37 AM · Restricted Project, Restricted Project
hctim added a reverting change for D142394: Fix tsan problem where the per-thread shared_ptr() can be locked right before the cache is destroyed causing a race where it tries to remove an entry from a destroyed cache.: rG44003d719dd3: Revert "Fix tsan problem where the per-thread shared_ptr() can be locked right….
Feb 1 2023, 10:37 AM · Restricted Project, Restricted Project
hctim committed rG44003d719dd3: Revert "Fix tsan problem where the per-thread shared_ptr() can be locked right… (authored by hctim).
Revert "Fix tsan problem where the per-thread shared_ptr() can be locked right…
Feb 1 2023, 10:36 AM · Restricted Project, Restricted Project
hctim added a comment to D140931: Improve and enable folding of conditional branches with tail calls..

Ah, looks like you beat me to it. Thanks for reverting early :).

Feb 1 2023, 9:45 AM · Restricted Project, Restricted Project
hctim added a comment to D142394: Fix tsan problem where the per-thread shared_ptr() can be locked right before the cache is destroyed causing a race where it tries to remove an entry from a destroyed cache..

Hey, looks like this broke the asan-aarch64 buildbot. https://lab.llvm.org/buildbot/#/builders/239/builds/771

Feb 1 2023, 9:19 AM · Restricted Project, Restricted Project
hctim added a comment to D140931: Improve and enable folding of conditional branches with tail calls..

Hey, looks like this probably broke the ASan buildbot: https://lab.llvm.org/buildbot/#/builders/5/builds/31141/steps/13/logs/stdio

Feb 1 2023, 8:40 AM · Restricted Project, Restricted Project

Jan 31 2023

hctim committed rG486729ce06c1: Re-land: [MTE] Add AArch64GlobalsTagging Pass (authored by hctim).
Re-land: [MTE] Add AArch64GlobalsTagging Pass
Jan 31 2023, 1:04 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to rG04ed86ff1b72: [clang-format][NFC] Bring FormatTokenSource under test..

Hey, FYI - it looks like this broke the ASan buildbot:

Jan 31 2023, 12:35 PM · Restricted Project, Restricted Project
hctim added a reverting change for rG4edfcff71e15: [MTE] Add AArch64GlobalsTagging Pass: rG15e33c699cef: Revert "[MTE] Add AArch64GlobalsTagging Pass".
Jan 31 2023, 12:26 PM · Restricted Project, Restricted Project, Restricted Project
hctim committed rG15e33c699cef: Revert "[MTE] Add AArch64GlobalsTagging Pass" (authored by hctim).
Revert "[MTE] Add AArch64GlobalsTagging Pass"
Jan 31 2023, 12:26 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a comment to D133392: [MTE] Add AArch64GlobalsTagging Pass.

Hi @hctim, the test you added is failing on buildbots where AArch64 is not built, can you either update the test to not require that backend, or mark the test as requiring it?

https://lab.llvm.org/buildbot/#/builders/139/builds/35253

error: unable to create target: 'No available targets are compatible with triple "aarch64-unknown-linux-android31"'
1 error generated.
Jan 31 2023, 12:26 PM · Restricted Project, Restricted Project, Restricted Project
hctim added a reverting change for D133392: [MTE] Add AArch64GlobalsTagging Pass: rG15e33c699cef: Revert "[MTE] Add AArch64GlobalsTagging Pass".
Jan 31 2023, 12:26 PM · Restricted Project, Restricted Project, Restricted Project
hctim committed rG4edfcff71e15: [MTE] Add AArch64GlobalsTagging Pass (authored by hctim).
[MTE] Add AArch64GlobalsTagging Pass
Jan 31 2023, 9:26 AM · Restricted Project, Restricted Project, Restricted Project
hctim closed D133392: [MTE] Add AArch64GlobalsTagging Pass.
Jan 31 2023, 9:25 AM · Restricted Project, Restricted Project, Restricted Project
hctim updated the diff for D133392: [MTE] Add AArch64GlobalsTagging Pass.

Rebase for submit.

Jan 31 2023, 9:04 AM · Restricted Project, Restricted Project, Restricted Project

Jan 30 2023

hctim added a reverting change for rG7f0003c19c3a: [AIX][BigArchive] Treat the archive is empty if the first child member offset…: rG09a3aef0f8f4: Revert "[AIX][BigArchive] Treat the archive is empty if the first child member….
Jan 30 2023, 9:42 AM · Restricted Project, Restricted Project
hctim committed rG09a3aef0f8f4: Revert "[AIX][BigArchive] Treat the archive is empty if the first child member… (authored by hctim).
Revert "[AIX][BigArchive] Treat the archive is empty if the first child member…
Jan 30 2023, 9:42 AM · Restricted Project, Restricted Project
hctim added a reverting change for D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero: rG09a3aef0f8f4: Revert "[AIX][BigArchive] Treat the archive is empty if the first child member….
Jan 30 2023, 9:42 AM · Restricted Project, Restricted Project
hctim added a comment to D138986: [AIX][BigArchive] Treat the archive is empty if the first child member offset is zero.

Looks like this patch still causes errors on the ASan buildbot, even with D142883 patched in.

Jan 30 2023, 9:41 AM · Restricted Project, Restricted Project

Jan 19 2023

hctim added a comment to D140706: [scudo] Add the thread-safety annotations.

Thanks for the patch, I think this is a really good addition to scudo. Clearly you've found some bugs. An overall comment, there's a lot of mixed non-functional and functional changes here. For example, it's my understanding that this patch is primarily to add thread safety annotations, but there's functional changes in unmapTestOnly, malloc_info, and other places.

Jan 19 2023, 9:24 AM · Restricted Project, Restricted Project

Jan 17 2023

hctim committed rG35b5499d7259: Reland: [GWP-ASan] Add recoverable mode. (authored by hctim).
Reland: [GWP-ASan] Add recoverable mode.
Jan 17 2023, 10:21 AM · Restricted Project, Restricted Project
hctim closed D140173: [GWP-ASan] Add recoverable mode..
Jan 17 2023, 10:21 AM · Restricted Project, Restricted Project

Jan 13 2023

hctim updated the diff for D140173: [GWP-ASan] Add recoverable mode..

Update with some fixes discovered from internal testing:

Jan 13 2023, 6:10 PM · Restricted Project, Restricted Project

Jan 12 2023

hctim committed rG7cc12cb6c838: Revert "[GWP-ASan] Add recoverable mode." (authored by hctim).
Revert "[GWP-ASan] Add recoverable mode."
Jan 12 2023, 4:01 PM · Restricted Project, Restricted Project
hctim added a reverting change for rG90a9beb7cc97: [GWP-ASan] Add recoverable mode.: rG7cc12cb6c838: Revert "[GWP-ASan] Add recoverable mode.".
Jan 12 2023, 4:01 PM · Restricted Project, Restricted Project