User Details
- User Since
- Sep 8 2017, 3:58 PM (289 w, 6 d)
Today
Yesterday
This might've broken builds? Either that, or one of your other three patches.
No problems at all! In case you're not familiar, ODR is explained a little in our docs (and the other stuff that's linked there). Best bet to track it down is to figure out why llvm/lib/Support/ABIBreak.cpp is linked twice.
Already reverted in https://reviews.llvm.org/rG270067d69532448c4f6d7956e68d7a392857f9ce :)
Hi, looks like this re-land triggered an ASan-detected heap leak: https://lab.llvm.org/buildbot/#/builders/5/builds/32516
Hey, looks like this breaks check-sanitizer on all the bots. Easily reproducible on a vanilla build, just do check-sanitizer on something that builds compiler-rt.
Hi folks, looks like this broke ASan buildbots because of an ODR. Full reproduction instructions can be found at https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild (either using buildbot_fast.sh or buildbot_bootstrap_asan.sh), or alternatively this is quickly reproducible without a multi-stage build using my example cmake config below (which definitely has some stuff you don't need, like libc):
Mon, Mar 27
Hi, yep, I've reverted upstream. If you could please also integrate https://reviews.llvm.org/rG8c7c1f11ffaacf762e612c65440fd2cbb58ee426 in the relanding, that would be great.
Mon, Mar 20
Add some extra edge case tests.
Any ideas why this was IE in the first place? Don't see any notes in the patch that added it (https://reviews.llvm.org/D37156)?
Fri, Mar 17
Address jhenderson@'s comments.
Thu, Mar 9
Tue, Mar 7
Wed, Mar 1
Feb 28 2023
Address MaskRay and jhenderson's comments.
Feb 23 2023
Feb 21 2023
we don't support llvm-symbolizer and the default libbacktraace symbolizer does not support location info.
Feb 17 2023
@fmayer / @jhenderson / @MaskRay , would you folks mind taking a second pass? thanks.
Feb 15 2023
Update with jhenderson@'s comments: used arrayref in place of vector, some minor reformatting and renaming.
Feb 13 2023
Update the test a little to be explicit about warning/error, remove a newline.
Address Ray's comments.
Feb 10 2023
Add a comment describing the use of printNotesHelper.
Feb 9 2023
Add test that --memtag doesn't print non-MTE dynamic entries.
Feb 2 2023
Hey folks, looks like this caused a failure on the msan buildbot: https://lab.llvm.org/buildbot/#/builders/237/builds/785
Feb 1 2023
Hey, looks like this broke the x86_64-linux sanitizer buildbot: https://lab.llvm.org/buildbot/#/builders/37/builds/19910
Hey, looks like this might've broken the windows sanitizer bots. Would you be able to take a look? https://lab.llvm.org/buildbot/#/builders/127/builds/43077
Ah, looks like you beat me to it. Thanks for reverting early :).
Hey, looks like this broke the asan-aarch64 buildbot. https://lab.llvm.org/buildbot/#/builders/239/builds/771
Hey, looks like this probably broke the ASan buildbot: https://lab.llvm.org/buildbot/#/builders/5/builds/31141/steps/13/logs/stdio
Jan 31 2023
Hey, FYI - it looks like this broke the ASan buildbot:
Rebase for submit.
Jan 30 2023
Looks like this patch still causes errors on the ASan buildbot, even with D142883 patched in.
Jan 19 2023
Thanks for the patch, I think this is a really good addition to scudo. Clearly you've found some bugs. An overall comment, there's a lot of mixed non-functional and functional changes here. For example, it's my understanding that this patch is primarily to add thread safety annotations, but there's functional changes in unmapTestOnly, malloc_info, and other places.
Jan 17 2023
Jan 13 2023
Update with some fixes discovered from internal testing: