hctim (Mitch Phillips)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2017, 3:58 PM (6 w, 1 d)

Recent Activity

Fri, Oct 20

hctim updated the diff for D38427: Graph builder implementation..

Patched out x86 test changes.

Fri, Oct 20, 6:18 PM
hctim updated the diff for D38427: Graph builder implementation..

Rebased over master. Forgot to add the unit test patches to this CL.

Fri, Oct 20, 4:45 PM
hctim added inline comments to D38654: Parse DWARF information to reduce false positives..
Fri, Oct 20, 2:00 PM
hctim updated the diff for D38654: Parse DWARF information to reduce false positives..
  • Modified tool to ensure that users are aware that all statically linked libraries are required to be compiled with '-g'.
  • Removed type unit check (thanks probison)!
  • Changed opt<uint64_t> to opt<unsigned long long> (known issue with opt<uint64_t>).
  • Lexicographically sorted library names.
Fri, Oct 20, 2:00 PM
hctim updated the diff for D38428: Add FileVerifier::isCFIProtected()..

Added successful initialisation checks.

Fri, Oct 20, 1:25 PM
hctim updated the diff for D38428: Add FileVerifier::isCFIProtected()..

Vlad's comments & merged changes from the stack.

Fri, Oct 20, 1:25 PM
hctim added inline comments to D38427: Graph builder implementation..
Fri, Oct 20, 11:43 AM
hctim updated the diff for D38427: Graph builder implementation..

Updated with Vlad's comments. Also patched the unit tests to succeed when x86 targets are not built, instead of not compiling.

Fri, Oct 20, 11:43 AM
hctim added a comment to D38516: Updated 'Getting Started' to use valid git links (added trailing slashes).

Friendly ping.

Fri, Oct 20, 11:05 AM

Tue, Oct 17

hctim abandoned D39032: cfi1.
Tue, Oct 17, 6:46 PM
hctim created D39032: cfi1.
Tue, Oct 17, 6:46 PM
hctim added inline comments to D39020: Statically link llvm-cfi-verify's libraries..
Tue, Oct 17, 5:48 PM
hctim updated the diff for D39020: Statically link llvm-cfi-verify's libraries..
  • pcc@'s comments
Tue, Oct 17, 5:48 PM
hctim retitled D39020: Statically link llvm-cfi-verify's libraries. from Made shlib compile explicitly AFTER all tools. to Statically link llvm-cfi-verify's libraries..
Tue, Oct 17, 5:01 PM
hctim updated the diff for D39020: Statically link llvm-cfi-verify's libraries..

Explicitly made llvm-cfi-verify build its own library that is statically linked into CFIVerifyTests. The target is not linked into the dynamic library when LLVM_BUILD_LLVM_DYLIB is enabled.

Tue, Oct 17, 4:59 PM
hctim added a comment to D39020: Statically link llvm-cfi-verify's libraries..
In D39020#900124, @pcc wrote:

Does it not work to declare your library with add_library instead of add_llvm_library? Alternatively it looks like add_llvm_library has a BUILDTREE_ONLY flag that appears to do what is needed here.

Tue, Oct 17, 3:05 PM
hctim added a comment to D38379: Classify llvm-cfi-verify..

Just for closure, the fix for this build issue is located over at D39020. Please direct all discussion over there :)

Tue, Oct 17, 2:17 PM
hctim created D39020: Statically link llvm-cfi-verify's libraries..
Tue, Oct 17, 2:15 PM
hctim added a comment to D38379: Classify llvm-cfi-verify..

Just confirming that I can now reproduce this by forcing llvm-cfi-verify to build last in the provided glob of tools (simply add 'zzzzz' as a prefix to the directory name and boom!).

Tue, Oct 17, 11:37 AM
hctim added a comment to D38379: Classify llvm-cfi-verify..

Hey Serguei,

Tue, Oct 17, 12:00 AM

Mon, Oct 16

hctim updated the diff for D38981: Added SpecialCastList fuzzer..
  • morehouse@ comments.
Mon, Oct 16, 6:25 PM
hctim updated the summary of D38981: Added SpecialCastList fuzzer..
Mon, Oct 16, 3:55 PM
hctim created D38981: Added SpecialCastList fuzzer..
Mon, Oct 16, 3:53 PM
hctim added a comment to D38379: Classify llvm-cfi-verify..

Please note that this patch causes a build failure to me in case of usage -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON.
I'm trying to figure out whether it is my configuration problem or patch problem.

Could you please try to run LLVM build with -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON? May be it is reproducible on your side?

Mon, Oct 16, 10:05 AM

Fri, Oct 13

hctim updated the diff for D38427: Graph builder implementation..

Made GraphResult's members automatic storage duration.

Fri, Oct 13, 4:29 PM

Thu, Oct 12

hctim added a comment to D38855: Add a fuzz target for llvm's ItaniumDemangler..

Note, I've already found some bugs running this locally, but would love to get it up and running in oss-fuzz.

Thu, Oct 12, 1:11 PM
hctim updated the diff for D38855: Add a fuzz target for llvm's ItaniumDemangler..
  • Fuzzer updates with dummy main.
  • Added main() for dummy target.
  • Remove LIB_FUZZING_ENGINE target (morehouse@)
  • Added to fuzzer doc.
Thu, Oct 12, 1:10 PM
hctim updated the diff for D38855: Add a fuzz target for llvm's ItaniumDemangler..
  • kcc's comments
Thu, Oct 12, 11:23 AM
hctim updated the diff for D38855: Add a fuzz target for llvm's ItaniumDemangler..
  • Fixed line length
Thu, Oct 12, 10:53 AM
hctim updated the diff for D38855: Add a fuzz target for llvm's ItaniumDemangler..
  • Null-terminated the string (oops).
Thu, Oct 12, 10:52 AM
hctim created D38855: Add a fuzz target for llvm's ItaniumDemangler..
Thu, Oct 12, 10:47 AM

Wed, Oct 11

hctim updated the diff for D38427: Graph builder implementation..

Patched in previous changes to unit tests.

Wed, Oct 11, 1:36 PM
hctim updated the diff for D38424: MC Helpers for llvm-cfi-verify..

Merged unit test modifications up stack.

Wed, Oct 11, 1:18 PM
hctim updated the diff for D38379: Classify llvm-cfi-verify..

clang-format over everything.

Wed, Oct 11, 11:43 AM
hctim updated the diff for D38379: Classify llvm-cfi-verify..

/s/Verifier/Analysis

Wed, Oct 11, 11:39 AM
hctim updated the diff for D38379: Classify llvm-cfi-verify..

[code diff updated]

Wed, Oct 11, 11:38 AM
hctim reopened D38379: Classify llvm-cfi-verify..

Reopened for resubmission as it was rolled back in rL315370.

Wed, Oct 11, 11:38 AM

Tue, Oct 10

hctim requested review of D38516: Updated 'Getting Started' to use valid git links (added trailing slashes).

Friendly ping :)

Tue, Oct 10, 11:06 AM
hctim updated the diff for D38657: Update cl::opt<uint64_t> instances to cl::opt<unsigned long long>.

Merged previous changes in the stack.

Tue, Oct 10, 10:55 AM
hctim updated the diff for D38654: Parse DWARF information to reduce false positives..

Merged previous changes in the stack.

Tue, Oct 10, 10:53 AM
hctim updated the diff for D38428: Add FileVerifier::isCFIProtected()..

Merged updates from stack.

Tue, Oct 10, 10:44 AM
hctim updated the diff for D38427: Graph builder implementation..

Merged updates from stack.

Tue, Oct 10, 10:44 AM
hctim updated the diff for D38424: MC Helpers for llvm-cfi-verify..

Merged updates from stack.

Tue, Oct 10, 10:43 AM
hctim updated the diff for D38379: Classify llvm-cfi-verify..

Added assertions on instruction insertion.

Tue, Oct 10, 10:42 AM

Mon, Oct 9

hctim added inline comments to D38428: Add FileVerifier::isCFIProtected()..
Mon, Oct 9, 12:45 PM
hctim updated the diff for D38428: Add FileVerifier::isCFIProtected()..

Updated from Vlad's comments.

Mon, Oct 9, 12:44 PM
hctim updated the diff for D38427: Graph builder implementation..

Backported usesRegisterOperand.

Mon, Oct 9, 12:39 PM
hctim updated the diff for D38424: MC Helpers for llvm-cfi-verify..

Backported usesRegisterOperand.

Mon, Oct 9, 12:38 PM
hctim updated the diff for D38379: Classify llvm-cfi-verify..

Backported usesRegisterOperand.

Mon, Oct 9, 12:36 PM
hctim added inline comments to D38427: Graph builder implementation..
Mon, Oct 9, 12:29 PM
hctim updated the diff for D38427: Graph builder implementation..

Updated with Vlad's comments.

Mon, Oct 9, 12:29 PM
hctim updated the diff for D38424: MC Helpers for llvm-cfi-verify..

Updated from Vlad's comments

Mon, Oct 9, 10:08 AM
hctim updated the diff for D38379: Classify llvm-cfi-verify..

Updated for Vlad's comments round 2.

Mon, Oct 9, 9:56 AM
hctim added inline comments to D38379: Classify llvm-cfi-verify..
Mon, Oct 9, 9:56 AM

Fri, Oct 6

hctim added a dependent revision for D38657: Update cl::opt<uint64_t> instances to cl::opt<unsigned long long>: D38658: [cfi-verify] Add an interesting unit test where undef search length changes result..
Fri, Oct 6, 6:01 PM
hctim added a dependency for D38658: [cfi-verify] Add an interesting unit test where undef search length changes result.: D38657: Update cl::opt<uint64_t> instances to cl::opt<unsigned long long>.
Fri, Oct 6, 6:01 PM
hctim created D38658: [cfi-verify] Add an interesting unit test where undef search length changes result..
Fri, Oct 6, 6:01 PM
hctim added a dependency for D38657: Update cl::opt<uint64_t> instances to cl::opt<unsigned long long>: D38654: Parse DWARF information to reduce false positives..
Fri, Oct 6, 5:57 PM
hctim added a dependent revision for D38654: Parse DWARF information to reduce false positives.: D38657: Update cl::opt<uint64_t> instances to cl::opt<unsigned long long>.
Fri, Oct 6, 5:57 PM
hctim created D38657: Update cl::opt<uint64_t> instances to cl::opt<unsigned long long>.
Fri, Oct 6, 5:57 PM
hctim updated the diff for D38654: Parse DWARF information to reduce false positives..

backported a clang-format

Fri, Oct 6, 5:52 PM
hctim updated the diff for D38428: Add FileVerifier::isCFIProtected()..

format was from prev in stack, put it down there.

Fri, Oct 6, 5:25 PM
hctim updated the diff for D38427: Graph builder implementation..

format was from prev in stack, put it down there.

Fri, Oct 6, 5:24 PM
hctim updated the diff for D38424: MC Helpers for llvm-cfi-verify..

clang format

Fri, Oct 6, 5:24 PM
hctim updated the diff for D38428: Add FileVerifier::isCFIProtected()..

clang-format

Fri, Oct 6, 5:22 PM
hctim updated the summary of D38654: Parse DWARF information to reduce false positives..
Fri, Oct 6, 5:17 PM
hctim added a dependent revision for D38428: Add FileVerifier::isCFIProtected().: D38654: Parse DWARF information to reduce false positives..
Fri, Oct 6, 5:16 PM
hctim added a dependency for D38654: Parse DWARF information to reduce false positives.: D38428: Add FileVerifier::isCFIProtected()..
Fri, Oct 6, 5:16 PM
hctim created D38654: Parse DWARF information to reduce false positives..
Fri, Oct 6, 5:16 PM

Thu, Oct 5

hctim updated the diff for D38428: Add FileVerifier::isCFIProtected()..

Backported D38564

Thu, Oct 5, 1:51 PM
hctim abandoned D38564: llvm-cfi-verify fixed GraphBuilder memory leak..

Backpatched into D38427.

Thu, Oct 5, 1:50 PM
hctim updated the diff for D38427: Graph builder implementation..

Backported D38564

Thu, Oct 5, 1:50 PM

Wed, Oct 4

hctim added a dependent revision for D38428: Add FileVerifier::isCFIProtected().: D38564: llvm-cfi-verify fixed GraphBuilder memory leak..
Wed, Oct 4, 3:01 PM
hctim added a dependency for D38564: llvm-cfi-verify fixed GraphBuilder memory leak.: D38428: Add FileVerifier::isCFIProtected()..
Wed, Oct 4, 3:01 PM
hctim created D38564: llvm-cfi-verify fixed GraphBuilder memory leak..
Wed, Oct 4, 3:01 PM
hctim added inline comments to D38428: Add FileVerifier::isCFIProtected()..
Wed, Oct 4, 2:34 PM
hctim updated the diff for D38428: Add FileVerifier::isCFIProtected()..

Fixed issues from Vlad's comments.

Wed, Oct 4, 2:34 PM
hctim updated the diff for D38427: Graph builder implementation..

Added header to GraphBuilder.cpp

Wed, Oct 4, 2:32 PM
hctim added inline comments to D38427: Graph builder implementation..
Wed, Oct 4, 2:01 PM
hctim updated the diff for D38427: Graph builder implementation..

Updated to fix vlad's comments.

Wed, Oct 4, 2:01 PM
hctim updated the diff for D38424: MC Helpers for llvm-cfi-verify..

Merge prev in stack.

Wed, Oct 4, 1:18 PM
hctim updated the diff for D38379: Classify llvm-cfi-verify..
  • Added file header.
Wed, Oct 4, 1:17 PM
hctim updated subscribers of D38427: Graph builder implementation..
Wed, Oct 4, 1:15 PM
hctim updated the diff for D38427: Graph builder implementation..

Merged changes from upstream.

Wed, Oct 4, 1:14 PM
hctim updated the diff for D38427: Graph builder implementation..

Merged wrong CL, putting this back to the way it should be.

Wed, Oct 4, 1:10 PM
hctim added inline comments to D38424: MC Helpers for llvm-cfi-verify..
Wed, Oct 4, 1:09 PM
hctim updated the diff for D38424: MC Helpers for llvm-cfi-verify..

Merged changes from previous in stack, updated for vlad.tsyrklevich's comments.

Wed, Oct 4, 1:08 PM
hctim updated the diff for D38427: Graph builder implementation..

Merged changes from previous in stack, updated for vlad.tsyrklevich's comments.

Wed, Oct 4, 1:08 PM
hctim added inline comments to D38379: Classify llvm-cfi-verify..
Wed, Oct 4, 12:47 PM
hctim updated the diff for D38379: Classify llvm-cfi-verify..
  • /s/FileVerifier/FileAnalysis, removed Instr::SectionName, other comments from vlad.tsyrklevich
Wed, Oct 4, 12:47 PM

Tue, Oct 3

hctim abandoned D38515: Fix ISO C++ fnptr -> objptr errors..
Tue, Oct 3, 4:25 PM
hctim added a comment to D38515: Fix ISO C++ fnptr -> objptr errors..

FYI: current default LLVM build errors list:

Tue, Oct 3, 3:59 PM
hctim updated the diff for D38516: Updated 'Getting Started' to use valid git links (added trailing slashes).
  • Buggered up some llvm.git references, fixed them.
Tue, Oct 3, 3:56 PM
hctim updated the diff for D38516: Updated 'Getting Started' to use valid git links (added trailing slashes).
  • Fixed llvm git references to point to non-redirected links.
Tue, Oct 3, 3:55 PM
hctim added a comment to D38515: Fix ISO C++ fnptr -> objptr errors..
In D38515#887573, @pcc wrote:

What's the motivation for this patch? Are you trying to make LLVM compile with -Wpedantic? Is this the only issue, or are there others?

Tue, Oct 3, 3:51 PM
hctim created D38516: Updated 'Getting Started' to use valid git links (added trailing slashes).
Tue, Oct 3, 2:22 PM
hctim created D38515: Fix ISO C++ fnptr -> objptr errors..
Tue, Oct 3, 2:14 PM

Mon, Oct 2

hctim updated the diff for D38428: Add FileVerifier::isCFIProtected()..

Fixed warnings.

Mon, Oct 2, 4:45 PM
hctim updated the diff for D38427: Graph builder implementation..

Fix various warnings.

Mon, Oct 2, 4:41 PM
hctim updated the diff for D38424: MC Helpers for llvm-cfi-verify..

Fix gtest unsigned/signed comparison warnings.

Mon, Oct 2, 4:33 PM