Page MenuHomePhabricator

hctim (Mitch Phillips)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 8 2017, 3:58 PM (102 w, 2 d)

Recent Activity

Fri, Aug 23

hctim added a comment to D66494: [GWP-ASan] Build stack_trace_compressor_fuzzer..

@vitalybuka: Maybe rL369823?

Fri, Aug 23, 6:37 PM · Restricted Project, Restricted Project
hctim committed rG27d69b2f4f6b: [GWP-ASan] Split options_parser and backtrace_sanitizer_common. (authored by hctim).
[GWP-ASan] Split options_parser and backtrace_sanitizer_common.
Fri, Aug 23, 4:25 PM
hctim committed rL369825: [GWP-ASan] Split options_parser and backtrace_sanitizer_common..
[GWP-ASan] Split options_parser and backtrace_sanitizer_common.
Fri, Aug 23, 4:23 PM
hctim closed D66684: [GWP-ASan] Split options_parser and backtrace_sanitizer_common..
Fri, Aug 23, 4:22 PM · Restricted Project, Restricted Project
hctim updated the diff for D66684: [GWP-ASan] Split options_parser and backtrace_sanitizer_common..

Merge branch 'master' into gwp_asan/glibc_printf in prep for submission.

Fri, Aug 23, 4:22 PM · Restricted Project, Restricted Project
hctim committed rG05bc1468c2f4: Fix stack_trace_compressor builds for Clang < 6.0 (authored by hctim).
Fix stack_trace_compressor builds for Clang < 6.0
Fri, Aug 23, 4:14 PM
hctim committed rL369823: Fix stack_trace_compressor builds for Clang < 6.0.
Fix stack_trace_compressor builds for Clang < 6.0
Fri, Aug 23, 4:14 PM
hctim closed D66682: Fix stack_trace_compressor builds for Clang < 6.0.
Fri, Aug 23, 4:14 PM · Restricted Project, Restricted Project
hctim created D66684: [GWP-ASan] Split options_parser and backtrace_sanitizer_common..
Fri, Aug 23, 2:13 PM · Restricted Project, Restricted Project
hctim created D66682: Fix stack_trace_compressor builds for Clang < 6.0.
Fri, Aug 23, 1:40 PM · Restricted Project, Restricted Project

Wed, Aug 21

hctim created D66568: [GWP-ASan] Remove c++ standard lib dependency..
Wed, Aug 21, 5:05 PM · Restricted Project, Restricted Project
hctim added a comment to D62875: [GWP-ASan] Add public-facing documentation [6]..

The docs don't build and rL369554 doesn't fully fix it

$ ninja docs-llvm-html
[1/1] Generating html Sphinx documentation
FAILED: docs/CMakeFiles/docs-llvm-html

Warning, treated as error:
llvm/docs/GwpAsan.rst:document isn't included in any toctree
ninja: build stopped: subcommand failed.

Submitted rL369556 to temporarily make docs build again. However that basically suppresses the warning; you likely want to put it in a toctree instead of making it an orphan doc, e.g. https://reviews.llvm.org/D66183#change-D4KqPHFormwF

Wed, Aug 21, 11:38 AM · Restricted Project, Restricted Project
hctim committed rG84b762af3b54: [docs] Add GwpAsan to toctree. (authored by hctim).
[docs] Add GwpAsan to toctree.
Wed, Aug 21, 11:32 AM
hctim added a reverting change for rL369556: [docs] Fix GwpAsan.rst: rL369560: [docs] Add GwpAsan to toctree..
Wed, Aug 21, 11:31 AM
hctim committed rL369560: [docs] Add GwpAsan to toctree..
[docs] Add GwpAsan to toctree.
Wed, Aug 21, 11:31 AM
hctim committed rG2213bbb57aa7: Add newline to GWP-ASan sphinx document. Should fix the document builder. (authored by hctim).
Add newline to GWP-ASan sphinx document. Should fix the document builder.
Wed, Aug 21, 11:05 AM
hctim committed rL369554: Add newline to GWP-ASan sphinx document..
Add newline to GWP-ASan sphinx document.
Wed, Aug 21, 11:05 AM
hctim committed rGc776f3f3c26f: [GWP-ASan] Add public-facing documentation [6]. (authored by hctim).
[GWP-ASan] Add public-facing documentation [6].
Wed, Aug 21, 10:55 AM
hctim committed rGf9269b5396c1: [GWP-ASan] Build stack_trace_compressor_fuzzer. (authored by hctim).
[GWP-ASan] Build stack_trace_compressor_fuzzer.
Wed, Aug 21, 10:55 AM
hctim committed rL369552: [GWP-ASan] Add public-facing documentation [6]..
[GWP-ASan] Add public-facing documentation [6].
Wed, Aug 21, 10:54 AM
hctim closed D62875: [GWP-ASan] Add public-facing documentation [6]..
Wed, Aug 21, 10:54 AM · Restricted Project, Restricted Project
hctim committed rL369551: [GWP-ASan] Build stack_trace_compressor_fuzzer..
[GWP-ASan] Build stack_trace_compressor_fuzzer.
Wed, Aug 21, 10:54 AM
hctim closed D66494: [GWP-ASan] Build stack_trace_compressor_fuzzer..
Wed, Aug 21, 10:54 AM · Restricted Project, Restricted Project

Tue, Aug 20

hctim updated the diff for D66494: [GWP-ASan] Build stack_trace_compressor_fuzzer..
  • Reverse order of fuzzer dependencies.
Tue, Aug 20, 6:01 PM · Restricted Project, Restricted Project
hctim added inline comments to D66494: [GWP-ASan] Build stack_trace_compressor_fuzzer..
Tue, Aug 20, 6:01 PM · Restricted Project, Restricted Project
hctim added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Tue, Aug 20, 4:48 PM · Restricted Project, Restricted Project
hctim created D66494: [GWP-ASan] Build stack_trace_compressor_fuzzer..
Tue, Aug 20, 1:37 PM · Restricted Project, Restricted Project
hctim committed rG8f5e1755ca38: [GWP-ASan] Fix typos. (authored by hctim).
[GWP-ASan] Fix typos.
Tue, Aug 20, 1:18 PM
hctim committed rL369433: [GWP-ASan] Fix typos..
[GWP-ASan] Fix typos.
Tue, Aug 20, 1:17 PM
hctim closed D66311: [GWP-ASan] Fix typos..
Tue, Aug 20, 1:17 PM · Restricted Project, Restricted Project
hctim added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Tue, Aug 20, 1:09 PM · Restricted Project, Restricted Project

Mon, Aug 19

hctim updated the diff for D62875: [GWP-ASan] Add public-facing documentation [6]..
  • Update from Matt's comments.
Mon, Aug 19, 4:14 PM · Restricted Project, Restricted Project
hctim added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Mon, Aug 19, 4:14 PM · Restricted Project, Restricted Project
hctim accepted D66231: [scudo][standalone] Fix malloc_iterate.

LGTM. Thanks :)

Mon, Aug 19, 3:10 PM · Restricted Project, Restricted Project
hctim added inline comments to D66231: [scudo][standalone] Fix malloc_iterate.
Mon, Aug 19, 2:18 PM · Restricted Project, Restricted Project

Thu, Aug 15

hctim committed rGeffc28c1398d: Disable stack_trace_compressor_fuzzer. (authored by hctim).
Disable stack_trace_compressor_fuzzer.
Thu, Aug 15, 7:04 PM
hctim committed rL369079: Disable stack_trace_compressor_fuzzer..
Disable stack_trace_compressor_fuzzer.
Thu, Aug 15, 7:04 PM
hctim added a comment to D66189: [GWP-ASan] Implement stack frame compression..

Commit is still causing some build issues. I'll take a look shortly and rollback if necessary.

Thu, Aug 15, 6:35 PM · Restricted Project, Restricted Project
hctim added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Thu, Aug 15, 5:08 PM · Restricted Project, Restricted Project
hctim updated the diff for D62875: [GWP-ASan] Add public-facing documentation [6]..
  • Addressed Matt's and Vlad's comments.
  • Updated memory overhead description in the docs.
Thu, Aug 15, 5:08 PM · Restricted Project, Restricted Project
hctim committed rG4660ea953e55: Moved binary off add_llvm_executable. Used add_executable instead, as this… (authored by hctim).
Moved binary off add_llvm_executable. Used add_executable instead, as this…
Thu, Aug 15, 4:50 PM
hctim committed rL369071: Moved binary off add_llvm_executable..
Moved binary off add_llvm_executable.
Thu, Aug 15, 4:50 PM
hctim committed rG4be5d53a3322: Re-instate 369051. (authored by hctim).
Re-instate 369051.
Thu, Aug 15, 4:31 PM
hctim added a comment to D66189: [GWP-ASan] Implement stack frame compression..

Looks like rL369051 was accidentally reverted by rL369055. Have fixed it in rL369067.

Thu, Aug 15, 4:31 PM · Restricted Project, Restricted Project
hctim committed rL369067: Re-instate 369051..
Re-instate 369051.
Thu, Aug 15, 4:27 PM
hctim added a comment to D66189: [GWP-ASan] Implement stack frame compression..

Hi. We believe this patch is causing a CMake error for out toolchian build:

-- Compiler-RT supported architectures: i386
CMake Error at /b/s/w/ir/k/llvm-project/compiler-rt/lib/gwp_asan/CMakeLists.txt:111 (target_link_options):
  Unknown CMake command "target_link_options".

Could you look into this? Thanks.

Thu, Aug 15, 4:03 PM · Restricted Project, Restricted Project
hctim committed rG2fb4e754c64a: Guard fuzzer build behind Clang-only flags. (authored by hctim).
Guard fuzzer build behind Clang-only flags.
Thu, Aug 15, 3:16 PM
hctim committed rL369055: Guard fuzzer build behind Clang-only flags..
Guard fuzzer build behind Clang-only flags.
Thu, Aug 15, 3:15 PM
hctim created D66311: [GWP-ASan] Fix typos..
Thu, Aug 15, 2:46 PM · Restricted Project, Restricted Project
hctim committed rGfdee340beabd: Remove CMake >= v3.13 target_link_options. Instead, use set_target_properties. (authored by hctim).
Remove CMake >= v3.13 target_link_options. Instead, use set_target_properties.
Thu, Aug 15, 2:37 PM
hctim committed rL369051: Remove CMake >= v3.13 target_link_options..
Remove CMake >= v3.13 target_link_options.
Thu, Aug 15, 2:33 PM
hctim committed rGbe8a2f75657b: [GWP-ASan] Implement stack frame compression. (authored by hctim).
[GWP-ASan] Implement stack frame compression.
Thu, Aug 15, 2:09 PM
hctim committed rL369048: [GWP-ASan] Implement stack frame compression..
[GWP-ASan] Implement stack frame compression.
Thu, Aug 15, 2:09 PM
hctim closed D66189: [GWP-ASan] Implement stack frame compression..
Thu, Aug 15, 2:09 PM · Restricted Project, Restricted Project
hctim added inline comments to D66189: [GWP-ASan] Implement stack frame compression..
Thu, Aug 15, 1:20 PM · Restricted Project, Restricted Project
hctim updated the diff for D66189: [GWP-ASan] Implement stack frame compression..
  • Removed ability to set trace length.
Thu, Aug 15, 1:20 PM · Restricted Project, Restricted Project
hctim added inline comments to D66189: [GWP-ASan] Implement stack frame compression..
Thu, Aug 15, 12:41 PM · Restricted Project, Restricted Project
hctim added inline comments to D66189: [GWP-ASan] Implement stack frame compression..
Thu, Aug 15, 11:05 AM · Restricted Project, Restricted Project
hctim updated the diff for D66189: [GWP-ASan] Implement stack frame compression..
  • Updated with Vlad's comments.
Thu, Aug 15, 11:05 AM · Restricted Project, Restricted Project

Wed, Aug 14

hctim added inline comments to D66231: [scudo][standalone] Fix malloc_iterate.
Wed, Aug 14, 11:19 AM · Restricted Project, Restricted Project

Tue, Aug 13

hctim created D66189: [GWP-ASan] Implement stack frame compression..
Tue, Aug 13, 5:15 PM · Restricted Project, Restricted Project

Mon, Aug 12

hctim committed rG352d1b59c0c8: [GWP-ASan] Update backtrace function signature. (authored by hctim).
[GWP-ASan] Update backtrace function signature.
Mon, Aug 12, 2:40 PM
hctim committed rL368619: [GWP-ASan] Update backtrace function signature..
[GWP-ASan] Update backtrace function signature.
Mon, Aug 12, 2:36 PM
hctim closed D66099: [GWP-ASan] Update backtrace function signature..
Mon, Aug 12, 2:35 PM · Restricted Project, Restricted Project
hctim added inline comments to D66099: [GWP-ASan] Update backtrace function signature..
Mon, Aug 12, 2:07 PM · Restricted Project, Restricted Project
hctim updated the diff for D66099: [GWP-ASan] Update backtrace function signature..
  • Update comment format.
Mon, Aug 12, 2:07 PM · Restricted Project, Restricted Project
hctim created D66099: [GWP-ASan] Update backtrace function signature..
Mon, Aug 12, 11:20 AM · Restricted Project, Restricted Project

Fri, Aug 9

hctim committed rGcace571c91ce: Revert "[asan_symbolize] Fix bug where the frame counter was not incremented." (authored by hctim).
Revert "[asan_symbolize] Fix bug where the frame counter was not incremented."
Fri, Aug 9, 12:38 PM
hctim added a reverting change for rG52a36fae2a3f: [asan_symbolize] Fix bug where the frame counter was not incremented.: rGcace571c91ce: Revert "[asan_symbolize] Fix bug where the frame counter was not incremented.".
Fri, Aug 9, 12:37 PM
hctim committed rL368472: Revert "[asan_symbolize] Fix bug where the frame counter was not incremented.".
Revert "[asan_symbolize] Fix bug where the frame counter was not incremented."
Fri, Aug 9, 12:36 PM
hctim added a comment to rL368373: [asan_symbolize] Fix bug where the frame counter was not incremented..

Looks like this may have broken the sanitizer-android buildbot: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/23393

Fri, Aug 9, 11:47 AM
hctim accepted D66020: [libFuzzer] Merge: print stats after reading the output corpus dir..
Fri, Aug 9, 11:18 AM · Restricted Project, Restricted Project

Wed, Aug 7

hctim committed rGc96387fce36b: [HWASan] Use LLD for check-hwasan. (authored by hctim).
[HWASan] Use LLD for check-hwasan.
Wed, Aug 7, 3:00 PM
hctim committed rL368218: [HWASan] Use LLD for check-hwasan..
[HWASan] Use LLD for check-hwasan.
Wed, Aug 7, 3:00 PM

Tue, Aug 6

hctim added a comment to rL368112: Added Delta IR Reduction Tool.

Broken on sanitizer-x86_64-linux-bootstrap-msan:

Tue, Aug 6, 5:51 PM
hctim added a comment to D63672: Added Delta IR Reduction Tool.

rL368112 Still broken on sanitizer-x86_64-linux-bootstrap-msan:

Tue, Aug 6, 5:51 PM · Restricted Project
hctim committed rG924359dc0f98: Revert "[X86] Add more extract subvector cost model tests for smaller element… (authored by hctim).
Revert "[X86] Add more extract subvector cost model tests for smaller element…
Tue, Aug 6, 4:43 PM
hctim added a reverting change for rGfc33e33776b7: [X86] Add more extract subvector cost model tests for smaller element sizes and…: rG924359dc0f98: Revert "[X86] Add more extract subvector cost model tests for smaller element….
Tue, Aug 6, 4:43 PM
hctim committed rG5b6785aca2da: Regenerate mmx-arith.ll. (authored by hctim).
Regenerate mmx-arith.ll.
Tue, Aug 6, 4:43 PM
hctim committed rL368110: Regenerate mmx-arith.ll..
Regenerate mmx-arith.ll.
Tue, Aug 6, 4:43 PM
hctim committed rL368109: Revert "[X86] Add more extract subvector cost model tests for smaller element….
Revert "[X86] Add more extract subvector cost model tests for smaller element…
Tue, Aug 6, 4:43 PM
hctim committed rGbd0d97e1c41f: Revert "[X86] Enable -x86-experimental-vector-widening-legalization by default." (authored by hctim).
Revert "[X86] Enable -x86-experimental-vector-widening-legalization by default."
Tue, Aug 6, 4:01 PM
hctim added a reverting change for rG3de33245d2c9: [X86] Enable -x86-experimental-vector-widening-legalization by default.: rGbd0d97e1c41f: Revert "[X86] Enable -x86-experimental-vector-widening-legalization by default.".
Tue, Aug 6, 4:01 PM
hctim committed rG2f908c1436b5: Revert "[X86] Remove uses of the -x86-experimental-vector-widening-legalization… (authored by hctim).
Revert "[X86] Remove uses of the -x86-experimental-vector-widening-legalization…
Tue, Aug 6, 4:01 PM
hctim committed rL368107: Revert "[X86] Enable -x86-experimental-vector-widening-legalization by default.".
Revert "[X86] Enable -x86-experimental-vector-widening-legalization by default."
Tue, Aug 6, 4:01 PM
hctim added a reverting change for rG3f572c7b8405: [X86] Remove uses of the -x86-experimental-vector-widening-legalization flag…: rG2f908c1436b5: Revert "[X86] Remove uses of the -x86-experimental-vector-widening-legalization….
Tue, Aug 6, 4:01 PM
hctim committed rL368106: Revert "[X86] Remove uses of the -x86-experimental-vector-widening-legalization….
Revert "[X86] Remove uses of the -x86-experimental-vector-widening-legalization…
Tue, Aug 6, 4:00 PM
hctim added a comment to rL367901: [X86] Enable -x86-experimental-vector-widening-legalization by default..

First build in which the error is seen: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/13942

Tue, Aug 6, 3:36 PM
hctim added a comment to rL367901: [X86] Enable -x86-experimental-vector-widening-legalization by default..

It looks like this commit has broken the sanitizer-x86_64-linux-bootstrap-msan bot with the error below. Unfortunately this was fairly hidden over the last few days as there's been a cascading set of failures on the sanitizer bots that has occluded this error from the limelight.

Tue, Aug 6, 3:31 PM

Mon, Aug 5

hctim accepted D65768: hwasan: Untag global variable addresses in tests..

LGTM with nits.

Mon, Aug 5, 2:34 PM · Restricted Project, Restricted Project
hctim added a comment to D65768: hwasan: Untag global variable addresses in tests..

Understood. I'm not the biggest fan of putting macros all around the codebase - could we define our own ErrorPrintf()/Printf()/strcmp() and explicitly untag there? I think relying on explicit untagging everywhere may be error-prone, and it looks like we can reduce the mental overhead of remembering to explicitly untag.

Mon, Aug 5, 1:37 PM · Restricted Project, Restricted Project
hctim added a comment to D65768: hwasan: Untag global variable addresses in tests..

Instead of putting UNTAG everywhere, could we change %clang_hwasan to instead have globals instrumentation disabled, then only use UNTAG in the hwasan_globals tests? WDYT?

Mon, Aug 5, 1:13 PM · Restricted Project, Restricted Project
hctim accepted D65769: llvm-symbolizer: Untag addresses in object files by default..
Mon, Aug 5, 1:01 PM · Restricted Project

Jul 22 2019

hctim updated the diff for D62875: [GWP-ASan] Add public-facing documentation [6]..
  • Updated from Matt's comments. Thanks Matt for taking a look on short notice :)
Jul 22 2019, 6:29 PM · Restricted Project, Restricted Project
hctim added inline comments to D62875: [GWP-ASan] Add public-facing documentation [6]..
Jul 22 2019, 6:29 PM · Restricted Project, Restricted Project
hctim updated the diff for D62875: [GWP-ASan] Add public-facing documentation [6]..
  • Added GWP-ASan symbolization example and script.
Jul 22 2019, 4:06 PM · Restricted Project, Restricted Project

Jul 16 2019

hctim committed rGb157dcacb5b9: [GWP-ASan] Add thread ID to PRNG seed. (authored by hctim).
[GWP-ASan] Add thread ID to PRNG seed.
Jul 16 2019, 1:08 PM
hctim committed rL366253: [GWP-ASan] Add thread ID to PRNG seed..
[GWP-ASan] Add thread ID to PRNG seed.
Jul 16 2019, 1:06 PM
hctim closed D64453: [GWP-ASan] Add thread ID to PRNG seed..
Jul 16 2019, 1:06 PM · Restricted Project, Restricted Project
hctim committed rG97b4d7a8e14f: Removed -mno-omit-leaf-frame-pointer from flags. (authored by hctim).
Removed -mno-omit-leaf-frame-pointer from flags.
Jul 16 2019, 10:15 AM