Page MenuHomePhabricator

ddunbar (Daniel Dunbar)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2012, 3:27 PM (344 w, 5 d)

Recent Activity

Jan 3 2019

ddunbar committed rL350372: Adopt SwiftABIInfo for WebAssembly..
Adopt SwiftABIInfo for WebAssembly.
Jan 3 2019, 3:28 PM
ddunbar committed rC350372: Adopt SwiftABIInfo for WebAssembly..
Adopt SwiftABIInfo for WebAssembly.
Jan 3 2019, 3:28 PM
ddunbar closed D56188: Adopt SwiftABIInfo for WebAssembly..
Jan 3 2019, 3:28 PM
ddunbar added a comment to D56188: Adopt SwiftABIInfo for WebAssembly..

...although it might be reasonable to extract the method implementations on DefaultABIInfo as helper functions so that the code can be reused without requiring a particular inheritance hierarchy.

Jan 3 2019, 1:06 PM

Jan 1 2019

ddunbar created D56188: Adopt SwiftABIInfo for WebAssembly..
Jan 1 2019, 2:30 PM

Oct 18 2018

ddunbar added inline comments to D53354: [WIP][NOT FOR COMMIT][PROTOTYPE] clang-scan-deps: dependency scanning tool rough prototype.
Oct 18 2018, 10:18 AM · Restricted Project

Apr 23 2018

ddunbar added a comment to D30882: Add a callback for __has_include and use it for dependency scanning.

I don't think this is quite right. I know at least make-based incremental builds wouldn't deal well with this.

Apr 23 2018, 7:53 AM

Oct 12 2017

ddunbar resigned from D38021: [Compiler-rt][MIPS] Fix cross build for XRAY.
Oct 12 2017, 8:32 AM
ddunbar accepted D38207: lit.py: Add new %{shared_output(LABEL)} substitution.

LGTM, thanks!

Oct 12 2017, 8:31 AM
ddunbar abandoned D20721: [lit] Factor out a helper for shell command results..
Oct 12 2017, 8:30 AM
ddunbar added a comment to D33271: lit: allow glob patterns as path arguments.

What is the motivation for using this, over using the --filter option? I have found --filter to be substantially more general and it is easier for us to support, so my preference would be to move it to be the standard way of solving this problem.

Oct 12 2017, 8:29 AM

Jul 13 2017

ddunbar accepted D35330: [LIT] add a -vv option to echo all executed commands.

LGTM, with one inline request, thanks!

Jul 13 2017, 12:05 PM

Jul 6 2017

ddunbar accepted D35091: Modify LIT to accept environment variable LIT_FILTER to select tests..

LGTM

Jul 6 2017, 4:45 PM

Jan 17 2017

ddunbar added inline comments to D28789: [lit] Support sharding testsuites, for parallel execution..
Jan 17 2017, 2:01 PM
ddunbar resigned from D24921: [cfe] [Headers] Fix inttypes.h macros visibility in C++ with C99-compliant libc.
Jan 17 2017, 11:38 AM
ddunbar resigned from D25402: [Driver] Pass -lunwind along with compiler-rt when necessary on Linux.
Jan 17 2017, 11:38 AM
ddunbar resigned from D28146: [compiler-rt] [test] [builtins] Remove obsolete/UB tests in __fixuns?fdi based.
Jan 17 2017, 11:37 AM
ddunbar accepted D28789: [lit] Support sharding testsuites, for parallel execution..

LGTM, this seems like a great idea!

Jan 17 2017, 11:37 AM
ddunbar resigned from D28796: Use filename in linemarker when compiling preprocessed source.
Jan 17 2017, 11:35 AM

Dec 17 2016

ddunbar added a comment to D27893: [lit] Fix shtest-format test on Windows.

Why don't we make this use an script we define to test the failure mode, rather than depend on an external tool, to make the test more reliable.

Dec 17 2016, 11:19 PM

Oct 20 2016

ddunbar added inline comments to rL284077: Moving to GitHub - Unified Proposal.
Oct 20 2016, 8:23 PM

Oct 9 2016

ddunbar accepted D25400: [lit] Remove Python 2.6 and below exec workaround.
Oct 9 2016, 5:05 PM
ddunbar resigned from D24933: Enable configuration files in clang.
Oct 9 2016, 5:04 PM
ddunbar accepted D25407: [lit] Remove (or allow specific) unused imports.
Oct 9 2016, 5:04 PM
ddunbar accepted D25408: [lit] Remove unused variable in googletest format.
Oct 9 2016, 5:03 PM
ddunbar accepted D25409: [lit] Remove semicolons in Python code.
Oct 9 2016, 5:03 PM
ddunbar accepted D25415: [lit] Remove unused TestingProgressDisplay attr.
Oct 9 2016, 5:03 PM
ddunbar accepted D25410: [lit] Fix undefined symbol ArgumentError.
Oct 9 2016, 5:02 PM

Oct 5 2016

ddunbar accepted D22144: [lit] add support for unsetting environment variable.

LGTM

Oct 5 2016, 3:22 PM

Oct 4 2016

ddunbar added a comment to D25138: [LIT] Add option to require PRs for XFAIL directives.

Cute, I like the idea.

Oct 4 2016, 10:40 AM

Sep 27 2016

ddunbar added a comment to D24968: [lit] Add instructions to run lit's test suite.

Ah, got it... that's a new feature to me, I am so out of the loop. :/

Sep 27 2016, 12:52 PM
ddunbar closed D24968: [lit] Add instructions to run lit's test suite.

https://llvm.org/svn/llvm-project/llvm/trunk@282525

Sep 27 2016, 12:07 PM
ddunbar committed rL282525: [lit] Add instructions to run lit's test suite.
[lit] Add instructions to run lit's test suite
Sep 27 2016, 12:07 PM
ddunbar added a comment to D24968: [lit] Add instructions to run lit's test suite.

I think we should just wire it up with all the other tests, from lits perspective it would just be another test suite (like we do with the regular tests and the unit tests).

Sep 27 2016, 12:00 PM
ddunbar committed rL282501: [lit] Fix refacto introduced by rL282479..
[lit] Fix refacto introduced by rL282479.
Sep 27 2016, 9:26 AM
ddunbar accepted D24968: [lit] Add instructions to run lit's test suite.

I believe they do all pass, but they are *not* (IIRC) wired up to run as part of LLVM's tests. We should definitely do that.

Sep 27 2016, 9:22 AM

Sep 26 2016

ddunbar committed rL282452: [lit] Add a --max-failures option..
[lit] Add a --max-failures option.
Sep 26 2016, 4:47 PM
ddunbar added a comment to D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.

Greg, I assumed you had LLVM commit access and could land this?

Sep 26 2016, 2:06 PM
ddunbar added a comment to D24933: Enable configuration files in clang.

I am too out of the loop on Clang development to be able to comment on the specific direction, but I will just say that I am highly in favor of adding new features in this direction. Thank you!

Sep 26 2016, 12:14 PM

Sep 1 2016

ddunbar resigned from D17293: [MC] AsmLexer: add extensible identifier's character set support..
Sep 1 2016, 8:26 PM · Restricted Project
ddunbar requested changes to D23743: lit/setup.py: Install as llvm-lit (as cmake expects it).

This isn't correct, llvm-lit is something else (an llvm specific entry point to lit that knows the object directory). That doesn't belong in the base lit project.

Sep 1 2016, 8:26 PM
ddunbar resigned from D2916: [libclang][python] Add test for Index read.
Sep 1 2016, 8:24 PM
ddunbar added a comment to D22144: [lit] add support for unsetting environment variable.

This looks reasonable to me, can we get a test for the behavior though?

Sep 1 2016, 8:24 PM
ddunbar resigned from D9133: Driver tests: don't assume the clang binary is called 'clang'.
Sep 1 2016, 8:22 PM
ddunbar resigned from D9420: Processes that spawn other processes should wait for their children to exit before exiting due to a signal..
Sep 1 2016, 8:22 PM
ddunbar resigned from D413: Add new lit argument: --exec-feature=FEATURE.
Sep 1 2016, 8:21 PM
ddunbar resigned from D337: GTestFormat should find "*Test" in the source root.
Sep 1 2016, 8:21 PM
ddunbar resigned from D2412: llvm-config: Print system libraries with --libs instead of --ldflags.
Sep 1 2016, 8:21 PM
ddunbar accepted D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.
Sep 1 2016, 8:21 PM
ddunbar accepted D24111: [lit] Fail testing if a googletest executable crashes during test discovery.
Sep 1 2016, 8:20 PM
ddunbar added a comment to D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.

LGTM, but can you add a section on the format to lit.pod? I know we don't have complete docs on the format, but if you could at least add section on the syntax it would be good.

Sep 1 2016, 7:58 PM
ddunbar added a comment to D24111: [lit] Fail testing if a googletest executable crashes during test discovery.

There might be clients of the capture() API which might aren't expecting it to throw on error, and will need to be updated, but I agree this makes more sense.

Sep 1 2016, 7:34 PM

Jul 21 2016

ddunbar committed rL276357: [lit] Use full config path in diagnostics..
[lit] Use full config path in diagnostics.
Jul 21 2016, 4:28 PM
ddunbar committed rL276353: [lit] Bump version number..
[lit] Bump version number.
Jul 21 2016, 4:25 PM

Jun 26 2016

ddunbar added a comment to D19888: [lit] Add SANITIZER_IGNORE_CVE_2016_2143 to pass_vars..

I have no objection.

Jun 26 2016, 1:00 PM

Jun 9 2016

ddunbar committed rL272365: [lit] Only gather redirected files for command failures..
[lit] Only gather redirected files for command failures.
Jun 9 2016, 9:24 PM

Jun 8 2016

ddunbar committed rL272147: [lit] Ensure we get bytes when reading redirected output files..
[lit] Ensure we get bytes when reading redirected output files.
Jun 8 2016, 7:48 AM

Jun 7 2016

ddunbar committed rL272066: [lit] Ignore errors when decoding redirected output..
[lit] Ignore errors when decoding redirected output.
Jun 7 2016, 3:13 PM
ddunbar committed rL272052: [lit] Fix an uninitialized var on Windows..
[lit] Fix an uninitialized var on Windows.
Jun 7 2016, 1:21 PM
ddunbar committed rL272022: [utils/lit] Show available_features with --show-suites..
[utils/lit] Show available_features with --show-suites.
Jun 7 2016, 9:29 AM
ddunbar committed rL272021: [lit] Improve logging with file redirection..
[lit] Improve logging with file redirection.
Jun 7 2016, 9:20 AM
ddunbar accepted D20721: [lit] Factor out a helper for shell command results..

I merged this with corrections in 271608, 271610, and 272021.

Jun 7 2016, 9:20 AM

Jun 2 2016

ddunbar committed rL271610: [lit] Improve readability of failing scripts..
[lit] Improve readability of failing scripts.
Jun 2 2016, 4:56 PM
ddunbar committed rL271608: [lit] Factor out a helper for shell command results..
[lit] Factor out a helper for shell command results.
Jun 2 2016, 4:39 PM

May 31 2016

ddunbar added inline comments to D20721: [lit] Factor out a helper for shell command results..
May 31 2016, 4:39 PM
ddunbar added a comment to D20757: Add "REQUIRES-ANY" feature test.

I believe you are thinking of: http://reviews.llvm.org/D18185

May 31 2016, 4:25 PM

May 26 2016

ddunbar retitled D20721: [lit] Factor out a helper for shell command results. from to [lit] Factor out a helper for shell command results..
May 26 2016, 8:50 PM

Mar 31 2016

ddunbar added a comment to D18647: [lit][googletest] Don't choke on non-executables.

In cases where this is trigger, wouldn't the warning always fire and the
proper way to suppress (so developers don't regularly see warnings) to
exclude that path? If so, then it seems like erroring out is ok, it just
forces resolution of that issue immediately.

Mar 31 2016, 11:38 AM
ddunbar committed rL265034: [lit][googletest] Handle upstream gtest output.
[lit][googletest] Handle upstream gtest output
Mar 31 2016, 11:28 AM
ddunbar closed D18606: [lit][googletest] Handle upstream gtest output.

Applied in r265034

Mar 31 2016, 11:28 AM
ddunbar accepted D18606: [lit][googletest] Handle upstream gtest output.
Mar 31 2016, 8:45 AM
ddunbar added a comment to D18606: [lit][googletest] Handle upstream gtest output.

LGTM, thanks for the fix and the new test coverage!

Mar 31 2016, 8:45 AM

Mar 24 2016

ddunbar added a comment to D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.

My comments:

Mar 24 2016, 9:06 PM

Feb 19 2016

ddunbar added a comment to D16871: lit: Add StringMetricValue for TestResult.addMetric().

Right, that is what I expected, something like MetricValueSignature that
clients would anticipate is a unique but otherwise meaningless signature
for some part of the test (and display accordingly, maybe by highlighting
when it changes).

Feb 19 2016, 4:22 PM

Feb 10 2016

ddunbar added a comment to D16871: lit: Add StringMetricValue for TestResult.addMetric().

I would just use addMetric for this. I see a binary signature as just
another kind of metric data, sometimes people even use the term "measure"
to the process of computing a hash signature for a binary.

Feb 10 2016, 3:22 PM

Jul 6 2015

ddunbar added a comment to D6584: Add per-test timeouts to lit.

I was just running the top-level suite, with lit -sv tests.

Jul 6 2015, 9:04 AM

Jun 26 2015

ddunbar added a comment to D6584: Add per-test timeouts to lit.

Hi Jonathan,

Jun 26 2015, 1:57 PM

May 25 2015

ddunbar resigned from D10011: Refactor: Simplify boolean conditional return statements in lib/Basic.
May 25 2015, 1:26 PM
ddunbar resigned from D10008: Refactor: simplify boolean conditional return statements in lib/Analysis.
May 25 2015, 1:24 PM
ddunbar resigned from D10012: Refactor: Simplify boolean conditional return statements in lib/CodeGen.
May 25 2015, 1:23 PM
ddunbar resigned from D10004: Refactor: Simplify boolean conditional return statements in tools/llvm-nm.
May 25 2015, 1:23 PM
ddunbar resigned from D10013: Refactor: Simplify boolean conditional return statements in lib/Driver.
May 25 2015, 1:23 PM

May 14 2015

ddunbar added inline comments to D9420: Processes that spawn other processes should wait for their children to exit before exiting due to a signal..
May 14 2015, 9:12 AM

May 11 2015

ddunbar added a comment to D6584: Add per-test timeouts to lit.

Hi Jonathan,

May 11 2015, 9:33 PM

May 4 2015

ddunbar added a comment to D9487: Lit: Allow overriding llvm tool paths+arguments, make -D an alias for --param.

Fine by me, can you also update the 'lit' docs in CommandGuide to note this.

May 4 2015, 1:14 PM

Apr 30 2015

ddunbar added a comment to D9420: Processes that spawn other processes should wait for their children to exit before exiting due to a signal..

It doesn't look like ChildPIDs is ever added to?

Apr 30 2015, 3:17 PM

Apr 5 2015

ddunbar added a comment to D8460: [LIT] Change the semantics of the LIT options '-s' and '-v' and modify when information is output..

Hi Eric,

Apr 5 2015, 10:46 AM

Mar 6 2015

ddunbar added a comment to D8106: Add check for needed tools for nightly tests.

Looks fine to me!

Mar 6 2015, 7:52 AM

Jan 28 2015

ddunbar committed rL227360: [lnttool] Compare parse version strings, to handle canonical version forms..
[lnttool] Compare parse version strings, to handle canonical version forms.
Jan 28 2015, 12:04 PM

Jan 23 2015

ddunbar added a comment to D6584: Add per-test timeouts to lit.

Hi Jonathan,

Jan 23 2015, 4:50 PM

Jan 3 2015

ddunbar added a comment to D6769: [LIT] Decode string result in lit.util.capture.

LGTM

Jan 3 2015, 4:07 PM

Dec 10 2014

ddunbar added a comment to D6576: [LIT] Add JSONMetricValue type to wrap types supported by the json encoder..

LGTM

Dec 10 2014, 4:31 PM

Dec 9 2014

ddunbar added a comment to D6275: [LIT] Allow suite configs to be preloaded allowing for better support of out-of-dir builds..

I sympathize with the use case, and in fact if you look at LLVM and Clang's
config files they have code which tries to do a trick where if it finds it
is running in the source without a lit.site.cfg, then it tries to infer the
location of the actual exec_root by seeing if you are the kind of user who
puts such things in your path. It's messy and only works for some users and
is complicated, so I'm ultimately not a big fan of that solution, but it
was the first thing I came up with.

Dec 9 2014, 7:52 PM
ddunbar added a comment to D6584: Add per-test timeouts to lit.

Looks good, some nits inline. I would like to see a test or two before this goes in, though.

Dec 9 2014, 7:37 PM
ddunbar added a comment to D6589: [LIT] Add support for `UNSUPPORTED` tag to `TestRunner.parseIntegratedTestScript`.

LGTM, although it might be good to add a note about how require_script can
be used. To be honest I don't quite understand how you will use this yet.

Dec 9 2014, 7:28 PM
ddunbar added a comment to D6206: [LIT] Add SuffixDispatchTest for use in libc++ and libc++abi tests..

Sounds good!

Dec 9 2014, 7:24 PM
ddunbar added a comment to D6584: Add per-test timeouts to lit.

In addition to the inline comments, could you include some tests that exercise this code?

Dec 9 2014, 5:15 PM
ddunbar added a comment to D6206: [LIT] Add SuffixDispatchTest for use in libc++ and libc++abi tests..

I see.

Dec 9 2014, 4:44 PM
ddunbar added a comment to D6576: [LIT] Add JSONMetricValue type to wrap types supported by the json encoder..

The MetricValue abstraction doesn't currently provide any value really, but it is there in case we ever wanted to make use of the values (e.g., report performance changes). Given that, I think it probably makes sense to just call this JSONMetricValue and make it explicit that this is tied to values which are representable in the output, but which will otherwise be uninterpreted.

Dec 9 2014, 4:25 PM
ddunbar added a comment to D6584: Add per-test timeouts to lit.

I would love to have this feature, so +1 on that.

Dec 9 2014, 4:15 PM