More uses of getSEWLMULRatio will be added in D130895.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp | ||
---|---|---|
191 | Is the namespace qualifier on decodeVLMUL still needed? |
LGTM
llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp | ||
---|---|---|
191 | I don't know if this is something that benefits from a structured binding. |
llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp | ||
---|---|---|
191 | Honestly, exactly here I don't see any reason to use structured binding as the current solution has better readability (imo) and there is no need for extra optimizations. Though, if anybody has concerns regarding to this, let's use structured bindings. |
Thanks for the review.
@frasercrmck, could you please submit the patch on my behalf? Author: Anton Sidorenko <anton.sidorenko@syntacore.com>
Is the namespace qualifier on decodeVLMUL still needed?