Page MenuHomePhabricator
Differential D135086

[NFC][RISCV] Move getSEWLMULRatio function to header
ClosedPublic
Actions

Authored by asi-sc on Oct 3 2022, 9:40 AM.

Details

Reviewers
craig.topper
reames
frasercrmck
Commits
rG3e97e9423742: [NFC][RISCV] Move getSEWLMULRatio function to header
Summary

More uses of getSEWLMULRatio will be added in D130895.

Diff Detail

Event Timeline

asi-sc created this revision.Oct 3 2022, 9:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2022, 9:40 AM
Herald added subscribers: sunshaoce, VincentWu, vkmr and 28 others. · View Herald Transcript
asi-sc requested review of this revision.Oct 3 2022, 9:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2022, 9:40 AM
Herald added subscribers: llvm-commits, pcwang-thead, eopXD, MaskRay. · View Herald Transcript
asi-sc mentioned this in D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.Oct 3 2022, 9:45 AM
Harbormaster completed remote builds in B190005: Diff 464717.Oct 3 2022, 10:32 AM
asi-sc added reviewers: craig.topper, reames.Oct 3 2022, 10:35 AM
Herald added a subscriber: StephenFan. · View Herald TranscriptOct 3 2022, 10:35 AM
craig.topper added inline comments.Oct 3 2022, 10:41 AM
llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp
191

Is the namespace qualifier on decodeVLMUL still needed?

asi-sc updated this revision to Diff 464917.Oct 4 2022, 1:38 AM

Addressed review comments

frasercrmck accepted this revision.Oct 4 2022, 2:28 AM

LGTM

llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp
191

I don't know if this is something that benefits from a structured binding.

This revision is now accepted and ready to land.Oct 4 2022, 2:28 AM
Harbormaster completed remote builds in B190140: Diff 464917.Oct 4 2022, 2:29 AM
asi-sc added inline comments.Oct 4 2022, 9:22 AM
llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp
191

Honestly, exactly here I don't see any reason to use structured binding as the current solution has better readability (imo) and there is no need for extra optimizations. Though, if anybody has concerns regarding to this, let's use structured bindings.

craig.topper accepted this revision.Oct 4 2022, 9:29 AM

LGTM

asi-sc added a comment.Oct 5 2022, 1:23 AM

Thanks for the review.
@frasercrmck, could you please submit the patch on my behalf? Author: Anton Sidorenko <anton.sidorenko@syntacore.com>

Closed by commit rG3e97e9423742: [NFC][RISCV] Move getSEWLMULRatio function to header (authored by asi-sc, committed by frasercrmck). · Explain WhyOct 5 2022, 7:12 AM
This revision was automatically updated to reflect the committed changes.
frasercrmck added a commit: rG3e97e9423742: [NFC][RISCV] Move getSEWLMULRatio function to header.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
RISCV/
MCTargetDesc/
2 lines
12 lines
22 lines

Diff 464717

View Options

llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h

Loading...
View Options

llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp

Loading...
View Options

llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp

Loading...