Page MenuHomePhabricator

asi-sc (Anton Sidorenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2022, 2:08 AM (7 w, 6 d)

Recent Activity

Thu, Sep 22

asi-sc added inline comments to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.
Thu, Sep 22, 1:49 AM · Restricted Project, Restricted Project

Wed, Sep 21

asi-sc updated the diff for D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

Rebase

Wed, Sep 21, 3:15 AM · Restricted Project, Restricted Project

Tue, Sep 20

asi-sc added a comment to D134179: [NFC][RISCV] Move calculations of SDNode policy operand idx to a separate function.

@arcbbb, could you please submit the patch on my behalf? Author: Anton Sidorenko <anton.sidorenko@syntacore.com>
Thanks.

Tue, Sep 20, 9:57 AM · Restricted Project, Restricted Project

Mon, Sep 19

asi-sc added a comment to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

Depends on D134179

Mon, Sep 19, 8:40 AM · Restricted Project, Restricted Project
asi-sc updated the diff for D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

Addressed review comments

Mon, Sep 19, 8:39 AM · Restricted Project, Restricted Project
asi-sc added inline comments to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.
Mon, Sep 19, 7:19 AM · Restricted Project, Restricted Project
asi-sc added reviewers for D134179: [NFC][RISCV] Move calculations of SDNode policy operand idx to a separate function: frasercrmck, arcbbb.
Mon, Sep 19, 5:48 AM · Restricted Project, Restricted Project
asi-sc added reviewers for D134179: [NFC][RISCV] Move calculations of SDNode policy operand idx to a separate function: reames, craig.topper.
Mon, Sep 19, 5:45 AM · Restricted Project, Restricted Project
asi-sc requested review of D134179: [NFC][RISCV] Move calculations of SDNode policy operand idx to a separate function.
Mon, Sep 19, 5:43 AM · Restricted Project, Restricted Project

Fri, Sep 16

asi-sc added inline comments to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.
Fri, Sep 16, 10:01 AM · Restricted Project, Restricted Project

Thu, Sep 15

asi-sc added a comment to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

I've looked at a few ideas in this area, and there's an interaction I want to point out that I don't have a good answer for.

While reducing the VL of a splat to match the demanded lanes can remove vsetv toggles, it can also add them. Specifically, if the splat happens to be scheduled in a region which uses the original wider VL, then reducing the VL actually pessimizes the code. This actually shows up in mixed VL code, particularly when combined with LICM for splats which can't be folded (profitably) into their users.

We can patch part of this by extending InsertVSETVLI to allow increasing VL on splats if the splat is TA. However, there's still a scheduling interaction here which is a bit hard to account for.

I generally do believe that having VL reduction for all computation (not just splats) is generally a good idea; I'm just trying to figure out how to slice the pieces so that we can get there incrementally without nasty regressions along the way.

Thu, Sep 15, 7:20 AM · Restricted Project, Restricted Project

Tue, Sep 13

asi-sc added a comment to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

A gentle ping

Tue, Sep 13, 1:03 AM · Restricted Project, Restricted Project

Tue, Sep 6

asi-sc updated the summary of D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.
Tue, Sep 6, 5:30 AM · Restricted Project, Restricted Project
asi-sc retitled D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users from Make VL choosing for a splat constant based on its users to [RISCV] Make VL choosing for a splat-like VMV based on its users.
Tue, Sep 6, 5:29 AM · Restricted Project, Restricted Project
asi-sc updated the diff for D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

Make VL choosing for a splat-like VMV based on its users

Tue, Sep 6, 5:27 AM · Restricted Project, Restricted Project

Aug 12 2022

asi-sc added a comment to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

A gentle ping on the question about adding a markup of merge operands for intrinsics.

Aug 12 2022, 6:13 AM · Restricted Project, Restricted Project

Aug 2 2022

asi-sc added a comment to D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.

What if the user is the merge operand of a tail undisturbed instruction. The VL of the using instruction would not apply to it then.

Aug 2 2022, 5:43 AM · Restricted Project, Restricted Project

Aug 1 2022

asi-sc added reviewers for D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users: reames, craig.topper, frasercrmck.
Aug 1 2022, 5:42 AM · Restricted Project, Restricted Project
asi-sc requested review of D130895: [RISCV] Make VL choosing for a splat-like VMV based on its users.
Aug 1 2022, 5:35 AM · Restricted Project, Restricted Project