Page MenuHomePhabricator

[ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.
Needs ReviewPublic

Authored by vsapsai on Jul 21 2022, 7:57 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

When during parsing we encountered a duplicate ObjCProtocolDecl, we
were always emitting an error. With this change we accept

  • when a previous ObjCProtocolDecl is in a hidden [sub]module;
  • parsed ObjCProtocolDecl is the same as the previous one.

And in case of mismatches we provide more detailed error messages.

rdar://93069080

Diff Detail