- User Since
- Mar 16 2021, 11:08 AM (31 w, 6 d)
Aug 10 2021
hi do you know Why this patch was closed?
hi There is the failing test case libcxx/test/std/input.output/filesystems/class.path/path.member/path.append.pass.cpp , this test case is not in https://reviews.llvm.org/D107124 and https://reviews.llvm.org/D105910 , the failure seems not related to this patch. it fails same without this patch. we will investigate separately. rest of tests in https://reviews.llvm.org/D107124 and https://reviews.llvm.org/D105910 passed. Thanks for the fixes.
Assertion failed: Result == E, file: /plex/wangn/llvm/dev/llvm-project/libcxx/test/std/input.output/filesystems/class.path/path.member/path.append.pass.cpp, line: 250
CEE5207E The signal SIGABRT was received.
Aug 9 2021
The changes look ok to me although I havent tried it on z/OS as long as build pass. I will fix in separate patch if there is an issue on z/OS. just want to confirm those assert wont be run on z/OS and assert macros are empty. I will need some time to download patch and test it out.
Let me know if this is ready, I will need to test it on z/OS.
Aug 6 2021
hi Any suggestion how we should fix those test case, I can add unsupport on z/OS.
Aug 4 2021
@Quuxplusone Thanks Arthur, I can remove delete macro. let me know how windows works if need me to check windows as well.
@Quuxplusone hi Arthur, Can you review ?
Jul 30 2021
Hi I only updated 3 test cases , I didnt modify test cases in https://reviews.llvm.org/D105910 , because @DanielMcIntosh-IBM did some investigation already in those test cases, I will let him handle it. another reason is I am unable to test windows if it requires modify macros for windows as well
Thanks. will look into how ASSERT_VIA_OVERRIDDEN_NEW works
Jul 29 2021
Jul 27 2021
Jul 26 2021
@ldionne hi Louis, any question regarding to this PR, I noticed you reviewed similar changes before. Thanks.
Jul 20 2021
hi Arthur O'Dwyer , I have updated test, can you review it? Thanks
Jul 19 2021
change test cases to be unsupported on z/OS
add unsupported on zOS for 2 failing test cases
hi Arthur O'Dwyer, I am thinking if we can add unsupported cxx-03 for both test cases with current resolution. adding u'some test' or u'a' is right syntax for uchar16_t , same for utf8_t type. any thoughts about this ?
Jul 16 2021
yeah. I also have same question as Sean mentioned. codecvt class for UTF16/32_t starts from c++11, utf8_t started from c++20. we shouldn't run with c++03. the error is expected.
do we know why build are failing ?
Jun 28 2021
hi Arthur O'Dwyer , can you kindly review it again? Thanks
Jun 24 2021
use new assert pattern so that we can keep old tests
- added assert(std::char_traits<char>::lt('A','a') == !std::char_traits<char>::lt('a','A')); for case insensitive test.
- make content of 2 test cases same except one testing char type another one testing wchar_t
Jun 23 2021
ping ;) can I get review for this ?