Page MenuHomePhabricator

NancyWang2222 (Nancy Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 16 2021, 11:08 AM (99 w, 10 h)

Recent Activity

Nov 22 2022

NancyWang2222 added a comment to D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing..

@vsapsai hi Volodymyr Sapsai , test case clang/test/Modules/hidden-duplicates.m is failing on our llvm community AIX box https://lab.llvm.org/buildbot/#/builders/214/builds/4442/steps/6/logs/FAIL__Clang__hidden-duplicates_m , it gives exit code 70 without detail error message, can you help fix it as soon as possible. Thanks

Nov 22 2022, 8:12 AM · Restricted Project, Restricted Project

Oct 14 2022

NancyWang2222 updated the diff for D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function.

use std:: to replace _VSTD::

Oct 14 2022, 7:02 AM · Restricted Project, Restricted Project

Oct 4 2022

NancyWang2222 added a comment to D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function.

Please use std:: instead of _VSTD::, though (as suggested by @philnik)

Oct 4 2022, 2:17 PM · Restricted Project, Restricted Project

Mar 1 2022

NancyWang2222 added a comment to D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.

ping for the review. Thanks

Mar 1 2022, 7:19 AM · Restricted Project
NancyWang2222 added a comment to D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .

please kindly review this patch again. thanks.

Mar 1 2022, 7:18 AM · Restricted Project

Feb 18 2022

NancyWang2222 added a comment to D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function.

Oh, sorry. For some reason I thought z/OS and AIX were the same thing. Are you working on libc++ officially supporting z/OS? If that is the case, maybe it would be a good idea to add a CI node for that?

Feb 18 2022, 3:48 PM · Restricted Project, Restricted Project
NancyWang2222 updated subscribers of D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function.
Feb 18 2022, 3:31 PM · Restricted Project, Restricted Project
NancyWang2222 updated subscribers of D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function.

There should also be a test changed somewhere in libcxx/test/std/localization, or is this only part of the fix?

Thanks for providing information, can you provide more detail about what change need for libcxx/test/localization, the patch will fix bunch of Assert d1==d2 issues in std/numerics/rand/rand.dis/rand.dist.bern/ on z/OS related to float point value.

I would have expected test failures in locale.categories/category.numeric/facet.num.get.members/get_float.pass.cpp, since this patch changes behavior of std::num_get on AIX IIUC. So either I'm not understanding something here or there are some test cases missing. Wait there are also no // XFAIL: AIX in std/numerics/rand.dis/rand.dis.bern/. Are these tests currently disabled on AIX somehow?

Feb 18 2022, 3:27 PM · Restricted Project, Restricted Project
NancyWang2222 added a comment to D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function.

There should also be a test changed somewhere in libcxx/test/std/localization, or is this only part of the fix?

Feb 18 2022, 1:57 PM · Restricted Project, Restricted Project
NancyWang2222 added a comment to D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function.

Can I have 2nd review from libcxx. Thanks.

Feb 18 2022, 12:09 PM · Restricted Project, Restricted Project
NancyWang2222 added a comment to D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .

Can I have 2nd review from libcxx? Thanks

Feb 18 2022, 11:35 AM · Restricted Project
NancyWang2222 added a comment to D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.

can I have 2nd review from libcxx?

Feb 18 2022, 11:33 AM · Restricted Project

Feb 16 2022

NancyWang2222 added a comment to D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function.

kindly ping for review or approval from libcxx group :)

Feb 16 2022, 9:09 AM · Restricted Project, Restricted Project
NancyWang2222 added a comment to D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.

kindly ping for review or approval from libcxx group

Feb 16 2022, 9:08 AM · Restricted Project
NancyWang2222 added a comment to D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .

ping :)

Feb 16 2022, 9:07 AM · Restricted Project

Feb 14 2022

NancyWang2222 set the repository for D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS to rG LLVM Github Monorepo.
Feb 14 2022, 8:59 AM · Restricted Project
NancyWang2222 set the repository for D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header to rG LLVM Github Monorepo.
Feb 14 2022, 8:59 AM · Restricted Project
NancyWang2222 set the repository for D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function to rG LLVM Github Monorepo.
Feb 14 2022, 8:57 AM · Restricted Project, Restricted Project
NancyWang2222 added a comment to D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .

@ldionne @Quuxplusone I have addressed comment, Can you help review again. Thanks for the feedback.

Feb 14 2022, 8:44 AM · Restricted Project
NancyWang2222 added a comment to D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.

@ldionne hi Louis, Can you help review again? Thanks everyone for providing feedback.

Feb 14 2022, 8:34 AM · Restricted Project

Feb 11 2022

NancyWang2222 updated the diff for D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .

change function name letter_value to alphabetical_index

Feb 11 2022, 2:23 PM · Restricted Project
NancyWang2222 added inline comments to D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .
Feb 11 2022, 2:18 PM · Restricted Project
NancyWang2222 updated the diff for D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.

please ignore comment.

Feb 11 2022, 2:14 PM · Restricted Project
NancyWang2222 updated the diff for D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.

change function name and return type

Feb 11 2022, 2:12 PM · Restricted Project
NancyWang2222 added inline comments to D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .
Feb 11 2022, 1:20 PM · Restricted Project
NancyWang2222 added inline comments to D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .
Feb 11 2022, 1:15 PM · Restricted Project
NancyWang2222 updated the diff for D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .

remove extra space

Feb 11 2022, 12:27 PM · Restricted Project
NancyWang2222 updated the diff for D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.

add _LIBCPP_HIDE_FROM_ABI for function __is_valid_in_encoding

Feb 11 2022, 12:15 PM · Restricted Project
NancyWang2222 added inline comments to D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.
Feb 11 2022, 11:17 AM · Restricted Project
NancyWang2222 updated the diff for D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .

match the format suggested by git-clang-format

Feb 11 2022, 8:22 AM · Restricted Project

Feb 10 2022

NancyWang2222 added a comment to D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function.

if no more comments on this PR. plan to land it . Thanks for the feedback.

Feb 10 2022, 10:26 AM · Restricted Project, Restricted Project
NancyWang2222 updated the diff for D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.

fix indentation for the function modified.

Feb 10 2022, 10:10 AM · Restricted Project
NancyWang2222 updated the diff for D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .

I rebased with latest master. hope it will fix error.

Feb 10 2022, 9:47 AM · Restricted Project
NancyWang2222 added inline comments to D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.
Feb 10 2022, 9:31 AM · Restricted Project
NancyWang2222 updated the diff for D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.

run git-clang-format for the changes

Feb 10 2022, 8:40 AM · Restricted Project

Feb 9 2022

NancyWang2222 updated the diff for D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .

address comment: change function name from LetterNum to letter_value, and remove extra blank line , also remove constexpr.

Feb 9 2022, 7:09 PM · Restricted Project
NancyWang2222 added inline comments to D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .
Feb 9 2022, 6:39 PM · Restricted Project
NancyWang2222 updated the diff for D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.

fix function name for locale.cpp as well.

Feb 9 2022, 2:44 PM · Restricted Project
NancyWang2222 updated the diff for D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.

change isbasic function name and fix return __c ? true: true statement

Feb 9 2022, 2:34 PM · Restricted Project
NancyWang2222 added inline comments to D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.
Feb 9 2022, 2:07 PM · Restricted Project
NancyWang2222 added inline comments to D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.
Feb 9 2022, 1:37 PM · Restricted Project

Feb 4 2022

NancyWang2222 added a comment to D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function.

ping -:)

Feb 4 2022, 8:48 AM · Restricted Project, Restricted Project
NancyWang2222 added a comment to D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.

ping -:)

Feb 4 2022, 8:47 AM · Restricted Project
NancyWang2222 added a comment to D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .

ping -:)

Feb 4 2022, 7:13 AM · Restricted Project

Feb 3 2022

NancyWang2222 updated the diff for D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .

include <cctype> so tolower function can be recognized when localization is disabled

Feb 3 2022, 5:42 PM · Restricted Project
NancyWang2222 updated the diff for D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .

need a guard in libcxx/include/charconv as well.

Feb 3 2022, 1:25 PM · Restricted Project
NancyWang2222 updated the diff for D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function.

remove an extra curly bracket

Feb 3 2022, 12:25 PM · Restricted Project, Restricted Project
NancyWang2222 requested review of D118930: [SystemZ]:[z/OS]:[libcxx]: fix the mask in stage2_float_loop function.
Feb 3 2022, 11:23 AM · Restricted Project, Restricted Project
NancyWang2222 updated the diff for D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .

put guard in __locale when include locale.h

Feb 3 2022, 9:57 AM · Restricted Project
NancyWang2222 updated the diff for D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .

only include <locale> when _LIBCPP_HAS_NO_LOCALIZATION is not defined

Feb 3 2022, 8:08 AM · Restricted Project

Feb 2 2022

NancyWang2222 updated the diff for D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .

move #include <locale> up one line according to alphabetical order

Feb 2 2022, 6:46 PM · Restricted Project
NancyWang2222 requested review of D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS.
Feb 2 2022, 3:05 PM · Restricted Project
NancyWang2222 retitled D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header from [SystemZ]:[libcxx]: fix nthLetter issue for charconv header to [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .
Feb 2 2022, 2:51 PM · Restricted Project
NancyWang2222 updated the summary of D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .
Feb 2 2022, 2:30 PM · Restricted Project
NancyWang2222 requested review of D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header .
Feb 2 2022, 2:28 PM · Restricted Project

Feb 1 2022

NancyWang2222 accepted D118723: [SystemZ][z/OS]: Manually create lit tmp_dir.
Feb 1 2022, 12:42 PM · Restricted Project

Jan 24 2022

NancyWang2222 added a comment to D118071: [SystemZ][z/OS]: fix lit tmp_dir to use - instead of _ .

Sounds reasonable to me - I don't think any other supported OSes would have an issue with that.

Jan 24 2022, 2:37 PM · Restricted Project
NancyWang2222 updated the diff for D118071: [SystemZ][z/OS]: fix lit tmp_dir to use - instead of _ .

Simplify the comments

Jan 24 2022, 2:35 PM · Restricted Project
NancyWang2222 added a comment to D118071: [SystemZ][z/OS]: fix lit tmp_dir to use - instead of _ .

Exact spelling of the temporary test directory shouldn't matter.
The z/OS linker not being able to handle this sounds like a bug... but oh my.

Nit: can we make the comment more compact, maybe:

tmp_dir = tempfile.mkdtemp(prefix='lit-tmp-')  # z/OS linker does not support '_' in paths, so use '-'

LGTM, thanks!

Jan 24 2022, 2:17 PM · Restricted Project
NancyWang2222 requested review of D118071: [SystemZ][z/OS]: fix lit tmp_dir to use - instead of _ .
Jan 24 2022, 1:08 PM · Restricted Project

Aug 10 2021

NancyWang2222 added a comment to D107755: [libcxx] [test] Generalize defines for skipping allocation checks.

hi do you know Why this patch was closed?

I applied it already as it was approved, as I thought you said you can fix any remaining z/OS related details in separate patches later?

Aug 10 2021, 8:08 AM · Restricted Project
NancyWang2222 added a comment to D107755: [libcxx] [test] Generalize defines for skipping allocation checks.

hi do you know Why this patch was closed?

Aug 10 2021, 7:04 AM · Restricted Project
NancyWang2222 added a comment to D107755: [libcxx] [test] Generalize defines for skipping allocation checks.

hi There is the failing test case libcxx/test/std/input.output/filesystems/class.path/path.member/path.append.pass.cpp , this test case is not in https://reviews.llvm.org/D107124 and https://reviews.llvm.org/D105910 , the failure seems not related to this patch. it fails same without this patch. we will investigate separately. rest of tests in https://reviews.llvm.org/D107124 and https://reviews.llvm.org/D105910 passed. Thanks for the fixes.
Assertion failed: Result == E, file: /plex/wangn/llvm/dev/llvm-project/libcxx/test/std/input.output/filesystems/class.path/path.member/path.append.pass.cpp, line: 250
CEE5207E The signal SIGABRT was received.

Aug 10 2021, 6:57 AM · Restricted Project

Aug 9 2021

NancyWang2222 added inline comments to D107755: [libcxx] [test] Generalize defines for skipping allocation checks.
Aug 9 2021, 2:33 PM · Restricted Project
NancyWang2222 added inline comments to D107755: [libcxx] [test] Generalize defines for skipping allocation checks.
Aug 9 2021, 2:28 PM · Restricted Project
NancyWang2222 added a comment to D107755: [libcxx] [test] Generalize defines for skipping allocation checks.

The changes look ok to me although I havent tried it on z/OS as long as build pass. I will fix in separate patch if there is an issue on z/OS. just want to confirm those assert wont be run on z/OS and assert macros are empty. I will need some time to download patch and test it out.

Aug 9 2021, 2:16 PM · Restricted Project
NancyWang2222 added a comment to D107755: [libcxx] [test] Generalize defines for skipping allocation checks.

Let me know if this is ready, I will need to test it on z/OS.

Aug 9 2021, 7:52 AM · Restricted Project

Aug 6 2021

NancyWang2222 added a comment to D107124: [SystemZ][z/OS][libcxx]: Disable some new operator test cases on z/OS.

hi Any suggestion how we should fix those test case, I can add unsupport on z/OS.

Aug 6 2021, 8:08 AM

Aug 4 2021

NancyWang2222 added a comment to D107124: [SystemZ][z/OS][libcxx]: Disable some new operator test cases on z/OS.

@Quuxplusone Thanks Arthur, I can remove delete macro. let me know how windows works if need me to check windows as well.

Aug 4 2021, 12:39 PM
NancyWang2222 added a comment to D107124: [SystemZ][z/OS][libcxx]: Disable some new operator test cases on z/OS.

@Quuxplusone hi Arthur, Can you review ?

Aug 4 2021, 7:00 AM

Jul 30 2021

NancyWang2222 updated the diff for D107124: [SystemZ][z/OS][libcxx]: Disable some new operator test cases on z/OS.

Hi I only updated 3 test cases , I didnt modify test cases in https://reviews.llvm.org/D105910 , because @DanielMcIntosh-IBM did some investigation already in those test cases, I will let him handle it. another reason is I am unable to test windows if it requires modify macros for windows as well

Jul 30 2021, 3:15 PM
NancyWang2222 added a comment to D107124: [SystemZ][z/OS][libcxx]: Disable some new operator test cases on z/OS.

Thanks. will look into how ASSERT_VIA_OVERRIDDEN_NEW works

Jul 30 2021, 5:14 AM

Jul 29 2021

NancyWang2222 requested review of D107124: [SystemZ][z/OS][libcxx]: Disable some new operator test cases on z/OS.
Jul 29 2021, 6:00 PM

Jul 27 2021

NancyWang2222 added a comment to D106810: [SystemZ][z/OS][libcxx]: Disable align_val_t test cases on z/OS.

ping :)

Jul 27 2021, 6:59 AM · Restricted Project

Jul 26 2021

NancyWang2222 updated subscribers of D106810: [SystemZ][z/OS][libcxx]: Disable align_val_t test cases on z/OS.

@ldionne hi Louis, any question regarding to this PR, I noticed you reviewed similar changes before. Thanks.

Jul 26 2021, 2:19 PM · Restricted Project
NancyWang2222 updated the summary of D106810: [SystemZ][z/OS][libcxx]: Disable align_val_t test cases on z/OS.
Jul 26 2021, 11:27 AM · Restricted Project
NancyWang2222 requested review of D106810: [SystemZ][z/OS][libcxx]: Disable align_val_t test cases on z/OS.
Jul 26 2021, 10:10 AM · Restricted Project

Jul 20 2021

NancyWang2222 requested review of D106404: [SystemZ][z/OS][libcxx]: add the missing comment for patch D106153 and D106151.
Jul 20 2021, 3:08 PM · Restricted Project
NancyWang2222 added a comment to D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .

LGTM, but please add short comments (1-2 lines) explaining why the tests are unsupported. I don't need to see this again.

Jul 20 2021, 1:50 PM · Restricted Project
NancyWang2222 added a comment to D106153: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF8.

LGTM, but please add a 1-2 line comment for each UNSUPPORTED explaining why it fails. You can copy/paste the comment, it's fine. Actually, it even helps cause you can then grep for:

// <the-comment>
// UNSUPPORTED: target={{.+}}-zos{{.*}}

and you'll find all tests that are marked as unsupported for the same reason.

@muiez

Please read the comments even when you get an approval. https://reviews.llvm.org/rG7704fedfff6ef5676adb6415f3be0ac927d1a746 didn't apply my requested change. I LGTM'd the patch because I trusted you'd apply the feedback and didn't want to block you until I could look at it again -- not because no changes were required.

Jul 20 2021, 1:23 PM · Restricted Project
NancyWang2222 added a comment to D106153: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF8.

hi Arthur O'Dwyer , I have updated test, can you review it? Thanks

Jul 20 2021, 8:20 AM · Restricted Project
NancyWang2222 added inline comments to D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .
Jul 20 2021, 7:31 AM · Restricted Project

Jul 19 2021

NancyWang2222 updated the diff for D106153: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF8.

change test cases to be unsupported on z/OS

Jul 19 2021, 4:50 PM · Restricted Project
NancyWang2222 updated the diff for D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .

add unsupported on zOS for 2 failing test cases

Jul 19 2021, 4:48 PM · Restricted Project
NancyWang2222 added a comment to D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .

hi Arthur O'Dwyer, I am thinking if we can add unsupported cxx-03 for both test cases with current resolution. adding u'some test' or u'a' is right syntax for uchar16_t , same for utf8_t type. any thoughts about this ?

Jul 19 2021, 6:45 AM · Restricted Project

Jul 16 2021

NancyWang2222 added a comment to D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .

yeah. I also have same question as Sean mentioned. codecvt class for UTF16/32_t starts from c++11, utf8_t started from c++20. we shouldn't run with c++03. the error is expected.

Jul 16 2021, 1:05 PM · Restricted Project
NancyWang2222 added inline comments to D106153: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF8.
Jul 16 2021, 10:42 AM · Restricted Project
NancyWang2222 added inline comments to D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .
Jul 16 2021, 10:40 AM · Restricted Project
NancyWang2222 added inline comments to D106153: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF8.
Jul 16 2021, 10:33 AM · Restricted Project
NancyWang2222 added a comment to D106153: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF8.

do we know why build are failing ?

Jul 16 2021, 9:58 AM · Restricted Project
NancyWang2222 added a comment to D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .

LGTM (if icky) for the char8_t-based tests.
For the other two tests that are currently failing buildkite in C++03 mode (because u's' is a syntax error in C++03), personally I would recommend leaving the code alone and just UNSUPPORTED'ing them on zOS. They're already marked with

// This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.

which indicates that it's not too important to make this stuff work on "new" platforms — in fact we're actively deprecating/breaking it on "old" platforms and it might be completely moot by the time C++23 ships.

Jul 16 2021, 9:48 AM · Restricted Project
NancyWang2222 requested review of D106153: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF8.
Jul 16 2021, 7:28 AM · Restricted Project
NancyWang2222 added reviewers for D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 : uweigand, hubert.reinterpretcast, abhina.sreeskantharajan, fanbo-meng, muiez, Restricted Project.
Jul 16 2021, 7:22 AM · Restricted Project
NancyWang2222 requested review of D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .
Jul 16 2021, 7:19 AM · Restricted Project

Jun 28 2021

NancyWang2222 updated the diff for D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.
Jun 28 2021, 8:02 AM · Restricted Project
NancyWang2222 added inline comments to D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.
Jun 28 2021, 7:21 AM · Restricted Project
NancyWang2222 added a comment to D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.

hi Arthur O'Dwyer , can you kindly review it again? Thanks

Jun 28 2021, 6:52 AM · Restricted Project

Jun 24 2021

NancyWang2222 added a comment to D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.

ping :)

Jun 24 2021, 2:03 PM · Restricted Project
NancyWang2222 updated the diff for D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.

use new assert pattern so that we can keep old tests

Jun 24 2021, 12:31 PM · Restricted Project
NancyWang2222 added inline comments to D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.
Jun 24 2021, 11:11 AM · Restricted Project