Page MenuHomePhabricator

NancyWang2222 (Nancy Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 16 2021, 11:08 AM (31 w, 6 d)

Recent Activity

Aug 10 2021

NancyWang2222 added a comment to D107755: [libcxx] [test] Generalize defines for skipping allocation checks.

hi do you know Why this patch was closed?

I applied it already as it was approved, as I thought you said you can fix any remaining z/OS related details in separate patches later?

Aug 10 2021, 8:08 AM · Restricted Project
NancyWang2222 added a comment to D107755: [libcxx] [test] Generalize defines for skipping allocation checks.

hi do you know Why this patch was closed?

Aug 10 2021, 7:04 AM · Restricted Project
NancyWang2222 added a comment to D107755: [libcxx] [test] Generalize defines for skipping allocation checks.

hi There is the failing test case libcxx/test/std/input.output/filesystems/class.path/path.member/path.append.pass.cpp , this test case is not in https://reviews.llvm.org/D107124 and https://reviews.llvm.org/D105910 , the failure seems not related to this patch. it fails same without this patch. we will investigate separately. rest of tests in https://reviews.llvm.org/D107124 and https://reviews.llvm.org/D105910 passed. Thanks for the fixes.
Assertion failed: Result == E, file: /plex/wangn/llvm/dev/llvm-project/libcxx/test/std/input.output/filesystems/class.path/path.member/path.append.pass.cpp, line: 250
CEE5207E The signal SIGABRT was received.

Aug 10 2021, 6:57 AM · Restricted Project

Aug 9 2021

NancyWang2222 added inline comments to D107755: [libcxx] [test] Generalize defines for skipping allocation checks.
Aug 9 2021, 2:33 PM · Restricted Project
NancyWang2222 added inline comments to D107755: [libcxx] [test] Generalize defines for skipping allocation checks.
Aug 9 2021, 2:28 PM · Restricted Project
NancyWang2222 added a comment to D107755: [libcxx] [test] Generalize defines for skipping allocation checks.

The changes look ok to me although I havent tried it on z/OS as long as build pass. I will fix in separate patch if there is an issue on z/OS. just want to confirm those assert wont be run on z/OS and assert macros are empty. I will need some time to download patch and test it out.

Aug 9 2021, 2:16 PM · Restricted Project
NancyWang2222 added a comment to D107755: [libcxx] [test] Generalize defines for skipping allocation checks.

Let me know if this is ready, I will need to test it on z/OS.

Aug 9 2021, 7:52 AM · Restricted Project

Aug 6 2021

NancyWang2222 added a comment to D107124: [SystemZ][z/OS][libcxx]: Disable some new operator test cases on z/OS.

hi Any suggestion how we should fix those test case, I can add unsupport on z/OS.

Aug 6 2021, 8:08 AM

Aug 4 2021

NancyWang2222 added a comment to D107124: [SystemZ][z/OS][libcxx]: Disable some new operator test cases on z/OS.

@Quuxplusone Thanks Arthur, I can remove delete macro. let me know how windows works if need me to check windows as well.

Aug 4 2021, 12:39 PM
NancyWang2222 added a comment to D107124: [SystemZ][z/OS][libcxx]: Disable some new operator test cases on z/OS.

@Quuxplusone hi Arthur, Can you review ?

Aug 4 2021, 7:00 AM

Jul 30 2021

NancyWang2222 updated the diff for D107124: [SystemZ][z/OS][libcxx]: Disable some new operator test cases on z/OS.

Hi I only updated 3 test cases , I didnt modify test cases in https://reviews.llvm.org/D105910 , because @DanielMcIntosh-IBM did some investigation already in those test cases, I will let him handle it. another reason is I am unable to test windows if it requires modify macros for windows as well

Jul 30 2021, 3:15 PM
NancyWang2222 added a comment to D107124: [SystemZ][z/OS][libcxx]: Disable some new operator test cases on z/OS.

Thanks. will look into how ASSERT_VIA_OVERRIDDEN_NEW works

Jul 30 2021, 5:14 AM

Jul 29 2021

NancyWang2222 requested review of D107124: [SystemZ][z/OS][libcxx]: Disable some new operator test cases on z/OS.
Jul 29 2021, 6:00 PM

Jul 27 2021

NancyWang2222 added a comment to D106810: [SystemZ][z/OS][libcxx]: Disable align_val_t test cases on z/OS.

ping :)

Jul 27 2021, 6:59 AM · Restricted Project

Jul 26 2021

NancyWang2222 updated subscribers of D106810: [SystemZ][z/OS][libcxx]: Disable align_val_t test cases on z/OS.

@ldionne hi Louis, any question regarding to this PR, I noticed you reviewed similar changes before. Thanks.

Jul 26 2021, 2:19 PM · Restricted Project
NancyWang2222 updated the summary of D106810: [SystemZ][z/OS][libcxx]: Disable align_val_t test cases on z/OS.
Jul 26 2021, 11:27 AM · Restricted Project
NancyWang2222 requested review of D106810: [SystemZ][z/OS][libcxx]: Disable align_val_t test cases on z/OS.
Jul 26 2021, 10:10 AM · Restricted Project

Jul 20 2021

NancyWang2222 requested review of D106404: [SystemZ][z/OS][libcxx]: add the missing comment for patch D106153 and D106151.
Jul 20 2021, 3:08 PM · Restricted Project
NancyWang2222 added a comment to D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .

LGTM, but please add short comments (1-2 lines) explaining why the tests are unsupported. I don't need to see this again.

Jul 20 2021, 1:50 PM · Restricted Project
NancyWang2222 added a comment to D106153: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF8.

LGTM, but please add a 1-2 line comment for each UNSUPPORTED explaining why it fails. You can copy/paste the comment, it's fine. Actually, it even helps cause you can then grep for:

// <the-comment>
// UNSUPPORTED: target={{.+}}-zos{{.*}}

and you'll find all tests that are marked as unsupported for the same reason.

@muiez

Please read the comments even when you get an approval. https://reviews.llvm.org/rG7704fedfff6ef5676adb6415f3be0ac927d1a746 didn't apply my requested change. I LGTM'd the patch because I trusted you'd apply the feedback and didn't want to block you until I could look at it again -- not because no changes were required.

Jul 20 2021, 1:23 PM · Restricted Project
NancyWang2222 added a comment to D106153: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF8.

hi Arthur O'Dwyer , I have updated test, can you review it? Thanks

Jul 20 2021, 8:20 AM · Restricted Project
NancyWang2222 added inline comments to D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .
Jul 20 2021, 7:31 AM · Restricted Project

Jul 19 2021

NancyWang2222 updated the diff for D106153: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF8.

change test cases to be unsupported on z/OS

Jul 19 2021, 4:50 PM · Restricted Project
NancyWang2222 updated the diff for D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .

add unsupported on zOS for 2 failing test cases

Jul 19 2021, 4:48 PM · Restricted Project
NancyWang2222 added a comment to D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .

hi Arthur O'Dwyer, I am thinking if we can add unsupported cxx-03 for both test cases with current resolution. adding u'some test' or u'a' is right syntax for uchar16_t , same for utf8_t type. any thoughts about this ?

Jul 19 2021, 6:45 AM · Restricted Project

Jul 16 2021

NancyWang2222 added a comment to D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .

yeah. I also have same question as Sean mentioned. codecvt class for UTF16/32_t starts from c++11, utf8_t started from c++20. we shouldn't run with c++03. the error is expected.

Jul 16 2021, 1:05 PM · Restricted Project
NancyWang2222 added inline comments to D106153: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF8.
Jul 16 2021, 10:42 AM · Restricted Project
NancyWang2222 added inline comments to D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .
Jul 16 2021, 10:40 AM · Restricted Project
NancyWang2222 added inline comments to D106153: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF8.
Jul 16 2021, 10:33 AM · Restricted Project
NancyWang2222 added a comment to D106153: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF8.

do we know why build are failing ?

Jul 16 2021, 9:58 AM · Restricted Project
NancyWang2222 added a comment to D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .

LGTM (if icky) for the char8_t-based tests.
For the other two tests that are currently failing buildkite in C++03 mode (because u's' is a syntax error in C++03), personally I would recommend leaving the code alone and just UNSUPPORTED'ing them on zOS. They're already marked with

// This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.

which indicates that it's not too important to make this stuff work on "new" platforms — in fact we're actively deprecating/breaking it on "old" platforms and it might be completely moot by the time C++23 ships.

Jul 16 2021, 9:48 AM · Restricted Project
NancyWang2222 requested review of D106153: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF8.
Jul 16 2021, 7:28 AM · Restricted Project
NancyWang2222 added reviewers for D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 : uweigand, hubert.reinterpretcast, abhina.sreeskantharajan, fanbo-meng, muiez, Restricted Project.
Jul 16 2021, 7:22 AM · Restricted Project
NancyWang2222 requested review of D106151: [SystemZ][z/OS][libcxx]: fix libcxx test cases related to codecvt class UTF16/32 .
Jul 16 2021, 7:19 AM · Restricted Project

Jun 28 2021

NancyWang2222 updated the diff for D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.
Jun 28 2021, 8:02 AM · Restricted Project
NancyWang2222 added inline comments to D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.
Jun 28 2021, 7:21 AM · Restricted Project
NancyWang2222 added a comment to D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.

hi Arthur O'Dwyer , can you kindly review it again? Thanks

Jun 28 2021, 6:52 AM · Restricted Project

Jun 24 2021

NancyWang2222 added a comment to D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.

ping :)

Jun 24 2021, 2:03 PM · Restricted Project
NancyWang2222 updated the diff for D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.

use new assert pattern so that we can keep old tests

Jun 24 2021, 12:31 PM · Restricted Project
NancyWang2222 added inline comments to D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.
Jun 24 2021, 11:11 AM · Restricted Project
NancyWang2222 updated the diff for D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.
  1. added assert(std::char_traits<char>::lt('A','a') == !std::char_traits<char>::lt('a','A')); for case insensitive test.
  2. make content of 2 test cases same except one testing char type another one testing wchar_t
Jun 24 2021, 9:16 AM · Restricted Project
NancyWang2222 added inline comments to D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.
Jun 24 2021, 7:12 AM · Restricted Project

Jun 23 2021

NancyWang2222 updated subscribers of D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.
Jun 23 2021, 1:18 PM · Restricted Project
NancyWang2222 added a comment to D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.

ping ;) can I get review for this ?

Jun 23 2021, 12:19 PM · Restricted Project

Jun 22 2021

NancyWang2222 requested review of D104748: [SystemZ][z/OS][libcxx]: fix libcxx test cases failed on ebcdic mode on z/OS.
Jun 22 2021, 2:13 PM · Restricted Project

Mar 18 2021

NancyWang2222 updated the summary of D98793: [SystemZ][z/OS] fix lit test related to alignment .
Mar 18 2021, 11:41 AM · Restricted Project
NancyWang2222 updated the summary of D98793: [SystemZ][z/OS] fix lit test related to alignment .
Mar 18 2021, 11:40 AM · Restricted Project
NancyWang2222 updated the summary of D98793: [SystemZ][z/OS] fix lit test related to alignment .
Mar 18 2021, 11:39 AM · Restricted Project
NancyWang2222 updated the diff for D98793: [SystemZ][z/OS] fix lit test related to alignment .
Mar 18 2021, 11:37 AM · Restricted Project
NancyWang2222 added a comment to D98793: [SystemZ][z/OS] fix lit test related to alignment .

Hi Nancy, can you set this patch as a child revision of https://reviews.llvm.org/D98864 which sets the maximum alignment.

Mar 18 2021, 9:54 AM · Restricted Project
NancyWang2222 added inline comments to D98793: [SystemZ][z/OS] fix lit test related to alignment .
Mar 18 2021, 9:38 AM · Restricted Project

Mar 17 2021

NancyWang2222 added a reviewer for D98793: [SystemZ][z/OS] fix lit test related to alignment : abhina.sreeskantharajan.
Mar 17 2021, 10:35 AM · Restricted Project
NancyWang2222 updated the summary of D98793: [SystemZ][z/OS] fix lit test related to alignment .
Mar 17 2021, 10:32 AM · Restricted Project
NancyWang2222 updated the summary of D98793: [SystemZ][z/OS] fix lit test related to alignment .
Mar 17 2021, 10:27 AM · Restricted Project
NancyWang2222 requested review of D98793: [SystemZ][z/OS] fix lit test related to alignment .
Mar 17 2021, 10:24 AM · Restricted Project