User Details
- User Since
- Mar 16 2021, 11:08 AM (99 w, 10 h)
Nov 22 2022
@vsapsai hi Volodymyr Sapsai , test case clang/test/Modules/hidden-duplicates.m is failing on our llvm community AIX box https://lab.llvm.org/buildbot/#/builders/214/builds/4442/steps/6/logs/FAIL__Clang__hidden-duplicates_m , it gives exit code 70 without detail error message, can you help fix it as soon as possible. Thanks
Oct 14 2022
use std:: to replace _VSTD::
Oct 4 2022
Mar 1 2022
ping for the review. Thanks
please kindly review this patch again. thanks.
Feb 18 2022
Oh, sorry. For some reason I thought z/OS and AIX were the same thing. Are you working on libc++ officially supporting z/OS? If that is the case, maybe it would be a good idea to add a CI node for that?
Can I have 2nd review from libcxx. Thanks.
Can I have 2nd review from libcxx? Thanks
can I have 2nd review from libcxx?
Feb 16 2022
kindly ping for review or approval from libcxx group :)
kindly ping for review or approval from libcxx group
ping :)
Feb 14 2022
@ldionne @Quuxplusone I have addressed comment, Can you help review again. Thanks for the feedback.
@ldionne hi Louis, Can you help review again? Thanks everyone for providing feedback.
Feb 11 2022
change function name letter_value to alphabetical_index
please ignore comment.
change function name and return type
remove extra space
add _LIBCPP_HIDE_FROM_ABI for function __is_valid_in_encoding
match the format suggested by git-clang-format
Feb 10 2022
if no more comments on this PR. plan to land it . Thanks for the feedback.
fix indentation for the function modified.
I rebased with latest master. hope it will fix error.
run git-clang-format for the changes
Feb 9 2022
address comment: change function name from LetterNum to letter_value, and remove extra blank line , also remove constexpr.
fix function name for locale.cpp as well.
change isbasic function name and fix return __c ? true: true statement
Feb 4 2022
ping -:)
ping -:)
ping -:)
Feb 3 2022
include <cctype> so tolower function can be recognized when localization is disabled
need a guard in libcxx/include/charconv as well.
remove an extra curly bracket
put guard in __locale when include locale.h
only include <locale> when _LIBCPP_HAS_NO_LOCALIZATION is not defined
Feb 2 2022
move #include <locale> up one line according to alphabetical order
Feb 1 2022
Jan 24 2022
Simplify the comments
Aug 10 2021
hi do you know Why this patch was closed?
hi There is the failing test case libcxx/test/std/input.output/filesystems/class.path/path.member/path.append.pass.cpp , this test case is not in https://reviews.llvm.org/D107124 and https://reviews.llvm.org/D105910 , the failure seems not related to this patch. it fails same without this patch. we will investigate separately. rest of tests in https://reviews.llvm.org/D107124 and https://reviews.llvm.org/D105910 passed. Thanks for the fixes.
Assertion failed: Result == E, file: /plex/wangn/llvm/dev/llvm-project/libcxx/test/std/input.output/filesystems/class.path/path.member/path.append.pass.cpp, line: 250
CEE5207E The signal SIGABRT was received.
Aug 9 2021
The changes look ok to me although I havent tried it on z/OS as long as build pass. I will fix in separate patch if there is an issue on z/OS. just want to confirm those assert wont be run on z/OS and assert macros are empty. I will need some time to download patch and test it out.
Let me know if this is ready, I will need to test it on z/OS.
Aug 6 2021
hi Any suggestion how we should fix those test case, I can add unsupport on z/OS.
Aug 4 2021
@Quuxplusone Thanks Arthur, I can remove delete macro. let me know how windows works if need me to check windows as well.
@Quuxplusone hi Arthur, Can you review ?
Jul 30 2021
Hi I only updated 3 test cases , I didnt modify test cases in https://reviews.llvm.org/D105910 , because @DanielMcIntosh-IBM did some investigation already in those test cases, I will let him handle it. another reason is I am unable to test windows if it requires modify macros for windows as well
Thanks. will look into how ASSERT_VIA_OVERRIDDEN_NEW works
Jul 29 2021
Jul 27 2021
ping :)
Jul 26 2021
@ldionne hi Louis, any question regarding to this PR, I noticed you reviewed similar changes before. Thanks.
Jul 20 2021
hi Arthur O'Dwyer , I have updated test, can you review it? Thanks
Jul 19 2021
change test cases to be unsupported on z/OS
add unsupported on zOS for 2 failing test cases
hi Arthur O'Dwyer, I am thinking if we can add unsupported cxx-03 for both test cases with current resolution. adding u'some test' or u'a' is right syntax for uchar16_t , same for utf8_t type. any thoughts about this ?
Jul 16 2021
yeah. I also have same question as Sean mentioned. codecvt class for UTF16/32_t starts from c++11, utf8_t started from c++20. we shouldn't run with c++03. the error is expected.
do we know why build are failing ?
Jun 28 2021
hi Arthur O'Dwyer , can you kindly review it again? Thanks
Jun 24 2021
ping :)
use new assert pattern so that we can keep old tests