Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D130326

[ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches.
ClosedPublic
Actions

Authored by vsapsai on Jul 21 2022, 7:55 PM.

Details

Reviewers
ChuanqiXu
Bigcheese
jansvoboda11
bruno
Commits
rGdcb71b5e1d13: [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches.

Diff Detail

Event Timeline

vsapsai created this revision.Jul 21 2022, 7:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2022, 7:55 PM
Herald added a subscriber: ributzka. · View Herald Transcript
vsapsai requested review of this revision.Jul 21 2022, 7:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2022, 7:55 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
vsapsai added a parent revision: D130325: [ODRHash] Hash `ObjCMethodDecl` and diagnose discovered mismatches..Jul 21 2022, 7:55 PM
vsapsai added a child revision: D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing..Jul 21 2022, 7:57 PM
Harbormaster completed remote builds in B176913: Diff 446696.Jul 21 2022, 8:29 PM
vsapsai updated this revision to Diff 465953.Oct 6 2022, 6:33 PM

Rebase.

Harbormaster completed remote builds in B190870: Diff 465953.Oct 6 2022, 6:34 PM
vsapsai mentioned this in D130324: [ODRHash] Hash `ObjCProtocolDecl` and diagnose discovered mismatches..Oct 11 2022, 5:05 PM
vsapsai updated this revision to Diff 469443.Oct 20 2022, 6:19 PM

Rebase.

Harbormaster completed remote builds in B193399: Diff 469443.Oct 20 2022, 6:19 PM
vsapsai added reviewers: ChuanqiXu, Bigcheese, jansvoboda11.Oct 20 2022, 6:21 PM
vsapsai added a comment.Nov 10 2022, 5:43 PM

Ping.

vsapsai added a reviewer: bruno.Nov 10 2022, 5:44 PM
bruno accepted this revision.Nov 10 2022, 10:49 PM

Very nice how this has improved since the version I worked on in the past, thanks!

This revision is now accepted and ready to land.Nov 10 2022, 10:49 PM
This revision was landed with ongoing or failed builds.Nov 17 2022, 5:22 PM
Closed by commit rGdcb71b5e1d13: [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches. (authored by vsapsai). · Explain Why
This revision was automatically updated to reflect the committed changes.
vsapsai added a commit: rGdcb71b5e1d13: [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches..
vsapsai added a comment.Nov 17 2022, 5:22 PM

Thanks for the review!

Revision Contents
Changeset List

PathSize
clang/
include/
clang/
AST/
10 lines
Basic/
30 lines
lib/
AST/
86 lines
10 lines
test/
Modules/
105 lines

Diff 476296

View Options

clang/include/clang/AST/ODRDiagsEmitter.h

Loading...
View Options

clang/include/clang/Basic/DiagnosticASTKinds.td

Loading...
View Options

clang/lib/AST/ODRDiagsEmitter.cpp

Loading...
View Options

clang/lib/AST/ODRHash.cpp

Loading...
View Options

clang/test/Modules/compare-objc-protocol.m

Loading...