Page MenuHomePhabricator
People Bigcheese

Bigcheese (Michael Spencer)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 7 2012, 3:08 PM (445 w, 9 h)

Recent Activity
View All

Thu, Jan 14

Bigcheese accepted D94682: [clang][cli] Parse Lang and CodeGen options separately.

LGTM.

Thu, Jan 14, 9:16 AM · Restricted Project
Bigcheese accepted D94681: [clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members.

LGTM.

Thu, Jan 14, 9:09 AM · Restricted Project
Bigcheese accepted D94680: [clang][cli] NFC: Parse some LangOpts after the defaults are set.

LGTM.

Thu, Jan 14, 9:03 AM · Restricted Project
Bigcheese accepted D94679: [clang][cli] NFC: Add PIE parsing for precompiled input and IR.

LGTM.

Thu, Jan 14, 9:01 AM · Restricted Project
Bigcheese accepted D94678: [clang][cli] Parse & generate options necessary for LangOptions defaults manually.

LGTM with the comment.

Thu, Jan 14, 8:58 AM · Restricted Project
Bigcheese accepted D94676: [clang][cli] Specify KeyPath prefixes via TableGen classes.

LGTM.

Thu, Jan 14, 8:53 AM · Restricted Project, Restricted Project
Bigcheese accepted D94675: [clang][cli] NFC: Decrease the scope of ParseCodeGenArgs parameters.

LGTM.

Thu, Jan 14, 8:41 AM · Restricted Project
Bigcheese accepted D94674: [clang][cli] NFC: Decrease the scope of ParseLangArgs parameters.

LGTM.

Thu, Jan 14, 8:39 AM · Restricted Project

Tue, Jan 5

Bigcheese accepted D84674: [clang][cli] Allow users to specify a conditional to prevent parsing options with MarshallingInfo.

lgtm

Tue, Jan 5, 8:57 AM · Restricted Project, Restricted Project
Bigcheese accepted D93636: [clang][cli] Implement ContainsN Google Test matcher.

We don't really have anywhere specific to put extra matchers, and we don't want to add stuff to the actual gtest folder so it's easy to merge updates. So this is fine.

Tue, Jan 5, 8:49 AM · Restricted Project
Bigcheese accepted D93700: [clang][cli] Report the actual argument parsing result.

LGTM

Tue, Jan 5, 8:40 AM · Restricted Project

Dec 17 2020

Bigcheese added a comment to D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line.

This looks fine to be as that code is definitely dead. I would wait for @SjoerdMeijer in case there's a bug in the existing code.

Dec 17 2020, 9:36 AM · Restricted Project
Bigcheese accepted D84672: [clang][cli] Port PreprocessorOpts simple string based options to new option parsing system.

lgtm

Dec 17 2020, 9:30 AM · Restricted Project
Bigcheese accepted D84671: [clang][cli] Port LangOpts simple string based options to new option parsing system.

lgtm.

Dec 17 2020, 9:27 AM · Restricted Project, Restricted Project
Bigcheese accepted D84670: [clang][cli] Port HeaderSearch simple string options to new option parsing system.

lgtm with nit.

Dec 17 2020, 9:15 AM · Restricted Project
Bigcheese accepted D84668: [clang][cli] Port TargetOpts simple string based options to new option parsing system.

lgtm with the fix above.

Dec 17 2020, 9:12 AM · Restricted Project
Bigcheese accepted D84669: [clang][cli] Port CodeGenOpts simple string flags to new option parsing system.

lgtm with the comment.

Dec 17 2020, 8:56 AM · Restricted Project

Dec 15 2020

Bigcheese accepted D93094: [clang][cli] Prevent double denormalization.

lgtm with the test fix.

Dec 15 2020, 8:52 AM · Restricted Project, Restricted Project
Bigcheese accepted D93008: [clang][cli] Do not marshall only CC1Option flags in BoolOption.

lgtm.

Dec 15 2020, 8:41 AM · Restricted Project, Restricted Project

Dec 11 2020

Bigcheese accepted D92191: [clang-scan-deps] Add support for clang-cl.

lgtm. Thanks for the patch.

Dec 11 2020, 2:51 PM · Restricted Project

Dec 9 2020

Bigcheese accepted D92857: [clang][cli] Don't always emit -f[no-]legacy-pass-manager.

LGTM. I don't see any reason to always emit this option.

Dec 9 2020, 10:23 AM · Restricted Project, Restricted Project

Dec 8 2020

Bigcheese added inline comments to D92775: [clang][cli] Add flexible TableGen multiclass for boolean options.
Dec 8 2020, 8:37 AM · Restricted Project, Restricted Project

Nov 30 2020

Bigcheese accepted D92330: [clang-scan-deps] Improve argument parsing to find target object file path..

lgtm.

Nov 30 2020, 11:16 AM · Restricted Project
Bigcheese added a reviewer for D92330: [clang-scan-deps] Improve argument parsing to find target object file path.: jansvoboda11.
Nov 30 2020, 11:13 AM · Restricted Project

Nov 24 2020

Bigcheese accepted D83698: [clang][cli] Port Target option flags to new option parsing system.

LGTM

Nov 24 2020, 9:14 AM · Restricted Project
Bigcheese added inline comments to D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC).
Nov 24 2020, 9:06 AM · Restricted Project, Restricted Project
Bigcheese accepted D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC).
Nov 24 2020, 8:53 AM · Restricted Project, Restricted Project

Nov 11 2020

Bigcheese added a comment to D84050: [YAMLIO] Support non-null-terminated inputs.
In D84050#2315437, @dexonsmith wrote:
In D84050#2242755, @arsenm wrote:
In D84050#2189370, @bkramer wrote:

The parser used to rely on the \0 being present. Was that fixed?

Do you know where this assumption was? I couldn't find it, but also couldn't find any commits that seemed to "fix" it. I haven't seen a sanitizer error yet

I just did a quick scan and I can't find any such assumption either. @Bigcheese, do remember what the original intent was?

Nov 11 2020, 4:38 PM · Restricted Project

Nov 10 2020

Bigcheese accepted D82860: Port ObjCMTAction to new option parsing system.

LGTM.

Nov 10 2020, 8:58 AM · Restricted Project, Restricted Project

Nov 5 2020

Bigcheese accepted D82756: Port some floating point options to new option marshalling infrastructure.

LGTM

Nov 5 2020, 4:27 PM · Restricted Project, Restricted Project

Sep 23 2020

Bigcheese accepted D68997: Allow searching for prebuilt implicit modules..

LGTM

Sep 23 2020, 4:30 PM · Restricted Project

Aug 27 2020

Bigcheese accepted D86290: Move all fields of '-cc1' option related classes into def file databases.

lgtm.

Aug 27 2020, 10:12 AM · Restricted Project

Aug 19 2020

Bigcheese accepted D83298: Add ability to make fixups to CompilerInvocation after option parsing.

lgtm.

Aug 19 2020, 5:53 PM · Restricted Project
Bigcheese added inline comments to D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC).
Aug 19 2020, 5:52 PM · Restricted Project, Restricted Project
Bigcheese accepted D82860: Port ObjCMTAction to new option parsing system.

lgtm

Aug 19 2020, 5:45 PM · Restricted Project, Restricted Project

Aug 14 2020

Bigcheese accepted D83071: Add support for options with two flags for controlling the same field..

lgtm

Aug 14 2020, 10:07 AM · Restricted Project, Restricted Project

Jul 30 2020

Bigcheese added inline comments to D68997: Allow searching for prebuilt implicit modules..
Jul 30 2020, 1:31 PM · Restricted Project

Jul 20 2020

Bigcheese accepted D84185: [clang][cli] Better defaults for MarshallingInfoString.

lgtm

Jul 20 2020, 10:07 AM · Restricted Project, Restricted Project

Jul 17 2020

Bigcheese committed rG7fcc1bb4b654: [clangd] Fix the build with clang <3.9. (authored by Bigcheese).
[clangd] Fix the build with clang <3.9.
Jul 17 2020, 3:14 PM
Bigcheese committed rGfda901a987dd: [Clang] Fix building with Clang < 3.9. (authored by Bigcheese).
[Clang] Fix building with Clang < 3.9.
Jul 17 2020, 12:34 PM

Jul 14 2020

GitHub <noreply@github.com> committed rG5cbb4fe23a48: Merge pull request #1327 from Bigcheese/59908962 (authored by Bigcheese).
Merge pull request #1327 from Bigcheese/59908962
Jul 14 2020, 4:54 PM
Bigcheese committed rG41745af7f7b9: [clang] Use IsVolatile=true and RequiresNullTerminator=false for PCMs (authored by Bigcheese).
[clang] Use IsVolatile=true and RequiresNullTerminator=false for PCMs
Jul 14 2020, 4:54 PM
GitHub <noreply@github.com> committed rG82811095a908: Merge pull request #1251 from Bigcheese/44987 (authored by Bigcheese).
Merge pull request #1251 from Bigcheese/44987
Jul 14 2020, 4:51 PM
Bigcheese committed rG6ffd432a8966: Use FinishThunk to finish musttail thunks (authored by rnk).
Use FinishThunk to finish musttail thunks
Jul 14 2020, 4:51 PM
GitHub <noreply@github.com> committed rG809d01c5274e: Merge pull request #1239 from Bigcheese/fix-intrin (authored by Bigcheese).
Merge pull request #1239 from Bigcheese/fix-intrin
Jul 14 2020, 4:51 PM
Bigcheese committed rGca9ed6e2fb3c: Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform." (authored by Bigcheese).
Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform."
Jul 14 2020, 4:51 PM
Bigcheese added a reverting change for rG92146ce399cd: Re-fix _lrotl/_lrotr to always take Long, no matter the platform.: rGca9ed6e2fb3c: Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform.".
Jul 14 2020, 4:51 PM
GitHub <noreply@github.com> committed rG768b425799ae: Merge pull request #1129 from Bigcheese/cherry-pick-d69575 (authored by Bigcheese).
Merge pull request #1129 from Bigcheese/cherry-pick-d69575
Jul 14 2020, 4:47 PM
Bigcheese committed rG082948a2d269: Improve module.pcm lock file performance on machines with high core counts (authored by Ladd).
Improve module.pcm lock file performance on machines with high core counts
Jul 14 2020, 4:47 PM
GitHub <noreply@github.com> committed rG526621643c79: Merge pull request #1117 from Bigcheese/modules-mmap (authored by Bigcheese).
Merge pull request #1117 from Bigcheese/modules-mmap
Jul 14 2020, 4:47 PM
Bigcheese committed rGce625f14169e: [Clang] Expose RequiresNullTerminator in FileManager. (authored by Bigcheese).
[Clang] Expose RequiresNullTerminator in FileManager.
Jul 14 2020, 4:47 PM
GitHub <noreply@github.com> committed rGe3385fb7bf91: Merge pull request #880 from Bigcheese/apple/arm_acle (authored by Bigcheese).
Merge pull request #880 from Bigcheese/apple/arm_acle
Jul 14 2020, 4:32 PM
Bigcheese committed rG459ab6a9bbbc: [clang][Headers] Use __has_builtin instead of _MSC_VER. (authored by Bigcheese).
[clang][Headers] Use __has_builtin instead of _MSC_VER.
Jul 14 2020, 4:32 PM
GitHub <noreply@github.com> committed rG0066d17dac4a: Merge pull request #792 from Bigcheese/scan-deps-stable (authored by Bigcheese).
Merge pull request #792 from Bigcheese/scan-deps-stable
Jul 14 2020, 4:24 PM
Bigcheese committed rG6df82a89ea5f: [Clang][Lex] Remove debugging code. (authored by Bigcheese).
[Clang][Lex] Remove debugging code.
Jul 14 2020, 4:24 PM
Bigcheese committed rGe85477ddb3e2: [Clang][ScanDeps] Ignore __inferred_module.map dependency. (authored by Bigcheese).
[Clang][ScanDeps] Ignore __inferred_module.map dependency.
Jul 14 2020, 4:24 PM
Bigcheese committed rG2572468081c2: [Clang] Fix the header paths in `clang::Module` for inferred modules. (authored by Bigcheese).
[Clang] Fix the header paths in `clang::Module` for inferred modules.
Jul 14 2020, 4:24 PM
Bigcheese committed rG0c02ad99db51: [Clang] Allow explicitly building an inferred module. (authored by Bigcheese).
[Clang] Allow explicitly building an inferred module.
Jul 14 2020, 4:24 PM
Bigcheese committed rG008966ca2e47: [Clang][cc1] Support -fno-implicit-module-maps in -cc1. (authored by Bigcheese).
[Clang][cc1] Support -fno-implicit-module-maps in -cc1.
Jul 14 2020, 4:24 PM
Bigcheese committed rG9205e61ea88a: [Clang] Temporarily comment out assert. (authored by Bigcheese).
[Clang] Temporarily comment out assert.
Jul 14 2020, 4:24 PM
Bigcheese committed rG46cfddafe85b: [Clang][ScanDeps] Use the module map a module was inferred from for inferred… (authored by Bigcheese).
[Clang][ScanDeps] Use the module map a module was inferred from for inferred…
Jul 14 2020, 4:24 PM
Bigcheese committed rG27bc98ab34ff: [Clang][ScanDeps] Actually pass the non path command line modifications. (authored by Bigcheese).
[Clang][ScanDeps] Actually pass the non path command line modifications.
Jul 14 2020, 4:24 PM
Bigcheese committed rG7eb316817ef6: [Clang][cc1] Add -remove-preceeding-explicit-module-build-incompatible-options (authored by Bigcheese).
[Clang][cc1] Add -remove-preceeding-explicit-module-build-incompatible-options
Jul 14 2020, 4:24 PM
Bigcheese committed rGb24296d9e4be: [libclang] Add clang_Driver_getExternalActionsForCommand_v0 (authored by Bigcheese).
[libclang] Add clang_Driver_getExternalActionsForCommand_v0
Jul 14 2020, 4:24 PM
Bigcheese committed rGe7c6ab3bcd43: [clang][clang-scan-deps] Add an experimental C API. (authored by Bigcheese).
[clang][clang-scan-deps] Add an experimental C API.
Jul 14 2020, 4:24 PM
Bigcheese committed rG696e280a36dd: [Clang][ScanDeps] Pass diagnostics to `getModuleHash`. (authored by Bigcheese).
[Clang][ScanDeps] Pass diagnostics to `getModuleHash`.
Jul 14 2020, 4:24 PM
Bigcheese committed rG53947a577ead: [clang][clang-scan-deps] Aggregate the full dependency information. (authored by Bigcheese).
[clang][clang-scan-deps] Aggregate the full dependency information.
Jul 14 2020, 4:24 PM
GitHub <noreply@github.com> committed rG8bd683f83e1f: Merge pull request #754 from Bigcheese/scan-deps-stable (authored by Bigcheese).
Merge pull request #754 from Bigcheese/scan-deps-stable
Jul 14 2020, 4:22 PM
Bigcheese committed rGb429e1cf63dc: [Clang][Lex] Remove debugging code. (authored by Bigcheese).
[Clang][Lex] Remove debugging code.
Jul 14 2020, 4:22 PM
Bigcheese committed rG05bfc81f9d0a: [Clang][ScanDeps] Ignore __inferred_module.map dependency. (authored by Bigcheese).
[Clang][ScanDeps] Ignore __inferred_module.map dependency.
Jul 14 2020, 4:22 PM
Bigcheese committed rG3ddc2d4b1228: [Clang] Fix the header paths in `clang::Module` for inferred modules. (authored by Bigcheese).
[Clang] Fix the header paths in `clang::Module` for inferred modules.
Jul 14 2020, 4:22 PM
Bigcheese committed rG56ff1f1096fa: [Clang] Allow explicitly building an inferred module. (authored by Bigcheese).
[Clang] Allow explicitly building an inferred module.
Jul 14 2020, 4:22 PM
Bigcheese committed rG4876ab38323f: [Clang][cc1] Support -fno-implicit-module-maps in -cc1. (authored by Bigcheese).
[Clang][cc1] Support -fno-implicit-module-maps in -cc1.
Jul 14 2020, 4:22 PM
Bigcheese committed rG61c21390a146: [Clang] Temporarily comment out assert. (authored by Bigcheese).
[Clang] Temporarily comment out assert.
Jul 14 2020, 4:22 PM
Bigcheese committed rG4e1cda68107a: [Clang][ScanDeps] Use the module map a module was inferred from for inferred… (authored by Bigcheese).
[Clang][ScanDeps] Use the module map a module was inferred from for inferred…
Jul 14 2020, 4:22 PM
Bigcheese committed rG611489822fce: [Clang][ScanDeps] Actually pass the non path command line modifications. (authored by Bigcheese).
[Clang][ScanDeps] Actually pass the non path command line modifications.
Jul 14 2020, 4:22 PM
Bigcheese committed rGcf2048b954f8: [Clang][cc1] Add -remove-preceeding-explicit-module-build-incompatible-options (authored by Bigcheese).
[Clang][cc1] Add -remove-preceeding-explicit-module-build-incompatible-options
Jul 14 2020, 4:22 PM
Bigcheese committed rGced3ced67cd5: [libclang] Add clang_Driver_getExternalActionsForCommand_v0 (authored by Bigcheese).
[libclang] Add clang_Driver_getExternalActionsForCommand_v0
Jul 14 2020, 4:21 PM
Bigcheese committed rGe23a09ebb8d7: [clang][clang-scan-deps] Add an experimental C API. (authored by Bigcheese).
[clang][clang-scan-deps] Add an experimental C API.
Jul 14 2020, 4:21 PM
Bigcheese committed rGcd0f9c81c08e: [Clang][ScanDeps] Pass diagnostics to `getModuleHash`. (authored by Bigcheese).
[Clang][ScanDeps] Pass diagnostics to `getModuleHash`.
Jul 14 2020, 4:21 PM
Bigcheese committed rG3299f974dc3b: [clang][clang-scan-deps] Aggregate the full dependency information. (authored by Bigcheese).
[clang][clang-scan-deps] Aggregate the full dependency information.
Jul 14 2020, 4:21 PM

Jul 13 2020

Bigcheese accepted D83406: Remove NormalizerRetTy and use the decltype of the KeyPath instead.

lgtm

Jul 13 2020, 10:22 AM · Restricted Project, Restricted Project
Bigcheese accepted D83690: Port Migator option flags to new option parsing system.

lgtm

Jul 13 2020, 10:19 AM · Restricted Project

Jul 7 2020

Bigcheese committed rG64788d7d5377: [clang] Include missing LangOpts in `getModuleHash`. (authored by Bigcheese).
[clang] Include missing LangOpts in `getModuleHash`.
Jul 7 2020, 4:15 PM
Bigcheese accepted D82574: Merge TableGen files used for clang options.

LGTM. We can look at splitting it up again once we know what the dependencies are.

Jul 7 2020, 10:38 AM · Restricted Project
Bigcheese accepted D83315: Turn arcmt-* options into a single option.

I have a slight preference for -arcmt-action=, but up to you if you want to change it. Otherwise LGTM.

Jul 7 2020, 10:31 AM · Restricted Project, Restricted Project

Jun 30 2020

Bigcheese accepted D82874: Add diagnostic option backing field for -fansi-escape-codes.

lgtm with the fix I mentioned.

Jun 30 2020, 10:50 AM · Restricted Project

Jun 23 2020

Bigcheese accepted D79796: Sketch support for generating CC1 command line from CompilerInvocation.

LGTM with KeyPathPrefix moved to the patch that actually uses it.

Jun 23 2020, 11:15 AM · Restricted Project, Restricted Project

Jun 19 2020

Bigcheese added inline comments to D79796: Sketch support for generating CC1 command line from CompilerInvocation.
Jun 19 2020, 2:41 PM · Restricted Project, Restricted Project

Jun 13 2020

Bigcheese added a comment to D81801: Remove KillTheDoctor.

The reason KillTheDoctor exists is because of test-suite. It compiles and runs programs that do not contain calls to that API, and can do so with non-llvm compilers. I personally don't use it anymore as I don't run test-suite on Windows anymore, but I'm still not aware of any way short of changing registry settings to run test-suite on Windows without hanging other than this.

Jun 13 2020, 6:09 PM · Restricted Project, Restricted Project

Jun 11 2020

Bigcheese accepted D81588: Make behavior of getValueAsListOfStrings consistent with getValueAsString.

lgtm.

Jun 11 2020, 10:28 AM · Restricted Project

Jun 10 2020

Bigcheese committed rG1727c6aab340: [clang] Use IsVolatile=true and RequiresNullTerminator=false for PCMs (authored by Bigcheese).
[clang] Use IsVolatile=true and RequiresNullTerminator=false for PCMs
Jun 10 2020, 1:56 PM

Jun 3 2020

Bigcheese added inline comments to D79796: Sketch support for generating CC1 command line from CompilerInvocation.
Jun 3 2020, 5:40 PM · Restricted Project, Restricted Project

May 19 2020

Bigcheese added inline comments to D79796: Sketch support for generating CC1 command line from CompilerInvocation.
May 19 2020, 5:06 PM · Restricted Project, Restricted Project
Bigcheese added a comment to D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3).
In D79998#2038430, @dang wrote:

Should I add the test here or in the clang-scan-deps patch?

May 19 2020, 4:34 PM · Restricted Project
Bigcheese added a comment to D80172: Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform.".
In D80172#2042946, @rnk wrote:

I'd be fine going back to the behavior from before.

Without this behavior there is no intrinsic for 32 bit rotates on these platforms.

Strictly speaking, there seems to be __builtin_rotate(left|right)32, which is portable to all clang platforms.

May 19 2020, 12:02 PM · Restricted Project

May 18 2020

Bigcheese created D80172: Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform.".
May 18 2020, 4:50 PM · Restricted Project

May 13 2020

Bigcheese added a comment to D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..

I mostly just need to rebase this patch now. I'll try to get to that soon.

May 13 2020, 10:50 AM · Restricted Project, Restricted Project

Apr 21 2020

Bigcheese accepted D78330: [libc++abi] Add a rate limiter when logging dynamic_cast errors.

LGTM

Apr 21 2020, 12:26 PM · Restricted Project

Apr 15 2020

Bigcheese committed rGbca47ef80e3e: [LLVM][SupportTests] Ask the OS how large the page size is instead of guessing. (authored by Bigcheese).
[LLVM][SupportTests] Ask the OS how large the page size is instead of guessing.
Apr 15 2020, 3:28 PM