Page MenuHomePhabricator

Bigcheese (Michael Spencer)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 7 2012, 3:08 PM (403 w, 6 d)

Recent Activity

Today

Bigcheese accepted D76572: Replace `T(x)` with `reinterpret_cast<T>(x)` everywhere it means reinterpret_cast. No functional change.

LGTM for llvm/{lib,include/llvm}/Object/* and llvm/tools/llvm-readobj/*.

Fri, Apr 3, 2:38 PM · Restricted Project

Mon, Mar 23

Bigcheese committed rGa20862307fff: Improve module.pcm lock file performance on machines with high core counts (authored by Ladd).
Improve module.pcm lock file performance on machines with high core counts
Mon, Mar 23, 3:16 PM
Bigcheese closed D69575: Improve module.pcm lock file performance on machines with high core counts.
Mon, Mar 23, 3:16 PM · Restricted Project
Bigcheese added a comment to D69575: Improve module.pcm lock file performance on machines with high core counts.

committed as a20862307fff9385bbf6562de3154d05138f8bec.

Mon, Mar 23, 3:16 PM · Restricted Project

Fri, Mar 13

Bigcheese accepted D69575: Improve module.pcm lock file performance on machines with high core counts.

Sorry for the delay. LGTM. I'll commit with you as the author.

Fri, Mar 13, 12:55 PM · Restricted Project

Fri, Mar 6

Bigcheese committed rG16af23fae8ad: [clang][Headers] Use __has_builtin instead of _MSC_VER. (authored by Bigcheese).
[clang][Headers] Use __has_builtin instead of _MSC_VER.
Fri, Mar 6, 1:50 PM
Bigcheese closed D75719: [clang][Headers] Use __has_builtin instead of _MSC_VER..
Fri, Mar 6, 1:50 PM · Restricted Project

Thu, Mar 5

Bigcheese created D75719: [clang][Headers] Use __has_builtin instead of _MSC_VER..
Thu, Mar 5, 6:35 PM · Restricted Project
Bigcheese added a comment to D69575: Improve module.pcm lock file performance on machines with high core counts.

@Bigcheese -- any more thoughts on this one? It would be helpful to have some version of this fix in the release compiler.

Thu, Mar 5, 5:31 PM · Restricted Project

Mar 3 2020

Bigcheese committed rG27a3ecee4558: [clang][Modules] Add -fsystem-module flag (authored by Bigcheese).
[clang][Modules] Add -fsystem-module flag
Mar 3 2020, 2:27 PM
Bigcheese closed D75395: [clang][Modules] Add -fsystem-module flag.
Mar 3 2020, 2:26 PM · Restricted Project

Mar 2 2020

Bigcheese updated the diff for D75395: [clang][Modules] Add -fsystem-module flag.

Cleaned up the test to not reference unused paths.

Mar 2 2020, 4:38 PM · Restricted Project
Bigcheese added a comment to D75395: [clang][Modules] Add -fsystem-module flag.

This is used when
converting an implicit build to an explicit build to match the
systemness the implicit build would have had for a given module.

I had another thought. What if for the explicitly built "system" modules:

  • If -Wsystem-headers is on, leave them as user modules in the explicit build.
  • If -Wsystem-headers is off, turn off all diagnostics in the explicit build.

    Does that give the right semantics, or is there something subtly different?
Mar 2 2020, 2:56 PM · Restricted Project
Bigcheese added inline comments to D75395: [clang][Modules] Add -fsystem-module flag.
Mar 2 2020, 2:09 PM · Restricted Project

Feb 28 2020

Bigcheese created D75395: [clang][Modules] Add -fsystem-module flag.
Feb 28 2020, 5:38 PM · Restricted Project
Bigcheese committed rG0b6abe428164: [llvm][Support][modulemap] Exclude WindowsSupport.h from the LLVM_Util module (authored by Bigcheese).
[llvm][Support][modulemap] Exclude WindowsSupport.h from the LLVM_Util module
Feb 28 2020, 2:45 PM
Bigcheese added a comment to D74599: llvm-ar: Fix MinGW compilation.

I pushed a commit fixing this in rG0b6abe428164 by just excluding the header.

Feb 28 2020, 2:45 PM · Restricted Project
Bigcheese added a comment to D74599: llvm-ar: Fix MinGW compilation.

I'm pretty sure this commit broke the modules build on non-Windows. WindowsSupport.h is now part of the LLVM_Util module which gets built on all platforms. You need to update the modulemap to put it in its own module, or wrap it in #ifdef.

Feb 28 2020, 1:24 PM · Restricted Project

Feb 26 2020

Bigcheese accepted D74892: [lldb][cmake] Also use local submodule visibility on Darwin.

lgtm

Feb 26 2020, 2:57 PM · Restricted Project, Restricted Project

Feb 25 2020

Bigcheese added a comment to rG82b47b297840: [libc++] Move abs and div into stdlib.h to fix header cycle..

The aforementioned review is at https://reviews.llvm.org/D74892. I'm currently verifying it fixes everything for us. I'll update you when you're good to recommit this, which should happen this week.

Feb 25 2020, 1:11 PM

Feb 20 2020

Bigcheese committed rGd4ded05ba851: [libunwind][CMake] Treat S files as C to work around CMake bug. (authored by Bigcheese).
[libunwind][CMake] Treat S files as C to work around CMake bug.
Feb 20 2020, 3:28 PM
Bigcheese added a comment to D72952: [libunwind] Set LIBUNWIND_ASM_SOURCES to the ASM source language from C.

Confirmed that CMake has a bug here: https://github.com/Kitware/CMake/blob/master/Source/cmLocalGenerator.cxx#L1780

Feb 20 2020, 3:16 PM · Restricted Project
Bigcheese added a comment to D72952: [libunwind] Set LIBUNWIND_ASM_SOURCES to the ASM source language from C.

This change also breaks MacOS, as -arch doesn't get passed to these invocations. Possibly CMAKE_OSX_ARCHITECTURES not being handled correctly within CMake.

Feb 20 2020, 2:48 PM · Restricted Project

Feb 11 2020

Bigcheese added a comment to D69575: Improve module.pcm lock file performance on machines with high core counts.

I would love to see one of these land, but I'll need to find some time to do a deeper look at the two.

Feb 11 2020, 12:59 AM · Restricted Project

Jan 23 2020

Bigcheese added a comment to D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..

I was finally able to land the patch this depended on. Still waiting on review for this. In the meantime I've tested this ABI out by building a simple program that outputs a ninja file given a command line. It depends on a bunch of changes to the Clang side of things, but no changes to this interface.

Jan 23 2020, 5:20 PM · Restricted Project, Restricted Project
Bigcheese committed rG356a4b433bf7: [clang][clang-scan-deps] Aggregate the full dependency information. (authored by Bigcheese).
[clang][clang-scan-deps] Aggregate the full dependency information.
Jan 23 2020, 5:01 PM

Dec 12 2019

Bigcheese committed rGd68c11580e4c: Manually merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by Bigcheese).
Manually merge remote-tracking branch 'upstream/master' into upstream-with-swift
Dec 12 2019, 3:00 PM
Bigcheese committed rG7d6e268a26f6: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by Bigcheese).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Dec 12 2019, 3:00 PM
Bigcheese committed rG1cf6cf7cb191: Manually merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by Bigcheese).
Manually merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 2:57 PM

Dec 11 2019

Bigcheese committed rG5bcd34a03ff3: Revert "[clang][clang-scan-deps] Aggregate the full dependency information." (authored by Bigcheese).
Revert "[clang][clang-scan-deps] Aggregate the full dependency information."
Dec 11 2019, 4:37 PM
Bigcheese added a reverting change for rGf978ea498309: [clang][clang-scan-deps] Aggregate the full dependency information.: rG5bcd34a03ff3: Revert "[clang][clang-scan-deps] Aggregate the full dependency information.".
Dec 11 2019, 4:37 PM
Bigcheese committed rGf978ea498309: [clang][clang-scan-deps] Aggregate the full dependency information. (authored by Bigcheese).
[clang][clang-scan-deps] Aggregate the full dependency information.
Dec 11 2019, 2:48 PM
Bigcheese closed D70268: [clang][clang-scan-deps] Aggregate the full dependency information..
Dec 11 2019, 2:48 PM · Restricted Project
Bigcheese added a comment to D70268: [clang][clang-scan-deps] Aggregate the full dependency information..

Looks like the test for -full-command-line got dropped. I'll add that when I commit.

Dec 11 2019, 2:19 PM · Restricted Project

Dec 10 2019

Bigcheese updated the diff for D70268: [clang][clang-scan-deps] Aggregate the full dependency information..

Refactored FullDependencies::getAdditionalCommandLine and ModuleDeps::getFullCommandLine to share code.

Dec 10 2019, 5:05 PM · Restricted Project
Bigcheese added inline comments to D71239: [clang-format] Fix ObjC keywords following try/catch getting split..
Dec 10 2019, 2:47 PM · Restricted Project, Restricted Project

Dec 9 2019

Bigcheese created D71239: [clang-format] Fix ObjC keywords following try/catch getting split..
Dec 9 2019, 5:54 PM · Restricted Project, Restricted Project

Dec 5 2019

Bigcheese added inline comments to D70268: [clang][clang-scan-deps] Aggregate the full dependency information..
Dec 5 2019, 6:06 PM · Restricted Project
Bigcheese updated the diff for D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..
  • Remove duplicate decl
  • Add test
Dec 5 2019, 6:06 PM · Restricted Project, Restricted Project
Bigcheese updated the diff for D70268: [clang][clang-scan-deps] Aggregate the full dependency information..
  • Removed OutputPaths.
  • Add documentation for AlreadySeen.
Dec 5 2019, 6:06 PM · Restricted Project

Nov 22 2019

Bigcheese added a comment to D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..

It was already there from a previous commit. I see it in tree currently.

Nov 22 2019, 10:43 PM · Restricted Project
Bigcheese accepted D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC.

lgtm. Nice cleanup.

Nov 22 2019, 5:36 PM
Bigcheese added inline comments to D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..
Nov 22 2019, 1:12 PM · Restricted Project, Restricted Project
Bigcheese accepted D70610: [TableGen] Add backend to generate command guide for tools using libOption..

lgtm

Nov 22 2019, 1:11 PM · Restricted Project
Bigcheese accepted D70071: [ConstExprPreter] Removed the flag forcing the use of the interpreter.

lgtm

Nov 22 2019, 12:34 PM · Restricted Project
Bigcheese added inline comments to D70610: [TableGen] Add backend to generate command guide for tools using libOption..
Nov 22 2019, 12:26 PM · Restricted Project

Nov 21 2019

Bigcheese added inline comments to D70268: [clang][clang-scan-deps] Aggregate the full dependency information..
Nov 21 2019, 3:06 PM · Restricted Project
Bigcheese added a comment to D69122: Add support to find out resource dir and add it as compilation args.

Thanks, you're good to commit.

Nov 21 2019, 12:58 PM · Restricted Project

Nov 20 2019

Bigcheese added a comment to D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..

Adding experimental APIs is something that we haven't done before, but it be useful for this case.

Nov 20 2019, 4:34 PM · Restricted Project, Restricted Project
Bigcheese added inline comments to D70268: [clang][clang-scan-deps] Aggregate the full dependency information..
Nov 20 2019, 4:25 PM · Restricted Project

Nov 19 2019

Bigcheese accepted D70285: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes.

lgtm as long as other compilers don't warn on unknown pragmas by default.

Nov 19 2019, 11:29 AM · Restricted Project
Bigcheese accepted D69575: Improve module.pcm lock file performance on machines with high core counts.

A few minor points, but with those fixed this looks good to me. Thanks for the patch!

Nov 19 2019, 10:43 AM · Restricted Project

Nov 15 2019

Bigcheese updated the summary of D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..
Nov 15 2019, 5:53 PM · Restricted Project, Restricted Project
Bigcheese added a parent revision for D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.: D70268: [clang][clang-scan-deps] Aggregate the full dependency information..
Nov 15 2019, 5:44 PM · Restricted Project, Restricted Project
Bigcheese created D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..
Nov 15 2019, 5:44 PM · Restricted Project, Restricted Project
Bigcheese added a child revision for D70268: [clang][clang-scan-deps] Aggregate the full dependency information.: D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..
Nov 15 2019, 5:44 PM · Restricted Project

Nov 14 2019

Bigcheese resigned from D2431: [lld] Registry model for Readers and Reference Kind strings.
Nov 14 2019, 1:11 PM
Bigcheese resigned from D2225: [InputGraph][Gnu] Add Linkerscript support. .
Nov 14 2019, 1:11 PM
Bigcheese abandoned D12545: [elf2] Add basic archive file support..
Nov 14 2019, 1:11 PM
Bigcheese abandoned D664: [lld][Driver] Parallelize reading initial object files..
Nov 14 2019, 1:11 PM
Bigcheese abandoned D13275: [lld][elf2] Sort output sections..
Nov 14 2019, 1:11 PM
Bigcheese abandoned D3353: [Headers] Improve codegen for _mm_slli_epi32..
Nov 14 2019, 1:11 PM
Bigcheese abandoned D13615: [lld][elf2] Local Dynamic TLS.
Nov 14 2019, 1:11 PM
Bigcheese abandoned D697: [lld][ELF] Initialize readers and writers on creation..
Nov 14 2019, 1:11 PM
Bigcheese abandoned D1332: [lld] Update to LLVM ELFFile changes..
Nov 14 2019, 1:11 PM
Bigcheese abandoned D540: [clang][Driver] Nativize paths when emitting crash diagnostics..
Nov 14 2019, 1:11 PM
Bigcheese added reviewers for D70268: [clang][clang-scan-deps] Aggregate the full dependency information.: arphaman, kousikk.
Nov 14 2019, 1:02 PM · Restricted Project
Bigcheese created D70268: [clang][clang-scan-deps] Aggregate the full dependency information..
Nov 14 2019, 1:02 PM · Restricted Project

Nov 13 2019

Bigcheese accepted D69122: Add support to find out resource dir and add it as compilation args.

lgtm with the changes to FindResourceDir.

Nov 13 2019, 4:04 PM · Restricted Project
Bigcheese accepted D69958: Improve VFS compatibility on Windows.

lgtm. Looking at the blame it would be best if @JDevlieghere @vsapsai or @benlangmuir could take a look also.

Nov 13 2019, 1:52 PM · Restricted Project, Restricted Project

Oct 31 2019

Bigcheese committed rGd816d9bdc585: [clang][ScanDeps] Fix issue with multiple commands with the same input. (authored by Bigcheese).
[clang][ScanDeps] Fix issue with multiple commands with the same input.
Oct 31 2019, 2:25 PM
Bigcheese closed D69643: [clang][ScanDeps] Fix issue with multiple commands with the same input..
Oct 31 2019, 2:24 PM · Restricted Project

Oct 30 2019

Bigcheese committed rG17b64e36e90a: [clang][ScanDeps] Fix shadowing warning. (authored by Bigcheese).
[clang][ScanDeps] Fix shadowing warning.
Oct 30 2019, 3:55 PM
Bigcheese committed rG33a745e6fe7e: [clang][clang-scan-deps] Add support for extracting full module dependencies. (authored by Bigcheese).
[clang][clang-scan-deps] Add support for extracting full module dependencies.
Oct 30 2019, 3:29 PM
Bigcheese committed rG1c88d662230e: Revert "[clang][clang-scan-deps] Add support for extracting full module… (authored by Bigcheese).
Revert "[clang][clang-scan-deps] Add support for extracting full module…
Oct 30 2019, 3:18 PM
Bigcheese added a reverting change for rGd8a4ef0e685c: [clang][clang-scan-deps] Add support for extracting full module dependencies.: rG1c88d662230e: Revert "[clang][clang-scan-deps] Add support for extracting full module….
Oct 30 2019, 3:18 PM
Bigcheese committed rGd8a4ef0e685c: [clang][clang-scan-deps] Add support for extracting full module dependencies. (authored by Bigcheese).
[clang][clang-scan-deps] Add support for extracting full module dependencies.
Oct 30 2019, 2:49 PM
Bigcheese closed D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..
Oct 30 2019, 2:49 PM · Restricted Project
Bigcheese created D69643: [clang][ScanDeps] Fix issue with multiple commands with the same input..
Oct 30 2019, 2:21 PM · Restricted Project
Bigcheese accepted D61608: YAML parser robustness improvements.

lgtm, sorry for the delay, I didn't see the updates for some reason.

Oct 30 2019, 2:21 PM · Restricted Project

Oct 29 2019

Bigcheese requested changes to D69122: Add support to find out resource dir and add it as compilation args.

So I agree solving this problem makes sense, but I have some issues with the current patch.

Oct 29 2019, 3:25 PM · Restricted Project
Bigcheese updated the diff for D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..

I forgot to clang-format.

Oct 29 2019, 2:43 PM · Restricted Project
Bigcheese updated the diff for D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..

This fixes some issues I received externally.

Oct 29 2019, 2:34 PM · Restricted Project

Oct 28 2019

Bigcheese committed rGdddec1f1840b: [clang][clang-scan-deps] Add -fcxx-modules to test for Darwin. (authored by Bigcheese).
[clang][clang-scan-deps] Add -fcxx-modules to test for Darwin.
Oct 28 2019, 5:55 PM

Oct 25 2019

Bigcheese committed rG8da20560ab0d: [clang][DependencyScanning] 80-col. (authored by Bigcheese).
[clang][DependencyScanning] 80-col.
Oct 25 2019, 3:44 PM
Bigcheese added inline comments to D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..
Oct 25 2019, 3:43 PM · Restricted Project
Bigcheese updated the diff for D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..

Address review comments.

Oct 25 2019, 3:43 PM · Restricted Project

Oct 24 2019

Bigcheese committed rG7af309a4ed1a: [clang][DependencyScanning] clang-format. (authored by Bigcheese).
[clang][DependencyScanning] clang-format.
Oct 24 2019, 6:31 PM
Bigcheese created D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..
Oct 24 2019, 5:57 PM · Restricted Project
Bigcheese committed rG9ab6d8236b17: [clang-scan-deps] Add basic support for modules. (authored by Bigcheese).
[clang-scan-deps] Add basic support for modules.
Oct 24 2019, 4:24 PM
Bigcheese closed D68835: [clang-scan-deps] Add basic support for Clang modules..
Oct 24 2019, 4:24 PM · Restricted Project
Bigcheese added a reviewer for D69122: Add support to find out resource dir and add it as compilation args: klimek.

I've added Manuel as a reviewer as this patch is also changing the tooling APIs.

Oct 24 2019, 11:20 AM · Restricted Project

Oct 23 2019

Bigcheese added a reviewer for D69331: [LegacyPM] Port CGProfile pass: chandlerc.

This was originally not added to the legacy pass manager because it leaks memory under it due to fundamental issues with the old pass manager. See https://reviews.llvm.org/D48105#1140299 .

Oct 23 2019, 2:02 PM · Restricted Project

Oct 21 2019

Bigcheese accepted D69186: Refactor DependencyScanningTool to its own file.

LGTM with style nit. I like that this decouples DependencyScanningTool from printing the results.

Oct 21 2019, 5:38 PM · Restricted Project
Bigcheese added a comment to D69122: Add support to find out resource dir and add it as compilation args.

The current assumption is that the clang-scan-deps binary is the one that comes next to the clang binary you are using. There are lots of other differences between clang versions than just the resource-dir.

Oct 21 2019, 5:38 PM · Restricted Project
Bigcheese committed rG8896d073b190: [Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes… (authored by Bigcheese).
[Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes…
Oct 21 2019, 3:56 PM

Oct 19 2019

Bigcheese committed rG81a01e73faab: Revert "[Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which… (authored by Bigcheese).
Revert "[Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which…
Oct 19 2019, 2:46 AM

Oct 18 2019

Bigcheese committed rGd7cf99ae0370: [Docs] Fix header level. (authored by Bigcheese).
[Docs] Fix header level.
Oct 18 2019, 6:52 PM
Bigcheese committed rG14a3f77ba103: [Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes… (authored by Bigcheese).
[Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes…
Oct 18 2019, 6:43 PM
Bigcheese closed D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..
Oct 18 2019, 6:42 PM · Restricted Project