- User Since
- Jul 7 2012, 3:08 PM (379 w, 4 d)
Fixed spelling and updated comment.
Added .i, .ii, .mi, and .mmi as files to minimize.
lgtm. Jan may want to take a look as I believe he was looking at a related issue.
Mon, Oct 14
Thu, Oct 10
Addressed review comments.
Wed, Oct 9
lgtm, but wait for Alex or Duncan to also take a look.
Fri, Oct 4
Do we really want to output \r\n on Windows? There is all of one program (notepad.exe) that doesn't support \n on Windows.
Fri, Sep 27
Thu, Sep 26
Sep 11 2019
Sep 5 2019
Also, please use -U999999 for patches so there's full context.
Sep 4 2019
Looking more into this I'm not sure you need the PPCallbacks. The Preprocessor should just own the PreprocessorSkippedMappings data structure and the dependency scanner can update it live.
Sep 3 2019
Aug 30 2019
Aug 21 2019
Aug 15 2019
Aug 14 2019
Aug 13 2019
Aug 9 2019
This fix works, but we could also use openat to get around max path length issues. Windows also has an API that can be used similarly.
Aug 8 2019
Fixed and committed as r368381.
Aug 7 2019
This looks like a good simplification, but I think call_once could be simplified more.
Jul 31 2019
Jul 11 2019
looks good. @ldionne are you happy with the changes?
Jul 10 2019
_LIBCXXABI_NO_EXCEPTIONS removes the exceptions abi from libc++abi, so I think this change as fine as __cxa_throw isn't even defined if _LIBCXXABI_NO_EXCEPTIONS is defined.
Jul 3 2019
Jun 25 2019
Jun 17 2019
Where do you want to keep these open? The default OS limit on open files for OSX is 256.
Also adding the llvm-commits list.
Thanks a lot for working on this. There's a lot of room to improve the performance of exceptions that nobody has done for C++ yet. I've added some reviewers that I'm aware are familiar with the area or that I've talked with about this before.
Jun 10 2019
May 31 2019
It would be nice to get tests for these cases, although I realize that can be difficult as it requires malformed inputs.
May 29 2019
Thanks for finding this!
I find it a bit odd to have clang care about this, but I suppose it is the driver that knows which features tools support. I also have an issue with the name as CGProfilePass doesn't actually do the sorting. I would just keep the option as -enable-call-graph-profile-emission or something like that.
May 28 2019
May 22 2019
May 21 2019
Apr 24 2019
Apr 12 2019
I have a bit more review to do, but this is what I've found so far. The naming comments are just suggestions, but the digit separators' are actually an issue.
Mar 27 2019
Mar 8 2019
I agree with Zach, this should be little_t and big_t. You should also add aligned_big_t and aligned_little_t.
Mar 5 2019
Ah, I see. This seems fine.
What's the use case?
Feb 27 2019
Thanks for the update. This still looks incorrect in that SANITIZER_NON_UNIQUE_TYPEINFO should be 1 on defined(__arm64__) && SANITIZER_IOS and 0 otherwise on SANITIZER_MAC.
Feb 26 2019
Then I'm fine with the patch as is.
Should the +0 be +0x0 so that it's always a hex digit? Or is the +0 what the binutils already output?
Feb 20 2019
Feb 14 2019
I do not believe this change is correct for MacOS or iOS. The original bug does not reproduce on MacOS, and on arm64 iOS you always need to compare strings. Could you preserve the existing behavior for those platforms?
Dec 17 2018
Nov 12 2018
Ah, the bugs canceled each other out. Adding a unit test is fine. Just add a new file in llvm/unittests/Object/.
Overall this looks fine, but can you add a test of something that this fixes? I'm rather surprised that no tests fail now.
Nov 1 2018
Oct 25 2018
I'm all in favor of removing the warnings. I was against adding them to begin with.
Oct 24 2018
Pretty sure I understand the algorithm now, but I still want to see what performance impact it has to see if it's worth the (minor) complexity. I'll benchmark it on some large links and see what happens.
I really like adding the option to disable it, but I'm not sure about disabling it by default. Is there any situation where the profile is present where a user wouldn't want to perform layout? The algorithm is very fast so unexpected link time increase isn't really an issue, and the exact order of sections already isn't guaranteed by ELF and differs between linkers so I don't expect there to be correctness issues.
Sep 19 2018
- Added test for unorderable symbols from object files
- Removed unneeded temporary
Sep 17 2018
Sep 7 2018
Sep 5 2018
Address review comments.
Jul 23 2018
Jul 19 2018
Jul 18 2018
This just needs the recommonmark python package added on whatever server builds the docs.
Jul 3 2018
Is there a good reason the use cases you want this for can't be added to libSupport? I'm a bit worried about continuing to add platform specific code outside of libSupport.
Jun 28 2018
Jun 26 2018
Remove duplication on updating Counts.
Add support for indirect calls using value profiling data.
Jun 25 2018
- Move to new PM
- Use CallSite
- Bail early if no profile counts
- Use TargetTransformInfo::isLoweredToCall
Jun 19 2018
I mean performance of actual cases. I'm interested in if the cache effects of list vs vector matter.
Jun 14 2018
Sorry for the delay. What change in performance does this give?
Jun 13 2018
Use the correct diff.
This is enabled by default as the time and size overhead is so small.
Address review comments.