Page MenuHomePhabricator

Bigcheese (Michael Spencer)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 7 2012, 3:08 PM (392 w, 6 d)

Recent Activity

Dec 12 2019

Bigcheese committed rGd68c11580e4c: Manually merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by Bigcheese).
Manually merge remote-tracking branch 'upstream/master' into upstream-with-swift
Dec 12 2019, 3:00 PM
Bigcheese committed rG7d6e268a26f6: Merge remote-tracking branch 'upstream/master' into upstream-with-swift (authored by Bigcheese).
Merge remote-tracking branch 'upstream/master' into upstream-with-swift
Dec 12 2019, 3:00 PM
Bigcheese committed rG1cf6cf7cb191: Manually merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by Bigcheese).
Manually merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 2:57 PM

Dec 11 2019

Bigcheese committed rG5bcd34a03ff3: Revert "[clang][clang-scan-deps] Aggregate the full dependency information." (authored by Bigcheese).
Revert "[clang][clang-scan-deps] Aggregate the full dependency information."
Dec 11 2019, 4:37 PM
Bigcheese added a reverting change for rGf978ea498309: [clang][clang-scan-deps] Aggregate the full dependency information.: rG5bcd34a03ff3: Revert "[clang][clang-scan-deps] Aggregate the full dependency information.".
Dec 11 2019, 4:37 PM
Bigcheese committed rGf978ea498309: [clang][clang-scan-deps] Aggregate the full dependency information. (authored by Bigcheese).
[clang][clang-scan-deps] Aggregate the full dependency information.
Dec 11 2019, 2:48 PM
Bigcheese closed D70268: [clang][clang-scan-deps] Aggregate the full dependency information..
Dec 11 2019, 2:48 PM · Restricted Project
Bigcheese added a comment to D70268: [clang][clang-scan-deps] Aggregate the full dependency information..

Looks like the test for -full-command-line got dropped. I'll add that when I commit.

Dec 11 2019, 2:19 PM · Restricted Project

Dec 10 2019

Bigcheese updated the diff for D70268: [clang][clang-scan-deps] Aggregate the full dependency information..

Refactored FullDependencies::getAdditionalCommandLine and ModuleDeps::getFullCommandLine to share code.

Dec 10 2019, 5:05 PM · Restricted Project
Bigcheese added inline comments to D71239: [clang-format] Fix ObjC keywords following try/catch getting split..
Dec 10 2019, 2:47 PM · Restricted Project, Restricted Project

Dec 9 2019

Bigcheese created D71239: [clang-format] Fix ObjC keywords following try/catch getting split..
Dec 9 2019, 5:54 PM · Restricted Project, Restricted Project

Dec 5 2019

Bigcheese added inline comments to D70268: [clang][clang-scan-deps] Aggregate the full dependency information..
Dec 5 2019, 6:06 PM · Restricted Project
Bigcheese updated the diff for D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..
  • Remove duplicate decl
  • Add test
Dec 5 2019, 6:06 PM · Restricted Project, Restricted Project
Bigcheese updated the diff for D70268: [clang][clang-scan-deps] Aggregate the full dependency information..
  • Removed OutputPaths.
  • Add documentation for AlreadySeen.
Dec 5 2019, 6:06 PM · Restricted Project

Nov 22 2019

Bigcheese added a comment to D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..

It was already there from a previous commit. I see it in tree currently.

Nov 22 2019, 10:43 PM · Restricted Project
Bigcheese accepted D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC.

lgtm. Nice cleanup.

Nov 22 2019, 5:36 PM
Bigcheese added inline comments to D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..
Nov 22 2019, 1:12 PM · Restricted Project, Restricted Project
Bigcheese accepted D70610: [TableGen] Add backend to generate command guide for tools using libOption..

lgtm

Nov 22 2019, 1:11 PM · Restricted Project
Bigcheese accepted D70071: [ConstExprPreter] Removed the flag forcing the use of the interpreter.

lgtm

Nov 22 2019, 12:34 PM · Restricted Project
Bigcheese added inline comments to D70610: [TableGen] Add backend to generate command guide for tools using libOption..
Nov 22 2019, 12:26 PM · Restricted Project

Nov 21 2019

Bigcheese added inline comments to D70268: [clang][clang-scan-deps] Aggregate the full dependency information..
Nov 21 2019, 3:06 PM · Restricted Project
Bigcheese added a comment to D69122: Add support to find out resource dir and add it as compilation args.

Thanks, you're good to commit.

Nov 21 2019, 12:58 PM · Restricted Project

Nov 20 2019

Bigcheese added a comment to D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..

Adding experimental APIs is something that we haven't done before, but it be useful for this case.

Nov 20 2019, 4:34 PM · Restricted Project, Restricted Project
Bigcheese added inline comments to D70268: [clang][clang-scan-deps] Aggregate the full dependency information..
Nov 20 2019, 4:25 PM · Restricted Project

Nov 19 2019

Bigcheese accepted D70285: Wrap C APIs with pragmas enforcing -Werror=strict-prototypes.

lgtm as long as other compilers don't warn on unknown pragmas by default.

Nov 19 2019, 11:29 AM · Restricted Project
Bigcheese accepted D69575: Improve module.pcm lock file performance on machines with high core counts.

A few minor points, but with those fixed this looks good to me. Thanks for the patch!

Nov 19 2019, 10:43 AM · Restricted Project

Nov 15 2019

Bigcheese updated the summary of D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..
Nov 15 2019, 5:53 PM · Restricted Project, Restricted Project
Bigcheese added a parent revision for D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.: D70268: [clang][clang-scan-deps] Aggregate the full dependency information..
Nov 15 2019, 5:44 PM · Restricted Project, Restricted Project
Bigcheese created D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..
Nov 15 2019, 5:44 PM · Restricted Project, Restricted Project
Bigcheese added a child revision for D70268: [clang][clang-scan-deps] Aggregate the full dependency information.: D70351: [clang][WIP][clang-scan-deps] Add an experimental C API..
Nov 15 2019, 5:44 PM · Restricted Project

Nov 14 2019

Bigcheese resigned from D2431: [lld] Registry model for Readers and Reference Kind strings.
Nov 14 2019, 1:11 PM
Bigcheese resigned from D2225: [InputGraph][Gnu] Add Linkerscript support. .
Nov 14 2019, 1:11 PM
Bigcheese abandoned D12545: [elf2] Add basic archive file support..
Nov 14 2019, 1:11 PM
Bigcheese abandoned D664: [lld][Driver] Parallelize reading initial object files..
Nov 14 2019, 1:11 PM
Bigcheese abandoned D13275: [lld][elf2] Sort output sections..
Nov 14 2019, 1:11 PM
Bigcheese abandoned D3353: [Headers] Improve codegen for _mm_slli_epi32..
Nov 14 2019, 1:11 PM
Bigcheese abandoned D13615: [lld][elf2] Local Dynamic TLS.
Nov 14 2019, 1:11 PM
Bigcheese abandoned D697: [lld][ELF] Initialize readers and writers on creation..
Nov 14 2019, 1:11 PM
Bigcheese abandoned D1332: [lld] Update to LLVM ELFFile changes..
Nov 14 2019, 1:11 PM
Bigcheese abandoned D540: [clang][Driver] Nativize paths when emitting crash diagnostics..
Nov 14 2019, 1:11 PM
Bigcheese added reviewers for D70268: [clang][clang-scan-deps] Aggregate the full dependency information.: arphaman, kousikk.
Nov 14 2019, 1:02 PM · Restricted Project
Bigcheese created D70268: [clang][clang-scan-deps] Aggregate the full dependency information..
Nov 14 2019, 1:02 PM · Restricted Project

Nov 13 2019

Bigcheese accepted D69122: Add support to find out resource dir and add it as compilation args.

lgtm with the changes to FindResourceDir.

Nov 13 2019, 4:04 PM · Restricted Project
Bigcheese accepted D69958: Improve VFS compatibility on Windows.

lgtm. Looking at the blame it would be best if @JDevlieghere @vsapsai or @benlangmuir could take a look also.

Nov 13 2019, 1:52 PM · Restricted Project, Restricted Project

Oct 31 2019

Bigcheese committed rGd816d9bdc585: [clang][ScanDeps] Fix issue with multiple commands with the same input. (authored by Bigcheese).
[clang][ScanDeps] Fix issue with multiple commands with the same input.
Oct 31 2019, 2:25 PM
Bigcheese closed D69643: [clang][ScanDeps] Fix issue with multiple commands with the same input..
Oct 31 2019, 2:24 PM · Restricted Project

Oct 30 2019

Bigcheese committed rG17b64e36e90a: [clang][ScanDeps] Fix shadowing warning. (authored by Bigcheese).
[clang][ScanDeps] Fix shadowing warning.
Oct 30 2019, 3:55 PM
Bigcheese committed rG33a745e6fe7e: [clang][clang-scan-deps] Add support for extracting full module dependencies. (authored by Bigcheese).
[clang][clang-scan-deps] Add support for extracting full module dependencies.
Oct 30 2019, 3:29 PM
Bigcheese committed rG1c88d662230e: Revert "[clang][clang-scan-deps] Add support for extracting full module… (authored by Bigcheese).
Revert "[clang][clang-scan-deps] Add support for extracting full module…
Oct 30 2019, 3:18 PM
Bigcheese added a reverting change for rGd8a4ef0e685c: [clang][clang-scan-deps] Add support for extracting full module dependencies.: rG1c88d662230e: Revert "[clang][clang-scan-deps] Add support for extracting full module….
Oct 30 2019, 3:18 PM
Bigcheese committed rGd8a4ef0e685c: [clang][clang-scan-deps] Add support for extracting full module dependencies. (authored by Bigcheese).
[clang][clang-scan-deps] Add support for extracting full module dependencies.
Oct 30 2019, 2:49 PM
Bigcheese closed D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..
Oct 30 2019, 2:49 PM · Restricted Project
Bigcheese created D69643: [clang][ScanDeps] Fix issue with multiple commands with the same input..
Oct 30 2019, 2:21 PM · Restricted Project
Bigcheese accepted D61608: YAML parser robustness improvements.

lgtm, sorry for the delay, I didn't see the updates for some reason.

Oct 30 2019, 2:21 PM · Restricted Project

Oct 29 2019

Bigcheese requested changes to D69122: Add support to find out resource dir and add it as compilation args.

So I agree solving this problem makes sense, but I have some issues with the current patch.

Oct 29 2019, 3:25 PM · Restricted Project
Bigcheese updated the diff for D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..

I forgot to clang-format.

Oct 29 2019, 2:43 PM · Restricted Project
Bigcheese updated the diff for D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..

This fixes some issues I received externally.

Oct 29 2019, 2:34 PM · Restricted Project

Oct 28 2019

Bigcheese committed rGdddec1f1840b: [clang][clang-scan-deps] Add -fcxx-modules to test for Darwin. (authored by Bigcheese).
[clang][clang-scan-deps] Add -fcxx-modules to test for Darwin.
Oct 28 2019, 5:55 PM

Oct 25 2019

Bigcheese committed rG8da20560ab0d: [clang][DependencyScanning] 80-col. (authored by Bigcheese).
[clang][DependencyScanning] 80-col.
Oct 25 2019, 3:44 PM
Bigcheese added inline comments to D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..
Oct 25 2019, 3:43 PM · Restricted Project
Bigcheese updated the diff for D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..

Address review comments.

Oct 25 2019, 3:43 PM · Restricted Project

Oct 24 2019

Bigcheese committed rG7af309a4ed1a: [clang][DependencyScanning] clang-format. (authored by Bigcheese).
[clang][DependencyScanning] clang-format.
Oct 24 2019, 6:31 PM
Bigcheese created D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies..
Oct 24 2019, 5:57 PM · Restricted Project
Bigcheese committed rG9ab6d8236b17: [clang-scan-deps] Add basic support for modules. (authored by Bigcheese).
[clang-scan-deps] Add basic support for modules.
Oct 24 2019, 4:24 PM
Bigcheese closed D68835: [clang-scan-deps] Add basic support for Clang modules..
Oct 24 2019, 4:24 PM · Restricted Project
Bigcheese added a reviewer for D69122: Add support to find out resource dir and add it as compilation args: klimek.

I've added Manuel as a reviewer as this patch is also changing the tooling APIs.

Oct 24 2019, 11:20 AM · Restricted Project

Oct 23 2019

Bigcheese added a reviewer for D69331: [LegacyPM] Port CGProfile pass: chandlerc.

This was originally not added to the legacy pass manager because it leaks memory under it due to fundamental issues with the old pass manager. See https://reviews.llvm.org/D48105#1140299 .

Oct 23 2019, 2:02 PM · Restricted Project

Oct 21 2019

Bigcheese accepted D69186: Refactor DependencyScanningTool to its own file.

LGTM with style nit. I like that this decouples DependencyScanningTool from printing the results.

Oct 21 2019, 5:38 PM · Restricted Project
Bigcheese added a comment to D69122: Add support to find out resource dir and add it as compilation args.

The current assumption is that the clang-scan-deps binary is the one that comes next to the clang binary you are using. There are lots of other differences between clang versions than just the resource-dir.

Oct 21 2019, 5:38 PM · Restricted Project
Bigcheese committed rG8896d073b190: [Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes… (authored by Bigcheese).
[Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes…
Oct 21 2019, 3:56 PM

Oct 19 2019

Bigcheese committed rG81a01e73faab: Revert "[Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which… (authored by Bigcheese).
Revert "[Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which…
Oct 19 2019, 2:46 AM

Oct 18 2019

Bigcheese committed rGd7cf99ae0370: [Docs] Fix header level. (authored by Bigcheese).
[Docs] Fix header level.
Oct 18 2019, 6:52 PM
Bigcheese committed rG14a3f77ba103: [Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes… (authored by Bigcheese).
[Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes…
Oct 18 2019, 6:43 PM
Bigcheese closed D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..
Oct 18 2019, 6:42 PM · Restricted Project

Oct 17 2019

Bigcheese added a comment to D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..

While adding the documentation I realized that a better name for this option would be -fmodules-strict-context-hash to make it clear which hash it's referring to.

Oct 17 2019, 3:52 PM · Restricted Project

Oct 16 2019

Bigcheese updated the diff for D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..

Fixed spelling and updated comment.

Oct 16 2019, 4:13 PM · Restricted Project
Bigcheese updated the diff for D68835: [clang-scan-deps] Add basic support for Clang modules..

Added .i, .ii, .mi, and .mmi as files to minimize.

Oct 16 2019, 2:57 PM · Restricted Project
Bigcheese accepted D69017: Include sanitize blacklist and other extra deps as part of scan-deps output.

lgtm. Jan may want to take a look as I believe he was looking at a related issue.

Oct 16 2019, 10:46 AM · Restricted Project

Oct 14 2019

Bigcheese committed rG9585d8c11a57: [Modules Build] Add missing dependency. (authored by Bigcheese).
[Modules Build] Add missing dependency.
Oct 14 2019, 3:00 PM
Bigcheese added inline comments to D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..
Oct 14 2019, 1:53 PM · Restricted Project

Oct 10 2019

Bigcheese updated the diff for D68835: [clang-scan-deps] Add basic support for Clang modules..

Addressed review comments.

Oct 10 2019, 5:31 PM · Restricted Project
Bigcheese created D68835: [clang-scan-deps] Add basic support for Clang modules..
Oct 10 2019, 2:43 PM · Restricted Project
Bigcheese committed rG2f56266234e5: [ScanDeps] clang-format, 80 cols. (authored by Bigcheese).
[ScanDeps] clang-format, 80 cols.
Oct 10 2019, 1:26 PM

Oct 9 2019

Bigcheese accepted D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests..

lgtm, but wait for Alex or Duncan to also take a look.

Oct 9 2019, 6:41 PM · Restricted Project
Bigcheese added inline comments to D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests..
Oct 9 2019, 6:32 PM · Restricted Project
Bigcheese added a comment to D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests..

@arphaman I don't mind changing this if there are race conditions as you say, but isn't the assumption of the tool that the filesystem remains unchanged for a single run of the tool? If so, should we actually throw error conditions instead of crashing in those cases?

Oct 9 2019, 2:31 PM · Restricted Project

Oct 4 2019

Bigcheese updated the diff for D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..

Add diagnostics.

Oct 4 2019, 5:33 PM · Restricted Project
Bigcheese created D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..
Oct 4 2019, 4:58 PM · Restricted Project
Bigcheese added a comment to D67696: [tools] Mark output of tools as text if it is really text.

Do we really want to output \r\n on Windows? There is all of one program (notepad.exe) that doesn't support \n on Windows.

Oct 4 2019, 12:20 AM · Restricted Project

Sep 27 2019

Bigcheese accepted D46228: [ELF] Use union-find set and doubly linked list in Call-Chain Clustering (C³) heuristic.

lgtm

Sep 27 2019, 10:39 AM · Restricted Project

Sep 26 2019

Bigcheese added inline comments to D68073: Propeller code layout optimizations.
Sep 26 2019, 5:41 PM · Restricted Project

Sep 11 2019

Bigcheese accepted D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization .
Sep 11 2019, 1:05 PM · Restricted Project, Restricted Project

Sep 5 2019

Bigcheese added a comment to D61608: YAML parser robustness improvements.

Also, please use -U999999 for patches so there's full context.

Sep 5 2019, 2:31 PM · Restricted Project
Bigcheese added inline comments to D61608: YAML parser robustness improvements.
Sep 5 2019, 2:29 PM · Restricted Project

Sep 4 2019

Bigcheese added a comment to D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization .

Looking more into this I'm not sure you need the PPCallbacks. The Preprocessor should just own the PreprocessorSkippedMappings data structure and the dependency scanner can update it live.

Sep 4 2019, 1:56 PM · Restricted Project, Restricted Project

Sep 3 2019

Bigcheese added inline comments to D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization .
Sep 3 2019, 5:20 PM · Restricted Project, Restricted Project

Aug 30 2019

Bigcheese accepted D66989: FileManager: Remove ShouldCloseOpenFile argument from getBufferForFile, NFC.

lgtm

Aug 30 2019, 9:34 AM

Aug 21 2019

Bigcheese accepted D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations.
Aug 21 2019, 2:02 PM · Restricted Project, Restricted Project

Aug 15 2019

Bigcheese requested changes to D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations.
Aug 15 2019, 3:56 PM · Restricted Project, Restricted Project

Aug 14 2019

Bigcheese added inline comments to D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations.
Aug 14 2019, 4:29 PM · Restricted Project, Restricted Project