- User Since
- Jul 7 2012, 3:08 PM (392 w, 6 d)
Dec 12 2019
Dec 11 2019
Looks like the test for -full-command-line got dropped. I'll add that when I commit.
Dec 10 2019
Refactored FullDependencies::getAdditionalCommandLine and ModuleDeps::getFullCommandLine to share code.
Dec 9 2019
Dec 5 2019
- Remove duplicate decl
- Add test
- Removed OutputPaths.
- Add documentation for AlreadySeen.
Nov 22 2019
It was already there from a previous commit. I see it in tree currently.
lgtm. Nice cleanup.
Nov 21 2019
Thanks, you're good to commit.
Nov 20 2019
Nov 19 2019
lgtm as long as other compilers don't warn on unknown pragmas by default.
A few minor points, but with those fixed this looks good to me. Thanks for the patch!
Nov 15 2019
Nov 14 2019
Nov 13 2019
lgtm with the changes to FindResourceDir.
Oct 31 2019
Oct 30 2019
lgtm, sorry for the delay, I didn't see the updates for some reason.
Oct 29 2019
So I agree solving this problem makes sense, but I have some issues with the current patch.
I forgot to clang-format.
This fixes some issues I received externally.
Oct 28 2019
Oct 25 2019
Address review comments.
Oct 24 2019
I've added Manuel as a reviewer as this patch is also changing the tooling APIs.
Oct 23 2019
This was originally not added to the legacy pass manager because it leaks memory under it due to fundamental issues with the old pass manager. See https://reviews.llvm.org/D48105#1140299 .
Oct 21 2019
LGTM with style nit. I like that this decouples DependencyScanningTool from printing the results.
The current assumption is that the clang-scan-deps binary is the one that comes next to the clang binary you are using. There are lots of other differences between clang versions than just the resource-dir.
Oct 19 2019
Oct 18 2019
Oct 17 2019
While adding the documentation I realized that a better name for this option would be -fmodules-strict-context-hash to make it clear which hash it's referring to.
Oct 16 2019
Fixed spelling and updated comment.
Added .i, .ii, .mi, and .mmi as files to minimize.
lgtm. Jan may want to take a look as I believe he was looking at a related issue.
Oct 14 2019
Oct 10 2019
Addressed review comments.
Oct 9 2019
lgtm, but wait for Alex or Duncan to also take a look.
Oct 4 2019
Do we really want to output \r\n on Windows? There is all of one program (notepad.exe) that doesn't support \n on Windows.
Sep 27 2019
Sep 26 2019
Sep 11 2019
Sep 5 2019
Also, please use -U999999 for patches so there's full context.
Sep 4 2019
Looking more into this I'm not sure you need the PPCallbacks. The Preprocessor should just own the PreprocessorSkippedMappings data structure and the dependency scanner can update it live.
Sep 3 2019
Aug 30 2019