Page MenuHomePhabricator

Bigcheese (Michael Spencer)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 7 2012, 3:08 PM (559 w, 6 d)

Recent Activity

Fri, Mar 17

Bigcheese accepted D146328: [clang][deps] Only cache files with specific extension.

lgtm, thanks!

Fri, Mar 17, 5:33 PM · Restricted Project, Restricted Project
Bigcheese added inline comments to D146328: [clang][deps] Only cache files with specific extension.
Fri, Mar 17, 3:45 PM · Restricted Project, Restricted Project
Bigcheese accepted D146328: [clang][deps] Only cache files with specific extension.

This doesn't appear to behave as expected for PP_CacheFailure or PP_ScanFile without PP_CacheSuccess. Looks like that will still cache. Should probably just assert that's not the computed policy.

Fri, Mar 17, 1:47 PM · Restricted Project, Restricted Project

Thu, Mar 16

Bigcheese accepted D146255: [clang] Unconditionally add autolink hints for frameworks..

lgtm

Thu, Mar 16, 3:16 PM · Restricted Project, Restricted Project

Mon, Mar 13

Bigcheese accepted D145838: [clang][deps] Handle response files in dep scanner.

LTGM, thanks!

Mon, Mar 13, 3:36 PM · Restricted Project, Restricted Project

Tue, Mar 7

Bigcheese committed rG57c7750f703d: [clang][DependencyScanner] Cache modulemap stat failures (authored by Bigcheese).
[clang][DependencyScanner] Cache modulemap stat failures
Tue, Mar 7, 3:14 PM · Restricted Project, Restricted Project
Bigcheese closed D145526: [clang][DependencyScanner] Cache modulemap stat failures.
Tue, Mar 7, 3:14 PM · Restricted Project, Restricted Project
Bigcheese updated the diff for D145526: [clang][DependencyScanner] Cache modulemap stat failures.

Also handle module.map.

Tue, Mar 7, 3:07 PM · Restricted Project, Restricted Project
Bigcheese updated the diff for D145526: [clang][DependencyScanner] Cache modulemap stat failures.

Forgot that Filename is actually a path, so call llvm::sys::path::filename.

Tue, Mar 7, 2:56 PM · Restricted Project, Restricted Project
Bigcheese requested review of D145526: [clang][DependencyScanner] Cache modulemap stat failures.
Tue, Mar 7, 2:48 PM · Restricted Project, Restricted Project

Feb 1 2023

Bigcheese committed rGffa2a647c6a9: [Clang][DependencyScanner] Remove secondary actions from -cc1 (authored by Bigcheese).
[Clang][DependencyScanner] Remove secondary actions from -cc1
Feb 1 2023, 3:18 PM · Restricted Project, Restricted Project
Bigcheese closed D143040: [Clang][DependencyScanner] Remove secondary actions from -cc1.
Feb 1 2023, 3:17 PM · Restricted Project, Restricted Project

Jan 31 2023

Bigcheese requested review of D143040: [Clang][DependencyScanner] Remove secondary actions from -cc1.
Jan 31 2023, 5:55 PM · Restricted Project, Restricted Project
Bigcheese accepted D143027: [clang][deps] Fix module context hash for constant strings.

Thanks for fixing this. LGTM.

Jan 31 2023, 4:18 PM · Restricted Project, Restricted Project

Jan 17 2023

Bigcheese updated the diff for D141450: [Clang][cc1] Make -fno-modules-local-submodule-visibility the default for ObjC++20.
Jan 17 2023, 4:08 PM · Restricted Project, Restricted Project, Restricted Project

Jan 12 2023

Bigcheese added a comment to D141450: [Clang][cc1] Make -fno-modules-local-submodule-visibility the default for ObjC++20.

This is a problem because some existing ObjectiveC code is not compatible with LSV

Hmm, how is that true? Does this code only build with Clang Header Modules enabled, and can't build without that? (if it could build without it, I don't know why it'd need LSV, if I'm understanding all these things correctly... )

Jan 12 2023, 4:07 PM · Restricted Project, Restricted Project, Restricted Project

Jan 10 2023

Bigcheese requested review of D141450: [Clang][cc1] Make -fno-modules-local-submodule-visibility the default for ObjC++20.
Jan 10 2023, 5:19 PM · Restricted Project, Restricted Project, Restricted Project

Jan 4 2023

Bigcheese committed rG22b65a329ac2: [NFC][Clang][ASTTests] Use ASSERT instead of EXPECT for nullptr checks (authored by Bigcheese).
[NFC][Clang][ASTTests] Use ASSERT instead of EXPECT for nullptr checks
Jan 4 2023, 5:34 PM · Restricted Project, Restricted Project

Nov 8 2022

Bigcheese accepted D137206: [clang][modules][deps] Including module maps are affecting.

lgtm

Nov 8 2022, 12:16 PM · Restricted Project, Restricted Project
Bigcheese accepted D137198: [clang][modules][deps] Parent module maps are affecting.

lgtm.

Nov 8 2022, 11:18 AM · Restricted Project, Restricted Project
Bigcheese accepted D137197: [clang][modules][deps] Transitive module maps are not affecting.

Yeah, I agree with this. lgtm.

Nov 8 2022, 11:12 AM · Restricted Project, Restricted Project
Bigcheese accepted D137192: [clang][serialization] NFCI: Avoid re-reading input file info.

lgtm, thanks for fixing this.

Nov 8 2022, 10:57 AM · Restricted Project, Restricted Project
Bigcheese added a comment to D137609: [C++20] [Modules] Remove unmaintained header modules.

I'm not aware of anyone using this mode, but please wait for responses from Google and Meta people to verify that.

Nov 8 2022, 10:19 AM · Restricted Project, Restricted Project, Restricted Project

Oct 26 2022

Bigcheese accepted D136007: [clang][modules][deps] System module maps might not be affecting.

lgtm once D136624 lands.

Oct 26 2022, 1:45 PM · Restricted Project, Restricted Project

Oct 24 2022

Bigcheese added a comment to D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`.

This looks reasonable. Have you measured the performance impact of this change?

Oct 24 2022, 1:27 PM · Restricted Project, Restricted Project

Oct 19 2022

Bigcheese accepted D136290: [clang] Disable assertion that can "easily happen".

lgtm.

Oct 19 2022, 2:31 PM · Restricted Project, Restricted Project

Oct 18 2022

Bigcheese accepted D135128: [clang][cli] Simplify repetitive macro invocations.

Looks good with the suggestion to split the change.

Oct 18 2022, 5:44 PM · Restricted Project, Restricted Project, Restricted Project

Oct 12 2022

Bigcheese accepted D135414: [clang][deps] Don't share in-memory VFS across scans.

lgtm

Oct 12 2022, 5:38 PM · Restricted Project, Restricted Project

Oct 11 2022

Bigcheese accepted D135720: [clang][deps] Remove more codegen options.

lgtm. Although I wonder if long term we should add something to the option tablegen file for this case?

Oct 11 2022, 3:30 PM · Restricted Project, Restricted Project
Bigcheese accepted D135416: [clang][deps] Respect VFS overlays in canonical preprocessing mode.

Ah, I hit the same thing recently, thanks.

Oct 11 2022, 2:24 PM · Restricted Project, Restricted Project
Bigcheese accepted D135637: [clang][deps] Prevent emitting diagnostics outside of source file.

lgtm

Oct 11 2022, 2:21 PM · Restricted Project, Restricted Project
Bigcheese accepted D135636: [clang][modules][deps] Serialize inputs into PCMs using the "as requested" name.

lgtm

Oct 11 2022, 1:58 PM · Restricted Project, Restricted Project

Oct 6 2022

Bigcheese accepted D135381: [clang][modules] Fix handling of `ModuleHeaderRole::ExcludedHeader`.

lgtm

Oct 6 2022, 3:28 PM · Restricted Project, Restricted Project

Sep 22 2022

Bigcheese accepted D134248: [clang][modules][deps] Preserve module map load order.

lgtm

Sep 22 2022, 11:21 AM · Restricted Project, Restricted Project
Bigcheese accepted D134224: [clang][modules][deps] Report modulemaps describing excluded headers.

lgtm with formatting fixed.

Sep 22 2022, 11:00 AM · Restricted Project, Restricted Project

Sep 21 2022

Bigcheese added a comment to D134224: [clang][modules][deps] Report modulemaps describing excluded headers.

I think this is fine, but I need to think more about the ModuleDepCollector.cpp change.

Sep 21 2022, 3:06 PM · Restricted Project, Restricted Project
Bigcheese accepted D134222: [clang][deps] Report module map describing compiled module.

lgtm.

Sep 21 2022, 1:18 PM · Restricted Project, Restricted Project, Restricted Project

Aug 30 2022

Bigcheese accepted D132971: [clang][modules] Don't hard code [no_undeclared_includes] for the Darwin module.

I'm fine with this change, but do we actually have a backwards compatibility policy anywhere in Clang? Would be good to know what range of SDKs a compiler release is expected to support.

Aug 30 2022, 1:14 PM · Restricted Project, Restricted Project

Jun 15 2022

Bigcheese committed rG169417531578: [Clang][Modules] Merge availability attributes on imported decls (authored by Bigcheese).
[Clang][Modules] Merge availability attributes on imported decls
Jun 15 2022, 5:47 PM · Restricted Project, Restricted Project
Bigcheese closed D127182: [Clang][Modules] Merge availability attributes on imported decls.
Jun 15 2022, 5:47 PM · Restricted Project, Restricted Project, Restricted Project

Jun 14 2022

Bigcheese added a comment to D127182: [Clang][Modules] Merge availability attributes on imported decls.

Should we add a FIXME saying we need to handle other kinds of attributes?

Jun 14 2022, 5:55 PM · Restricted Project, Restricted Project, Restricted Project
Bigcheese added a reviewer for D127182: [Clang][Modules] Merge availability attributes on imported decls: jansvoboda11.
Jun 14 2022, 10:52 AM · Restricted Project, Restricted Project, Restricted Project

Jun 6 2022

Bigcheese requested review of D127182: [Clang][Modules] Merge availability attributes on imported decls.
Jun 6 2022, 11:05 PM · Restricted Project, Restricted Project, Restricted Project

Mar 8 2022

Bigcheese added inline comments to D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration.
Mar 8 2022, 5:13 PM · Restricted Project, Restricted Project, Restricted Project

Feb 14 2022

Bigcheese accepted D118855: [modules] Add a flag for TagDecl if it was a definition demoted to a declaration..

lgtm.

Feb 14 2022, 11:04 AM · Restricted Project

Feb 11 2022

Bigcheese accepted D118986: [clang][deps] Return the whole TU command line.

This does require build systems to be able to totally replace a command line rather than just add to it, but it seems like that's a requirement unless we add a way to modify the command line to Clang. lgtm.

Feb 11 2022, 3:33 PM · Restricted Project

Feb 3 2022

Bigcheese accepted D118890: [clang][deps] Disable global module index.

lgtm. I agree that testing this isn't really necessary given the difficulty of even constructing one.

Feb 3 2022, 4:19 PM · Restricted Project
Bigcheese accepted D118915: [clang][deps] Generate '-fmodule-file=' only for direct dependencies.

lgtm

Feb 3 2022, 4:17 PM · Restricted Project, Restricted Project

Feb 2 2022

Bigcheese updated the diff for D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration.
  • Fixed documentation typo.
  • Made missing '{' diagnostic more clear.
  • Use ModuleMapParser::skipUntil.
Feb 2 2022, 4:02 PM · Restricted Project, Restricted Project, Restricted Project

Feb 1 2022

Bigcheese added a comment to D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration.

Drive-by comment on the docs; otherwise this sounds awesome; as long as else is easy to add later this SGTM (I'll let others do the code review).
(Although, if else {} and else requires {} would be easy to add now/soon, I feel like it'd be worth it. Modelling an else-requires chain by hand would be quite error-prone, and it might be annoying to stage the adoption separately...)

Feb 1 2022, 7:41 PM · Restricted Project, Restricted Project, Restricted Project
Bigcheese updated the diff for D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration.

Add testing of empty blocks and nested blocks and make the missing { error clearer.

Feb 1 2022, 5:25 PM · Restricted Project, Restricted Project, Restricted Project
Bigcheese added a comment to D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration.

Is it possible to reference external module map from requires block? I mean that in one context the module has some extra requirements but in a different context doesn't have them.

Feb 1 2022, 5:14 PM · Restricted Project, Restricted Project, Restricted Project

Jan 27 2022

Bigcheese added inline comments to D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration.
Jan 27 2022, 3:24 PM · Restricted Project, Restricted Project, Restricted Project

Jan 26 2022

Bigcheese requested review of D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration.
Jan 26 2022, 8:32 PM · Restricted Project, Restricted Project, Restricted Project

Jan 25 2022

Bigcheese accepted D118150: [clang] Fix serialized diagnostics edge-cases.

lgtm

Jan 25 2022, 1:32 PM · Restricted Project

Jan 24 2022

Bigcheese added a comment to D114342: ConvertUTF, new wrapper API.

I though modern LLVM is to return llvm::Expected<std::string>?!?

Jan 24 2022, 5:39 PM · Restricted Project, Restricted Project, Restricted Project

Jan 21 2022

Bigcheese requested changes to D114342: ConvertUTF, new wrapper API.

Once these issues are fixed this should be fine.

Jan 21 2022, 6:29 PM · Restricted Project, Restricted Project, Restricted Project

Jan 5 2022

Bigcheese added a comment to D114206: [Clang][ScanDeps] Use the virtual path for module maps.

Update: I'm going to revert this on main. This patch was accepted conditionally on you fixing the windows crash, which you have not done, so this was landed without being accepted.

Revert is here: https://reviews.llvm.org/rGea835171389a

When you re-land this, don't forget to include the changes from D116611, please.

Jan 5 2022, 4:35 AM · Restricted Project

Dec 14 2021

Bigcheese committed rG04192422c4e3: [Clang][ScanDeps] Use the virtual path for module maps (authored by Bigcheese).
[Clang][ScanDeps] Use the virtual path for module maps
Dec 14 2021, 10:22 AM
Bigcheese closed D114206: [Clang][ScanDeps] Use the virtual path for module maps.
Dec 14 2021, 10:21 AM · Restricted Project

Dec 2 2021

Bigcheese added a comment to D113676: [clang][lex] Fix search path usage remark with modules.

Can we not consider a modulemap used when we load an AST that depends on that modulemap? It's possible this breaks if the module only includes textual headers though. It really feels like we should have a single place where we actually know if a module is used or not. Long term I would really like to separate modulemap parsing from Module creation, which would be a great place to actually do this.

Dec 2 2021, 2:27 PM · Restricted Project, Restricted Project

Dec 1 2021

Bigcheese updated the diff for D114206: [Clang][ScanDeps] Use the virtual path for module maps.
Dec 1 2021, 4:53 PM · Restricted Project
Bigcheese added a comment to D114206: [Clang][ScanDeps] Use the virtual path for module maps.

There were two issues for Windows.

Dec 1 2021, 4:35 PM · Restricted Project

Nov 18 2021

Bigcheese requested review of D114206: [Clang][ScanDeps] Use the virtual path for module maps.
Nov 18 2021, 4:17 PM · Restricted Project
Bigcheese accepted D113880: [clang][modules] Infer framework modules in explicit builds.

I think this makes sense to do given that you need to explicitly opt into inferred modules anyway. This isn't implicitly finding module maps, as we already have a module map with framework module *.

Nov 18 2021, 8:32 AM · Restricted Project
Bigcheese accepted D112923: [clang][deps] Reset some benign codegen options.

lgtm

Nov 18 2021, 8:17 AM · Restricted Project

Nov 9 2021

Bigcheese added inline comments to D113391: [Modules] Don't support clang module and c++20 module at the same time.
Nov 9 2021, 9:42 AM · Restricted Project, Restricted Project

Nov 5 2021

Bigcheese accepted D111860: [modules] Update visibility for merged ObjCProtocolDecl definitions..

lgtm

Nov 5 2021, 11:34 AM · Restricted Project

Oct 28 2021

Bigcheese accepted D112289: Support: Use sys::path::is_style_{posix,windows}() in a few places.

lgtm

Oct 28 2021, 10:02 AM · Restricted Project, Restricted Project
Bigcheese accepted D112288: Support: Expose sys::path::is_style_{posix,windows,native}().

Looks good. We shouldn't be checking _WIN32 just for path style questions.

Oct 28 2021, 9:52 AM · Restricted Project

Oct 27 2021

Bigcheese accepted D112655: [CGProfile] Don't emit call graph profile edges with zero weight.

Looks reasonable. Edges with weight 0 shouldn't matter anyway.

Oct 27 2021, 2:56 PM · Restricted Project

Jul 27 2021

Bigcheese added a comment to D105527: libclang.so: Make SONAME independent from LLVM version.

Here's a version that actually works (python 3, not sure if it's valid in 2), although I would much prefer we not write to the source directory during a build.

Jul 27 2021, 4:55 PM · Restricted Project
Bigcheese added a comment to D105527: libclang.so: Make SONAME independent from LLVM version.

Also, this python script just doesn't work. It's missing a sys import, a "w" flag, and a new line after each write. It also dumps the output into the source directory. Was this actually tested?

Jul 27 2021, 4:48 PM · Restricted Project

Jul 26 2021

Bigcheese added a comment to D105527: libclang.so: Make SONAME independent from LLVM version.

For future reference this was very difficult to merge into external changes. It looks like you resorted this at the same time as renaming it, and that messes up git's rename logic.

Jul 26 2021, 7:06 PM · Restricted Project

Jun 3 2021

Bigcheese accepted D103524: [clang][deps] Handle precompiled headers' AST files.

lgtm.

Jun 3 2021, 9:32 AM · Restricted Project
Bigcheese accepted D103519: [clang][deps] Support object files.

lgtm

Jun 3 2021, 9:14 AM · Restricted Project
Bigcheese accepted D103516: [clang][deps] Add argument for customizing PCM paths.

lgtm with a few minor changes.

Jun 3 2021, 8:50 AM · Restricted Project

May 26 2021

Bigcheese updated subscribers of D102923: [clang][lex] Remark on search path usage.

I think this is looking good, but would like either @dexonsmith, @akyrtzi, or someone else familiar with this area to take a look. Only other comment I have is that the new functions you add should use the current LLVM naming convention.

May 26 2021, 2:40 AM · Restricted Project

Apr 21 2021

Bigcheese accepted D100942: [clang][deps] Include "-cc1" in the arguments.

lgtm.

Apr 21 2021, 9:01 AM · Restricted Project

Apr 16 2021

Bigcheese accepted D100473: [clang] Implement CompilerInvocation copy assignment.

I think this is fine given that we already have a copy constructor with deep copy semantics.

Apr 16 2021, 8:56 AM · Restricted Project
Bigcheese accepted D100455: [clang] Rename CompilerInvocationBase to RefBase, split out ValueBase.

lgtm

Apr 16 2021, 8:46 AM · Restricted Project
Bigcheese accepted D100653: [clang][cli] NFC: Move conditional LangOptions parsing/generation.

lgtm

Apr 16 2021, 8:37 AM · Restricted Project
Bigcheese accepted D100533: [clang][deps] Remove the -full-command-line flag.

lgtm

Apr 16 2021, 8:35 AM · Restricted Project

Mar 23 2021

Bigcheese accepted D98950: [clang][deps] NFC: Document collector, rename members.

Thanks for the cleanup. Code makes more sense now.

Mar 23 2021, 8:50 AM · Restricted Project
Bigcheese accepted D98943: [clang][deps] NFC: Extract ModuleID struct.
Mar 23 2021, 8:46 AM · Restricted Project

Mar 4 2021

Bigcheese accepted D97552: [clang][cli] Fix generation of '-fvisibility' with regards to '-mignore-xcoff-visibility'.

LGTM

Mar 4 2021, 9:11 AM · Restricted Project
Bigcheese added a comment to D97702: [clang][modules] Use extensible RTTI for ModuleFileExtension.

Looks fine to me, but it would be good for a Swift person to look at this patch.

Mar 4 2021, 9:06 AM · Restricted Project

Feb 25 2021

Bigcheese accepted D97461: [clang][cli] Implement '-cuid=' marshalling.

LGTM

Feb 25 2021, 9:16 AM · Restricted Project

Feb 16 2021

Bigcheese accepted D95790: [clang][cli] Documentation of CompilerInvocation parsing/generation.

Needs an example in the "Creating new Command Line Option" section, but with that it looks good.

Feb 16 2021, 8:45 AM · Restricted Project

Feb 4 2021

Bigcheese added inline comments to D95790: [clang][cli] Documentation of CompilerInvocation parsing/generation.
Feb 4 2021, 8:55 AM · Restricted Project

Jan 28 2021

Bigcheese added a comment to D95514: [clang][cli] Teach CompilerInvocation to allocate strings on its own.

Well, the compiler developers are the users, since -cc1 isn't for end-users. I acknowledge it's a tradeoff. IMO, without actually seeing it in practice, it seems a bit nicer to design this away entirely. But maybe having a = is more valuable than I think.

For string options:

  • If -cc1 accepts only -opt string, no need for allocation.
  • If -cc1 accepts only -opt=string, the fully-spelled option is on the original command-line. ExistingStrings.find() should turn it up when calling Strings.save().
  • If -cc1 accepts both -opt=string and -opt string canonicalize to -opt string when generating. No need for allocation.

For numeric / enum options we'll need to allocate, but the allocation doesn't have to live past running the parser.

The only problem would be if string gets canonicalized / rewritten somehow during parse + generate, or if an enum value is additionally saved as a string value.

We can definitely ask around how would people feel about that.

Consider that some callers may parse the full command-line and then drop everything but one options class. That pattern wouldn’t work anymore since the StringRefs won’t be valid.

Ah, that's right. So if we don't go with the allocation-less approach, we'd need to take StringAllocator from the client that also ensures proper lifetimes.

Maybe it wouldn't be terrible to have a RoundTrip arg on each options class. When you assign to the CompilerInvocation, it copies the shared ptr into each of the options classes, so that the pool stays alive as long as one of them has it.

I think this is the most robust solution.

Moving BumpPtrAllocator/StringSaver into CompilerInvocation will become problematic once we start round-tripping more option classes.

I've looked through all option classes in CompilerInvocation, and AnalyzerOptions::Config seems to be the only member that stores non-owning references to command line arguments.
I think the best path forward is to change AnalyzerOptions to take ownership and avoid dealing with complicated lifetimes. We can look into removing allocations later, as an optional optimization.
What do you think?

Jan 28 2021, 8:42 AM · Restricted Project

Jan 26 2021

Bigcheese added a comment to D94472: [clang][cli] Command line round-trip for HeaderSearch options.

strict mode additionally uses the GeneratedArgs1 to fill CompilerInvocation, indirectly checking both directions by requiring tests to pass both with and without this round-trip. However, during development people generally only run the tests one way and the failure mode won't be ideal.

So people build without assertions during development? In that case, I agree that erroring out on GeneratedArgs1 != GeneratedArgs2 (in all kinds of builds) would improve the experience. I don't think there's anything preventing us to incorporate this into the current patch.

Jan 26 2021, 9:38 AM · Restricted Project, Restricted Project

Jan 14 2021

Bigcheese accepted D94682: [clang][cli] Parse Lang and CodeGen options separately.

LGTM.

Jan 14 2021, 9:16 AM · Restricted Project
Bigcheese accepted D94681: [clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members.

LGTM.

Jan 14 2021, 9:09 AM · Restricted Project
Bigcheese accepted D94680: [clang][cli] NFC: Parse some LangOpts after the defaults are set.

LGTM.

Jan 14 2021, 9:03 AM · Restricted Project
Bigcheese accepted D94679: [clang][cli] NFC: Add PIE parsing for precompiled input and IR.

LGTM.

Jan 14 2021, 9:01 AM · Restricted Project
Bigcheese accepted D94678: [clang][cli] Parse & generate options necessary for LangOptions defaults manually.

LGTM with the comment.

Jan 14 2021, 8:58 AM · Restricted Project
Bigcheese accepted D94676: [clang][cli] Specify KeyPath prefixes via TableGen classes.

LGTM.

Jan 14 2021, 8:53 AM · Restricted Project, Restricted Project
Bigcheese accepted D94675: [clang][cli] NFC: Decrease the scope of ParseCodeGenArgs parameters.

LGTM.

Jan 14 2021, 8:41 AM · Restricted Project
Bigcheese accepted D94674: [clang][cli] NFC: Decrease the scope of ParseLangArgs parameters.

LGTM.

Jan 14 2021, 8:39 AM · Restricted Project