User Details
- User Since
- Jul 7 2012, 3:08 PM (445 w, 9 h)
Thu, Jan 14
LGTM.
LGTM.
LGTM.
LGTM.
LGTM with the comment.
LGTM.
LGTM.
LGTM.
Tue, Jan 5
lgtm
We don't really have anywhere specific to put extra matchers, and we don't want to add stuff to the actual gtest folder so it's easy to merge updates. So this is fine.
LGTM
Dec 17 2020
This looks fine to be as that code is definitely dead. I would wait for @SjoerdMeijer in case there's a bug in the existing code.
lgtm
lgtm.
lgtm with nit.
lgtm with the fix above.
lgtm with the comment.
Dec 15 2020
lgtm with the test fix.
lgtm.
Dec 11 2020
lgtm. Thanks for the patch.
Dec 9 2020
LGTM. I don't see any reason to always emit this option.
Dec 8 2020
Nov 30 2020
lgtm.
Nov 24 2020
LGTM
Nov 11 2020
Nov 10 2020
LGTM.
Nov 5 2020
LGTM
Sep 23 2020
LGTM
Aug 27 2020
lgtm.
Aug 19 2020
lgtm.
lgtm
Aug 14 2020
lgtm
Jul 30 2020
Jul 20 2020
lgtm
Jul 17 2020
Jul 14 2020
Jul 13 2020
lgtm
lgtm
Jul 7 2020
LGTM. We can look at splitting it up again once we know what the dependencies are.
I have a slight preference for -arcmt-action=, but up to you if you want to change it. Otherwise LGTM.
Jun 30 2020
lgtm with the fix I mentioned.
Jun 23 2020
LGTM with KeyPathPrefix moved to the patch that actually uses it.
Jun 19 2020
Jun 13 2020
The reason KillTheDoctor exists is because of test-suite. It compiles and runs programs that do not contain calls to that API, and can do so with non-llvm compilers. I personally don't use it anymore as I don't run test-suite on Windows anymore, but I'm still not aware of any way short of changing registry settings to run test-suite on Windows without hanging other than this.
Jun 11 2020
lgtm.
Jun 10 2020
Jun 3 2020
May 19 2020
May 18 2020
May 13 2020
I mostly just need to rebase this patch now. I'll try to get to that soon.
Apr 21 2020
LGTM