Page MenuHomePhabricator

vsapsai (Volodymyr Sapsai)
User

Projects

User does not belong to any projects.

User Details

User Since
May 27 2014, 6:39 AM (280 w, 6 d)

Recent Activity

Fri, Oct 11

vsapsai committed rGb95d4c3a9979: [ObjC] Remove default parameter no caller was providing. NFC intended. (authored by vsapsai).
[ObjC] Remove default parameter no caller was providing. NFC intended.
Fri, Oct 11, 2:23 PM
vsapsai committed rL374596: [ObjC] Remove default parameter no caller was providing. NFC intended..
[ObjC] Remove default parameter no caller was providing. NFC intended.
Fri, Oct 11, 2:22 PM
vsapsai committed rGe8752a9d1bcf: [Stats] Convert some ad-hoc header search stats to ALWAYS_ENABLED_STATISTIC. (authored by vsapsai).
[Stats] Convert some ad-hoc header search stats to ALWAYS_ENABLED_STATISTIC.
Fri, Oct 11, 11:21 AM
vsapsai committed rL374581: [Stats] Convert some ad-hoc header search stats to ALWAYS_ENABLED_STATISTIC..
[Stats] Convert some ad-hoc header search stats to ALWAYS_ENABLED_STATISTIC.
Fri, Oct 11, 11:21 AM

Thu, Oct 10

vsapsai committed rG109bfb7b3293: [Polly] Fix formatting violation. NFC. (authored by vsapsai).
[Polly] Fix formatting violation. NFC.
Thu, Oct 10, 8:12 PM
vsapsai committed rL374504: [Polly] Fix formatting violation. NFC..
[Polly] Fix formatting violation. NFC.
Thu, Oct 10, 8:07 PM
vsapsai committed rG126158f096ca: [Stats] More polly fixes following llvm::Statistic changes in r374490. (authored by vsapsai).
[Stats] More polly fixes following llvm::Statistic changes in r374490.
Thu, Oct 10, 7:42 PM
vsapsai committed rL374501: [Stats] More polly fixes following llvm::Statistic changes in r374490..
[Stats] More polly fixes following llvm::Statistic changes in r374490.
Thu, Oct 10, 7:40 PM
vsapsai committed rGe90cc03a85ea: [Stats] Fix polly build due to change in llvm::Statistic constructor in r374490. (authored by vsapsai).
[Stats] Fix polly build due to change in llvm::Statistic constructor in r374490.
Thu, Oct 10, 6:45 PM
vsapsai committed rL374497: [Stats] Fix polly build due to change in llvm::Statistic constructor in r374490..
[Stats] Fix polly build due to change in llvm::Statistic constructor in r374490.
Thu, Oct 10, 6:45 PM
vsapsai committed rGadb203feda90: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS. (authored by vsapsai).
[Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.
Thu, Oct 10, 5:59 PM
vsapsai committed rL374490: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS..
[Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.
Thu, Oct 10, 5:59 PM
vsapsai closed D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS..
Thu, Oct 10, 5:59 PM · Restricted Project

Wed, Oct 9

vsapsai added a comment to D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS..

Thanks for the review.

Wed, Oct 9, 7:08 PM · Restricted Project
vsapsai updated the diff for D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS..
  • Address review comments.
Wed, Oct 9, 6:59 PM · Restricted Project
vsapsai committed rG02c2ab3d8872: [ObjC generics] Fix not inheriting type bounds in categories/extensions. (authored by vsapsai).
[ObjC generics] Fix not inheriting type bounds in categories/extensions.
Wed, Oct 9, 12:33 PM
vsapsai closed D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions..
Wed, Oct 9, 12:33 PM · Restricted Project
vsapsai committed rL374202: [ObjC generics] Fix not inheriting type bounds in categories/extensions..
[ObjC generics] Fix not inheriting type bounds in categories/extensions.
Wed, Oct 9, 12:32 PM
vsapsai added a comment to D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions..

Thanks for the review.

Wed, Oct 9, 12:32 PM · Restricted Project

Mon, Sep 30

vsapsai added a comment to D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS..

On release build with assertions disabled and LLVM_ENABLE_STATS being 0 the impact on the compile time is the following

Metric: compile_time
Mon, Sep 30, 4:12 PM · Restricted Project
vsapsai created D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS..
Mon, Sep 30, 4:09 PM · Restricted Project

Fri, Sep 27

vsapsai added a comment to D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions..

Found a use case where getCanonicalType() causes problems:

Fri, Sep 27, 5:16 PM · Restricted Project

Thu, Sep 26

vsapsai committed rL373020: Request commit access for vsapsai.
Request commit access for vsapsai
Thu, Sep 26, 3:13 PM

Wed, Sep 25

vsapsai committed rL372922: [LNT][docs] Fix some typos..
[LNT][docs] Fix some typos.
Wed, Sep 25, 3:25 PM

Tue, Sep 17

vsapsai committed rG6e353b4df3aa: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328. (authored by vsapsai).
[Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328.
Tue, Sep 17, 5:10 PM
vsapsai added a comment to D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328..

Thanks for the fast review.

Tue, Sep 17, 5:09 PM · Restricted Project
vsapsai committed rL372191: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328..
[Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328.
Tue, Sep 17, 5:04 PM
vsapsai closed D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328..
Tue, Sep 17, 5:04 PM · Restricted Project
vsapsai created D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328..
Tue, Sep 17, 4:05 PM · Restricted Project

Sep 13 2019

vsapsai added a comment to D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions..

I'm a bit curious about clients that use getCanonicalType() to get a full desugaring, instead of doing a single step. It seems like they'd still get the out of date type parameter type. Has that ever worked?

Sep 13 2019, 5:54 PM · Restricted Project

Sep 11 2019

vsapsai committed rGfdb83b505595: Fix up a test updated in r371655 - require case-insensitive file system. (authored by vsapsai).
Fix up a test updated in r371655 - require case-insensitive file system.
Sep 11 2019, 2:22 PM
vsapsai committed rL371665: Fix up a test updated in r371655 - require case-insensitive file system..
Fix up a test updated in r371655 - require case-insensitive file system.
Sep 11 2019, 2:22 PM
vsapsai committed rG2f8436168499: Fix -Wnonportable-include-path suppression for header maps with absolute paths. (authored by vsapsai).
Fix -Wnonportable-include-path suppression for header maps with absolute paths.
Sep 11 2019, 1:41 PM
vsapsai committed rL371655: Fix -Wnonportable-include-path suppression for header maps with absolute paths..
Fix -Wnonportable-include-path suppression for header maps with absolute paths.
Sep 11 2019, 1:40 PM
vsapsai closed D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..
Sep 11 2019, 1:40 PM · Restricted Project
vsapsai added a comment to D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..

Thanks for the review.

Sep 11 2019, 1:27 PM · Restricted Project

Sep 9 2019

vsapsai added a comment to D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions..

Ping.

Sep 9 2019, 1:39 PM · Restricted Project

Sep 6 2019

vsapsai added a comment to D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..

Updated the code. Hope it is easier to understand now.

Sep 6 2019, 4:03 PM · Restricted Project
vsapsai updated the diff for D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..
  • Add a test for unused absolute path in a header map; simplify code.
Sep 6 2019, 3:56 PM · Restricted Project
vsapsai added inline comments to D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..
Sep 6 2019, 11:28 AM · Restricted Project

Sep 5 2019

vsapsai updated subscribers of D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory..

Adding Michael Spencer as he was doing some work for a working directory in VFS.

Sep 5 2019, 3:26 PM · Restricted Project, Restricted Project

Sep 4 2019

vsapsai added a comment to D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..

Ping.

Sep 4 2019, 3:04 PM · Restricted Project
vsapsai updated the diff for D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..
  • Rebase the patch.
Sep 4 2019, 3:04 PM · Restricted Project

Aug 29 2019

vsapsai added a comment to D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU.

For the record, there was another change regarding the delayed typos in clang::Sema::~Sema(): D62648 [Sema][Typo] Fix assertion failure for expressions with multiple typos.

Aug 29 2019, 4:18 PM · Restricted Project
vsapsai committed rG0785f8d0bb70: Remove `FileManager::invalidateCache` as it has no callers anymore. NFC. (authored by vsapsai).
Remove `FileManager::invalidateCache` as it has no callers anymore. NFC.
Aug 29 2019, 12:54 PM
vsapsai committed rL370400: Remove `FileManager::invalidateCache` as it has no callers anymore. NFC..
Remove `FileManager::invalidateCache` as it has no callers anymore. NFC.
Aug 29 2019, 12:50 PM

Aug 28 2019

vsapsai added inline comments to D66907: [Modules] Fix rebuilding an updated module for each of its consumers..
Aug 28 2019, 4:48 PM · Restricted Project
vsapsai added a comment to D66831: [ObjC] Fix type checking for qualified id block parameters..

We're getting a bunch of errors looking like ../../AppsListViewController.m:11:37: error: incompatible block pointer types assigning to 'void (^)(__strong id<AppCellProtocol>)' from 'void (^)(AppCollectionViewCell *__strong)' on code that looks fairly harmless to me. It looks something like this:

@protocol AppCellProtocol <NSObject> ... @end
@interface AppCollectionViewCell : NSObject <AppCellProtocol> ...@enderby 

@interface Cell : NSObject
@property(nonatomic, copy) void (^buttonPressed)(id<AppCellProtocol> cell);
@end

@implementation Bar
- (void) f {
  __weak __typeof(self) weakSelf = self;
  cell.buttonPressed = ^(AppCollectionViewCell *pressedCell) {
    // ...
  };
}
@end

The code doesn't say __strong anywhere as far as I can tell; it looks like regular protocol code.

Is this expected?

Aug 28 2019, 4:41 PM · Restricted Project
vsapsai committed rGf91b6f8159b1: [Modules] Fix rebuilding an updated module for each of its consumers. (authored by vsapsai).
[Modules] Fix rebuilding an updated module for each of its consumers.
Aug 28 2019, 4:33 PM
vsapsai committed rL370274: [Modules] Fix rebuilding an updated module for each of its consumers..
[Modules] Fix rebuilding an updated module for each of its consumers.
Aug 28 2019, 4:32 PM
vsapsai closed D66907: [Modules] Fix rebuilding an updated module for each of its consumers..
Aug 28 2019, 4:32 PM · Restricted Project
vsapsai added a comment to D66907: [Modules] Fix rebuilding an updated module for each of its consumers..

Earlier tryToDropPCM was called tryToRemoveBuffer and it was added in r298278. According to my investigation and understanding it was used to remove tentatively loaded dependencies. Otherwise we would finalize them before validating if they are up to date. But now we are tracking a state of each module (Unknown, Tentative, ToBuild, Final) individually and don't need tryToDropPCM.

Aug 28 2019, 3:21 PM · Restricted Project
vsapsai created D66907: [Modules] Fix rebuilding an updated module for each of its consumers..
Aug 28 2019, 3:05 PM · Restricted Project

Aug 27 2019

vsapsai committed rG73152a2ec207: [ObjC] Fix type checking for qualified id block parameters. (authored by vsapsai).
[ObjC] Fix type checking for qualified id block parameters.
Aug 27 2019, 5:28 PM
vsapsai committed rL370130: [ObjC] Fix type checking for qualified id block parameters..
[ObjC] Fix type checking for qualified id block parameters.
Aug 27 2019, 5:28 PM
vsapsai closed D66831: [ObjC] Fix type checking for qualified id block parameters..
Aug 27 2019, 5:27 PM · Restricted Project
vsapsai added a comment to D66831: [ObjC] Fix type checking for qualified id block parameters..

Thanks for the fast review.

Aug 27 2019, 5:27 PM · Restricted Project
vsapsai added inline comments to D66831: [ObjC] Fix type checking for qualified id block parameters..
Aug 27 2019, 2:48 PM · Restricted Project
vsapsai created D66831: [ObjC] Fix type checking for qualified id block parameters..
Aug 27 2019, 2:42 PM · Restricted Project

Aug 23 2019

vsapsai created D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions..
Aug 23 2019, 7:08 PM · Restricted Project

Aug 9 2019

vsapsai accepted D65545: Handle some fs::remove failures.

Looks good to me. If in some situations abort on error turns out to be too aggressive, we can change it later.

Aug 9 2019, 3:39 PM · Restricted Project, Restricted Project

Aug 7 2019

vsapsai updated subscribers of D65545: Handle some fs::remove failures.
Aug 7 2019, 12:30 PM · Restricted Project, Restricted Project
vsapsai added a comment to D65545: Handle some fs::remove failures.

I have no other comments but for the fatal error in FileRemover I'd like to loop in Jonas as he was touching module cache in LLDB fairly recently.

Aug 7 2019, 12:29 PM · Restricted Project, Restricted Project

Aug 2 2019

vsapsai added inline comments to D65545: Handle some fs::remove failures.
Aug 2 2019, 5:02 PM · Restricted Project, Restricted Project

Jul 31 2019

vsapsai added inline comments to D65545: Handle some fs::remove failures.
Jul 31 2019, 5:25 PM · Restricted Project, Restricted Project

Jul 16 2019

vsapsai added inline comments to D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU.
Jul 16 2019, 7:07 PM · Restricted Project

Jun 28 2019

vsapsai committed rG5f8b9092fff4: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots. (authored by vsapsai).
[ODRHash] Fix null pointer dereference for ObjC selectors with empty slots.
Jun 28 2019, 10:44 AM
vsapsai committed rL364664: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..
[ODRHash] Fix null pointer dereference for ObjC selectors with empty slots.
Jun 28 2019, 10:44 AM
vsapsai closed D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..
Jun 28 2019, 10:44 AM · Restricted Project, Restricted Project

Jun 27 2019

vsapsai updated the diff for D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..
  • Address review comments.
Jun 27 2019, 8:27 PM · Restricted Project, Restricted Project

Jun 25 2019

vsapsai added inline comments to D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..
Jun 25 2019, 7:31 PM · Restricted Project, Restricted Project
vsapsai created D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..
Jun 25 2019, 1:38 PM · Restricted Project, Restricted Project

Jun 18 2019

vsapsai added a comment to D63508: make -frewrite-includes also rewrite conditions in #if/#elif.

Luboš, can you please clarify what is wrong with the current Clang behavior? I'm just thinking about what should we do with nested macros.

Jun 18 2019, 6:21 PM · Restricted Project, Restricted Project

May 27 2019

vsapsai committed rGe32ff0968585: [Preprocessor] Fix crash emitting note with framework location for "file not… (authored by vsapsai).
[Preprocessor] Fix crash emitting note with framework location for "file not…
May 27 2019, 12:14 PM
vsapsai committed rL361779: [Preprocessor] Fix crash emitting note with framework location for "file not….
[Preprocessor] Fix crash emitting note with framework location for "file not…
May 27 2019, 12:14 PM
vsapsai committed rC361779: [Preprocessor] Fix crash emitting note with framework location for "file not….
[Preprocessor] Fix crash emitting note with framework location for "file not…
May 27 2019, 12:14 PM
vsapsai closed D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error..
May 27 2019, 12:14 PM · Restricted Project
vsapsai added a comment to D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error..

Thanks for the review, Alex.

May 27 2019, 12:14 PM · Restricted Project

May 22 2019

vsapsai updated the diff for D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error..
  • Address review comments: don't introduce HasBeenMapped and rely on CacheLookup.MappedName.
May 22 2019, 7:34 PM · Restricted Project
vsapsai added inline comments to D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error..
May 22 2019, 7:33 PM · Restricted Project

May 21 2019

vsapsai added a comment to D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error..

Ping.

May 21 2019, 12:54 PM · Restricted Project

May 13 2019

vsapsai committed rG51e79f06342b: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`. (authored by vsapsai).
[X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.
May 13 2019, 3:39 PM
vsapsai committed rC360630: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`..
[X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.
May 13 2019, 3:39 PM
vsapsai committed rL360630: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`..
[X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.
May 13 2019, 3:39 PM
vsapsai closed D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`..
May 13 2019, 3:39 PM · Restricted Project
vsapsai added a comment to D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`..
In D61621#1497027, @rnk wrote:

lgtm, thanks!

Didn't use -fms-compatibility in the test and it seems to be working fine.
Don't know if it is accidental and if I should add the flag.

-fms-extensions is probably all you need. That's the one that defines _MSC_VER.

May 13 2019, 3:32 PM · Restricted Project
vsapsai committed rG44a7abe58410: Make language option `GNUAsm` discoverable with `__has_extension` macro. (authored by vsapsai).
Make language option `GNUAsm` discoverable with `__has_extension` macro.
May 13 2019, 3:10 PM
vsapsai committed rL360625: Make language option `GNUAsm` discoverable with `__has_extension` macro..
Make language option `GNUAsm` discoverable with `__has_extension` macro.
May 13 2019, 3:10 PM
vsapsai committed rC360625: Make language option `GNUAsm` discoverable with `__has_extension` macro..
Make language option `GNUAsm` discoverable with `__has_extension` macro.
May 13 2019, 3:10 PM
vsapsai closed D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro..
May 13 2019, 3:09 PM · Restricted Project
vsapsai added a comment to D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro..

Thanks for the review, Aaron.

May 13 2019, 3:02 PM · Restricted Project
vsapsai added a comment to D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro..

Ping.

May 13 2019, 12:40 PM · Restricted Project
vsapsai added a comment to D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error..

Ping.

May 13 2019, 12:39 PM · Restricted Project

May 9 2019

vsapsai updated the diff for D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`..
  • Improve -fno-gnu-inline-asm support for MS-compatibility too.
May 9 2019, 11:06 AM · Restricted Project

May 8 2019

vsapsai created D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error..
May 8 2019, 5:41 PM · Restricted Project

May 6 2019

vsapsai added a comment to D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics.

Discussed with the team different approaches and suggesting https://reviews.llvm.org/D61621

May 6 2019, 4:28 PM
vsapsai added a parent revision for D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.: D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro..
May 6 2019, 4:17 PM · Restricted Project
vsapsai created D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`..
May 6 2019, 4:17 PM · Restricted Project
vsapsai added a child revision for D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.: D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`..
May 6 2019, 4:17 PM · Restricted Project
vsapsai created D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro..
May 6 2019, 4:13 PM · Restricted Project