Page MenuHomePhabricator

vsapsai (Volodymyr Sapsai)
User

Projects

User does not belong to any projects.

User Details

User Since
May 27 2014, 6:39 AM (256 w, 14 h)

Recent Activity

Today

vsapsai added a comment to D60848: [Parser] Avoid correcting delayed typos in array subscript multiple times..

Wait, why is NumTypos incorrect here? I think its because we don't handle the typo on the line: [self undeclaredMethod:undeclaredArg];, even the following asserts now. Seems like the right fix would be to track down why we aren't handling the typo in the message expr.

// RUN: clang -cc1 %s -fobjc-arc
@implementation X
-x { [self undeclaredMethod:undeclaredArg]; }
@end
Tue, Apr 23, 5:47 PM

Wed, Apr 17

vsapsai updated the summary of D60848: [Parser] Avoid correcting delayed typos in array subscript multiple times..
Wed, Apr 17, 7:14 PM
vsapsai created D60848: [Parser] Avoid correcting delayed typos in array subscript multiple times..
Wed, Apr 17, 7:06 PM

Tue, Apr 16

vsapsai added a comment to D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..

Ping.

Tue, Apr 16, 3:38 PM

Mon, Apr 1

vsapsai added a comment to D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..

Ping.

Mon, Apr 1, 5:25 PM

Fri, Mar 29

vsapsai committed rG9e911f3a6476: [Sema] Fix assertion when `auto` parameter in lambda has an attribute. (authored by vsapsai).
[Sema] Fix assertion when `auto` parameter in lambda has an attribute.
Fri, Mar 29, 11:46 AM
vsapsai committed rC357298: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..
[Sema] Fix assertion when `auto` parameter in lambda has an attribute.
Fri, Mar 29, 11:45 AM
vsapsai committed rL357298: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..
[Sema] Fix assertion when `auto` parameter in lambda has an attribute.
Fri, Mar 29, 11:45 AM
vsapsai closed D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..
Fri, Mar 29, 11:45 AM · Restricted Project
vsapsai added a comment to D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..

Thanks for the review, Aaron.

Fri, Mar 29, 11:44 AM · Restricted Project

Mar 11 2019

vsapsai added inline comments to D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..
Mar 11 2019, 1:05 PM · Restricted Project

Mar 4 2019

vsapsai added inline comments to D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..
Mar 4 2019, 7:40 PM · Restricted Project
vsapsai added a comment to D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..

Ping.

Mar 4 2019, 6:59 PM

Mar 1 2019

vsapsai committed rG738f697a19a7: [sanitizers] Fix build on macOS with LogFullErrorReport redefinition error. (authored by vsapsai).
[sanitizers] Fix build on macOS with LogFullErrorReport redefinition error.
Mar 1 2019, 4:05 PM
vsapsai committed rL355244: [sanitizers] Fix build on macOS with LogFullErrorReport redefinition error..
[sanitizers] Fix build on macOS with LogFullErrorReport redefinition error.
Mar 1 2019, 4:04 PM
vsapsai committed rCRT355244: [sanitizers] Fix build on macOS with LogFullErrorReport redefinition error..
[sanitizers] Fix build on macOS with LogFullErrorReport redefinition error.
Mar 1 2019, 4:04 PM

Feb 28 2019

vsapsai committed rG93317d82daf8: [CodeGen] Fix calling llvm.var.annotation outside of a basic block. (authored by vsapsai).
[CodeGen] Fix calling llvm.var.annotation outside of a basic block.
Feb 28 2019, 6:16 PM
vsapsai committed rC355166: [CodeGen] Fix calling llvm.var.annotation outside of a basic block..
[CodeGen] Fix calling llvm.var.annotation outside of a basic block.
Feb 28 2019, 6:16 PM
vsapsai committed rL355166: [CodeGen] Fix calling llvm.var.annotation outside of a basic block..
[CodeGen] Fix calling llvm.var.annotation outside of a basic block.
Feb 28 2019, 6:16 PM
vsapsai closed D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block..
Feb 28 2019, 6:16 PM · Restricted Project
vsapsai added a comment to D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block..

Thanks for the review.

Feb 28 2019, 6:16 PM · Restricted Project

Feb 26 2019

vsapsai committed rGbc72061edf42: [index] Fixup for r354942. Specify target in test to achieve stable mangling. (authored by vsapsai).
[index] Fixup for r354942. Specify target in test to achieve stable mangling.
Feb 26 2019, 5:39 PM
vsapsai committed rC354946: [index] Fixup for r354942. Specify target in test to achieve stable mangling..
[index] Fixup for r354942. Specify target in test to achieve stable mangling.
Feb 26 2019, 5:39 PM
vsapsai committed rL354946: [index] Fixup for r354942. Specify target in test to achieve stable mangling..
[index] Fixup for r354942. Specify target in test to achieve stable mangling.
Feb 26 2019, 5:39 PM
vsapsai committed rG4b0f7f99ce13: [index] Improve indexing support for MSPropertyDecl. (authored by vsapsai).
[index] Improve indexing support for MSPropertyDecl.
Feb 26 2019, 5:06 PM
vsapsai committed rC354942: [index] Improve indexing support for MSPropertyDecl..
[index] Improve indexing support for MSPropertyDecl.
Feb 26 2019, 5:05 PM
vsapsai committed rL354942: [index] Improve indexing support for MSPropertyDecl..
[index] Improve indexing support for MSPropertyDecl.
Feb 26 2019, 5:05 PM
vsapsai closed D57628: [index] Improve indexing support for MSPropertyDecl..
Feb 26 2019, 5:05 PM · Restricted Project
vsapsai added a comment to D57628: [index] Improve indexing support for MSPropertyDecl..

Thanks for reviewing the change!

Feb 26 2019, 5:05 PM · Restricted Project
vsapsai added a comment to D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block..

Okay. Is it acceptable for the annotation to simply disappear in this case? I don't really understand the purposes of annotations well enough to judge.

Feb 26 2019, 3:52 PM · Restricted Project
vsapsai added a comment to D57628: [index] Improve indexing support for MSPropertyDecl..

Ping.

Feb 26 2019, 11:35 AM · Restricted Project

Feb 25 2019

vsapsai added a reviewer for D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute.: aaron.ballman.
Feb 25 2019, 5:49 PM · Restricted Project
vsapsai added a comment to D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..

Have doubts that checking only the outermost type for being AttributedType after Sema::ReplaceAutoType is sufficient but haven't found a counterexample yet. Decided to post the proposed fix to see if others have any ideas.

Feb 25 2019, 5:46 PM · Restricted Project
vsapsai created D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..
Feb 25 2019, 5:41 PM · Restricted Project

Feb 15 2019

vsapsai added a comment to D57075: [ObjC] For type substitution in generics use a regular recursive type visitor..

Thanks for the review, Erik.

Feb 15 2019, 5:02 PM · Restricted Project
vsapsai committed rGbcb4f7208dac: [ObjC generics] Fix applying `__kindof` to the type parameter. (authored by vsapsai).
[ObjC generics] Fix applying `__kindof` to the type parameter.
Feb 15 2019, 5:01 PM
vsapsai committed rL354189: [ObjC generics] Fix applying `__kindof` to the type parameter..
[ObjC generics] Fix applying `__kindof` to the type parameter.
Feb 15 2019, 5:01 PM
vsapsai committed rC354189: [ObjC generics] Fix applying `__kindof` to the type parameter..
[ObjC generics] Fix applying `__kindof` to the type parameter.
Feb 15 2019, 5:00 PM
vsapsai closed D57076: [ObjC generics] Fix applying `__kindof` to the type parameter..
Feb 15 2019, 5:00 PM · Restricted Project
vsapsai committed rG78b84cf99120: [ObjC] For type substitution in generics use a regular recursive type visitor. (authored by vsapsai).
[ObjC] For type substitution in generics use a regular recursive type visitor.
Feb 15 2019, 2:16 PM
vsapsai committed rL354180: [ObjC] For type substitution in generics use a regular recursive type visitor..
[ObjC] For type substitution in generics use a regular recursive type visitor.
Feb 15 2019, 2:14 PM
vsapsai committed rC354180: [ObjC] For type substitution in generics use a regular recursive type visitor..
[ObjC] For type substitution in generics use a regular recursive type visitor.
Feb 15 2019, 2:14 PM
vsapsai closed D57075: [ObjC] For type substitution in generics use a regular recursive type visitor..
Feb 15 2019, 2:14 PM · Restricted Project
vsapsai committed rG4b512c36b6ab: [ObjC] Fix non-canonical types preventing type arguments substitution. (authored by vsapsai).
[ObjC] Fix non-canonical types preventing type arguments substitution.
Feb 15 2019, 12:18 PM
vsapsai committed rC354164: [ObjC] Fix non-canonical types preventing type arguments substitution..
[ObjC] Fix non-canonical types preventing type arguments substitution.
Feb 15 2019, 12:17 PM
vsapsai committed rL354164: [ObjC] Fix non-canonical types preventing type arguments substitution..
[ObjC] Fix non-canonical types preventing type arguments substitution.
Feb 15 2019, 12:17 PM
vsapsai closed D57270: [ObjC] Fix non-canonical types preventing type arguments substitution..
Feb 15 2019, 12:17 PM · Restricted Project

Feb 14 2019

vsapsai committed rG78899aed7f1b: [Driver][Darwin] Emit an error when using -pg on OS without support for it. (authored by vsapsai).
[Driver][Darwin] Emit an error when using -pg on OS without support for it.
Feb 14 2019, 3:54 PM
vsapsai committed rC354084: [Driver][Darwin] Emit an error when using -pg on OS without support for it..
[Driver][Darwin] Emit an error when using -pg on OS without support for it.
Feb 14 2019, 3:54 PM
vsapsai committed rL354084: [Driver][Darwin] Emit an error when using -pg on OS without support for it..
[Driver][Darwin] Emit an error when using -pg on OS without support for it.
Feb 14 2019, 3:54 PM
vsapsai closed D57991: [Driver][Darwin] Emit an error when using -pg on OS without support for it..
Feb 14 2019, 3:54 PM · Restricted Project
vsapsai committed rG8b982cb8a90d: [clang-tidy] Mention language version in test explicitly. (authored by vsapsai).
[clang-tidy] Mention language version in test explicitly.
Feb 14 2019, 2:43 PM
vsapsai committed rCTE354069: [clang-tidy] Mention language version in test explicitly..
[clang-tidy] Mention language version in test explicitly.
Feb 14 2019, 2:42 PM
vsapsai committed rL354069: [clang-tidy] Mention language version in test explicitly..
[clang-tidy] Mention language version in test explicitly.
Feb 14 2019, 2:37 PM

Feb 12 2019

vsapsai added a comment to D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block..

I've checked and seems like other places where we EmitAnnotationCall should be safe. We do that for globals, function parameters, fields (FieldDecl) and early return isn't applicable in those cases. We can do that for any expressions with __builtin_annotation but that was already working correctly and I've just added a test.

Feb 12 2019, 2:08 PM · Restricted Project
vsapsai created D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block..
Feb 12 2019, 2:03 PM · Restricted Project
vsapsai updated the diff for D57991: [Driver][Darwin] Emit an error when using -pg on OS without support for it..
  • Use %select per Steven's recommendation.
Feb 12 2019, 11:24 AM · Restricted Project

Feb 11 2019

vsapsai added inline comments to D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..
Feb 11 2019, 7:59 PM
vsapsai created D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..
Feb 11 2019, 7:52 PM

Feb 8 2019

vsapsai created D57991: [Driver][Darwin] Emit an error when using -pg on OS without support for it..
Feb 8 2019, 5:56 PM · Restricted Project
vsapsai committed rG1570571ded26: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects. (authored by vsapsai).
[CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.
Feb 8 2019, 3:02 PM
vsapsai committed rL353577: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects..
[CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.
Feb 8 2019, 3:02 PM
vsapsai committed rC353577: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects..
[CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.
Feb 8 2019, 3:02 PM
vsapsai closed D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects..
Feb 8 2019, 3:02 PM · Restricted Project
vsapsai added a comment to D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects..

What's the status of this patch? Is it something we should merge onto the 8.0 release branch?

Feb 8 2019, 1:37 PM · Restricted Project
vsapsai added a comment to D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects..

@ahatanak, can you please take a look again?

Feb 8 2019, 1:27 PM · Restricted Project
vsapsai added a comment to D57628: [index] Improve indexing support for MSPropertyDecl..

Ping.

Feb 8 2019, 1:10 PM · Restricted Project
vsapsai added a comment to D57270: [ObjC] Fix non-canonical types preventing type arguments substitution..

Ping.

Feb 8 2019, 1:10 PM · Restricted Project

Feb 5 2019

vsapsai committed rG421380a10816: [Preprocessor] Add a note with framework location for "file not found" error. (authored by vsapsai).
[Preprocessor] Add a note with framework location for "file not found" error.
Feb 5 2019, 2:35 PM
vsapsai committed rL353231: [Preprocessor] Add a note with framework location for "file not found" error..
[Preprocessor] Add a note with framework location for "file not found" error.
Feb 5 2019, 2:35 PM
vsapsai committed rC353231: [Preprocessor] Add a note with framework location for "file not found" error..
[Preprocessor] Add a note with framework location for "file not found" error.
Feb 5 2019, 2:34 PM
vsapsai closed D56561: [Preprocessor] For missing file in framework add note about framework location..
Feb 5 2019, 2:34 PM · Restricted Project

Feb 1 2019

vsapsai updated the diff for D56561: [Preprocessor] For missing file in framework add note about framework location..
  • Improve the diagnostic message wording.
Feb 1 2019, 4:20 PM · Restricted Project
vsapsai created D57628: [index] Improve indexing support for MSPropertyDecl..
Feb 1 2019, 3:28 PM · Restricted Project

Jan 30 2019

vsapsai updated the diff for D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects..
  • Add in the test -disable-llvm-passes and relax FileCheck expectations to accept alloca-store-load.
Jan 30 2019, 10:59 AM · Restricted Project

Jan 29 2019

vsapsai added a comment to D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects..

LGTM, but may want to wait for other reviewers.

Jan 29 2019, 5:34 PM · Restricted Project
vsapsai created D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects..
Jan 29 2019, 5:03 PM · Restricted Project

Jan 25 2019

vsapsai added inline comments to D56561: [Preprocessor] For missing file in framework add note about framework location..
Jan 25 2019, 6:40 PM · Restricted Project
vsapsai updated the diff for D56561: [Preprocessor] For missing file in framework add note about framework location..
  • Tweak doxygen comment to express IsFrameworkFound in terms of IsFrameworkFound returned by DirectoryLookup.
Jan 25 2019, 6:33 PM · Restricted Project
vsapsai updated the diff for D57075: [ObjC] For type substitution in generics use a regular recursive type visitor..

Rebase on top of https://reviews.llvm.org/D57270

Jan 25 2019, 5:19 PM · Restricted Project
vsapsai added a child revision for D57270: [ObjC] Fix non-canonical types preventing type arguments substitution.: D57075: [ObjC] For type substitution in generics use a regular recursive type visitor..
Jan 25 2019, 5:11 PM · Restricted Project
vsapsai added a parent revision for D57075: [ObjC] For type substitution in generics use a regular recursive type visitor.: D57270: [ObjC] Fix non-canonical types preventing type arguments substitution..
Jan 25 2019, 5:11 PM · Restricted Project
vsapsai created D57270: [ObjC] Fix non-canonical types preventing type arguments substitution..
Jan 25 2019, 5:10 PM · Restricted Project
vsapsai planned changes to D57075: [ObjC] For type substitution in generics use a regular recursive type visitor..
Jan 25 2019, 4:05 PM · Restricted Project

Jan 24 2019

vsapsai added a comment to D57075: [ObjC] For type substitution in generics use a regular recursive type visitor..

I've added a test case with typedef and think it should be emitting a warning. I.e., the behaviour with typedef should be the same as without it, modulo different pretty-printing in diagnostic. The interesting part is that this test is failing even without my change. I'll look into that and depending on the fix, I'll update this change accordingly.

Jan 24 2019, 5:24 PM · Restricted Project
vsapsai updated the diff for D57075: [ObjC] For type substitution in generics use a regular recursive type visitor..
  • Add a failing test case.
Jan 24 2019, 5:19 PM · Restricted Project
vsapsai planned changes to D57075: [ObjC] For type substitution in generics use a regular recursive type visitor..
Jan 24 2019, 4:48 PM · Restricted Project
vsapsai added inline comments to D57076: [ObjC generics] Fix applying `__kindof` to the type parameter..
Jan 24 2019, 10:46 AM · Restricted Project
vsapsai updated the diff for D57076: [ObjC generics] Fix applying `__kindof` to the type parameter..
  • Address review comment: don't crash when AttributedType is transformed to another type class.
Jan 24 2019, 10:44 AM · Restricted Project

Jan 23 2019

vsapsai updated the diff for D57076: [ObjC generics] Fix applying `__kindof` to the type parameter..
  • Add a test that __kindof works with type sugar such as typedef.
  • Use early return to reduce nesting. Also it's consistent with the previous early returns.
Jan 23 2019, 5:14 PM · Restricted Project
vsapsai updated the diff for D57076: [ObjC generics] Fix applying `__kindof` to the type parameter..

Update diff to ignore parent patch.

Jan 23 2019, 5:14 PM · Restricted Project
vsapsai added a comment to D57076: [ObjC generics] Fix applying `__kindof` to the type parameter..

I think this is reasonable but Doug was the one who worked on this. I wonder if it also helps with the test cases in rdar://problem/24619481.

Jan 23 2019, 5:10 PM · Restricted Project
vsapsai added a comment to D56561: [Preprocessor] For missing file in framework add note about framework location..

Ping.

Jan 23 2019, 12:05 PM · Restricted Project

Jan 22 2019

vsapsai added a parent revision for D57076: [ObjC generics] Fix applying `__kindof` to the type parameter.: D57075: [ObjC] For type substitution in generics use a regular recursive type visitor..
Jan 22 2019, 6:20 PM · Restricted Project
vsapsai added a child revision for D57075: [ObjC] For type substitution in generics use a regular recursive type visitor.: D57076: [ObjC generics] Fix applying `__kindof` to the type parameter..
Jan 22 2019, 6:20 PM · Restricted Project
vsapsai created D57076: [ObjC generics] Fix applying `__kindof` to the type parameter..
Jan 22 2019, 6:19 PM · Restricted Project
vsapsai created D57075: [ObjC] For type substitution in generics use a regular recursive type visitor..
Jan 22 2019, 6:18 PM · Restricted Project

Jan 16 2019

vsapsai added a comment to D56766: [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction..

Thanks for the review.

Jan 16 2019, 4:26 PM
vsapsai committed rL351402: [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction..
[Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction.
Jan 16 2019, 4:25 PM
vsapsai committed rC351402: [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction..
[Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction.
Jan 16 2019, 4:25 PM