Page MenuHomePhabricator

vsapsai (Volodymyr Sapsai)
User

Projects

User does not belong to any projects.

User Details

User Since
May 27 2014, 6:39 AM (272 w, 5 d)

Recent Activity

Fri, Aug 9

vsapsai accepted D65545: Handle some fs::remove failures.

Looks good to me. If in some situations abort on error turns out to be too aggressive, we can change it later.

Fri, Aug 9, 3:39 PM · Restricted Project, Restricted Project

Wed, Aug 7

vsapsai updated subscribers of D65545: Handle some fs::remove failures.
Wed, Aug 7, 12:30 PM · Restricted Project, Restricted Project
vsapsai added a comment to D65545: Handle some fs::remove failures.

I have no other comments but for the fatal error in FileRemover I'd like to loop in Jonas as he was touching module cache in LLDB fairly recently.

Wed, Aug 7, 12:29 PM · Restricted Project, Restricted Project

Fri, Aug 2

vsapsai added inline comments to D65545: Handle some fs::remove failures.
Fri, Aug 2, 5:02 PM · Restricted Project, Restricted Project

Wed, Jul 31

vsapsai added inline comments to D65545: Handle some fs::remove failures.
Wed, Jul 31, 5:25 PM · Restricted Project, Restricted Project

Jul 16 2019

vsapsai added inline comments to D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU.
Jul 16 2019, 7:07 PM · Restricted Project

Jun 28 2019

vsapsai committed rG5f8b9092fff4: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots. (authored by vsapsai).
[ODRHash] Fix null pointer dereference for ObjC selectors with empty slots.
Jun 28 2019, 10:44 AM
vsapsai committed rL364664: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..
[ODRHash] Fix null pointer dereference for ObjC selectors with empty slots.
Jun 28 2019, 10:44 AM
vsapsai closed D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..
Jun 28 2019, 10:44 AM · Restricted Project, Restricted Project

Jun 27 2019

vsapsai updated the diff for D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..
  • Address review comments.
Jun 27 2019, 8:27 PM · Restricted Project, Restricted Project

Jun 25 2019

vsapsai added inline comments to D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..
Jun 25 2019, 7:31 PM · Restricted Project, Restricted Project
vsapsai created D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..
Jun 25 2019, 1:38 PM · Restricted Project, Restricted Project

Jun 18 2019

vsapsai added a comment to D63508: make -frewrite-includes also rewrite conditions in #if/#elif.

Luboš, can you please clarify what is wrong with the current Clang behavior? I'm just thinking about what should we do with nested macros.

Jun 18 2019, 6:21 PM · Restricted Project

May 27 2019

vsapsai committed rGe32ff0968585: [Preprocessor] Fix crash emitting note with framework location for "file not… (authored by vsapsai).
[Preprocessor] Fix crash emitting note with framework location for "file not…
May 27 2019, 12:14 PM
vsapsai committed rL361779: [Preprocessor] Fix crash emitting note with framework location for "file not….
[Preprocessor] Fix crash emitting note with framework location for "file not…
May 27 2019, 12:14 PM
vsapsai committed rC361779: [Preprocessor] Fix crash emitting note with framework location for "file not….
[Preprocessor] Fix crash emitting note with framework location for "file not…
May 27 2019, 12:14 PM
vsapsai closed D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error..
May 27 2019, 12:14 PM · Restricted Project
vsapsai added a comment to D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error..

Thanks for the review, Alex.

May 27 2019, 12:14 PM · Restricted Project

May 22 2019

vsapsai updated the diff for D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error..
  • Address review comments: don't introduce HasBeenMapped and rely on CacheLookup.MappedName.
May 22 2019, 7:34 PM · Restricted Project
vsapsai added inline comments to D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error..
May 22 2019, 7:33 PM · Restricted Project

May 21 2019

vsapsai added a comment to D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error..

Ping.

May 21 2019, 12:54 PM · Restricted Project

May 13 2019

vsapsai committed rG51e79f06342b: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`. (authored by vsapsai).
[X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.
May 13 2019, 3:39 PM
vsapsai committed rC360630: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`..
[X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.
May 13 2019, 3:39 PM
vsapsai committed rL360630: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`..
[X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.
May 13 2019, 3:39 PM
vsapsai closed D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`..
May 13 2019, 3:39 PM · Restricted Project
vsapsai added a comment to D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`..
In D61621#1497027, @rnk wrote:

lgtm, thanks!

Didn't use -fms-compatibility in the test and it seems to be working fine.
Don't know if it is accidental and if I should add the flag.

-fms-extensions is probably all you need. That's the one that defines _MSC_VER.

May 13 2019, 3:32 PM · Restricted Project
vsapsai committed rG44a7abe58410: Make language option `GNUAsm` discoverable with `__has_extension` macro. (authored by vsapsai).
Make language option `GNUAsm` discoverable with `__has_extension` macro.
May 13 2019, 3:10 PM
vsapsai committed rL360625: Make language option `GNUAsm` discoverable with `__has_extension` macro..
Make language option `GNUAsm` discoverable with `__has_extension` macro.
May 13 2019, 3:10 PM
vsapsai committed rC360625: Make language option `GNUAsm` discoverable with `__has_extension` macro..
Make language option `GNUAsm` discoverable with `__has_extension` macro.
May 13 2019, 3:10 PM
vsapsai closed D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro..
May 13 2019, 3:09 PM · Restricted Project
vsapsai added a comment to D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro..

Thanks for the review, Aaron.

May 13 2019, 3:02 PM · Restricted Project
vsapsai added a comment to D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro..

Ping.

May 13 2019, 12:40 PM · Restricted Project
vsapsai added a comment to D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error..

Ping.

May 13 2019, 12:39 PM · Restricted Project

May 9 2019

vsapsai updated the diff for D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`..
  • Improve -fno-gnu-inline-asm support for MS-compatibility too.
May 9 2019, 11:06 AM · Restricted Project

May 8 2019

vsapsai created D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error..
May 8 2019, 5:41 PM · Restricted Project

May 6 2019

vsapsai added a comment to D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics.

Discussed with the team different approaches and suggesting https://reviews.llvm.org/D61621

May 6 2019, 4:28 PM
vsapsai added a parent revision for D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.: D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro..
May 6 2019, 4:17 PM · Restricted Project
vsapsai created D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`..
May 6 2019, 4:17 PM · Restricted Project
vsapsai added a child revision for D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.: D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`..
May 6 2019, 4:17 PM · Restricted Project
vsapsai created D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro..
May 6 2019, 4:13 PM · Restricted Project

May 1 2019

vsapsai committed rG31f7c4aa77e1: [Parser] Avoid correcting delayed typos in array subscript multiple times. (authored by vsapsai).
[Parser] Avoid correcting delayed typos in array subscript multiple times.
May 1 2019, 12:24 PM
vsapsai committed rC359713: [Parser] Avoid correcting delayed typos in array subscript multiple times..
[Parser] Avoid correcting delayed typos in array subscript multiple times.
May 1 2019, 12:24 PM
vsapsai committed rL359713: [Parser] Avoid correcting delayed typos in array subscript multiple times..
[Parser] Avoid correcting delayed typos in array subscript multiple times.
May 1 2019, 12:23 PM
vsapsai closed D60848: [Parser] Avoid correcting delayed typos in array subscript multiple times..
May 1 2019, 12:23 PM · Restricted Project

Apr 30 2019

vsapsai added a comment to D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics.

Having in bitcode something like @llvm.x86.encls.64 is better than inline assembly because we understand the meaning of the bitcode while we don't parse assembly and have a very limited understanding of what it is doing.

Apr 30 2019, 3:00 PM
vsapsai updated the diff for D60848: [Parser] Avoid correcting delayed typos in array subscript multiple times..
  • Add a test case with -disable-free.
Apr 30 2019, 1:07 PM · Restricted Project
vsapsai added a comment to D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics.

Thanks for the insightful explanation, Craig. As far as I understand, implementing intrinsics with builtins is possible but it is more complex and wasn't providing enough value to prefer it over inline assembly. If that is correct, I'd like to revive the abandoned implementation. Does it sound reasonable? And do I need to do something special for testing? Because I don't have access to corresponding hardware and unable to test the intrinsics on the actual hardware.

Apr 30 2019, 12:09 PM

Apr 29 2019

vsapsai added a comment to D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics.

I see you've ended up implementing the intrinsics with inline assembly but are there any reasons not to do it with builtins like in this patch? The problem with inline assembly is that for some Apple platforms we require developers to emit bitcode. And inline assembly isn't really compatible with bitcode abstraction. Unfortunately, I have no experience with Intel intrinsics and I need your help in pursuing implementing them with builtins.

Apr 29 2019, 3:20 PM

Apr 23 2019

vsapsai added a comment to D60848: [Parser] Avoid correcting delayed typos in array subscript multiple times..

Wait, why is NumTypos incorrect here? I think its because we don't handle the typo on the line: [self undeclaredMethod:undeclaredArg];, even the following asserts now. Seems like the right fix would be to track down why we aren't handling the typo in the message expr.

// RUN: clang -cc1 %s -fobjc-arc
@implementation X
-x { [self undeclaredMethod:undeclaredArg]; }
@end
Apr 23 2019, 5:47 PM · Restricted Project

Apr 17 2019

vsapsai updated the summary of D60848: [Parser] Avoid correcting delayed typos in array subscript multiple times..
Apr 17 2019, 7:14 PM · Restricted Project
vsapsai created D60848: [Parser] Avoid correcting delayed typos in array subscript multiple times..
Apr 17 2019, 7:06 PM · Restricted Project

Apr 16 2019

vsapsai added a comment to D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..

Ping.

Apr 16 2019, 3:38 PM

Apr 1 2019

vsapsai added a comment to D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..

Ping.

Apr 1 2019, 5:25 PM

Mar 29 2019

vsapsai committed rG9e911f3a6476: [Sema] Fix assertion when `auto` parameter in lambda has an attribute. (authored by vsapsai).
[Sema] Fix assertion when `auto` parameter in lambda has an attribute.
Mar 29 2019, 11:46 AM
vsapsai committed rC357298: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..
[Sema] Fix assertion when `auto` parameter in lambda has an attribute.
Mar 29 2019, 11:45 AM
vsapsai committed rL357298: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..
[Sema] Fix assertion when `auto` parameter in lambda has an attribute.
Mar 29 2019, 11:45 AM
vsapsai closed D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..
Mar 29 2019, 11:45 AM · Restricted Project
vsapsai added a comment to D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..

Thanks for the review, Aaron.

Mar 29 2019, 11:44 AM · Restricted Project

Mar 11 2019

vsapsai added inline comments to D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..
Mar 11 2019, 1:05 PM · Restricted Project

Mar 4 2019

vsapsai added inline comments to D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..
Mar 4 2019, 7:40 PM · Restricted Project
vsapsai added a comment to D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..

Ping.

Mar 4 2019, 6:59 PM

Mar 1 2019

vsapsai committed rG738f697a19a7: [sanitizers] Fix build on macOS with LogFullErrorReport redefinition error. (authored by vsapsai).
[sanitizers] Fix build on macOS with LogFullErrorReport redefinition error.
Mar 1 2019, 4:05 PM
vsapsai committed rL355244: [sanitizers] Fix build on macOS with LogFullErrorReport redefinition error..
[sanitizers] Fix build on macOS with LogFullErrorReport redefinition error.
Mar 1 2019, 4:04 PM
vsapsai committed rCRT355244: [sanitizers] Fix build on macOS with LogFullErrorReport redefinition error..
[sanitizers] Fix build on macOS with LogFullErrorReport redefinition error.
Mar 1 2019, 4:04 PM

Feb 28 2019

vsapsai committed rG93317d82daf8: [CodeGen] Fix calling llvm.var.annotation outside of a basic block. (authored by vsapsai).
[CodeGen] Fix calling llvm.var.annotation outside of a basic block.
Feb 28 2019, 6:16 PM
vsapsai committed rC355166: [CodeGen] Fix calling llvm.var.annotation outside of a basic block..
[CodeGen] Fix calling llvm.var.annotation outside of a basic block.
Feb 28 2019, 6:16 PM
vsapsai committed rL355166: [CodeGen] Fix calling llvm.var.annotation outside of a basic block..
[CodeGen] Fix calling llvm.var.annotation outside of a basic block.
Feb 28 2019, 6:16 PM
vsapsai closed D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block..
Feb 28 2019, 6:16 PM · Restricted Project
vsapsai added a comment to D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block..

Thanks for the review.

Feb 28 2019, 6:16 PM · Restricted Project

Feb 26 2019

vsapsai committed rGbc72061edf42: [index] Fixup for r354942. Specify target in test to achieve stable mangling. (authored by vsapsai).
[index] Fixup for r354942. Specify target in test to achieve stable mangling.
Feb 26 2019, 5:39 PM
vsapsai committed rC354946: [index] Fixup for r354942. Specify target in test to achieve stable mangling..
[index] Fixup for r354942. Specify target in test to achieve stable mangling.
Feb 26 2019, 5:39 PM
vsapsai committed rL354946: [index] Fixup for r354942. Specify target in test to achieve stable mangling..
[index] Fixup for r354942. Specify target in test to achieve stable mangling.
Feb 26 2019, 5:39 PM
vsapsai committed rG4b0f7f99ce13: [index] Improve indexing support for MSPropertyDecl. (authored by vsapsai).
[index] Improve indexing support for MSPropertyDecl.
Feb 26 2019, 5:06 PM
vsapsai committed rC354942: [index] Improve indexing support for MSPropertyDecl..
[index] Improve indexing support for MSPropertyDecl.
Feb 26 2019, 5:05 PM
vsapsai committed rL354942: [index] Improve indexing support for MSPropertyDecl..
[index] Improve indexing support for MSPropertyDecl.
Feb 26 2019, 5:05 PM
vsapsai closed D57628: [index] Improve indexing support for MSPropertyDecl..
Feb 26 2019, 5:05 PM · Restricted Project
vsapsai added a comment to D57628: [index] Improve indexing support for MSPropertyDecl..

Thanks for reviewing the change!

Feb 26 2019, 5:05 PM · Restricted Project
vsapsai added a comment to D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block..

Okay. Is it acceptable for the annotation to simply disappear in this case? I don't really understand the purposes of annotations well enough to judge.

Feb 26 2019, 3:52 PM · Restricted Project
vsapsai added a comment to D57628: [index] Improve indexing support for MSPropertyDecl..

Ping.

Feb 26 2019, 11:35 AM · Restricted Project

Feb 25 2019

vsapsai added a reviewer for D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute.: aaron.ballman.
Feb 25 2019, 5:49 PM · Restricted Project
vsapsai added a comment to D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..

Have doubts that checking only the outermost type for being AttributedType after Sema::ReplaceAutoType is sufficient but haven't found a counterexample yet. Decided to post the proposed fix to see if others have any ideas.

Feb 25 2019, 5:46 PM · Restricted Project
vsapsai created D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute..
Feb 25 2019, 5:41 PM · Restricted Project

Feb 15 2019

vsapsai added a comment to D57075: [ObjC] For type substitution in generics use a regular recursive type visitor..

Thanks for the review, Erik.

Feb 15 2019, 5:02 PM · Restricted Project
vsapsai committed rGbcb4f7208dac: [ObjC generics] Fix applying `__kindof` to the type parameter. (authored by vsapsai).
[ObjC generics] Fix applying `__kindof` to the type parameter.
Feb 15 2019, 5:01 PM
vsapsai committed rL354189: [ObjC generics] Fix applying `__kindof` to the type parameter..
[ObjC generics] Fix applying `__kindof` to the type parameter.
Feb 15 2019, 5:01 PM
vsapsai committed rC354189: [ObjC generics] Fix applying `__kindof` to the type parameter..
[ObjC generics] Fix applying `__kindof` to the type parameter.
Feb 15 2019, 5:00 PM
vsapsai closed D57076: [ObjC generics] Fix applying `__kindof` to the type parameter..
Feb 15 2019, 5:00 PM · Restricted Project
vsapsai committed rG78b84cf99120: [ObjC] For type substitution in generics use a regular recursive type visitor. (authored by vsapsai).
[ObjC] For type substitution in generics use a regular recursive type visitor.
Feb 15 2019, 2:16 PM
vsapsai committed rL354180: [ObjC] For type substitution in generics use a regular recursive type visitor..
[ObjC] For type substitution in generics use a regular recursive type visitor.
Feb 15 2019, 2:14 PM
vsapsai committed rC354180: [ObjC] For type substitution in generics use a regular recursive type visitor..
[ObjC] For type substitution in generics use a regular recursive type visitor.
Feb 15 2019, 2:14 PM
vsapsai closed D57075: [ObjC] For type substitution in generics use a regular recursive type visitor..
Feb 15 2019, 2:14 PM · Restricted Project
vsapsai committed rG4b512c36b6ab: [ObjC] Fix non-canonical types preventing type arguments substitution. (authored by vsapsai).
[ObjC] Fix non-canonical types preventing type arguments substitution.
Feb 15 2019, 12:18 PM
vsapsai committed rC354164: [ObjC] Fix non-canonical types preventing type arguments substitution..
[ObjC] Fix non-canonical types preventing type arguments substitution.
Feb 15 2019, 12:17 PM
vsapsai committed rL354164: [ObjC] Fix non-canonical types preventing type arguments substitution..
[ObjC] Fix non-canonical types preventing type arguments substitution.
Feb 15 2019, 12:17 PM
vsapsai closed D57270: [ObjC] Fix non-canonical types preventing type arguments substitution..
Feb 15 2019, 12:17 PM · Restricted Project

Feb 14 2019

vsapsai committed rG78899aed7f1b: [Driver][Darwin] Emit an error when using -pg on OS without support for it. (authored by vsapsai).
[Driver][Darwin] Emit an error when using -pg on OS without support for it.
Feb 14 2019, 3:54 PM
vsapsai committed rC354084: [Driver][Darwin] Emit an error when using -pg on OS without support for it..
[Driver][Darwin] Emit an error when using -pg on OS without support for it.
Feb 14 2019, 3:54 PM
vsapsai committed rL354084: [Driver][Darwin] Emit an error when using -pg on OS without support for it..
[Driver][Darwin] Emit an error when using -pg on OS without support for it.
Feb 14 2019, 3:54 PM
vsapsai closed D57991: [Driver][Darwin] Emit an error when using -pg on OS without support for it..
Feb 14 2019, 3:54 PM · Restricted Project
vsapsai committed rG8b982cb8a90d: [clang-tidy] Mention language version in test explicitly. (authored by vsapsai).
[clang-tidy] Mention language version in test explicitly.
Feb 14 2019, 2:43 PM