vsapsai (Volodymyr Sapsai)
User

Projects

User does not belong to any projects.

User Details

User Since
May 27 2014, 6:39 AM (234 w, 1 d)

Recent Activity

Fri, Nov 16

vsapsai added a comment to D49736: [Basic] Emit warning flag suggestion only in case there's existing flag *similar* to the unknown one.

Have you considered the same approach as typo correction? I.e. for the max allowed edit distance use percentage of the input size. For example, something similar to TypoCorrectionConsumer::addName.

Fri, Nov 16, 1:30 PM

Thu, Nov 15

vsapsai committed rL347016: [VFS] Update unittest to fix Windows buildbot..
[VFS] Update unittest to fix Windows buildbot.
Thu, Nov 15, 6:23 PM
vsapsai committed rL347012: [VFS] Implement `RedirectingFileSystem::getRealPath`..
[VFS] Implement `RedirectingFileSystem::getRealPath`.
Thu, Nov 15, 5:21 PM
vsapsai committed rC347012: [VFS] Implement `RedirectingFileSystem::getRealPath`..
[VFS] Implement `RedirectingFileSystem::getRealPath`.
Thu, Nov 15, 5:21 PM
vsapsai committed rL347009: [VFS] Implement `RedirectingFileSystem::getRealPath`..
[VFS] Implement `RedirectingFileSystem::getRealPath`.
Thu, Nov 15, 5:18 PM
vsapsai closed D54245: [VFS] Implement `RedirectingFileSystem::getRealPath`..
Thu, Nov 15, 5:18 PM

Tue, Nov 13

vsapsai added a comment to D53522: [Frontend] Include module map header declaration in dependency file output.

The test case I've promised is

Tue, Nov 13, 12:06 PM
vsapsai added a comment to D54245: [VFS] Implement `RedirectingFileSystem::getRealPath`..

Ping.

Tue, Nov 13, 10:43 AM

Fri, Nov 9

vsapsai added inline comments to D53522: [Frontend] Include module map header declaration in dependency file output.
Fri, Nov 9, 7:38 PM
vsapsai added a comment to D54277: Extend VFS with function to get external path..

How do you want it to work with symlinks? Would getRealPath be sufficient for your purpose?

I'm not sure how those two are related, other than the confusing name. As far as I can tell this only wraps the realpath(3) call, which is definitely much too expensive to do in the "real" file system case. For symlinks I wouldn't really care, it's up to the user to resolve them if they matter.

Fri, Nov 9, 5:57 PM

Thu, Nov 8

vsapsai added a comment to D54277: Extend VFS with function to get external path..

How do you want it to work with symlinks? Would getRealPath be sufficient for your purpose?

Thu, Nov 8, 3:05 PM
vsapsai added a comment to D54245: [VFS] Implement `RedirectingFileSystem::getRealPath`..

Hi Volodymyr. Does this behavior changed after your VFS fallback change?

Thu, Nov 8, 12:18 PM

Wed, Nov 7

vsapsai added inline comments to D53522: [Frontend] Include module map header declaration in dependency file output.
Wed, Nov 7, 7:28 PM
vsapsai added inline comments to D53522: [Frontend] Include module map header declaration in dependency file output.
Wed, Nov 7, 6:33 PM
vsapsai created D54245: [VFS] Implement `RedirectingFileSystem::getRealPath`..
Wed, Nov 7, 5:21 PM
vsapsai added a comment to D54127: Extend virtual file system with `isLocal` method..

Depending on isLocal usage, it can be worth implementing it for RedirectingFileSystem.

Wed, Nov 7, 3:43 PM

Tue, Nov 6

vsapsai added a comment to D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971).

OK. Good to know you are still working on it.

Tue, Nov 6, 6:14 PM

Mon, Nov 5

vsapsai added a comment to D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971).

Sorry, you've decided to abandon the patch, it took a lot of good work. Xing, are you sure you don't want to see this change finished? I agree that delays in code review can be frustrating and I think it is something we can improve.

Mon, Nov 5, 7:22 PM
vsapsai committed rL346200: [CodeGenCXX] XFAIL test for ASAN on Darwin..
[CodeGenCXX] XFAIL test for ASAN on Darwin.
Mon, Nov 5, 6:19 PM
vsapsai committed rC346200: [CodeGenCXX] XFAIL test for ASAN on Darwin..
[CodeGenCXX] XFAIL test for ASAN on Darwin.
Mon, Nov 5, 6:18 PM
vsapsai closed D54132: [CodeGenCXX] XFAIL test for ASAN on Darwin..
Mon, Nov 5, 6:18 PM
vsapsai added inline comments to D54132: [CodeGenCXX] XFAIL test for ASAN on Darwin..
Mon, Nov 5, 6:07 PM
vsapsai added a comment to D50050: [AST] CastExpr: BasePathSize is not large enough..

Disabling test in D54132.

Mon, Nov 5, 5:49 PM
vsapsai created D54132: [CodeGenCXX] XFAIL test for ASAN on Darwin..
Mon, Nov 5, 5:49 PM

Thu, Nov 1

vsapsai committed rC345903: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC..
[CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC.
Thu, Nov 1, 3:52 PM
vsapsai committed rL345903: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC..
[CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC.
Thu, Nov 1, 3:52 PM
vsapsai closed D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC..
Thu, Nov 1, 3:52 PM
vsapsai added a comment to D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC..

Thanks for the review, John. I'll update the comment with TODO and commit.

Thu, Nov 1, 3:01 PM
vsapsai committed rC345897: [CodeGen] Move `emitConstant` from ScalarExprEmitter to CodeGenFunction. NFC..
[CodeGen] Move `emitConstant` from ScalarExprEmitter to CodeGenFunction. NFC.
Thu, Nov 1, 2:59 PM
vsapsai committed rL345897: [CodeGen] Move `emitConstant` from ScalarExprEmitter to CodeGenFunction. NFC..
[CodeGen] Move `emitConstant` from ScalarExprEmitter to CodeGenFunction. NFC.
Thu, Nov 1, 2:59 PM
vsapsai closed D53725: [CodeGen] Move `emitConstant` from ScalarExprEmitter to CodeGenFunction. NFC..
Thu, Nov 1, 2:59 PM

Wed, Oct 31

vsapsai added a comment to D53725: [CodeGen] Move `emitConstant` from ScalarExprEmitter to CodeGenFunction. NFC..

Can you please check https://reviews.llvm.org/D53674 ? It builds on top of this change and I plan to commit them together.

Wed, Oct 31, 4:42 PM
vsapsai updated the diff for D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC..

Exclude commits tracked in a different review.

Wed, Oct 31, 4:39 PM
vsapsai updated the diff for D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC..
  • Rename EmitConstant to emitScalarConstant.
  • Tweak comment to be explicitly about intended IR code, not about Obj-C++ code.
Wed, Oct 31, 4:36 PM
vsapsai updated the diff for D53725: [CodeGen] Move `emitConstant` from ScalarExprEmitter to CodeGenFunction. NFC..
  • Switch to camelCase.
Wed, Oct 31, 4:25 PM
vsapsai accepted D53465: [VFS] Add support for "no_push" to VFS recursive iterators..

Looks good to me.

Wed, Oct 31, 4:03 PM

Tue, Oct 30

vsapsai added a comment to D53725: [CodeGen] Move `emitConstant` from ScalarExprEmitter to CodeGenFunction. NFC..

This should at least be named emitScalarConstant.

Tue, Oct 30, 11:50 AM
vsapsai updated the diff for D53725: [CodeGen] Move `emitConstant` from ScalarExprEmitter to CodeGenFunction. NFC..
  • Rename EmitConstant to EmitScalarConstant.
Tue, Oct 30, 11:48 AM

Mon, Oct 29

vsapsai added a comment to D53465: [VFS] Add support for "no_push" to VFS recursive iterators..

I am gravitating towards having a separate unit test(s) for no_push functionality. Maybe I'm wrong but I expect it to be smaller and easier to understand, though there'll be some boilerplate.

Mon, Oct 29, 4:19 PM

Fri, Oct 26

vsapsai committed rL345432: [VFS] Add property 'fallthrough' that controls fallback to real file system..
[VFS] Add property 'fallthrough' that controls fallback to real file system.
Fri, Oct 26, 3:18 PM
vsapsai committed rC345432: [VFS] Add property 'fallthrough' that controls fallback to real file system..
[VFS] Add property 'fallthrough' that controls fallback to real file system.
Fri, Oct 26, 3:18 PM
vsapsai committed rL345431: [VFS] Add property 'fallthrough' that controls fallback to real file system..
[VFS] Add property 'fallthrough' that controls fallback to real file system.
Fri, Oct 26, 3:16 PM
vsapsai closed D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system..
Fri, Oct 26, 3:16 PM

Thu, Oct 25

vsapsai updated the diff for D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system..
  • Rebase once again.
  • Use Doxygen comments in some places.
Thu, Oct 25, 3:51 PM
vsapsai added a comment to D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system..

I was using // instead of /// on purpose. Class VFSFromYamlDirIterImpl resides entirely in .cpp file and isn't available outside of it. Comments are supposed to cover implementation details and intention, not class interface. That's why I think those comments shouldn't be consumed by Doxygen. Does it make sense or do you think it would be better to have those comments in Doxygen?

IMO we should have the doxygen comments for any developer that's trying to expand/use/understand the impl class. In my experience the main reasons we stuff things in .cpp files are to optimize compile time and to enable better optimizations within a TU.

Thu, Oct 25, 2:32 PM
vsapsai added inline comments to D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC..
Thu, Oct 25, 12:35 PM
vsapsai added a dependency for D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC.: D53725: [CodeGen] Move `emitConstant` from ScalarExprEmitter to CodeGenFunction. NFC..
Thu, Oct 25, 12:31 PM
vsapsai added a dependent revision for D53725: [CodeGen] Move `emitConstant` from ScalarExprEmitter to CodeGenFunction. NFC.: D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC..
Thu, Oct 25, 12:31 PM
vsapsai created D53725: [CodeGen] Move `emitConstant` from ScalarExprEmitter to CodeGenFunction. NFC..
Thu, Oct 25, 12:30 PM
vsapsai updated the diff for D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC..
  • Address review comments.
Thu, Oct 25, 12:28 PM
vsapsai added inline comments to D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC..
Thu, Oct 25, 11:02 AM

Wed, Oct 24

vsapsai added a comment to D53228: [VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS..

Thanks for the review.

Wed, Oct 24, 3:43 PM
vsapsai committed rL345213: [VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS..
[VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS.
Wed, Oct 24, 3:43 PM
vsapsai committed rL345212: [VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS..
[VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS.
Wed, Oct 24, 3:41 PM
vsapsai committed rC345212: [VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS..
[VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS.
Wed, Oct 24, 3:41 PM
vsapsai closed D53228: [VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS..
Wed, Oct 24, 3:41 PM
vsapsai created D53674: [CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC..
Wed, Oct 24, 2:43 PM

Tue, Oct 23

vsapsai added a comment to D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system..

LGTM with some minor changes.

Tue, Oct 23, 5:59 PM
vsapsai added inline comments to D53522: [Frontend] Include module map header declaration in dependency file output.
Tue, Oct 23, 2:48 PM
vsapsai added a comment to D53522: [Frontend] Include module map header declaration in dependency file output.

Have a few comments but didn't try to come up with edge cases yet.

Tue, Oct 23, 12:33 PM

Oct 16 2018

vsapsai added a comment to D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971).

Sorry about the delay. The change seems to be correct but ninja check-clang reveals the test "Misc/caret-diags-macros.c" is failing. Can you please look into that?

Oct 16 2018, 12:39 PM
vsapsai added a comment to D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system..
  • Current way of working with modules in VFS "root" is clunky and error-prone.

Why?

Oct 16 2018, 10:43 AM
vsapsai added inline comments to D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system..
Oct 16 2018, 10:39 AM
vsapsai updated the diff for D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system..
  • Rebase on top of the latest changes in trunk.
  • Address review comments.
Oct 16 2018, 10:21 AM

Oct 12 2018

vsapsai created D53228: [VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS..
Oct 12 2018, 4:39 PM

Sep 21 2018

vsapsai added a comment to D51867: [Diagnostics] Add error handling to FormatDiagnostic().

It seems like there are too many asserts and they are too specific, they seem to be aimed at specific potential bugs. What about asserts that make sure we maintain some invariants? For example, check DiagStr < DiagEnd once in a loop instead of every place we increment DiagStr. Do you think it should catch the same problems but maybe a little bit later?

Sep 21 2018, 6:35 PM · Restricted Project

Sep 20 2018

vsapsai added a comment to D52278: Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin..

Thanks for review.

Sep 20 2018, 11:52 AM
vsapsai committed rT342676: Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin..
Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin.
Sep 20 2018, 11:47 AM
vsapsai added a comment to D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system..

Ping.

Sep 20 2018, 11:47 AM
vsapsai committed rL342676: Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin..
Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin.
Sep 20 2018, 11:45 AM
vsapsai closed D52278: Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin..
Sep 20 2018, 11:45 AM

Sep 19 2018

vsapsai added a comment to D51606: [XRay] Remove the deprecated __xray_log_init API.

The repro is

Sep 19 2018, 5:34 PM
vsapsai added a comment to D44263: Implement LWG 2221 - No formatted output operator for nullptr.

Reverted in r342599.

Sep 19 2018, 4:36 PM
vsapsai committed rCXX342599: Revert "Implement LWG 2221 - No formatted output operator for nullptr.".
Revert "Implement LWG 2221 - No formatted output operator for nullptr."
Sep 19 2018, 4:33 PM
vsapsai committed rL342599: Revert "Implement LWG 2221 - No formatted output operator for nullptr.".
Revert "Implement LWG 2221 - No formatted output operator for nullptr."
Sep 19 2018, 4:33 PM
vsapsai added a comment to D44263: Implement LWG 2221 - No formatted output operator for nullptr.

Seems like revert didn't go through. I suspect it is causing build failure in http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/49593/consoleText

Sep 19 2018, 3:41 PM
vsapsai added a comment to D51606: [XRay] Remove the deprecated __xray_log_init API.

I have published D52278 for disabling the test on Darwin. So far my investigation shows that __xray_log_select_mode("xray-fdr") returns 2 (aka XRAY_MODE_NOT_FOUND) and that's why we are calling std::abort.

Sep 19 2018, 2:23 PM
vsapsai created D52278: Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin..
Sep 19 2018, 2:08 PM

Sep 18 2018

vsapsai committed rC342517: Add a callback for `__has_include` and use it for dependency scanning..
Add a callback for `__has_include` and use it for dependency scanning.
Sep 18 2018, 4:28 PM
vsapsai committed rL342517: Add a callback for `__has_include` and use it for dependency scanning..
Add a callback for `__has_include` and use it for dependency scanning.
Sep 18 2018, 4:28 PM
vsapsai closed D30882: Add a callback for __has_include and use it for dependency scanning.
Sep 18 2018, 4:28 PM
vsapsai added a comment to D51606: [XRay] Remove the deprecated __xray_log_init API.

test-suite should be fixed by r342426.

Sep 18 2018, 3:10 PM
vsapsai added a comment to D52191: Fix logic around determining use of frame pointer with -pg..

Thanks for the fix.

Sep 18 2018, 2:33 PM
vsapsai added a comment to D52191: Fix logic around determining use of frame pointer with -pg..

Confirm that reverting the change locally fixes the tests. If nobody beats me to it, I plan to revert the change in 30-60 minutes. @srhines, if you want to fix it in another way and need more time, please let me know.

Sep 18 2018, 1:10 PM
vsapsai added a comment to D52191: Fix logic around determining use of frame pointer with -pg..

Seems like this change causes 2 test failures:

Sep 18 2018, 12:56 PM

Sep 17 2018

vsapsai committed rL342431: Revert "[ARM] Cleanup ARM CGP isSupportedValue".
Revert "[ARM] Cleanup ARM CGP isSupportedValue"
Sep 17 2018, 5:13 PM
vsapsai added a comment to D52080: [ARM] Cleanup ARM CGP isSupportedValue.

I've reduced the input causing error to

Sep 17 2018, 5:03 PM
vsapsai added a comment to D51606: [XRay] Remove the deprecated __xray_log_init API.

Who is responsible for updating the clients? Currently in the test suite MicroBenchmarks/XRay/FDRMode/fdrmode-bench.cc is failing to compile because it is using __xray::FDRLoggingOptions.

Sep 17 2018, 4:08 PM
vsapsai added a comment to D30882: Add a callback for __has_include and use it for dependency scanning.

@dexonsmith, does my change address your concerns?

Sep 17 2018, 2:58 PM
vsapsai added a comment to D52080: [ARM] Cleanup ARM CGP isSupportedValue.

Looks like this changed causes errors in backend in stage 2 on Apple platforms

Sep 17 2018, 2:44 PM

Sep 14 2018

vsapsai added inline comments to D30882: Add a callback for __has_include and use it for dependency scanning.
Sep 14 2018, 5:15 PM
vsapsai added inline comments to D30882: Add a callback for __has_include and use it for dependency scanning.
Sep 14 2018, 4:29 PM
vsapsai added inline comments to D30882: Add a callback for __has_include and use it for dependency scanning.
Sep 14 2018, 4:20 PM
vsapsai updated the diff for D30882: Add a callback for __has_include and use it for dependency scanning.
  • Improve tests, fix -MMD, address comments.
Sep 14 2018, 4:07 PM
vsapsai commandeered D30882: Add a callback for __has_include and use it for dependency scanning.

Taking over the change, I'll address the reviewers' comments.

Sep 14 2018, 4:04 PM

Sep 13 2018

vsapsai committed rL342169: Revert "[cmake] Fix a unittest when `LLVM_LINK_LLVM_DYLIB` is requested.".
Revert "[cmake] Fix a unittest when `LLVM_LINK_LLVM_DYLIB` is requested."
Sep 13 2018, 1:25 PM

Sep 10 2018

vsapsai added a comment to D50462: Try building complete AST after a fatal error was emitted if further diagnostics are expected.

Agree that fatal/non-fatal error is too coarse and tooling/IDEs need more details and more control to provide better experience. But I don't think we are in a state to claim that all errors are recoverable (in theory and in current implementation). Instead of continuing on all errors, I prefer to select errors that are important for tooling and improve those first.

Sep 10 2018, 2:05 PM
vsapsai added a comment to D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system..

Rebased on top of trunk and checked that this is still working. Please take a look.

Sep 10 2018, 12:12 PM
vsapsai abandoned D50032: [VFS] Add property 'fallthrough' that controls fallback to real file system..

Draft is abandoned in favor of D50539.

Sep 10 2018, 12:11 PM
vsapsai added a comment to D51867: [Diagnostics] Add error handling to FormatDiagnostic().

Regarding the asserts to catch potential problems, seems most of them are for buffer overflows. Aren't sanitizers catching those cases, specifically Address Sanitizer? I haven't checked, just seems it would be good to check buffer overflow automatically instead of using explicit asserts.

Sep 10 2018, 10:50 AM · Restricted Project