vsapsai (Volodymyr Sapsai)
User

Projects

User does not belong to any projects.

User Details

User Since
May 27 2014, 6:39 AM (226 w, 1 d)

Recent Activity

Fri, Sep 21

vsapsai added a comment to D51867: [Diagnostics] Add error handling to FormatDiagnostic().

It seems like there are too many asserts and they are too specific, they seem to be aimed at specific potential bugs. What about asserts that make sure we maintain some invariants? For example, check DiagStr < DiagEnd once in a loop instead of every place we increment DiagStr. Do you think it should catch the same problems but maybe a little bit later?

Fri, Sep 21, 6:35 PM · Restricted Project

Thu, Sep 20

vsapsai added a comment to D52278: Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin..

Thanks for review.

Thu, Sep 20, 11:52 AM
vsapsai committed rT342676: Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin..
Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin.
Thu, Sep 20, 11:47 AM
vsapsai added a comment to D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system..

Ping.

Thu, Sep 20, 11:47 AM
vsapsai committed rL342676: Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin..
Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin.
Thu, Sep 20, 11:45 AM
vsapsai closed D52278: Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin..
Thu, Sep 20, 11:45 AM

Wed, Sep 19

vsapsai added a comment to D51606: [XRay] Remove the deprecated __xray_log_init API.

The repro is

Wed, Sep 19, 5:34 PM
vsapsai added a comment to D44263: Implement LWG 2221 - No formatted output operator for nullptr.

Reverted in r342599.

Wed, Sep 19, 4:36 PM
vsapsai committed rCXX342599: Revert "Implement LWG 2221 - No formatted output operator for nullptr.".
Revert "Implement LWG 2221 - No formatted output operator for nullptr."
Wed, Sep 19, 4:33 PM
vsapsai committed rL342599: Revert "Implement LWG 2221 - No formatted output operator for nullptr.".
Revert "Implement LWG 2221 - No formatted output operator for nullptr."
Wed, Sep 19, 4:33 PM
vsapsai added a comment to D44263: Implement LWG 2221 - No formatted output operator for nullptr.

Seems like revert didn't go through. I suspect it is causing build failure in http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/49593/consoleText

Wed, Sep 19, 3:41 PM
vsapsai added a comment to D51606: [XRay] Remove the deprecated __xray_log_init API.

I have published D52278 for disabling the test on Darwin. So far my investigation shows that __xray_log_select_mode("xray-fdr") returns 2 (aka XRAY_MODE_NOT_FOUND) and that's why we are calling std::abort.

Wed, Sep 19, 2:23 PM
vsapsai created D52278: Disable test MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test on Darwin..
Wed, Sep 19, 2:08 PM

Tue, Sep 18

vsapsai committed rC342517: Add a callback for `__has_include` and use it for dependency scanning..
Add a callback for `__has_include` and use it for dependency scanning.
Tue, Sep 18, 4:28 PM
vsapsai committed rL342517: Add a callback for `__has_include` and use it for dependency scanning..
Add a callback for `__has_include` and use it for dependency scanning.
Tue, Sep 18, 4:28 PM
vsapsai closed D30882: Add a callback for __has_include and use it for dependency scanning.
Tue, Sep 18, 4:28 PM
vsapsai added a comment to D51606: [XRay] Remove the deprecated __xray_log_init API.

test-suite should be fixed by r342426.

Tue, Sep 18, 3:10 PM
vsapsai added a comment to D52191: Fix logic around determining use of frame pointer with -pg..

Thanks for the fix.

Tue, Sep 18, 2:33 PM
vsapsai added a comment to D52191: Fix logic around determining use of frame pointer with -pg..

Confirm that reverting the change locally fixes the tests. If nobody beats me to it, I plan to revert the change in 30-60 minutes. @srhines, if you want to fix it in another way and need more time, please let me know.

Tue, Sep 18, 1:10 PM
vsapsai added a comment to D52191: Fix logic around determining use of frame pointer with -pg..

Seems like this change causes 2 test failures:

Tue, Sep 18, 12:56 PM

Mon, Sep 17

vsapsai committed rL342431: Revert "[ARM] Cleanup ARM CGP isSupportedValue".
Revert "[ARM] Cleanup ARM CGP isSupportedValue"
Mon, Sep 17, 5:13 PM
vsapsai added a comment to D52080: [ARM] Cleanup ARM CGP isSupportedValue.

I've reduced the input causing error to

Mon, Sep 17, 5:03 PM
vsapsai added a comment to D51606: [XRay] Remove the deprecated __xray_log_init API.

Who is responsible for updating the clients? Currently in the test suite MicroBenchmarks/XRay/FDRMode/fdrmode-bench.cc is failing to compile because it is using __xray::FDRLoggingOptions.

Mon, Sep 17, 4:08 PM
vsapsai added a comment to D30882: Add a callback for __has_include and use it for dependency scanning.

@dexonsmith, does my change address your concerns?

Mon, Sep 17, 2:58 PM
vsapsai added a comment to D52080: [ARM] Cleanup ARM CGP isSupportedValue.

Looks like this changed causes errors in backend in stage 2 on Apple platforms

Mon, Sep 17, 2:44 PM

Fri, Sep 14

vsapsai added inline comments to D30882: Add a callback for __has_include and use it for dependency scanning.
Fri, Sep 14, 5:15 PM
vsapsai added inline comments to D30882: Add a callback for __has_include and use it for dependency scanning.
Fri, Sep 14, 4:29 PM
vsapsai added inline comments to D30882: Add a callback for __has_include and use it for dependency scanning.
Fri, Sep 14, 4:20 PM
vsapsai updated the diff for D30882: Add a callback for __has_include and use it for dependency scanning.
  • Improve tests, fix -MMD, address comments.
Fri, Sep 14, 4:07 PM
vsapsai commandeered D30882: Add a callback for __has_include and use it for dependency scanning.

Taking over the change, I'll address the reviewers' comments.

Fri, Sep 14, 4:04 PM

Thu, Sep 13

vsapsai committed rL342169: Revert "[cmake] Fix a unittest when `LLVM_LINK_LLVM_DYLIB` is requested.".
Revert "[cmake] Fix a unittest when `LLVM_LINK_LLVM_DYLIB` is requested."
Thu, Sep 13, 1:25 PM

Mon, Sep 10

vsapsai added a comment to D50462: Try building complete AST after a fatal error was emitted if further diagnostics are expected.

Agree that fatal/non-fatal error is too coarse and tooling/IDEs need more details and more control to provide better experience. But I don't think we are in a state to claim that all errors are recoverable (in theory and in current implementation). Instead of continuing on all errors, I prefer to select errors that are important for tooling and improve those first.

Mon, Sep 10, 2:05 PM
vsapsai added a comment to D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system..

Rebased on top of trunk and checked that this is still working. Please take a look.

Mon, Sep 10, 12:12 PM
vsapsai abandoned D50032: [VFS] Add property 'fallthrough' that controls fallback to real file system..

Draft is abandoned in favor of D50539.

Mon, Sep 10, 12:11 PM
vsapsai added a comment to D51867: [Diagnostics] Add error handling to FormatDiagnostic().

Regarding the asserts to catch potential problems, seems most of them are for buffer overflows. Aren't sanitizers catching those cases, specifically Address Sanitizer? I haven't checked, just seems it would be good to check buffer overflow automatically instead of using explicit asserts.

Mon, Sep 10, 10:50 AM · Restricted Project

Aug 20 2018

vsapsai added a comment to D50462: Try building complete AST after a fatal error was emitted if further diagnostics are expected.

Thanks, Dmitry, for your explanation. It does help to understand your use case better.

Aug 20 2018, 11:28 AM

Aug 17 2018

vsapsai committed rL340107: [LNT] In command-line tool allow to use relative path for test suite location..
[LNT] In command-line tool allow to use relative path for test suite location.
Aug 17 2018, 3:47 PM
vsapsai closed D50916: [LNT] In command-line tool allow to use relative path for test suite location..
Aug 17 2018, 3:47 PM
vsapsai added a comment to D50915: [LNT] In command-line tool expand tilde when resolving commands..

Thanks for review, Chris.

Aug 17 2018, 3:40 PM
vsapsai committed rL340106: [LNT] In command-line tool expand tilde when resolving commands..
[LNT] In command-line tool expand tilde when resolving commands.
Aug 17 2018, 3:39 PM
vsapsai closed D50915: [LNT] In command-line tool expand tilde when resolving commands..
Aug 17 2018, 3:39 PM
vsapsai created D50916: [LNT] In command-line tool allow to use relative path for test suite location..
Aug 17 2018, 12:37 PM
vsapsai created D50915: [LNT] In command-line tool expand tilde when resolving commands..
Aug 17 2018, 12:27 PM

Aug 16 2018

vsapsai committed rL339956: Fix a link to Bugzilla in documentation..
Fix a link to Bugzilla in documentation.
Aug 16 2018, 3:27 PM
vsapsai added a comment to D50462: Try building complete AST after a fatal error was emitted if further diagnostics are expected.

Have you checked that produced AST is of sufficient quality to be used? Because, for example, for invalid code error recovery tries to keep going but the end result isn't always good.

Aug 16 2018, 1:14 PM

Aug 14 2018

vsapsai accepted D50341: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions.

I don't have any other comments. Looks good to me.

Aug 14 2018, 4:16 PM

Aug 13 2018

vsapsai added a comment to D50341: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions.

What about defining a feature for unsupported configurations? I've tried

Aug 13 2018, 7:06 PM

Aug 10 2018

vsapsai added a comment to D50543: [libcxx] Mark charconv tests as failing for previous libcxx versions..

Thanks for the review.

Aug 10 2018, 10:21 AM
vsapsai committed rCXX339451: [libcxx] Mark charconv tests as failing for previous libcxx versions..
[libcxx] Mark charconv tests as failing for previous libcxx versions.
Aug 10 2018, 10:04 AM
vsapsai committed rL339451: [libcxx] Mark charconv tests as failing for previous libcxx versions..
[libcxx] Mark charconv tests as failing for previous libcxx versions.
Aug 10 2018, 10:04 AM
vsapsai closed D50543: [libcxx] Mark charconv tests as failing for previous libcxx versions..
Aug 10 2018, 10:04 AM

Aug 9 2018

vsapsai created D50543: [libcxx] Mark charconv tests as failing for previous libcxx versions..
Aug 9 2018, 5:49 PM
vsapsai added a comment to D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system..

Known issues:

  • No support for 'fallthrough' in crash reproducer.
  • Current way of working with modules in VFS "root" is clunky and error-prone.
Aug 9 2018, 4:05 PM
vsapsai created D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system..
Aug 9 2018, 4:00 PM
vsapsai accepted D50344: [libc++] Enable aligned allocation based on feature test macro, irrespective of standard.
Aug 9 2018, 11:54 AM

Aug 7 2018

vsapsai committed rC339215: [NFC][VFS] Fix typos in comments..
[NFC][VFS] Fix typos in comments.
Aug 7 2018, 6:29 PM
vsapsai committed rL339215: [NFC][VFS] Fix typos in comments..
[NFC][VFS] Fix typos in comments.
Aug 7 2018, 6:29 PM
vsapsai committed rL339199: [VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended..
[VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended.
Aug 7 2018, 4:01 PM
vsapsai committed rC339199: [VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended..
[VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended.
Aug 7 2018, 4:01 PM
vsapsai closed D50118: [VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended..
Aug 7 2018, 4:01 PM
vsapsai added inline comments to D50341: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions.
Aug 7 2018, 3:35 PM
vsapsai added inline comments to D50344: [libc++] Enable aligned allocation based on feature test macro, irrespective of standard.
Aug 7 2018, 3:28 PM
vsapsai added a comment to D49518: [VFS] Emit an error when a file isn't located in any directory..

Thanks for the review, Bruno.

Aug 7 2018, 12:07 PM
vsapsai committed rL339164: [VFS] Emit an error when entry at root level uses a relative path..
[VFS] Emit an error when entry at root level uses a relative path.
Aug 7 2018, 12:06 PM
vsapsai committed rC339164: [VFS] Emit an error when entry at root level uses a relative path..
[VFS] Emit an error when entry at root level uses a relative path.
Aug 7 2018, 12:06 PM
vsapsai closed D49518: [VFS] Emit an error when a file isn't located in any directory..
Aug 7 2018, 12:06 PM

Aug 3 2018

vsapsai added a comment to D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable..

Hi, I'm in the process of moving cities. please take over.

Thanks, and sorry

Aug 3 2018, 4:18 PM
vsapsai committed rC338934: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable..
[Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.
Aug 3 2018, 4:13 PM
vsapsai committed rL338934: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable..
[Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.
Aug 3 2018, 4:13 PM
vsapsai closed D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable..
Aug 3 2018, 4:13 PM
vsapsai added a comment to D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable..

Eric, will you have time to commit this patch? If you don't have time and don't have objections, I plan to land this change on your behalf.

Aug 3 2018, 3:02 PM

Aug 2 2018

vsapsai added a comment to D50160: [c-index-test] Use correct executable path to discover resource directory..

Thanks for the review!

Aug 2 2018, 10:30 AM
vsapsai committed rC338741: [c-index-test] Use correct executable path to discover resource directory..
[c-index-test] Use correct executable path to discover resource directory.
Aug 2 2018, 10:30 AM
vsapsai committed rL338741: [c-index-test] Use correct executable path to discover resource directory..
[c-index-test] Use correct executable path to discover resource directory.
Aug 2 2018, 10:30 AM
vsapsai closed D50160: [c-index-test] Use correct executable path to discover resource directory..
Aug 2 2018, 10:30 AM

Aug 1 2018

vsapsai added inline comments to D50160: [c-index-test] Use correct executable path to discover resource directory..
Aug 1 2018, 4:18 PM
vsapsai updated the diff for D50160: [c-index-test] Use correct executable path to discover resource directory..
  • Address review comment: move getMainExecutable to indextest_core_main.
Aug 1 2018, 4:16 PM
vsapsai created D50160: [c-index-test] Use correct executable path to discover resource directory..
Aug 1 2018, 2:45 PM

Jul 31 2018

vsapsai created D50118: [VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended..
Jul 31 2018, 4:43 PM

Jul 27 2018

vsapsai accepted D49119: [Sema][ObjC] Issue a warning when a method declared in a protocol is non-escaping but the corresponding method in the implementation is escaping..

Looks good to me. Any further improvements are up to you.

Jul 27 2018, 3:18 PM · Restricted Project

Jul 25 2018

vsapsai added a comment to D49119: [Sema][ObjC] Issue a warning when a method declared in a protocol is non-escaping but the corresponding method in the implementation is escaping..

Also I had a few ideas for tests when the warning isn't required and it is absent. But I'm not sure they are actually valuable. If you are interested, we can discuss it in more details.

Could you elaborate on what kind of tests you have in mind?

Jul 25 2018, 5:59 PM · Restricted Project
vsapsai added a comment to D48753: [libcxx] Use custom allocator's `construct` in C++03 when available..

Ping.

Jul 25 2018, 12:23 PM
vsapsai committed rC337953: [Preprocessor] Stop entering included files after hitting a fatal error..
[Preprocessor] Stop entering included files after hitting a fatal error.
Jul 25 2018, 12:16 PM
vsapsai committed rL337953: [Preprocessor] Stop entering included files after hitting a fatal error..
[Preprocessor] Stop entering included files after hitting a fatal error.
Jul 25 2018, 12:16 PM
vsapsai added a comment to D48786: [Preprocessor] Stop entering included files after hitting a fatal error..

Thanks everyone for reviewing the change.

Jul 25 2018, 12:16 PM
vsapsai closed D48786: [Preprocessor] Stop entering included files after hitting a fatal error..
Jul 25 2018, 12:16 PM
vsapsai updated the diff for D49518: [VFS] Emit an error when a file isn't located in any directory..
  • Make diagnostics more general, use unit tests.
Jul 25 2018, 11:04 AM

Jul 24 2018

vsapsai added a comment to D49518: [VFS] Emit an error when a file isn't located in any directory..

Hi Volodymyr, thanks for improving this.

Need to double check what tests we have when using relative path names at the root level.

Another interesting place to look at is unittests/Basic/VirtualFileSystemTest.cpp

Thanks for the pointer. Probably I'll move the added test there as it doesn't need full file system interaction and doesn't need to execute entire clang_cc1.

Jul 24 2018, 6:02 PM

Jul 23 2018

vsapsai updated the diff for D48786: [Preprocessor] Stop entering included files after hitting a fatal error..
  • Tweak the comment according to review comments.
Jul 23 2018, 4:02 PM
vsapsai added inline comments to D48786: [Preprocessor] Stop entering included files after hitting a fatal error..
Jul 23 2018, 3:39 PM

Jul 18 2018

vsapsai added a comment to D49518: [VFS] Emit an error when a file isn't located in any directory..

Need to double check what tests we have when using relative path names at the root level. I'd like to make the behavior consistent because a file name is a specific case of relative paths. So far there are no assertions and no errors but file lookup doesn't seem to be working.

Jul 18 2018, 6:59 PM
vsapsai added inline comments to D49518: [VFS] Emit an error when a file isn't located in any directory..
Jul 18 2018, 4:27 PM
vsapsai created D49518: [VFS] Emit an error when a file isn't located in any directory..
Jul 18 2018, 4:26 PM
vsapsai added inline comments to D48786: [Preprocessor] Stop entering included files after hitting a fatal error..
Jul 18 2018, 4:14 PM

Jul 17 2018

vsapsai added inline comments to D49317: Move __construct_forward (etc.) out of std::allocator_traits..
Jul 17 2018, 11:18 AM

Jul 16 2018

vsapsai added a comment to D49317: Move __construct_forward (etc.) out of std::allocator_traits..

My review is incomplete, especially I cannot say with confidence if the proposed change is entirely free from unintended consequences that might break code not covered by the test suite. So other reviewers are welcome to chime in.

Jul 16 2018, 5:26 PM
vsapsai added a comment to D48786: [Preprocessor] Stop entering included files after hitting a fatal error..

Ping.

Jul 16 2018, 4:01 PM
vsapsai added a comment to D49119: [Sema][ObjC] Issue a warning when a method declared in a protocol is non-escaping but the corresponding method in the implementation is escaping..

Overall looks good to me. Maybe add a test when a protocol is declared for an interface, not for a category. Something like

Jul 16 2018, 2:57 PM · Restricted Project

Jul 10 2018

vsapsai updated the diff for D48753: [libcxx] Use custom allocator's `construct` in C++03 when available..
  • In C++03 call allocator's destroy when available.
  • Rename _Args as it's not a variadic template pack.
Jul 10 2018, 6:02 PM
vsapsai added a comment to D48753: [libcxx] Use custom allocator's `construct` in C++03 when available..

Why are we doing this?

I can't find the language in the C++03 specification that requires us to call an allocators construct method if it's present.

I think it's being proposed under "quality of implementation."

It has only just now occurred to me: a quality implementation should probably never mismatch calls to construct and destroy. Does libc++ currently call destroy in C++03? Does it call destroy in C++03 after this patch? If this patch is making libc++ call construct but not destroy, that's a bug. If before this patch libc++ would call destroy but not construct, this patch is a bugfix! (And please add a test case for matched pairs of construct and destroy.)

Jul 10 2018, 3:47 PM