Page MenuHomePhabricator

vsapsai (Volodymyr Sapsai)
User

Projects

User does not belong to any projects.

User Details

User Since
May 27 2014, 6:39 AM (294 w, 6 d)

Recent Activity

Fri, Jan 17

vsapsai updated subscribers of D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions..
Fri, Jan 17, 12:47 PM · Restricted Project

Thu, Jan 16

vsapsai added a reverting change for rG0a2be46cfdb6: Modules: Invalidate out-of-date PCMs as they're discovered: rG83f4c3af021c: [modules] Do not cache invalid state for modules that we attempted to load..
Thu, Jan 16, 5:20 PM
vsapsai committed rG83f4c3af021c: [modules] Do not cache invalid state for modules that we attempted to load. (authored by vsapsai).
[modules] Do not cache invalid state for modules that we attempted to load.
Thu, Jan 16, 5:20 PM
vsapsai closed D72860: [modules] Do not cache invalid state for modules that we attempted to load..
Thu, Jan 16, 5:19 PM · Restricted Project
vsapsai created D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions..
Thu, Jan 16, 1:26 PM · Restricted Project
vsapsai added a comment to D72860: [modules] Do not cache invalid state for modules that we attempted to load..

Anecdotal build time measurements before and after the change. First row is a clean build, subsequent rows are incremental builds.

Thu, Jan 16, 12:18 PM · Restricted Project
vsapsai created D72860: [modules] Do not cache invalid state for modules that we attempted to load..
Thu, Jan 16, 11:58 AM · Restricted Project

Mon, Jan 13

vsapsai added a comment to D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.

Think I'll need to make another review pass but here are my comments so far:

  • Why are you adding ODR hash support for RecordDecl and not TagDecl? We already have support for EnumDecl, so TagDecl seems like a good candidate to cover both. Honestly, I don't know if it is possible or a good idea but it looks plausible enough to consider.
  • Are anonymous structs working? Worth adding test cases.
  • Are unions working? Didn't notice any code specifically for them but RecordDecl covers both structs and unions, so they should be working and we need to test that.
  • Few testing additions. These cases might be already covered or might be low value, so take these suggestions with a grain of salt:
    • test self-referential structs like struct Node { struct Node *next; };
    • test comparing structs and forward declarations, e.g., struct S; and struct S { ... };, and another couple struct S { ... }; and struct S; struct S { ... }; The motivation is to make sure we aren't stumped when we cannot find struct definition or when the definition is in unexpected place.
Mon, Jan 13, 4:03 PM · Restricted Project

Dec 12 2019

vsapsai abandoned D69817: Fix OrcError build with modules enabled..

The bot is green now.

Dec 12 2019, 3:58 PM · Restricted Project
vsapsai committed rG011e40489d96: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by vsapsai).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 2:58 PM
vsapsai committed rGa6f2bf7f12a7: [CrashReproducer] Upstream a test for -index-store-path support. (authored by vsapsai).
[CrashReproducer] Upstream a test for -index-store-path support.
Dec 12 2019, 2:34 PM
vsapsai committed rG56b1cf621a6a: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by vsapsai).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 1:05 PM
vsapsai committed rGd8be0c1637a3: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by vsapsai).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 1:03 PM
vsapsai committed rGe348b5c8d625: [ObjC generics] Remove `__kindof` tests depending on reverted c7c63c5. (authored by vsapsai).
[ObjC generics] Remove `__kindof` tests depending on reverted c7c63c5.
Dec 12 2019, 1:02 PM
vsapsai committed rG0176f64c13b0: [ObjC] Fix SubstObjCTypeArgsVisitor for TypedefType. (authored by vsapsai).
[ObjC] Fix SubstObjCTypeArgsVisitor for TypedefType.
Dec 12 2019, 1:02 PM
vsapsai committed rGffb6bec7d510: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by vsapsai).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 1:01 PM
vsapsai committed rG99419ecd0546: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by vsapsai).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 1:01 PM
vsapsai committed rG18f6bc75ed0e: Fixup for r347141 after BuryPointer was moved from Clang to LLVM. (authored by vsapsai).
Fixup for r347141 after BuryPointer was moved from Clang to LLVM.
Dec 12 2019, 12:03 PM
vsapsai committed rGfaf92f6a10cc: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by vsapsai).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Dec 12 2019, 12:03 PM

Dec 3 2019

vsapsai accepted D70024: [compiler-rt] Disable fuzzer large.test when LLVM_ENABLE_EXPENSIVE_CHECKS=ON..

Looks good to me.

Dec 3 2019, 1:49 PM · Restricted Project, Restricted Project
vsapsai reclaimed D70024: [compiler-rt] Disable fuzzer large.test when LLVM_ENABLE_EXPENSIVE_CHECKS=ON..
Dec 3 2019, 1:30 PM · Restricted Project, Restricted Project

Nov 15 2019

vsapsai abandoned D70024: [compiler-rt] Disable fuzzer large.test when LLVM_ENABLE_EXPENSIVE_CHECKS=ON..

Abandon in favor of D70288.

Nov 15 2019, 11:17 AM · Restricted Project, Restricted Project

Nov 13 2019

vsapsai accepted D69958: Improve VFS compatibility on Windows.
Nov 13 2019, 4:22 PM · Restricted Project, Restricted Project
vsapsai added a comment to D69958: Improve VFS compatibility on Windows.

There is one issue with a comment, apart of that everything looks good to me. Looked into replacing slash and backslash literals with calls to llvm::sys::path::get_separator or llvm::sys::path::is_separator but in my attempts failed to improve existing patch.

Nov 13 2019, 3:36 PM · Restricted Project, Restricted Project

Nov 12 2019

vsapsai created D70141: Make `print` behave in Python 2 as in Python 3..
Nov 12 2019, 1:25 PM

Nov 8 2019

vsapsai created D70024: [compiler-rt] Disable fuzzer large.test when LLVM_ENABLE_EXPENSIVE_CHECKS=ON..
Nov 8 2019, 11:57 AM · Restricted Project, Restricted Project

Nov 6 2019

vsapsai added a comment to D69817: Fix OrcError build with modules enabled..

The error with the notes is

In module 'std' imported from llvm-project/llvm/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h:40:
host-compiler/bin/../include/c++/v1/memory:3003:32: error: definition of 'JITSymbolNotFound' must be imported from module 'LLVM_ExecutionEngine.Orc.CompileOnDemandLayer' before it is required
    return unique_ptr<_Tp>(new _Tp(_VSTD::forward<_Args>(__args)...));
                               ^
llvm-project/llvm/include/llvm/Support/Error.h:331:21: note: in instantiation of function template specialization 'std::__1::make_unique<llvm::orc::JITSymbolNotFound, const std::__1::basic_string<char> &>' requested here
  return Error(std::make_unique<ErrT>(std::forward<ArgTs>(Args)...));
                    ^
llvm-project/llvm/include/llvm/ExecutionEngine/Orc/ExecutionUtils.h:130:18: note: in instantiation of function template specialization 'llvm::make_error<llvm::orc::JITSymbolNotFound, const std::__1::basic_string<char> &>' requested here
          return make_error<JITSymbolNotFound>(CtorDtorName);
                 ^
llvm-project/llvm/lib/ExecutionEngine/Orc/OrcMCJITReplacement.cpp:132:19: note: in instantiation of member function 'llvm::orc::LegacyCtorDtorRunner<llvm::orc::LazyEmittingLayer<llvm::orc::LegacyIRCompileLayer<llvm::orc::LegacyRTDyldObjectLinkingLayer, llvm::orc::SimpleCompiler> > >::runViaLayer' requested here
                 .runViaLayer(LazyEmitLayer));
                  ^
llvm-project/llvm/include/llvm/ExecutionEngine/Orc/OrcError.h:55:7: note: previous definition is here
class JITSymbolNotFound : public ErrorInfo<JITSymbolNotFound> {
      ^
Nov 6 2019, 6:15 PM · Restricted Project

Nov 5 2019

vsapsai added a comment to D69817: Fix OrcError build with modules enabled..

RPCUtils.h and RPCSerialization.h can both also be excluded.

Nov 5 2019, 5:05 PM · Restricted Project
vsapsai committed rG39573daa76f2: Revert "[analyzer] Add test directory for scan-build." (authored by vsapsai).
Revert "[analyzer] Add test directory for scan-build."
Nov 5 2019, 2:10 PM
vsapsai added a reverting change for rG0aba69eb1a01: [analyzer] Add test directory for scan-build.: rG39573daa76f2: Revert "[analyzer] Add test directory for scan-build.".
Nov 5 2019, 2:10 PM
vsapsai added a comment to D69817: Fix OrcError build with modules enabled..

Adding exclude header "ExecutionEngine/Orc/OrcError.h" to the module specification for LLVM_ExecutionEngine seems like a more appropriate fix.

Nov 5 2019, 12:57 PM · Restricted Project

Nov 4 2019

vsapsai added a comment to D69817: Fix OrcError build with modules enabled..

A better solution might be creating a proper module for OrcError but given the discussion in https://reviews.llvm.org/D68732 I'm not sure what is the future of OrcError library and if it is worth spending time on tweaking a module map.

Nov 4 2019, 12:32 PM · Restricted Project
vsapsai created D69817: Fix OrcError build with modules enabled..
Nov 4 2019, 12:31 PM · Restricted Project

Oct 29 2019

vsapsai committed rGd485460da5a6: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by vsapsai).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 5:13 PM
vsapsai committed rG16bc8624444e: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by vsapsai).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 5:11 PM
vsapsai committed rG5bf37eb4d2cc: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by vsapsai).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 4:47 PM
vsapsai committed rGaa8c9fa8fb9d: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by vsapsai).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 3:48 PM
vsapsai committed rG3171ceb84ebe: Update test for the new diagnostic text. (authored by vsapsai).
Update test for the new diagnostic text.
Oct 29 2019, 3:28 PM
vsapsai committed rG2763aa71cdff: Add a missing comma lost during merge. (authored by vsapsai).
Add a missing comma lost during merge.
Oct 29 2019, 3:27 PM
vsapsai committed rG567d480d538b: Add missing diagnostic string for ObjCClassMethod SubsetSubject. (authored by vsapsai).
Add missing diagnostic string for ObjCClassMethod SubsetSubject.
Oct 29 2019, 3:27 PM

Oct 16 2019

vsapsai committed rG930ada91ce8f: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended. (authored by vsapsai).
Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended.
Oct 16 2019, 12:12 PM
vsapsai closed D69011: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended..
Oct 16 2019, 12:12 PM · Restricted Project
vsapsai committed rL375031: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended..
Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended.
Oct 16 2019, 12:12 PM
vsapsai added a comment to D69011: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended..

Thanks for the review! If fs::status behaviour is sufficiently different on Windows, it is worth fixing because I believe majority of non-Windows developers expect them to work in the same way.

Oct 16 2019, 12:12 PM · Restricted Project

Oct 15 2019

vsapsai added a comment to D69011: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended..

The plan is to instrument llvm::sys::fs::status with ALWAYS_ENABLED_STATITSTIC to be able to catch regressions causing lots of stat calls. That's why replacing current stat calls. And it seems to be a good change regardless of future plans.

Oct 15 2019, 4:13 PM · Restricted Project
vsapsai created D69011: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended..
Oct 15 2019, 4:13 PM · Restricted Project

Oct 11 2019

vsapsai committed rGb95d4c3a9979: [ObjC] Remove default parameter no caller was providing. NFC intended. (authored by vsapsai).
[ObjC] Remove default parameter no caller was providing. NFC intended.
Oct 11 2019, 2:23 PM
vsapsai committed rL374596: [ObjC] Remove default parameter no caller was providing. NFC intended..
[ObjC] Remove default parameter no caller was providing. NFC intended.
Oct 11 2019, 2:22 PM
vsapsai committed rGe8752a9d1bcf: [Stats] Convert some ad-hoc header search stats to ALWAYS_ENABLED_STATISTIC. (authored by vsapsai).
[Stats] Convert some ad-hoc header search stats to ALWAYS_ENABLED_STATISTIC.
Oct 11 2019, 11:21 AM
vsapsai committed rL374581: [Stats] Convert some ad-hoc header search stats to ALWAYS_ENABLED_STATISTIC..
[Stats] Convert some ad-hoc header search stats to ALWAYS_ENABLED_STATISTIC.
Oct 11 2019, 11:21 AM

Oct 10 2019

vsapsai committed rG109bfb7b3293: [Polly] Fix formatting violation. NFC. (authored by vsapsai).
[Polly] Fix formatting violation. NFC.
Oct 10 2019, 8:12 PM
vsapsai committed rL374504: [Polly] Fix formatting violation. NFC..
[Polly] Fix formatting violation. NFC.
Oct 10 2019, 8:07 PM
vsapsai committed rG126158f096ca: [Stats] More polly fixes following llvm::Statistic changes in r374490. (authored by vsapsai).
[Stats] More polly fixes following llvm::Statistic changes in r374490.
Oct 10 2019, 7:42 PM
vsapsai committed rL374501: [Stats] More polly fixes following llvm::Statistic changes in r374490..
[Stats] More polly fixes following llvm::Statistic changes in r374490.
Oct 10 2019, 7:40 PM
vsapsai committed rGe90cc03a85ea: [Stats] Fix polly build due to change in llvm::Statistic constructor in r374490. (authored by vsapsai).
[Stats] Fix polly build due to change in llvm::Statistic constructor in r374490.
Oct 10 2019, 6:45 PM
vsapsai committed rL374497: [Stats] Fix polly build due to change in llvm::Statistic constructor in r374490..
[Stats] Fix polly build due to change in llvm::Statistic constructor in r374490.
Oct 10 2019, 6:45 PM
vsapsai committed rGadb203feda90: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS. (authored by vsapsai).
[Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.
Oct 10 2019, 5:59 PM
vsapsai committed rL374490: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS..
[Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.
Oct 10 2019, 5:59 PM
vsapsai closed D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS..
Oct 10 2019, 5:59 PM · Restricted Project

Oct 9 2019

vsapsai added a comment to D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS..

Thanks for the review.

Oct 9 2019, 7:08 PM · Restricted Project
vsapsai updated the diff for D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS..
  • Address review comments.
Oct 9 2019, 6:59 PM · Restricted Project
vsapsai committed rG02c2ab3d8872: [ObjC generics] Fix not inheriting type bounds in categories/extensions. (authored by vsapsai).
[ObjC generics] Fix not inheriting type bounds in categories/extensions.
Oct 9 2019, 12:33 PM
vsapsai closed D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions..
Oct 9 2019, 12:33 PM · Restricted Project
vsapsai committed rL374202: [ObjC generics] Fix not inheriting type bounds in categories/extensions..
[ObjC generics] Fix not inheriting type bounds in categories/extensions.
Oct 9 2019, 12:32 PM
vsapsai added a comment to D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions..

Thanks for the review.

Oct 9 2019, 12:32 PM · Restricted Project

Sep 30 2019

vsapsai added a comment to D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS..

On release build with assertions disabled and LLVM_ENABLE_STATS being 0 the impact on the compile time is the following

Metric: compile_time
Sep 30 2019, 4:12 PM · Restricted Project
vsapsai created D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS..
Sep 30 2019, 4:09 PM · Restricted Project

Sep 27 2019

vsapsai added a comment to D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions..

Found a use case where getCanonicalType() causes problems:

Sep 27 2019, 5:16 PM · Restricted Project

Sep 26 2019

vsapsai committed rL373020: Request commit access for vsapsai.
Request commit access for vsapsai
Sep 26 2019, 3:13 PM

Sep 25 2019

vsapsai committed rL372922: [LNT][docs] Fix some typos..
[LNT][docs] Fix some typos.
Sep 25 2019, 3:25 PM

Sep 17 2019

vsapsai committed rG6e353b4df3aa: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328. (authored by vsapsai).
[Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328.
Sep 17 2019, 5:10 PM
vsapsai added a comment to D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328..

Thanks for the fast review.

Sep 17 2019, 5:09 PM · Restricted Project
vsapsai committed rL372191: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328..
[Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328.
Sep 17 2019, 5:04 PM
vsapsai closed D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328..
Sep 17 2019, 5:04 PM · Restricted Project
vsapsai created D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328..
Sep 17 2019, 4:05 PM · Restricted Project

Sep 13 2019

vsapsai added a comment to D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions..

I'm a bit curious about clients that use getCanonicalType() to get a full desugaring, instead of doing a single step. It seems like they'd still get the out of date type parameter type. Has that ever worked?

Sep 13 2019, 5:54 PM · Restricted Project

Sep 11 2019

vsapsai committed rGfdb83b505595: Fix up a test updated in r371655 - require case-insensitive file system. (authored by vsapsai).
Fix up a test updated in r371655 - require case-insensitive file system.
Sep 11 2019, 2:22 PM
vsapsai committed rL371665: Fix up a test updated in r371655 - require case-insensitive file system..
Fix up a test updated in r371655 - require case-insensitive file system.
Sep 11 2019, 2:22 PM
vsapsai committed rG2f8436168499: Fix -Wnonportable-include-path suppression for header maps with absolute paths. (authored by vsapsai).
Fix -Wnonportable-include-path suppression for header maps with absolute paths.
Sep 11 2019, 1:41 PM
vsapsai committed rL371655: Fix -Wnonportable-include-path suppression for header maps with absolute paths..
Fix -Wnonportable-include-path suppression for header maps with absolute paths.
Sep 11 2019, 1:40 PM
vsapsai closed D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..
Sep 11 2019, 1:40 PM · Restricted Project
vsapsai added a comment to D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..

Thanks for the review.

Sep 11 2019, 1:27 PM · Restricted Project

Sep 9 2019

vsapsai added a comment to D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions..

Ping.

Sep 9 2019, 1:39 PM · Restricted Project

Sep 6 2019

vsapsai added a comment to D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..

Updated the code. Hope it is easier to understand now.

Sep 6 2019, 4:03 PM · Restricted Project
vsapsai updated the diff for D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..
  • Add a test for unused absolute path in a header map; simplify code.
Sep 6 2019, 3:56 PM · Restricted Project
vsapsai added inline comments to D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..
Sep 6 2019, 11:28 AM · Restricted Project

Sep 5 2019

vsapsai updated subscribers of D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory..

Adding Michael Spencer as he was doing some work for a working directory in VFS.

Sep 5 2019, 3:26 PM · Restricted Project, Restricted Project

Sep 4 2019

vsapsai added a comment to D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..

Ping.

Sep 4 2019, 3:04 PM · Restricted Project
vsapsai updated the diff for D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths..
  • Rebase the patch.
Sep 4 2019, 3:04 PM · Restricted Project

Aug 29 2019

vsapsai added a comment to D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU.

For the record, there was another change regarding the delayed typos in clang::Sema::~Sema(): D62648 [Sema][Typo] Fix assertion failure for expressions with multiple typos.

Aug 29 2019, 4:18 PM · Restricted Project
vsapsai committed rG0785f8d0bb70: Remove `FileManager::invalidateCache` as it has no callers anymore. NFC. (authored by vsapsai).
Remove `FileManager::invalidateCache` as it has no callers anymore. NFC.
Aug 29 2019, 12:54 PM
vsapsai committed rL370400: Remove `FileManager::invalidateCache` as it has no callers anymore. NFC..
Remove `FileManager::invalidateCache` as it has no callers anymore. NFC.
Aug 29 2019, 12:50 PM

Aug 28 2019

vsapsai added inline comments to D66907: [Modules] Fix rebuilding an updated module for each of its consumers..
Aug 28 2019, 4:48 PM · Restricted Project
vsapsai added a comment to D66831: [ObjC] Fix type checking for qualified id block parameters..

We're getting a bunch of errors looking like ../../AppsListViewController.m:11:37: error: incompatible block pointer types assigning to 'void (^)(__strong id<AppCellProtocol>)' from 'void (^)(AppCollectionViewCell *__strong)' on code that looks fairly harmless to me. It looks something like this:

@protocol AppCellProtocol <NSObject> ... @end
@interface AppCollectionViewCell : NSObject <AppCellProtocol> ...@enderby 

@interface Cell : NSObject
@property(nonatomic, copy) void (^buttonPressed)(id<AppCellProtocol> cell);
@end

@implementation Bar
- (void) f {
  __weak __typeof(self) weakSelf = self;
  cell.buttonPressed = ^(AppCollectionViewCell *pressedCell) {
    // ...
  };
}
@end

The code doesn't say __strong anywhere as far as I can tell; it looks like regular protocol code.

Is this expected?

Aug 28 2019, 4:41 PM · Restricted Project
vsapsai committed rGf91b6f8159b1: [Modules] Fix rebuilding an updated module for each of its consumers. (authored by vsapsai).
[Modules] Fix rebuilding an updated module for each of its consumers.
Aug 28 2019, 4:33 PM
vsapsai committed rL370274: [Modules] Fix rebuilding an updated module for each of its consumers..
[Modules] Fix rebuilding an updated module for each of its consumers.
Aug 28 2019, 4:32 PM
vsapsai closed D66907: [Modules] Fix rebuilding an updated module for each of its consumers..
Aug 28 2019, 4:32 PM · Restricted Project
vsapsai added a comment to D66907: [Modules] Fix rebuilding an updated module for each of its consumers..

Earlier tryToDropPCM was called tryToRemoveBuffer and it was added in r298278. According to my investigation and understanding it was used to remove tentatively loaded dependencies. Otherwise we would finalize them before validating if they are up to date. But now we are tracking a state of each module (Unknown, Tentative, ToBuild, Final) individually and don't need tryToDropPCM.

Aug 28 2019, 3:21 PM · Restricted Project
vsapsai created D66907: [Modules] Fix rebuilding an updated module for each of its consumers..
Aug 28 2019, 3:05 PM · Restricted Project

Aug 27 2019

vsapsai committed rG73152a2ec207: [ObjC] Fix type checking for qualified id block parameters. (authored by vsapsai).
[ObjC] Fix type checking for qualified id block parameters.
Aug 27 2019, 5:28 PM