Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

bruno (Bruno Cardoso Lopes)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2014, 7:40 AM (475 w, 2 d)

Recent Activity

Aug 10 2023

bruno accepted D157661: [clang][NFC] Robustify testcase.
Aug 10 2023, 8:35 PM · Restricted Project, Restricted Project

May 4 2023

bruno added a comment to D103930: [clang][HeaderSearch] Fix implicit module when using header maps.

Thanks Duncan.

May 4 2023, 10:55 AM · Restricted Project, Restricted Project
bruno added reviewers for D103930: [clang][HeaderSearch] Fix implicit module when using header maps: Bigcheese, ChuanqiXu, jansvoboda11.

Adding code owners and more relevant folks

May 4 2023, 10:51 AM · Restricted Project, Restricted Project
bruno accepted D149850: [Clang][Modules] Support `requires cplusplus20` in a modulemap.

LGTM

May 4 2023, 10:44 AM · Restricted Project, Restricted Project
bruno added reviewers for D149850: [Clang][Modules] Support `requires cplusplus20` in a modulemap: Bigcheese, ChuanqiXu.
May 4 2023, 10:44 AM · Restricted Project, Restricted Project

Apr 25 2023

bruno added a comment to D103930: [clang][HeaderSearch] Fix implicit module when using header maps.

Looks like this patch causes a number of issues for us, I will work with @jansvoboda11 to see if there's some way to resolve them.

Apr 25 2023, 11:27 AM · Restricted Project, Restricted Project

Apr 3 2023

bruno committed rWdbc19ab61659: [GSoC][2023] Update ClangIR project idea with more detailed info (authored by bruno).
[GSoC][2023] Update ClangIR project idea with more detailed info
Apr 3 2023, 11:10 PM · Restricted Project

Mar 23 2023

bruno accepted D146758: Fix codegen for coroutine with function-try-block.

LGTM! @ChuanqiXu wdyt?

Mar 23 2023, 4:46 PM · Restricted Project, Restricted Project
bruno committed rG07ef7b1ff21e: [Builtins] Add __builtin_assume_separate_storage (authored by bruno).
[Builtins] Add __builtin_assume_separate_storage
Mar 23 2023, 4:36 PM · Restricted Project, Restricted Project
bruno closed D136515: [builtins] Add __builtin_assume_separate_storage..
Mar 23 2023, 4:35 PM · Restricted Project, Restricted Project

Mar 21 2023

bruno committed rGfa0d4e1f12a3: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain… (authored by bruno).
[Coroutines] Implement fix for cwg2563 issue and enable RVO under certain…
Mar 21 2023, 9:43 PM · Restricted Project, Restricted Project
bruno committed rG43f5085fa80f: [Coroutines] Fix premature conversion of return object (authored by bruno).
[Coroutines] Fix premature conversion of return object
Mar 21 2023, 9:43 PM · Restricted Project, Restricted Project
bruno closed D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions.
Mar 21 2023, 9:43 PM · Restricted Project, Restricted Project
bruno closed D145639: [Coroutines] Fix premature conversion of return object.
Mar 21 2023, 9:43 PM · Restricted Project, Restricted Project
bruno updated the diff for D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions.

Apply last round of reviews before landing

Mar 21 2023, 9:25 PM · Restricted Project, Restricted Project
bruno updated the diff for D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions.

Add release notes entry.

Mar 21 2023, 12:29 PM · Restricted Project, Restricted Project
bruno updated the diff for D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions.

Address last round of review

Mar 21 2023, 12:21 PM · Restricted Project, Restricted Project
bruno updated the diff for D145639: [Coroutines] Fix premature conversion of return object.

Put dependency in place for D145641

Mar 21 2023, 12:20 PM · Restricted Project, Restricted Project
bruno accepted D136515: [builtins] Add __builtin_assume_separate_storage..

LGTM!

Mar 21 2023, 11:19 AM · Restricted Project, Restricted Project

Mar 17 2023

bruno added a comment to D146187: [docs] Update the status for coroutines.

... I think in general we want feature testing macros to be treated as our signal to the user that we think something is complete, not that we think something is in progress but pretty usable.

Mar 17 2023, 12:19 PM · Restricted Project, Restricted Project
bruno added a comment to D145639: [Coroutines] Fix premature conversion of return object.

@bruno, @ChuanqiXu please let us know if you have any objections, otherwise we will land the revert in ~2 hours.

Mar 17 2023, 11:37 AM · Restricted Project, Restricted Project

Mar 15 2023

bruno updated the diff for D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions.

Update after reviewer comments

Mar 15 2023, 12:13 PM · Restricted Project, Restricted Project
bruno added inline comments to D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions.
Mar 15 2023, 12:13 PM · Restricted Project, Restricted Project
bruno added inline comments to D136515: [builtins] Add __builtin_assume_separate_storage..
Mar 15 2023, 11:23 AM · Restricted Project, Restricted Project
bruno accepted D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth.

Good catch, thanks! LGTM

Mar 15 2023, 11:20 AM · Restricted Project, Restricted Project

Mar 9 2023

bruno committed rG54225c457a33: [Coroutines] Fix premature conversion of return object (authored by bruno).
[Coroutines] Fix premature conversion of return object
Mar 9 2023, 2:19 PM · Restricted Project, Restricted Project
bruno closed D145639: [Coroutines] Fix premature conversion of return object.
Mar 9 2023, 2:19 PM · Restricted Project, Restricted Project
bruno added a comment to D145639: [Coroutines] Fix premature conversion of return object.

Test failures are unrelated, thanks for the review @ChuanqiXu

Mar 9 2023, 2:18 PM · Restricted Project, Restricted Project

Mar 8 2023

bruno committed rW6875c69c6f12: [GSoc2023] Add a clangir open project proposal: Build and run SingleSource… (authored by bruno).
[GSoc2023] Add a clangir open project proposal: Build and run SingleSource…
Mar 8 2023, 11:05 PM · Restricted Project
bruno requested review of D145641: [Coroutines] Implement fix for cwg2563 issue and enable RVO under certain conditions.
Mar 8 2023, 7:15 PM · Restricted Project, Restricted Project
bruno requested review of D145639: [Coroutines] Fix premature conversion of return object.
Mar 8 2023, 6:53 PM · Restricted Project, Restricted Project

Feb 23 2023

bruno added a comment to D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block.

Thanks for working on this Wei!

Feb 23 2023, 3:29 PM · Restricted Project, Restricted Project

Feb 3 2023

bruno committed rG0b8daee028a8: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced (authored by bruno).
[Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced
Feb 3 2023, 3:39 PM · Restricted Project, Restricted Project
bruno closed D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced.
Feb 3 2023, 3:39 PM · Restricted Project, Restricted Project
bruno added a comment to D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced.

Only test failing is ClangScanDeps/modules-full.cpp on Windoes, which is unrelated to this change.

Feb 3 2023, 3:33 PM · Restricted Project, Restricted Project
bruno updated the diff for D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced.

Update checks that rely on coroutine_traits in std-coroutine.h

Feb 3 2023, 2:39 PM · Restricted Project, Restricted Project
bruno added a comment to D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced.

Thanks for the review, will push once all tests pass!

Feb 3 2023, 12:33 PM · Restricted Project, Restricted Project
bruno updated the diff for D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced.

Update patch to reuse std-coroutine.h and add a few more other bits there.

Feb 3 2023, 12:31 PM · Restricted Project, Restricted Project

Jan 20 2023

bruno added a comment to D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced.

Test failure is unrelated.

Jan 20 2023, 9:43 AM · Restricted Project, Restricted Project
bruno added reviewers for D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced: aaron.ballman, riccibruno.
Jan 20 2023, 9:42 AM · Restricted Project, Restricted Project

Jan 18 2023

bruno requested review of D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced.
Jan 18 2023, 7:48 PM · Restricted Project, Restricted Project

Jan 17 2023

bruno accepted D124286: [modules] Allow parsing a duplicate Obj-C interface if a previous one comes from a hidden [sub]module..

Nice new testcase snippets, LGTM

Jan 17 2023, 10:27 AM · Restricted Project, Restricted Project

Dec 20 2022

bruno added a comment to D136515: [builtins] Add __builtin_assume_separate_storage..

Additionally, this likely deserves an entry in ./clang/docs/ReleaseNotes.rst.

Dec 20 2022, 6:44 AM · Restricted Project, Restricted Project
bruno requested changes to D136515: [builtins] Add __builtin_assume_separate_storage..

Nice, thanks for adding the builtin layer.

Dec 20 2022, 6:34 AM · Restricted Project, Restricted Project

Nov 17 2022

bruno accepted D137609: [C++20] [Modules] Remove unmaintained header modules.

Also not using this at Meta, LGTM.

Nov 17 2022, 10:19 AM · Restricted Project, Restricted Project, Restricted Project

Nov 10 2022

bruno accepted D130326: [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches..

Very nice how this has improved since the version I worked on in the past, thanks!

Nov 10 2022, 10:49 PM · Restricted Project, Restricted Project
bruno accepted D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing..

LGTM

Nov 10 2022, 10:47 PM · Restricted Project, Restricted Project

Nov 1 2022

bruno accepted D137179: [clang][Lex] Header map search case insensitivity.

LGTM with minor nitpick: can you reflect in the title that this is related to header maps?

Nov 1 2022, 11:29 AM · Restricted Project, Restricted Project

Oct 27 2022

bruno accepted D136190: [clang][Sema][NFC] Remove redundant isTypeValid.

Nice cleanup, before landing please capitalize remove in the title and also add [NFC] to it!

Oct 27 2022, 10:05 AM · Restricted Project, Restricted Project
bruno added a comment to D136633: [clang][AST] avoid unnecessary FunctionProtoTypes.FindNodeOrInsertPos call.

Nice catch, thanks for improving this.

Oct 27 2022, 10:00 AM · Restricted Project, Restricted Project

Oct 26 2022

Herald added a project to D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions: Restricted Project.
Oct 26 2022, 3:14 PM · Restricted Project, Restricted Project

Oct 21 2022

bruno accepted D136221: [docs] Add the description about mixing use of clang modules and c++ modules.

Looks great, some minor suggestions.

Oct 21 2022, 12:08 PM · Restricted Project, Restricted Project

Oct 17 2022

bruno accepted D135801: [clang][Lexer] Speedup HeaderSearch when there are many HeaderMaps.

Thanks for the detailed explanations, LGTM!

Oct 17 2022, 11:18 PM · Restricted Project, Restricted Project

Oct 14 2022

bruno accepted D130324: [ODRHash] Hash `ObjCProtocolDecl` and diagnose discovered mismatches..

Great to see both this and D130325 landing, LGTM too.

Oct 14 2022, 5:31 PM · Restricted Project, Restricted Project

Oct 12 2022

bruno added a comment to D135801: [clang][Lexer] Speedup HeaderSearch when there are many HeaderMaps.

Thanks for working on this Troy, nice speed up.

Oct 12 2022, 9:28 PM · Restricted Project, Restricted Project
bruno added reviewers for D135801: [clang][Lexer] Speedup HeaderSearch when there are many HeaderMaps: arphaman, vsapsai, jansvoboda11.
Oct 12 2022, 1:16 PM · Restricted Project, Restricted Project

Oct 10 2022

bruno added a comment to D135370: Narrow inline namespace filtration for unqualified friend declarations.

LGTM! Should we also add a release note or do we think this isn't enough of a compile-time performance improvement to warrant that?

Oct 10 2022, 12:43 PM · Restricted Project, Restricted Project
bruno accepted D130325: [ODRHash] Hash `ObjCMethodDecl` and diagnose discovered mismatches..

LGTM

Oct 10 2022, 10:33 AM · Restricted Project, Restricted Project

Oct 6 2022

bruno accepted D135370: Narrow inline namespace filtration for unqualified friend declarations.

Hi Troy, thanks for working on this, nice compile time perf savings. Can you update the diff to contain more context? If anything, -U 999999 or similar would do the job.

Oct 6 2022, 5:15 PM · Restricted Project, Restricted Project

Sep 13 2022

bruno added a comment to D133622: [clang][test] Disallow using the default module cache path in lit tests.

I'm not sure how to deal with missing env -u.

  • We could do env CLANG_MODULE_CACHE_PATH= and change the compiler's interpretation of empty string for this variable. I'm not sure if the current behaviour (there will be no module cache in the cc1 at all) is intentional or useful. Hesitant to change this behaviour.
Sep 13 2022, 6:08 PM · Restricted Project, Restricted Project, Restricted Project

Sep 9 2022

bruno accepted D133622: [clang][test] Disallow using the default module cache path in lit tests.

Awesome!

Sep 9 2022, 5:26 PM · Restricted Project, Restricted Project, Restricted Project
bruno committed rGf4a13c9c0a04: [Clang][ScanDeps] Change multiple-commands.c test to use -fmodules-cache-path… (authored by bruno).
[Clang][ScanDeps] Change multiple-commands.c test to use -fmodules-cache-path…
Sep 9 2022, 4:21 PM · Restricted Project, Restricted Project
bruno closed D133617: [Clang][ScanDeps] Change multiple-commands.c test to use -fmodules-cache-path on implicit builds.
Sep 9 2022, 4:20 PM · Restricted Project, Restricted Project
bruno added a comment to D133617: [Clang][ScanDeps] Change multiple-commands.c test to use -fmodules-cache-path on implicit builds.

Thanks for the fast review! Good suggestions, will apply and land.

Sep 9 2022, 4:12 PM · Restricted Project, Restricted Project
bruno requested review of D133617: [Clang][ScanDeps] Change multiple-commands.c test to use -fmodules-cache-path on implicit builds.
Sep 9 2022, 3:25 PM · Restricted Project, Restricted Project

Jun 14 2022

bruno accepted D127182: [Clang][Modules] Merge availability attributes on imported decls.

LGTM

Jun 14 2022, 10:53 AM · Restricted Project, Restricted Project, Restricted Project

Jun 8 2022

bruno committed rGe6a76a49356e: [Clang][CoverageMapping] Fix compile time explosions by adjusting only… (authored by bruno).
[Clang][CoverageMapping] Fix compile time explosions by adjusting only…
Jun 8 2022, 11:14 PM · Restricted Project, Restricted Project
bruno closed D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges.
Jun 8 2022, 11:13 PM · Restricted Project, Restricted Project
bruno updated the diff for D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges.

Empty lines handling should also make it skipped, fix the 3 failures.

Jun 8 2022, 4:49 PM · Restricted Project, Restricted Project
bruno accepted D127236: [clang][pr55896]:co_yield/co_await thread-safety.

LGTM, thanks for the detailed explanation/comments. One minor nitpick inline.

Jun 8 2022, 3:44 PM · Restricted Project, Restricted Project
bruno added a comment to D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges.

Just noticed that 3 test cases failed. Please fix them before landing.

Jun 8 2022, 2:09 PM · Restricted Project, Restricted Project
bruno requested review of D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges.
Jun 8 2022, 12:48 PM · Restricted Project, Restricted Project

May 26 2022

bruno added a comment to D124751: [HLSL] Support -E option for HLSL..

Hi, nice to see this getting in. Comments inline!

May 26 2022, 5:52 PM · Restricted Project, Restricted Project
bruno committed rGce54b22657f0: [Clang][CoverageMapping] Fix switch counter codegen compile time explosion (authored by bruno).
[Clang][CoverageMapping] Fix switch counter codegen compile time explosion
May 26 2022, 11:11 AM · Restricted Project, Restricted Project, Restricted Project
bruno closed D126345: [Clang][CoverageMapping] Fix switch case counter compile time explosion.
May 26 2022, 11:11 AM · Restricted Project, Restricted Project, Restricted Project

May 25 2022

bruno accepted D126399: [clang][PR55406] CFG for coroutine.
May 25 2022, 2:00 PM · Restricted Project, Restricted Project
bruno added inline comments to D126399: [clang][PR55406] CFG for coroutine.
May 25 2022, 11:19 AM · Restricted Project, Restricted Project

May 24 2022

bruno requested review of D126345: [Clang][CoverageMapping] Fix switch case counter compile time explosion.
May 24 2022, 5:09 PM · Restricted Project, Restricted Project, Restricted Project

Apr 6 2022

bruno accepted D123141: [clang][DOC] Document module mangler changes.
Apr 6 2022, 10:38 AM · Restricted Project, Restricted Project

Apr 5 2022

bruno added a comment to D123141: [clang][DOC] Document module mangler changes.

Nice!

Apr 5 2022, 9:48 AM · Restricted Project, Restricted Project

Mar 30 2022

bruno added a comment to D122741: [clang] Module global init mangling.

Forgot to ask, is there anything preventing a testcase to be added here?

Mar 30 2022, 9:33 AM · Restricted Project, Restricted Project
bruno accepted D122741: [clang] Module global init mangling.
Mar 30 2022, 9:29 AM · Restricted Project, Restricted Project

Mar 25 2022

bruno accepted D120905: [demangler] Add operator precedence.

LGTM

Mar 25 2022, 11:26 AM · Restricted Project, Restricted Project, Restricted Project

Mar 21 2022

bruno added a reviewer for D120201: [Clang] Extend -gen-reproducer flag: bruno.
Mar 21 2022, 3:02 PM · Restricted Project, Restricted Project
bruno added a comment to D120201: [Clang] Extend -gen-reproducer flag.

This is pretty cool, I enjoy the idea of getting a tar out of a crash. I'm also a +1 for having this group of behaviors as a more official -femit-reproducer=<option> flag. In future work, do you plan to change the default crash mode to output a tar instead of multiple files?

Mar 21 2022, 3:02 PM · Restricted Project, Restricted Project

Mar 7 2022

bruno added a reviewer for D121040: Add a new preprocessor option `-fbuild-session-timestamp-date-time-macros`: vsapsai.
Mar 7 2022, 12:40 PM · Restricted Project
bruno added a comment to D121040: Add a new preprocessor option `-fbuild-session-timestamp-date-time-macros`.

Why isn't D23934 sufficient? What do these flags with very long names do that ffixed-date-time doesn't?

Mar 7 2022, 12:40 PM · Restricted Project

Mar 3 2022

bruno requested changes to D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration.

It would be nice to have some mechanism to notify developers that includes are still performed regardless of requires

Mar 3 2022, 4:04 PM · Restricted Project, Restricted Project, Restricted Project
bruno accepted D120901: [demangler] Make OutputBuffer non-copyable.

LGTM

Mar 3 2022, 3:35 PM · Restricted Project, Restricted Project, Restricted Project
bruno requested changes to D120905: [demangler] Add operator precedence.

Nice cleanup, fixes and testcases, just pending test failures and this looks good.

Mar 3 2022, 3:32 PM · Restricted Project, Restricted Project, Restricted Project
bruno accepted D118005: [hmaptool] Fix string decoding for Python 3.

LGTM

Mar 3 2022, 3:06 PM · Restricted Project, Restricted Project
bruno accepted D118004: [hmaptool] Fix dumping.

LGTM

Mar 3 2022, 3:05 PM · Restricted Project, Restricted Project

Feb 18 2022

bruno added a comment to D120118: [demangler][NFC] Reformat test part 1.

Could the test be tagged with keywords that would prevent the linting to kick in? The amount of changes for this and following patches seems too big to be worth the reformatting.

Feb 18 2022, 10:48 AM · Restricted Project

Feb 7 2022

bruno accepted D118486: [demangler] Improve ->* & .* demangling.

The right solution to the paren problem is to add some notion of precedence (and associativity) to Nodes, but that's a larger change that would become simpler once the refactoring I'm doing is completed.

Feb 7 2022, 2:42 PM · Restricted Project, Restricted Project

Feb 1 2022

bruno accepted D118704: [clang][NFC] Remove unreachable code.

LGTM

Feb 1 2022, 10:27 AM · Restricted Project

Nov 19 2021

bruno accepted D107944: [hmaptool] Port to python3.

LGTM!

Nov 19 2021, 3:28 PM · Restricted Project

Nov 18 2021

bruno accepted D113685: [IR] Define "ptrauth" operand bundle..

Given context from further patches in the set, I believe ptrauth operand bundle has been a good way to represent this and works well. LGTM

Nov 18 2021, 6:41 PM · Restricted Project
bruno accepted D112481: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType.

This is good to go, sorry for the delay.

Nov 18 2021, 6:31 PM · Restricted Project, Restricted Project
bruno accepted D113523: Add toggling for -fnew-infallible/-fno-new-infallible.

LGTM

Nov 18 2021, 6:28 PM · Restricted Project
bruno added inline comments to D112941: [clang] Add support for the new pointer authentication builtins..
Nov 18 2021, 6:26 PM · Restricted Project, Restricted Project, Restricted Project