Page MenuHomePhabricator

bruno (Bruno Cardoso Lopes)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2014, 7:40 AM (424 w, 3 d)

Recent Activity

Tue, Sep 13

bruno added a comment to D133622: [clang][test] Disallow using the default module cache path in lit tests.

I'm not sure how to deal with missing env -u.

  • We could do env CLANG_MODULE_CACHE_PATH= and change the compiler's interpretation of empty string for this variable. I'm not sure if the current behaviour (there will be no module cache in the cc1 at all) is intentional or useful. Hesitant to change this behaviour.
Tue, Sep 13, 6:08 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Sep 9

bruno accepted D133622: [clang][test] Disallow using the default module cache path in lit tests.

Awesome!

Fri, Sep 9, 5:26 PM · Restricted Project, Restricted Project, Restricted Project
bruno committed rGf4a13c9c0a04: [Clang][ScanDeps] Change multiple-commands.c test to use -fmodules-cache-path… (authored by bruno).
[Clang][ScanDeps] Change multiple-commands.c test to use -fmodules-cache-path…
Fri, Sep 9, 4:21 PM · Restricted Project, Restricted Project
bruno closed D133617: [Clang][ScanDeps] Change multiple-commands.c test to use -fmodules-cache-path on implicit builds.
Fri, Sep 9, 4:20 PM · Restricted Project, Restricted Project
bruno added a comment to D133617: [Clang][ScanDeps] Change multiple-commands.c test to use -fmodules-cache-path on implicit builds.

Thanks for the fast review! Good suggestions, will apply and land.

Fri, Sep 9, 4:12 PM · Restricted Project, Restricted Project
bruno requested review of D133617: [Clang][ScanDeps] Change multiple-commands.c test to use -fmodules-cache-path on implicit builds.
Fri, Sep 9, 3:25 PM · Restricted Project, Restricted Project

Jun 14 2022

bruno accepted D127182: [Clang][Modules] Merge availability attributes on imported decls.

LGTM

Jun 14 2022, 10:53 AM · Restricted Project, Restricted Project, Restricted Project

Jun 8 2022

bruno committed rGe6a76a49356e: [Clang][CoverageMapping] Fix compile time explosions by adjusting only… (authored by bruno).
[Clang][CoverageMapping] Fix compile time explosions by adjusting only…
Jun 8 2022, 11:14 PM · Restricted Project, Restricted Project
bruno closed D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges.
Jun 8 2022, 11:13 PM · Restricted Project, Restricted Project
bruno updated the diff for D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges.

Empty lines handling should also make it skipped, fix the 3 failures.

Jun 8 2022, 4:49 PM · Restricted Project, Restricted Project
bruno accepted D127236: [clang][pr55896]:co_yield/co_await thread-safety.

LGTM, thanks for the detailed explanation/comments. One minor nitpick inline.

Jun 8 2022, 3:44 PM · Restricted Project, Restricted Project
bruno added a comment to D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges.

Just noticed that 3 test cases failed. Please fix them before landing.

Jun 8 2022, 2:09 PM · Restricted Project, Restricted Project
bruno requested review of D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges.
Jun 8 2022, 12:48 PM · Restricted Project, Restricted Project

May 26 2022

bruno added a comment to D124751: [HLSL] Support -E option for HLSL..

Hi, nice to see this getting in. Comments inline!

May 26 2022, 5:52 PM · Restricted Project, Restricted Project
bruno committed rGce54b22657f0: [Clang][CoverageMapping] Fix switch counter codegen compile time explosion (authored by bruno).
[Clang][CoverageMapping] Fix switch counter codegen compile time explosion
May 26 2022, 11:11 AM · Restricted Project, Restricted Project, Restricted Project
bruno closed D126345: [Clang][CoverageMapping] Fix switch case counter compile time explosion.
May 26 2022, 11:11 AM · Restricted Project, Restricted Project, Restricted Project

May 25 2022

bruno accepted D126399: [clang][PR55406] CFG for coroutine.
May 25 2022, 2:00 PM · Restricted Project, Restricted Project
bruno added inline comments to D126399: [clang][PR55406] CFG for coroutine.
May 25 2022, 11:19 AM · Restricted Project, Restricted Project

May 24 2022

bruno requested review of D126345: [Clang][CoverageMapping] Fix switch case counter compile time explosion.
May 24 2022, 5:09 PM · Restricted Project, Restricted Project, Restricted Project

Apr 6 2022

bruno accepted D123141: [clang][DOC] Document module mangler changes.
Apr 6 2022, 10:38 AM · Restricted Project, Restricted Project

Apr 5 2022

bruno added a comment to D123141: [clang][DOC] Document module mangler changes.

Nice!

Apr 5 2022, 9:48 AM · Restricted Project, Restricted Project

Mar 30 2022

bruno added a comment to D122741: [clang] Module global init mangling.

Forgot to ask, is there anything preventing a testcase to be added here?

Mar 30 2022, 9:33 AM · Restricted Project, Restricted Project
bruno accepted D122741: [clang] Module global init mangling.
Mar 30 2022, 9:29 AM · Restricted Project, Restricted Project

Mar 25 2022

bruno accepted D120905: [demangler] Add operator precedence.

LGTM

Mar 25 2022, 11:26 AM · Restricted Project, Restricted Project, Restricted Project

Mar 21 2022

bruno added a reviewer for D120201: [Clang] Extend -gen-reproducer flag: bruno.
Mar 21 2022, 3:02 PM · Restricted Project, Restricted Project
bruno added a comment to D120201: [Clang] Extend -gen-reproducer flag.

This is pretty cool, I enjoy the idea of getting a tar out of a crash. I'm also a +1 for having this group of behaviors as a more official -femit-reproducer=<option> flag. In future work, do you plan to change the default crash mode to output a tar instead of multiple files?

Mar 21 2022, 3:02 PM · Restricted Project, Restricted Project

Mar 7 2022

bruno added a reviewer for D121040: Add a new preprocessor option `-fbuild-session-timestamp-date-time-macros`: vsapsai.
Mar 7 2022, 12:40 PM · Restricted Project
bruno added a comment to D121040: Add a new preprocessor option `-fbuild-session-timestamp-date-time-macros`.

Why isn't D23934 sufficient? What do these flags with very long names do that ffixed-date-time doesn't?

Mar 7 2022, 12:40 PM · Restricted Project

Mar 3 2022

bruno requested changes to D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration.

It would be nice to have some mechanism to notify developers that includes are still performed regardless of requires

Mar 3 2022, 4:04 PM · Restricted Project, Restricted Project, Restricted Project
bruno accepted D120901: [demangler] Make OutputBuffer non-copyable.

LGTM

Mar 3 2022, 3:35 PM · Restricted Project, Restricted Project, Restricted Project
bruno requested changes to D120905: [demangler] Add operator precedence.

Nice cleanup, fixes and testcases, just pending test failures and this looks good.

Mar 3 2022, 3:32 PM · Restricted Project, Restricted Project, Restricted Project
bruno accepted D118005: [hmaptool] Fix string decoding for Python 3.

LGTM

Mar 3 2022, 3:06 PM · Restricted Project, Restricted Project
bruno accepted D118004: [hmaptool] Fix dumping.

LGTM

Mar 3 2022, 3:05 PM · Restricted Project, Restricted Project

Feb 18 2022

bruno added a comment to D120118: [demangler][NFC] Reformat test part 1.

Could the test be tagged with keywords that would prevent the linting to kick in? The amount of changes for this and following patches seems too big to be worth the reformatting.

Feb 18 2022, 10:48 AM · Restricted Project

Feb 7 2022

bruno accepted D118486: [demangler] Improve ->* & .* demangling.

The right solution to the paren problem is to add some notion of precedence (and associativity) to Nodes, but that's a larger change that would become simpler once the refactoring I'm doing is completed.

Feb 7 2022, 2:42 PM · Restricted Project, Restricted Project

Feb 1 2022

bruno accepted D118704: [clang][NFC] Remove unreachable code.

LGTM

Feb 1 2022, 10:27 AM · Restricted Project

Nov 19 2021

bruno accepted D107944: [hmaptool] Port to python3.

LGTM!

Nov 19 2021, 3:28 PM · Restricted Project

Nov 18 2021

bruno accepted D113685: [IR] Define "ptrauth" operand bundle..

Given context from further patches in the set, I believe ptrauth operand bundle has been a good way to represent this and works well. LGTM

Nov 18 2021, 6:41 PM · Restricted Project
bruno accepted D112481: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType.

This is good to go, sorry for the delay.

Nov 18 2021, 6:31 PM · Restricted Project, Restricted Project
bruno accepted D113523: Add toggling for -fnew-infallible/-fno-new-infallible.

LGTM

Nov 18 2021, 6:28 PM · Restricted Project
bruno added inline comments to D112941: [clang] Add support for the new pointer authentication builtins..
Nov 18 2021, 6:26 PM · Restricted Project

Nov 9 2021

bruno added a comment to D113523: Add toggling for -fnew-infallible/-fno-new-infallible.

Hi @modimo, can you also add a driver test to check (clang/test/Driver/...) that nothing is added to cc1 cmdline when -fno-new-infallible is used or take precendence?

Nov 9 2021, 5:02 PM · Restricted Project
bruno added a comment to D112941: [clang] Add support for the new pointer authentication builtins..

Thanks for working on upstreaming this @ab. Overall looks good to me, I see clang-format issues, are those legit? One more comment inline.

Nov 9 2021, 12:00 AM · Restricted Project

Nov 8 2021

bruno accepted D113425: gcc extension # NNN directive lines.

Seems like the build failures are unrelated, LGTM with the suggested clang-format changes.

Nov 8 2021, 11:16 PM · Restricted Project

Oct 25 2021

bruno added a reviewer for D112481: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType: bruno.

Nice catch, thanks for working on this!

Oct 25 2021, 11:52 PM · Restricted Project, Restricted Project

Oct 12 2021

bruno added a comment to D107944: [hmaptool] Port to python3.

Overall looks great but there are some test failures, looks like you also need to update line 223?

Oct 12 2021, 6:38 PM · Restricted Project

Jun 22 2021

bruno committed rGc9aaf34b8db8: [SemaCXX] Handle lack of TypeSourceInfo on special member functions in… (authored by bruno).
[SemaCXX] Handle lack of TypeSourceInfo on special member functions in…
Jun 22 2021, 5:28 PM
bruno closed D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.
Jun 22 2021, 5:28 PM · Restricted Project

Jun 21 2021

bruno added a comment to D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Ping

Jun 21 2021, 12:26 PM · Restricted Project

Jun 18 2021

bruno added inline comments to D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.
Jun 18 2021, 12:27 PM · Restricted Project

Jun 17 2021

bruno added a comment to D103930: [clang][HeaderSearch] Fix implicit module when using header maps.

@dexonsmith and @jansvoboda11 thanks for the fast reply and the extra testing.

Jun 17 2021, 2:33 PM · Restricted Project, Restricted Project

Jun 15 2021

bruno accepted D102820: [Clang] Check for returns_nonnull when deciding to add allocation null checks.

Assuming I'm answering the correct question that the returns_nonnull is preserved through a PCH, the answer is yes.

Jun 15 2021, 4:55 PM · Restricted Project
bruno updated subscribers of D103930: [clang][HeaderSearch] Fix implicit module when using header maps.

Thanks for working on this, comments inline. @vsapsai @jansvoboda11 @dexonsmith any headermap related concerns on your side?

Jun 15 2021, 4:42 PM · Restricted Project, Restricted Project
bruno added a comment to D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Ping

Jun 15 2021, 3:32 PM · Restricted Project

Jun 7 2021

bruno added a comment to D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Ping

Jun 7 2021, 12:45 PM · Restricted Project

Jun 4 2021

bruno accepted D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText().

Thanks for adding more tests! LGTM.

Jun 4 2021, 3:34 PM · Restricted Project

Jun 2 2021

bruno accepted D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

LGTM!

Jun 2 2021, 9:31 AM · Restricted Project

Jun 1 2021

bruno added inline comments to D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.
Jun 1 2021, 1:01 PM · Restricted Project
bruno accepted D103258: [clang] Fix ICE with typeid & polymorphic class (pr50497).

LGTM

Jun 1 2021, 12:36 PM · Restricted Project
bruno added a comment to D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Ping.

Jun 1 2021, 11:20 AM · Restricted Project
bruno added a comment to D98995: [CGAtomic] Lift stronger requirements on cmpxch and add support for acquire failure mode.

@yln sorry, I didn't get notifications for this somehow. This got fixed as part of the more general support in https://github.com/llvm/llvm-project/commit/819e0d105e84c6081cfcfa0e38fd257b6124553a

Jun 1 2021, 10:18 AM · Restricted Project, Restricted Project

May 27 2021

bruno requested changes to D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.

Overall looks good, few remaining nitpicks.

May 27 2021, 5:32 PM · Restricted Project
bruno accepted D103229: [clang] NFC: split HeaderMapTest to have re-usable header map implementation for testing.

LGTM

May 27 2021, 12:35 PM · Restricted Project

May 26 2021

bruno updated subscribers of D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics.
May 26 2021, 5:38 PM · Restricted Project

May 25 2021

bruno committed rG6c35991ca024: [TSAN][CMake] Add support to run lit on individual tests (authored by bruno).
[TSAN][CMake] Add support to run lit on individual tests
May 25 2021, 12:33 PM
bruno closed D103054: [TSAN][CMake] Add support to run lit on individual tests.
May 25 2021, 12:33 PM · Restricted Project

May 24 2021

bruno requested review of D103054: [TSAN][CMake] Add support to run lit on individual tests.
May 24 2021, 3:56 PM · Restricted Project

May 21 2021

bruno accepted D100276: [clang] p1099 3/5: using Enum::member.

LGTM. An additional review here would be nice though.

May 21 2021, 1:26 PM · Restricted Project

May 20 2021

bruno accepted D102241: [clang] p1099 4/5: using enum EnumTag.

Thanks for adding the tests. LGTM after some remaining nitpick.

May 20 2021, 6:12 PM · Restricted Project, Restricted Project
bruno resigned from D53522: [Frontend] Include module map header declaration in dependency file output.
May 20 2021, 5:59 PM
bruno updated the diff for D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Update after last round of reviews.

May 20 2021, 3:00 PM · Restricted Project
bruno added a comment to D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Nothing else of substance from me, but I don't feel confident in giving final sign off on this. LG, but please wait until one of the other reviewers accepts as well.

May 20 2021, 2:54 PM · Restricted Project
bruno added a comment to D102782: Add support for Warning Flag "-Wstack-usage=".

Overall looks good, sounds like it's failing tests though?

May 20 2021, 2:45 PM · Restricted Project
bruno resigned from D101965: Added Support for Warning Flag -Wstack-usage=.
May 20 2021, 2:44 PM · Restricted Project, Restricted Project
bruno resigned from D101964: Added support for -Wstack-usage flag and Framesize reporting fix.
May 20 2021, 2:44 PM · Restricted Project, Restricted Project
bruno accepted D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl.

LGTM

May 20 2021, 2:34 PM · Restricted Project, Restricted Project
bruno added a comment to D102820: [Clang] Check for returns_nonnull when deciding to add allocation null checks.

Sounds reasonable to me! Can you double check whether this attribute gets correctly serialized/deserialized in face of CXXNewExpr? An example of how to test that would be in clang/test/PCH/cxx-method.cpp.

May 20 2021, 2:19 PM · Restricted Project

May 19 2021

bruno resigned from D80172: Revert "Re-fix _lrotl/_lrotr to always take Long, no matter the platform.".
May 19 2021, 6:14 PM · Restricted Project
bruno resigned from D78058: option to write files to memory instead of disk.
May 19 2021, 6:14 PM · Restricted Project, Restricted Project
bruno resigned from D70563: Use kevent queue for detecting file unlocking in LockFileManager.
May 19 2021, 6:13 PM · Restricted Project, Restricted Project
bruno resigned from D66172: [clang][Modules] Serialize decl to comment mapping to speed up code completion..
May 19 2021, 6:12 PM
bruno resigned from D60356: Accelerate isPotentiallyReachable when a DominatorTree is available..
May 19 2021, 6:12 PM · Restricted Project
bruno resigned from D54880: Ignore gcc's stack-clash-protection flag.
May 19 2021, 6:10 PM · Restricted Project

May 18 2021

bruno updated the diff for D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Update patch after @aaron.ballman review!

May 18 2021, 6:01 PM · Restricted Project
bruno added a comment to D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Thanks for the review @aaron.ballman!

May 18 2021, 5:57 PM · Restricted Project

May 17 2021

bruno updated the diff for D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.

Make this work for c++14 as well, update testcase to cover all possibilities mentioned. @mdreseler thanks for bringing this up.

May 17 2021, 6:01 PM · Restricted Project

May 14 2021

bruno accepted D102239: [clang][NFC] p1099 2/5: Break out enum completion from context completion.

Looks good to me with the remaining clang-format linting on the assert.

May 14 2021, 10:30 AM · Restricted Project

May 13 2021

bruno added inline comments to D102241: [clang] p1099 4/5: using enum EnumTag.
May 13 2021, 11:23 PM · Restricted Project, Restricted Project
bruno added a comment to D100276: [clang] p1099 3/5: using Enum::member.

Overall looks good, one more comment below.

May 13 2021, 11:18 PM · Restricted Project
bruno added inline comments to D102239: [clang][NFC] p1099 2/5: Break out enum completion from context completion.
May 13 2021, 11:03 PM · Restricted Project
bruno added a comment to D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl.

You should also update the title with [NFC] or similar.

May 13 2021, 10:43 PM · Restricted Project, Restricted Project
bruno added a comment to D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl.

The approach looks good. There are some test failures - you need to update some bits in clangd and probably anywhere else in the repo that you see uses of getUsingDecl().

May 13 2021, 10:41 PM · Restricted Project, Restricted Project
bruno committed rGfd184c062c1a: [TSAN] Honor failure memory orders in AtomicCAS (authored by bruno).
[TSAN] Honor failure memory orders in AtomicCAS
May 13 2021, 1:08 AM
bruno closed D99434: [TSAN] Honor failure memory orders in AtomicCAS.
May 13 2021, 1:07 AM · Restricted Project, Restricted Project
bruno added inline comments to D99434: [TSAN] Honor failure memory orders in AtomicCAS.
May 13 2021, 12:20 AM · Restricted Project, Restricted Project

May 12 2021

bruno updated the diff for D99434: [TSAN] Honor failure memory orders in AtomicCAS.

Update patch to reduce code dup as suggested by @dvyukov

May 12 2021, 2:25 PM · Restricted Project, Restricted Project
bruno added inline comments to D99434: [TSAN] Honor failure memory orders in AtomicCAS.
May 12 2021, 2:23 PM · Restricted Project, Restricted Project

May 11 2021

bruno updated the diff for D99434: [TSAN] Honor failure memory orders in AtomicCAS.

Cool, thanks for the input!

May 11 2021, 5:43 PM · Restricted Project, Restricted Project

May 10 2021

bruno updated the diff for D99434: [TSAN] Honor failure memory orders in AtomicCAS.

Thank you @dvyukov for another round of reviews! A have more questions for you.

May 10 2021, 1:20 PM · Restricted Project, Restricted Project

May 6 2021

bruno updated the diff for D99434: [TSAN] Honor failure memory orders in AtomicCAS.

Cover more cases in atomic.ll.

May 6 2021, 10:50 PM · Restricted Project, Restricted Project