Page MenuHomePhabricator

bruno (Bruno Cardoso Lopes)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2014, 7:40 AM (283 w, 3 d)

Recent Activity

Fri, Jan 10

bruno updated the diff for D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.

Updated the patch to refactor mode code.

Fri, Jan 10, 3:39 PM · Restricted Project
bruno added inline comments to D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.
Fri, Jan 10, 9:53 AM · Restricted Project

Thu, Jan 9

bruno committed rGe54af192450d: Handle tag types and complain about bad merges in C/Objective-C mode (authored by bruno).
Handle tag types and complain about bad merges in C/Objective-C mode
Thu, Jan 9, 5:46 PM

Wed, Jan 8

bruno updated the diff for D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.

Remove some FIXMEs that are now done.

Wed, Jan 8, 10:03 PM · Restricted Project
bruno updated the summary of D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.
Wed, Jan 8, 9:56 PM · Restricted Project
bruno added a comment to D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.
Wed, Jan 8, 9:54 PM · Restricted Project
bruno updated the diff for D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.

Change the approach: handle type merging for tag types using the ODRHash mechanism

Wed, Jan 8, 9:54 PM · Restricted Project

Dec 19 2019

bruno updated the summary of D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.
Dec 19 2019, 4:30 PM · Restricted Project
bruno created D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.
Dec 19 2019, 4:30 PM · Restricted Project

Dec 12 2019

bruno committed rGdde37d52bc71: [Modules] Fix implicit modules 'could not read module signature' problem (authored by bruno).
[Modules] Fix implicit modules 'could not read module signature' problem
Dec 12 2019, 3:01 PM
bruno committed rG25027f26ad64: [Modules] Make ReadModuleMapFileBlock errors reliable (authored by bruno).
[Modules] Make ReadModuleMapFileBlock errors reliable
Dec 12 2019, 1:46 PM
bruno committed rG07aa5e7bf743: [Modules] Move FILE_SYSTEM_OPTIONS to the unhashed control block (authored by bruno).
[Modules] Move FILE_SYSTEM_OPTIONS to the unhashed control block
Dec 12 2019, 1:38 PM
bruno committed rG7bbc38d32acd: [Modules] Move search paths outside of the control block (authored by bruno).
[Modules] Move search paths outside of the control block
Dec 12 2019, 1:38 PM
bruno committed rG01336d79be59: [Modules][Objective-C] Use complete decl from module when diagnosing missing… (authored by bruno).
[Modules][Objective-C] Use complete decl from module when diagnosing missing…
Dec 12 2019, 1:28 PM
bruno committed rG7264ab365a83: [Modules] Use -skip-unused-modulemap-deps by default (authored by bruno).
[Modules] Use -skip-unused-modulemap-deps by default
Dec 12 2019, 1:17 PM
bruno committed rG093ca1263714: [Modules] Skip adding unused module maps to the dependency file (authored by bruno).
[Modules] Skip adding unused module maps to the dependency file
Dec 12 2019, 1:17 PM
bruno committed rG67c70038bcc0: Reinstate r310605: [Modules] Prevent #import to reenter header if not building… (authored by bruno).
Reinstate r310605: [Modules] Prevent #import to reenter header if not building…
Dec 12 2019, 12:57 PM
bruno committed rGc43f3fbc8b65: Revert "[modules] Separately track whether an identifier's preprocessor… (authored by bruno).
Revert "[modules] Separately track whether an identifier's preprocessor…
Dec 12 2019, 12:13 PM
bruno committed rG6476c5481f95: [Modules] Prevent nonrecoverable module-out-of-date errors in projects that mix… (authored by bruno).
[Modules] Prevent nonrecoverable module-out-of-date errors in projects that mix…
Dec 12 2019, 11:58 AM
bruno committed rG3abd88dbf0c6: Revert support for serializing PPD_SKIPPED_RANGES. (authored by bruno).
Revert support for serializing PPD_SKIPPED_RANGES.
Dec 12 2019, 11:52 AM
bruno committed rG7d936ab817df: Turn -Wframework-include-private-from-public off by default (authored by bruno).
Turn -Wframework-include-private-from-public off by default
Dec 12 2019, 11:48 AM
bruno committed rG10cc4b4e5222: Turn -Watimport-in-framework-header off by default (authored by bruno).
Turn -Watimport-in-framework-header off by default
Dec 12 2019, 11:48 AM

Nov 22 2019

bruno accepted D70583: clang/Modules: Rename CompilerInstance::ModuleManager, NFC.

I have to assume there was a point in the past where they were just one class, but it's been pretty confusing for a while. I think it's time to fix it.

Nov 22 2019, 6:13 PM
bruno accepted D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC.

Nice! LGTM

Nov 22 2019, 6:08 PM

Nov 14 2019

bruno committed rG3466cebe94ba: Add a test to cover structural match for recursive data types (authored by bruno).
Add a test to cover structural match for recursive data types
Nov 14 2019, 6:35 PM

Nov 12 2019

bruno accepted D70063: clang/Modules: Error if ReadASTBlock does not find the main module.

LGTM with some minor comment below!

Nov 12 2019, 8:18 AM

Nov 11 2019

bruno added inline comments to D70063: clang/Modules: Error if ReadASTBlock does not find the main module.
Nov 11 2019, 5:04 PM

Oct 29 2019

bruno committed rG87a7ef1f60d4: Merge remote-tracking branch 'origin/master' into upstream-with-swift (authored by bruno).
Merge remote-tracking branch 'origin/master' into upstream-with-swift
Oct 29 2019, 5:02 PM
bruno committed rGcf8af681dcfb: Merge remote-tracking branch 'origin/master' into upstream-with-swift (authored by bruno).
Merge remote-tracking branch 'origin/master' into upstream-with-swift
Oct 29 2019, 4:56 PM
bruno committed rG533c30052285: Some changes got lost in some bad merge conflict a while ago. Re-introduce them… (authored by bruno).
Some changes got lost in some bad merge conflict a while ago. Re-introduce them…
Oct 29 2019, 4:56 PM
bruno committed rG22d214fdd69f: Merge remote-tracking branch 'origin/master' into upstream-with-swift (authored by bruno).
Merge remote-tracking branch 'origin/master' into upstream-with-swift
Oct 29 2019, 4:56 PM
bruno committed rGa273d71c5527: Update calls to getEndLoc and getStartLoc (authored by bruno).
Update calls to getEndLoc and getStartLoc
Oct 29 2019, 4:52 PM
bruno committed rG6b25b5f4e596: Merge remote-tracking branch 'origin/master' into upstream-with-swift (authored by bruno).
Merge remote-tracking branch 'origin/master' into upstream-with-swift
Oct 29 2019, 4:52 PM
bruno committed rG543c5c593a20: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by bruno).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 3:36 PM
bruno committed rG5278ab41a994: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by bruno).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 3:36 PM
bruno committed rGcc3c659fc702: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by bruno).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 3:15 PM
bruno committed rG3118e1c53d22: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by bruno).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 3:14 PM
bruno committed rG4a0522b6936f: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by bruno).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 3:08 PM
bruno committed rG3c28407998bb: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by bruno).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 2:30 PM
bruno committed rGa6cad39c6c00: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by bruno).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 2:29 PM
bruno committed rGbd64ca1c27cd: Merge branch 'opensource' into upstream-with-swift (authored by bruno).
Merge branch 'opensource' into upstream-with-swift
Oct 29 2019, 1:57 PM
bruno committed rGc67f4a85cf63: Merge branch 'mirror-master' into upstream-with-swift (authored by bruno).
Merge branch 'mirror-master' into upstream-with-swift
Oct 29 2019, 1:38 PM
bruno committed rG5b8049a6760f: Merge branch 'opensource' into upstream-with-swift (authored by bruno).
Merge branch 'opensource' into upstream-with-swift
Oct 29 2019, 1:38 PM
bruno committed rG52834b47b40a: Merge remote-tracking branch 'mirror/master' into upstream-with-swift (authored by bruno).
Merge remote-tracking branch 'mirror/master' into upstream-with-swift
Oct 29 2019, 1:05 PM
bruno committed rG766c60e4b972: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by bruno).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 12:22 PM
bruno committed rG1a7685a9b5ea: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by bruno).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 12:22 PM
bruno committed rG831912e6e3b1: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift (authored by bruno).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift
Oct 29 2019, 12:22 PM
bruno committed rGbebb9477e7c9: Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift-local (authored by bruno).
Merge remote-tracking branch 'llvm.org/master' into upstream-with-swift-local
Oct 29 2019, 12:21 PM

Oct 18 2019

bruno added a comment to D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..

While adding the documentation I realized that a better name for this option would be -fmodules-strict-context-hash to make it clear which hash it's referring to.

Oct 18 2019, 6:35 AM · Restricted Project

Oct 17 2019

bruno added a comment to D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..

*using implicit modules in a build where compiler flags in different invocations aren't homogeneous, or something along those lines.

Oct 17 2019, 2:57 PM · Restricted Project
bruno accepted D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..

LGTM with one minor change. Can you add an entry in the modules docs for this flag and mention that using it can lead to more PCMs in an implicit build?

Oct 17 2019, 2:57 PM · Restricted Project

Oct 15 2019

bruno committed rG1731fc88d1fa: Reapply: [Modules][PCH] Hash input files content (authored by bruno).
Reapply: [Modules][PCH] Hash input files content
Oct 15 2019, 7:30 AM
bruno committed rL374895: Reapply: [Modules][PCH] Hash input files content.
Reapply: [Modules][PCH] Hash input files content
Oct 15 2019, 7:30 AM

Oct 14 2019

bruno committed rG2a1386c81de5: [Modules][PCH] Hash input files content (authored by bruno).
[Modules][PCH] Hash input files content
Oct 14 2019, 4:01 PM
bruno closed D67249: [Modules][PCH] Hash input files content.
Oct 14 2019, 4:01 PM · Restricted Project
bruno committed rL374841: [Modules][PCH] Hash input files content.
[Modules][PCH] Hash input files content
Oct 14 2019, 4:01 PM
bruno accepted D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory..

This approach looks overall much better! Unless @sammccall has any extra comments, it LGTM.

Oct 14 2019, 10:15 AM · Restricted Project, Restricted Project
bruno added a comment to D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics..

Hi Michael, thanks for working on this!

Oct 14 2019, 9:57 AM · Restricted Project

Oct 1 2019

bruno added a reviewer for D67010: [Modules] Move search paths from control block to unhashed control block: v.g.vassilev.

Ping!

Oct 1 2019, 3:40 PM · Restricted Project
bruno added a reviewer for D67249: [Modules][PCH] Hash input files content: v.g.vassilev.

Ping!

Oct 1 2019, 3:40 PM · Restricted Project

Sep 16 2019

bruno committed rG919fc50034b4: [Modules][Objective-C] Use complete decl from module when diagnosing missing… (authored by bruno).
[Modules][Objective-C] Use complete decl from module when diagnosing missing…
Sep 16 2019, 3:03 PM
bruno committed rL372039: [Modules][Objective-C] Use complete decl from module when diagnosing missing….
[Modules][Objective-C] Use complete decl from module when diagnosing missing…
Sep 16 2019, 2:59 PM
bruno closed D66982: [Modules][Objective-C] Use complete decl from module when diagnosing missing import.
Sep 16 2019, 2:59 PM · Restricted Project, Restricted Project

Sep 13 2019

bruno added a comment to D67249: [Modules][PCH] Hash input files content.

Did you try xxHash64?

Sep 13 2019, 12:51 PM · Restricted Project
bruno added a comment to D66982: [Modules][Objective-C] Use complete decl from module when diagnosing missing import.

Ping!

Sep 13 2019, 12:46 PM · Restricted Project, Restricted Project

Sep 10 2019

bruno updated the diff for D67249: [Modules][PCH] Hash input files content.

Update the patch to use two ::Fixed, 32 in abbrev to encode hash.

Sep 10 2019, 2:24 PM · Restricted Project
bruno added inline comments to D67249: [Modules][PCH] Hash input files content.
Sep 10 2019, 2:15 PM · Restricted Project

Sep 6 2019

bruno updated the diff for D67249: [Modules][PCH] Hash input files content.

Remove pasto from one of the testcases

Sep 6 2019, 1:53 PM · Restricted Project
bruno updated the diff for D67249: [Modules][PCH] Hash input files content.

Update testcase to use a more portable version of touch

Sep 6 2019, 1:53 PM · Restricted Project
bruno added a comment to D67249: [Modules][PCH] Hash input files content.

Nice! Are you planning to address the FIXME's in a later update of this patch?

Sep 6 2019, 1:33 PM · Restricted Project

Sep 5 2019

bruno created D67249: [Modules][PCH] Hash input files content.
Sep 5 2019, 5:50 PM · Restricted Project

Sep 3 2019

bruno committed rL370794: Request commit access for bruno.
Request commit access for bruno
Sep 3 2019, 10:47 AM

Aug 30 2019

bruno created D67010: [Modules] Move search paths from control block to unhashed control block.
Aug 30 2019, 10:34 AM · Restricted Project
bruno accepted D66710: ASTReader: Bypass overridden files when reading PCHs.

LGTM!

Aug 30 2019, 10:23 AM

Aug 29 2019

bruno created D66982: [Modules][Objective-C] Use complete decl from module when diagnosing missing import.
Aug 29 2019, 4:36 PM · Restricted Project, Restricted Project
bruno committed rG4625c18b5f48: [Modules] Make ReadModuleMapFileBlock errors reliable (authored by bruno).
[Modules] Make ReadModuleMapFileBlock errors reliable
Aug 29 2019, 4:14 PM
bruno committed rL370422: [Modules] Make ReadModuleMapFileBlock errors reliable.
[Modules] Make ReadModuleMapFileBlock errors reliable
Aug 29 2019, 4:14 PM

Aug 28 2019

bruno added a comment to D66710: ASTReader: Bypass overridden files when reading PCHs.

Nice! Is this something that can be tested for in unittests/Basic/FileManagerTest.cpp?

Aug 28 2019, 4:57 PM
bruno accepted D66907: [Modules] Fix rebuilding an updated module for each of its consumers..

Thanks for fixing this, LGTM!

Aug 28 2019, 4:05 PM · Restricted Project

Aug 16 2019

bruno added a comment to D66172: [clang][Modules] Serialize decl to comment mapping to speed up code completion..

I'm curious to know if you measured the impact on the PCM size after this change (example: PCMs from building macOS public SDK)? For instance, PPD_SKIPPED_RANGES currently explodes for some specific inputs, just wonder what's the story here.

Aug 16 2019, 2:47 PM
bruno accepted D65545: Handle some fs::remove failures.

LGTM with one minor change.

Aug 16 2019, 2:32 PM · Restricted Project, Restricted Project
bruno added inline comments to D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations.
Aug 16 2019, 2:31 PM · Restricted Project, Restricted Project

Aug 9 2019

bruno accepted D65986: Allow setting the VFS to 'real' mode instead of default 'physical'.

LGTM

Aug 9 2019, 9:55 AM · Restricted Project

Aug 7 2019

bruno added a comment to D65846: Improve error message from FrontendAction.
Internal compiler error: LFS error for "/Users/jfb/s/llvmm/debug/tools/clang/test/Index/Output/pch-from-libclang.c.tmp.mcp/14EC4PG1UTVLY/modules.idx"failed to create unique file /Users/jfb/s/llvmm/debug/tools/clang/test/Index/Output/pch-from-libclang.c.tmp.mcp/14EC4PG1UTVLY/modules.idx.lock-0ae18733: No such file or directory
Aug 7 2019, 1:44 PM · Restricted Project

Aug 5 2019

bruno added a comment to D65545: Handle some fs::remove failures.

Thanks for working on this JF!

Aug 5 2019, 8:15 PM · Restricted Project, Restricted Project
bruno added a comment to D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory..

It seems conceptually a little strange to have the working directory be part of a serialized "FS", as it's fundamentally a property of a process and only transiently a property of the VFS.

Aug 5 2019, 7:59 PM · Restricted Project, Restricted Project

Jul 2 2019

bruno accepted D64113: [VFS] Add reverse iterator to OverlayFileSystem.

Nice, LGTM!

Jul 2 2019, 5:42 PM · Restricted Project
bruno added a comment to D64113: [VFS] Add reverse iterator to OverlayFileSystem.

Thanks for working on this. Can you add unit tests for those?

Jul 2 2019, 5:26 PM · Restricted Project

Jul 1 2019

bruno added a comment to D60974: Clang IFSO driver action..

I am currently working on the next part of clang interface stubs that will take the interface stubs per compilation unit and merge them into one text stub (which will be used by something like llvm-elfabi to generate a stubbed out ELF .so file). I was using llvm-nm, but there are cases where the symbol is present in the .o file but it is marked as HIDDEN and llvm-readelf was what I was using to determine if the symbol was in fact marked as hidden. In these cases, the linker will not emit the symbol in the final .so file but it still needs the symbol as part of linking.

Jul 1 2019, 3:24 PM · Restricted Project, Restricted Project

Jun 25 2019

bruno accepted D63518: BitStream reader: propagate errors.

LGTM

Jun 25 2019, 1:21 PM · Restricted Project, Restricted Project

Jun 19 2019

bruno added a comment to D63518: BitStream reader: propagate errors.

Hi JF. Thanks for working on this, nice improvement to error handling!

Jun 19 2019, 12:01 PM · Restricted Project, Restricted Project

Mar 6 2019

bruno accepted D58890: Modules: Rename MemoryBufferCache to InMemoryModuleCache.

ninja check-clang passes... is there anything else I should be testing?

Mar 6 2019, 10:09 AM

Mar 4 2019

bruno accepted D58893: Modules: Invalidate out-of-date PCMs as they're discovered.

Thanks for working on this, the approach & patch LGTM.

Mar 4 2019, 3:06 PM
bruno added a comment to D58890: Modules: Rename MemoryBufferCache to InMemoryModuleCache.

InMemoryModuleCache seems like a way more appropriate name here. Also thanks for improving some of the comments.

Mar 4 2019, 2:31 PM
bruno accepted D58891: Modules: Add -Rmodule-import.

Nice, note that a subset of this information can be achieved with -Wauto-import, but this is way more general and solid, since it will handles @imports and pragma imports too. LGTM with a minor nitpick, see comments.

Mar 4 2019, 2:17 PM

Feb 12 2019

bruno accepted D58072: Make ModuleDependencyCollector's method virtual (NFC).

LGTM!

Feb 12 2019, 1:25 PM · Restricted Project, Restricted Project
bruno added a comment to D58072: Make ModuleDependencyCollector's method virtual (NFC).

I missed that the DependencyCollector already marks them virtual, you are just making it obvious here. I think you can omit the ones that are already virtual and only add to the ones that are on the intend of this patch.

Feb 12 2019, 11:41 AM · Restricted Project, Restricted Project

Feb 11 2019

bruno added a comment to D58072: Make ModuleDependencyCollector's method virtual (NFC).

Not really. Would making only the attachTo* methods virtual enough though?

Feb 11 2019, 2:43 PM · Restricted Project, Restricted Project
bruno added a comment to D58072: Make ModuleDependencyCollector's method virtual (NFC).

How much of the ModuleDependencyCollector will be reused as is by LLDB? I wonder about the tradeoff versus inheriting from DependencyCollector directly.

Feb 11 2019, 1:23 PM · Restricted Project, Restricted Project

Jan 29 2019

bruno accepted D57411: [ModuleDependencyCollector] Use llvm::sys::fs::real_path.

Thanks for working on this! LGTM

Jan 29 2019, 8:05 PM