Page MenuHomePhabricator

bruno (Bruno Cardoso Lopes)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2014, 7:40 AM (319 w, 5 d)

Recent Activity

Mon, Sep 28

bruno added a comment to D87853: [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation.

Ping!

Mon, Sep 28, 2:26 PM · Restricted Project

Fri, Sep 25

bruno updated the summary of D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.
Fri, Sep 25, 12:09 PM
bruno requested review of D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas.
Fri, Sep 25, 11:47 AM
bruno added a comment to D78699: [X86] Passing union type through register..

Thanks, @bruno. Modifying the existing logic is risky. If we have to do that, I think a new patch will be better. The purpose of this patch is to solve an ABI bug.

Fri, Sep 25, 10:49 AM

Tue, Sep 22

bruno added a comment to D78699: [X86] Passing union type through register..

Hi, @majnemer, @bruno. I saw that both of you have modified this logic. What's your opinion here?

Tue, Sep 22, 1:38 PM
bruno accepted D86895: [Modules] Add stats to measure performance of building and loading modules..

This looks pretty useful, thanks for adding this Volodymyr. LGTM.

Tue, Sep 22, 10:46 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 21

bruno updated the diff for D87853: [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation.

Add context

Mon, Sep 21, 11:52 PM · Restricted Project
bruno updated the diff for D87853: [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation.

Hi Richard. Thanks for the quick feedback and for the testcase!

Mon, Sep 21, 11:38 PM · Restricted Project
bruno commandeered D87853: [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation.

I'm taking this over from Hongtao (w/ his blessing :)

Mon, Sep 21, 11:34 PM · Restricted Project

Tue, Sep 1

bruno added reviewers for D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`: rsmith, v.g.vassilev.
Tue, Sep 1, 11:42 AM · Restricted Project
bruno added inline comments to D86802: [Modules] Don't parse/load explicit module maps if modules are disabled.
Tue, Sep 1, 10:51 AM · Restricted Project
bruno updated subscribers of D86896: [Modules] Add a small test suite to measure modules' performance..
Tue, Sep 1, 10:28 AM · Restricted Project
bruno added a comment to D86896: [Modules] Add a small test suite to measure modules' performance..

Hi Volodymyr, this looks pretty interesting. Can you share screenshots or examples of how the output looks like?

Tue, Sep 1, 10:26 AM · Restricted Project

Aug 31 2020

bruno added a comment to D82118: [clang][module] Improve incomplete-umbrella warning.

Yes the wrapper is definitely problematic. I'm checking how the diagnostic itself is handled correctly and start from there when I have time. For now would it be better to separate this into multiple patches and get the diagnostic improvement in first?

Aug 31 2020, 10:29 AM · Restricted Project

Aug 28 2020

bruno added inline comments to D86802: [Modules] Don't parse/load explicit module maps if modules are disabled.
Aug 28 2020, 12:58 PM · Restricted Project
bruno added a comment to D86802: [Modules] Don't parse/load explicit module maps if modules are disabled.

Hi Andrew, thanks for improving this. I think this makes sense: dependents can choose to not use modules without having to trigger the build system to rebuild all dependencies. Can you add a simple testcase to prove the point of the change?

Aug 28 2020, 12:24 PM · Restricted Project

Aug 18 2020

bruno added a comment to D85810: [clang] Pass-through remarks options to linker.

Hi Wei, this looks handy! Minor stylish comments below.

Aug 18 2020, 12:58 PM · Restricted Project
bruno accepted D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled..

Nice catch! LGTM

Aug 18 2020, 11:43 AM · Restricted Project
bruno accepted D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations..

Neat unit test! LGTM (one minor suggestion below).

Aug 18 2020, 11:00 AM · Restricted Project
bruno added a comment to D82118: [clang][module] Improve incomplete-umbrella warning.

Hi Zixu, thanks for working on improving this.

Aug 18 2020, 10:51 AM · Restricted Project
bruno accepted D84458: [Modules] Improve error message when cannot find parent module for submodule definition..

LGTM as is, minor suggestion below.

Aug 18 2020, 10:25 AM · Restricted Project

Jul 14 2020

GitHub <noreply@github.com> committed rG47df64f64e5b: Merge pull request #1073 from bcardosolopes/apple-stable-20200108-x86-textual… (authored by bruno).
Merge pull request #1073 from bcardosolopes/apple-stable-20200108-x86-textual…
Jul 14 2020, 4:43 PM
bruno committed rGc5b600e0d508: [Modules] Add more x86 textual headers to the module map (authored by bruno).
[Modules] Add more x86 textual headers to the module map
Jul 14 2020, 4:43 PM
bruno committed rG915c19777ab4: [Modules] Reapply: Make header inclusion order from umbrella dirs deterministic (authored by bruno).
[Modules] Reapply: Make header inclusion order from umbrella dirs deterministic
Jul 14 2020, 4:34 PM
GitHub <noreply@github.com> committed rGdc2531c7537c: Merge pull request #925 from bcardosolopes/apple-stable-20200108-sort-umbrella… (authored by bruno).
Merge pull request #925 from bcardosolopes/apple-stable-20200108-sort-umbrella…
Jul 14 2020, 4:34 PM
GitHub <noreply@github.com> committed rGa8a4130d888b: Merge pull request #849 from bcardosolopes/apple-stable-20200108-odr-cc1-extra… (authored by bruno).
Merge pull request #849 from bcardosolopes/apple-stable-20200108-odr-cc1-extra…
Jul 14 2020, 4:30 PM
bruno committed rGfbe4d585a51f: [ODRHash] Add several `-cc1` options for fine grained odr checking control (authored by bruno).
[ODRHash] Add several `-cc1` options for fine grained odr checking control
Jul 14 2020, 4:29 PM
bruno committed rG9b3c79b06772: [PATCH] [ODRHash] Add basic support for hashing attributes (authored by bruno).
[PATCH] [ODRHash] Add basic support for hashing attributes
Jul 14 2020, 4:29 PM
GitHub <noreply@github.com> committed rGd82199c830d7: Merge pull request #848 from bcardosolopes/apple-stable-20200108-odr-hash… (authored by bruno).
Merge pull request #848 from bcardosolopes/apple-stable-20200108-odr-hash…
Jul 14 2020, 4:29 PM
bruno committed rG281a00fa0fbd: [ODRHash] Add tests for merging types for class extensions (authored by bruno).
[ODRHash] Add tests for merging types for class extensions
Jul 14 2020, 4:28 PM
GitHub <noreply@github.com> committed rG5af7e4e98743: Merge pull request #827 from bcardosolopes/apple-stable-20200108-odr-objc… (authored by bruno).
Merge pull request #827 from bcardosolopes/apple-stable-20200108-odr-objc…
Jul 14 2020, 4:28 PM
GitHub <noreply@github.com> committed rGf3aba2d9c5ef: Merge pull request #828 from bcardosolopes/apple-stable-20200108-odr-more… (authored by bruno).
Merge pull request #828 from bcardosolopes/apple-stable-20200108-odr-more…
Jul 14 2020, 4:28 PM
bruno committed rG4ceca22678dc: [ODRHash] Use more efficient storage for ODR hash in RecordDecl (authored by bruno).
[ODRHash] Use more efficient storage for ODR hash in RecordDecl
Jul 14 2020, 4:28 PM
GitHub <noreply@github.com> committed rGa23291837502: Merge pull request #829 from bcardosolopes/apple-stable-20200108-odr-merge… (authored by bruno).
Merge pull request #829 from bcardosolopes/apple-stable-20200108-odr-merge…
Jul 14 2020, 4:28 PM
bruno committed rGe4bb6d09a58c: [ODRHash] Change the approach to handle merging in absence of definitions (authored by bruno).
[ODRHash] Change the approach to handle merging in absence of definitions
Jul 14 2020, 4:28 PM
GitHub <noreply@github.com> committed rG4fb896257830: Merge pull request #825 from bcardosolopes/apple-stable-20200108-odr-objc… (authored by bruno).
Merge pull request #825 from bcardosolopes/apple-stable-20200108-odr-objc…
Jul 14 2020, 4:28 PM
bruno committed rG93169a318151: [PATCH 2/2] [Modules][ODRHash] Add support for merging ObjCCategoryDecl (authored by bruno).
[PATCH 2/2] [Modules][ODRHash] Add support for merging ObjCCategoryDecl
Jul 14 2020, 4:28 PM
bruno committed rGa79670c0f8ac: [PATCH 1/2] [ODRHash] ObjCInterface data merging: remove workaround to skip… (authored by bruno).
[PATCH 1/2] [ODRHash] ObjCInterface data merging: remove workaround to skip…
Jul 14 2020, 4:28 PM
GitHub <noreply@github.com> committed rGc2fcb08c022b: Merge pull request #798 from bcardosolopes/apple-stable-20200108-odr-objc… (authored by bruno).
Merge pull request #798 from bcardosolopes/apple-stable-20200108-odr-objc…
Jul 14 2020, 4:25 PM
bruno committed rG661447100e21: [ODRHash][APINotes] Prevent hashing OBJC_PR_null_resettable if from APINotes (authored by bruno).
[ODRHash][APINotes] Prevent hashing OBJC_PR_null_resettable if from APINotes
Jul 14 2020, 4:25 PM
GitHub <noreply@github.com> committed rG1e7da96039b3: Merge pull request #774 from bcardosolopes/apple-stable-20200108-odr-objc… (authored by bruno).
Merge pull request #774 from bcardosolopes/apple-stable-20200108-odr-objc…
Jul 14 2020, 4:23 PM
bruno committed rG7ab779297169: Use desugared type for ObjCProperty with nullable types (authored by bruno).
Use desugared type for ObjCProperty with nullable types
Jul 14 2020, 4:23 PM
GitHub <noreply@github.com> committed rGfa2348cb7738: Merge pull request #755 from bcardosolopes/apple-stable-20200108-odr-objc… (authored by bruno).
Merge pull request #755 from bcardosolopes/apple-stable-20200108-odr-objc…
Jul 14 2020, 4:22 PM
bruno committed rG74b87a0e8565: [ODRHash] Check references protocols as part of MergeDefintionData (authored by bruno).
[ODRHash] Check references protocols as part of MergeDefintionData
Jul 14 2020, 4:22 PM
GitHub <noreply@github.com> committed rG28a6983d3535: Merge pull request #724 from bcardosolopes/apple-stable-20200108-odr-objc… (authored by bruno).
Merge pull request #724 from bcardosolopes/apple-stable-20200108-odr-objc…
Jul 14 2020, 4:20 PM
bruno committed rG9cc6f4745141: [Modules][ODRHash] Add diagnostics for property implementation control mismatch (authored by bruno).
[Modules][ODRHash] Add diagnostics for property implementation control mismatch
Jul 14 2020, 4:20 PM
GitHub <noreply@github.com> committed rG120dbe8f28ee: Merge pull request #719 from bcardosolopes/apple-stable-20200108-odr-objc… (authored by bruno).
Merge pull request #719 from bcardosolopes/apple-stable-20200108-odr-objc…
Jul 14 2020, 4:20 PM
bruno committed rGa39404e1fdbf: [PATCH 3/3] [Modules][ODRHash] Add ODR checking for @protocols (authored by bruno).
[PATCH 3/3] [Modules][ODRHash] Add ODR checking for @protocols
Jul 14 2020, 4:20 PM
bruno committed rG15289bb26121: [PATCH 2/3] [ODRHash] Factor out protocol list checking from interface ODR… (authored by bruno).
[PATCH 2/3] [ODRHash] Factor out protocol list checking from interface ODR…
Jul 14 2020, 4:20 PM
bruno committed rG63e4fe0c0b78: [PATCH 1/3] [ODRHash] Change signature for ODRDiagDeclError and make it… (authored by bruno).
[PATCH 1/3] [ODRHash] Change signature for ODRDiagDeclError and make it…
Jul 14 2020, 4:20 PM
GitHub <noreply@github.com> committed rGab18ceb63dfd: Merge pull request #708 from bcardosolopes/apple-stable-20200108-odr-objc… (authored by bruno).
Merge pull request #708 from bcardosolopes/apple-stable-20200108-odr-objc…
Jul 14 2020, 4:19 PM
bruno committed rG6dd0ccf4ba53: [PATCH 2/2] [Modules][ODRHash] Add ODRHash support for ObjCProperty (authored by bruno).
[PATCH 2/2] [Modules][ODRHash] Add ODRHash support for ObjCProperty
Jul 14 2020, 4:19 PM
bruno committed rG3f298a31c27a: [PATCH 1/2] [ODRHash] Add missing unknown diagnostics for instance variable (authored by bruno).
[PATCH 1/2] [ODRHash] Add missing unknown diagnostics for instance variable
Jul 14 2020, 4:19 PM
GitHub <noreply@github.com> committed rG4cfc86ea895f: Merge pull request #691 from bcardosolopes/apple-stable-20200108-odr-ivars (authored by bruno).
Merge pull request #691 from bcardosolopes/apple-stable-20200108-odr-ivars
Jul 14 2020, 4:18 PM
bruno committed rGe1a75408145d: [PATCH 3/3] [Modules][ODRHash] Add support for ObjCIvar (authored by bruno).
[PATCH 3/3] [Modules][ODRHash] Add support for ObjCIvar
Jul 14 2020, 4:18 PM
bruno committed rG6aff6449f18e: [PATCH 2/3] [ODRHash] Add ObjectiveC specific diagnostic mismatch logic (NFC) (authored by bruno).
[PATCH 2/3] [ODRHash] Add ObjectiveC specific diagnostic mismatch logic (NFC)
Jul 14 2020, 4:18 PM
bruno committed rGf1c34c1764ad: [PATCH 1/3] [ODRHash] Simplify DiagnoseODRMismatch by splitting some… (authored by bruno).
[PATCH 1/3] [ODRHash] Simplify DiagnoseODRMismatch by splitting some…
Jul 14 2020, 4:18 PM
GitHub <noreply@github.com> committed rG4db5b23dc18b: Merge pull request #682 from bcardosolopes/apple-stable-20200108-anonymous… (authored by bruno).
Merge pull request #682 from bcardosolopes/apple-stable-20200108-anonymous…
Jul 14 2020, 4:18 PM
bruno committed rG1d3c6b22376c: Add support for anonymous structs and unions (authored by bruno).
Add support for anonymous structs and unions
Jul 14 2020, 4:18 PM
GitHub <noreply@github.com> committed rG49cc321afe32: Merge pull request #668 from bcardosolopes/apple-stable-20200108-odrhash… (authored by bruno).
Merge pull request #668 from bcardosolopes/apple-stable-20200108-odrhash…
Jul 14 2020, 4:17 PM
bruno committed rG291c974e9391: [Modules][ODRHash] Trigger ODR hashes for methods in a safe way (authored by bruno).
[Modules][ODRHash] Trigger ODR hashes for methods in a safe way
Jul 14 2020, 4:17 PM
GitHub <noreply@github.com> committed rG74c07d557b3e: Merge pull request #669 from bcardosolopes/apple-stable-20200108-add-fixit-to… (authored by bruno).
Merge pull request #669 from bcardosolopes/apple-stable-20200108-add-fixit-to…
Jul 14 2020, 4:17 PM
bruno committed rG034dde5c8b18: Include fixit hints in -diagnostic-log-file output (authored by bruno).
Include fixit hints in -diagnostic-log-file output
Jul 14 2020, 4:17 PM
GitHub <noreply@github.com> committed rG102ad3e9a721: Merge pull request #659 from bcardosolopes/apple-stable-20200108-odrhash… (authored by bruno).
Merge pull request #659 from bcardosolopes/apple-stable-20200108-odrhash…
Jul 14 2020, 4:16 PM
bruno committed rG4125236621c3: [Modules][ODRHash] Add support for checking ObjCMethodDecl (authored by bruno).
[Modules][ODRHash] Add support for checking ObjCMethodDecl
Jul 14 2020, 4:16 PM
bruno committed rG248363f073bb: [Modules][ODRHash] Factor out some CXXMethodDecl ODR violation checks (NFCI) (authored by bruno).
[Modules][ODRHash] Factor out some CXXMethodDecl ODR violation checks (NFCI)
Jul 14 2020, 4:16 PM
GitHub <noreply@github.com> committed rGd20ae6985438: Merge pull request #611 from bcardosolopes/apple-stable-20200108-odrhash… (authored by bruno).
Merge pull request #611 from bcardosolopes/apple-stable-20200108-odrhash…
Jul 14 2020, 4:14 PM
bruno committed rG62abd468e6c5: Add general ODR hash support for ObjCInterfaceDecl. (authored by bruno).
Add general ODR hash support for ObjCInterfaceDecl.
Jul 14 2020, 4:14 PM
bruno committed rG4ee45365bce9: Factor out logic from CXXRecordDecl to reuse for RecordDecl handling (NFC) (authored by bruno).
Factor out logic from CXXRecordDecl to reuse for RecordDecl handling (NFC)
Jul 14 2020, 4:14 PM
bruno committed rG832737b6a344: Refactor bits for tag types work (authored by bruno).
Refactor bits for tag types work
Jul 14 2020, 4:14 PM

Apr 21 2020

bruno committed rGd892eec710ca: Reapply: Make header inclusion order from umbrella dirs deterministic (authored by bruno).
Reapply: Make header inclusion order from umbrella dirs deterministic
Apr 21 2020, 4:17 PM

Mar 9 2020

bruno requested changes to D75323: Support relative dest paths in headermap files.

I also want to understand why you want this change. I'm not convinced this is the behavior we want and it's not like we encourage people to use header maps in the first place. I'd be fine with such behavior under a CC1 flag though. Falling back to the filesystem is something that pertains more to a VFS kinda thing than header maps.

Mar 9 2020, 7:26 PM · Restricted Project

Mar 3 2020

bruno accepted D75395: [clang][Modules] Add -fsystem-module flag.

LGTM

Mar 3 2020, 8:52 AM · Restricted Project

Mar 2 2020

bruno added a comment to D75395: [clang][Modules] Add -fsystem-module flag.

Hi Michael, thanks for improving this.

Mar 2 2020, 1:43 PM · Restricted Project

Feb 27 2020

bruno accepted D75311: [modules] Allow frameworks to have only a private module without a public one..

Sounds great!

Feb 27 2020, 4:38 PM · Restricted Project

Feb 24 2020

bruno added a comment to D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.

Ping!

Feb 24 2020, 1:52 PM · Restricted Project

Feb 19 2020

bruno added a comment to D74795: Make diagnostic reporting more robust in presence of corrupt PCH data..

Thanks for working on this.

Feb 19 2020, 3:24 PM · Restricted Project

Feb 13 2020

bruno updated the diff for D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.

Address Richard's review.

Feb 13 2020, 8:06 AM · Restricted Project
bruno added a comment to D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.

Thanks for taking a look Richard, comments inline.

Feb 13 2020, 8:06 AM · Restricted Project

Jan 31 2020

bruno updated the diff for D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.
  • Update patch after Volodymyr's review.
  • Refactor bits done as part of rG90f58eaeff5f, update it to remove that part.
Jan 31 2020, 5:50 PM · Restricted Project
bruno added a comment to D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.
  • Why are you adding ODR hash support for RecordDecl and not TagDecl? We already have support for EnumDecl, so TagDecl seems like a good candidate to cover both. Honestly, I don't know if it is possible or a good idea but it looks plausible enough to consider.
Jan 31 2020, 5:47 PM · Restricted Project

Jan 22 2020

bruno committed rG90f58eaeff5f: [ODRHash] Factor out functionality for CXXRecord ODR diagnostics (NFCI) (authored by bruno).
[ODRHash] Factor out functionality for CXXRecord ODR diagnostics (NFCI)
Jan 22 2020, 1:37 PM

Jan 10 2020

bruno updated the diff for D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.

Updated the patch to refactor mode code.

Jan 10 2020, 3:39 PM · Restricted Project
bruno added inline comments to D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.
Jan 10 2020, 9:53 AM · Restricted Project

Jan 9 2020

bruno committed rGe54af192450d: Handle tag types and complain about bad merges in C/Objective-C mode (authored by bruno).
Handle tag types and complain about bad merges in C/Objective-C mode
Jan 9 2020, 5:46 PM

Jan 8 2020

bruno updated the diff for D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.

Remove some FIXMEs that are now done.

Jan 8 2020, 10:03 PM · Restricted Project
bruno updated the summary of D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.
Jan 8 2020, 9:56 PM · Restricted Project
bruno added a comment to D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.
Jan 8 2020, 9:54 PM · Restricted Project
bruno updated the diff for D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.

Change the approach: handle type merging for tag types using the ODRHash mechanism

Jan 8 2020, 9:54 PM · Restricted Project

Dec 19 2019

bruno updated the summary of D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.
Dec 19 2019, 4:30 PM · Restricted Project
bruno created D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode.
Dec 19 2019, 4:30 PM · Restricted Project

Dec 12 2019

bruno committed rGdde37d52bc71: [Modules] Fix implicit modules 'could not read module signature' problem (authored by bruno).
[Modules] Fix implicit modules 'could not read module signature' problem
Dec 12 2019, 3:01 PM
bruno committed rG25027f26ad64: [Modules] Make ReadModuleMapFileBlock errors reliable (authored by bruno).
[Modules] Make ReadModuleMapFileBlock errors reliable
Dec 12 2019, 1:46 PM
bruno committed rG07aa5e7bf743: [Modules] Move FILE_SYSTEM_OPTIONS to the unhashed control block (authored by bruno).
[Modules] Move FILE_SYSTEM_OPTIONS to the unhashed control block
Dec 12 2019, 1:38 PM
bruno committed rG7bbc38d32acd: [Modules] Move search paths outside of the control block (authored by bruno).
[Modules] Move search paths outside of the control block
Dec 12 2019, 1:38 PM
bruno committed rG01336d79be59: [Modules][Objective-C] Use complete decl from module when diagnosing missing… (authored by bruno).
[Modules][Objective-C] Use complete decl from module when diagnosing missing…
Dec 12 2019, 1:28 PM
bruno committed rG7264ab365a83: [Modules] Use -skip-unused-modulemap-deps by default (authored by bruno).
[Modules] Use -skip-unused-modulemap-deps by default
Dec 12 2019, 1:17 PM
bruno committed rG093ca1263714: [Modules] Skip adding unused module maps to the dependency file (authored by bruno).
[Modules] Skip adding unused module maps to the dependency file
Dec 12 2019, 1:17 PM
bruno committed rG67c70038bcc0: Reinstate r310605: [Modules] Prevent #import to reenter header if not building… (authored by bruno).
Reinstate r310605: [Modules] Prevent #import to reenter header if not building…
Dec 12 2019, 12:57 PM
bruno committed rGc43f3fbc8b65: Revert "[modules] Separately track whether an identifier's preprocessor… (authored by bruno).
Revert "[modules] Separately track whether an identifier's preprocessor…
Dec 12 2019, 12:13 PM