- User Since
- Aug 15 2014, 7:40 AM (243 w, 6 d)
Mar 6 2019
ninja check-clang passes... is there anything else I should be testing?
Mar 4 2019
Thanks for working on this, the approach & patch LGTM.
InMemoryModuleCache seems like a way more appropriate name here. Also thanks for improving some of the comments.
Nice, note that a subset of this information can be achieved with -Wauto-import, but this is way more general and solid, since it will handles @imports and pragma imports too. LGTM with a minor nitpick, see comments.
Feb 12 2019
I missed that the DependencyCollector already marks them virtual, you are just making it obvious here. I think you can omit the ones that are already virtual and only add to the ones that are on the intend of this patch.
Feb 11 2019
Not really. Would making only the attachTo* methods virtual enough though?
How much of the ModuleDependencyCollector will be reused as is by LLDB? I wonder about the tradeoff versus inheriting from DependencyCollector directly.
Jan 29 2019
Thanks for working on this! LGTM
Jan 22 2019
Jan 15 2019
Jan 7 2019
Dec 13 2018
This fixes the same problem previously addressed in https://reviews.llvm.org/D54923
Abandon this one in favor of https://reviews.llvm.org/D55676
Dec 11 2018
Dec 10 2018
Dec 7 2018
Dec 4 2018
Update patch after @erik.pilkington review!
Address @rsmith comments
Nov 29 2018
@rsmith this is on the non-determinism issue we discussed offline. Do you have any concerns with this approach?
Looks like adding a test in test/Driver/clang_f_opts.c would be good here.
Thanks for working on this @andrewjcg
Out of curiosity, why? If it makes you happy though, go for it! LGTM
Nov 27 2018
Although we can't synthesize a testcase for inclusion in the patch. Here is how one should attempt to reproduce the problem in macOS 10.14.
Nov 26 2018
Nov 15 2018
Nov 13 2018
Nov 8 2018
Hi Volodymyr. Does this behavior changed after your VFS fallback change?
Oct 24 2018
Oct 23 2018
LGTM with some minor changes.
Hi Erik, thanks for improving this. Comments below.
Sep 20 2018
LGTM with one more small change.
Sep 18 2018
Sep 17 2018
Update patch after review.
Sep 14 2018
Addressed Adrian's review. Added support to consider the environment and well the combination platform-environment. @aprantl also handled multiple variants of simulator combinations.
Sep 10 2018
Aug 17 2018
Thanks for working on this Adrian, LGTM.
Aug 14 2018
Aug 7 2018
Thanks for the clean up! LGTM
Jul 20 2018
Jul 19 2018
Hi Volodymyr, thanks for improving this.
Thanks for working on this.
Jul 18 2018
Jul 12 2018
Jul 6 2018
Jun 29 2018
Jun 28 2018
Thanks for working on this, LGTM
It looks like the diagnostic options and few others were moved out from the control block in r297655 by Manman Ren. The header files are still part of the control block. The best I can do is buffer that information and print it out last. Is that what we want?
Jun 27 2018
Jun 25 2018
Jun 22 2018