User Details
- User Since
- Aug 15 2014, 7:40 AM (475 w, 2 d)
Aug 10 2023
May 4 2023
Thanks Duncan.
Adding code owners and more relevant folks
LGTM
Apr 25 2023
Looks like this patch causes a number of issues for us, I will work with @jansvoboda11 to see if there's some way to resolve them.
Apr 3 2023
Mar 23 2023
LGTM! @ChuanqiXu wdyt?
Mar 21 2023
Apply last round of reviews before landing
Add release notes entry.
Address last round of review
Put dependency in place for D145641
LGTM!
Mar 17 2023
... I think in general we want feature testing macros to be treated as our signal to the user that we think something is complete, not that we think something is in progress but pretty usable.
@bruno, @ChuanqiXu please let us know if you have any objections, otherwise we will land the revert in ~2 hours.
Mar 15 2023
Update after reviewer comments
Good catch, thanks! LGTM
Mar 9 2023
Test failures are unrelated, thanks for the review @ChuanqiXu
Mar 8 2023
Feb 23 2023
Thanks for working on this Wei!
Feb 3 2023
Only test failing is ClangScanDeps/modules-full.cpp on Windoes, which is unrelated to this change.
Update checks that rely on coroutine_traits in std-coroutine.h
Thanks for the review, will push once all tests pass!
Update patch to reuse std-coroutine.h and add a few more other bits there.
Jan 20 2023
Test failure is unrelated.
Jan 18 2023
Jan 17 2023
Nice new testcase snippets, LGTM
Dec 20 2022
Additionally, this likely deserves an entry in ./clang/docs/ReleaseNotes.rst.
Nice, thanks for adding the builtin layer.
Nov 17 2022
Also not using this at Meta, LGTM.
Nov 10 2022
Very nice how this has improved since the version I worked on in the past, thanks!
LGTM
Nov 1 2022
LGTM with minor nitpick: can you reflect in the title that this is related to header maps?
Oct 27 2022
Nice cleanup, before landing please capitalize remove in the title and also add [NFC] to it!
Nice catch, thanks for improving this.
Oct 26 2022
Oct 21 2022
Looks great, some minor suggestions.
Oct 17 2022
Thanks for the detailed explanations, LGTM!
Oct 14 2022
Great to see both this and D130325 landing, LGTM too.
Oct 12 2022
Thanks for working on this Troy, nice speed up.
Oct 10 2022
LGTM! Should we also add a release note or do we think this isn't enough of a compile-time performance improvement to warrant that?
LGTM
Oct 6 2022
Hi Troy, thanks for working on this, nice compile time perf savings. Can you update the diff to contain more context? If anything, -U 999999 or similar would do the job.
Sep 13 2022
I'm not sure how to deal with missing env -u.
- We could do env CLANG_MODULE_CACHE_PATH= and change the compiler's interpretation of empty string for this variable. I'm not sure if the current behaviour (there will be no module cache in the cc1 at all) is intentional or useful. Hesitant to change this behaviour.
Sep 9 2022
Awesome!
Thanks for the fast review! Good suggestions, will apply and land.
Jun 14 2022
LGTM
Jun 8 2022
Empty lines handling should also make it skipped, fix the 3 failures.
LGTM, thanks for the detailed explanation/comments. One minor nitpick inline.
Just noticed that 3 test cases failed. Please fix them before landing.
May 26 2022
Hi, nice to see this getting in. Comments inline!
May 25 2022
May 24 2022
Apr 6 2022
Apr 5 2022
Nice!
Mar 30 2022
Forgot to ask, is there anything preventing a testcase to be added here?
Mar 25 2022
LGTM
Mar 21 2022
This is pretty cool, I enjoy the idea of getting a tar out of a crash. I'm also a +1 for having this group of behaviors as a more official -femit-reproducer=<option> flag. In future work, do you plan to change the default crash mode to output a tar instead of multiple files?
Mar 7 2022
Why isn't D23934 sufficient? What do these flags with very long names do that ffixed-date-time doesn't?
Mar 3 2022
It would be nice to have some mechanism to notify developers that includes are still performed regardless of requires
LGTM
Nice cleanup, fixes and testcases, just pending test failures and this looks good.
LGTM
LGTM
Feb 18 2022
Could the test be tagged with keywords that would prevent the linting to kick in? The amount of changes for this and following patches seems too big to be worth the reformatting.
Feb 7 2022
The right solution to the paren problem is to add some notion of precedence (and associativity) to Nodes, but that's a larger change that would become simpler once the refactoring I'm doing is completed.
Feb 1 2022
LGTM
Nov 19 2021
Nov 18 2021
Given context from further patches in the set, I believe ptrauth operand bundle has been a good way to represent this and works well. LGTM
This is good to go, sorry for the delay.
LGTM