♟ bruno

LGTM with one more small change.

[Modules] Add platform and environment features to requires clause

Update patch after review.

Addressed Adrian's review. Added support to consider the environment and well the combination platform-environment. @aprantl also handled multiple variants of simulator combinations.

[Modules] Add imported modules to the output of -module-file-info

Revert "Add a basic integration test for C++ smart pointers"

Revert "[analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker"

Thanks for working on this Adrian, LGTM.

Revert "[DebugInfo] Generate DWARF debug information for labels. (Fix leak…

Thanks for the clean up! LGTM

[www] Add CodeCompass and CodeChecker to Clang Related Projects page

Hi Volodymyr, thanks for improving this.

Thanks for working on this.

[PCH+Modules] Load -fmodule-map-file content before including PCHs

Reapply r336660: [Modules] Autoload subdirectory modulemaps with specific…

Revert "[modules] Fix 37878; Autoload subdirectory modulemaps with specific…

Add protocol redefinition to the current scope/context

Thanks for working on this, LGTM

It looks like the diagnostic options and few others were moved out from the control block in r297655 by Manman Ren. The header files are still part of the control block. The best I can do is buffer that information and print it out last. Is that what we want?

[Modules][ObjC] Warn on the use of '@import' in framework headers

Fix tests from r335542 to use %hmaptool

Warning for framework include violation from Headers to PrivateHeaders

Re-apply: Warning for framework headers using double quote includes

Re-apply: Add python tool to dump and construct header maps

Revert "Add python tool to dump and construct header maps"

Revert "Warning for framework headers using double quote includes"

Revert "Fix hmaptool cmake file to work on Windows"

Address Volodymyr's comments

Fix hmaptool cmake file to work on Windows

Warning for framework headers using double quote includes

Fix WasmEHFuncInfo.h to include what it uses

Add python tool to dump and construct header maps

Update after Richard's review, fix python3 compatibility and check for zero sized string table

Hi Yuka, thanks for working on this.

[Modules] Improve .Private fix-its to handle 'explicit' and 'framework'

[CMAKE][c-index-test] Honor CMAKE_OSX_SYSROOT to compute include dir for libxml2

[CMAKE] Honor CMAKE_OSX_SYSROOT to compute include dir for libxml2

[Modules] Warning for module declarations lacking 'framework' qualifier

Without this patch, we would have to add binary header maps for tests in D47157 and D47301, which I would like to avoid.

Update patch after changes to D47157. Also address some of Volodymyr feedback.

Update after Duncan's review: remove header name from the warning message (since it's already in the fixit)

Updated the patch after Duncan and Aaron reviews. I actually went a bit more aggressive with the fixits, since I realized the conditions for the warning are already strict enough and we should take the chance to be more clear. For the attached testcase, the output now is:

Consistency would be nice, but at the same time, I don't see a good metric for when we'd know it's time to switch it to being on by default. I'm worried that it'll remain off by default forever simply because no one thinks to go turn it on (because it's silent by default). Perhaps on-by-default here and off-by-default downstream would be the better approach, or do you think this would be too disruptive to enable by default anywhere?

bruno (Bruno Cardoso Lopes)
User

Projects

User Details

Recent Activity
View All

Thu, Sep 20

Tue, Sep 18

Mon, Sep 17

Fri, Sep 14

Mon, Sep 10

Aug 17 2018

Aug 14 2018

Aug 7 2018

Jul 20 2018

Jul 19 2018

Jul 18 2018

Jul 12 2018

Jul 6 2018

Jun 29 2018

Jun 28 2018

Jun 27 2018

Jun 25 2018

Jun 22 2018

Jun 21 2018

Jun 20 2018

Jun 19 2018

Jun 18 2018

Jun 15 2018

Jun 14 2018

Jun 11 2018

Jun 8 2018

May 31 2018

May 30 2018

May 29 2018

bruno (Bruno Cardoso Lopes)User