- User Since
- Aug 15 2014, 7:40 AM (335 w, 3 d)
Fri, Jan 15
Nice correctness improvement!
Tue, Jan 12
Dec 9 2020
LGTM, it would be great if someone else stamps this too, in case I missed something.
Dec 4 2020
Dec 2 2020
Hmm... I'm using trunk lldb and gdb8.2, both of them can only print address. Btw, os is centos7.2, FYI.
Thanks for following up with this, I did miss to incorporate this suggestion! Out of curiosity, are you using lldb or gdb to print the variable? In lldb I already get values instead of address before this patch, so I wonder if one debugger needs more specific info than the other.
Nov 19 2020
Looking forward to see m68k support (and hopefully sega genesis toolchain support someday)!
Nov 18 2020
I forgot to follow up, but LGTM too.
Nov 10 2020
Very nice explanation, thanks for improving this!
Nov 9 2020
One of the another issue is that it is also necessary to track coroutine function parameters correctly under O1/O2 level which use dbg.value. Thoughts?
Could you add a test (or update existing tests) to demonstrate that the issue is fixed?
Nov 6 2020
Update comments and now use dbg.values after @jmorse feedback.
This patch works for llvm.dbg.addr. So what is status of llvm.dbg.addr? does anyone know about it ?
Nov 5 2020
Hi Jeremy, thanks for taking a deep look here.
Nov 4 2020
Nov 2 2020
Oct 20 2020
Oct 13 2020
Oct 12 2020
Oct 8 2020
Oct 6 2020
Sep 28 2020
Sep 25 2020
Thanks, @bruno. Modifying the existing logic is risky. If we have to do that, I think a new patch will be better. The purpose of this patch is to solve an ABI bug.
Sep 22 2020
This looks pretty useful, thanks for adding this Volodymyr. LGTM.
Sep 21 2020
Hi Richard. Thanks for the quick feedback and for the testcase!
I'm taking this over from Hongtao (w/ his blessing :)
Sep 1 2020
Hi Volodymyr, this looks pretty interesting. Can you share screenshots or examples of how the output looks like?
Aug 31 2020
Yes the wrapper is definitely problematic. I'm checking how the diagnostic itself is handled correctly and start from there when I have time. For now would it be better to separate this into multiple patches and get the diagnostic improvement in first?
Aug 28 2020
Hi Andrew, thanks for improving this. I think this makes sense: dependents can choose to not use modules without having to trigger the build system to rebuild all dependencies. Can you add a simple testcase to prove the point of the change?
Aug 18 2020
Hi Wei, this looks handy! Minor stylish comments below.
Nice catch! LGTM
Neat unit test! LGTM (one minor suggestion below).
Hi Zixu, thanks for working on improving this.
LGTM as is, minor suggestion below.