Page MenuHomePhabricator

bruno (Bruno Cardoso Lopes)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2014, 7:40 AM (261 w, 23 h)

Recent Activity

Yesterday

bruno added a comment to D66172: [clang][Modules] Serialize decl to comment mapping to speed up code completion..

I'm curious to know if you measured the impact on the PCM size after this change (example: PCMs from building macOS public SDK)? For instance, PPD_SKIPPED_RANGES currently explodes for some specific inputs, just wonder what's the story here.

Fri, Aug 16, 2:47 PM
bruno accepted D65545: Handle some fs::remove failures.

LGTM with one minor change.

Fri, Aug 16, 2:32 PM · Restricted Project, Restricted Project
bruno added inline comments to D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations.
Fri, Aug 16, 2:31 PM · Restricted Project

Fri, Aug 9

bruno accepted D65986: Allow setting the VFS to 'real' mode instead of default 'physical'.

LGTM

Fri, Aug 9, 9:55 AM · Restricted Project

Wed, Aug 7

bruno added a comment to D65846: Improve error message from FrontendAction.
Internal compiler error: LFS error for "/Users/jfb/s/llvmm/debug/tools/clang/test/Index/Output/pch-from-libclang.c.tmp.mcp/14EC4PG1UTVLY/modules.idx"failed to create unique file /Users/jfb/s/llvmm/debug/tools/clang/test/Index/Output/pch-from-libclang.c.tmp.mcp/14EC4PG1UTVLY/modules.idx.lock-0ae18733: No such file or directory
Wed, Aug 7, 1:44 PM · Restricted Project

Mon, Aug 5

bruno added a comment to D65545: Handle some fs::remove failures.

Thanks for working on this JF!

Mon, Aug 5, 8:15 PM · Restricted Project, Restricted Project
bruno added a comment to D65677: [VirtualFileSystem] Support encoding a current working directory in a VFS mapping..

It seems conceptually a little strange to have the working directory be part of a serialized "FS", as it's fundamentally a property of a process and only transiently a property of the VFS.

Mon, Aug 5, 7:59 PM · Restricted Project, Restricted Project

Jul 2 2019

bruno accepted D64113: [VFS] Add reverse iterator to OverlayFileSystem.

Nice, LGTM!

Jul 2 2019, 5:42 PM · Restricted Project
bruno added a comment to D64113: [VFS] Add reverse iterator to OverlayFileSystem.

Thanks for working on this. Can you add unit tests for those?

Jul 2 2019, 5:26 PM · Restricted Project

Jul 1 2019

bruno added a comment to D60974: Clang IFSO driver action..

I am currently working on the next part of clang interface stubs that will take the interface stubs per compilation unit and merge them into one text stub (which will be used by something like llvm-elfabi to generate a stubbed out ELF .so file). I was using llvm-nm, but there are cases where the symbol is present in the .o file but it is marked as HIDDEN and llvm-readelf was what I was using to determine if the symbol was in fact marked as hidden. In these cases, the linker will not emit the symbol in the final .so file but it still needs the symbol as part of linking.

Jul 1 2019, 3:24 PM · Restricted Project, Restricted Project

Jun 25 2019

bruno accepted D63518: BitStream reader: propagate errors.

LGTM

Jun 25 2019, 1:21 PM · Restricted Project, Restricted Project

Jun 19 2019

bruno added a comment to D63518: BitStream reader: propagate errors.

Hi JF. Thanks for working on this, nice improvement to error handling!

Jun 19 2019, 12:01 PM · Restricted Project, Restricted Project

Mar 6 2019

bruno accepted D58890: Modules: Rename MemoryBufferCache to InMemoryModuleCache.

ninja check-clang passes... is there anything else I should be testing?

Mar 6 2019, 10:09 AM

Mar 4 2019

bruno accepted D58893: Modules: Invalidate out-of-date PCMs as they're discovered.

Thanks for working on this, the approach & patch LGTM.

Mar 4 2019, 3:06 PM
bruno added a comment to D58890: Modules: Rename MemoryBufferCache to InMemoryModuleCache.

InMemoryModuleCache seems like a way more appropriate name here. Also thanks for improving some of the comments.

Mar 4 2019, 2:31 PM
bruno accepted D58891: Modules: Add -Rmodule-import.

Nice, note that a subset of this information can be achieved with -Wauto-import, but this is way more general and solid, since it will handles @imports and pragma imports too. LGTM with a minor nitpick, see comments.

Mar 4 2019, 2:17 PM

Feb 12 2019

bruno accepted D58072: Make ModuleDependencyCollector's method virtual (NFC).

LGTM!

Feb 12 2019, 1:25 PM · Restricted Project, Restricted Project
bruno added a comment to D58072: Make ModuleDependencyCollector's method virtual (NFC).

I missed that the DependencyCollector already marks them virtual, you are just making it obvious here. I think you can omit the ones that are already virtual and only add to the ones that are on the intend of this patch.

Feb 12 2019, 11:41 AM · Restricted Project, Restricted Project

Feb 11 2019

bruno added a comment to D58072: Make ModuleDependencyCollector's method virtual (NFC).

Not really. Would making only the attachTo* methods virtual enough though?

Feb 11 2019, 2:43 PM · Restricted Project, Restricted Project
bruno added a comment to D58072: Make ModuleDependencyCollector's method virtual (NFC).

How much of the ModuleDependencyCollector will be reused as is by LLDB? I wonder about the tradeoff versus inheriting from DependencyCollector directly.

Feb 11 2019, 1:23 PM · Restricted Project, Restricted Project

Jan 29 2019

bruno accepted D57411: [ModuleDependencyCollector] Use llvm::sys::fs::real_path.

Thanks for working on this! LGTM

Jan 29 2019, 8:05 PM

Jan 22 2019

bruno added a comment to D55676: [Modules] Fix decl order for DeclsInPrototype.

Ping

Jan 22 2019, 11:07 AM

Jan 15 2019

bruno added a comment to D55676: [Modules] Fix decl order for DeclsInPrototype.

Ping!

Jan 15 2019, 10:45 AM

Jan 7 2019

bruno added inline comments to D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a.
Jan 7 2019, 4:47 PM · Restricted Project

Dec 13 2018

bruno added a comment to D55676: [Modules] Fix decl order for DeclsInPrototype.

This fixes the same problem previously addressed in https://reviews.llvm.org/D54923

Dec 13 2018, 2:49 PM
bruno abandoned D54923: [Modules] Remove non-determinism while serializing DECL_CONTEXT_LEXICAL and DECL_RECORD.

Abandon this one in favor of https://reviews.llvm.org/D55676

Dec 13 2018, 2:48 PM
bruno created D55676: [Modules] Fix decl order for DeclsInPrototype.
Dec 13 2018, 2:48 PM

Dec 11 2018

bruno added a comment to D54923: [Modules] Remove non-determinism while serializing DECL_CONTEXT_LEXICAL and DECL_RECORD.

Ping

Dec 11 2018, 10:37 AM

Dec 10 2018

bruno added a comment to D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a.

Hi Eric,

Dec 10 2018, 11:30 AM · Restricted Project
bruno committed rC348789: [constexpr][c++2a] Try-catch blocks in constexpr functions.
[constexpr][c++2a] Try-catch blocks in constexpr functions
Dec 10 2018, 11:06 AM
bruno committed rL348789: [constexpr][c++2a] Try-catch blocks in constexpr functions.
[constexpr][c++2a] Try-catch blocks in constexpr functions
Dec 10 2018, 11:06 AM
bruno closed D55097: [constexpr][c++2a] Try-catch blocks in constexpr functions.
Dec 10 2018, 11:06 AM

Dec 7 2018

bruno updated the diff for D55097: [constexpr][c++2a] Try-catch blocks in constexpr functions.

Address @aaron.ballman and @erik.pilkington reviews.

Dec 7 2018, 5:52 PM

Dec 4 2018

bruno added a comment to D54923: [Modules] Remove non-determinism while serializing DECL_CONTEXT_LEXICAL and DECL_RECORD.

Ping!

Dec 4 2018, 5:26 PM
bruno updated the diff for D55097: [constexpr][c++2a] Try-catch blocks in constexpr functions.

Update patch after @erik.pilkington review!

Dec 4 2018, 4:46 PM
bruno updated the diff for D55097: [constexpr][c++2a] Try-catch blocks in constexpr functions.

Address @rsmith comments

Dec 4 2018, 12:43 AM

Nov 29 2018

bruno added a comment to D54923: [Modules] Remove non-determinism while serializing DECL_CONTEXT_LEXICAL and DECL_RECORD.

@rsmith this is on the non-determinism issue we discussed offline. Do you have any concerns with this approach?

Nov 29 2018, 7:17 PM
bruno added a comment to D54880: Ignore gcc's stack-clash-protection flag.

Looks like adding a test in test/Driver/clang_f_opts.c would be good here.

Nov 29 2018, 6:50 PM · Restricted Project
bruno added a comment to D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.

Thanks for working on this @andrewjcg

Nov 29 2018, 6:33 PM
bruno accepted D52967: Extend shelf-life by 70 years.

Out of curiosity, why? If it makes you happy though, go for it! LGTM

Nov 29 2018, 5:50 PM · Restricted Project
bruno created D55097: [constexpr][c++2a] Try-catch blocks in constexpr functions.
Nov 29 2018, 5:24 PM
bruno accepted D55037: [-gmodules] Honor -fdebug-prefix-map in the debug info inside PCMs..

LGTM

Nov 29 2018, 1:39 PM

Nov 27 2018

bruno added a comment to D54923: [Modules] Remove non-determinism while serializing DECL_CONTEXT_LEXICAL and DECL_RECORD.

Although we can't synthesize a testcase for inclusion in the patch. Here is how one should attempt to reproduce the problem in macOS 10.14.

Nov 27 2018, 10:18 AM

Nov 26 2018

bruno created D54923: [Modules] Remove non-determinism while serializing DECL_CONTEXT_LEXICAL and DECL_RECORD.
Nov 26 2018, 6:01 PM

Nov 15 2018

bruno accepted D54245: [VFS] Implement `RedirectingFileSystem::getRealPath`..

LGTM

Nov 15 2018, 1:26 PM

Nov 13 2018

bruno accepted D54503: [HeaderSearch] loadSubdirectoryModuleMaps should respect -working-directory.

LGTM

Nov 13 2018, 5:00 PM

Nov 8 2018

bruno added a comment to D54245: [VFS] Implement `RedirectingFileSystem::getRealPath`..

Hi Volodymyr. Does this behavior changed after your VFS fallback change?

Nov 8 2018, 12:01 PM

Oct 24 2018

bruno added a reviewer for D53465: [VFS] Add support for "no_push" to VFS recursive iterators.: vsapsai.
Oct 24 2018, 6:42 PM

Oct 23 2018

bruno accepted D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system..

LGTM with some minor changes.

Oct 23 2018, 11:28 AM
bruno accepted D53228: [VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS..

LGTM.

Oct 23 2018, 11:20 AM
bruno added a comment to D53522: [Frontend] Include module map header declaration in dependency file output.

Hi Erik, thanks for improving this. Comments below.

Oct 23 2018, 11:16 AM

Sep 20 2018

bruno added a comment to D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system..

Hi Volodymyr,

Sep 20 2018, 1:29 PM
bruno accepted D52253: Fix an assert in the implementation of -Wquoted-include-in-framework-header.

LGTM with one more small change.

Sep 20 2018, 11:45 AM

Sep 18 2018

bruno added a comment to D52253: Fix an assert in the implementation of -Wquoted-include-in-framework-header.

Hi Erik,

Sep 18 2018, 6:35 PM
bruno committed rL342499: [Modules] Add platform and environment features to requires clause.
[Modules] Add platform and environment features to requires clause
Sep 18 2018, 10:15 AM
bruno committed rC342499: [Modules] Add platform and environment features to requires clause.
[Modules] Add platform and environment features to requires clause
Sep 18 2018, 10:15 AM
bruno closed D51910: [Modules] Add platform feature to requires clause.
Sep 18 2018, 10:15 AM
bruno closed D51910: [Modules] Add platform feature to requires clause.
Sep 18 2018, 10:15 AM

Sep 17 2018

bruno updated the diff for D51910: [Modules] Add platform feature to requires clause.

Update patch after review.

Sep 17 2018, 6:22 PM
bruno added inline comments to D51910: [Modules] Add platform feature to requires clause.
Sep 17 2018, 2:43 PM

Sep 14 2018

bruno updated the diff for D51910: [Modules] Add platform feature to requires clause.

Addressed Adrian's review. Added support to consider the environment and well the combination platform-environment. @aprantl also handled multiple variants of simulator combinations.

Sep 14 2018, 4:33 PM

Sep 10 2018

bruno committed rC341902: [Modules] Add imported modules to the output of -module-file-info.
[Modules] Add imported modules to the output of -module-file-info
Sep 10 2018, 10:18 PM
bruno committed rL341902: [Modules] Add imported modules to the output of -module-file-info.
[Modules] Add imported modules to the output of -module-file-info
Sep 10 2018, 10:18 PM
bruno created D51910: [Modules] Add platform feature to requires clause.
Sep 10 2018, 9:49 PM

Aug 17 2018

bruno committed rL340119: Revert "Add a basic integration test for C++ smart pointers".
Revert "Add a basic integration test for C++ smart pointers"
Aug 17 2018, 9:17 PM
bruno committed rL340117: Revert "[analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker".
Revert "[analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker"
Aug 17 2018, 8:23 PM
bruno committed rC340117: Revert "[analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker".
Revert "[analyzer] [NFC] Split up RetainSummaryManager from RetainCountChecker"
Aug 17 2018, 8:22 PM
bruno accepted D50870: Close FileEntries of cached files in ModuleManager::addModule()..

Thanks for working on this Adrian, LGTM.

Aug 17 2018, 6:16 PM

Aug 14 2018

bruno committed rL339700: Revert "[DebugInfo] Generate DWARF debug information for labels. (Fix leak….
Revert "[DebugInfo] Generate DWARF debug information for labels. (Fix leak…
Aug 14 2018, 10:55 AM

Aug 7 2018

bruno accepted D50118: [VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended..

Thanks for the clean up! LGTM

Aug 7 2018, 11:18 AM
bruno accepted D49518: [VFS] Emit an error when a file isn't located in any directory..

LGTM

Aug 7 2018, 11:11 AM

Jul 20 2018

bruno committed rL337555: [www] Add CodeCompass and CodeChecker to Clang Related Projects page.
[www] Add CodeCompass and CodeChecker to Clang Related Projects page
Jul 20 2018, 7:51 AM
bruno committed rC337555: [www] Add CodeCompass and CodeChecker to Clang Related Projects page.
[www] Add CodeCompass and CodeChecker to Clang Related Projects page
Jul 20 2018, 7:51 AM

Jul 19 2018

bruno added a comment to D49518: [VFS] Emit an error when a file isn't located in any directory..

Hi Volodymyr, thanks for improving this.

Jul 19 2018, 6:50 AM
bruno accepted D48786: [Preprocessor] Stop entering included files after hitting a fatal error..

Thanks for working on this.

Jul 19 2018, 5:49 AM
bruno committed rC337447: [PCH+Modules] Load -fmodule-map-file content before including PCHs.
[PCH+Modules] Load -fmodule-map-file content before including PCHs
Jul 19 2018, 5:38 AM
bruno committed rL337447: [PCH+Modules] Load -fmodule-map-file content before including PCHs.
[PCH+Modules] Load -fmodule-map-file content before including PCHs
Jul 19 2018, 5:37 AM
bruno closed D48685: [PCH+Modules] Load -fmodule-map-file content before including PCHs.
Jul 19 2018, 5:37 AM

Jul 18 2018

bruno committed rL337430: Reapply r336660: [Modules] Autoload subdirectory modulemaps with specific….
Reapply r336660: [Modules] Autoload subdirectory modulemaps with specific…
Jul 18 2018, 4:26 PM
bruno committed rC337430: Reapply r336660: [Modules] Autoload subdirectory modulemaps with specific….
Reapply r336660: [Modules] Autoload subdirectory modulemaps with specific…
Jul 18 2018, 4:26 PM

Jul 12 2018

bruno committed rL336920: Revert "[modules] Fix 37878; Autoload subdirectory modulemaps with specific….
Revert "[modules] Fix 37878; Autoload subdirectory modulemaps with specific…
Jul 12 2018, 10:44 AM
bruno committed rC336920: Revert "[modules] Fix 37878; Autoload subdirectory modulemaps with specific….
Revert "[modules] Fix 37878; Autoload subdirectory modulemaps with specific…
Jul 12 2018, 10:44 AM

Jul 6 2018

bruno added a comment to D48685: [PCH+Modules] Load -fmodule-map-file content before including PCHs.

Ping!

Jul 6 2018, 10:59 AM

Jun 29 2018

bruno committed rL336031: Add protocol redefinition to the current scope/context.
Add protocol redefinition to the current scope/context
Jun 29 2018, 5:54 PM
bruno committed rC336031: Add protocol redefinition to the current scope/context.
Add protocol redefinition to the current scope/context
Jun 29 2018, 5:54 PM
bruno closed D47297: [Modules][ObjC] Add protocol redefinition to the current scope/context.
Jun 29 2018, 5:54 PM
bruno closed D47297: [Modules][ObjC] Add protocol redefinition to the current scope/context.
Jun 29 2018, 5:54 PM
bruno added inline comments to D47297: [Modules][ObjC] Add protocol redefinition to the current scope/context.
Jun 29 2018, 11:37 AM
bruno added a comment to D47297: [Modules][ObjC] Add protocol redefinition to the current scope/context.

Ping!

Jun 29 2018, 10:11 AM

Jun 28 2018

bruno accepted D48736: [frontend] Don't include the C++ stdlib for -x assembler-with-cpp.

LGTM

Jun 28 2018, 3:57 PM
bruno added inline comments to D48736: [frontend] Don't include the C++ stdlib for -x assembler-with-cpp.
Jun 28 2018, 2:58 PM
bruno accepted D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts.

Thanks for working on this, LGTM

Jun 28 2018, 11:00 AM
bruno accepted D47118: [modules] Print input files when -module-file-info file switch is passed..

It looks like the diagnostic options and few others were moved out from the control block in r297655 by Manman Ren. The header files are still part of the control block. The best I can do is buffer that information and print it out last. Is that what we want?

Jun 28 2018, 9:47 AM

Jun 27 2018

bruno created D48685: [PCH+Modules] Load -fmodule-map-file content before including PCHs.
Jun 27 2018, 4:45 PM
bruno committed rL335780: [Modules][ObjC] Warn on the use of '@import' in framework headers.
[Modules][ObjC] Warn on the use of '@import' in framework headers
Jun 27 2018, 1:34 PM
bruno committed rC335780: [Modules][ObjC] Warn on the use of '@import' in framework headers.
[Modules][ObjC] Warn on the use of '@import' in framework headers
Jun 27 2018, 1:34 PM

Jun 25 2018

bruno closed D47301: Warning for framework include violation from Headers to PrivateHeaders.

Committed r335542

Jun 25 2018, 3:36 PM
bruno committed rL335543: Fix tests from r335542 to use %hmaptool.
Fix tests from r335542 to use %hmaptool
Jun 25 2018, 3:30 PM
bruno committed rC335543: Fix tests from r335542 to use %hmaptool.
Fix tests from r335542 to use %hmaptool
Jun 25 2018, 3:30 PM
bruno committed rC335542: Warning for framework include violation from Headers to PrivateHeaders.
Warning for framework include violation from Headers to PrivateHeaders
Jun 25 2018, 3:29 PM