bruno (Bruno Cardoso Lopes)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2014, 7:40 AM (200 w, 4 d)

Recent Activity

Today

bruno accepted D48297: [Darwin] Add a warning for missing include path for libstdc++.

LGTM

Tue, Jun 19, 10:57 AM

Yesterday

bruno added inline comments to D48297: [Darwin] Add a warning for missing include path for libstdc++.
Mon, Jun 18, 2:26 PM

Fri, Jun 15

bruno committed rC334859: [Modules] Improve .Private fix-its to handle 'explicit' and 'framework'.
[Modules] Improve .Private fix-its to handle 'explicit' and 'framework'
Fri, Jun 15, 1:17 PM
bruno committed rL334859: [Modules] Improve .Private fix-its to handle 'explicit' and 'framework'.
[Modules] Improve .Private fix-its to handle 'explicit' and 'framework'
Fri, Jun 15, 1:17 PM

Thu, Jun 14

bruno committed rC334747: [CMAKE][c-index-test] Honor CMAKE_OSX_SYSROOT to compute include dir for libxml2.
[CMAKE][c-index-test] Honor CMAKE_OSX_SYSROOT to compute include dir for libxml2
Thu, Jun 14, 11:24 AM
bruno committed rL334747: [CMAKE][c-index-test] Honor CMAKE_OSX_SYSROOT to compute include dir for libxml2.
[CMAKE][c-index-test] Honor CMAKE_OSX_SYSROOT to compute include dir for libxml2
Thu, Jun 14, 11:24 AM
bruno committed rL334746: [CMAKE] Honor CMAKE_OSX_SYSROOT to compute include dir for libxml2.
[CMAKE] Honor CMAKE_OSX_SYSROOT to compute include dir for libxml2
Thu, Jun 14, 11:24 AM

Mon, Jun 11

bruno accepted D47929: Add modules support for lldb headers in include/.

LGTM

Mon, Jun 11, 11:35 AM

Fri, Jun 8

bruno added a comment to D47929: Add modules support for lldb headers in include/.

Very nice!

Fri, Jun 8, 9:49 AM

Thu, May 31

bruno committed rL333718: [Modules] Warning for module declarations lacking 'framework' qualifier.
[Modules] Warning for module declarations lacking 'framework' qualifier
Thu, May 31, 6:30 PM
bruno committed rC333718: [Modules] Warning for module declarations lacking 'framework' qualifier.
[Modules] Warning for module declarations lacking 'framework' qualifier
Thu, May 31, 6:30 PM
bruno added a reviewer for D47297: [Modules][ObjC] Add protocol redefinition to the current scope/context: arphaman.
Thu, May 31, 5:19 PM
bruno added a comment to D46485: Add python tool to dump and construct header maps.

Without this patch, we would have to add binary header maps for tests in D47157 and D47301, which I would like to avoid.

Thu, May 31, 5:18 PM
bruno added inline comments to D47301: Warning for framework include violation from Headers to PrivateHeaders.
Thu, May 31, 2:58 PM
bruno updated the diff for D47301: Warning for framework include violation from Headers to PrivateHeaders.

Update patch after changes to D47157. Also address some of Volodymyr feedback.

Thu, May 31, 2:52 PM
bruno added inline comments to D47157: Warning for framework headers using double quote includes.
Thu, May 31, 2:41 PM
bruno updated the diff for D47157: Warning for framework headers using double quote includes.

Update after Duncan's review: remove header name from the warning message (since it's already in the fixit)

Thu, May 31, 2:40 PM
bruno updated the diff for D47157: Warning for framework headers using double quote includes.

Updated the patch after Duncan and Aaron reviews. I actually went a bit more aggressive with the fixits, since I realized the conditions for the warning are already strict enough and we should take the chance to be more clear. For the attached testcase, the output now is:

Thu, May 31, 10:45 AM

Wed, May 30

bruno added inline comments to D47157: Warning for framework headers using double quote includes.
Wed, May 30, 3:46 PM
bruno added inline comments to D47157: Warning for framework headers using double quote includes.
Wed, May 30, 3:18 PM
bruno updated subscribers of D47157: Warning for framework headers using double quote includes.
Wed, May 30, 3:05 PM

Tue, May 29

bruno added a comment to D47157: Warning for framework headers using double quote includes.

Consistency would be nice, but at the same time, I don't see a good metric for when we'd know it's time to switch it to being on by default. I'm worried that it'll remain off by default forever simply because no one thinks to go turn it on (because it's silent by default). Perhaps on-by-default here and off-by-default downstream would be the better approach, or do you think this would be too disruptive to enable by default anywhere?

Tue, May 29, 3:26 PM
bruno added a comment to D45012: [Modules] Skip adding unused module maps to the dependency file.

Ping

Tue, May 29, 2:59 PM
bruno added a comment to D46485: Add python tool to dump and construct header maps.

Ping!

Tue, May 29, 2:58 PM

Wed, May 23

bruno added a comment to D47157: Warning for framework headers using double quote includes.

Hi Eugene,

Wed, May 23, 4:45 PM
bruno updated the diff for D47301: Warning for framework include violation from Headers to PrivateHeaders.

Update to a more recent version of the patch.

Wed, May 23, 4:37 PM
bruno created D47301: Warning for framework include violation from Headers to PrivateHeaders.
Wed, May 23, 4:36 PM
bruno added a dependent revision for D47157: Warning for framework headers using double quote includes: D47301: Warning for framework include violation from Headers to PrivateHeaders.
Wed, May 23, 4:36 PM
bruno created D47297: [Modules][ObjC] Add protocol redefinition to the current scope/context.
Wed, May 23, 3:45 PM

Mon, May 21

bruno updated the diff for D46485: Add python tool to dump and construct header maps.

Remove more outdated comments

Mon, May 21, 4:28 PM
bruno added a comment to D47157: Warning for framework headers using double quote includes.

See also PR22165.

Mon, May 21, 3:40 PM
bruno added a comment to D47157: Warning for framework headers using double quote includes.

Depends on D46485

Mon, May 21, 1:27 PM
bruno created D47157: Warning for framework headers using double quote includes.
Mon, May 21, 1:21 PM
bruno updated the diff for D46485: Add python tool to dump and construct header maps.

Update testcases (and fixed a missing one) after Duncan's review.

Mon, May 21, 11:51 AM
bruno added a comment to D47118: [modules] Print input files when -module-file-info file switch is passed..

Thanks for improving this Vassil. Where does in the output it shows up? I wonder if we should have those at the end given the huge amount of headers some modules might have.

Mon, May 21, 11:08 AM

May 18 2018

bruno added inline comments to D46485: Add python tool to dump and construct header maps.
May 18 2018, 4:31 PM

May 16 2018

bruno committed rC332491: [Modules] Do not diagnose missing import in recovery mode if there isn't a decl….
[Modules] Do not diagnose missing import in recovery mode if there isn't a decl…
May 16 2018, 10:04 AM
bruno committed rL332491: [Modules] Do not diagnose missing import in recovery mode if there isn't a decl….
[Modules] Do not diagnose missing import in recovery mode if there isn't a decl…
May 16 2018, 10:04 AM

May 15 2018

bruno updated the diff for D46485: Add python tool to dump and construct header maps.

Update after Jan review.

May 15 2018, 9:49 PM
bruno added inline comments to D46485: Add python tool to dump and construct header maps.
May 15 2018, 9:48 PM
bruno added a comment to D46485: Add python tool to dump and construct header maps.

@jkorous, thanks for taking a look. This is an old python script which I haven't touched before, maybe there were answers to your questions but they are now lost in time. I'll address the review though and upload a new version.

May 15 2018, 1:46 PM

May 14 2018

bruno added a comment to D46485: Add python tool to dump and construct header maps.

Ping

May 14 2018, 5:37 PM

May 9 2018

bruno added a comment to D46485: Add python tool to dump and construct header maps.

Ping!

May 9 2018, 10:43 AM

May 4 2018

bruno created D46485: Add python tool to dump and construct header maps.
May 4 2018, 5:47 PM

May 1 2018

bruno committed rL331322: [Modules] Allow @import to reach submodules in private module maps.
[Modules] Allow @import to reach submodules in private module maps
May 1 2018, 7:28 PM
bruno committed rC331322: [Modules] Allow @import to reach submodules in private module maps.
[Modules] Allow @import to reach submodules in private module maps
May 1 2018, 7:28 PM
bruno accepted D30881: Track skipped files in dependency scanning.

Thanks for the detailed answers. LGTM

May 1 2018, 4:11 PM
bruno accepted D34848: Driver: Don't mix system tools with devtoolset tools on RHEL.

LGTM, thanks!

May 1 2018, 3:23 PM
bruno closed D46165: [Modules] Handle ObjC/C ODR-like semantics for EnumConstantDecl.

Landed in r331232 & r331233.

May 1 2018, 10:13 AM

Apr 30 2018

bruno committed rL331233: [Modules] Fix testcases from r331232.
[Modules] Fix testcases from r331232
Apr 30 2018, 4:02 PM
bruno committed rC331233: [Modules] Fix testcases from r331232.
[Modules] Fix testcases from r331232
Apr 30 2018, 4:02 PM
bruno committed rC331232: [Modules] Handle ObjC/C ODR-like semantics for EnumConstantDecl.
[Modules] Handle ObjC/C ODR-like semantics for EnumConstantDecl
Apr 30 2018, 3:18 PM
bruno committed rL331232: [Modules] Handle ObjC/C ODR-like semantics for EnumConstantDecl.
[Modules] Handle ObjC/C ODR-like semantics for EnumConstantDecl
Apr 30 2018, 3:18 PM
bruno added inline comments to D46165: [Modules] Handle ObjC/C ODR-like semantics for EnumConstantDecl.
Apr 30 2018, 2:24 PM

Apr 27 2018

bruno committed rL331063: [Modules][ObjC] ASTReader should add protocols for class extensions.
[Modules][ObjC] ASTReader should add protocols for class extensions
Apr 27 2018, 11:04 AM
bruno committed rC331063: [Modules][ObjC] ASTReader should add protocols for class extensions.
[Modules][ObjC] ASTReader should add protocols for class extensions
Apr 27 2018, 11:04 AM

Apr 26 2018

bruno created D46165: [Modules] Handle ObjC/C ODR-like semantics for EnumConstantDecl.
Apr 26 2018, 6:25 PM

Apr 19 2018

bruno accepted D37475: Make MultiplexASTDeserializationListener part of the API [NFC].

LGTM

Apr 19 2018, 11:13 AM

Apr 17 2018

bruno committed rC330240: [Modules] Turn on system header validation for implicit modules.
[Modules] Turn on system header validation for implicit modules
Apr 17 2018, 11:13 PM
bruno committed rL330240: [Modules] Turn on system header validation for implicit modules.
[Modules] Turn on system header validation for implicit modules
Apr 17 2018, 11:13 PM

Apr 16 2018

bruno committed rL330152: Use export_as for autolinking frameworks.
Use export_as for autolinking frameworks
Apr 16 2018, 12:46 PM
bruno committed rC330152: Use export_as for autolinking frameworks.
Use export_as for autolinking frameworks
Apr 16 2018, 12:45 PM

Apr 10 2018

bruno added a comment to D45165: Use llvm::sys::fs::real_path() in clang..

Thanks Nico!

Apr 10 2018, 11:41 AM

Mar 29 2018

bruno committed rL328857: [Modules] Improve fixit for framework private module maps.
[Modules] Improve fixit for framework private module maps
Mar 29 2018, 10:21 PM
bruno committed rC328857: [Modules] Improve fixit for framework private module maps.
[Modules] Improve fixit for framework private module maps
Mar 29 2018, 10:21 PM

Mar 28 2018

bruno created D45012: [Modules] Skip adding unused module maps to the dependency file.
Mar 28 2018, 7:35 PM

Mar 27 2018

bruno accepted D44901: [Diag] Avoid emitting a redefinition note if no location is available..

LGTM

Mar 27 2018, 3:47 PM

Mar 23 2018

bruno added a comment to D34848: Driver: Don't mix system tools with devtoolset tools on RHEL.

Is there a way to test this?

Mar 23 2018, 5:02 PM
bruno added inline comments to D43871: [modules] No longer include stdlib.h from mm_malloc.h..
Mar 23 2018, 5:02 PM
bruno added a comment to D42608: Driver: Prefer vendor supplied gcc toolchain.

The change seems fine.

Mar 23 2018, 4:51 PM
bruno accepted D44130: Driver: Add gcc search path for RHEL devtoolset-7.

LGTM

Mar 23 2018, 4:47 PM
Herald added a reviewer for D41979: [bcanalyzer] Recognize more stream types: george.karpenkov.
Mar 23 2018, 3:54 PM

Mar 22 2018

bruno accepted D44652: [vfs] Don't bail out after a missing -ivfsoverlay file.

One minor suggestion but otherwise LGTM

Mar 22 2018, 3:34 PM
bruno accepted D44498: Sink PrettyDeclStackTrace down to the AST library.

Hi Jordan,

Mar 22 2018, 2:56 PM

Mar 20 2018

bruno committed rC328053: [Modules] Honor -fmodule-name when handling private framework modules.
[Modules] Honor -fmodule-name when handling private framework modules
Mar 20 2018, 3:41 PM
bruno committed rL328053: [Modules] Honor -fmodule-name when handling private framework modules.
[Modules] Honor -fmodule-name when handling private framework modules
Mar 20 2018, 3:41 PM

Feb 15 2018

bruno committed rL325305: [Modules] Extend -fmodule-name semantic for frameworks with private modules.
[Modules] Extend -fmodule-name semantic for frameworks with private modules
Feb 15 2018, 4:17 PM
bruno committed rC325305: [Modules] Extend -fmodule-name semantic for frameworks with private modules.
[Modules] Extend -fmodule-name semantic for frameworks with private modules
Feb 15 2018, 4:17 PM

Feb 14 2018

bruno committed rL325154: [Modules] Add more language features to be used with requires-declaration.
[Modules] Add more language features to be used with requires-declaration
Feb 14 2018, 11:03 AM
bruno committed rC325154: [Modules] Add more language features to be used with requires-declaration.
[Modules] Add more language features to be used with requires-declaration
Feb 14 2018, 11:03 AM

Feb 12 2018

bruno committed rC324965: [Modules] Fix remapping from Foo.Private to Foo_Private to happen before typo….
[Modules] Fix remapping from Foo.Private to Foo_Private to happen before typo…
Feb 12 2018, 3:45 PM
bruno committed rL324965: [Modules] Fix remapping from Foo.Private to Foo_Private to happen before typo….
[Modules] Fix remapping from Foo.Private to Foo_Private to happen before typo…
Feb 12 2018, 3:45 PM

Feb 9 2018

bruno accepted D43128: Introduce an API for LLDB to compute the default module cache path.

LGTM

Feb 9 2018, 10:18 AM

Jan 11 2018

bruno accepted D40758: PeepholeOptimizer: Do not form PHI with subreg operands.

LGTM

Jan 11 2018, 10:03 AM

Jan 5 2018

bruno committed rC321906: Track shadow modules with a generation counter..
Track shadow modules with a generation counter.
Jan 5 2018, 2:15 PM
bruno committed rL321906: Track shadow modules with a generation counter..
Track shadow modules with a generation counter.
Jan 5 2018, 2:15 PM
bruno accepted D40983: Generate Libclang invocation reproducers using a new -cc1gen-reproducer option.

Makes sense, LGTM.

Jan 5 2018, 2:02 PM
bruno accepted D40712: [Driver] Add flag enabling the function stack size section that was added in r319430.

Thanks! LGTM

Jan 5 2018, 1:58 PM
bruno accepted D41733: [Driver] Suggest correctly spelled driver options.

Thanks! LGTM.

Jan 5 2018, 1:55 PM

Jan 4 2018

bruno committed rL321855: Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to….
Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to…
Jan 4 2018, 6:34 PM
bruno committed rC321855: Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to….
Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to…
Jan 4 2018, 6:34 PM
bruno added a comment to D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor..

The change seems good to me in general. I wonder if this will hit any broken assumption in the code. Did you run other tests beside unittests?

Jan 4 2018, 3:00 PM
bruno added a comment to D41733: [Driver] Suggest correctly spelled driver options.

This is great!

Jan 4 2018, 12:56 PM
bruno accepted D41544: Use backslash escape, replacing xargs -0 in test macro-multiline.c.

LGTM

Jan 4 2018, 10:19 AM
bruno added inline comments to D40712: [Driver] Add flag enabling the function stack size section that was added in r319430.
Jan 4 2018, 10:17 AM

Jan 3 2018

bruno committed rC321786: Revert "[Modules] Allow modules specified by -fmodule-map-file to shadow….
Revert "[Modules] Allow modules specified by -fmodule-map-file to shadow…
Jan 3 2018, 11:33 PM
bruno committed rL321786: Revert "[Modules] Allow modules specified by -fmodule-map-file to shadow….
Revert "[Modules] Allow modules specified by -fmodule-map-file to shadow…
Jan 3 2018, 11:32 PM
bruno committed rC321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly….
[Modules] Allow modules specified by -fmodule-map-file to shadow implicitly…
Jan 3 2018, 6:19 PM
bruno committed rL321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly….
[Modules] Allow modules specified by -fmodule-map-file to shadow implicitly…
Jan 3 2018, 6:18 PM
bruno closed D31269: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones.
Jan 3 2018, 6:18 PM