bruno (Bruno Cardoso Lopes)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 15 2014, 7:40 AM (170 w, 6 d)

Recent Activity

Fri, Nov 17

bruno accepted D39990: Use TempFile in the implementation of LockFileManager.

LGTM as well!

Fri, Nov 17, 6:33 PM

Thu, Nov 16

bruno committed rL318507: Change path used in a test from r318503 to work on windows.
Change path used in a test from r318503 to work on windows
Thu, Nov 16, 8:26 PM
bruno committed rL318503: [PCH+Modules] Improve diagnosticts to help out users pass an extra header….
[PCH+Modules] Improve diagnosticts to help out users pass an extra header…
Thu, Nov 16, 7:24 PM

Tue, Nov 14

bruno added a comment to D33275: Keep into account if files were virtual..

Ping!

Tue, Nov 14, 11:25 AM

Oct 23 2017

bruno committed rL316414: [Modules] Add module for Config/llvm-config.h.
[Modules] Add module for Config/llvm-config.h
Oct 23 2017, 11:19 PM

Oct 17 2017

bruno committed rL316016: [OpenCL] Restrict swizzle length check to OpenCL mode.
[OpenCL] Restrict swizzle length check to OpenCL mode
Oct 17 2017, 10:55 AM
bruno closed D38868: [OpenCL] Restrict swizzle length check to OpenCL mode by committing rL316016: [OpenCL] Restrict swizzle length check to OpenCL mode.
Oct 17 2017, 10:55 AM

Oct 14 2017

bruno committed rL315829: Mark test as unsupported until r315808 is fixed.
Mark test as unsupported until r315808 is fixed
Oct 14 2017, 3:14 PM
bruno committed rL315823: Revert "[AArch64][RegisterBankInfo] Use the statically computed mappings for….
Revert "[AArch64][RegisterBankInfo] Use the statically computed mappings for…
Oct 14 2017, 12:31 PM

Oct 13 2017

bruno updated the diff for D38868: [OpenCL] Restrict swizzle length check to OpenCL mode.

Update patch after Anastasia's suggestions

Oct 13 2017, 1:18 PM
bruno added inline comments to D38868: [OpenCL] Restrict swizzle length check to OpenCL mode.
Oct 13 2017, 11:45 AM
bruno committed rL315712: Revert "[lit] Raise the logic for enabling clang & lld substitutions to llvm.".
Revert "[lit] Raise the logic for enabling clang & lld substitutions to llvm."
Oct 13 2017, 10:11 AM

Oct 12 2017

bruno created D38868: [OpenCL] Restrict swizzle length check to OpenCL mode.
Oct 12 2017, 5:55 PM
bruno committed rL315618: Revert "Reintroduce "[SCCP] Propagate integer range info for parameters in….
Revert "Reintroduce "[SCCP] Propagate integer range info for parameters in…
Oct 12 2017, 1:52 PM
bruno committed rL315593: Reintroduce "[SCCP] Propagate integer range info for parameters in IPSCCP.".
Reintroduce "[SCCP] Propagate integer range info for parameters in IPSCCP."
Oct 12 2017, 9:54 AM

Oct 10 2017

bruno accepted D38699: [llvm-objdump] Disable leak checking on an llvm-objdump test.

Hi Francis,

Oct 10 2017, 10:12 AM
bruno committed rL315329: Revert "[SCCP] Propagate integer range info for parameters in IPSCCP.".
Revert "[SCCP] Propagate integer range info for parameters in IPSCCP."
Oct 10 2017, 9:38 AM
bruno committed rL315328: Revert "[SCCP] Fix mem-sanitizer failure introduced by r315288.".
Revert "[SCCP] Fix mem-sanitizer failure introduced by r315288."
Oct 10 2017, 9:38 AM

Oct 9 2017

bruno committed rL315242: Revert r315214 since diff -Z isn't portable, this is breaking:.
Revert r315214 since diff -Z isn't portable, this is breaking:
Oct 9 2017, 1:24 PM

Sep 28 2017

bruno accepted D38364: Fix Modules/builtin-import.mm to be able to handle non-Darwin targets.

Thanks Filipe, LGTM

Sep 28 2017, 10:36 AM

Sep 27 2017

bruno accepted D38208: Add support for remembering origins to ExternalASTMerger.

LGTM

Sep 27 2017, 10:16 AM · Restricted Project

Sep 25 2017

bruno added inline comments to D38208: Add support for remembering origins to ExternalASTMerger.
Sep 25 2017, 5:02 AM · Restricted Project
bruno added a comment to D36589: Add support for remembering origins to ExternalASTMerger.

Thanks for the additional docs! More comments below.

Sep 25 2017, 5:02 AM · Restricted Project

Sep 22 2017

bruno added a comment to D37299: [Modules] Add ability to specify module name to module file mapping in a file.

Hi Boris,

Sep 22 2017, 11:50 AM
bruno accepted D32520: Support __fp16 vectors.

Thanks Akira.

Sep 22 2017, 11:04 AM

Sep 20 2017

bruno added a comment to D36589: Add support for remembering origins to ExternalASTMerger.

Hi Sean,

Sep 20 2017, 4:50 PM · Restricted Project

Sep 19 2017

bruno added inline comments to D32520: Support __fp16 vectors.
Sep 19 2017, 4:04 PM

Sep 5 2017

bruno committed rL312599: Fix indentation mistake from r312595.
Fix indentation mistake from r312595
Sep 5 2017, 5:45 PM
bruno committed rL312595: [Darwin] Enable -fstack-protector (back) by default with -ffreestanding.
[Darwin] Enable -fstack-protector (back) by default with -ffreestanding
Sep 5 2017, 4:52 PM

Aug 11 2017

bruno committed rL310775: Revert "[Modules] Prevent #import to reenter header if not building a module.".
Revert "[Modules] Prevent #import to reenter header if not building a module."
Aug 11 2017, 6:39 PM

Aug 10 2017

bruno committed rL310605: [Modules] Prevent #import to reenter header if not building a module..
[Modules] Prevent #import to reenter header if not building a module.
Aug 10 2017, 8:17 AM

Aug 2 2017

bruno added inline comments to D34878: [ARM] Option for reading thread pointer from coprocessor register.
Aug 2 2017, 10:58 AM

Aug 1 2017

bruno committed rL309752: [Headers][Darwin] Allow #include_next<float.h> to work on Darwin prior to 10.7.
[Headers][Darwin] Allow #include_next<float.h> to work on Darwin prior to 10.7
Aug 1 2017, 3:11 PM
bruno committed rL309722: [Sema] Fix lax conversion between non ext vectors.
[Sema] Fix lax conversion between non ext vectors
Aug 1 2017, 12:06 PM

Jul 28 2017

bruno added a comment to D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor..

One more comment: please also fix names of local variables, member variables and function parameters. See https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly. Yes, there is precedence for violations in other places in this file, but that doesn't mean we should keep adding those :-)

Jul 28 2017, 9:39 AM

Jul 27 2017

bruno added a comment to D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor..

Added test for the fix.

Jul 27 2017, 10:02 AM

Jul 25 2017

bruno added a comment to D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor..

As I can see the clang/test contains a lot of different simple tests, but for testing this I think it is not enough to run the clang with some arguments on a specific input. So I should create a new executable which uses the postorder mode of the RecursiveASTVisitor. Am I right or is there another preferred way for doing this?

Jul 25 2017, 9:56 AM
bruno added a comment to D34878: [ARM] Option for reading thread pointer from coprocessor register.

If there's a precedence for a flag name there, it's nice to be compatible here. You don't necessarily need to use the same name as the backend.

Jul 25 2017, 9:53 AM

Jul 24 2017

bruno added a comment to D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor..

Hi Peter,

Jul 24 2017, 12:12 PM
bruno added a comment to D34878: [ARM] Option for reading thread pointer from coprocessor register.

Hi Strahinja,

Jul 24 2017, 12:04 PM

Jul 17 2017

bruno added a comment to D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT.

Could something like _WIN32 && _MSC_VER make this better? That would allow us to differentiate between the various environments. It's kinda icky, but, does make sense in a round about way.

Jul 17 2017, 3:03 PM
bruno committed rL308225: Check for _MSC_VER before defining _LIBCPP_MSVCRT.
Check for _MSC_VER before defining _LIBCPP_MSVCRT
Jul 17 2017, 2:53 PM
bruno closed D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT by committing rL308225: Check for _MSC_VER before defining _LIBCPP_MSVCRT.
Jul 17 2017, 2:53 PM

Jul 9 2017

bruno added a comment to D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT.

Thinking more about this, on Windows, is there a strong reason to default to a different libc by default on Windows?

Jul 9 2017, 6:13 AM

Jul 6 2017

bruno added a comment to D34985: Do not read the file to determine its name..

@v.g.vassilev will this also benefit from ContentCache::getBuffer improvements from D33275? I guess if getBuffer transparently handles pointing to right buffer we won't need this change?

Jul 6 2017, 3:14 PM
bruno added a comment to D33275: Keep into account if files were virtual..

That sounds even better. Thanks @v.g.vassilev

Jul 6 2017, 3:06 PM
bruno accepted D33275: Keep into account if files were virtual..

We're hitting a very similar problem to this one, which I think this patch will likely fix. I can't come up with a reproducible testcase either. If you can write one better yet, but I'm ok with this as is. LGTM.

Jul 6 2017, 2:56 PM

Jun 30 2017

bruno accepted D34510: Teach clang how to merge typedef over anonymous structs in C mode..

Tested it locally, we actually need all these changes on top of D31778.

Jun 30 2017, 5:26 PM
bruno committed rL306918: [Modules] Implement ODR-like semantics for tag types in C/ObjC.
[Modules] Implement ODR-like semantics for tag types in C/ObjC
Jun 30 2017, 5:07 PM
bruno closed D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC by committing rL306918: [Modules] Implement ODR-like semantics for tag types in C/ObjC.
Jun 30 2017, 5:07 PM
bruno committed rL306917: Change enumerator default linkage type for C.
Change enumerator default linkage type for C
Jun 30 2017, 5:06 PM
bruno added a comment to D34510: Teach clang how to merge typedef over anonymous structs in C mode..

Hi @v.g.vassilev, sorry for the delay.

Jun 30 2017, 10:04 AM
bruno updated the diff for D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC.

Digging into this a bit more, I think the root of the problem is that the ND->isExternallyVisible() call in LookupResult::isHiddenDeclarationVisible is wrong. Redeclaration lookup should never find hidden enumerators in C, because they do not have linkage (C11 6.2.2/6). (The same is true in C++, but I don't know whether we can apply the same thing there too, due to the different

merging rules.) A function foo in some source file should not conflict with an enumerator foo in a non-imported module, for instance.

The linkage of an enumerator should probably be VisibleNoLinkage, and isHiddenDeclarationVisible should probably be checking hasExternalFormalLinkage...

Jun 30 2017, 9:54 AM

Jun 29 2017

bruno accepted D34788: [ASTReader] Add test for previous change r306583 / 145692e..

LGTM! Thanks Graydon

Jun 29 2017, 12:17 PM

Jun 26 2017

bruno updated the diff for D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT.

Update patch after reviewer suggestions!

Jun 26 2017, 9:29 AM
bruno added inline comments to D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT.
Jun 26 2017, 9:28 AM

Jun 23 2017

bruno created D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT.
Jun 23 2017, 5:33 PM

Jun 22 2017

bruno added a reviewer for D34469: Use vfs::FileSystem in ASTUnit when creating CompilerInvocation.: bruno.

Any reason why this doesn't contain a testcase?

Jun 22 2017, 10:36 AM

Jun 20 2017

bruno committed rL305875: Support MS builtins using 'long' on LP64 platforms.
Support MS builtins using 'long' on LP64 platforms
Jun 20 2017, 7:21 PM
bruno closed D34377: Support MS builtins using 'long' on LP64 by committing rL305875: Support MS builtins using 'long' on LP64 platforms.
Jun 20 2017, 7:21 PM
bruno committed rL305874: Run dos2unix on ms-intrinsics-rotations.c test. NFC.
Run dos2unix on ms-intrinsics-rotations.c test. NFC
Jun 20 2017, 7:21 PM
bruno updated the diff for D34377: Support MS builtins using 'long' on LP64.

Addressing comments!

Jun 20 2017, 6:23 PM
bruno added inline comments to D34377: Support MS builtins using 'long' on LP64.
Jun 20 2017, 6:21 PM
bruno updated the diff for D34377: Support MS builtins using 'long' on LP64.

New patch addressing comments from reviewers.

Jun 20 2017, 4:22 PM
bruno added inline comments to D34377: Support MS builtins using 'long' on LP64.
Jun 20 2017, 2:30 PM
bruno added inline comments to D34377: Support MS builtins using 'long' on LP64.
Jun 20 2017, 2:25 PM
bruno added inline comments to D34377: Support MS builtins using 'long' on LP64.
Jun 20 2017, 1:44 PM

Jun 19 2017

bruno created D34377: Support MS builtins using 'long' on LP64.
Jun 19 2017, 6:43 PM

Jun 6 2017

bruno accepted D33732: Catch invalid bitwise operation on vector of floats.

LGTM

Jun 6 2017, 2:52 PM
bruno added a comment to D33719: Add _Float16 as a C/C++ source language type.

About the tests and using --target=aarch64: you're right that there should nothing be ARM specific here, but it is just that for Aarch64 it will show "half" IR types which I preferred, while it looks like x86 way of dealing with is to convert it and work on i16 types. Perhaps I need tests for both?

Jun 6 2017, 2:50 PM

Jun 2 2017

bruno added a comment to D33732: Catch invalid bitwise operation on vector of floats.

Hi,

Jun 2 2017, 1:35 PM
bruno accepted D33788: Return a canonical path from getClangResourcePath().

Yes, but that does not canonicalize the path. For instance, it won't handle doubled-up slashes or symlinks.

Jun 2 2017, 11:57 AM
bruno added a comment to D33788: Return a canonical path from getClangResourcePath().

I'm unaware of any other API that canonicalizes the path, which is what users of this API are going to expect.

Jun 2 2017, 11:29 AM

Jun 1 2017

bruno added a reviewer for D33788: Return a canonical path from getClangResourcePath(): bruno.

Hi Aaron,

Jun 1 2017, 6:35 PM
bruno accepted D33703: Support lazy stat'ing of files referenced by module maps.

LGTM!

Jun 1 2017, 6:31 PM
bruno added a reviewer for D33719: Add _Float16 as a C/C++ source language type: bruno.
Jun 1 2017, 6:21 PM
bruno added a comment to D33719: Add _Float16 as a C/C++ source language type.

Hi Sjoerd,

Jun 1 2017, 6:20 PM
bruno added a comment to D32520: Support __fp16 vectors.

Hi Akira,

Jun 1 2017, 5:46 PM
bruno added a comment to D33703: Support lazy stat'ing of files referenced by module maps.

Hi Richard,

Jun 1 2017, 4:45 PM

May 24 2017

bruno accepted D33357: Avoid calling report_fatal_error in the destructor of raw_fd_ostream when saving a module timestamp file.

Makes sense. LGTM!

May 24 2017, 3:56 PM

May 23 2017

bruno committed rL303705: [Modules] Fix overly conservative assertion for import diagnostic.
[Modules] Fix overly conservative assertion for import diagnostic
May 23 2017, 4:53 PM
bruno closed D32828: [Modules] Fix conservative assertion for import diagnostics by committing rL303705: [Modules] Fix overly conservative assertion for import diagnostic.
May 23 2017, 4:53 PM
bruno updated the diff for D32828: [Modules] Fix conservative assertion for import diagnostics.

Updated the patch after Richard's comments. Removed the assertion but bail out early if the module is already visible.

May 23 2017, 3:53 PM

May 22 2017

bruno added a comment to D33357: Avoid calling report_fatal_error in the destructor of raw_fd_ostream when saving a module timestamp file.

Any idea why we're hitting this issue in the first place? The error that gets cleaned up is reported at some point before? Seems to me that we're going to fail to update the timestamp but continue as nothing happened, I wonder how many other issues this might trigger...

May 22 2017, 2:05 PM

May 19 2017

bruno updated the diff for D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC.

Update the patch to address @rsmith comments and rebase

May 19 2017, 9:58 AM
bruno added a comment to D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC.

I think the problem is that we don't take module visibility into account when doing redefinition checking for enumerators. Instead of passing through this flag, we should probably just ignore hidden declarations when checking for a redefinition of an enumerator.

May 19 2017, 9:56 AM

May 17 2017

bruno added a comment to D33275: Keep into account if files were virtual..

Hi Vassil,

May 17 2017, 10:24 AM

May 11 2017

bruno committed rL302771: Make tests from r302765 windows friendly.
Make tests from r302765 windows friendly
May 11 2017, 12:20 AM

May 10 2017

bruno committed rL302765: [Sema] Improve redefinition errors pointing to the same header.
[Sema] Improve redefinition errors pointing to the same header
May 10 2017, 11:33 PM
bruno closed D28832: Improve redefinition errors pointing to the same header. by committing rL302765: [Sema] Improve redefinition errors pointing to the same header.
May 10 2017, 11:33 PM
bruno accepted D32981: [ASTImporter] Improve handling of incomplete types .

Hi Sean,

May 10 2017, 3:14 PM

May 8 2017

bruno committed rL302491: [Modules] Allow umbrella frameworks to define private submodules for….
[Modules] Allow umbrella frameworks to define private submodules for…
May 8 2017, 5:54 PM

May 3 2017

bruno created D32828: [Modules] Fix conservative assertion for import diagnostics.
May 3 2017, 2:09 PM

Apr 27 2017

bruno committed rL301604: [ASTImporter] Move structural equivalence context to its own file. NFCI.
[ASTImporter] Move structural equivalence context to its own file. NFCI
Apr 27 2017, 5:44 PM
bruno closed D31777: [ASTImporter] Move structural equivalence context to its own file. NFCI by committing rL301604: [ASTImporter] Move structural equivalence context to its own file. NFCI.
Apr 27 2017, 5:44 PM
bruno committed rL301597: [Modules] Improve diagnostics for incomplete umbrella.
[Modules] Improve diagnostics for incomplete umbrella
Apr 27 2017, 3:42 PM
bruno closed D32576: [Modules] Improve diagnostics for incomplete umbrella by committing rL301597: [Modules] Improve diagnostics for incomplete umbrella.
Apr 27 2017, 3:42 PM
bruno committed rL301596: [Modules] Refactor logic for incomplete umbrella warnings. NFC.
[Modules] Refactor logic for incomplete umbrella warnings. NFC
Apr 27 2017, 3:42 PM

Apr 26 2017

bruno accepted D25866: [Sema] Support implicit scalar to vector conversions.

Thanks for your patience! LGTM with a minor comment below.

Apr 26 2017, 7:06 PM
bruno accepted D28670: [ObjC] Disallow vector parameters and return values in Objective-C methods on older X86 targets.

Thanks Alex. LGTM

Apr 26 2017, 6:56 PM