This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Add gfx11 subtarget ELF definition
ClosedPublic

Authored by Joe_Nash on Apr 27 2022, 10:17 AM.

Details

Summary

This is the first patch of a series to upstream support for the new
subtarget.

Contributors:
Jay Foad <jay.foad@amd.com>
Konstantin Zhuravlyov <kzhuravl_dev@outlook.com>

Patch 1/N for upstreaming AMDGPU gfx11 architectures.

Diff Detail

Event Timeline

Joe_Nash created this revision.Apr 27 2022, 10:17 AM
Herald added a project: Restricted Project. · View Herald Transcript
Joe_Nash requested review of this revision.Apr 27 2022, 10:17 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 27 2022, 10:17 AM
Joe_Nash added reviewers: foad, kzhuravl, Restricted Project.Apr 27 2022, 10:18 AM
foad accepted this revision.Apr 28 2022, 1:21 AM
foad added a reviewer: t-tye.

LGTM, thanks!

This revision is now accepted and ready to land.Apr 28 2022, 1:21 AM

Looks like this change is missing doc updates?

kzhuravl requested changes to this revision.Apr 28 2022, 8:30 AM

Need to update processor table: https://llvm.org/docs/AMDGPUUsage.html#processors
Need to update EF_AMDGPU_MACH_AMDGCN table: https://llvm.org/docs/AMDGPUUsage.html#amdgpu-ef-amdgpu-mach-table

This revision now requires changes to proceed.Apr 28 2022, 8:30 AM
Joe_Nash updated this revision to Diff 425802.Apr 28 2022, 8:46 AM

add requested docs

kzhuravl accepted this revision.Apr 28 2022, 9:18 AM

LGTM, thanks

This revision is now accepted and ready to land.Apr 28 2022, 9:18 AM
This revision was landed with ongoing or failed builds.Apr 29 2022, 9:54 AM
This revision was automatically updated to reflect the committed changes.