This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] gfx11 LDSDIR instructions MC support
ClosedPublic

Authored by Joe_Nash on May 17 2022, 11:14 AM.

Details

Reviewers
critson
rampitec
foad
Group Reviewers
Restricted Project
Commits
rG729467aceff8: [AMDGPU] gfx11 LDSDIR instructions MC support
Summary

Contributors:
Carl Ritson <carl.ritson@amd.com>

Patch 8/N for upstreaming of AMDGPU gfx11 architecture.

Depends on D125498

Diff Detail

Event Timeline

Joe_Nash created this revision.May 17 2022, 11:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 11:14 AM
Joe_Nash requested review of this revision.May 17 2022, 11:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 11:14 AM
Joe_Nash added reviewers: critson, rampitec, foad, Restricted Project.May 17 2022, 11:15 AM
rampitec accepted this revision.May 17 2022, 11:53 AM

LGTM with formatting fixed.

llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp
599

Formatting, code is misaligned.

This revision is now accepted and ready to land.May 17 2022, 11:53 AM
arsenm added inline comments.May 17 2022, 11:55 AM
llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
8858–8868

Missing parse error tests

Joe_Nash updated this revision to Diff 430395.May 18 2022, 8:48 AM
Joe_Nash marked 2 inline comments as done.

deleted dead parser function and fixed formatting

llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
8858–8868

Apparently this code is dead. Added error tests for the default parser and removed this.

critson accepted this revision.May 18 2022, 5:26 PM

LGTM, thanks!

This revision was landed with ongoing or failed builds.May 19 2022, 7:36 AM
This revision was automatically updated to reflect the committed changes.