Page MenuHomePhabricator

t-tye (Tony Tye)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 22 2017, 6:01 PM (183 w, 3 d)

Recent Activity

Thu, Sep 17

t-tye added inline comments to D87858: [hip] Add HIP scope atomic ops..
Thu, Sep 17, 4:33 PM · Restricted Project
t-tye requested changes to D87858: [hip] Add HIP scope atomic ops..
Thu, Sep 17, 2:55 PM · Restricted Project
t-tye added inline comments to D87858: [hip] Add HIP scope atomic ops..
Thu, Sep 17, 2:55 PM · Restricted Project

Wed, Sep 9

t-tye committed rG72e2fbde5456: [AMDGPU] Correct gfx1031 XNACK setting documentation (authored by t-tye).
[AMDGPU] Correct gfx1031 XNACK setting documentation
Wed, Sep 9, 12:45 PM
t-tye closed D87198: [AMDGPU] Correct gfx1031 XNACK setting documentation.
Wed, Sep 9, 12:45 PM · Restricted Project
t-tye accepted D87356: [docs] Fix typos.

LGTM

Wed, Sep 9, 3:17 AM · Restricted Project

Sat, Sep 5

t-tye requested review of D87198: [AMDGPU] Correct gfx1031 XNACK setting documentation.
Sat, Sep 5, 4:00 PM · Restricted Project

Thu, Sep 3

t-tye added inline comments to D84822: Add documentation for target ID and ClangOffloadBundlerFormat.
Thu, Sep 3, 8:57 AM · Restricted Project

Mon, Aug 31

t-tye added a comment to D86902: [AMDGPU] Correct documentation for default setting of sram-ecc.

So it seems the e_flags report that sram-ecc off, yet the code generated is for on.

Mon, Aug 31, 8:27 PM · Restricted Project
t-tye retitled D86902: [AMDGPU] Correct documentation for default setting of sram-ecc from [AMDGPU] Correct documentation for default setting of sram-ecc to on to [AMDGPU] Correct documentation for default setting of sram-ecc.
Mon, Aug 31, 8:25 PM · Restricted Project
t-tye retitled D86902: [AMDGPU] Correct documentation for default setting of sram-ecc from [AMDGPU] Correct documetnation for default setting of sram-ecc to on to [AMDGPU] Correct documentation for default setting of sram-ecc to on.
Mon, Aug 31, 7:10 PM · Restricted Project
t-tye updated the diff for D86902: [AMDGPU] Correct documentation for default setting of sram-ecc.

Correct commit heading.

Mon, Aug 31, 7:09 PM · Restricted Project
t-tye requested review of D86902: [AMDGPU] Correct documentation for default setting of sram-ecc.
Mon, Aug 31, 7:07 PM · Restricted Project

Aug 24 2020

t-tye accepted D86340: [AMDGPU, docs] Fix typos.

LGTM

Aug 24 2020, 8:24 AM · Restricted Project

Aug 21 2020

t-tye requested changes to D86340: [AMDGPU, docs] Fix typos.
Aug 21 2020, 10:14 AM · Restricted Project

Aug 20 2020

t-tye requested changes to D84822: Add documentation for target ID and ClangOffloadBundlerFormat.
Aug 20 2020, 11:04 AM · Restricted Project
t-tye resigned from D84522: [AMDGPU] Reorganize GCN subtarget features for unaligned access.

Thanks for updating the subtarget features. I defer to @arsenm for the rest of the review.

Aug 20 2020, 8:58 AM · Restricted Project

Aug 19 2020

t-tye added inline comments to D84822: Add documentation for target ID and ClangOffloadBundlerFormat.
Aug 19 2020, 7:26 PM · Restricted Project
t-tye committed rGb690c1157e90: [AMDGPU] Correct DWARF register defintions (authored by t-tye).
[AMDGPU] Correct DWARF register defintions
Aug 19 2020, 6:19 PM
t-tye closed D86259: [AMDGPU] Correct DWARF register defintions.
Aug 19 2020, 6:19 PM · Restricted Project
t-tye requested review of D86259: [AMDGPU] Correct DWARF register defintions.
Aug 19 2020, 6:15 PM · Restricted Project
t-tye accepted D86206: [NFC] Fix typo in AMDGPU doc.

LGTM

Aug 19 2020, 6:53 AM · Restricted Project

Aug 18 2020

t-tye requested changes to D84522: [AMDGPU] Reorganize GCN subtarget features for unaligned access.

We are about to change the xnack and sramecc subtarget features to remove the "DoesNot" so I would suggest that FeatureDoesNotSupportUnalignedBufferAccess changes to FeatureSupportUnalignedBufferAccess.

Aug 18 2020, 3:38 PM · Restricted Project
t-tye added inline comments to D84822: Add documentation for target ID and ClangOffloadBundlerFormat.
Aug 18 2020, 2:39 PM · Restricted Project

Aug 17 2020

t-tye added inline comments to D84822: Add documentation for target ID and ClangOffloadBundlerFormat.
Aug 17 2020, 8:29 PM · Restricted Project
t-tye requested changes to D84822: Add documentation for target ID and ClangOffloadBundlerFormat.
Aug 17 2020, 7:51 PM · Restricted Project
t-tye added inline comments to D84822: Add documentation for target ID and ClangOffloadBundlerFormat.
Aug 17 2020, 7:51 PM · Restricted Project

Aug 13 2020

t-tye added inline comments to D84822: Add documentation for target ID and ClangOffloadBundlerFormat.
Aug 13 2020, 6:34 PM · Restricted Project
t-tye added a reviewer for D84822: Add documentation for target ID and ClangOffloadBundlerFormat: arsenm.
Aug 13 2020, 11:02 AM · Restricted Project
t-tye added inline comments to D85882: [AMDGPU] Update subtarget features for new target ID support.
Aug 13 2020, 8:14 AM · Restricted Project

Aug 12 2020

t-tye accepted D84822: Add documentation for target ID and ClangOffloadBundlerFormat.

LGTM

Aug 12 2020, 10:01 PM · Restricted Project
t-tye requested changes to D84822: Add documentation for target ID and ClangOffloadBundlerFormat.
Aug 12 2020, 9:57 AM · Restricted Project
t-tye added inline comments to D84822: Add documentation for target ID and ClangOffloadBundlerFormat.
Aug 12 2020, 9:57 AM · Restricted Project

Aug 9 2020

t-tye added a comment to D85603: IR: Add convergence control operand bundle and intrinsics.

Sorry, just lots of questions:-)

Aug 9 2020, 1:48 PM · Restricted Project

Aug 6 2020

t-tye committed rGce74e97d9b15: [AMDGPU] Correct missing sram-ecc target feature for gfx906 (authored by t-tye).
[AMDGPU] Correct missing sram-ecc target feature for gfx906
Aug 6 2020, 3:13 PM
t-tye closed D85476: [AMDGPU] Correct missing sram-ecc target feature for gfx906.
Aug 6 2020, 3:13 PM · Restricted Project
t-tye added a reviewer for D85476: [AMDGPU] Correct missing sram-ecc target feature for gfx906: yaxunl.
Aug 6 2020, 3:07 PM · Restricted Project
t-tye added a reviewer for D85476: [AMDGPU] Correct missing sram-ecc target feature for gfx906: kzhuravl.
Aug 6 2020, 3:07 PM · Restricted Project
t-tye requested review of D85476: [AMDGPU] Correct missing sram-ecc target feature for gfx906.
Aug 6 2020, 3:06 PM · Restricted Project

Aug 5 2020

t-tye accepted D84822: Add documentation for target ID and ClangOffloadBundlerFormat.

LGTM except for minor :doc: reference comment.

Aug 5 2020, 7:12 PM · Restricted Project
t-tye added inline comments to D84822: Add documentation for target ID and ClangOffloadBundlerFormat.
Aug 5 2020, 12:51 PM · Restricted Project

Jul 29 2020

t-tye committed rG629467eb981a: [AMDGPU] Fix DWARF extensions User Guide table of contents (authored by t-tye).
[AMDGPU] Fix DWARF extensions User Guide table of contents
Jul 29 2020, 10:12 PM
t-tye committed rGe24f5f314914: [AMDGPU] DWARF proposal changes (authored by t-tye).
[AMDGPU] DWARF proposal changes
Jul 29 2020, 10:08 PM
t-tye closed D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.
Jul 29 2020, 10:08 PM · debug-info, Restricted Project
t-tye updated the diff for D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

Clarify that these are extensions to DWARF 5 and not as yet a
proposal.

Jul 29 2020, 10:04 PM · debug-info, Restricted Project
t-tye reopened D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

Clarify these are extension to DWARF 5 and not as yet a proposal to DWARF.

Jul 29 2020, 9:34 PM · debug-info, Restricted Project
t-tye committed rG5aa2fd88cfb7: [AMDGPU] DWARF proposal changes for expression context (authored by t-tye).
[AMDGPU] DWARF proposal changes for expression context
Jul 29 2020, 7:00 PM
t-tye closed D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.
Jul 29 2020, 6:59 PM · debug-info, Restricted Project
t-tye updated the diff for D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

[AMDGPU] DWARF proposal changes for expression context

Jul 29 2020, 6:02 PM · debug-info, Restricted Project
t-tye reopened D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

Need to add clarification of how context is used in the evaluation of DWARF expressions and how evaluation relates to CFI information.

Jul 29 2020, 3:46 PM · debug-info, Restricted Project

Jul 22 2020

t-tye added inline comments to D84194: [AMDGPU] Correct the number of SGPR blocks used for GFX9.
Jul 22 2020, 12:59 AM · Restricted Project

Jul 1 2020

t-tye committed rG31fdcf64d24d: [AMDGPU] Update DWARF proposal (authored by t-tye).
[AMDGPU] Update DWARF proposal
Jul 1 2020, 2:05 PM
t-tye committed rG76b2d9cbebd2: [AMDGPU] Correct AMDGPUUsage.rst DW_AT_LLVM_lane_pc example (authored by t-tye).
[AMDGPU] Correct AMDGPUUsage.rst DW_AT_LLVM_lane_pc example
Jul 1 2020, 1:35 AM

Jun 26 2020

t-tye committed rG990f8702c911: [AMDGPU] Define DWARF encoding for condition code registers (authored by t-tye).
[AMDGPU] Define DWARF encoding for condition code registers
Jun 26 2020, 3:11 PM
t-tye closed D82519: [AMDGPU] Define DWARF encoding for condition code registers.
Jun 26 2020, 3:11 PM · Restricted Project

Jun 24 2020

t-tye created D82519: [AMDGPU] Define DWARF encoding for condition code registers.
Jun 24 2020, 8:05 PM · Restricted Project
t-tye added a comment to D82496: [amdgpu] Add codegen support for HIP dynamic shared memory..

My understanding is this feature is equivalent to the OpenCL dynamic group segment allocation. The runtime would presumably implement it in a similar way.

Jun 24 2020, 3:13 PM · Restricted Project

Jun 23 2020

t-tye committed rGea6df2fb8fa5: [AMDGPU] Update AMD GPU processor information (authored by t-tye).
[AMDGPU] Update AMD GPU processor information
Jun 23 2020, 4:12 PM
t-tye closed D82348: [AMDGPU] Update AMD GPU processor information.
Jun 23 2020, 4:12 PM · Restricted Project

Jun 22 2020

t-tye added reviewers for D82348: [AMDGPU] Update AMD GPU processor information: yaxunl, kzhuravl, arsenm, rampitec, b-sumner.
Jun 22 2020, 11:04 PM · Restricted Project
t-tye created D82348: [AMDGPU] Update AMD GPU processor information.
Jun 22 2020, 10:33 PM · Restricted Project

May 29 2020

t-tye committed rG7318e2400009: [AMDGPU] Add loaded code object path URI definition to AMDGPUUsage (authored by t-tye).
[AMDGPU] Add loaded code object path URI definition to AMDGPUUsage
May 29 2020, 4:58 PM
t-tye added a reviewer for D80810: AMDGPU: Add URI definition to AMDGPUUsage: kzhuravl.
May 29 2020, 4:57 PM · Restricted Project
t-tye updated the diff for D80810: AMDGPU: Add URI definition to AMDGPUUsage.

[AMDGPU] Add loaded code object path URI definition to AMDGPUUsage

May 29 2020, 4:57 PM · Restricted Project

May 28 2020

t-tye committed rGb4668a268dde: [AMDGPU] DWARF Proposal For Heterogeneous Debugging (authored by t-tye).
[AMDGPU] DWARF Proposal For Heterogeneous Debugging
May 28 2020, 5:39 PM
t-tye closed D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.
May 28 2020, 5:39 PM · debug-info, Restricted Project
t-tye updated the diff for D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

[AMDGPU] DWARF Proposal For Heterogeneous Debugging

May 28 2020, 5:38 PM · debug-info, Restricted Project
t-tye reopened D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

Add introduction section.

May 28 2020, 5:38 PM · debug-info, Restricted Project

May 22 2020

t-tye committed rG8a9f09df4286: [AMDGPU] DWARF Proposal For Heterogeneous Debugging (authored by t-tye).
[AMDGPU] DWARF Proposal For Heterogeneous Debugging
May 22 2020, 7:50 PM
t-tye committed rG1b58cbad018c: [AMDGPU] DWARF For Heterogeneous Debugging (authored by t-tye).
[AMDGPU] DWARF For Heterogeneous Debugging
May 22 2020, 7:50 PM
t-tye closed D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.
May 22 2020, 7:49 PM · debug-info, Restricted Project
t-tye updated the diff for D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

[AMDGPU] DWARF For Heterogeneous Debugging

May 22 2020, 7:20 PM · debug-info, Restricted Project
t-tye reopened D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

Adding minor updates as part of this review instead of creating a new review as the RFC email references this review and seems best to allow all comments within a single review.

May 22 2020, 7:18 PM · debug-info, Restricted Project

May 21 2020

t-tye committed rGe36be90c82c4: [AMDGPU] Correct formatting typos in documentation (authored by t-tye).
[AMDGPU] Correct formatting typos in documentation
May 21 2020, 5:53 PM
t-tye closed D80407: [AMDGPU] Correct formatting typos in documentation.
May 21 2020, 5:53 PM · Restricted Project
t-tye added a reviewer for D80407: [AMDGPU] Correct formatting typos in documentation: scott.linder.
May 21 2020, 2:38 PM · Restricted Project
t-tye added a reviewer for D80407: [AMDGPU] Correct formatting typos in documentation: kzhuravl.
May 21 2020, 2:38 PM · Restricted Project
t-tye created D80407: [AMDGPU] Correct formatting typos in documentation.
May 21 2020, 2:38 PM · Restricted Project

May 5 2020

t-tye accepted D76356: [AMDGPU] Introduce more scratch registers in the ABI..

LGTM. The call convention is still open to further refinement as more information is collected, but this appears to be an improvement so a good starting point.

May 5 2020, 9:41 AM · Restricted Project

Apr 29 2020

t-tye accepted D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

LGTM

Apr 29 2020, 5:50 PM · debug-info, Restricted Project

Apr 27 2020

t-tye committed rG756ba3548cbe: [AMDGPU] DWARF proposal review feedback (authored by t-tye).
[AMDGPU] DWARF proposal review feedback
Apr 27 2020, 10:05 PM
t-tye closed D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.
Apr 27 2020, 10:05 PM · debug-info, Restricted Project
t-tye added a comment to D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

Thanks @echristo. I had been keeping all the updates on the same review as had provided the link to a number of non-LLVM reviewers so they can see the diffs more easily. @scott.linder had also sent out the link to the review in the RFC. Hope that seems reasonable.

Apr 27 2020, 10:05 PM · debug-info, Restricted Project
t-tye updated the diff for D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

[AMDGPU] DWARF proposal review feedback

Apr 27 2020, 9:01 PM · debug-info, Restricted Project
t-tye reopened D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

Reopen for additional review feedback.

Apr 27 2020, 7:57 PM · debug-info, Restricted Project
t-tye updated the diff for D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

[AMDGPU] DWARF proposal review feedback

Apr 27 2020, 7:57 PM · debug-info, Restricted Project

Apr 24 2020

t-tye added a comment to D78800: [AMDGPU] Skip generating cache invalidating instructions on AMDPAL.

@nhaehnle my thinking was that the Vulkan memory model could be semantically represented in the LLVM IR by adding new memory orderings to make the distinction of the effective two sets of memory that the Vulkam memory model introduces. There needs to be memory orderings that only relates to the subset that Vulkan is requiring to be coherent. However, I have not followed the Vulkan memory model specification recently so not sure if it is still the same as when I was looking at it. What are your thoughts?

Apr 24 2020, 12:26 PM · Restricted Project

Apr 15 2020

t-tye committed rG1eac2c55d861: [AMDGPU] Move DWARF proposal to separate file (authored by t-tye).
[AMDGPU] Move DWARF proposal to separate file
Apr 15 2020, 2:22 PM
t-tye closed D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.
Apr 15 2020, 2:21 PM · debug-info, Restricted Project
t-tye updated the diff for D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

[AMDGPU] Move DWARF proposal to separate file

Apr 15 2020, 2:19 PM · debug-info, Restricted Project

Apr 14 2020

t-tye reopened D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

Reopening to update proposal to move it to a separate file.

Apr 14 2020, 7:36 PM · debug-info, Restricted Project
t-tye committed rGb43612401077: [AMDGPU] Update DWARF proposal (authored by t-tye).
[AMDGPU] Update DWARF proposal
Apr 14 2020, 5:26 PM
t-tye closed D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.
Apr 14 2020, 5:26 PM · debug-info, Restricted Project
t-tye added a comment to D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

Enthusiastic LGTM. :)

I would love to see this formally written up and passed along to the committee. Feel free to talk to me, Paul, Adrian, or a few others if you need or want any help.

Apr 14 2020, 2:39 PM · debug-info, Restricted Project

Apr 13 2020

t-tye updated the diff for D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

[AMDGPU] Update DWARF proposal

Apr 13 2020, 4:52 PM · debug-info, Restricted Project
t-tye reopened D70523: [AMDGPU] Update AMDGPUUsage with DWARF proposal.

Reopening to update proposal so more suitable to submit to DWARF site.

Apr 13 2020, 3:15 PM · debug-info, Restricted Project

Mar 27 2020

t-tye added a comment to D76881: [AMDGPU] Skip CFIInstructions in SIInsertWaitcnts.

Right, but the placement of the meta instructions here can't affect change codegen, can it? Also, if we do need to skip the DEBUG_VALUEs it may also be that we would need to either update or drop them to avoid producing incorrect debug info. I'm not actually certain this is an issue though, but the situation I have in mind is if we pass an argument by-ref or on the stack, and in the callee we claim the value is in memory when the appropriate counts haven't been waited on yet.

Doesn't the placement of CFI matter relative to the real instructions?

Yes, and same for DEBUG_VALUE, which is where my uncertainty comes up. For CFI we absolutely need the directives at the beginning of the block to precede any real instructions, because they apply "on entry". For example, we reference the ABI return address registers here, and we can't have these be defined incorrectly until after the initial s_waitcnt. Conversely for DEBUG_VALUEs it may be that we are constructing them assuming they can reference memory locations for arguments that are only valid after the initial s_waitcnt. So I think we need to handle the two cases distinctly.

ok

Mar 27 2020, 2:21 PM · debug-info, Restricted Project

Mar 26 2020

t-tye added inline comments to D76278: [AMDGPU] Don't mark the .note section as ALLOC.
Mar 26 2020, 9:44 PM · Restricted Project

Mar 21 2020

t-tye added a reviewer for D76356: [AMDGPU] Introduce more scratch registers in the ABI.: tpr.
Mar 21 2020, 12:47 PM · Restricted Project
t-tye requested changes to D76356: [AMDGPU] Introduce more scratch registers in the ABI..

Added @mjbedy to review.

Mar 21 2020, 12:47 PM · Restricted Project