Page MenuHomePhabricator

t-tye (Tony Tye)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 22 2017, 6:01 PM (313 w, 3 d)

Recent Activity

Tue, Mar 14

t-tye added inline comments to D146031: [AMDGPU] Add MMOs for GFX11 Streamout Instructions.
Tue, Mar 14, 6:19 PM · Restricted Project, Restricted Project

Tue, Mar 7

t-tye accepted D145524: [AMDGPU] Skip buffer_wbl2 before atomic fence acquire.

After offline discussion, the extra waitcnt is needed because this is a fence, and an acquire needs a waitcnt to ensure a proceeding load atomic that pairs with the fence has completed before invalidating the cache. The memory model on AMDGPUUsage does show the extra waitcnt for the fence. Previously, the waitcnt was being generated as part of the release which is not required if the fence is just an acquire.

Tue, Mar 7, 4:23 PM · Restricted Project, Restricted Project
t-tye requested changes to D145524: [AMDGPU] Skip buffer_wbl2 before atomic fence acquire.
Tue, Mar 7, 3:23 PM · Restricted Project, Restricted Project

Jan 20 2023

t-tye committed rGe60d1239d561: [AMDGPU][NFC] Clarify heterogeneous DWARF address/memory spaces (authored by t-tye).
[AMDGPU][NFC] Clarify heterogeneous DWARF address/memory spaces
Jan 20 2023, 1:13 PM · Restricted Project, Restricted Project
t-tye closed D142237: [AMDGPU][NFC] Clarify heterogeneous DWARF address/memory spaces.
Jan 20 2023, 1:13 PM · Restricted Project, Restricted Project
t-tye updated the diff for D142237: [AMDGPU][NFC] Clarify heterogeneous DWARF address/memory spaces.

Fixed review comments concerning use of class instead of space.

Jan 20 2023, 11:52 AM · Restricted Project, Restricted Project
t-tye requested review of D142237: [AMDGPU][NFC] Clarify heterogeneous DWARF address/memory spaces.
Jan 20 2023, 10:12 AM · Restricted Project, Restricted Project

Jan 12 2023

t-tye committed rG3138fda3d9aa: [AMDGPU][NFC] Heterogeneous DWARF extensions update (authored by t-tye).
[AMDGPU][NFC] Heterogeneous DWARF extensions update
Jan 12 2023, 6:09 PM · Restricted Project, Restricted Project
t-tye closed D141548: [AMDGPU][NFC] Heterogeneous DWARF extensions update.
Jan 12 2023, 6:08 PM · Restricted Project, Restricted Project
t-tye added inline comments to D141548: [AMDGPU][NFC] Heterogeneous DWARF extensions update.
Jan 12 2023, 4:55 PM · Restricted Project, Restricted Project
t-tye updated the diff for D141548: [AMDGPU][NFC] Heterogeneous DWARF extensions update.

Fix review comments.

Jan 12 2023, 4:54 PM · Restricted Project, Restricted Project

Jan 11 2023

t-tye updated the diff for D141548: [AMDGPU][NFC] Heterogeneous DWARF extensions update.

Add common block DW_AT_location description.

Jan 11 2023, 4:26 PM · Restricted Project, Restricted Project
t-tye requested review of D141548: [AMDGPU][NFC] Heterogeneous DWARF extensions update.
Jan 11 2023, 2:42 PM · Restricted Project, Restricted Project

Jan 3 2023

t-tye committed rG817f64e7ce54: [AMDGPU][NFC] DWARF extensions minor update (authored by t-tye).
[AMDGPU][NFC] DWARF extensions minor update
Jan 3 2023, 3:50 PM · Restricted Project, Restricted Project
t-tye closed D140646: [AMDGPU][NFC] DWARF extensions minor update.
Jan 3 2023, 3:49 PM · Restricted Project, Restricted Project
t-tye added inline comments to D140646: [AMDGPU][NFC] DWARF extensions minor update.
Jan 3 2023, 3:46 PM · Restricted Project, Restricted Project
t-tye updated the diff for D140646: [AMDGPU][NFC] DWARF extensions minor update.

Address review comment by adding a missing period.

Jan 3 2023, 3:42 PM · Restricted Project, Restricted Project
t-tye updated the diff for D140646: [AMDGPU][NFC] DWARF extensions minor update.
  • Correct DW_OP_LLVM_implicit_aspace_pointer to DW_OP_LLVM_aspace_implicit_pointer.
Jan 3 2023, 3:38 PM · Restricted Project, Restricted Project

Dec 23 2022

t-tye requested review of D140646: [AMDGPU][NFC] DWARF extensions minor update.
Dec 23 2022, 5:11 PM · Restricted Project, Restricted Project

Oct 10 2022

t-tye committed rG0fde0f41241e: [AMDGPU][NFC] Update DW_OP_LLVM_overlay documentation (authored by t-tye).
[AMDGPU][NFC] Update DW_OP_LLVM_overlay documentation
Oct 10 2022, 11:51 AM · Restricted Project, Restricted Project
t-tye closed D135394: [AMDGPU][NFC] Update DW_OP_LLVM_overlay documentation.
Oct 10 2022, 11:51 AM · Restricted Project, Restricted Project

Oct 7 2022

t-tye updated the diff for D135394: [AMDGPU][NFC] Update DW_OP_LLVM_overlay documentation.

Correct section number of "Extensions" section.

Oct 7 2022, 3:51 PM · Restricted Project, Restricted Project
t-tye updated the diff for D135394: [AMDGPU][NFC] Update DW_OP_LLVM_overlay documentation.

Correct offset operand for DW_OP_bit_extract in DW_OP_LLVM_overlay definition.

Oct 7 2022, 8:27 AM · Restricted Project, Restricted Project

Oct 6 2022

t-tye updated the summary of D135394: [AMDGPU][NFC] Update DW_OP_LLVM_overlay documentation.
Oct 6 2022, 2:31 PM · Restricted Project, Restricted Project
t-tye updated the diff for D135394: [AMDGPU][NFC] Update DW_OP_LLVM_overlay documentation.

Correct type in defintion of rbss.

Oct 6 2022, 2:28 PM · Restricted Project, Restricted Project
t-tye requested review of D135394: [AMDGPU][NFC] Update DW_OP_LLVM_overlay documentation.
Oct 6 2022, 1:16 PM · Restricted Project, Restricted Project

Sep 26 2022

t-tye committed rG586614064e3c: [AMDGPU][NFC] Correct name of DW_OP_LLVM_aspace_bregx (authored by t-tye).
[AMDGPU][NFC] Correct name of DW_OP_LLVM_aspace_bregx
Sep 26 2022, 4:11 PM · Restricted Project, Restricted Project
t-tye closed D134467: [AMDGPU][NFC] Correct name of DW_OP_LLVM_aspace_bregx.
Sep 26 2022, 4:11 PM · Restricted Project, Restricted Project

Sep 22 2022

t-tye requested review of D134467: [AMDGPU][NFC] Correct name of DW_OP_LLVM_aspace_bregx.
Sep 22 2022, 12:10 PM · Restricted Project, Restricted Project

Sep 13 2022

t-tye accepted D133791: Add virtual-base-class example to AMDGPUDwarfExtensionAllowLocationDescriptionOnTheDwarfExpressionStack.md.

LGTM

Sep 13 2022, 2:27 PM · Restricted Project, Restricted Project

Sep 12 2022

t-tye accepted D133735: Add example to AMDGPUDwarfExtensionAllowLocationDescriptionOnTheDwarfExpressionStack.md.

LGTM

Sep 12 2022, 4:45 PM · Restricted Project, Restricted Project

Mar 14 2022

t-tye accepted D121397: [AMDGPU] Correct gfx940 memory model documentation..

LGTM

Mar 14 2022, 4:14 PM · Restricted Project, Restricted Project
t-tye accepted D121242: [AMDGPU] gfx940 memory model.

LGTM

Mar 14 2022, 2:31 PM · Restricted Project, Restricted Project
t-tye added inline comments to D121397: [AMDGPU] Correct gfx940 memory model documentation..
Mar 14 2022, 8:29 AM · Restricted Project, Restricted Project

Mar 9 2022

t-tye added inline comments to D121242: [AMDGPU] gfx940 memory model.
Mar 9 2022, 3:21 PM · Restricted Project, Restricted Project

Feb 8 2022

t-tye added a reviewer for D119216: [AMDGPU] replace hostcall module flag with function attribute: t-tye.
Feb 8 2022, 11:28 AM · Restricted Project, Restricted Project, Restricted Project
t-tye removed a reviewer for D119216: [AMDGPU] replace hostcall module flag with function attribute: tony-tye.
Feb 8 2022, 11:27 AM · Restricted Project, Restricted Project, Restricted Project

Feb 7 2022

t-tye added inline comments to D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.
Feb 7 2022, 2:05 PM · Restricted Project, Restricted Project

Feb 5 2022

t-tye accepted D118908: [AMDGPU][NFC] AMDGPUUsage.rst: fix wording..

LGTM

Feb 5 2022, 12:24 PM · Restricted Project

Jan 18 2022

t-tye committed rG8ba5043dbfb0: [AMDGPU][NFC] Add DWARF extension support for SIMD execution (authored by t-tye).
[AMDGPU][NFC] Add DWARF extension support for SIMD execution
Jan 18 2022, 9:37 AM
t-tye closed D117572: [AMDGPU][NFC] Add DWARF extension support for SIMD execution.
Jan 18 2022, 9:37 AM · Restricted Project
t-tye requested review of D117572: [AMDGPU][NFC] Add DWARF extension support for SIMD execution.
Jan 18 2022, 9:26 AM · Restricted Project

Dec 28 2021

t-tye committed rG0ac939f3e249: [AMDGPU][NFC] Update to DWARF extension for heterogeneous debugging (authored by t-tye).
[AMDGPU][NFC] Update to DWARF extension for heterogeneous debugging
Dec 28 2021, 9:14 AM
t-tye closed D116275: [AMDGPU][NFC] Update to DWARF extension for heterogeneous debugging.
Dec 28 2021, 9:14 AM · Restricted Project
t-tye committed rG4360207a219c: [AMDGPU][NFC] Update DWARF extension allowing locations on stack (authored by t-tye).
[AMDGPU][NFC] Update DWARF extension allowing locations on stack
Dec 28 2021, 9:13 AM
t-tye closed D116265: [AMDGPU][NFC] Update DWARF extension allowing locations on stack.
Dec 28 2021, 9:12 AM · Restricted Project

Dec 27 2021

t-tye updated the diff for D116265: [AMDGPU][NFC] Update DWARF extension allowing locations on stack.
  • Improve doument overview in first section.
  • Improve opening descrition of appendix A.
Dec 27 2021, 3:49 PM · Restricted Project
t-tye updated the diff for D116275: [AMDGPU][NFC] Update to DWARF extension for heterogeneous debugging.

Improve the summary of the extensions.

Dec 27 2021, 3:40 PM · Restricted Project

Dec 26 2021

t-tye updated the diff for D116275: [AMDGPU][NFC] Update to DWARF extension for heterogeneous debugging.
  • Add section numbers.
Dec 26 2021, 2:39 PM · Restricted Project
t-tye updated the diff for D116265: [AMDGPU][NFC] Update DWARF extension allowing locations on stack.
  • Add section numbers.
  • Other minor corrections.
Dec 26 2021, 2:22 PM · Restricted Project
t-tye updated the diff for D116275: [AMDGPU][NFC] Update to DWARF extension for heterogeneous debugging.

Additional corrections.

Dec 26 2021, 10:34 AM · Restricted Project
t-tye updated the diff for D116265: [AMDGPU][NFC] Update DWARF extension allowing locations on stack.

Additional corrections.

Dec 26 2021, 10:34 AM · Restricted Project

Dec 25 2021

t-tye updated the diff for D116265: [AMDGPU][NFC] Update DWARF extension allowing locations on stack.

Further corrections.

Dec 25 2021, 7:16 PM · Restricted Project

Dec 24 2021

t-tye requested review of D116275: [AMDGPU][NFC] Update to DWARF extension for heterogeneous debugging.
Dec 24 2021, 4:53 PM · Restricted Project
t-tye updated the diff for D116265: [AMDGPU][NFC] Update DWARF extension allowing locations on stack.
  • Remove mention of DW_OP_offset.
  • Other minor corrections.
Dec 24 2021, 12:06 PM · Restricted Project
t-tye requested review of D116265: [AMDGPU][NFC] Update DWARF extension allowing locations on stack.
Dec 24 2021, 12:33 AM · Restricted Project

Dec 20 2021

t-tye committed rG0a3258febf2f: [AMDGPU][NFC] Update DWARF extension for locations on the stack (authored by t-tye).
[AMDGPU][NFC] Update DWARF extension for locations on the stack
Dec 20 2021, 9:59 PM
t-tye closed D116077: [AMDGPU][NFC] Update DWARF extension for locations on the stack.
Dec 20 2021, 9:58 PM · Restricted Project
t-tye requested review of D116077: [AMDGPU][NFC] Update DWARF extension for locations on the stack.
Dec 20 2021, 8:55 PM · Restricted Project

Dec 13 2021

t-tye committed rGc6be2ad73acb: [AMDGPU][NFC] Add documentation for location description DWARF extension (authored by t-tye).
[AMDGPU][NFC] Add documentation for location description DWARF extension
Dec 13 2021, 4:58 PM
t-tye closed D115587: [AMDGPU][NFC] Add documentation for location description DWARF extension.
Dec 13 2021, 4:58 PM · Restricted Project
t-tye updated the diff for D115587: [AMDGPU][NFC] Add documentation for location description DWARF extension.

Update review feedback from @scott.linder .

Dec 13 2021, 3:49 PM · Restricted Project

Dec 11 2021

t-tye requested review of D115587: [AMDGPU][NFC] Add documentation for location description DWARF extension.
Dec 11 2021, 4:02 PM · Restricted Project

Dec 7 2021

t-tye added a comment to D115229: [AMDGPU] In SIMemoryLegalizer assume all atomic ops have memoperands.

My understanding was that it was not guaranteed that an MI instruction has a MMO. That passes could drop the MMO. Are you saying that is not the case? As Matt says, if that is the case the verifier needs to enforce that.

Dec 7 2021, 7:06 PM · Restricted Project

Nov 25 2021

t-tye accepted D114351: [AMDGPU] Add SIMemoryLegalizer comments to clarify bit usage.

LGTM

Nov 25 2021, 5:41 AM · Restricted Project
t-tye added inline comments to D114351: [AMDGPU] Add SIMemoryLegalizer comments to clarify bit usage.
Nov 25 2021, 3:59 AM · Restricted Project

Nov 23 2021

t-tye added inline comments to D114351: [AMDGPU] Add SIMemoryLegalizer comments to clarify bit usage.
Nov 23 2021, 1:52 PM · Restricted Project
t-tye added inline comments to D114351: [AMDGPU] Add SIMemoryLegalizer comments to clarify bit usage.
Nov 23 2021, 12:16 AM · Restricted Project

Nov 22 2021

t-tye requested changes to D114351: [AMDGPU] Add SIMemoryLegalizer comments to clarify bit usage.
Nov 22 2021, 10:46 AM · Restricted Project
t-tye added inline comments to D114351: [AMDGPU] Add SIMemoryLegalizer comments to clarify bit usage.
Nov 22 2021, 10:45 AM · Restricted Project
t-tye added inline comments to D114351: [AMDGPU] Add SIMemoryLegalizer comments to clarify bit usage.
Nov 22 2021, 9:11 AM · Restricted Project

Nov 20 2021

t-tye added a comment to D114273: [AMDGPU] Do not generate ELF symbols for the local branch target labels.

@tpr does this change break anything in LLPC?

Nov 20 2021, 12:59 PM · Restricted Project

Nov 17 2021

t-tye accepted D114076: [AMDGPU] Update GFX10 memory model to account for MALL.

LGTM

Nov 17 2021, 9:55 AM · Restricted Project

Aug 30 2021

t-tye added a comment to D108865: [AMDGPU] Use gcc pragmas to disable -Wtype-limits warning.

If LocalMemorySize is unsigned, how can it ever be less than 0? Shouldn't the code be corrected instead of adding pragmas?

Aug 30 2021, 6:30 PM · Restricted Project

Aug 19 2021

t-tye added inline comments to D108322: AMDGPU: Add options to override SGPR and VGPR blocks.
Aug 19 2021, 9:10 PM · Restricted Project, Restricted Project

Aug 18 2021

t-tye added inline comments to D108322: AMDGPU: Add options to override SGPR and VGPR blocks.
Aug 18 2021, 8:28 PM · Restricted Project, Restricted Project

Aug 10 2021

t-tye committed rG53eb469195b8: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer (authored by t-tye).
[AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer
Aug 10 2021, 1:44 AM
t-tye closed D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer.
Aug 10 2021, 1:44 AM · Restricted Project
t-tye added a comment to D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer.

Haven't looked at the test changes in detail, but code changes look fine.

Aug 10 2021, 1:39 AM · Restricted Project

Aug 7 2021

t-tye added a comment to D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer.

@rampitec I believe the other changes do not change the behavior from the perspective of the C++ 20 standard.

Aug 7 2021, 3:46 PM · Restricted Project

Jul 30 2021

t-tye accepted D107190: [AMDGPU][HIP] Switch default DWARF version to 5.

LGTM

Jul 30 2021, 1:34 PM · Restricted Project

Jul 27 2021

t-tye added a comment to D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer.

No testcases?

Jul 27 2021, 3:35 AM · Restricted Project
t-tye updated the diff for D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer.

Remove unnecessary ()s.

Jul 27 2021, 3:32 AM · Restricted Project

Jul 26 2021

t-tye added a comment to D106338: Use GNUInstallDirs to define install locations for documentation.

I think the change itself LGTM, but I did a grep for GNUInstallDirs and it it only used in two other places currently. I suppose that means it is OK to use, but it does seem to imply there can be cases where we install to inconsistent locations. I don't know who to add to get more info on this, though?

Jul 26 2021, 4:10 PM · Restricted Project
t-tye added inline comments to D106736: Minor Sphinx documentation generation improvements.
Jul 26 2021, 4:07 PM · Restricted Project, Restricted Project
t-tye updated the diff for D106736: Minor Sphinx documentation generation improvements.

Replaced comment with a trailing "Slash indicates contents of" comment as suggested by @scott.linder.

Jul 26 2021, 4:06 PM · Restricted Project, Restricted Project
t-tye added a reviewer for D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer: arsenm.
Jul 26 2021, 8:37 AM · Restricted Project

Jul 24 2021

t-tye added inline comments to D106736: Minor Sphinx documentation generation improvements.
Jul 24 2021, 7:17 PM · Restricted Project, Restricted Project
t-tye updated the diff for D106736: Minor Sphinx documentation generation improvements.

Remove mention of easy_install as deprecated. MacOS still appears to only come with easy_install.

Jul 24 2021, 7:13 PM · Restricted Project, Restricted Project

Jul 23 2021

t-tye added a comment to D106339: Add support to generate Sphinx DOCX documentation.

What's the benefit of having docx documentation? We generate HTML documentation, which ends up in the website, and that seems strictly superior to generating docx. What do you need it for?

The libc++ changes are almost trivial so I would not object to the change on that basis, however in general I think it's better to avoid adding support for things we won't be using on a regular basis.

Jul 23 2021, 8:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
t-tye updated the diff for D106339: Add support to generate Sphinx DOCX documentation.

Factor out documentation and CMake file changes unrelated to adding DOCX support to D106736.

Jul 23 2021, 7:50 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
t-tye requested review of D106736: Minor Sphinx documentation generation improvements.
Jul 23 2021, 7:47 PM · Restricted Project, Restricted Project
t-tye updated the diff for D106339: Add support to generate Sphinx DOCX documentation.

Split change for clang makefile to elimnate Sphinx warnings of missing .rst fies when building man pages into D106734.

Jul 23 2021, 6:54 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
t-tye requested review of D106734: Eliminate clang man page generation warning for missing .rst files.
Jul 23 2021, 6:51 PM · Restricted Project, Restricted Project
t-tye added a reviewer for D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer: efriedma.
Jul 23 2021, 5:49 PM · Restricted Project
t-tye requested review of D106729: [AMDGPU] Support non-strictly stronger memory orderings in SIMemoryLegalizer.
Jul 23 2021, 5:09 PM · Restricted Project

Jul 19 2021

t-tye requested review of D106339: Add support to generate Sphinx DOCX documentation.
Jul 19 2021, 8:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
t-tye requested review of D106338: Use GNUInstallDirs to define install locations for documentation.
Jul 19 2021, 8:12 PM · Restricted Project
t-tye committed rG038602139db2: [NFC] Correct documentation error in OpenMP release ReleaseNotes (authored by t-tye).
[NFC] Correct documentation error in OpenMP release ReleaseNotes
Jul 19 2021, 7:05 PM
t-tye closed D106330: [NFC] Correct documentation error in OpenMP release ReleaseNotes.
Jul 19 2021, 7:05 PM · Restricted Project