User Details
- User Since
- Mar 22 2017, 6:01 PM (313 w, 3 d)
Tue, Mar 14
Tue, Mar 7
After offline discussion, the extra waitcnt is needed because this is a fence, and an acquire needs a waitcnt to ensure a proceeding load atomic that pairs with the fence has completed before invalidating the cache. The memory model on AMDGPUUsage does show the extra waitcnt for the fence. Previously, the waitcnt was being generated as part of the release which is not required if the fence is just an acquire.
Jan 20 2023
Fixed review comments concerning use of class instead of space.
Jan 12 2023
Fix review comments.
Jan 11 2023
Add common block DW_AT_location description.
Jan 3 2023
Address review comment by adding a missing period.
- Correct DW_OP_LLVM_implicit_aspace_pointer to DW_OP_LLVM_aspace_implicit_pointer.
Dec 23 2022
Oct 10 2022
Oct 7 2022
Correct section number of "Extensions" section.
Correct offset operand for DW_OP_bit_extract in DW_OP_LLVM_overlay definition.
Oct 6 2022
Correct type in defintion of rbss.
Sep 26 2022
Sep 22 2022
Sep 13 2022
LGTM
Sep 12 2022
LGTM
Mar 14 2022
LGTM
LGTM
Mar 9 2022
Feb 8 2022
Feb 7 2022
Feb 5 2022
LGTM
Jan 18 2022
Dec 28 2021
Dec 27 2021
- Improve doument overview in first section.
- Improve opening descrition of appendix A.
Improve the summary of the extensions.
Dec 26 2021
- Add section numbers.
- Add section numbers.
- Other minor corrections.
Additional corrections.
Additional corrections.
Dec 25 2021
Further corrections.
Dec 24 2021
- Remove mention of DW_OP_offset.
- Other minor corrections.
Dec 20 2021
Dec 13 2021
Update review feedback from @scott.linder .
Dec 11 2021
Dec 7 2021
My understanding was that it was not guaranteed that an MI instruction has a MMO. That passes could drop the MMO. Are you saying that is not the case? As Matt says, if that is the case the verifier needs to enforce that.
Nov 25 2021
LGTM
Nov 23 2021
Nov 22 2021
Nov 20 2021
@tpr does this change break anything in LLPC?
Nov 17 2021
LGTM
Aug 30 2021
If LocalMemorySize is unsigned, how can it ever be less than 0? Shouldn't the code be corrected instead of adding pragmas?
Aug 19 2021
Aug 18 2021
Aug 10 2021
Aug 7 2021
@rampitec I believe the other changes do not change the behavior from the perspective of the C++ 20 standard.
Jul 30 2021
LGTM
Jul 27 2021
Remove unnecessary ()s.
Jul 26 2021
Replaced comment with a trailing "Slash indicates contents of" comment as suggested by @scott.linder.
Jul 24 2021
Remove mention of easy_install as deprecated. MacOS still appears to only come with easy_install.
Jul 23 2021
Factor out documentation and CMake file changes unrelated to adding DOCX support to D106736.
Split change for clang makefile to elimnate Sphinx warnings of missing .rst fies when building man pages into D106734.