- User Since
- Jul 21 2020, 2:19 PM (101 w, 6 d)
Thu, Jun 30
combine cases in doReplace
invert op_sel_0 value check
better way to copy implicit operands
Wed, Jun 29
use Register() in place of NoRegister. Add implicit operands in convertToThreeAddress
Removed clang builtin from intrinsics. The builtins can be added in a later patch.
Tue, Jun 28
call getDPPOp64 after early exit for DPP32
Removed HasVOP3DPP parameter. explicit type instead of auto. Check ST->hasVOP3DPP before calling getDPPOp64
Mon, Jun 27
changed auto to explicit type, changed print syntax in dbg statement, fixed bad DBG_VALUE in test
Fri, Jun 24
LGTM. Perhaps we want to add the store clustering to postRA scheduling as well?
Thu, Jun 23
fixed formatting, deduplicated VOP2eInst, named a variable
removed return after else
Wed, Jun 22
Thanks for all the tests, I only verified a couple but it seems reasonable. LGTM.
added globalisel support
Tue, Jun 21
Mon, Jun 20
Fri, Jun 17
Overall looks good, thanks!
Thu, Jun 16
added builtin positive tests, removed clamp from intrinsic comments, combined gisel with normal codegen test
added globalisel runlines to codegen test
Wed, Jun 15
I think all outstanding issues are addressed; please take another look.
removed builtin from intrinsic definition
added s_mov m0 to param.load test
changed return type of lds_direct_load and commented on input argument type
Nice find, thanks! LGTM
Tue, Jun 14
Mon, Jun 13
LGTM, but could there be more opportunities to use this?
Are there cases where we want to have value 0 in a source operand (a normal VSrc, not VOPDstS64orS32 like is used in https://reviews.llvm.org/D127542), it can't be folded, and we could use sgpr null 64? It might be interesting to have a test case for that with folding excluded.
added ISA codegen test.