Page MenuHomePhabricator

Joe_Nash (Joe Nash)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 21 2020, 2:19 PM (26 w, 6 d)

Recent Activity

Fri, Jan 22

Joe_Nash accepted D94795: [AMDGPU] Fix use of HasModifiers in VopProfile.
Fri, Jan 22, 12:02 PM · Restricted Project

Tue, Jan 19

Joe_Nash requested changes to D94795: [AMDGPU] Fix use of HasModifiers in VopProfile.

I'm getting failing tests in check-llvm-mc-disassembler-amdgpu when applying this patch, can you take a look at that please?

Tue, Jan 19, 11:47 AM · Restricted Project
Joe_Nash accepted D94975: [AMDGPU] Simpler names for arch-specific ttmp registers. NFC..

LGTM

Tue, Jan 19, 10:12 AM · Restricted Project

Tue, Jan 12

Joe_Nash committed rG314e29ed2b78: [AMDGPU] Add _e64 suffix to VOP3 Insts (authored by Joe_Nash).
[AMDGPU] Add _e64 suffix to VOP3 Insts
Tue, Jan 12, 3:40 PM
Joe_Nash closed D94341: [AMDGPU] Add _e64 suffix to VOP3 Insts.
Tue, Jan 12, 3:40 PM · Restricted Project

Mon, Jan 11

Joe_Nash added a comment to D94341: [AMDGPU] Add _e64 suffix to VOP3 Insts.

Looks OK to me. Does this enable any immediate simplifications? Or is it just to help with future work?

Mon, Jan 11, 11:42 AM · Restricted Project
Joe_Nash updated the diff for D94341: [AMDGPU] Add _e64 suffix to VOP3 Insts.

Address format comments of foad.

Mon, Jan 11, 11:42 AM · Restricted Project
Joe_Nash committed rGbcec0f27a2c3: [AMDGPU] Deduplicate VOP tablegen asm & ins (authored by Joe_Nash).
[AMDGPU] Deduplicate VOP tablegen asm & ins
Mon, Jan 11, 10:57 AM
Joe_Nash closed D94102: [AMDGPU] Deduplicate VOP tablegen asm & ins.
Mon, Jan 11, 10:56 AM · Restricted Project
Joe_Nash updated the diff for D94102: [AMDGPU] Deduplicate VOP tablegen asm & ins.

Apply nfc edits suggested by dp

Mon, Jan 11, 10:03 AM · Restricted Project

Fri, Jan 8

Joe_Nash requested review of D94341: [AMDGPU] Add _e64 suffix to VOP3 Insts.
Fri, Jan 8, 2:06 PM · Restricted Project

Tue, Jan 5

Joe_Nash updated the diff for D94102: [AMDGPU] Deduplicate VOP tablegen asm & ins.

combined !con per comment by foad

Tue, Jan 5, 11:30 AM · Restricted Project
Joe_Nash added a reviewer for D94102: [AMDGPU] Deduplicate VOP tablegen asm & ins: dp.
Tue, Jan 5, 10:52 AM · Restricted Project
Joe_Nash requested review of D94102: [AMDGPU] Deduplicate VOP tablegen asm & ins.
Tue, Jan 5, 10:49 AM · Restricted Project
Joe_Nash committed rG60466fad2dc1: [AMDGPU] Remove deprecated V_MUL_LO_I32 from GFX10 (authored by Joe_Nash).
[AMDGPU] Remove deprecated V_MUL_LO_I32 from GFX10
Tue, Jan 5, 9:07 AM
Joe_Nash closed D94020: [AMDGPU] Remove deprecated V_MUL_LO_I32 from GFX10.
Tue, Jan 5, 9:07 AM · Restricted Project

Mon, Jan 4

Joe_Nash updated the diff for D94020: [AMDGPU] Remove deprecated V_MUL_LO_I32 from GFX10.

changed B_encoding predicate to be 10_3Insts

Mon, Jan 4, 4:25 PM · Restricted Project
Joe_Nash updated the diff for D94020: [AMDGPU] Remove deprecated V_MUL_LO_I32 from GFX10.

remove inst from gfx1030 only, instead of all gfx10

Mon, Jan 4, 4:18 PM · Restricted Project
Joe_Nash requested review of D94020: [AMDGPU] Remove deprecated V_MUL_LO_I32 from GFX10.
Mon, Jan 4, 10:53 AM · Restricted Project

Nov 30 2020

Joe_Nash added inline comments to D92092: [AMDGPU] Introduce and use isGFX10Plus. NFC..
Nov 30 2020, 9:30 AM · Restricted Project

Nov 4 2020

Joe_Nash committed rG58adab34c480: [AMDGPU] Resolve pseudo registers at encoding uses (authored by Joe_Nash).
[AMDGPU] Resolve pseudo registers at encoding uses
Nov 4 2020, 9:56 AM
Joe_Nash closed D90721: [AMDGPU] Resolve pseudo registers at encoding uses.
Nov 4 2020, 9:56 AM · Restricted Project
Joe_Nash updated the diff for D90721: [AMDGPU] Resolve pseudo registers at encoding uses.

whitespace change for lint and rerun build

Nov 4 2020, 9:14 AM · Restricted Project

Nov 3 2020

Joe_Nash requested review of D90721: [AMDGPU] Resolve pseudo registers at encoding uses.
Nov 3 2020, 2:45 PM · Restricted Project

Oct 21 2020

Joe_Nash committed rGf6d7832f4cf8: [AMDGPU] Refactor SOPC & SOPP .td for extension (authored by Joe_Nash).
[AMDGPU] Refactor SOPC & SOPP .td for extension
Oct 21 2020, 9:39 AM
Joe_Nash closed D89738: [AMDGPU] Refactor SOPC & SOPP .td for extension.
Oct 21 2020, 9:39 AM · Restricted Project

Oct 20 2020

Joe_Nash updated the diff for D89738: [AMDGPU] Refactor SOPC & SOPP .td for extension.

remove accidental commented code

Oct 20 2020, 12:55 PM · Restricted Project
Joe_Nash updated the diff for D89738: [AMDGPU] Refactor SOPC & SOPP .td for extension.

add OtherPredicates and blank line for rampitec

Oct 20 2020, 11:41 AM · Restricted Project

Oct 19 2020

Joe_Nash added a comment to D89738: [AMDGPU] Refactor SOPC & SOPP .td for extension.

Are there hazards associated with SOP, where we have it lowered to real instructions?

I'm not sure exactly what you mean, but there is a workaround for branch instructions, that operates on the real instructions. Original fix at https://github.com/llvm/llvm-project/commit/9ab812d4752b2a1442426db2ccc17dc95d12eb04

Also please run PSDB for this change.

Will do

Oct 19 2020, 2:28 PM · Restricted Project
Joe_Nash requested review of D89738: [AMDGPU] Refactor SOPC & SOPP .td for extension.
Oct 19 2020, 2:07 PM · Restricted Project

Oct 6 2020

Joe_Nash added a comment to D88908: [AMDGPU] Create isGFX9Plus utility function.

Thank you for the review. I do not yet have commit access so please commit this on my behalf.

Oct 6 2020, 10:02 AM · Restricted Project
Joe_Nash requested review of D88908: [AMDGPU] Create isGFX9Plus utility function.
Oct 6 2020, 9:15 AM · Restricted Project

Oct 1 2020

Joe_Nash added a comment to D88708: [AMDGPU] Allow SOP asm mnemonic to differ.

I do not have commit access, please commit the patch for me.

Oct 1 2020, 3:38 PM · Restricted Project
Joe_Nash requested review of D88708: [AMDGPU] Allow SOP asm mnemonic to differ.
Oct 1 2020, 3:35 PM · Restricted Project