Page MenuHomePhabricator
People kzhuravl

kzhuravl (Konstantin Zhuravlyov)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 16 2016, 12:13 PM (178 w, 5 d)

Recent Activity
View All

Mon, Jul 15

kzhuravl committed rGff1c5288cb6a: AMDGPU: Remove reserved value accidentally left in for gfx908 (authored by kzhuravl).
AMDGPU: Remove reserved value accidentally left in for gfx908
Mon, Jul 15, 11:23 AM
kzhuravl committed rL366101: AMDGPU: Remove reserved value accidentally left in for gfx908.
AMDGPU: Remove reserved value accidentally left in for gfx908
Mon, Jul 15, 11:22 AM
kzhuravl accepted D64761: [AMDGPU] Copy missing predicate from pseudo to real.

LGTM

Mon, Jul 15, 10:47 AM · Restricted Project

Fri, Jul 12

kzhuravl accepted D64649: [AMDGPU] Extend MIMG opcode to 8 bits.

LGTM

Fri, Jul 12, 11:36 AM · Restricted Project

Wed, Jul 10

kzhuravl accepted D64522: AMDGPU: Fix some missing GCCBuiltin declarations.

LGTM

Wed, Jul 10, 12:01 PM

Tue, Jul 9

kzhuravl accepted D64430: [AMDGPU] gfx908 clang target.

LGTM

Tue, Jul 9, 11:17 AM · Restricted Project
kzhuravl accepted D64429: [AMDGPU] gfx908 target.

LGTM

Tue, Jul 9, 11:08 AM · Restricted Project

Wed, Jul 3

kzhuravl accepted D63850: [AMDGPU] Kernel arg metadata: added support for "__hip_texture" type..

LGTM, thanks!

Wed, Jul 3, 8:13 AM · Restricted Project
kzhuravl added a comment to D63850: [AMDGPU] Kernel arg metadata: added support for "__hip_texture" type..

Test for v3?

Wed, Jul 3, 7:51 AM · Restricted Project

Wed, Jun 26

kzhuravl added a comment to D63850: [AMDGPU] Kernel arg metadata: added support for "__hip_texture" type..

Does this need to be done for v3 as well? Needs test?

Wed, Jun 26, 4:43 PM · Restricted Project

Mon, Jun 24

kzhuravl added inline comments to D63209: [AMDGPU] gfx1010 wave32 clang support.
Mon, Jun 24, 4:10 PM · Restricted Project
kzhuravl accepted D63724: [AMDGPU] Allow any value in unused src0 field in v_nop.

LGTM

Mon, Jun 24, 9:32 AM · Restricted Project
kzhuravl added inline comments to D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h.
Mon, Jun 24, 9:30 AM · Restricted Project, Restricted Project

Jun 21 2019

kzhuravl updated subscribers of D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h.
Jun 21 2019, 1:10 PM · Restricted Project, Restricted Project
kzhuravl updated subscribers of D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h.

+ @b-sumner

Jun 21 2019, 12:58 PM · Restricted Project, Restricted Project

Jun 18 2019

kzhuravl accepted D63511: [AMDGPU] gfx10 wave32 patterns.

LGTM

Jun 18 2019, 12:49 PM · Restricted Project

Jun 13 2019

kzhuravl accepted D63307: [AMDGPU] gfx1011/gfx1012 targets.

Never mind, didn’t see this https://github.com/llvm-mirror/llvm/commit/50d6e67368454cdb11accc7eab91c5e942e186e8

Jun 13 2019, 5:28 PM · Restricted Project
kzhuravl accepted D63308: [AMDGPU] gfx1011/gfx1012 clang support.

LGTM

Jun 13 2019, 5:25 PM · Restricted Project
kzhuravl accepted D63204: [AMDGPU] gfx1010 core wave32 changes.

LGTM

Jun 13 2019, 5:25 PM · Restricted Project
kzhuravl added a comment to D63307: [AMDGPU] gfx1011/gfx1012 targets.

Seems like docs (AMDGPUUsage) are missing. Will they be updated in a separate patch?

Jun 13 2019, 5:25 PM · Restricted Project
kzhuravl accepted D63206: [AMDGPU] gfx1010 wavefrontsize intrinsic folding.

lgtm

Jun 13 2019, 5:17 PM · Restricted Project
kzhuravl accepted D63208: [AMDGPU] Pass to propagate ABI attributes from kernels to the functions.

LGTM

Jun 13 2019, 5:12 PM · Restricted Project
kzhuravl accepted D63293: [AMDGPU] gfx1010 base changes for wave32.

LGTM

Jun 13 2019, 12:13 PM · Restricted Project

Jun 12 2019

kzhuravl added inline comments to D63203: [AMDGPU] gfx1010 dpp16 and dpp8.
Jun 12 2019, 10:52 AM · Restricted Project
kzhuravl accepted D63203: [AMDGPU] gfx1010 dpp16 and dpp8.

LGTM

Jun 12 2019, 10:47 AM · Restricted Project
kzhuravl accepted D63202: [AMDGPU] gfx1010 premlane instructions.

LGTM, thanks.

Jun 12 2019, 10:44 AM · Restricted Project

May 28 2019

kzhuravl closed D61528: Revert "[AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`.".

rL361879

May 28 2019, 2:23 PM
kzhuravl committed rGfe23ed2c6814: AMDGPU: Temporary drop s_mul_hi_i/u32 patterns (authored by kzhuravl).
AMDGPU: Temporary drop s_mul_hi_i/u32 patterns
May 28 2019, 2:18 PM
kzhuravl committed rL361879: AMDGPU: Temporary drop s_mul_hi_i/u32 patterns.
AMDGPU: Temporary drop s_mul_hi_i/u32 patterns
May 28 2019, 2:17 PM

May 13 2019

kzhuravl accepted D61856: [test]Make test work on Windows.

LGTM, thanks!

May 13 2019, 2:50 PM · Restricted Project
kzhuravl accepted D61868: [AMDGPU] gfx1010 SearchableTableEmitter patch for NSA.

LGTM

May 13 2019, 2:46 PM · Restricted Project

May 10 2019

kzhuravl added a comment to D61528: Revert "[AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`.".
In D61528#1490289, @arsenm wrote:

Should not revert to fix performance problems. A proper fix should be found

May 10 2019, 2:58 PM
kzhuravl updated the diff for D61528: Revert "[AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`.".

Address review feedback.

May 10 2019, 2:58 PM

May 9 2019

kzhuravl accepted D61763: AMDGPU] Pattern for v_xor3_b32.

LGTM

May 9 2019, 4:38 PM · Restricted Project
kzhuravl accepted D61703: [AMDGPU] gfx1010 v_interp_* instructions.

LGTM

May 9 2019, 11:00 AM · Restricted Project
kzhuravl accepted D61704: [AMDGPU] gfx1010 changes for PAL metadata.

LGTM

May 9 2019, 8:47 AM · Restricted Project

May 8 2019

kzhuravl accepted D61701: [AMDGPU] gfx1010 exp modifications.

LGTM

May 8 2019, 2:20 PM · Restricted Project

May 6 2019

kzhuravl accepted D61521: [AMDGPU] gfx1010 verifier changes.

LGTM with a todo about tests?

May 6 2019, 3:23 PM · Restricted Project
kzhuravl accepted D61525: [AMDGPU] gfx1010: prefer V_MUL_LO_U32 over V_MUL_LO_I32.

LGTM

May 6 2019, 3:09 PM · Restricted Project
kzhuravl accepted D61535: [AMDGPU] gfx1010 memory legalizer.

LGTM

May 6 2019, 2:26 PM · Restricted Project

May 3 2019

kzhuravl created D61528: Revert "[AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`.".
May 3 2019, 12:31 PM

May 1 2019

kzhuravl accepted D61416: [AMDGPU] gfx1010 lost VOP2 forms of some add/sub.

LGTM

May 1 2019, 7:48 PM
kzhuravl accepted D61413: [AMDGPU] gfx1010 allows VOP3 to have a literal.

LGTM

May 1 2019, 7:22 PM · Restricted Project
kzhuravl accepted D61404: [AMDGPU] gfx1010 constant bus limit.

LGTM

May 1 2019, 6:06 PM · Restricted Project
kzhuravl added inline comments to D61341: [AMDGPU] gfx1010 GCNNSAReassign pass.
May 1 2019, 8:43 AM · Restricted Project
kzhuravl accepted D61344: [AMDGPU] gfx1010 GCNRegBankReassign pass.

LGTM

May 1 2019, 8:43 AM · Restricted Project
kzhuravl accepted D61341: [AMDGPU] gfx1010 GCNNSAReassign pass.

LGTM

May 1 2019, 8:40 AM · Restricted Project
kzhuravl accepted D61339: [AMDGPU] gfx1010 MIMG implementation.

LGTM

May 1 2019, 8:39 AM · Restricted Project
kzhuravl accepted D61332: [AMDGPU] gfx1010 DS implementation.

LGTM

May 1 2019, 8:23 AM · Restricted Project

Apr 30 2019

kzhuravl accepted D61330: [AMDGPU] gfx1010 VMEM and SMEM implementation.

LGTM

Apr 30 2019, 2:45 PM · Restricted Project

Apr 26 2019

kzhuravl accepted D61208: [AMDGPU] gfx1010 VOPC implementation.

LGTM

Apr 26 2019, 3:59 PM · Restricted Project
kzhuravl added inline comments to D61202: [AMDGPU] gfx1010 VOP3 and VOP3P implementation.
Apr 26 2019, 10:50 AM · Restricted Project
kzhuravl accepted D61202: [AMDGPU] gfx1010 VOP3 and VOP3P implementation.

LGTM

Apr 26 2019, 10:50 AM · Restricted Project
kzhuravl accepted D61156: [AMDGPU] gfx1010 VOP2 changes.

LGTM

Apr 26 2019, 8:32 AM · Restricted Project

Apr 25 2019

kzhuravl accepted D61099: [AMDGPU] gfx1010 VOP1 instructions.

LGTM

Apr 25 2019, 11:53 AM · Restricted Project
kzhuravl accepted D61094: [AMDGPU] gfx1010 utility functions.

LGTM

Apr 25 2019, 11:20 AM · Restricted Project

Apr 24 2019

kzhuravl accepted D61080: [AMDGPU] gfx1010 SOP instructions.

LGTM

Apr 24 2019, 1:23 PM · Restricted Project
kzhuravl accepted D61045: [AMDGPU] gfx1010 sgpr register changes.

LGTM

Apr 24 2019, 10:13 AM · Restricted Project
kzhuravl accepted D61041: [AMDGPU] Add gfx1010 target definitions.

LGTM

Apr 24 2019, 8:52 AM · Restricted Project

Apr 22 2019

kzhuravl accepted D60858: AMDGPU: Skip debug instructions in assert.

LGTM, thx

Apr 22 2019, 9:05 AM
kzhuravl accepted D60915: [AMDGPU] Fix hidden argument metadata duplication for V3.

LGTM

Apr 22 2019, 9:05 AM · Restricted Project

Apr 5 2019

kzhuravl accepted D60346: [AMDGPU] Sort out and rename multiple CI/VI predicates.

LGTM

Apr 5 2019, 5:07 PM · Restricted Project
kzhuravl added inline comments to D60292: [AMDGPU] predicate and feature refactoring.
Apr 5 2019, 11:05 AM · Restricted Project
kzhuravl accepted D60292: [AMDGPU] predicate and feature refactoring.

LGTM. Minor comment which does not affect the LGTM! Thanks for doing this.

Apr 5 2019, 11:00 AM · Restricted Project

Apr 3 2019

kzhuravl committed rG6dff95cf55e4: AMDGPU/NFC: Add offset field to arg metadata (required for code object v3) (authored by kzhuravl).
AMDGPU/NFC: Add offset field to arg metadata (required for code object v3)
Apr 3 2019, 12:07 PM
kzhuravl committed rL357623: AMDGPU/NFC: Add offset field to arg metadata (required for code object v3).
AMDGPU/NFC: Add offset field to arg metadata (required for code object v3)
Apr 3 2019, 12:07 PM

Apr 2 2019

kzhuravl reclaimed D31874: AMDGPU: Switch aperture queries to use aperture registers instead of s_getreg_b32.
Apr 2 2019, 12:49 PM
kzhuravl abandoned D31872: AMDGPU: Minor SReg64 register class refactoring.
Apr 2 2019, 12:44 PM
kzhuravl abandoned D31873: AMDGPU/GFX9: Add AsmPrinter support for aperture registers.
Apr 2 2019, 12:43 PM
kzhuravl abandoned D31874: AMDGPU: Switch aperture queries to use aperture registers instead of s_getreg_b32.
Apr 2 2019, 12:43 PM
kzhuravl abandoned D44544: llvm-objdump: Print symbol name if it's address is the same as the next one's.
Apr 2 2019, 12:43 PM
kzhuravl abandoned D38959: AMDGPU: Don't use TargetStreamer if it has not been initialized.
Apr 2 2019, 12:43 PM
kzhuravl abandoned D59717: AMDGPU: Ignore SRAM ECC feature when inlining.
Apr 2 2019, 12:43 PM

Apr 1 2019

kzhuravl accepted D60106: AMDGPU: Assume ECC is enabled by default if supported.

LGTM

Apr 1 2019, 9:47 PM

Mar 29 2019

kzhuravl committed rG2b766ed774d4: AMDGPU: Make sram-ecc off by default for Vega20 (authored by kzhuravl).
AMDGPU: Make sram-ecc off by default for Vega20
Mar 29 2019, 5:05 AM
kzhuravl committed rL357247: AMDGPU: Make sram-ecc off by default for Vega20.
AMDGPU: Make sram-ecc off by default for Vega20
Mar 29 2019, 5:05 AM
kzhuravl closed D59718: AMDGPU: Make sram-ecc off by default for Vega20.
Mar 29 2019, 5:05 AM · Restricted Project

Mar 28 2019

kzhuravl accepted D59949: [AMDGPU] Add an additional Code Object V3 assembler example.

LGTM

Mar 28 2019, 10:53 AM · Restricted Project

Mar 25 2019

kzhuravl accepted D59782: [AMDGPU] Clarify Code Object V2/V3 differences in AMDGPUUsage.

LGTM

Mar 25 2019, 2:08 PM · Restricted Project
kzhuravl accepted D59008: [AMDGPU] Switch default dwarf version to 5.

LGTM

Mar 25 2019, 2:05 PM · Restricted Project
kzhuravl committed rGec28a1dcefc3: AMDGPU: Add support for cross address space synchronization scopes (clang) (authored by kzhuravl).
AMDGPU: Add support for cross address space synchronization scopes (clang)
Mar 25 2019, 1:55 PM
kzhuravl committed rL356947: AMDGPU: Add support for cross address space synchronization scopes (clang).
AMDGPU: Add support for cross address space synchronization scopes (clang)
Mar 25 2019, 1:55 PM
kzhuravl committed rC356947: AMDGPU: Add support for cross address space synchronization scopes (clang).
AMDGPU: Add support for cross address space synchronization scopes (clang)
Mar 25 2019, 1:55 PM
kzhuravl closed D59494: AMDGPU: Add support for cross address space synchronization scopes (clang).
Mar 25 2019, 1:55 PM · Restricted Project
kzhuravl committed rG51809cbc98ce: AMDGPU: Add support for cross address space synchronization scopes (authored by kzhuravl).
AMDGPU: Add support for cross address space synchronization scopes
Mar 25 2019, 1:50 PM
kzhuravl committed rL356946: AMDGPU: Add support for cross address space synchronization scopes.
AMDGPU: Add support for cross address space synchronization scopes
Mar 25 2019, 1:49 PM
kzhuravl closed D59517: AMDGPU: Add support for cross address space synchronization scopes.
Mar 25 2019, 1:49 PM · Restricted Project

Mar 22 2019

kzhuravl created D59718: AMDGPU: Make sram-ecc off by default for Vega20.
Mar 22 2019, 2:26 PM · Restricted Project
kzhuravl created D59717: AMDGPU: Ignore SRAM ECC feature when inlining.
Mar 22 2019, 2:08 PM

Mar 20 2019

kzhuravl added a comment to D59614: [AMDGPU] Add missing dependency on BinaryFormat.

Dup of D59610 ?

Mar 20 2019, 2:30 PM · Restricted Project
kzhuravl accepted D59613: [AMDGPU] Do not generate spurious PAL metadata.

LGTM

Mar 20 2019, 2:14 PM · Restricted Project
kzhuravl committed rG88268e3e3607: AMDHSA: Fix COMPUTE_PGM_RSRC2.USER_SGPR calculation when parsing ISA assembly (authored by kzhuravl).
AMDHSA: Fix COMPUTE_PGM_RSRC2.USER_SGPR calculation when parsing ISA assembly
Mar 20 2019, 12:44 PM
kzhuravl committed rL356603: AMDHSA: Fix COMPUTE_PGM_RSRC2.USER_SGPR calculation when parsing ISA assembly.
AMDHSA: Fix COMPUTE_PGM_RSRC2.USER_SGPR calculation when parsing ISA assembly
Mar 20 2019, 12:43 PM
kzhuravl closed D59570: AMDHSA: Fix COMPUTE_PGM_RSRC2.USER_SGPR calculation when parsing ISA assembly.
Mar 20 2019, 12:43 PM · Restricted Project

Mar 19 2019

kzhuravl created D59570: AMDHSA: Fix COMPUTE_PGM_RSRC2.USER_SGPR calculation when parsing ISA assembly.
Mar 19 2019, 5:14 PM · Restricted Project
kzhuravl updated the diff for D59517: AMDGPU: Add support for cross address space synchronization scopes.

Added docs and tests. Addressed review feedback.

Mar 19 2019, 1:34 PM · Restricted Project

Mar 18 2019

kzhuravl added a child revision for D59517: AMDGPU: Add support for cross address space synchronization scopes: D59494: AMDGPU: Add support for cross address space synchronization scopes (clang).
Mar 18 2019, 3:38 PM · Restricted Project
kzhuravl added a parent revision for D59494: AMDGPU: Add support for cross address space synchronization scopes (clang): D59517: AMDGPU: Add support for cross address space synchronization scopes.
Mar 18 2019, 3:38 PM · Restricted Project
kzhuravl created D59517: AMDGPU: Add support for cross address space synchronization scopes.
Mar 18 2019, 3:38 PM · Restricted Project
kzhuravl added a comment to D59517: AMDGPU: Add support for cross address space synchronization scopes.

This still requires some more tests to be added (which I am working on), and docs updated. I just wanted to get this out here for some early code reviews and testing on hw.

Mar 18 2019, 3:38 PM · Restricted Project