Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

kzhuravl (Konstantin Zhuravlyov)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 16 2016, 12:13 PM (407 w, 3 d)

Recent Activity

Aug 25 2023

kzhuravl added a reviewer for D158603: [AMDGPU][TargetMachine] Handle case when +extended-image-insts is set, and the user forces +wave64: Pierre-vh.

Adding Pierre as he worked on this recently as well.

Aug 25 2023, 9:43 AM · Restricted Project, Restricted Project

Jul 12 2023

kzhuravl added reviewers for D155036: Add support for missing v_pk_fmac_f16_dpp: dp, rampitec.
Jul 12 2023, 1:00 PM · Restricted Project, Restricted Project

May 12 2023

kzhuravl committed rG42bd81410e36: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941 (authored by kzhuravl).
AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941
May 12 2023, 8:54 AM · Restricted Project, Restricted Project
kzhuravl closed D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941.
May 12 2023, 8:53 AM · Restricted Project, Restricted Project, Restricted Project
kzhuravl updated the diff for D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941.

Address @arsenm's comment

May 12 2023, 7:16 AM · Restricted Project, Restricted Project, Restricted Project
kzhuravl updated the diff for D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941.

Address review feedback

May 12 2023, 7:13 AM · Restricted Project, Restricted Project, Restricted Project

May 11 2023

kzhuravl added inline comments to D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941.
May 11 2023, 8:32 AM · Restricted Project, Restricted Project, Restricted Project
kzhuravl updated the diff for D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941.

Address review comments.

May 11 2023, 8:32 AM · Restricted Project, Restricted Project, Restricted Project
kzhuravl added a comment to D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941.

I think that if this is a new property of the GFX940/941 targets, and turning it off shouldn't be possible, we shouldn't even bother with a feature and just set a bool in the ST for those targets

May 11 2023, 5:24 AM · Restricted Project, Restricted Project, Restricted Project

May 10 2023

kzhuravl added inline comments to D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941.
May 10 2023, 9:26 AM · Restricted Project, Restricted Project, Restricted Project
kzhuravl committed rGfae9e7d46ce5: AMDGPU: Factor out GFX9.4 common features into a feature set (authored by kzhuravl).
AMDGPU: Factor out GFX9.4 common features into a feature set
May 10 2023, 8:46 AM · Restricted Project, Restricted Project
kzhuravl committed rG9d0572797233: AMDGPU: Add basic gfx942 target (authored by kzhuravl).
AMDGPU: Add basic gfx942 target
May 10 2023, 8:46 AM · Restricted Project, Restricted Project, Restricted Project
kzhuravl committed rG1fc70210a6a5: AMDGPU: Add basic gfx941 target (authored by kzhuravl).
AMDGPU: Add basic gfx941 target
May 10 2023, 8:46 AM · Restricted Project, Restricted Project, Restricted Project
kzhuravl closed D149985: AMDGPU: Factor out GFX9.4 common features into a feature set.
May 10 2023, 8:46 AM · Restricted Project, Restricted Project
kzhuravl closed D149983: AMDGPU: Add basic gfx942 target.
May 10 2023, 8:46 AM · Restricted Project, Restricted Project, Restricted Project
kzhuravl closed D149982: AMDGPU: Add basic gfx941 target.
May 10 2023, 8:46 AM · Restricted Project, Restricted Project, Restricted Project

May 9 2023

kzhuravl added a comment to D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941.

Should this be a feature set by default in the subtarget constructor instead? Should you be able to turn this off?

May 9 2023, 11:38 AM · Restricted Project, Restricted Project, Restricted Project

May 5 2023

kzhuravl added a reviewer for D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941: Restricted Project.
May 5 2023, 12:48 PM · Restricted Project, Restricted Project, Restricted Project
kzhuravl added a reviewer for D149985: AMDGPU: Factor out GFX9.4 common features into a feature set: Restricted Project.
May 5 2023, 12:48 PM · Restricted Project, Restricted Project
kzhuravl added a reviewer for D149983: AMDGPU: Add basic gfx942 target: Restricted Project.
May 5 2023, 12:48 PM · Restricted Project, Restricted Project, Restricted Project
kzhuravl added a reviewer for D149982: AMDGPU: Add basic gfx941 target: Restricted Project.
May 5 2023, 12:47 PM · Restricted Project, Restricted Project, Restricted Project
kzhuravl requested review of D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941.
May 5 2023, 12:44 PM · Restricted Project, Restricted Project, Restricted Project
kzhuravl requested review of D149985: AMDGPU: Factor out GFX9.4 common features into a feature set.
May 5 2023, 12:44 PM · Restricted Project, Restricted Project
kzhuravl requested review of D149983: AMDGPU: Add basic gfx942 target.
May 5 2023, 12:43 PM · Restricted Project, Restricted Project, Restricted Project
kzhuravl requested review of D149982: AMDGPU: Add basic gfx941 target.
May 5 2023, 12:42 PM · Restricted Project, Restricted Project, Restricted Project
kzhuravl abandoned D117797: Revert "[amdgpu] Improve the from f32 to i64.".

Issue was fixed by another change.

May 5 2023, 12:33 PM · Restricted Project, Restricted Project
kzhuravl abandoned D108322: AMDGPU: Add options to override SGPR and VGPR blocks.
May 5 2023, 12:32 PM · Restricted Project, Restricted Project
kzhuravl added a comment to D108322: AMDGPU: Add options to override SGPR and VGPR blocks.

Is this still relevant? Would this be better served by making the lower bound of amdgpu-waves-per-eu artificially increase the register usage?

May 5 2023, 12:32 PM · Restricted Project, Restricted Project
kzhuravl abandoned D31874: AMDGPU: Switch aperture queries to use aperture registers instead of s_getreg_b32.
May 5 2023, 12:31 PM · Restricted Project
kzhuravl abandoned D81780: AMDGPU/AMDHSA: Implement new target ID support in AMDGPU backend.
May 5 2023, 12:30 PM · Restricted Project, Restricted Project
kzhuravl committed rGa1be6f0290ef: AMDGPU: Reserve 0x048, 0x049, 0x04a MACHs (authored by kzhuravl).
AMDGPU: Reserve 0x048, 0x049, 0x04a MACHs
May 5 2023, 8:05 AM · Restricted Project, Restricted Project
kzhuravl closed D149856: AMDGPU: Reserve 0x048, 0x049, 0x04a MACHs.
May 5 2023, 8:05 AM · Restricted Project, Restricted Project

May 4 2023

kzhuravl added a reviewer for D149856: AMDGPU: Reserve 0x048, 0x049, 0x04a MACHs: Restricted Project.
May 4 2023, 8:13 AM · Restricted Project, Restricted Project
kzhuravl requested review of D149856: AMDGPU: Reserve 0x048, 0x049, 0x04a MACHs.
May 4 2023, 8:13 AM · Restricted Project, Restricted Project

May 2 2023

kzhuravl accepted D146119: [llvm-readobj][AMDGPU] Bypass MD verification for PAL.

looks good

May 2 2023, 7:00 AM · Restricted Project, Restricted Project

Apr 4 2023

kzhuravl added a comment to D141700: AMDGPU: Move enqueued block handling into clang.

Overall looks good.

Apr 4 2023, 8:25 AM · Restricted Project, Restricted Project

Mar 27 2023

kzhuravl accepted D143731: [AMDGPU] Break-up large PHIs for DAGISel.

lgtm, thanks!

Mar 27 2023, 6:54 PM · Restricted Project, Restricted Project

Mar 14 2023

kzhuravl added inline comments to D146023: [AMDGPU] Remove Code Object V2.
Mar 14 2023, 6:37 AM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2023

kzhuravl added a comment to D145671: [clang] Remove legacy -m(no)-code-object-v3 options.

Did you go through the deprecation process for this option? We need to send a documentation team first so that it is announced to the users. Then in the next release we can deprecate it.

Mar 9 2023, 9:24 AM · Restricted Project, Restricted Project
kzhuravl added a reviewer for D145671: [clang] Remove legacy -m(no)-code-object-v3 options: t-tye.
Mar 9 2023, 6:52 AM · Restricted Project, Restricted Project
kzhuravl added a reviewer for D145671: [clang] Remove legacy -m(no)-code-object-v3 options: yaxunl.
Mar 9 2023, 6:50 AM · Restricted Project, Restricted Project

Mar 8 2023

kzhuravl accepted D145401: [AMDGPU] Reserve extra SGPR blocks wth XNACK "any" TID Setting.

LGTM, but please add a todo or a fixme (see comment below), thanks

Mar 8 2023, 2:19 AM · Restricted Project, Restricted Project, Restricted Project

Mar 7 2023

kzhuravl added inline comments to D145401: [AMDGPU] Reserve extra SGPR blocks wth XNACK "any" TID Setting.
Mar 7 2023, 3:45 PM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2023

kzhuravl added a reviewer for D144162: [AMDGPU] Replace LegacyDA with Uniformity Analysis in AnnotateUniformValues: Pierre-vh.
Feb 22 2023, 12:30 PM · Restricted Project, Restricted Project, Restricted Project

Jan 24 2023

kzhuravl accepted D142407: [AMDGPU] Split dot8 feature.

LGTM, thanks

Jan 24 2023, 10:48 AM · Restricted Project, Restricted Project, Restricted Project

Jan 5 2023

kzhuravl accepted D141012: [AMDGPU] Add .uniform_work_group_size metadata to v5.

lgtm

Jan 5 2023, 12:30 PM · Restricted Project, Restricted Project

Dec 13 2022

kzhuravl accepted D139931: [AMDGPU] Add `.workgroup_processor_mode` to v5 MD.

lgtm, thanks

Dec 13 2022, 7:42 AM · Restricted Project, Restricted Project
kzhuravl added inline comments to D139931: [AMDGPU] Add `.workgroup_processor_mode` to v5 MD.
Dec 13 2022, 7:24 AM · Restricted Project, Restricted Project
kzhuravl added a comment to D139931: [AMDGPU] Add `.workgroup_processor_mode` to v5 MD.

Also needs a test.

Dec 13 2022, 6:24 AM · Restricted Project, Restricted Project

Sep 19 2022

kzhuravl accepted D130105: [NFC][AMDGPU] Refactor AMDGPUDisassembler.

LGTM, thanks!

Sep 19 2022, 7:56 AM · Restricted Project, Restricted Project

Aug 18 2022

kzhuravl added a comment to D132145: AMDGPU/MetaData: Restrict address space key to only be emitted for "global_buffer" and "dynamic_shared_pointer".

Please upload the full diff

Aug 18 2022, 10:04 AM · Restricted Project, Restricted Project

Aug 4 2022

kzhuravl added a reviewer for D131019: Revert "[AMDGPU] Only count global-to-global as indirect accesses": foad.

Adding Jay

Aug 4 2022, 12:00 PM · Restricted Project, Restricted Project

Jul 18 2022

kzhuravl accepted D129906: [AMDGPU] Support for gfx940 fp8 mfma.
Jul 18 2022, 12:08 PM · Restricted Project, Restricted Project, Restricted Project
kzhuravl accepted D129902: [AMDGPU] Support for gfx940 fp8 conversions.
Jul 18 2022, 11:26 AM · Restricted Project, Restricted Project, Restricted Project
kzhuravl accepted D129908: [AMDGPU] Support for gfx940 fp8 smfmac.
Jul 18 2022, 11:11 AM · Restricted Project, Restricted Project, Restricted Project

Jul 15 2022

kzhuravl added a comment to D129818: AMDGPU: Make default AMDHSA Code Object Version to be 5.

Need to also update: https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Driver/Options.td#L3626

Jul 15 2022, 9:42 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 29 2022

kzhuravl accepted D128344: [AMDGPU] Add the uses_dynamic_stack field to the kernel descriptor and the kernel metadata map.
Jun 29 2022, 10:20 AM · Restricted Project, Restricted Project

Jun 28 2022

kzhuravl accepted D115562: AMDGPU: Remove amdgpu-waves-per-eu support in old attribute pass.

LGTM, thanks

Jun 28 2022, 6:50 AM · Restricted Project, Restricted Project

Jun 24 2022

kzhuravl committed rG7736ce1c56c7: AMDGPU: Clear kill flags when optimizing vcmp save exec sequence (authored by kzhuravl).
AMDGPU: Clear kill flags when optimizing vcmp save exec sequence
Jun 24 2022, 8:33 AM · Restricted Project, Restricted Project
kzhuravl closed D127768: AMDGPU: Clear kill flags when optimizing vcmp save exec sequence.
Jun 24 2022, 8:33 AM · Restricted Project, Restricted Project

Jun 22 2022

kzhuravl requested changes to D128344: [AMDGPU] Add the uses_dynamic_stack field to the kernel descriptor and the kernel metadata map.

Do we want to tie this bit to a particular code object version? Code object v4 and up? Why did you pick code object v3 and up?

Jun 22 2022, 8:48 AM · Restricted Project, Restricted Project
kzhuravl added a comment to D127768: AMDGPU: Clear kill flags when optimizing vcmp save exec sequence.

@arsenm, any additional feedback?

Jun 22 2022, 8:11 AM · Restricted Project, Restricted Project

Jun 20 2022

kzhuravl added inline comments to D127768: AMDGPU: Clear kill flags when optimizing vcmp save exec sequence.
Jun 20 2022, 10:01 AM · Restricted Project, Restricted Project
kzhuravl updated the diff for D127768: AMDGPU: Clear kill flags when optimizing vcmp save exec sequence.

Clear kill flags for Src0 if its a reg.

Jun 20 2022, 10:01 AM · Restricted Project, Restricted Project

Jun 14 2022

kzhuravl updated the diff for D127768: AMDGPU: Clear kill flags when optimizing vcmp save exec sequence.

Handle non register case and add a test for it.

Jun 14 2022, 12:40 PM · Restricted Project, Restricted Project
kzhuravl added a comment to D127768: AMDGPU: Clear kill flags when optimizing vcmp save exec sequence.

Why not to remove original v_cmp instead? It should have no other uses.

Original v_cmp_eq_u32 got removed in favor of v_cmpx_eq_u32. v_cmp_ne_u32 is left as is.

OK, I see. That's another instruction in between kills it..

What if src1 is not register?

Jun 14 2022, 12:39 PM · Restricted Project, Restricted Project
kzhuravl added a comment to D127768: AMDGPU: Clear kill flags when optimizing vcmp save exec sequence.

Why not to remove original v_cmp instead? It should have no other uses.

Jun 14 2022, 11:47 AM · Restricted Project, Restricted Project
kzhuravl updated the summary of D127768: AMDGPU: Clear kill flags when optimizing vcmp save exec sequence.
Jun 14 2022, 10:36 AM · Restricted Project, Restricted Project
kzhuravl requested review of D127768: AMDGPU: Clear kill flags when optimizing vcmp save exec sequence.
Jun 14 2022, 10:35 AM · Restricted Project, Restricted Project

Jun 9 2022

kzhuravl accepted D127241: [AMDGPU] gfx11 add bits to COMPUTE_PGM_RSRC3.

LGTM, can you wait and see if @rampitec has any additional comments?

Jun 9 2022, 7:54 AM · Restricted Project, Restricted Project
kzhuravl added a comment to D127241: [AMDGPU] gfx11 add bits to COMPUTE_PGM_RSRC3.

Can you add documentation to AMDGPUUsage in this patch as well?

That's in D127402 which is in review right now.

Jun 9 2022, 7:53 AM · Restricted Project, Restricted Project
kzhuravl added a comment to D127241: [AMDGPU] gfx11 add bits to COMPUTE_PGM_RSRC3.

This looks like it affects gfx10 as well, while probably should not?

@kzhuravl Do you know about this?

GFX10 is only using COMPUTE_PGM_RSRC3_GFX10_PLUS.SHARED_VGPR_COUNT, the rest of the bits for GFX10 are reserved and must be 0.

GFX11 is using COMPUTE_PGM_RSRC3_GFX10_PLUS.INST_PREF_SIZE and others.

This is similar to how we do other compute program resource registers. E.g.:

...
  COMPUTE_PGM_RSRC1(BULKY, 24, 1),
  COMPUTE_PGM_RSRC1(CDBG_USER, 25, 1),
  COMPUTE_PGM_RSRC1(FP16_OVFL, 26, 1),    // GFX9+
  COMPUTE_PGM_RSRC1(RESERVED0, 27, 2),
  COMPUTE_PGM_RSRC1(WGP_MODE, 29, 1),     // GFX10+
  COMPUTE_PGM_RSRC1(MEM_ORDERED, 30, 1),  // GFX10+
  COMPUTE_PGM_RSRC1(FWD_PROGRESS, 31, 1), // GFX10+
...

The reason we have 2 different compute program resource register 3 is because GFX90A and GFX10 have completely different layout for those. So I think this header file should be fine.

Can you add documentation to AMDGPUUsage in this patch as well?

Thanks

Jun 9 2022, 7:47 AM · Restricted Project, Restricted Project
kzhuravl added a comment to D127241: [AMDGPU] gfx11 add bits to COMPUTE_PGM_RSRC3.

This looks like it affects gfx10 as well, while probably should not?

@kzhuravl Do you know about this?

Jun 9 2022, 7:45 AM · Restricted Project, Restricted Project

Apr 28 2022

kzhuravl accepted D124536: [AMDGPU] Add gfx11 subtarget ELF definition.

LGTM, thanks

Apr 28 2022, 9:18 AM · Restricted Project, Restricted Project, Restricted Project
kzhuravl requested changes to D124536: [AMDGPU] Add gfx11 subtarget ELF definition.

Need to update processor table: https://llvm.org/docs/AMDGPUUsage.html#processors
Need to update EF_AMDGPU_MACH_AMDGCN table: https://llvm.org/docs/AMDGPUUsage.html#amdgpu-ef-amdgpu-mach-table

Apr 28 2022, 8:30 AM · Restricted Project, Restricted Project, Restricted Project
kzhuravl added a comment to D124536: [AMDGPU] Add gfx11 subtarget ELF definition.

Looks like this change is missing doc updates?

Apr 28 2022, 8:28 AM · Restricted Project, Restricted Project, Restricted Project
kzhuravl accepted D124537: [AMDGPU][clang] Definition of gfx11 subtarget.
Apr 28 2022, 8:25 AM · Restricted Project, Restricted Project

Apr 13 2022

kzhuravl accepted D123687: [AMDGPU] Increate hazard for store dwordx3/4 to 2 waitstates on gfx940.

LGTM, thanks!

Apr 13 2022, 2:05 PM · Restricted Project, Restricted Project

Mar 29 2022

kzhuravl accepted D122339: [AMDGPU] gfx940 VALU hazard recognizer.

LGTM with clang formatting fixed

Mar 29 2022, 9:36 AM · Restricted Project, Restricted Project

Mar 24 2022

kzhuravl accepted D122044: [AMDGPU] New gfx940 mfma instructions.

LGTM, unless @foad has any additional questions

Mar 24 2022, 11:50 AM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2022

kzhuravl accepted D122191: [AMDGPU] Support gfx940 smfmac instructions.

LGTM with a minor nit

Mar 23 2022, 12:43 PM · Restricted Project, Restricted Project, Restricted Project

Mar 22 2022

kzhuravl added a comment to D122190: [AMDGPU][LLD] Adding support for ABI version 5 option.

Do we need to add the test for it?

Mar 22 2022, 1:02 PM · Restricted Project, Restricted Project

Mar 18 2022

kzhuravl accepted D121966: [AMDGPU] gfx940 basic speed model.
Mar 18 2022, 12:36 PM · Restricted Project, Restricted Project
kzhuravl accepted D121745: [AMDGPU] reuse blgp as neg in 2 mfma operations on gfx940.

LGTM

Mar 18 2022, 12:32 PM · Restricted Project, Restricted Project

Mar 17 2022

kzhuravl accepted D121741: [AMDGPU] New MFMA names for existing instructions.

LGTM

Mar 17 2022, 1:18 PM · Restricted Project, Restricted Project
kzhuravl accepted D121811: [AMDGPU][DOC][NFC] Add links to MI200 documentation.

LGTM, thanks

Mar 17 2022, 12:41 PM · Restricted Project, Restricted Project
kzhuravl added inline comments to D121745: [AMDGPU] reuse blgp as neg in 2 mfma operations on gfx940.
Mar 17 2022, 12:38 PM · Restricted Project, Restricted Project
kzhuravl accepted D120849: [AMDGPU] Add gfx90a and gfx940 to get_elf_mach_gfx_name.cpp.

lgtm

Mar 17 2022, 12:31 PM · Restricted Project, Restricted Project

Mar 14 2022

kzhuravl accepted D121634: [AMDGPU] gfx940: disable OP_SEL on V_DOT instructions.
Mar 14 2022, 4:43 PM · Restricted Project, Restricted Project

Mar 11 2022

kzhuravl accepted D121234: [AMDGPU] gfx940 MUBUF format changes.

LGTM with the nit fixed

Mar 11 2022, 10:51 AM · Restricted Project, Restricted Project

Mar 9 2022

kzhuravl added a reviewer for D121242: [AMDGPU] gfx940 memory model: t-tye.

Adding Tony

Mar 9 2022, 10:18 AM · Restricted Project, Restricted Project

Mar 7 2022

kzhuravl accepted D105507: [AMDGPU] Add gfx10 assembler directive to specify shared VGPR count.

LGTM, thanks for taking this over!

Mar 7 2022, 1:43 PM · Restricted Project, Restricted Project
kzhuravl accepted D120769: [AMDGPU] gfx940: support V_FMAMK_F32 and V_FMAAK_F32.

LGTM, thanks

Mar 7 2022, 11:09 AM · Restricted Project, Restricted Project
kzhuravl accepted D120855: [AMDGPU] gfx940 uses new names for coherency bits.

Other than a TODO comment, LGTM, thanks

Mar 7 2022, 10:23 AM · Restricted Project, Restricted Project
kzhuravl accepted D121028: [AMDGPU] new gfx940 fp atomics.

lgtm

Mar 7 2022, 8:52 AM · Restricted Project, Restricted Project, Restricted Project
kzhuravl added inline comments to D121028: [AMDGPU] new gfx940 fp atomics.
Mar 7 2022, 8:40 AM · Restricted Project, Restricted Project, Restricted Project

Mar 3 2022

Herald added a project to D117797: Revert "[amdgpu] Improve the from f32 to i64.": Restricted Project.

ping

Mar 3 2022, 9:30 AM · Restricted Project, Restricted Project

Mar 2 2022

kzhuravl accepted D120763: [AMDGPU] gfx940 removes all image instructions.

lgtm

Mar 2 2022, 11:10 AM · Restricted Project, Restricted Project

Mar 1 2022

kzhuravl accepted D120688: [AMDGPU] Add gfx940 target.

LGTM, maybe give a day or so before merging this, so other folks have a chance to take a look

Mar 1 2022, 5:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 15 2022

kzhuravl accepted D119869: [AMDGPU] Do not define GET_INSTRINFO_SCHED_ENUM.

lgtm, thanks

Feb 15 2022, 12:50 PM · Restricted Project