User Details
- User Since
- Feb 16 2016, 12:13 PM (407 w, 3 d)
Aug 25 2023
Adding Pierre as he worked on this recently as well.
Jul 12 2023
May 12 2023
Address @arsenm's comment
Address review feedback
May 11 2023
Address review comments.
May 10 2023
May 9 2023
May 5 2023
Issue was fixed by another change.
May 4 2023
May 2 2023
looks good
Apr 4 2023
Overall looks good.
Mar 27 2023
lgtm, thanks!
Mar 14 2023
Mar 9 2023
Mar 8 2023
LGTM, but please add a todo or a fixme (see comment below), thanks
Mar 7 2023
Feb 22 2023
Jan 24 2023
LGTM, thanks
Jan 5 2023
lgtm
Dec 13 2022
lgtm, thanks
Also needs a test.
Sep 19 2022
LGTM, thanks!
Aug 18 2022
Please upload the full diff
Aug 4 2022
Adding Jay
Jul 18 2022
Jul 15 2022
Need to also update: https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Driver/Options.td#L3626
Jun 29 2022
Jun 28 2022
LGTM, thanks
Jun 24 2022
Jun 22 2022
Do we want to tie this bit to a particular code object version? Code object v4 and up? Why did you pick code object v3 and up?
@arsenm, any additional feedback?
Jun 20 2022
Clear kill flags for Src0 if its a reg.
Jun 14 2022
Handle non register case and add a test for it.
Jun 9 2022
LGTM, can you wait and see if @rampitec has any additional comments?
Apr 28 2022
LGTM, thanks
Need to update processor table: https://llvm.org/docs/AMDGPUUsage.html#processors
Need to update EF_AMDGPU_MACH_AMDGCN table: https://llvm.org/docs/AMDGPUUsage.html#amdgpu-ef-amdgpu-mach-table
Looks like this change is missing doc updates?
Apr 13 2022
LGTM, thanks!
Mar 29 2022
LGTM with clang formatting fixed
Mar 24 2022
LGTM, unless @foad has any additional questions
Mar 23 2022
LGTM with a minor nit
Mar 22 2022
Do we need to add the test for it?
Mar 18 2022
LGTM
Mar 17 2022
LGTM
LGTM, thanks
lgtm
Mar 14 2022
Mar 11 2022
LGTM with the nit fixed
Mar 9 2022
Adding Tony
Mar 7 2022
LGTM, thanks for taking this over!
LGTM, thanks
Other than a TODO comment, LGTM, thanks
lgtm
Mar 3 2022
ping
Mar 2 2022
lgtm
Mar 1 2022
LGTM, maybe give a day or so before merging this, so other folks have a chance to take a look
Feb 15 2022
lgtm, thanks