User Details
- User Since
- Feb 16 2016, 12:13 PM (370 w, 5 d)
Tue, Mar 14
Thu, Mar 9
Wed, Mar 8
LGTM, but please a todo or a fixme (see comment below), thanks
Tue, Mar 7
Feb 22 2023
Jan 24 2023
LGTM, thanks
Jan 5 2023
lgtm
Dec 13 2022
lgtm, thanks
Also needs a test.
Sep 19 2022
LGTM, thanks!
Aug 18 2022
Please upload the full diff
Aug 4 2022
Adding Jay
Jul 18 2022
Jul 15 2022
Jun 29 2022
Jun 28 2022
LGTM, thanks
Jun 24 2022
Jun 22 2022
Do we want to tie this bit to a particular code object version? Code object v4 and up? Why did you pick code object v3 and up?
@arsenm, any additional feedback?
Jun 20 2022
Clear kill flags for Src0 if its a reg.
Jun 14 2022
Handle non register case and add a test for it.
Jun 9 2022
LGTM, can you wait and see if @rampitec has any additional comments?
Apr 28 2022
LGTM, thanks
Need to update processor table: https://llvm.org/docs/AMDGPUUsage.html#processors
Need to update EF_AMDGPU_MACH_AMDGCN table: https://llvm.org/docs/AMDGPUUsage.html#amdgpu-ef-amdgpu-mach-table
Looks like this change is missing doc updates?
Apr 13 2022
LGTM, thanks!
Mar 29 2022
LGTM with clang formatting fixed
Mar 24 2022
LGTM, unless @foad has any additional questions
Mar 23 2022
LGTM with a minor nit
Mar 22 2022
Do we need to add the test for it?
Mar 18 2022
LGTM
Mar 17 2022
LGTM
LGTM, thanks
lgtm
Mar 14 2022
Mar 11 2022
LGTM with the nit fixed
Mar 9 2022
Adding Tony
Mar 7 2022
LGTM, thanks for taking this over!
LGTM, thanks
Other than a TODO comment, LGTM, thanks
lgtm
Mar 3 2022
ping
Mar 2 2022
lgtm
Mar 1 2022
LGTM, maybe give a day or so before merging this, so other folks have a chance to take a look
Feb 15 2022
lgtm, thanks
Feb 10 2022
ping
Feb 3 2022
ping
Feb 2 2022
+Mark,Ron
This change introduces the regression in OpenCL conformance test: basic - kernel_memory_alignment_local. Does it require any corresponding runtime changes?
Jan 24 2022
lgtm
Can you also update summary to drop AMDGPULLVMExtensionsForHeterogeneousDebugging?
Any reason you are bringing in heterogeneous debugging bits in this change?
Can you upload a diff with the context?
Jan 20 2022
Jan 11 2022
LGTM, I have looked through the implementation, and it looks like a correct revert of https://reviews.llvm.org/rG640beb38e7710b939b3cfb3f4c54accc694b1d30. I have looked through most tests, but not all. Can you make sure to run lit tests before pushing your change? Thank you
Dec 28 2021
Dec 22 2021
Add @tpr to look at pal metadata changes
Dec 20 2021
Nov 23 2021
Nov 10 2021
LGTM with a nit below. Thanks!
Nov 9 2021
The metadata treats the minimum as 16?
Nov 4 2021
Agreed on needing a lit test
Oct 5 2021
ping
Sep 24 2021
LGTM, thanks!
Sep 23 2021
Probably need docs https://llvm.org/docs/AMDGPUUsage.html#llvm-ir-attributes
Aug 27 2021
ping
Aug 20 2021
Address review feedback.
Aug 19 2021
Aug 18 2021
Jul 7 2021
Jul 6 2021
Jun 24 2021
lgtm