Page MenuHomePhabricator
People kzhuravl

kzhuravl (Konstantin Zhuravlyov)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 16 2016, 12:13 PM (169 w, 6 d)

Recent Activity
View All

Mon, May 13

kzhuravl accepted D61856: [test]Make test work on Windows.

LGTM, thanks!

Mon, May 13, 2:50 PM · Restricted Project
kzhuravl accepted D61868: [AMDGPU] gfx1010 SearchableTableEmitter patch for NSA.

LGTM

Mon, May 13, 2:46 PM · Restricted Project

Fri, May 10

kzhuravl added a comment to D61528: Revert "[AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`.".
In D61528#1490289, @arsenm wrote:

Should not revert to fix performance problems. A proper fix should be found

Fri, May 10, 2:58 PM
kzhuravl updated the diff for D61528: Revert "[AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`.".

Address review feedback.

Fri, May 10, 2:58 PM

Thu, May 9

kzhuravl accepted D61763: AMDGPU] Pattern for v_xor3_b32.

LGTM

Thu, May 9, 4:38 PM · Restricted Project
kzhuravl accepted D61703: [AMDGPU] gfx1010 v_interp_* instructions.

LGTM

Thu, May 9, 11:00 AM · Restricted Project
kzhuravl accepted D61704: [AMDGPU] gfx1010 changes for PAL metadata.

LGTM

Thu, May 9, 8:47 AM · Restricted Project

Wed, May 8

kzhuravl accepted D61701: [AMDGPU] gfx1010 exp modifications.

LGTM

Wed, May 8, 2:20 PM · Restricted Project

Mon, May 6

kzhuravl accepted D61521: [AMDGPU] gfx1010 verifier changes.

LGTM with a todo about tests?

Mon, May 6, 3:23 PM · Restricted Project
kzhuravl accepted D61525: [AMDGPU] gfx1010: prefer V_MUL_LO_U32 over V_MUL_LO_I32.

LGTM

Mon, May 6, 3:09 PM · Restricted Project
kzhuravl accepted D61535: [AMDGPU] gfx1010 memory legalizer.

LGTM

Mon, May 6, 2:26 PM · Restricted Project

Fri, May 3

kzhuravl created D61528: Revert "[AMDGPU] Enable code selection using `s_mul_hi_u32`/`s_mul_hi_i32`.".
Fri, May 3, 12:31 PM

Wed, May 1

kzhuravl accepted D61416: [AMDGPU] gfx1010 lost VOP2 forms of some add/sub.

LGTM

Wed, May 1, 7:48 PM
kzhuravl accepted D61413: [AMDGPU] gfx1010 allows VOP3 to have a literal.

LGTM

Wed, May 1, 7:22 PM · Restricted Project
kzhuravl accepted D61404: [AMDGPU] gfx1010 constant bus limit.

LGTM

Wed, May 1, 6:06 PM · Restricted Project
kzhuravl added inline comments to D61341: [AMDGPU] gfx1010 GCNNSAReassign pass.
Wed, May 1, 8:43 AM · Restricted Project
kzhuravl accepted D61344: [AMDGPU] gfx1010 GCNRegBankReassign pass.

LGTM

Wed, May 1, 8:43 AM · Restricted Project
kzhuravl accepted D61341: [AMDGPU] gfx1010 GCNNSAReassign pass.

LGTM

Wed, May 1, 8:40 AM · Restricted Project
kzhuravl accepted D61339: [AMDGPU] gfx1010 MIMG implementation.

LGTM

Wed, May 1, 8:39 AM · Restricted Project
kzhuravl accepted D61332: [AMDGPU] gfx1010 DS implementation.

LGTM

Wed, May 1, 8:23 AM · Restricted Project

Tue, Apr 30

kzhuravl accepted D61330: [AMDGPU] gfx1010 VMEM and SMEM implementation.

LGTM

Tue, Apr 30, 2:45 PM · Restricted Project

Fri, Apr 26

kzhuravl accepted D61208: [AMDGPU] gfx1010 VOPC implementation.

LGTM

Fri, Apr 26, 3:59 PM · Restricted Project
kzhuravl added inline comments to D61202: [AMDGPU] gfx1010 VOP3 and VOP3P implementation.
Fri, Apr 26, 10:50 AM · Restricted Project
kzhuravl accepted D61202: [AMDGPU] gfx1010 VOP3 and VOP3P implementation.

LGTM

Fri, Apr 26, 10:50 AM · Restricted Project
kzhuravl accepted D61156: [AMDGPU] gfx1010 VOP2 changes.

LGTM

Fri, Apr 26, 8:32 AM · Restricted Project

Thu, Apr 25

kzhuravl accepted D61099: [AMDGPU] gfx1010 VOP1 instructions.

LGTM

Thu, Apr 25, 11:53 AM · Restricted Project
kzhuravl accepted D61094: [AMDGPU] gfx1010 utility functions.

LGTM

Thu, Apr 25, 11:20 AM · Restricted Project

Wed, Apr 24

kzhuravl accepted D61080: [AMDGPU] gfx1010 SOP instructions.

LGTM

Wed, Apr 24, 1:23 PM · Restricted Project
kzhuravl accepted D61045: [AMDGPU] gfx1010 sgpr register changes.

LGTM

Wed, Apr 24, 10:13 AM · Restricted Project
kzhuravl accepted D61041: [AMDGPU] Add gfx1010 target definitions.

LGTM

Wed, Apr 24, 8:52 AM · Restricted Project

Mon, Apr 22

kzhuravl accepted D60858: AMDGPU: Skip debug instructions in assert.

LGTM, thx

Mon, Apr 22, 9:05 AM
kzhuravl accepted D60915: [AMDGPU] Fix hidden argument metadata duplication for V3.

LGTM

Mon, Apr 22, 9:05 AM · Restricted Project

Apr 5 2019

kzhuravl accepted D60346: [AMDGPU] Sort out and rename multiple CI/VI predicates.

LGTM

Apr 5 2019, 5:07 PM · Restricted Project
kzhuravl added inline comments to D60292: [AMDGPU] predicate and feature refactoring.
Apr 5 2019, 11:05 AM · Restricted Project
kzhuravl accepted D60292: [AMDGPU] predicate and feature refactoring.

LGTM. Minor comment which does not affect the LGTM! Thanks for doing this.

Apr 5 2019, 11:00 AM · Restricted Project

Apr 3 2019

kzhuravl committed rG6dff95cf55e4: AMDGPU/NFC: Add offset field to arg metadata (required for code object v3) (authored by kzhuravl).
AMDGPU/NFC: Add offset field to arg metadata (required for code object v3)
Apr 3 2019, 12:07 PM
kzhuravl committed rL357623: AMDGPU/NFC: Add offset field to arg metadata (required for code object v3).
AMDGPU/NFC: Add offset field to arg metadata (required for code object v3)
Apr 3 2019, 12:07 PM

Apr 2 2019

kzhuravl reclaimed D31874: AMDGPU: Switch aperture queries to use aperture registers instead of s_getreg_b32.
Apr 2 2019, 12:49 PM
kzhuravl abandoned D31872: AMDGPU: Minor SReg64 register class refactoring.
Apr 2 2019, 12:44 PM
kzhuravl abandoned D31873: AMDGPU/GFX9: Add AsmPrinter support for aperture registers.
Apr 2 2019, 12:43 PM
kzhuravl abandoned D31874: AMDGPU: Switch aperture queries to use aperture registers instead of s_getreg_b32.
Apr 2 2019, 12:43 PM
kzhuravl abandoned D44544: llvm-objdump: Print symbol name if it's address is the same as the next one's.
Apr 2 2019, 12:43 PM
kzhuravl abandoned D38959: AMDGPU: Don't use TargetStreamer if it has not been initialized.
Apr 2 2019, 12:43 PM
kzhuravl abandoned D59717: AMDGPU: Ignore SRAM ECC feature when inlining.
Apr 2 2019, 12:43 PM

Apr 1 2019

kzhuravl accepted D60106: AMDGPU: Assume ECC is enabled by default if supported.

LGTM

Apr 1 2019, 9:47 PM

Mar 29 2019

kzhuravl committed rG2b766ed774d4: AMDGPU: Make sram-ecc off by default for Vega20 (authored by kzhuravl).
AMDGPU: Make sram-ecc off by default for Vega20
Mar 29 2019, 5:05 AM
kzhuravl committed rL357247: AMDGPU: Make sram-ecc off by default for Vega20.
AMDGPU: Make sram-ecc off by default for Vega20
Mar 29 2019, 5:05 AM
kzhuravl closed D59718: AMDGPU: Make sram-ecc off by default for Vega20.
Mar 29 2019, 5:05 AM · Restricted Project

Mar 28 2019

kzhuravl accepted D59949: [AMDGPU] Add an additional Code Object V3 assembler example.

LGTM

Mar 28 2019, 10:53 AM · Restricted Project

Mar 25 2019

kzhuravl accepted D59782: [AMDGPU] Clarify Code Object V2/V3 differences in AMDGPUUsage.

LGTM

Mar 25 2019, 2:08 PM · Restricted Project
kzhuravl accepted D59008: [AMDGPU] Switch default dwarf version to 5.

LGTM

Mar 25 2019, 2:05 PM · Restricted Project
kzhuravl committed rGec28a1dcefc3: AMDGPU: Add support for cross address space synchronization scopes (clang) (authored by kzhuravl).
AMDGPU: Add support for cross address space synchronization scopes (clang)
Mar 25 2019, 1:55 PM
kzhuravl committed rL356947: AMDGPU: Add support for cross address space synchronization scopes (clang).
AMDGPU: Add support for cross address space synchronization scopes (clang)
Mar 25 2019, 1:55 PM
kzhuravl committed rC356947: AMDGPU: Add support for cross address space synchronization scopes (clang).
AMDGPU: Add support for cross address space synchronization scopes (clang)
Mar 25 2019, 1:55 PM
kzhuravl closed D59494: AMDGPU: Add support for cross address space synchronization scopes (clang).
Mar 25 2019, 1:55 PM · Restricted Project
kzhuravl committed rG51809cbc98ce: AMDGPU: Add support for cross address space synchronization scopes (authored by kzhuravl).
AMDGPU: Add support for cross address space synchronization scopes
Mar 25 2019, 1:50 PM
kzhuravl committed rL356946: AMDGPU: Add support for cross address space synchronization scopes.
AMDGPU: Add support for cross address space synchronization scopes
Mar 25 2019, 1:49 PM
kzhuravl closed D59517: AMDGPU: Add support for cross address space synchronization scopes.
Mar 25 2019, 1:49 PM · Restricted Project

Mar 22 2019

kzhuravl created D59718: AMDGPU: Make sram-ecc off by default for Vega20.
Mar 22 2019, 2:26 PM · Restricted Project
kzhuravl created D59717: AMDGPU: Ignore SRAM ECC feature when inlining.
Mar 22 2019, 2:08 PM

Mar 20 2019

kzhuravl added a comment to D59614: [AMDGPU] Add missing dependency on BinaryFormat.

Dup of D59610 ?

Mar 20 2019, 2:30 PM · Restricted Project
kzhuravl accepted D59613: [AMDGPU] Do not generate spurious PAL metadata.

LGTM

Mar 20 2019, 2:14 PM · Restricted Project
kzhuravl committed rG88268e3e3607: AMDHSA: Fix COMPUTE_PGM_RSRC2.USER_SGPR calculation when parsing ISA assembly (authored by kzhuravl).
AMDHSA: Fix COMPUTE_PGM_RSRC2.USER_SGPR calculation when parsing ISA assembly
Mar 20 2019, 12:44 PM
kzhuravl committed rL356603: AMDHSA: Fix COMPUTE_PGM_RSRC2.USER_SGPR calculation when parsing ISA assembly.
AMDHSA: Fix COMPUTE_PGM_RSRC2.USER_SGPR calculation when parsing ISA assembly
Mar 20 2019, 12:43 PM
kzhuravl closed D59570: AMDHSA: Fix COMPUTE_PGM_RSRC2.USER_SGPR calculation when parsing ISA assembly.
Mar 20 2019, 12:43 PM · Restricted Project

Mar 19 2019

kzhuravl created D59570: AMDHSA: Fix COMPUTE_PGM_RSRC2.USER_SGPR calculation when parsing ISA assembly.
Mar 19 2019, 5:14 PM · Restricted Project
kzhuravl updated the diff for D59517: AMDGPU: Add support for cross address space synchronization scopes.

Added docs and tests. Addressed review feedback.

Mar 19 2019, 1:34 PM · Restricted Project

Mar 18 2019

kzhuravl added a child revision for D59517: AMDGPU: Add support for cross address space synchronization scopes: D59494: AMDGPU: Add support for cross address space synchronization scopes (clang).
Mar 18 2019, 3:38 PM · Restricted Project
kzhuravl added a parent revision for D59494: AMDGPU: Add support for cross address space synchronization scopes (clang): D59517: AMDGPU: Add support for cross address space synchronization scopes.
Mar 18 2019, 3:38 PM · Restricted Project
kzhuravl created D59517: AMDGPU: Add support for cross address space synchronization scopes.
Mar 18 2019, 3:38 PM · Restricted Project
kzhuravl added a comment to D59517: AMDGPU: Add support for cross address space synchronization scopes.

This still requires some more tests to be added (which I am working on), and docs updated. I just wanted to get this out here for some early code reviews and testing on hw.

Mar 18 2019, 3:38 PM · Restricted Project
kzhuravl retitled D59494: AMDGPU: Add support for cross address space synchronization scopes (clang) from AMDGPU: Add support for cross address space synchronization scopes to AMDGPU: Add support for cross address space synchronization scopes (clang).
Mar 18 2019, 3:38 PM · Restricted Project
kzhuravl added inline comments to D59494: AMDGPU: Add support for cross address space synchronization scopes (clang).
Mar 18 2019, 3:38 PM · Restricted Project
kzhuravl updated the diff for D59494: AMDGPU: Add support for cross address space synchronization scopes (clang).

Address review feedback.

Mar 18 2019, 3:38 PM · Restricted Project
kzhuravl added a comment to D59494: AMDGPU: Add support for cross address space synchronization scopes (clang).

Backend change will be posted later today. I am currently working on adding backend tests.

Mar 18 2019, 8:29 AM · Restricted Project
kzhuravl created D59494: AMDGPU: Add support for cross address space synchronization scopes (clang).
Mar 18 2019, 8:29 AM · Restricted Project

Mar 13 2019

kzhuravl accepted D59330: [AMDGPU] Silence gcc 7 warnings.

LGTM

Mar 13 2019, 1:59 PM · Restricted Project

Mar 7 2019

kzhuravl committed rG47f0bf8f1fa0: AMDHSA: Code object v3 updates (authored by kzhuravl).
AMDHSA: Code object v3 updates
Mar 7 2019, 11:59 AM
kzhuravl committed rL355630: AMDHSA: Code object v3 updates.
AMDHSA: Code object v3 updates
Mar 7 2019, 11:59 AM
kzhuravl closed D59057: AMDHSA: Code object v3 updates.
Mar 7 2019, 11:59 AM · Restricted Project
kzhuravl updated the diff for D59057: AMDHSA: Code object v3 updates.

Address review feedback.

Mar 7 2019, 9:48 AM · Restricted Project

Mar 6 2019

kzhuravl created D59057: AMDHSA: Code object v3 updates.
Mar 6 2019, 3:07 PM · Restricted Project
kzhuravl committed rG3161c89a22f9: AMDGPU: Fix the mapping of sub group sync scope (authored by kzhuravl).
AMDGPU: Fix the mapping of sub group sync scope
Mar 6 2019, 12:54 PM
kzhuravl committed rL355549: AMDGPU: Fix the mapping of sub group sync scope.
AMDGPU: Fix the mapping of sub group sync scope
Mar 6 2019, 12:54 PM
kzhuravl committed rC355549: AMDGPU: Fix the mapping of sub group sync scope.
AMDGPU: Fix the mapping of sub group sync scope
Mar 6 2019, 12:54 PM
kzhuravl closed D58847: AMDGPU: Fix the mapping of sub group sync scope.
Mar 6 2019, 12:54 PM · Restricted Project

Mar 1 2019

kzhuravl created D58847: AMDGPU: Fix the mapping of sub group sync scope.
Mar 1 2019, 2:06 PM · Restricted Project

Feb 22 2019

kzhuravl committed rG9a278bf6b5f4: Revert "AMDGPU/NFC: Cleanup subtarget predicates" (authored by kzhuravl).
Revert "AMDGPU/NFC: Cleanup subtarget predicates"
Feb 22 2019, 3:21 PM
kzhuravl committed rL354700: Revert "AMDGPU/NFC: Cleanup subtarget predicates".
Revert "AMDGPU/NFC: Cleanup subtarget predicates"
Feb 22 2019, 3:20 PM

Feb 21 2019

kzhuravl accepted D58159: AMDGPU: Remove debugger related subtarget features.

LGTM

Feb 21 2019, 2:00 PM
kzhuravl accepted D58526: AMDGPU: Don't emit debugger subtarget features.

LGTM

Feb 21 2019, 1:04 PM
kzhuravl added a comment to D58159: AMDGPU: Remove debugger related subtarget features.

Can SIProgramInfo::DebuggerWavefrontPrivateSegmentOffsetSGPR and SIProgramInfo::DebuggerPrivateSegmentBufferSGPR be completely deleted?

Feb 21 2019, 12:57 PM
kzhuravl added a comment to D58159: AMDGPU: Remove debugger related subtarget features.

https://github.com/llvm-mirror/llvm/blob/master/lib/Target/AMDGPU/SIProgramInfo.h#L55
https://github.com/llvm-mirror/llvm/blob/master/lib/Target/AMDGPU/SIProgramInfo.h#L61

Feb 21 2019, 12:57 PM
kzhuravl committed rGc2650178a179: AMDGPU/NFC: Cleanup subtarget predicates (authored by kzhuravl).
AMDGPU/NFC: Cleanup subtarget predicates
Feb 21 2019, 12:44 PM
kzhuravl added inline comments to D58526: AMDGPU: Don't emit debugger subtarget features.
Feb 21 2019, 12:44 PM
kzhuravl committed rL354620: AMDGPU/NFC: Cleanup subtarget predicates.
AMDGPU/NFC: Cleanup subtarget predicates
Feb 21 2019, 12:43 PM
kzhuravl closed D58522: AMDGPU/NFC: Cleanup subtarget predicates.
Feb 21 2019, 12:43 PM · Restricted Project
kzhuravl added a comment to D58159: AMDGPU: Remove debugger related subtarget features.

I am in favor of removing these. Clang will also need to be updated around here:
https://github.com/llvm-mirror/clang/blob/master/lib/Driver/ToolChains/AMDGPU.cpp#L41

Feb 21 2019, 11:19 AM
kzhuravl created D58522: AMDGPU/NFC: Cleanup subtarget predicates.
Feb 21 2019, 11:09 AM · Restricted Project

Feb 14 2019

kzhuravl committed rG87498153aa12: LLD/AMDGPU: Preserve ABI version during linking ELF for AMDGPU (authored by kzhuravl).
LLD/AMDGPU: Preserve ABI version during linking ELF for AMDGPU
Feb 14 2019, 4:00 PM