This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] gfx11 vinterp instructions MC support
ClosedPublic

Authored by Joe_Nash on May 19 2022, 10:03 AM.

Details

Reviewers
critson
foad
arsenm
Group Reviewers
Restricted Project
Commits
rGef1ea5ac0133: [AMDGPU] gfx11 vinterp instructions MC support
Summary

A new instruction encoding. Some of these instructions were previously VOP3
encoded.

Contributors:
Carl Ritson <carl.ritson@amd.com>

Patch 11/N for upstreaming of AMDGPU gfx11 architecture.

Depends on D125824

Diff Detail

Event Timeline

Joe_Nash created this revision.May 19 2022, 10:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2022, 10:03 AM
Joe_Nash requested review of this revision.May 19 2022, 10:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2022, 10:03 AM
Joe_Nash added reviewers: critson, foad, arsenm, Restricted Project.May 19 2022, 10:05 AM

As with LDSDIR, probably needs a couple of tests for invalid values of wait_exp.

llvm/lib/Target/AMDGPU/SIInstrInfo.td
1480

I don't think these two lines are related to this change.

Joe_Nash updated this revision to Diff 431017.May 20 2022, 11:47 AM
Joe_Nash marked an inline comment as done.

added err tests for wait_exp and deleted unrelated lines

critson accepted this revision.May 24 2022, 6:33 PM

LGTM

This revision is now accepted and ready to land.May 24 2022, 6:33 PM
This revision was landed with ongoing or failed builds.May 25 2022, 12:27 PM
This revision was automatically updated to reflect the committed changes.