This reverts commit cce239c45d6ef3865a017b5b3f935964e0348734.
HHVM calling conventions are unused. Remove them by partially reverting the commit.
Paths
| Differential D124330
Revert "HHVM calling conventions." ClosedPublic Authored by Amir on Apr 23 2022, 9:20 AM.
Details Summary This reverts commit cce239c45d6ef3865a017b5b3f935964e0348734. HHVM calling conventions are unused. Remove them by partially reverting the commit.
Diff Detail
Event TimelineComment Actions Makes sense to me to drop this and I like the simplification. There is a chance that an out-of-tree target is overriding the getStackAlignmentSkew callback, but given that is at least pretty unlikely it's probably good to try to remove first and possibly bringing it back if there really was a user... Added one nitpick but otherwise seems good to go.
Amir added inline comments.
This revision is now accepted and ready to land.Feb 7 2023, 3:58 PM
Closed by commit rG782045e727b7: Revert "HHVM calling conventions." (authored by Amir). · Explain WhyFeb 9 2023, 10:53 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 495696 llvm/include/llvm/CodeGen/TargetFrameLowering.h
llvm/include/llvm/IR/CallingConv.h
llvm/lib/AsmParser/LLParser.cpp
llvm/lib/CodeGen/PrologEpilogInserter.cpp
llvm/lib/CodeGen/TargetFrameLoweringImpl.cpp
llvm/lib/IR/AsmWriter.cpp
llvm/lib/Target/X86/X86CallingConv.td
llvm/lib/Target/X86/X86ISelLowering.cpp
llvm/lib/Target/X86/X86RegisterInfo.cpp
llvm/test/CodeGen/X86/hhvm-cc.ll
llvm/test/CodeGen/X86/statepoint-fastregalloc.mir
llvm/test/Feature/callingconventions.ll
mlir/include/mlir/Dialect/LLVMIR/LLVMEnums.td
|
Maybe rename to make it more explicit this is gone now?