This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add lowering for vp.sext and vp.zext.
ClosedPublic

Authored by craig.topper on Apr 5 2022, 12:12 PM.

Details

Diff Detail

Event Timeline

craig.topper created this revision.Apr 5 2022, 12:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2022, 12:12 PM
craig.topper requested review of this revision.Apr 5 2022, 12:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2022, 12:12 PM
rogfer01 accepted this revision.Apr 6 2022, 3:37 AM

LGTM. Thanks @craig.topper !

This revision is now accepted and ready to land.Apr 6 2022, 3:37 AM
frasercrmck accepted this revision.Apr 6 2022, 4:03 AM

LGTM with some nits.

llvm/lib/Target/RISCV/RISCVISelLowering.cpp
3698

Not sure you need these parens, strictly speaking

3701

I'm surprised clang-format isn't complaining about this long line.

This revision was landed with ongoing or failed builds.Apr 6 2022, 10:00 AM
This revision was automatically updated to reflect the committed changes.