Thanks @craig.topper!

• Create the MachineMemOperand before invoking getStridedLoadVP
• Rebase

thanks @simoll!

Changelog:

Thanks @craig.topper!

I do not have commit rights, may I ask you to commit this for me? @craig.topper

Changelog:

Thanks @simoll!

In D123112#3662037, @simoll wrote:

I could not apply this patch. Please rebase again so i can commit.

Changelog:

Changelog:

Changelog

Changelog:

In D109584#3553244, @bmahjour wrote:

Following the discussion in the comments, remove expandPredicationInUnfoldedLoadStore() function (to be added in a follow-up patch)

Is there a follow up patch for this yet?

In D123112#3537527, @craig.topper wrote:

Is it possible to test this?

• Address review comments

• Address review comment

• Address some of the review comments

• Update tests

• Address review comments

• Use isAllOnesValue() instead of isOneValue()

• Use getSplatValue() instead of PatternMatch in isAllTrueMask()
• Update tests

• Add fixed vectors tests

• Use DataLayout to determine the alignment (if there is not one already)
• Add fixed vectors tests

• Improve isAllTrueMask() (for scalable vectors only)
• Add and update tests

• Use poison instead of undef in tests

• Address review comment

Thanks!

I do not have commit access, could anyone commit this for me please?

• Apply suggestions in the comments

• Remove unnecessary custom legalization of narrow scalar types
• Do not add new RISCVISD nodes, use existing intrinsics instead

• Update documentation
• Align with recent changes to vp_load and vp_store

• Address comments

• Change parent revisions to include both D109584 and D120664

• Changed the pointer operand type to match the scalar elements type of the data/return operand

• Remove VP gather/scatter references (to be added in a follow-up patch)
• Following the discussion in the comments, remove expandPredicationInUnfoldedLoadStore() function (to be added in a follow-up patch)
• Apply suggestions in comments
• Add tests

hello @hussainjk @bmahjour, are you still working on this? Otherwise, I may take it over on your behalf.

• Mention that the align parameter attribute can be provided for the base pointer operands

• use explicit return type in Intrinsic::getDeclaration() for experimental_vp_strided_load
  • get first argument type from first operand in Intrinsic::getDeclaration() for experimental_vp_strided_store

• ensure default alignment behaviour reflects changes in D114423
  • align MemoryLocation retrieval for VPStridedLoad to VPLoad (see D115036)

Thanks everybody! I do not have commit access, can anyone commit this for me?

ChangeLog:

• add documentation for the new intrinsics
• use MemoryLocation::UnknownSize
• use SmallVectorImpl<SDValue> in functions signatures