User Details
User Details
- User Since
- May 4 2021, 8:46 AM (91 w, 6 d)
Aug 22 2022
Aug 22 2022
loralb added a comment to D121784: [VP] Add splitting for VP_STRIDED_STORE and VP_STRIDED_LOAD.
Thanks @craig.topper!
Aug 17 2022
Aug 17 2022
loralb updated the diff for D121784: [VP] Add splitting for VP_STRIDED_STORE and VP_STRIDED_LOAD.
- Create the MachineMemOperand before invoking getStridedLoadVP
- Rebase
Aug 5 2022
Aug 5 2022
loralb added a comment to D121114: [VP] Add widening for VP_STRIDED_LOAD and VP_STRIDED_STORE.
thanks @simoll!
Aug 3 2022
Aug 3 2022
loralb updated the diff for D121114: [VP] Add widening for VP_STRIDED_LOAD and VP_STRIDED_STORE.
Changelog:
Aug 1 2022
Aug 1 2022
loralb added a comment to D121113: [RISCV][VP] Custom lower VP_STRIDED_LOAD and VP_STRIDED_STORE.
Thanks @craig.topper!
loralb added inline comments to D121784: [VP] Add splitting for VP_STRIDED_STORE and VP_STRIDED_LOAD.
loralb added a comment to D121113: [RISCV][VP] Custom lower VP_STRIDED_LOAD and VP_STRIDED_STORE.
I do not have commit rights, may I ask you to commit this for me? @craig.topper
Jul 20 2022
Jul 20 2022
loralb updated the diff for D121113: [RISCV][VP] Custom lower VP_STRIDED_LOAD and VP_STRIDED_STORE.
Changelog:
loralb added a comment to D123112: [VP] Legalize the stride operand for EXPERIMENTAL_VP_STRIDED SDNodes.
Thanks @simoll!
Jul 19 2022
Jul 19 2022
loralb added a comment to D123112: [VP] Legalize the stride operand for EXPERIMENTAL_VP_STRIDED SDNodes.
loralb updated the diff for D123112: [VP] Legalize the stride operand for EXPERIMENTAL_VP_STRIDED SDNodes.
Changelog:
Jul 14 2022
Jul 14 2022
loralb updated the diff for D123112: [VP] Legalize the stride operand for EXPERIMENTAL_VP_STRIDED SDNodes.
Changelog:
loralb updated the diff for D120664: [VP] IR expansion pass for VP gather and scatter.
Changelog
loralb updated the diff for D109584: [VP] Implementing expansion pass for VP load and store..
Changelog:
loralb added a comment to D109584: [VP] Implementing expansion pass for VP load and store..
Jun 9 2022
Jun 9 2022
loralb added a comment to D123112: [VP] Legalize the stride operand for EXPERIMENTAL_VP_STRIDED SDNodes.
May 23 2022
May 23 2022
loralb updated the diff for D123112: [VP] Legalize the stride operand for EXPERIMENTAL_VP_STRIDED SDNodes.
- Address review comments
May 19 2022
May 19 2022
loralb requested review of D125971: [RISCV] Ensure the forwarded AVL register is alive.
Apr 8 2022
Apr 8 2022
loralb updated the diff for D123112: [VP] Legalize the stride operand for EXPERIMENTAL_VP_STRIDED SDNodes.
- Address review comment
Apr 6 2022
Apr 6 2022
loralb updated the diff for D121784: [VP] Add splitting for VP_STRIDED_STORE and VP_STRIDED_LOAD.
- Address some of the review comments
loralb added inline comments to D121784: [VP] Add splitting for VP_STRIDED_STORE and VP_STRIDED_LOAD.
loralb updated the summary of D121784: [VP] Add splitting for VP_STRIDED_STORE and VP_STRIDED_LOAD.
Apr 5 2022
Apr 5 2022
loralb updated the diff for D121114: [VP] Add widening for VP_STRIDED_LOAD and VP_STRIDED_STORE.
- Update tests
loralb updated the diff for D121113: [RISCV][VP] Custom lower VP_STRIDED_LOAD and VP_STRIDED_STORE.
- Address review comments
loralb requested review of D123112: [VP] Legalize the stride operand for EXPERIMENTAL_VP_STRIDED SDNodes.
Mar 30 2022
Mar 30 2022
loralb updated the diff for D109584: [VP] Implementing expansion pass for VP load and store..
- Use isAllOnesValue() instead of isOneValue()
loralb added inline comments to D109584: [VP] Implementing expansion pass for VP load and store..
loralb updated the diff for D109584: [VP] Implementing expansion pass for VP load and store..
- Use getSplatValue() instead of PatternMatch in isAllTrueMask()
- Update tests
Mar 29 2022
Mar 29 2022
loralb updated the diff for D120564: [VP] IR expansion pass for VP strided load and store.
- Add fixed vectors tests
loralb updated the diff for D120664: [VP] IR expansion pass for VP gather and scatter.
- Use DataLayout to determine the alignment (if there is not one already)
- Add fixed vectors tests
Mar 28 2022
Mar 28 2022
loralb updated the diff for D109584: [VP] Implementing expansion pass for VP load and store..
- Improve isAllTrueMask() (for scalable vectors only)
- Add and update tests
Mar 16 2022
Mar 16 2022
loralb updated the diff for D121114: [VP] Add widening for VP_STRIDED_LOAD and VP_STRIDED_STORE.
- Use poison instead of undef in tests
loralb requested review of D121784: [VP] Add splitting for VP_STRIDED_STORE and VP_STRIDED_LOAD.
loralb updated the diff for D121113: [RISCV][VP] Custom lower VP_STRIDED_LOAD and VP_STRIDED_STORE.
- Address review comment
Mar 11 2022
Mar 11 2022
loralb added a comment to D114884: [VP] Strided loads/stores.
Thanks!
Mar 8 2022
Mar 8 2022
loralb added a comment to D114884: [VP] Strided loads/stores.
I do not have commit access, could anyone commit this for me please?
loralb added inline comments to D121114: [VP] Add widening for VP_STRIDED_LOAD and VP_STRIDED_STORE.
loralb updated the diff for D121114: [VP] Add widening for VP_STRIDED_LOAD and VP_STRIDED_STORE.
- Apply suggestions in the comments
loralb updated the diff for D121113: [RISCV][VP] Custom lower VP_STRIDED_LOAD and VP_STRIDED_STORE.
- Remove unnecessary custom legalization of narrow scalar types
- Do not add new RISCVISD nodes, use existing intrinsics instead
Mar 7 2022
Mar 7 2022
loralb requested review of D121114: [VP] Add widening for VP_STRIDED_LOAD and VP_STRIDED_STORE.
loralb requested review of D121113: [RISCV][VP] Custom lower VP_STRIDED_LOAD and VP_STRIDED_STORE.
loralb updated the diff for D114884: [VP] Strided loads/stores.
- Update documentation
- Align with recent changes to vp_load and vp_store
Mar 1 2022
Mar 1 2022
loralb updated the diff for D109584: [VP] Implementing expansion pass for VP load and store..
- Address comments
loralb updated the diff for D120564: [VP] IR expansion pass for VP strided load and store.
loralb updated the diff for D114884: [VP] Strided loads/stores.
- Changed the pointer operand type to match the scalar elements type of the data/return operand
Feb 28 2022
Feb 28 2022
loralb requested review of D120664: [VP] IR expansion pass for VP gather and scatter.
loralb added inline comments to D109584: [VP] Implementing expansion pass for VP load and store..
loralb updated the diff for D109584: [VP] Implementing expansion pass for VP load and store..
- Remove VP gather/scatter references (to be added in a follow-up patch)
- Following the discussion in the comments, remove expandPredicationInUnfoldedLoadStore() function (to be added in a follow-up patch)
- Apply suggestions in comments
- Add tests
Feb 25 2022
Feb 25 2022
loralb added a comment to D109584: [VP] Implementing expansion pass for VP load and store..
hello @hussainjk @bmahjour, are you still working on this? Otherwise, I may take it over on your behalf.
loralb added inline comments to D114884: [VP] Strided loads/stores.
loralb requested review of D120564: [VP] IR expansion pass for VP strided load and store.
Feb 18 2022
Feb 18 2022
loralb updated the diff for D114884: [VP] Strided loads/stores.
- Mention that the align parameter attribute can be provided for the base pointer operands
Dec 15 2021
Dec 15 2021
loralb updated the diff for D114884: [VP] Strided loads/stores.
- use explicit return type in Intrinsic::getDeclaration() for experimental_vp_strided_load
- get first argument type from first operand in Intrinsic::getDeclaration() for experimental_vp_strided_store
Dec 14 2021
Dec 14 2021
loralb updated the diff for D114884: [VP] Strided loads/stores.
Dec 13 2021
Dec 13 2021
loralb added a comment to D115027: [VP] [NFC] Fix vp_store signature and vp_gather examples.
Thanks everybody! I do not have commit access, can anyone commit this for me?
Dec 13 2021, 9:05 AM · Restricted Project
Dec 3 2021
Dec 3 2021
loralb added inline comments to D114884: [VP] Strided loads/stores.
loralb updated the diff for D114884: [VP] Strided loads/stores.
ChangeLog:
- add documentation for the new intrinsics
- use MemoryLocation::UnknownSize
- use SmallVectorImpl<SDValue> in functions signatures
loralb requested review of D115027: [VP] [NFC] Fix vp_store signature and vp_gather examples.
Dec 3 2021, 12:50 AM · Restricted Project
Dec 1 2021
Dec 1 2021
loralb requested review of D114884: [VP] Strided loads/stores.