This is an archive of the discontinued LLVM Phabricator instance.

re-roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".""
ClosedPublic

Authored by devin.jeanpierre on Apr 4 2022, 12:01 PM.

Details

Summary

This reverts commit b0bc93da926a943cdc2d8b04f8dcbe23a774520c.

Changes: s/_WIN32/_WIN64/g in clang/test/SemaCXX/attr-trivial-abi.cpp.

The calling convention is specific to 64-bit windows. It's even in the name: CCK_MicrosoftWin64.

After this, the test passes with both -triple i686-pc-win32 and -triple x86_64-pc-win32. Phew!

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald Transcript
devin.jeanpierre requested review of this revision.Apr 4 2022, 12:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2022, 12:01 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
devin.jeanpierre edited the summary of this revision. (Show Details)Apr 4 2022, 12:03 PM
gribozavr2 accepted this revision.Apr 28 2022, 5:03 AM
This revision is now accepted and ready to land.Apr 28 2022, 5:03 AM