- User Since
- Jul 18 2012, 9:18 AM (362 w, 12 h)
LGTM, assuming you know what's new in QtCreator.
Wed, Jun 19
Thanks! Please add tests in ./unittests/Tooling/ReplacementsYamlTest.cpp.
Thu, Jun 13
Wed, Jun 12
Tue, Jun 11
This fix works. The alternative would have been to wrap these variables into llvm::ManagedStatic, just like the problematic TrueMatcherInstance in ASTMatchersInternal.cpp.
I'll commit this change.
Fri, Jun 7
Thu, Jun 6
Is this patch still needed?
Wed, Jun 5
Tue, Jun 4
Looks great, thank you!
Sorry for jumping in late, but renaming the declaration is not enough -- usages should also be updated; otherwise the developer is better off using a refactoring in their IDE or even a textual search and replace.
I'm also not sure what the intent behind these tests is. Maybe the right fix is to add a constructor that can be called?
I'd suggest to add a separate file that covers the exact language modes needed.
Mon, Jun 3
Sorry, I reverted this change in r362413, it was breaking the build.