Page MenuHomePhabricator

gribozavr (Dmitri Gribenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 18 2012, 9:18 AM (353 w, 8 h)

Recent Activity

Today

gribozavr added a comment to D58573: [analyzer] Move UninitializedObjectChecker out of alpha.

Thanks for the checker! We are hitting a crash on _Atomic fields, could you take a look? https://bugs.llvm.org/show_bug.cgi?id=41590 Thanks!

Wed, Apr 24, 1:39 PM · Restricted Project

Yesterday

gribozavr added inline comments to D59963: [clang-tidy] Add a module for the Linux kernel..
Tue, Apr 23, 11:44 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D59963: [clang-tidy] Add a module for the Linux kernel..
Tue, Apr 23, 8:08 AM · Restricted Project, Restricted Project

Thu, Apr 18

gribozavr accepted D60865: [clangd] Use llvm::set_thread_priority in background-index.
Thu, Apr 18, 6:36 AM · Restricted Project
gribozavr accepted D60867: [clang][CIndex] Use llvm::set_thread_priority.
Thu, Apr 18, 6:31 AM · Restricted Project

Tue, Apr 16

gribozavr committed rGb9b35fd12d47: Fixed error message printing in write_cmake_config.py (authored by gribozavr).
Fixed error message printing in write_cmake_config.py
Tue, Apr 16, 11:15 PM
gribozavr committed rL358557: Fixed error message printing in write_cmake_config.py.
Fixed error message printing in write_cmake_config.py
Tue, Apr 16, 11:14 PM
gribozavr closed D60766: Fixed error message printing in write_cmake_config.py.
Tue, Apr 16, 11:14 PM · Restricted Project
gribozavr accepted D60779: [ADT] llvm::bsearch, binary search for mere mortals.
Tue, Apr 16, 9:25 AM · Restricted Project
gribozavr added a reviewer for D60766: Fixed error message printing in write_cmake_config.py: phosek.
Tue, Apr 16, 2:49 AM · Restricted Project
gribozavr created D60766: Fixed error message printing in write_cmake_config.py.
Tue, Apr 16, 2:48 AM · Restricted Project
gribozavr committed rG7fe7e15b2cf4: Removed CMake cache upgrade code from 2011 (authored by gribozavr).
Removed CMake cache upgrade code from 2011
Tue, Apr 16, 2:45 AM
gribozavr committed rL358482: Removed CMake cache upgrade code from 2011.
Removed CMake cache upgrade code from 2011
Tue, Apr 16, 2:44 AM
gribozavr closed D60711: Removed CMake cache upgrade code from 2011.
Tue, Apr 16, 2:44 AM · Restricted Project

Mon, Apr 15

gribozavr added reviewers for D60711: Removed CMake cache upgrade code from 2011: smeenai, chandlerc, phosek.
Mon, Apr 15, 8:15 AM · Restricted Project
gribozavr created D60711: Removed CMake cache upgrade code from 2011.
Mon, Apr 15, 8:06 AM · Restricted Project

Fri, Apr 12

gribozavr added inline comments to D60432: [clang][ASTContext] Simplify caching for declaration-related comments.
Fri, Apr 12, 2:11 AM · Restricted Project

Wed, Apr 10

gribozavr added a comment to D60494: [clang][ASTContext] Don't load external comments from Sema::ActOnDocumentableDecls.

On the functional side - does this look like a reasonable idea?

Wed, Apr 10, 5:16 PM
gribozavr committed rG66b6bb1766b3: Check i < FD->getNumParams() before querying (authored by gribozavr).
Check i < FD->getNumParams() before querying
Wed, Apr 10, 1:24 PM
gribozavr committed rL358134: Check i < FD->getNumParams() before querying.
Check i < FD->getNumParams() before querying
Wed, Apr 10, 1:24 PM
gribozavr committed rC358134: Check i < FD->getNumParams() before querying.
Check i < FD->getNumParams() before querying
Wed, Apr 10, 1:24 PM
gribozavr closed D60055: Check i < FD->getNumParams() before querying.
Wed, Apr 10, 1:23 PM · Restricted Project
gribozavr added a comment to D60055: Check i < FD->getNumParams() before querying.

I'd be happy to land it, but I do want @rsmith to take a look.

Wed, Apr 10, 7:05 AM · Restricted Project
gribozavr added a comment to D60494: [clang][ASTContext] Don't load external comments from Sema::ActOnDocumentableDecls.

The way I understand the intention in ActOnDocumentableDecls is that we are just checking if some of existing comments should be attached to newly created Decls. I assume we don't need to load external comments since those Decls are "local".

Wed, Apr 10, 3:11 AM
gribozavr accepted D60493: [clang][ASTContext] Try to exit early before loading serialize comments from AST files.
Wed, Apr 10, 3:11 AM · Restricted Project
gribozavr added inline comments to D60432: [clang][ASTContext] Simplify caching for declaration-related comments.
Wed, Apr 10, 2:29 AM · Restricted Project
gribozavr accepted D60055: Check i < FD->getNumParams() before querying.

This fix makes sense to me, however, Richard Smith @rsmith is the best person to review this patch.

Wed, Apr 10, 2:17 AM · Restricted Project

Sun, Mar 31

gribozavr accepted D60040: [clangd] Use capacity() instead of size() in RefSlab::bytes().

Do you have commit access?

Sun, Mar 31, 3:16 AM · Restricted Project, Restricted Project

Thu, Mar 28

gribozavr added inline comments to D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
Thu, Mar 28, 11:15 AM · Restricted Project
gribozavr accepted D59814: [Testing] Move clangd::Annotations to llvm testing support.
Thu, Mar 28, 9:56 AM · Restricted Project, Restricted Project

Tue, Mar 26

gribozavr added a comment to D59407: [clangd] Add RelationSlab.

Submitting code as it becomes ready is the usual practice here.

Tue, Mar 26, 5:37 PM · Restricted Project

Mar 22 2019

gribozavr added inline comments to D59650: [NFC] ExceptionEscapeCheck: small refactoring .
Mar 22 2019, 7:35 AM · Restricted Project, Restricted Project
gribozavr accepted D59650: [NFC] ExceptionEscapeCheck: small refactoring .
Mar 22 2019, 6:49 AM · Restricted Project, Restricted Project
gribozavr accepted D59466: [clang-tidy] openmp-exception-escape - a new check.
Mar 22 2019, 6:47 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr accepted D59528: [clang-tidy] Expand modular headers for PPCallbacks.
Mar 22 2019, 6:11 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr added inline comments to D59407: [clangd] Add RelationSlab.
Mar 22 2019, 6:07 AM · Restricted Project
gribozavr added inline comments to D59466: [clang-tidy] openmp-exception-escape - a new check.
Mar 22 2019, 5:49 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr added inline comments to D59650: [NFC] ExceptionEscapeCheck: small refactoring .
Mar 22 2019, 5:37 AM · Restricted Project, Restricted Project

Mar 21 2019

gribozavr accepted D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling.
Mar 21 2019, 7:13 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr accepted D59453: [ASTMatchers][OpenMP] Add base ompExecutableDirective() matcher..
Mar 21 2019, 7:12 AM · Restricted Project, Restricted Project
gribozavr accepted D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers.
Mar 21 2019, 6:57 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr added inline comments to D59528: [clang-tidy] Expand modular headers for PPCallbacks.
Mar 21 2019, 6:43 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr added inline comments to D59528: [clang-tidy] Expand modular headers for PPCallbacks.
Mar 21 2019, 6:20 AM · Restricted Project, Restricted Project, Restricted Project

Mar 20 2019

gribozavr accepted D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563).
Mar 20 2019, 8:15 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr added inline comments to D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563).
Mar 20 2019, 5:19 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr added inline comments to D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563).
Mar 20 2019, 2:39 AM · Restricted Project, Restricted Project, Restricted Project

Mar 18 2019

gribozavr added a comment to D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563).

As far as I'm concerned, I don't have any major revision requests. I haven't reviewed the unit tests (I'm planning to), but for non-test code, I don't have any further comments.

Mar 18 2019, 8:19 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr added inline comments to D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling.
Mar 18 2019, 4:16 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr added inline comments to D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563).
Mar 18 2019, 4:12 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr added inline comments to D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling.
Mar 18 2019, 4:03 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr added inline comments to D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers.
Mar 18 2019, 3:33 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr added inline comments to D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling.
Mar 18 2019, 3:32 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr added a comment to D59130: [llvm][Support] Provide interface to set thread priorities.

I would port it to NetBSD... but I don't see use-case for it. I think kernel should be allowed to schedule priorities on its own without manual help.

Mar 18 2019, 3:24 AM · Restricted Project
gribozavr accepted D59130: [llvm][Support] Provide interface to set thread priorities.
In D59130#1426403, @jfb wrote:
In D59130#1424778, @jfb wrote:

That doesn't answer my question though: if someone sets priority and on the platform the test witness acceptable forward progress, will it happen that another platform provide no forward progress for the same work. For example, some implementations don't let a background thread perform any I/O. In such a case, a mere logging statement would halt the background thread's progress.

Fair enough. But is this a theoretical concern for some abstract platform that might implement this function in future, or is it a concrete concern for one of the implementations in this review?

You're adding a "portable" abstraction to different platform APIs. The onus here is on you to make sure that the abstraction is portable

Mar 18 2019, 3:17 AM · Restricted Project
gribozavr added inline comments to D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling.
Mar 18 2019, 3:08 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr accepted D57571: [clang-tidy] A new OpenMP module.
Mar 18 2019, 2:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
gribozavr accepted D59453: [ASTMatchers][OpenMP] Add base ompExecutableDirective() matcher..
Mar 18 2019, 2:54 AM · Restricted Project, Restricted Project
gribozavr accepted D59407: [clangd] Add RelationSlab.
Mar 18 2019, 1:54 AM · Restricted Project

Mar 15 2019

gribozavr added inline comments to D59407: [clangd] Add RelationSlab.
Mar 15 2019, 6:35 AM · Restricted Project
gribozavr requested changes to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.
Mar 15 2019, 6:25 AM · Restricted Project

Mar 13 2019

gribozavr added inline comments to D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓.
Mar 13 2019, 3:56 PM · Restricted Project
gribozavr accepted D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓.
Mar 13 2019, 3:56 PM · Restricted Project

Mar 12 2019

gribozavr added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Sorry for the delay. I will finish reviewing tomorrow.

Mar 12 2019, 2:41 PM · Restricted Project
gribozavr added inline comments to D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563).
Mar 12 2019, 1:54 PM · Restricted Project, Restricted Project, Restricted Project
gribozavr added a comment to D58749: [index-while-building] IndexRecordHasher.

I basically didn't really like the idea of testing against hard-coded hash values in unittests as I consider it to be an implementation detail.

Mar 12 2019, 1:44 PM · Restricted Project
gribozavr added inline comments to D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563).
Mar 12 2019, 11:11 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr added a comment to D58749: [index-while-building] IndexRecordHasher.

I left some comments, but it is difficult for me to review without understanding what the requirements for this hasher are, why some information is hashed in, and some is left out, could you clarify? See detailed comments.

Mar 12 2019, 8:48 AM · Restricted Project
gribozavr added a comment to D59130: [llvm][Support] Provide interface to set thread priorities.
In D59130#1424778, @jfb wrote:

That doesn't answer my question though: if someone sets priority and on the platform the test witness acceptable forward progress, will it happen that another platform provide no forward progress for the same work. For example, some implementations don't let a background thread perform any I/O. In such a case, a mere logging statement would halt the background thread's progress.

Mar 12 2019, 7:21 AM · Restricted Project
gribozavr added inline comments to D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563).
Mar 12 2019, 2:23 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr added inline comments to D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563).
Mar 12 2019, 2:22 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2019

gribozavr accepted D59210: clang-format: distinguish ObjC call subexpressions after r355434.
Mar 11 2019, 8:36 AM · Restricted Project, Restricted Project

Mar 8 2019

gribozavr accepted D59132: [clangd] Add TOC section to clangd doc..
Mar 8 2019, 6:24 AM · Restricted Project, Restricted Project
gribozavr accepted D58815: [clangd] Make sure constructors do not reference class.
Mar 8 2019, 1:52 AM · Restricted Project
gribozavr accepted D59128: [clangd] Redirect clangd page..

Fancy!

Mar 8 2019, 1:52 AM · Restricted Project
gribozavr accepted D59083: [clangd] Store explicit template specializations in index for code navigation purposes.
Mar 8 2019, 12:53 AM · Restricted Project, Restricted Project

Mar 7 2019

gribozavr added inline comments to D59086: [clangd] Adjust compile commands to be applicable for tooling.
Mar 7 2019, 9:48 AM · Restricted Project, Restricted Project
gribozavr accepted D59086: [clangd] Adjust compile commands to be applicable for tooling.
Mar 7 2019, 7:30 AM · Restricted Project, Restricted Project
gribozavr accepted D58814: [clang][Index] Mark references from Constructors and Destructors to class as NameReference .

Do we also need to change anything for constructor calls? If not, please add a test for that.

Mar 7 2019, 5:15 AM · Restricted Project
gribozavr accepted D59083: [clangd] Store explicit template specializations in index for code navigation purposes.
Mar 7 2019, 3:14 AM · Restricted Project, Restricted Project

Mar 6 2019

gribozavr added a comment to D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes.

My understanding is that the storage space taken up for Refs is currently 8 bytes per Ref (4 each for the start and end positions), plus filename strings which are deduplicated across all refs. If we add a SymbolID, that adds an additional 8 bytes to each Ref. Given that Refs are numerous, and most of them won't use the SymbolID, that seems wasteful.

Mar 6 2019, 2:49 AM · Restricted Project

Mar 5 2019

gribozavr accepted D58979: [clang][OpenMP] Revert "OMPFlushClause is synthetic, no such clause exists".

Hmm, do we really need the matches for the AST node that is not described/defined by the standard? If this is really so, I'm ok with this.

Mar 5 2019, 10:03 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr committed rG8a3b7d390c81: [ASTMatchers] Improved formatting in a documentation comment (authored by gribozavr).
[ASTMatchers] Improved formatting in a documentation comment
Mar 5 2019, 4:38 AM
gribozavr committed rL355395: [ASTMatchers] Improved formatting in a documentation comment.
[ASTMatchers] Improved formatting in a documentation comment
Mar 5 2019, 4:37 AM
gribozavr committed rC355395: [ASTMatchers] Improved formatting in a documentation comment.
[ASTMatchers] Improved formatting in a documentation comment
Mar 5 2019, 4:37 AM
gribozavr added inline comments to D39050: Add index-while-building support to Clang.
Mar 5 2019, 12:55 AM

Mar 4 2019

gribozavr added a comment to D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling.

The test coverage i have will be in the clang-tidy check.

Mar 4 2019, 3:25 AM · Restricted Project, Restricted Project, Restricted Project

Mar 1 2019

gribozavr added a comment to D58814: [clang][Index] Mark references from Constructors and Destructors to class as NameReference .

These references were added to support using the index data for symbol rename.

Mar 1 2019, 2:18 PM · Restricted Project
gribozavr accepted D58815: [clangd] Make sure constructors do not reference class.
Mar 1 2019, 3:17 AM · Restricted Project
gribozavr accepted D58814: [clang][Index] Mark references from Constructors and Destructors to class as NameReference .

Please also add a test for find references on a constructor.

Mar 1 2019, 2:28 AM · Restricted Project

Feb 28 2019

gribozavr committed rG2098b86b9658: Added missing license headers (authored by gribozavr).
Added missing license headers
Feb 28 2019, 6:02 AM
gribozavr committed rL355092: Added missing license headers.
Added missing license headers
Feb 28 2019, 6:00 AM
gribozavr committed rCTE355092: Added missing license headers.
Added missing license headers
Feb 28 2019, 6:00 AM
gribozavr closed D58781: Added missing license headers.
Feb 28 2019, 6:00 AM · Restricted Project
gribozavr committed rG7344188b72b7: Use ArrayRef::copy, instead of copying data manually (authored by gribozavr).
Use ArrayRef::copy, instead of copying data manually
Feb 28 2019, 6:00 AM
gribozavr committed rL355091: Use ArrayRef::copy, instead of copying data manually.
Use ArrayRef::copy, instead of copying data manually
Feb 28 2019, 5:59 AM
gribozavr committed rCTE355091: Use ArrayRef::copy, instead of copying data manually.
Use ArrayRef::copy, instead of copying data manually
Feb 28 2019, 5:59 AM
gribozavr closed D58782: Use ArrayRef::copy, instead of copying data manually.
Feb 28 2019, 5:59 AM · Restricted Project
gribozavr created D58782: Use ArrayRef::copy, instead of copying data manually.
Feb 28 2019, 5:50 AM · Restricted Project
gribozavr committed rGcb83ea627483: Moved Ref into its own header and implementation file (authored by gribozavr).
Moved Ref into its own header and implementation file
Feb 28 2019, 5:49 AM
gribozavr committed rL355090: Moved Ref into its own header and implementation file.
Moved Ref into its own header and implementation file
Feb 28 2019, 5:49 AM