Page MenuHomePhabricator
People gribozavr

gribozavr (Dmitri Gribenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 18 2012, 9:18 AM (392 w, 4 d)

Recent Activity
View All

Fri, Jan 17

gribozavr committed rG0406b4fab946: Renamed traverseDecl to TraverseDecl in a test (authored by gribozavr).
Renamed traverseDecl to TraverseDecl in a test
Fri, Jan 17, 8:15 AM
gribozavr committed rG10b4aece5289: Revert "Avoid creating an immutable map in the Automaton class." (authored by gribozavr).
Revert "Avoid creating an immutable map in the Automaton class."
Fri, Jan 17, 1:24 AM
gribozavr added a reverting change for rG051d330314cb: Avoid creating an immutable map in the Automaton class.: rG10b4aece5289: Revert "Avoid creating an immutable map in the Automaton class.".
Fri, Jan 17, 1:24 AM

Thu, Jan 16

gribozavr committed rGcbaa32650a0b: Removed an unused include from TypeLocVisitor.h (authored by gribozavr).
Removed an unused include from TypeLocVisitor.h
Thu, Jan 16, 7:02 AM

Tue, Jan 14

gribozavr committed rG2948ec5ca98f: Removed PointerUnion3 and PointerUnion4 aliases in favor of the variadic… (authored by gribozavr).
Removed PointerUnion3 and PointerUnion4 aliases in favor of the variadic…
Tue, Jan 14, 10:04 AM

Thu, Jan 2

gribozavr committed rG0eea9ba730b5: Make the llvm-ranlib/help-message.test test pass in unusual configurations (authored by gribozavr).
Make the llvm-ranlib/help-message.test test pass in unusual configurations
Thu, Jan 2, 6:29 AM

Mon, Dec 30

gribozavr committed rG32cc14100e80: Revert "[MIPS GlobalISel] Select bitreverse" (authored by gribozavr).
Revert "[MIPS GlobalISel] Select bitreverse"
Mon, Dec 30, 5:32 AM
gribozavr added a reverting change for rGdbc136e0fe7e: [MIPS GlobalISel] Select bitreverse: rG32cc14100e80: Revert "[MIPS GlobalISel] Select bitreverse".
Mon, Dec 30, 5:32 AM

Dec 20 2019

gribozavr committed rG73f423e739bc: Parenthesized a logical expression. (authored by gribozavr).
Parenthesized a logical expression.
Dec 20 2019, 5:48 AM
gribozavr committed rG9caf12e8495c: Use isa instead of dyn_cast (authored by gribozavr).
Use isa instead of dyn_cast
Dec 20 2019, 5:48 AM

Dec 19 2019

gribozavr committed rG0109efe7513d: Revert "Support powerpc when builing without init_array." (authored by gribozavr).
Revert "Support powerpc when builing without init_array."
Dec 19 2019, 2:35 AM
gribozavr added a reverting change for rG5789e83dedb9: Support powerpc when builing without init_array.: rG0109efe7513d: Revert "Support powerpc when builing without init_array.".
Dec 19 2019, 2:35 AM

Dec 16 2019

gribozavr committed rG079ef783dd55: Revert "[clangd] Implement "textDocument/documentLink" protocol support" (authored by gribozavr).
Revert "[clangd] Implement "textDocument/documentLink" protocol support"
Dec 16 2019, 6:33 AM
gribozavr added a reverting change for rGd6417f5584aa: [clangd] Implement "textDocument/documentLink" protocol support: rG079ef783dd55: Revert "[clangd] Implement "textDocument/documentLink" protocol support".
Dec 16 2019, 6:33 AM
gribozavr committed rG51707196a045: Fix title underline in LangRef (authored by gribozavr).
Fix title underline in LangRef
Dec 16 2019, 12:14 AM

Dec 13 2019

gribozavr added a reverting change for rG0eb099273918: [ARM][MVE][Intrinsics] remove extraneous intrinsics.: rG34536db7bbe0: Revert "[ARM][MVE][Intrinsics] remove extraneous intrinsics.".
Dec 13 2019, 8:24 AM
gribozavr committed rG34536db7bbe0: Revert "[ARM][MVE][Intrinsics] remove extraneous intrinsics." (authored by gribozavr).
Revert "[ARM][MVE][Intrinsics] remove extraneous intrinsics."
Dec 13 2019, 8:24 AM

Nov 30 2019

gribozavr committed rGb094258661e0: Updated the OCaml/bitwriter.ml test for OCaml 4.06+ (authored by gribozavr).
Updated the OCaml/bitwriter.ml test for OCaml 4.06+
Nov 30 2019, 4:43 AM

Nov 19 2019

gribozavr updated the diff for D69354: Make coding standards document more inclusive.

Addressed review comments.

Nov 19 2019, 10:24 AM · Restricted Project

Oct 24 2019

gribozavr added a comment to D69171: [clang-fuzzer] Add new fuzzer target for Objective-C.

Looks reasonable to me. The duplication is unfortunate, but it is reasonable while we have two binaries.

Oct 24 2019, 1:50 PM · Restricted Project
gribozavr added inline comments to D69354: Make coding standards document more inclusive.
Oct 24 2019, 12:36 PM · Restricted Project
gribozavr updated the summary of D69354: Make coding standards document more inclusive.
Oct 24 2019, 12:36 PM · Restricted Project
gribozavr updated the diff for D69354: Make coding standards document more inclusive.

Addressed review comments

Oct 24 2019, 12:36 PM · Restricted Project

Oct 23 2019

gribozavr created D69354: Make coding standards document more inclusive.
Oct 23 2019, 12:52 PM · Restricted Project

Oct 18 2019

gribozavr added a comment to D69184: [libTooling] Introduce general combinator for fixed-value `MatchConsumer`s..

What are the use cases for non-text values?

Oct 18 2019, 3:18 PM · Restricted Project
gribozavr added a comment to D68885: Add a Ranges field to Diagnostic struct.

Please upload patches with context in future (arc diff will do that for you).

Oct 18 2019, 6:37 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D56924: Special case ObjCPropertyDecl for printing.
Oct 18 2019, 6:06 AM · Restricted Project

Oct 14 2019

gribozavr committed rL374768: Revert "Add a pass to lower is.constant and objectsize intrinsics".
Revert "Add a pass to lower is.constant and objectsize intrinsics"
Oct 14 2019, 5:29 AM
gribozavr committed rG1a21f98ac3c5: Revert "Add a pass to lower is.constant and objectsize intrinsics" (authored by gribozavr).
Revert "Add a pass to lower is.constant and objectsize intrinsics"
Oct 14 2019, 5:29 AM
gribozavr added a comment to D65280: Add a pass to lower is.constant and objectsize intrinsics.

Sorry, this change broke the build (http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/19218) and I reverted it in r374768.

Oct 14 2019, 5:29 AM · Restricted Project

Oct 11 2019

gribozavr added a comment to D68876: [libTooling] Put all Transformer declarations in a single namespace..

What do you think of my just putting all of the Transformer types + combis in the single clang::transformer namespace?

Oct 11 2019, 11:55 AM · Restricted Project
gribozavr accepted D68876: [libTooling] Put all Transformer declarations in a single namespace..

WDYT about clang::transformer? I don't see much point in the intermediate namespace. However, LGTM either way.

Oct 11 2019, 9:47 AM · Restricted Project
gribozavr committed rGaa87b081cdff: Updated add_new_check.py to create checker tests in the new directory (authored by gribozavr).
Updated add_new_check.py to create checker tests in the new directory
Oct 11 2019, 6:50 AM
gribozavr committed rL374551: Updated add_new_check.py to create checker tests in the new directory.
Updated add_new_check.py to create checker tests in the new directory
Oct 11 2019, 6:49 AM
gribozavr added a comment to D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank.

I guess here's the high-level question: should all removals that remove all non-blank text from a line also delete the line?

Oct 11 2019, 6:40 AM · Restricted Project, Restricted Project
gribozavr committed rGd103e2d267db: [ClangTidy] Separate tests for infrastructure and checkers, fixup (authored by gribozavr).
[ClangTidy] Separate tests for infrastructure and checkers, fixup
Oct 11 2019, 6:22 AM
gribozavr committed rL374549: [ClangTidy] Separate tests for infrastructure and checkers, fixup.
[ClangTidy] Separate tests for infrastructure and checkers, fixup
Oct 11 2019, 6:14 AM
gribozavr committed rL374540: [ClangTidy] Separate tests for infrastructure and checkers.
[ClangTidy] Separate tests for infrastructure and checkers
Oct 11 2019, 5:18 AM
gribozavr committed rG885c559369fe: [ClangTidy] Separate tests for infrastructure and checkers (authored by gribozavr).
[ClangTidy] Separate tests for infrastructure and checkers
Oct 11 2019, 5:18 AM
gribozavr closed D68807: [ClangTidy] Separate tests for infrastructure and checkers.
Oct 11 2019, 5:14 AM · Restricted Project
gribozavr added inline comments to D68074: [clang-tidy] Add readability-make-member-function-const.
Oct 11 2019, 2:44 AM · Restricted Project, Restricted Project
gribozavr accepted D68825: [libTooling] Change Stencil equality to use `toString()`.
Oct 11 2019, 1:36 AM · Restricted Project
gribozavr accepted D68795: [libTooling] Move `RewriteRule` abstraction into its own header and impl..
Oct 11 2019, 1:27 AM · Restricted Project

Oct 10 2019

gribozavr added a comment to D68807: [ClangTidy] Separate tests for infrastructure and checkers.

It would look weird if we have a ton of tests for checkers in a directory, and then a subdirectory for infra tests.

Oct 10 2019, 3:21 PM · Restricted Project
gribozavr added a comment to D68807: [ClangTidy] Separate tests for infrastructure and checkers.

Why does the number of moves matter? Git preserves history across moves.

Oct 10 2019, 2:52 PM · Restricted Project
gribozavr added reviewers for D68807: [ClangTidy] Separate tests for infrastructure and checkers: ilya-biryukov, alexfh.
Oct 10 2019, 8:59 AM · Restricted Project
Herald added a reviewer for D68807: [ClangTidy] Separate tests for infrastructure and checkers: jdoerfert.
Oct 10 2019, 8:59 AM · Restricted Project
gribozavr added inline comments to D68795: [libTooling] Move `RewriteRule` abstraction into its own header and impl..
Oct 10 2019, 8:40 AM · Restricted Project
gribozavr committed rGd3aed7fc7986: Revert "[FileCheck] Implement --ignore-case option." (authored by gribozavr).
Revert "[FileCheck] Implement --ignore-case option."
Oct 10 2019, 7:26 AM
gribozavr committed rGa89e5a41ec7c: Revert "[Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj). (authored by gribozavr).
Revert "[Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj).
Oct 10 2019, 7:26 AM
gribozavr committed rL374359: Revert "[FileCheck] Implement --ignore-case option.".
Revert "[FileCheck] Implement --ignore-case option."
Oct 10 2019, 7:25 AM
gribozavr committed rL374358: Revert "[Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj)..
Revert "[Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj).
Oct 10 2019, 7:25 AM
gribozavr added a comment to D68693: [Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj)..

I reverted this change in r374358 because it depends on https://reviews.llvm.org/D68146, which broke tests.

Oct 10 2019, 7:25 AM · Restricted Project
gribozavr added a comment to D68146: [FileCheck] Implement --ignore-case option..

This change broke tests: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/19066

Oct 10 2019, 7:25 AM · Restricted Project
gribozavr committed rG43fcbcb4e8e5: Revert "Fix OCaml/core.ml fneg check" (authored by gribozavr).
Revert "Fix OCaml/core.ml fneg check"
Oct 10 2019, 7:16 AM
gribozavr committed rGeaf6dd482b0a: Revert "[IRBuilder] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator" (authored by gribozavr).
Revert "[IRBuilder] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator"
Oct 10 2019, 7:16 AM
gribozavr committed rL374357: Revert "Fix OCaml/core.ml fneg check".
Revert "Fix OCaml/core.ml fneg check"
Oct 10 2019, 7:16 AM
gribozavr committed rL374354: Revert "[IRBuilder] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator".
Revert "[IRBuilder] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator"
Oct 10 2019, 7:16 AM
gribozavr added a comment to D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator.

Sorry, but this commit broke OCaml tests: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/19014

Oct 10 2019, 7:16 AM · Restricted Project, Restricted Project
gribozavr committed rL374319: Add github commit access for gribozavr.
Add github commit access for gribozavr
Oct 10 2019, 5:03 AM

Oct 9 2019

gribozavr requested changes to D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank.

+1 to what MyDeveloperDay said. The infrastructure can't know whether the newlines are intentional or not. Checks that edit the source code should be improved to delete newlines where they become unnecessary. I don't think we can accept the patch that changes how we apply edits.

Oct 9 2019, 1:42 AM · Restricted Project, Restricted Project

Oct 8 2019

gribozavr added a comment to D68640: Try to get readability-deleted-default.cpp to pass on Windows..

Thanks!

Oct 8 2019, 1:47 PM · Restricted Project
gribozavr added a comment to D68640: Try to get readability-deleted-default.cpp to pass on Windows..

There's no shortage of possible implicit TODOs

Oct 8 2019, 7:38 AM · Restricted Project
gribozavr added a comment to D68074: [clang-tidy] Add readability-make-member-function-const.

I'm holding off on reviewing the code until we figure out what the rules are.

Oct 8 2019, 7:29 AM · Restricted Project, Restricted Project
gribozavr added a comment to D68640: Try to get readability-deleted-default.cpp to pass on Windows..

It looks to me that a better fix is to fix the checker to not emit this warning in MS compatibility mode.

Oct 8 2019, 7:19 AM · Restricted Project
gribozavr accepted D68637: [libTooling] Move Transformer files to their own directory/library..

Update header guards?

Oct 8 2019, 6:42 AM · Restricted Project

Oct 7 2019

gribozavr accepted D68574: [libTooling] Add `toString` method to the Stencil class.
Oct 7 2019, 8:29 AM · Restricted Project, Restricted Project

Oct 4 2019

gribozavr committed rGb0e997bbf4e8: Revert "[NFC] [FileCheck] Fix init of stack objects in unit tests" (authored by gribozavr).
Revert "[NFC] [FileCheck] Fix init of stack objects in unit tests"
Oct 4 2019, 2:43 AM
gribozavr committed rL373722: Revert "[NFC] [FileCheck] Fix init of stack objects in unit tests".
Revert "[NFC] [FileCheck] Fix init of stack objects in unit tests"
Oct 4 2019, 2:42 AM
gribozavr added a comment to D68425: [NFC] [FileCheck] Fix init of objects in unit tests.

Sorry, but this change broke the build: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/18721

Oct 4 2019, 2:42 AM · Restricted Project

Oct 2 2019

gribozavr added inline comments to D68315: [libTooling] Add various Stencil combinators for expressions..
Oct 2 2019, 3:26 PM · Restricted Project, Restricted Project
gribozavr added inline comments to D68315: [libTooling] Add various Stencil combinators for expressions..
Oct 2 2019, 12:32 PM · Restricted Project, Restricted Project
gribozavr accepted D68315: [libTooling] Add various Stencil combinators for expressions..
Oct 2 2019, 8:19 AM · Restricted Project, Restricted Project

Oct 1 2019

gribozavr committed rGf58d01930f6f: Revert "[OCaml] Handle nullptr in Llvm.global_initializer" (authored by gribozavr).
Revert "[OCaml] Handle nullptr in Llvm.global_initializer"
Oct 1 2019, 1:29 AM
gribozavr committed rL373311: Revert "[OCaml] Handle nullptr in Llvm.global_initializer".
Revert "[OCaml] Handle nullptr in Llvm.global_initializer"
Oct 1 2019, 1:27 AM
gribozavr added a comment to D65195: [OCaml] Handle nullptr in Llvm.global_initializer.

This change broke tests: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/18485. I reverted it in r373311.

Oct 1 2019, 1:27 AM · Restricted Project
gribozavr committed rG827a7fab78dc: Revert "GlobalISel: Handle llvm.read_register" (authored by gribozavr).
Revert "GlobalISel: Handle llvm.read_register"
Oct 1 2019, 1:25 AM
gribozavr committed rL373310: Revert "GlobalISel: Handle llvm.read_register".
Revert "GlobalISel: Handle llvm.read_register"
Oct 1 2019, 1:22 AM
gribozavr committed rGd1337ec22d48: [clang-tidy] Fix module registry name and description for Darwin clang-tidy… (authored by gribozavr).
[clang-tidy] Fix module registry name and description for Darwin clang-tidy…
Oct 1 2019, 12:16 AM
gribozavr committed rL373304: [clang-tidy] Fix module registry name and description for Darwin clang-tidy….
[clang-tidy] Fix module registry name and description for Darwin clang-tidy…
Oct 1 2019, 12:16 AM
gribozavr closed D68251: [clang-tidy] Fix module registry name and description for Darwin clang-tidy module..
Oct 1 2019, 12:15 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr accepted D68251: [clang-tidy] Fix module registry name and description for Darwin clang-tidy module..
Oct 1 2019, 12:07 AM · Restricted Project, Restricted Project, Restricted Project

Sep 27 2019

gribozavr accepted D68132: clang-tidy: Don't repeat list of all checks in three places..
Sep 27 2019, 5:50 AM · Restricted Project
gribozavr committed rG6328f948adfa: Fixed indentation in a ClangTidy test (authored by gribozavr).
Fixed indentation in a ClangTidy test
Sep 27 2019, 4:00 AM
gribozavr committed rL373068: Fixed indentation in a ClangTidy test.
Fixed indentation in a ClangTidy test
Sep 27 2019, 4:00 AM
gribozavr committed rG69f9f20fc529: Moved -fblocks from an individual test to check_clang_tidy.py (authored by gribozavr).
Moved -fblocks from an individual test to check_clang_tidy.py
Sep 27 2019, 4:00 AM
gribozavr committed rL373066: Moved -fblocks from an individual test to check_clang_tidy.py.
Moved -fblocks from an individual test to check_clang_tidy.py
Sep 27 2019, 4:00 AM
gribozavr committed rG405c3a6be171: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non… (authored by gribozavr).
[clang-tidy] New check to warn when storing dispatch_once_t in non-static, non…
Sep 27 2019, 3:51 AM
gribozavr committed rL373065: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non….
[clang-tidy] New check to warn when storing dispatch_once_t in non-static, non…
Sep 27 2019, 3:51 AM
gribozavr closed D68109: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage..
Sep 27 2019, 3:50 AM · Restricted Project, Restricted Project, Restricted Project

Sep 26 2019

gribozavr committed rGda963abd5308: Revert "gn build: (manually) merge r373028" (authored by gribozavr).
Revert "gn build: (manually) merge r373028"
Sep 26 2019, 4:31 PM
gribozavr committed rL373033: Revert "gn build: (manually) merge r373028".
Revert "gn build: (manually) merge r373028"
Sep 26 2019, 4:31 PM
gribozavr committed rG847f4d3f6d7e: Revert "[clang-tidy] New check to warn when storing dispatch_once_t in non… (authored by gribozavr).
Revert "[clang-tidy] New check to warn when storing dispatch_once_t in non…
Sep 26 2019, 4:31 PM
gribozavr committed rL373032: Revert "[clang-tidy] New check to warn when storing dispatch_once_t in non….
Revert "[clang-tidy] New check to warn when storing dispatch_once_t in non…
Sep 26 2019, 4:31 PM
gribozavr added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

Sorry, I reverted it in r373032 because the test fails on Linux: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/18323 . Could you please take a look? Thanks!

Sep 26 2019, 4:30 PM · Restricted Project, Restricted Project, Restricted Project
gribozavr added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

Sorry, could you rebase the patch to apply cleanly to master? Seems like someone else edited ReleaseNotes.rst in the meanwhile.

Sep 26 2019, 12:50 PM · Restricted Project, Restricted Project, Restricted Project
gribozavr committed rGbb7a9dcd4282: Return results by value from ClangTidyCheckFactories::createChecks (authored by gribozavr).
Return results by value from ClangTidyCheckFactories::createChecks
Sep 26 2019, 7:01 AM
gribozavr committed rL372979: Return results by value from ClangTidyCheckFactories::createChecks.
Return results by value from ClangTidyCheckFactories::createChecks
Sep 26 2019, 6:53 AM
gribozavr committed rG5338ffcfa1d2: Use std::unique_ptr in ClangTidyCheckFactories (authored by gribozavr).
Use std::unique_ptr in ClangTidyCheckFactories
Sep 26 2019, 6:47 AM
gribozavr committed rL372978: Use std::unique_ptr in ClangTidyCheckFactories.
Use std::unique_ptr in ClangTidyCheckFactories
Sep 26 2019, 6:47 AM