Page MenuHomePhabricator

gribozavr (Dmitri Gribenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 18 2012, 9:18 AM (362 w, 12 h)

Recent Activity

Today

gribozavr added inline comments to D63623: [clang-tidy] new check: bugprone-posix-return.
Wed, Jun 26, 11:57 AM · Restricted Project
gribozavr accepted D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..
Wed, Jun 26, 2:56 AM · Restricted Project, Restricted Project
gribozavr accepted D63784: [clang-tidy] Fix ClangTidyTest to initialize context before checks..

Good catch!

Wed, Jun 26, 2:54 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D63623: [clang-tidy] new check: bugprone-posix-return.
Wed, Jun 26, 2:48 AM · Restricted Project

Yesterday

gribozavr accepted D63623: [clang-tidy] new check: bugprone-posix-return.
Tue, Jun 25, 6:49 AM · Restricted Project
gribozavr accepted D63763: [clang-tidy] Update documentation for Qt Creator integration..

LGTM, assuming you know what's new in QtCreator.

Tue, Jun 25, 6:37 AM · Restricted Project
gribozavr accepted D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..
Tue, Jun 25, 6:37 AM · Restricted Project, Restricted Project

Wed, Jun 19

gribozavr added a comment to D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value.

Thanks! Please add tests in ./unittests/Tooling/ReplacementsYamlTest.cpp.

Wed, Jun 19, 3:16 AM

Thu, Jun 13

gribozavr added inline comments to D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..
Thu, Jun 13, 1:38 PM · Restricted Project, Restricted Project
gribozavr accepted D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator..
Thu, Jun 13, 10:53 AM · Restricted Project, Restricted Project
gribozavr accepted D63287: [clang-tidy] Make ClangTidyCheck::OptionsView public..
Thu, Jun 13, 10:34 AM · Restricted Project, Restricted Project
gribozavr committed rG558369b54956: [clang-tidy] Made abseil-faster-strsplit-delimiter tests pass on C++17 (authored by gribozavr).
[clang-tidy] Made abseil-faster-strsplit-delimiter tests pass on C++17
Thu, Jun 13, 8:15 AM
gribozavr committed rL363273: [clang-tidy] Made abseil-faster-strsplit-delimiter tests pass on C++17.
[clang-tidy] Made abseil-faster-strsplit-delimiter tests pass on C++17
Thu, Jun 13, 8:15 AM
gribozavr closed D63253: [clang-tidy] Made abseil-faster-strsplit-delimiter tests pass on C++17.
Thu, Jun 13, 8:14 AM · Restricted Project, Restricted Project
gribozavr accepted D63253: [clang-tidy] Made abseil-faster-strsplit-delimiter tests pass on C++17.
Thu, Jun 13, 8:11 AM · Restricted Project, Restricted Project
gribozavr committed rG0030306555de: [clang-tidy] Fixed abseil-time-subtraction to work on C++17 (authored by gribozavr).
[clang-tidy] Fixed abseil-time-subtraction to work on C++17
Thu, Jun 13, 8:09 AM
gribozavr committed rL363272: [clang-tidy] Fixed abseil-time-subtraction to work on C++17.
[clang-tidy] Fixed abseil-time-subtraction to work on C++17
Thu, Jun 13, 8:08 AM
gribozavr closed D63261: [clang-tidy] Fixed abseil-time-subtraction to work on C++17.
Thu, Jun 13, 8:07 AM · Restricted Project, Restricted Project
gribozavr committed rG93f96b2be936: [clang-tidy] Made abseil-upgrade-duration-conversions tests pass on c++17 (authored by gribozavr).
[clang-tidy] Made abseil-upgrade-duration-conversions tests pass on c++17
Thu, Jun 13, 7:26 AM
gribozavr committed rL363270: [clang-tidy] Made abseil-upgrade-duration-conversions tests pass on c++17.
[clang-tidy] Made abseil-upgrade-duration-conversions tests pass on c++17
Thu, Jun 13, 7:24 AM
gribozavr closed D63262: [clang-tidy] Made abseil-upgrade-duration-conversions tests pass on c++17.
Thu, Jun 13, 7:24 AM · Restricted Project, Restricted Project
gribozavr accepted D63262: [clang-tidy] Made abseil-upgrade-duration-conversions tests pass on c++17.
Thu, Jun 13, 7:22 AM · Restricted Project, Restricted Project
gribozavr committed rGab240c5eee4c: [clang-tidy] Fixed abseil-duration-unnecessary-conversion tests for c++17 (authored by gribozavr).
[clang-tidy] Fixed abseil-duration-unnecessary-conversion tests for c++17
Thu, Jun 13, 6:50 AM
gribozavr committed rL363263: [clang-tidy] Fixed abseil-duration-unnecessary-conversion tests for c++17.
[clang-tidy] Fixed abseil-duration-unnecessary-conversion tests for c++17
Thu, Jun 13, 6:49 AM
gribozavr closed D63263: [clang-tidy] Fixed abseil-duration-unnecessary-conversion tests for c++17.
Thu, Jun 13, 6:49 AM · Restricted Project, Restricted Project
gribozavr committed rG31d68804fd46: Added AST matcher for ignoring elidable constructors (authored by gribozavr).
Added AST matcher for ignoring elidable constructors
Thu, Jun 13, 6:48 AM
gribozavr committed rL363262: Added AST matcher for ignoring elidable constructors.
Added AST matcher for ignoring elidable constructors
Thu, Jun 13, 6:48 AM
gribozavr closed D63149: Added AST matcher for ignoring elidable constructors.
Thu, Jun 13, 6:48 AM · Restricted Project, Restricted Project
gribozavr accepted D63263: [clang-tidy] Fixed abseil-duration-unnecessary-conversion tests for c++17.
Thu, Jun 13, 6:42 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D63261: [clang-tidy] Fixed abseil-time-subtraction to work on C++17.
Thu, Jun 13, 6:41 AM · Restricted Project, Restricted Project
gribozavr accepted D63149: Added AST matcher for ignoring elidable constructors.
Thu, Jun 13, 6:33 AM · Restricted Project, Restricted Project

Wed, Jun 12

gribozavr added inline comments to D63149: Added AST matcher for ignoring elidable constructors.
Wed, Jun 12, 7:49 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D63149: Added AST matcher for ignoring elidable constructors.
Wed, Jun 12, 7:00 AM · Restricted Project, Restricted Project
gribozavr committed rGcf7d76835157: Fixed a crash in misc-redundant-expression ClangTidy checker (authored by gribozavr).
Fixed a crash in misc-redundant-expression ClangTidy checker
Wed, Jun 12, 1:38 AM
gribozavr committed rL363133: Fixed a crash in misc-redundant-expression ClangTidy checker.
Fixed a crash in misc-redundant-expression ClangTidy checker
Wed, Jun 12, 1:38 AM
gribozavr closed D63188: Fixed a crash in misc-redundant-expression ClangTidy checker.
Wed, Jun 12, 1:38 AM · Restricted Project, Restricted Project
gribozavr created D63188: Fixed a crash in misc-redundant-expression ClangTidy checker.
Wed, Jun 12, 1:33 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D63149: Added AST matcher for ignoring elidable constructors.
Wed, Jun 12, 1:28 AM · Restricted Project, Restricted Project

Tue, Jun 11

gribozavr added inline comments to D63149: Added AST matcher for ignoring elidable constructors.
Tue, Jun 11, 10:41 AM · Restricted Project, Restricted Project
gribozavr accepted D63129: [clang-tidy] Fix invalid read on destruction.

This fix works. The alternative would have been to wrap these variables into llvm::ManagedStatic, just like the problematic TrueMatcherInstance in ASTMatchersInternal.cpp.

Tue, Jun 11, 6:29 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D63127: [clang-tidy] Fixed checker for abseil to work in C++17 mode.
Tue, Jun 11, 5:01 AM · Restricted Project
gribozavr committed rGbe20daa8ebcc: Fixed google-readability-casting test to work in c++17 (authored by gribozavr).
Fixed google-readability-casting test to work in c++17
Tue, Jun 11, 3:57 AM
gribozavr committed rL363047: Fixed google-readability-casting test to work in c++17.
Fixed google-readability-casting test to work in c++17
Tue, Jun 11, 3:57 AM
gribozavr closed D63128: Fixed google-readability-casting test to work in c++17.
Tue, Jun 11, 3:57 AM · Restricted Project, Restricted Project
gribozavr accepted D63128: Fixed google-readability-casting test to work in c++17.

I'll commit this change.

Tue, Jun 11, 3:33 AM · Restricted Project, Restricted Project

Fri, Jun 7

gribozavr committed rG5b3c9880e23b: Work around a circular dependency between IR and MC introduced in r362735 (authored by gribozavr).
Work around a circular dependency between IR and MC introduced in r362735
Fri, Jun 7, 2:28 AM
gribozavr committed rL362782: Work around a circular dependency between IR and MC introduced in r362735.
Work around a circular dependency between IR and MC introduced in r362735
Fri, Jun 7, 2:27 AM
gribozavr added inline comments to D62532: [AIX] Implement function descriptor on SDAG.
Fri, Jun 7, 2:27 AM · Restricted Project
gribozavr added inline comments to D62532: [AIX] Implement function descriptor on SDAG.
Fri, Jun 7, 2:21 AM · Restricted Project

Thu, Jun 6

gribozavr committed rG5438cc6910b0: Remove unused PPC.h includes under llvm/lib/Target/PowerPC. (authored by gribozavr).
Remove unused PPC.h includes under llvm/lib/Target/PowerPC.
Thu, Jun 6, 9:46 AM
gribozavr committed rL362718: Remove unused PPC.h includes under llvm/lib/Target/PowerPC..
Remove unused PPC.h includes under llvm/lib/Target/PowerPC.
Thu, Jun 6, 9:44 AM
gribozavr added a comment to D61486: [Basic] Introduce active dummy DiagnosticBuilder.

Is this patch still needed?

Thu, Jun 6, 5:13 AM · Restricted Project
gribozavr accepted D61487: [clang-tidy] Make the plugin honor NOLINT.
Thu, Jun 6, 5:13 AM · Restricted Project, Restricted Project
gribozavr accepted D62947: [clang-tidy] Fix an assertion failure in misc-redundant-expression..
Thu, Jun 6, 5:00 AM · Restricted Project, Restricted Project
gribozavr committed rG8c2c07258288: Include what you use in LanaiAsmParser.cpp (authored by gribozavr).
Include what you use in LanaiAsmParser.cpp
Thu, Jun 6, 3:36 AM
gribozavr committed rL362696: Include what you use in LanaiAsmParser.cpp.
Include what you use in LanaiAsmParser.cpp
Thu, Jun 6, 3:36 AM

Wed, Jun 5

gribozavr committed rG6fc4c1cc54ac: Include what you use in PPCFrameLowering.h (authored by gribozavr).
Include what you use in PPCFrameLowering.h
Wed, Jun 5, 1:59 AM
gribozavr committed rL362590: Include what you use in PPCFrameLowering.h.
Include what you use in PPCFrameLowering.h
Wed, Jun 5, 1:59 AM
gribozavr accepted D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..
Wed, Jun 5, 12:30 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 4

gribozavr added inline comments to D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..
Tue, Jun 4, 2:58 PM · Restricted Project, Restricted Project, Restricted Project
gribozavr accepted D62845: [clang-tidy] Fix make-unique tests on C++2a..

Looks great, thank you!

Tue, Jun 4, 8:00 AM · Restricted Project, Restricted Project
gribozavr added a comment to D62845: [clang-tidy] Fix make-unique tests on C++2a..

I think we should be looking at the intent of the test rather than its name.

The intent looks like testing how the check works when std::make_unique is available from the standard library (as opposed to some kind of replacement like absl::make_unique). See the patch that introduced it: https://reviews.llvm.org/D43766

So modernize-make-unique-cxx14 is actually "C++14 or later". (Probably it should be renamed.)

yeap, it seems to me that "modernize-make-unique-cxx14" is redundant, "modernize-make-unique" should cover what it tests, I believe. We also have "modernize-make-unique-cxx11" which runs on C++11 mode only, maybe we just repurpose the modernize-make-unique-cxx14, what do you think?

Tue, Jun 4, 6:51 AM · Restricted Project, Restricted Project
gribozavr committed rG454fc7787256: Include what you use in PPCRegisterInfo.cpp (authored by gribozavr).
Include what you use in PPCRegisterInfo.cpp
Tue, Jun 4, 5:54 AM
gribozavr committed rL362495: Include what you use in PPCRegisterInfo.cpp.
Include what you use in PPCRegisterInfo.cpp
Tue, Jun 4, 5:52 AM
gribozavr added a comment to D62845: [clang-tidy] Fix make-unique tests on C++2a..

I'd suggest to add a separate file that covers the exact language modes needed.

The C++14 test that we have right now is about C++14-or-later, testing the availability of std::make_unique.

The test file name ("modernize-make-unique-cxx14") indicates this test is for C++14, and since we change the existing modernize-make-unique test (which covers more cases) to C++14 or later, I think it is reasonable to restrict the cxx14 test to run only on C++14. or am I missing anything?

Tue, Jun 4, 3:18 AM · Restricted Project, Restricted Project
gribozavr committed rG63846039f574: Silenced a warning "implicit conversion turns string literal into bool"… (authored by gribozavr).
Silenced a warning "implicit conversion turns string literal into bool"…
Tue, Jun 4, 2:30 AM
gribozavr committed rL362480: Silenced a warning "implicit conversion turns string literal into bool"….
Silenced a warning "implicit conversion turns string literal into bool"…
Tue, Jun 4, 2:30 AM
gribozavr committed rG73a15d4b7822: Include what you use in PPC.h (authored by gribozavr).
Include what you use in PPC.h
Tue, Jun 4, 2:14 AM
gribozavr committed rG067a17b51dcf: Include what you use in PPCMachineScheduler.cpp (authored by gribozavr).
Include what you use in PPCMachineScheduler.cpp
Tue, Jun 4, 2:14 AM
gribozavr committed rL362477: Include what you use in PPC.h.
Include what you use in PPC.h
Tue, Jun 4, 2:14 AM
gribozavr committed rL362476: Include what you use in PPCMachineScheduler.cpp.
Include what you use in PPCMachineScheduler.cpp
Tue, Jun 4, 2:14 AM
gribozavr committed rG9d1c5ea16502: Include what you use in PPCRegisterInfo.h (authored by gribozavr).
Include what you use in PPCRegisterInfo.h
Tue, Jun 4, 2:13 AM
gribozavr committed rL362475: Include what you use in PPCRegisterInfo.h.
Include what you use in PPCRegisterInfo.h
Tue, Jun 4, 2:13 AM
gribozavr added a comment to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Sorry for jumping in late, but renaming the declaration is not enough -- usages should also be updated; otherwise the developer is better off using a refactoring in their IDE or even a textual search and replace.

Tue, Jun 4, 1:57 AM · Restricted Project, Restricted Project
gribozavr added a comment to D62845: [clang-tidy] Fix make-unique tests on C++2a..

I'm also not sure what the intent behind these tests is. Maybe the right fix is to add a constructor that can be called?

Tue, Jun 4, 1:50 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..
Tue, Jun 4, 1:50 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr added a comment to D62845: [clang-tidy] Fix make-unique tests on C++2a..

I'd suggest to add a separate file that covers the exact language modes needed.

Tue, Jun 4, 1:50 AM · Restricted Project, Restricted Project
gribozavr accepted D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..
Tue, Jun 4, 1:41 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 3

gribozavr committed rG26c43d0ef8e5: Include what you use in Lanai.h (authored by gribozavr).
Include what you use in Lanai.h
Mon, Jun 3, 10:01 AM
gribozavr committed rGb8aeaf882e49: Include what you use in LanaiAsmPrinter.cpp (authored by gribozavr).
Include what you use in LanaiAsmPrinter.cpp
Mon, Jun 3, 10:00 AM
gribozavr committed rGdc136847e3f8: Include what you use in LanaiMemAluCombiner.cpp (authored by gribozavr).
Include what you use in LanaiMemAluCombiner.cpp
Mon, Jun 3, 10:00 AM
gribozavr committed rG179154f6b99f: Include what you use in LanaiFrameLowering.{cpp,h} (authored by gribozavr).
Include what you use in LanaiFrameLowering.{cpp,h}
Mon, Jun 3, 10:00 AM
gribozavr committed rGf4d22bd0b40b: Include what you use in LanaiISelDAGToDAG.cpp (authored by gribozavr).
Include what you use in LanaiISelDAGToDAG.cpp
Mon, Jun 3, 10:00 AM
gribozavr committed rL362423: Include what you use in Lanai.h.
Include what you use in Lanai.h
Mon, Jun 3, 9:59 AM
gribozavr committed rL362422: Include what you use in LanaiAsmPrinter.cpp.
Include what you use in LanaiAsmPrinter.cpp
Mon, Jun 3, 9:59 AM
gribozavr committed rL362421: Include what you use in LanaiMemAluCombiner.cpp.
Include what you use in LanaiMemAluCombiner.cpp
Mon, Jun 3, 9:59 AM
gribozavr committed rL362420: Include what you use in LanaiISelDAGToDAG.cpp.
Include what you use in LanaiISelDAGToDAG.cpp
Mon, Jun 3, 9:59 AM
gribozavr committed rGb46934eeb8ce: Revert "[Tests] Add LFTR tests for multiple exit loops" (authored by gribozavr).
Revert "[Tests] Add LFTR tests for multiple exit loops"
Mon, Jun 3, 9:59 AM
gribozavr committed rL362419: Include what you use in LanaiFrameLowering.{cpp,h}.
Include what you use in LanaiFrameLowering.{cpp,h}
Mon, Jun 3, 9:59 AM
gribozavr committed rL362418: Revert "[Tests] Add LFTR tests for multiple exit loops".
Revert "[Tests] Add LFTR tests for multiple exit loops"
Mon, Jun 3, 9:59 AM
gribozavr committed rG8e317e29da4a: Include what you use in LanaiRegisterInfo.cpp (authored by gribozavr).
Include what you use in LanaiRegisterInfo.cpp
Mon, Jun 3, 9:33 AM
gribozavr committed rL362416: Include what you use in LanaiRegisterInfo.cpp.
Include what you use in LanaiRegisterInfo.cpp
Mon, Jun 3, 9:32 AM
gribozavr committed rG857de979a7e4: Revert "[llvm-ar] Fix relative thin archive path handling" (authored by gribozavr).
Revert "[llvm-ar] Fix relative thin archive path handling"
Mon, Jun 3, 9:20 AM
gribozavr added a comment to D59491: Fix relative thin archive path handling.

Sorry, I reverted this change in r362413, it was breaking the build.

Mon, Jun 3, 9:19 AM · Restricted Project
gribozavr committed rL362413: Revert "[llvm-ar] Fix relative thin archive path handling".
Revert "[llvm-ar] Fix relative thin archive path handling"
Mon, Jun 3, 9:18 AM
gribozavr committed rGbedcaea99a78: Include what you use in LanaiInstrInfo.cpp (authored by gribozavr).
Include what you use in LanaiInstrInfo.cpp
Mon, Jun 3, 8:26 AM
gribozavr committed rL362408: Include what you use in LanaiInstrInfo.cpp.
Include what you use in LanaiInstrInfo.cpp
Mon, Jun 3, 8:26 AM
gribozavr committed rGb3bd866c7f5f: Include what you use in PPCInstrInfo.h (authored by gribozavr).
Include what you use in PPCInstrInfo.h
Mon, Jun 3, 8:04 AM
gribozavr committed rL362405: Include what you use in PPCInstrInfo.h.
Include what you use in PPCInstrInfo.h
Mon, Jun 3, 8:01 AM
gribozavr committed rG2b369f83c59b: Include what you use in NVPTX.h (authored by gribozavr).
Include what you use in NVPTX.h
Mon, Jun 3, 7:36 AM