- User Since
- Jul 18 2012, 9:18 AM (370 w, 2 d)
Agreed about multiplexing issues -- this is a case where wrapping or merging abstraction layers is the right solution.
LGTM, although I'd be more comfortable with a whitelist of macros.
Fixed a typo
Wed, Aug 21
Updated a comment.
Tue, Aug 20
Fixed a typo.
Wed, Aug 14
Sorry, but this patch broke the build (http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/16455), I reverted it. Please run check-all before re-committing.
Tue, Aug 13
Like @riccibruno said, check-clang-tools will run them. However, before committing a patch, please run check-all -- you never know what your patch can affect.
Sorry, but this change broke ClangTidy tests: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/16398. I reverted it.
Mon, Aug 12
Very nice improvement! Thank you!
Nice simplification, thanks!
Fri, Aug 9
Thu, Aug 8
Wed, Aug 7
Tue, Aug 6
Sorry, this change broke the buildbots (http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/16018) and I reverted it in r368073.