- User Since
- Jul 18 2012, 9:18 AM (353 w, 8 h)
Thanks for the checker! We are hitting a crash on _Atomic fields, could you take a look? https://bugs.llvm.org/show_bug.cgi?id=41590 Thanks!
Thu, Apr 18
Tue, Apr 16
Mon, Apr 15
Fri, Apr 12
Wed, Apr 10
On the functional side - does this look like a reasonable idea?
I'd be happy to land it, but I do want @rsmith to take a look.
The way I understand the intention in ActOnDocumentableDecls is that we are just checking if some of existing comments should be attached to newly created Decls. I assume we don't need to load external comments since those Decls are "local".
This fix makes sense to me, however, Richard Smith @rsmith is the best person to review this patch.
Sun, Mar 31
Do you have commit access?
Thu, Mar 28
Tue, Mar 26
Submitting code as it becomes ready is the usual practice here.
Mar 22 2019
Mar 21 2019
Mar 20 2019
Mar 18 2019
As far as I'm concerned, I don't have any major revision requests. I haven't reviewed the unit tests (I'm planning to), but for non-test code, I don't have any further comments.
Mar 15 2019
Mar 13 2019
Mar 12 2019
Sorry for the delay. I will finish reviewing tomorrow.
I basically didn't really like the idea of testing against hard-coded hash values in unittests as I consider it to be an implementation detail.
I left some comments, but it is difficult for me to review without understanding what the requirements for this hasher are, why some information is hashed in, and some is left out, could you clarify? See detailed comments.
Mar 11 2019
Mar 8 2019
Mar 7 2019
Do we also need to change anything for constructor calls? If not, please add a test for that.
Mar 6 2019
My understanding is that the storage space taken up for Refs is currently 8 bytes per Ref (4 each for the start and end positions), plus filename strings which are deduplicated across all refs. If we add a SymbolID, that adds an additional 8 bytes to each Ref. Given that Refs are numerous, and most of them won't use the SymbolID, that seems wasteful.
Mar 5 2019
Hmm, do we really need the matches for the AST node that is not described/defined by the standard? If this is really so, I'm ok with this.
Mar 4 2019
The test coverage i have will be in the clang-tidy check.
Mar 1 2019
These references were added to support using the index data for symbol rename.
Please also add a test for find references on a constructor.