♟ gribozavr

LGTM, assuming you know what's new in QtCreator.

Thanks! Please add tests in ./unittests/Tooling/ReplacementsYamlTest.cpp.

[clang-tidy] Made abseil-faster-strsplit-delimiter tests pass on C++17

[clang-tidy] Fixed abseil-time-subtraction to work on C++17

[clang-tidy] Made abseil-upgrade-duration-conversions tests pass on c++17

[clang-tidy] Fixed abseil-duration-unnecessary-conversion tests for c++17

Added AST matcher for ignoring elidable constructors

Fixed a crash in misc-redundant-expression ClangTidy checker

This fix works. The alternative would have been to wrap these variables into llvm::ManagedStatic, just like the problematic TrueMatcherInstance in ASTMatchersInternal.cpp.

Fixed google-readability-casting test to work in c++17

I'll commit this change.

Work around a circular dependency between IR and MC introduced in r362735

Remove unused PPC.h includes under llvm/lib/Target/PowerPC.

Is this patch still needed?

Include what you use in LanaiAsmParser.cpp

Include what you use in PPCFrameLowering.h

Looks great, thank you!

In D62845#1529149, @hokein wrote:

I think we should be looking at the intent of the test rather than its name.

The intent looks like testing how the check works when std::make_unique is available from the standard library (as opposed to some kind of replacement like absl::make_unique). See the patch that introduced it: https://reviews.llvm.org/D43766

So modernize-make-unique-cxx14 is actually "C++14 or later". (Probably it should be renamed.)

yeap, it seems to me that "modernize-make-unique-cxx14" is redundant, "modernize-make-unique" should cover what it tests, I believe. We also have "modernize-make-unique-cxx11" which runs on C++11 mode only, maybe we just repurpose the modernize-make-unique-cxx14, what do you think?

Include what you use in PPCRegisterInfo.cpp

In D62845#1528887, @hokein wrote:

In D62845#1528791, @gribozavr wrote:

I'd suggest to add a separate file that covers the exact language modes needed.

The C++14 test that we have right now is about C++14-or-later, testing the availability of std::make_unique.

The test file name ("modernize-make-unique-cxx14") indicates this test is for C++14, and since we change the existing modernize-make-unique test (which covers more cases) to C++14 or later, I think it is reasonable to restrict the cxx14 test to run only on C++14. or am I missing anything?

Silenced a warning "implicit conversion turns string literal into bool"…

Include what you use in PPC.h

Include what you use in PPCMachineScheduler.cpp

Include what you use in PPC.h

Include what you use in PPCMachineScheduler.cpp

Include what you use in PPCRegisterInfo.h

Sorry for jumping in late, but renaming the declaration is not enough -- usages should also be updated; otherwise the developer is better off using a refactoring in their IDE or even a textual search and replace.

I'm also not sure what the intent behind these tests is. Maybe the right fix is to add a constructor that can be called?

I'd suggest to add a separate file that covers the exact language modes needed.

Include what you use in Lanai.h

Include what you use in LanaiAsmPrinter.cpp

Include what you use in LanaiMemAluCombiner.cpp

Include what you use in LanaiFrameLowering.{cpp,h}

Include what you use in LanaiISelDAGToDAG.cpp

Include what you use in Lanai.h

Include what you use in LanaiAsmPrinter.cpp

Include what you use in LanaiMemAluCombiner.cpp

Include what you use in LanaiISelDAGToDAG.cpp

Revert "[Tests] Add LFTR tests for multiple exit loops"

Include what you use in LanaiFrameLowering.{cpp,h}

Revert "[Tests] Add LFTR tests for multiple exit loops"

Include what you use in LanaiRegisterInfo.cpp

Revert "[llvm-ar] Fix relative thin archive path handling"

Sorry, I reverted this change in r362413, it was breaking the build.

Revert "[llvm-ar] Fix relative thin archive path handling"

Include what you use in LanaiInstrInfo.cpp

Include what you use in PPCInstrInfo.h

Include what you use in NVPTX.h

gribozavr (Dmitri Gribenko)
User

Projects

User Details

Recent Activity
View All

Today

Yesterday

Wed, Jun 19

Thu, Jun 13

Wed, Jun 12

Tue, Jun 11

Fri, Jun 7

Thu, Jun 6

Wed, Jun 5

Tue, Jun 4

Mon, Jun 3

gribozavr (Dmitri Gribenko)User