- User Since
- Jul 18 2012, 9:18 AM (392 w, 4 d)
Fri, Jan 17
Thu, Jan 16
Tue, Jan 14
Thu, Jan 2
Mon, Dec 30
Dec 20 2019
Dec 19 2019
Dec 16 2019
Dec 13 2019
Nov 30 2019
Nov 19 2019
Addressed review comments.
Oct 24 2019
Looks reasonable to me. The duplication is unfortunate, but it is reasonable while we have two binaries.
Addressed review comments
Oct 23 2019
Oct 18 2019
What are the use cases for non-text values?
Please upload patches with context in future (arc diff will do that for you).
Oct 14 2019
Sorry, this change broke the build (http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/19218) and I reverted it in r374768.
Oct 11 2019
What do you think of my just putting all of the Transformer types + combis in the single clang::transformer namespace?
WDYT about clang::transformer? I don't see much point in the intermediate namespace. However, LGTM either way.
I guess here's the high-level question: should all removals that remove all non-blank text from a line also delete the line?
Oct 10 2019
It would look weird if we have a ton of tests for checkers in a directory, and then a subdirectory for infra tests.
Why does the number of moves matter? Git preserves history across moves.
I reverted this change in r374358 because it depends on https://reviews.llvm.org/D68146, which broke tests.
This change broke tests: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/19066
Sorry, but this commit broke OCaml tests: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/19014
Oct 9 2019
+1 to what MyDeveloperDay said. The infrastructure can't know whether the newlines are intentional or not. Checks that edit the source code should be improved to delete newlines where they become unnecessary. I don't think we can accept the patch that changes how we apply edits.
Oct 8 2019
There's no shortage of possible implicit TODOs
I'm holding off on reviewing the code until we figure out what the rules are.
It looks to me that a better fix is to fix the checker to not emit this warning in MS compatibility mode.
Update header guards?
Oct 7 2019
Oct 4 2019
Sorry, but this change broke the build: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/18721
Oct 2 2019
Oct 1 2019
This change broke tests: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/18485. I reverted it in r373311.
Sep 27 2019
Sep 26 2019
Sorry, I reverted it in r373032 because the test fails on Linux: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/18323 . Could you please take a look? Thanks!
Sorry, could you rebase the patch to apply cleanly to master? Seems like someone else edited ReleaseNotes.rst in the meanwhile.