Page MenuHomePhabricator

gribozavr (Dmitri Gribenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 18 2012, 9:18 AM (370 w, 2 d)

Recent Activity

Today

gribozavr added a comment to D66125: [clang] Generalize WrapperFrontendAction to support multiple actions.

Agreed about multiplexing issues -- this is a case where wrapping or merging abstraction layers is the right solution.

Fri, Aug 23, 10:21 AM
gribozavr accepted D66652: [libTooling] Transformer: refine `SourceLocation` specified as anchor of changes..
Fri, Aug 23, 10:16 AM · Restricted Project
gribozavr accepted D66631: [clang-tidy] Don't emit google-runtime-references warning for functions defined in macros..

LGTM, although I'd be more comfortable with a whitelist of macros.

Fri, Aug 23, 1:23 AM · Restricted Project, Restricted Project

Yesterday

gribozavr committed rG282dc72c8b84: Remove \brief commands from doxygen comments. (authored by gribozavr).
Remove \brief commands from doxygen comments.
Thu, Aug 22, 4:33 AM
gribozavr committed rL369643: Remove \brief commands from doxygen comments..
Remove \brief commands from doxygen comments.
Thu, Aug 22, 4:32 AM
gribozavr closed D66578: Remove \brief commands from doxygen comments..
Thu, Aug 22, 4:32 AM · Restricted Project, Restricted Project
gribozavr updated the diff for D66578: Remove \brief commands from doxygen comments..

Fixed a typo

Thu, Aug 22, 2:30 AM · Restricted Project, Restricted Project
gribozavr added a reviewer for D66578: Remove \brief commands from doxygen comments.: ilya-biryukov.
Thu, Aug 22, 2:30 AM · Restricted Project, Restricted Project
gribozavr created D66578: Remove \brief commands from doxygen comments..
Thu, Aug 22, 2:28 AM · Restricted Project, Restricted Project

Wed, Aug 21

gribozavr accepted D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType).
Wed, Aug 21, 2:19 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes.
Wed, Aug 21, 2:14 AM · Restricted Project
gribozavr committed rG6b9d7c9da591: Removed some dead code in BugReporter and related files (authored by gribozavr).
Removed some dead code in BugReporter and related files
Wed, Aug 21, 1:50 AM
gribozavr committed rL369504: Removed some dead code in BugReporter and related files.
Removed some dead code in BugReporter and related files
Wed, Aug 21, 1:50 AM
gribozavr closed D66473: [analyzer] Removed some dead code in BugReporter and related files.
Wed, Aug 21, 1:50 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D66473: [analyzer] Removed some dead code in BugReporter and related files.
Wed, Aug 21, 1:41 AM · Restricted Project, Restricted Project
gribozavr updated the diff for D66473: [analyzer] Removed some dead code in BugReporter and related files.

Updated a comment.

Wed, Aug 21, 1:34 AM · Restricted Project, Restricted Project

Tue, Aug 20

gribozavr added inline comments to D66473: [analyzer] Removed some dead code in BugReporter and related files.
Tue, Aug 20, 1:55 PM · Restricted Project, Restricted Project
gribozavr added inline comments to D66125: [clang] Generalize WrapperFrontendAction to support multiple actions.
Tue, Aug 20, 11:44 AM
gribozavr added inline comments to D66473: [analyzer] Removed some dead code in BugReporter and related files.
Tue, Aug 20, 11:41 AM · Restricted Project, Restricted Project
gribozavr created D66473: [analyzer] Removed some dead code in BugReporter and related files.
Tue, Aug 20, 7:00 AM · Restricted Project, Restricted Project
gribozavr added a reviewer for D66473: [analyzer] Removed some dead code in BugReporter and related files: NoQ.
Tue, Aug 20, 7:00 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D65182: [analyzer] Add fix-it hint support..
Tue, Aug 20, 6:10 AM · Restricted Project
gribozavr committed rGdee011b7f4ce: Removed the 'id' AST matcher, which is superseded by '.bind()' (authored by gribozavr).
Removed the 'id' AST matcher, which is superseded by '.bind()'
Tue, Aug 20, 6:05 AM
gribozavr committed rL369380: Removed the 'id' AST matcher, which is superseded by '.bind()'.
Removed the 'id' AST matcher, which is superseded by '.bind()'
Tue, Aug 20, 6:01 AM
gribozavr closed D66462: Removed the 'id' AST matcher, which is superseded by '.bind()'.
Tue, Aug 20, 6:01 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType).
Tue, Aug 20, 5:50 AM · Restricted Project, Restricted Project
gribozavr updated the diff for D66462: Removed the 'id' AST matcher, which is superseded by '.bind()'.

Fixed a typo.

Tue, Aug 20, 2:50 AM · Restricted Project, Restricted Project
gribozavr added a reviewer for D66462: Removed the 'id' AST matcher, which is superseded by '.bind()': ymandel.
Tue, Aug 20, 2:50 AM · Restricted Project, Restricted Project
gribozavr added reviewers for D66462: Removed the 'id' AST matcher, which is superseded by '.bind()': ilya-biryukov, klimek.
Tue, Aug 20, 2:50 AM · Restricted Project, Restricted Project
gribozavr created D66462: Removed the 'id' AST matcher, which is superseded by '.bind()'.
Tue, Aug 20, 2:47 AM · Restricted Project, Restricted Project
gribozavr added a comment to D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛.

LGTM, thanks!

Tue, Aug 20, 1:47 AM · Restricted Project, Restricted Project
gribozavr added a comment to D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛.

LGTM, thanks!

Tue, Aug 20, 1:47 AM · Restricted Project, Restricted Project
gribozavr accepted D66303: [LifetimeAnalysis] Add support for free functions.
Tue, Aug 20, 1:43 AM · Restricted Project, Restricted Project
gribozavr accepted D66350: Rudimentary support for Doxygen \retval command.

Thanks!

Tue, Aug 20, 1:24 AM · Restricted Project, Restricted Project
gribozavr accepted D66443: [LifetimeAnalysis] Add [[gsl::Pointer]] to llvm::StringRef.
Tue, Aug 20, 1:16 AM · Restricted Project

Wed, Aug 14

gribozavr added inline comments to D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType).
Wed, Aug 14, 4:02 PM · Restricted Project, Restricted Project
gribozavr committed rG030409020cd5: Removed ToolExecutor::isSingleProcess, it is not used by anything (authored by gribozavr).
Removed ToolExecutor::isSingleProcess, it is not used by anything
Wed, Aug 14, 4:35 AM
gribozavr committed rL368832: Removed ToolExecutor::isSingleProcess, it is not used by anything.
Removed ToolExecutor::isSingleProcess, it is not used by anything
Wed, Aug 14, 4:34 AM
gribozavr closed D66212: Removed ToolExecutor::isSingleProcess, it is not used by anything.
Wed, Aug 14, 4:34 AM · Restricted Project, Restricted Project
gribozavr added a reviewer for D66212: Removed ToolExecutor::isSingleProcess, it is not used by anything: sammccall.
Wed, Aug 14, 4:21 AM · Restricted Project, Restricted Project
gribozavr created D66212: Removed ToolExecutor::isSingleProcess, it is not used by anything.
Wed, Aug 14, 4:21 AM · Restricted Project, Restricted Project
gribozavr committed rG175261c9ec39: Improved the doc comment for getCommentsInFile (authored by gribozavr).
Improved the doc comment for getCommentsInFile
Wed, Aug 14, 4:12 AM
gribozavr committed rL368827: Improved the doc comment for getCommentsInFile.
Improved the doc comment for getCommentsInFile
Wed, Aug 14, 4:11 AM
gribozavr closed D66209: Improved the doc comment for getCommentsInFile.
Wed, Aug 14, 4:11 AM · Restricted Project, Restricted Project
gribozavr added a reviewer for D66209: Improved the doc comment for getCommentsInFile: hokein.
Wed, Aug 14, 3:55 AM · Restricted Project, Restricted Project
gribozavr created D66209: Improved the doc comment for getCommentsInFile.
Wed, Aug 14, 3:54 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D64384: [WIP] Index-while-building.
Wed, Aug 14, 3:08 AM · Restricted Project
gribozavr added inline comments to D66172: [clang][Modules] Serialize decl to comment mapping to speed up code completion..
Wed, Aug 14, 3:00 AM
gribozavr accepted D66152: Fix false negatives of statement local lifetime analysis for some STL implementation.
Wed, Aug 14, 2:42 AM · Restricted Project, Restricted Project
gribozavr accepted D66164: [LifetimeAnalysis] Support std::stack::top() and std::optional::value().
Wed, Aug 14, 2:17 AM · Restricted Project, Restricted Project
gribozavr added a comment to D66089: [llvm/Object] - Convert SectionRef::getName() to return Expected<>.

Sorry, but this patch broke the build (http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/16455), I reverted it. Please run check-all before re-committing.

Wed, Aug 14, 2:05 AM · Restricted Project
gribozavr added inline comments to D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType).
Wed, Aug 14, 1:55 AM · Restricted Project, Restricted Project
gribozavr committed rG1427226fe8c3: Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h} (authored by gribozavr).
Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h}
Wed, Aug 14, 12:35 AM
gribozavr committed rL368805: Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h}.
Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h}
Wed, Aug 14, 12:32 AM
gribozavr closed D66156: Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h}.
Wed, Aug 14, 12:32 AM · Restricted Project, Restricted Project

Tue, Aug 13

gribozavr added a comment to D61027: Fix crash on switch conditions of non-integer types in templates.

Like @riccibruno said, check-clang-tools will run them. However, before committing a patch, please run check-all -- you never know what your patch can affect.

Tue, Aug 13, 1:38 PM · Restricted Project
gribozavr committed rL368738: Revert "Fix crash on switch conditions of non-integer types in templates".
Revert "Fix crash on switch conditions of non-integer types in templates"
Tue, Aug 13, 12:19 PM
gribozavr committed rGa5ef73cb4bd6: Revert "Fix crash on switch conditions of non-integer types in templates" (authored by gribozavr).
Revert "Fix crash on switch conditions of non-integer types in templates"
Tue, Aug 13, 12:19 PM
gribozavr added a comment to D61027: Fix crash on switch conditions of non-integer types in templates.

Sorry, but this change broke ClangTidy tests: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/16398. I reverted it.

Tue, Aug 13, 12:06 PM · Restricted Project
gribozavr created D66156: Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h}.
Tue, Aug 13, 11:40 AM · Restricted Project, Restricted Project
gribozavr abandoned D66136: Remove no-op callbacks from TemplateInstantiationCallback.
Tue, Aug 13, 11:37 AM · Restricted Project
gribozavr added inline comments to D66125: [clang] Generalize WrapperFrontendAction to support multiple actions.
Tue, Aug 13, 5:58 AM
gribozavr added a reviewer for D66136: Remove no-op callbacks from TemplateInstantiationCallback: xazax.hun.
Tue, Aug 13, 4:24 AM · Restricted Project
gribozavr created D66136: Remove no-op callbacks from TemplateInstantiationCallback.
Tue, Aug 13, 4:23 AM · Restricted Project

Mon, Aug 12

gribozavr accepted D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers..
Mon, Aug 12, 12:46 PM · Restricted Project, Restricted Project
gribozavr added a comment to D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers..

I was going to add a test for Type/QualType and realized that they don't carry any source location info. Therefore, I don't think they belong as top-level matchers for rewrite rules.

Mon, Aug 12, 11:27 AM · Restricted Project, Restricted Project
gribozavr accepted D65301: [clang] Refactor how are doc comments attached to Decls.

Very nice improvement! Thank you!

Mon, Aug 12, 1:36 AM · Restricted Project
gribozavr accepted D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers..

Nice simplification, thanks!

Mon, Aug 12, 1:17 AM · Restricted Project, Restricted Project

Fri, Aug 9

gribozavr added inline comments to D64384: [WIP] Index-while-building.
Fri, Aug 9, 6:25 AM · Restricted Project
gribozavr accepted D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations.
Fri, Aug 9, 6:12 AM · Restricted Project, Restricted Project
gribozavr accepted D65879: [clang-tidy] Update `TransformerClangTidyCheck` to use new `buildMatchers` functionality..
Fri, Aug 9, 5:44 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers..
Fri, Aug 9, 5:43 AM · Restricted Project, Restricted Project
gribozavr accepted D65120: More warnings regarding gsl::Pointer and gsl::Owner attributes.
Fri, Aug 9, 1:17 AM · Restricted Project, Restricted Project

Thu, Aug 8

gribozavr added inline comments to D65301: [clang] Refactor how are doc comments attached to Decls.
Thu, Aug 8, 11:25 PM · Restricted Project
gribozavr committed rGe187336374c1: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit (authored by gribozavr).
Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit
Thu, Aug 8, 11:15 PM
gribozavr accepted D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.
Thu, Aug 8, 11:15 PM · Restricted Project, Restricted Project
gribozavr committed rL368399: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit.
Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit
Thu, Aug 8, 11:14 PM
gribozavr closed D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit.
Thu, Aug 8, 11:14 PM · Restricted Project, Restricted Project
gribozavr accepted D65963: [clang][NFC] Move matcher ignoringElidableConstructorCall's tests to appropriate file..

Thanks!

Thu, Aug 8, 11:48 AM · Restricted Project, Restricted Project
gribozavr added a comment to D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit.

I tested this out. Seems to work fine, and print the Expected's Error. I am fine with it if @compnerd and @lhames and @jkorous are cool with it.

Thu, Aug 8, 10:02 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D65301: [clang] Refactor how are doc comments attached to Decls.
Thu, Aug 8, 9:48 AM · Restricted Project
gribozavr accepted D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.
Thu, Aug 8, 9:13 AM · Restricted Project, Restricted Project
gribozavr accepted D65944: [clang] Update `ignoringElidableConstructorCall` matcher to ignore `ExprWithCleanups`..
Thu, Aug 8, 8:49 AM · Restricted Project, Restricted Project
gribozavr accepted D65938: [AST] No longer visiting CXXMethodDecl bodies created by compiler when method was default created..
Thu, Aug 8, 6:38 AM · Restricted Project, Restricted Project
gribozavr accepted D65944: [clang] Update `ignoringElidableConstructorCall` matcher to ignore `ExprWithCleanups`..
Thu, Aug 8, 6:25 AM · Restricted Project, Restricted Project
gribozavr accepted D65940: [clang-format] fix crash involving invalid preprocessor line.
Thu, Aug 8, 4:52 AM · Restricted Project, Restricted Project

Wed, Aug 7

gribozavr created D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit.
Wed, Aug 7, 2:08 AM · Restricted Project, Restricted Project
gribozavr accepted D65849: [unittests] Mark private gmock headers with IWYU pragmas. NFC.
Wed, Aug 7, 1:32 AM · Restricted Project
gribozavr committed rG8840cd31414b: Remove inclusion of a private gmock header from a test (authored by gribozavr).
Remove inclusion of a private gmock header from a test
Wed, Aug 7, 1:17 AM
gribozavr committed rL368132: Remove inclusion of a private gmock header from a test.
Remove inclusion of a private gmock header from a test
Wed, Aug 7, 1:15 AM

Tue, Aug 6

gribozavr added inline comments to D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create..
Tue, Aug 6, 2:44 PM · Restricted Project, Restricted Project
gribozavr added inline comments to D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create..
Tue, Aug 6, 2:33 PM · Restricted Project, Restricted Project
gribozavr added inline comments to D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create..
Tue, Aug 6, 2:28 PM · Restricted Project, Restricted Project
gribozavr added inline comments to D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create..
Tue, Aug 6, 2:14 PM · Restricted Project, Restricted Project
gribozavr added inline comments to D65704: DirectoryWatcher::create: Adding better error handling..
Tue, Aug 6, 1:32 PM · Restricted Project, Restricted Project
gribozavr added inline comments to D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes.
Tue, Aug 6, 12:50 PM · Restricted Project, Restricted Project
gribozavr added a comment to D63672: Added Delta IR Reduction Tool.

Sorry, this change broke the buildbots (http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/16018) and I reverted it in r368073.

Tue, Aug 6, 12:46 PM · Restricted Project
gribozavr added inline comments to D65704: DirectoryWatcher::create: Adding better error handling..
Tue, Aug 6, 12:45 PM · Restricted Project, Restricted Project
gribozavr committed rGe2f17e264997: Revert "Added Delta IR Reduction Tool" (authored by gribozavr).
Revert "Added Delta IR Reduction Tool"
Tue, Aug 6, 12:43 PM
gribozavr committed rL368073: Revert "Added Delta IR Reduction Tool".
Revert "Added Delta IR Reduction Tool"
Tue, Aug 6, 12:43 PM