Page MenuHomePhabricator
People gribozavr

gribozavr (Dmitri Gribenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 18 2012, 9:18 AM (378 w, 6 h)

Recent Activity
View All

Mon, Oct 14

gribozavr committed rL374768: Revert "Add a pass to lower is.constant and objectsize intrinsics".
Revert "Add a pass to lower is.constant and objectsize intrinsics"
Mon, Oct 14, 5:29 AM
gribozavr committed rG1a21f98ac3c5: Revert "Add a pass to lower is.constant and objectsize intrinsics" (authored by gribozavr).
Revert "Add a pass to lower is.constant and objectsize intrinsics"
Mon, Oct 14, 5:29 AM
gribozavr added a comment to D65280: Add a pass to lower is.constant and objectsize intrinsics.

Sorry, this change broke the build (http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/19218) and I reverted it in r374768.

Mon, Oct 14, 5:29 AM · Restricted Project

Fri, Oct 11

gribozavr added a comment to D68876: [libTooling] Put all Transformer declarations in a single namespace..

What do you think of my just putting all of the Transformer types + combis in the single clang::transformer namespace?

Fri, Oct 11, 11:55 AM · Restricted Project
gribozavr accepted D68876: [libTooling] Put all Transformer declarations in a single namespace..

WDYT about clang::transformer? I don't see much point in the intermediate namespace. However, LGTM either way.

Fri, Oct 11, 9:47 AM · Restricted Project
gribozavr committed rGaa87b081cdff: Updated add_new_check.py to create checker tests in the new directory (authored by gribozavr).
Updated add_new_check.py to create checker tests in the new directory
Fri, Oct 11, 6:50 AM
gribozavr committed rL374551: Updated add_new_check.py to create checker tests in the new directory.
Updated add_new_check.py to create checker tests in the new directory
Fri, Oct 11, 6:49 AM
gribozavr added a comment to D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line.

I guess here's the high-level question: should all removals that remove all non-blank text from a line also delete the line?

Fri, Oct 11, 6:40 AM · Restricted Project, Restricted Project
gribozavr committed rGd103e2d267db: [ClangTidy] Separate tests for infrastructure and checkers, fixup (authored by gribozavr).
[ClangTidy] Separate tests for infrastructure and checkers, fixup
Fri, Oct 11, 6:22 AM
gribozavr committed rL374549: [ClangTidy] Separate tests for infrastructure and checkers, fixup.
[ClangTidy] Separate tests for infrastructure and checkers, fixup
Fri, Oct 11, 6:14 AM
gribozavr committed rL374540: [ClangTidy] Separate tests for infrastructure and checkers.
[ClangTidy] Separate tests for infrastructure and checkers
Fri, Oct 11, 5:18 AM
gribozavr committed rG885c559369fe: [ClangTidy] Separate tests for infrastructure and checkers (authored by gribozavr).
[ClangTidy] Separate tests for infrastructure and checkers
Fri, Oct 11, 5:18 AM
gribozavr closed D68807: [ClangTidy] Separate tests for infrastructure and checkers.
Fri, Oct 11, 5:14 AM · Restricted Project
gribozavr added inline comments to D68074: [clang-tidy] Add readability-make-member-function-const.
Fri, Oct 11, 2:44 AM · Restricted Project, Restricted Project
gribozavr accepted D68825: [libTooling] Change Stencil equality to use `toString()`.
Fri, Oct 11, 1:36 AM · Restricted Project
gribozavr accepted D68795: [libTooling] Move `RewriteRule` abstraction into its own header and impl..
Fri, Oct 11, 1:27 AM · Restricted Project

Thu, Oct 10

gribozavr added a comment to D68807: [ClangTidy] Separate tests for infrastructure and checkers.

It would look weird if we have a ton of tests for checkers in a directory, and then a subdirectory for infra tests.

Thu, Oct 10, 3:21 PM · Restricted Project
gribozavr added a comment to D68807: [ClangTidy] Separate tests for infrastructure and checkers.

Why does the number of moves matter? Git preserves history across moves.

Thu, Oct 10, 2:52 PM · Restricted Project
gribozavr added reviewers for D68807: [ClangTidy] Separate tests for infrastructure and checkers: ilya-biryukov, alexfh.
Thu, Oct 10, 8:59 AM · Restricted Project
Herald added a reviewer for D68807: [ClangTidy] Separate tests for infrastructure and checkers: jdoerfert.
Thu, Oct 10, 8:59 AM · Restricted Project
gribozavr added inline comments to D68795: [libTooling] Move `RewriteRule` abstraction into its own header and impl..
Thu, Oct 10, 8:40 AM · Restricted Project
gribozavr committed rGd3aed7fc7986: Revert "[FileCheck] Implement --ignore-case option." (authored by gribozavr).
Revert "[FileCheck] Implement --ignore-case option."
Thu, Oct 10, 7:26 AM
gribozavr committed rGa89e5a41ec7c: Revert "[Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj). (authored by gribozavr).
Revert "[Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj).
Thu, Oct 10, 7:26 AM
gribozavr committed rL374359: Revert "[FileCheck] Implement --ignore-case option.".
Revert "[FileCheck] Implement --ignore-case option."
Thu, Oct 10, 7:25 AM
gribozavr committed rL374358: Revert "[Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj)..
Revert "[Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj).
Thu, Oct 10, 7:25 AM
gribozavr added a comment to D68693: [Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj)..

I reverted this change in r374358 because it depends on https://reviews.llvm.org/D68146, which broke tests.

Thu, Oct 10, 7:25 AM · Restricted Project
gribozavr added a comment to D68146: [FileCheck] Implement --ignore-case option..

This change broke tests: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/19066

Thu, Oct 10, 7:25 AM · Restricted Project
gribozavr committed rG43fcbcb4e8e5: Revert "Fix OCaml/core.ml fneg check" (authored by gribozavr).
Revert "Fix OCaml/core.ml fneg check"
Thu, Oct 10, 7:16 AM
gribozavr committed rGeaf6dd482b0a: Revert "[IRBuilder] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator" (authored by gribozavr).
Revert "[IRBuilder] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator"
Thu, Oct 10, 7:16 AM
gribozavr committed rL374357: Revert "Fix OCaml/core.ml fneg check".
Revert "Fix OCaml/core.ml fneg check"
Thu, Oct 10, 7:16 AM
gribozavr committed rL374354: Revert "[IRBuilder] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator".
Revert "[IRBuilder] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator"
Thu, Oct 10, 7:16 AM
gribozavr added a comment to D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator.

Sorry, but this commit broke OCaml tests: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/19014

Thu, Oct 10, 7:16 AM · Restricted Project, Restricted Project
gribozavr committed rL374319: Add github commit access for gribozavr.
Add github commit access for gribozavr
Thu, Oct 10, 5:03 AM

Wed, Oct 9

gribozavr requested changes to D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line.

+1 to what MyDeveloperDay said. The infrastructure can't know whether the newlines are intentional or not. Checks that edit the source code should be improved to delete newlines where they become unnecessary. I don't think we can accept the patch that changes how we apply edits.

Wed, Oct 9, 1:42 AM · Restricted Project, Restricted Project

Tue, Oct 8

gribozavr added a comment to D68640: Try to get readability-deleted-default.cpp to pass on Windows..

Thanks!

Tue, Oct 8, 1:47 PM · Restricted Project
gribozavr added a comment to D68640: Try to get readability-deleted-default.cpp to pass on Windows..

There's no shortage of possible implicit TODOs

Tue, Oct 8, 7:38 AM · Restricted Project
gribozavr added a comment to D68074: [clang-tidy] Add readability-make-member-function-const.

I'm holding off on reviewing the code until we figure out what the rules are.

Tue, Oct 8, 7:29 AM · Restricted Project, Restricted Project
gribozavr added a comment to D68640: Try to get readability-deleted-default.cpp to pass on Windows..

It looks to me that a better fix is to fix the checker to not emit this warning in MS compatibility mode.

Tue, Oct 8, 7:19 AM · Restricted Project
gribozavr accepted D68637: [libTooling] Move Transformer files to their own directory/library..

Update header guards?

Tue, Oct 8, 6:42 AM · Restricted Project

Mon, Oct 7

gribozavr accepted D68574: [libTooling] Add `toString` method to the Stencil class.
Mon, Oct 7, 8:29 AM · Restricted Project, Restricted Project

Fri, Oct 4

gribozavr committed rGb0e997bbf4e8: Revert "[NFC] [FileCheck] Fix init of stack objects in unit tests" (authored by gribozavr).
Revert "[NFC] [FileCheck] Fix init of stack objects in unit tests"
Fri, Oct 4, 2:43 AM
gribozavr committed rL373722: Revert "[NFC] [FileCheck] Fix init of stack objects in unit tests".
Revert "[NFC] [FileCheck] Fix init of stack objects in unit tests"
Fri, Oct 4, 2:42 AM
gribozavr added a comment to D68425: [NFC] [FileCheck] Fix init of objects in unit tests.

Sorry, but this change broke the build: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/18721

Fri, Oct 4, 2:42 AM · Restricted Project

Wed, Oct 2

gribozavr added inline comments to D68315: [libTooling] Add various Stencil combinators for expressions..
Wed, Oct 2, 3:26 PM · Restricted Project, Restricted Project
gribozavr added inline comments to D68315: [libTooling] Add various Stencil combinators for expressions..
Wed, Oct 2, 12:32 PM · Restricted Project, Restricted Project
gribozavr accepted D68315: [libTooling] Add various Stencil combinators for expressions..
Wed, Oct 2, 8:19 AM · Restricted Project, Restricted Project

Tue, Oct 1

gribozavr committed rGf58d01930f6f: Revert "[OCaml] Handle nullptr in Llvm.global_initializer" (authored by gribozavr).
Revert "[OCaml] Handle nullptr in Llvm.global_initializer"
Tue, Oct 1, 1:29 AM
gribozavr committed rL373311: Revert "[OCaml] Handle nullptr in Llvm.global_initializer".
Revert "[OCaml] Handle nullptr in Llvm.global_initializer"
Tue, Oct 1, 1:27 AM
gribozavr added a comment to D65195: [OCaml] Handle nullptr in Llvm.global_initializer.

This change broke tests: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/18485. I reverted it in r373311.

Tue, Oct 1, 1:27 AM · Restricted Project
gribozavr committed rG827a7fab78dc: Revert "GlobalISel: Handle llvm.read_register" (authored by gribozavr).
Revert "GlobalISel: Handle llvm.read_register"
Tue, Oct 1, 1:25 AM
gribozavr committed rL373310: Revert "GlobalISel: Handle llvm.read_register".
Revert "GlobalISel: Handle llvm.read_register"
Tue, Oct 1, 1:22 AM
gribozavr committed rGd1337ec22d48: [clang-tidy] Fix module registry name and description for Darwin clang-tidy… (authored by gribozavr).
[clang-tidy] Fix module registry name and description for Darwin clang-tidy…
Tue, Oct 1, 12:16 AM
gribozavr committed rL373304: [clang-tidy] Fix module registry name and description for Darwin clang-tidy….
[clang-tidy] Fix module registry name and description for Darwin clang-tidy…
Tue, Oct 1, 12:16 AM
gribozavr closed D68251: [clang-tidy] Fix module registry name and description for Darwin clang-tidy module..
Tue, Oct 1, 12:15 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr accepted D68251: [clang-tidy] Fix module registry name and description for Darwin clang-tidy module..
Tue, Oct 1, 12:07 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Sep 27

gribozavr accepted D68132: clang-tidy: Don't repeat list of all checks in three places..
Fri, Sep 27, 5:50 AM · Restricted Project
gribozavr committed rG6328f948adfa: Fixed indentation in a ClangTidy test (authored by gribozavr).
Fixed indentation in a ClangTidy test
Fri, Sep 27, 4:00 AM
gribozavr committed rL373068: Fixed indentation in a ClangTidy test.
Fixed indentation in a ClangTidy test
Fri, Sep 27, 4:00 AM
gribozavr committed rG69f9f20fc529: Moved -fblocks from an individual test to check_clang_tidy.py (authored by gribozavr).
Moved -fblocks from an individual test to check_clang_tidy.py
Fri, Sep 27, 4:00 AM
gribozavr committed rL373066: Moved -fblocks from an individual test to check_clang_tidy.py.
Moved -fblocks from an individual test to check_clang_tidy.py
Fri, Sep 27, 4:00 AM
gribozavr committed rG405c3a6be171: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non… (authored by gribozavr).
[clang-tidy] New check to warn when storing dispatch_once_t in non-static, non…
Fri, Sep 27, 3:51 AM
gribozavr committed rL373065: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non….
[clang-tidy] New check to warn when storing dispatch_once_t in non-static, non…
Fri, Sep 27, 3:51 AM
gribozavr closed D68109: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage..
Fri, Sep 27, 3:50 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 26

gribozavr committed rGda963abd5308: Revert "gn build: (manually) merge r373028" (authored by gribozavr).
Revert "gn build: (manually) merge r373028"
Thu, Sep 26, 4:31 PM
gribozavr committed rL373033: Revert "gn build: (manually) merge r373028".
Revert "gn build: (manually) merge r373028"
Thu, Sep 26, 4:31 PM
gribozavr committed rG847f4d3f6d7e: Revert "[clang-tidy] New check to warn when storing dispatch_once_t in non… (authored by gribozavr).
Revert "[clang-tidy] New check to warn when storing dispatch_once_t in non…
Thu, Sep 26, 4:31 PM
gribozavr committed rL373032: Revert "[clang-tidy] New check to warn when storing dispatch_once_t in non….
Revert "[clang-tidy] New check to warn when storing dispatch_once_t in non…
Thu, Sep 26, 4:31 PM
gribozavr added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

Sorry, I reverted it in r373032 because the test fails on Linux: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/18323 . Could you please take a look? Thanks!

Thu, Sep 26, 4:30 PM · Restricted Project, Restricted Project, Restricted Project
gribozavr added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

Sorry, could you rebase the patch to apply cleanly to master? Seems like someone else edited ReleaseNotes.rst in the meanwhile.

Thu, Sep 26, 12:50 PM · Restricted Project, Restricted Project, Restricted Project
gribozavr committed rGbb7a9dcd4282: Return results by value from ClangTidyCheckFactories::createChecks (authored by gribozavr).
Return results by value from ClangTidyCheckFactories::createChecks
Thu, Sep 26, 7:01 AM
gribozavr committed rL372979: Return results by value from ClangTidyCheckFactories::createChecks.
Return results by value from ClangTidyCheckFactories::createChecks
Thu, Sep 26, 6:53 AM
gribozavr committed rG5338ffcfa1d2: Use std::unique_ptr in ClangTidyCheckFactories (authored by gribozavr).
Use std::unique_ptr in ClangTidyCheckFactories
Thu, Sep 26, 6:47 AM
gribozavr committed rL372978: Use std::unique_ptr in ClangTidyCheckFactories.
Use std::unique_ptr in ClangTidyCheckFactories
Thu, Sep 26, 6:47 AM
gribozavr added a comment to D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads.

What is the expected contract of the functions that this checker flags? Are they supposed to perform unaligned reads correctly, and we have just an implementation bug in these functions, or is it the caller's fault if they pass an unaligned address?

Thu, Sep 26, 3:47 AM · Restricted Project
gribozavr added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

Thanks! Do you need me to commit the patch for you?

Thu, Sep 26, 3:38 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Sep 25

gribozavr accepted D67969: [libTooling] Add `run` combinator to Stencils..
Wed, Sep 25, 7:43 AM · Restricted Project, Restricted Project
gribozavr accepted D68026: [clang-tidy] Make llvm-header-guard work on llvm git monorepo.
Wed, Sep 25, 7:34 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D67969: [libTooling] Add `run` combinator to Stencils..
Wed, Sep 25, 5:49 AM · Restricted Project, Restricted Project
gribozavr accepted D67961: [libTooling] Introduce the MatchConsumer abstraction.
Wed, Sep 25, 5:15 AM · Restricted Project, Restricted Project

Mon, Sep 23

gribozavr updated subscribers of D67501: [clang-tidy] Fix relative path in header-filter..

I added a test in r372607 for your reference. It tests both foo/.. and symlink behavior.

Mon, Sep 23, 6:51 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr committed rG7964e8940999: Added a test for agreement between paths used in ClangTidy's diagnostics and… (authored by gribozavr).
Added a test for agreement between paths used in ClangTidy's diagnostics and…
Mon, Sep 23, 6:46 AM
gribozavr committed rL372607: Added a test for agreement between paths used in ClangTidy's diagnostics and….
Added a test for agreement between paths used in ClangTidy's diagnostics and…
Mon, Sep 23, 6:42 AM
gribozavr added a comment to D67501: [clang-tidy] Fix relative path in header-filter..

Sorry, I reverted this patch in r372601.

Mon, Sep 23, 6:07 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr committed rGddc9a06e95db: Revert "[clang-tidy] Fix relative path in header-filter." (authored by gribozavr).
Revert "[clang-tidy] Fix relative path in header-filter."
Mon, Sep 23, 6:07 AM
gribozavr committed rL372601: Revert "[clang-tidy] Fix relative path in header-filter.".
Revert "[clang-tidy] Fix relative path in header-filter."
Mon, Sep 23, 6:07 AM
gribozavr accepted D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops.

Thanks! Please let me know if you need me to commit the patch for you.

Mon, Sep 23, 5:38 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr committed rGbefcd660d294: Removed dead code from Stencil.h (authored by gribozavr).
Removed dead code from Stencil.h
Mon, Sep 23, 5:17 AM
gribozavr committed rL372594: Removed dead code from Stencil.h.
Removed dead code from Stencil.h
Mon, Sep 23, 5:17 AM
gribozavr committed rG04b34a20b9c5: Removed an incorred namespace-end comment (authored by gribozavr).
Removed an incorred namespace-end comment
Mon, Sep 23, 5:06 AM
gribozavr committed rL372593: Removed an incorred namespace-end comment.
Removed an incorred namespace-end comment
Mon, Sep 23, 5:06 AM
gribozavr accepted D67633: [libTooling] Add `access` and `ifBound` combinators to Stencil library..
Mon, Sep 23, 4:28 AM · Restricted Project, Restricted Project
gribozavr accepted D67632: [libTooling] Introduce new library of source-code builders..
Mon, Sep 23, 1:25 AM · Restricted Project, Restricted Project

Fri, Sep 20

gribozavr added inline comments to D67632: [libTooling] Introduce new library of source-code builders..
Fri, Sep 20, 11:37 AM · Restricted Project, Restricted Project
gribozavr committed rG4a13c828f6d7: [clang-tidy] Fix relative path in header-filter. (authored by gribozavr).
[clang-tidy] Fix relative path in header-filter.
Fri, Sep 20, 6:20 AM
gribozavr committed rL372388: [clang-tidy] Fix relative path in header-filter..
[clang-tidy] Fix relative path in header-filter.
Fri, Sep 20, 6:20 AM
gribozavr closed D67501: [clang-tidy] Fix relative path in header-filter..
Fri, Sep 20, 6:20 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr accepted D67621: [libTooling] Add `ifBound`, `elseBranch` RangeSelector combinators..
Fri, Sep 20, 6:08 AM · Restricted Project, Restricted Project
gribozavr accepted D67501: [clang-tidy] Fix relative path in header-filter..

Thanks! Please let me know if you need me to commit the patch for you.

Fri, Sep 20, 5:50 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr added inline comments to D67632: [libTooling] Introduce new library of source-code builders..
Fri, Sep 20, 5:50 AM · Restricted Project, Restricted Project
gribozavr added inline comments to D67501: [clang-tidy] Fix relative path in header-filter..
Fri, Sep 20, 1:58 AM · Restricted Project, Restricted Project, Restricted Project