Page MenuHomePhabricator

gribozavr2 (Dmitri Gribenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 31 2019, 10:15 AM (139 w, 4 d)

Recent Activity

Today

gribozavr2 accepted D129097: [clang][dataflow] Handle null pointers of type std::nullptr_t.
Tue, Jul 5, 5:48 AM · Restricted Project, Restricted Project

Wed, Jun 29

gribozavr2 accepted D128833: [clang][dataflow] Handle `for` statements without conditions.
Wed, Jun 29, 12:28 PM · Restricted Project, Restricted Project

Tue, Jun 28

gribozavr2 accepted D128352: [clang][dataflow] Use diagnosis API in optional checker.
Tue, Jun 28, 1:38 PM · Restricted Project, Restricted Project, Restricted Project
gribozavr2 accepted D127898: [clang][dataflow] Add API to separate analysis from diagnosis.
Tue, Jun 28, 1:31 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mon, Jun 27

gribozavr2 accepted D128658: [clang][dataflow] Do not allow substitution of true/false boolean literals in `buildAndSubstituteFlowCondition`.
Mon, Jun 27, 11:51 AM · Restricted Project, Restricted Project
gribozavr2 accepted D128659: [clang][dataflow] Add `buildAndSubstituteFlowCondition` to `DataflowEnvironment`.
Mon, Jun 27, 9:44 AM · Restricted Project, Restricted Project
gribozavr2 accepted D128056: [clang][dataflow] Singleton pointer values for null pointers..
Mon, Jun 27, 5:13 AM · Restricted Project, Restricted Project
gribozavr2 accepted D128056: [clang][dataflow] Singleton pointer values for null pointers..
Mon, Jun 27, 3:48 AM · Restricted Project, Restricted Project
gribozavr2 accepted D128363: [clang][dataflow] Implement functionality for flow condition variable substitution..
Mon, Jun 27, 2:17 AM · Restricted Project, Restricted Project
gribozavr2 accepted D128359: [clang][dataflow] Move logic for `createStorageLocation` from `DataflowEnvironment` to `DataflowAnalysisContext`..
Mon, Jun 27, 2:17 AM · Restricted Project, Restricted Project

Fri, Jun 24

gribozavr2 accepted D128359: [clang][dataflow] Move logic for `createStorageLocation` from `DataflowEnvironment` to `DataflowAnalysisContext`..
Fri, Jun 24, 7:06 PM · Restricted Project, Restricted Project
gribozavr2 accepted D128363: [clang][dataflow] Implement functionality for flow condition variable substitution..
Fri, Jun 24, 3:22 PM · Restricted Project, Restricted Project
gribozavr2 added a comment to D128556: Make Objective-C++ match Objective-C's behavior on implicit ivar access when `self` is shadowed.

Please add a test.

Fri, Jun 24, 3:13 PM · Restricted Project, Restricted Project
gribozavr2 accepted D128521: [clang][dataflow] Implement functionality to compare if two boolean values are equivalent..
Fri, Jun 24, 2:31 PM · Restricted Project, Restricted Project
gribozavr2 accepted D128520: [clang][dataflow] Refactor function that queries the solver for satisfiability checking..
Fri, Jun 24, 2:18 PM · Restricted Project, Restricted Project
gribozavr2 accepted D128519: [clang][dataflow] Move logic for creating implication and iff expressions into `DataflowAnalysisContext` from `DataflowEnvironment`..
Fri, Jun 24, 1:02 PM · Restricted Project, Restricted Project
gribozavr2 accepted D128357: [clang][dataflow] Store flow condition constraints in a single `FlowConditionConstraints` map..
Fri, Jun 24, 12:36 PM · Restricted Project, Restricted Project
gribozavr2 accepted D128533: [clang][dataflow] Allow MatchSwitch to return a value.
Fri, Jun 24, 7:33 AM · Restricted Project, Restricted Project
gribozavr2 accepted D128467: [clang][dataflow] Allow MatchSwitch to return a value.
Fri, Jun 24, 6:17 AM · Restricted Project, Restricted Project
gribozavr2 accepted D128446: [clang][dataflow] Use annotations for optional diagnostic tests.
Fri, Jun 24, 5:39 AM · Restricted Project, Restricted Project

Thu, Jun 23

gribozavr2 added inline comments to D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker .
Thu, Jun 23, 5:56 PM · Restricted Project, Restricted Project
gribozavr2 accepted D128406: clang: Tweak behaviour of warn_empty_while_body and warn_empty_if_body.
Thu, Jun 23, 5:21 PM · Restricted Project, Restricted Project
gribozavr2 accepted D128467: [clang][dataflow] Allow MatchSwitch to return a value.
Thu, Jun 23, 4:29 PM · Restricted Project, Restricted Project
gribozavr2 added inline comments to D127898: [clang][dataflow] Add API to separate analysis from diagnosis.
Thu, Jun 23, 10:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
gribozavr2 accepted D128356: [clang][dataflow] Use NoopLattice in optional model.
Thu, Jun 23, 9:14 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr2 accepted D128448: [clang][dataflow] Delete SourceLocationsLattice.
Thu, Jun 23, 9:13 AM · Restricted Project, Restricted Project, Restricted Project
gribozavr2 added inline comments to D127898: [clang][dataflow] Add API to separate analysis from diagnosis.
Thu, Jun 23, 9:12 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
gribozavr2 accepted D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker .
Thu, Jun 23, 7:45 AM · Restricted Project, Restricted Project

Wed, Jun 22

gribozavr2 added inline comments to D128363: [clang][dataflow] Implement functionality for flow condition variable substitution..
Wed, Jun 22, 11:53 AM · Restricted Project, Restricted Project

Mon, Jun 20

gribozavr2 accepted D128183: [clang][dataflow] Extend flow condition in the body of a do/while loop.
Mon, Jun 20, 10:15 AM · Restricted Project, Restricted Project
gribozavr2 accepted D128183: [clang][dataflow] Extend flow condition in the body of a do/while loop.
Mon, Jun 20, 8:01 AM · Restricted Project, Restricted Project

Fri, Jun 17

gribozavr2 accepted D128060: [clang][dataflow] Extend flow condition in the body of a for loop.
Fri, Jun 17, 7:43 AM · Restricted Project, Restricted Project

Wed, Jun 15

gribozavr2 added a comment to D127886: [clang-tidy] Allow access to the SourceManager in clang-tidy checks.

Could you provide more context? There seems to be plenty of ways to access the SourceManager from a ClangTidy check, for example, see clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp

Wed, Jun 15, 11:43 AM · Restricted Project, Restricted Project
gribozavr2 accepted D127865: [clang][dataflow] Make `Value` and `StorageLocation` non-copyable.
Wed, Jun 15, 9:15 AM · Restricted Project, Restricted Project

Tue, Jun 14

gribozavr2 accepted D127745: [clang][dataflow] Rename `getPointeeLoc` to `getReferentLoc` for ReferenceValue..
Tue, Jun 14, 3:40 PM · Restricted Project, Restricted Project

Wed, Jun 8

gribozavr2 accepted D127312: [clang][dataflow] Remove IndirectionValue class, moving PointeeLoc field into PointerValue and ReferenceValue.
Wed, Jun 8, 4:14 PM · Restricted Project, Restricted Project
gribozavr2 accepted D127196: [clang][dataflow] Enable use of synthetic properties on all Value instances..
Wed, Jun 8, 10:50 AM · Restricted Project, Restricted Project
gribozavr2 added inline comments to D127312: [clang][dataflow] Remove IndirectionValue class, moving PointeeLoc field into PointerValue and ReferenceValue.
Wed, Jun 8, 10:47 AM · Restricted Project, Restricted Project

Tue, Jun 7

gribozavr2 added inline comments to D127196: [clang][dataflow] Enable use of synthetic properties on all Value instances..
Tue, Jun 7, 7:01 AM · Restricted Project, Restricted Project

Mon, Jun 6

gribozavr2 added a reviewer for D127114: new clang-tidy checker for assignments within condition clause of if statement: aaron.ballman.
Mon, Jun 6, 8:50 AM · Restricted Project, Restricted Project
gribozavr2 added inline comments to D127114: new clang-tidy checker for assignments within condition clause of if statement.
Mon, Jun 6, 8:32 AM · Restricted Project, Restricted Project
gribozavr2 added inline comments to D127114: new clang-tidy checker for assignments within condition clause of if statement.
Mon, Jun 6, 7:55 AM · Restricted Project, Restricted Project

Jun 4 2022

gribozavr2 added a comment to D126973: [clang][dataflow] Relax assumption that `AggregateStorageLocations` correspond to struct type..

using the StructValue for its properties, while modeling a non-struct type.

Jun 4 2022, 7:44 AM · Restricted Project, Restricted Project

May 24 2022

gribozavr2 added inline comments to D126316: [clang][dataflow] Make limit on fixpoint-algorithm iterations proportional to size of CFG..
May 24 2022, 12:19 PM · Restricted Project, Restricted Project

May 20 2022

gribozavr2 accepted D126034: [clang-tidy] bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops.
May 20 2022, 9:51 AM · Restricted Project, Restricted Project, Restricted Project

May 19 2022

gribozavr2 accepted D126028: [bazel][libc] Fix bazel build.
May 19 2022, 3:47 PM · Restricted Project, Restricted Project

May 13 2022

gribozavr2 added reviewers for D124918: [clang-tidy] Add a new check for non-trivial unused variables.: ymandel, sgatev.
May 13 2022, 9:09 AM · Restricted Project, Restricted Project

May 12 2022

gribozavr2 accepted D125473: Comment parsing: Treat properties as zero-argument inline commands.

Nice!

May 12 2022, 12:38 PM · Restricted Project, Restricted Project
gribozavr2 accepted D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument.
May 12 2022, 10:10 AM · Restricted Project, Restricted Project
gribozavr2 accepted D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument.
May 12 2022, 4:22 AM · Restricted Project, Restricted Project

May 11 2022

gribozavr2 accepted D125422: Comment parsing: Specify argument numbers for some block commands.
May 11 2022, 4:09 PM · Restricted Project, Restricted Project

May 4 2022

gribozavr2 accepted D124952: [clang-tidy] Escape diagnostic messages before passing to `diag` in Transformer..
May 4 2022, 1:35 PM · Restricted Project, Restricted Project

May 3 2022

gribozavr2 accepted D124819: [bazel] Add test targets for dataflow framework.
May 3 2022, 6:43 AM · Restricted Project, Restricted Project
gribozavr2 requested changes to D124819: [bazel] Add test targets for dataflow framework.

Please fix the pre-merge check error:

May 3 2022, 1:40 AM · Restricted Project, Restricted Project

Apr 28 2022

gribozavr2 accepted D123059: re-roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable""."".
Apr 28 2022, 5:03 AM · Restricted Project, Restricted Project

Mar 16 2022

gribozavr2 added inline comments to D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality.
Mar 16 2022, 7:08 AM · Restricted Project, Restricted Project
gribozavr2 added inline comments to D121796: [clang][dataflow] Add an API for dataflow "models" -- reusable analysis components..
Mar 16 2022, 6:57 AM · Restricted Project, Restricted Project

Mar 9 2022

gribozavr2 accepted D121285: [clang][dataflow] Move dataflow testing support out of unittests.
Mar 9 2022, 5:28 AM · Restricted Project, Restricted Project

Mar 5 2022

gribozavr2 added a comment to D114231: [clang][docs][dataflow] Added an introduction to dataflow analysis.

Did you add somewhere what dependency we need in order to build the documentation now as mine is having problems with "recommonmark"

Mar 5 2022, 10:17 AM · Restricted Project, Restricted Project

Feb 4 2022

gribozavr2 accepted D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable""..

Approving the delta for the PS4 fix (relying or @rsmith 's approval for the actual patch -- https://reviews.llvm.org/D114732).

Feb 4 2022, 10:01 AM · Restricted Project, Restricted Project

Feb 3 2022

gribozavr2 added a comment to D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

I rolled it back while @devin.jeanpierre investigates.

Feb 3 2022, 1:37 PM · Restricted Project

Jan 25 2022

gribozavr2 accepted D116377: [libTooling] Adds more support for constructing object access expressions..
Jan 25 2022, 10:23 AM · Restricted Project, Restricted Project

Jan 20 2022

gribozavr2 accepted D117579: Add assert on End iteration distance to Rewriter::getRewrittenText..
Jan 20 2022, 11:28 AM · Restricted Project
gribozavr2 added a comment to D117304: [clang][dataflow] Remove TestingSupport's dependency on gtest.

Why does it matter what version outside users are using -- these are clang unit-tests, not a public API, right?

Jan 20 2022, 9:09 AM · Restricted Project

Jan 17 2022

gribozavr2 added inline comments to D116377: [libTooling] Adds more support for constructing object access expressions..
Jan 17 2022, 8:34 AM · Restricted Project, Restricted Project
gribozavr2 accepted D116377: [libTooling] Adds more support for constructing object access expressions..
Jan 17 2022, 1:52 AM · Restricted Project, Restricted Project

Jan 16 2022

gribozavr2 accepted D117304: [clang][dataflow] Remove TestingSupport's dependency on gtest.
Jan 16 2022, 1:58 PM · Restricted Project

Jan 14 2022

gribozavr2 accepted D116186: Comment parsing: Simplify Lexer::skipLineStartingDecorations (NFC).

Nice simplification, thank you!

Jan 14 2022, 9:20 AM · Restricted Project
gribozavr2 accepted D116190: Comment parsing: Don't recognize commands in single-line double quotation.
Jan 14 2022, 9:12 AM · Restricted Project

Jan 12 2022

gribozavr2 added inline comments to D116190: Comment parsing: Don't recognize commands in single-line double quotation.
Jan 12 2022, 10:14 AM · Restricted Project

Dec 22 2021

gribozavr2 added inline comments to D116022: [clang][dataflow] Add support for noreturn destructor calls.
Dec 22 2021, 9:28 AM · Restricted Project
gribozavr2 accepted D116022: [clang][dataflow] Add support for noreturn destructor calls.
Dec 22 2021, 9:22 AM · Restricted Project

Dec 21 2021

gribozavr2 added a comment to D116022: [clang][dataflow] Add support for noreturn destructor calls.

How resilient is this pattern matching?

Dec 21 2021, 12:53 PM · Restricted Project
gribozavr2 added inline comments to D116022: [clang][dataflow] Add support for noreturn destructor calls.
Dec 21 2021, 12:30 PM · Restricted Project

Dec 14 2021

gribozavr2 accepted D115733: [benchmark] Delete BUILD files.

Could you also delete BUILD.bazel files?

Dec 14 2021, 8:10 AM · Restricted Project
gribozavr2 closed D115721: [Bazel] Add build and test targets for Debuginfod.

Ben won the race:

Dec 14 2021, 4:55 AM · Restricted Project

Dec 10 2021

gribozavr2 accepted D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis.
Dec 10 2021, 1:39 AM · Restricted Project

Dec 9 2021

gribozavr2 accepted D115341: [clang][dataflow] Add framework for testing analyses..
Dec 9 2021, 11:49 AM · Restricted Project, Restricted Project

Dec 7 2021

gribozavr2 added a comment to D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis.

LGTM but deferring approval to @xazax.hun .

Dec 7 2021, 8:37 AM · Restricted Project

Dec 6 2021

gribozavr2 added inline comments to D114231: [clang][docs][dataflow] Added an introduction to dataflow analysis.
Dec 6 2021, 2:59 AM · Restricted Project, Restricted Project

Dec 2 2021

gribozavr2 accepted D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals..
Dec 2 2021, 3:29 PM · Restricted Project
gribozavr2 accepted D114981: [clang-tidy] Allow disabling support for NOLINTBEGIN/NOLINTEND blocks..

Thank you for a quick workaround!

Dec 2 2021, 2:04 PM · Restricted Project

Nov 29 2021

gribozavr2 accepted D114721: [clang][dataflow] Add unit tests for PostOrderCFGView.
Nov 29 2021, 11:46 AM · Restricted Project
gribozavr2 added inline comments to D114231: [clang][docs][dataflow] Added an introduction to dataflow analysis.
Nov 29 2021, 5:51 AM · Restricted Project, Restricted Project

Nov 26 2021

gribozavr2 accepted D114234: [clang][dataflow] Add base types for building dataflow analyses.
Nov 26 2021, 5:50 AM · Restricted Project

Nov 19 2021

gribozavr2 added reviewers for D114231: [clang][docs][dataflow] Added an introduction to dataflow analysis: ymandel, NoQ, Szelethus, xazax.hun.
Nov 19 2021, 3:24 AM · Restricted Project, Restricted Project

Nov 17 2021

gribozavr2 accepted D114011: Add a clang-transformer tutorial.
Nov 17 2021, 5:08 AM · Restricted Project
gribozavr2 added a comment to D113795: Comment Sema: Eliminate or factor out DeclInfo inspection (NFC).

Sorry, here I also find the old code to be more readable.

Nov 17 2021, 4:11 AM · Restricted Project
gribozavr2 added a comment to D113793: Comment Sema: Run checks only when appropriate (NFC).

I find the code more readable and robust when the check* function checks its applicability itself. After this refactoring, it is not so clear when each check functions applies, what are the correct conditions to call them. To ensure correct usage, probably we should be adding equivalent asserts to the beginning of each function; at which point I'm not sure if the new code is better.

Nov 17 2021, 4:03 AM · Restricted Project, Restricted Project
gribozavr2 accepted D113794: Comment Sema: Use Name from CommandInfo for HeaderDoc diagnostics (NFC).
Nov 17 2021, 3:32 AM · Restricted Project

Nov 12 2021

gribozavr2 accepted D113690: Comment AST: Find out if function is variadic in DeclInfo::fill.
Nov 12 2021, 8:30 AM · Restricted Project
gribozavr2 added a comment to D113690: Comment AST: Find out if function is variadic in DeclInfo::fill.

Thank you for the cleanup!

Nov 12 2021, 8:30 AM · Restricted Project
gribozavr2 accepted D113691: Comment AST: Recognize function-like objects via return type (NFC).

Nice, thanks!

Nov 12 2021, 8:07 AM · Restricted Project

Nov 8 2021

gribozavr2 accepted D111266: Comment AST: Add support for variable templates.
Nov 8 2021, 3:58 AM · Restricted Project
gribozavr2 accepted D111264: Comment AST: Declare function pointer variables as functions.

I feel uneasy about claiming that variable decls of function type are FunctionKind for the purposes of comment parsing (even doing it for typedefs is questionable). It seems like a better way would be to make "is function like" an extra dimension that can be combined with any decl kind.

Nov 8 2021, 3:50 AM · Restricted Project
gribozavr2 accepted D111262: Comment AST: Factor out function type extraction in DeclInfo::fill (NFC).
Nov 8 2021, 2:44 AM · Restricted Project
gribozavr2 accepted D111190: Comment parsing: Complete list of Doxygen commands.

Sorry for the delayed response! LGTM modulo the unit test comment. Please let me know if you don't have commit access and you need me to push on your behalf.

Nov 8 2021, 2:34 AM · Restricted Project

Oct 15 2021

gribozavr2 accepted D111876: Adds //mlir:GPUTransforms dependency to //llvm:MC as the former includes headers from the latter..
Oct 15 2021, 4:25 AM · Restricted Project

Aug 27 2021

gribozavr2 added a comment to D108808: [clang-tidy] bugprone-infinite-loop: Fix false positives with volatile addresses..

What happens for something like the following? Maybe it's also worth a test case?

Aug 27 2021, 1:47 AM · Restricted Project
gribozavr2 accepted D108808: [clang-tidy] bugprone-infinite-loop: Fix false positives with volatile addresses..
Aug 27 2021, 1:46 AM · Restricted Project