# Projects

User does not belong to any projects.

# User Details

User Since
Oct 31 2019, 10:15 AM (16 w, 6 d)

# Yesterday

Tue, Feb 25, 8:08 AM · Restricted Project

# Mon, Feb 24

Mon, Feb 24, 11:30 PM · Restricted Project
Mon, Feb 24, 11:30 PM · Restricted Project
Mon, Feb 24, 5:46 AM · Restricted Project
Mon, Feb 24, 5:37 AM · Restricted Project

# Fri, Feb 21

Fri, Feb 21, 8:32 AM · Restricted Project

# Thu, Feb 20

Thu, Feb 20, 11:29 PM · Restricted Project, Restricted Project

# Tue, Feb 18

Tue, Feb 18, 6:14 AM · Restricted Project

# Wed, Feb 12

Wed, Feb 12, 4:05 AM · Restricted Project

# Mon, Feb 10

Mon, Feb 10, 11:37 PM · Restricted Project, Restricted Project

# Tue, Feb 4

Tue, Feb 4, 8:04 AM · Restricted Project

# Mon, Feb 3

Mon, Feb 3, 2:45 AM · Restricted Project

# Thu, Jan 30

Thu, Jan 30, 1:21 AM · Restricted Project

# Jan 27 2020

Jan 27 2020, 6:58 AM · Restricted Project, Restricted Project

LGTM with fixes to the test.

Jan 27 2020, 4:14 AM · Restricted Project, Restricted Project
Jan 27 2020, 4:05 AM · Restricted Project, Restricted Project

Thank you for the contribution! I didn't review the code thoroughly yet, only the tests.

Jan 27 2020, 2:43 AM · Restricted Project, Restricted Project
gribozavr2 added a comment to D71966: [Wdocumentation][RFC] Improve identifier's of \param.

So if I understand correctly:

• getParamNameAsWritten will become getArgText
• The getParamName will do the translation from the name in the documentation to the name in the current function declaration. If the parameter index is invalid the function will fail (with an assertion error) and not fallback to call getArgText.
Jan 27 2020, 2:18 AM · Restricted Project
gribozavr2 added inline comments to D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator.
Jan 27 2020, 2:15 AM · Restricted Project, Restricted Project
gribozavr2 added a comment to D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop.

Please talk to Hans Wennborg <hwennborg@google.com> about cherry-picking this change into the release. I think it is a safe change, if Hans needs that sort of review from someone.

Jan 27 2020, 2:15 AM · Restricted Project, Restricted Project

# Jan 26 2020

gribozavr2 added inline comments to D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator.
Jan 26 2020, 11:27 PM · Restricted Project, Restricted Project

# Jan 24 2020

gribozavr2 added a comment to D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop.

May not be one for this patch, but how does this check handle volatile loop variables and cases where modification isn't visible in the context e.g.

Jan 24 2020, 8:24 AM · Restricted Project, Restricted Project

LGTM! Please commit if you have commit access, or let me know if I should push it for you.

Jan 24 2020, 8:04 AM · Restricted Project, Restricted Project
Jan 24 2020, 4:26 AM · Restricted Project
Jan 24 2020, 1:59 AM · Restricted Project, Restricted Project

# Jan 23 2020

gribozavr2 added inline comments to D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop.
Jan 23 2020, 11:14 AM · Restricted Project, Restricted Project
gribozavr2 added inline comments to D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop.
Jan 23 2020, 9:25 AM · Restricted Project, Restricted Project

# Jan 22 2020

I'd also appreciate if you updated the docs for the changes done in this patch.

Jan 22 2020, 9:09 AM · Restricted Project

Sorry, just getting back to this review. Your justification makes sense, and the patch LGTM.

Jan 22 2020, 3:32 AM · Restricted Project
Jan 22 2020, 1:27 AM · Restricted Project

# Jan 21 2020

Let me know if you want me to commit this change for you.

Jan 21 2020, 2:56 AM · Restricted Project, Restricted Project
Jan 21 2020, 2:56 AM · Restricted Project, Restricted Project

# Jan 17 2020

gribozavr2 added a comment to rG12e479475a89: Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot.

Sorry, no, it broke it in a different way:

gribozavr2 added a comment to rG12e479475a89: Rename DW_AT_LLVM_isysroot to DW_AT_LLVM_sysroot.

Jan 17 2020, 8:55 AM · Restricted Project

The only functional change that I see in this patch is in clang/lib/Tooling/Transformer/Stencil.cpp. However, I don't understand how that change in the (deprecated) selection() stencil can affect other stencils.

Good point. Actually, selection and text are still used internally. See, for example, lines 301-303 in Stencil.cpp. We deprecated their use for clients.

Jan 17 2020, 8:25 AM · Restricted Project
gribozavr2 added a comment to D72274: [libTooling] Fix bug in Stencil handling of macro ranges.

The only functional change that I see in this patch is in clang/lib/Tooling/Transformer/Stencil.cpp. However, I don't understand how that change in the (deprecated) selection() stencil can affect other stencils.

Jan 17 2020, 7:09 AM · Restricted Project

Since I seem to be in the minority about thinking that this check does not pull its weight, I reviewed the code, and will LGTM and push once the few small issues are fixed.

Jan 17 2020, 5:32 AM · Restricted Project, Restricted Project

Thank you for factoring our this library!

Jan 17 2020, 5:13 AM · Restricted Project
gribozavr2 added a comment to D72682: Avoid creating an immutable map in the Automaton class..

This change broke buildbots and I reverted it in 10b4aece528936bb7f75a9758ae95c61b6434d2f.

Jan 17 2020, 1:24 AM · Restricted Project

# Jan 16 2020

Jan 16 2020, 7:05 AM · Restricted Project

A test would be nice, but we don't have infrastructure for checking call ordering.

Jan 16 2020, 4:28 AM · Restricted Project

# Jan 15 2020

gribozavr2 added inline comments to D72073: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc.
Jan 15 2020, 12:32 PM · Restricted Project
gribozavr2 added inline comments to D72334: [Syntax] Build nodes for template declarations..
Jan 15 2020, 12:23 PM · Restricted Project
Jan 15 2020, 12:23 PM · Restricted Project

# Jan 14 2020

Jan 14 2020, 10:04 AM · Restricted Project
gribozavr2 added a comment to D71966: [Wdocumentation][RFC] Improve identifier's of \param.

Thank you for the patch!

Jan 14 2020, 6:26 AM · Restricted Project

# Jan 2 2020

Could you provide a more fleshed out example of a case where it is useful?

Jan 2 2020, 12:21 PM · Restricted Project

# Dec 30 2019

gribozavr2 added inline comments to D71842: Allow newlines in AST Matchers in clang-query files.
Dec 30 2019, 7:26 AM · Restricted Project
gribozavr2 added a comment to D71363: [MIPS GlobalISel] Select bitreverse.

This change broke buildbots: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/21066.

Dec 30 2019, 5:33 AM · Restricted Project

# Dec 20 2019

gribozavr2 added a comment to D64573: [Syntax] Allow to mutate syntax trees.

@Ka-Ka Thanks for bringing it to our attention! I fixed these warnings in:

Dec 20 2019, 5:48 AM · Restricted Project

# Dec 19 2019

gribozavr2 added a comment to D71670: Support powerpc when builing without init_array..

Sorry, I reverted this change because it broke the build on aarch64. https://github.com/llvm/llvm-project/commit/0109efe7513dd984cf67d102ce5179a5b24d58f6

Dec 19 2019, 2:39 AM · Restricted Project, Restricted Project

# Dec 18 2019

I believe this commit broke the expensive checks bot. Could you take a look?

Dec 18 2019, 8:18 AM · Restricted Project

Updated version LGTM, thanks!

Dec 18 2019, 5:46 AM · Restricted Project
gribozavr2 added a comment to D69223: WDocumentation: Implement the \anchor..

LGTM, feel free to push.

Dec 18 2019, 5:27 AM · Restricted Project
gribozavr2 added a comment to D64573: [Syntax] Allow to mutate syntax trees.

Updated version LGTM, thanks!

Dec 18 2019, 5:18 AM · Restricted Project

# Dec 16 2019

Sorry, I reverted this change in 079ef783dd5530b5f87beefe624b9179547ded7e. The tests depend on builtin headers, which is not intentionally supported in clangd tests; these tests are broken in some build environments.

Dec 16 2019, 6:33 AM · Restricted Project

# Dec 13 2019

Generally looks good, just nitpicks.

Dec 13 2019, 8:33 AM · Restricted Project
gribozavr2 added a comment to D71466: [ARM][MVE][Intrinsics] remove extraneous intrinsics..

I reverted this change in 34536db7bbe0b8c5f8ffa70df307312b451aca2e. This change didn't compile: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/20462. Please always run ninja check-all before pushing.

Dec 13 2019, 8:24 AM · Restricted Project

# Dec 9 2019

Dec 9 2019, 2:17 PM · Restricted Project
Dec 9 2019, 2:17 PM · Restricted Project

Dec 9 2019, 5:58 AM · Restricted Project
Dec 9 2019, 5:45 AM · Restricted Project
Dec 9 2019, 5:40 AM · Restricted Project

# Dec 4 2019

With such logic, Clang-tidy is maintenance burden: 368 unaddressed request in Bugzilla is very telling.

Dec 4 2019, 11:27 AM · Restricted Project, Restricted Project
Dec 4 2019, 10:59 AM · Restricted Project

@alexfh, @gribozavr2, @aaron.ballman I think the best way out here is just to implement the basic fix for the above problem and only allow to use macro definition in closing comment and skip checking macro expansions completely. If you agree I will provide a patch for that.

Dec 4 2019, 10:59 AM · Restricted Project, Restricted Project

ASan can help debug this issue, and more.

ASan is too heavyweight for this simple problem. It does not point out the source of the issue as quickly as this simple check which also provides a fix. ASan is meant for the less trivial cases. Is this really such a performance hit? Clang-Tidy already contains lots of checks which target a very narrow pattern.

Dec 4 2019, 10:50 AM · Restricted Project, Restricted Project

ASan can help debug this issue, and more.

This is dynamic analysis, and detection of problem depends on test case. Detection of such problem during static analysis makes sense.

Dec 4 2019, 7:58 AM · Restricted Project, Restricted Project

I'm not convinced this feature is worth implementing at all, because there's a good alternative to a macro here -- a namespace alias. What is the reason to use a macro instead of a namespace alias?

While I think that's a superior solution to using macros, some users have macros instead. This fixes a bug reported in https://bugs.llvm.org/show_bug.cgi?id=26274 and I agree that the behavior described in that bug is not what I would expect it to be.

Dec 4 2019, 7:58 AM · Restricted Project

Is this a common problem? There's a lot of silly code we could try to find, but if people don't actually write it, then we get all downsides of maintenance without the benefits of the checker.

Oh yes, all our checkers are developed upon user request. They only request it if they find out their developers write such silly code.

Dec 4 2019, 7:39 AM · Restricted Project, Restricted Project
Dec 4 2019, 6:43 AM · Restricted Project, Restricted Project

Is this a common problem? There's a lot of silly code we could try to find, but if people don't actually write it, then we get all downsides of maintenance without the benefits of the checker.

Dec 4 2019, 6:35 AM · Restricted Project, Restricted Project
gribozavr2 added a reviewer for D70974: [clang-tidy] Fix PR26274: gribozavr2.

I'm not convinced this feature is worth implementing at all, because there's a good alternative to a macro here -- a namespace alias. What is the reason to use a macro instead of a namespace alias?

Dec 4 2019, 6:34 AM · Restricted Project

# Dec 3 2019

@twardakm: I'm not convinced this feature is worth implementing at all, because there's a good alternative to a macro here -- a namespace alias. What is the reason to use a macro instead of a namespace alias?

Dec 3 2019, 2:46 PM · Restricted Project, Restricted Project

With that last comment, LGTM. Do you have commit access?

Dec 3 2019, 4:41 AM · Restricted Project
Dec 3 2019, 4:14 AM · Restricted Project, Restricted Project

# Dec 2 2019

Dec 2 2019, 12:09 PM · Restricted Project
Dec 2 2019, 2:05 AM · Restricted Project
gribozavr2 added a comment to D69223: WDocumentation: Implement the \anchor..

A few more comments, but generally looks good!

Dec 2 2019, 1:28 AM · Restricted Project

# Nov 29 2019

Nov 29 2019, 2:31 AM · Restricted Project

# Nov 27 2019

Nov 27 2019, 12:05 AM · Restricted Project

# Nov 22 2019

gribozavr2 added a comment to D45890: [OMPT] Add implementation and tests of Archer tool.

Thank you very much for the quick workaround!

Nov 22 2019, 9:31 AM · Restricted Project
Nov 22 2019, 7:18 AM · Restricted Project
gribozavr2 added inline comments to D70554: [libTooling] Add stencil combinators for nodes that may be pointers or values..
Nov 22 2019, 7:18 AM · Restricted Project
gribozavr2 added a comment to D45890: [OMPT] Add implementation and tests of Archer tool.
• the tests rely on the availability of thread-sanitizer
Nov 22 2019, 7:18 AM · Restricted Project
gribozavr2 added a comment to D45890: [OMPT] Add implementation and tests of Archer tool.
• MOST important: we should make the sanitizers available in the build-bot
Nov 22 2019, 7:18 AM · Restricted Project
gribozavr2 added a comment to D69932: [IR] Redefine Freeze instruction.

Sorry for the delayed response, but the OCaml test is failing: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/19714/steps/test-check-all/logs/stdio

Nov 22 2019, 4:25 AM · Restricted Project
gribozavr2 added a reviewer for D69223: WDocumentation: Implement the \anchor.: gribozavr2.
Nov 22 2019, 4:16 AM · Restricted Project
gribozavr2 added a comment to D69223: WDocumentation: Implement the \anchor..

Thank you for the contribution and sorry for the review delay!

Nov 22 2019, 4:16 AM · Restricted Project
gribozavr2 added a comment to D45890: [OMPT] Add implementation and tests of Archer tool.

The newly added tests fail on buildbots: http://lab.llvm.org:8011/builders/openmp-gcc-x86_64-linux-debian/builds/236

Nov 22 2019, 2:52 AM · Restricted Project

This patch introduces a way to apply the fix-its by the Analyzer:

Nov 22 2019, 2:42 AM · Restricted Project
Nov 22 2019, 2:37 AM · Restricted Project

# Nov 21 2019

gribozavr2 added a comment to D69354: Make coding standards document more inclusive.

@chandlerc has LGTM'ed this patch over chat.

Nov 21 2019, 4:12 AM · Restricted Project

# Nov 19 2019

hence not throwing the warning on any platform?

The way I read the buildbot breakage, an existing ClangTidy test passed before and after this change, but broke on Windows. The breakage was that the warnings stopped being produced.

The existing test does not have this warning. I modified the test to add the check for this warning since it is generated on Linux after my patch. It is not generated on Windows because of delayed template parsing.

Nov 19 2019, 10:24 AM · Restricted Project
gribozavr2 added inline comments to D69354: Make coding standards document more inclusive.
Nov 19 2019, 10:24 AM · Restricted Project

hence not throwing the warning on any platform?

Nov 19 2019, 8:43 AM · Restricted Project
Nov 19 2019, 8:24 AM · Restricted Project