Page MenuHomePhabricator

gribozavr2 (Dmitri Gribenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 31 2019, 10:15 AM (47 w, 11 h)

Recent Activity

Tue, Sep 22

gribozavr2 accepted D87839: [SyntaxTree] Test the List API.
Tue, Sep 22, 9:31 AM · Restricted Project
gribozavr2 added inline comments to D87839: [SyntaxTree] Test the List API.
Tue, Sep 22, 6:12 AM · Restricted Project
gribozavr2 accepted D88077: [SyntaxTree] Add tests for the assignment of the `canModify` tag..
Tue, Sep 22, 6:00 AM · Restricted Project
gribozavr2 accepted D88034: [SyntaxTree][Synthesis] Fix: `deepCopy` -> `deepCopyExpandingMacros`..
Tue, Sep 22, 1:31 AM · Restricted Project

Mon, Sep 21

gribozavr2 accepted D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`.
Mon, Sep 21, 10:15 AM · Restricted Project
gribozavr2 accepted D88024: [SyntaxTree][Nit] Take `ArrayRef` instead of `std::vector` as argument for `createTree`.
Mon, Sep 21, 10:09 AM · Restricted Project
gribozavr2 accepted D88004: [SyntaxTree][NFC] follow naming convention + remove auto on empty vector declaration.
Mon, Sep 21, 2:57 AM · Restricted Project
gribozavr2 added inline comments to D87749: [SyntaxTree][Synthesis] Implement `deepCopy`.
Mon, Sep 21, 2:56 AM · Restricted Project
gribozavr2 added inline comments to D87749: [SyntaxTree][Synthesis] Implement `deepCopy`.
Mon, Sep 21, 12:26 AM · Restricted Project

Fri, Sep 18

gribozavr2 added inline comments to D87720: Sema: add support for `__attribute__((__swift_private__))`.
Fri, Sep 18, 2:32 PM · Restricted Project
gribozavr2 added inline comments to D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`.
Fri, Sep 18, 2:26 PM · Restricted Project
gribozavr2 accepted D87534: Sema: introduce `__attribute__((__swift_name__))`.

This introduces the new swift_name attribute that allows annotating
interfaces with an alternate spelling for Swift. This is used as part
of the importing mechanism to allow interfaces to be imported with a new

Fri, Sep 18, 2:10 PM · Restricted Project
gribozavr2 accepted D87896: [SyntaxTree][Synthesis] Improve testing `createLeaf`.
Fri, Sep 18, 4:37 AM · Restricted Project
gribozavr2 accepted D87895: [SyntaxTree] Test for '\' inside token..
Fri, Sep 18, 4:36 AM · Restricted Project

Thu, Sep 17

gribozavr2 accepted D87749: [SyntaxTree][Synthesis] Implement `deepCopy`.
Thu, Sep 17, 12:47 PM · Restricted Project
gribozavr2 accepted D87820: [SyntaxTree][Synthesis] Fix allocation in `createTree` for more general use.
Thu, Sep 17, 5:54 AM · Restricted Project

Tue, Sep 15

gribozavr2 added a comment to D87683: [clang-tidy] Crash fix for bugprone-misplaced-pointer-arithmetic-in-alloc.

Please fix the test case first, can't call operator new(unsigned long, void*) with an argument of type void*
The other failures the pre merge bot detected can safely be disregarded

Placement new is defined per standard:

void* operator new  ( std::size_t count, void* ptr );

Here, the problem is that size_t is unsigned long on Linux and it seems that it is unsigned long long on Windows. How should I overcome this?

In CSA, to overcome the platform problem, it is common to add a target triple for the RUN line:
https://github.com/llvm/llvm-project/blob/master/clang/test/Analysis/std-c-library-functions.c#L14

Tue, Sep 15, 11:33 AM · Restricted Project, Restricted Project

Mon, Sep 14

gribozavr2 accepted D87600: [SyntaxTree][List] `assertInvariants` for `List`s.
Mon, Sep 14, 1:53 AM · Restricted Project
gribozavr2 accepted D87599: [SyntaxTree] Provide `List::classof`.
Mon, Sep 14, 1:49 AM · Restricted Project
gribozavr2 accepted D87598: [SyntaxTree][List] Fix: `ParameterDeclarationList` is the `List` inside `ParametersAndQualifiers`.
Mon, Sep 14, 1:49 AM · Restricted Project

Fri, Sep 11

gribozavr2 added a comment to D87482: Fix clang Wrange-loop-analysis in BuildTree.cpp.

Sorry, I didn't realize you don't have commit access. Pushed this patch to git, thanks for the contribution!

Fri, Sep 11, 4:10 PM · Restricted Project
gribozavr2 accepted D87395: Sema: add support for `__attribute__((__swift_objc_members__))`.

LGTM!

Fri, Sep 11, 3:35 PM · Restricted Project
gribozavr2 accepted D87533: [SyntaxTree][Synthesis] Add support for Tree..
Fri, Sep 11, 11:52 AM · Restricted Project
gribozavr2 accepted D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump.
Fri, Sep 11, 11:26 AM · Restricted Project
gribozavr2 accepted D87522: [SyntaxTree] Add const qualifiers, from [llvm-qualified-auto].
Fri, Sep 11, 10:54 AM · Restricted Project
gribozavr2 added reviewers for D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`: ymandel, gribozavr2.
Fri, Sep 11, 10:52 AM · Restricted Project
gribozavr2 accepted D87523: [SyntaxTree] Reduce visibility of `Arena::lexBuffer`..
Fri, Sep 11, 10:51 AM · Restricted Project
gribozavr2 accepted D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump.
Fri, Sep 11, 10:46 AM · Restricted Project
gribozavr2 added inline comments to D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump.
Fri, Sep 11, 5:51 AM · Restricted Project
gribozavr2 accepted D87498: [SyntaxTree][NFC] Rename functions to start with verb.
Fri, Sep 11, 2:21 AM · Restricted Project
gribozavr2 added inline comments to D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump.
Fri, Sep 11, 1:58 AM · Restricted Project

Thu, Sep 10

gribozavr2 added inline comments to D87395: Sema: add support for `__attribute__((__swift_objc_members__))`.
Thu, Sep 10, 5:23 PM · Restricted Project
gribozavr2 accepted D87482: Fix clang Wrange-loop-analysis in BuildTree.cpp.
Thu, Sep 10, 2:29 PM · Restricted Project
gribozavr2 accepted D87409: [libTooling] Fix use of `char` in comparison..
Thu, Sep 10, 2:24 PM · Restricted Project
gribozavr2 added inline comments to D87395: Sema: add support for `__attribute__((__swift_objc_members__))`.
Thu, Sep 10, 1:10 PM · Restricted Project
gribozavr2 added inline comments to D87395: Sema: add support for `__attribute__((__swift_objc_members__))`.
Thu, Sep 10, 12:57 PM · Restricted Project
gribozavr2 added inline comments to D87395: Sema: add support for `__attribute__((__swift_objc_members__))`.
Thu, Sep 10, 12:56 PM · Restricted Project
gribozavr2 accepted D87331: Sema: add support for `__attribute__((__swift_error__))`.
Thu, Sep 10, 4:28 AM · Restricted Project
gribozavr2 added inline comments to D87395: Sema: add support for `__attribute__((__swift_objc_members__))`.
Thu, Sep 10, 4:22 AM · Restricted Project
gribozavr2 accepted D87374: [SyntaxTree] Specialize `TreeTestBase` for `BuildTreeTest` and `MutationsTest`.
Thu, Sep 10, 1:50 AM · Restricted Project

Tue, Sep 8

gribozavr2 accepted D87278: [Ignore Expressions] Fix performance regression by inlining `Ignore*SingleStep`.
Tue, Sep 8, 6:43 AM · Restricted Project
gribozavr2 accepted D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`.
Tue, Sep 8, 1:38 AM · Restricted Project

Mon, Sep 7

gribozavr2 accepted D87249: [SyntaxTree] Fix crash on functions with default arguments..
Mon, Sep 7, 11:43 PM · Restricted Project
gribozavr2 added a comment to D87249: [SyntaxTree] Fix crash on functions with default arguments..

Please also add tests for calls to constructors without arguments and calls to implicit constructors 1 argument, as requested in https://reviews.llvm.org/D86700.

Mon, Sep 7, 11:55 AM · Restricted Project
gribozavr2 added inline comments to D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`.
Mon, Sep 7, 11:54 AM · Restricted Project
gribozavr2 accepted D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`.
Mon, Sep 7, 10:30 AM · Restricted Project
gribozavr2 accepted D87229: [SyntaxTree] Ignore implicit `CXXFunctionalCastExpr` wrapping constructor.
Mon, Sep 7, 9:12 AM · Restricted Project
gribozavr2 accepted D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`.
Mon, Sep 7, 9:11 AM · Restricted Project

Thu, Sep 3

gribozavr2 added inline comments to D87031: [libTooling] Provide overloads of `rewriteDescendants` that operate directly on an AST node..
Thu, Sep 3, 11:32 AM · Restricted Project

Wed, Sep 2

gribozavr2 accepted D87031: [libTooling] Provide overloads of `rewriteDescendants` that operate directly on an AST node..
Wed, Sep 2, 4:30 PM · Restricted Project
gribozavr2 accepted D87048: [libTooling] Restore defaults for matchers in makeRule..
Wed, Sep 2, 12:11 PM · Restricted Project

Tue, Sep 1

gribozavr2 accepted D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`.
Tue, Sep 1, 2:18 AM · Restricted Project

Mon, Aug 31

gribozavr2 accepted D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`.
Mon, Aug 31, 12:31 PM · Restricted Project
gribozavr2 accepted D86700: [SyntaxTree] Ignore leaf implicit `CXXConstructExpr`.
Mon, Aug 31, 12:24 PM · Restricted Project
gribozavr2 accepted D86778: Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`.
Mon, Aug 31, 9:20 AM · Restricted Project
gribozavr2 accepted D86880: [Ignore Expressions][NFC] Refactor to better use `IgnoreExpr.h` and nits.
Mon, Aug 31, 9:16 AM · Restricted Project

Fri, Aug 28

gribozavr2 accepted D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class.
Fri, Aug 28, 5:23 AM · Restricted Project
gribozavr2 added a comment to D86778: Extract infrastructure to ignore intermediate expressions into `clang/AST/IgnoreExpr.h`.

This allows users to use IgnoreExprNodes outside of clang/AST/Expr.h

Fri, Aug 28, 5:13 AM · Restricted Project
gribozavr2 accepted D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class.
Fri, Aug 28, 4:05 AM · Restricted Project

Thu, Aug 27

gribozavr2 added a comment to D85214: [OpenMP] Ensure testing for versions 4.5 and default - Part 3.
Thu, Aug 27, 4:15 PM · Restricted Project
gribozavr2 added a comment to D85214: [OpenMP] Ensure testing for versions 4.5 and default - Part 3.

@saiislam This change seems to have broken a buildbot, please take a look at your earliest convenience.

Thu, Aug 27, 2:23 PM · Restricted Project
gribozavr2 accepted D86719: [SyntaxTree][NFC] Refactor function templates into functions taking base class.

Perhaps we should inline getQualifiedNameStart and getInitializerRange and make getDeclaratorRange a member function taking a Decl. What do you think?

Thu, Aug 27, 11:53 AM · Restricted Project
gribozavr2 added a comment to D85159: [ConstProp] Remove ConstantPropagation.

@aeubanks This change seems to have broken an OCaml test. Could you please take a look and push a fix at your earliest convenience?

Thu, Aug 27, 7:58 AM · Restricted Project
gribozavr2 accepted D86679: [SyntaxTree][NFC] Append "get" to syntax Nodes accessor names.

It's worth noting that accessors in the base APIs don't follow this rule. Should we refactor them as well?

Thu, Aug 27, 4:06 AM · Restricted Project
gribozavr2 accepted D86682: [SyntaxTree][NFC][Style] Functions start with lowercase.
Thu, Aug 27, 1:27 AM · Restricted Project

Wed, Aug 26

gribozavr2 accepted D86636: [SyntaxTree] Refactor `NodeRole`s.
Wed, Aug 26, 10:04 AM · Restricted Project
gribozavr2 accepted D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API.
Wed, Aug 26, 7:18 AM · Restricted Project
gribozavr2 added a comment to D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API.

Could you add some tests with variadic parameter lists & variadic function templates? If we don't handle them correctly, please leave a FIXME in the test.

Wed, Aug 26, 4:20 AM · Restricted Project
gribozavr2 added a comment to D86600: [SyntaxTree] Migrate `ParamatersAndQualifiers` to use the new List API.

I think we also need to update List::getTerminationKind() and other similar List methods to handle this list kind.

Wed, Aug 26, 4:18 AM · Restricted Project
gribozavr2 accepted D86591: [SyntaxTree] Fix C++ versions on tests of `BuildTreeTest.cpp`.
Wed, Aug 26, 12:26 AM · Restricted Project

Aug 25 2020

gribozavr2 accepted D86544: [SyntaxTree] Add support for call expressions.
Aug 25 2020, 1:54 PM · Restricted Project

Aug 24 2020

gribozavr2 accepted D85330: [SyntaxTree] Extend the syntax tree dump.
Aug 24 2020, 3:09 PM · Restricted Project
gribozavr2 accepted D86467: [SyntaxTree] Split `MemberPointer` tests with annotations.
Aug 24 2020, 3:02 PM · Restricted Project
gribozavr2 accepted D86469: [SyntaxTree] Split ConstVolatileQualifiers tests.
Aug 24 2020, 2:58 PM · Restricted Project
gribozavr2 accepted D86470: [SyntaxTree] Use annotations on ClassTemplate_MemberClassDefinition test.
Aug 24 2020, 2:56 PM · Restricted Project
gribozavr2 accepted D86459: [SyntaxTree] Split `ParametersAndQualifiers` tests.
Aug 24 2020, 7:06 AM · Restricted Project
gribozavr2 accepted D86441: [SyntaxTree] Split ExplicitTemplateInstantiation test.
Aug 24 2020, 3:40 AM · Restricted Project
gribozavr2 accepted D86443: [SyntaxTree] Group tests related to `using`.
Aug 24 2020, 3:38 AM · Restricted Project
gribozavr2 accepted D86440: [SyntaxTree] Split FreeStandingClass tests.
Aug 24 2020, 3:37 AM · Restricted Project
gribozavr2 accepted D86437: [SyntaxTree] Split array declarator tests.
Aug 24 2020, 3:36 AM · Restricted Project
gribozavr2 accepted D86439: [SyntaxTree] Use annotations to reduce noise on member function tests.
Aug 24 2020, 3:35 AM · Restricted Project

Aug 21 2020

gribozavr2 accepted D86345: [SyntaxTree] Use annotations in Statement tests.
Aug 21 2020, 6:32 AM · Restricted Project
gribozavr2 added inline comments to D85330: [SyntaxTree] Extend the syntax tree dump.
Aug 21 2020, 3:37 AM · Restricted Project
gribozavr2 added a comment to D85330: [SyntaxTree] Extend the syntax tree dump.

Output format LGTM!

Aug 21 2020, 3:37 AM · Restricted Project

Aug 20 2020

gribozavr2 accepted D86298: [SyntaxTree] Add support for `this`.
Aug 20 2020, 11:51 AM · Restricted Project
gribozavr2 accepted D86227: [SyntaxTree] Add support for `MemberExpression`.
Aug 20 2020, 6:36 AM · Restricted Project
gribozavr2 added inline comments to D86227: [SyntaxTree] Add support for `MemberExpression`.
Aug 20 2020, 2:01 AM · Restricted Project

Aug 19 2020

gribozavr2 added a comment to D86134: Fix OCaml build failure because of absolute path in system libs.

@haampie This change helped, thanks!

Aug 19 2020, 1:01 PM · Restricted Project
gribozavr2 added a comment to D85820: Use find_library for ncurses.

@haampie It looks like this change caused a build problem with OCaml enabled.

Aug 19 2020, 3:53 AM · Restricted Project, Restricted Project, Restricted Project

Aug 18 2020

gribozavr2 accepted D86139: [SyntaxTree] Split tests related to Namespace.
Aug 18 2020, 7:35 AM · Restricted Project

Aug 14 2020

gribozavr2 accepted D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests..

Very nice improvement to tests!

Aug 14 2020, 3:04 PM · Restricted Project
gribozavr2 added inline comments to D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests..
Aug 14 2020, 5:32 AM · Restricted Project

Aug 13 2020

gribozavr2 accepted D85913: [SyntaxTree] Split `TreeTestBase` into header and source.
Aug 13 2020, 10:38 AM · Restricted Project
gribozavr2 accepted D85897: [SyntaxTree] Split `TreeTest.cpp`.
Aug 13 2020, 5:53 AM · Restricted Project
gribozavr2 accepted D85898: [SyntaxTree] Clean `#includes` in `TreeTestBase.h`.
Aug 13 2020, 5:51 AM · Restricted Project

Aug 12 2020

gribozavr2 accepted D85819: [SyntaxTree] Split tests.

Please also consider splitting the file into multiple.

Aug 12 2020, 3:47 PM · Restricted Project

Aug 11 2020

gribozavr2 added inline comments to D85750: [SyntaxTree] Unbox operators into tokens for nodes generated from `CXXOperatorCallExpr`.
Aug 11 2020, 10:18 AM · Restricted Project
gribozavr2 accepted D85750: [SyntaxTree] Unbox operators into tokens for nodes generated from `CXXOperatorCallExpr`.
Aug 11 2020, 10:11 AM · Restricted Project
gribozavr2 accepted D85734: [libTooling] Move RewriteRule include edits to ASTEdit granularity..
Aug 11 2020, 9:30 AM · Restricted Project
gribozavr2 accepted D85733: [libTooling] Cleanup and reorder `RewriteRule.h`..
Aug 11 2020, 9:18 AM · Restricted Project