Page MenuHomePhabricator

devin.jeanpierre (Devin Jeanpierre)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 19 2019, 2:25 PM (152 w, 6 d)

Recent Activity

Wed, Jan 19

devin.jeanpierre added a comment to D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

@rsmith I've pulled+rebased again to avoid the (looks like pre-existing) failure. Copy-pasting the wording on https://llvm.org/docs/MyFirstTypoFix.html#commit-by-proxy: I don’t have commit access, can you land this patch for me? Please use “Devin Jeanpierre jeanpierreda@google.com” to commit the change.

Wed, Jan 19, 3:42 PM · Restricted Project
devin.jeanpierre updated the diff for D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

pull/rebase

Wed, Jan 19, 3:14 PM · Restricted Project
devin.jeanpierre added a comment to D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

Sorry, I missed your other comments. Let me know if there's anything else I didn't address.

Wed, Jan 19, 1:20 PM · Restricted Project
devin.jeanpierre updated the diff for D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

Fix copy-paste error.

Wed, Jan 19, 1:11 PM · Restricted Project
devin.jeanpierre added a comment to D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

Sorry, I missed your other comments. Let me know if there's anything else I didn't address.

Wed, Jan 19, 1:09 PM · Restricted Project
devin.jeanpierre added a comment to D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

CI test finished successfully before windows setup did 😢. My workplace's Windows VMs are a bit hosed at the moment...

Wed, Jan 19, 12:00 PM · Restricted Project
devin.jeanpierre updated the diff for D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

Clarify Windows comments.

Wed, Jan 19, 11:54 AM · Restricted Project

Tue, Jan 18

devin.jeanpierre added a comment to D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

OK, while I'm struggling to set up a new Windows machine so I can make sure this works on Windows... @Quuxplusone, after this is merged, do you want to rebase D67524 on top of this, or should I? I can review it -- I think when I looked at it, I only had two ideas for changes:

Tue, Jan 18, 4:55 PM · Restricted Project
devin.jeanpierre updated the diff for D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

Update to pass on Windows (untested right now).

Tue, Jan 18, 4:22 PM · Restricted Project

Dec 7 2021

devin.jeanpierre added a comment to D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

Trivial relocation doesn't imply that types have to be safe against being suddenly relocated during the middle of operations while they're not in a safe internal state. That is not a consideration.

Dec 7 2021, 6:54 PM · Restricted Project
devin.jeanpierre added a comment to D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

(Sorry, I think I'm doing threading wrong here due to lack of experience with phabricator. The reply buttons are grayed out!)

Dec 7 2021, 5:55 PM · Restricted Project
devin.jeanpierre updated the diff for D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

Use PCK_ARCStrong to check for ObjC strong pointers, marking them as trivially relocatable as well.

Dec 7 2021, 5:40 PM · Restricted Project

Dec 6 2021

devin.jeanpierre added a comment to D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

(Sorry for delayed reply -- I made the mistake of signing up to phabricator with my personal email, which I don't check very well, apparently!)

Dec 6 2021, 3:57 PM · Restricted Project
devin.jeanpierre updated the diff for D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

Suggested changes from code review.

Dec 6 2021, 3:55 PM · Restricted Project

Nov 29 2021

devin.jeanpierre added a comment to D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

Wow, thanks for the quick response! I really appreciate it.

Nov 29 2021, 1:13 PM · Restricted Project
mehdi_amini renamed devin.jeanpierre from devinj.jeanpierre to devin.jeanpierre.
Nov 29 2021, 1:01 PM
devin.jeanpierre added a comment to D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

Just a heads up, I think this is my first change to clang or llvm, and I'd appreciate any feedback you have on the code, review process, etc.

Nov 29 2021, 12:11 PM · Restricted Project
devin.jeanpierre updated the summary of D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..
Nov 29 2021, 12:08 PM · Restricted Project
devin.jeanpierre updated the summary of D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..
Nov 29 2021, 12:08 PM · Restricted Project
devin.jeanpierre requested review of D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..
Nov 29 2021, 12:06 PM · Restricted Project