- User Since
- Feb 19 2019, 2:25 PM (152 w, 6 d)
Wed, Jan 19
@rsmith I've pulled+rebased again to avoid the (looks like pre-existing) failure. Copy-pasting the wording on https://llvm.org/docs/MyFirstTypoFix.html#commit-by-proxy: I don’t have commit access, can you land this patch for me? Please use “Devin Jeanpierre email@example.com” to commit the change.
Fix copy-paste error.
Sorry, I missed your other comments. Let me know if there's anything else I didn't address.
CI test finished successfully before windows setup did 😢. My workplace's Windows VMs are a bit hosed at the moment...
Clarify Windows comments.
Tue, Jan 18
OK, while I'm struggling to set up a new Windows machine so I can make sure this works on Windows... @Quuxplusone, after this is merged, do you want to rebase D67524 on top of this, or should I? I can review it -- I think when I looked at it, I only had two ideas for changes:
Update to pass on Windows (untested right now).
Dec 7 2021
(Sorry, I think I'm doing threading wrong here due to lack of experience with phabricator. The reply buttons are grayed out!)
Use PCK_ARCStrong to check for ObjC strong pointers, marking them as trivially relocatable as well.
Dec 6 2021
(Sorry for delayed reply -- I made the mistake of signing up to phabricator with my personal email, which I don't check very well, apparently!)
Suggested changes from code review.
Nov 29 2021
Wow, thanks for the quick response! I really appreciate it.
Just a heads up, I think this is my first change to clang or llvm, and I'd appreciate any feedback you have on the code, review process, etc.