Details
- Reviewers
frasercrmck craig.topper kito-cheng khchen
Diff Detail
Event Timeline
Ok, regarding the testing in sink-splat-operands-commute.ll I took the relevant operations in sink-splat-operands.ll and swapped the input so the broadcast operand is the first one. They generate the same input (the only difference is the basic block IDs).
If we feel this is too much I can integrate that in sink-splat-operands.ll.
llvm/test/CodeGen/RISCV/rvv/sink-splat-operands.ll | ||
---|---|---|
3037 | This is an interesting case! By doing this we are increasing the number of vsetvlis in the loop from 2 to 3. However we could hoist the first one outside the loop because the state of vl and vtype right before the latch (bnez) is exactly the same. I guess we can fix this in a specific change in RISCVInsertVSETVLI.cpp |
Drop the FIXME?