Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Can you also check for updates in:
clang/lib/Basic/Cuda.cpp
openmp/libomptarget/plugins/amdgpu/impl/get_elf_mach_gfx_name.cpp
llvm/test/CodeGen/AMDGPU/directive-amdgcn-target.ll
llvm/test/tools/llvm-objdump/ELF/AMDGPU/subtarget.ll
llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-headers.test
clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp | ||
---|---|---|
4489 | I think lint is complaining about trailing whitespace here -- please check the whole patch for it. | |
llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml | ||
337 | You also need to add RUN lines at the top of this file. |
Is there documentation for the mapping from product names to gfx numbers?
It's possible to work it out from roct's topology.cpp and the pci.ids table, but hopefully there's a table we could point users to as well.
llvm/include/llvm/BinaryFormat/ELF.h | ||
---|---|---|
737 | For future reference, MACH values are sorted by value, reserved MACHs need to be replaced with real MACHs (see line 742 in this review). |
I think lint is complaining about trailing whitespace here -- please check the whole patch for it.