Page MenuHomePhabricator

Add gfx1034
ClosedPublic

Authored by aakanksha555 on May 11 2021, 9:46 PM.

Diff Detail

Event Timeline

aakanksha555 created this revision.May 11 2021, 9:46 PM
aakanksha555 requested review of this revision.May 11 2021, 9:46 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 11 2021, 9:46 PM
foad added a subscriber: foad.May 12 2021, 5:19 AM

Can you also check for updates in:
clang/lib/Basic/Cuda.cpp
openmp/libomptarget/plugins/amdgpu/impl/get_elf_mach_gfx_name.cpp
llvm/test/CodeGen/AMDGPU/directive-amdgcn-target.ll
llvm/test/tools/llvm-objdump/ELF/AMDGPU/subtarget.ll
llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-headers.test

clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp
4489

I think lint is complaining about trailing whitespace here -- please check the whole patch for it.

llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml
337

You also need to add RUN lines at the top of this file.

This revision is now accepted and ready to land.May 13 2021, 11:18 AM
This revision was landed with ongoing or failed builds.May 13 2021, 11:25 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2021, 11:25 AM

Is there documentation for the mapping from product names to gfx numbers?

It's possible to work it out from roct's topology.cpp and the pci.ids table, but hopefully there's a table we could point users to as well.

Is there documentation for the mapping from product names to gfx numbers?

See the Processors section of https://llvm.org/docs/AMDGPUUsage.html

tra added a subscriber: tra.May 14 2021, 2:31 PM

Is there documentation for the mapping from product names to gfx numbers?

See the Processors section of https://llvm.org/docs/AMDGPUUsage.html

It appears to be missing some GPUs. None of WX series are listed, for example.

kzhuravl added a subscriber: t-tye.May 17 2021, 8:49 AM

Is there documentation for the mapping from product names to gfx numbers?

See the Processors section of https://llvm.org/docs/AMDGPUUsage.html

It appears to be missing some GPUs. None of WX series are listed, for example.

+ @t-tye

@t-tye usually updates product names as they become available.

kzhuravl added inline comments.May 18 2021, 2:06 PM
llvm/include/llvm/BinaryFormat/ELF.h
737

For future reference, MACH values are sorted by value, reserved MACHs need to be replaced with real MACHs (see line 742 in this review).