User Details
- User Since
- Apr 4 2014, 4:14 AM (354 w, 3 d)
Fri, Jan 15
LGTM
LGTM
Wed, Jan 13
With this patch you would set features on an address-taken function and ignore whole call stack below it. I.e. its own callees will not be processed. I think you need to continue traversal, just skip actual setting of attributes on such a function. Setting these attributes on a functions it may call in turn shall be fine.
Mon, Jan 11
Fri, Jan 8
Thu, Jan 7
LGTM. Make sure to rerun tests before push as a lot of tests are affected.
Wed, Jan 6
LGTM
Mon, Jan 4
LGTM
Generally speaking it is deprecated but it is supported. Well, not in gfx1030.
Wed, Dec 23
Tue, Dec 22
Added run line to the unaligned-load-store.ll.
LGTM, but please check with Tony for the documentation.
LGTM
Mon, Dec 21
LGTM
Dec 18 2020
Dec 17 2020
Dec 16 2020
LGTM, but please fix typo in the commit message before submit: "unniform".
Dec 15 2020
LGTM
Needs test in Transforms/JumpThreading.
Typo in the commit message "unniform".
LGTM, thanks!
Dec 14 2020
Removed CHAR_WIDTH.
LGTM
Dec 11 2020
Added 0=unlimited to the option description.
ping.
Dec 10 2020
Dec 9 2020
Dec 8 2020
LGTM. Not sure why MODE was also defined by set_gpr_idx, but that can be corrected later if needed.
Dec 7 2020
JBTW, having a need to def M0 probably defeats the idea of potential rescheduling which justifies the separation of the indirect access methods.
I think I've seen similar cases before. LGTM, but will be nice if @qcolombet will look at this too.
Updated option description.
Updated callback comment to clarify this is used by SLP only now.
Dropped BE test.
Addded a store to the general test to make it useful if anyone needs to run AMDGPU BE on it too.