msearles (Mark Searles)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2017, 11:02 AM (75 w, 6 d)

Recent Activity

Jul 16 2018

msearles committed rL337156: [AMDGPU][Waitcnt] Re-apply fix "comparison of integers of different signs"….
[AMDGPU][Waitcnt] Re-apply fix "comparison of integers of different signs"…
Jul 16 2018, 3:26 AM
msearles committed rL337154: run post-RA hazard recognizer pass late.
run post-RA hazard recognizer pass late
Jul 16 2018, 3:07 AM
msearles closed D49288: [AMDGPU] run post-RA hazard recognizer pass late.
Jul 16 2018, 3:07 AM · Restricted Project
msearles committed rL337153: Revert "[AMDGPU][Waitcnt] fix "comparison of integers of different signs" build….
Revert "[AMDGPU][Waitcnt] fix "comparison of integers of different signs" build…
Jul 16 2018, 3:07 AM

Jul 13 2018

msearles updated the diff for D49288: [AMDGPU] run post-RA hazard recognizer pass late.
  • Move post-RA hazard recognizer pass after shrink instr as well.
  • Update tests.
Jul 13 2018, 11:40 AM · Restricted Project
msearles added inline comments to D49288: [AMDGPU] run post-RA hazard recognizer pass late.
Jul 13 2018, 5:32 AM · Restricted Project
msearles created D49288: [AMDGPU] run post-RA hazard recognizer pass late.
Jul 13 2018, 4:51 AM · Restricted Project

Jul 12 2018

msearles accepted D49257: AMDGPU: Fix assert in truncate combine with vectors.

LGTM

Jul 12 2018, 11:08 AM

Jul 9 2018

msearles committed rL336593: RenameIndependentSubregs: Fix handling of undef tied operands.
RenameIndependentSubregs: Fix handling of undef tied operands
Jul 9 2018, 1:12 PM
msearles closed D49052: RenameIndependentSubregs: Fix handling of undef tied operands.
Jul 9 2018, 1:12 PM · Restricted Project
msearles committed rL336588: [AMDGPU][Waitcnt] fix "comparison of integers of different signs" build error.
[AMDGPU][Waitcnt] fix "comparison of integers of different signs" build error
Jul 9 2018, 12:33 PM
msearles closed D49089: [AMDGPU][Waitcnt] fix "comparison of integers of different signs" build error.
Jul 9 2018, 12:33 PM · Restricted Project
msearles created D49089: [AMDGPU][Waitcnt] fix "comparison of integers of different signs" build error.
Jul 9 2018, 10:17 AM · Restricted Project

Jul 6 2018

msearles created D49052: RenameIndependentSubregs: Fix handling of undef tied operands.
Jul 6 2018, 8:24 PM · Restricted Project

Jun 27 2018

msearles accepted D48645: AMDGPU: Error on calls from graphics shaders.

LGTM

Jun 27 2018, 2:42 PM

Jun 26 2018

msearles accepted D48607: AMDGPU: Silence unused warnings in waitcnt insertion pass in release build.

LGTM; thx, I've been meaning to address this.

Jun 26 2018, 2:10 PM

Jun 20 2018

msearles accepted D48391: [AMDGPU] Fix bug with tracking processed blocks in SIInsertWaitcnts.

LGTM

Jun 20 2018, 1:28 PM

Jun 15 2018

msearles accepted D48246: [AMDGPU] setcc (select cc, CT, CF), CF, eq | ne -> xor cc, -1 | cc.

LGTM

Jun 15 2018, 5:10 PM
msearles accepted D48223: Allow binop C1, (select cc, CF, CT) -> select folding.

LGTM

Jun 15 2018, 12:37 PM

Jun 13 2018

msearles accepted D48133: [AMDGPU] Corrected computeKnownBits for V_PERM_B32.

LGTM

Jun 13 2018, 9:52 AM

Jun 12 2018

msearles added a comment to D48099: [AMDGPU] DAG combine to produce V_PERM_B32.

LGTM

Jun 12 2018, 4:43 PM
msearles accepted D48099: [AMDGPU] DAG combine to produce V_PERM_B32.

LGTM; couple of minor nits on couple of comments

Jun 12 2018, 3:48 PM

Jun 11 2018

msearles committed rL334459: [AMDGPU] prevent hitting Assertion `isReg() && "Wrong MachineOperand accessor"'.
[AMDGPU] prevent hitting Assertion `isReg() && "Wrong MachineOperand accessor"'
Jun 11 2018, 5:45 PM
msearles closed D48047: [AMDGPU] findMaskOperands() - prevent hitting Assertion `isReg() && "Wrong MachineOperand accessor"' .
Jun 11 2018, 5:45 PM · Restricted Project
msearles added inline comments to D48047: [AMDGPU] findMaskOperands() - prevent hitting Assertion `isReg() && "Wrong MachineOperand accessor"' .
Jun 11 2018, 1:37 PM · Restricted Project
msearles updated the diff for D48047: [AMDGPU] findMaskOperands() - prevent hitting Assertion `isReg() && "Wrong MachineOperand accessor"' .

Removed # REQUIRES: asserts in test

Jun 11 2018, 1:37 PM · Restricted Project
msearles updated the diff for D48047: [AMDGPU] findMaskOperands() - prevent hitting Assertion `isReg() && "Wrong MachineOperand accessor"' .

Added a test

Jun 11 2018, 1:22 PM · Restricted Project
msearles created D48047: [AMDGPU] findMaskOperands() - prevent hitting Assertion `isReg() && "Wrong MachineOperand accessor"' .
Jun 11 2018, 1:11 PM · Restricted Project

Jun 4 2018

msearles committed rL333926: [AMDGPU][Waitcnt] Fix handling of flat instrs.
[AMDGPU][Waitcnt] Fix handling of flat instrs
Jun 4 2018, 9:56 AM
msearles closed D46616: [AMDGPU][Waitcnt] Fix handling of flat instrs.
Jun 4 2018, 9:56 AM · Restricted Project

May 30 2018

msearles committed rL333559: [AMDGPU][Waitcnt] Fix build error: unused variable 'SWaitInst'.
[AMDGPU][Waitcnt] Fix build error: unused variable 'SWaitInst'
May 30 2018, 9:32 AM
msearles committed rL333556: [AMDGPU][Waitcnt] Fix handling of loops with many bottom blocks.
[AMDGPU][Waitcnt] Fix handling of loops with many bottom blocks
May 30 2018, 8:51 AM
msearles closed D47488: [AMDGPU][Waitcnt] Fix handling of loops with many bottom blocks.
May 30 2018, 8:51 AM · Restricted Project

May 29 2018

msearles created D47488: [AMDGPU][Waitcnt] Fix handling of loops with many bottom blocks.
May 29 2018, 10:39 AM · Restricted Project

May 25 2018

msearles committed rL333303: [AMDGPU][Waitcnt] Remove obsolete waitcnt option.
[AMDGPU][Waitcnt] Remove obsolete waitcnt option
May 25 2018, 1:28 PM
msearles closed D47378: [AMDGPU][Waitcnt] Remove obsolete waitcnt option.
May 25 2018, 1:28 PM · Restricted Project
msearles created D47378: [AMDGPU][Waitcnt] Remove obsolete waitcnt option.
May 25 2018, 10:40 AM · Restricted Project

May 24 2018

msearles added a comment to D46616: [AMDGPU][Waitcnt] Fix handling of flat instrs.

ping

May 24 2018, 3:38 PM · Restricted Project

May 21 2018

msearles committed rC332854: [Clang Tablegen] Add llvm_unreachable() to getModifierName().
[Clang Tablegen] Add llvm_unreachable() to getModifierName()
May 21 2018, 10:33 AM
msearles committed rL332854: [Clang Tablegen] Add llvm_unreachable() to getModifierName().
[Clang Tablegen] Add llvm_unreachable() to getModifierName()
May 21 2018, 10:33 AM
msearles closed D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName().
May 21 2018, 10:33 AM
msearles updated the diff for D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName().

Add comment per reviewer suggestion.

May 21 2018, 10:25 AM
msearles updated the diff for D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName().

Ah, yes. Adding llvm_unreachable() is better. Done.

May 21 2018, 10:05 AM
msearles created D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName().
May 21 2018, 9:47 AM

May 17 2018

msearles added a comment to D46616: [AMDGPU][Waitcnt] Fix handling of flat instrs.

ping

May 17 2018, 9:28 PM · Restricted Project

May 10 2018

msearles updated the diff for D46616: [AMDGPU][Waitcnt] Fix handling of flat instrs.

Add subtarget-specific checks

May 10 2018, 8:25 AM · Restricted Project

May 8 2018

msearles updated the diff for D46616: [AMDGPU][Waitcnt] Fix handling of flat instrs.

Update comment as suggested by reviewer.

May 8 2018, 6:49 PM · Restricted Project
msearles created D46616: [AMDGPU][Waitcnt] Fix handling of flat instrs.
May 8 2018, 5:43 PM · Restricted Project

May 7 2018

msearles committed rL331641: [AMDGPU][Waitcnt] Remove the old waitcnt pass.
[AMDGPU][Waitcnt] Remove the old waitcnt pass
May 7 2018, 7:47 AM
msearles closed D46448: [AMDGPU][Waitcnt] Remove the old waitcnt pass, which is no longer maintained and getting crufty.
May 7 2018, 7:47 AM · Restricted Project

May 4 2018

msearles added a comment to D46448: [AMDGPU][Waitcnt] Remove the old waitcnt pass, which is no longer maintained and getting crufty.

Please also remove it from AMDGPU.h. Otherwise LGTM.

May 4 2018, 3:26 PM · Restricted Project
msearles updated the diff for D46448: [AMDGPU][Waitcnt] Remove the old waitcnt pass, which is no longer maintained and getting crufty.

Remove old waitcnt pass from lib/Target/AMDGPU/AMDGPU.h

May 4 2018, 3:26 PM · Restricted Project
msearles added reviewers for D46448: [AMDGPU][Waitcnt] Remove the old waitcnt pass, which is no longer maintained and getting crufty: arsenm, rampitec.
May 4 2018, 3:13 PM · Restricted Project
msearles updated the diff for D46448: [AMDGPU][Waitcnt] Remove the old waitcnt pass, which is no longer maintained and getting crufty.

Add waitcnt.mir

May 4 2018, 1:10 PM · Restricted Project
msearles created D46448: [AMDGPU][Waitcnt] Remove the old waitcnt pass, which is no longer maintained and getting crufty.
May 4 2018, 12:52 PM · Restricted Project

May 1 2018

msearles added inline comments to D46298: AMDGPU: Move isSDNodeSourceOfDivergence() implementation to SITargetLowering.
May 1 2018, 8:57 AM

Apr 27 2018

msearles committed rL331062: [AMDGPU][Waitcnt] Update a few tests to use default waitcnt pass (si-insert….
[AMDGPU][Waitcnt] Update a few tests to use default waitcnt pass (si-insert…
Apr 27 2018, 11:02 AM
msearles closed D46154: [AMDGPU][Waitcnt] Update a few lit tests to use the default waitcnt pass.
Apr 27 2018, 11:02 AM · Restricted Project

Apr 26 2018

msearles added reviewers for D46154: [AMDGPU][Waitcnt] Update a few lit tests to use the default waitcnt pass: cfang, FarhanaAleen.
Apr 26 2018, 4:42 PM · Restricted Project
msearles created D46154: [AMDGPU][Waitcnt] Update a few lit tests to use the default waitcnt pass.
Apr 26 2018, 4:41 PM · Restricted Project
msearles committed rL330954: [AMDGPU][Waitcnt] As of gfx7, VMEM operations do not increment the export….
[AMDGPU][Waitcnt] As of gfx7, VMEM operations do not increment the export…
Apr 26 2018, 9:14 AM
msearles closed D46067: [AMDGPU][Waitcnt] Take ISA target into account for s_waitcnt expcnt instr generation.
Apr 26 2018, 9:14 AM · Restricted Project

Apr 25 2018

msearles committed rL330862: [AMDGPU] Waitcnt pass: add debug options.
[AMDGPU] Waitcnt pass: add debug options
Apr 25 2018, 12:26 PM
msearles closed D45888: [AMDGPU][Waitcnt] Add debug options.
Apr 25 2018, 12:26 PM · Restricted Project
msearles created D46067: [AMDGPU][Waitcnt] Take ISA target into account for s_waitcnt expcnt instr generation.
Apr 25 2018, 8:53 AM · Restricted Project

Apr 24 2018

msearles closed D45973: [AMDGPU][Waitcnt] NFC. Cleanup some code.

https://reviews.llvm.org/rL330730

Apr 24 2018, 9:07 AM · Restricted Project
msearles committed rL330730: [AMDGPU][Waitcnt] NFC. Cleanup some code/naming consistency:.
[AMDGPU][Waitcnt] NFC. Cleanup some code/naming consistency:
Apr 24 2018, 9:03 AM

Apr 23 2018

msearles created D45973: [AMDGPU][Waitcnt] NFC. Cleanup some code.
Apr 23 2018, 10:05 AM · Restricted Project
msearles updated the diff for D45888: [AMDGPU][Waitcnt] Add debug options.

To simplify review, remove unrelated code cleanup: naming consistency s/SWaitcnt/Waitcnt s/WaitCnt/Waitcnt

Apr 23 2018, 9:19 AM · Restricted Project

Apr 20 2018

msearles created D45888: [AMDGPU][Waitcnt] Add debug options.
Apr 20 2018, 9:55 AM · Restricted Project

Apr 19 2018

msearles committed rL330337: [AMDGPU] Do not only rely on BB number when finding bottom loop.
[AMDGPU] Do not only rely on BB number when finding bottom loop
Apr 19 2018, 8:45 AM
msearles closed D43831: [AMDGPU] Do not only rely on BB number when finding bottom loop.
Apr 19 2018, 8:45 AM

Apr 17 2018

msearles added a comment to D43831: [AMDGPU] Do not only rely on BB number when finding bottom loop.

Ping; the patch looks good to the original author and to me, the follow-on author. However, it would be nice if someone other than one of us accepts the revision.

Apr 17 2018, 12:02 PM

Apr 10 2018

msearles updated the diff for D43831: [AMDGPU] Do not only rely on BB number when finding bottom loop.
  • Change isLoopBottom() to return true in the case of a single basic block loop
  • Clear LoopWaitcntDataMap in between functions
Apr 10 2018, 9:15 AM
msearles commandeered D43831: [AMDGPU] Do not only rely on BB number when finding bottom loop.

Picking up where @hakzsam left off

Apr 10 2018, 9:13 AM

Apr 7 2018

msearles added inline comments to D43831: [AMDGPU] Do not only rely on BB number when finding bottom loop.
Apr 7 2018, 7:14 AM

Mar 27 2018

msearles accepted D44940: AMDGPU: Fix crash when MachinePointerInfo invalid.

LGTM

Mar 27 2018, 9:01 AM

Mar 15 2018

msearles added inline comments to D43831: [AMDGPU] Do not only rely on BB number when finding bottom loop.
Mar 15 2018, 8:50 AM

Mar 14 2018

msearles committed rL327583: [AMDGPU] Waitcnt pass: Modify the waitcnt pass to propagate info in the case of….
[AMDGPU] Waitcnt pass: Modify the waitcnt pass to propagate info in the case of…
Mar 14 2018, 3:07 PM
msearles closed D44434: [AMDGPU] Waitcnt pass: propagate info in the case of a single basic block loop.
Mar 14 2018, 3:07 PM · Restricted Project
msearles accepted D44319: [AMDGPU]Supported ds_write_b128 generation..

LGTM

Mar 14 2018, 2:55 PM
msearles updated the diff for D44434: [AMDGPU] Waitcnt pass: propagate info in the case of a single basic block loop.

Fix formatting per reviewer comments

Mar 14 2018, 11:50 AM · Restricted Project
msearles added inline comments to D43831: [AMDGPU] Do not only rely on BB number when finding bottom loop.
Mar 14 2018, 9:35 AM
msearles updated the diff for D44434: [AMDGPU] Waitcnt pass: propagate info in the case of a single basic block loop.

Adjust per reviewer comments.

Mar 14 2018, 9:32 AM · Restricted Project

Mar 13 2018

msearles added reviewers for D44434: [AMDGPU] Waitcnt pass: propagate info in the case of a single basic block loop: arsenm, rampitec.
Mar 13 2018, 8:53 AM · Restricted Project
msearles created D44434: [AMDGPU] Waitcnt pass: propagate info in the case of a single basic block loop.
Mar 13 2018, 8:53 AM · Restricted Project

Mar 8 2018

msearles added inline comments to D43831: [AMDGPU] Do not only rely on BB number when finding bottom loop.
Mar 8 2018, 6:42 PM

Mar 5 2018

msearles added a comment to D43831: [AMDGPU] Do not only rely on BB number when finding bottom loop.

For the testcase, would you also run -instnamer to rename instances of %<number>? You may want to combine it with other clean-up options, something like this: opt -S -deadarghaX0r -strip -strip-debug -strip-dead-prototypes -instnamer

Mar 5 2018, 10:14 AM

Feb 23 2018

msearles accepted D43699: [AMDGPU] Shrinking V_SUBBREV_U32.

LGTM

Feb 23 2018, 3:12 PM

Feb 19 2018

msearles closed D43426: [AMDGPU] Make note of exisitng waitcnt instrs.

https://reviews.llvm.org/rL325524

Feb 19 2018, 11:25 AM · Restricted Project
msearles committed rL325524: [AMDGPU] Make note of existing waitcnt instrs; this is add-on work related to….
[AMDGPU] Make note of existing waitcnt instrs; this is add-on work related to…
Feb 19 2018, 11:24 AM
msearles committed rL325518: [AMDGPU] Increased vector length for global/constant loads..
[AMDGPU] Increased vector length for global/constant loads.
Feb 19 2018, 8:47 AM
msearles closed D43275: [AMDGPU]Increased vector length for global/constant loads. .
Feb 19 2018, 8:47 AM

Feb 16 2018

msearles created D43426: [AMDGPU] Make note of exisitng waitcnt instrs.
Feb 16 2018, 5:59 PM · Restricted Project

Feb 15 2018

msearles accepted D43350: [AMDGPU] Combine adjacent waitcounts in a single strongest wait.

LGTM

Feb 15 2018, 1:23 PM

Feb 8 2018

msearles accepted D43094: AMDGPU: Enable PIC by default for amdgcn.

LGTM

Feb 8 2018, 3:42 PM

Feb 6 2018

msearles accepted D42997: [AMDGPU] Fixed wait count reuse.

LGTM; what about a test that exercises the code that was effectively turned off (~line 1129)?

Feb 6 2018, 6:27 PM
msearles committed rL324440: [AMDGPU] Suppress redundant waitcnt instrs..
[AMDGPU] Suppress redundant waitcnt instrs.
Feb 6 2018, 6:23 PM
msearles closed D42854: [AMDGPU] Suppress redundant waitcnt instrs.
Feb 6 2018, 6:23 PM · Restricted Project
msearles added inline comments to D42854: [AMDGPU] Suppress redundant waitcnt instrs.
Feb 6 2018, 5:57 PM · Restricted Project