Page MenuHomePhabricator

msearles (Mark Searles)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2017, 11:02 AM (114 w, 4 d)

Recent Activity

Mon, May 13

msearles accepted D61875: [AMDGPU] gfx1010 clang target.

LGTM

Mon, May 13, 3:57 PM · Restricted Project

Fri, May 3

msearles accepted D61536: [AMDGPU] gfx1010 hazard recognizer.

LGTM

Fri, May 3, 7:22 PM · Restricted Project
msearles accepted D61527: [AMDGPU] gfx1010: use fmac instructions.

LGTM

Fri, May 3, 7:19 PM · Restricted Project
msearles accepted D61534: [AMDGPU] gfx1010 wait count insertion.

LGTM

Fri, May 3, 2:01 PM · Restricted Project
msearles accepted D61531: [AMDGPU] gfx1010 s_code_end generation.

LGTM

Fri, May 3, 2:00 PM · Restricted Project
msearles accepted D61529: [AMDGPU] gfx1010 loop alignment.

LGTM

Fri, May 3, 1:58 PM · Restricted Project

Fri, Apr 26

msearles committed rG76c5b62988ff: Revert "AMDGPU: Split block for si_end_cf" (authored by msearles).
Revert "AMDGPU: Split block for si_end_cf"
Fri, Apr 26, 5:51 PM
msearles committed rL359363: Revert "AMDGPU: Split block for si_end_cf".
Revert "AMDGPU: Split block for si_end_cf"
Fri, Apr 26, 5:51 PM
msearles closed D61213: [AMDGPU] Revert "AMDGPU: Split block for si_end_cf".
Fri, Apr 26, 5:51 PM · Restricted Project, Restricted Project
msearles created D61213: [AMDGPU] Revert "AMDGPU: Split block for si_end_cf".
Fri, Apr 26, 2:51 PM · Restricted Project, Restricted Project

Tue, Apr 23

msearles accepted D61031: [AMDGPU] Fixed addReg() in SIOptimizeExecMaskingPreRA.cpp.

LGTM

Tue, Apr 23, 10:56 AM · Restricted Project

Apr 4 2019

msearles accepted D60293: [AMDGPU] rename vi-insts into gfx8-insts.

LGTM

Apr 4 2019, 4:41 PM · Restricted Project

Mar 19 2019

msearles accepted D59570: AMDHSA: Fix COMPUTE_PGM_RSRC2.USER_SGPR calculation when parsing ISA assembly.

LGTM

Mar 19 2019, 5:23 PM · Restricted Project

Mar 14 2019

msearles accepted D59365: AMDGPU: Correct type for waitcnt debug flag.

LGTM

Mar 14 2019, 8:35 AM

Mar 13 2019

msearles added inline comments to D59312: AMDGPU: Fix a SIAnnotateControlFlow issue when there are multiple backedges..
Mar 13 2019, 10:56 AM · Restricted Project

Feb 26 2019

msearles accepted D58688: AMDGPU: Enable function calls by default.

LGTM; 1 minor nit (typo in comment); no need to re-review

Feb 26 2019, 4:04 PM

Feb 21 2019

msearles committed rG599ce44d3f39: [AMDGPU] remove unused AssemblerPredicates (authored by msearles).
[AMDGPU] remove unused AssemblerPredicates
Feb 21 2019, 10:20 AM
msearles committed rL354604: [AMDGPU] remove unused AssemblerPredicates.
[AMDGPU] remove unused AssemblerPredicates
Feb 21 2019, 10:19 AM
msearles closed D58516: [AMDGPU] remove unused AssemblerPredicates.
Feb 21 2019, 10:19 AM · Restricted Project, Restricted Project
msearles updated the diff for D58516: [AMDGPU] remove unused AssemblerPredicates.

Address reviewer feedback - remove unused 'NotHasVOP3PInsts'

Feb 21 2019, 10:01 AM · Restricted Project, Restricted Project
msearles created D58516: [AMDGPU] remove unused AssemblerPredicates.
Feb 21 2019, 9:48 AM · Restricted Project, Restricted Project

Feb 1 2019

Herald added a project to D57539: [InstCombine] Extra null-checking on TFE/LWE support: Restricted Project.
Feb 1 2019, 8:24 AM · Restricted Project

Jan 17 2019

msearles accepted D56874: [WebAssembly] Fix windows compiler warning by using explicit 64bit shift. NFC..

LGTM

Jan 17 2019, 1:08 PM
msearles added a comment to D56874: [WebAssembly] Fix windows compiler warning by using explicit 64bit shift. NFC..

Would you kindly apply the same fix to:

Jan 17 2019, 12:26 PM
msearles added a comment to D56762: [WebAssembly] Store section alignment as a power of 2.

Yes, it looks like ULL should fix the warning: https://reviews.llvm.org/D56874

Jan 17 2019, 12:25 PM
msearles added inline comments to D56762: [WebAssembly] Store section alignment as a power of 2.
Jan 17 2019, 9:31 AM

Jan 4 2019

msearles added a comment to D56302: Fix typo: "with he MODULE" -> "with the MODULE".

@delcypher - I just committed; thanks much!

Jan 4 2019, 8:40 AM
msearles committed rL350400: Fix typo: "with he MODULE" -> "with the MODULE".
Fix typo: "with he MODULE" -> "with the MODULE"
Jan 4 2019, 8:39 AM
msearles closed D56302: Fix typo: "with he MODULE" -> "with the MODULE".
Jan 4 2019, 8:39 AM

Jan 3 2019

msearles created D56302: Fix typo: "with he MODULE" -> "with the MODULE".
Jan 3 2019, 5:03 PM

Dec 3 2018

msearles added inline comments to D55241: AMDGPU: Should always start from the first register in VGPR indexing..
Dec 3 2018, 4:28 PM

Nov 22 2018

msearles accepted D54226: AMDGPU/InsertWaitcnts: Untangle some semi-global state.

LGTM

Nov 22 2018, 9:38 AM
msearles accepted D54228: AMDGPU/InsertWaitcnts: Simplify pending events tracking.

LGTM

Nov 22 2018, 9:38 AM
msearles accepted D54231: AMDGPU/InsertWaitcnts: Remove the dependence on MachineLoopInfo.

LGTM

Nov 22 2018, 9:38 AM

Nov 7 2018

msearles accepted D54229: AMDGPU/InsertWaitcnt: Remove unused WaitAtBeginning.

LGTM

Nov 7 2018, 2:37 PM
msearles accepted D54230: AMDGPU/InsertWaitcnt: Consistently use uint32_t for scores / time points.

LGTM

Nov 7 2018, 2:27 PM
msearles accepted D54225: AMDGPU/InsertWaitcnts: Some more const-correctness.

LGTM

Nov 7 2018, 2:23 PM

Oct 8 2018

msearles added a comment to D52846: [AMDGPU] Add FixupVectorISel pass, currently Supports SREGs in GLOBAL LD/ST.

I took a look and (1) seems OK, though Matt should opine as well (2) minor nit: you could run instnamer on global-saddr-misc.ll to tidy up the %var<numbering>

Oct 8 2018, 4:23 PM

Oct 3 2018

msearles accepted D52520: [AMDGPU] Match signed dot4/8 pattern..

LGTM

Oct 3 2018, 10:06 AM

Oct 1 2018

msearles added a comment to D52520: [AMDGPU] Match signed dot4/8 pattern..

Can the tests be reduced/made more flexible? E.g., the tests previously used FileCheck variables ( [[FF:s[0-9]+]] .

Oct 1 2018, 10:20 AM

Aug 31 2018

msearles accepted D51555: [AMDGPU] Split v32i32 loads.

LGTM

Aug 31 2018, 3:35 PM

Jul 16 2018

msearles committed rL337156: [AMDGPU][Waitcnt] Re-apply fix "comparison of integers of different signs"….
[AMDGPU][Waitcnt] Re-apply fix "comparison of integers of different signs"…
Jul 16 2018, 3:26 AM
msearles committed rL337154: run post-RA hazard recognizer pass late.
run post-RA hazard recognizer pass late
Jul 16 2018, 3:07 AM
msearles closed D49288: [AMDGPU] run post-RA hazard recognizer pass late.
Jul 16 2018, 3:07 AM · Restricted Project
msearles committed rL337153: Revert "[AMDGPU][Waitcnt] fix "comparison of integers of different signs" build….
Revert "[AMDGPU][Waitcnt] fix "comparison of integers of different signs" build…
Jul 16 2018, 3:07 AM

Jul 13 2018

msearles updated the diff for D49288: [AMDGPU] run post-RA hazard recognizer pass late.
  • Move post-RA hazard recognizer pass after shrink instr as well.
  • Update tests.
Jul 13 2018, 11:40 AM · Restricted Project
msearles added inline comments to D49288: [AMDGPU] run post-RA hazard recognizer pass late.
Jul 13 2018, 5:32 AM · Restricted Project
msearles created D49288: [AMDGPU] run post-RA hazard recognizer pass late.
Jul 13 2018, 4:51 AM · Restricted Project

Jul 12 2018

msearles accepted D49257: AMDGPU: Fix assert in truncate combine with vectors.

LGTM

Jul 12 2018, 11:08 AM

Jul 9 2018

msearles committed rL336593: RenameIndependentSubregs: Fix handling of undef tied operands.
RenameIndependentSubregs: Fix handling of undef tied operands
Jul 9 2018, 1:12 PM
msearles closed D49052: RenameIndependentSubregs: Fix handling of undef tied operands.
Jul 9 2018, 1:12 PM · Restricted Project
msearles committed rL336588: [AMDGPU][Waitcnt] fix "comparison of integers of different signs" build error.
[AMDGPU][Waitcnt] fix "comparison of integers of different signs" build error
Jul 9 2018, 12:33 PM
msearles closed D49089: [AMDGPU][Waitcnt] fix "comparison of integers of different signs" build error.
Jul 9 2018, 12:33 PM · Restricted Project
msearles created D49089: [AMDGPU][Waitcnt] fix "comparison of integers of different signs" build error.
Jul 9 2018, 10:17 AM · Restricted Project

Jul 6 2018

msearles created D49052: RenameIndependentSubregs: Fix handling of undef tied operands.
Jul 6 2018, 8:24 PM · Restricted Project

Jun 27 2018

msearles accepted D48645: AMDGPU: Error on calls from graphics shaders.

LGTM

Jun 27 2018, 2:42 PM

Jun 26 2018

msearles accepted D48607: AMDGPU: Silence unused warnings in waitcnt insertion pass in release build.

LGTM; thx, I've been meaning to address this.

Jun 26 2018, 2:10 PM

Jun 20 2018

msearles accepted D48391: [AMDGPU] Fix bug with tracking processed blocks in SIInsertWaitcnts.

LGTM

Jun 20 2018, 1:28 PM

Jun 15 2018

msearles accepted D48246: [AMDGPU] setcc (select cc, CT, CF), CF, eq | ne -> xor cc, -1 | cc.

LGTM

Jun 15 2018, 5:10 PM
msearles accepted D48223: Allow binop C1, (select cc, CF, CT) -> select folding.

LGTM

Jun 15 2018, 12:37 PM

Jun 13 2018

msearles accepted D48133: [AMDGPU] Corrected computeKnownBits for V_PERM_B32.

LGTM

Jun 13 2018, 9:52 AM

Jun 12 2018

msearles added a comment to D48099: [AMDGPU] DAG combine to produce V_PERM_B32.

LGTM

Jun 12 2018, 4:43 PM
msearles accepted D48099: [AMDGPU] DAG combine to produce V_PERM_B32.

LGTM; couple of minor nits on couple of comments

Jun 12 2018, 3:48 PM

Jun 11 2018

msearles committed rL334459: [AMDGPU] prevent hitting Assertion `isReg() && "Wrong MachineOperand accessor"'.
[AMDGPU] prevent hitting Assertion `isReg() && "Wrong MachineOperand accessor"'
Jun 11 2018, 5:45 PM
msearles closed D48047: [AMDGPU] findMaskOperands() - prevent hitting Assertion `isReg() && "Wrong MachineOperand accessor"' .
Jun 11 2018, 5:45 PM · Restricted Project
msearles added inline comments to D48047: [AMDGPU] findMaskOperands() - prevent hitting Assertion `isReg() && "Wrong MachineOperand accessor"' .
Jun 11 2018, 1:37 PM · Restricted Project
msearles updated the diff for D48047: [AMDGPU] findMaskOperands() - prevent hitting Assertion `isReg() && "Wrong MachineOperand accessor"' .

Removed # REQUIRES: asserts in test

Jun 11 2018, 1:37 PM · Restricted Project
msearles updated the diff for D48047: [AMDGPU] findMaskOperands() - prevent hitting Assertion `isReg() && "Wrong MachineOperand accessor"' .

Added a test

Jun 11 2018, 1:22 PM · Restricted Project
msearles created D48047: [AMDGPU] findMaskOperands() - prevent hitting Assertion `isReg() && "Wrong MachineOperand accessor"' .
Jun 11 2018, 1:11 PM · Restricted Project

Jun 4 2018

msearles committed rL333926: [AMDGPU][Waitcnt] Fix handling of flat instrs.
[AMDGPU][Waitcnt] Fix handling of flat instrs
Jun 4 2018, 9:56 AM
msearles closed D46616: [AMDGPU][Waitcnt] Fix handling of flat instrs.
Jun 4 2018, 9:56 AM · Restricted Project

May 30 2018

msearles committed rL333559: [AMDGPU][Waitcnt] Fix build error: unused variable 'SWaitInst'.
[AMDGPU][Waitcnt] Fix build error: unused variable 'SWaitInst'
May 30 2018, 9:32 AM
msearles committed rL333556: [AMDGPU][Waitcnt] Fix handling of loops with many bottom blocks.
[AMDGPU][Waitcnt] Fix handling of loops with many bottom blocks
May 30 2018, 8:51 AM
msearles closed D47488: [AMDGPU][Waitcnt] Fix handling of loops with many bottom blocks.
May 30 2018, 8:51 AM · Restricted Project

May 29 2018

msearles created D47488: [AMDGPU][Waitcnt] Fix handling of loops with many bottom blocks.
May 29 2018, 10:39 AM · Restricted Project

May 25 2018

msearles committed rL333303: [AMDGPU][Waitcnt] Remove obsolete waitcnt option.
[AMDGPU][Waitcnt] Remove obsolete waitcnt option
May 25 2018, 1:28 PM
msearles closed D47378: [AMDGPU][Waitcnt] Remove obsolete waitcnt option.
May 25 2018, 1:28 PM · Restricted Project
msearles created D47378: [AMDGPU][Waitcnt] Remove obsolete waitcnt option.
May 25 2018, 10:40 AM · Restricted Project

May 24 2018

msearles added a comment to D46616: [AMDGPU][Waitcnt] Fix handling of flat instrs.

ping

May 24 2018, 3:38 PM · Restricted Project

May 21 2018

msearles committed rC332854: [Clang Tablegen] Add llvm_unreachable() to getModifierName().
[Clang Tablegen] Add llvm_unreachable() to getModifierName()
May 21 2018, 10:33 AM
msearles committed rL332854: [Clang Tablegen] Add llvm_unreachable() to getModifierName().
[Clang Tablegen] Add llvm_unreachable() to getModifierName()
May 21 2018, 10:33 AM
msearles closed D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName().
May 21 2018, 10:33 AM
msearles updated the diff for D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName().

Add comment per reviewer suggestion.

May 21 2018, 10:25 AM
msearles updated the diff for D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName().

Ah, yes. Adding llvm_unreachable() is better. Done.

May 21 2018, 10:05 AM
msearles created D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName().
May 21 2018, 9:47 AM

May 17 2018

msearles added a comment to D46616: [AMDGPU][Waitcnt] Fix handling of flat instrs.

ping

May 17 2018, 9:28 PM · Restricted Project

May 10 2018

msearles updated the diff for D46616: [AMDGPU][Waitcnt] Fix handling of flat instrs.

Add subtarget-specific checks

May 10 2018, 8:25 AM · Restricted Project

May 8 2018

msearles updated the diff for D46616: [AMDGPU][Waitcnt] Fix handling of flat instrs.

Update comment as suggested by reviewer.

May 8 2018, 6:49 PM · Restricted Project
msearles created D46616: [AMDGPU][Waitcnt] Fix handling of flat instrs.
May 8 2018, 5:43 PM · Restricted Project

May 7 2018

msearles committed rL331641: [AMDGPU][Waitcnt] Remove the old waitcnt pass.
[AMDGPU][Waitcnt] Remove the old waitcnt pass
May 7 2018, 7:47 AM
msearles closed D46448: [AMDGPU][Waitcnt] Remove the old waitcnt pass, which is no longer maintained and getting crufty.
May 7 2018, 7:47 AM · Restricted Project

May 4 2018

msearles added a comment to D46448: [AMDGPU][Waitcnt] Remove the old waitcnt pass, which is no longer maintained and getting crufty.

Please also remove it from AMDGPU.h. Otherwise LGTM.

May 4 2018, 3:26 PM · Restricted Project
msearles updated the diff for D46448: [AMDGPU][Waitcnt] Remove the old waitcnt pass, which is no longer maintained and getting crufty.

Remove old waitcnt pass from lib/Target/AMDGPU/AMDGPU.h

May 4 2018, 3:26 PM · Restricted Project
msearles added reviewers for D46448: [AMDGPU][Waitcnt] Remove the old waitcnt pass, which is no longer maintained and getting crufty: arsenm, rampitec.
May 4 2018, 3:13 PM · Restricted Project
msearles updated the diff for D46448: [AMDGPU][Waitcnt] Remove the old waitcnt pass, which is no longer maintained and getting crufty.

Add waitcnt.mir

May 4 2018, 1:10 PM · Restricted Project
msearles created D46448: [AMDGPU][Waitcnt] Remove the old waitcnt pass, which is no longer maintained and getting crufty.
May 4 2018, 12:52 PM · Restricted Project

May 1 2018

msearles added inline comments to D46298: AMDGPU: Move isSDNodeSourceOfDivergence() implementation to SITargetLowering.
May 1 2018, 8:57 AM

Apr 27 2018

msearles committed rL331062: [AMDGPU][Waitcnt] Update a few tests to use default waitcnt pass (si-insert….
[AMDGPU][Waitcnt] Update a few tests to use default waitcnt pass (si-insert…
Apr 27 2018, 11:02 AM
msearles closed D46154: [AMDGPU][Waitcnt] Update a few lit tests to use the default waitcnt pass.
Apr 27 2018, 11:02 AM · Restricted Project

Apr 26 2018

msearles added reviewers for D46154: [AMDGPU][Waitcnt] Update a few lit tests to use the default waitcnt pass: cfang, FarhanaAleen.
Apr 26 2018, 4:42 PM · Restricted Project