This cleanup patch refactors a bunch of functional duplicates of
getDecltypeForParenthesizedExpr into a common implementation.
Signed-off-by: Matheus Izvekov <mizvekov@gmail.com>
Differential D100713
[clang] NFC: refactor multiple implementations of getDecltypeForParenthesizedExpr mizvekov on Apr 17 2021, 6:51 PM. Authored by
Details This cleanup patch refactors a bunch of functional duplicates of Signed-off-by: Matheus Izvekov <mizvekov@gmail.com>
Diff Detail
Event TimelineComment Actions It seems that using is*Value and the introduction of getDecltypeForParenthesizedExpr could be two separate changes.
Comment Actions Again, I'm not sure if it helps to use getDecltypeForParenthesizedExpr where we don't actually have the decltype of a parenthesized expression. It's probably not entirely coincidental, but things aren't defined this way.
Comment Actions The current situation with getDecltypeForParenthesizedExpr is that it already is used in some places where there is no decltype of a parenthesized expression either. This function is a bit new, I introduced it in D98160. I think the mnemonic is OK, but this is the best I could come up at the time. If you have better suggestions, I am all for it. I think it's no coincidence that for the patch I am working on, I had to change all of these copies in exactly the same way :)
Comment Actions
|