Page MenuHomePhabricator

mizvekov (Matheus Izvekov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 25 2021, 3:57 PM (68 w, 6 d)

Recent Activity

Nov 23 2021

mizvekov added inline comments to D113161: [libc++] Implement P1989R2: range constructor for string_view.
Nov 23 2021, 5:31 PM · Restricted Project
mizvekov updated the diff for D112374: [clang] Implement ElaboratedType sugaring for types written bare.
  • fix IntrospectionTests.
Nov 23 2021, 4:28 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov updated the diff for D112374: [clang] Implement ElaboratedType sugaring for types written bare.
  • Avoid using any storage for an empty ElaboratedTYpeLoc.
    • But we still require pointer alignment for it, due to pre-existing bugs.
Nov 23 2021, 1:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 21 2021

mizvekov added a comment to D113161: [libc++] Implement P1989R2: range constructor for string_view.

By the way, the issues you see with concepts here are related to the cache, and how invalidation is not implemented.

Nov 21 2021, 5:06 PM · Restricted Project

Nov 18 2021

mizvekov committed rG85914b757015: [clang] fix regression deducing pack expansion arguments introduced by D110216 (authored by mizvekov).
[clang] fix regression deducing pack expansion arguments introduced by D110216
Nov 18 2021, 6:36 PM
mizvekov closed D114207: [clang] fix regression deducing pack expansion arguments introduced by D110216.
Nov 18 2021, 6:36 PM · Restricted Project
mizvekov added a comment to D114207: [clang] fix regression deducing pack expansion arguments introduced by D110216.

Thanks for testing!

Nov 18 2021, 6:27 PM · Restricted Project
mizvekov added a reviewer for D114207: [clang] fix regression deducing pack expansion arguments introduced by D110216: rsmith.
Nov 18 2021, 6:22 PM · Restricted Project
mizvekov added a comment to D110216: [clang] retain type sugar in auto / template argument deduction.

Fix pushed to https://reviews.llvm.org/D114207

Nov 18 2021, 5:40 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov added a comment to D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check.

Thanks for the quick review! Can you also commit it for me? You can use name and email as in commit 738e7f1231949ec248c1d8d154783338215613d1. Thank you!

Nov 18 2021, 4:55 PM · Restricted Project
mizvekov requested review of D114207: [clang] fix regression deducing pack expansion arguments introduced by D110216.
Nov 18 2021, 4:33 PM · Restricted Project
mizvekov added a comment to D110216: [clang] retain type sugar in auto / template argument deduction.

Hi we found regression in our internal tests. It compiles with clang-13.0.0 https://godbolt.org/z/3abGrcf7o and gcc https://godbolt.org/z/K9oj3Grs1, but fails with clang-trunk https://godbolt.org/z/1Tehxa1x9. Is it an intended change? If so, do we have to document this?

Nov 18 2021, 4:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov accepted D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check.

LGTM

Nov 18 2021, 2:51 PM · Restricted Project

Nov 17 2021

mizvekov added a comment to D110216: [clang] retain type sugar in auto / template argument deduction.

Isolated example:

template <class T, int=0> struct span {};
Nov 17 2021, 12:08 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov added a comment to D110216: [clang] retain type sugar in auto / template argument deduction.

I am not sure how to reproduce this.

Attaching preprocessed source. With Clang built at 508aa4fe0c82b3b409e2e194d591ee6d665c8623 it reproduces for me like this:

$ clang++ -c /tmp/a.ii
../../base/containers/span_unittest.cc:11:13: error: no viable conversion from 'span<T, [...]>' to 'span<int, [...]>'
  span<int> s = make_span(v);
            ^   ~~~~~~~~~~~~
../../base/containers/span.h:340:13: note: candidate constructor not viable: no known conversion from 'span<T, Extent::value>' (aka 'span<const int, Extent::value>') to 'const base::span<int, 18446744073709551615> &' for 1st argument
  constexpr span(const span& other) noexcept = default;
            ^
Nov 17 2021, 12:04 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 16 2021

mizvekov added a comment to D104478: [clang] p2085 out-of-class comparison operator defaulting.

When we instantiate a template definition, we don't instantiate a new declaration. That's fine when the introducing declaration is the definition. But when we have a forward declaration, we can run into problems. For instance, regard:

Nov 16 2021, 3:53 PM · Restricted Project
mizvekov accepted D104478: [clang] p2085 out-of-class comparison operator defaulting.

From my POV this looks good.

Nov 16 2021, 3:34 PM · Restricted Project
mizvekov added a comment to D110216: [clang] retain type sugar in auto / template argument deduction.

We're seeing a diagnostic change in Chromium which looks funny. For the following code (span<> is our own class):
....
the diagnostic changes from:

fatal error: no viable conversion from 'span<const int, [...]>' to 'span<int, [...]>

to

fatal error: no viable conversion from 'span<T, [...]>' to 'span<int, [...]>

This looks very strange.

Nov 16 2021, 12:55 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov updated the diff for D112374: [clang] Implement ElaboratedType sugaring for types written bare.

rebase

Nov 16 2021, 10:43 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov published D112374: [clang] Implement ElaboratedType sugaring for types written bare for review.
Nov 16 2021, 10:40 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov committed rG35f798d05d51: [libcxx] CI: only build native target for bootstrapping-build (authored by mizvekov).
[libcxx] CI: only build native target for bootstrapping-build
Nov 16 2021, 8:23 AM
mizvekov closed D113950: [libcxx] CI: only build native target for bootstrapping-build.
Nov 16 2021, 8:22 AM · Restricted Project
mizvekov added a comment to D113950: [libcxx] CI: only build native target for bootstrapping-build.

Thanks for the review!

Nov 16 2021, 8:17 AM · Restricted Project
mizvekov updated the diff for D111509: [clang] use getCommonSugar in an assortment of places.
  • Run libcxx CI
Nov 16 2021, 5:01 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov updated the diff for D111283: [clang] template / auto deduction deduces common sugar.

.

Nov 16 2021, 3:46 AM · Restricted Project, Restricted Project
mizvekov updated the diff for D111283: [clang] template / auto deduction deduces common sugar.
  • Fix rebuilding Template Specializations
Nov 16 2021, 3:41 AM · Restricted Project, Restricted Project

Nov 15 2021

mizvekov committed rG21ed00bc1bfd: [clang] NFC: rename internal `IsPossiblyOpaquelyQualifiedType` overload (authored by mizvekov).
[clang] NFC: rename internal `IsPossiblyOpaquelyQualifiedType` overload
Nov 15 2021, 6:10 PM
mizvekov closed D113954: [clang] NFC: rename internal `IsPossiblyOpaquelyQualifiedType` overload.
Nov 15 2021, 6:10 PM · Restricted Project
mizvekov added a comment to D113950: [libcxx] CI: only build native target for bootstrapping-build.

Rough estimate of improvement:

Nov 15 2021, 5:23 PM · Restricted Project
mizvekov updated the diff for D113954: [clang] NFC: rename internal `IsPossiblyOpaquelyQualifiedType` overload.

.

Nov 15 2021, 5:09 PM · Restricted Project
mizvekov requested review of D113954: [clang] NFC: rename internal `IsPossiblyOpaquelyQualifiedType` overload.
Nov 15 2021, 4:52 PM · Restricted Project
mizvekov added a reviewer for D113950: [libcxx] CI: only build native target for bootstrapping-build: ldionne.
Nov 15 2021, 4:32 PM · Restricted Project
mizvekov requested review of D113950: [libcxx] CI: only build native target for bootstrapping-build.
Nov 15 2021, 3:35 PM · Restricted Project
mizvekov updated the diff for D111283: [clang] template / auto deduction deduces common sugar.
  • Add libcxx/DELETE.ME to trigger libcxx CI.
Nov 15 2021, 2:18 PM · Restricted Project, Restricted Project
mizvekov committed rGc9e46219f38d: [clang] retain type sugar in auto / template argument deduction (authored by mizvekov).
[clang] retain type sugar in auto / template argument deduction
Nov 15 2021, 2:08 PM
mizvekov closed D110216: [clang] retain type sugar in auto / template argument deduction.
Nov 15 2021, 2:08 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov updated the diff for D110216: [clang] retain type sugar in auto / template argument deduction.
  • IsPossiblyOpaquelyQualifiedType should use canonical type.
  • Add test
Nov 15 2021, 1:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov added a comment to D110216: [clang] retain type sugar in auto / template argument deduction.

FYI this is a minimal repro taken from Martin's preprocessed source (Thanks!):

template <class> struct a { using b = const float; };
template <class c> using d = typename a<c>::b;
Nov 15 2021, 8:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov committed rG9fec50f001b1: [cmake] use project relative paths when generating ASTNodeAPI.json (authored by mizvekov).
[cmake] use project relative paths when generating ASTNodeAPI.json
Nov 15 2021, 3:36 AM
mizvekov closed D113664: [cmake] use project relative paths when generating ASTNodeAPI.json.
Nov 15 2021, 3:35 AM · Restricted Project

Nov 14 2021

mizvekov reopened D110216: [clang] retain type sugar in auto / template argument deduction.

Reverting for now.

Nov 14 2021, 3:30 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov added a reverting change for rG4d8fff477e02: [clang] retain type sugar in auto / template argument deduction: rG6438a52df1c7: Revert "[clang] retain type sugar in auto / template argument deduction".
Nov 14 2021, 3:30 PM
mizvekov committed rG6438a52df1c7: Revert "[clang] retain type sugar in auto / template argument deduction" (authored by mizvekov).
Revert "[clang] retain type sugar in auto / template argument deduction"
Nov 14 2021, 3:30 PM
mizvekov added a reverting change for D110216: [clang] retain type sugar in auto / template argument deduction: rG6438a52df1c7: Revert "[clang] retain type sugar in auto / template argument deduction".
Nov 14 2021, 3:30 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov added a comment to D110216: [clang] retain type sugar in auto / template argument deduction.
Nov 14 2021, 1:27 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 12 2021

mizvekov committed rG4d8fff477e02: [clang] retain type sugar in auto / template argument deduction (authored by mizvekov).
[clang] retain type sugar in auto / template argument deduction
Nov 12 2021, 6:35 PM
mizvekov closed D110216: [clang] retain type sugar in auto / template argument deduction.
Nov 12 2021, 6:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov added a comment to D110216: [clang] retain type sugar in auto / template argument deduction.

Okay, libcxx pipeline passes, disregarding the clang-format failure for pre-existing badness in those files, which would need to be fixed separately or else git loses track of the rename.
The AIX failures also seem completely unrelated.

Nov 12 2021, 5:36 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov updated the diff for D110216: [clang] retain type sugar in auto / template argument deduction.

use --nolint this time, it seems to have flubbed the rename somehow.

Nov 12 2021, 4:25 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov updated the diff for D110216: [clang] retain type sugar in auto / template argument deduction.
  • Incorporating fixes for post-commit failures.
Nov 12 2021, 4:18 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov updated subscribers of D110216: [clang] retain type sugar in auto / template argument deduction.

Exactly what Aaron said :-)

Nov 12 2021, 7:53 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 11 2021

mizvekov updated the summary of D111283: [clang] template / auto deduction deduces common sugar.
Nov 11 2021, 5:06 PM · Restricted Project, Restricted Project
mizvekov committed rG55085952175e: [lldb] fix test expectation broken by clang fix at D110216 (authored by mizvekov).
[lldb] fix test expectation broken by clang fix at D110216
Nov 11 2021, 4:48 PM
mizvekov closed D113722: [lldb] fix test expectation broken by clang fix at D110216.
Nov 11 2021, 4:47 PM · Restricted Project
mizvekov added a reviewer for D113722: [lldb] fix test expectation broken by clang fix at D110216: zturner.
Nov 11 2021, 4:31 PM · Restricted Project
mizvekov added a comment to D113722: [lldb] fix test expectation broken by clang fix at D110216.

Fixes buildbot failure seen at http://lab.llvm.org:8011/#/builders/68/builds/21662/steps/6/logs/stdio
Caused by a fix in D110216.

Nov 11 2021, 4:30 PM · Restricted Project
mizvekov requested review of D113722: [lldb] fix test expectation broken by clang fix at D110216.
Nov 11 2021, 4:29 PM · Restricted Project
mizvekov committed rG9b6036deedf2: [clang] retain type sugar in auto / template argument deduction (authored by mizvekov).
[clang] retain type sugar in auto / template argument deduction
Nov 11 2021, 4:17 PM
mizvekov closed D110216: [clang] retain type sugar in auto / template argument deduction.
Nov 11 2021, 4:17 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov added inline comments to D110216: [clang] retain type sugar in auto / template argument deduction.
Nov 11 2021, 2:54 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov updated the diff for D110216: [clang] retain type sugar in auto / template argument deduction.

address last comments, one last CI push.

Nov 11 2021, 2:52 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov added a reviewer for D113664: [cmake] use project relative paths when generating ASTNodeAPI.json: chandlerc.
Nov 11 2021, 1:03 PM · Restricted Project
mizvekov published D113664: [cmake] use project relative paths when generating ASTNodeAPI.json for review.
Nov 11 2021, 9:01 AM · Restricted Project

Nov 4 2021

mizvekov updated the diff for D109496: [clang] deprecate frelaxed-template-template-args, make it on by default.

.

Nov 4 2021, 6:06 PM · Restricted Project
mizvekov added a comment to D104478: [clang] p2085 out-of-class comparison operator defaulting.

Am I correct in thinking that instantiating a function definition doesn't create a new FunctionDecl, but attaches the definition to the already-instantiated FunctionDecl instance? See the code where I update the instantiation's location in the out-of-class defaulting case. Without that change, the errors for bad default parameter types point at the in-class declaration, which is not helpful.

Nov 4 2021, 4:37 PM · Restricted Project
mizvekov updated the diff for D109496: [clang] deprecate frelaxed-template-template-args, make it on by default.

Implement workaround.

Nov 4 2021, 2:55 PM · Restricted Project

Nov 2 2021

mizvekov planned changes to D109496: [clang] deprecate frelaxed-template-template-args, make it on by default.
Nov 2 2021, 4:00 PM · Restricted Project
mizvekov reopened D109496: [clang] deprecate frelaxed-template-template-args, make it on by default.
Nov 2 2021, 4:00 PM · Restricted Project
mizvekov added a comment to D109496: [clang] deprecate frelaxed-template-template-args, make it on by default.

Feel free to revert it if this is blocking you. I don't seem to find a way to do it via web interface, so I need more time to have access to a machine that can do it

Nov 2 2021, 1:12 PM · Restricted Project
mizvekov added a comment to D109496: [clang] deprecate frelaxed-template-template-args, make it on by default.

Thanks for reporting this!

Nov 2 2021, 1:05 PM · Restricted Project

Oct 31 2021

mizvekov updated the summary of D111509: [clang] use getCommonSugar in an assortment of places.
Oct 31 2021, 9:03 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov updated the diff for D111509: [clang] use getCommonSugar in an assortment of places.

rebase

Oct 31 2021, 8:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov updated the diff for D111283: [clang] template / auto deduction deduces common sugar.

rebase

Oct 31 2021, 7:42 AM · Restricted Project, Restricted Project

Oct 30 2021

mizvekov updated the summary of D110216: [clang] retain type sugar in auto / template argument deduction.
Oct 30 2021, 9:38 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov added inline comments to D110216: [clang] retain type sugar in auto / template argument deduction.
Oct 30 2021, 9:38 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov updated the diff for D110216: [clang] retain type sugar in auto / template argument deduction.

Address rsmith's review comments.

Oct 30 2021, 9:34 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 27 2021

mizvekov committed rG32d45862fc03: [clang] NFC: remove carriage return from AST tests (authored by mizvekov).
[clang] NFC: remove carriage return from AST tests
Oct 27 2021, 3:25 PM
mizvekov closed D112372: [clang] NFC: remove carriage return from AST tests.
Oct 27 2021, 3:25 PM · Restricted Project
mizvekov updated the diff for D112372: [clang] NFC: remove carriage return from AST tests.

rebase, rerun pipeline.

Oct 27 2021, 2:16 PM · Restricted Project
mizvekov committed rG086e111216bc: [clang] NFC: include non friendly types and missing sugar in test expectations (authored by mizvekov).
[clang] NFC: include non friendly types and missing sugar in test expectations
Oct 27 2021, 2:03 PM
mizvekov closed D110210: [clang] NFC: include non friendly types and missing sugar in test expectations.
Oct 27 2021, 2:03 PM · Restricted Project
mizvekov committed rG2d7fba5f95f0: [clang] deprecate frelaxed-template-template-args, make it on by default (authored by mizvekov).
[clang] deprecate frelaxed-template-template-args, make it on by default
Oct 27 2021, 1:48 PM
mizvekov closed D109496: [clang] deprecate frelaxed-template-template-args, make it on by default.
Oct 27 2021, 1:48 PM · Restricted Project
mizvekov updated the diff for D109496: [clang] deprecate frelaxed-template-template-args, make it on by default.

rebase, one last CI run.

Oct 27 2021, 1:05 PM · Restricted Project

Oct 23 2021

mizvekov requested review of D112372: [clang] NFC: remove carriage return from AST tests.
Oct 23 2021, 3:48 PM · Restricted Project

Oct 18 2021

mizvekov added inline comments to D104478: [clang] p2085 out-of-class comparison operator defaulting.
Oct 18 2021, 1:48 PM · Restricted Project
mizvekov added inline comments to D104478: [clang] p2085 out-of-class comparison operator defaulting.
Oct 18 2021, 8:06 AM · Restricted Project
mizvekov added inline comments to D111307: [clang] __attribute__ bpf_dominating_decl .
Oct 18 2021, 3:05 AM · Restricted Project

Oct 15 2021

mizvekov committed rG489561d46381: [clang] fix typo correction not looking for candidates in base classes. (authored by mizvekov).
[clang] fix typo correction not looking for candidates in base classes.
Oct 15 2021, 3:35 PM
mizvekov closed D111830: [clang] fix typo correction not looking for candidates in base classes..
Oct 15 2021, 3:35 PM · Restricted Project

Oct 14 2021

mizvekov added a comment to D104478: [clang] p2085 out-of-class comparison operator defaulting.

Hello! Thanks for this, just a few small comments, I'll try to give it a more careful look later!

Oct 14 2021, 3:55 PM · Restricted Project
mizvekov added inline comments to D111307: [clang] __attribute__ bpf_dominating_decl .
Oct 14 2021, 3:08 PM · Restricted Project
mizvekov updated the diff for D111830: [clang] fix typo correction not looking for candidates in base classes..

.

Oct 14 2021, 12:55 PM · Restricted Project
mizvekov added a reviewer for D111830: [clang] fix typo correction not looking for candidates in base classes.: rsmith.
Oct 14 2021, 12:52 PM · Restricted Project
mizvekov requested review of D111830: [clang] fix typo correction not looking for candidates in base classes..
Oct 14 2021, 12:51 PM · Restricted Project

Oct 12 2021

mizvekov added inline comments to D111283: [clang] template / auto deduction deduces common sugar.
Oct 12 2021, 4:02 PM · Restricted Project, Restricted Project
mizvekov added a reviewer for D111509: [clang] use getCommonSugar in an assortment of places: rsmith.
Oct 12 2021, 4:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov published D111509: [clang] use getCommonSugar in an assortment of places for review.
Oct 12 2021, 4:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mizvekov updated the diff for D111283: [clang] template / auto deduction deduces common sugar.
  • Introduce TDK_AlreadyDiagnosed.
Oct 12 2021, 2:05 PM · Restricted Project, Restricted Project
mizvekov updated the diff for D110216: [clang] retain type sugar in auto / template argument deduction.

.

Oct 12 2021, 12:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project