Page MenuHomePhabricator

aaronpuchert (Aaron Puchert)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2018, 4:43 PM (207 w, 5 d)

Recent Activity

May 18 2022

aaronpuchert added a comment to D125798: [release] Add cmake as an extra tarball and not bundle it.

You might also mention that this solves #54716 (in my understanding).

May 18 2022, 4:27 AM · Restricted Project, Restricted Project
aaronpuchert accepted D125798: [release] Add cmake as an extra tarball and not bundle it.

Looks good to me.

May 18 2022, 4:22 AM · Restricted Project, Restricted Project

May 16 2022

aaronpuchert added a comment to D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument.

Proposed this in D125580.

May 16 2022, 5:25 AM · Restricted Project, Restricted Project

May 14 2022

aaronpuchert added inline comments to D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum.
May 14 2022, 1:45 PM · Restricted Project, Restricted Project
aaronpuchert added inline comments to D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum.
May 14 2022, 4:06 AM · Restricted Project, Restricted Project
aaronpuchert committed rGac7a9ef0ae3a: Resolve overload ambiguity on Mac OS when printing size_t in diagnostics (authored by aaronpuchert).
Resolve overload ambiguity on Mac OS when printing size_t in diagnostics
May 14 2022, 3:38 AM · Restricted Project, Restricted Project
aaronpuchert closed D125580: Resolve overload ambiguity on Mac OS when printing size_t in diagnostics.
May 14 2022, 3:38 AM · Restricted Project, Restricted Project

May 13 2022

aaronpuchert added a comment to D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument.

And it appears that unsigned long does not have a clear favorite here.

May 13 2022, 1:18 PM · Restricted Project, Restricted Project
aaronpuchert requested review of D125580: Resolve overload ambiguity on Mac OS when printing size_t in diagnostics.
May 13 2022, 1:17 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument.

So we have overloads

May 13 2022, 7:35 AM · Restricted Project, Restricted Project
aaronpuchert committed rG25862f53cce9: Try to disambiguate between overloads on Mac (authored by aaronpuchert).
Try to disambiguate between overloads on Mac
May 13 2022, 7:29 AM · Restricted Project, Restricted Project
aaronpuchert added a comment to D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument.

Hmm, didn't see this on Linux. I'll try to disambiguate.

May 13 2022, 7:21 AM · Restricted Project, Restricted Project
aaronpuchert committed rGd2396d896ee1: Comment parsing: Treat properties as zero-argument inline commands (authored by aaronpuchert).
Comment parsing: Treat properties as zero-argument inline commands
May 13 2022, 4:50 AM · Restricted Project, Restricted Project
aaronpuchert committed rGd3a4033d6ee1: Comment parsing: Allow inline commands to have 0 or more than 1 argument (authored by aaronpuchert).
Comment parsing: Allow inline commands to have 0 or more than 1 argument
May 13 2022, 4:50 AM · Restricted Project, Restricted Project
aaronpuchert committed rG99d35826a043: Comment parsing: Specify argument numbers for some block commands (authored by aaronpuchert).
Comment parsing: Specify argument numbers for some block commands
May 13 2022, 4:49 AM · Restricted Project, Restricted Project
aaronpuchert closed D125473: Comment parsing: Treat properties as zero-argument inline commands.
May 13 2022, 4:49 AM · Restricted Project, Restricted Project
aaronpuchert closed D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument.
May 13 2022, 4:49 AM · Restricted Project, Restricted Project
aaronpuchert closed D125422: Comment parsing: Specify argument numbers for some block commands.
May 13 2022, 4:49 AM · Restricted Project, Restricted Project

May 12 2022

aaronpuchert requested review of D125473: Comment parsing: Treat properties as zero-argument inline commands.
May 12 2022, 9:46 AM · Restricted Project, Restricted Project
aaronpuchert updated the diff for D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument.

Unify Argument types and parsing. Add AST test. Simplify TableGen.

May 12 2022, 9:21 AM · Restricted Project, Restricted Project
aaronpuchert added inline comments to D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument.
May 12 2022, 9:19 AM · Restricted Project, Restricted Project

May 11 2022

aaronpuchert added inline comments to D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument.
May 11 2022, 4:32 PM · Restricted Project, Restricted Project
aaronpuchert requested review of D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument.
May 11 2022, 4:22 PM · Restricted Project, Restricted Project
aaronpuchert updated the diff for D125422: Comment parsing: Specify argument numbers for some block commands.

Add an AST test to check that we parse the arguments correctly. (We don't use them for diagnostics currently.)

May 11 2022, 4:11 PM · Restricted Project, Restricted Project
aaronpuchert requested review of D125422: Comment parsing: Specify argument numbers for some block commands.
May 11 2022, 2:11 PM · Restricted Project, Restricted Project
Herald added a project to D113793: Comment Sema: Run checks only when appropriate (NFC): Restricted Project.

Ping.

May 11 2022, 1:20 PM · Restricted Project, Restricted Project

May 9 2022

aaronpuchert committed rG44ae49e1a725: Thread safety analysis: Handle compound assignment and ->* overloads (authored by aaronpuchert).
Thread safety analysis: Handle compound assignment and ->* overloads
May 9 2022, 6:36 AM · Restricted Project, Restricted Project
aaronpuchert closed D124966: Thread safety analysis: Handle compound assignment and ->* overloads.
May 9 2022, 6:36 AM · Restricted Project, Restricted Project

May 6 2022

aaronpuchert added inline comments to D124966: Thread safety analysis: Handle compound assignment and ->* overloads.
May 6 2022, 2:43 PM · Restricted Project, Restricted Project
aaronpuchert updated the diff for D124966: Thread safety analysis: Handle compound assignment and ->* overloads.

Add a release note.

May 6 2022, 2:28 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D124966: Thread safety analysis: Handle compound assignment and ->* overloads.

LGTM! You should probably add a release note for this change so users know about it.

May 6 2022, 2:26 PM · Restricted Project, Restricted Project
aaronpuchert updated the diff for D124966: Thread safety analysis: Handle compound assignment and ->* overloads.

Use 1 instead of 0 just to be sure. We don't want to trigger warnings about division by zero.

May 6 2022, 6:52 AM · Restricted Project, Restricted Project
aaronpuchert updated the diff for D124966: Thread safety analysis: Handle compound assignment and ->* overloads.

Also consider ++ and -- as writing, test all operators.

May 6 2022, 6:37 AM · Restricted Project, Restricted Project
aaronpuchert added inline comments to D124966: Thread safety analysis: Handle compound assignment and ->* overloads.
May 6 2022, 6:35 AM · Restricted Project, Restricted Project

May 5 2022

aaronpuchert retitled D74588: Use DISABLE_LLVM_LINK_LLVM_DYLIB for TableGenTests from Make TableGenGlobalISel an object library to Use DISABLE_LLVM_LINK_LLVM_DYLIB for TableGenTests.
May 5 2022, 6:48 PM · Restricted Project, Restricted Project

May 4 2022

aaronpuchert updated subscribers of D124966: Thread safety analysis: Handle compound assignment and ->* overloads.

@rupprecht, do you still do integration at Google? This patch might be interesting to try out, since it strengthens some warnings.

May 4 2022, 2:58 PM · Restricted Project, Restricted Project
aaronpuchert requested review of D124966: Thread safety analysis: Handle compound assignment and ->* overloads.
May 4 2022, 2:48 PM · Restricted Project, Restricted Project

Apr 29 2022

aaronpuchert committed rG0314dbac026f: Thread safety analysis: Don't pass capability kind where not needed (NFC) (authored by aaronpuchert).
Thread safety analysis: Don't pass capability kind where not needed (NFC)
Apr 29 2022, 1:32 PM · Restricted Project, Restricted Project
aaronpuchert committed rGd65c922450d1: Thread safety analysis: Store CapabilityExprs in ScopedLockableFactEntry (NFC) (authored by aaronpuchert).
Thread safety analysis: Store CapabilityExprs in ScopedLockableFactEntry (NFC)
Apr 29 2022, 1:32 PM · Restricted Project, Restricted Project
aaronpuchert committed rGf8afb8fdedae: Thread safety analysis: Store capability kind in CapabilityExpr (authored by aaronpuchert).
Thread safety analysis: Store capability kind in CapabilityExpr
Apr 29 2022, 1:32 PM · Restricted Project, Restricted Project
aaronpuchert committed rGdd1790cd05ae: Thread safety analysis: Pack CapabilityExpr using PointerIntPair (NFC) (authored by aaronpuchert).
Thread safety analysis: Pack CapabilityExpr using PointerIntPair (NFC)
Apr 29 2022, 1:32 PM · Restricted Project, Restricted Project
aaronpuchert closed D124132: Thread safety analysis: Don't pass capability kind where not needed (NFC).
Apr 29 2022, 1:32 PM · Restricted Project, Restricted Project
aaronpuchert closed D124128: Thread safety analysis: Store CapabilityExprs in ScopedLockableFactEntry (NFC).
Apr 29 2022, 1:32 PM · Restricted Project, Restricted Project
aaronpuchert closed D124131: Thread safety analysis: Store capability kind in CapabilityExpr.
Apr 29 2022, 1:32 PM · Restricted Project, Restricted Project
aaronpuchert closed D124127: Thread safety analysis: Pack CapabilityExpr using PointerIntPair (NFC).
Apr 29 2022, 1:32 PM · Restricted Project, Restricted Project

Apr 28 2022

aaronpuchert added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

If CMAKE_BUILD_TYPE is specified in a multi-configuration build (like visual studio), the alternative build types won't be available.

Apr 28 2022, 3:14 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D124606: Use `-text` git attribute instead of `text eol=...'.

An editor could inadvertently change the line endings, and someone might not notice before committing.

From what I understood, most of these tests would immediately break (due to hardcoded offsets) if the line endings were changed.

Ok, that's a valid point.

Apr 28 2022, 8:52 AM · Restricted Project, Restricted Project
aaronpuchert added a comment to D124606: Use `-text` git attribute instead of `text eol=...'.

Also I still don't understand what specifically this is fixing. What exactly was wrong about the previous configuration?

Apr 28 2022, 8:12 AM · Restricted Project, Restricted Project
aaronpuchert added a comment to D124606: Use `-text` git attribute instead of `text eol=...'.

Fair enough, but don't we want to enforce LF or CRLF, respectively? An editor could inadvertently change the line endings, and someone might not notice before committing. Explicitly specifying the right line endings gives us the proper line endings even if some editors mess things up.

Apr 28 2022, 8:07 AM · Restricted Project, Restricted Project
aaronpuchert updated subscribers of D124606: Use `-text` git attribute instead of `text eol=...'.

I think this change broke again what D97625 was trying to fix. These are text files and we want them to keep the specified line endings regardless of the local git configuration. See also @smeenai's comment D124563#3478625.

Apr 28 2022, 7:05 AM · Restricted Project, Restricted Project
aaronpuchert added a comment to D124563: Drop '* text=auto' from .gitattributes and normalize.

See D124606. -text seems to be the right compromise.

Apr 28 2022, 6:56 AM · Restricted Project, Restricted Project
aaronpuchert added a comment to D124563: Drop '* text=auto' from .gitattributes and normalize.

As a temporary workaround for switching between branches, just add a local file clang-tools-extra/test/clang-apply-replacements/.gitattributes with contents:

Inputs/crlf/crlf.cpp binary
Inputs/crlf/crlf.cpp.expected binary

This will remove all kinds of filtering for the moment. When you remove that file, just make sure to force checkout both files again to make sure the filter applies.

Apr 28 2022, 5:28 AM · Restricted Project, Restricted Project
aaronpuchert added a comment to D124563: Drop '* text=auto' from .gitattributes and normalize.

This change seems to have broken switching to a branch before the commit completely. The only way I was able to recover my git checkout is to comment out the * text=auto line and then run git reset --hard, otherwise the crlf.cpp files always show up as changed.

Apr 28 2022, 5:19 AM · Restricted Project, Restricted Project

Apr 27 2022

aaronpuchert added a comment to D124563: Drop '* text=auto' from .gitattributes and normalize.

Git will apply the LF -> CRLF transformation when it checks out itself. Git doesn't show the file as modified because after cleaning the file (i.e. applying CRLF -> LF) it's the same as in the index.

Apr 27 2022, 7:24 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D124563: Drop '* text=auto' from .gitattributes and normalize.

I used arc patch and also saw the same thing.

Apr 27 2022, 6:21 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D124563: Drop '* text=auto' from .gitattributes and normalize.

Checking locally I'm seeing LF as the line ending in crlf.cpp in the working directory. Can you double check that everything matches up?

Apr 27 2022, 6:11 PM · Restricted Project, Restricted Project
aaronpuchert committed rGc9a16e8c3d99: Drop '* text=auto' from .gitattributes and normalize (authored by aaronpuchert).
Drop '* text=auto' from .gitattributes and normalize
Apr 27 2022, 6:07 PM · Restricted Project, Restricted Project
aaronpuchert closed D124563: Drop '* text=auto' from .gitattributes and normalize.
Apr 27 2022, 6:07 PM · Restricted Project, Restricted Project
aaronpuchert commandeered D124563: Drop '* text=auto' from .gitattributes and normalize.

Ok, let's do it this way.

Apr 27 2022, 5:58 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D124563: Drop '* text=auto' from .gitattributes and normalize.

Would be nice if someone could accept this. I think this comes closest to the intention of D97625.

Apr 27 2022, 5:51 PM · Restricted Project, Restricted Project
aaronpuchert updated subscribers of D124563: Drop '* text=auto' from .gitattributes and normalize.
Apr 27 2022, 5:49 PM · Restricted Project, Restricted Project
aaronpuchert retitled D124563: Drop '* text=auto' from .gitattributes and normalize from Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b to Drop '* text=auto' from .gitattributes and normalize.
Apr 27 2022, 5:48 PM · Restricted Project, Restricted Project
aaronpuchert updated the diff for D124563: Drop '* text=auto' from .gitattributes and normalize.

Drop * text=auto, so that we renormalize only the files that need it.

Apr 27 2022, 5:46 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D124563: Drop '* text=auto' from .gitattributes and normalize.

I think the way to go is to revert ac5f7be6a868 then land everything as a single stack to prevent this issue.

Apr 27 2022, 5:34 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D124563: Drop '* text=auto' from .gitattributes and normalize.

How about we remove * text=auto for now? Or would that break something?

Apr 27 2022, 5:28 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D124563: Drop '* text=auto' from .gitattributes and normalize.

I *think* this would mean that if you're on Windows and have core.autocrlf set to input, when you commit changes to this files, Git will convert them back to LF line endings. Not 100% sure of that though.

Apr 27 2022, 5:24 PM · Restricted Project, Restricted Project
aaronpuchert added reviewers for D124563: Drop '* text=auto' from .gitattributes and normalize: Meinersbur, LegalizeAdulthood.
Apr 27 2022, 4:43 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D124563: Drop '* text=auto' from .gitattributes and normalize.

Most of the files changed here are not affected by the .gitattributes file, such as

clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-duplicate-include/readability-duplicate-include.h
clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-duplicate-include/readability-duplicate-include2.h
clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-duplicate-include/system/sys/types.h
clang-tools-extra/test/clang-tidy/checkers/readability-else-after-return-if-constexpr.cpp
clang-tools-extra/test/modularize/Inputs/CompileError/module.modulemap
clang-tools-extra/test/modularize/Inputs/MissingHeader/module.modulemap
clang-tools-extra/test/pp-trace/Inputs/module.map

The only affected files seem to be

clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp
clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp.expected
Apr 27 2022, 4:38 PM · Restricted Project, Restricted Project

Apr 26 2022

aaronpuchert added a comment to D124367: [docs] Improve documentation around CMAKE_BUILD_TYPE.

This looks pretty good!

Apr 26 2022, 3:52 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to rGac5f7be6a868: Move test/.gitattributes to clang-tools-extra/test.

Are the files bit-by-bit identical between the checkouts? I guess it might be an issue in the index.

Apr 26 2022, 3:33 PM · Restricted Project, Restricted Project

Apr 25 2022

aaronpuchert added a comment to D124367: [docs] Improve documentation around CMAKE_BUILD_TYPE.

The build types control three different aspects, so maybe you could even present this as a table:

Apr 25 2022, 5:06 PM · Restricted Project, Restricted Project
aaronpuchert added inline comments to D124128: Thread safety analysis: Store CapabilityExprs in ScopedLockableFactEntry (NFC).
Apr 25 2022, 7:26 AM · Restricted Project, Restricted Project

Apr 24 2022

aaronpuchert added a comment to D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings.

I'm not sure it will do much where it is.

Apr 24 2022, 1:44 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
aaronpuchert committed rGac5f7be6a868: Move test/.gitattributes to clang-tools-extra/test (authored by aaronpuchert).
Move test/.gitattributes to clang-tools-extra/test
Apr 24 2022, 1:43 PM · Restricted Project, Restricted Project

Apr 22 2022

aaronpuchert added inline comments to D124131: Thread safety analysis: Store capability kind in CapabilityExpr.
Apr 22 2022, 4:35 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.
  • Linker OOMs are mainly caused by large object files, both due to code size of unoptimized code and especially due to the extra debug info. Hence the first recommendation in any of the forums when people show a linker OOM is to make sure they're using a release build, if that is what they intended, and to use LLD or Gold (that is a separate topic however)
Apr 22 2022, 4:02 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

My experience tells me that if we present 3 options to choose from, many users will just randomly pick one without thinking about it, and we'll still get bug reports about debug builds using too much memory.

Apr 22 2022, 7:07 AM · Restricted Project, Restricted Project

Apr 21 2022

aaronpuchert added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

We could also point to https://llvm.org/docs/CMake.html if no CMAKE_BUILD_TYPE is given. Depending on the use case (e.g. debug info might actually be wanted) other flags might be helpful like BUILD_SHARED_LIBS or LLVM_USE_SPLIT_DWARF. Or if you're working on frontend topics, set LLVM_TARGETS_TO_BUILD=Native. Some of these have a greater effect on build time/size than CMAKE_BUILD_TYPE=Release in my experience, and the page lists these options quite nicely.

Apr 21 2022, 1:50 PM · Restricted Project, Restricted Project
aaronpuchert updated subscribers of D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.
  • We can flip it to ON if you don't specify CMAKE_BUILD_TYPE and OFF if you pass Release and ON when passing debug. But this seems a bit ... convoluted? Is that really what end users expect?

Actually I think that's exactly how it works today :-)

I see your point about the logic getting convoluted, but I don't think it'd be too bad, especially since we're printing a message about it anyway. It could be "No build type selected, default to Release with asserts enabled".

Apr 21 2022, 10:15 AM · Restricted Project, Restricted Project

Apr 20 2022

aaronpuchert requested review of D124132: Thread safety analysis: Don't pass capability kind where not needed (NFC).
Apr 20 2022, 2:50 PM · Restricted Project, Restricted Project
aaronpuchert requested review of D124131: Thread safety analysis: Store capability kind in CapabilityExpr.
Apr 20 2022, 2:44 PM · Restricted Project, Restricted Project
aaronpuchert requested review of D124128: Thread safety analysis: Store CapabilityExprs in ScopedLockableFactEntry (NFC).
Apr 20 2022, 2:29 PM · Restricted Project, Restricted Project
aaronpuchert requested review of D124127: Thread safety analysis: Pack CapabilityExpr using PointerIntPair (NFC).
Apr 20 2022, 2:24 PM · Restricted Project, Restricted Project

Mar 29 2022

aaronpuchert added a comment to rGf10cee91ae07: [clang-tidy] Fix test failing on 32-bit architectures due to missing….

This fix doesn't look correct as filecheck will still look for the diagnostic on 32bit platforms. You would also need to use a check-prefix to disable the filecheck check line

Mar 29 2022, 3:45 PM · Restricted Project, Restricted Project

Mar 28 2022

aaronpuchert added a comment to D122544: Utilize comparison operation implemented in APInt.

Note that __int128_t is not available everywhere, generally only on 64-bit platforms.

Mar 28 2022, 6:50 PM · Restricted Project, Restricted Project
aaronpuchert committed rG1721d52a6206: Let clang-repl link privately against Clang components (authored by aaronpuchert).
Let clang-repl link privately against Clang components
Mar 28 2022, 2:54 PM · Restricted Project, Restricted Project
aaronpuchert closed D122546: Let clang-repl link privately against Clang components.
Mar 28 2022, 2:54 PM · Restricted Project, Restricted Project

Mar 27 2022

aaronpuchert requested review of D122546: Let clang-repl link privately against Clang components.
Mar 27 2022, 12:10 PM · Restricted Project, Restricted Project

Mar 24 2022

aaronpuchert accepted D122343: Support ObjC Method call in enforce_tcb checks.

Feel free to fix that on commit.

Mar 24 2022, 1:02 PM · Restricted Project, Restricted Project

Mar 23 2022

aaronpuchert added a comment to D122343: Support ObjC Method call in enforce_tcb checks.

Just some suggestions, feel free to ignore them.

Mar 23 2022, 4:57 PM · Restricted Project, Restricted Project

Mar 22 2022

aaronpuchert added a comment to D122090: [PPCISelLowering] Avoid emitting calls to __multi3, __muloti4.

I think it would only be safe to assume --rtlib=compiler-rt if the compiler was driving a full link. Otherwise, the linker could be invoked manually against libgcc.

Mar 22 2022, 4:16 PM · Restricted Project, Restricted Project

Mar 21 2022

aaronpuchert added inline comments to D121972: Add cmake/ to release tarballs via concatenation.
Mar 21 2022, 7:32 AM · Restricted Project, Restricted Project
aaronpuchert committed rG3a33664e8838: Add cmake/ to release tarballs via concatenation (authored by aaronpuchert).
Add cmake/ to release tarballs via concatenation
Mar 21 2022, 7:29 AM · Restricted Project
aaronpuchert closed D121972: Add cmake/ to release tarballs via concatenation.
Mar 21 2022, 7:29 AM · Restricted Project, Restricted Project

Mar 20 2022

aaronpuchert added a comment to D122090: [PPCISelLowering] Avoid emitting calls to __multi3, __muloti4.

I was also wondering if we could block the overflow intrinsics only if Subtarget.getTargetTriple().isGNUEnvironment() is true, but we can also discuss this separately.

Mar 20 2022, 3:46 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D121740: [docs] Add details to MemorySSA docs..

Seems to have broken the documentation build:

Warning, treated as error:
/home/buildbot/llvm-build-dir/llvm-sphinx-docs/llvm/src/llvm/docs/MemorySSA.rst:168:Unknown target name: "build-time use optimization".
Mar 20 2022, 1:16 PM · Restricted Project, Restricted Project
aaronpuchert committed rGc1a31ee65b3a: [PPCISelLowering] Avoid emitting calls to __multi3, __muloti4 (authored by aaronpuchert).
[PPCISelLowering] Avoid emitting calls to __multi3, __muloti4
Mar 20 2022, 1:00 PM · Restricted Project
aaronpuchert closed D122090: [PPCISelLowering] Avoid emitting calls to __multi3, __muloti4.
Mar 20 2022, 1:00 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D122090: [PPCISelLowering] Avoid emitting calls to __multi3, __muloti4.

I was also wondering if we could block the overflow intrinsics only if Subtarget.getTargetTriple().isGNUEnvironment() is true, but we can also discuss this separately. (That would affect all targets then, I guess.)

Mar 20 2022, 6:34 AM · Restricted Project, Restricted Project
aaronpuchert updated the diff for D122090: [PPCISelLowering] Avoid emitting calls to __multi3, __muloti4.

Had to adapt two more tests where we were emitting __multi3 calls on PowerPC 32-bit. That builtin doesn't exist even in compiler-rt, so I guess it's an improvement.

Mar 20 2022, 6:26 AM · Restricted Project, Restricted Project