Page MenuHomePhabricator

aaronpuchert (Aaron Puchert)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2018, 4:43 PM (153 w, 45 m)

Recent Activity

Mon, Jun 14

aaronpuchert added a comment to D96670: [CMake] Look up target subcomponents in LLVM_AVAILABLE_LIBS.

Ping.

Mon, Jun 14, 2:39 PM · Restricted Project
aaronpuchert added inline comments to D104261: Thread safety analysis: Always warn when dropping locks on back edges.
Mon, Jun 14, 1:15 PM · Restricted Project
aaronpuchert requested review of D104261: Thread safety analysis: Always warn when dropping locks on back edges.
Mon, Jun 14, 12:58 PM · Restricted Project

Wed, Jun 9

aaronpuchert added a comment to D99696: [clang] NRVO: Improvements and handling of more cases..

@aaronpuchert what's your take on D99696 at this point; is it good to go or still unresolved issues?

Wed, Jun 9, 4:19 PM · Restricted Project

Sat, Jun 5

aaronpuchert committed rGdc1e7b73b818: Make TableGenGlobalISel an object library (authored by aaronpuchert).
Make TableGenGlobalISel an object library
Sat, Jun 5, 6:05 AM
aaronpuchert closed D74588: Make TableGenGlobalISel an object library.
Sat, Jun 5, 6:05 AM · Restricted Project

Thu, May 27

aaronpuchert added a comment to D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities.

Assert_capability is not a back door. It is supposed to be used only on a function which does a run-time check: if (!mu_.is_locked()) fail().

Right, although assertions can turn into no-ops depending on the build profile. We discussed this on D87629.

Thu, May 27, 5:21 PM · Restricted Project
aaronpuchert added a comment to D101566: Let -Wweak-template-vtables warn on implicit instantiations.

Right - to remove -Wweak-template-vtable in its entirety. The original implementation explicitly didn't warn on implicit instantiations and I think the fact that it warned on explicit instantiations is more bug than feature - and we should treat it that way.

Thu, May 27, 4:50 PM · Restricted Project
aaronpuchert added a comment to D101566: Let -Wweak-template-vtables warn on implicit instantiations.

Makes it hard to justify the complexity in the compiler if it's hard to justify/support the value of the warning.

The complexity for -Wweak-template-vtables is just 10 lines of code. We're just using information that's already there.

Thu, May 27, 9:46 AM · Restricted Project
aaronpuchert committed rGcf0b337c1b1f: Thread safety analysis: Allow exlusive/shared joins for managed and asserted… (authored by aaronpuchert).
Thread safety analysis: Allow exlusive/shared joins for managed and asserted…
Thu, May 27, 8:47 AM
aaronpuchert committed rG3d64677c2807: Thread safety analysis: Factor out function for merging locks (NFC) (authored by aaronpuchert).
Thread safety analysis: Factor out function for merging locks (NFC)
Thu, May 27, 8:46 AM
aaronpuchert closed D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities.
Thu, May 27, 8:46 AM · Restricted Project
aaronpuchert closed D102025: Thread safety analysis: Factor out function for merging locks (NFC).
Thu, May 27, 8:46 AM · Restricted Project
aaronpuchert added a comment to D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities.

Thanks for taking the time to discuss things with me. :-)

Thank you as well!

Thu, May 27, 8:43 AM · Restricted Project

Tue, May 25

aaronpuchert added a comment to D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities.

So this change will allow shared/exclusive - asserted/unmanaged joins until my follow-up will disallow them again, though because of the asserted/unmanaged part and not the shared/exclusive part. If you're not happy about this gap in warning coverage, we can also postpone this change until we have the asserted/unmanaged joins disallowed.

Tue, May 25, 12:38 PM · Restricted Project
aaronpuchert added a comment to D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities.

The warn/not-warn is consistent with more relaxed handling of managed locks, but exclusive/shared difference could lead to confusion. Both mechanisms are sound; they're just not consistent. Any thoughts?

Essentially I'm suggesting here to treat exclusive/shared joins the same way as locked/unlocked joins: we allow them for managed locks and take the "weaker" state afterwards to prevent false negatives, but not for unmanaged locks, where we take the "stronger" state afterwards to prevent spamming the user.

Tue, May 25, 10:18 AM · Restricted Project

Fri, May 21

aaronpuchert added a comment to D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`.
  • I still think a new value category is simpler than the two phase overload resolution it replaces :D

Not sure if it's simpler, but it'll produce less confusing results.

Fri, May 21, 8:51 AM · Restricted Project

Thu, May 20

aaronpuchert updated the diff for D74588: Make TableGenGlobalISel an object library.

Reverting back to original change. I think it's the only thing that works.

Thu, May 20, 7:35 AM · Restricted Project
aaronpuchert committed rGa5c2ec96e5f9: [AST] Store regular ValueDecl* in BindingDecl (NFC) (authored by aaronpuchert).
[AST] Store regular ValueDecl* in BindingDecl (NFC)
Thu, May 20, 7:29 AM
aaronpuchert closed D99455: [AST] Store regular ValueDecl* in BindingDecl.
Thu, May 20, 7:29 AM · Restricted Project
aaronpuchert added a comment to D74588: Make TableGenGlobalISel an object library.

Hmm, this doesn't actually work. The problem is that we're using target_link_libraries with LLVMTableGen, which we have to, because it's not in the big shared library. But then we also get the dependencies of that (LLVMSupport and LLVMDemangle), which are part of the shared library. In my experiments there wasn't a problem, but that might just be a coincidence.

Thu, May 20, 7:21 AM · Restricted Project
aaronpuchert added a comment to D99455: [AST] Store regular ValueDecl* in BindingDecl.

Ping @rsmith.

Thu, May 20, 6:15 AM · Restricted Project

May 14 2021

aaronpuchert added a comment to D100713: [clang] NFC: refactor multiple implementations of getDecltypeForParenthesizedExpr.

Again, I'm not sure if it helps to use getDecltypeForParenthesizedExpr where we don't actually have the decltype of a parenthesized expression.

May 14 2021, 7:35 AM · Restricted Project
aaronpuchert updated subscribers of D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`.

@aaron.ballman, what do you think about this? We can't really prevent anyone from writing .getValueKind() == VK_*Value instead of .is*Value(), so this change will make things consistent only for now.

May 14 2021, 7:12 AM · Restricted Project

May 13 2021

aaronpuchert added inline comments to D102025: Thread safety analysis: Factor out function for merging locks (NFC).
May 13 2021, 7:05 AM · Restricted Project
aaronpuchert added a comment to D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities.

Ping @aaron.ballman, also for the parent change.

May 13 2021, 5:05 AM · Restricted Project

May 7 2021

aaronpuchert added a comment to D101446: [llvm] Improve export.sh with help and snapshot.

(I think you have to squash the changes, Arcanist seems to take only the last commit.)

May 7 2021, 2:30 PM · Restricted Project
aaronpuchert added a comment to D101446: [llvm] Improve export.sh with help and snapshot.

Somehow the patch got messed up, I think. The changes that I see look like the changes since the previous patch, not the new patch.

May 7 2021, 2:27 PM · Restricted Project

May 6 2021

aaronpuchert requested review of D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities.
May 6 2021, 2:14 PM · Restricted Project
aaronpuchert requested review of D102025: Thread safety analysis: Factor out function for merging locks (NFC).
May 6 2021, 2:13 PM · Restricted Project
aaronpuchert committed rGd21e1b79ff7d: Thread safety analysis: Eliminate parameter from intersectAndWarn (NFC) (authored by aaronpuchert).
Thread safety analysis: Eliminate parameter from intersectAndWarn (NFC)
May 6 2021, 2:08 PM
aaronpuchert closed D101755: Thread safety analysis: Eliminate parameter from intersectAndWarn (NFC).
May 6 2021, 2:08 PM · Restricted Project

May 5 2021

aaronpuchert added a comment to D101446: [llvm] Improve export.sh with help and snapshot.

This is useful for creating daily snapshot tarballs that can easily be consumed by packagers who want to build a daily snapshot.

May 5 2021, 3:40 PM · Restricted Project

May 3 2021

aaronpuchert requested review of D101755: Thread safety analysis: Eliminate parameter from intersectAndWarn (NFC).
May 3 2021, 5:06 AM · Restricted Project
aaronpuchert committed rGdaca6edb31ef: Thread safety analysis: Fix false negative on break (authored by aaronpuchert).
Thread safety analysis: Fix false negative on break
May 3 2021, 5:04 AM
aaronpuchert closed D101202: Thread safety analysis: Fix false negative on break.
May 3 2021, 5:04 AM · Restricted Project
aaronpuchert committed rG530e074faafe: Thread safety analysis: Replace flags in FactEntry by SourceKind (NFC) (authored by aaronpuchert).
Thread safety analysis: Replace flags in FactEntry by SourceKind (NFC)
May 3 2021, 5:04 AM
aaronpuchert closed D100801: Thread safety analysis: Replace flags in FactEntry by SourceKind [NFC].
May 3 2021, 5:03 AM · Restricted Project
aaronpuchert added a comment to D101566: Let -Wweak-template-vtables warn on implicit instantiations.

Out of curiosity - have you tried it & measured any significant improvement/value in build times/sizes/etc?

No, I fear that would take too much time. (Not so much the benchmarking, but making a number of fixes that can be expected to make a dent.)

May 3 2021, 4:51 AM · Restricted Project

Apr 30 2021

aaronpuchert added a comment to D101566: Let -Wweak-template-vtables warn on implicit instantiations.

So I tried this in two code bases, both of which don't have -Wweak-vtables enabled though.

Apr 30 2021, 2:58 PM · Restricted Project
aaronpuchert updated the diff for D101566: Let -Wweak-template-vtables warn on implicit instantiations.
  • Fix punctuation in expected warning message.
  • Fix test failure: the instantiated class might not be a template, it could also be the member of another template.
Apr 30 2021, 4:37 AM · Restricted Project

Apr 29 2021

aaronpuchert added a comment to D101566: Let -Wweak-template-vtables warn on implicit instantiations.

I think it'd be good to gather that data first before committing it to Clang - that's usually what we try to do to justify the warning.

Well, except that this isn't a new warning. But yeah, it does make sense to look at some actual code bases.

Apr 29 2021, 6:40 PM · Restricted Project
aaronpuchert added a comment to D101566: Let -Wweak-template-vtables warn on implicit instantiations.

Along time ago Clang had a fairly strong aversion to implementing "off by default" warnings ([...]) because they would tend to go unused and unmaintained.

That was a valid reason, but now there are code bases that work with -Weverything and disable the warnings they are not interested in.

Apr 29 2021, 3:44 PM · Restricted Project
aaronpuchert requested review of D101566: Let -Wweak-template-vtables warn on implicit instantiations.
Apr 29 2021, 1:30 PM · Restricted Project

Apr 23 2021

aaronpuchert added inline comments to D101202: Thread safety analysis: Fix false negative on break.
Apr 23 2021, 2:49 PM · Restricted Project
aaronpuchert committed rG572fe0877656: Thread safety analysis: Simplify intersectAndWarn (NFC) (authored by aaronpuchert).
Thread safety analysis: Simplify intersectAndWarn (NFC)
Apr 23 2021, 2:21 PM
aaronpuchert requested review of D101202: Thread safety analysis: Fix false negative on break.
Apr 23 2021, 2:17 PM · Restricted Project

Apr 19 2021

aaronpuchert requested review of D100801: Thread safety analysis: Replace flags in FactEntry by SourceKind [NFC].
Apr 19 2021, 3:05 PM · Restricted Project

Apr 18 2021

aaronpuchert added a comment to D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`.

The change seems to be correct, but I'm wondering if x.getValueKind() == VK_*Value doesn't have one advantage over x.is*Value(): it's obvious that this is exclusive with the other values. Especially with isRValue() it might not be so obvious, because Clang doesn't follow the C++11 terminology with this.

Apr 18 2021, 3:55 PM · Restricted Project

Apr 17 2021

aaronpuchert added a comment to D100713: [clang] NFC: refactor multiple implementations of getDecltypeForParenthesizedExpr.

It seems that using is*Value and the introduction of getDecltypeForParenthesizedExpr could be two separate changes.

Apr 17 2021, 7:19 PM · Restricted Project

Apr 14 2021

aaronpuchert added inline comments to D99696: [clang] NRVO: Improvements and handling of more cases..
Apr 14 2021, 3:43 PM · Restricted Project

Apr 13 2021

aaronpuchert added inline comments to D99696: [clang] NRVO: Improvements and handling of more cases..
Apr 13 2021, 3:56 PM · Restricted Project
aaronpuchert accepted D100382: [TableGen] [docs] Correct a reference in the TableGen Overview.
Apr 13 2021, 11:24 AM · Restricted Project

Apr 11 2021

aaronpuchert added inline comments to D99696: [clang] NRVO: Improvements and handling of more cases..
Apr 11 2021, 1:46 PM · Restricted Project

Apr 10 2021

aaronpuchert added inline comments to D99696: [clang] NRVO: Improvements and handling of more cases..
Apr 10 2021, 3:07 PM · Restricted Project

Apr 9 2021

aaronpuchert added a comment to D99696: [clang] NRVO: Improvements and handling of more cases..

Didn't really check for correctness yet, just a superficial review.

Apr 9 2021, 6:48 PM · Restricted Project

Apr 6 2021

aaronpuchert committed rGdfec26b186d2: Thread safety analysis: Don't warn about managed locks on join points (authored by aaronpuchert).
Thread safety analysis: Don't warn about managed locks on join points
Apr 6 2021, 1:30 PM
aaronpuchert closed D98747: Thread safety analysis: Don't warn about managed locks on join points.
Apr 6 2021, 1:30 PM · Restricted Project
aaronpuchert added a comment to D98747: Thread safety analysis: Don't warn about managed locks on join points.

Ping @aaron.ballman, @delesley.

Apr 6 2021, 8:55 AM · Restricted Project

Apr 1 2021

aaronpuchert added a comment to D99455: [AST] Store regular ValueDecl* in BindingDecl.

Ping @rsmith.

Apr 1 2021, 1:09 PM · Restricted Project
aaronpuchert added a comment to D74588: Make TableGenGlobalISel an object library.

@beanz, Phabricator still treats this as accepted, but I'd appreciate if you have another look at it.

Apr 1 2021, 12:55 PM · Restricted Project
aaronpuchert accepted D99605: [TableGen] [Docs] Add lldb-tblgen to command guide; add 4 stubs for xxx-tblgen commands.

I'm wondering if we should move the files to their respective subprojects, but that would probably prevent the links from working. So I guess we have to live with this for now.

Apr 1 2021, 12:50 PM · Restricted Project

Mar 31 2021

aaronpuchert updated the diff for D74588: Make TableGenGlobalISel an object library.

Let's do it the CMake 3.13 way, that seems to work even with the object library hack in add_tablegen.

Mar 31 2021, 6:08 PM · Restricted Project
aaronpuchert reopened D74588: Make TableGenGlobalISel an object library.
Mar 31 2021, 6:07 PM · Restricted Project
aaronpuchert added a comment to D74588: Make TableGenGlobalISel an object library.

It seems that everything is fine with ninja, but with make we're running into this fun hack:

Mar 31 2021, 4:12 PM · Restricted Project
aaronpuchert committed rG2c3cf62d4a26: Make TableGenGlobalISel an object library (authored by aaronpuchert).
Make TableGenGlobalISel an object library
Mar 31 2021, 1:22 PM
aaronpuchert closed D74588: Make TableGenGlobalISel an object library.
Mar 31 2021, 1:22 PM · Restricted Project
aaronpuchert added a comment to D74588: Make TableGenGlobalISel an object library.
diff --git a/llvm/unittests/TableGen/CMakeLists.txt b/llvm/unittests/TableGen/CMakeLists.txt
--- a/llvm/unittests/TableGen/CMakeLists.txt
+++ b/llvm/unittests/TableGen/CMakeLists.txt
-target_link_libraries(TableGenTests PRIVATE LLVMTableGenGlobalISel LLVMTableGen)
+target_link_libraries(TableGenTests PRIVATE LLVMTableGen)

I think we can also drop LLVMTableGen since it's in LLVM_LINK_COMPONENTS already?

Mar 31 2021, 1:09 PM · Restricted Project
aaronpuchert retitled D74588: Make TableGenGlobalISel an object library from Use DISABLE_LLVM_LINK_LLVM_DYLIB for TableGenTests to Make TableGenGlobalISel an object library.
Mar 31 2021, 11:10 AM · Restricted Project
aaronpuchert updated the diff for D74588: Make TableGenGlobalISel an object library.

Go back to object library instead.

Mar 31 2021, 11:09 AM · Restricted Project
aaronpuchert added a comment to D74588: Make TableGenGlobalISel an object library.
diff --git a/llvm/unittests/TableGen/CMakeLists.txt b/llvm/unittests/TableGen/CMakeLists.txt
--- a/llvm/unittests/TableGen/CMakeLists.txt
+++ b/llvm/unittests/TableGen/CMakeLists.txt
-target_link_libraries(TableGenTests PRIVATE LLVMTableGenGlobalISel LLVMTableGen)
+target_link_libraries(TableGenTests PRIVATE LLVMTableGen)
Mar 31 2021, 11:08 AM · Restricted Project

Mar 30 2021

aaronpuchert added a comment to D74588: Make TableGenGlobalISel an object library.

On the other hand, if llvm-tblgen is not meant to link with the LLVM dylib, maybe the unit test for TableGen should also be standalone? Which would be an argument for the change as it is.

Mar 30 2021, 6:02 PM · Restricted Project
aaronpuchert added a comment to D74588: Make TableGenGlobalISel an object library.

All I wanted was a subdirectory to organize the sources specific to the GISel tablegen passes :-).

Not only that, you also want to use them in TableGenTests, and this I think is why can't just have them in llvm-tblgen.

Mar 30 2021, 4:23 PM · Restricted Project
aaronpuchert added a comment to D99605: [TableGen] [Docs] Add lldb-tblgen to command guide; add 4 stubs for xxx-tblgen commands.

The comments apply similarly to the other files,

Mar 30 2021, 3:59 PM · Restricted Project
aaronpuchert added a comment to D74588: Make TableGenGlobalISel an object library.

Yep, and that's because of a different bug in how LLVMTableGenGlobalISel was setup.

This patch would address the issues: [...]

Mar 30 2021, 9:43 AM · Restricted Project
aaronpuchert added a comment to D74588: Make TableGenGlobalISel an object library.

This makes no sense. The tablegen tool build disables linking the dylib, which should be sufficient. We should never need to force it on a static archive. I’m 99% sure, that rL373651 is just wrong here, and that the solution to all of this is to just remove DISABLE_LLVM_LINK_LLVM_DYLIB from the library.

Mar 30 2021, 8:03 AM · Restricted Project

Mar 29 2021

aaronpuchert added a comment to D90186: [TableGen] Update xxx-tblgen command document.

The problem is all the common options. You know if we repeat those in three places they will quickly become inconsistent.

Agreed, we don't want to duplicate them.

Mar 29 2021, 3:58 PM · Restricted Project
aaronpuchert added a comment to D90186: [TableGen] Update xxx-tblgen command document.

How about the title "tblgen Family - Target Description to C++ Code" and then I list the three command names in the Synopsis?

Mar 29 2021, 2:59 PM · Restricted Project

Mar 28 2021

aaronpuchert added inline comments to D99466: Fix PR48889: assertion failure for void() in flattened ternary expression.
Mar 28 2021, 3:02 PM · Restricted Project
aaronpuchert updated the diff for D99466: Fix PR48889: assertion failure for void() in flattened ternary expression.

Replace E->getType() argument by T.

Mar 28 2021, 6:50 AM · Restricted Project
aaronpuchert requested review of D99466: Fix PR48889: assertion failure for void() in flattened ternary expression.
Mar 28 2021, 5:32 AM · Restricted Project

Mar 27 2021

aaronpuchert updated subscribers of D74588: Make TableGenGlobalISel an object library.

@thakis, now that we require CMake 3.13.4, would you be fine with going back to an object library?

Mar 27 2021, 3:24 PM · Restricted Project
aaronpuchert committed rGc61ae6e6d597: Deduplicate branches and adjust comment [NFC] (authored by aaronpuchert).
Deduplicate branches and adjust comment [NFC]
Mar 27 2021, 3:09 PM
aaronpuchert added a comment to D74588: Make TableGenGlobalISel an object library.

I think this bug is the other way around. LLVMTableGenGlobalISel should not be using DISABLE_LLVM_LINK_LLVM_DYLIB.

Mar 27 2021, 2:15 PM · Restricted Project
aaronpuchert added a comment to D74588: Make TableGenGlobalISel an object library.

Ping.

Mar 27 2021, 6:17 AM · Restricted Project
aaronpuchert added a comment to D90186: [TableGen] Update xxx-tblgen command document.

This generates a man page for xxx-tblgen, though arguably no such tool exists.

Mar 27 2021, 6:13 AM · Restricted Project
aaronpuchert requested review of D99455: [AST] Store regular ValueDecl* in BindingDecl.
Mar 27 2021, 6:06 AM · Restricted Project

Mar 25 2021

aaronpuchert added a comment to D98747: Thread safety analysis: Don't warn about managed locks on join points.

We could probably address all false negatives by introducing a FactEntry for "managed locks that might be held", which we introduce on discrepancies at join points. We assume that they're fine for the destructor, but we would warn if there is an explicit lock/unlock. I could start working on this if you think that's a good idea, but it would not only address false negatives introduced in this change, but also false negatives that we've had before.

Mar 25 2021, 6:26 AM · Restricted Project

Mar 24 2021

aaronpuchert added a comment to D98747: Thread safety analysis: Don't warn about managed locks on join points.

Not replying in order, I hope that's not confusing. Let's start with the motivation.

Mar 24 2021, 2:16 PM · Restricted Project
aaronpuchert committed rGa6a1c3051dbd: Fix false negative in -Wthread-safety-attributes (authored by aaronpuchert).
Fix false negative in -Wthread-safety-attributes
Mar 24 2021, 9:46 AM
aaronpuchert closed D98724: Fix false negative in -Wthread-safety-attributes.
Mar 24 2021, 9:46 AM · Restricted Project
aaronpuchert added a comment to D98747: Thread safety analysis: Don't warn about managed locks on join points.

Ping.

Mar 24 2021, 7:02 AM · Restricted Project
aaronpuchert added a comment to D98724: Fix false negative in -Wthread-safety-attributes.

Ping @aaron.ballman.

Mar 24 2021, 6:54 AM · Restricted Project

Mar 23 2021

aaronpuchert accepted D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type.

I thought maybe you wanted to follow @mizvekov's proposal to simplify, but I understand you want to stick close to the standard language.

Mar 23 2021, 8:01 AM · Restricted Project

Mar 21 2021

aaronpuchert added a comment to D99005: [clang] Implement P2266 Simpler implicit move.

We should expect the test above to work, by binding value to the rvalue reference in task's promise, right?

Mar 21 2021, 4:22 PM · Restricted Project
aaronpuchert added a comment to D99005: [clang] Implement P2266 Simpler implicit move.

With my previous comment I meant that it's better if you leave out the co_return bits for now because it's wrong anyway. We can't use PerformMoveOrCopyInitialization. It would just generate merge conflicts.

Mar 21 2021, 7:10 AM · Restricted Project

Mar 20 2021

aaronpuchert added a comment to D99005: [clang] Implement P2266 Simpler implicit move.

For coroutines I have D68845. The current code is wrong, and not trivial to fix. We have never properly implemented P1825 and will probably just go with P2266 unconditionally, because that two-phase lookup is very cumbersome to imlement.

Mar 20 2021, 5:56 AM · Restricted Project

Mar 19 2021

aaronpuchert added inline comments to D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type.
Mar 19 2021, 6:48 PM · Restricted Project
aaronpuchert added inline comments to D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type.
Mar 19 2021, 5:36 PM · Restricted Project

Mar 18 2021

aaronpuchert updated the diff for D98747: Thread safety analysis: Don't warn about managed locks on join points.

Negative capabilities don't need to be considered as managed.

Mar 18 2021, 8:04 AM · Restricted Project