Page MenuHomePhabricator

aaronpuchert (Aaron Puchert)
Engineering

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2018, 4:43 PM (245 w, 17 h)

Mostly working on Clang's Thread safety analysis (-Wthread-safety-analysis), but occasionally other aspects of the frontend, with a cursory interest in optimizations and backends.

Package maintainer for openSUSE's LLVM package.

Recent Activity

Sat, Mar 11

Herald added a project to D109727: [Driver] Remove unneeded *-suse-* triples: Restricted Project.

Basically this should be Ok. We set the LLVM_HOST_TRIPLE to match the GCC triple on almost all platforms now.

Sat, Mar 11, 7:52 AM · Restricted Project, Restricted Project, Restricted Project
aaronpuchert added a comment to D110900: Triple: Add RedHat vendor.

We switched to using <arch>-redhat-linux-gnu as the default triple and we patch clang to translate the triple from <arch>-redhat-linux-gnu to <arch>-redhat-linux only when searching for the gcc installation, but not for anything else.

Sat, Mar 11, 7:28 AM · Restricted Project, Restricted Project

Tue, Feb 28

Herald added a project to D110900: Triple: Add RedHat vendor: Restricted Project.

Can't speak for RedHat, but on SUSE we have

> gcc -dumpmachine
x86_64-suse-linux
> clang -dumpmachine
x86_64-unknown-linux-gnu
Tue, Feb 28, 4:01 PM · Restricted Project, Restricted Project
Herald added a project to D110899: [Driver][XRay][test] XFAIL on linux with no environment specified: Restricted Project.

Should be obsolete after 016785d9316d8c5abc5fdf3cdb86479095bbb677.

Tue, Feb 28, 3:13 PM · Restricted Project, Restricted Project

Jan 25 2023

aaronpuchert added a comment to D142405: [CMake] Replace list(FIND) by if(IN_LIST) where index isn't used.

@beanz, a configuration error caused by this in a third-party project has been reported to me:

Jan 25 2023, 4:05 PM · Restricted Project, Restricted Project

Jan 23 2023

aaronpuchert added inline comments to D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling.
Jan 23 2023, 3:51 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
aaronpuchert added a comment to rG6f96dadb7a5b: [Clang][NFC] Remove documentation and mentions of deleted tools.

This might have caused a documentation build error:

Warning, treated as error:
/home/buildbot/llvm-build-dir/clang-sphinx-docs/llvm/build/tools/clang/docs/index.rst:81:toctree contains reference to nonexisting document 'ClangNvlinkWrapper'

Perhaps we need to remove the entries from clang/docs/index.rst?

diff --git a/clang/docs/index.rst b/clang/docs/index.rst
index 4befe61ee5ca..e572f706c01f 100644
--- a/clang/docs/index.rst
+++ b/clang/docs/index.rst
@@ -87,9 +87,7 @@ Using Clang Tools
    ClangFormatStyleOptions
    ClangFormattedStatus
    ClangLinkerWrapper
-   ClangNvlinkWrapper
    ClangOffloadBundler
-   ClangOffloadWrapper
    ClangOffloadPackager
    ClangRepl
Jan 23 2023, 3:44 PM · Restricted Project, Restricted Project
aaronpuchert committed rGf1d3bc49634c: [CMake] Replace list(FIND) by if(IN_LIST) where index isn't used (authored by aaronpuchert).
[CMake] Replace list(FIND) by if(IN_LIST) where index isn't used
Jan 23 2023, 2:59 PM · Restricted Project, Restricted Project
aaronpuchert closed D142405: [CMake] Replace list(FIND) by if(IN_LIST) where index isn't used.
Jan 23 2023, 2:59 PM · Restricted Project, Restricted Project
aaronpuchert added inline comments to D142405: [CMake] Replace list(FIND) by if(IN_LIST) where index isn't used.
Jan 23 2023, 2:58 PM · Restricted Project, Restricted Project
aaronpuchert added inline comments to D142405: [CMake] Replace list(FIND) by if(IN_LIST) where index isn't used.
Jan 23 2023, 2:48 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D96670: [CMake] Look up target subcomponents in LLVM_AVAILABLE_LIBS.

Yeah, I don't usually do this. But this has been sitting for a very long time with a couple of pings and no attention.

Jan 23 2023, 2:36 PM · Restricted Project, Restricted Project
aaronpuchert requested review of D142405: [CMake] Replace list(FIND) by if(IN_LIST) where index isn't used.
Jan 23 2023, 2:34 PM · Restricted Project, Restricted Project

Jan 22 2023

aaronpuchert committed rG0b5cb41dd07c: [CMake] Look up target subcomponents in LLVM_AVAILABLE_LIBS (authored by aaronpuchert).
[CMake] Look up target subcomponents in LLVM_AVAILABLE_LIBS
Jan 22 2023, 12:39 PM · Restricted Project, Restricted Project
aaronpuchert closed D96670: [CMake] Look up target subcomponents in LLVM_AVAILABLE_LIBS.
Jan 22 2023, 12:39 PM · Restricted Project, Restricted Project
Herald added a project to D96670: [CMake] Look up target subcomponents in LLVM_AVAILABLE_LIBS: Restricted Project.

Doesn't seem like I can get this reviewed, so let me just land it and see if someone complains.

Jan 22 2023, 12:37 PM · Restricted Project, Restricted Project

Nov 20 2022

aaronpuchert added a comment to D137043: [clang] add implicit include for Linux/gnu compatibility.

This include-if-exists mechanism seems brittle to me.

Do you mean the way that we used to test a file and include it (inserting #if __has_include) is brittle or compilation flags like --include-if-exists themselves are?

Nov 20 2022, 3:10 PM · Restricted Project, Restricted Project

Nov 17 2022

aaronpuchert added a comment to D137043: [clang] add implicit include for Linux/gnu compatibility.

This include-if-exists mechanism seems brittle to me. Can we not make it dependent on the triple, i.e. include the file if we're using a libc implementation that's known to provide (and require) this file?

Nov 17 2022, 3:22 PM · Restricted Project, Restricted Project

Nov 16 2022

aaronpuchert added inline comments to D136282: [clang] [CMake] Link libclangBasic against libatomic when necessary..
Nov 16 2022, 4:41 PM · Restricted Project, Restricted Project

Nov 4 2022

Herald added a project to D114936: [llvm-c] Add header deprecations: Restricted Project.

Nice to see that we have this now! (There was an earlier attempt in D18964 that somehow didn't make it.)

Nov 4 2022, 3:53 PM · Restricted Project, Restricted Project
aaronpuchert added inline comments to D120571: [CGP,AArch64] Replace zexts with shuffle that can be lowered using tbl..
Nov 4 2022, 3:49 PM · Restricted Project, Restricted Project

Nov 2 2022

aaronpuchert added inline comments to D136447: [ARM] Fix vector ule zero lowering.
Nov 2 2022, 8:57 AM · Restricted Project, Restricted Project

Nov 1 2022

aaronpuchert committed rGd71a8ad3460f: [llvm-c] Harmonize usage of unwrap (NFC) (authored by aaronpuchert).
[llvm-c] Harmonize usage of unwrap (NFC)
Nov 1 2022, 2:55 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D136447: [ARM] Fix vector ule zero lowering.

Do you mean converting ule 0 -> eq 0? I wanted the code here to be correct without needing it.

Nov 1 2022, 1:33 PM · Restricted Project, Restricted Project

Oct 26 2022

aaronpuchert updated aaronpuchert.
Oct 26 2022, 6:27 PM
aaronpuchert updated aaronpuchert.
Oct 26 2022, 6:27 PM

Oct 19 2022

aaronpuchert added a comment to D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.

Thanks for the detailed write-up, very much appreciated.

Oct 19 2022, 11:54 AM · Restricted Project, Restricted Project

Oct 18 2022

aaronpuchert added a comment to D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.

I'm seeing a fair number of breakages from this patch (not really sure how many we truly have, I've hit ~5-10 so far in widely used libraries, but I suspect we have far more in the long tail).

Oct 18 2022, 12:35 PM · Restricted Project, Restricted Project

Oct 13 2022

aaronpuchert committed rG54bfd0484615: Thread safety analysis: Support copy-elided production of scoped capabilities… (authored by aaronpuchert).
Thread safety analysis: Support copy-elided production of scoped capabilities…
Oct 13 2022, 10:37 AM · Restricted Project, Restricted Project
aaronpuchert closed D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.
Oct 13 2022, 10:37 AM · Restricted Project, Restricted Project

Oct 12 2022

aaronpuchert added a comment to D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.

@aaron.ballman, would like some feedback on the release notes. Should I additionally write something under "Potentially Breaking Changes", or is it enough to mention this under "Improvements to Clang's diagnostics"? Though I guess we could also add this later on if we get more complaints that this breaks things.

Oct 12 2022, 1:44 PM · Restricted Project, Restricted Project

Oct 11 2022

aaronpuchert added a comment to D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.

@hans, where you able to fix or work around the warnings? I'd like to land this again, but if you need more time it can also wait a bit.

Oct 11 2022, 2:28 PM · Restricted Project, Restricted Project
aaronpuchert updated the diff for D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.

Add sentence to release notes that we now look into more constructor calls and that this could lead to additional warnings being emitted.

Oct 11 2022, 2:24 PM · Restricted Project, Restricted Project

Oct 7 2022

aaronpuchert added a comment to D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.

We also started seeing -Wthread-safety-precise error in our Fuchsia code.
https://luci-milo.appspot.com/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-release/b8800959115965408001/overview
I'm trying to verify with our team whether it is a false positive, but I just wanted to give you heads up!

Oct 7 2022, 2:54 PM · Restricted Project, Restricted Project
aaronpuchert updated the diff for D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.
  • Pass til::LiteralPtr *Self for automatic object destructors into handling of require_capability and locks_excluded attributes.
  • Add [[maybe_unused]] attribute to silence -Wunused-variable warinng in Release builds.
  • A few more tests.
Oct 7 2022, 1:58 PM · Restricted Project, Restricted Project
aaronpuchert planned changes to D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.

Presumably Cursor is some kind of alias to VmoCursor, as we don't look at base destructors yet. Since the code is not easily searchable for me, can you look up the annotations on DiscardableVmosLock::Get, the constructor of Cursor/VmoCursor being used here, Cursor::lock_ref, and AssertHeld?

Oct 7 2022, 10:32 AM · Restricted Project, Restricted Project
aaronpuchert added a comment to D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.

We also started seeing -Wthread-safety-precise error in our Fuchsia code.
https://luci-milo.appspot.com/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-release/b8800959115965408001/overview
I'm trying to verify with our team whether it is a false positive, but I just wanted to give you heads up!

Oct 7 2022, 10:12 AM · Restricted Project, Restricted Project
aaronpuchert reopened D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.
Oct 7 2022, 9:57 AM · Restricted Project, Restricted Project
aaronpuchert added a comment to D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.

We're hitting a false positive in grpc after this:

> ../../third_party/grpc/src/src/core/lib/gprpp/ref_counted_ptr.h:335:31: error: calling function 'TlsSessionKeyLoggerCache' requires holding mutex 'g_tls_session_key_log_cache_mu' exclusively [-Werror,-Wthread-safety-analysis]
>   return RefCountedPtr<T>(new T(std::forward<Args>(args)...));
>                               ^
> ../../third_party/grpc/src/src/core/tsi/ssl/key_logging/ssl_key_logging.cc:121:26: note: in instantiation of function template specialization 'grpc_core::MakeRefCounted<tsi::TlsSessionKeyLoggerCache>' requested here
>      cache = grpc_core::MakeRefCounted<TlsSessionKeyLoggerCache>();
>                         ^


The code looks like this:

grpc_core::RefCountedPtr<TlsSessionKeyLogger> TlsSessionKeyLoggerCache::Get(
    std::string tls_session_key_log_file_path) {
  gpr_once_init(&g_cache_mutex_init, do_cache_mutex_init);
  GPR_DEBUG_ASSERT(g_tls_session_key_log_cache_mu != nullptr);
  if (tls_session_key_log_file_path.empty()) {
    return nullptr;
  }
  {
    grpc_core::MutexLock lock(g_tls_session_key_log_cache_mu);        <---------- holding the mutex
    grpc_core::RefCountedPtr<TlsSessionKeyLoggerCache> cache;
    if (g_cache_instance == nullptr) {
      // This will automatically set g_cache_instance.
      cache = grpc_core::MakeRefCounted<TlsSessionKeyLoggerCache>();      <------ line 121



lock is holding a MutexLock (I assume that's an exclusive thing) on g_tls_session_key_log_cache_mu.

See https://bugs.chromium.org/p/chromium/issues/detail?id=1372394#c4 for how to reproduce.

I've reverted this in https://github.com/llvm/llvm-project/commit/a4afa2bde6f4db215ddd3267a8d11c04367812e5 in the meantime.

Oct 7 2022, 9:56 AM · Restricted Project, Restricted Project
aaronpuchert abandoned D133707: Let llvm-config --system-libs print full paths if we use them.

No longer needed as we went with a different solution in D132799.

Oct 7 2022, 5:04 AM · Restricted Project, Restricted Project

Oct 6 2022

aaronpuchert added inline comments to D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.
Oct 6 2022, 5:54 PM · Restricted Project, Restricted Project
aaronpuchert accepted D134275: [OpenMP] [OMPD] Build gdb-plugin code only when python3 development files are available..
Oct 6 2022, 3:10 PM · Restricted Project, Restricted Project
aaronpuchert committed rG0041a69495f8: Thread safety analysis: Support copy-elided production of scoped capabilities… (authored by aaronpuchert).
Thread safety analysis: Support copy-elided production of scoped capabilities…
Oct 6 2022, 1:21 PM · Restricted Project, Restricted Project
aaronpuchert committed rGd8fa40dfa7ad: Thread safety analysis: Handle additional cast in scoped capability construction (authored by aaronpuchert).
Thread safety analysis: Handle additional cast in scoped capability construction
Oct 6 2022, 1:21 PM · Restricted Project, Restricted Project
aaronpuchert closed D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.
Oct 6 2022, 1:21 PM · Restricted Project, Restricted Project
aaronpuchert closed D129752: Thread safety analysis: Handle additional cast in scoped capability construction.
Oct 6 2022, 1:21 PM · Restricted Project, Restricted Project
aaronpuchert updated the diff for D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.

Add trimmed-down documentation back in and a release note.

Oct 6 2022, 10:24 AM · Restricted Project, Restricted Project

Oct 4 2022

aaronpuchert accepted D134275: [OpenMP] [OMPD] Build gdb-plugin code only when python3 development files are available..

Perhaps wait for @mgorny before you submit. Just a minor suggestion from me how you could simplify this.

Oct 4 2022, 12:40 PM · Restricted Project, Restricted Project

Sep 20 2022

aaronpuchert added inline comments to D134275: [OpenMP] [OMPD] Build gdb-plugin code only when python3 development files are available..
Sep 20 2022, 2:59 PM · Restricted Project, Restricted Project

Sep 18 2022

aaronpuchert updated the summary of D132799: Make sure libLLVM users link with libatomic if needed.
Sep 18 2022, 10:14 AM · Restricted Project, Restricted Project
aaronpuchert committed rG1a14436c35b4: Make sure libLLVM users link with libatomic if needed (authored by aaronpuchert).
Make sure libLLVM users link with libatomic if needed
Sep 18 2022, 10:12 AM · Restricted Project, Restricted Project
aaronpuchert closed D132799: Make sure libLLVM users link with libatomic if needed.
Sep 18 2022, 10:12 AM · Restricted Project, Restricted Project

Sep 16 2022

aaronpuchert added a comment to D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.

Please be sure to add a release note for the changes!

Sep 16 2022, 2:47 PM · Restricted Project, Restricted Project

Sep 14 2022

aaronpuchert added inline comments to D111283: [clang] template / auto deduction deduces common sugar.
Sep 14 2022, 1:47 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 13 2022

aaronpuchert added inline comments to D111283: [clang] template / auto deduction deduces common sugar.
Sep 13 2022, 5:03 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
aaronpuchert updated the diff for D132799: Make sure libLLVM users link with libatomic if needed.

Go back to only adding libatomic. The LLVM_SYSTEM_LIBS contain many libraries that seem to be private dependencies only, and for now we don't properly track private vs public dependencies on component libraries.

Sep 13 2022, 3:02 PM · Restricted Project, Restricted Project
aaronpuchert reopened D132799: Make sure libLLVM users link with libatomic if needed.
Sep 13 2022, 3:02 PM · Restricted Project, Restricted Project
aaronpuchert added a reverting change for rG44ffc13f2eb6: Make sure libLLVM users link with libatomic if needed: rGd8afcaf93e84: Revert "Make sure libLLVM users link with libatomic if needed".
Sep 13 2022, 2:58 PM · Restricted Project, Restricted Project
aaronpuchert committed rGd8afcaf93e84: Revert "Make sure libLLVM users link with libatomic if needed" (authored by aaronpuchert).
Revert "Make sure libLLVM users link with libatomic if needed"
Sep 13 2022, 2:58 PM · Restricted Project, Restricted Project
aaronpuchert added a reverting change for D132799: Make sure libLLVM users link with libatomic if needed: rGd8afcaf93e84: Revert "Make sure libLLVM users link with libatomic if needed".
Sep 13 2022, 2:58 PM · Restricted Project, Restricted Project

Sep 12 2022

aaronpuchert added a comment to D132799: Make sure libLLVM users link with libatomic if needed.

The Z3 Solver is an external dependency that gets put on any user of libLLVM if they are building with Z3, so that's correct too.

Sep 12 2022, 4:52 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D132799: Make sure libLLVM users link with libatomic if needed.

As an alternative, we strip when the path is part of the standard linker search paths.

Sep 12 2022, 9:52 AM · Restricted Project, Restricted Project
aaronpuchert added a reviewer for D133707: Let llvm-config --system-libs print full paths if we use them: phosek.
Sep 12 2022, 9:49 AM · Restricted Project, Restricted Project
aaronpuchert requested review of D133707: Let llvm-config --system-libs print full paths if we use them.
Sep 12 2022, 9:48 AM · Restricted Project, Restricted Project
aaronpuchert added a comment to D132799: Make sure libLLVM users link with libatomic if needed.

Hmm, seems that since D79219 we use find_package, which has a habit of producing full paths instead of e.g. -lz for zlib, so for llvm-config we strip off the path and pretend we've been linking against the system library all along.

Sep 12 2022, 9:25 AM · Restricted Project, Restricted Project
aaronpuchert added a comment to D132799: Make sure libLLVM users link with libatomic if needed.

CMake manages to find a custom-installed libzstd in a nondefault location (/home/linuxbrew/.linuxbrew/lib/libzstd.so.1.5.2), and for every other place that these dependencies are used, it's linked by just adding that absolute path to the linking command line. However after this commit, when linking, it links by passing both -lzstd and /home/linuxbrew/.linuxbrew/lib/libzstd.so.1.5.2, and linking fails since the -lzstd is unresolved.

Sep 12 2022, 9:04 AM · Restricted Project, Restricted Project
aaronpuchert added inline comments to D100185: [OpenMP] [OMPD] [5/6] Implementation of OMPD debugging library - libompd. gdb-plugin: A Plugin code to gdb to leverage libompd to provide debugging support..
Sep 12 2022, 8:48 AM · Restricted Project, Restricted Project

Sep 11 2022

aaronpuchert committed rG44ffc13f2eb6: Make sure libLLVM users link with libatomic if needed (authored by aaronpuchert).
Make sure libLLVM users link with libatomic if needed
Sep 11 2022, 11:46 AM · Restricted Project, Restricted Project
aaronpuchert committed rG4491bb19df17: [libcxxabi] Fix forced_unwind3.pass.cpp compilation error (authored by aaronpuchert).
[libcxxabi] Fix forced_unwind3.pass.cpp compilation error
Sep 11 2022, 11:46 AM · Restricted Project
aaronpuchert committed rGe4f64ad4e38d: [docs] Use relative URLs for man pages (authored by aaronpuchert).
[docs] Use relative URLs for man pages
Sep 11 2022, 11:46 AM · Restricted Project, Restricted Project
aaronpuchert closed D132799: Make sure libLLVM users link with libatomic if needed.
Sep 11 2022, 11:46 AM · Restricted Project, Restricted Project
aaronpuchert closed D132873: [libcxxabi] Fix forced_unwind3.pass.cpp compilation error.
Sep 11 2022, 11:45 AM · Restricted Project, Restricted Project
aaronpuchert closed D132794: [docs] Use relative URLs for man pages.
Sep 11 2022, 11:45 AM · Restricted Project, Restricted Project

Sep 9 2022

aaronpuchert added a comment to D132799: Make sure libLLVM users link with libatomic if needed.

Ping.

Sep 9 2022, 6:02 AM · Restricted Project, Restricted Project

Sep 8 2022

aaronpuchert added a comment to D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.

I was under the impression that we've already switched to C++17, but the Windows pre-submit build failed with:

C:\ws\w9\llvm-project\premerge-checks\clang\lib\Analysis\ThreadSafety.cpp(2107): error C2429: language feature 'init-statements in if/switch' requires compiler flag '/std:c++17'
C:\ws\w9\llvm-project\premerge-checks\clang\lib\Analysis\ThreadSafety.cpp(2120): error C2429: language feature 'init-statements in if/switch' requires compiler flag '/std:c++17'
C:\ws\w9\llvm-project\premerge-checks\clang\lib\Analysis\ThreadSafety.cpp(2418): error C2429: language feature 'init-statements in if/switch' requires compiler flag '/std:c++17'

Perhaps I should move the init statements out again?

Sep 8 2022, 7:05 AM · Restricted Project, Restricted Project

Sep 7 2022

aaronpuchert added inline comments to D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.
Sep 7 2022, 2:59 PM · Restricted Project, Restricted Project
aaronpuchert updated the diff for D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.

Use SmallDenseMap plus some minor changes.

Sep 7 2022, 2:54 PM · Restricted Project, Restricted Project
aaronpuchert added inline comments to D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.
Sep 7 2022, 2:53 PM · Restricted Project, Restricted Project

Sep 1 2022

aaronpuchert accepted D133105: [Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c`.

Thanks!

Sep 1 2022, 2:23 PM · Restricted Project, Restricted Project

Aug 31 2022

aaronpuchert added inline comments to D133009: [libclang] Fix conversion from `StringRef` to `CXString`.
Aug 31 2022, 5:09 PM · Restricted Project, Restricted Project

Aug 30 2022

aaronpuchert updated the summary of D132799: Make sure libLLVM users link with libatomic if needed.
Aug 30 2022, 3:52 PM · Restricted Project, Restricted Project
aaronpuchert updated the diff for D132799: Make sure libLLVM users link with libatomic if needed.

Add all dependencies from Support's LLVM_SYSTEM_LIBS as public link dependencies of libLLVM.

Aug 30 2022, 3:50 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D132799: Make sure libLLVM users link with libatomic if needed.

We probably should replace atomic here with the LLVM_SYSTEM_LIBS property from the LLVMSupport target.

Aug 30 2022, 3:41 PM · Restricted Project, Restricted Project

Aug 29 2022

aaronpuchert added a comment to D132873: [libcxxabi] Fix forced_unwind3.pass.cpp compilation error.

If you care to share, it'd be interesting to know under what circumstances you end up with no struct definition.

Aug 29 2022, 3:15 PM · Restricted Project, Restricted Project
aaronpuchert requested review of D132873: [libcxxabi] Fix forced_unwind3.pass.cpp compilation error.
Aug 29 2022, 11:05 AM · Restricted Project, Restricted Project
aaronpuchert closed D132791: Fix formatting in release notes.

Landed in 0c5ce1d7fba38948c27ed6b875f962cd60895574.

Aug 29 2022, 10:59 AM · Restricted Project, Restricted Project, Restricted Project
aaronpuchert added a comment to D132791: Fix formatting in release notes.

The documentation build (docs-{llvm,clang}-{html,man}) is fine after this, in fact it fixes:

Warning, treated as error:
[...]/build/tools/clang/docs/ReleaseNotes.rst:632:Bullet list ends without a blank line; unexpected unindent.

by adding some indentation.

Aug 29 2022, 10:47 AM · Restricted Project, Restricted Project, Restricted Project

Aug 27 2022

aaronpuchert requested review of D132799: Make sure libLLVM users link with libatomic if needed.
Aug 27 2022, 2:39 PM · Restricted Project, Restricted Project
aaronpuchert requested review of D132794: [docs] Use relative URLs for man pages.
Aug 27 2022, 10:59 AM · Restricted Project, Restricted Project
aaronpuchert updated the summary of D132791: Fix formatting in release notes.
Aug 27 2022, 9:53 AM · Restricted Project, Restricted Project, Restricted Project
aaronpuchert updated the diff for D132791: Fix formatting in release notes.

Use links instead :manpage:, which is meant for man pages cross-referencing each other.

Aug 27 2022, 9:51 AM · Restricted Project, Restricted Project, Restricted Project
aaronpuchert added a comment to D132791: Fix formatting in release notes.

This is for release/15.x.

Aug 27 2022, 9:30 AM · Restricted Project, Restricted Project, Restricted Project
aaronpuchert requested review of D132791: Fix formatting in release notes.
Aug 27 2022, 9:29 AM · Restricted Project, Restricted Project, Restricted Project

Aug 17 2022

aaronpuchert added a comment to D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls.

Ping.

Aug 17 2022, 1:54 PM · Restricted Project, Restricted Project

Aug 14 2022

aaronpuchert added a comment to D129160: libclang.so: Make SONAME the same as LLVM version.

Sure. If an application links to libclang.so when the application is being built, the application will hardcode libclang.so.13 in it and will look for it.
When the SONAME changes to libclang.so.15 in LLVM 15, the application will not be able to use the libclang from LLVM 15 unless the
application was rebuilt with libclang.so in LLVM 15.

Aug 14 2022, 11:45 AM · Restricted Project, Restricted Project
aaronpuchert added a comment to D129160: libclang.so: Make SONAME the same as LLVM version.

Also, this change did not really acheive it's purpose of allowing apps to use newer versions of libclang.so without rebuilding, because a new version of libclang.so requires a new version of libLLVM.so, which does not have a stable ABI.

Aug 14 2022, 8:45 AM · Restricted Project, Restricted Project

Aug 5 2022

Herald added a reviewer for D44943: Fill the last page of each executable section with 0xcc or equivalent.: MaskRay.

This has been accepted for quite some time, any reason why we're not landing it?

Aug 5 2022, 10:32 AM · Restricted Project

Aug 2 2022

aaronpuchert added inline comments to D130956: [X86][MC] Always emit `rep` prefix for `bsf`.
Aug 2 2022, 3:32 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D130956: [X86][MC] Always emit `rep` prefix for `bsf`.

By the way, the original bug for this is #34191.

Aug 2 2022, 1:28 AM · Restricted Project, Restricted Project

Jul 28 2022

aaronpuchert added a comment to D129752: Thread safety analysis: Handle additional cast in scoped capability construction.

Do you think this warrants a release note (or did it close any open issues in the tracker)?

Jul 28 2022, 8:32 AM · Restricted Project, Restricted Project