- User Since
- Jul 12 2018, 4:43 PM (65 w, 3 d)
Sat, Oct 12
@GorNishanov Do I read the standard correctly that there are no constraints on what return_value is? That is, could it also be a function pointer or function object?
I'll add your test case, but I'll probably reuse the existing data structures.
Fri, Oct 11
Thu, Oct 10
Also remove FIXME comment.
Please have a look at D68845. This should address the issues that we discussed.
@Quuxplusone Thanks for your very helpful comments!
Wed, Oct 9
This change breaks the following code that worked before:
Tue, Oct 8
Mon, Sep 30
Sat, Sep 28
Can be "reproduced" with clang -fsyntax-only -Wstrict-prototypes clang/include/clang-c/*.h.
Handle static libraries correctly.
I didn't know about this patch and published D68172: adding BUILDTREE_ONLY still builds the examples, but doesn't install them. It's also used by other test plugins like llvm/lib/Transforms/Hello.
Thanks to @lebedev.ri for informing my about this patch.
Fri, Sep 27
Wed, Sep 25
This change does not affect the Clang triple, that is and will be powerpc-unknown-linux-gnu. It's just about where Clang looks for the GCC toolchain.
Sat, Sep 21
Perhaps I should mention that this fixes an assertion failure.
Pass correct Clang triple as argument to --target.
Sep 9 2019
Sep 7 2019
I'm thinking about the following, but I'm not sure if that's the proper way to do it.
Sep 4 2019
Sep 3 2019
Remove wrong changes in SemaExprCXX.cpp.
If anyone shares my feeling that the boolean output parameters of CompareReferenceRelationship should rather move to the return value, I would be happy to do that.
Sep 2 2019
Thank you for having a look at the notes, that's good to hear.
Aug 30 2019
IIRC, when we rolled out -Wstrict-prototypes we explicitly excluded this case since it hit a lot of code without finding bugs.
We had a discussion on IRC yesterday and @aaron.ballman pointed out that the K&R syntax has been considered "obsolescent" (= deprecated) since C89, 30 years ago. He added that there are thoughts within the standards committee about removing the syntax entirely from C2x.
Aug 29 2019
By the way, I'm open to adding a fix-it hint for zero-parameter K&R-style definitions, since the fix is pretty straightforward.
"Meaning" is a difficult term. What we know is that this is a K&R-style definition, and does not define a prototype. So one would expect -Wstrict-prototypes to warn about this.
Aug 28 2019
Note that I'm just copying GCC, which seems the be the original intent behind the warning (https://bugs.llvm.org/show_bug.cgi?id=20796). So people who use both compilers will have seen that warning already. Note also that there is no warning if any declaration provides a prototype, so this is fine:
Added a test case, verified that it fails before the change.
Aug 10 2019
Sorry for warming this up again, but it would be nice to get rid of this patch in openSUSE.
Jul 30 2019
The primary purpose of Thread Safety Analysis is to make sure that accesses to shared resources are protected. That's why we only track whether a lock is available by default (i.e. without -Wthread-safety-negative), locks that we don't know anything about are assumed to be unlocked. As a side effect, we can detect double unlocks and lock/unlock-kind mismatches.
Jul 26 2019
Jul 25 2019
What distinguishes a shared from an exclusive negative capability? Negative capabilities (as I understand them) express the mutex not being held at all, meaning neither in shared nor in exclusive mode.
Jun 26 2019
Thanks for the reviews!
Jun 25 2019
Jun 18 2019
Jun 17 2019
Jun 15 2019
Remove -enable-split-dwarf completely, adapting the test case accordingly. Also remove -split-dwarf which wasn't used at all.
Jun 14 2019
Jun 13 2019
Sorry for making the inline comments disappear, but I had to switch to the big repository.
Make sure the flags have the same meaning for LTO. Also slightly reworded the HelpText.
Jun 12 2019
Jun 11 2019
Add checks that we don't emit the fix-it when we shouldn't.
adding the new one,
then removing the single split dwarf flag handling in favor of implying that by the absence of an output file name. (if I'm reading what this patch does)
Correct an oversight.