Page MenuHomePhabricator

aaronpuchert (Aaron Puchert)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2018, 4:43 PM (65 w, 3 d)

Recent Activity

Sat, Oct 12

aaronpuchert created D68923: Don't warn about missing declarations for partial template specializations.
Sat, Oct 12, 5:08 PM · Restricted Project
aaronpuchert added a comment to D68845: Don't emit unwanted constructor calls in co_return statements.

@GorNishanov Do I read the standard correctly that there are no constraints on what return_value is? That is, could it also be a function pointer or function object?

Sat, Oct 12, 4:41 PM · Restricted Project
aaronpuchert added a comment to D68845: Don't emit unwanted constructor calls in co_return statements.

I'll add your test case, but I'll probably reuse the existing data structures.

Sat, Oct 12, 7:51 AM · Restricted Project

Fri, Oct 11

aaronpuchert planned changes to D68845: Don't emit unwanted constructor calls in co_return statements.

Both of these should first do overload resolution for one parameter of type MoveOnly&&, and then, only if that overload resolution fails, should they fall back to overload resolution for one parameter of type MoveOnly&.

Fri, Oct 11, 4:09 AM · Restricted Project

Thu, Oct 10

aaronpuchert added inline comments to D68845: Don't emit unwanted constructor calls in co_return statements.
Thu, Oct 10, 6:08 PM · Restricted Project
aaronpuchert updated the diff for D68845: Don't emit unwanted constructor calls in co_return statements.

Also remove FIXME comment.

Thu, Oct 10, 5:59 PM · Restricted Project
aaronpuchert created D68845: Don't emit unwanted constructor calls in co_return statements.
Thu, Oct 10, 5:58 PM · Restricted Project
aaronpuchert added a comment to D51741: [coro]Pass rvalue reference for named local variable to return_value.

Please have a look at D68845. This should address the issues that we discussed.

Thu, Oct 10, 5:58 PM · Restricted Project
aaronpuchert added a comment to D51741: [coro]Pass rvalue reference for named local variable to return_value.

@Quuxplusone Thanks for your very helpful comments!

Thu, Oct 10, 2:34 PM · Restricted Project

Wed, Oct 9

aaronpuchert added a comment to D51741: [coro]Pass rvalue reference for named local variable to return_value.

This patch is heavily heavily merge-conflicted by P1825.

Wed, Oct 9, 1:32 PM · Restricted Project
Herald added a project to D51741: [coro]Pass rvalue reference for named local variable to return_value: Restricted Project.

This change breaks the following code that worked before:

Wed, Oct 9, 10:09 AM · Restricted Project

Tue, Oct 8

aaronpuchert added a comment to D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.

Gentle ping.

Tue, Oct 8, 1:15 PM · Restricted Project
aaronpuchert planned changes to D67112: [Sema] Add implicit cast for conversion of function references.

If anyone shares my feeling that the boolean output parameters of CompareReferenceRelationship should rather move to the return value, I would be happy to do that.

Tue, Oct 8, 12:59 PM · Restricted Project

Mon, Sep 30

aaronpuchert added a comment to D67113: ICK_Function_Conversion is a third kind conversion.

Ping?

Mon, Sep 30, 2:44 PM · Restricted Project
aaronpuchert abandoned D68187: [libclang] Use strict prototypes in header.

Fixed by @aaron.ballman in rC373213 along with another issue.

Mon, Sep 30, 2:37 PM · Restricted Project

Sat, Sep 28

aaronpuchert added a comment to D68187: [libclang] Use strict prototypes in header.

Can be "reproduced" with clang -fsyntax-only -Wstrict-prototypes clang/include/clang-c/*.h.

Sat, Sep 28, 4:12 PM · Restricted Project
aaronpuchert created D68187: [libclang] Use strict prototypes in header.
Sat, Sep 28, 4:09 PM · Restricted Project
aaronpuchert updated the diff for D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test.

Fix typo.

Sat, Sep 28, 3:34 PM · Restricted Project
aaronpuchert updated the diff for D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test.

Handle static libraries correctly.

Sat, Sep 28, 3:25 PM · Restricted Project
aaronpuchert added inline comments to D66775: [libclang] Expose abort()-ing fatal error handler.
Sat, Sep 28, 9:32 AM · Restricted Project
aaronpuchert committed rG243058fff140: Don't install example analyzer plugins (authored by aaronpuchert).
Don't install example analyzer plugins
Sat, Sep 28, 6:31 AM
aaronpuchert committed rL373148: Don't install example analyzer plugins.
Don't install example analyzer plugins
Sat, Sep 28, 6:27 AM
aaronpuchert closed D68172: Don't install example analyzer plugins.
Sat, Sep 28, 6:27 AM · Restricted Project, Restricted Project
aaronpuchert added a comment to D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake..

@Szelethus could you confirm that thus examples shouldn't be built when CLANG_BUILD_EXAMPLES is OFF, and that this patch is still valid?

Sat, Sep 28, 5:59 AM · Restricted Project
aaronpuchert added a comment to D68172: Don't install example analyzer plugins.

The patch looks alright, I won't formally accept because if I knew how these worked, it wouldn't have caused so much pain to so many people :)

Sat, Sep 28, 5:56 AM · Restricted Project, Restricted Project
aaronpuchert updated the summary of D68172: Don't install example analyzer plugins.
Sat, Sep 28, 4:02 AM · Restricted Project, Restricted Project
aaronpuchert added a comment to D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake..

I didn't know about this patch and published D68172: adding BUILDTREE_ONLY still builds the examples, but doesn't install them. It's also used by other test plugins like llvm/lib/Transforms/Hello.
Thanks to @lebedev.ri for informing my about this patch.

Sat, Sep 28, 4:02 AM · Restricted Project

Fri, Sep 27

aaronpuchert added a comment to D68172: Don't install example analyzer plugins.
In D68172#1686772, @NoQ wrote:

+@Szelethus because i'm a bit out-of-the-loop on plugins: i very vaguely remember that we decided to put them into tests(?)

Fri, Sep 27, 6:39 PM · Restricted Project, Restricted Project
aaronpuchert created D68172: Don't install example analyzer plugins.
Fri, Sep 27, 5:27 PM · Restricted Project, Restricted Project

Wed, Sep 25

aaronpuchert added a comment to D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.

A couple of questions since I am not all that familiar with clang and am certainly not familiar with this unusual SUSE 32-bit situation:

  • We seem to be changing the set of aliases here, but what happens if someone actually explicitly specifies --target=powerpc-suse-linux?
  • Can you describe the default triple for clang on SUSE 32-bit PPC? Will it be powerpc-suse-linux? powerpc64-suse-linux?

This change does not affect the Clang triple, that is and will be powerpc-unknown-linux-gnu. It's just about where Clang looks for the GCC toolchain.

Wed, Sep 25, 4:35 PM · Restricted Project

Sat, Sep 21

aaronpuchert added a reviewer for D67112: [Sema] Add implicit cast for conversion of function references: riccibruno.

Perhaps I should mention that this fixes an assertion failure.

Sat, Sep 21, 1:32 PM · Restricted Project
aaronpuchert updated the diff for D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.

Pass correct Clang triple as argument to --target.

Sat, Sep 21, 12:56 PM · Restricted Project

Sep 9 2019

aaronpuchert added inline comments to D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test.
Sep 9 2019, 5:27 PM · Restricted Project

Sep 7 2019

aaronpuchert added a comment to D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test.

I'm thinking about the following, but I'm not sure if that's the proper way to do it.

Sep 7 2019, 11:20 AM · Restricted Project
aaronpuchert created D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test.
Sep 7 2019, 10:11 AM · Restricted Project
aaronpuchert added inline comments to D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test.
Sep 7 2019, 10:11 AM · Restricted Project

Sep 4 2019

aaronpuchert added a comment to D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes.

We do have numerous warnings that are default errors, you can look for DefaultError in the diagnostic .td files to see the uses.

Sep 4 2019, 3:27 PM · Restricted Project

Sep 3 2019

aaronpuchert retitled D67113: ICK_Function_Conversion is a third kind conversion from ICK_Function_Conversion and ICK_Qualification are third kind conversions to ICK_Function_Conversion is a third kind conversion.
Sep 3 2019, 3:27 PM · Restricted Project
aaronpuchert updated the diff for D67113: ICK_Function_Conversion is a third kind conversion.

Remove wrong changes in SemaExprCXX.cpp.

Sep 3 2019, 3:27 PM · Restricted Project
aaronpuchert created D67113: ICK_Function_Conversion is a third kind conversion.
Sep 3 2019, 10:38 AM · Restricted Project
aaronpuchert added a comment to D67112: [Sema] Add implicit cast for conversion of function references.

If anyone shares my feeling that the boolean output parameters of CompareReferenceRelationship should rather move to the return value, I would be happy to do that.

Sep 3 2019, 10:34 AM · Restricted Project
aaronpuchert created D67112: [Sema] Add implicit cast for conversion of function references.
Sep 3 2019, 10:34 AM · Restricted Project

Sep 2 2019

aaronpuchert added a comment to D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes.

I went back to read notes from when we deployed -Wstrict-prototypes (which we have had on-by-default for our users for a couple of years, since it catches lots of -fblocks-related bugs). I was mainly objecting because I had (mis)remembered trying and backing out the specific behaviour you're adding. On the contrary, our notes say that we might want to strengthen the diagnostic as you're doing.

Thank you for having a look at the notes, that's good to hear.

Sep 2 2019, 4:54 PM · Restricted Project

Aug 30 2019

aaronpuchert added a comment to D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes.

IIRC, when we rolled out -Wstrict-prototypes we explicitly excluded this case since it hit a lot of code without finding bugs.

Aug 30 2019, 2:36 PM · Restricted Project
aaronpuchert added a comment to D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes.

We had a discussion on IRC yesterday and @aaron.ballman pointed out that the K&R syntax has been considered "obsolescent" (= deprecated) since C89, 30 years ago. He added that there are thoughts within the standards committee about removing the syntax entirely from C2x.

Aug 30 2019, 2:16 PM · Restricted Project

Aug 29 2019

aaronpuchert added a comment to D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes.

By the way, I'm open to adding a fix-it hint for zero-parameter K&R-style definitions, since the fix is pretty straightforward.

Aug 29 2019, 12:04 PM · Restricted Project
aaronpuchert added a comment to D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes.

we just don't warn on non-prototype defining declarations, where the meaning is unambiguous:

void foo() {}

"Meaning" is a difficult term. What we know is that this is a K&R-style definition, and does not define a prototype. So one would expect -Wstrict-prototypes to warn about this.

Aug 29 2019, 11:48 AM · Restricted Project

Aug 28 2019

aaronpuchert added a comment to D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes.

Note that I'm just copying GCC, which seems the be the original intent behind the warning (https://bugs.llvm.org/show_bug.cgi?id=20796). So people who use both compilers will have seen that warning already. Note also that there is no warning if any declaration provides a prototype, so this is fine:

Aug 28 2019, 7:30 PM · Restricted Project
aaronpuchert updated the diff for D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.

Added a test case, verified that it fails before the change.

Aug 28 2019, 6:51 PM · Restricted Project
aaronpuchert commandeered D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.
Aug 28 2019, 6:51 PM · Restricted Project
aaronpuchert created D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes.
Aug 28 2019, 6:10 PM · Restricted Project

Aug 10 2019

aaronpuchert added a comment to D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux.

Sorry for warming this up again, but it would be nice to get rid of this patch in openSUSE.

Aug 10 2019, 7:52 AM · Restricted Project

Jul 30 2019

Herald added a project to D41296: Limit size of non-GlobalValue name: Restricted Project.

Why don't we just cap all names at some point (and then just start adding numbers as we generally do to break degeneracies). It seems like, otherwise, we'll end up with these kinds of fixes in many places. Fixing this in one common place seems better.

Jul 30 2019, 5:39 PM · Restricted Project
aaronpuchert added inline comments to D65184: [Sema] Thread Safety Analysis: Make negative capability typeless..
Jul 30 2019, 2:37 PM · Restricted Project
aaronpuchert added a comment to D65184: [Sema] Thread Safety Analysis: Make negative capability typeless..

The primary purpose of Thread Safety Analysis is to make sure that accesses to shared resources are protected. That's why we only track whether a lock is available by default (i.e. without -Wthread-safety-negative), locks that we don't know anything about are assumed to be unlocked. As a side effect, we can detect double unlocks and lock/unlock-kind mismatches.

Jul 30 2019, 2:28 PM · Restricted Project
aaronpuchert added inline comments to D65184: [Sema] Thread Safety Analysis: Make negative capability typeless..
Jul 30 2019, 1:38 PM · Restricted Project

Jul 26 2019

aaronpuchert added a reviewer for D65184: [Sema] Thread Safety Analysis: Make negative capability typeless.: aaronpuchert.
Jul 26 2019, 5:45 AM · Restricted Project

Jul 25 2019

aaronpuchert added a reviewer for D65184: [Sema] Thread Safety Analysis: Make negative capability typeless.: aaron.ballman.

What distinguishes a shared from an exclusive negative capability? Negative capabilities (as I understand them) express the mutex not being held at all, meaning neither in shared nor in exclusive mode.

Jul 25 2019, 3:29 PM · Restricted Project

Jun 26 2019

aaronpuchert committed rG4561161345da: Fix formatting after r364479 (authored by aaronpuchert).
Fix formatting after r364479
Jun 26 2019, 2:42 PM
aaronpuchert added a comment to D63167: [Clang] Remove unused -split-dwarf and obsolete -enable-split-dwarf.

Thanks for the reviews!

Jun 26 2019, 2:42 PM · Restricted Project, Restricted Project
aaronpuchert committed rL364480: Fix formatting after r364479.
Fix formatting after r364479
Jun 26 2019, 2:39 PM
aaronpuchert committed rGb207baeb2830: [Clang] Remove unused -split-dwarf and obsolete -enable-split-dwarf (authored by aaronpuchert).
[Clang] Remove unused -split-dwarf and obsolete -enable-split-dwarf
Jun 26 2019, 2:38 PM
aaronpuchert committed rL364479: [Clang] Remove unused -split-dwarf and obsolete -enable-split-dwarf.
[Clang] Remove unused -split-dwarf and obsolete -enable-split-dwarf
Jun 26 2019, 2:37 PM
aaronpuchert closed D63167: [Clang] Remove unused -split-dwarf and obsolete -enable-split-dwarf.
Jun 26 2019, 2:36 PM · Restricted Project, Restricted Project

Jun 25 2019

aaronpuchert added inline comments to D63167: [Clang] Remove unused -split-dwarf and obsolete -enable-split-dwarf.
Jun 25 2019, 5:12 PM · Restricted Project, Restricted Project

Jun 18 2019

aaronpuchert committed rG44940048dde5: Fix more tests after r363749 (authored by aaronpuchert).
Fix more tests after r363749
Jun 18 2019, 6:54 PM
aaronpuchert committed rL363760: Fix more tests after r363749.
Fix more tests after r363749
Jun 18 2019, 6:50 PM
aaronpuchert committed rG2b285c664d77: Fix tests after r363749 (authored by aaronpuchert).
Fix tests after r363749
Jun 18 2019, 4:37 PM
aaronpuchert committed rL363754: Fix tests after r363749.
Fix tests after r363749
Jun 18 2019, 4:37 PM
aaronpuchert committed rGdf195d8aedff: Suggestions to fix -Wmissing-{prototypes,variable-declarations} (authored by aaronpuchert).
Suggestions to fix -Wmissing-{prototypes,variable-declarations}
Jun 18 2019, 3:56 PM
aaronpuchert committed rL363749: Suggestions to fix -Wmissing-{prototypes,variable-declarations}.
Suggestions to fix -Wmissing-{prototypes,variable-declarations}
Jun 18 2019, 3:56 PM
aaronpuchert closed D59402: Suggestions to fix -Wmissing-{prototypes,variable-declarations}.
Jun 18 2019, 3:55 PM · Restricted Project, Restricted Project
aaronpuchert committed rGf9c6e565de2a: Show note for -Wmissing-prototypes for functions with parameters (authored by aaronpuchert).
Show note for -Wmissing-prototypes for functions with parameters
Jun 18 2019, 3:50 PM
aaronpuchert committed rL363748: Show note for -Wmissing-prototypes for functions with parameters.
Show note for -Wmissing-prototypes for functions with parameters
Jun 18 2019, 3:49 PM
aaronpuchert closed D62750: Show note for -Wmissing-prototypes for functions with parameters.
Jun 18 2019, 3:49 PM · Restricted Project, Restricted Project

Jun 17 2019

aaronpuchert added inline comments to D59402: Suggestions to fix -Wmissing-{prototypes,variable-declarations}.
Jun 17 2019, 1:21 PM · Restricted Project, Restricted Project
aaronpuchert added inline comments to D59402: Suggestions to fix -Wmissing-{prototypes,variable-declarations}.
Jun 17 2019, 12:18 PM · Restricted Project, Restricted Project
aaronpuchert added inline comments to D62750: Show note for -Wmissing-prototypes for functions with parameters.
Jun 17 2019, 12:01 PM · Restricted Project, Restricted Project

Jun 15 2019

aaronpuchert retitled D63167: [Clang] Remove unused -split-dwarf and obsolete -enable-split-dwarf from [Clang] Remove obsolete -enable-split-dwarf={single,split} to [Clang] Remove unused -split-dwarf and obsolete -enable-split-dwarf.
Jun 15 2019, 9:23 AM · Restricted Project, Restricted Project
aaronpuchert added inline comments to D63167: [Clang] Remove unused -split-dwarf and obsolete -enable-split-dwarf.
Jun 15 2019, 9:23 AM · Restricted Project, Restricted Project
aaronpuchert updated the diff for D63167: [Clang] Remove unused -split-dwarf and obsolete -enable-split-dwarf.

Remove -enable-split-dwarf completely, adapting the test case accordingly. Also remove -split-dwarf which wasn't used at all.

Jun 15 2019, 9:16 AM · Restricted Project, Restricted Project
aaronpuchert committed rGe1dc495e6302: [Clang] Harmonize Split DWARF options with llc (authored by aaronpuchert).
[Clang] Harmonize Split DWARF options with llc
Jun 15 2019, 8:36 AM
aaronpuchert committed rL363496: [Clang] Harmonize Split DWARF options with llc.
[Clang] Harmonize Split DWARF options with llc
Jun 15 2019, 8:36 AM
aaronpuchert closed D59673: [Clang] Harmonize Split DWARF options with llc.
Jun 15 2019, 8:36 AM · Restricted Project, Restricted Project
aaronpuchert committed rG922759a63d7d: [Clang] Rename -split-dwarf-file to -split-dwarf-output (authored by aaronpuchert).
[Clang] Rename -split-dwarf-file to -split-dwarf-output
Jun 15 2019, 7:06 AM
aaronpuchert committed rL363494: [Clang] Rename -split-dwarf-file to -split-dwarf-output.
[Clang] Rename -split-dwarf-file to -split-dwarf-output
Jun 15 2019, 7:05 AM
aaronpuchert closed D63130: [Clang] Rename -split-dwarf-file to -split-dwarf-output.
Jun 15 2019, 7:05 AM · Restricted Project, Restricted Project

Jun 14 2019

aaronpuchert added inline comments to D59673: [Clang] Harmonize Split DWARF options with llc.
Jun 14 2019, 7:53 AM · Restricted Project, Restricted Project

Jun 13 2019

aaronpuchert added a reviewer for D59673: [Clang] Harmonize Split DWARF options with llc: tejohnson.

Sorry for making the inline comments disappear, but I had to switch to the big repository.

Jun 13 2019, 5:07 PM · Restricted Project, Restricted Project
aaronpuchert updated the diff for D59673: [Clang] Harmonize Split DWARF options with llc.

Make sure the flags have the same meaning for LTO. Also slightly reworded the HelpText.

Jun 13 2019, 4:50 PM · Restricted Project, Restricted Project
aaronpuchert added inline comments to D63167: [Clang] Remove unused -split-dwarf and obsolete -enable-split-dwarf.
Jun 13 2019, 12:43 PM · Restricted Project, Restricted Project

Jun 12 2019

aaronpuchert added inline comments to D59673: [Clang] Harmonize Split DWARF options with llc.
Jun 12 2019, 1:22 PM · Restricted Project, Restricted Project
aaronpuchert added inline comments to D59673: [Clang] Harmonize Split DWARF options with llc.
Jun 12 2019, 12:36 PM · Restricted Project, Restricted Project
aaronpuchert updated subscribers of D59673: [Clang] Harmonize Split DWARF options with llc.
Jun 12 2019, 5:46 AM · Restricted Project, Restricted Project
aaronpuchert added inline comments to D63167: [Clang] Remove unused -split-dwarf and obsolete -enable-split-dwarf.
Jun 12 2019, 5:32 AM · Restricted Project, Restricted Project

Jun 11 2019

aaronpuchert updated the diff for D62750: Show note for -Wmissing-prototypes for functions with parameters.

Add checks that we don't emit the fix-it when we shouldn't.

Jun 11 2019, 2:44 PM · Restricted Project, Restricted Project
aaronpuchert added a comment to D59673: [Clang] Harmonize Split DWARF options with llc.

Might be easier as a few patches - renaming the existing option,

D63130

adding the new one,

This change.

then removing the single split dwarf flag handling in favor of implying that by the absence of an output file name. (if I'm reading what this patch does)

D63167

Jun 11 2019, 2:12 PM · Restricted Project, Restricted Project
aaronpuchert created D63167: [Clang] Remove unused -split-dwarf and obsolete -enable-split-dwarf.
Jun 11 2019, 2:12 PM · Restricted Project, Restricted Project
aaronpuchert updated the diff for D59673: [Clang] Harmonize Split DWARF options with llc.

Correct an oversight.

Jun 11 2019, 4:42 AM · Restricted Project, Restricted Project
aaronpuchert updated the summary of D59673: [Clang] Harmonize Split DWARF options with llc.
Jun 11 2019, 4:22 AM · Restricted Project, Restricted Project