Details

Reviewers: None

Summary

WIP, not ready for review.

Signed-off-by: Matheus Izvekov <mizvekov@gmail.com>

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	40 ms	x64 debian > Clang.CXX/class/class_compare/class_compare_default::p4.cpp
	140 ms	x64 debian > Clang.CXX/class/class_init/class_copy_elision::p3.cpp
	60 ms	x64 windows > Clang.SemaCXX::overload-call.cpp

Event Timeline

mizvekov created this revision.Apr 6 2021, 5:27 PM

Herald added a subscriber: lxfind. · View Herald TranscriptApr 6 2021, 5:27 PM

mizvekov requested review of this revision.Apr 6 2021, 5:27 PM

Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2021, 5:27 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Harbormaster completed remote builds in B97416: Diff 335683.Apr 6 2021, 5:28 PM

mizvekov added a parent revision: D99005: [clang] Implement P2266 Simpler implicit move.Apr 6 2021, 5:29 PM

mizvekov retitled this revision from [clang] WIP: Implement simpler alternative to two-phase lookup for NRVO WIP, not ready for review. to [clang] WIP: Implement simpler alternative to two-phase lookup for NRVO.

mizvekov edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B97420: Diff 335688.Apr 6 2021, 6:16 PM

Harbormaster completed remote builds in B97421: Diff 335689.Apr 6 2021, 6:49 PM

mizvekov added parent revisions: D100713: [clang] NFC: refactor multiple implementations of getDecltypeForParenthesizedExpr, D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`.Apr 20 2021, 4:19 PM

Initial implementation, still WIP.

Herald added a subscriber: dexonsmith. · View Herald TranscriptApr 20 2021, 4:24 PM

Harbormaster completed remote builds in B99841: Diff 339035.Apr 20 2021, 4:30 PM

mizvekov removed parent revisions: D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`, D100713: [clang] NFC: refactor multiple implementations of getDecltypeForParenthesizedExpr.Apr 21 2021, 12:26 PM

Harbormaster completed remote builds in B100072: Diff 339349.Apr 21 2021, 12:46 PM

mizvekov mentioned this in D88220: [C++20] P1825R0: More implicit moves.Jun 8 2021, 1:28 PM

mizvekov mentioned this in D99696: [clang] NRVO: Improvements and handling of more cases..Jun 9 2021, 2:04 PM

mizvekov edited parent revisions, added: D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20., D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`, D100713: [clang] NFC: refactor multiple implementations of getDecltypeForParenthesizedExpr; removed: D99005: [clang] Implement P2266 Simpler implicit move.Jun 29 2021, 4:09 PM

Patch now in workable state. Is Missing a few cleanups in the implementation.

Updates coroutine implicit move tests, as now they can finally match C++20 behavior and don't need P2266 retroactively applied.

There are some test result changes.
These all match current GCC behaviour though: We are now broken in the same way as GCC is for these.
TBD what to do about these. The ambiguous overload resolution one might be easy to solve,
the other ones have to be studied more carefully.

Harbormaster completed remote builds in B111638: Diff 355393.Jun 29 2021, 5:16 PM

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[clang] WIP: Implement simpler alternative to two-phase lookup for NRVO
Needs ReviewPublic
Actions

Details

Diff Detail

Unit TestsFailed
View All

Event Timeline

Revision Contents
Changeset List

Diff 355393

clang/include/clang/AST/Expr.h

clang/include/clang/Basic/Specifiers.h

clang/include/clang/Sema/Overload.h

clang/include/clang/Sema/Sema.h

clang/lib/AST/ASTContext.cpp

clang/lib/AST/ExprClassification.cpp

clang/lib/AST/JSONNodeDumper.cpp

clang/lib/AST/TextNodeDumper.cpp

clang/lib/CodeGen/CGDecl.cpp

clang/lib/CodeGen/CGObjC.cpp

clang/lib/Sema/Sema.cpp

clang/lib/Sema/SemaCodeComplete.cpp

clang/lib/Sema/SemaCoroutine.cpp

clang/lib/Sema/SemaExprCXX.cpp

clang/lib/Sema/SemaInit.cpp

clang/lib/Sema/SemaOverload.cpp

clang/lib/Sema/SemaStmt.cpp

clang/lib/Sema/SemaTemplateInstantiateDecl.cpp

clang/test/CXX/class/class.init/class.copy.elision/p3.cpp

clang/test/SemaCXX/conversion-function.cpp

clang/test/SemaCXX/coroutine-rvo.cpp

clang/test/SemaObjCXX/block-capture.mm

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[clang] WIP: Implement simpler alternative to two-phase lookup for NRVONeeds ReviewPublicActions

Details

Diff Detail

Unit TestsFailedView All

Event Timeline

Revision ContentsChangeset List

Diff 355393

clang/include/clang/AST/Expr.h

clang/include/clang/Basic/Specifiers.h

clang/include/clang/Sema/Overload.h

clang/include/clang/Sema/Sema.h

clang/lib/AST/ASTContext.cpp

clang/lib/AST/ExprClassification.cpp

clang/lib/AST/JSONNodeDumper.cpp

clang/lib/AST/TextNodeDumper.cpp

clang/lib/CodeGen/CGDecl.cpp

clang/lib/CodeGen/CGObjC.cpp

clang/lib/Sema/Sema.cpp

clang/lib/Sema/SemaCodeComplete.cpp

clang/lib/Sema/SemaCoroutine.cpp

clang/lib/Sema/SemaExprCXX.cpp

clang/lib/Sema/SemaInit.cpp

clang/lib/Sema/SemaOverload.cpp

clang/lib/Sema/SemaStmt.cpp

clang/lib/Sema/SemaTemplateInstantiateDecl.cpp

clang/test/CXX/class/class.init/class.copy.elision/p3.cpp

clang/test/SemaCXX/conversion-function.cpp

clang/test/SemaCXX/coroutine-rvo.cpp

clang/test/SemaObjCXX/block-capture.mm

[clang] WIP: Implement simpler alternative to two-phase lookup for NRVO
Needs ReviewPublic
Actions

Unit TestsFailed
View All

Revision Contents
Changeset List