See OMP-5.0 2.19.5.5 task_reduction Clause.
To add a positive test case we need taskgroup directive which is not added hence skipping the test.
This is a dependency for taskgroup construct.
Co-authored-by: Valentin Clement <clementval@gmail.com>
Differential D93105
[Flang][openmp][5.0] Add task_reduction clause. sameeranjoshi on Dec 11 2020, 4:36 AM. Authored by
Details See OMP-5.0 2.19.5.5 task_reduction Clause. Co-authored-by: Valentin Clement <clementval@gmail.com>
Diff Detail
Unit Tests Event Timeline
Comment Actions Update OmpReductionClause to use OmpObjectList. Comment Actions Thank you for reviewing.
Comment Actions I guess it looks like what we have discussed now. If you want to attribute correctly the co-authorship of this patch, you can add Co-authored-by: Valentin Clement <clementval@gmail.com> at the end of the commit message. GitHub will do the rest. Comment Actions @yhegde Will the changes in this patch affect your reduction patch (https://reviews.llvm.org/D90697)? Comment Actions Yes. Rt now I am directly getting the list of Designators . Now it will become a level of indirection with the list of OmpObjects. Comment Actions I am not sure if I completely understand your question. Comment Actions The co-authorship must be in the commit message. Updating phab doesn't change what was landed. Look at https://github.com/llvm/llvm-project/commit/8a58f21f5b6c228137a9b87906fe5b720c4d1dfb, the co-authorship is correctly displayed on GitHub. This is not the case with the commit you landed for this revision. |
Is there a problem with the formatting here?