Page MenuHomePhabricator

sameeranjoshi (sameeran joshi)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 14 2020, 10:41 AM (164 w, 2 d)

Recent Activity

Jan 4 2023

sameeranjoshi removed a reviewer for D104391: [flang] [openmp] Correct OpenMP Allocate Directive parse tree structure to associate directives with allocate statements correctly.: sameeranjoshi.
Jan 4 2023, 10:49 PM · Restricted Project, Unknown Object (Project), Restricted Project
Herald added a project to D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct.: Restricted Project.
Jan 4 2023, 10:49 PM · Restricted Project, Unknown Object (Project), Restricted Project
Herald added a project to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct.: Restricted Project.
Jan 4 2023, 10:49 PM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi removed a reviewer for D95465: [flang][driver] Fix reading from stdin when using `-test-io`: sameeranjoshi.
Jan 4 2023, 10:48 PM · Restricted Project, Unknown Object (Project), Restricted Project

Nov 18 2021

sameeranjoshi accepted D114145: [flang] GettingInvolved: update LLVM Alias Analysis Technical Call info.

Thanks.
LGTM.

Nov 18 2021, 7:45 PM · Unknown Object (Project), Restricted Project

Jan 21 2021

sameeranjoshi updated the diff for D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..

Capitalized clauses in message.

Jan 21 2021, 7:53 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi added inline comments to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Jan 21 2021, 6:22 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi updated the diff for D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..

Summary of changes:

Jan 21 2021, 6:14 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jan 20 2021

sameeranjoshi added inline comments to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Jan 20 2021, 10:52 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi added inline comments to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Jan 20 2021, 10:44 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi added inline comments to D94782: [flang][driver] Make the driver report diagnostics from the prescanner.
Jan 20 2021, 9:31 AM · Unknown Object (Project), Restricted Project
sameeranjoshi added inline comments to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Jan 20 2021, 7:33 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi accepted D94805: [flang][driver] Update PP tests to use the new driver.

We are slowly trying to replace the throwaway driver f18. That's actually a good progress.
Thank you for the progress @awarzynski @FarisRehman
I would wait for others to approve as this patch touches the core Fortran parts.

Jan 20 2021, 1:58 AM · Unknown Object (Project), Restricted Project
sameeranjoshi added inline comments to D94782: [flang][driver] Make the driver report diagnostics from the prescanner.
Jan 20 2021, 1:58 AM · Unknown Object (Project), Restricted Project
sameeranjoshi accepted D94782: [flang][driver] Make the driver report diagnostics from the prescanner.
Jan 20 2021, 1:11 AM · Unknown Object (Project), Restricted Project

Jan 19 2021

sameeranjoshi added a reviewer for D95023: [test-suite] SPEC2017 CPU Exchange2 integer tests.: sameeranjoshi.
Jan 19 2021, 11:59 PM
sameeranjoshi accepted D94922: [flang][driver] Refactor one unit-test case to use fixtures (nfc).

Looks good.

Jan 19 2021, 11:53 PM · Unknown Object (Project), Restricted Project
sameeranjoshi added inline comments to D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..
Jan 19 2021, 10:34 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi added a comment to D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

Ping.

Jan 19 2021, 9:41 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jan 18 2021

sameeranjoshi accepted D94821: [flang][directive] Get rid of flangClassValue in TableGen.

Ok a clang version 8.0.1 based build passes.
It's seems compiler version related issue.
BTW, is there a way to mitigate or conform such compiler version/build related issues?
LGTM.

Jan 18 2021, 9:34 PM · Unknown Object (Project), Restricted Project
sameeranjoshi added inline comments to D94821: [flang][directive] Get rid of flangClassValue in TableGen.
Jan 18 2021, 8:26 PM · Unknown Object (Project), Restricted Project
sameeranjoshi accepted D94516: [flang][driver] Add standard predefinitions.

Thank you.
LGTM.

Jan 18 2021, 5:11 AM · Restricted Project
sameeranjoshi added a comment to D94516: [flang][driver] Add standard predefinitions.

Agreed. @awarzynski. Thank you for clarification.

Jan 18 2021, 12:42 AM · Restricted Project

Jan 17 2021

sameeranjoshi accepted D94228: [flang][driver] Support fixed form detection.

Thank you for working on this.
It build and tests successfully.
Please wait for other reviewers to accept.

Jan 17 2021, 11:44 PM · Unknown Object (Project), Restricted Project
sameeranjoshi added a comment to D94821: [flang][directive] Get rid of flangClassValue in TableGen.

This was a much needed change. Thank you for the refactoring.
One of the typical and most common problems was FindClause did not work as expected given that CheckAllowed was correctly defined for the clauses.

Jan 17 2021, 10:02 PM · Unknown Object (Project), Restricted Project

Jan 14 2021

sameeranjoshi accepted D93485: [openacc] Rename generated file from ACC.cpp.inc to ACC.inc to match D92955.

Thank you for the patch.
It was pending since many days.
The changes look good to me from the matching point w.r.t the linked patch.
I couldn't understand still the rational for *.cpp.inc to *.inc for both OMP and OACC, could you please point why was that needed?
Thank you.

Jan 14 2021, 7:55 AM · Unknown Object (Project), Restricted Project
sameeranjoshi added inline comments to D94516: [flang][driver] Add standard predefinitions.
Jan 14 2021, 7:18 AM · Restricted Project
sameeranjoshi added inline comments to D93453: [flang][driver] Add support for `-I`.
Jan 14 2021, 6:54 AM · Unknown Object (Project), Restricted Project
sameeranjoshi added inline comments to D94422: [flang][driver] Unify f18_version.h.in and Version.inc.in.
Jan 14 2021, 6:53 AM · Unknown Object (Project), Restricted Project
sameeranjoshi added a comment to D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce..

Hi @sameeranjoshi , thank you for working on this!

Sadly with this patch one of our upstream builders has started failing: http://lab.llvm.org:8011/#/builders/33/builds/1866. More specifically,Semantics/omp-parallell01.f90 is failing.

All other builders are fine, which makes this weird. The only unique thing about the failing builder (flang-aarch64-ubuntu-clang) is that it uses clang-10. Could you take a look?

Edit: @kiranchandramohan just pointed out to me offline that this is probably fixed here: https://reviews.llvm.org/D94618.

Jan 14 2021, 6:50 AM · Unknown Object (Project), Restricted Project
sameeranjoshi accepted D94618: [flang] Fix dangling pointer in LabelEnforce.

Thank you for the patch.
I did get an email from the bot with a weird text Control flow escapes from \xcb\x1c\xda\xff\xff\nexpect at 16: Control flow escapes from PARALLEL\n'
I had a build of gcc 9.2 and the tried to check with the recent pull from main and all tests seem to work.
It was pointed[1] by @awarzynski that the issue was specifically due to clang-10.

Jan 14 2021, 6:39 AM · Restricted Project, Unknown Object (Project)

Jan 13 2021

sameeranjoshi updated the diff for D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..

Ideally in the first look the checks would fit better for ordered construct
inside a single function CheckDependOnOrderedDir so we have them at a
single place , unfortunately it's harder to implement it in above function
considering that the information to differentiate between a
OmpBlockDirective and OmpSimpleStandaloneDirective is unavailable.

Jan 13 2021, 7:11 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jan 12 2021

sameeranjoshi added inline comments to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Jan 12 2021, 12:01 PM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi updated the diff for D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..

Tweak comments as suggested.

Jan 12 2021, 11:58 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi added a comment to D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

These are great catches, thank you.
I was wondering since the merge of task_reduction why were the tests failing and did kept this on hold for a while since then.
Thanks again. :)

Jan 12 2021, 11:47 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi updated the diff for D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

Summary of changes:

  • Simplify the test as those checks were already covered.
  • Update OMP.td to specifiy to add 5.0 standard for the clauses.
Jan 12 2021, 11:43 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi committed rG6f4d46076200: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided… (authored by sameeranjoshi).
[Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided…
Jan 12 2021, 10:35 AM
sameeranjoshi closed D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce..
Jan 12 2021, 10:35 AM · Unknown Object (Project), Restricted Project
sameeranjoshi updated the summary of D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Jan 12 2021, 10:13 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi added inline comments to D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce..
Jan 12 2021, 10:11 AM · Unknown Object (Project), Restricted Project
sameeranjoshi updated the diff for D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..

Summary of changes:

  • Handle depend(source) and depend(sink:vec) separately.
  • Handle one more restriction from standard[5.0][2.17.9] which was needed with this patch. Either depend(sink:vec) clauses or depend(source) clauses may appear on an ordered construct, but not both.
Jan 12 2021, 7:00 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi added a comment to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

Need an answer here to proceed with review.

@kiranchandramohan I am trying to resuse the function CheckBranchesIntoDoBody . Will update the patch regarding the same.

@sameeranjoshi Will you be merging the related changes https://reviews.llvm.org/D93447 that makes use of LabelEnforce ?

Jan 12 2021, 5:09 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jan 11 2021

sameeranjoshi accepted D93575: [flang][openxx][NFC] Remove duplicated function to check required clauses.

LGMT. Thanks for cleaning that up.

Jan 11 2021, 8:35 AM · Unknown Object (Project), Restricted Project
sameeranjoshi accepted D94243: [flang][driver] Copy input files into a temp dir when testing (nfc).

Looks good.

Jan 11 2021, 4:06 AM · Restricted Project

Jan 10 2021

sameeranjoshi requested changes to D94228: [flang][driver] Support fixed form detection.
Jan 10 2021, 11:48 PM · Unknown Object (Project), Restricted Project

Jan 9 2021

sameeranjoshi added inline comments to D93401: [flang][driver] Add support for `-D`, `-U`.
Jan 9 2021, 1:53 AM · Unknown Object (Project), Restricted Project

Jan 7 2021

sameeranjoshi updated the diff for D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..

Summary of changes:

  • Fix core dump in ordered construct due to missing tree node visit

for OpenMPSimpleStandaloneConstruct as ordered with a depend falls under it.

  • Fix internal error in name resolution of depend clause.
Jan 7 2021, 8:59 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi added a reviewer for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive: sameeranjoshi.
Jan 7 2021, 6:55 AM · Unknown Object (Project), Restricted Project

Jan 5 2021

sameeranjoshi added a project to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct.: Unknown Object (Project).
Jan 5 2021, 7:30 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi requested review of D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Jan 5 2021, 7:29 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jan 4 2021

sameeranjoshi accepted D93712: [flang][driver] Add checks for errors from `Prescan` and `Parse`.

Mostly nit comments.
Thanks and LGMT.

Jan 4 2021, 10:33 PM · Unknown Object (Project), Restricted Project
sameeranjoshi added inline comments to D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct..
Jan 4 2021, 1:32 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jan 3 2021

sameeranjoshi committed rG6280bc1cc34a: [Flang][openmp][5.0] Add task_reduction clause. (authored by sameeranjoshi).
[Flang][openmp][5.0] Add task_reduction clause.
Jan 3 2021, 7:33 PM
sameeranjoshi closed D93105: [Flang][openmp][5.0] Add task_reduction clause..
Jan 3 2021, 7:33 PM · Unknown Object (Project), Restricted Project

Dec 22 2020

sameeranjoshi added a reverting change for rG9a7895dc2085: [Flang][openmp][5.0] Add task_reduction clause.: rG1aa10ab2e1dd: Revert "[Flang][openmp][5.0] Add task_reduction clause.".
Dec 22 2020, 10:24 AM
sameeranjoshi committed rG1aa10ab2e1dd: Revert "[Flang][openmp][5.0] Add task_reduction clause." (authored by sameeranjoshi).
Revert "[Flang][openmp][5.0] Add task_reduction clause."
Dec 22 2020, 10:24 AM
sameeranjoshi added a reverting change for D93105: [Flang][openmp][5.0] Add task_reduction clause.: rG1aa10ab2e1dd: Revert "[Flang][openmp][5.0] Add task_reduction clause.".
Dec 22 2020, 10:24 AM · Unknown Object (Project), Restricted Project
sameeranjoshi added a comment to rG9a7895dc2085: [Flang][openmp][5.0] Add task_reduction clause..

This patch was co-authored by @valentime. I forgot to update the commit message when pushing to main, apologies.

Dec 22 2020, 9:29 AM
sameeranjoshi updated the summary of D93105: [Flang][openmp][5.0] Add task_reduction clause..
Dec 22 2020, 9:25 AM · Unknown Object (Project), Restricted Project
sameeranjoshi added 1 auditor(s) for rG9a7895dc2085: [Flang][openmp][5.0] Add task_reduction clause.: clementval.
Dec 22 2020, 9:24 AM
sameeranjoshi committed rG9a7895dc2085: [Flang][openmp][5.0] Add task_reduction clause. (authored by sameeranjoshi).
[Flang][openmp][5.0] Add task_reduction clause.
Dec 22 2020, 9:05 AM
sameeranjoshi closed D93105: [Flang][openmp][5.0] Add task_reduction clause..
Dec 22 2020, 9:05 AM · Unknown Object (Project), Restricted Project
sameeranjoshi added a comment to D93105: [Flang][openmp][5.0] Add task_reduction clause..

@yhegde Will the changes in this patch affect your reduction patch (https://reviews.llvm.org/D90697)?

Yes. Rt now I am directly getting the list of Designators . Now it will become a level of indirection with the list of OmpObjects.
I may be missing something but OpenMP 4.5 and 5.0 Reduction clause restrictions looks very similar , why this one level of indirection required?! Is it because functions names in Reduction clause can come from common blocks ?!

Dec 22 2020, 8:24 AM · Unknown Object (Project), Restricted Project
sameeranjoshi accepted D93544: [flang][driver] Refactor unit tests for frontend actions (nfc).
Dec 22 2020, 3:27 AM · Unknown Object (Project), Restricted Project
sameeranjoshi committed rG1a6f43991ff7: [Flang][openmp][5/5] Make dist_schedule clause part of OmpClause (authored by sameeranjoshi).
[Flang][openmp][5/5] Make dist_schedule clause part of OmpClause
Dec 22 2020, 1:03 AM
sameeranjoshi closed D93644: [Flang][openmp][5/5] Make dist_schedule clause part of OmpClause.
Dec 22 2020, 1:02 AM · Unknown Object (Project), Restricted Project
sameeranjoshi added inline comments to D93576: [openacc] Use TableGen enum for default clause value.
Dec 22 2020, 1:02 AM · Unknown Object (Project), Restricted Project
sameeranjoshi committed rGe282ae57da29: [Flang][openmp][4/5] Make nowait clause part of OmpClause (authored by sameeranjoshi).
[Flang][openmp][4/5] Make nowait clause part of OmpClause
Dec 22 2020, 12:32 AM
sameeranjoshi closed D93643: [Flang][openmp][4/5] Make nowait clause part of OmpClause.
Dec 22 2020, 12:32 AM · Restricted Project
sameeranjoshi committed rG34958d11c345: [Flang][openmp][3/5] Make ProcBind clause part of OmpClause (authored by sameeranjoshi).
[Flang][openmp][3/5] Make ProcBind clause part of OmpClause
Dec 22 2020, 12:11 AM
sameeranjoshi closed D93642: [Flang][openmp][3/5] Make ProcBind clause part of OmpClause.
Dec 22 2020, 12:11 AM · Restricted Project

Dec 21 2020

sameeranjoshi committed rGf72c384b5ba9: [Flang][openmp][2/5] Make Default clause part of OmpClause (authored by sameeranjoshi).
[Flang][openmp][2/5] Make Default clause part of OmpClause
Dec 21 2020, 11:48 PM
sameeranjoshi closed D93641: [Flang][openmp][2/5] Make Default clause part of OmpClause.
Dec 21 2020, 11:48 PM · Restricted Project
sameeranjoshi committed rG442aac5da68c: [Flang][openmp][1/5] Make Allocate clause part of OmpClause (authored by sameeranjoshi).
[Flang][openmp][1/5] Make Allocate clause part of OmpClause
Dec 21 2020, 11:24 PM
sameeranjoshi closed D93640: [Flang][openmp][1/5] Make Allocate clause part of OmpClause.
Dec 21 2020, 11:23 PM · Restricted Project
sameeranjoshi added inline comments to D93544: [flang][driver] Refactor unit tests for frontend actions (nfc).
Dec 21 2020, 11:20 PM · Unknown Object (Project), Restricted Project
sameeranjoshi added a comment to D93544: [flang][driver] Refactor unit tests for frontend actions (nfc).

Thank you!
That was much needed to extract into a fixture, given a few upcoming reviews.

Dec 21 2020, 10:15 PM · Unknown Object (Project), Restricted Project
sameeranjoshi added a project to D93644: [Flang][openmp][5/5] Make dist_schedule clause part of OmpClause: Unknown Object (Project).
Dec 21 2020, 9:44 AM · Unknown Object (Project), Restricted Project
sameeranjoshi requested review of D93644: [Flang][openmp][5/5] Make dist_schedule clause part of OmpClause.
Dec 21 2020, 9:37 AM · Unknown Object (Project), Restricted Project
sameeranjoshi requested review of D93643: [Flang][openmp][4/5] Make nowait clause part of OmpClause.
Dec 21 2020, 9:30 AM · Restricted Project
sameeranjoshi requested review of D93642: [Flang][openmp][3/5] Make ProcBind clause part of OmpClause.
Dec 21 2020, 9:29 AM · Restricted Project
sameeranjoshi requested review of D93641: [Flang][openmp][2/5] Make Default clause part of OmpClause.
Dec 21 2020, 9:28 AM · Restricted Project
sameeranjoshi requested review of D93640: [Flang][openmp][1/5] Make Allocate clause part of OmpClause.
Dec 21 2020, 9:25 AM · Restricted Project

Dec 18 2020

sameeranjoshi added inline comments to D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct..
Dec 18 2020, 10:57 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi updated the diff for D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct..

Remove unnecessary variable mayBeName.

Dec 18 2020, 10:54 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi updated the diff for D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct..

Merge ResolveName into ResolveOmpName.

Dec 18 2020, 10:06 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi added inline comments to D93482: [flang][openmp] Make Reduction clause part of OmpClause.
Dec 18 2020, 9:10 AM · Unknown Object (Project), Restricted Project
sameeranjoshi added inline comments to D93482: [flang][openmp] Make Reduction clause part of OmpClause.
Dec 18 2020, 8:41 AM · Unknown Object (Project), Restricted Project
sameeranjoshi accepted D93482: [flang][openmp] Make Reduction clause part of OmpClause.
Dec 18 2020, 8:19 AM · Unknown Object (Project), Restricted Project
sameeranjoshi added a comment to D93482: [flang][openmp] Make Reduction clause part of OmpClause.

+1 for finding the issue.
Thanks for the efforts and LGMT.

Dec 18 2020, 5:24 AM · Unknown Object (Project), Restricted Project

Dec 17 2020

sameeranjoshi updated the diff for D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

Address review comments.

Dec 17 2020, 3:51 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi accepted D92672: [flang][openacc] Enforce restriction on routine directive and clauses.

LGTM.
Please take care of the remaining nits comments before merging.
Thank you @tskeith for pointers.

Dec 17 2020, 2:26 AM · Unknown Object (Project), Restricted Project
sameeranjoshi committed rGa4e47cd1857b: [Flang][openmp]Fix crash in OpenMP semantic check( bug 48308) (authored by sameeranjoshi).
[Flang][openmp]Fix crash in OpenMP semantic check( bug 48308)
Dec 17 2020, 1:47 AM
sameeranjoshi closed D92638: [Flang][openmp]Fix crash in OpenMP semantic check( bug 48308).
Dec 17 2020, 1:47 AM · Restricted Project
sameeranjoshi accepted D92123: [flang][openacc] Update serial construct clauses for OpenACC 3.1.
Dec 17 2020, 1:43 AM · Unknown Object (Project), Restricted Project
sameeranjoshi added a comment to D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce..

Addresses one of the comments from
https://reviews.llvm.org/D88655#2356685

Dec 17 2020, 1:28 AM · Unknown Object (Project), Restricted Project
sameeranjoshi added a project to D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce.: Unknown Object (Project).
Dec 17 2020, 1:28 AM · Unknown Object (Project), Restricted Project
sameeranjoshi added a comment to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

Please suggest.

Dec 17 2020, 1:27 AM · Restricted Project, Unknown Object (Project), Restricted Project
sameeranjoshi requested review of D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce..
Dec 17 2020, 1:26 AM · Restricted Project, Restricted Project

Dec 16 2020

sameeranjoshi added inline comments to D92672: [flang][openacc] Enforce restriction on routine directive and clauses.
Dec 16 2020, 10:34 AM · Restricted Project, Restricted Project