Page MenuHomePhabricator

sameeranjoshi (sameeran joshi)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 14 2020, 10:41 AM (39 w, 2 d)

Recent Activity

Yesterday

sameeranjoshi accepted D93485: [openacc] Rename generated file from ACC.cpp.inc to ACC.inc to match D92955.

Thank you for the patch.
It was pending since many days.
The changes look good to me from the matching point w.r.t the linked patch.
I couldn't understand still the rational for *.cpp.inc to *.inc for both OMP and OACC, could you please point why was that needed?
Thank you.

Thu, Jan 14, 7:55 AM · Restricted Project, Restricted Project
sameeranjoshi added inline comments to D94516: [flang][driver] Add standard predefinitions.
Thu, Jan 14, 7:18 AM · Restricted Project
sameeranjoshi added inline comments to D93453: [flang][driver] Add support for `-I`.
Thu, Jan 14, 6:54 AM · Restricted Project, Restricted Project
sameeranjoshi added inline comments to D94422: [flang][driver] Unify f18_version.h.in and Version.inc.in.
Thu, Jan 14, 6:53 AM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce..

Hi @sameeranjoshi , thank you for working on this!

Sadly with this patch one of our upstream builders has started failing: http://lab.llvm.org:8011/#/builders/33/builds/1866. More specifically,Semantics/omp-parallell01.f90 is failing.

All other builders are fine, which makes this weird. The only unique thing about the failing builder (flang-aarch64-ubuntu-clang) is that it uses clang-10. Could you take a look?

Edit: @kiranchandramohan just pointed out to me offline that this is probably fixed here: https://reviews.llvm.org/D94618.

Thu, Jan 14, 6:50 AM · Restricted Project, Restricted Project
sameeranjoshi accepted D94618: [flang] Fix dangling pointer in LabelEnforce.

Thank you for the patch.
I did get an email from the bot with a weird text Control flow escapes from \xcb\x1c\xda\xff\xff\nexpect at 16: Control flow escapes from PARALLEL\n'
I had a build of gcc 9.2 and the tried to check with the recent pull from main and all tests seem to work.
It was pointed[1] by @awarzynski that the issue was specifically due to clang-10.

Thu, Jan 14, 6:39 AM · Restricted Project, Restricted Project

Wed, Jan 13

sameeranjoshi updated the diff for D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..

Ideally in the first look the checks would fit better for ordered construct
inside a single function CheckDependOnOrderedDir so we have them at a
single place , unfortunately it's harder to implement it in above function
considering that the information to differentiate between a
OmpBlockDirective and OmpSimpleStandaloneDirective is unavailable.

Wed, Jan 13, 7:11 AM · Restricted Project, Restricted Project

Tue, Jan 12

sameeranjoshi added inline comments to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Tue, Jan 12, 12:01 PM · Restricted Project, Restricted Project
sameeranjoshi updated the diff for D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..

Tweak comments as suggested.

Tue, Jan 12, 11:58 AM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

These are great catches, thank you.
I was wondering since the merge of task_reduction why were the tests failing and did kept this on hold for a while since then.
Thanks again. :)

Tue, Jan 12, 11:47 AM · Restricted Project, Restricted Project
sameeranjoshi updated the diff for D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

Summary of changes:

  • Simplify the test as those checks were already covered.
  • Update OMP.td to specifiy to add 5.0 standard for the clauses.
Tue, Jan 12, 11:43 AM · Restricted Project, Restricted Project
sameeranjoshi committed rG6f4d46076200: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided… (authored by sameeranjoshi).
[Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided…
Tue, Jan 12, 10:35 AM
sameeranjoshi closed D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce..
Tue, Jan 12, 10:35 AM · Restricted Project, Restricted Project
sameeranjoshi updated the summary of D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Tue, Jan 12, 10:13 AM · Restricted Project, Restricted Project
sameeranjoshi added inline comments to D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce..
Tue, Jan 12, 10:11 AM · Restricted Project, Restricted Project
sameeranjoshi updated the diff for D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..

Summary of changes:

  • Handle depend(source) and depend(sink:vec) separately.
  • Handle one more restriction from standard[5.0][2.17.9] which was needed with this patch. Either depend(sink:vec) clauses or depend(source) clauses may appear on an ordered construct, but not both.
Tue, Jan 12, 7:00 AM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

Need an answer here to proceed with review.

@kiranchandramohan I am trying to resuse the function CheckBranchesIntoDoBody . Will update the patch regarding the same.

@sameeranjoshi Will you be merging the related changes https://reviews.llvm.org/D93447 that makes use of LabelEnforce ?

Tue, Jan 12, 5:09 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jan 11

sameeranjoshi accepted D93575: [flang][openxx][NFC] Remove duplicated function to check required clauses.

LGMT. Thanks for cleaning that up.

Mon, Jan 11, 8:35 AM · Restricted Project, Restricted Project
sameeranjoshi accepted D94243: [flang][driver] Copy input files into a temp dir when testing (nfc).

Looks good.

Mon, Jan 11, 4:06 AM · Restricted Project

Sun, Jan 10

sameeranjoshi requested changes to D94228: [flang][driver] Support fixed form detection.
Sun, Jan 10, 11:48 PM · Restricted Project, Restricted Project

Sat, Jan 9

sameeranjoshi added inline comments to D93401: [flang][driver] Add support for `-D`, `-U`.
Sat, Jan 9, 1:53 AM · Restricted Project, Restricted Project

Thu, Jan 7

sameeranjoshi updated the diff for D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..

Summary of changes:

  • Fix core dump in ordered construct due to missing tree node visit

for OpenMPSimpleStandaloneConstruct as ordered with a depend falls under it.

  • Fix internal error in name resolution of depend clause.
Thu, Jan 7, 8:59 AM · Restricted Project, Restricted Project
sameeranjoshi added a reviewer for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive: sameeranjoshi.
Thu, Jan 7, 6:55 AM · Restricted Project, Restricted Project

Tue, Jan 5

sameeranjoshi added a project to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct.: Restricted Project.
Tue, Jan 5, 7:30 AM · Restricted Project, Restricted Project
sameeranjoshi requested review of D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Tue, Jan 5, 7:29 AM · Restricted Project, Restricted Project

Mon, Jan 4

sameeranjoshi accepted D93712: [flang][driver] Add checks for errors from `Prescan` and `Parse`.

Mostly nit comments.
Thanks and LGMT.

Mon, Jan 4, 10:33 PM · Restricted Project, Restricted Project
sameeranjoshi added inline comments to D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct..
Mon, Jan 4, 1:32 AM · Restricted Project

Sun, Jan 3

sameeranjoshi committed rG6280bc1cc34a: [Flang][openmp][5.0] Add task_reduction clause. (authored by sameeranjoshi).
[Flang][openmp][5.0] Add task_reduction clause.
Sun, Jan 3, 7:33 PM
sameeranjoshi closed D93105: [Flang][openmp][5.0] Add task_reduction clause..
Sun, Jan 3, 7:33 PM · Restricted Project, Restricted Project

Tue, Dec 22

sameeranjoshi added a reverting change for rG9a7895dc2085: [Flang][openmp][5.0] Add task_reduction clause.: rG1aa10ab2e1dd: Revert "[Flang][openmp][5.0] Add task_reduction clause.".
Tue, Dec 22, 10:24 AM
sameeranjoshi committed rG1aa10ab2e1dd: Revert "[Flang][openmp][5.0] Add task_reduction clause." (authored by sameeranjoshi).
Revert "[Flang][openmp][5.0] Add task_reduction clause."
Tue, Dec 22, 10:24 AM
sameeranjoshi added a reverting change for D93105: [Flang][openmp][5.0] Add task_reduction clause.: rG1aa10ab2e1dd: Revert "[Flang][openmp][5.0] Add task_reduction clause.".
Tue, Dec 22, 10:24 AM · Restricted Project, Restricted Project
sameeranjoshi added a comment to rG9a7895dc2085: [Flang][openmp][5.0] Add task_reduction clause..

Co-authored-by: Valentin Clement <clementval@gmail.com>

Tue, Dec 22, 9:29 AM
sameeranjoshi updated the summary of D93105: [Flang][openmp][5.0] Add task_reduction clause..
Tue, Dec 22, 9:25 AM · Restricted Project, Restricted Project
sameeranjoshi added 1 auditor(s) for rG9a7895dc2085: [Flang][openmp][5.0] Add task_reduction clause.: clementval.
Tue, Dec 22, 9:24 AM
sameeranjoshi committed rG9a7895dc2085: [Flang][openmp][5.0] Add task_reduction clause. (authored by sameeranjoshi).
[Flang][openmp][5.0] Add task_reduction clause.
Tue, Dec 22, 9:05 AM
sameeranjoshi closed D93105: [Flang][openmp][5.0] Add task_reduction clause..
Tue, Dec 22, 9:05 AM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D93105: [Flang][openmp][5.0] Add task_reduction clause..

@yhegde Will the changes in this patch affect your reduction patch (https://reviews.llvm.org/D90697)?

Yes. Rt now I am directly getting the list of Designators . Now it will become a level of indirection with the list of OmpObjects.
I may be missing something but OpenMP 4.5 and 5.0 Reduction clause restrictions looks very similar , why this one level of indirection required?! Is it because functions names in Reduction clause can come from common blocks ?!

Tue, Dec 22, 8:24 AM · Restricted Project, Restricted Project
sameeranjoshi accepted D93544: [flang][driver] Refactor unit tests for frontend actions (nfc).
Tue, Dec 22, 3:27 AM · Restricted Project, Restricted Project
sameeranjoshi committed rG1a6f43991ff7: [Flang][openmp][5/5] Make dist_schedule clause part of OmpClause (authored by sameeranjoshi).
[Flang][openmp][5/5] Make dist_schedule clause part of OmpClause
Tue, Dec 22, 1:03 AM
sameeranjoshi closed D93644: [Flang][openmp][5/5] Make dist_schedule clause part of OmpClause.
Tue, Dec 22, 1:02 AM · Restricted Project, Restricted Project
sameeranjoshi added inline comments to D93576: [openacc] Use TableGen enum for default clause value.
Tue, Dec 22, 1:02 AM · Restricted Project, Restricted Project
sameeranjoshi committed rGe282ae57da29: [Flang][openmp][4/5] Make nowait clause part of OmpClause (authored by sameeranjoshi).
[Flang][openmp][4/5] Make nowait clause part of OmpClause
Tue, Dec 22, 12:32 AM
sameeranjoshi closed D93643: [Flang][openmp][4/5] Make nowait clause part of OmpClause.
Tue, Dec 22, 12:32 AM · Restricted Project
sameeranjoshi committed rG34958d11c345: [Flang][openmp][3/5] Make ProcBind clause part of OmpClause (authored by sameeranjoshi).
[Flang][openmp][3/5] Make ProcBind clause part of OmpClause
Tue, Dec 22, 12:11 AM
sameeranjoshi closed D93642: [Flang][openmp][3/5] Make ProcBind clause part of OmpClause.
Tue, Dec 22, 12:11 AM · Restricted Project

Mon, Dec 21

sameeranjoshi committed rGf72c384b5ba9: [Flang][openmp][2/5] Make Default clause part of OmpClause (authored by sameeranjoshi).
[Flang][openmp][2/5] Make Default clause part of OmpClause
Mon, Dec 21, 11:48 PM
sameeranjoshi closed D93641: [Flang][openmp][2/5] Make Default clause part of OmpClause.
Mon, Dec 21, 11:48 PM · Restricted Project
sameeranjoshi committed rG442aac5da68c: [Flang][openmp][1/5] Make Allocate clause part of OmpClause (authored by sameeranjoshi).
[Flang][openmp][1/5] Make Allocate clause part of OmpClause
Mon, Dec 21, 11:24 PM
sameeranjoshi closed D93640: [Flang][openmp][1/5] Make Allocate clause part of OmpClause.
Mon, Dec 21, 11:23 PM · Restricted Project
sameeranjoshi added inline comments to D93544: [flang][driver] Refactor unit tests for frontend actions (nfc).
Mon, Dec 21, 11:20 PM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D93544: [flang][driver] Refactor unit tests for frontend actions (nfc).

Thank you!
That was much needed to extract into a fixture, given a few upcoming reviews.

Mon, Dec 21, 10:15 PM · Restricted Project, Restricted Project
sameeranjoshi added a project to D93644: [Flang][openmp][5/5] Make dist_schedule clause part of OmpClause: Restricted Project.
Mon, Dec 21, 9:44 AM · Restricted Project, Restricted Project
sameeranjoshi requested review of D93644: [Flang][openmp][5/5] Make dist_schedule clause part of OmpClause.
Mon, Dec 21, 9:37 AM · Restricted Project, Restricted Project
sameeranjoshi requested review of D93643: [Flang][openmp][4/5] Make nowait clause part of OmpClause.
Mon, Dec 21, 9:30 AM · Restricted Project
sameeranjoshi requested review of D93642: [Flang][openmp][3/5] Make ProcBind clause part of OmpClause.
Mon, Dec 21, 9:29 AM · Restricted Project
sameeranjoshi requested review of D93641: [Flang][openmp][2/5] Make Default clause part of OmpClause.
Mon, Dec 21, 9:28 AM · Restricted Project
sameeranjoshi requested review of D93640: [Flang][openmp][1/5] Make Allocate clause part of OmpClause.
Mon, Dec 21, 9:25 AM · Restricted Project

Fri, Dec 18

sameeranjoshi added inline comments to D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct..
Fri, Dec 18, 10:57 AM · Restricted Project
sameeranjoshi updated the diff for D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct..

Remove unnecessary variable mayBeName.

Fri, Dec 18, 10:54 AM · Restricted Project
sameeranjoshi updated the diff for D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct..

Merge ResolveName into ResolveOmpName.

Fri, Dec 18, 10:06 AM · Restricted Project
sameeranjoshi added inline comments to D93482: [flang][openmp] Make Reduction clause part of OmpClause.
Fri, Dec 18, 9:10 AM · Restricted Project, Restricted Project
sameeranjoshi added inline comments to D93482: [flang][openmp] Make Reduction clause part of OmpClause.
Fri, Dec 18, 8:41 AM · Restricted Project, Restricted Project
sameeranjoshi accepted D93482: [flang][openmp] Make Reduction clause part of OmpClause.
Fri, Dec 18, 8:19 AM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D93482: [flang][openmp] Make Reduction clause part of OmpClause.

+1 for finding the issue.
Thanks for the efforts and LGMT.

Fri, Dec 18, 5:24 AM · Restricted Project, Restricted Project

Thu, Dec 17

sameeranjoshi updated the diff for D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

Address review comments.

Thu, Dec 17, 3:51 AM · Restricted Project, Restricted Project
sameeranjoshi accepted D92672: [flang][openacc] Enforce restriction on routine directive and clauses.

LGTM.
Please take care of the remaining nits comments before merging.
Thank you @tskeith for pointers.

Thu, Dec 17, 2:26 AM · Restricted Project, Restricted Project
sameeranjoshi committed rGa4e47cd1857b: [Flang][openmp]Fix crash in OpenMP semantic check( bug 48308) (authored by sameeranjoshi).
[Flang][openmp]Fix crash in OpenMP semantic check( bug 48308)
Thu, Dec 17, 1:47 AM
sameeranjoshi closed D92638: [Flang][openmp]Fix crash in OpenMP semantic check( bug 48308).
Thu, Dec 17, 1:47 AM · Restricted Project
sameeranjoshi accepted D92123: [flang][openacc] Update serial construct clauses for OpenACC 3.1.
Thu, Dec 17, 1:43 AM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce..

Addresses one of the comments from
https://reviews.llvm.org/D88655#2356685

Thu, Dec 17, 1:28 AM · Restricted Project, Restricted Project
sameeranjoshi added a project to D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce.: Restricted Project.
Thu, Dec 17, 1:28 AM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

Please suggest.

Thu, Dec 17, 1:27 AM · Restricted Project, Restricted Project, Restricted Project
sameeranjoshi requested review of D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce..
Thu, Dec 17, 1:26 AM · Restricted Project, Restricted Project

Wed, Dec 16

sameeranjoshi added inline comments to D92672: [flang][openacc] Enforce restriction on routine directive and clauses.
Wed, Dec 16, 10:34 AM · Restricted Project, Restricted Project
sameeranjoshi added inline comments to D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..
Wed, Dec 16, 10:27 AM · Restricted Project, Restricted Project
sameeranjoshi added inline comments to D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct..
Wed, Dec 16, 10:24 AM · Restricted Project

Dec 16 2020

sameeranjoshi updated the diff for D92638: [Flang][openmp]Fix crash in OpenMP semantic check( bug 48308).

Try to simplify comments.

Dec 16 2020, 4:48 AM · Restricted Project
sameeranjoshi added a comment to D92672: [flang][openacc] Enforce restriction on routine directive and clauses.

Thanks for patch.
A few comments below.

Dec 16 2020, 4:28 AM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D92123: [flang][openacc] Update serial construct clauses for OpenACC 3.1.

Thanks for the upgrade.
A comment below.

Dec 16 2020, 2:27 AM · Restricted Project, Restricted Project
sameeranjoshi added a project to D92741: [flang][openacc] Enforce delcare directive restriction: Restricted Project.
Dec 16 2020, 1:56 AM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D92741: [flang][openacc] Enforce delcare directive restriction.

Thanks for the patch.
A few comments below.

Dec 16 2020, 1:56 AM · Restricted Project, Restricted Project

Dec 15 2020

sameeranjoshi added a project to D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.: Restricted Project.
Dec 15 2020, 11:17 PM · Restricted Project, Restricted Project
sameeranjoshi updated the diff for D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..

Fix newlines.

Dec 15 2020, 11:12 PM · Restricted Project, Restricted Project
sameeranjoshi requested review of D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..
Dec 15 2020, 11:00 PM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D93105: [Flang][openmp][5.0] Add task_reduction clause..

Thank you for reviewing.

Dec 15 2020, 10:58 PM · Restricted Project, Restricted Project
sameeranjoshi updated the diff for D93105: [Flang][openmp][5.0] Add task_reduction clause..

Update OmpReductionClause to use OmpObjectList.
Make OmpTaskReductionClause depend on OmpReductionClause.
This change was needed to create consistency among the reduction clauses.

Dec 15 2020, 10:49 PM · Restricted Project, Restricted Project

Dec 14 2020

sameeranjoshi added inline comments to D93105: [Flang][openmp][5.0] Add task_reduction clause..
Dec 14 2020, 11:13 AM · Restricted Project, Restricted Project
sameeranjoshi added inline comments to D92638: [Flang][openmp]Fix crash in OpenMP semantic check( bug 48308).
Dec 14 2020, 11:06 AM · Restricted Project
sameeranjoshi committed rGf1569b1ece55: [Flang][OpenMP-5.0] Semantic checks for flush construct. (authored by sameeranjoshi).
[Flang][OpenMP-5.0] Semantic checks for flush construct.
Dec 14 2020, 12:05 AM
sameeranjoshi closed D89879: [Flang][OpenMP-5.0] Semantic checks for flush construct..
Dec 14 2020, 12:05 AM · Restricted Project, Restricted Project

Dec 13 2020

sameeranjoshi committed rGe43b3b08ccd6: [Flang][OpenMP] Semantic checks for Atomic construct. (authored by sameeranjoshi).
[Flang][OpenMP] Semantic checks for Atomic construct.
Dec 13 2020, 11:35 PM
sameeranjoshi closed D89583: [Flang][OpenMP] Semantic checks for Atomic construct..
Dec 13 2020, 11:35 PM · Restricted Project, Restricted Project
sameeranjoshi accepted D92854: [flang][driver] Add support for `-fsyntax-only`.

Looks good from my end.
Thank you.

Dec 13 2020, 11:11 PM · Restricted Project, Restricted Project

Dec 11 2020

sameeranjoshi updated the summary of D93105: [Flang][openmp][5.0] Add task_reduction clause..
Dec 11 2020, 4:41 AM · Restricted Project, Restricted Project
sameeranjoshi updated the summary of D93105: [Flang][openmp][5.0] Add task_reduction clause..
Dec 11 2020, 4:39 AM · Restricted Project, Restricted Project
sameeranjoshi requested review of D93105: [Flang][openmp][5.0] Add task_reduction clause..
Dec 11 2020, 4:37 AM · Restricted Project, Restricted Project

Dec 10 2020

sameeranjoshi updated the diff for D89583: [Flang][OpenMP] Semantic checks for Atomic construct..

Add a clarification comment.

Dec 10 2020, 10:10 AM · Restricted Project, Restricted Project
sameeranjoshi updated the diff for D92638: [Flang][openmp]Fix crash in OpenMP semantic check( bug 48308).

change test name.
Change title.

Dec 10 2020, 9:56 AM · Restricted Project
sameeranjoshi requested review of D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct..
Dec 10 2020, 9:35 AM · Restricted Project