updated commit message

Minor fix in test case; Rebased.

Rebased. Verified, this patch is not causing any test failures for me.

Minor test fix

Removed parent line in summary, it was not longer relevant and caused build failures.

Rebase to current main branch

@jdoerfert Could you please take a look at this patch as well? (especially for the clang part)

@kiranchandramohan The tests passed now!

Rebased

@kiranchandramohan It failed again. Apparently, it automatically attempted to add a patch D93105 which is already merged. I removed that patch as dependency before (edit related revisions), but it seems to have been added again.
Am I missing something?

Oh great! That triggered it!
Thank you!

Rebased

In D93373#2832533, @kiranchandramohan wrote:

It could be because you are not the author. Can you commandeer the patch (option available in the Add Action menu below)?

Hi @kiranchandramohan How do I restart the build? It says I don't have permission.

Rebased to main

Fixes the clang test cases

LGTM. I'll let someone else take a look too.

Rebase to retrigger build

Corrected rebase

Rebased to HEAD of main branch

Rebased to HEAD of main branch

In D91054#2708873, @jdoerfert wrote:

What is missing or not working in the IRBuilder impl that prevents us from turning it on by default?

@jdoerfert Anything else to do here? Can this be merged?

@Meinersbur For D89671, Johannes had some comments which have been taken care of. I am just waiting for him to get back on it. I'll ping him there.
This patch is done from my end unless someone has some comment/thought.

In D91054#2693514, @fghanim wrote:

You can update the tests as long as long as the output is correct. for example the difference is only in names, ordering of basicblocks and instructions that doesn't affect correctness, etc.

Incorporated comments.

Removed the mistakenly added utils file (common.py)

Fixed cancel codegen crash, updated test case.

Fixed cancel construct and applied updates to its test cases

LGTM.
I'll let someone else review the patch if required.

@fghanim @jdoerfert please review the code if/when possible.

Added FIXME comment for cancellation construct not working with sections construct
Also updated the lit test cases to reflect this change.
The lit test case modification will be removed once this issue is resolved.

Added IsCancellable parameter to EmitOMPInlinedRegion for sections construct.
Even after which, the cancel construct is causing an assertion failure.
For now, this is marked as an expected failure and the FIXME comment is available.
The clang test case (marked XFAIL) is available in frontend patch - D91054.

Currently cancellation clause is failing to work, within sections directive. Working on it.

removed the accidentally added test statement

Added OMP delegating code for createSection (EmitOMPSectionDirective).
@fghanim working on clang lit test case.

Address a comment.

Added the use of createCanonicalLoop and createStaticWorkshareLoop.
Created OMP.createSection for handling the section's code generation.
Section callbacks are no longer a part of createSections.
Modified EmitOMPInlinedRegion to be able to handle nullptr for EntryCall/ExitCall parameters.
Removed changes from OMPConstants.hpp and OMPKinds.def to, originally, move to separate differential, but now are not required since loop creation is handled with createCanonicalLoop and createStaticWorkshareLoop.
OMP.createSections no longer uses EmitOMPInlinedRegion.

Please don't merge this differential.
With new changes being done in D89671, this will probably no longer be required.

Addressing comment

@jdoerfert Ouch. Totally forgot about that, apologies, on it.
Would it be fine/better to have the change for that in a separate patch though? Or must it be a part of this patch itself?

Updated BGenCallbackTy to StorableBodyGenCallbackTy.

Updated information for StoredBodyGenCallbackTy

Updated code according to the changes in LLVM side of things.

Updated code, test case, fixed some issues

Fixed usage of BodyGenCallbackTy
Removed ArrayRef variable

Added FiniCB usage and Control Flow Graph

The test case will also be added here.

Minor corrections in naming

squashed the commits

Applied some review changes

Amended the original commit, applying the fixes:

@fghanim Hello and thank you!