Page MenuHomePhabricator

yhegde (Yashaswini Hegde)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 14 2020, 5:09 AM (6 w, 2 h)

Recent Activity

Yesterday

yhegde added inline comments to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Tue, Nov 24, 11:11 PM · Restricted Project, Restricted Project, Restricted Project

Sun, Nov 22

yhegde closed D89861: [Flang][OpenMP 4.5] Add semantic check for OpenMP default clause.

Committed. https://reviews.llvm.org/rG3fa20baf009d

Sun, Nov 22, 5:20 AM · Restricted Project, Restricted Project, Restricted Project

Sat, Nov 21

yhegde added a comment to D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.

Shall I assume there are no issues with this patch. ?

Sat, Nov 21, 10:51 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added a comment to D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.
Sat, Nov 21, 10:45 AM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size.

Thank you very much for the inputs @kiranchandramohan . If my understanding is correct, this test case requires a run time check and probably it is not possible to do a semantic check.

Sat, Nov 21, 2:11 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Nov 20

yhegde requested review of D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size.
Fri, Nov 20, 9:58 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Nov 17

yhegde updated the diff for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

Thanks for review comments.
The code changes with this patch includes ResolvingNames for max, min, iand, ior, and ieor , assuming that the reduction clause can take user defined procedures.

Tue, Nov 17, 11:05 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Nov 13

yhegde updated the diff for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

Thank you both @kiranchandramohan and @clementval for your review comments and inputs.

Fri, Nov 13, 10:17 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Nov 12

yhegde updated the diff for D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.

Thanks for reviewing.
Function name PrivatizeAssociatedLoopIndex is changed to PrivatizeAssociatedLoopIndexAndCheckLoopLevel.

Thu, Nov 12, 9:53 PM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.

Thanks a lot for the review comments.
Requesting a quick review of this accepted patch. I had to revert the code part related to Shared and Private clause from the review https://reviews.llvm.org/D90324.

Thu, Nov 12, 10:55 AM · Restricted Project, Restricted Project, Restricted Project
yhegde added a comment to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

Thanks for this patch.

Can you check what is happening with this test?

      subroutine sb(q,nx)
      integer :: q(100)
      integer :: t1, t8
!$OMP PARALLEL DO PRIVATE(k,t1) REDUCTION(max:t8)
      do k=1,nx
        t1=q(k)
        t8=max(t8,t1)
      enddo
      end
Thu, Nov 12, 6:50 AM · Restricted Project, Restricted Project, Restricted Project

Sat, Nov 7

yhegde updated the diff for D89546: [Flang][OpenMP 4.5] Add semantic check for OpenMP schedule clause.
  1. Clause names are changed to uppercase in test cases.
  2. An optional StringRef paramName is introduced. Non optional paramName would break the previous test cases.
Sat, Nov 7, 9:04 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Nov 6

yhegde updated the diff for D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.
  1. From PrivatizeAssociatedLoopIndex function, the loop level checking code for ordered and collapse clause  is moved to CheckAssocLoopLevel function.
Fri, Nov 6, 6:26 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Nov 4

yhegde updated the diff for D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.
  1. Function name changed to CheckIsVarPartOfAnotherVar
  2. Clause names in uppercase.
Wed, Nov 4, 10:02 PM · Restricted Project, Restricted Project, Restricted Project
yhegde added a comment to D89546: [Flang][OpenMP 4.5] Add semantic check for OpenMP schedule clause.

If RPP () function constructed like this
void RequiresPositiveParameter(

const C &clause, const parser::ScalarIntExpr &i, llvm::StringRef paramName="parameter");

It wont break the test cases. Otherwise suggested change requires fixes in ERROR messages of previous test cases also. Shall I go ahead with this ?

Wed, Nov 4, 6:20 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Nov 3

yhegde requested review of D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Tue, Nov 3, 10:52 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Oct 29

yhegde updated the diff for D89546: [Flang][OpenMP 4.5] Add semantic check for OpenMP schedule clause.

Clause name changed to upper case.

Thu, Oct 29, 9:48 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Oct 27

yhegde updated the diff for D89546: [Flang][OpenMP 4.5] Add semantic check for OpenMP schedule clause.

RequiresPositiveParameter() is modified to take optional custom error message.

Tue, Oct 27, 9:08 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Oct 26

yhegde updated the diff for D89861: [Flang][OpenMP 4.5] Add semantic check for OpenMP default clause.

Positive test cases are added.

Mon, Oct 26, 11:35 AM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.
  1. More positive and negative test cases are added.
  2. Code moved to OmpAttributeVisitor.
Mon, Oct 26, 11:29 AM · Restricted Project, Restricted Project, Restricted Project

Oct 23 2020

yhegde updated the diff for D89546: [Flang][OpenMP 4.5] Add semantic check for OpenMP schedule clause.
  1. Three more test cases are added.
  2. RequiresPositiveParameter() function is not called, because with the custom implementation we can give specific error message pointing to invalid chunk size. If we use that function we will end up in throwing generic error message.
Oct 23 2020, 5:58 AM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D89861: [Flang][OpenMP 4.5] Add semantic check for OpenMP default clause.

Semantic check for OpenMP 4.5 - 2.15.3.1 default clause

Oct 23 2020, 5:35 AM · Restricted Project, Restricted Project, Restricted Project

Oct 21 2020

yhegde requested review of D89861: [Flang][OpenMP 4.5] Add semantic check for OpenMP default clause.
Oct 21 2020, 2:54 AM · Restricted Project, Restricted Project, Restricted Project
yhegde requested review of D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.
Oct 21 2020, 2:22 AM · Restricted Project, Restricted Project, Restricted Project

Oct 19 2020

yhegde updated the diff for D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.

clang format

Oct 19 2020, 11:02 AM · Restricted Project, Restricted Project, Restricted Project
yhegde updated the diff for D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.
  1. Array element check added along with test cases to test the same.
Oct 19 2020, 8:09 AM · Restricted Project, Restricted Project, Restricted Project

Oct 16 2020

yhegde requested review of D89546: [Flang][OpenMP 4.5] Add semantic check for OpenMP schedule clause.
Oct 16 2020, 5:56 AM · Restricted Project, Restricted Project, Restricted Project

Oct 15 2020

yhegde updated the diff for D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.
Oct 15 2020, 2:34 AM · Restricted Project, Restricted Project, Restricted Project

Oct 14 2020

yhegde added a project to D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause: Restricted Project.
Oct 14 2020, 8:01 AM · Restricted Project, Restricted Project, Restricted Project
yhegde requested review of D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.
Oct 14 2020, 7:59 AM · Restricted Project, Restricted Project, Restricted Project