User Details
- User Since
- Oct 14 2020, 5:09 AM (25 w, 5 d)
Mar 11 2021
Mar 10 2021
This patch is updated with a few more test cases with max/min etc in omp-reduction07.f90 and also TODO comments. Hope they are acceptable.
Mar 8 2021
Thank you for the review comments. Sure will update the diff with the suggestions.
Mar 6 2021
Patch updated and rebased to check Threadprivate variables in do loops , across the modules.
Thanks for the suggestion. This patch is rebased and updated with the popping of end_section and other end worksharing clauses fix.
Mar 4 2021
This patch is updated after addressing the review comments.
Mar 3 2021
Feb 27 2021
Feb 24 2021
Feb 23 2021
Patch updated and rebased after addressing the reviewer's comments.
Feb 16 2021
It works for the following case.
@kiranchandramohan , I was working with the following test case you have given ,
Feb 14 2021
Thank you @kiranchandramohan
Patch updated and rebased after addressing the review comments.
Thanks for the review comments. @kiranchandramohan . The patch is updated after addressing the review comments.
Feb 13 2021
Feb 10 2021
Based on Reviewer's comments , this patch is now updated with DoWhile , Cycles and other checks. Threadprivate related checks are removed.
Feb 9 2021
Feb 8 2021
Addressed the review comments and rebased .
Feb 6 2021
Feb 3 2021
This patch address the review comments.
The cycle related checks are in OmpCycleChecker class.
The test cases omp-do08.f90 and then omp-do12.f90 to omp-do17.f90 are the test cases for cycle checks.
Feb 2 2021
Feb 1 2021
This patch has the following changes.
- The functions CheckIntentInPointer and CheckDefinableObjects are combined and renamed as 'CheckIntentInPointerAndDefinable'.
- Removed CheckDependArraySection function.
- cleaned up unwanted code around multimap which was required earlier to reuse some part of the code.
- Added few test cases in omp-reduction02.f90 and omp-reduction07.f90 to address the review comments.
- Removed some unnecessary code in CheckIsVarPartOfAnotherVar
Jan 30 2021
Jan 29 2021
The patch is updated with Cycle checks in IfConstruct and CaseConstruct with omp-do15.f90 ,omp-do16.f90 and omp-do17.f90 . The parser::Walk is out of the loop now and called only once. Cycles are mostly a concern when appear in do loops with collapse clause. Hence most of the test cases are with collapse.
Jan 27 2021
Jan 26 2021
Code that are related to ordered clause and cycle stmts are modified to address the review comments.
Jan 21 2021
Addressed review comments.
Jan 14 2021
Jan 13 2021
Addressed the review comments related to loopIV.
Rebased with the latest changes.
Updated the patch with few more test cases.
Jan 12 2021
Jan 11 2021
Addressed the review comments.
Jan 9 2021
Rebased again.
Jan 8 2021
Rebased with some code changes.
Jan 5 2021
With updated Reduction Clause.
With updated Reduction Clause (OmpObjectList).
Dec 30 2020
Addressed review issues. Code with similar checks are reused. There are minor changes in depend clause related checks because same function is called from reduction clause related checks.
Dec 24 2020
Dec 22 2020
Dec 21 2020
This patch is updated with corrections to positive test cases and indentations.
This patch is updated with corrections to positive cases and indentations.
Dec 20 2020
This patch is updated with corrections to positive test cases and indentations.
Dec 19 2020
Dec 18 2020
Dec 14 2020
Dec 13 2020
Rebased. Requesting the review comments.
Dec 10 2020
Implementation includes a check to "the ordered clause must be present on the loop construct if any ordered region ever binds to a loop region arising from the loop construct" - along with the previous Do loop iteration variable check , Do while loop check , Do loop threadprivate check, Do loop cycle restrictions.
Dec 8 2020
Test cases added for named do loops. Global variables removed.
Dec 6 2020
Dec 1 2020
As reviewers feel this semantic check is not needed, I am closing this review.
and 4) neither loop is associated with a SIMD construct. A data dependence between the same logical iterations in two such loops is guaranteed to be satisfied allowing safe use of the nowait clause."
Nov 25 2020
This patch resolves the name symbol for the procedure, called in Reduction clause.
A new test case is added -
omp-reduction10.f90.
Nov 24 2020
Nov 22 2020
Committed. https://reviews.llvm.org/rG3fa20baf009d
Nov 21 2020
Shall I assume there are no issues with this patch. ?
Thank you very much for the inputs @kiranchandramohan . If my understanding is correct, this test case requires a run time check and probably it is not possible to do a semantic check.
Nov 20 2020
Nov 17 2020
Thanks for review comments.
The code changes with this patch includes ResolvingNames for max, min, iand, ior, and ieor , assuming that the reduction clause can take user defined procedures.
Nov 13 2020
Thank you both @kiranchandramohan and @clementval for your review comments and inputs.
Nov 12 2020
Thanks for reviewing.
Function name PrivatizeAssociatedLoopIndex is changed to PrivatizeAssociatedLoopIndexAndCheckLoopLevel.
Thanks a lot for the review comments.
Requesting a quick review of this accepted patch. I had to revert the code part related to Shared and Private clause from the review https://reviews.llvm.org/D90324.
Nov 7 2020
- Clause names are changed to uppercase in test cases.
- An optional StringRef paramName is introduced. Non optional paramName would break the previous test cases.