Committed. https://reviews.llvm.org/rG3fa20baf009d

Shall I assume there are no issues with this patch. ?

Thank you very much for the inputs @kiranchandramohan . If my understanding is correct, this test case requires a run time check and probably it is not possible to do a semantic check.

Thanks for review comments.
The code changes with this patch includes ResolvingNames for max, min, iand, ior, and ieor , assuming that the reduction clause can take user defined procedures.

Thank you both @kiranchandramohan and @clementval for your review comments and inputs.

Thanks for reviewing.
Function name PrivatizeAssociatedLoopIndex is changed to PrivatizeAssociatedLoopIndexAndCheckLoopLevel.

Thanks a lot for the review comments.
Requesting a quick review of this accepted patch. I had to revert the code part related to Shared and Private clause from the review https://reviews.llvm.org/D90324.

In D90697#2372471, @kiranchandramohan wrote:

Thanks for this patch.

Can you check what is happening with this test?

      subroutine sb(q,nx)
      integer :: q(100)
      integer :: t1, t8
!$OMP PARALLEL DO PRIVATE(k,t1) REDUCTION(max:t8)
      do k=1,nx
        t1=q(k)
        t8=max(t8,t1)
      enddo
      end

1. Clause names are changed to uppercase in test cases.
2. An optional StringRef paramName is introduced. Non optional paramName would break the previous test cases.

1. From PrivatizeAssociatedLoopIndex function, the loop level checking code for ordered and collapse clause  is moved to CheckAssocLoopLevel function.

1. Function name changed to CheckIsVarPartOfAnotherVar
2. Clause names in uppercase.

If RPP () function constructed like this
void RequiresPositiveParameter(

const C &clause, const parser::ScalarIntExpr &i, llvm::StringRef paramName="parameter");

It wont break the test cases. Otherwise suggested change requires fixes in ERROR messages of previous test cases also. Shall I go ahead with this ?

Clause name changed to upper case.

RequiresPositiveParameter() is modified to take optional custom error message.

Positive test cases are added.

1. More positive and negative test cases are added.
2. Code moved to OmpAttributeVisitor.

1. Three more test cases are added.
2. RequiresPositiveParameter() function is not called, because with the custom implementation we can give specific error message pointing to invalid chunk size. If we use that function we will end up in throwing generic error message.

Semantic check for OpenMP 4.5 - 2.15.3.1 default clause

clang format

1. Array element check added along with test cases to test the same.