Page MenuHomePhabricator

praveen (Praveen G)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 18 2020, 5:18 AM (29 w, 1 d)

Recent Activity

Tue, Mar 16

praveen committed rG1d7960a601fc: [Flang][OpenMP][OpenACC] Add function for mapping parser clause classes with… (authored by praveen).
[Flang][OpenMP][OpenACC] Add function for mapping parser clause classes with…
Tue, Mar 16, 11:54 PM
praveen closed D98603: [Flang] [OpenMP] Add function for mapping OpenMP Parser clause classes with the corresponding clause kind.
Tue, Mar 16, 11:53 PM · Restricted Project, Restricted Project, Restricted Project
praveen added a comment to D98603: [Flang] [OpenMP] Add function for mapping OpenMP Parser clause classes with the corresponding clause kind.

The clang-tidy seems to identify the case style as invalid for this function name GenerateFlangClauseParserKindMap
Any changes required regarding this ? All other functions in the file DirectiveEmitter.cpp follows the same naming convention.

Don't worry about this. All other TableGen backend follows this naming convention that's why we did it too.

Tue, Mar 16, 11:54 AM · Restricted Project, Restricted Project, Restricted Project
praveen added a comment to D98603: [Flang] [OpenMP] Add function for mapping OpenMP Parser clause classes with the corresponding clause kind.

@kiranchandramohan @clementval Thanks for the review . I have updated the test case for the Tablegen changes.

Tue, Mar 16, 10:56 AM · Restricted Project, Restricted Project, Restricted Project
praveen updated the diff for D98603: [Flang] [OpenMP] Add function for mapping OpenMP Parser clause classes with the corresponding clause kind.

Update test case directive1.td for TableGen changes

Tue, Mar 16, 10:49 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Mar 14

praveen requested review of D98603: [Flang] [OpenMP] Add function for mapping OpenMP Parser clause classes with the corresponding clause kind.
Sun, Mar 14, 9:49 AM · Restricted Project, Restricted Project, Restricted Project

Mar 1 2021

praveen committed rG75ef78ffee7f: [Flang][OpenMP] Add semantic checks for OpenMP clauses. (authored by praveen).
[Flang][OpenMP] Add semantic checks for OpenMP clauses.
Mar 1 2021, 6:25 AM
praveen closed D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.
Mar 1 2021, 6:25 AM · Restricted Project, Restricted Project, Restricted Project

Feb 28 2021

praveen added a comment to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

@kiranchandramohan The test case flang/test/Semantics/resolve102.f90 is failing with the error messages possibly due to the commit

Feb 28 2021, 10:14 PM · Restricted Project, Restricted Project, Restricted Project
praveen updated the diff for D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

Add TODO and comments for the data structures

Feb 28 2021, 10:41 AM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2021

praveen added inline comments to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.
Feb 24 2021, 10:02 AM · Restricted Project, Restricted Project, Restricted Project

Feb 12 2021

praveen added inline comments to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.
Feb 12 2021, 10:22 AM · Restricted Project, Restricted Project, Restricted Project
praveen updated the diff for D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

Check threadprivate variables in symbols with HostAssocDetails

Feb 12 2021, 10:19 AM · Restricted Project, Restricted Project, Restricted Project

Feb 11 2021

praveen added inline comments to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.
Feb 11 2021, 6:17 AM · Restricted Project, Restricted Project, Restricted Project

Feb 5 2021

praveen updated the diff for D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

Address review comments and rebase

Feb 5 2021, 10:21 AM · Restricted Project, Restricted Project, Restricted Project

Feb 3 2021

praveen committed rG5bc6e75386e7: [Flang][OpenMP] Add semantic checks for invalid branches into or out of OpenMP… (authored by praveen).
[Flang][OpenMP] Add semantic checks for invalid branches into or out of OpenMP…
Feb 3 2021, 2:59 AM
praveen closed D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.
Feb 3 2021, 2:59 AM · Restricted Project, Restricted Project, Restricted Project

Feb 2 2021

praveen added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Feb 2 2021, 9:35 AM · Restricted Project, Restricted Project, Restricted Project
praveen updated the diff for D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

Add check for cycle statements leaving OpenMP structured blocks

Feb 2 2021, 9:32 AM · Restricted Project, Restricted Project, Restricted Project
praveen added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Feb 2 2021, 6:49 AM · Restricted Project, Restricted Project, Restricted Project
praveen added inline comments to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Feb 2 2021, 6:10 AM · Restricted Project, Restricted Project, Restricted Project

Feb 1 2021

praveen added inline comments to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.
Feb 1 2021, 10:50 AM · Restricted Project, Restricted Project, Restricted Project
praveen added a comment to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

Thanks for the detailed listing. I think the second message in the do loop checks (non-openmp) is also not listed as an error. But they still check for that in the tests.
In short,

  1. you can follow what they do for the do loop checks (non-openmp)
  2. Add the two separate messages in the tests.
Feb 1 2021, 6:42 AM · Restricted Project, Restricted Project, Restricted Project
praveen updated the diff for D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

Modify error messages to identify branch into or branch out of openmp structued blocks

Feb 1 2021, 6:40 AM · Restricted Project, Restricted Project, Restricted Project

Jan 30 2021

praveen added a comment to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

I am not familiar with that. I can look up if required. But what I am suggesting is to do what is similar to the do loop checks like the following.

$ ./bin/flang ../flang/test/Semantics/doconcurrent03.f90
../flang/test/Semantics/doconcurrent03.f90:11:9: error: Control flow escapes from DO CONCURRENT
          goto 20
          ^^^^^^^
../flang/test/Semantics/doconcurrent03.f90:9:3: Enclosing DO CONCURRENT statement
    do 10 concurrent (i = 1:10)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
../flang/test/Semantics/doconcurrent03.f90:18:3: branch into loop body from outside
    goto 30
    ^^^^^^^
../flang/test/Semantics/doconcurrent03.f90:9:3: the loop branched into
    do 10 concurrent (i = 1:10)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
`
Jan 30 2021, 7:32 AM · Restricted Project, Restricted Project, Restricted Project

Jan 29 2021

praveen added a comment to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

Can the error messages be updated to check for the entire message, both the place where it is entering and leaving (or viceversa)?

Jan 29 2021, 9:53 AM · Restricted Project, Restricted Project, Restricted Project

Jan 28 2021

praveen added a comment to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

@kiranchandramohan I guess the checks work for all the OpenMP constructs . I have added the code for omp critical constructs to identify the invalid entry and branch to/from errors.

Jan 28 2021, 10:39 PM · Restricted Project, Restricted Project, Restricted Project
praveen updated the diff for D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

Use the logic in resolve-directives.cpp instead of 'LabelEnforce' to identify control flow escaping the OpenMP constructs.

Jan 28 2021, 10:23 PM · Restricted Project, Restricted Project, Restricted Project

Jan 25 2021

praveen added a comment to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

@kiranchandramohan @sameeranjoshi

I tried to make use of the CheckBranchesIntoDoBody function, but since it involves the use of multiple functions and types defined in resolve-labels.cpp such as using ProxyForScope, LabeledStatementInfoTuplePOD, SourceStatementInfoTuplePOD and also the labels, scopes and other details are being identified as part of the walk in ParseTreeAnalyzer class, it would be more complex to reuse these functions.

Hence I felt adding the logic in resolve-directives.cpp to identify the control flow to / from OpenMP structured blocks would be simple .

OK if it is difficult or too specialized for Do loops then no need to reuse CheckBranchesIntoDoBody.

Also handled the checks for all the statements involving labels as in 'LabelEnforce' class except AssignStmt.

void LabelEnforce::Post(const parser::AssignStmt &);
The check involving AssignStmt in LabelEnforce may not be suitable as part of the control flow checks for OpenMP constructs.

integer :: b
!$omp parallel
assign 5 to b
!$omp end parallel

5 print *, 5

In the above example, we detect this as an error as part of the 'LabelEnforce' check.

Can we make use of the function CheckLabelContext added as part of this change itself to check the control flow escaping the OpenMP constructs ?

Can we remove void LabelEnforce::Post(const parser::AssignStmt &); from LabelEnforce? Are you saying it is not applicable in this context but applicable in other contexts?

@kiranchandramohan We can maybe remove void LabelEnforce::Post(const parser::AssignStmt &); check from LabelEnforce as it detects the error when there is only AssignStmt.
The control flow escaping from 'CONSTRUCT' would make sense for parser::AssignStmt only when the assigned label is used in the goto stmt (AssignedGoto) in the same context as below.

Jan 25 2021, 3:53 AM · Restricted Project, Restricted Project, Restricted Project

Jan 22 2021

praveen added a comment to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

I tried to make use of the CheckBranchesIntoDoBody function, but since it involves the use of multiple functions and types defined in resolve-labels.cpp such as using ProxyForScope, LabeledStatementInfoTuplePOD, SourceStatementInfoTuplePOD and also the labels, scopes and other details are being identified as part of the walk in ParseTreeAnalyzer class, it would be more complex to reuse these functions.

Jan 22 2021, 12:16 AM · Restricted Project, Restricted Project, Restricted Project
praveen updated the diff for D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

Handle all the statements invloving labels and branches.

Jan 22 2021, 12:07 AM · Restricted Project, Restricted Project, Restricted Project

Jan 19 2021

praveen committed rGc42f5ca3d84c: [Flang][OpenMP] Add semantic checks for OpenMP Workshare Construct (authored by praveen).
[Flang][OpenMP] Add semantic checks for OpenMP Workshare Construct
Jan 19 2021, 6:36 AM
praveen closed D93091: [Flang] [OpenMP] Add semantic checks for OpenMP Workshare Construct.
Jan 19 2021, 6:35 AM · Restricted Project

Jan 18 2021

praveen updated the diff for D93091: [Flang] [OpenMP] Add semantic checks for OpenMP Workshare Construct.

Address review comments

Jan 18 2021, 12:12 PM · Restricted Project
praveen added inline comments to D93091: [Flang] [OpenMP] Add semantic checks for OpenMP Workshare Construct.
Jan 18 2021, 9:45 AM · Restricted Project

Jan 15 2021

praveen added a comment to D93091: [Flang] [OpenMP] Add semantic checks for OpenMP Workshare Construct.

Add a few tests to show that most restrictions do not apply inside a parallel construct nested inside a workshare construct.

Jan 15 2021, 6:40 AM · Restricted Project
praveen updated the diff for D93091: [Flang] [OpenMP] Add semantic checks for OpenMP Workshare Construct.

Use parse-tree walk to check the validity of assignments and expressions in workshare construct .

Jan 15 2021, 6:37 AM · Restricted Project

Jan 14 2021

praveen added a comment to D93091: [Flang] [OpenMP] Add semantic checks for OpenMP Workshare Construct.

@kiranchandramohan To make use of parse-tree walk to check all the assignments and expressions in OpenMP Workshare constructs , is it preferred to add a class in check-omp-structure.cpp specific for workshare or add a generic class in Semantics/tools.cpp to collect all the assignments and expressions and then iterate over all the assignments / expressions identified in the walk?

Jan 14 2021, 11:36 AM · Restricted Project

Jan 12 2021

praveen added a comment to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

Need an answer here to proceed with review.

@kiranchandramohan I am trying to resuse the function CheckBranchesIntoDoBody . Will update the patch regarding the same.

@sameeranjoshi Will you be merging the related changes https://reviews.llvm.org/D93447 that makes use of LabelEnforce ?

I was waiting for action based on the approach we follow from the current patch.
If all statements from LabelEnforce are allowed inside an openmp block, I can merge the pending patch?

Jan 12 2021, 6:07 AM · Restricted Project, Restricted Project, Restricted Project

Jan 11 2021

praveen added a comment to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

Need an answer here to proceed with review.

Jan 11 2021, 9:57 AM · Restricted Project, Restricted Project, Restricted Project

Jan 9 2021

praveen added a comment to D93091: [Flang] [OpenMP] Add semantic checks for OpenMP Workshare Construct.

@kiranchandramohan Updated the patch to handle all the checks on workshare construct . Since the WhereConstruct and ForallConstructs have nested WhereStmt/WhereConstructs and ForAllStmt/ForallConstructs , separate functions are added to handle the same recursively.

Jan 9 2021, 5:21 AM · Restricted Project
praveen updated the diff for D93091: [Flang] [OpenMP] Add semantic checks for OpenMP Workshare Construct.
  1. Handle uses of non-elemental functions in the workshare construct
  2. Handle the nested where/forall constructs enclosed in the workshare construct
  3. Apply the restrictions on workshare to OpenMP critical construct enclosed in workshare construct
Jan 9 2021, 5:13 AM · Restricted Project

Jan 5 2021

praveen updated the diff for D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

Update to latest syntax of Omp Reduction clause

Jan 5 2021, 2:32 AM · Restricted Project, Restricted Project, Restricted Project

Dec 30 2020

praveen added a comment to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

@kiranchandramohan @sameeranjoshi Will the patch https://reviews.llvm.org/D93105 be committed to the master again?
If so , the function void GetSymbolsInDesignatorList(const std::list<parser::Designator> &, SymbolSourceMap &); would not be required.

Dec 30 2020, 7:38 AM · Restricted Project, Restricted Project, Restricted Project
praveen updated the diff for D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

Handle all the private symbols in enclosing context for firstprivate and lastprivate clauses

Dec 30 2020, 12:07 AM · Restricted Project, Restricted Project, Restricted Project

Dec 25 2020

praveen committed rGa2ca6bbda616: [Flang][OpenMP] Add semantic check for OpenMP Private, Firstprivate and… (authored by praveen).
[Flang][OpenMP] Add semantic check for OpenMP Private, Firstprivate and…
Dec 25 2020, 1:22 AM
praveen closed D93213: [Flang] [OpenMP] Add semantic check for OpenMP private ,firstprivate and lastprivate clauses.
Dec 25 2020, 1:21 AM · Restricted Project, Restricted Project, Restricted Project

Dec 17 2020

praveen added a comment to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

Please suggest.

Please see D93447 if it helps in this patch.
I am unaware of and haven't looked into how we can reuse code for branching inside maybe you can think/would be better how we could reuse the code already present.
Also do look into NoBranchingEnforce if we can reuse.

Dec 17 2020, 2:15 AM · Restricted Project, Restricted Project, Restricted Project

Dec 16 2020

praveen added a comment to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

There is a labelEnforce class (https://github.com/llvm/llvm-project/blob/a2f922140f5380571fb74179f2bf622b3b925697/flang/lib/Semantics/tools.cpp#L1338) which is used for checks in do-concurrent and co-arrays. It is used to find control flow escaping from a construct. Can that be reused?

Dec 16 2020, 1:05 AM · Restricted Project, Restricted Project, Restricted Project
praveen updated the diff for D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

Check invalid branch into/from all the openMP constructs with structured blocks

Dec 16 2020, 12:48 AM · Restricted Project, Restricted Project, Restricted Project

Dec 14 2020

praveen added a comment to D93213: [Flang] [OpenMP] Add semantic check for OpenMP private ,firstprivate and lastprivate clauses.

"Variables that appear in namelist statements, in variable format expressions, or in expressions for statement function definitions, may not appear in a firstprivate clause."

Dec 14 2020, 7:13 AM · Restricted Project, Restricted Project, Restricted Project
praveen requested review of D93213: [Flang] [OpenMP] Add semantic check for OpenMP private ,firstprivate and lastprivate clauses.
Dec 14 2020, 7:09 AM · Restricted Project, Restricted Project, Restricted Project

Dec 11 2020

praveen updated the diff for D93091: [Flang] [OpenMP] Add semantic checks for OpenMP Workshare Construct.

Rebase and apply clang-format

Dec 11 2020, 12:27 AM · Restricted Project
praveen requested review of D93091: [Flang] [OpenMP] Add semantic checks for OpenMP Workshare Construct.
Dec 11 2020, 12:04 AM · Restricted Project

Dec 6 2020

praveen requested review of D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.
Dec 6 2020, 11:08 AM · Restricted Project, Restricted Project, Restricted Project

Dec 2 2020

praveen added a comment to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

@kiranchandramohan In the test file omp-clause-validity01.f90 , the following no symbol found errors are not being thrown.

!ERROR: Internal: no symbol found for 'i'
!$omp taskwait depend(sink:i-1)

!ERROR: Internal: no symbol found for 'first'
!$omp critical (first)

Since the errors related to copyprivate clause in omp-clause-validity01.f90 (line numbers 324 and 340 above) being thrown as part of the checks for copyprivate in resolve-directives.cpp are marked as fatal errors , the flag errorOnUnresolvedName_ is being set to false and the no symbol found error is not being thrown.

 RewriteMutator(SemanticsContext &context)
 : errorOnUnresolvedName_{!context.AnyFatalError()},
    messages_{context.messages()} {}

void RewriteMutator::Post(parser::Name &name) {
   if (!name.symbol && errorOnUnresolvedName_) {
     messages_.Say(name.source, "Internal: no symbol found for '%s'"_err_en_US,
       name.source);
    }
 }

Is it not necessary to throw the "no symbol found" error if there is any error marked as fatal while resolving the directives ?

Should all the checks related to copyprivate be moved to check-omp-structure.cpp?

Can you please suggest the approach to follow for these changes?

Thanks!

I think these checks can stay in the current file since they need to check the data sharing attributes.
For the depend clause I think the test need to be changed to a valid test. Is that OK @kiranktp.
For critical I believe we may not have done the semantic check and hence the symbol is not available. For this I think it is OK to comment out the check.

Is it not necessary to throw the "no symbol found" error if there is any error marked as fatal while resolving the directives ?

Is this OK @clementval ?

Dec 2 2020, 9:22 AM · Restricted Project, Restricted Project, Restricted Project
praveen updated the diff for D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

Addressed review comments and combined the test cases

Dec 2 2020, 9:14 AM · Restricted Project, Restricted Project, Restricted Project

Nov 30 2020

praveen committed rG7a91794d5b26: [Flang][OpenMP] Add semantic checks for OpenMP Private clause. (authored by praveen).
[Flang][OpenMP] Add semantic checks for OpenMP Private clause.
Nov 30 2020, 8:53 AM
praveen closed D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.
Nov 30 2020, 8:53 AM · Restricted Project, Restricted Project, Restricted Project

Nov 26 2020

praveen updated the diff for D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.

Added a flag in symbol.h to identify the symbols in namelist

Nov 26 2020, 1:17 AM · Restricted Project, Restricted Project, Restricted Project

Nov 23 2020

praveen added a comment to D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.

@kiranchandramohan Updated the reply for each of the inline comments.
Thanks!

Nov 23 2020, 10:14 PM · Restricted Project, Restricted Project, Restricted Project
praveen updated the diff for D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.

Address review comments.

Nov 23 2020, 10:50 AM · Restricted Project, Restricted Project, Restricted Project
praveen updated the diff for D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.

Rebase with latest master

Nov 23 2020, 2:22 AM · Restricted Project, Restricted Project, Restricted Project

Nov 22 2020

praveen added a comment to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

@kiranchandramohan In the test file omp-clause-validity01.f90 , the following no symbol found errors are not being thrown.

Nov 22 2020, 11:01 AM · Restricted Project, Restricted Project, Restricted Project

Nov 21 2020

praveen requested review of D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.
Nov 21 2020, 11:19 AM · Restricted Project, Restricted Project, Restricted Project

Nov 17 2020

praveen updated the diff for D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.

Modified the logic to identify all the variables in namelist statements

Nov 17 2020, 12:18 PM · Restricted Project, Restricted Project, Restricted Project

Nov 16 2020

praveen committed rG2e26459fabca: [Flang][OpenMP] Add semantic checks for OpenMP Depend clause. (authored by praveen).
[Flang][OpenMP] Add semantic checks for OpenMP Depend clause.
Nov 16 2020, 10:17 AM
praveen closed D89934: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Depend clause.
Nov 16 2020, 10:17 AM · Restricted Project, Restricted Project, Restricted Project

Nov 12 2020

praveen updated the diff for D89934: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Depend clause.

Add test case omp-depend03.f90 for usage of coarray in the depend clause

Nov 12 2020, 10:21 AM · Restricted Project, Restricted Project, Restricted Project

Nov 4 2020

praveen committed rGa4a4c503708f: [Flang][OpenMP] Add semantic checks for OpenMP copyin clause. (authored by praveen).
[Flang][OpenMP] Add semantic checks for OpenMP copyin clause.
Nov 4 2020, 12:21 AM
praveen closed D89385: [Flang][OpenMP 4.5] Add semantic check for OpenMP copyin clause.
Nov 4 2020, 12:21 AM · Restricted Project, Restricted Project, Restricted Project

Oct 28 2020

praveen updated the diff for D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.

Moved the pointer check to separate function as per review comment

Oct 28 2020, 4:55 AM · Restricted Project, Restricted Project, Restricted Project

Oct 27 2020

praveen updated the diff for D89385: [Flang][OpenMP 4.5] Add semantic check for OpenMP copyin clause.

Removed redundant code used to resolve threadprivate directive as per review comments.

Oct 27 2020, 11:34 PM · Restricted Project, Restricted Project, Restricted Project

Oct 26 2020

praveen updated the diff for D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.

Updated formatting

Oct 26 2020, 11:37 PM · Restricted Project, Restricted Project, Restricted Project
praveen requested review of D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.
Oct 26 2020, 10:59 PM · Restricted Project, Restricted Project, Restricted Project

Oct 21 2020

praveen requested review of D89934: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Depend clause.
Oct 21 2020, 11:46 PM · Restricted Project, Restricted Project, Restricted Project

Oct 19 2020

praveen added a comment to D89385: [Flang][OpenMP 4.5] Add semantic check for OpenMP copyin clause.

@kiranchandramohan @SouraVX Thanks for the review ! I have addressed the review comments as specified.

Oct 19 2020, 3:27 AM · Restricted Project, Restricted Project, Restricted Project
praveen updated the diff for D89385: [Flang][OpenMP 4.5] Add semantic check for OpenMP copyin clause.

Address the review comments and update the summary.

Oct 19 2020, 3:21 AM · Restricted Project, Restricted Project, Restricted Project

Oct 15 2020

praveen updated the diff for D89385: [Flang][OpenMP 4.5] Add semantic check for OpenMP copyin clause.

Added positive test cases , formatting as per review comments

Oct 15 2020, 4:53 AM · Restricted Project, Restricted Project, Restricted Project

Oct 14 2020

praveen updated the diff for D89385: [Flang][OpenMP 4.5] Add semantic check for OpenMP copyin clause.

Updated formatting

Oct 14 2020, 5:12 AM · Restricted Project, Restricted Project, Restricted Project
praveen requested review of D89385: [Flang][OpenMP 4.5] Add semantic check for OpenMP copyin clause.
Oct 14 2020, 4:48 AM · Restricted Project, Restricted Project, Restricted Project

Sep 23 2020

praveen added a comment to D87908: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs..

@DavidTruby Thanks !

Sep 23 2020, 7:19 AM · Restricted Project, Restricted Project, Restricted Project

Sep 22 2020

praveen added a comment to D87908: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs..

@kiranktp @DavidTruby Thanks for the review.

Sep 22 2020, 9:12 AM · Restricted Project, Restricted Project, Restricted Project

Sep 20 2020

praveen updated the summary of D87908: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs..
Sep 20 2020, 11:46 PM · Restricted Project, Restricted Project, Restricted Project
praveen updated the diff for D87908: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs..

Add test cases for more OpenMP constructs

Sep 20 2020, 11:45 PM · Restricted Project, Restricted Project, Restricted Project

Sep 18 2020

praveen added a reviewer for D87908: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs.: richard.barton.arm.
Sep 18 2020, 9:10 AM · Restricted Project, Restricted Project, Restricted Project
praveen requested review of D87908: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs..
Sep 18 2020, 8:35 AM · Restricted Project, Restricted Project, Restricted Project