In D108512#2959209, @kiranchandramohan wrote:

There is a similar patch (https://reviews.llvm.org/D94087) from @sameeranjoshi (AMD) which implements these constraints. Please go through the discussion in that patch. Also,

@kiranktp is it OK if @peixin proceed with this patch. He can use the D94087 as a reference and take it to completion. Peixin can add @sameeranjoshi as a co-author.

Aug 23 2021, 2:47 AM · Restricted Project

Jul 15 2021

kiranktp added reviewers for D105581: [MLIR][OpenMP] Teams Construct Operation: kiranchandramohan, clementval.

Jul 15 2021, 8:17 AM · Restricted Project

Mar 29 2021

kiranktp accepted D99494: [flang] Move .f77 to the list of fixed-form file extension.

LGTM

Mar 29 2021, 8:51 AM · Restricted Project, Restricted Project

Jan 7 2021

kiranktp accepted D92741: [flang][openacc] Enforce delcare directive restriction.

LGTM

Jan 7 2021, 3:08 AM · Restricted Project, Restricted Project

Jan 5 2021

kiranktp accepted D90786: [flang][openacc] Add more parsing/sema tests for init and shutdown directives.

LGTM

Jan 5 2021, 10:06 PM · Restricted Project

Dec 21 2020

kiranktp accepted D93644: [Flang][openmp][5/5] Make dist_schedule clause part of OmpClause.

LGTM

Dec 21 2020, 8:50 PM · Restricted Project, Restricted Project

kiranktp accepted D93643: [Flang][openmp][4/5] Make nowait clause part of OmpClause.

LGTM

Dec 21 2020, 8:49 PM · Restricted Project

kiranktp accepted D93642: [Flang][openmp][3/5] Make ProcBind clause part of OmpClause.

LGTM

Dec 21 2020, 8:48 PM · Restricted Project

kiranktp accepted D93641: [Flang][openmp][2/5] Make Default clause part of OmpClause.

LGTM.

Dec 21 2020, 8:28 PM · Restricted Project

Dec 11 2020

kiranktp added inline comments to D92638: [Flang][openmp]Fix crash in OpenMP semantic check( bug 48308).

Dec 11 2020, 3:24 AM · Restricted Project

kiranktp added inline comments to D92638: [Flang][openmp]Fix crash in OpenMP semantic check( bug 48308).

Dec 11 2020, 3:19 AM · Restricted Project

Nov 10 2020

kiranktp added a comment to D90538: [Flang][OpenMP] Fix 'Internal: no symbol found' for OpenMP aligned and linear clause..

LGTM

Nov 10 2020, 9:07 AM · Restricted Project, Restricted Project

Nov 5 2020

kiranktp added inline comments to D90786: [flang][openacc] Add more parsing/sema tests for init and shutdown directives.

Nov 5 2020, 12:15 AM · Restricted Project

Oct 28 2020

kiranktp accepted D90280: [flang][openacc] Enforce no modifier on enter data and exit data clauses.

LGTM

Oct 28 2020, 8:21 PM · Restricted Project

kiranktp added inline comments to D90280: [flang][openacc] Enforce no modifier on enter data and exit data clauses.

Oct 28 2020, 8:57 AM · Restricted Project

Oct 27 2020

kiranktp added inline comments to D90280: [flang][openacc] Enforce no modifier on enter data and exit data clauses.

Oct 27 2020, 11:33 PM · Restricted Project

kiranktp accepted D90185: [flang][openacc] Fix ambiguity in the self clause parsing.

LGTM

Oct 27 2020, 10:22 AM · Restricted Project, Restricted Project

Sep 28 2020

kiranktp committed rGf3ead88e9c6c: [MLIR][OpenMP] Removed the ambiguity in flush op assembly syntax (authored by kiranktp).

[MLIR][OpenMP] Removed the ambiguity in flush op assembly syntax

Sep 28 2020, 9:12 PM

kiranktp closed D88376: [MLIR][OpenMP] Removed the ambiguity in flush op assembly syntax.

Sep 28 2020, 9:12 PM · Restricted Project

Sep 27 2020

kiranktp updated the diff for D88376: [MLIR][OpenMP] Removed the ambiguity in flush op assembly syntax.

Incorporated review comments.

Sep 27 2020, 10:48 PM · Restricted Project

kiranktp added inline comments to D88376: [MLIR][OpenMP] Removed the ambiguity in flush op assembly syntax.

Sep 27 2020, 10:46 PM · Restricted Project

kiranktp requested review of D88376: [MLIR][OpenMP] Removed the ambiguity in flush op assembly syntax.

Sep 27 2020, 4:58 AM · Restricted Project

Sep 26 2020

kiranktp accepted D88326: [mlir][openacc] Remove detach and delete operands from acc.data.

LGTM

Sep 26 2020, 9:09 PM · Restricted Project

kiranktp added a comment to D88330: [mlir][openacc] Switch to assembly format for acc.data.

LGTM

Sep 26 2020, 4:44 AM · Restricted Project

Sep 21 2020

kiranktp added a comment to D87908: [flang] [OpenMP 4.5] Adding lit test cases for OpenMP Constructs..

Thanks for adding the OpenMP test cases Praveen!
However, the current plan is to support OpenMP 5.0 standard in llvm-project/flang.
Possible to upgrade these test cases to OpenMP 5.0?

Sep 21 2020, 12:43 AM · Restricted Project, Restricted Project, Restricted Project

Sep 15 2020

kiranktp accepted D87549: [OpenMP][MLIR] Add assembly format for master op.

LGTM

Sep 15 2020, 8:27 PM · Restricted Project

Sep 8 2020

kiranktp accepted D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

LGTM

Sep 8 2020, 9:08 AM · Restricted Project, Restricted Project, Restricted Project

Sep 7 2020

kiranktp added reviewers for D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR: anchu-rajendran, clementval.

Sep 7 2020, 6:27 PM · Restricted Project

kiranktp committed rG4536c6acb380: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0 (authored by kiranktp).

[flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0

Sep 7 2020, 6:22 PM

kiranktp closed D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0.

Sep 7 2020, 6:22 PM · Restricted Project, Restricted Project

kiranktp added inline comments to D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.

Sep 7 2020, 6:03 PM · Restricted Project

Sep 1 2020

kiranktp updated the diff for D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0.

Incorporated review comments.

Sep 1 2020, 12:30 AM · Restricted Project, Restricted Project

kiranktp added inline comments to D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0.

Sep 1 2020, 12:21 AM · Restricted Project, Restricted Project

Aug 5 2020

kiranktp added a comment to D85212: [flang] Add parser support for OpenMP allocate clause.

LGTM

Aug 5 2020, 9:01 AM · Restricted Project, Restricted Project

Jul 29 2020

kiranktp added a reviewer for D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0: clementval.

Jul 29 2020, 5:35 AM · Restricted Project, Restricted Project

kiranktp updated the diff for D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0.

Used Common openmp Directives and added a negative test case.

Jul 29 2020, 5:31 AM · Restricted Project, Restricted Project

Jul 28 2020

kiranktp added inline comments to D84798: [OpenMP,MLIR] Translation of parallel operation: num_threads, if clauses 3/n.

Jul 28 2020, 11:18 PM · Restricted Project

kiranktp added a comment to D84798: [OpenMP,MLIR] Translation of parallel operation: num_threads, if clauses 3/n.

LGTM

Jul 28 2020, 9:24 PM · Restricted Project

Jul 15 2020

kiranktp committed rGd4b1a14f0a6f: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0 (authored by kiranktp).

[flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0

Jul 15 2020, 9:42 PM

kiranktp closed D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0.

Jul 15 2020, 9:41 PM · Restricted Project, Restricted Project

kiranktp updated the diff for D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0.

taskwait has depend clause from OpenMP 5.0 and later.

Jul 15 2020, 9:37 AM · Restricted Project, Restricted Project

kiranktp added a comment to D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0.

In D82255#2153074, @clementval wrote:

Minor comment but LGTM.

Jul 15 2020, 7:04 AM · Restricted Project, Restricted Project

kiranktp added a reviewer for D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0: clementval.

Jul 15 2020, 2:20 AM · Restricted Project, Restricted Project

kiranktp updated the diff for D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0.

Rebasing after @clementval's patch and adding appropriate changes needed.

Jul 15 2020, 12:57 AM · Restricted Project, Restricted Project

Jul 14 2020

kiranktp added a comment to D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0.

In D82255#2149511, @kiranchandramohan wrote:

This looks OK but needs a rebase after @clementval's changes.

Jul 14 2020, 3:04 AM · Restricted Project, Restricted Project

Jul 8 2020

kiranktp added a comment to D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0.

In D82931#2134924, @sscalpone wrote:

Any syntax error will lead to chain of errors. It will be tough to add a case for invalid syntax.

Please consider adding error recovery to prevent the cascade of errors. See the docs and the parser for examples.

Jul 8 2020, 5:10 AM · Restricted Project, Restricted Project

Jul 7 2020

kiranktp committed rGcd503166fb74: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0 (authored by kiranktp).

[flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0

Jul 7 2020, 1:57 AM

Jul 6 2020

kiranktp added a comment to D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0.

In D82931#2132486, @DavidTruby wrote:

Looks good to me! As a nit, perhaps you could add some tests that shouldn't parse correctly as well?

Jul 6 2020, 9:15 PM · Restricted Project, Restricted Project

Jun 30 2020

kiranktp created D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0.

Jun 30 2020, 10:43 PM · Restricted Project, Restricted Project

kiranktp added a reviewer for D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0: • shivarama_rao.

Jun 30 2020, 10:43 PM · Restricted Project, Restricted Project

kiranktp added a comment to D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.

In D82177#2123312, @echristo wrote:

In D82177#2123184, @kiranchandramohan wrote:

@echristo was seeing a failure when running the test "Semantics/omp-clause-validity01.f90" as per his revert commit message.

Tests pass for me. I built and tested on an ubuntu Aarch64 machine. Flang was built as a release with debug build using gcc-9.2 with ninja.

I'm happy to try again if you think that the current diff should work :)

-eric

Jun 30 2020, 9:39 PM · Restricted Project, Restricted Project

kiranktp added a comment to D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.

In D82177#2123184, @kiranchandramohan wrote:

@echristo was seeing a failure when running the test "Semantics/omp-clause-validity01.f90" as per his revert commit message.

Tests pass for me. I built and tested on an ubuntu Aarch64 machine. Flang was built as a release with debug build using gcc-9.2 with ninja.

Jun 30 2020, 9:39 PM · Restricted Project, Restricted Project

Jun 26 2020

kiranktp added a comment to D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.

In D82177#2111512, @tskeith wrote:

What is happening with this change? It looks like it was applied and then reverted.
@echristo, was there a problem?

Jun 26 2020, 5:56 AM · Restricted Project, Restricted Project

Jun 24 2020

kiranktp added a comment to D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0.

Lint: Pre-merge checks

Jun 24 2020, 9:42 PM · Restricted Project, Restricted Project

Jun 23 2020

kiranktp updated the diff for D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0.

Corrected the section number to 2.17.5 [from OpenMP 5.0] for taskwait construct

Jun 23 2020, 5:17 AM · Restricted Project, Restricted Project

kiranktp updated the diff for D82176: [flang][OpenMP] Added parser support for Iterators (OpenMP 5.0) and updated depend clause.

Corrected the section number to 2.17.11 [From OpenMP 5.0] for Depend clause.
Removed the dependence type (inoutset) which is from OpenMP 5.1.

Jun 23 2020, 4:45 AM · Restricted Project, Restricted Project, Restricted Project

kiranktp updated the diff for D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.

Corrected the section number to 2.17.8 [from OpenMP 5.0] for flush construct

Jun 23 2020, 2:36 AM · Restricted Project, Restricted Project

Jun 20 2020

kiranktp added a comment to D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.

In D82177#2105223, @kiranchandramohan wrote:

Two comments.

memory-order-clause is defined for both atomic and flush instructions. We already have MemoryOrder
defined in the parse-tree for atomic in 4.5. In 4.5 memory-order can only be seq_cst. In 5.0 memory-order
for atomic can be seq_cst, acq_rel, release, acquire, relaxed. For flush it is only a subset and the allowed
values are only acq_rel, release, acquire.

Would it make sense to have a common definition for memory-order-clause and handle the fact that it
can only be a subset in semantics?

Flush is 2.17.8 (not 2.18.8) as part of the OpenMP 5.0 specification here. Is there a newer document?
https://www.openmp.org/wp-content/uploads/OpenMP-API-Specification-5.0.pdf

Jun 20 2020, 5:16 AM · Restricted Project, Restricted Project

kiranktp added a comment to D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.

In D82177#2105199, @echristo wrote:

Hi All,

The commit for this ended up failing so I temporarily reverted it in 64b04e4754bfe7bf718e5140fe1fd0ca50373c28. Feel free to recommit on fix :)

Thanks!

-eric

Jun 20 2020, 5:16 AM · Restricted Project, Restricted Project

kiranktp created D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0.

Jun 20 2020, 2:05 AM · Restricted Project, Restricted Project

kiranktp committed rGb32401464f4c: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0 (authored by kiranktp).

[flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0

Jun 20 2020, 1:33 AM

kiranktp closed D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.

Jun 20 2020, 1:33 AM · Restricted Project, Restricted Project

Jun 19 2020

kiranktp updated the diff for D82176: [flang][OpenMP] Added parser support for Iterators (OpenMP 5.0) and updated depend clause.

Corrected the test case

Jun 19 2020, 5:53 AM · Restricted Project, Restricted Project, Restricted Project

kiranktp created D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.

Jun 19 2020, 5:21 AM · Restricted Project, Restricted Project

kiranktp created D82176: [flang][OpenMP] Added parser support for Iterators (OpenMP 5.0) and updated depend clause.

Jun 19 2020, 4:49 AM · Restricted Project, Restricted Project, Restricted Project

Jun 16 2020

kiranktp abandoned D81848: [flang][OpenMP] Upgrade support for Flush, Depend, Taskwait construct to OpenMP 5.0.

Jun 16 2020, 11:57 PM · Restricted Project, Restricted Project

kiranktp added a comment to D81848: [flang][OpenMP] Upgrade support for Flush, Depend, Taskwait construct to OpenMP 5.0.

In D81848#2096663, @kiranchandramohan wrote:

@kiranktp Can we have separate patches for Flush, depend & iterator, taskwait? It will be easier to review.

Jun 16 2020, 10:23 PM · Restricted Project, Restricted Project