Page MenuHomePhabricator

[RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior
Needs ReviewPublic

Authored by mibintc on May 31 2019, 7:01 AM.

Details

Reviewers
chandlerc
Summary

Intel would like to contribute a patch to implement support for these Intel- and Microsoft -fp options. This message is to describe the options and request feedback from the community.
-fp-model=[precise|strict|fast|except[-]] and -fp-speculation=[fast|strict|safe]

This contribution would dovetail with the llvm patch "Teach the IRBuilder about constrained fadd and friends" which is under review here, https://reviews.llvm.org/D53157/new/. I have a patch ready to review that works with D53157. The motivation for providing these is that having a single option to control most basic FP options is better and easier to understand for users.

The companion llvm patch is available for review here: https://reviews.llvm.org/D62730 ; I made a couple small changes to D53157.

The option settings -fp-model=[precise|strict|fast|except] are supported by both ICC and CL. The fp-speculation option is supported only by ICC. The CL and ICC -fp-model option is documented on these pages:

https://docs.microsoft.com/en-us/cpp/build/reference/fp-specify-floating-point-behavior?view=vs-2019
https://software.intel.com/en-us/cpp-compiler-developer-guide-and-reference-fp-model-fp

Currently, clang's default behavior corresponds to -fp-model=precise. Clang/llvm support for -fp-model=[strict|except] is being developed in the D53157 patch, and there is current llvm support for the fast settings by using the fast math flags llvm::FastMathFlags. Note: the clang-cl wrapper to support Microsoft options has simplified support for these options by mapping /fp-model=except to ftrapping-math, fp-mdel=fast to ffast-math, fp-model=precise and fp-model=strict to fno-fast-math (see clang/Driver/CLCompatOptions.td).

According to the online options documentation, you can combine except[-] with [precise|strict|fast], but combining both fast and except is not a valid setting (the Driver will emit an error).

precise - Disables optimizations that are not value-safe on floating-point data, although FP contraction is enabled.
strict - Enables precise and except, disables contractions (FMA), and enables pragma stdc fenv_access.   
fast - Equivalent to -ffast-math
except/except- - Determines whether strict floating-point exception semantics are honored.

The ICC option -fp-speculation is described here,

https://software.intel.com/en-us/cpp-compiler-developer-guide-and-reference-fp-speculation-qfp-speculation

These are the meanings of the fp-speculation settings:

fast - Tells the compiler to speculate on floating-point operations.  This is equivalent to “fpexcept.ignore” in the constrained intrinsics review D53157.
strict - Tells the compiler to disable speculation on floating-point operations.  This is equivalent to “fpexcept.strict” in the constrained intrinsics review D53157.
safe - Tells the compiler to disable speculation if there is a possibility that the speculation may cause a floating-point exception.  This is equivalent to “fpexcept.maytrap” in the constrained intrinsics review D53157.

Diff Detail

Repository
rL LLVM

Event Timeline

mibintc created this revision.May 31 2019, 7:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2019, 7:01 AM

Documentation missing. All the blurb from patch description should be in doc/

pengfei added a subscriber: pengfei.Jun 2 2019, 5:40 PM
wuzish added a subscriber: wuzish.Wed, Jul 3, 7:35 PM