Page MenuHomePhabricator

royjacobson (Roy Jacobson)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 21 2022, 7:34 AM (57 w, 5 d)

Recent Activity

Yesterday

royjacobson added a comment to D147288: [clang][NFC] updates cxx_status for P2113R0.

There was some discussion of this last year in this review: https://reviews.llvm.org/D128750

Fri, Mar 31, 12:39 PM · Restricted Project, Restricted Project

Wed, Mar 29

royjacobson committed rG0eb06cb3aa27: [Sema] Stop stripping CV quals from *this captures in lambdas (authored by royjacobson).
[Sema] Stop stripping CV quals from *this captures in lambdas
Wed, Mar 29, 1:12 PM · Restricted Project, Restricted Project
royjacobson closed D146168: [Sema] Stop stripping CV quals from *this captures in lambdas.
Wed, Mar 29, 1:12 PM · Restricted Project, Restricted Project
royjacobson added a comment to D146168: [Sema] Stop stripping CV quals from *this captures in lambdas.

LGTM aside from a minor nit, though I have some minor concerns that we may silently break people's code by calling different overloads or instantiating templates differently so I wonder if this is a potentially breaking change or not. I think we can leave it out of the potentially breaking changes section unless we get some reports about a behavior change organically during this release cycle?

Wed, Mar 29, 12:11 PM · Restricted Project, Restricted Project
royjacobson updated the diff for D146168: [Sema] Stop stripping CV quals from *this captures in lambdas.

fix unintended indentation & rebase

Wed, Mar 29, 12:11 PM · Restricted Project, Restricted Project
royjacobson committed rGda71cbacfc3f: [Doc][Clang] Update information about default standard version (authored by royjacobson).
[Doc][Clang] Update information about default standard version
Wed, Mar 29, 4:26 AM · Restricted Project, Restricted Project
royjacobson committed rG6ce272b3f4ce: [Doc][Clang] Update Clang 16 from 'unreleased' to 'full' (authored by royjacobson).
[Doc][Clang] Update Clang 16 from 'unreleased' to 'full'
Wed, Mar 29, 4:20 AM · Restricted Project, Restricted Project
royjacobson updated the diff for D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields..

Add some ((packed)) tests

Wed, Mar 29, 4:16 AM · Restricted Project, Restricted Project

Thu, Mar 23

royjacobson added inline comments to D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields..
Thu, Mar 23, 3:06 PM · Restricted Project, Restricted Project

Mon, Mar 20

royjacobson added a comment to D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields.

I would have loved to test the case from https://github.com/llvm/llvm-project/issues/61335 directly but I think in order to do it nicely I need __builtin_memset to be usable in a constant expression context. I will add this to my todo list. I am open to other alternatives for testing this.

Mon, Mar 20, 2:16 PM · Restricted Project

Sat, Mar 18

royjacobson updated the summary of D146168: [Sema] Stop stripping CV quals from *this captures in lambdas.
Sat, Mar 18, 8:33 AM · Restricted Project, Restricted Project
royjacobson updated the diff for D146168: [Sema] Stop stripping CV quals from *this captures in lambdas.

Add the test case from the GH issue.

Sat, Mar 18, 8:31 AM · Restricted Project, Restricted Project

Wed, Mar 15

royjacobson committed rG765d8a192180: [Clang][Sema] Fix incorrect deletion of default constructors for some unions (authored by royjacobson).
[Clang][Sema] Fix incorrect deletion of default constructors for some unions
Wed, Mar 15, 2:56 PM · Restricted Project, Restricted Project
royjacobson closed D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions.
Wed, Mar 15, 2:56 PM · Restricted Project, Restricted Project
royjacobson updated the diff for D146168: [Sema] Stop stripping CV quals from *this captures in lambdas.

rebase + release notes.

Wed, Mar 15, 2:19 PM · Restricted Project, Restricted Project
royjacobson requested review of D146168: [Sema] Stop stripping CV quals from *this captures in lambdas.
Wed, Mar 15, 2:17 PM · Restricted Project, Restricted Project
royjacobson updated the diff for D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions.

slimmer codegen test

Wed, Mar 15, 2:13 PM · Restricted Project, Restricted Project
royjacobson added inline comments to D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields..
Wed, Mar 15, 1:25 PM · Restricted Project, Restricted Project

Tue, Mar 14

royjacobson added inline comments to D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions.
Tue, Mar 14, 12:28 PM · Restricted Project, Restricted Project
royjacobson added a comment to D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions.

Oops, sorry for the bad codegen test and thanks for the comments.

Tue, Mar 14, 12:27 PM · Restricted Project, Restricted Project
royjacobson updated the diff for D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions.

Fix the codegen test, add a standard ref to the comment.

Tue, Mar 14, 12:26 PM · Restricted Project, Restricted Project

Mon, Mar 13

royjacobson added inline comments to D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields..
Mon, Mar 13, 10:15 AM · Restricted Project, Restricted Project
royjacobson updated the diff for D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields..

Add a test case, slightly simpler modeling.

Mon, Mar 13, 10:10 AM · Restricted Project, Restricted Project
royjacobson added a comment to D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions.

Generally looks good to me. Do we do anything special if there are multiple initializers? Also, can we have a codegen test that validates that we actually construct it correctly (and perhaps a constexpr test for the same!)?

Mon, Mar 13, 10:02 AM · Restricted Project, Restricted Project
royjacobson updated the diff for D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions.

Add more tests, small nit.

Mon, Mar 13, 10:02 AM · Restricted Project, Restricted Project

Sat, Mar 11

royjacobson updated the diff for D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions.

Small cleanup

Sat, Mar 11, 1:30 PM · Restricted Project, Restricted Project
royjacobson updated the diff for D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields..

Handle 0-length unnamed bit fields as well.

Sat, Mar 11, 1:23 PM · Restricted Project, Restricted Project
royjacobson added reviewers for D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions: erichkeane, cor3ntin.
Sat, Mar 11, 8:59 AM · Restricted Project, Restricted Project
royjacobson added reviewers for D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.: shafik, Endill.
Sat, Mar 11, 8:58 AM · Restricted Project, Restricted Project
royjacobson updated the diff for D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields..

Change to a simpler fix.

Sat, Mar 11, 8:58 AM · Restricted Project, Restricted Project
royjacobson requested review of D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields..
Sat, Mar 11, 8:51 AM · Restricted Project, Restricted Project
royjacobson requested review of D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions.
Sat, Mar 11, 8:46 AM · Restricted Project, Restricted Project
royjacobson committed rGc0dc8f7a29e7: [Clang][Doc] Fix inconsistent links in release notes (authored by royjacobson).
[Clang][Doc] Fix inconsistent links in release notes
Sat, Mar 11, 8:40 AM · Restricted Project, Restricted Project

Fri, Mar 10

royjacobson added a comment to D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

@royjacobson, I've added some test cases for using the new NTTP arguments in clang modules. It uses serialization, in principle. Or more specialized tests are still needed?

Fri, Mar 10, 2:43 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sat, Mar 4

royjacobson committed rGfc10715f9bb3: Fix broken link on Clang documentation page (authored by tupaschoal).
Fix broken link on Clang documentation page
Sat, Mar 4, 3:00 PM · Restricted Project, Restricted Project
royjacobson closed D145047: Fix broken link on Clang documentation page.
Sat, Mar 4, 2:59 PM · Restricted Project, Restricted Project

Mar 2 2023

royjacobson accepted D145047: Fix broken link on Clang documentation page.

Thanks! Do you need me to land this for you? If so, could you please provide name + email to sign the commit with?

Mar 2 2023, 9:36 AM · Restricted Project, Restricted Project

Feb 26 2023

royjacobson added a comment to D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class..

LGTM, thanks for the contribution! Do you have commit rights or would you like that we land it for you? If so, please provide name and email for attribution.

Feb 26 2023, 4:00 AM · Restricted Project, Restricted Project
royjacobson committed rGaa56e66bf752: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor… (authored by royjacobson).
[clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor…
Feb 26 2023, 3:58 AM · Restricted Project, Restricted Project
royjacobson closed D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class..
Feb 26 2023, 3:58 AM · Restricted Project, Restricted Project

Feb 25 2023

royjacobson added a comment to D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

There are no AST [de]serialization tests in this PR, right? Would be nice to add some.

Feb 25 2023, 1:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
royjacobson added a comment to D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class..

friendly ping

Feb 25 2023, 12:50 PM · Restricted Project, Restricted Project

Feb 22 2023

royjacobson added a comment to D144572: [C++20] Stop claiming full support for consteval (for the moment!).

@aaron.ballman is the plan to backport that to clang 16? I think it probably should.
We ought to try to improve the situation for clang 17

Feb 22 2023, 1:29 PM · Restricted Project, Restricted Project
royjacobson committed rG000ec50ef511: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases. (authored by royjacobson).
[Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.
Feb 22 2023, 1:27 PM · Restricted Project, Restricted Project
royjacobson closed D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases..
Feb 22 2023, 1:27 PM · Restricted Project, Restricted Project
royjacobson accepted D144572: [C++20] Stop claiming full support for consteval (for the moment!).

+1 from me, at least as long as we don't define the feature test macro.

Feb 22 2023, 12:52 PM · Restricted Project, Restricted Project

Feb 15 2023

royjacobson committed rGf5aa8d191a5b: [Clang][docs] Update the release notes page to the new skeleton (authored by royjacobson).
[Clang][docs] Update the release notes page to the new skeleton
Feb 15 2023, 1:55 PM · Restricted Project, Restricted Project
royjacobson added a comment to D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases..

It's an interesting discussion, I just want to remind that this change is for triviality rules from P0848 (conditionally trivial member functions) which is only going to ship in Clang 16 anyway.

Feb 15 2023, 9:04 AM · Restricted Project, Restricted Project

Feb 14 2023

royjacobson added a comment to D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class..
In D143851#4126453, @ClockMan wrote:

Thing is that same issue may happen with all other members, what about copy/move constructors defaulted in .cpp (just to speed up compilation for classes with many members).
Best thing would simply to check if all definitions are available. In that case issues would be reported only for source file that corresponds to header file with defined class.
This would also reduce amount of generated warnings for a big project that include such header with class in many places.

Other good option would be to excluded classes defined in system headers, no point to check if some boost class or std::vector got proper constructors.

Feb 14 2023, 9:42 AM · Restricted Project, Restricted Project
royjacobson closed D142578: [Clang][Doc] Edit the Clang release notes.

Landed in https://github.com/llvm/llvm-project/commit/be701ab08f12daf9437c2db6d08a1731cf1df34c

Feb 14 2023, 8:56 AM · Restricted Project, Restricted Project

Feb 13 2023

royjacobson added inline comments to D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases..
Feb 13 2023, 10:03 AM · Restricted Project, Restricted Project
royjacobson committed rGb6259eca16f6: [Clang] Export CanPassInRegisters as a type trait (authored by royjacobson).
[Clang] Export CanPassInRegisters as a type trait
Feb 13 2023, 9:16 AM · Restricted Project, Restricted Project
royjacobson closed D141775: [Clang] Export CanPassInRegisters as a type trait.
Feb 13 2023, 9:16 AM · Restricted Project, Restricted Project
royjacobson updated the summary of D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class..
Feb 13 2023, 8:35 AM · Restricted Project, Restricted Project
royjacobson updated the diff for D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class..

Address CR comments.

Feb 13 2023, 8:24 AM · Restricted Project, Restricted Project
royjacobson added a comment to D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases..

This is an ABI breaking change, isn't it? (The type trait now returns something different than it did before, which could change instantiations or object layout.)

Feb 13 2023, 5:41 AM · Restricted Project, Restricted Project
royjacobson requested review of D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases..
Feb 13 2023, 2:15 AM · Restricted Project, Restricted Project

Feb 12 2023

royjacobson requested review of D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class..
Feb 12 2023, 11:30 AM · Restricted Project, Restricted Project
royjacobson updated subscribers of D142578: [Clang][Doc] Edit the Clang release notes.

friendly ping :)

Feb 12 2023, 10:28 AM · Restricted Project, Restricted Project
royjacobson updated the diff for D142578: [Clang][Doc] Edit the Clang release notes.

Rebase to include the RISC-V changes.

Feb 12 2023, 10:26 AM · Restricted Project, Restricted Project

Jan 30 2023

royjacobson added inline comments to D142578: [Clang][Doc] Edit the Clang release notes.
Jan 30 2023, 11:16 AM · Restricted Project, Restricted Project
royjacobson updated the diff for D142578: [Clang][Doc] Edit the Clang release notes.

15 -> Clang 15

Jan 30 2023, 11:16 AM · Restricted Project, Restricted Project

Jan 29 2023

royjacobson added a comment to D142578: [Clang][Doc] Edit the Clang release notes.

IDK. Clang 16 is fully is a fully conformant C++20 except for some DRs. Or beginning with Clang 16, we start a long-term project to overhaul the diagnostics.

I agree that breaking changes are important.

Jan 29 2023, 5:19 AM · Restricted Project, Restricted Project

Jan 28 2023

royjacobson added inline comments to D142578: [Clang][Doc] Edit the Clang release notes.
Jan 28 2023, 8:53 AM · Restricted Project, Restricted Project
royjacobson updated the diff for D142578: [Clang][Doc] Edit the Clang release notes.
  • Remove redundant paragraph from the intro
  • Remove outdated bug fix bullet
Jan 28 2023, 8:52 AM · Restricted Project, Restricted Project
royjacobson added a comment to D142578: [Clang][Doc] Edit the Clang release notes.

I am not the only one who has a different background. If the introduction says this is the introduction of the release notes, I am not super motivated to read on. I would prefer to see some highlights to motivate the readers to continue reading.

Jan 28 2023, 6:13 AM · Restricted Project, Restricted Project

Jan 26 2023

royjacobson added a comment to D142578: [Clang][Doc] Edit the Clang release notes.

Thanks Erich and Emilia!

Jan 26 2023, 10:42 AM · Restricted Project, Restricted Project
royjacobson updated the diff for D142578: [Clang][Doc] Edit the Clang release notes.
  • Address comments from Erich and Emilia
  • Validate that the rst actually builds an html file
  • Fix some missing backticks and underscores
Jan 26 2023, 10:39 AM · Restricted Project, Restricted Project

Jan 25 2023

royjacobson updated the summary of D142578: [Clang][Doc] Edit the Clang release notes.
Jan 25 2023, 1:08 PM · Restricted Project, Restricted Project
royjacobson requested review of D142578: [Clang][Doc] Edit the Clang release notes.
Jan 25 2023, 1:06 PM · Restricted Project, Restricted Project

Jan 21 2023

royjacobson updated the diff for D141775: [Clang] Export CanPassInRegisters as a type trait.

fix the test after diag change

Jan 21 2023, 1:43 PM · Restricted Project, Restricted Project

Jan 17 2023

royjacobson added inline comments to D141775: [Clang] Export CanPassInRegisters as a type trait.
Jan 17 2023, 1:57 PM · Restricted Project, Restricted Project
royjacobson updated the diff for D141775: [Clang] Export CanPassInRegisters as a type trait.

Reject non class types, update doc.

Jan 17 2023, 1:50 PM · Restricted Project, Restricted Project
royjacobson committed rG6a763343e29f: [Clang] Reject in-class defaulting of previously declared comparison operators (authored by royjacobson).
[Clang] Reject in-class defaulting of previously declared comparison operators
Jan 17 2023, 12:30 PM · Restricted Project, Restricted Project
royjacobson closed D141803: [Clang] Reject in-class defaulting of previously declared comparison operators.
Jan 17 2023, 12:30 PM · Restricted Project, Restricted Project

Jan 16 2023

royjacobson updated the diff for D141803: [Clang] Reject in-class defaulting of previously declared comparison operators.

rebase on main

Jan 16 2023, 11:03 AM · Restricted Project, Restricted Project

Jan 15 2023

royjacobson requested review of D141803: [Clang] Reject in-class defaulting of previously declared comparison operators.
Jan 15 2023, 2:42 PM · Restricted Project, Restricted Project

Jan 14 2023

royjacobson requested review of D141775: [Clang] Export CanPassInRegisters as a type trait.
Jan 14 2023, 1:14 PM · Restricted Project, Restricted Project

Jan 10 2023

royjacobson added a comment to D141358: Remove unnecessary template specifiers from truct constructors in tests..

Thanks for the pointers! Clang does not seem to diagnose or forbid this even in trunk. I suspect the DR is not yet implemented, but there are other changes to the parser that cause these errors? 'Down with typename' maybe?

Jan 10 2023, 4:05 AM · Restricted Project, Restricted Project
royjacobson added a comment to D141358: Remove unnecessary template specifiers from truct constructors in tests..

It's dr2237, see https://github.com/llvm/llvm-project/issues/55164

Jan 10 2023, 3:11 AM · Restricted Project, Restricted Project

Jan 7 2023

royjacobson accepted D141023: [C++20] [Modules] Make placement allocation functions always acceptable.

Since people run into this very quickly and the Clang workaround is pretty simple, LGTM.

Jan 7 2023, 9:33 AM · Restricted Project, Restricted Project, Restricted Project

Jan 5 2023

royjacobson planned changes to D140664: [Sema] Don't mark deleted special member functions as non-trivial.
Jan 5 2023, 1:43 PM · Restricted Project, Restricted Project
royjacobson reopened D140664: [Sema] Don't mark deleted special member functions as non-trivial.

So, I had a quick look at this. Turns out this fix changed the argument passing ABI for those classes on the Sony PS4. This is probably not acceptable :)

Jan 5 2023, 1:43 PM · Restricted Project, Restricted Project

Jan 4 2023

royjacobson added a reverting change for rGd5dd37ac139a: [Sema] Don't mark deleted special member functions as non-trivial: rG91fefaa62ea5: Revert "[Sema] Don't mark deleted special member functions as non-trivial".
Jan 4 2023, 12:40 PM · Restricted Project, Restricted Project
royjacobson committed rG91fefaa62ea5: Revert "[Sema] Don't mark deleted special member functions as non-trivial" (authored by royjacobson).
Revert "[Sema] Don't mark deleted special member functions as non-trivial"
Jan 4 2023, 12:40 PM · Restricted Project, Restricted Project
royjacobson added a reverting change for D140664: [Sema] Don't mark deleted special member functions as non-trivial: rG91fefaa62ea5: Revert "[Sema] Don't mark deleted special member functions as non-trivial".
Jan 4 2023, 12:40 PM · Restricted Project, Restricted Project
royjacobson committed rGd5dd37ac139a: [Sema] Don't mark deleted special member functions as non-trivial (authored by royjacobson).
[Sema] Don't mark deleted special member functions as non-trivial
Jan 4 2023, 11:27 AM · Restricted Project, Restricted Project
royjacobson closed D140664: [Sema] Don't mark deleted special member functions as non-trivial.
Jan 4 2023, 11:27 AM · Restricted Project, Restricted Project
royjacobson updated the diff for D140664: [Sema] Don't mark deleted special member functions as non-trivial.

format

Jan 4 2023, 11:26 AM · Restricted Project, Restricted Project

Jan 3 2023

royjacobson updated the diff for D140664: [Sema] Don't mark deleted special member functions as non-trivial.

Rebase + remove extra class

Jan 3 2023, 3:11 PM · Restricted Project, Restricted Project
royjacobson added a comment to D140876: [clang][C++20] Non-dependent access checks in requires expression..

Should access checks should happen in the context where concept is written or where it's used? Is there a standard wording around it?

Jan 3 2023, 10:03 AM · Restricted Project, Restricted Project

Dec 25 2022

royjacobson updated the summary of D140664: [Sema] Don't mark deleted special member functions as non-trivial.
Dec 25 2022, 1:55 PM · Restricted Project, Restricted Project
royjacobson requested review of D140664: [Sema] Don't mark deleted special member functions as non-trivial.
Dec 25 2022, 1:54 PM · Restricted Project, Restricted Project

Dec 19 2022

royjacobson added a comment to D137302: [clang-tidy] Add modernize-type-traits check.

This seems to be stuck with no reviewers, is there any way to help here?

Dec 19 2022, 11:11 PM · Restricted Project, Restricted Project

Dec 11 2022

royjacobson added a comment to D139586: [Clang][C++23] Lifetime extension in range-based for loops.

Thanks for picking this up! :)

Dec 11 2022, 2:42 PM · Restricted Project, Restricted Project

Dec 5 2022

royjacobson committed rG7d58c95635cc: [Clang] Don't consider default constructors ineligible if the more constrained… (authored by royjacobson).
[Clang] Don't consider default constructors ineligible if the more constrained…
Dec 5 2022, 1:03 PM · Restricted Project, Restricted Project
royjacobson closed D139038: [Clang] Don't consider default constructors ineligible if the more constrained constructor is a template.
Dec 5 2022, 1:02 PM · Restricted Project, Restricted Project

Dec 4 2022

royjacobson published D139038: [Clang] Don't consider default constructors ineligible if the more constrained constructor is a template for review.
Dec 4 2022, 11:13 AM · Restricted Project, Restricted Project

Nov 29 2022

royjacobson committed rGc64359ea4c8e: [NFC] fix doc inconsistency in cxx_status (authored by royjacobson).
[NFC] fix doc inconsistency in cxx_status
Nov 29 2022, 5:01 AM · Restricted Project, Restricted Project
royjacobson committed rG13c32288354b: [Clang] Implement LWG3823 for __is_aggregate (authored by royjacobson).
[Clang] Implement LWG3823 for __is_aggregate
Nov 29 2022, 4:58 AM · Restricted Project, Restricted Project