User Details
- User Since
- Feb 21 2022, 7:34 AM (57 w, 5 d)
Yesterday
There was some discussion of this last year in this review: https://reviews.llvm.org/D128750
Wed, Mar 29
fix unintended indentation & rebase
Add some ((packed)) tests
Thu, Mar 23
Mon, Mar 20
Sat, Mar 18
Add the test case from the GH issue.
Wed, Mar 15
rebase + release notes.
slimmer codegen test
Tue, Mar 14
Oops, sorry for the bad codegen test and thanks for the comments.
Fix the codegen test, add a standard ref to the comment.
Mon, Mar 13
Add a test case, slightly simpler modeling.
Add more tests, small nit.
Sat, Mar 11
Small cleanup
Handle 0-length unnamed bit fields as well.
Change to a simpler fix.
Fri, Mar 10
Sat, Mar 4
Mar 2 2023
Thanks! Do you need me to land this for you? If so, could you please provide name + email to sign the commit with?
Feb 26 2023
Feb 25 2023
There are no AST [de]serialization tests in this PR, right? Would be nice to add some.
friendly ping
Feb 22 2023
+1 from me, at least as long as we don't define the feature test macro.
Feb 15 2023
It's an interesting discussion, I just want to remind that this change is for triviality rules from P0848 (conditionally trivial member functions) which is only going to ship in Clang 16 anyway.
Feb 14 2023
Feb 13 2023
Address CR comments.
Feb 12 2023
friendly ping :)
Rebase to include the RISC-V changes.
Jan 30 2023
15 -> Clang 15
Jan 29 2023
Jan 28 2023
- Remove redundant paragraph from the intro
- Remove outdated bug fix bullet
Jan 26 2023
Thanks Erich and Emilia!
- Address comments from Erich and Emilia
- Validate that the rst actually builds an html file
- Fix some missing backticks and underscores
Jan 25 2023
Jan 21 2023
fix the test after diag change
Jan 17 2023
Reject non class types, update doc.
Jan 16 2023
rebase on main
Jan 15 2023
Jan 14 2023
Jan 10 2023
It's dr2237, see https://github.com/llvm/llvm-project/issues/55164
Jan 7 2023
Since people run into this very quickly and the Clang workaround is pretty simple, LGTM.
Jan 5 2023
So, I had a quick look at this. Turns out this fix changed the argument passing ABI for those classes on the Sony PS4. This is probably not acceptable :)
Jan 4 2023
format
Jan 3 2023
Rebase + remove extra class
Dec 25 2022
Dec 19 2022
This seems to be stuck with no reviewers, is there any way to help here?
Dec 11 2022
Thanks for picking this up! :)