Page MenuHomePhabricator

jgorbe (Jorge Gorbe Moya)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 3:56 PM (287 w, 3 d)

Recent Activity

Tue, Aug 9

jgorbe committed rGfe01292457fc: Move FormattersMatchCandidate flags to a struct. (authored by jgorbe).
Move FormattersMatchCandidate flags to a struct.
Tue, Aug 9, 10:49 AM · Restricted Project
jgorbe closed D131459: Move FormattersMatchCandidate flags to a struct..
Tue, Aug 9, 10:49 AM · Restricted Project, Restricted Project

Mon, Aug 8

jgorbe requested review of D131459: Move FormattersMatchCandidate flags to a struct..
Mon, Aug 8, 6:09 PM · Restricted Project, Restricted Project

Mon, Jul 25

jgorbe added a comment to D129823: [libc++][ranges] Make range algorithms support proxy iterators.

Some more information about the problem. The stack trace looks like follows. The problem manifests as an ASan out of memory error because the move constructor in varlen_sort.h:59 is getting incorrect data and it's trying to allocate an absurdly big amount of memory.

Mon, Jul 25, 4:42 PM · Restricted Project, Restricted Project

Thu, Jul 21

jgorbe committed rGfa3a2e611d84: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList (authored by jgorbe).
[lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList
Thu, Jul 21, 9:23 AM · Restricted Project
jgorbe closed D130219: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList.
Thu, Jul 21, 9:22 AM · Restricted Project, Restricted Project
jgorbe added inline comments to D130219: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList.
Thu, Jul 21, 9:17 AM · Restricted Project, Restricted Project
jgorbe updated the diff for D130219: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList.

Removed unnecessary parentheses.

Thu, Jul 21, 9:16 AM · Restricted Project, Restricted Project

Wed, Jul 20

jgorbe requested review of D130219: [lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList.
Wed, Jul 20, 7:37 PM · Restricted Project, Restricted Project

Tue, Jul 19

jgorbe accepted D129899: Bazel BUILD file for BOLT.

Looks good to me.

Tue, Jul 19, 3:57 PM · Restricted Project, Restricted Project

Jul 13 2022

jgorbe added a comment to D129478: [IR] Remove support for float binop constant expressions.

After this patch, llvm-dis will crash if passed a bitcode file with metadata that is now non-representable.

Jul 13 2022, 3:40 PM · Restricted Project, Restricted Project

Jul 12 2022

jgorbe committed rGd6071fa52d7a: [bazel] add missing gmock dependency to //clang/unittests:format_tests (authored by jgorbe).
[bazel] add missing gmock dependency to //clang/unittests:format_tests
Jul 12 2022, 6:14 PM · Restricted Project
jgorbe committed rGfcbb4e1fa427: [NFCI] Fix unused variable warning with asserts off in… (authored by jgorbe).
[NFCI] Fix unused variable warning with asserts off in…
Jul 12 2022, 5:41 PM · Restricted Project, Restricted Project
jgorbe committed rGee88c0cf0996: [NFCI] Fix unused variable/function warnings in MacroCallReconstructorTest.cpp… (authored by jgorbe).
[NFCI] Fix unused variable/function warnings in MacroCallReconstructorTest.cpp…
Jul 12 2022, 4:47 PM · Restricted Project, Restricted Project

Jun 27 2022

jgorbe updated subscribers of rGb5d7beeb9792: [X86] combineConcatVectorOps - add support for concatenation of VSELECT/BLENDV….

Yes, it fixes both the original compilation where we noticed the problem
and the reduced test case. Thank you very much for the fix and the quick
response!

Jun 27 2022, 11:40 AM · Restricted Project, Restricted Project

Jun 7 2022

jgorbe added a comment to D126240: [lldb] Tighten the scope of a couple of locks in DataFormatters..

I've been experimenting a little bit and it seems that I can avoid the deadlocks I was seeing by applying only the modification to TypeCategoryMap::Add. This would avoid the problem that @hawkinsw pointed out in my change to FormatManager::GetCategoryForLanguage. However, the following problem could still happen with the change to TypeCategoryMap::Add:

Jun 7 2022, 3:09 PM · Restricted Project, Restricted Project

Jun 3 2022

jgorbe added inline comments to D126240: [lldb] Tighten the scope of a couple of locks in DataFormatters..
Jun 3 2022, 6:44 PM · Restricted Project, Restricted Project

Jun 2 2022

jgorbe added a reviewer for D126240: [lldb] Tighten the scope of a couple of locks in DataFormatters.: teemperor.
Jun 2 2022, 11:56 AM · Restricted Project, Restricted Project

May 23 2022

jgorbe updated the summary of D126240: [lldb] Tighten the scope of a couple of locks in DataFormatters..
May 23 2022, 2:04 PM · Restricted Project, Restricted Project
jgorbe requested review of D126240: [lldb] Tighten the scope of a couple of locks in DataFormatters..
May 23 2022, 1:59 PM · Restricted Project, Restricted Project
jgorbe committed rGf0a61c2ce2af: Remove `friend` classes from TypeCategoryMap (authored by jgorbe).
Remove `friend` classes from TypeCategoryMap
May 23 2022, 11:33 AM · Restricted Project
jgorbe closed D126103: Remove `friend` classes from TypeCategoryMap.
May 23 2022, 11:32 AM · Restricted Project, Restricted Project

May 20 2022

jgorbe requested review of D126103: Remove `friend` classes from TypeCategoryMap.
May 20 2022, 4:15 PM · Restricted Project, Restricted Project

May 19 2022

jgorbe committed rG221b7a45833d: [bazel] Add lib/Basic/BuiltinTargetFeatures.h to clang:basic `hdrs`. (authored by jgorbe).
[bazel] Add lib/Basic/BuiltinTargetFeatures.h to clang:basic `hdrs`.
May 19 2022, 2:20 PM · Restricted Project

May 4 2022

Herald added a project to D92223: [lldb] Add support for looking up static const members: Restricted Project.
May 4 2022, 10:09 AM · Restricted Project, Restricted Project
Herald added a project to D92643: [lldb] Lookup static const members in FindGlobalVariables: Restricted Project.
May 4 2022, 10:09 AM · Restricted Project, Restricted Project

Apr 19 2022

jgorbe abandoned D32573: [Driver] Rename GetNamedOutputPath() to addNamedOutputPath().
Apr 19 2022, 11:56 AM · Restricted Project

Apr 14 2022

jgorbe added inline comments to D123580: [libc++] Use bit field for checking if string is in long or short mode.
Apr 14 2022, 2:01 PM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2022

jgorbe added a comment to D122598: [libcxx] avoid using anonymous struct with base classes (fixes gcc-12).

Thanks for the reply! Yes, I've seen some test failures while trying to update our llvm to (closer to) HEAD, and I bisected them to this commit. These were the affected tests:

Apr 11 2022, 2:43 PM · Restricted Project, Restricted Project

Apr 8 2022

jgorbe added a comment to D122598: [libcxx] avoid using anonymous struct with base classes (fixes gcc-12).

Is it possible that this change just broke the lldb data formatter for string?

Apr 8 2022, 4:51 PM · Restricted Project, Restricted Project
jgorbe committed rGac1235dda60a: Fix bazel rule for __support_fputil_fma when using header modules. (authored by jgorbe).
Fix bazel rule for __support_fputil_fma when using header modules.
Apr 8 2022, 4:29 PM · Restricted Project
jgorbe committed rG7dcd698875cc: Use writable temporary file for test compiler output instead of hardcoded name. (authored by jgorbe).
Use writable temporary file for test compiler output instead of hardcoded name.
Apr 8 2022, 11:00 AM · Restricted Project, Restricted Project
jgorbe committed rG8843245ddd2d: Use portable formatting specified in test. NFCI. (authored by jgorbe).
Use portable formatting specified in test. NFCI.
Apr 8 2022, 10:44 AM · Restricted Project, Restricted Project

Apr 7 2022

jgorbe committed rG627f55b3ae7e: Fix format specifier. NFCI. (authored by jgorbe).
Fix format specifier. NFCI.
Apr 7 2022, 3:27 PM · Restricted Project

Apr 5 2022

jgorbe committed rG54cc7de4bc01: Fix bazel build. (authored by jgorbe).
Fix bazel build.
Apr 5 2022, 3:47 PM · Restricted Project

Mar 31 2022

jgorbe added a reverting change for rG46774df30715: [misexpect] Re-implement MisExpect Diagnostics: rGfc7573f29c79: Revert "[misexpect] Re-implement MisExpect Diagnostics".
Mar 31 2022, 2:56 PM · Restricted Project, Restricted Project, Restricted Project
jgorbe committed rGfc7573f29c79: Revert "[misexpect] Re-implement MisExpect Diagnostics" (authored by jgorbe).
Revert "[misexpect] Re-implement MisExpect Diagnostics"
Mar 31 2022, 2:56 PM · Restricted Project, Restricted Project, Restricted Project
jgorbe added a reverting change for D115907: [misexpect] Re-implement MisExpect Diagnostics: rGfc7573f29c79: Revert "[misexpect] Re-implement MisExpect Diagnostics".
Mar 31 2022, 2:56 PM · Restricted Project, Restricted Project, Restricted Project
jgorbe added a comment to D115907: [misexpect] Re-implement MisExpect Diagnostics.

By the way, the line number for llvm::misexpect::verifyMisExpect in the stack trace above includes the debug printfs I inserted to get the variable values so it won't match the exact line number in the repo. But I think that's the only call to BranchProbability in that function so I hope it's not very confusing anyway. Sorry about that.

Mar 31 2022, 2:53 PM · Restricted Project, Restricted Project, Restricted Project
jgorbe added a comment to D115907: [misexpect] Re-implement MisExpect Diagnostics.

Hi, this patch is causing floating point exceptions for us during profile generation. On a debug build I get this assertion failure (see stack trace below):

clang: /usr/local/google/home/jgorbe/code/llvm/llvm/lib/Support/BranchProbability.cpp:41: llvm::BranchProbability::BranchProbability(uint32_t, uint32_t): Assertion `Denominator > 0 && "Denominator cannot be 0!"' failed.
Mar 31 2022, 2:51 PM · Restricted Project, Restricted Project, Restricted Project

Mar 21 2022

jgorbe added a reverting change for rG596fa2d90044: [clang-format] Handle attributes before case label.: rG5b8115867588: Revert "[clang-format] Handle attributes before case label.".
Mar 21 2022, 2:40 PM · Restricted Project
jgorbe added a reverting change for D121450: [clang-format] Handle attributes before case label.: rG5b8115867588: Revert "[clang-format] Handle attributes before case label.".
Mar 21 2022, 2:40 PM · Restricted Project, Restricted Project
jgorbe committed rG5b8115867588: Revert "[clang-format] Handle attributes before case label." (authored by jgorbe).
Revert "[clang-format] Handle attributes before case label."
Mar 21 2022, 2:39 PM · Restricted Project
jgorbe added a comment to D121450: [clang-format] Handle attributes before case label..

We've observed that this patch introduces infinite loops in some cases. Here's a reduced test case:

export class Foo extends Bar {
  get case(): Case {
    return (
        (this.Bar$has('case')) ? (this.Bar$get('case')) :
                                 (this.case = new Case()));
  }
}
Mar 21 2022, 2:34 PM · Restricted Project, Restricted Project

Mar 4 2022

jgorbe added a reverting change for rG09602d3b47ec: [ELF] Parallelize initializeLocalSymbols: rG449b649fecee: Revert "[ELF] Parallelize initializeLocalSymbols".
Mar 4 2022, 3:02 PM
jgorbe committed rG449b649fecee: Revert "[ELF] Parallelize initializeLocalSymbols" (authored by jgorbe).
Revert "[ELF] Parallelize initializeLocalSymbols"
Mar 4 2022, 3:02 PM · Restricted Project
jgorbe added a reverting change for D119909: [ELF] Parallelize initializeLocalSymbols: rG449b649fecee: Revert "[ELF] Parallelize initializeLocalSymbols".
Mar 4 2022, 3:01 PM · Restricted Project, Restricted Project
Herald added a project to D119909: [ELF] Parallelize initializeLocalSymbols: Restricted Project.

We've found segfaults in lld when linking go binaries after this patch:

Mar 4 2022, 3:00 PM · Restricted Project, Restricted Project

Mar 1 2022

jgorbe committed rG3de4e6b400c7: [bazel] add missing dependency (authored by jgorbe).
[bazel] add missing dependency
Mar 1 2022, 10:44 AM

Feb 28 2022

jgorbe committed rGde9611befeeb: [NFC] Don't pass temporary LangOptions to Lexer (authored by jgorbe).
[NFC] Don't pass temporary LangOptions to Lexer
Feb 28 2022, 12:55 PM

Nov 11 2021

jgorbe added a comment to D51650: Implement target_clones multiversioning.

This breaks some existing code (we have found this issue building the JPEG XL library at github.com/libjxl). This is a very simplified version of the problem:

Nov 11 2021, 5:56 PM · Restricted Project

Nov 10 2021

jgorbe added a comment to D112337: [DebugInfo] Only create concrete DIEs of concrete functions.

I rebuilt clang at this commit with -DLLVM_USE_SANITIZER=Address and it reports a problem nearby. I don't know if this patch is the actual root cause for the crash or if it's triggering an existing bug. Here's the full report in case it can help you debug the issue further:

Nov 10 2021, 1:42 PM · Restricted Project
jgorbe added a comment to D112337: [DebugInfo] Only create concrete DIEs of concrete functions.

Hi, I created the reproducer that akuegel posted above. I have reproduced the crash starting with a clean repo with the steps below. The stack trace is a bit different, but a release build following the same steps will get you a stack trace very similar to what he posted. What I've noticed is that the crash does not always reproduce consistently. I was trying a new release build to double check the steps below, I ran the build command multiple times in a row, and it crashed only sometimes. The crash is a segfault, so it's possible that sometimes an invalid memory access doesn't immediatly crash the program.

Nov 10 2021, 12:12 PM · Restricted Project

Nov 9 2021

jgorbe committed rG770ddf599d28: Fix unused variable warning in release build (authored by jgorbe).
Fix unused variable warning in release build
Nov 9 2021, 7:49 PM
jgorbe added a reverting change for rG00769572025f: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC): rG74add1b6d6d3: Revert "[clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)".
Nov 9 2021, 11:30 AM
jgorbe committed rG74add1b6d6d3: Revert "[clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)" (authored by jgorbe).
Revert "[clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)"
Nov 9 2021, 11:30 AM
jgorbe added a reverting change for D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC): rG74add1b6d6d3: Revert "[clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)".
Nov 9 2021, 11:30 AM · Restricted Project
jgorbe added a comment to D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC).

This change is causing asan errors when running the clang-tidy checks under ASan, most likely because of the reason akuegel pointed out in his comment. I'm going to revert the patch to unbreak HEAD until the problem can be fixed.

Nov 9 2021, 11:20 AM · Restricted Project

Jun 17 2021

jgorbe added a reverting change for rG738abfdbea21: [NFC] Remove checking pointee type for byval/preallocated type: rG9ac7388e3dd5: Revert "[NFC] Remove checking pointee type for byval/preallocated type".
Jun 17 2021, 12:31 PM
jgorbe committed rG9ac7388e3dd5: Revert "[NFC] Remove checking pointee type for byval/preallocated type" (authored by jgorbe).
Revert "[NFC] Remove checking pointee type for byval/preallocated type"
Jun 17 2021, 12:31 PM

May 5 2021

jgorbe added a comment to D99980: [SLP]Improve cost model for the vectorized extractelements..
May 5 2021, 12:16 PM · Restricted Project

May 3 2021

jgorbe added a comment to D99980: [SLP]Improve cost model for the vectorized extractelements..

Hi, we're seeing some build failures after this patch. If you build the following reduced test case with clang -cc1 -emit-obj -O3 -vectorize-slp reduced.cc

May 3 2021, 4:33 PM · Restricted Project

Apr 21 2021

jgorbe added a comment to D100466: clang-format: [JS] merge import lines..

Hi, one of our tests is failing because of this patch and it looks like an actual bug. clang-format now turns this file:

import './a';
import {bar} from './a';

into this:

barimport './a';
Apr 21 2021, 1:28 PM · Restricted Project

Feb 23 2021

jgorbe committed rG979ca1c05f83: Defer the decision whether to use the CU or TU index until after reading the… (authored by jgorbe).
Defer the decision whether to use the CU or TU index until after reading the…
Feb 23 2021, 1:26 PM
jgorbe closed D96194: Defer the decision whether to use the CU or TU index until after reading the unit header..
Feb 23 2021, 1:26 PM · Restricted Project
jgorbe added a comment to D96194: Defer the decision whether to use the CU or TU index until after reading the unit header..

I'm going to go ahead and commit this given that I have just made the last suggested modification and the patch has already been up for review without further comments for a long while (sorry for the late replies, work keeps getting in the way of work).

Feb 23 2021, 1:22 PM · Restricted Project
jgorbe updated the diff for D96194: Defer the decision whether to use the CU or TU index until after reading the unit header..

Changed logic that checked the type of unit to use header.IsTypeUnit() as suggested by reviewer.

Feb 23 2021, 1:20 PM · Restricted Project

Feb 11 2021

jgorbe updated the diff for D96194: Defer the decision whether to use the CU or TU index until after reading the unit header..

Moved index handling to DWARFUnit.cpp as suggested by Pavel.

Feb 11 2021, 2:54 PM · Restricted Project
jgorbe added inline comments to D96194: Defer the decision whether to use the CU or TU index until after reading the unit header..
Feb 11 2021, 10:46 AM · Restricted Project

Feb 5 2021

jgorbe requested review of D96194: Defer the decision whether to use the CU or TU index until after reading the unit header..
Feb 5 2021, 6:19 PM · Restricted Project

Jan 5 2021

jgorbe committed rGa39b19821b6b: Make DWARFUnit use the dwo_id from the DWARF5 CU header. (authored by jgorbe).
Make DWARFUnit use the dwo_id from the DWARF5 CU header.
Jan 5 2021, 4:41 PM
jgorbe closed D93444: Make DWARFUnit use the dwo_id from the DWARF5 CU header..
Jan 5 2021, 4:40 PM · Restricted Project
jgorbe added a comment to D93444: Make DWARFUnit use the dwo_id from the DWARF5 CU header..

Thanks for accepting the patch! (and sorry for the late reply, I was on vacation). I'll commit this now :)

Jan 5 2021, 3:44 PM · Restricted Project

Dec 16 2020

jgorbe requested review of D93444: Make DWARFUnit use the dwo_id from the DWARF5 CU header..
Dec 16 2020, 9:59 PM · Restricted Project

Dec 14 2020

jgorbe added a comment to D91589: [DAGCombiner] Fold (sext (not i1 x)) -> (add (zext i1 x), -1).

Hi! We have bisected a clang crash to this patch. The following reduced test case crashes clang when built with clang -O1 -frounding-math:

Dec 14 2020, 5:23 PM · Restricted Project

Dec 3 2020

jgorbe added a comment to D80706: [DAGCombine] Add hook to allow target specific test for sqrt input.

Found a crash that seems to be caused by this patch. This is a reduced test case:

extern "C"
#define a(b, c, args) d(double, b, , args)
#define d(g, b, c, args) g b args
    a(sqrt, , (double));
int e;
double f = sqrt(e);

Building with clang -target powerpc64le-grtev4-linux-gnu -ffast-math repro.cpp crashes a top-of-tree clang.

Dec 3 2020, 5:56 PM · Restricted Project

Nov 19 2020

jgorbe committed rG314a0d73a844: Fix crash after looking up dwo_id=0 in CU index. (authored by jgorbe).
Fix crash after looking up dwo_id=0 in CU index.
Nov 19 2020, 11:15 AM
jgorbe closed D91670: Fix crash after looking up dwo_id=0 in CU index..
Nov 19 2020, 11:15 AM · Restricted Project
jgorbe added a comment to D91670: Fix crash after looking up dwo_id=0 in CU index..

Thanks everyone for the reviews! I'm committing this now.

Nov 19 2020, 10:53 AM · Restricted Project

Nov 18 2020

jgorbe added a comment to D91670: Fix crash after looking up dwo_id=0 in CU index..

then the check Rows[H].getSignature() != S won't fail

The condition fails. It should return nullptr but returned a Rows entry.

Nov 18 2020, 12:26 PM · Restricted Project
jgorbe added a comment to D91670: Fix crash after looking up dwo_id=0 in CU index..

Updated diff addressing the new round of feedback.

Nov 18 2020, 11:40 AM · Restricted Project
jgorbe updated the diff for D91670: Fix crash after looking up dwo_id=0 in CU index..

Addressed reviewer comments.

Nov 18 2020, 11:38 AM · Restricted Project

Nov 17 2020

jgorbe added a comment to D91670: Fix crash after looking up dwo_id=0 in CU index..

Thanks for the comments!

Nov 17 2020, 6:08 PM · Restricted Project
jgorbe updated the diff for D91670: Fix crash after looking up dwo_id=0 in CU index..

Changed test expectation from "not a stack dump" to the actual output from llvm-symbolizer for the test case.

Nov 17 2020, 6:05 PM · Restricted Project
jgorbe requested review of D91670: Fix crash after looking up dwo_id=0 in CU index..
Nov 17 2020, 5:32 PM · Restricted Project

Aug 18 2020

jgorbe accepted D86163: Default to disabling the libunwind frameheader cache.

LGTM

Aug 18 2020, 1:40 PM · Restricted Project, Restricted Project

Aug 10 2020

jgorbe added a comment to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

This looks good to me FWIW. I'd prefer if someone more experienced with the project would accept it, though.

Aug 10 2020, 2:25 PM · Restricted Project, Restricted Project

Aug 6 2020

jgorbe added inline comments to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Aug 6 2020, 5:52 PM · Restricted Project, Restricted Project

Apr 7 2020

jgorbe committed rG82576d6fecfe: [libunwind] Fix UB in EHHeaderParser::findFDE (authored by jgorbe).
[libunwind] Fix UB in EHHeaderParser::findFDE
Apr 7 2020, 3:17 PM
jgorbe closed D77679: [libunwind] Fix UB in EHHeaderParser::findFDE.
Apr 7 2020, 3:17 PM · Restricted Project, Restricted Project
jgorbe created D77679: [libunwind] Fix UB in EHHeaderParser::findFDE.
Apr 7 2020, 2:10 PM · Restricted Project, Restricted Project

Mar 17 2020

jgorbe added a comment to D75689: [VectorCombine] fold extract-extract-op with different extraction indexes.

Thanks for the note about the flags. We have tried both of them, and any (or both) of them being present causes the regression to go away, so that unblocks us while we work on producing a proper test case.

Mar 17 2020, 4:46 PM · Restricted Project

Mar 16 2020

jgorbe added a comment to D75689: [VectorCombine] fold extract-extract-op with different extraction indexes.

We're seeing some large performance regressions on Eigen (http://eigen.tuxfamily.org/) running on haswell and skylake machines with this patch. Could you please revert it?

Mar 16 2020, 6:03 PM · Restricted Project

Mar 12 2020

jgorbe accepted D75954: Cache uwnind frame headers as they are found..
Mar 12 2020, 9:46 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2020

jgorbe added a comment to D75954: Cache uwnind frame headers as they are found..

Thanks for doing the extra work of adding a test. Just one final nit.

Mar 11 2020, 3:32 PM · Restricted Project, Restricted Project, Restricted Project
jgorbe added a comment to D75954: Cache uwnind frame headers as they are found..

I think it looks good now. My only issue is that it seems to rely on a couple of glibc-specific features: glibc modifying the fields adds and subs in dl_phdr_info when loading/unloading libraries (which this patch uses to know when to invalidate the cache), and dl_iterate_phdr holding a lock (which the patch relies on to avoid races while accessing the cache). What other libc implementations do we support? Do they share these behaviors we rely on here?

Mar 11 2020, 11:19 AM · Restricted Project, Restricted Project, Restricted Project

Mar 10 2020

jgorbe added inline comments to D75954: Cache uwnind frame headers as they are found..
Mar 10 2020, 3:21 PM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2020

jgorbe accepted D75781: Rework findUnwindSectionsByPhdr to be more optimal..

Thanks!

Mar 9 2020, 6:22 PM · Restricted Project
jgorbe added inline comments to D75781: Rework findUnwindSectionsByPhdr to be more optimal..
Mar 9 2020, 5:17 PM · Restricted Project
jgorbe accepted D75692: Lazily save initialState of registers during unwind..

Looks good to me.

Mar 9 2020, 5:17 PM · Restricted Project