Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

jgorbe (Jorge Gorbe Moya)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2017, 3:56 PM (345 w, 4 d)

Recent Activity

Aug 9 2023

jgorbe committed rG6556e2902570: [bazel] Add missing dep after 99475f5b4a45ce623810a967c3bf8b716b4679bd (authored by jgorbe).
[bazel] Add missing dep after 99475f5b4a45ce623810a967c3bf8b716b4679bd
Aug 9 2023, 10:12 AM · Restricted Project

Aug 8 2023

jgorbe committed rGd0ca66ad7531: [bazel] Fix mlir bazel build. (authored by jgorbe).
[bazel] Fix mlir bazel build.
Aug 8 2023, 1:40 PM · Restricted Project

Aug 7 2023

jgorbe committed rGdf3800f0f3c5: [bazel][libc] Add more missing deps for parsing headers standalone. (authored by jgorbe).
[bazel][libc] Add more missing deps for parsing headers standalone.
Aug 7 2023, 3:28 PM · Restricted Project

May 30 2023

jgorbe committed rGa79b0f9f1d82: [lldb] Fix build after Clang API change at rev 769d282d7292 (authored by jgorbe).
[lldb] Fix build after Clang API change at rev 769d282d7292
May 30 2023, 2:22 PM · Restricted Project

May 22 2023

jgorbe committed rGd25fb4e90c96: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails. (authored by jgorbe).
[lldb-vscode] Make tests not wait for 'launch' process events if launch fails.
May 22 2023, 10:59 AM · Restricted Project
jgorbe closed D150470: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails..
May 22 2023, 10:58 AM · Restricted Project, Restricted Project

May 12 2023

jgorbe added a comment to D150470: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails..

See also https://github.com/llvm/llvm-project/issues/62684

May 12 2023, 11:44 AM · Restricted Project, Restricted Project
jgorbe requested review of D150470: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails..
May 12 2023, 11:44 AM · Restricted Project, Restricted Project

May 11 2023

jgorbe committed rG1b11034c672f: [lldb-vscode] Fix handling of RestartRequest arguments. (authored by jgorbe).
[lldb-vscode] Fix handling of RestartRequest arguments.
May 11 2023, 1:13 PM · Restricted Project
jgorbe closed D150392: [lldb-vscode] Fix handling of RestartRequest arguments..
May 11 2023, 1:13 PM · Restricted Project, Restricted Project
jgorbe updated the diff for D150392: [lldb-vscode] Fix handling of RestartRequest arguments..

Added test case.

May 11 2023, 12:43 PM · Restricted Project, Restricted Project
jgorbe requested review of D150392: [lldb-vscode] Fix handling of RestartRequest arguments..
May 11 2023, 12:12 PM · Restricted Project, Restricted Project

May 8 2023

jgorbe added inline comments to D149774: [lldb] Use templates to simplify {Get,Set}PropertyAtIndex (NFC).
May 8 2023, 11:28 AM · Restricted Project, Restricted Project

May 2 2023

jgorbe committed rG2b6c5bb995be: [lldb-vscode] Implement RestartRequest (authored by jgorbe).
[lldb-vscode] Implement RestartRequest
May 2 2023, 2:51 PM · Restricted Project
jgorbe closed D147831: [lldb-vscode] Implement RestartRequest.
May 2 2023, 2:51 PM · Restricted Project, Restricted Project

May 1 2023

jgorbe added inline comments to D147831: [lldb-vscode] Implement RestartRequest.
May 1 2023, 6:11 PM · Restricted Project, Restricted Project
jgorbe added a comment to D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters..

Landed again, with a fix for the test that was failing on Darwin, as https://github.com/llvm/llvm-project/commit/d69518b4e52d527b3f8fcc41e90ae21f1f234555. I'll keep an eye on the build bot.

May 1 2023, 4:21 PM · Restricted Project, Restricted Project
jgorbe added a reverting change for rG45351120105a: Revert "[lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.: rGd69518b4e52d: Re-land "[lldb] Make the libcxx unique_ptr prettyprinter support custom….
May 1 2023, 4:19 PM · Restricted Project
jgorbe committed rGd69518b4e52d: Re-land "[lldb] Make the libcxx unique_ptr prettyprinter support custom… (authored by jgorbe).
Re-land "[lldb] Make the libcxx unique_ptr prettyprinter support custom…
May 1 2023, 4:19 PM · Restricted Project
jgorbe added a reverting change for rGd366da97bd24: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.: rG45351120105a: Revert "[lldb] Make the libcxx unique_ptr prettyprinter support custom deleters..
May 1 2023, 2:15 PM · Restricted Project
jgorbe committed rG45351120105a: Revert "[lldb] Make the libcxx unique_ptr prettyprinter support custom deleters. (authored by jgorbe).
Revert "[lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.
May 1 2023, 2:15 PM · Restricted Project
jgorbe added a reverting change for D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.: rG45351120105a: Revert "[lldb] Make the libcxx unique_ptr prettyprinter support custom deleters..
May 1 2023, 2:14 PM · Restricted Project, Restricted Project
jgorbe added a comment to D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters..

Sure, I'll revert. Thanks for notifying me of the problem.

May 1 2023, 2:12 PM · Restricted Project, Restricted Project
jgorbe committed rGd366da97bd24: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters. (authored by jgorbe).
[lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.
May 1 2023, 1:08 PM · Restricted Project
jgorbe closed D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters..
May 1 2023, 1:08 PM · Restricted Project, Restricted Project
jgorbe updated the diff for D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters..

Addressed review comments:

May 1 2023, 1:05 PM · Restricted Project, Restricted Project

Apr 27 2023

jgorbe added inline comments to D149324: [PGO] Minor instrumentation code cleanup (NFC).
Apr 27 2023, 1:16 PM · Restricted Project, Restricted Project
jgorbe added inline comments to D149324: [PGO] Minor instrumentation code cleanup (NFC).
Apr 27 2023, 12:18 PM · Restricted Project, Restricted Project

Apr 26 2023

jgorbe committed rG15ca90070a46: [bazel][NFC] Run buildifier on libc/libc_build_rules.bzl. (authored by jgorbe).
[bazel][NFC] Run buildifier on libc/libc_build_rules.bzl.
Apr 26 2023, 5:03 PM · Restricted Project

Apr 25 2023

jgorbe committed rG404c63184e12: [bazel] Fix //libc:errno deps after d9f033146b47ceef94c1f041afcd339ef007279e. (authored by jgorbe).
[bazel] Fix //libc:errno deps after d9f033146b47ceef94c1f041afcd339ef007279e.
Apr 25 2023, 4:16 PM · Restricted Project
jgorbe added a comment to D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters..

Ping.

Apr 25 2023, 11:25 AM · Restricted Project, Restricted Project
jgorbe committed rG3778574507db: [bazel] Fix libc target deps after 7090c102731192d5abafb7e0b2b49adb4912efae (authored by jgorbe).
[bazel] Fix libc target deps after 7090c102731192d5abafb7e0b2b49adb4912efae
Apr 25 2023, 10:49 AM · Restricted Project

Apr 21 2023

jgorbe added a comment to D147831: [lldb-vscode] Implement RestartRequest.

Ping.

Apr 21 2023, 10:55 AM · Restricted Project, Restricted Project

Apr 18 2023

jgorbe requested review of D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters..
Apr 18 2023, 2:31 PM · Restricted Project, Restricted Project

Apr 17 2023

jgorbe committed rG3c91d016349a: [lldb] Build libcxx unique_ptr and shared_ptr test programs with -glldb. (authored by jgorbe).
[lldb] Build libcxx unique_ptr and shared_ptr test programs with -glldb.
Apr 17 2023, 5:04 PM · Restricted Project
jgorbe closed D148582: [lldb] Build libcxx unique_ptr and shared_ptr test programs with -glldb..
Apr 17 2023, 5:03 PM · Restricted Project, Restricted Project
jgorbe requested review of D148582: [lldb] Build libcxx unique_ptr and shared_ptr test programs with -glldb..
Apr 17 2023, 4:46 PM · Restricted Project, Restricted Project

Apr 10 2023

jgorbe added inline comments to D147831: [lldb-vscode] Implement RestartRequest.
Apr 10 2023, 6:46 PM · Restricted Project, Restricted Project
jgorbe updated the diff for D147831: [lldb-vscode] Implement RestartRequest.

Addressed review comments.

Apr 10 2023, 6:46 PM · Restricted Project, Restricted Project
jgorbe committed rG53aa22cd9ac4: [lldb-vscode] Fix two issues with runInTerminal test. (authored by jgorbe).
[lldb-vscode] Fix two issues with runInTerminal test.
Apr 10 2023, 6:18 PM · Restricted Project
jgorbe closed D147805: [lldb-vscode] Fix two issues with runInTerminal test..
Apr 10 2023, 6:18 PM · Restricted Project, Restricted Project
jgorbe added inline comments to D147805: [lldb-vscode] Fix two issues with runInTerminal test..
Apr 10 2023, 3:10 PM · Restricted Project, Restricted Project
jgorbe updated the diff for D147805: [lldb-vscode] Fix two issues with runInTerminal test..

Addressed review comments.

Apr 10 2023, 3:09 PM · Restricted Project, Restricted Project

Apr 7 2023

jgorbe requested review of D147831: [lldb-vscode] Implement RestartRequest.
Apr 7 2023, 6:19 PM · Restricted Project, Restricted Project
jgorbe updated the diff for D147805: [lldb-vscode] Fix two issues with runInTerminal test..

Added a --debugger-pid flag that needs to be passed with --launch-target so
that we can restrict PR_SET_PTRACER to the main lldb-vscode instance instead of
using PR_SET_PTRACER_ANY.

Apr 7 2023, 4:16 PM · Restricted Project, Restricted Project
jgorbe requested review of D147805: [lldb-vscode] Fix two issues with runInTerminal test..
Apr 7 2023, 12:48 PM · Restricted Project, Restricted Project

Mar 27 2023

jgorbe accepted D147006: [lldb] Fix value printing for a specific case.

Thanks!

Mar 27 2023, 4:35 PM · Restricted Project, Restricted Project
jgorbe added a comment to D147007: [lldb] Fix double free in python bindings error handling..

LGTM. I think it would be worth adding that information to the top of the file to prevent similar mistakes in the future.

Mar 27 2023, 4:08 PM · Restricted Project, Restricted Project
jgorbe committed rG4a38d3326895: [lldb] Fix double free in python bindings error handling. (authored by jgorbe).
[lldb] Fix double free in python bindings error handling.
Mar 27 2023, 4:08 PM · Restricted Project
jgorbe closed D147007: [lldb] Fix double free in python bindings error handling..
Mar 27 2023, 4:07 PM · Restricted Project, Restricted Project
jgorbe added a comment to D146590: [lldb] Update some uses of Python2 API in typemaps..

Yea, after reading the SWIG documentation, this diagnosis looks correct. If you'd like to fix this feel free to upload a patch and list myself and @mib as reviewers. Otherwise let me know and I can take care of it. Thanks for doing that investigation!

Mar 27 2023, 3:14 PM · Restricted Project, Restricted Project
jgorbe requested review of D147007: [lldb] Fix double free in python bindings error handling..
Mar 27 2023, 3:14 PM · Restricted Project, Restricted Project

Mar 24 2023

jgorbe added a comment to D146783: [lldb] Add ability to hide the root name of a value.

I just noticed a minor aesthetic problem with the input of dwim-print when using data formatters. There are some spacing adjustments in this commit but I'm not sure if they are the actual cause (please let me know if you'd prefer me to file a bug instead).

Mar 24 2023, 4:59 PM · Restricted Project, Restricted Project
jgorbe added a comment to D146590: [lldb] Update some uses of Python2 API in typemaps..

I found the actual reason for the crash I was talking about. This patch only addressed the incorrect OverflowError, but the crash comes from a double free (as @rupprecht mentioned) in the error handling logic. The error path here does both free($1); and SWIG_fail;. The same goes for another error check a few lines below that. In the generated code, the SWIG_fail macro is expanded to goto fail and the fail label also frees the same memory buffer.

Mar 24 2023, 11:44 AM · Restricted Project, Restricted Project
jgorbe accepted D146783: [lldb] Add ability to hide the root name of a value.
Mar 24 2023, 11:31 AM · Restricted Project, Restricted Project
jgorbe added a comment to D146783: [lldb] Add ability to hide the root name of a value.

I've tried building lldb with this patch applied and it fixes the problem I saw. Thanks for the quick fix!

Mar 24 2023, 11:21 AM · Restricted Project, Restricted Project

Mar 23 2023

jgorbe added a comment to D145609: [lldb] Change dwim-print to default to disabled persistent results.

By the way, I just bisected another problem to this commit: I'm seeing in some cases that prettyprinted values with synthetic children don't show child names when using dwim-print. So print used to show:

(lldb) p c
(MyClass) $0 = MyClass object with children: {
  [0] = 0x0000555555556004 "hello"
}
(lldb) p m
(MyMap) $1 = MyMap object with children: {
  ["my_key"] = 0x0000555555556011 "my_value"
}

but now it shows

(lldb) p c
(MyClass)  MyClass object with children: {
  0x0000555555556004 "hello"
}
(lldb) p m
(MyMap)  MyMap object with children: {
  0x0000555555556011 "my_value"
}
Mar 23 2023, 7:58 PM · Restricted Project, Restricted Project
jgorbe added a comment to D145609: [lldb] Change dwim-print to default to disabled persistent results.

Are you using persistent results? If not, how much effort is it to either 1) change the tools/code that examine the output to not look for $\d+, or 2) use a custom print/p alias? Honest question.

Mar 23 2023, 12:08 PM · Restricted Project, Restricted Project
jgorbe added a comment to D145609: [lldb] Change dwim-print to default to disabled persistent results.

What was the rationale for this change? It changes the output format of a common command (given that print is now an alias for dwim-print) and it breaks basically anything that examines debugger output.

Mar 23 2023, 10:01 AM · Restricted Project, Restricted Project

Mar 22 2023

jgorbe committed rG984354fbbe4e: [lldb] Update some uses of Python2 API in typemaps. (authored by jgorbe).
[lldb] Update some uses of Python2 API in typemaps.
Mar 22 2023, 11:30 AM · Restricted Project
jgorbe closed D146590: [lldb] Update some uses of Python2 API in typemaps..
Mar 22 2023, 11:30 AM · Restricted Project, Restricted Project
jgorbe updated the diff for D146590: [lldb] Update some uses of Python2 API in typemaps..

Modified one of the existing test cases for SBData.SetDataFromUInt64Array to add a 2**63 to actually exercise the uint64 range.

Mar 22 2023, 11:26 AM · Restricted Project, Restricted Project

Mar 21 2023

jgorbe requested review of D146590: [lldb] Update some uses of Python2 API in typemaps..
Mar 21 2023, 3:50 PM · Restricted Project, Restricted Project

Mar 17 2023

jgorbe committed rGe07a872c6180: [bazel] add missing dependency to //mlir:SPIRVCommonConversion (authored by jgorbe).
[bazel] add missing dependency to //mlir:SPIRVCommonConversion
Mar 17 2023, 3:02 PM · Restricted Project

Mar 15 2023

jgorbe added a comment to D141222: [libc++] Use __verbose_abort instead of std::abort in __throw_ functions.

There's a comment next to the __libcpp_verbose_abort definition that says

// This function should never be called directly from the code -- it should only be called through
// the _LIBCPP_VERBOSE_ABORT macro.

Does this apply here? For context, we have a libc-free project that uses variant and optional and this change pulls in vfprintf. We'd like to just provide our own _LIBCPP_VERBOSE_ABORT, or build with -D_LIBCPP_HAS_NO_VERBOSE_ABORT_IN_LIBRARY but it doesn't look like we can do that if the code calls __libcpp_verbose_abort directly.

Mar 15 2023, 3:49 PM · Restricted Project, Restricted Project

Mar 14 2023

jgorbe committed rGb5c661c2f4d2: [bazel][libc] Re-add dependency on errno to strtol_test_helper. (authored by jgorbe).
[bazel][libc] Re-add dependency on errno to strtol_test_helper.
Mar 14 2023, 3:52 PM · Restricted Project

Feb 1 2023

jgorbe committed rGdbd02002dd0c: [Hexagon] Use %t for output file in test introduced in 97d51e3fa8e8 (NFCI). (authored by jgorbe).
[Hexagon] Use %t for output file in test introduced in 97d51e3fa8e8 (NFCI).
Feb 1 2023, 10:15 AM · Restricted Project, Restricted Project

Jan 31 2023

jgorbe committed rG5672cbc18a13: Fix bazel build (authored by jgorbe).
Fix bazel build
Jan 31 2023, 5:06 PM · Restricted Project
jgorbe committed rGb09e6b9810dc: Fix two warnings introduced by 69011a2ad0ce "[mlir][Linalg] Make Elementwise op… (authored by jgorbe).
Fix two warnings introduced by 69011a2ad0ce "[mlir][Linalg] Make Elementwise op…
Jan 31 2023, 1:52 PM · Restricted Project, Restricted Project
jgorbe committed rGb27e4f72213e: [lldb] Fix warning about unhandled enum value `WasmExternRef` (NFC). (authored by jgorbe).
[lldb] Fix warning about unhandled enum value `WasmExternRef` (NFC).
Jan 31 2023, 10:31 AM · Restricted Project
jgorbe added inline comments to D122215: [WebAssembly] Initial support for reference type externref in clang.
Jan 31 2023, 9:30 AM · Restricted Project, Restricted Project, Restricted Project

Jan 27 2023

jgorbe added inline comments to D136702: [llvm-cov] Look up object files using debuginfod.
Jan 27 2023, 10:29 AM · Restricted Project, Restricted Project, Restricted Project
jgorbe committed rG805600c7d573: [lldb] Make SBSection::GetSectionData call Section::GetSectionData. (authored by jgorbe).
[lldb] Make SBSection::GetSectionData call Section::GetSectionData.
Jan 27 2023, 10:16 AM · Restricted Project
jgorbe closed D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData..
Jan 27 2023, 10:15 AM · Restricted Project, Restricted Project

Jan 26 2023

jgorbe added inline comments to D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData..
Jan 26 2023, 4:53 PM · Restricted Project, Restricted Project
jgorbe updated the diff for D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData..

Addressing review comment.

Jan 26 2023, 4:52 PM · Restricted Project, Restricted Project
jgorbe requested review of D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData..
Jan 26 2023, 2:30 PM · Restricted Project, Restricted Project

Nov 10 2022

jgorbe committed rG868186cf6cb7: [lldb] Make callback-based formatter matching available from the CLI. (authored by jgorbe).
[lldb] Make callback-based formatter matching available from the CLI.
Nov 10 2022, 10:34 AM · Restricted Project
jgorbe closed D137000: [lldb] Make callback-based formatter matching available from the CLI..
Nov 10 2022, 10:34 AM · Restricted Project, Restricted Project
jgorbe updated the diff for D137000: [lldb] Make callback-based formatter matching available from the CLI..
  • Clarified help text for --recognizer-function as suggested by reviewer. Instead of "Incompatible with --regex (-x)." now it says "Cannot be specified at the same time as --regex (-x)."
  • Rebased on top of current HEAD.
Nov 10 2022, 10:33 AM · Restricted Project, Restricted Project
jgorbe added a comment to D137000: [lldb] Make callback-based formatter matching available from the CLI..

It is a bit odd to follow the what the help summary says is a valid option set and then get an error. But this is a corner case, and since you say explicitly that you can't provide both that's probably good enough. Would you mind changing "Incompatible with" to: "Cannot be specified at the same time as". Incompatible isn't precise - does it mean you can't use them both, or that if you do something weird will happen?

Nov 10 2022, 10:24 AM · Restricted Project, Restricted Project

Nov 3 2022

jgorbe added a comment to D137000: [lldb] Make callback-based formatter matching available from the CLI..

@jingham any comments on https://reviews.llvm.org/D137000#3897162?

Nov 3 2022, 10:36 AM · Restricted Project, Restricted Project

Oct 31 2022

jgorbe updated the diff for D137000: [lldb] Make callback-based formatter matching available from the CLI..
  • Removed -R short option to avoid confusion with regex. Updated doc, test case, and example.
  • Added some logic to make --recognizer-function and --regex mutually exclusive. Specifying both now results in an error being reported to the user.
  • Rebased on top of current HEAD.
Oct 31 2022, 4:56 PM · Restricted Project, Restricted Project
jgorbe added a comment to D137000: [lldb] Make callback-based formatter matching available from the CLI..

I'm looking at the option of using a non-printable character for the short flag, and at the same time make --regex and --recognizer-function mutually exclusive using option groups. One problem I see is that the command help gets pretty confusing. Using a non-printable character as the short option name makes the option completely disappear from the "Command Options Usage" summary part of the help.

Oct 31 2022, 3:58 PM · Restricted Project, Restricted Project
jgorbe added a comment to D137000: [lldb] Make callback-based formatter matching available from the CLI..

You can't provide the --regex option and this matcher at the same time

Oct 31 2022, 11:53 AM · Restricted Project, Restricted Project

Oct 28 2022

jgorbe requested review of D137000: [lldb] Make callback-based formatter matching available from the CLI..
Oct 28 2022, 5:15 PM · Restricted Project, Restricted Project

Oct 27 2022

jgorbe committed rG7d4d25c42a68: [lldb-vscode] Don't call SBValue.GetError after generating a summary. (authored by jgorbe).
[lldb-vscode] Don't call SBValue.GetError after generating a summary.
Oct 27 2022, 3:06 PM · Restricted Project
jgorbe closed D136890: [lldb-vscode] Don't call SBValue.GetError after generating a summary..
Oct 27 2022, 3:06 PM · Restricted Project, Restricted Project
jgorbe added inline comments to D126014: Show error message for optimized variables.
Oct 27 2022, 2:56 PM · Restricted Project, Restricted Project
jgorbe requested review of D136890: [lldb-vscode] Don't call SBValue.GetError after generating a summary..
Oct 27 2022, 2:54 PM · Restricted Project, Restricted Project

Oct 26 2022

jgorbe added a comment to D126014: Show error message for optimized variables.

Hi! I've just debugged an issue that brought me to this commit. I'll start preparing a patch tomorrow (not sure how to test it yet) but since it's a recent-ish change I figured I'd ping the commit thread to give you a heads up.

Oct 26 2022, 5:04 PM · Restricted Project, Restricted Project

Oct 19 2022

jgorbe committed rGd76566417e59: [lldb] Add matching based on Python callbacks for data formatters. (authored by jgorbe).
[lldb] Add matching based on Python callbacks for data formatters.
Oct 19 2022, 12:54 PM · Restricted Project
jgorbe closed D135648: [lldb] Add matching based on Python callbacks for data formatters..
Oct 19 2022, 12:54 PM · Restricted Project, Restricted Project

Oct 14 2022

jgorbe added inline comments to D135648: [lldb] Add matching based on Python callbacks for data formatters..
Oct 14 2022, 6:00 PM · Restricted Project, Restricted Project
jgorbe updated the diff for D135648: [lldb] Add matching based on Python callbacks for data formatters..

Address review comments.

Oct 14 2022, 5:58 PM · Restricted Project, Restricted Project

Oct 11 2022

jgorbe requested review of D135648: [lldb] Add matching based on Python callbacks for data formatters..
Oct 11 2022, 1:05 AM · Restricted Project, Restricted Project

Oct 10 2022

jgorbe committed rGe5fd507f9b6f: [NFCI] More TypeCategoryImpl refactoring. (authored by jgorbe).
[NFCI] More TypeCategoryImpl refactoring.
Oct 10 2022, 3:16 PM · Restricted Project
jgorbe closed D135399: [NFCI] More TypeCategoryImpl refactoring..
Oct 10 2022, 3:15 PM · Restricted Project, Restricted Project

Oct 6 2022

jgorbe requested review of D135399: [NFCI] More TypeCategoryImpl refactoring..
Oct 6 2022, 1:58 PM · Restricted Project, Restricted Project
jgorbe committed rG69c661a65ff8: [lldb] Skip check for conflicting filter/synth when adding a new regex. (authored by jgorbe).
[lldb] Skip check for conflicting filter/synth when adding a new regex.
Oct 6 2022, 1:28 PM · Restricted Project