Fixed some issues pointed out in review comments:

• call to getBaseElementType before checking type validity.
• when the type is incomplete, mark not only the lambda closure type as invalid but also the field

I think this change is breaking one of our builds. The attached reduced test case fails with the current trunk revision if built with "clang -x c -O2 -mavx -c crash.ii".

Can't comment much on the patch itself (I'm still not very familiar with the codebase, I'll leave that to the other reviewers), but thanks a lot for responding so quickly! :)

Removed unneeded branch.

Also clear the 'requires import' flag when the TypoCorrection has no decls at all.

Ping?

Clarify that we only skip saving IR for multiarch Mach-O universal builds, not other multi-arch builds like CUDA.

Only generate extra .ll files when not targeting multiple archs. Updated related tests.

Added -mtriple parameter to the RUN line. I messed up when regenerating the test with the script, reverted it, and lost the edit I had done before. Thanks for noticing.

• Regenerated the test with update_llc_test_checks.py
• Specified target triple in the RUN: line with -mtriple
• Removed entry label added in the previous version of the patch.

Some more answers to inline comments. Thanks!

• Added explicit target triple to test/CodeGen/X86/2004-02-14-InefficientStackPointer.ll
• Added regex to catch possible constant displacements from %esp in test/CodeGen/X86/2004-02-13-FrameReturnAddress.ll
• Added missing entry label.

Some responses to @chandlerc 's previous comments.

Made some changes suggested by chandlerc:

Noted, thanks!

Forgot to add llvm-commits, commenting so a message gets posted there. Sorry!

@dlj Can you please commit this patch? I don't have commit access.