User Details
- User Since
- Feb 9 2017, 3:56 PM (101 w, 6 d)
Mon, Jan 14
Wed, Jan 9
I reverted this patch on r350787
Tue, Jan 8
I think this change just broke the clang build:
Mon, Jan 7
Nov 21 2018
Folded the two test cases (capturing an invalid type and capturing an invalid array type) into a single file.
Nov 20 2018
Added a test for the "capturing an array of incomplete type" case. See also responses to inline comments below.
Nov 14 2018
Fixed some issues pointed out in review comments:
- call to getBaseElementType before checking type validity.
- when the type is incomplete, mark not only the lambda closure type as invalid but also the field
Nov 8 2018
Nov 7 2018
Sep 21 2018
Sep 19 2018
Aug 17 2018
I think this change is breaking one of our builds. The attached reduced test case fails with the current trunk revision if built with "clang -x c -O2 -mavx -c crash.ii".
Apr 26 2018
Can't comment much on the patch itself (I'm still not very familiar with the codebase, I'll leave that to the other reviewers), but thanks a lot for responding so quickly! :)
Jun 5 2017
Removed unneeded branch.
Jun 2 2017
Also clear the 'requires import' flag when the TypoCorrection has no decls at all.
Ping?
Jun 1 2017
May 31 2017
Clarify that we only skip saving IR for multiarch Mach-O universal builds, not other multi-arch builds like CUDA.
Only generate extra .ll files when not targeting multiple archs. Updated related tests.
May 11 2017
Apr 26 2017
Mar 16 2017
Added -mtriple parameter to the RUN line. I messed up when regenerating the test with the script, reverted it, and lost the edit I had done before. Thanks for noticing.
- Regenerated the test with update_llc_test_checks.py
- Specified target triple in the RUN: line with -mtriple
- Removed entry label added in the previous version of the patch.
Mar 14 2017
Feb 23 2017
Feb 16 2017
Feb 13 2017
Some more answers to inline comments. Thanks!
- Added explicit target triple to test/CodeGen/X86/2004-02-14-InefficientStackPointer.ll
- Added regex to catch possible constant displacements from %esp in test/CodeGen/X86/2004-02-13-FrameReturnAddress.ll
- Added missing entry label.
Feb 10 2017
Some responses to @chandlerc 's previous comments.
Made some changes suggested by chandlerc:
Feb 9 2017
Noted, thanks!
Forgot to add llvm-commits, commenting so a message gets posted there. Sorry!
@dlj Can you please commit this patch? I don't have commit access.