I considered assigning it to a std::string, but GetCString() can return a null pointer and I'm not sure you can construct a std::string directly from that.

Thu, Mar 14, 6:43 PM · Restricted Project

jgorbe created D59400: [lldb-vscode] Fix dangling pointer in request_evaluate..

Thu, Mar 14, 6:05 PM · Restricted Project

Wed, Mar 13

jgorbe committed rGd383a342aaa0: [lldb-vscode] Don't try to launch an invalid program. (authored by jgorbe).

[lldb-vscode] Don't try to launch an invalid program.

Wed, Mar 13, 4:50 PM

jgorbe committed rL356110: [lldb-vscode] Don't try to launch an invalid program..

[lldb-vscode] Don't try to launch an invalid program.

Wed, Mar 13, 4:50 PM

jgorbe committed rLLDB356110: [lldb-vscode] Don't try to launch an invalid program..

[lldb-vscode] Don't try to launch an invalid program.

Wed, Mar 13, 4:49 PM

jgorbe closed D59340: [lldb-vscode] Don't try to launch an invalid program..

Wed, Mar 13, 4:49 PM · Restricted Project

jgorbe created D59340: [lldb-vscode] Don't try to launch an invalid program..

Wed, Mar 13, 4:21 PM · Restricted Project

Feb 15 2019

jgorbe committed rGda0487f3f26f: Disable stop-hook-threads.test on Linux (authored by jgorbe).

Disable stop-hook-threads.test on Linux

Feb 15 2019, 9:54 AM

jgorbe committed rLLDB354149: Disable stop-hook-threads.test on Linux.

Disable stop-hook-threads.test on Linux

Feb 15 2019, 9:53 AM

jgorbe committed rL354149: Disable stop-hook-threads.test on Linux.

Disable stop-hook-threads.test on Linux

Feb 15 2019, 9:53 AM

jgorbe closed D58257: Disable ExecControl/StopHook/stop-hook-threads.test on Linux.

Feb 15 2019, 9:53 AM · Restricted Project

Feb 14 2019

jgorbe created D58257: Disable ExecControl/StopHook/stop-hook-threads.test on Linux.

Feb 14 2019, 3:24 PM · Restricted Project

jgorbe abandoned D33108: Generate extra .ll files before/after optimization when using -save-temps..

Feb 14 2019, 11:29 AM

Jan 14 2019

jgorbe accepted D56693: Remove unused variable somehow left in rL351132.

Jan 14 2019, 5:59 PM

Jan 9 2019

jgorbe committed rL350790: Revert "Fix go bindings for r350647: missed a function rename".

Revert "Fix go bindings for r350647: missed a function rename"

Jan 9 2019, 5:56 PM

jgorbe added a comment to D55763: [Sparc] Add Sparc V8 support.

I reverted this patch on r350787

Jan 9 2019, 5:13 PM

jgorbe committed rUNW350787: Revert "[Sparc] Add Sparc V8 support".

Revert "[Sparc] Add Sparc V8 support"

Jan 9 2019, 5:13 PM

jgorbe committed rL350787: Revert "[Sparc] Add Sparc V8 support".

Revert "[Sparc] Add Sparc V8 support"

Jan 9 2019, 5:12 PM

Jan 8 2019

jgorbe committed rL350657: Fix go bindings for r350647: missed a function rename.

Fix go bindings for r350647: missed a function rename

Jan 8 2019, 1:49 PM

jgorbe closed D56452: Fix go bindings for r350647: missed a function rename.

Jan 8 2019, 1:49 PM

jgorbe created D56452: Fix go bindings for r350647: missed a function rename.

Jan 8 2019, 1:30 PM

jgorbe added a comment to rL350647: [NewPM] Port tsan.

I think this change just broke the clang build:

Jan 8 2019, 11:57 AM

Jan 7 2019

jgorbe committed rLLDB350570: [lldb] Fix -Wstring-plus-int warning in POSIX-DYLD/AuxVector.cpp.

[lldb] Fix -Wstring-plus-int warning in POSIX-DYLD/AuxVector.cpp

Jan 7 2019, 1:09 PM

jgorbe committed rL350570: [lldb] Fix -Wstring-plus-int warning in POSIX-DYLD/AuxVector.cpp.

[lldb] Fix -Wstring-plus-int warning in POSIX-DYLD/AuxVector.cpp

Jan 7 2019, 1:09 PM

Nov 21 2018

jgorbe closed D54550: Mark lambda decl as invalid if a captured variable has an invalid type..

Nov 21 2018, 10:05 AM

jgorbe added an edge to rL347402: Mark lambda decl as invalid if a captured variable has an invalid type.: D54550: Mark lambda decl as invalid if a captured variable has an invalid type..

Nov 21 2018, 10:03 AM

jgorbe added 1 commit(s) for D54550: Mark lambda decl as invalid if a captured variable has an invalid type.: rL347402: Mark lambda decl as invalid if a captured variable has an invalid type..

Nov 21 2018, 10:03 AM

jgorbe committed rL347402: Mark lambda decl as invalid if a captured variable has an invalid type..

Mark lambda decl as invalid if a captured variable has an invalid type.

Nov 21 2018, 9:52 AM

jgorbe committed rC347402: Mark lambda decl as invalid if a captured variable has an invalid type..

Mark lambda decl as invalid if a captured variable has an invalid type.

Nov 21 2018, 9:52 AM

jgorbe updated the diff for D54550: Mark lambda decl as invalid if a captured variable has an invalid type..

Folded the two test cases (capturing an invalid type and capturing an invalid array type) into a single file.

Nov 21 2018, 9:34 AM

Nov 20 2018

jgorbe added a comment to D54550: Mark lambda decl as invalid if a captured variable has an invalid type..

Added a test for the "capturing an array of incomplete type" case. See also responses to inline comments below.

Nov 20 2018, 4:16 PM

jgorbe updated the diff for D54550: Mark lambda decl as invalid if a captured variable has an invalid type..

Nov 20 2018, 4:14 PM

Nov 14 2018

jgorbe added inline comments to D54550: Mark lambda decl as invalid if a captured variable has an invalid type..

Nov 14 2018, 4:27 PM

jgorbe updated the diff for D54550: Mark lambda decl as invalid if a captured variable has an invalid type..

Fixed some issues pointed out in review comments:

call to getBaseElementType before checking type validity.
when the type is incomplete, mark not only the lambda closure type as invalid but also the field

Nov 14 2018, 4:25 PM

jgorbe created D54550: Mark lambda decl as invalid if a captured variable has an invalid type..

Nov 14 2018, 3:26 PM

Nov 8 2018

jgorbe committed rLLDB346441: [lldb] Silence unhandled enums warning..

[lldb] Silence unhandled enums warning.

Nov 8 2018, 2:07 PM

jgorbe committed rL346441: [lldb] Silence unhandled enums warning..

[lldb] Silence unhandled enums warning.

Nov 8 2018, 2:07 PM

jgorbe committed rLLDB346435: [lldb] Fix initialization order warnings..

[lldb] Fix initialization order warnings.

Nov 8 2018, 12:01 PM

jgorbe committed rL346435: [lldb] Fix initialization order warnings..

[lldb] Fix initialization order warnings.

Nov 8 2018, 12:01 PM

Nov 7 2018

jgorbe committed rL346365: Add parentheses to silence warning..

Add parentheses to silence warning.

Nov 7 2018, 2:32 PM

Sep 21 2018

jgorbe committed rL342771: Test commit. Removed a blank line..

Test commit. Removed a blank line.

Sep 21 2018, 1:46 PM

Sep 19 2018

jgorbe created D52280: Don't trim non-alphanumeric characters in 'file not found' errors for include directives..

Sep 19 2018, 2:34 PM

Aug 17 2018

jgorbe added a comment to D46179: [X86] Lowering addus/subus intrinsics to native IR (LLVM part).

I think this change is breaking one of our builds. The attached reduced test case fails with the current trunk revision if built with "clang -x c -O2 -mavx -c crash.ii".

Aug 17 2018, 3:58 AM

Apr 26 2018

jgorbe added a comment to D46135: [Driver, CodeGen] add options to enable/disable an FP cast optimization.

Can't comment much on the patch itself (I'm still not very familiar with the codebase, I'll leave that to the other reviewers), but thanks a lot for responding so quickly! :)

Apr 26 2018, 1:08 PM

Jun 5 2017

jgorbe added inline comments to D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls..

Jun 5 2017, 11:56 AM

jgorbe updated the diff for D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls..

Removed unneeded branch.

Jun 5 2017, 11:54 AM

Jun 2 2017

jgorbe added inline comments to D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls..

Jun 2 2017, 6:07 PM

jgorbe updated the diff for D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls..

Also clear the 'requires import' flag when the TypoCorrection has no decls at all.

Jun 2 2017, 6:03 PM

jgorbe added a comment to D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls..

Ping?

Jun 2 2017, 5:04 PM

Jun 1 2017

jgorbe added inline comments to D33108: Generate extra .ll files before/after optimization when using -save-temps..

Jun 1 2017, 5:00 PM

May 31 2017

jgorbe added inline comments to D33108: Generate extra .ll files before/after optimization when using -save-temps..

May 31 2017, 6:15 PM

jgorbe updated the diff for D33108: Generate extra .ll files before/after optimization when using -save-temps..

Clarify that we only skip saving IR for multiarch Mach-O universal builds, not other multi-arch builds like CUDA.

May 31 2017, 6:15 PM

jgorbe added a reviewer for D33108: Generate extra .ll files before/after optimization when using -save-temps.: chandlerc.

May 31 2017, 5:12 PM

jgorbe updated the diff for D33108: Generate extra .ll files before/after optimization when using -save-temps..

Only generate extra .ll files when not targeting multiple archs. Updated related tests.

May 31 2017, 5:09 PM

May 11 2017

jgorbe updated the summary of D33108: Generate extra .ll files before/after optimization when using -save-temps..

May 11 2017, 4:00 PM

jgorbe created D33108: Generate extra .ll files before/after optimization when using -save-temps..

May 11 2017, 3:49 PM

Apr 26 2017

jgorbe created D32573: [Driver] Rename GetNamedOutputPath() to addNamedOutputPath().

Apr 26 2017, 5:19 PM

Mar 16 2017

jgorbe updated the diff for D30317: [X86] Clean up test/CodeGen/X86/2006-03-01-InstrSchedBug.ll.

Added -mtriple parameter to the RUN line. I messed up when regenerating the test with the script, reverted it, and lost the edit I had done before. Thanks for noticing.

Mar 16 2017, 4:30 PM

jgorbe updated the diff for D30317: [X86] Clean up test/CodeGen/X86/2006-03-01-InstrSchedBug.ll.

Regenerated the test with update_llc_test_checks.py
Specified target triple in the RUN: line with -mtriple
Removed entry label added in the previous version of the patch.

Mar 16 2017, 4:01 PM

Mar 14 2017

jgorbe created D30963: Fix crash when an 'import a module' TypoCorrection has its CorrectionDecls replaced by visible decls..

Mar 14 2017, 6:00 PM

Feb 23 2017

jgorbe created D30320: [X86] Clean up test/CodeGen/X86/2006-03-02-InstrSchedBug.ll.

Feb 23 2017, 6:47 PM

jgorbe created D30317: [X86] Clean up test/CodeGen/X86/2006-03-01-InstrSchedBug.ll.

Feb 23 2017, 5:22 PM

Feb 16 2017

jgorbe added inline comments to D29807: FileCheck-ize some tests in test/CodeGen/X86/.

Feb 16 2017, 4:19 PM

Feb 13 2017

jgorbe added a comment to D29807: FileCheck-ize some tests in test/CodeGen/X86/.

Some more answers to inline comments. Thanks!

Feb 13 2017, 11:59 AM

jgorbe updated the diff for D29807: FileCheck-ize some tests in test/CodeGen/X86/.

Added explicit target triple to test/CodeGen/X86/2004-02-14-InefficientStackPointer.ll
Added regex to catch possible constant displacements from %esp in test/CodeGen/X86/2004-02-13-FrameReturnAddress.ll
Added missing entry label.

Feb 13 2017, 11:59 AM