Page MenuHomePhabricator

mibintc (Melanie Blower)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 14 2016, 12:37 PM (200 w, 6 d)

Recent Activity

Thu, Sep 17

mibintc abandoned D78305: [NFC] Rename Sema.FPFeatures to CurFPFeatures and accessor to getCurFPFeatures.

not needed

Thu, Sep 17, 7:27 AM · Restricted Project
mibintc accepted D87812: [FPEnv] Use typed accessors in FPOptions.

LGTM - thanks

Thu, Sep 17, 7:21 AM · Restricted Project, Restricted Project

Wed, Sep 16

mibintc added inline comments to D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress.
Wed, Sep 16, 2:29 PM · Restricted Project
mibintc updated the diff for D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress.

I pulled out the isStrictFP boolean from EvalInfo and used the FPOptions when visiting floating point BinaryOperator, CastExpr and builtin CallExpr. I created the diagnostic note explaining why constant evaluation failed. Not certain about the language rules C vs C++.

Wed, Sep 16, 2:27 PM · Restricted Project

Mon, Sep 14

mibintc updated the diff for D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress.

This update uses context information from Expr->getFPFeaturesInEffect() to disable fp constant folding in ExprConstant.cpp

Mon, Sep 14, 4:53 PM · Restricted Project
mibintc added a comment to D69272: Enable '#pragma STDC FENV_ACCESS' in frontend.

I am working on a task to ensure that clang is doing floating point constant folding correctly.

Could you please share your plans on it? I recently also started implementing constant folding in ExprConstant.cpp. I have not made anything substantial yet, so I can easily switch to another task. Do you have any estimation when you could prepare the first version of the patch?

I've been given a vague assignment, something along the lines "investigate floating point constant folding and make sure that the semantics are correct. " In the Intel ICL compiler, there were some circumstances of the semantics not being correct. I saw Richard's comments in this review, and Intel also needs FENV_ACCESS implemented so I thought I'd start here. I'm not a floating point expert, but of course some of my colleagues at Intel are! I am pretty slow but it's my area of focus.

But sometimes, if the floating point semantics are set to 'strict', even tho' folding has occurred successfully in ExprConstant.cpp, when i look at emit-llvm, there is arithmetic emitted for the floating point expression;

I used a bit different approach, may be it could be useful for you too. An initializer for global variable must be a constant, so things like const xxx = 1.0 + 2.0 are evaluated. No llvm arithmetic occurs in the resulting ll file. Using pragma STDC FENV_ROUND floating point environment may be set to non-default state, which constant evaluator must use.

When I implemented clang #pragma float_control, I noticed that initialization expressions in classes were not subject to the pragma's that are active in the source file. Those expressions are pulled out and processed differently than the function bodies. I'll upload later today a patch that uses Expr->getFPFeaturesInEffect() to inhibit constant folding in ExprConstant.cpp.

In D69272#2268387, @kpn wrote:

Say, in D80952 I added support for disabling strictfp support when a target doesn't support it. But it only applies to command line arguments.

Is there any chance at all that relevant pragmas can also be disabled with the warning in the same cases?

This is definitely a good idea.

I'll look into it, thank you

Mon, Sep 14, 11:03 AM · Restricted Project

Fri, Sep 11

mibintc added a comment to D69272: Enable '#pragma STDC FENV_ACCESS' in frontend.

Hello, I rebased this and made a few changes here, https://reviews.llvm.org/D87528 ; I added a question about floating point constant folding in that review, I'm going to duplicate it here,

Fri, Sep 11, 10:12 AM · Restricted Project
mibintc requested review of D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress.
Fri, Sep 11, 10:09 AM · Restricted Project

Wed, Sep 2

mibintc added a comment to D87049: Exploratory patch - capture DebugInfo for constexpr variables used within lambda.

I think it'd be helpful to discuss what the DWARF does and should look like in this case (I wonder if, maybe, the better solution is in the DWARF consumer - to do name lookup out through the lambda) - could you provide some summarized llvm-dwarfdump output comparisons between Clang (with/without the patch applied) and GCC's output?

Wed, Sep 2, 2:11 PM · Restricted Project
mibintc requested review of D87049: Exploratory patch - capture DebugInfo for constexpr variables used within lambda.
Wed, Sep 2, 11:54 AM · Restricted Project

Jun 27 2020

mibintc committed rGf4aaed3bf16b: Reland D81869 "Modify FPFeatures to use delta not absolute settings" This… (authored by mibintc).
Reland D81869 "Modify FPFeatures to use delta not absolute settings" This…
Jun 27 2020, 1:35 AM
mibintc added a reverting change for rGdefd43a5b393: Revert "Revert "Revert "Modify FPFeatures to use delta not absolute settings""": rGf4aaed3bf16b: Reland D81869 "Modify FPFeatures to use delta not absolute settings" This….
Jun 27 2020, 1:35 AM

Jun 26 2020

mibintc committed rG467ba4c92f5b: More corrections to documented spelling of ffinite-math to ffinite-math-only (authored by mibintc).
More corrections to documented spelling of ffinite-math to ffinite-math-only
Jun 26 2020, 1:42 PM
mibintc committed rG7cc5307c73ca: Correct documented spelling of ffinite-math to ffinite-math-only (authored by mibintc).
Correct documented spelling of ffinite-math to ffinite-math-only
Jun 26 2020, 1:09 PM
mibintc committed rGdefd43a5b393: Revert "Revert "Revert "Modify FPFeatures to use delta not absolute settings""" (authored by mibintc).
Revert "Revert "Revert "Modify FPFeatures to use delta not absolute settings"""
Jun 26 2020, 9:18 AM
mibintc added a reverting change for rG9518763d710b: Revert "Revert "Modify FPFeatures to use delta not absolute settings"": rGdefd43a5b393: Revert "Revert "Revert "Modify FPFeatures to use delta not absolute settings""".
Jun 26 2020, 9:18 AM
mibintc committed rG9518763d710b: Revert "Revert "Modify FPFeatures to use delta not absolute settings"" (authored by mibintc).
Revert "Revert "Modify FPFeatures to use delta not absolute settings""
Jun 26 2020, 8:12 AM
mibintc added a reverting change for rGb55d723ed610: Revert "Modify FPFeatures to use delta not absolute settings": rG9518763d710b: Revert "Revert "Modify FPFeatures to use delta not absolute settings"".
Jun 26 2020, 8:12 AM
mibintc closed D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems.
Jun 26 2020, 8:11 AM · Restricted Project, Restricted Project
mibintc committed rGb55d723ed610: Revert "Modify FPFeatures to use delta not absolute settings" (authored by mibintc).
Revert "Modify FPFeatures to use delta not absolute settings"
Jun 26 2020, 8:11 AM
mibintc added a reverting change for rG3a748cbf86ce: Modify FPFeatures to use delta not absolute settings: rGb55d723ed610: Revert "Modify FPFeatures to use delta not absolute settings".
Jun 26 2020, 8:11 AM
mibintc committed rG3a748cbf86ce: Modify FPFeatures to use delta not absolute settings (authored by mibintc).
Modify FPFeatures to use delta not absolute settings
Jun 26 2020, 8:11 AM
mibintc updated the diff for D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems.

with updates from @yaxunl , i'm planning to push this

Jun 26 2020, 7:37 AM · Restricted Project, Restricted Project
mibintc added a comment to D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems.

Would you please add the following lit test

If you change FastMath, FiniteMathOnly and UnsafeFPMath to COMPATIBLE_LANGOPT, the test should pass.

Jun 26 2020, 6:30 AM · Restricted Project, Restricted Project

Jun 24 2020

mibintc updated the diff for D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems.

I decided that I shouldn't make float options that define a macro, like -ffast-math, as BENIGN_LANGOPT, I made ffp-contract= , fp-exception-behavior and rounding-mode BENIGN, I modified the pch test case to test that the benign command line floating options on the pch-create don't affect compilations that use the pch file.

Jun 24 2020, 1:01 PM · Restricted Project, Restricted Project

Jun 23 2020

mibintc added a comment to D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems.

I need to make another revision that makes a couple more of the fp options, like ffp-contract, "benign" and add a test case that demonstrates fp options don't carry over from pch-create to pch-use

Jun 23 2020, 2:31 PM · Restricted Project, Restricted Project
mibintc updated the diff for D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems.

The difference between this patch and the earlier one today is that I modified the new test case

Jun 23 2020, 1:26 PM · Restricted Project, Restricted Project
mibintc updated the summary of D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems.
Jun 23 2020, 1:26 PM · Restricted Project, Restricted Project
mibintc updated the diff for D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems.

I responded to review from @riccibruno and @rjmccall : I put the dump() routines into the .cpp file and changed them to use the x-macros. I moved CXXOperatorCall.FPOptionsOverride from the Expr bits into the OperatorCall itself. I added the operator call test case suggested by John. I must be mistaken about the bug, the operator call addition does account for the FPFeatures in both the unmodified compiler and the patched compiler.

Jun 23 2020, 12:54 PM · Restricted Project, Restricted Project

Jun 22 2020

mibintc updated subscribers of D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems.

@rjmccall I added some inline questions and comments for you. Thanks a lot for your review.

Jun 22 2020, 2:31 PM · Restricted Project, Restricted Project
mibintc updated the diff for D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems.

This revision rewrites FPOptionsOverride like @rjmccall suggests. There are a couple problems, i'll add inline comments in the trouble areas

Jun 22 2020, 1:59 PM · Restricted Project, Restricted Project

Jun 16 2020

mibintc updated the diff for D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems.

This version passes all the lit tests, i believe it's functional tho' maybe not elegant.
I still need to add a test case that PCH behaves as desired, and that the floating point command line options from PCH create do not clobber command line options from compilations that use a pch

Jun 16 2020, 2:18 PM · Restricted Project, Restricted Project
mibintc updated subscribers of D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems.
Jun 16 2020, 6:37 AM · Restricted Project, Restricted Project

Jun 15 2020

mibintc added a comment to D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems.

@rjmccall You suggested that the FPFeatures could be delta instead of absolute settings, I think this is approximately what you mean. This is a rough patch employing that idea, would welcome your early comments. There are 2 clang tests that are failing with this patch, I need to dig into those.

Jun 15 2020, 1:14 PM · Restricted Project, Restricted Project
mibintc created D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems.
Jun 15 2020, 1:14 PM · Restricted Project, Restricted Project

Jun 1 2020

mibintc added a comment to D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.

I documented the issue reported by @yaxunl here, https://bugs.llvm.org/show_bug.cgi?id=46166, and take ownership of the bug. Thanks for the report.

Jun 1 2020, 2:05 PM · Restricted Project, Restricted Project

May 20 2020

mibintc added a comment to D80315: Fix CC1 command line options mapping into fast-math flags..

Thanks for cleaning this up!

May 20 2020, 2:18 PM · Restricted Project
mibintc committed rG827be690dce1: [clang] FastMathFlags.allowContract should be initialized only from FPFeatures. (authored by mibintc).
[clang] FastMathFlags.allowContract should be initialized only from FPFeatures.
May 20 2020, 6:30 AM
mibintc closed D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement.
May 20 2020, 6:30 AM · Restricted Project

May 15 2020

mibintc updated subscribers of D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement.
May 15 2020, 8:06 AM · Restricted Project
mibintc updated subscribers of D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement.
May 15 2020, 8:06 AM · Restricted Project
mibintc updated the diff for D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement.

This is the same as the previous patch, except I removed the fix for pragma push-pop that John said should be committed separately

May 15 2020, 8:06 AM · Restricted Project

May 14 2020

mibintc added a comment to D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement.

reply about the incorrect setting of 'fast' during OpenCL compilation with option -cl-fast-relaxed-math

May 14 2020, 11:23 AM · Restricted Project
mibintc added inline comments to D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement.
May 14 2020, 7:32 AM · Restricted Project
mibintc committed rG7b8e3065606c: [clang] Fix bug in #pragma float_control(push/pop) (authored by mibintc).
[clang] Fix bug in #pragma float_control(push/pop)
May 14 2020, 6:26 AM

May 13 2020

mibintc added inline comments to D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement.
May 13 2020, 2:42 PM · Restricted Project
mibintc added inline comments to D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.
May 13 2020, 2:09 PM · Restricted Project, Restricted Project
mibintc added a comment to D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement.

added some inline explanation

May 13 2020, 1:03 PM · Restricted Project
mibintc created D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement.
May 13 2020, 1:03 PM · Restricted Project
mibintc added inline comments to D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.
May 13 2020, 8:37 AM · Restricted Project, Restricted Project

May 12 2020

mibintc added inline comments to D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.
May 12 2020, 11:16 AM · Restricted Project, Restricted Project
mibintc committed rG7f2db9935009: [PATCH] #pragma float_control should be permitted in namespace scope. (authored by mibintc).
[PATCH] #pragma float_control should be permitted in namespace scope.
May 12 2020, 6:25 AM
mibintc closed D79631: #pragma float_control should be permitted at namespace scope.
May 12 2020, 6:25 AM · Restricted Project

May 11 2020

mibintc committed rG01dc694ccb86: FP LangOpts should not be dependent on CGOpt This bug was observed by Apple… (authored by mibintc).
FP LangOpts should not be dependent on CGOpt This bug was observed by Apple…
May 11 2020, 12:56 PM
mibintc closed D79735: FP LangOpts should not be dependent on CGOpts.
May 11 2020, 12:56 PM · Restricted Project
mibintc added a comment to D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.

@ab @rjmccall @mibintc Posted D79730 for consideration.
@mibintc can you produce a version of _this_ diff that works with D79730 applied. Currently the following fail, as they do on Apple Master:

May 11 2020, 12:56 PM · Restricted Project, Restricted Project
mibintc created D79735: FP LangOpts should not be dependent on CGOpts.
May 11 2020, 12:22 PM · Restricted Project
mibintc added inline comments to D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.
May 11 2020, 10:45 AM · Restricted Project, Restricted Project
mibintc added a comment to D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.

@rjmccall Uncertain how to proceed, can you recommend? If I recall correctly, I added the lines in CompilerOptions because there were many failing lit tests, i could have fixed the lit fails by adding the lang options to the lit tests. (of course that change could have other repercussions)

May 11 2020, 6:24 AM · Restricted Project, Restricted Project
mibintc added a comment to D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.

Some inline replies/comments to @rjmccall and @plotfi

May 11 2020, 5:52 AM · Restricted Project, Restricted Project
mibintc added a comment to D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.
May 11 2020, 5:19 AM · Restricted Project, Restricted Project

May 9 2020

mibintc updated the diff for D79631: #pragma float_control should be permitted at namespace scope.

I corrected the assertion error by propagating usesFPIntrin flag from the template function to the template instantiation and added a test case. Ready for review.

May 9 2020, 9:01 AM · Restricted Project

May 8 2020

mibintc added a comment to D79631: #pragma float_control should be permitted at namespace scope.

No this patch isn't ready yet. i see an assertion if try to instantiate a template function when the template has enabled floating point settings

May 8 2020, 11:48 AM · Restricted Project
mibintc created D79631: #pragma float_control should be permitted at namespace scope.
May 8 2020, 8:32 AM · Restricted Project
mibintc added a comment to D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.

I got a report that this patch was causing a problem with Windows <numeric> header because #pragma float_control should be supported in namespace context. I've posted a patch for review here https://reviews.llvm.org/D79631

May 8 2020, 8:32 AM · Restricted Project, Restricted Project

May 6 2020

mibintc committed rGe5578013b199: When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures Bug… (authored by mibintc).
When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures Bug…
May 6 2020, 1:36 PM
mibintc closed D79510: [PATCH] When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures.
May 6 2020, 1:36 PM · Restricted Project
mibintc added a comment to D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations.

The ISO C proposal is here http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2407.pdf but the details are in the IEEE standards documents.

May 6 2020, 1:35 PM · Restricted Project
mibintc added a comment to D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations.

BTW there is a proposal http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2421.pdf at the ISO C meeting to support some new floating point pragmas including
#pragma STDC FENV_ALLOW_ASSOCIATIVE_LAW on-off-switch
The committee wants to see an implementation(s) to ensure that it's viable.

May 6 2020, 12:26 PM · Restricted Project
mibintc added a comment to D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.

I posted a patch to fix the bug reported by @uabelho here https://reviews.llvm.org/D79510

May 6 2020, 12:25 PM · Restricted Project, Restricted Project
mibintc added inline comments to D79510: [PATCH] When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures.
May 6 2020, 12:25 PM · Restricted Project
mibintc created D79510: [PATCH] When pragma FENV_ACCESS is ignored do not modify Sema.CurFPFeatures.
May 6 2020, 11:54 AM · Restricted Project
mibintc committed rGc355bec749e9: Add support for #pragma clang fp reassociate(on|off) (authored by mibintc).
Add support for #pragma clang fp reassociate(on|off)
May 6 2020, 8:36 AM
mibintc closed D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations.
May 6 2020, 8:35 AM · Restricted Project
mibintc added a comment to D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.

It seems to be this change in SemaStmt.cpp that makes the FENV-pragma have some effect regardless of the warning saying that the pragma doesn't have any effect:

index aa0d89ac09c3..f76994a6dab3 100644
@@ -394,6 +394,11 @@ StmtResult Sema::ActOnCompoundStmt(SourceLocation L, SourceLocation R,
                                    ArrayRef<Stmt *> Elts, bool isStmtExpr) {
   const unsigned NumElts = Elts.size();
 
+  // Mark the current function as usng floating point constrained intrinsics
+  if (getCurFPFeatures().isFPConstrained())
+    if (FunctionDecl *F = dyn_cast<FunctionDecl>(CurContext))
+      F->setUsesFPIntrin(true);
+
May 6 2020, 6:57 AM · Restricted Project, Restricted Project

May 5 2020

mibintc updated the diff for D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations.

Here it is again with the on/off spelling

May 5 2020, 2:03 PM · Restricted Project
mibintc added a comment to D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations.

I checked with FPGA folks and confirm what @scanon says is correct, the reassoc fast math flag enables reassociation across multiple statements, so i changed the syntax to use 'fast' and 'off', and changed the documentation

May 5 2020, 8:03 AM · Restricted Project
mibintc updated the diff for D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations.
May 5 2020, 8:03 AM · Restricted Project

May 4 2020

mibintc updated the diff for D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations.

I fixed the issues that @rjmccall mentioned. I don't yet have an answer for @scanon, need to get back to you about that.

May 4 2020, 2:00 PM · Restricted Project
mibintc added a comment to D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations.

A reply to @scanon

May 4 2020, 12:21 PM · Restricted Project
mibintc added inline comments to D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations.
May 4 2020, 11:15 AM · Restricted Project
mibintc updated the diff for D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations.

Responded to @rjmccall 's review.

May 4 2020, 11:15 AM · Restricted Project
mibintc committed rG7cbb495ab452: Fix LABEL match for test case for D72841 #pragma float_control (authored by mibintc).
Fix LABEL match for test case for D72841 #pragma float_control
May 4 2020, 7:28 AM
mibintc committed rGf5360d4bb337: Reapply "Add support for #pragma float_control" with buildbot fixes Add support… (authored by mibintc).
Reapply "Add support for #pragma float_control" with buildbot fixes Add support…
May 4 2020, 6:22 AM
mibintc added a reverting change for rGfce82c0ed310: Revert "Reapply "Add support for #pragma float_control" with improvements to": rGf5360d4bb337: Reapply "Add support for #pragma float_control" with buildbot fixes Add support….
May 4 2020, 6:22 AM

May 1 2020

mibintc committed rGfce82c0ed310: Revert "Reapply "Add support for #pragma float_control" with improvements to" (authored by mibintc).
Revert "Reapply "Add support for #pragma float_control" with improvements to"
May 1 2020, 5:24 PM
mibintc added a reverting change for rG69aacaf69992: Reapply "Add support for #pragma float_control" with improvements to test cases…: rGfce82c0ed310: Revert "Reapply "Add support for #pragma float_control" with improvements to".
May 1 2020, 5:24 PM
mibintc committed rG69aacaf69992: Reapply "Add support for #pragma float_control" with improvements to test cases… (authored by mibintc).
Reapply "Add support for #pragma float_control" with improvements to test cases…
May 1 2020, 5:22 PM
mibintc added a reverting change for rG85dc033cacca: Revert "Add support for #pragma float_control": rG69aacaf69992: Reapply "Add support for #pragma float_control" with improvements to test cases….
May 1 2020, 5:22 PM
mibintc committed rG4f1e9a17e9d2: Add support for #pragma float_control (authored by mibintc).
Add support for #pragma float_control
May 1 2020, 8:16 AM
mibintc closed D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.
May 1 2020, 8:15 AM · Restricted Project, Restricted Project
mibintc committed rG85dc033cacca: Revert "Add support for #pragma float_control" (authored by mibintc).
Revert "Add support for #pragma float_control"
May 1 2020, 8:13 AM

Apr 30 2020

mibintc added inline comments to D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.
Apr 30 2020, 7:56 AM · Restricted Project, Restricted Project
mibintc updated the diff for D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.

I changed a comment to add a period, rebased, and used clang-format

Apr 30 2020, 7:56 AM · Restricted Project, Restricted Project

Apr 29 2020

mibintc updated the summary of D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations.
Apr 29 2020, 2:33 PM · Restricted Project
mibintc retitled D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations from Add support for #pragma clang fp allow_reassociation(on|off) -- floating point control of associative math transformations to Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations.
Apr 29 2020, 2:33 PM · Restricted Project
mibintc updated the diff for D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations.

Thanks for your review @sepavloff and @erichkeane, I have responded to your feedback and reverted the name back to reassoc which is what Serge prefers

Apr 29 2020, 2:33 PM · Restricted Project
mibintc updated the diff for D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.

I dropped FPOptions from CallExpr -- if it's needed I will add it using TrailingStorage in a separate patch; I responded to @erichkeane 's code review

Apr 29 2020, 11:16 AM · Restricted Project, Restricted Project
mibintc added inline comments to D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.
Apr 29 2020, 11:16 AM · Restricted Project, Restricted Project

Apr 27 2020

mibintc added a comment to D72841: Add support for pragma float_control, to control precision and exception behavior at the source level.

A couple replies to @erichkeane

Apr 27 2020, 12:55 PM · Restricted Project, Restricted Project