Page MenuHomePhabricator
People bolshakov-a

bolshakov-a (Andrey Ali Khan Bolshakov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 4 2023, 1:02 AM (10 w, 5 d)

Recent Activity
View All

Yesterday

bolshakov-a updated the diff for D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Finalize renaming one more time.

Sun, Mar 19, 2:25 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a updated the diff for D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Finalize renaming.

Sun, Mar 19, 2:21 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a updated the diff for D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Add USR generation and a couple of minor fixes.

Sun, Mar 19, 2:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a updated the diff for D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Rename UncommonValue to StructuralValue and add "TODO" about it.

Sun, Mar 19, 2:12 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a added inline comments to D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..
Sun, Mar 19, 2:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a updated the diff for D146386: [MS ABI] Fix mangling references to declarations..

Rebased.

Sun, Mar 19, 11:50 AM · Restricted Project, Restricted Project
bolshakov-a requested review of D146386: [MS ABI] Fix mangling references to declarations..
Sun, Mar 19, 11:03 AM · Restricted Project, Restricted Project

Mon, Mar 13

bolshakov-a added inline comments to D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..
Mon, Mar 13, 3:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a added inline comments to D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..
Mon, Mar 13, 2:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a added a comment to D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

It works, thanks!

Mon, Mar 13, 8:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a updated the diff for D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Update patch with more context.

Mon, Mar 13, 8:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a added a comment to D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Sorry! It's my first time using Phabricator. Maybe, the problem occurs because I've solved the issue with Arcanist just by means of copy-pasting patches into "Update Diff" Web GUI form. Maybe, I should reopen the PR?

Mon, Mar 13, 8:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sat, Mar 11

bolshakov-a updated the diff for D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Fix formatting.

Sat, Mar 11, 10:44 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a updated the diff for D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Rebase and replace "Clang 16" with "Clang 17" in cxx_status.html (Clang 16 RC has already been branched off, AFAIK).

Sat, Mar 11, 9:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, Mar 10

bolshakov-a abandoned D145814: Release notes and C++ status.
Fri, Mar 10, 1:35 PM · Restricted Project, Restricted Project
bolshakov-a added a comment to D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

@royjacobson, I've added some test cases for using the new NTTP arguments in clang modules. It uses serialization, in principle. Or more specialized tests are still needed?

Fri, Mar 10, 12:18 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a updated the diff for D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Add relnote and update C++ status.

Fri, Mar 10, 12:16 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a updated the diff for D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Fix constness issue in TemplateArgument for ASTContext.

Fri, Mar 10, 12:15 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a updated the diff for D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Add some testcases.

Fri, Mar 10, 12:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a updated the diff for D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Add ODRHash calculation for UncommonValue (and test it).

Fri, Mar 10, 12:12 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a updated the diff for D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Add ODRHash calculation for UncommonValue (and test it).

Fri, Mar 10, 12:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a updated the diff for D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Refactor TemplateArgument constructors.

Fri, Mar 10, 12:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a updated the diff for D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Fix after rebase.

Fri, Mar 10, 12:08 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a updated the diff for D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Fix after rebase.

Fri, Mar 10, 12:06 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a updated the diff for D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Rebased.

Fri, Mar 10, 12:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a added a comment to D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

I have some problems with Arcanist... It tries to open a new PR instead of updating this one. Probably because I've re-cloned my local repository.

Fri, Mar 10, 10:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a added a comment to D145814: Release notes and C++ status.

Occasional PR, sorry. I'm still learning Arcanist...

Fri, Mar 10, 10:40 AM · Restricted Project, Restricted Project
bolshakov-a added inline comments to D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..
Fri, Mar 10, 10:38 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bolshakov-a requested review of D145814: Release notes and C++ status.
Fri, Mar 10, 10:37 AM · Restricted Project, Restricted Project

Wed, Mar 8

bolshakov-a added inline comments to D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument.
Wed, Mar 8, 1:14 AM · Restricted Project, Restricted Project

Sat, Feb 25

bolshakov-a added inline comments to D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..
Sat, Feb 25, 7:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, Feb 24

bolshakov-a updated subscribers of D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

Thanks for the review! I definitely can try to answer questions and fix issues, but I just want to note that I'm not the original author, and these changes already were upstream. (Maybe, @rsmith will find some time for taking a look at this, after all?)

Fri, Feb 24, 9:09 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 13 2023

bolshakov-a added a comment to D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..

@aaron.ballman, @rsmith, @mizvekov, @shafik, has the mankind any chance to get this reviewed and merged?

Feb 13 2023, 11:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 4 2023

bolshakov-a requested review of D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..
Jan 4 2023, 8:33 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project