Page MenuHomePhabricator

chandlerc (Chandler Carruth)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 7 2012, 2:54 PM (345 w, 3 d)
Roles
Administrator

Recent Activity

Today

chandlerc added inline comments to D58250: [AIX][CMake] Changes for building on AIX with XL and GCC.
Wed, Feb 20, 2:18 AM · Restricted Project

Yesterday

chandlerc accepted D58424: [NewPM] Add other sanitizers at O0.

LGTM

Tue, Feb 19, 7:04 PM · Restricted Project, Restricted Project
chandlerc accepted D58399: [Inliner] Don't initialize ComputeFullInlineCost to be always true because of ORE.

LGTM (with a minor cleanup, but feel free to just submit w/ that if we're all agreeing about this direction).

Tue, Feb 19, 6:44 PM · Restricted Project
chandlerc accepted D58412: [X86] Remove FeatureSlowIncDec from Sandy Bridge and later Intel Core CPUs.

I think we can consider tweaking the generic ones separately.

Tue, Feb 19, 6:13 PM · Restricted Project
chandlerc added a comment to D58375: [Clang][NewPM] Disable tests that are broken under new PM.

I can understand why tests that use -O1 or -O2 would produce different results with the new pass manager, but it looks like not all the tests are like that. Do you know why those tests are failing?

For the tests that do use -O, instead of marking them unsupported, could you use -fno-experimental-new-pass-manager or something like that?

Tue, Feb 19, 5:47 PM · Restricted Project
chandlerc requested changes to D58375: [Clang][NewPM] Disable tests that are broken under new PM.

Based on the -dev discussion, update once the target machine differences are addressed by mimicing the way the legacy PM works, which will hopefully restrict this similarly to what Eli is suggesting as well...

Tue, Feb 19, 5:46 PM · Restricted Project
chandlerc added a comment to D57793: [NewPM][MSan] Add sanitizer at O0.

Will need to be rebased after rC353985. Should this also include tsan, unless this is just for msan specifically?

Tue, Feb 19, 5:45 PM · Restricted Project
chandlerc added inline comments to D58399: [Inliner] Don't initialize ComputeFullInlineCost to be always true because of ORE.
Tue, Feb 19, 4:34 PM · Restricted Project
chandlerc added inline comments to D58399: [Inliner] Don't initialize ComputeFullInlineCost to be always true because of ORE.
Tue, Feb 19, 3:31 PM · Restricted Project
chandlerc added inline comments to D58399: [Inliner] Don't initialize ComputeFullInlineCost to be always true because of ORE.
Tue, Feb 19, 12:14 PM · Restricted Project

Mon, Feb 18

chandlerc requested changes to D58260: [INLINER] allow inlining of address taken blocks.
Mon, Feb 18, 9:40 PM · Restricted Project
chandlerc added a comment to D57400: Add a .gitignore file to the root that ignores any files outside of the project directories..

What about using /*/ at the ignore pattern? This allows top-level files, and makes only new top-level *directories* require an ignore update. To my mind, that seems a bit more narrowly scoped and might be a bit less surprising. Thoughts?

Mon, Feb 18, 9:17 PM

Tue, Feb 12

chandlerc accepted D57097: Make llvm::Optional<T> trivially copyable when T is trivially copyable.

Thanks for seeing through this .... very non-trivial effort! =D Also, as I'm sure you know by now, will need to watch the bots carefully. Sadly, some may fall over.

Tue, Feb 12, 11:57 PM · Restricted Project

Mon, Feb 11

chandlerc committed rG9beadff6a57b: Move CFLGraph and the AA summary code over to the new `CallBase` instruction… (authored by chandlerc).
Move CFLGraph and the AA summary code over to the new `CallBase` instruction…
Mon, Feb 11, 1:26 AM
chandlerc committed rL353676: Move CFLGraph and the AA summary code over to the new `CallBase`.
Move CFLGraph and the AA summary code over to the new `CallBase`
Mon, Feb 11, 1:26 AM
chandlerc committed rG2d2a4359a22e: Remove `CallSite` from the CodeMetrics analysis, moving it to the new… (authored by chandlerc).
Remove `CallSite` from the CodeMetrics analysis, moving it to the new…
Mon, Feb 11, 1:04 AM
chandlerc committed rG73634358a19d: Remove a declaration that is dead, and not even implemented any longer. (authored by chandlerc).
Remove a declaration that is dead, and not even implemented any longer.
Mon, Feb 11, 1:03 AM
chandlerc committed rL353673: Remove `CallSite` from the CodeMetrics analysis, moving it to the new.
Remove `CallSite` from the CodeMetrics analysis, moving it to the new
Mon, Feb 11, 1:03 AM
chandlerc committed rL353672: Remove a declaration that is dead, and not even implemented any longer..
Remove a declaration that is dead, and not even implemented any longer.
Mon, Feb 11, 1:03 AM
chandlerc committed rCXX353669: The new file header didn't get carried over when these files were.
The new file header didn't get carried over when these files were
Mon, Feb 11, 12:40 AM
chandlerc committed rCXX353668: Update some newly added files that mistakenly used the old file header.
Update some newly added files that mistakenly used the old file header
Mon, Feb 11, 12:40 AM
chandlerc committed rG9d610c5a539e: The new file header didn't get carried over when these files were "moved"… (authored by chandlerc).
The new file header didn't get carried over when these files were "moved"…
Mon, Feb 11, 12:40 AM
chandlerc committed rGa20f61106b8a: Update some newly added files that mistakenly used the old file header to the… (authored by chandlerc).
Update some newly added files that mistakenly used the old file header to the…
Mon, Feb 11, 12:39 AM
chandlerc committed rL353669: The new file header didn't get carried over when these files were.
The new file header didn't get carried over when these files were
Mon, Feb 11, 12:39 AM
chandlerc committed rL353668: Update some newly added files that mistakenly used the old file header.
Update some newly added files that mistakenly used the old file header
Mon, Feb 11, 12:39 AM
chandlerc added a comment to D28248: Work around GCC PR37804.

Hey Marshall and Michael,

Mon, Feb 11, 12:36 AM
chandlerc committed rG1f5550326f12: Update more files added with the old header to the new one. (authored by chandlerc).
Update more files added with the old header to the new one.
Mon, Feb 11, 12:27 AM
chandlerc committed rG127252b7d95f: Update new files added to llvm-objcopy to use the new file header. (authored by chandlerc).
Update new files added to llvm-objcopy to use the new file header.
Mon, Feb 11, 12:27 AM
chandlerc committed rL353667: Update more files added with the old header to the new one..
Update more files added with the old header to the new one.
Mon, Feb 11, 12:27 AM
chandlerc committed rL353666: Update new files added to llvm-objcopy to use the new file header..
Update new files added to llvm-objcopy to use the new file header.
Mon, Feb 11, 12:27 AM
chandlerc committed rGb53f0e1145e3: Update files that were mistakenly added with the old file header to the new one. (authored by chandlerc).
Update files that were mistakenly added with the old file header to the new one.
Mon, Feb 11, 12:09 AM
chandlerc committed rG3b387a7e3cbe: Update files that were mistakenly added with the old file header. (authored by chandlerc).
Update files that were mistakenly added with the old file header.
Mon, Feb 11, 12:09 AM
chandlerc committed rL353665: Update files that were mistakenly added with the old file header to the.
Update files that were mistakenly added with the old file header to the
Mon, Feb 11, 12:09 AM
chandlerc committed rL353664: Update files that were mistakenly added with the old file header..
Update files that were mistakenly added with the old file header.
Mon, Feb 11, 12:09 AM
chandlerc committed rLLDB353663: Update files to the new header that were incorrectly landed with the old.
Update files to the new header that were incorrectly landed with the old
Mon, Feb 11, 12:04 AM
chandlerc committed rG023f999822b7: Update files to the new header that were incorrectly landed with the old one. (authored by chandlerc).
Update files to the new header that were incorrectly landed with the old one.
Mon, Feb 11, 12:04 AM
chandlerc committed rL353663: Update files to the new header that were incorrectly landed with the old.
Update files to the new header that were incorrectly landed with the old
Mon, Feb 11, 12:03 AM

Sun, Feb 10

chandlerc committed rGdac20a82540d: [CallSite removal] Port InstSimplify over to use `CallBase` both in its… (authored by chandlerc).
[CallSite removal] Port InstSimplify over to use `CallBase` both in its…
Sun, Feb 10, 11:54 PM
chandlerc committed rL353662: [CallSite removal] Port InstSimplify over to use `CallBase` both in its.
[CallSite removal] Port InstSimplify over to use `CallBase` both in its
Sun, Feb 10, 11:54 PM
chandlerc committed rG751d95fb9b3d: [CallSite removal] Migrate ConstantFolding APIs and implementation to… (authored by chandlerc).
[CallSite removal] Migrate ConstantFolding APIs and implementation to…
Sun, Feb 10, 11:52 PM
chandlerc committed rL353661: [CallSite removal] Migrate ConstantFolding APIs and implementation to.
[CallSite removal] Migrate ConstantFolding APIs and implementation to
Sun, Feb 10, 11:51 PM
chandlerc committed rG3160734af13b: [CallSite removal] Migrate the statepoint GC infrastructure to use the… (authored by chandlerc).
[CallSite removal] Migrate the statepoint GC infrastructure to use the…
Sun, Feb 10, 11:43 PM
chandlerc committed rL353660: [CallSite removal] Migrate the statepoint GC infrastructure to use the.
[CallSite removal] Migrate the statepoint GC infrastructure to use the
Sun, Feb 10, 11:43 PM
chandlerc closed D56122: [CallSite removal] Migrate the statepoint GC infrastructure to use the `CallBase` class rather than `CallSite` wrappers..
Sun, Feb 10, 11:43 PM · Restricted Project
Herald added a project to D56122: [CallSite removal] Migrate the statepoint GC infrastructure to use the `CallBase` class rather than `CallSite` wrappers.: Restricted Project.

LGTM w/one requested change before submit. If you strongly disagree, feel free to land and discuss afterwards. I don't want this blocked on me finding time to re-review.

Sun, Feb 10, 11:41 PM · Restricted Project

Fri, Feb 8

chandlerc accepted D57968: [LICM] Cap the clobbering calls in LICM..

LGTM

Fri, Feb 8, 12:51 PM · Restricted Project

Thu, Feb 7

chandlerc added a comment to D39111: Extensible LLVM RTTI.

Sorry this completely fell off my radar. It is back on my radar, and I'll try to get to it in the next day or two.

Thu, Feb 7, 12:02 AM · Restricted Project

Wed, Feb 6

chandlerc accepted D53765: [RFC prototype] Implementation of asm-goto support in LLVM.

This is looking really close. I think we should get some basic sanity checks w/ the kernel, and even if there is an obscure bug or two, land this and move to follow-up patches.

Wed, Feb 6, 11:26 PM · Restricted Project
chandlerc added a comment to D57097: Make llvm::Optional<T> trivially copyable when T is trivially copyable.

I think you may be able to do this in a slightly nicer way.

Wed, Feb 6, 11:15 PM · Restricted Project

Tue, Feb 5

chandlerc accepted D57627: [BasicAA] Cache nonEscapingLocalObjects for alias() calls..

LGTM!

Tue, Feb 5, 3:21 PM · Restricted Project

Mon, Feb 4

chandlerc added inline comments to D53765: [RFC prototype] Implementation of asm-goto support in LLVM.
Mon, Feb 4, 7:59 PM · Restricted Project
chandlerc added a comment to D57627: [BasicAA] Cache nonEscapingLocalObjects for alias() calls..

Just think we can poke the map a bit better here.

Mon, Feb 4, 7:17 PM · Restricted Project
chandlerc added a comment to D53765: [RFC prototype] Implementation of asm-goto support in LLVM.

A few minor comments.

Mon, Feb 4, 7:07 PM · Restricted Project
chandlerc added a comment to D57640: [NewPM][MSan] Add Options Handling.

Minor past-commit nit.

Mon, Feb 4, 6:53 PM · Restricted Project, Restricted Project
chandlerc committed rL353133: Add another company..
Add another company.
Mon, Feb 4, 6:09 PM
chandlerc created D57723: WIP change to address phase ordering issues between loop optimizations, jump threading, and GVN..
Mon, Feb 4, 4:18 PM · Restricted Project

Fri, Feb 1

chandlerc added inline comments to D57627: [BasicAA] Cache nonEscapingLocalObjects for alias() calls..
Fri, Feb 1, 5:20 PM · Restricted Project

Wed, Jan 30

chandlerc accepted D57494: [CallSite removal] Remove CallSite uses from InstCombine..

(also LGTM with the updates above and any renaming you want to do)

Wed, Jan 30, 8:00 PM
chandlerc added a comment to D57494: [CallSite removal] Remove CallSite uses from InstCombine..

Minor nits. I've been using Call instead of CB because when there is a nice word instead of initialism, I prefer it for readability. But that's up to you really.

Wed, Jan 30, 8:00 PM
chandlerc added a comment to D56932: [Driver] [NetBSD] Pass default library search paths to linker.

There was a long discussion between two NetBSD maintainers about this (both already in the reviewers list of this patch). I'm not sure if there is an existing thread that would be better to follow up on as opposed to starting a fresh thread.

Wed, Jan 30, 1:57 PM

Tue, Jan 29

chandlerc added inline comments to D53765: [RFC prototype] Implementation of asm-goto support in LLVM.
Tue, Jan 29, 8:11 PM · Restricted Project
chandlerc added a comment to D53765: [RFC prototype] Implementation of asm-goto support in LLVM.

Made it through the optimizer code. Really minor changes here, I think this is looking good. Probable the biggest question marks are in the MI representation.

Tue, Jan 29, 6:35 PM · Restricted Project
chandlerc added a comment to D53765: [RFC prototype] Implementation of asm-goto support in LLVM.

Looking at updated patch and some of the optimizer bits, but some inline responses to discussion points below:

Tue, Jan 29, 6:25 PM · Restricted Project
chandlerc accepted D57415: [IR] Use CallBase to simplify some code.

LGTM

Tue, Jan 29, 6:12 PM
chandlerc accepted D57295: [IR] Use CallBase to reduce code duplication. NFC.

LGTM

Tue, Jan 29, 2:31 PM
chandlerc added a comment to D53765: [RFC prototype] Implementation of asm-goto support in LLVM.

Sorry it took so long, but made a full pass through this. Just want to point out that this patch is already in really great shape due to the huge amount of work from the original author, Craig taking it over, and the multiple rounds of review from Bill and Nick among others.

Tue, Jan 29, 1:51 AM · Restricted Project

Mon, Jan 28

chandlerc committed rL352448: Add a couple more labs that have agreed..
Add a couple more labs that have agreed.
Mon, Jan 28, 7:31 PM

Fri, Jan 25

chandlerc accepted D57200: [EarlyCSE & MSSA] Cleanup special handling for removing MemoryAccesses..

FWIW, I think this patch is trivially good when D57199 lands. I might suggest just merge this into that patch, but if you want to keep them separate, LGTM.

Fri, Jan 25, 7:55 PM
chandlerc added a comment to D53786: [AliasSetTracker] Actually delete instructions from the AliasSetTracker..

Let me re-purpose this patch:
Is there a point to having deleteValue()?
Is there a point to having the ref count (addRef, dropRef) for alias sets?

AFAICT these are incomplete and not used.

Fri, Jan 25, 7:54 PM
chandlerc added a comment to D56568: [AliasSetTracker] Store AliasResult and pass it on mergeSetIn..

(peanut gallery comments)

Fri, Jan 25, 7:50 PM · Restricted Project
chandlerc accepted D56625: [LICM/MSSA] Add promotion to scalars by building an AliasSetTracker with MemorySSA..

Overall, really nice patch. A bunch of super nit-picky comments below, not much more to add beyond Sanjoy's review honestly. =D With these comments addressed, LGTM, but maybe double check if Sanjoy is happy w/ the update before submitting.

Fri, Jan 25, 7:49 PM · Restricted Project
chandlerc accepted D57129: [SimpleLoopUnswitch] Early check exit for trivial unswitch with MemorySSA..

LGTM (provided I've not missed anything below w.r.t. atomics).

Fri, Jan 25, 7:44 PM
chandlerc committed rL352269: Update the release site text to reflect that LLVM 8 will be the last release.
Update the release site text to reflect that LLVM 8 will be the last release
Fri, Jan 25, 7:41 PM

Wed, Jan 23

chandlerc committed rL352015: Update signed list with new companies, and remove a university that we are no….
Update signed list with new companies, and remove a university that we are no…
Wed, Jan 23, 7:04 PM
chandlerc accepted D57120: [ADT] Notify ilist traits about in-list transfers.

I live in fear of the use cases we haven't yet thought of for this that we will discover in the future. ;] But proceed, LGTM!

Wed, Jan 23, 2:40 PM

Tue, Jan 22

chandlerc committed rL351802: Add another company that signed (and sort the list again)..
Add another company that signed (and sort the list again).
Tue, Jan 22, 3:05 AM
chandlerc committed rL351796: Revert r351778: IR: Add fp operations to atomicrmw.
Revert r351778: IR: Add fp operations to atomicrmw
Tue, Jan 22, 2:30 AM

Mon, Jan 21

chandlerc committed rL351775: Add another company that signed..
Add another company that signed.
Mon, Jan 21, 5:47 PM

Jan 21 2019

chandlerc committed rL351736: Add another company that has signed..
Add another company that has signed.
Jan 21 2019, 2:03 AM
chandlerc committed rL351734: Move NetBSD to the signed list. I still need to do a major update here to.
Move NetBSD to the signed list. I still need to do a major update here to
Jan 21 2019, 1:56 AM
chandlerc committed rCXX351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Jan 21 2019, 1:55 AM
chandlerc committed rPSTL351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Jan 21 2019, 1:54 AM
chandlerc committed rCXXA351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Jan 21 2019, 1:54 AM
chandlerc committed rCTE351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Jan 21 2019, 1:54 AM
chandlerc committed rC351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Jan 21 2019, 1:54 AM
chandlerc committed rL351732: Put the new license into place at the top of the website. We now have many.
Put the new license into place at the top of the website. We now have many
Jan 21 2019, 1:54 AM
chandlerc committed rLLDB351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Jan 21 2019, 1:53 AM
chandlerc committed rUNW351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Jan 21 2019, 1:53 AM
chandlerc committed rLLD351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Jan 21 2019, 1:53 AM
chandlerc committed rL351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Jan 21 2019, 1:53 AM
chandlerc committed rCRT351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Jan 21 2019, 1:53 AM
chandlerc committed rOMP351731: Fix typos throughout the license files that somehow I and my reviewers.
Fix typos throughout the license files that somehow I and my reviewers
Jan 21 2019, 1:52 AM

Jan 19 2019

chandlerc committed rL351677: Update remaining file headers of LLVM-project code to the new license..
Update remaining file headers of LLVM-project code to the new license.
Jan 19 2019, 11:17 PM
chandlerc committed rT351677: Update remaining file headers of LLVM-project code to the new license..
Update remaining file headers of LLVM-project code to the new license.
Jan 19 2019, 11:16 PM
chandlerc committed rL351676: Update the file headers used throughout the ABI testsuite to reflect the.
Update the file headers used throughout the ABI testsuite to reflect the
Jan 19 2019, 8:55 PM
chandlerc committed rT351676: Update the file headers used throughout the ABI testsuite to reflect the.
Update the file headers used throughout the ABI testsuite to reflect the
Jan 19 2019, 8:54 PM
chandlerc committed rT351675: Update LICENSE file for the test-suite to the new license..
Update LICENSE file for the test-suite to the new license.
Jan 19 2019, 8:45 PM
chandlerc committed rL351675: Update LICENSE file for the test-suite to the new license..
Update LICENSE file for the test-suite to the new license.
Jan 19 2019, 8:45 PM
chandlerc committed rT351656: Consistently use unix line endings on all the source code in the test.
Consistently use unix line endings on all the source code in the test
Jan 19 2019, 5:31 AM
chandlerc committed rL351656: Consistently use unix line endings on all the source code in the test.
Consistently use unix line endings on all the source code in the test
Jan 19 2019, 5:12 AM