- User Since
- Jul 7 2012, 2:54 PM (327 w, 5 d)
Fix one more place.
Update based on Jame's suggestion.
Ping, rebase, and update to remove all but the type system bits to match the
progress outside of the C API.
Wed, Oct 17
Ping again! Also rebase...
Tue, Oct 16
Mon, Oct 15
LGTM, this is a great improvement IMO!
Ping? Would be really nice to get a review here.
Thu, Oct 11
Wed, Oct 10
Ok, also had some time to really think about the core problem and approach. Write-up below.
Basic suggestions on test case...
Minor implementation improvement suggestion...
Mon, Oct 8
Sun, Oct 7
Sending this for pre-commit review as I want to be sure I'm doing the right thing w/ the C-API here.
Fri, Oct 5
Somewhat minor code simplification below. If it makes sense, feel free to land. If it doesn't honestly, feel free to explain why not and land. Even if I convince you, it's super simple to land as a follow-up. =]
Just wanted to send a quick note that I saw this and am thinking about the approach and the problem. Thanks for looking at this (really tricky) problem!
Thu, Oct 4
Some more minor code comments inline...
Wed, Sep 19
Sep 18 2018
LGTM (provided Philip is still happy here, I know I asked to remove his plugin hooks).
Sep 15 2018
It gets better and better. Another round of comments.
Sep 13 2018
Before we add yet another experimental backend, I think it is somewhat important to know what the long-term user story is and the long-term maintenance story.
This is looking really, really good. Some comments below.
Sep 7 2018
Sep 4 2018
All outstanding comments addressed, and landing this. Thanks all for the reviews and let me know if I missed anything.
Reverted temporarily in r341360 to unbreak my build and the aarch64 build bot. Let me know if I can help with the investigation in any way.
There are bots obviously still failing so I'm going to revert....
Thanks for the review, landing.
FWIW, thanks for the fantastic explanation Zach.
FWIW, just because a lot of code hits the assert for non-zero size does not (to me) mean that isn't the correct approach.
Aug 28 2018
Update addressing review feedback.
Aug 27 2018
Rebase and ping.
Very high level comments here...
Aug 26 2018
Aug 23 2018
Move to a more conservative model suggested by Kristof.