Page MenuHomePhabricator

michele.scandale (Michele Scandale)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 27 2013, 3:26 AM (348 w, 20 h)

Recent Activity

Sun, Feb 23

michele.scandale updated the summary of D74643: [Parse] Fix `TryParsePtrOperatorSeq`..
Sun, Feb 23, 11:30 PM · Restricted Project
michele.scandale retitled D74643: [Parse] Fix `TryParsePtrOperatorSeq`. from [Parse] Consider attributes in `TryParsePtrOperatorSeq`. to [Parse] Fix `TryParsePtrOperatorSeq`..
Sun, Feb 23, 11:30 PM · Restricted Project
michele.scandale updated the diff for D74643: [Parse] Fix `TryParsePtrOperatorSeq`..

Tests for __attribute__(()) syntax + attribute arguments + fix for _Atomic qualifier.

Sun, Feb 23, 10:14 PM · Restricted Project

Sat, Feb 22

michele.scandale updated the diff for D74643: [Parse] Fix `TryParsePtrOperatorSeq`..

Fixed comment wording + rebase.

Sat, Feb 22, 7:11 PM · Restricted Project

Fri, Feb 21

michele.scandale added a comment to D74643: [Parse] Fix `TryParsePtrOperatorSeq`..

@rsmith: is this fine for you as well?

Fri, Feb 21, 7:29 PM · Restricted Project

Mon, Feb 17

michele.scandale added a comment to D74643: [Parse] Fix `TryParsePtrOperatorSeq`..

Assuming this is fine, I would need someone landing this change on my behalf since I do not have commit rights. Thanks!

Mon, Feb 17, 7:26 PM · Restricted Project
michele.scandale updated the diff for D74643: [Parse] Fix `TryParsePtrOperatorSeq`..

Add comment about ObjC message send being rejected + rebase

Mon, Feb 17, 7:24 PM · Restricted Project
michele.scandale added inline comments to D74643: [Parse] Fix `TryParsePtrOperatorSeq`..
Mon, Feb 17, 6:57 PM · Restricted Project
michele.scandale updated the diff for D74643: [Parse] Fix `TryParsePtrOperatorSeq`..

Check for double brackets for C++11 style attributes, and outline the loop to skip attributes in TrySkipAttributes to fix also the other use in TryConsumeDeclarationSpecifier

Mon, Feb 17, 6:51 PM · Restricted Project

Fri, Feb 14

michele.scandale updated the diff for D74643: [Parse] Fix `TryParsePtrOperatorSeq`..

Missed GNU style attributes

Fri, Feb 14, 1:34 PM · Restricted Project
michele.scandale created D74643: [Parse] Fix `TryParsePtrOperatorSeq`..
Fri, Feb 14, 1:34 PM · Restricted Project

Dec 10 2019

michele.scandale added a comment to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.

I've noticed you removed the change for CompilerInvocation.cpp about the initialization of the codegen option NoTrappingMath. Was that an accident?

I checked the old and new version of the patch and it seems like initialization of NoTrappingMath is unchanged, the definition of the option has it default to 0, and CompilerInvocation.cpp sets it like this in ParseLangArgs, was it something else you were looking at?

Opts.NoTrappingMath = Args.hasArg(OPT_fno_trapping_math);
Dec 10 2019, 4:36 PM · Restricted Project, Restricted Project

Dec 6 2019

michele.scandale added a comment to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.

I've noticed you removed the change for CompilerInvocation.cpp about the initialization of the codegen option NoTrappingMath. Was that an accident?

Dec 6 2019, 7:47 PM · Restricted Project, Restricted Project

Dec 2 2019

michele.scandale added inline comments to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.
Dec 2 2019, 7:18 PM · Restricted Project, Restricted Project

Nov 19 2019

michele.scandale added inline comments to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.
Nov 19 2019, 11:58 PM · Restricted Project, Restricted Project
michele.scandale added inline comments to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.
Nov 19 2019, 11:35 PM · Restricted Project, Restricted Project

Nov 18 2019

michele.scandale added inline comments to D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior.
Nov 18 2019, 9:40 PM · Restricted Project, Restricted Project

Mar 22 2017

michele.scandale abandoned D3002: SROA fix to avoid invalid bitcast generation when converting a load from a double pointer bitcasted with an address space change of the pointee pointee.
Mar 22 2017, 1:11 PM
michele.scandale abandoned D2462: Fix for CUDA codegen due to missing generation of implicit address space conversions.
Mar 22 2017, 1:11 PM

Apr 10 2015

michele.scandale added a comment to D7622: CodeGenPrepare: Avoid and/or i1 in select conditions..

I would be fine with either skipping the transformation if the types don't match up or extending the types. I personally would lean towards skipping the transformation as the extension is an extra instruction which makes the transformation less beneficial. As none of the targets I know are affected, what would the preference for your target?

  • Matthias
Apr 10 2015, 6:44 PM
michele.scandale added a comment to D7622: CodeGenPrepare: Avoid and/or i1 in select conditions..

Hi all,

Apr 10 2015, 1:40 PM